Re: [PATCH v2 07/16] drm/imx: Add i.MX8qxp Display Controller pixel engine

2024-07-29 Thread Liu Ying
On 07/28/2024, Dmitry Baryshkov wrote: > On Fri, Jul 12, 2024 at 05:32:34PM GMT, Liu Ying wrote: >> i.MX8qxp Display Controller pixel engine consists of all processing >> units that operate in the AXI bus clock domain. Add drivers for >> ConstFrame, ExtDst, FetchLayer, FetchWarp and LayerBlend uni

Re: [PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-29 Thread Maxime Ripard
On Tue, Jul 30, 2024 at 11:36:58AM GMT, Tejas Vipin wrote: > Add more functions that can benefit from being multi style and mark > older variants as deprecated to eventually convert all mipi_dsi functions > to multi style. > > Signed-off-by: Tejas Vipin Acked-by: Maxime Ripard We should also a

Re: [PATCH 2/5] drm/ast: astdp: Test firmware status once during probing

2024-07-29 Thread Thomas Zimmermann
Am 17.07.24 um 16:24 schrieb Thomas Zimmermann: Test for running ASTDP firmware during probe. Do not bother testing this later. We cannot do much anyway if the firmware fails. Do not initialize the ASTDP conenctor if the test fails during device probing. Signed-off-by: Thomas Zimmermann Re

Re: [PATCH] drm/ast: add multiple connectors support

2024-07-29 Thread Thomas Zimmermann
Hi Am 30.07.24 um 03:25 schrieb oushixiong: Yes, I have  tested these patches, and these patches fix the problem. Thanks a lot. Patch 2 is the one that fixes the issue. I'll add your Tested-by tag to it. Best regards Thomas Best regards Shixiong 在 2024/7/29 20:34, Thomas Zimmermann 写道:

Re: [PATCH V2 07/16] drm/vc4: Get the rid of DRM_ERROR()

2024-07-29 Thread Maxime Ripard
On Sun, 28 Jul 2024 13:41:51 +0200, Stefan Wahren wrote: > DRM_ERROR() has been deprecated in favor of pr_err(). However, we > should prefer to use drm_err() whenever possible so we get device- > specific output with the error message. In error case of kcalloc, > we can simply drop DRM_ERROR(), bec

Re: [PATCH v2 06/16] drm/imx: Add i.MX8qxp Display Controller display engine

2024-07-29 Thread Liu Ying
On 07/28/2024, Dmitry Baryshkov wrote: > On Fri, Jul 12, 2024 at 05:32:33PM GMT, Liu Ying wrote: >> i.MX8qxp Display Controller display engine consists of all processing >> units that operate in a display clock domain. Add minimal feature >> support with FrameGen and TCon so that the engine can ou

Re: [PATCH 1/4] dt-bindings: display/msm/gmu: Add SDM670 compatible

2024-07-29 Thread Krzysztof Kozlowski
On 30/07/2024 03:38, Richard Acayan wrote: > The Snapdragon 670 has a GMU. Add its compatible. > > Signed-off-by: Richard Acayan Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Greg KH
On Tue, Jul 30, 2024 at 05:56:42AM +, Lin, Wayne wrote: > [Public] > > Hi, > Thanks for the report. > > Patch fa57924c76d995 ("drm/amd/display: Refactor function > dm_dp_mst_is_port_support_mode()") > is kind of correcting problems causing by commit: > 4df96ba6676034 ("drm/amd/display: Add t

[PATCH v2 2/2] drm/panel: startek-kd070fhfid015: transition to mipi_dsi wrapped functions

2024-07-29 Thread Tejas Vipin
Use multi style wrapped functions for mipi_dsi in the startek-kd070fhfid015 panel. Signed-off-by: Tejas Vipin --- .../drm/panel/panel-startek-kd070fhfid015.c | 123 ++ 1 file changed, 39 insertions(+), 84 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-startek-kd070fhfid

[PATCH v2 1/2] drm/mipi-dsi: add more multi functions for better error handling

2024-07-29 Thread Tejas Vipin
Add more functions that can benefit from being multi style and mark older variants as deprecated to eventually convert all mipi_dsi functions to multi style. Signed-off-by: Tejas Vipin --- drivers/gpu/drm/drm_mipi_dsi.c | 226 + include/drm/drm_mipi_dsi.h | 1

[PATCH v2 0/2] add more multi functions to streamline error handling

2024-07-29 Thread Tejas Vipin
This series adds more multi style functions and uses them in the startek-kd070fhfid015 panel. Additionally it marks the older functions as deprecated. --- Changes in v2: - Improved formatting - Rewrote hex as lowercase - Marked old functions as deprecated - Added more functions to

RE: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Lin, Wayne
[Public] Thanks, Kevin. The revert patch seems correct, but we plan to refactor this function as the following patch fa57924c76d995 ("drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()") I'll make time to provide one. Thanks! Regards, Wayne > -Original Message- > From

RE: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread Lin, Wayne
[Public] Hi, Thanks for the report. Patch fa57924c76d995 ("drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()") is kind of correcting problems causing by commit: 4df96ba6676034 ("drm/amd/display: Add timing pixel encoding for mst mode validation") Sorry if it misses fixes tag

[PATCH v2] drm/i915/hwmon: expose fan speed

2024-07-29 Thread Raag Jadav
Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1: N/A (max = 43.00 W) energy1: 32.02 k

RE: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability

2024-07-29 Thread Murthy, Arun R
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, July 30, 2024 4:21 AM > To: Murthy, Arun R > Cc: dri-devel@lists.freedesktop.org; intel-...@lists.freedesktop.org > Subject: Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and > interoperability > > On Mon, Jul 2

Re: [RFC PATCH] ARM: dts: imx53-qsb: Add MCIMX-LVDS1 display module support

2024-07-29 Thread Liu Ying
On 07/29/2024, Liu Ying wrote: > Hi Dmitry, > > On 07/27/2024, Dmitry Baryshkov wrote: >> On Fri, Jul 26, 2024 at 02:50:12PM GMT, Liu Ying wrote: >>> MCIMX-LVDS1[1] display module integrates a HannStar HSD100PXN1 LVDS >>> display panel and a touch IC. Add an overlay to support the LVDS >>> panel

[PATCH net-next v17 14/14] netdev: add dmabuf introspection

2024-07-29 Thread Mina Almasry
Add dmabuf information to page_pool stats: $ ./cli.py --spec ../netlink/specs/netdev.yaml --dump page-pool-get ... {'dmabuf': 10, 'id': 456, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208}, {'dmabuf': 10, 'id': 455, 'ifindex': 3, 'inflight': 1023, 'inflight-mem': 4190208

[PATCH net-next v17 12/14] net: add devmem TCP documentation

2024-07-29 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry Reviewed-by: Bagas Sanjaya Reviewed-by: Donald Hunter --- v16: - Add documentation on unbinding the NIC from dmabuf (Donald). - Add note that any dmabuf should work (Donald). v9: https://lore.kernel

[PATCH net-next v17 11/14] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-07-29 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry Reviewe

[PATCH net-next v17 13/14] selftests: add ncdevmem, netcat for devmem TCP

2024-07-29 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support, ncdevmem

[PATCH net-next v17 08/14] net: support non paged skb frags

2024-07-29 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry Reviewed-by: Eric Dumazet --- v10: - Fixed newly generated kdoc warnings found by patchwork. While we're at it, fix the Return section

[PATCH net-next v17 04/14] netdev: netdevice devmem allocator

2024-07-29 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[PATCH net-next v17 06/14] page_pool: devmem support

2024-07-29 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long pp_mag

[PATCH net-next v17 09/14] net: add support for skbs with unreadable frags

2024-07-29 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[PATCH net-next v17 10/14] tcp: RX path for devmem TCP

2024-07-29 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg

[PATCH net-next v17 07/14] memory-provider: dmabuf devmem memory provider

2024-07-29 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the netde

[PATCH net-next v17 05/14] page_pool: move dmaddr helpers to .c file

2024-07-29 Thread Mina Almasry
These helpers are used for setup and init of buffers, and their implementation need not be static inline in the header file. Moving the implementation to the .c file allows us to hide netmem implementation details in internal header files rather than the public file. Signed-off-by: Mina Almasry

[PATCH net-next v17 03/14] netdev: support binding dma-buf to netdevice

2024-07-29 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool

[PATCH net-next v17 02/14] net: netdev netlink api to bind dma-buf to a net device

2024-07-29 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry Reviewed-by: Donald Hunter Reviewed-by: Jakub Kicinski --- v16: - Use subset-of: queue queue-id instead of

[PATCH net-next v17 01/14] netdev: add netdev_rx_queue_restart()

2024-07-29 Thread Mina Almasry
Add netdev_rx_queue_restart() function to netdev_rx_queue.h Signed-off-by: David Wei Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov Reviewed-by: Jakub Kicinski --- v17: - Use ASSERT_RTNL() (Jakub). v13: - Add reviewed-by from Pavel (thanks!) - Fixed comment (Pavel) v11: - Fix not

[PATCH net-next v17 00/14] Device Memory TCP

2024-07-29 Thread Mina Almasry
v17: https://patchwork.kernel.org/project/netdevbpf/list/?series=869900&state=* v16 also got a very thorough review and some testing (thanks again!). Thes version addresses all the concerns reported on v15, in terms of feedback and issues reported. Major changes: - Use ASSERT_RTNL. - Moved a

[PATCH v9 6/6] drm/ci: rockchip: add tests for rockchip display driver

2024-07-29 Thread Vignesh Raman
For rockchip rk3288 and rk3399, the display driver is rockchip and gpu driver is panfrost. Currently, in drm-ci for rockchip rk3288 and rk3399, only the gpu driver is tested. Refactor the existing rockchip jobs to test both display and gpu driver and update xfails. Since the correct driver name is

[PATCH v9 5/6] drm/ci: meson: add tests for meson display driver

2024-07-29 Thread Vignesh Raman
For Amlogic Meson G12B (A311D) SOC the display driver is meson and gpu driver is panfrost. Currently, in drm-ci for Meson G12B (A311D), only the gpu driver is tested. Refactor the existing meson jobs and add support in drm-ci to test both display and gpu driver for Amlogic Meson G12B (A311D) and up

[PATCH v9 4/6] drm/ci: mediatek: add tests for powervr gpu driver

2024-07-29 Thread Vignesh Raman
For mediatek mt8173, the display driver is mediatek, while the gpu driver is powervr. Currently, in drm-ci for mt8173, only the display driver is tested. Add support in drm-ci to test powervr driver for mt8173. Powervr driver was merged in linux kernel, but there's no mediatek support yet. So disab

[PATCH v9 3/6] drm/ci: mediatek: add tests for mediatek display driver

2024-07-29 Thread Vignesh Raman
For mediatek mt8183, the display driver is mediatek, while the gpu driver is panfrost. Currently, in drm-ci for mt8183, only the gpu driver is tested. Refactor the existing mediatek jobs and add support in drm-ci to test both display and gpu driver for mt8183 and update xfails. Since the correct d

[PATCH v9 2/6] drm/ci: skip tools_test on non-intel platforms

2024-07-29 Thread Vignesh Raman
tools_test is a wrapper for running tools/intel_reg and tools/intel_l3_parity. So skip these tests on non-intel platforms and update expectaion files. Signed-off-by: Vignesh Raman --- v9: - New patch in the series to skip tools_test on non-intel platforms --- drivers/gpu/drm/ci/xfails/amdgpu

[PATCH v9 1/6] drm/ci: arm64.config: Enable CONFIG_DRM_ANALOGIX_ANX7625

2024-07-29 Thread Vignesh Raman
Enable CONFIG_DRM_ANALOGIX_ANX7625 in the arm64 defconfig to get display driver probed on the mt8183-kukui-jacuzzi-juniper machine. arch/arm64/configs/defconfig has CONFIG_DRM_ANALOGIX_ANX7625=m, but drm-ci don't have initrd with modules, so add CONFIG_DRM_ANALOGIX_ANX7625=y in CI arm64 config. A

[PATCH v9 0/6] drm/ci: Add support for GPU and display testing

2024-07-29 Thread Vignesh Raman
Some ARM SOCs have a separate display controller and GPU, each with different drivers. For mediatek mt8173, the GPU driver is powervr, and the display driver is mediatek. In the case of mediatek mt8183, the GPU driver is panfrost, and the display driver is mediatek. With rockchip rk3288/rk3399, the

Re: [PATCH v4 1/6] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-07-29 Thread Easwar Hariharan
On 7/10/2024 10:27 PM, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, > fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that > the approved

[PATCH 1/4] dt-bindings: display/msm/gmu: Add SDM670 compatible

2024-07-29 Thread Richard Acayan
The Snapdragon 670 has a GMU. Add its compatible. Signed-off-by: Richard Acayan --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/g

[PATCH 4/4] arm64: dts: qcom: sdm670-google-common: enable gpu

2024-07-29 Thread Richard Acayan
Enable the A615 GPU and GMU for the Pixel 3a. It has zap firmware, so add that in as well. Signed-off-by: Richard Acayan --- arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm670-google-sargo.dts b/arc

[PATCH 3/4] arm64: dts: qcom: sdm670: add gpu

2024-07-29 Thread Richard Acayan
The Snapdragon 670 has the Adreno A615 GPU. Add it along with its device tree dependencies. Signed-off-by: Richard Acayan --- arch/arm64/boot/dts/qcom/sdm670.dtsi | 168 +++ 1 file changed, 168 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm670.dtsi b/arch/arm64

[PATCH 2/4] drm/msm/adreno: add a615 support

2024-07-29 Thread Richard Acayan
The Adreno A615 is used in SDM670. Add an entry to support it along with the speed bins. Signed-off-by: Richard Acayan --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/g

[PATCH 0/4] drm/msm/adreno: Add A615 GPU for SDM670 and Pixel 3a

2024-07-29 Thread Richard Acayan
This adds support for the speed-binned A615 GPU on SDM670. Richard Acayan (4): dt-bindings: display/msm/gmu: Add SDM670 compatible drm/msm/adreno: add a615 support arm64: dts: qcom: sdm670: add gpu arm64: dts: qcom: sdm670-google-common: enable gpu .../devicetree/bindings/display/msm/gmu

Re: [PATCH] drm/ast: add multiple connectors support

2024-07-29 Thread oushixiong
Yes, I have  tested these patches, and these patches fix the problem. Best regards Shixiong 在 2024/7/29 20:34, Thomas Zimmermann 写道: Hi Am 11.07.24 um 11:01 schrieb oushixiong1...@163.com: From: Shixiong Ou [WHY] The AST2600 tx_chip_types will be detected as AST_TX_DP, but some BMC boards t

Re: [PATCH] drm/ast: add multiple connectors support

2024-07-29 Thread oushixiong
Just a VGA connector on the board. Best regards Shixiong 在 2024/7/29 20:29, Thomas Zimmermann 写道: Hi Am 11.07.24 um 11:01 schrieb oushixiong1...@163.com: From: Shixiong Ou [WHY] The AST2600 tx_chip_types will be detected as AST_TX_DP, but some BMC boards that use AST2600 use the VGA interfa

[PATCH] gpu: drm: use for_each_endpoint_of_node()

2024-07-29 Thread Kuninori Morimoto
We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Acked-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/base.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) di

[PATCH] gpu: drm: replace of_graph_get_next_endpoint()

2024-07-29 Thread Kuninori Morimoto
>From DT point of view, in general, drivers should be asking for a specific port number because their function is fixed in the binding. of_graph_get_next_endpoint() doesn't match to this concept. Simply replace - of_graph_get_next_endpoint(xxx, NULL); + of_graph_get_endpoint_by_r

Re: panel-simple-dp-aux: "DP AUX done_probing() can't defer" on MT8186 w/ Collabora kernel

2024-07-29 Thread Dmitry Baryshkov
On Sat, Jul 27, 2024 at 08:33:10PM GMT, Alper Nebi Yasak wrote: > Hi, > > I have a MT8186 "Magneton" Chromebook that I'm trying to boot a kernel > based on Collabora's for-kernelci branch [1], using a config from > postmarketOS [2] (intended for that), on a Debian sid installation. > This sometime

Re: [PATCH v3] rockchip/drm: vop2: add support for gamma LUT

2024-07-29 Thread Piotr Zalewski
Hi Andy On Monday, July 29th, 2024 at 4:35 AM, Andy Yan wrote: > > > > + > > > > +static void vop2_crtc_gamma_set(struct vop2 *vop2, struct drm_crtc > > > > *crtc, > > > > + struct drm_crtc_state *old_state) > > > > +{ > > > > + struct drm_crtc_state *state = crtc->state; > > > > + struct vop2_

Re: [PATCH] RFC: drm/drm_plane: Expose the plane capability and interoperability

2024-07-29 Thread Dmitry Baryshkov
On Mon, Jul 29, 2024 at 04:59:14AM GMT, Murthy, Arun R wrote: > Gentle Reminder! > Any comments? First of all, the format is underdocumented. Second, there is a usual requirement for new uAPI: please provide a pointer to IGT patch and to the userspace utilising the property. > > Thanks and Regar

Re: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Dixit, Ashutosh
On Mon, 29 Jul 2024 06:21:20 -0700, Lucas De Marchi wrote: > Hi Lucas, > Reviewed-by: Lucas De Marchi > > That fixes the build, but question to Ashutosh: it's odd to tie the > format to a bspec. What happens on next platform if the HW changes? > Hopefully it doesn't change in an incompatible way

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Dan Carpenter
On Mon, Jul 29, 2024 at 10:09:39PM +0200, Helge Deller wrote: > On 7/29/24 17:59, Dan Carpenter wrote: > > On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: > > > On 7/28/24 20:29, Christophe JAILLET wrote: > > > > If an error occurs after request_mem_region(), a corresponding > > > > r

Re: [PATCH 1/2] drivers: drm/msm/a6xx_catalog: Add A642L speedbin (0x81)

2024-07-29 Thread Danila Tikhonov
On 7/29/24 06:09, Bjorn Andersson wrote: On Mon, Jul 22, 2024 at 09:43:13PM GMT, Danila Tikhonov wrote: From: Eugene Lepshy Please make sure the subject prefix matches other changes in the same driver/files. Regards, Bjorn Thanks for the advice "drm/msm/a6xx: --//--" will be better? Bes

[PATCH v3 1/2] dt-bindings: display: panel: samsung, atna45dc02: Document ATNA45DC02

2024-07-29 Thread Rob Clark
From: Rob Clark The Samsung ATNA45DC02 panel is an AMOLED eDP panel, similar to the existing ATNA45AF01 and ATNA33XC20 panel but with a higher resolution. Signed-off-by: Rob Clark Acked-by: Conor Dooley --- .../bindings/display/panel/samsung,atna33xc20.yaml | 9 ++--- 1 file changed

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Christophe JAILLET
Le 29/07/2024 à 22:09, Helge Deller a écrit : On 7/29/24 17:59, Dan Carpenter wrote: On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: On 7/28/24 20:29, Christophe JAILLET wrote: If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called, a

Re: (subset) [PATCH 00/13] rockchip: Enable 4K@60Hz mode on RK3228, RK3328, RK3399 and RK356x

2024-07-29 Thread Heiko Stuebner
On Sat, 15 Jun 2024 17:03:51 +, Jonas Karlman wrote: > This prepares and enable use of HDMI2.0 modes, e.g. 4K@60Hz, on RK3228, > RK3328, RK3399 and RK356x. > > Patch 1-3 fixes some issues to help support use of high-resolution modes. > > Patch 4 fixes reading of EDID on RK3328 when using a fo

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Helge Deller
On 7/29/24 17:59, Dan Carpenter wrote: On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: On 7/28/24 20:29, Christophe JAILLET wrote: If an error occurs after request_mem_region(), a corresponding release_mem_region() should be called, as already done in the remove function. True.

Re: [PATCH v1 1/2] drm/panel: jd9365da: Move the sending location of the 11/29 command

2024-07-29 Thread Dmitry Baryshkov
On Mon, 29 Jul 2024 at 06:10, zhaoxiong lv wrote: > > On Sun, Jul 28, 2024 at 12:59 AM Dmitry Baryshkov > wrote: > > > > On Thu, Jul 25, 2024 at 04:32:44PM GMT, Zhaoxiong Lv wrote: > > > Move the 11/29 command from enable() to init() function > > > > > > As mentioned in the patch: > > > https://l

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-07-29 11:28:35) > > Thanks for the feedback. > > Your change looks valid. We can use this and drop the max_t usage. > > Let me push this with your Suggested-by credits. You can take my Signed-off-by: Stephen Boyd and either squash it in or make a follow-up.

Re: [PATCH] drm/plane: Fix IS_ERR() vs NULL bug

2024-07-29 Thread Zack Rusin
On Sat, Jul 27, 2024 at 1:32 AM Dan Carpenter wrote: > > The drm_property_create_signed_range() function returns NULL on error, > it doesn't return error pointers. Change the IS_ERR() tests to check > for NULL. > > Fixes: 8f7179a1027d ("drm/atomic: Add support for mouse hotspots") > Signed-off-by

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-29 Thread Christian König
Am 26.07.24 um 16:21 schrieb Daniel Vetter: On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANC

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Abhinav Kumar
On 7/27/2024 5:51 AM, Dmitry Baryshkov wrote: On Fri, 26 Jul 2024 at 01:04, Abhinav Kumar wrote: Currently the DP driver hard-codes the max supported bpp to 30. This is incorrect because the number of lanes and max data rate supported by the lanes need to be taken into account. Replace the

Re: [PATCH] drm/sched: add optional errno to drm_sched_start()

2024-07-29 Thread Christian König
Am 26.07.24 um 14:30 schrieb Matthew Brost: On Fri, Jul 26, 2024 at 09:55:50AM +0200, Christian König wrote: The current implementation of drm_sched_start uses a hardcoded -ECANCELED to dispose of a job when the parent/hw fence is NULL. This results in drm_sched_job_done being called with -ECANC

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-29 Thread Lyude Paul
On Fri, 2024-07-26 at 15:40 +0200, Daniel Vetter wrote: > On Thu, Jul 25, 2024 at 03:35:18PM -0400, Lyude Paul wrote: > > On Tue, 2024-07-16 at 11:25 +0200, Daniel Vetter wrote: > > > On Mon, Jul 15, 2024 at 02:05:49PM -0300, Daniel Almeida wrote: > > > > Hi Sima! > > > > > > > > > > > > > > > >

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Abhinav Kumar
Hi Stephen On 7/26/2024 5:24 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-07-25 15:03:19) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index a916b5f3b317..56ce5e4008f8 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_pa

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: S

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Christian König
Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: Hi, On 7/29/24 02:23, Christian König wrote: Am 26.07.24 um 14:52 schrieb Alex Deucher: On Fri, Jul 26, 2024 at 3:05 AM Christian König wrote: Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_r

[PATCH v2] drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

2024-07-29 Thread Nikita Zhandarovich
On the off chance that clock value ends up being too high (by means of skl_ddi_calculate_wrpll() having benn called with big enough value of crtc_state->port_clock * 1000), one possible consequence may be that the result will not be able to fit into signed int. Fix this issue by moving conversion

Re: [PATCH 3/4] drm/msm/a5xx: fix races in preemption evaluation stage

2024-07-29 Thread Connor Abbott
On Thu, Jul 11, 2024 at 11:10 AM Vladimir Lypak wrote: > > On A5XX GPUs when preemption is used it's invietable to enter a soft > lock-up state in which GPU is stuck at empty ring-buffer doing nothing. > This appears as full UI lockup and not detected as GPU hang (because > it's not). This happens

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-07-29 Thread Nikita Zhandarovich
Hi, On 7/29/24 02:23, Christian König wrote: > Am 26.07.24 um 14:52 schrieb Alex Deucher: >> On Fri, Jul 26, 2024 at 3:05 AM Christian König >> wrote: >>> Am 25.07.24 um 20:09 schrieb Nikita Zhandarovich: Several cs track offsets (such as 'track->db_s_read_offset') either are initialize

Re: [REGRESSION] No image on 4k display port displays connected through usb-c dock in kernel 6.10

2024-07-29 Thread kevin
July 29, 2024 at 11:15 AM, "Linux regression tracking (Thorsten Leemhuis)" wrote: > > On 29.07.24 10:47, Christian Heusel wrote: > > > > > On 24/07/29 10:35AM, Linux regression tracking (Thorsten Leemhuis) wrote: > > > > > > > > [+Greg +stable] > > > > > > On 29.07.24 10:16, Lin, Wayne

Re: [PATCH] MAINTAINERS: update email for Konrad Dybcio

2024-07-29 Thread Konrad Dybcio
On 29.07.2024 2:51 PM, Wolfram Sang wrote: > The old email address bounced. I found the newer one in MAINTAINERS, > so update entries accordingly. > > Cc: Konrad Dybcio > Signed-off-by: Wolfram Sang > --- Already sent a series of fixups, but thanks for keeping track https://lore.kernel.org/

[PATCH] drm/amd/amdgpu: Properly tune the size of struct

2024-07-29 Thread WangYuli
The struct assertion is failed because sparse cannot parse `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. GCC's output is still 1-byte-aligned. No harm to memory layout. The error can be filtered out by sparse-diff, but sometimes multiple lines queezed into one, making the sparse-diff

Re: [Linux-stm32] [PATCH RESEND v3 0/3] Update STM DSI PHY driver

2024-07-29 Thread Yanjun Yang
On Fri, Jul 26, 2024 at 09:55:35AM +0200, Philippe CORNU wrote: > > > On 7/22/24 10:38, Yanjun Yang wrote: > > > > This patch (commit id:185f99b614427360) seems to break the dsi of > > stm32f469 chip. > > I'm not familiar with the drm and the clock framework, maybe it's > > because there is no >

[PATCH v2] drm/amd/amdgpu: Properly tune the size of struct

2024-07-29 Thread WangYuli
The struct assertion is failed because sparse cannot parse `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. GCC's output is still 1-byte-aligned. No harm to memory layout. The error can be filtered out by sparse-diff, but sometimes multiple lines queezed into one, making the sparse-diff

Re: [PATCH] fbdev/hpfb: Fix an error handling path in hpfb_dio_probe()

2024-07-29 Thread Dan Carpenter
On Mon, Jul 29, 2024 at 10:13:17AM +0200, Helge Deller wrote: > On 7/28/24 20:29, Christophe JAILLET wrote: > > If an error occurs after request_mem_region(), a corresponding > > release_mem_region() should be called, as already done in the remove > > function. > > True. > > > Fixes: 1da177e4c3f4

Re: [PATCH 3/3] dt-bindings: Batch-update Konrad Dybcio's email

2024-07-29 Thread Rob Herring (Arm)
On Fri, 26 Jul 2024 13:18:25 +0200, Konrad Dybcio wrote: > Use my @kernel.org address everywhere. > > Signed-off-by: Konrad Dybcio > --- > Documentation/devicetree/bindings/clock/qcom,dispcc-sm6350.yaml | 2 > +- > Documentation/devicetree/bindings/clock/qcom,gcc-msm8994.yaml

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-29 Thread Akhil P Oommen
On Mon, Jul 29, 2024 at 02:40:30PM +0200, Konrad Dybcio wrote: > > > On 29.07.2024 2:13 PM, Konrad Dybcio wrote: > > On 16.07.2024 1:56 PM, Konrad Dybcio wrote: > >> On 15.07.2024 10:04 PM, Akhil P Oommen wrote: > >>> On Tue, Jul 09, 2024 at 12:45:29PM +0200, Konrad Dybcio wrote: > On recent

Re: [PATCH v2] drm/amd/amdgpu: Properly tune the size of struct

2024-07-29 Thread Dan Carpenter
On Mon, Jul 29, 2024 at 10:00:00PM +0800, WangYuli wrote: > The struct assertion is failed because sparse cannot parse > `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. > GCC's output is still 1-byte-aligned. No harm to memory layout. > > The error can be filtered out by sparse-diff, bu

Re: [PATCH v4 09/11] drm/amd/display: get SAD from drm_eld when parsing EDID caps

2024-07-29 Thread Alex Hung
On 2024-07-28 20:02, Melissa Wen wrote: On 07/25, Alex Hung wrote: On 2024-07-05 21:35, Melissa Wen wrote: instead of parsing struct edid. A more informative commit message will be helpful. sure. I'll improve it in the next version. A soft reminder - a few other patches need improved

Re: [PATCH v4 01/11] drm/amd/display: clean unused variables for hdmi freesync parser

2024-07-29 Thread Alex Hung
On 2024-07-28 19:32, Melissa Wen wrote: On 07/25, Alex Hung wrote: Hi Melissa, There are no commit messages in this patch. Also, do you think this can be merged with Patch 5 "drm/amd/display: remove redundant freesync parser for DP"? Hi Alex, Thanks for your feedback. I'll add a brief d

Re: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Lucas De Marchi
On Mon, Jul 29, 2024 at 11:26:34AM GMT, Geert Uytterhoeven wrote: When building with gcc-5: In function ‘decode_oa_format.isra.26’, inlined from ‘xe_oa_set_prop_oa_format’ at drivers/gpu/drm/xe/xe_oa.c:1664:6: ././include/linux/compiler_types.h:510:38: error: call to ‘__compileti

Re: [PATCH] drm/nouveau: remove unused variable ret

2024-07-29 Thread Danilo Krummrich
Hi Jani, On Mon, Jul 29, 2024 at 03:36:24PM +0300, Jani Nikula wrote: > Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled: > > ../drivers/gpu/drm/nouveau/nouveau_platform.c: In function > ‘nouveau_platform_probe’: > ../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable

Re: [PATCH] MAINTAINERS: update email for Konrad Dybcio

2024-07-29 Thread Wolfram Sang
Hi Konrad, > Already sent a series of fixups, but thanks for keeping track Welcome. Cool that you are at it! Happy hacking, Wolfram signature.asc Description: PGP signature

[PATCH] MAINTAINERS: update email for Konrad Dybcio

2024-07-29 Thread Wolfram Sang
The old email address bounced. I found the newer one in MAINTAINERS, so update entries accordingly. Cc: Konrad Dybcio Signed-off-by: Wolfram Sang --- Against v6.11-rc1. Still needs ack from Konrad Dybcio MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAI

Re: [PATCH v3 0/2] Basic support for TI TDP158

2024-07-29 Thread Marc Gonzalez
On 27/06/2024 13:13, Marc Gonzalez wrote: > Changes in v3: > - Add 'select DRM_PANEL_BRIDGE' in driver Kconfig > - Fix checkpatch errors > - log errors using dev_err (so save dev pointer) > - expand a few error messages > - expand commit messages with info from the datasheet > - mark regulators as

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-29 Thread Konrad Dybcio
On 29.07.2024 2:13 PM, Konrad Dybcio wrote: > On 16.07.2024 1:56 PM, Konrad Dybcio wrote: >> On 15.07.2024 10:04 PM, Akhil P Oommen wrote: >>> On Tue, Jul 09, 2024 at 12:45:29PM +0200, Konrad Dybcio wrote: On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is abstracted t

[PATCH] drm/nouveau: remove unused variable ret

2024-07-29 Thread Jani Nikula
Fix build with CONFIG_NOUVEAU_PLATFORM_DRIVER enabled: ../drivers/gpu/drm/nouveau/nouveau_platform.c: In function ‘nouveau_platform_probe’: ../drivers/gpu/drm/nouveau/nouveau_platform.c:29:13: error: unused variable ‘ret’ [-Werror=unused-variable] 29 | int ret; | ^~~

Re: [PATCH] drm/ast: add multiple connectors support

2024-07-29 Thread Thomas Zimmermann
Hi Am 11.07.24 um 11:01 schrieb oushixiong1...@163.com: From: Shixiong Ou [WHY] The AST2600 tx_chip_types will be detected as AST_TX_DP, but some BMC boards that use AST2600 use the VGA interface instead of the DP interface. In this case, it will use Virtual connector as the DP is disconnected

Re: [PATCH 0/5] drm/ast: Fix DP hotplugging and clean up

2024-07-29 Thread Thomas Zimmermann
Ping for review Am 17.07.24 um 16:24 schrieb Thomas Zimmermann: Here are a number of updates for ast's ASTDP transmitter code. So far the ast driver required the DisplayPort to be connected at boot. Later detection was not supported. Re-connecting the cable was also not supported. Once atomic_d

Re: [PATCH] drm/ast: add multiple connectors support

2024-07-29 Thread Thomas Zimmermann
Hi Am 11.07.24 um 11:01 schrieb oushixiong1...@163.com: From: Shixiong Ou [WHY] The AST2600 tx_chip_types will be detected as AST_TX_DP, but some BMC boards that use AST2600 use the VGA interface instead of the DP interface. In this case, it will use Virtual connector as the DP is disconnected

Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-29 Thread Krzysztof Kozlowski
On 29/07/2024 14:05, Alex Lanzano wrote: >> Under which circumstances would you become interested to apply a statement >> like “guard(mutex)(&smd->tx_mutex);”? >> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/mutex.h#L196 >> > > Ah, I didn't realize guarded mutexes were implemented

Re: [PATCH v5 00/12] spi: add driver for Intel discrete graphics

2024-07-29 Thread Mark Brown
On Mon, Jul 29, 2024 at 11:43:14AM +0300, Alexander Usyskin wrote: > V5: depend solely on AUXILIARY_BUS, not on COMPILE_TEST > disable spi driver on virtual function in Xe, no spi device there > V4: fix white-spaces > add check for discrete graphics missed in i915 intel_spi_fini > V3: re

[PATCH 0/1] Update on habanalabs maintainer status

2024-07-29 Thread Ofir Bitton
Hi Dave, Sima. As I am about to leave Intel during the next weeks, I'm stepping down from the maintainer role of the habanalabs driver. Yaron Avizrat from Intel will replace me as the new maintainer. Ofir Bitton (1): MAINTAINERS: Change habanalabs maintainer MAINTAINERS | 2 +- 1 file change

[PATCH 1/1] MAINTAINERS: Change habanalabs maintainer

2024-07-29 Thread Ofir Bitton
I will be leaving Intel soon, Yaron Avizrat will take the role of habanalabs driver maintainer. Signed-off-by: Ofir Bitton --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ed2d2dbcec81..a4b36590061e 100644 --- a/MAINTAINERS +++ b

Re: [PATCH v5 1/5] drm/msm/adreno: Implement SMEM-based speed bin

2024-07-29 Thread Konrad Dybcio
On 16.07.2024 1:56 PM, Konrad Dybcio wrote: > On 15.07.2024 10:04 PM, Akhil P Oommen wrote: >> On Tue, Jul 09, 2024 at 12:45:29PM +0200, Konrad Dybcio wrote: >>> On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is >>> abstracted through SMEM, instead of being directly available in a

Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD

2024-07-29 Thread Alex Lanzano
On Mon, Jul 29, 2024 at 01:00:47PM GMT, Markus Elfring wrote: > … > > +++ b/drivers/gpu/drm/tiny/sharp-memory.c > > @@ -0,0 +1,684 @@ > … > > static int sharp_memory_update_display(struct sharp_memory_device *smd, > > + struct drm_framebuffer *fb, > > +

Re: [PATCH resend v4 00/11] Improve the copy of task comm

2024-07-29 Thread Yafang Shao
On Mon, Jul 29, 2024 at 5:29 PM Jani Nikula wrote: > > On Mon, 29 Jul 2024, Yafang Shao wrote: > > Hello Andrew, > > > > Is it appropriate for you to apply this to the mm tree? > > > > Using {memcpy,strncpy,strcpy,kstrdup} to copy the task comm relies on the > > length of task comm. Changes in th

Re: [PATCH v6 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-07-29 Thread Mostafa Saleh
Hi Rob, On Wed, Jul 17, 2024 at 09:36:21AM -0700, Rob Clark wrote: > From: Rob Clark > > Add an io-pgtable method to walk the pgtable returning the raw PTEs that > would be traversed for a given iova access. > > Signed-off-by: Rob Clark > Acked-by: Joerg Roedel > > --- > drivers/iommu/io-pg

  1   2   >