Re: [PATCH v2] drm/amdgpu: fix a possible null pointer dereference

2024-07-10 Thread Markus Elfring
> In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode() > is assigned to mode, which will lead to a NULL pointer dereference on > failure of drm_cvt_mode(). Add a check to avoid npd. > > Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") > Signed-off-by: Ma Ke Are you g

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Krzysztof Kozlowski
On 10/07/2024 19:04, Stephan Gerhold wrote: > The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight > control over the DP AUX channel. While it works almost correctly with the > generic "edp-panel" compatible, the backlight needs special handling to > work correctly. It is similar

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Krzysztof Kozlowski
On 10/07/2024 19:35, Doug Anderson wrote: > Hi, > > On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold > wrote: >> >> The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight >> control over the DP AUX channel. While it works almost correctly with the >> generic "edp-panel" compatible

[PATCH v4 6/6] fbdev/viafb: Make I2C terminology more inclusive

2024-07-10 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Acked-by: Thoma

[PATCH v4 5/6] fbdev/smscufx: Make I2C terminology more inclusive

2024-07-10 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Acked-by: Thoma

[PATCH v4 4/6] sfc: falcon: Make I2C terminology more inclusive

2024-07-10 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Reviewed-by: Ma

[PATCH v4 3/6] drm/i915: Make I2C terminology more inclusive

2024-07-10 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Reviewed-by: Ro

[PATCH v4 2/6] drm/gma500: Make I2C terminology more inclusive

2024-07-10 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Acked-by: Thoma

[PATCH v4 1/6] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive

2024-07-10 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Acked-by: Alex

[PATCH v4 0/6] Make I2C terminology more inclusive for I2C Algobit and consumers

2024-07-10 Thread Easwar Hariharan
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of the I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the spec

[PATCH] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-10 Thread Nitin Gote
We're seeing a GPU HANG issue on a CHV platform, which was caused by bac24f59f454 ("drm/i915/execlists: Enable coarse preemption boundaries for gen8"). Gen8 platform has only timeslice and doesn't support a preemption mechanism as engines do not have a preemption timer and doesn't send an irq if

回复:va range based memory management discussion (was: 回复:回复:Re:Proposal to add CRIU support to DRM render nodes)

2024-07-10 Thread 周春明(日月)
-- 发件人:Felix Kuehling 发送时间:2024年7月11日(星期四) 07:47 收件人:周春明(日月) ; Tvrtko Ursulin ; dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org ; Dave Airlie ; Daniel Vetter ; criu 抄 送:"Errabolu, Ramesh" ; "Christian König" ; 张伦强

[PATCH v2] drm/amdgpu: fix a possible null pointer dereference

2024-07-10 Thread Ma Ke
In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid npd. Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") Signed-off-by: Ma Ke --- Changes in v2: -

Re: [PATCH net-next v16 13/13] netdev: add dmabuf introspection

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 00:17:46 + Mina Almasry wrote: > Add dmabuf information to page_pool stats: > > $ ./cli.py --spec ../netlink/specs/netdev.yaml --dump page-pool-get Aha, thanks! Reviewed-by: Jakub Kicinski

Re: [PATCH v3 3/5] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-07-10 Thread 宋孝謙

Re: [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference

2024-07-10 Thread 林睿祥

Re: [PATCH net-next v16 05/13] page_pool: devmem support

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 16:42:04 -0700 Mina Almasry wrote: > > > +static inline void netmem_set_pp(netmem_ref netmem, struct page_pool > > > *pool) > > > +{ > > > + __netmem_clear_lsb(netmem)->pp = pool; > > > +} > > > > Why is all this stuff in the main header? It's really low level. > > Please

Re: [PATCH net-next v16 05/13] page_pool: devmem support

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 13:29:03 -0700 Mina Almasry wrote: > If we want to add __skb_frag_ref() support for net_iov I suggest something > like: > > diff --git a/include/linux/skbuff_ref.h b/include/linux/skbuff_ref.h > index 0f3c58007488a..02f7f4c7d4821 100644 > --- a/include/linux/skbuff_ref.h > +++

Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml

2024-07-10 Thread 林睿祥

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

2024-07-10 Thread cong yang
Hi, Michael Walle 于2024年7月11日周四 03:38写道: > > On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: > > Hi, > > > > On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: > > > > > > On Wed Jul 10, 2024 at 10:47 AM CEST, Cong Yang wrote: > > > > Break select page cmds into helper function. > >

Re: [PATCH net-next v16 12/13] selftests: add ncdevmem, netcat for devmem TCP

2024-07-10 Thread John Hubbard
On 7/9/24 5:17 PM, Mina Almasry wrote: ... diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index bc3925200637c..39420a6e86b7f 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -95,6 +95,11 @@ TEST_PROGS += fq_

Re: [RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-10 Thread Danilo Krummrich
(+Sima) Hi Daniel, On 7/11/24 12:50 AM, Daniel Almeida wrote: Dump the state of the GPU. This feature is useful for debugging purposes. --- Hi everybody! For those looking for a branch instead, see [0]. I know this patch has (possibly many) issues. It is meant as a discussion around the GEM a

Re: va range based memory management discussion (was: 回复:回复:Re:Proposal to add CRIU support to DRM render nodes)

2024-07-10 Thread Felix Kuehling
On 2024-07-09 22:38, 周春明(日月) wrote: -- 发件人:Felix Kuehling 发送时间:2024年7月10日(星期三) 01:07 收件人:周春明(日月) ; Tvrtko Ursulin ; dri-devel@lists.freedesktop.org ; amd-...@lists.freedesktop.org ; Dave Airlie ; Daniel Vetter ; criu 抄 送:

Re: [PATCH net-next v16 05/13] page_pool: devmem support

2024-07-10 Thread Mina Almasry
On Wed, Jul 10, 2024 at 9:49 AM Jakub Kicinski wrote: > > On Wed, 10 Jul 2024 00:17:38 + Mina Almasry wrote: > > +static inline struct net_iov *__netmem_clear_lsb(netmem_ref netmem) > > +{ > > + return (struct net_iov *)((__force unsigned long)netmem & ~NET_IOV); > > +} > > + > > +static i

[RFC PATCH] drm: panthor: add dev_coredumpv support

2024-07-10 Thread Daniel Almeida
Dump the state of the GPU. This feature is useful for debugging purposes. --- Hi everybody! For those looking for a branch instead, see [0]. I know this patch has (possibly many) issues. It is meant as a discussion around the GEM abstractions for now. In particular, I am aware of the series intro

Re: [PATCH net-next v16 04/13] netdev: netdevice devmem allocator

2024-07-10 Thread Mina Almasry
On Wed, Jul 10, 2024 at 12:55 PM Jakub Kicinski wrote: > > On Wed, 10 Jul 2024 12:29:58 -0700 Mina Almasry wrote: > > On Wed, Jul 10, 2024 at 9:37 AM Jakub Kicinski wrote: > > > On Wed, 10 Jul 2024 00:17:37 + Mina Almasry wrote: > > > > + net_devmem_dmabuf_binding_get(binding); > > > > >

Re: [PATCH 4/5] arm64: dts: qcom: x1e80100-crd: Fix backlight

2024-07-10 Thread Konrad Dybcio
On 10.07.2024 7:05 PM, Stephan Gerhold wrote: > The backlight does not work correctly with the current display panel > configuration: It works after boot, but once the display gets disabled it > is not possible to get it back on. It turns out that the ATNA45AF01 panel > needs exactly the same non-s

Re: [PATCH 2/2] drm/amd/display: use drm_crtc_set_vblank_offdelay()

2024-07-10 Thread Hamza Mahfooz
On 7/10/24 04:43, Daniel Vetter wrote: On Tue, Jul 09, 2024 at 10:02:08AM -0400, Hamza Mahfooz wrote: On 7/9/24 06:09, Daniel Vetter wrote: On Tue, Jul 09, 2024 at 11:32:11AM +0200, Daniel Vetter wrote: On Mon, Jul 08, 2024 at 04:29:07PM -0400, Hamza Mahfooz wrote: Hook up drm_crtc_set_vblank

[PATCH] drm/tegra: hub: Use fn parameter directly to fix Coccinelle warning

2024-07-10 Thread Thorsten Blum
The function parameter out can be used directly instead of assigning it to a temporary u64 variable first. Remove the local variable tmp2 and use the parameter out directly as the divisor in do_div() to remove the following Coccinelle/coccicheck warning reported by do_div.cocci: WARNING: do_div

Re: [PATCH v4 0/2] Add support for 'power saving policy' property

2024-07-10 Thread Hamza Mahfooz
On 7/3/24 01:17, Mario Limonciello wrote: During the Display Next hackfest 2024 one of the topics discussed was the need for compositor to be able to relay intention to drivers that color fidelity is preferred over power savings. To accomplish this a new optional DRM property is being introduced

Re: [PATCH v4 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-07-10 Thread Leo Li
On 2024-07-03 01:17, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Req

Re: [PULL] drm-xe-next-fixes

2024-07-10 Thread Rodrigo Vivi
On Wed, Jul 10, 2024 at 02:42:38PM -0500, Lucas De Marchi wrote: > On Tue, Jul 09, 2024 at 05:31:39PM GMT, Rodrigo Vivi wrote: > > Hi Dave and Sima, > > > > Here goes a very early drm-xe-next-fixes with 2 important fixes > > that are going to impact user space. > > > > 1. The first one is the ren

Re: [PATCH net-next v16 05/13] page_pool: devmem support

2024-07-10 Thread Mina Almasry
On Wed, Jul 10, 2024 at 9:49 AM Jakub Kicinski wrote: > > On Wed, 10 Jul 2024 00:17:38 + Mina Almasry wrote: > > @@ -68,17 +107,103 @@ static inline netmem_ref page_to_netmem(struct page > > *page) > > > > static inline int netmem_ref_count(netmem_ref netmem) > > { > > + /* The non-pp r

Re: [PATCH v9 27/52] selftests-dyndbg: check KCONFIG_CONFIG to avoid silly fails

2024-07-10 Thread Helen Koike
On 02/07/2024 18:57, Jim Cromie wrote: Several tests are dependent upon config choices. Lets avoid failing where that is noise. The KCONFIG_CONFIG var exists to convey the config-file around. If the var names a file, read it and extract the relevant CONFIG items, and use them to skip the dep

Re: [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-10 Thread Lei Liu
on 2024/7/10 22:48, Christian König wrote: Am 10.07.24 um 16:35 schrieb Lei Liu: on 2024/7/10 22:14, Christian König wrote: Am 10.07.24 um 15:57 schrieb Lei Liu: Use vm_insert_page to establish a mapping for the memory allocated by dmabuf, thus supporting direct I/O read and write; and fix

[PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-10 Thread Lei Liu
Use vm_insert_page to establish a mapping for the memory allocated by dmabuf, thus supporting direct I/O read and write; and fix the issue of incorrect memory statistics after mapping dmabuf memory. Lei Liu (2): mm: dmabuf_direct_io: Support direct_io for memory allocated by dmabuf mm: dmabuf_

[PATCH 2/2] mm: dmabuf_direct_io: Fix memory statistics error for dmabuf allocated memory with direct_io support

2024-07-10 Thread Lei Liu
The method of establishing mmap mapping for memory allocated by dmabuf through vm_insert_page causes changes in the way dmabuf memory is accounted for, primarily in the following three aspects: (1) The memory usage of dmabuf is accounted for in mm->rss. (2) /proc/self/smaps will account for the m

[PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-10 Thread Lei Liu
Use vm_insert_page to establish a mapping for the memory allocated by dmabuf, thus supporting direct I/O read and write; and fix the issue of incorrect memory statistics after mapping dmabuf memory. Lei Liu (2): mm: dmabuf_direct_io: Support direct_io for memory allocated by dmabuf mm: dmabuf_

Re: [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-10 Thread Lei Liu
在 2024/7/10 22:14, Christian König 写道: Am 10.07.24 um 15:57 schrieb Lei Liu: Use vm_insert_page to establish a mapping for the memory allocated by dmabuf, thus supporting direct I/O read and write; and fix the issue of incorrect memory statistics after mapping dmabuf memory. Well big NAK to

[PATCH 1/2] mm: dmabuf_direct_io: Support direct_io for memory allocated by dmabuf

2024-07-10 Thread Lei Liu
1.Effects and reasons for lack of support: Currently, memory allocated by dmabuf cannot be read from files using direct_io. With the increasing use of AI models in mobile applications, there is a growing need to load large model files occupying up to 3-4GB into mobile memory. Presently, the only w

[PATCH 1/2] mm: dmabuf_direct_io: Support direct_io for memory allocated by dmabuf

2024-07-10 Thread Lei Liu
1.Effects and reasons for lack of support: Currently, memory allocated by dmabuf cannot be read from files using direct_io. With the increasing use of AI models in mobile applications, there is a growing need to load large model files occupying up to 3-4GB into mobile memory. Presently, the only w

Re: [PATCH net-next v16 04/13] netdev: netdevice devmem allocator

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 12:29:58 -0700 Mina Almasry wrote: > On Wed, Jul 10, 2024 at 9:37 AM Jakub Kicinski wrote: > > On Wed, 10 Jul 2024 00:17:37 + Mina Almasry wrote: > > > + net_devmem_dmabuf_binding_get(binding); > > > > Why does every iov need to hold a ref? pp holds a ref and does i

Re: [PULL] drm-xe-next-fixes

2024-07-10 Thread Lucas De Marchi
On Tue, Jul 09, 2024 at 05:31:39PM GMT, Rodrigo Vivi wrote: Hi Dave and Sima, Here goes a very early drm-xe-next-fixes with 2 important fixes that are going to impact user space. 1. The first one is the rename of the OA stuff from the bad 'perf' name to the xe_observation. Although the rename i

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

2024-07-10 Thread Michael Walle
On Wed Jul 10, 2024 at 9:12 PM CEST, Doug Anderson wrote: > Hi, > > On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: > > > > On Wed Jul 10, 2024 at 10:47 AM CEST, Cong Yang wrote: > > > Break select page cmds into helper function. > > > > Why though? I don't find that anything easier to read.

Re: [PATCH net-next v16 04/13] netdev: netdevice devmem allocator

2024-07-10 Thread Mina Almasry
On Wed, Jul 10, 2024 at 9:37 AM Jakub Kicinski wrote: > > On Wed, 10 Jul 2024 00:17:37 + Mina Almasry wrote: > > + net_devmem_dmabuf_binding_get(binding); > > Why does every iov need to hold a ref? pp holds a ref and does its own > accounting, so it won't disappear unless all the pages are

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 12:03 PM Stephan Gerhold wrote: > > > 2. In theory you could make your compatible look like this: > > > > compatible = "samsung,atna45af01", "samsung,atna33xc20" > > > > ...which would say "I have a 45af01 but if the OS doesn't have > > anything special to do that it w

Re: [PATCH v1 4/4] drm/panel: ili9806e: Break some CMDS into helper functions

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 2:02 AM Michael Walle wrote: > > On Wed Jul 10, 2024 at 10:47 AM CEST, Cong Yang wrote: > > Break select page cmds into helper function. > > Why though? I don't find that anything easier to read. In fact, I > deliberately chose not to factor that out into a function. I

Re: [PATCH v1 2/4] drm/panel: nt35521: Break some CMDS into helper functions

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 1:47 AM Cong Yang wrote: > > Break select page cmds into helper functions. > > Signed-off-by: Cong Yang > --- > .../panel/panel-sony-tulip-truly-nt35521.c| 29 ++- > 1 file changed, 21 insertions(+), 8 deletions(-) Reviewed-by: Douglas Anderson

Re: [PATCH v1 3/4] drm/panel: nt36672e: Break some CMDS into helper functions

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 1:47 AM Cong Yang wrote: > > Break select page cmds and reload cmds into helper functions. > > Signed-off-by: Cong Yang > --- > .../gpu/drm/panel/panel-novatek-nt36672e.c| 69 --- > 1 file changed, 44 insertions(+), 25 deletions(-) Reviewed-by: D

Re: [PATCH v1 1/4] drm/panel: boe-tv101wum-nl6: Break some CMDS into helper functions

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 1:47 AM Cong Yang wrote: > > hj110iz-01a and tv110c9m-ll3 both nt36523 controller, and they have > some common cmds, so let's break them into helper functions. > > Signed-off-by: Cong Yang > --- > .../gpu/drm/panel/panel-boe-tv101wum-nl6.c| 190 ++

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Stephan Gerhold
On Wed, Jul 10, 2024 at 10:35:28AM -0700, Doug Anderson wrote: > On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold > wrote: > > > > The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight > > control over the DP AUX channel. While it works almost correctly with the > > generic "edp-p

[PATCH] drm/panel-edp: Add BOE NV140WUM-N41

2024-07-10 Thread Hsin-Yi Wang
The raw edid of the panel is: 00 ff ff ff ff ff ff 00 09 e5 e8 0a 00 00 00 00 2a 1f 01 04 a5 1e 13 78 03 fb f5 96 5d 5a 91 29 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 9c 3e 80 c8 70 b0 3c 40 30 20 36 00 2e bc 10 00 00 1a 00 00 00 fd 00 28 3c 4c 4c 10 01 0a 20 20 20 20 20 20

Re: [PATCH 4/7] drm/ttm: move LRU walk defines into new internal header

2024-07-10 Thread Matthew Brost
On Wed, Jul 10, 2024 at 02:42:58PM +0200, Christian König wrote: > That is something drivers really shouldn't mess with. > Thomas uses this in Xe to implement a shrinker [1]. Seems to need to remain available for drivers. Matt [1] https://patchwork.freedesktop.org/patch/602165/?series=131815&re

Re: [PATCH 12/12] drm/v3d: Prefer get_user for scalar types

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin It makes it just a tiny bit more obvious what is going on. Signed-off-by: Tvrtko Ursulin Reviewed-by: Maíra Canal Best Regards, - Maíra --- drivers/gpu/drm/v3d/v3d_submit.c | 10 +- 1 file changed, 5 insertions(+),

Re: [PATCH 3/5] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold wrote: > > This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. > > The panel should be handled through the samsung-atna33xc20 driver for > correct power up timings. Otherwise the backlight does not work correctly. > > We have existing

Re: [PATCH 11/12] drm/v3d: Add some local variables in queries/extensions

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add some local variables to make the code a bit less verbose, with the main benefit being pulling some lines to under 80 columns wide. Signed-off-by: Tvrtko Ursulin I'd prefer `query_info`, but anyway: Reviewed-by: Maíra Canal

Re: [PATCH 10/12] drm/v3d: Align data types of internal and uapi counts

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In the timestamp and performance extensions userspace type for counts is u32 so lets use unsigned in the kernel too. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_submit.c | 9 ++--- 1 file changed, 6 insertions(+

Re: [PATCH 09/12] drm/v3d: Move perfmon init completely into own unit

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Now that the build time dependencies on various array sizes have been removed, we can move the perfmon init completely into its own compilation unit and remove the hardcoded defines. This improves on the temporary fix quickly deliver

Re: [PATCH 2/5] drm/panel: samsung-atna33xc20: Add compatible for ATNA45AF01

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold wrote: > > The Samsung ATNA45AF01 panel needs exactly the same non-standard power > sequence as the Samsung ATNA33XC20 panel for backlight to work properly. > Add the new "samsung,atna45af01" compatible to the driver to make it handle > these p

Re: [PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Doug Anderson
Hi, On Wed, Jul 10, 2024 at 10:05 AM Stephan Gerhold wrote: > > The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight > control over the DP AUX channel. While it works almost correctly with the > generic "edp-panel" compatible, the backlight needs special handling to > work corre

Re: [PATCH 07/12] drm/v3d: Size the kperfmon_ids array at runtime

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Instead of statically reserving pessimistic space for the kperfmon_ids array, make the userspace extension code allocate the exactly required amount of space. Apart from saving some memory at runtime, this also removes the need for t

Re: [PATCH 06/12] drm/v3d: Move part of copying of reset/copy performance extension to a helper

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin The loop which looks up the syncobj and copies the kperfmon ids is identical so lets move it to a helper. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/v3d/v3d_submit.c | 148 +-- 1 file changed, 6

Re: [PATCH 05/12] drm/v3d: Validate passed in drm syncobj handles in the performance extension

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin If userspace provides an unknown or invalid handle anywhere in the handle array the rest of the driver will not handle that well. Fix it by checking handle was looked up successfuly or otherwise fail the extension by jumping into the

Re: [PATCH 04/12] drm/v3d: Validate passed in drm syncobj handles in the timestamp extension

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin If userspace provides an unknown or invalid handle anywhere in the handle array the rest of the driver will not handle that well. Fix it by checking handle was looked up successfuly or otherwise fail the I believe you mean "Fix it

[PATCH 3/5] Revert "drm/panel-edp: Add SDC ATNA45AF01"

2024-07-10 Thread Stephan Gerhold
This reverts commit 8ebb1fc2e69ab8b89a425e402c7bd85e053b7b01. The panel should be handled through the samsung-atna33xc20 driver for correct power up timings. Otherwise the backlight does not work correctly. We have existing users of this panel through the generic "edp-panel" compatible (e.g. the

[PATCH 5/5] arm64: defconfig: Add CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20

2024-07-10 Thread Stephan Gerhold
This is needed for the display panel to work on the Qualcomm sc7180-trogdor-homestar and x1e80100-crd. Signed-off-by: Stephan Gerhold --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5c9fcf9ad39

[PATCH 4/5] arm64: dts: qcom: x1e80100-crd: Fix backlight

2024-07-10 Thread Stephan Gerhold
The backlight does not work correctly with the current display panel configuration: It works after boot, but once the display gets disabled it is not possible to get it back on. It turns out that the ATNA45AF01 panel needs exactly the same non-standard power sequence as implemented by the panel-sam

[PATCH 1/5] dt-bindings: display: panel: samsung,atna33xc20: Document ATNA45AF01

2024-07-10 Thread Stephan Gerhold
The Samsung ATNA45AF01 panel is an AMOLED eDP panel that has backlight control over the DP AUX channel. While it works almost correctly with the generic "edp-panel" compatible, the backlight needs special handling to work correctly. It is similar to the existing ATNA33XC20 panel, just with a larger

[PATCH 2/5] drm/panel: samsung-atna33xc20: Add compatible for ATNA45AF01

2024-07-10 Thread Stephan Gerhold
The Samsung ATNA45AF01 panel needs exactly the same non-standard power sequence as the Samsung ATNA33XC20 panel for backlight to work properly. Add the new "samsung,atna45af01" compatible to the driver to make it handle these panels as well. While ATNA45AF01 would also work with "samsung,atna33xc2

[PATCH 0/5] drm/panel: atna33xc20: Fix the Samsung ATNA45AF01 panel

2024-07-10 Thread Stephan Gerhold
hanged, 22 insertions(+), 5 deletions(-) --- base-commit: 523b23f0bee3014a7a752c9bb9f5c54f0eddae88 change-id: 20240710-x1e80100-crd-backlight-632f9bf936ef Best regards, -- Stephan Gerhold

Re: [PATCH 03/12] drm/v3d: Fix potential memory leak in the performance extension

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin If fetching of userspace memory fails during the main loop, all drm sync objs looked up until that point will be leaked because of the missing drm_syncobj_put. Fix it by exporting and using a common cleanup helper. Signed-off-by: Tv

Re: [PATCH 02/12] drm/v3d: Fix potential memory leak in the timestamp extension

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin If fetching of userspace memory fails during the main loop, all drm sync objs looked up until that point will be leaked because of the missing drm_syncobj_put. Fix it by exporting and using a common cleanup helper. Signed-off-by: Tv

Re: [PATCH net-next v16 05/13] page_pool: devmem support

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 00:17:38 + Mina Almasry wrote: > @@ -68,17 +107,103 @@ static inline netmem_ref page_to_netmem(struct page > *page) > > static inline int netmem_ref_count(netmem_ref netmem) > { > + /* The non-pp refcount of net_iov is always 1. On net_iov, we only > + * suppor

Re: [PATCH 01/12] drm/v3d: Prevent out of bounds access in performance query extensions

2024-07-10 Thread Maíra Canal
On 7/10/24 10:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Check that the number of perfmons userspace is passing in the copy and reset extensions is not greater than the internal kernel storage where the ids will be copied into. Signed-off-by: Tvrtko Ursulin Reviewed-by: Maíra Canal Be

Re: [PATCH net-next v16 04/13] netdev: netdevice devmem allocator

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 00:17:37 + Mina Almasry wrote: > + net_devmem_dmabuf_binding_get(binding); Why does every iov need to hold a ref? pp holds a ref and does its own accounting, so it won't disappear unless all the pages are returned.

Re: [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-10 Thread T.J. Mercier
On Wed, Jul 10, 2024 at 8:08 AM Lei Liu wrote: > > > on 2024/7/10 22:48, Christian König wrote: > > Am 10.07.24 um 16:35 schrieb Lei Liu: > >> > >> on 2024/7/10 22:14, Christian König wrote: > >>> Am 10.07.24 um 15:57 schrieb Lei Liu: > Use vm_insert_page to establish a mapping for the memory

Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml

2024-07-10 Thread Jassi Brar
On Wed, Jul 10, 2024 at 9:28 AM Jassi Brar wrote: > > On Sun, May 26, 2024 at 10:04 AM Jason-JH Lin (林睿祥) > wrote: > > > > Hi Angelo, Jassi, > > > > Could you help me apply this series? > > Thanks! > > > Please get it reviewed by DT maintainers Rob or Krzysztof. > I see Conor Dooley listed a

Re: [PATCH net-next v16 03/13] netdev: support binding dma-buf to netdevice

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 00:17:36 + Mina Almasry wrote: > + err = gen_pool_add_owner(binding->chunk_pool, dma_addr, > + dma_addr, len, dev_to_node(&dev->dev), > + owner); > + if (err) { kfree(o

Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing

2024-07-10 Thread Doug Anderson
Hi, On Thu, Jul 4, 2024 at 1:56 AM Zhaoxiong Lv wrote: > > Elan-ekth6a12nay requires reset to pull down time greater than 10ms, > so the configuration post_power_delay_ms is 10, and the chipset > initial time is required to be greater than 300ms, > so the post_gpio_reset_on_delay_ms is set to 300

Re: [PATCH net-next v16 02/13] net: netdev netlink api to bind dma-buf to a net device

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 00:17:35 + Mina Almasry wrote: > API takes the dma-buf fd as input, and binds it to the netdevice. The > user can specify the rx queues to bind the dma-buf to. > > Suggested-by: Stanislav Fomichev > Signed-off-by: Mina Almasry Reviewed-by: Jakub Kicinski

Re: [PATCH net-next v16 01/13] netdev: add netdev_rx_queue_restart()

2024-07-10 Thread Jakub Kicinski
On Wed, 10 Jul 2024 00:17:34 + Mina Almasry wrote: > + DEBUG_NET_WARN_ON_ONCE(!rtnl_is_locked()); ASSERT_RTNL() ?

Re: [PATCH v4 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-07-10 Thread Rob Herring (Arm)
On Mon, 08 Jul 2024 17:01:13 +0200, Marek Vasut wrote: > Document default DP port preemphasis configurable via new DT property > "toshiba,pre-emphasis". This is useful in case the DP link properties > are known and starting link training from preemphasis setting of 0 dB > is not useful. The preem

RE: [PATCH] drm/i915/gt: Do not consider preemption during execlists_dequeue for gen8

2024-07-10 Thread Gote, Nitin R
> -Original Message- > From: Tvrtko Ursulin > Sent: Wednesday, July 10, 2024 4:22 PM > To: Gote, Nitin R ; intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shyti, Andi ; > chris.p.wil...@linux.intel.com; Das, Nirmoy ; > janusz.krzyszto...@linux.intel.com; sta...@vge

Re: [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-10 Thread Christian König
Am 10.07.24 um 16:35 schrieb Lei Liu: 在 2024/7/10 22:14, Christian König 写道: Am 10.07.24 um 15:57 schrieb Lei Liu: Use vm_insert_page to establish a mapping for the memory allocated by dmabuf, thus supporting direct I/O read and write; and fix the issue of incorrect memory statistics after map

Re: [PATCH v2 1/3] drm/mgag200: Only set VIDRST bits in CRTC modesetting

2024-07-10 Thread Thomas Zimmermann
Hi Am 10.07.24 um 16:25 schrieb Jocelyn Falempe: +    if (set_vidrst)   crtcext1 |= MGAREG_CRTCEXT1_VRSTEN |   MGAREG_CRTCEXT1_HRSTEN; +    else +    crtcext1 &= ~(MGAREG_CRTCEXT1_VRSTEN | MGAREG_CRTCEXT1_HRSTEN); The else case is useless, as crtcext1 has already

Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml

2024-07-10 Thread Jassi Brar
On Sun, May 26, 2024 at 10:04 AM Jason-JH Lin (林睿祥) wrote: > > Hi Angelo, Jassi, > > Could you help me apply this series? > Thanks! > Please get it reviewed by DT maintainers Rob or Krzysztof. -Jassi

Re: [PATCH v2 3/3] drm/mgag200: Rename BMC vidrst names

2024-07-10 Thread Jocelyn Falempe
On 10/07/2024 10:42, Thomas Zimmermann wrote: The BMC's scanout synchronization is only indirectly related to the VIDRST functionality. Do some renaming. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_bmc

Re: [PATCH v2 1/3] drm/mgag200: Only set VIDRST bits in CRTC modesetting

2024-07-10 Thread Jocelyn Falempe
On 10/07/2024 10:42, Thomas Zimmermann wrote: The VRSTEN and HRSTEN bits control whether a CRTC synchronizes its display signal with an external source on the VIDRST pin. The G200WB and G200EW3 models synchronize with a BMC chip, but different external video encoders, such as the Matrox Maven,

Re: [PATCH v2 2/3] drm/mgag200: Remove vidrst callbacks from struct mgag200_device_funcs

2024-07-10 Thread Jocelyn Falempe
On 10/07/2024 10:42, Thomas Zimmermann wrote: The callbacks disable_vidrst and enable_vidrst are obsolete. Remove the fields from struct mgag200_device_funcs. Instead call their implementations directly of the field 'has_vidrst' has been set in struct mgag200_device_info. Also change the logi

Re: [PATCH] drm/rockchip: cdn-dp: Remove redundant workarounds for firmware loading

2024-07-10 Thread Dragan Simic
Hello Maxime, On 2024-07-10 09:13, Maxime Ripard wrote: On Tue, Jul 09, 2024 at 06:36:08PM GMT, Dragan Simic wrote: > > > > As I already wrote earlier, and as the above-linked discussions > > > > conclude, solving these issues doesn't belong to any specific driver. > > > > It should be resolved

Re: [PATCH 0/2] Support direct I/O read and write for memory allocated by dmabuf

2024-07-10 Thread Christian König
Am 10.07.24 um 15:57 schrieb Lei Liu: Use vm_insert_page to establish a mapping for the memory allocated by dmabuf, thus supporting direct I/O read and write; and fix the issue of incorrect memory statistics after mapping dmabuf memory. Well big NAK to that! Direct I/O is intentionally disabled

Re: [PATCH] bcachefs: no console_lock in bch2_print_string_as_lines

2024-07-10 Thread John Ogness
On 2024-07-10, Daniel Vetter wrote: > console_lock is the outermost subsystem lock for a lot of subsystems, > which means get/put_user must nest within. Which means it cannot be > acquired somewhere deeply nested in other locks, and most definitely > not while holding fs locks potentially needed t

[PATCH v3 3/4] drm/panic: Simplify logo handling

2024-07-10 Thread Jocelyn Falempe
Move logo rectangle initialisation, and logo drawing in separate functions, so they can be re-used by different panic screens. It prepares the introduction of the QR code panic screen. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 57 + 1 fi

Re: [PATCH] bcachefs: no console_lock in bch2_print_string_as_lines

2024-07-10 Thread John Ogness
On 2024-07-10, Daniel Vetter wrote: > console_lock is the outermost subsystem lock for a lot of subsystems, > which means get/put_user must nest within. Which means it cannot be > acquired somewhere deeply nested in other locks, and most definitely > not while holding fs locks potentially needed t

[PATCH v3 4/4] drm/panic: Add a QR code panic screen

2024-07-10 Thread Jocelyn Falempe
This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical segment, and appended to the URL as a URL parameter. This allows to save space, and put about ~7500 bytes

[PATCH v3 2/4] drm/rect: Add drm_rect_overlap()

2024-07-10 Thread Jocelyn Falempe
Check if two rectangles overlap. It's a bit similar to drm_rect_intersect() but this won't modify the rectangle. Simplifies a bit drm_panic. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_panic.c | 3 +-- include/drm/drm_rect.h | 15 +++ 2 files changed, 16 insertions(+

[PATCH v3 1/4] drm/panic: Add integer scaling to blit()

2024-07-10 Thread Jocelyn Falempe
Add a parameter to the blit function, to upscale the image. This is necessary to draw a QR code, otherwise, the pixels are usually too small to be readable by most QR code reader. It can also be used later for drawing fonts on high DPI display. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/

[PATCH v3 0/4] drm/panic: Add a QR code panic screen

2024-07-10 Thread Jocelyn Falempe
This series adds a new panic screen, with the kmsg data embedded in a QR code. The main advantage of QR code, is that you can copy/paste the debug data to a bug report. The QR code encoder is written in rust, and is very specific to drm panic. The reason is that it is called in a panic handler,

Re: [PATCH v3 3/5] dt-bindings: display: st7701: Add Anbernic RG28XX panel

2024-07-10 Thread Conor Dooley
On Sat, Jul 06, 2024 at 07:23:34PM +0900, Hironori KIKUCHI wrote: > The RG28XX panel is a display panel of the Anbernic RG28XX, a handheld > gaming device from Anbernic. It is 2.8 inches in size (diagonally) with > a resolution of 480x640. > > This panel is driven by a variant of the ST7701 driver

Re: [PATCH 1/2] dt-bindings: display: panel: document BOE TV101WUM-LL2 DSI Display Panel

2024-07-10 Thread Conor Dooley
On Tue, Jul 09, 2024 at 03:05:44PM +0200, Neil Armstrong wrote: > Document the 1200x1920 BOE TV101WUM-LL2 DSI Display Panel found > in the Lenovo Smart Tab M10 tablet. The controller is unknown. > > Signed-off-by: Neil Armstrong Reviewed-by: Conor Dooley signature.asc Description: PGP signatu

  1   2   >