Re: [PATCH v2 3/8] drm/tegra: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-26 Thread Thierry Reding
On Thu Jun 13, 2024 at 12:23 AM CEST, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-26 Thread Christian König
Am 27.06.24 um 05:21 schrieb Jason-JH Lin (林睿祥): On Wed, 2024-06-26 at 19:56 +0200, Daniel Vetter wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Wed, Jun 26, 2024 at 12:49:02PM +0200, Christian König wrote:

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-26 Thread Christian König
Am 27.06.24 um 05:17 schrieb Jason-JH Lin (林睿祥): On Wed, 2024-06-26 at 12:49 +0200, Christian König wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > Am 26.06.24 um 10:05 schrieb Jason-JH Lin (林睿祥): > > > > > > >

Re: [PATCH RESEND] drm: bridge: dw-mipi-dsi: Allow sync-pulses to override the burst vid-mode

2024-06-26 Thread Liu Ying
Hi Heiko, On 06/26/2024, Heiko Stuebner wrote: > From: Heiko Stuebner > > The state right now is that if the panel has the burst-mode flag it > will take precedence over the sync-pulses mode. Yes. > > While sync-pulses are only relevant for the video-mode, the burst-mode > flag affects both t

[PATCH v2] drm/gma500: fix null pointer dereference in cdv_intel_lvds_get_modes

2024-06-26 Thread Ma Ke
In cdv_intel_lvds_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Fixes: 6a227d5fd6c4 ("gma500: Add support for Cedarview") Signed-off-b

[PATCH 4/4] drm/vmwgfx: Add basic support for external buffers

2024-06-26 Thread Zack Rusin
Make vmwgfx go through the dma-buf interface to map/unmap imported buffers. The driver used to try to directly manipulate external buffers, assuming that everything that was coming to it had to live in cpu accessible memory. While technically true because what's in the vms is controlled by us, it's

[PATCH 2/4] drm/vmwgfx: Make sure the screen surface is ref counted

2024-06-26 Thread Zack Rusin
Fix races issues in virtual crc generation by making sure the surface the code uses for crc computation is properly ref counted. Crc generation was trying to be too clever by allowing the surfaces to go in and out of scope, with the hope of always having some kind of screen present. That's not alw

[PATCH 3/4] drm/vmwgfx: Fix handling of dumb buffers

2024-06-26 Thread Zack Rusin
Dumb buffers can be used in kms but also through prime with gallium's resource_from_handle. In the second case the dumb buffers can be rendered by the GPU where with the regular DRM kms interfaces they are mapped and written to by the CPU. Because the same buffer can be written to by the GPU and CP

[PATCH 1/4] drm/vmwgfx: Fix a deadlock in dma buf fence polling

2024-06-26 Thread Zack Rusin
Introduce a version of the fence ops that on release doesn't remove the fence from the pending list, and thus doesn't require a lock to fix poll->fence wait->fence unref deadlocks. vmwgfx overwrites the wait callback to iterate over the list of all fences and update their status, to do that it hol

[PATCH 0/4] Fix various buffer mapping/import issues

2024-06-26 Thread Zack Rusin
This small series fixes all known prime/dumb_buffer/buffer dirty tracking issues. Fixing of dumb-buffers turned out to be a lot more complex than I wanted it to be. There's not much that can be done there because the driver has to support old userspace (our Xorg driver expects those to not be gem b

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-06-26 Thread Chen-Yu Tsai
On Thu, Jun 27, 2024 at 9:23 AM Pafford, Robert J. wrote: > > Frank Oltmanns writes: > > > Hi Robert, > > > > 26.06.2024 18:03:24 Pafford, Robert J. : > > > >> Hi Frank, > >> > >> Moving to a new for loop makes sense. Let me know when you have a patch > > > > The patch is here, strange you didn't

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-26 Thread 林睿祥

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-26 Thread 林睿祥

[PATCH v2] drm/gma500: fix null pointer dereference in psb_intel_lvds_get_modes

2024-06-26 Thread Ma Ke
In psb_intel_lvds_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Cc: sta...@vger.kernel.org Fixes: 89c78134cc54 ("gma500: Add Poulsbo support") Signed-of

[PATCH v2] drm/nouveau: fix null pointer dereference in nouveau_connector_get_modes

2024-06-26 Thread Ma Ke
In nouveau_connector_get_modes(), the return value of drm_mode_duplicate() is assigned to mode, which will lead to a possible NULL pointer dereference on failure of drm_mode_duplicate(). Add a check to avoid npd. Fixes: 6ee738610f41 ("drm/nouveau: Add DRM driver for NVIDIA GPUs") Signed-off-by: Ma

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-06-26 Thread Pafford, Robert J.
Frank Oltmanns writes: > Hi Robert, > > 26.06.2024 18:03:24 Pafford, Robert J. : > >> Hi Frank, >> >> Moving to a new for loop makes sense. Let me know when you have a patch > > The patch is here, strange you didn't receive it: > https://lore.kernel.org/all/20240623-sunxi-ng_fix_common_probe-v1-1

Re: [PATCH net-next v14 13/13] selftests: add ncdevmem, netcat for devmem TCP

2024-06-26 Thread Jakub Kicinski
On Wed, 26 Jun 2024 15:08:22 -0700 Jakub Kicinski wrote: > On Tue, 25 Jun 2024 19:54:01 + Mina Almasry wrote: > > +CFLAGS += -I../../../net/ynl/generated/ > > +CFLAGS += -I../../../net/ynl/lib/ > > + > > +LDLIBS += ../../../net/ynl/lib/ynl.a ../../../net/ynl/generated/protos.a > > Not as eas

Re: [PATCH v13 09/13] Documentation: core-api: Add math.h macros and functions

2024-06-26 Thread Randy Dunlap
On 6/7/24 6:31 AM, Devarsh Thakkar wrote: > Add documentation for rounding, scaling, absolute value and 32-bit division > related macros and functions exported by math.h header file. > > Signed-off-by: Devarsh Thakkar > Reviewed-by: Andy Shevchenko Reviewed-by: Randy Dunlap Tested-by: Randy

[PATCH 6/6] drm/bridge: imx8qxp-ldb: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the __m

[PATCH 5/6] drm/bridge: dw-hdmi-cec: Switch to SYSTEM_SLEEP_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() alternative. The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows r

[PATCH 4/6] drm/bridge: samsung-dsim: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the __m

[PATCH 3/6] drm/bridge: imx8qxp-pixel-combiner: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the __m

[PATCH 2/6] drm/bridge: imx8qm-ldb: Switch to RUNTIME_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_RUNTIME_PM_OPS with its modern RUNTIME_PM_OPS() alternative. The combined usage of pm_ptr() and RUNTIME_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows removing the __m

[PATCH 1/6] drm/bridge: imx8mp-hdmi-tx: Switch to SYSTEM_SLEEP_PM_OPS()

2024-06-26 Thread Fabio Estevam
From: Fabio Estevam Replace SET_SYSTEM_SLEEP_PM_OPS with its modern SYSTEM_SLEEP_PM_OPS() alternative. The combined usage of pm_ptr() and SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code. This allows r

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Konrad Dybcio
On 27.06.2024 12:32 AM, Rob Clark wrote: > On Wed, Jun 26, 2024 at 2:38 PM Konrad Dybcio > wrote: >> >> On 26.06.2024 8:43 PM, Rob Clark wrote: >>> On Wed, Jun 26, 2024 at 1:24 AM Akhil P Oommen >>> wrote: On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: > >

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Rob Clark
On Wed, Jun 26, 2024 at 2:38 PM Konrad Dybcio wrote: > > On 26.06.2024 8:43 PM, Rob Clark wrote: > > On Wed, Jun 26, 2024 at 1:24 AM Akhil P Oommen > > wrote: > >> > >> On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: > >>> > >>> > >>> On 6/23/24 13:06, Akhil P Oommen wrote: >

[PULL] drm-xe-next

2024-06-26 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our likely last pull-request towards 6.11. If some last minute thing shows up a small one might come next Tuesday. Thanks, Rodrigo. drm-xe-next-2024-06-26: UAPI Changes: - New uapi adding OA functionality to Xe (Ashutosh) Cross-subsystem Changes: - devcoredump: Add

[pull] amdgpu drm-fixes-6.10

2024-06-26 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.10. The following changes since commit f2661062f16b2de5d7b6a5c42a9a5c96326b8454: Linux 6.10-rc5 (2024-06-23 17:08:54 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.10-2024-06-26 for you to fetc

Re: [PATCH net-next v14 13/13] selftests: add ncdevmem, netcat for devmem TCP

2024-06-26 Thread Jakub Kicinski
On Tue, 25 Jun 2024 19:54:01 + Mina Almasry wrote: > +CFLAGS += -I../../../net/ynl/generated/ > +CFLAGS += -I../../../net/ynl/lib/ > + > +LDLIBS += ../../../net/ynl/lib/ynl.a ../../../net/ynl/generated/protos.a Not as easy as this.. Please add this commit to your series: https://github.com/kub

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-26 Thread Dmitry Baryshkov
On Thu, Jun 27, 2024 at 03:22:18AM GMT, Akhil P Oommen wrote: > << snip >> > > > > > > > > @@ -1503,7 +1497,7 @@ static void __iomem > > > > > > > *a6xx_gmu_get_mmio(struct platform_device *pdev, > > > > > > > return ERR_PTR(-EINVAL); > > > > > > > } > > > > > > > > > > >

Re: [PATCH] drm/msm/a6xx: request memory region

2024-06-26 Thread Akhil P Oommen
<< snip >> > > > > > > @@ -1503,7 +1497,7 @@ static void __iomem *a6xx_gmu_get_mmio(struct > > > > > > platform_device *pdev, > > > > > > return ERR_PTR(-EINVAL); > > > > > > } > > > > > > > > > > > > - ret = ioremap(res->start, resource_size(res)); > > > > > > +

[PATCH v5 11/12] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-06-26 Thread Dmitry Baryshkov
Virtual wide planes give high amount of flexibility, but it is not always enough: In parallel multirect case only the half of the usual width is supported for tiled formats. Thus the whole width of two tiled multirect rectangles can not be greater than max_linewidth, which is not enough for some p

[PATCH v5 08/12] drm/msm/dpu: split dpu_plane_atomic_check()

2024-06-26 Thread Dmitry Baryshkov
Split dpu_plane_atomic_check() function into two pieces: dpu_plane_atomic_check_nopipe() performing generic checks on the pstate, without touching the associated pipe, and dpu_plane_atomic_check_pipes(), which takes into account used pipes. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

[PATCH v5 04/12] drm/msm/dpu: use drm_rect_fp_to_int()

2024-06-26 Thread Dmitry Baryshkov
Use the drm_rect_fp_to_int() helper instead of using the hand-written code. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.

[PATCH v5 12/12] drm/msm/dpu: include SSPP allocation state into the dumped state

2024-06-26 Thread Dmitry Baryshkov
Make dpu_rm_print_state() also output the SSPP allocation state. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dp

[PATCH v5 10/12] drm/msm/dpu: add support for virtual planes

2024-06-26 Thread Dmitry Baryshkov
Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features. Properly utilizing all planes requires the attention of the compositor, who should prefer simpler planes to YUV-supporting ones. Otherwise it is very easy to end up in a situ

[PATCH v5 09/12] drm/msm/dpu: move rot90 checking to dpu_plane_atomic_check_pipe()

2024-06-26 Thread Dmitry Baryshkov
Move a call to dpu_plane_check_inline_rotation() to the dpu_plane_atomic_check_pipe() function, so that the rot90 constraints are checked for both pipes. Also move rotation field from struct dpu_plane_state to struct dpu_sw_pipe_cfg. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/d

[PATCH v5 01/12] drm/msm/dpu: limit QCM2290 to RGB formats only

2024-06-26 Thread Dmitry Baryshkov
The QCM2290 doesn't have CSC blocks, so it can not support YUV formats even on ViG blocks. Fix the formats declared by _VIG_SBLK_NOSCALE(). Fixes: 5334087ee743 ("drm/msm: add support for QCM2290 MDSS") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 4 ++-- 1

[PATCH v5 06/12] drm/msm/dpu: drop virt_formats from SSPP subblock configuration

2024-06-26 Thread Dmitry Baryshkov
The virt_formats / virt_num_formats are not used by the current driver and are not going to be used in future since formats for virtual planes are handled in a different way, by forbidding unsupported combinations during atomic_check. Drop those fields now. Reviewed-by: Abhinav Kumar Signed-off-b

[PATCH v5 02/12] drm/msm/dpu: relax YUV requirements

2024-06-26 Thread Dmitry Baryshkov
YUV formats require only CSC to be enabled. Even decimated formats should not require scaler. Relax the requirement and don't check for the scaler block while checking if YUV format can be enabled. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry Baryshkov --- driver

[PATCH v5 07/12] drm/msm/dpu: move scaling limitations out of the hw_catalog

2024-06-26 Thread Dmitry Baryshkov
Max upscale / downscale factors are constant between platforms. In preparation to adding support for virtual planes and allocating SSPP blocks on demand move max scaling factors out of the HW catalog and handle them in the dpu_plane directly. If any of the scaling blocks gets different limitations,

[PATCH v5 03/12] drm/msm/dpu: take plane rotation into account for wide planes

2024-06-26 Thread Dmitry Baryshkov
Take into account the plane rotation and flipping when calculating src positions for the wide plane parts. This is not an issue yet, because rotation is only supported for the UBWC planes and wide UBWC planes are rejected anyway because in parallel multirect case only the half of the usual width i

[PATCH v5 05/12] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

2024-06-26 Thread Dmitry Baryshkov
In preparation for virtualized planes support, move pstate->pipe initialization from dpu_plane_reset() to dpu_plane_atomic_check(). In case of virtual planes the plane's pipe will not be known up to the point of atomic_check() callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dis

[PATCH v5 00/12] drm/msm/dpu: support virtual wide planes

2024-06-26 Thread Dmitry Baryshkov
rtions(+), 145 deletions(-) --- base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed change-id: 20240626-dpu-virtual-wide-beefb746a900 Best regards, -- Dmitry Baryshkov

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-26 Thread Konrad Dybcio
On 26.06.2024 11:04 PM, Akhil P Oommen wrote: > On Mon, Jun 24, 2024 at 03:57:35PM +0200, Konrad Dybcio wrote: >> >> >> On 6/23/24 13:06, Akhil P Oommen wrote: >>> Add the necessary dt nodes for gpu support in X1E80100. >>> >>> Signed-off-by: Akhil P Oommen >>> --- >> >> [...] >> >>> + >>> +

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Konrad Dybcio
On 26.06.2024 8:43 PM, Rob Clark wrote: > On Wed, Jun 26, 2024 at 1:24 AM Akhil P Oommen > wrote: >> >> On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: >>> >>> >>> On 6/23/24 13:06, Akhil P Oommen wrote: Add support in drm/msm driver for the Adreno X185 gpu found in Snapd

Re: [PATCH v2 1/2] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-26 Thread Akhil P Oommen
On Wed, Jun 26, 2024 at 09:59:39AM +0200, Daniel Vetter wrote: > On Tue, Jun 25, 2024 at 08:54:41PM +0200, Konrad Dybcio wrote: > > Memory barriers help ensure instruction ordering, NOT time and order > > of actual write arrival at other observers (e.g. memory-mapped IP). > > On architectures emplo

Re: [PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Nirmoy Das
Hi Rodrigo, On 6/26/2024 5:50 PM, Rodrigo Vivi wrote: On Wed, Jun 26, 2024 at 05:36:43PM +0200, Nirmoy Das wrote: Hi Rodrigo, On 6/26/2024 5:24 PM, Rodrigo Vivi wrote:

[syzbot] [dri?] WARNING in drm_mode_create_lease_ioctl

2024-06-26 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ac2193b4b460 Merge branches 'for-next/misc', 'for-next/kse.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci console output: https://syzkaller.appspot.com/x/log.txt?x=101cc88298 kernel conf

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 03:57:35PM +0200, Konrad Dybcio wrote: > > > On 6/23/24 13:06, Akhil P Oommen wrote: > > Add the necessary dt nodes for gpu support in X1E80100. > > > > Signed-off-by: Akhil P Oommen > > --- > > [...] > > > + > > + opp-11 { > > +

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Rob Clark
On Wed, Jun 26, 2024 at 1:49 PM Akhil P Oommen wrote: > > On Mon, Jun 24, 2024 at 07:28:06AM -0700, Rob Clark wrote: > > On Mon, Jun 24, 2024 at 7:25 AM Rob Clark wrote: > > > > > > On Sun, Jun 23, 2024 at 4:08 AM Akhil P Oommen > > > wrote: > > > > > > > > Add support in drm/msm driver for the

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 12:23:42AM +0300, Dmitry Baryshkov wrote: > On Sun, Jun 23, 2024 at 04:36:30PM GMT, Akhil P Oommen wrote: > > Add the necessary dt nodes for gpu support in X1E80100. > > > > Signed-off-by: Akhil P Oommen > > --- > > > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 195 ++

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Wed, Jun 26, 2024 at 11:43:08AM -0700, Rob Clark wrote: > On Wed, Jun 26, 2024 at 1:24 AM Akhil P Oommen > wrote: > > > > On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: > > > > > > > > > On 6/23/24 13:06, Akhil P Oommen wrote: > > > > Add support in drm/msm driver for the Adren

Re: [PATCH v2 2/2] drm/panel: add Ilitek ILI9806E panel driver

2024-06-26 Thread Jessica Zhang
On 6/26/2024 7:44 AM, Michael Walle wrote: The Ortustech COM35H3P70ULC panel is based on the ILI9806E DSI display controller. Co-developed-by: Gunnar Dibbern Signed-off-by: Gunnar Dibbern Signed-off-by: Michael Walle Reviewed-by: Jessica Zhang --- MAINTAINERS

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Akhil P Oommen
On Mon, Jun 24, 2024 at 07:28:06AM -0700, Rob Clark wrote: > On Mon, Jun 24, 2024 at 7:25 AM Rob Clark wrote: > > > > On Sun, Jun 23, 2024 at 4:08 AM Akhil P Oommen > > wrote: > > > > > > Add support in drm/msm driver for the Adreno X185 gpu found in > > > Snapdragon X1 Elite chipset. > > > > >

[PATCH v5 2/2] drm/msm: Extend gpu devcore dumps with pgtbl info

2024-06-26 Thread Rob Clark
From: Rob Clark In the case of iova fault triggered devcore dumps, include additional debug information based on what we think is the current page tables, including the TTBR0 value (which should match what we have in adreno_smmu_fault_info unless things have gone horribly wrong), and the pagetabl

[PATCH v5 0/2] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-06-26 Thread Rob Clark
From: Rob Clark This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. This is a respin of https://patchwork.freedes

[PATCH] drm/amd/display: Add null check before access structs

2024-06-26 Thread Ma Ke
In enable_phantom_plane, we should better check null pointer before accessing various structs. Fixes: 09a4ec5da92c ("drm/amd/display: Refactor dc_state interface") Signed-off-by: Ma Ke --- drivers/gpu/drm/amd/display/dc/dml2/dml2_mall_phantom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-06-26 Thread Pafford, Robert J.
Hi Frank, Moving to a new for loop makes sense. Let me know when you have a patch and I'll be glad to test it on my board. I do also wonder if this may have contributed to some of the HDMI issues seen in the other thread. Best, Robert > Hi Robert, > > I'm truly sorry for the trouble the patch ha

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Stone
On Wed, 26 Jun 2024 at 18:52, Daniel Vetter wrote: > On Wed, Jun 26, 2024 at 11:39:01AM +0100, Daniel Stone wrote: > > On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > > > So we are kind of stuck here between breaking one or the other use- > > > case. I'm leaning heavily into the direction of j

RE: [PATCH v16 0/9] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios

2024-06-26 Thread Kasireddy, Vivek
Hi Andrew, > Subject: [PATCH v16 0/9] mm/gup: Introduce memfd_pin_folios() for pinning > memfd folios > > Currently, some drivers (e.g, Udmabuf) that want to longterm-pin > the pages/folios associated with a memfd, do so by simply taking a > reference on them. This is not desirable because the pa

Re: [PATCH] drm/amd/display: Add null check before access structs

2024-06-26 Thread Markus Elfring
> > In enable_phantom_plane, we should better check null pointer before > > accessing various structs. > > Thanks for the fix, I'll apply this. Do you care for better commit messages and summary phrases? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/

Re: [PATCH RFC 3/5] drm/connector: implement generic HDMI codec helpers

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 06:07:50PM GMT, Dave Stevenson wrote: > Hi Dmitry > > On Wed, 26 Jun 2024 at 17:11, Dmitry Baryshkov > wrote: > > > > On Wed, Jun 26, 2024 at 04:10:05PM GMT, Dave Stevenson wrote: > > > Hi Maxime and Dmitry > > > > > > On Wed, 26 Jun 2024 at 15:05, Maxime Ripard wrote: >

Re: [PATCH v4 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-06-26 Thread Rob Clark
On Mon, Jun 24, 2024 at 8:14 AM Will Deacon wrote: > > On Thu, May 23, 2024 at 10:52:21AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Add an io-pgtable method to walk the pgtable returning the raw PTEs that > > would be traversed for a given iova access. > > > > Signed-off-by: Rob Clark

[rerere PATCH] nightly.conf: Merge drm-msm trees into drm-tip

2024-06-26 Thread Dmitry Baryshkov
In order to improve testing of drm/msm branches, add drm-msm trees to the list of the trees to be merged into drm-tip. Cc: Rob Clark Signed-off-by: Dmitry Baryshkov --- nightly.conf | 8 1 file changed, 8 insertions(+) diff --git a/nightly.conf b/nightly.conf index 49abf3fb2a72..f2e18

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-26 Thread Rob Clark
On Wed, Jun 26, 2024 at 1:24 AM Akhil P Oommen wrote: > > On Mon, Jun 24, 2024 at 03:53:48PM +0200, Konrad Dybcio wrote: > > > > > > On 6/23/24 13:06, Akhil P Oommen wrote: > > > Add support in drm/msm driver for the Adreno X185 gpu found in > > > Snapdragon X1 Elite chipset. > > > > > > Signed-of

Re: [PATCH] drm/ast: Inline drm_simple_encoder_init()

2024-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 11:01:11AM +0200, Thomas Zimmermann wrote: > Hi > > Am 26.06.24 um 06:34 schrieb Dmitry Baryshkov: > > On Tue, Jun 25, 2024 at 03:18:09PM GMT, Thomas Zimmermann wrote: > > > The function drm_simple_encoder_init() is a trivial helper and > > > deprecated. Replace it with the

Re: [PATCH] drm/amd/display: Add null check before access structs

2024-06-26 Thread Aurabindo Pillai
Thanks for the fix, I'll apply this. On 6/26/24 9:06 AM, Ma Ke wrote: In enable_phantom_plane, we should better check null pointer before accessing various structs. Fixes: 09a4ec5da92c ("drm/amd/display: Refactor dc_state interface") Signed-off-by: Ma Ke --- drivers/gpu/drm/amd/display/dc/dm

Re: [PATCH v5 2/9] scatterlist: Add a flag for the restricted memory

2024-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 12:49:02PM +0200, Christian König wrote: > Am 26.06.24 um 10:05 schrieb Jason-JH Lin (林睿祥): > > > > I think I have the same problem as the ECC_FLAG mention in: > > > > > > https://lore.kernel.org/linux-media/20240515-dma-buf-ecc-heap-v1-0-54cbbd049...@kernel.org/ > > > > > >

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 11:39:01AM +0100, Daniel Stone wrote: > Hi, > > On Wed, 26 Jun 2024 at 09:28, Lucas Stach wrote: > > Mesa doesn't cope right now. Mostly because of the renderonly thing > > where we magically need to match render devices to otherwise render > > incapable KMS devices. The w

Re: [PATCH] drm/etnaviv: Create an accel device node if compute-only

2024-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 11:42:24AM +0300, Dmitry Baryshkov wrote: > On Wed, Jun 26, 2024 at 09:26:40AM GMT, Daniel Vetter wrote: > > On Thu, May 09, 2024 at 05:41:18PM +0300, Oded Gabbay wrote: > > > On Thu, May 09, 2024 at 03:53:01PM +0200, Tomeu Vizoso wrote: > > > > Oded, Dave, > > > > > > > >

Re: Time for drm-ci-next?

2024-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2024 at 11:38:30AM +0300, Dmitry Baryshkov wrote: > On Wed, Jun 26, 2024 at 09:32:44AM GMT, Daniel Vetter wrote: > > On Mon, Jun 24, 2024 at 10:25:25AM -0300, Helen Koike wrote: > > > > > > > > > On 24/06/2024 02:34, Vignesh Raman wrote: > > > > Hi, > > > > > > > > On 15/03/24 22

Re: [PATCH v2 1/2] dt-bindings: display: bridge: add TI TDP158

2024-06-26 Thread Marc Gonzalez
On 26/06/2024 18:08, Conor Dooley wrote: > On Tue, Jun 25, 2024 at 06:38:12PM +0200, Marc Gonzalez wrote: > >> The TI TDP158 is an HDMI to TMDS Redriver. >> >> Signed-off-by: Marc Gonzalez >> --- >> .../bindings/display/bridge/ti,tdp158.yaml | 48 >> ++ >> 1 file cha

Re: [PATCH RFC 3/5] drm/connector: implement generic HDMI codec helpers

2024-06-26 Thread Dave Stevenson
Hi Dmitry On Wed, 26 Jun 2024 at 17:11, Dmitry Baryshkov wrote: > > On Wed, Jun 26, 2024 at 04:10:05PM GMT, Dave Stevenson wrote: > > Hi Maxime and Dmitry > > > > On Wed, 26 Jun 2024 at 15:05, Maxime Ripard wrote: > > > > > > On Fri, Jun 21, 2024 at 02:09:04PM GMT, Dmitry Baryshkov wrote: > > >

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-06-26 Thread Frank Oltmanns
Hi Robert, 26.06.2024 18:03:24 Pafford, Robert J. : > Hi Frank, > > Moving to a new for loop makes sense. Let me know when you have a patch The patch is here, strange you didn't receive it: https://lore.kernel.org/all/20240623-sunxi-ng_fix_common_probe-v1-1-7c97e3282...@oltmanns.dev/ > and I'l

Re: [PATCH 2/2] drm/panel: simple: Add AUO G104STN01 panel entry

2024-06-26 Thread Neil Armstrong
On 26/06/2024 06:36, Paul Gerber wrote: Add support for the AUO G104STN01 10.4" (800x600) LCD-TFT panel. Signed-off-by: Paul Gerber --- Tested on TQ MBa8MPxL with TQMa8MPxL. drivers/gpu/drm/panel/panel-simple.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a

Re: [PATCH 2/2] drm/panel: simple: Add Jiangsu Smartwin SMMT043480272A-A19 panel

2024-06-26 Thread neil . armstrong
On 26/06/2024 18:17, Marco Felsch wrote: From: Rouven Czerwinski Add support for the Jiangsu Smartwin SMMT043480272A-A19 4.3" 480x272 TFT-LCD panel. The timings are based on the ILI6485 controller IC datasheet. Signed-off-by: Rouven Czerwinski Signed-off-by: Marco Felsch --- drivers/gpu/dr

Re: [PATCH v2 0/2] drm/panel: initial support for the Ortustech COM35H3P70ULC

2024-06-26 Thread Neil Armstrong
Hi, On Wed, 26 Jun 2024 16:44:31 +0200, Michael Walle wrote: > Add initial support for the 480x640 DSI panel from Ortustech. The > panel uses an Ilitek ILI9806E panel driver IC. > > v2: > - use drm_connector_helper_get_modes_fixed(), thanks Dmitry. > - slight header files cleanup > > [...] Th

Re: [PATCH v2 0/3] drm: panel: add support lincolntech LCD197 panel

2024-06-26 Thread Neil Armstrong
Hi, On Wed, 26 Jun 2024 16:22:06 +0200, Jerome Brunet wrote: > This patchset adds support for the Lincolntech LCD197 1080x1920 DSI panel. > > Changes since v1 [1]: > * Rebased on drm-misc-next > * Drop vendor prefix change (lincolntech recently added) > * Use mipi_dsi_dcs_*multi() > * Drop th

Re: [PATCH] drm/panel: sitronix-st7703: transition to mipi_dsi wrapped functions

2024-06-26 Thread Neil Armstrong
Hi, On Wed, 26 Jun 2024 10:22:41 +0530, Tejas Vipin wrote: > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: > Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for > sitronix-st7703 based panels. > >

Re: [PATCH v2 2/2] drm/panel: add Ilitek ILI9806E panel driver

2024-06-26 Thread Neil Armstrong
On 26/06/2024 16:44, Michael Walle wrote: The Ortustech COM35H3P70ULC panel is based on the ILI9806E DSI display controller. Co-developed-by: Gunnar Dibbern Signed-off-by: Gunnar Dibbern Signed-off-by: Michael Walle --- MAINTAINERS | 5 + drivers/gpu/drm

Re: [PATCH v2 3/3] drm/panel: add lincolntech lcd197 support

2024-06-26 Thread Neil Armstrong
On 26/06/2024 16:22, Jerome Brunet wrote: Add support for the Lincoln Technologies LCD197 1080x1920 DSI panel. Signed-off-by: Jerome Brunet --- drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu/drm/panel/panel-lincolntech-l

Re: [PATCH v2 2/3] drm/mipi-dsi: add mipi_dsi_usleep_range helper

2024-06-26 Thread Neil Armstrong
On 26/06/2024 16:22, Jerome Brunet wrote: Like for mipi_dsi_msleep(), usleep_range() may often be called in between mipi_dsi_dcs_*() functions and needs a multi compatible counter part. Suggested-by: Dmitry Baryshkov Signed-off-by: Jerome Brunet --- include/drm/drm_mipi_dsi.h | 7 +++ 1

Re: [PATCH] drm/panel: sitronix-st7703: transition to mipi_dsi wrapped functions

2024-06-26 Thread neil . armstrong
On 26/06/2024 06:52, Tejas Vipin wrote: Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe ("drm/mipi-dsi: wrap more functions for streamline handling") for sitronix-st7703 based panels. Signed-off-by: Tejas Vipin ---

Re: [PATCH] drm/amd/display: Add null check before access structs

2024-06-26 Thread Markus Elfring
> In enable_phantom_plane, we should better check null pointer before > accessing various structs. 1. Can a wording approach (like the following) be a better change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst

Re: [PATCH] printk: Add a short description string to kmsg_dump()

2024-06-26 Thread Kees Cook
On Tue, Jun 25, 2024 at 02:39:29PM +0200, Jocelyn Falempe wrote: > kmsg_dump doesn't forward the panic reason string to the kmsg_dumper > callback. > This patch adds a new parameter "const char *desc" to the kmsg_dumper > dump() callback, and update all drivers that are using it. > > To avoid upda

Re: [PATCH v2 2/2] drm/bridge: add support for TI TDP158

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 05:26:10PM GMT, Marc Gonzalez wrote: > On 26/06/2024 06:47, Dmitry Baryshkov wrote: > > > On Tue, Jun 25, 2024 at 06:38:13PM GMT, Marc Gonzalez wrote: > > > >> The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting > >> DVI 1.0 and HDMI 1.4b and 2.0b output

Re: [PATCH 1/3] drm/dp_mst: Fix all mstb marked as not probed after suspend/resume

2024-06-26 Thread Lyude Paul
Thanks! Reviewed-by: Lyude Paul On Wed, 2024-06-26 at 16:48 +0800, Wayne Lin wrote: > [Why] > After supend/resume, with topology unchanged, observe that > link_address_sent of all mstb are marked as false even the topology > probing > is done without any error. > > It is caused by wrongly also

Re: [PATCH 2/3] drm/dp_mst: Skip CSN if topology probing is not done yet

2024-06-26 Thread Lyude Paul
Some comments down below: On Wed, 2024-06-26 at 16:48 +0800, Wayne Lin wrote: > [Why] > During resume, observe that we receive CSN event before we start > topology > probing. Handling CSN at this moment based on uncertain topology is > unnecessary. > > [How] > Add checking condition in drm_dp_mst

[PATCH 1/2] dt-bindings: display: simple: Add Jiangsu Smartwin SMMT043480272A-A19

2024-06-26 Thread Marco Felsch
Add compatible to panel-simple for Jiangsu Smartwin Electronics SMMT043480272A-A19 4.3" 480x272 LCD-TFT panel. Signed-off-by: Marco Felsch --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/d

[PATCH 2/2] drm/panel: simple: Add Jiangsu Smartwin SMMT043480272A-A19 panel

2024-06-26 Thread Marco Felsch
From: Rouven Czerwinski Add support for the Jiangsu Smartwin SMMT043480272A-A19 4.3" 480x272 TFT-LCD panel. The timings are based on the ILI6485 controller IC datasheet. Signed-off-by: Rouven Czerwinski Signed-off-by: Marco Felsch --- drivers/gpu/drm/panel/panel-simple.c | 32

Re: [PATCH RFC 3/5] drm/connector: implement generic HDMI codec helpers

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 04:10:05PM GMT, Dave Stevenson wrote: > Hi Maxime and Dmitry > > On Wed, 26 Jun 2024 at 15:05, Maxime Ripard wrote: > > > > On Fri, Jun 21, 2024 at 02:09:04PM GMT, Dmitry Baryshkov wrote: > > > On Fri, 21 Jun 2024 at 12:27, Maxime Ripard wrote: > > > > > > > > Hi, > > > >

Re: [PATCH RFC 3/5] drm/connector: implement generic HDMI codec helpers

2024-06-26 Thread Dmitry Baryshkov
On Wed, Jun 26, 2024 at 04:05:01PM GMT, Maxime Ripard wrote: > On Fri, Jun 21, 2024 at 02:09:04PM GMT, Dmitry Baryshkov wrote: > > On Fri, 21 Jun 2024 at 12:27, Maxime Ripard wrote: > > > > > > Hi, > > > > > > Sorry for taking some time to review this series. > > > > No problem, that's not long.

Re: [PATCH v2 1/2] dt-bindings: display: bridge: add TI TDP158

2024-06-26 Thread Conor Dooley
On Tue, Jun 25, 2024 at 06:38:12PM +0200, Marc Gonzalez wrote: > The TI TDP158 is an HDMI to TMDS Redriver. > > Signed-off-by: Marc Gonzalez > --- > .../bindings/display/bridge/ti,tdp158.yaml | 48 > ++ > 1 file changed, 48 insertions(+) > > diff --git a/Documentati

Re: [PATCH v5] drm/display: split DSC helpers from DP helpers

2024-06-26 Thread Thomas Zimmermann
Hi Am 23.06.24 um 00:44 schrieb Dmitry Baryshkov: Currently the DRM DSC functions are selected by the DRM_DISPLAY_DP_HELPER Kconfig symbol. This is not optimal, since the DSI code (both panel and host drivers) end up selecting the seemingly irrelevant DP helpers. Split the DSC code to be guarded

Re: [PATCH v5] drm/display: split DSC helpers from DP helpers

2024-06-26 Thread Rodrigo Vivi
On Sun, Jun 23, 2024 at 01:44:19AM +0300, Dmitry Baryshkov wrote: > Currently the DRM DSC functions are selected by the > DRM_DISPLAY_DP_HELPER Kconfig symbol. This is not optimal, since the DSI > code (both panel and host drivers) end up selecting the seemingly > irrelevant DP helpers. Split the D

dma_buf_detach lockdep splat

2024-06-26 Thread Thomas Hellström
Hi! I'm seeing the below lockdep splat 1) with the xe driver in an imported dma-buf object destruction path. It's not because we hold the dma_resv lock at that point, but rather because we hold *another* dma_resv lock at that point, and the dma_resv detach happens when the object is idle, in this

Re: [PATCH] drm/mipi-dsi: Fix devm unregister & detach

2024-06-26 Thread Tomi Valkeinen
On 26/06/2024 18:07, Maxime Ripard wrote: On Wed, Jun 26, 2024 at 12:55:39PM GMT, Tomi Valkeinen wrote: On 26/06/2024 11:49, Maxime Ripard wrote: Hi, On Wed, Jun 19, 2024 at 12:07:48PM GMT, Tomi Valkeinen wrote: From: Tomi Valkeinen When a bridge driver uses devm_mipi_dsi_device_register_fu

Re: [PATCH] drm/i915/gem: Suppress oom warning in favour of ENOMEM to userspace

2024-06-26 Thread Rodrigo Vivi
On Wed, Jun 26, 2024 at 05:36:43PM +0200, Nirmoy Das wrote: >Hi Rodrigo, > > > >On 6/26/2024 5:24 PM, Rodrigo Vivi wrote:

Re: (subset) [PATCH] backlight: lm3509_bl: Fix early returns in for_each_child_of_node()

2024-06-26 Thread Lee Jones
On Mon, 24 Jun 2024 17:30:50 +0200, Javier Carrasco wrote: > The for_each_child_of_node() macro automatically decrements the child > refcount at the end of every iteration. On early exits, of_node_put() > must be used to manually decrement the refcount and avoid memory leaks. > > The scoped versio

  1   2   3   >