Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-24 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 at 01:56, Abhinav Kumar wrote: > > > > On 6/24/2024 3:46 PM, Dmitry Baryshkov wrote: > > On Tue, 25 Jun 2024 at 01:39, Abhinav Kumar > > wrote: > >> > >> + IGT dev > >> > >> On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote: > >>> With the introduction of the HDMI Connector frame

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-24 Thread Alexander Stein
Hi Marek, Am Dienstag, 25. Juni 2024, 02:33:53 CEST schrieb Marek Vasut: > On 6/24/24 11:26 AM, Alexander Stein wrote: > > Hi Marek, > > Hi, > > > Am Freitag, 21. Juni 2024, 16:54:51 CEST schrieb Marek Vasut: > >> On 6/21/24 12:32 PM, Alexander Stein wrote: > >> > >> Hi, > >> > >> skipping the p

Re: [PATCH v6 3/8] soc: mediatek: cmdq: Add cmdq_pkt_logic_command to support math operation

2024-06-24 Thread 林睿祥

Re: [etnaviv-next v14 0/8] drm/etnaviv: Add driver wrapper for vivante GPUs attached on PCI(e) device

2024-06-24 Thread Icenowy Zheng
在 2024-05-20星期一的 00:53 +0800,Sui Jingfeng写道: > drm/etnaviv use the component framework to bind multiple GPU cores to > a > virtual master, the virtual master is manually create during driver > load > time. This works well for various SoCs, yet there are some PCIe card > has > the vivante GPU cores

[PATCH net-next v13 04/13] netdev: netdevice devmem allocator

2024-06-24 Thread Mina Almasry
Implement netdev devmem allocator. The allocator takes a given struct netdev_dmabuf_binding as input and allocates net_iov from that binding. The allocation simply delegates to the binding's genpool for the allocation logic and wraps the returned memory region in a net_iov struct. Signed-off-by:

[PATCH net-next v13 08/13] net: support non paged skb frags

2024-06-24 Thread Mina Almasry
Make skb_frag_page() fail in the case where the frag is not backed by a page, and fix its relevant callers to handle this case. Signed-off-by: Mina Almasry --- v10: - Fixed newly generated kdoc warnings found by patchwork. While we're at it, fix the Return section of the functions I touched.

[PATCH net-next v13 09/13] net: add support for skbs with unreadable frags

2024-06-24 Thread Mina Almasry
For device memory TCP, we expect the skb headers to be available in host memory for access, and we expect the skb frags to be in device memory and unaccessible to the host. We expect there to be no mixing and matching of device memory frags (unaccessible) with host memory frags (accessible) in the

[PATCH net-next v13 13/13] selftests: add ncdevmem, netcat for devmem TCP

2024-06-24 Thread Mina Almasry
ncdevmem is a devmem TCP netcat. It works similarly to netcat, but it sends and receives data using the devmem TCP APIs. It uses udmabuf as the dmabuf provider. It is compatible with a regular netcat running on a peer, or a ncdevmem running on a peer. In addition to normal netcat support, ncdevmem

[PATCH net-next v13 11/13] net: add SO_DEVMEM_DONTNEED setsockopt to release RX frags

2024-06-24 Thread Mina Almasry
Add an interface for the user to notify the kernel that it is done reading the devmem dmabuf frags returned as cmsg. The kernel will drop the reference on the frags to make them available for reuse. Signed-off-by: Willem de Bruijn Signed-off-by: Kaiyuan Zhang Signed-off-by: Mina Almasry --- v

[PATCH net-next v13 12/13] net: add devmem TCP documentation

2024-06-24 Thread Mina Almasry
Add documentation outlining the usage and details of devmem TCP. Signed-off-by: Mina Almasry Reviewed-by: Bagas Sanjaya --- v9: https://lore.kernel.org/netdev/20240403002053.2376017-14-almasrym...@google.com/ - Bagas doc suggestions. v8: - Applied docs suggestions (Randy). Thanks! v7: - App

[PATCH net-next v13 10/13] tcp: RX path for devmem TCP

2024-06-24 Thread Mina Almasry
In tcp_recvmsg_locked(), detect if the skb being received by the user is a devmem skb. In this case - if the user provided the MSG_SOCK_DEVMEM flag - pass it to tcp_recvmsg_devmem() for custom handling. tcp_recvmsg_devmem() copies any data in the skb header to the linear buffer, and returns a cmsg

[PATCH net-next v13 06/13] page_pool: devmem support

2024-06-24 Thread Mina Almasry
Convert netmem to be a union of struct page and struct netmem. Overload the LSB of struct netmem* to indicate that it's a net_iov, otherwise it's a page. Currently these entries in struct page are rented by the page_pool and used exclusively by the net stack: struct { unsigned long pp_mag

[PATCH net-next v13 07/13] memory-provider: dmabuf devmem memory provider

2024-06-24 Thread Mina Almasry
Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The provider obtains a reference on the netde

[PATCH net-next v13 05/13] page_pool: convert to use netmem

2024-06-24 Thread Mina Almasry
Abstract the memory type from the page_pool so we can later add support for new memory types. Convert the page_pool to use the new netmem type abstraction, rather than use struct page directly. As of this patch the netmem type is a no-op abstraction: it's always a struct page underneath. All the p

[PATCH net-next v13 03/13] netdev: support binding dma-buf to netdevice

2024-06-24 Thread Mina Almasry
Add a netdev_dmabuf_binding struct which represents the dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to rx queues on the netdevice. On the binding, the dma_buf_attach & dma_buf_map_attachment will occur. The entries in the sg_table from mapping will be inserted into a genpool

[PATCH net-next v13 02/13] net: netdev netlink api to bind dma-buf to a net device

2024-06-24 Thread Mina Almasry
API takes the dma-buf fd as input, and binds it to the netdevice. The user can specify the rx queues to bind the dma-buf to. Suggested-by: Stanislav Fomichev Signed-off-by: Mina Almasry --- v7: - Use flags: [ admin-perm ] instead of a CAP_NET_ADMIN check. Changes in v1: - Add rx-queue-type to

[PATCH net-next v13 01/13] netdev: add netdev_rx_queue_restart()

2024-06-24 Thread Mina Almasry
Add netdev_rx_queue_restart() function to netdev_rx_queue.h Signed-off-by: David Wei Signed-off-by: Mina Almasry Reviewed-by: Pavel Begunkov --- v13: - Add reviewed-by from Pavel (thanks!) - Fixed comment (Pavel) v11: - Fix not checking dev->queue_mgmt_ops (Pavel). - Fix ndo_queue_mem_free c

[PATCH net-next v13 00/13] Device Memory TCP

2024-06-24 Thread Mina Almasry
v13: https://patchwork.kernel.org/project/netdevbpf/list/?series=861406&archive=both&state=* Major changes: -- This iteration addresses Pavel's review comments, applies his reviewed-by's, and seeks to fix the patchwork build error (sorry!). As usual, the full devmem TCP changes

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-24 Thread Marek Vasut
On 6/24/24 11:26 AM, Alexander Stein wrote: Hi Marek, Hi, Am Freitag, 21. Juni 2024, 16:54:51 CEST schrieb Marek Vasut: On 6/21/24 12:32 PM, Alexander Stein wrote: Hi, skipping the parts where I would simply write "OK" ... As FVUEN is cleared at the next VSYNC event I suspect the DSI tim

Re: [PATCH RFC v2] drm/msm/dpu: Configure DP INTF/PHY selector

2024-06-24 Thread Abhinav Kumar
On 6/13/2024 4:17 AM, Dmitry Baryshkov wrote: From: Bjorn Andersson Some platforms provides a mechanism for configuring the mapping between (one or two) DisplayPort intfs and their PHYs. In particular SC8180X provides this functionality, without a default configuration, resulting in no conn

Re: [PATCH 18/23] dt-bindings: allwinner: add H616 DE33 bus, clock and display bindings

2024-06-24 Thread Ryan Walklin
Hi, On Tue, 25 Jun 2024, at 12:37 PM, Andre Przywara wrote: > That doesn't look right, that would allow: > - h6-de > - h616-de33 > - a64-de2 > > which is not what we want, right? It's more: > - h6-de, a64-de2 > - h616-de, a64-de2 > - a64-de2 Ah right, have got my head round how the fallback work

[PATCH v2] drm/ttm/tests: add missing MODULE_DESCRIPTION() macros

2024-06-24 Thread Jeff Johnson
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_device_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/ttm/tests/ttm_pool_test.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/gpu/drm/t

Re: [PATCH 14/23] drm: sun4i: de2/de3: refactor mixer initialisation

2024-06-24 Thread Ryan Walklin
Hi Andre, On Tue, 25 Jun 2024, at 12:28 PM, Andre Przywara wrote: Thanks for the review! >> regmap_write(mixer->engine.regs, SUN50I_MIXER_CDC1_EN, 0); >> -} else { >> + > > That seems to add an extra line, which shouldn't be here. This was intentional to add some whitespace be

Re: [PATCH v5 4/5] drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel

2024-06-24 Thread Jessica Zhang
On 6/24/2024 7:19 AM, Zhaoxiong Lv wrote: The K&d kd101ne3-40ti is a 10.1" WXGA TFT-LCD panel, use jd9365da controller,which fits in nicely with the existing panel-jadard-jd9365da-h3 driver.Hence,we add a new compatible with panel specific config. Although they have the same control IC, the t

Re: [PATCH v5 5/5] drm/panel: jd9365da: Add the function of adjusting orientation

2024-06-24 Thread Jessica Zhang
On 6/24/2024 7:19 AM, Zhaoxiong Lv wrote: This driver does not have the function to adjust the orientation, so this function is added. Signed-off-by: Zhaoxiong Lv Reviewed-by: Jessica Zhang --- Changes between V5 and V4: - 1. Change dev_err() to dev_err_probe(). V4:https://lore.kernel.

Re: [PATCH 18/23] dt-bindings: allwinner: add H616 DE33 bus, clock and display bindings

2024-06-24 Thread Andre Przywara
On Thu, 20 Jun 2024 23:29:56 +1200 Ryan Walklin wrote: > The Allwinner H616 and variants have a new display engine revision > (DE33). > > Add display engine bus, clock and mixer bindings for the DE33. > > Signed-off-by: Ryan Walklin > --- > .../devicetree/bindings/bus/allwinner,sun50i-a64-de2

Re: [PATCH 14/23] drm: sun4i: de2/de3: refactor mixer initialisation

2024-06-24 Thread Andre Przywara
On Thu, 20 Jun 2024 23:29:52 +1200 Ryan Walklin wrote: Hi, > From: Jernej Skrabec > > Now that the DE variant can be selected by enum, take the oppportunity > to factor out some common initialisation code to a separate function. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Ryan Walklin

Re: [PATCH 13/23] drm: sun4i: de2/de3: add mixer version enum

2024-06-24 Thread Andre Przywara
On Thu, 20 Jun 2024 23:29:51 +1200 Ryan Walklin wrote: Hi, > From: Jernej Skrabec > > The Allwinner DE2 and DE3 display engine mixers are currently identified > by a simple boolean flag. This will not scale to support additional DE > variants. > > Convert the boolean flag to an enum, and refa

Re: [PATCH 01/23] drm: sun4i: de2/de3: Change CSC argument

2024-06-24 Thread Andre Przywara
On Thu, 20 Jun 2024 23:29:39 +1200 Ryan Walklin wrote: Hi, > From: Jernej Skrabec > > Currently, CSC module takes care only for converting YUV to RGB. > However, DE3 is more suited to work in YUV color space. Change CSC mode > argument to format type to be more neutral. New argument only tells

Re: [PATCH v5 3/5] drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS functions

2024-06-24 Thread Jessica Zhang
On 6/24/2024 7:19 AM, Zhaoxiong Lv wrote: Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to simplify driver's init/enable/exit code. Signed-off-by: Zhaoxiong Lv Reviewed-by: Jessica Zhang --- .../gpu/drm/panel/panel-jadard-jd9365da-h3.c | 793 +-

Re: [PATCH v5 1/5] drm/panel: jd9365da: Modify the method of sending commands

2024-06-24 Thread Jessica Zhang
On 6/24/2024 7:19 AM, Zhaoxiong Lv wrote: Currently, the init_code of the jd9365da driver is placed in the enable() function and sent, but this seems to take a long time. It takes 17ms to send each instruction (an init code consists of about 200 instructions), so it takes about 3.5s to send th

Re: [PATCH v3] drm/msm/dpu: remove CRTC frame event callback registration

2024-06-24 Thread Abhinav Kumar
On 6/24/2024 3:38 PM, Dmitry Baryshkov wrote: The frame event callback is always set to dpu_crtc_frame_event_cb() (or to NULL) and the data is always either the CRTC itself or NULL (correpondingly). Thus drop the event callback registration, call the dpu_crtc_frame_event_cb() directly and gate

Re: [PATCH] drm/ttm/tests: add missing MODULE_DESCRIPTION() macros

2024-06-24 Thread Jeff Johnson
On 6/9/2024 9:34 AM, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/ttm/tests/ttm_device_test.o > WARNING: modpost: missing MODULE_DESCRIPTION() in > drivers/gpu/drm/ttm/tests/ttm_pool_test.o > WARNING: modpos

Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-24 Thread Abhinav Kumar
On 6/24/2024 3:46 PM, Dmitry Baryshkov wrote: On Tue, 25 Jun 2024 at 01:39, Abhinav Kumar wrote: + IGT dev On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote: With the introduction of the HDMI Connector framework the driver might end up creating the max_bpc property with min = max = 8. IGT ins

Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-24 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 at 01:39, Abhinav Kumar wrote: > > + IGT dev > > On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote: > > With the introduction of the HDMI Connector framework the driver might > > end up creating the max_bpc property with min = max = 8. IGT insists > > that such properties carry the

Re: [PATCH v2 2/2] drm/connector: automatically set immutable flag for max_bpc property

2024-06-24 Thread Abhinav Kumar
+ IGT dev On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote: With the introduction of the HDMI Connector framework the driver might end up creating the max_bpc property with min = max = 8. IGT insists that such properties carry the 'immutable' flag. Automatically set the flag if the driver asks for

[PATCH v3] drm/msm/dpu: remove CRTC frame event callback registration

2024-06-24 Thread Dmitry Baryshkov
The frame event callback is always set to dpu_crtc_frame_event_cb() (or to NULL) and the data is always either the CRTC itself or NULL (correpondingly). Thus drop the event callback registration, call the dpu_crtc_frame_event_cb() directly and gate on the dpu_enc->crtc assigned using dpu_encoder_as

Re: [PATCH v2 1/2] drm/bridge-connector: reset the HDMI connector state

2024-06-24 Thread Dmitry Baryshkov
On Tue, 25 Jun 2024 at 01:28, Abhinav Kumar wrote: > > > > On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote: > > On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI > > IGT chokes on the max_bpc property in several kms_properties tests due > > to the the drm_bridge_connector fail

Re: [PATCH v2 1/2] drm/bridge-connector: reset the HDMI connector state

2024-06-24 Thread Abhinav Kumar
On 6/22/2024 10:40 PM, Dmitry Baryshkov wrote: On HDMI connectors which use drm_bridge_connector and DRM_BRIDGE_OP_HDMI IGT chokes on the max_bpc property in several kms_properties tests due to the the drm_bridge_connector failing to reset HDMI-related properties. Call __drm_atomic_helper_con

Re: [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA

2024-06-24 Thread Jessica Zhang
On 6/23/2024 6:56 PM, Liu Ying wrote: KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags. This aligns display_timing with panel_desc. Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D

Re: [PATCH] drm/xe: Use write-back caching mode for system memory on DGFX

2024-06-24 Thread Matt Roper
On Wed, Jun 19, 2024 at 06:39:04PM +0200, Thomas Hellström wrote: > The caching mode for buffer objects with VRAM as a possible > placement was forced to write-combined, regardless of placement. > > However, write-combined system memory is expensive to allocate and > even though it is pooled, the

[PATCH v5 09/16] drm/msm/dpu: pass drm_framebuffer to _dpu_format_get_plane_sizes()

2024-06-24 Thread Dmitry Baryshkov
Instead of passing width / height / pitches, pass drm_framebuffer directly. This allows us to drop the useless check for !pitches, since an array can not be NULL. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 73 ++--- 1 file changed, 3

[PATCH v5 13/16] drm/msm/dpu: move layout setup population out of dpu_plane_prepare_fb()

2024-06-24 Thread Dmitry Baryshkov
Move the call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. At the same time move the call to dpu_format_populate_addrs() to dpu_plane_sspp_atomic_update(). This way the all layout management is performed

[PATCH v5 08/16] drm/msm/dpu: drop msm_format from struct dpu_hw_fmt_layout

2024-06-24 Thread Dmitry Baryshkov
The struct dpu_hw_fmt_layout defines hardware data layout (addresses, sizes and pitches. Drop format field from this structure as it's not a part of the data layout. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 31 +++--- drivers/gpu/dr

[PATCH v5 15/16] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-06-24 Thread Dmitry Baryshkov
dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_fo

[PATCH v5 12/16] drm/msm/dpu: make dpu_format_populate_addrs return void

2024-06-24 Thread Dmitry Baryshkov
The function msm_framebuffer_iova() can not fail, it always returns a valid address. Drop the useless checks (that were already performed at the time) and make dpu_format_populate_addrs() return void. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 6 +--

[PATCH v5 16/16] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-24 Thread Dmitry Baryshkov
Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov ---

[PATCH v5 14/16] drm/msm/dpu: check for the plane pitch overflow

2024-06-24 Thread Dmitry Baryshkov
Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 +

[PATCH v5 10/16] drm/msm/dpu: move pitch check to _dpu_format_get_plane_sizes_linear()

2024-06-24 Thread Dmitry Baryshkov
The _dpu_format_get_plane_sizes_linear() already compares pitches of the framebuffer with the calculated pitches. Move the check to the same place, demoting DPU_ERROR to DPU_DEBUG to prevent user from spamming the kernel log. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_

[PATCH v5 11/16] drm/msm/dpu: split dpu_format_populate_layout

2024-06-24 Thread Dmitry Baryshkov
Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

[PATCH v5 06/16] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-24 Thread Dmitry Baryshkov
The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layout in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v5 02/16] drm/msm/dpu: fix error condition in dpu_encoder_virt_atomic_mode_set

2024-06-24 Thread Dmitry Baryshkov
The commit b954fa6baaca ("drm/msm/dpu: Refactor rm iterator") removed zero-init of the hw_ctl array, but didn't change the error condition, that checked for hw_ctl[i] being NULL. Use indices check instead. Fixes: b954fa6baaca ("drm/msm/dpu: Refactor rm iterator") Signed-off-by: Dmitry Baryshkov -

[PATCH v5 04/16] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-24 Thread Dmitry Baryshkov
Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/m

[PATCH v5 00/16] drm/msm/dpu: be more friendly to X.org

2024-06-24 Thread Dmitry Baryshkov
-off-by: Dmitry Baryshkov --- Changes in v5: - Fix crash in the writeback code. - Link to v4: https://lore.kernel.org/r/20240624-dpu-mode-config-width-v4-0-1038c13da...@linaro.org Changes in v4: - Fix handling of the not visible planes with the FB being set, as detected via the

[PATCH v5 05/16] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-24 Thread Dmitry Baryshkov
The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Reviewed-by: Abhinav Kumar Tested-by: Abhinav Kumar # sc7280 Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 - drivers/gpu/drm/ms

[PATCH v5 07/16] drm/msm/dpu: drop extra aspace checks in dpu_formats

2024-06-24 Thread Dmitry Baryshkov
The DPU driver isn't expected to be used without an IOMMU. Thus the aspace will be always present. Not to mention that mdp4/mdp5 drivers call msm_framebuffer_iova() without such checks, as the whole msm_framebuffer layer is expected to support both IOMMU and IOMMU-less configurations. Drop these u

[PATCH v5 03/16] drm/msm/dpu: move CRTC resource assignment to dpu_encoder_virt_atomic_mode_set

2024-06-24 Thread Dmitry Baryshkov
Historically CRTC resources (LMs and CTLs) were assigned in dpu_crtc_atomic_begin(). The commit 9222cdd27e82 ("drm/msm/dpu: move hw resource tracking to crtc state") simply moved resources to struct dpu_crtc_state, without changing the code sequence. Later on the commit b107603b4ad0 ("drm/msm/dpu:

[PATCH v5 01/16] drm/msm/dpu: cleanup FB if dpu_format_populate_layout fails

2024-06-24 Thread Dmitry Baryshkov
If the dpu_format_populate_layout() fails, then FB is prepared, but not cleaned up. This ends up leaking the pin_count on the GEM object and causes a splat during DRM file closure: msm_obj->pin_count WARNING: CPU: 2 PID: 569 at drivers/gpu/drm/msm/msm_gem.c:121 update_lru_locked+0xc4/0xcc [...] C

[PATCH] drm/vmwgfx: Trigger a modeset when the screen moves

2024-06-24 Thread Ian Forbes
When multi-monitor is cycled the X,Y position of the Screen Target will likely change but the resolution will not. We need to trigger a modeset when this occurs in order to recreate the Screen Target with the correct X,Y position. Fixes a bug where multiple displays are shown in a single scrollabl

[PATCH v4 2/2] drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066

2024-06-24 Thread Val Packett
The RK3066 does have RGB display output, so it should be marked as such. Fixes: f4a6de8 ("drm: rockchip: vop: add rk3066 vop definitions") Cc: sta...@vger.kernel.org Signed-off-by: Val Packett --- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

[PATCH v4 1/2] drm/rockchip: vop: clear DMA stop bit on RK3066

2024-06-24 Thread Val Packett
The RK3066 VOP sets a dma_stop bit when it's done scanning out a frame and needs the driver to acknowledge that by clearing the bit. Unless we clear it "between" frames, the RGB output only shows noise instead of the picture. atomic_flush is the place for it that least affects other code (doing it

[PATCH v4 0/2] drm/rockchip: vop: Support internal display on RK3066

2024-06-24 Thread Val Packett
This tiny patch series makes the changes required to enable the RGB display output on the Rockchip RK3066 SoC. Final version as discussed. Val Packett (2): drm/rockchip: vop: clear DMA stop bit on RK3066 drm/rockchip: vop: enable VOP_FEATURE_INTERNAL_RGB on RK3066 drivers/gpu/drm/rockchip/ro

Re: [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series

2024-06-24 Thread Rob Herring
On Mon, Jun 24, 2024 at 03:30:27AM +0200, Caleb Connolly wrote: > Add bindings for the OnePlus 8, 8 Pro, and 8T devices. > > Signed-off-by: Caleb Connolly > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree

[PATCH] fbdev: mmp: Constify struct mmp_overlay_ops

2024-06-24 Thread Christophe JAILLET
'struct mmp_overlay_ops' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig, as an example: Before: == textdata bss dec hex filename 11798 555 16 12369

Re: [PATCH] drm/amd/display: Check pipe_ctx before it is used

2024-06-24 Thread Markus Elfring
>> resource_get_otg_master_for_stream() could return NULL, we >> should check the return value of 'otg_master' before it is >> used in resource_log_pipe_for_stream(). > > A similar fix was integrated already according to a contribution > by Natanel Roizenman. > From which Linux version did you take

[RFC PATCH] drm/panel: synaptics-r63353: Fix regulator unbalance

2024-06-24 Thread Michael Trimarchi
The shutdown function can be called when the display is already unprepared. For example during reboot this trigger a kernel backlog. Calling the drm_panel_unprepare, allow us to avoid to trigger the kernel warning Signed-off-by: Michael Trimarchi --- It's not obviovus if shutdown can be dropped

Re: [etnaviv-next v14 0/8] drm/etnaviv: Add driver wrapper for vivante GPUs attached on PCI(e) device

2024-06-24 Thread Christian Gmeiner
Hi > > drm/etnaviv use the component framework to bind multiple GPU cores to a > virtual master, the virtual master is manually create during driver load > time. This works well for various SoCs, yet there are some PCIe card has > the vivante GPU cores integrated. The driver lacks the support for

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-24 Thread Mario Limonciello
On 6/23/2024 15:55, Hans de Goede wrote: Hi, On 6/23/24 10:20 PM, Mario Limonciello wrote: On 6/23/2024 03:51, Thomas Weißschuh wrote: Panels using a PWM-controlled backlight source without an do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACP

Re: [PATCH 09/18] dmaengine: bcm2835: Add function to handle DMA mapping

2024-06-24 Thread Dave Stevenson
On Wed, 5 Jun 2024 at 19:13, Frank Li wrote: > > On Fri, May 24, 2024 at 07:26:53PM +0100, Dave Stevenson wrote: > > The code handling DMA mapping is currently incorrect and > > needs a sequence of fixups. > > Can you descript what incorrect here? Clients are passing in DMA addresses, not CPU phy

Re: [PATCH 08/18] dmaengine: bcm2835: pass dma_chan to generic functions

2024-06-24 Thread Dave Stevenson
Hi Frank. On Wed, 5 Jun 2024 at 19:05, Frank Li wrote: > > On Fri, May 24, 2024 at 07:26:52PM +0100, Dave Stevenson wrote: > > From: Stefan Wahren > > > > In preparation to support more platforms pass the dma_chan to the > > generic functions. This provides access to the DMA device and possible

Re: [syzbot] [net?] [nfc?] INFO: task hung in nfc_targets_found

2024-06-24 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 487fa28fa8b60417642ac58e8beda6e2509d18f9 Author: Helge Deller Date: Sat Apr 27 17:43:51 2024 + parisc: Define sigset_t in parisc uapi header bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17038a6198 start commit:

Re: [PATCH 06/18] dmaengine: bcm2835: make address increment platform independent

2024-06-24 Thread Dave Stevenson
Hi Frank Thanks for the review, and sorry for the delay in coming back to this. On Wed, 5 Jun 2024 at 18:53, Frank Li wrote: > > On Fri, May 24, 2024 at 07:26:50PM +0100, Dave Stevenson wrote: > > From: Stefan Wahren > > > > Actually the criteria to increment source & destination address doesn'

Re: [PATCH v3 6/7] drm/drm_file: add display of driver's internal memory size

2024-06-24 Thread Rob Clark
On Thu, Jun 6, 2024 at 1:35 AM Tvrtko Ursulin wrote: > > > On 06/06/2024 02:49, Adrián Larumbe wrote: > > > Some drivers must allocate a considerable amount of memory for bookkeeping > > structures and GPU's MCU-kernel shared communication regions. These are > > often created as a result of the in

[PATCH] drm/connector: hdmi: shorten too long function name

2024-06-24 Thread Dmitry Baryshkov
_infoframe(struct drm_connector *connector); int drm_atomic_helper_connector_hdmi_update_infoframes(struct drm_connector *connector, struct drm_atomic_state *state); --- base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7 change-id: 202406

Re: [PATCH] drm/amd/display: Check pipe_ctx before it is used

2024-06-24 Thread Markus Elfring
> resource_get_otg_master_for_stream() could return NULL, we > should check the return value of 'otg_master' before it is > used in resource_log_pipe_for_stream(). A similar fix was integrated already according to a contribution by Natanel Roizenman. >From which Linux version did you take source f

Re: [PATCH v5 5/5] drm/panel: jd9365da: Add the function of adjusting orientation

2024-06-24 Thread Doug Anderson
Hi, On Mon, Jun 24, 2024 at 7:21 AM Zhaoxiong Lv wrote: > > This driver does not have the function to adjust the orientation, > so this function is added. > > Signed-off-by: Zhaoxiong Lv > --- > Changes between V5 and V4: > - 1. Change dev_err() to dev_err_probe(). > > V4:https://lore.kernel.org

Re: [PATCH v5 4/5] drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel

2024-06-24 Thread Doug Anderson
Hi, On Mon, Jun 24, 2024 at 7:21 AM Zhaoxiong Lv wrote: > > The K&d kd101ne3-40ti is a 10.1" WXGA TFT-LCD panel, use > jd9365da controller,which fits in nicely with the existing > panel-jadard-jd9365da-h3 driver.Hence,we add a new compatible > with panel specific config. > > Although they have th

[PATCH 2/3] drm/mediatek: ovl_adaptor: add missing of_node_put()

2024-06-24 Thread Javier Carrasco
Error paths that exit for_each_child_of_node() need to call of_node_put() to decerement the child refcount and avoid memory leaks. Add the missing of_node_put(). Cc: sta...@vger.kernel.org Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for MT8195") Signed-off-by: Javier Carrasco ---

[PATCH 1/3] drm/mediatek: ovl_adaptor: drop unused mtk_crtc.h header

2024-06-24 Thread Javier Carrasco
None of the elements from that header is used in this file. Signed-off-by: Javier Carrasco --- drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c ind

[PATCH 3/3] drm/mediatek: ovl_adaptor: use scoped variant of for_each_child_of_node()

2024-06-24 Thread Javier Carrasco
In order to avoid potential memory leaks if new error paths are added without a call to of_node_put(), use for_each_child_of_node_scoped() instead of for_each_child_of_node(). The former automatically decrements the refcount when the child goes out of scope, which removes the need for explicit call

[PATCH 0/3] drm/mediatek: fixes for ovl_adaptor

2024-06-24 Thread Javier Carrasco
: ovl_adaptor: add missing of_node_put() drm/mediatek: ovl_adaptor: use scoped variant of for_each_child_of_node() drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7 change-id: 20240624

Re: [PATCH v5 3/5] drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS functions

2024-06-24 Thread Doug Anderson
Hi, On Mon, Jun 24, 2024 at 7:21 AM Zhaoxiong Lv wrote: > > +static int radxa_display_8hd_ad002_init_cmds(struct jadard *jadard) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi }; > + > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xE0, 0x00); nit: could you convert

Re: [PATCH v2 0/4] dt-bindings: display/msm/gpu: few cleanups

2024-06-24 Thread Conor Dooley
On Sun, Jun 23, 2024 at 10:02:59PM +0200, Krzysztof Kozlowski wrote: > Changes since v1: > 1. Add tags > 2. New patches #3 and #4 > 3. Drop previous patch "dt-bindings: display/msm/gpu: constrain >reg/reg-names per variant", because I need to investigate more. Acked-by: Conor Dooley Cheers,

Re: [PATCH v5 3/5] drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS functions

2024-06-24 Thread Dmitry Baryshkov
On Mon, 24 Jun 2024 at 19:31, Doug Anderson wrote: > > Hi, > > On Mon, Jun 24, 2024 at 8:27 AM Dmitry Baryshkov > wrote: > > > > On Mon, Jun 24, 2024 at 10:19:24PM GMT, Zhaoxiong Lv wrote: > > > Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to > > > simplify driver's init/

Re: [PATCH v5 3/5] drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS functions

2024-06-24 Thread Doug Anderson
Hi, On Mon, Jun 24, 2024 at 8:27 AM Dmitry Baryshkov wrote: > > On Mon, Jun 24, 2024 at 10:19:24PM GMT, Zhaoxiong Lv wrote: > > Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to > > simplify driver's init/enable/exit code. > > > > Signed-off-by: Zhaoxiong Lv > > --- > > .

Re: [PATCH v5 1/5] drm/panel: jd9365da: Modify the method of sending commands

2024-06-24 Thread Doug Anderson
Hi, On Mon, Jun 24, 2024 at 7:20 AM Zhaoxiong Lv wrote: > > Currently, the init_code of the jd9365da driver is placed > in the enable() function and sent, but this seems to take > a long time. It takes 17ms to send each instruction (an init > code consists of about 200 instructions), so it takes

Re: (subset) [PATCH 00/13] rockchip: Enable 4K@60Hz mode on RK3228, RK3328, RK3399 and RK356x

2024-06-24 Thread Heiko Stuebner
On Sat, 15 Jun 2024 17:03:51 +, Jonas Karlman wrote: > This prepares and enable use of HDMI2.0 modes, e.g. 4K@60Hz, on RK3228, > RK3328, RK3399 and RK356x. > > Patch 1-3 fixes some issues to help support use of high-resolution modes. > > Patch 4 fixes reading of EDID on RK3328 when using a fo

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-06-24 Thread Thomas Weißschuh
Hi Hans! thanks for your feedback! On 2024-06-24 11:11:40+, Hans de Goede wrote: > On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > > is "12". This leads to a fairly bright minimum display backlight. > > > > Add a gen

Re: [PATCH v5 08/12] drm/ttm: Add a virtual base class for graphics memory backup

2024-06-24 Thread Thomas Hellström
On Mon, 2024-06-24 at 11:26 +0200, Thomas Hellström wrote: > On Thu, 2024-06-20 at 15:17 +, Matthew Brost wrote: > > On Tue, Jun 18, 2024 at 09:18:16AM +0200, Thomas Hellström wrote: > > > Initially intended for experimenting with different backup > > > solutions (shmem vs direct swap cache ins

Re: [PATCH v4 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-06-24 Thread Rob Clark
On Mon, Jun 24, 2024 at 8:14 AM Will Deacon wrote: > > On Thu, May 23, 2024 at 10:52:21AM -0700, Rob Clark wrote: > > From: Rob Clark > > > > Add an io-pgtable method to walk the pgtable returning the raw PTEs that > > would be traversed for a given iova access. > > > > Signed-off-by: Rob Clark

[PATCH] backlight: lm3509_bl: Fix early returns in for_each_child_of_node()

2024-06-24 Thread Javier Carrasco
ources = 0; - for_each_child_of_node(dev->of_node, child) { + for_each_child_of_node_scoped(dev->of_node, child) { struct lm3509_bl_led_data *ld; int ret; u32 reg; --- base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7 change-id: 20240624-lm3509_bl_sco

Re: [PATCH v5 3/5] drm/panel: panel-jadard-jd9365da-h3: use wrapped MIPI DCS functions

2024-06-24 Thread Dmitry Baryshkov
On Mon, Jun 24, 2024 at 10:19:24PM GMT, Zhaoxiong Lv wrote: > Remove conditional code and always use mipi_dsi_dcs_*multi() wrappers to > simplify driver's init/enable/exit code. > > Signed-off-by: Zhaoxiong Lv > --- > .../gpu/drm/panel/panel-jadard-jd9365da-h3.c | 793 +- > 1 fi

[PATCH v2 17/17] backlight: sky81452-backlight: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/sky81452-backlight.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 06/17] backlight: ipaq-micro-backlight: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ipaq_micro_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dr

[PATCH v2 08/17] backlight: kb3886-bl: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/kb3886_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driv

[PATCH v2 11/17] backlight: lm3533-backlight: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/lm3533_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

[PATCH v2 14/17] backlight: pcf50633-backlight: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/pcf50633-backlight.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --

[PATCH v2 05/17] backlight: gpio-backlight: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/gpio_backlight.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --

[PATCH v2 12/17] backlight: mp3309c: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/mp3309c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH v2 09/17] backlight: ktd253-backlight: Use backlight power constants

2024-06-24 Thread Thomas Zimmermann
Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality. Signed-off-by: Thomas Zimmermann --- drivers/video/backlight/ktd253-backlight.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --gi

  1   2   3   >