Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-18 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 09:45, Ekansh Gupta wrote: > > > > On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > >> to be added for PD notifications and other missin

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-18 Thread Greg KH
On Wed, Jun 19, 2024 at 12:15:03PM +0530, Ekansh Gupta wrote: > > > On 6/12/2024 11:58 PM, Dmitry Baryshkov wrote: > > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > >> Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > >> to be added for PD notifications and o

Re: [PATCH v2] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-18 Thread Dmitry Baryshkov
On Wed, Jun 19, 2024 at 09:03:49AM GMT, Tejas Vipin wrote: > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce > mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for the > raydium rm692e5 panel. > > Signe

[PATCH 2/9] MAINTAINERS: Change habanalabs maintainer and git repo path

2024-06-18 Thread Ofir Bitton
From: Oded Gabbay Because I left habana, Ofir Bitton is now the habanalabs driver maintainer. The git repo also changed location to the Habana GitHub website. Signed-off-by: Oded Gabbay Acked-by: Daniel Vetter --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

[PATCH 8/9] accel/habanalabs: move heartbeat work initialization to early init

2024-06-18 Thread Ofir Bitton
From: Tomer Tayar The device heartbeat work is currently initialized at device_heartbeat_schedule() which is called at the end of hl_device_init(). However hl_device_init() can fail at a previous step, and in such a case, a subsequent call to hl_device_fini() will lead to calling cleanup_resource

[PATCH 6/9] accel/habanalabs: dump the EQ entries headers on EQ heartbeat failure

2024-06-18 Thread Ofir Bitton
From: Tomer Tayar Add a dump of the EQ entries headers upon a EQ heartbeat failure. Signed-off-by: Tomer Tayar Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/common/device.c | 2 ++ drivers/accel/habanalabs/common/habanalabs.h | 1 + drivers/accel/habanalabs/common/irq.c|

[PATCH 9/9] accel/habanalabs: gradual sleep in polling memory macro

2024-06-18 Thread Ofir Bitton
From: Didi Freiman It’s better to avoid long sleeps right from the beginning of the polling since the data may be available much sooner than the sleep period. Because polling host memory is inexpensive, this change gradually increases the sleep time up to the user-requested period. Signed-off-by

[PATCH 7/9] accel/habanalabs: print timestamp of last PQ heartbeat on EQ heartbeat failure

2024-06-18 Thread Ofir Bitton
From: Tomer Tayar The test packet which is sent to FW for the PQ heartbeat is used also as the trigger in FW to send the EQ heartbeat event. Add the time of the last sent packet to the debug info which is printed upon a EQ heartbeat failure. Signed-off-by: Tomer Tayar Reviewed-by: Ofir Bitton

[PATCH 3/9] accel/habanalabs: additional print in device-in-use info

2024-06-18 Thread Ofir Bitton
From: Ilia Levi When device release triggers a hard reset, there is a printout of the cause. Currently listed causes (that increment context refcount) are active command submissions and exported DMA buffer objects. In any other case, the printout emits "unknown reason". We identify and print anot

[PATCH 5/9] accel/habanalabs: revise print on EQ heartbeat failure

2024-06-18 Thread Ofir Bitton
From: Tomer Tayar Don't print the "previous EQ index" value in case of a EQ heartbeat failure, because it is incremented along with the EQ CI and therefore redundant. In addition, as the CPU-CP PI is zeroed when it reaches a value that is twice the queue size, add a value of the CI with a simila

[PATCH 4/9] accel/habanalabs: add more info upon cpu pkt timeout

2024-06-18 Thread Ofir Bitton
From: Farah Kassabri In order to have better debuggability upon encountering FW issues, We are adding additional info once CPU packet timeout expires. Signed-off-by: Farah Kassabri Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/common/firmware_if.c | 14 +++--- 1 file changed,

[PATCH 1/9] accel/habanalbs/gaudi2: reduce interrupt count to 128

2024-06-18 Thread Ofir Bitton
Some systems allow a maximum number of 128 MSI-X interrupts. Hence we reduce the interrupt count to 128 instead of 512. Signed-off-by: Ofir Bitton Reviewed-by: Ofir Bitton --- drivers/accel/habanalabs/gaudi2/gaudi2P.h| 8 drivers/accel/habanalabs/include/gaudi2/gaudi2.h | 4 ++-

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 09:11:58PM GMT, Konrad Dybcio wrote: > > > On 6/18/24 20:55, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: > > > > > > > > > On 6/18/24 19:50, Dmitry Baryshkov wrote: > > > > On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sanko

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-18 Thread Nuno Sá
On Wed, 2024-06-19 at 11:15 +0800, kernel test robot wrote: > Hi Paul, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on jic23-iio/togreg] > [also build test ERROR on vkoul-dmaengine/next linus/master v6.10-rc4 next- > 20240618] > [

[Bug 211807] [drm:drm_dp_mst_dpcd_read] *ERROR* mstb 000000004e6288dd port 3: DPCD read on addr 0x60 for 1 bytes NAKed

2024-06-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211807 TiaPadavano (jiloxe4...@elahan.com) changed: What|Removed |Added CC||jiloxe4...@elahan.co

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Tomasz Figa
On Wed, Jun 19, 2024 at 1:24 AM Nicolas Dufresne wrote: > > Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > > Hi TaoJiang, > > > > On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > > > > > From: Ming Qian > > > > > > When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't

Re: [PATCH v5 06/12] drm/ttm: Use the LRU walker helper for swapping

2024-06-18 Thread Matthew Brost
On Tue, Jun 18, 2024 at 09:18:14AM +0200, Thomas Hellström wrote: > Rework the TTM swapping to use the LRU walker helper. > This helps fixing up the ttm_bo_swapout() interface > to be consistent about not requiring any locking. > > For now mimic the current behaviour of using trylock > only. We co

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Mario Limonciello
On 6/18/2024 17:36, Leo Li wrote: On 2024-06-05 22:04, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy

Re: [PATCH v5 04/12] drm/ttm, drm/amdgpu, drm/xe: Consider hitch moves within bulk sublist moves

2024-06-18 Thread Matthew Brost
On Tue, Jun 18, 2024 at 09:18:12AM +0200, Thomas Hellström wrote: Ugh, replying to correct version again... > To address the problem with hitches moving when bulk move > sublists are lru-bumped, register the list cursors with the > ttm_lru_bulk_move structure when traversing its list, and > when

[PATCH v2] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-18 Thread Tejas Vipin
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe ("drm/mipi-dsi: wrap more functions for streamline handling") for the raydium rm692e5 panel. Signed-off-by: Tejas Vipin --- Changes in v2: - Change rm692e5_on to re

Re: [PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-18 Thread Dmitry Baryshkov
On Wed, 19 Jun 2024 at 01:56, Abhinav Kumar wrote: > On 6/13/2024 4:20 PM, Abhinav Kumar wrote: > > On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: > >> The dpu_crtc_atomic_check() already calls the function > >> _dpu_crtc_check_and_setup_lm_bounds(). There is no need to call it > >> again from dpu

Re: [PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-18 Thread 胡俊光

Re: [PATCH v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-18 Thread kernel test robot
Hi Paul, kernel test robot noticed the following build errors: [auto build test ERROR on jic23-iio/togreg] [also build test ERROR on vkoul-dmaengine/next linus/master v6.10-rc4 next-20240618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: Correct sequencing of usage of DRM writeback connector

2024-06-18 Thread Abhinav Kumar
On 6/18/2024 2:33 AM, Daniel Vetter wrote: On Mon, Jun 17, 2024 at 10:52:27PM +0300, Dmitry Baryshkov wrote: On Mon, Jun 17, 2024 at 11:28:35AM GMT, Abhinav Kumar wrote: Hi On 6/17/2024 9:54 AM, Brian Starkey wrote: Hi, On Mon, Jun 17, 2024 at 05:16:36PM +0200, Daniel Vetter wrote: On Mo

Re: [PATCH v2 08/14] drm/msm/hdmi: add runtime PM calls to DDC transfer function

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:51 AM, Dmitry Baryshkov wrote: We must be sure that the HDMI controller is powered on, while performing the DDC transfer. Add corresponding runtime PM calls to msm_hdmi_i2c_xfer(). Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang --- drivers/gpu/drm/msm/hdmi/h

Re: [PATCH v2 07/14] drm/msm/hdmi: switch to pm_runtime_resume_and_get()

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: The pm_runtime_get_sync() function is a bad choise for runtime power [nit: s/choise/choice/] Reviewed-by: Jessica Zhang management. Switch HDMI driver to pm_runtime_resume_and_get() and add proper error handling, while we are at it. Signed-o

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Doug Anderson
Hi, On Tue, Jun 18, 2024 at 3:00 PM Alex Deucher wrote: > > On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson wrote: > > > > Hi, > > > > > > On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > > > > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > > > wrote: > > > > > > > > Based on grepp

Re: [PATCH v2 06/14] drm/msm/hdmi: switch to clk_bulk API

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: The last platform using legacy clock names for HDMI block (APQ8064) switched to new clock names in 5.16. It's time to stop caring about old DT, drop hand-coded helpers and switch to clk_bulk_* API. Signed-off-by: Dmitry Baryshkov Reviewed-by: J

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 7:22 AM Daniel Vetter wrote: > > > I'm really not convinced that hacking with device links in order to > > get the shutdown notification in the right order is correct, though. > > The idea is that after we're confident that all DRM modeset drivers > > are calling shutd

Re: [PATCH] drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 7:17 AM Daniel Vetter wrote: > > > That all being said, I'm also totally OK with any of the following: > > > > 1. Dropping my patch and just accepting that we will have warnings > > printed out for all DRM drivers that do things correctly and have no > > warnings for b

Device / Driver and PCI Rust abstractions

2024-06-18 Thread Danilo Krummrich
https://lore.kernel.org/lkml/20240618234025.15036-1-d...@redhat.com/

[PATCH v2 10/10] nova: add initial driver stub

2024-06-18 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to bui

[PATCH v2 8/8] nova: add initial driver stub

2024-06-18 Thread Danilo Krummrich
Add the initial driver stub of Nova, a Rust-based GSP-only driver for Nvidia GPUs. Nova, in the long term, is intended to serve as the successor of Nouveau for GSP-firmware-based GPUs. [1] As a stub driver Nova's focus is to make use of the most basic device / driver infrastructure required to bui

[PATCH v2 7/8] rust: drm: gem: Add GEM object abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina The DRM GEM subsystem is the DRM memory management subsystem used by most modern drivers. Add a Rust abstraction to allow Rust DRM driver implementations to use it. Signed-off-by: Asahi Lina Co-developed-by: Danilo Krummrich Signed-off-by: Danilo Krummrich --- rust/bindings/

[PATCH v2 6/8] rust: drm: file: Add File abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina A DRM File is the DRM counterpart to a kernel file structure, representing an open DRM file descriptor. Add a Rust abstraction to allow drivers to implement their own File types that implement the DriverFile trait. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich ---

[PATCH v2 5/8] rust: drm: add DRM driver registration

2024-06-18 Thread Danilo Krummrich
Implement the DRM driver `Registration`. The `Registration` structure is responsible to register and unregister a DRM driver. It makes use of the `Devres` container in order to allow the `Registration` to be owned by devres, such that it is automatically dropped (and the DRM driver unregistered) o

[PATCH v2 4/8] rust: drm: add device abstraction

2024-06-18 Thread Danilo Krummrich
Implement the abstraction for a `struct drm_device`. A `drm::device::Device` creates a static const `struct drm_driver` filled with the data from the `drm::drv::Driver` trait implementation of the actual driver creating the `drm::device::Device`. Co-developed-by: Asahi Lina Signed-off-by: Asahi

[PATCH v2 2/8] rust: Add a Sealed trait

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina Some traits exposed by the kernel crate may not be intended to be implemented by downstream modules. Add a Sealed trait to allow avoiding this using the sealed trait pattern. Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich --- rust/kernel/lib.rs | 5 + 1 file ch

[PATCH v2 3/8] rust: drm: add driver abstractions

2024-06-18 Thread Danilo Krummrich
Implement the DRM driver abstractions. The `Driver` trait provides the interface to the actual driver to fill in the driver specific data, such as the `DriverInfo`, driver features and IOCTLs. Co-developed-by: Asahi Lina Signed-off-by: Asahi Lina Signed-off-by: Danilo Krummrich --- rust/bindi

[PATCH v2 1/8] rust: drm: ioctl: Add DRM ioctl abstraction

2024-06-18 Thread Danilo Krummrich
From: Asahi Lina DRM drivers need to be able to declare which driver-specific ioctls they support. Add an abstraction implementing the required types and a helper macro to generate the ioctl definition inside the DRM driver. Note that this macro is not usable until further bits of the abstractio

[PATCH v2 0/8] DRM Rust abstractions and Nova

2024-06-18 Thread Danilo Krummrich
This patch series implements some basic DRM Rust abstractions and a stub implementation of the Nova GPU driver. Nova is intended to be developed upstream, starting out with just a stub driver to lift some initial required infrastructure upstream. A more detailed explanation can be found in [1]. T

Re: [PATCH v2 05/14] drm/msm/hdmi: drop clock frequency assignment

2024-06-18 Thread Jessica Zhang
On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote: The only clock which has frequency being set through hpd_freqs is the "core" aka MDSS_HDMI_CLK clock. It always has the specified frequency, so we can drop corresponding clk_set_rate() call together with the hpd_freq infrastructure. Signed-off-by:

Re: [PATCH v3 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:16 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Move 2*max_lm_width check where it belongs, to the drm_crtc_helper_funcs::mode_valid() callback. Sig

Re: [PATCH v3 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

Re: [PATCH v3 7/9] drm/msm/dpu: drop _dpu_crtc_check_and_setup_lm_bounds from atomic_begin

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:20 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The dpu_crtc_atomic_check() already calls the function _dpu_crtc_check_and_setup_lm_bounds().  There is no need to call it again from dpu_crtc_atomic_begin(). Signed-off-by: Dmitry Baryshkov ---   dri

Re: [PATCH v3 6/9] drm/msm/dpu: check for the plane pitch overflow

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_p

Re: [PATCH v3 5/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-06-18 Thread Abhinav Kumar
On 6/14/2024 3:34 AM, Dmitry Baryshkov wrote: On Thu, Jun 13, 2024 at 04:19:07PM GMT, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early

Re: [PATCH v3 4/9] drm/msm/dpu: split dpu_format_populate_layout

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++- drivers/gpu/drm/msm/disp/dpu1/

Re: [PATCH v3 3/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layout in the plane state and drop this call from dpu_plane_sspp_update(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/dr

Re: [PATCH v3 2/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:14 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov ---   drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 43 -

Re: [PATCH v3 1/9] drm/msm/dpu: check for overflow in _dpu_crtc_setup_lm_bounds()

2024-06-18 Thread Abhinav Kumar
On 6/13/2024 4:13 PM, Abhinav Kumar wrote: On 6/13/2024 3:36 PM, Dmitry Baryshkov wrote: Make _dpu_crtc_setup_lm_bounds() check that CRTC width is not overflowing LM requirements. Rename the function accordingly. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") Signed-off-by: Dmitry

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-18 Thread Leo Li
On 2024-06-05 22:04, Mario Limonciello wrote: When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Req

Re: [PATCH v5 05/12] drm/ttm: Provide a generic LRU walker helper

2024-06-18 Thread Matthew Brost
On Tue, Jun 18, 2024 at 09:18:13AM +0200, Thomas Hellström wrote: Replying to correct version... > Provide a generic LRU walker in TTM, in the spirit of drm_gem_lru_scan() > but building on the restartable TTM LRU functionality. > > The LRU walker optionally supports locking objects as part of >

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Alex Deucher
On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson wrote: > > Hi, > > > On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > > wrote: > > > > > > Based on grepping through the source code this driver appears to be > > > missing a call to drm_

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > wrote: > > > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among other things,

Re: [PATCH] drm/amd/display: Disable CONFIG_DRM_AMD_DC_FP for RISC-V with clang

2024-06-18 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Jun 18, 2024 at 10:17 AM Harry Wentland wrote: > > > > On 2024-06-14 15:54, Nathan Chancellor wrote: > > Commit 77acc6b55ae4 ("riscv: add support for kernel-mode FPU") and > > commit a28e4b672f04 ("drm/amd/display: use ARCH_HAS_KERNEL_FPU_SUPPORT") > > enabled supp

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Mario Limonciello
On 6/18/2024 15:20, Leo Li wrote: On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR ---   tests/amdgpu/amd_psr.c | 74 ++   1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Mario Limonciello
On 6/18/2024 15:20, Leo Li wrote: Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has in

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread André Almeida
Em 18/06/2024 14:43, Dmitry Baryshkov escreveu: On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote: Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: On Tue, 18 Jun 2024, André Almeida wrote: Drivers have different capabilities on wha

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 01:48, Joe Damato wrote: > [You don't often get email from jdam...@fastly.com. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > On Thu, Jun 13, 2024 at 11:22:02AM +0300, Omer Shpigelman wrote: >> This ethernet driver is initialized via auxiliary bus

Re: [PATCH 04/15] net: hbl_cn: QP state machine

2024-06-18 Thread Omer Shpigelman
On 6/18/24 10:08, Leon Romanovsky wrote: > On Tue, Jun 18, 2024 at 05:50:15AM +, Omer Shpigelman wrote: >> On 6/17/24 16:18, Leon Romanovsky wrote: >>> [Some people who received this message don't often get email from >>> l...@kernel.org. Learn why this is important at >>> https://aka.ms/Lear

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 14:48, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 08:08:26AM +, Omer Shpigelman wrote: >> On 6/13/24 16:0

[PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread TaoJiang
From: Ming Qian When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know whether the dma buffer is coherent or synchronized. The videobuf2-core will skip cache syncs as it think the DMA exporter should take care of cache syncs But in fact it's likely that the client doesn't synchro

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread ming qian
Hi TaoJiang, On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: From: Ming Qian When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know whether the dma buffer is coherent or synchronized. The videobuf2-core will skip cache syncs as it think the DMA exporter should take care o

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 13:55, Zhu Yanjun wrote: > [You don't often get email from yanjun@linux.dev. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > > 在 2024/6/13 16:22, Omer Shpigelman 写道: >> + >> +/* This function should be called after ctrl_lock was taken */ > > https:

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-18 Thread Omer Shpigelman
On 6/15/24 03:16, Stephen Hemminger wrote: > [You don't often get email from step...@networkplumber.org. Learn why this is > important at https://aka.ms/LearnAboutSenderIdentification ] > >> + >> +/* get the src IP as it is done in devinet_ioctl() */ >> +static int hbl_en_get_src_ip(struct hbl_au

Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 18:02, Andrew Lunn wrote: > [Some people who received this message don't often get email from > and...@lunn.ch. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 04:05:57PM +0200, Markus Elfring wrote: >> … >>> +++ b/drivers/ne

Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

2024-06-18 Thread Omer Shpigelman
On 6/17/24 22:04, Leon Romanovsky wrote: > [Some people who received this message don't often get email from > l...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Jun 17, 2024 at 05:43:49PM +, Omer Shpigelman wrote: >> On 6/13/24 22:1

Re: [PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-06-18 Thread Leo Li
On 2024-05-22 18:08, Mario Limonciello wrote: Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5 10064

Re: [PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-06-18 Thread Leo Li
Thanks for the tests! FYI IGT patches should also cc igt-...@lists.freedesktop.org Some comments inline: On 2024-05-22 18:08, Mario Limonciello wrote: From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to h

Re: [PATCH v2 1/2] drm/dp: Describe target_rr_divider in struct drm_dp_as_sdp

2024-06-18 Thread Rodrigo Vivi
On Fri, Jun 14, 2024 at 03:53:04PM -0400, Rodrigo Vivi wrote: > On Fri, Jun 14, 2024 at 09:55:57AM +0530, Mitul Golani wrote: > > Describe newly added parameter target_rr_divider in struct > > drm_dp_as_sdp. > > > > -v2: > > Remove extra line from commit message.(Lucas) > > > > Fixes: a20c6d954d7

RE: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen

2024-06-18 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Monday, June 17, 2024 11:43 AM To: intel-gfx ; dri-devel Cc: Andi Shyti ; Cavitt, Jonathan ; De Marchi, Lucas Subject: [PATCH v2 0/2] Sparse errors on the i915_gem_stolen > > Hi Jonathan, > > Commit 05da7d9f717b ("drm/i915/gem: Downgrade sto

Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

2024-06-18 Thread Dragan Simic
On 2024-06-18 12:33, Dragan Simic wrote: Hello Qiang and Maxime, On 2024-06-18 10:13, Maxime Ripard wrote: On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote: On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu wrote: > > I see the problem that initramfs need to build a module dependency chain, > b

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Konrad Dybcio
On 6/18/24 20:55, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: On 6/18/24 19:50, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: sdm845 has "General Purpose" clocks that can be muxed to SoC pins. Those clock

Re: [PATCH v4 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-18 Thread Konrad Dybcio
On 6/18/24 18:42, Rob Clark wrote: From: Rob Clark Move the CP_PROTECT settings into the hw catalog. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- [...] +static inline void __build_asserts(void) +{ + BUILD_BUG_ON(a630_protect.count > a630_protect.count_max); +

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 08:50:52PM GMT, Konrad Dybcio wrote: > > > On 6/18/24 19:50, Dmitry Baryshkov wrote: > > On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: > > > sdm845 has "General Purpose" clocks that can be muxed to > > > SoC pins. > > > > > > Those clocks may be used as

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Konrad Dybcio
On 6/18/24 19:50, Dmitry Baryshkov wrote: On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: sdm845 has "General Purpose" clocks that can be muxed to SoC pins. Those clocks may be used as e.g. PWM sources for external peripherals. Add more frequencies to the table for those clo

Re: [PATCH v3 11/23] drm/panel: Add support for S6E3HA8 panel driver

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 04:59:45PM GMT, Dzmitry Sankouski wrote: > Add support for MIPI-DSI based S6E3HA8 AMOLED panel > driver. This panel has 1440x2960 resolution, 5.8-inch physical > size, and can be found in starqltechn device. > Brightness regulation is not yet supported. > > Signed-off-by: D

Re: [PATCH] drm: bridge: simple-bridge: use devm_drm_bridge_add in probe

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 06:19:59PM GMT, Marc Gonzalez wrote: > simple_bridge_probe() calls drm_bridge_add() > Thus, drm_bridge_remove() must be called in the remove() callback. > > If we call devm_drm_bridge_add() instead, then drm_bridge_remove() > will be called automatically at device release,

Re: [PATCH 2/3] drm/vc4: Add monochrome mode to the VEC.

2024-06-18 Thread Dave Stevenson
Hi Maxime On Tue, 18 Jun 2024 at 10:28, Maxime Ripard wrote: > > Hi, > > On Fri, Feb 16, 2024 at 06:48:56PM GMT, Dave Stevenson wrote: > > The VEC supports not producing colour bursts for monochrome output. > > It also has an option for disabling the chroma input to remove > > chroma from the sig

Re: [PATCH v3 02/23] gcc-sdm845: Add rates to the GP clocks

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 04:59:36PM GMT, Dzmitry Sankouski wrote: > sdm845 has "General Purpose" clocks that can be muxed to > SoC pins. > > Those clocks may be used as e.g. PWM sources for external peripherals. > Add more frequencies to the table for those clocks so it's possible > for arbitrary p

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote: > Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: > > On Tue, 18 Jun 2024 at 12:38, Jani Nikula > > wrote: > > > > > > On Tue, 18 Jun 2024, André Almeida wrote: > > > > Drivers have different capabilities on what plane types they can

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 09:33:48AM GMT, Rob Clark wrote: > On Tue, Jun 18, 2024 at 1:30 AM Dmitry Baryshkov > wrote: > > > > On Mon, Jun 17, 2024 at 03:51:14PM GMT, Rob Clark wrote: > > > From: Rob Clark > > > > > > Introduce a6xx_info where we can stash gen specific stuff without > > > polluting

Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:48:48PM GMT, Marc Gonzalez wrote: > On 18/06/2024 00:33, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > > > >> + if (sbridge->vcc) { > >> + ret = regulator_enable(sbridge->vcc); > >> + msleep(100); > > >

Re: [PATCH 3/4] drm: bridge: simple-bridge: use only devm* in probe

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:37:15PM GMT, Marc Gonzalez wrote: > On 18/06/2024 00:28, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 06:03:01PM GMT, Marc Gonzalez wrote: > > > >> Once probe uses only devm functions, remove() becomes unnecessary. > > > > Breves vibrantesque sententiae > > >

Re: [PATCH v9 16/21] drm/mediatek: Support "Pre-multiplied" blending in OVL

2024-06-18 Thread 林睿祥

Re: [PATCH v3 07/23] dt-bindings: power: supply: add maxim,max77705

2024-06-18 Thread Rob Herring (Arm)
ry', 'power-supplies' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/power/supply/maxim,max77705-fg.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings

Re: [PATCH v3 09/23] dt-bindings: mfd: add samsung,s2dos05

2024-06-18 Thread Rob Herring (Arm)
c@60: failed to match any schema with compatible: ['samsung,s2dos05'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618-starqltechn_integration_upstream-v3-9-e3f666201...@gmail.com The base for the series is generally the lat

Re: [PATCH v3 04/23] dt-bindings: mfd: add maxim,max77705

2024-06-18 Thread Rob Herring (Arm)
7705.example.dtb: /example-0/i2c14/pmic@66/fuelgauge: failed to match any schema with compatible: ['maxim,max77705-fg'] Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: /example-0/i2c14/pmic@66/haptic: failed to match any schema with compatible: ['maxim,max77705-haptic&

[PATCH v4 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-18 Thread Rob Clark
From: Rob Clark Move the CP_PROTECT settings into the hw catalog. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 248 + drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 257 +- drivers/gpu/drm/msm/adren

[PATCH v4 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Rob Clark
From: Rob Clark Introduce a6xx_info where we can stash gen specific stuff without polluting the toplevel adreno_info struct. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 65 +-- drivers/g

[PATCH v4 3/5] drm/msm/adreno: Move hwcg regs to a6xx hw catalog

2024-06-18 Thread Rob Clark
From: Rob Clark Move the hwcg tables into the hw catalog. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 619 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 617 - drive

[PATCH v4 2/5] drm/msm/adreno: Split catalog into separate files

2024-06-18 Thread Rob Clark
From: Rob Clark Split each gen's gpu table into it's own file. Only code-motion, no functional change. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/Makefile | 5 + drivers/gpu/drm/msm/adreno/a2xx_catalog.c | 52 +

[PATCH v4 1/5] drm/msm/adreno: Split up giant device table

2024-06-18 Thread Rob Clark
From: Rob Clark Split into a separate table per generation, in preparation to move each gen's device table to it's own file. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/gpu/drm/msm/adreno/adreno_device.c | 67 +- drivers/g

[PATCH v4 0/5] drm/msm/adreno: Introduce/rework device hw catalog

2024-06-18 Thread Rob Clark
From: Rob Clark Split the single flat gpulist table into per-gen tables that exist in their own per-gen files, and start moving more info into the device table. This at least gets all the big tables of register settings out of the heart of the a6xx_gpu code. Probably more could be moved, to rem

Re: [PATCH] drm/msm/adreno: De-spaghettify the use of memory barriers

2024-06-18 Thread Akhil P Oommen
On Tue, Jun 04, 2024 at 07:35:04PM +0200, Konrad Dybcio wrote: > > > On 5/14/24 20:38, Akhil P Oommen wrote: > > On Wed, May 08, 2024 at 07:46:31PM +0200, Konrad Dybcio wrote: > > > Memory barriers help ensure instruction ordering, NOT time and order > > > of actual write arrival at other observe

Re: [PATCH v3 4/5] drm/msm/adreno: Move hwcg table into a6xx specific info

2024-06-18 Thread Rob Clark
On Tue, Jun 18, 2024 at 1:30 AM Dmitry Baryshkov wrote: > > On Mon, Jun 17, 2024 at 03:51:14PM GMT, Rob Clark wrote: > > From: Rob Clark > > > > Introduce a6xx_info where we can stash gen specific stuff without > > polluting the toplevel adreno_info struct. > > > > Signed-off-by: Rob Clark > > -

[PATCH] drm: bridge: simple-bridge: use devm_drm_bridge_add in probe

2024-06-18 Thread Marc Gonzalez
ruct platform_driver simple_bridge_driver = { .probe = simple_bridge_probe, - .remove_new = simple_bridge_remove, .driver = { .name = "simple-bridge", .of_match_table = simple_bridge_match, --- base-commit: 17b591a4a

Re: [PATCH] media: videobuf2: sync caches for dmabuf memory

2024-06-18 Thread Nicolas Dufresne
Le mardi 18 juin 2024 à 16:47 +0900, Tomasz Figa a écrit : > Hi TaoJiang, > > On Tue, Jun 18, 2024 at 4:30 PM TaoJiang wrote: > > > > From: Ming Qian > > > > When the memory type is VB2_MEMORY_DMABUF, the v4l2 device can't know > > whether the dma buffer is coherent or synchronized. > > > > T

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread André Almeida
Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: On Tue, 18 Jun 2024, André Almeida wrote: Drivers have different capabilities on what plane types they can or cannot perform async flips. Create a plane::async_flip field so each driver can choos

  1   2   3   >