Re: DRM Accel BoF at Linux Plumbers

2024-05-22 Thread Jacek Lawrynowicz
Hi, On 21.05.2024 17:10, Jeffrey Hugo wrote: > On 5/21/2024 8:41 AM, Tomeu Vizoso wrote: >> On Tue, May 21, 2024 at 2:12 PM Daniel Vetter wrote: >>> >>> On Sat, May 18, 2024 at 10:46:01AM +0200, Tomeu Vizoso wrote: Hi, I would like to use the chance at the next Plumbers to discuss

Re: [PATCH] drm/shmem-helper: Fix BUG_ON() on mmap(PROT_WRITE, MAP_PRIVATE)

2024-05-22 Thread Jacek Lawrynowicz
Hi, On 21.05.2024 14:58, Daniel Vetter wrote: > On Tue, 21 May 2024 at 14:38, Daniel Vetter wrote: >> >> On Mon, May 20, 2024 at 12:05:14PM +0200, Jacek Lawrynowicz wrote: >>> From: "Wachowski, Karol" >>> >>> Lack of check for copy-on-write (COW) mapping in drm_gem_shmem_mmap >>> allows users to

Re: [PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-22 Thread Vignesh Raman
Hi Dmitry, On 20/05/24 16:13, Dmitry Baryshkov wrote: On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote: zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.erro

Re: [PATCH net-next v9 11/14] tcp: RX path for devmem TCP

2024-05-22 Thread David Wei
On 2024-05-10 16:21, Mina Almasry wrote: > +/* On error, returns the -errno. On success, returns number of bytes sent to > the > + * user. May not consume all of @remaining_len. > + */ > +static int tcp_recvmsg_dmabuf(struct sock *sk, const struct sk_buff *skb, > + unsign

Re: [PATCH v2 3/6] drm/ci: build virtual GPU driver as module

2024-05-22 Thread Vignesh Raman
Hi Dmitry, On 21/05/24 12:39, Vignesh Raman wrote: Hi Dmitry, On 20/05/24 16:32, Dmitry Baryshkov wrote: On Fri, May 17, 2024 at 02:54:59PM +0530, Vignesh Raman wrote: With latest IGT, the tests tries to load the module and it fails. So build the virtual GPU driver for virtio as module. Why

[PULL] drm-misc-next-fixes

2024-05-22 Thread Maarten Lankhorst
drm-misc-next-fixes-2024-05-23: drm-misc-next-fixes for v6.10-rc1: - MST null deref fix. - Don't let next bridge create connector in adv7511 to make probe work. The following changes since commit 959314c438caf1b62d787f02d54a193efda38880: drm/nouveau: use tile_mode and pte_kind for VM_BIND bo al

Re: [PATCH v14 0/8] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios

2024-05-22 Thread Dave Airlie
Hey Gerd, do you have any time to look at this series again, I think at v14 we should probably consider landing it. I'm happy to give Acked-by: Dave Airlie for landing this via mm if it makes the most sense. One comment in passing, was I wonder if it makes sense for things like vm_map_ram to ha

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Rino André Johnsen
Looked through the patch series from Andri Yngvason and that does exactly what I wanted in the first place. I think that the patch series should be encouraged to be merged in as fast as possible. For the patch I have submitted, it stands on its own, since the patch series from Andri Yngvason does

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-22 Thread Boqun Feng
On Thu, May 23, 2024 at 08:15:13AM +0900, FUJITA Tomonori wrote: > Hi, > > On Wed, 22 May 2024 09:37:30 +0200 > Philipp Stanner wrote: > > >> > +/// Abstraction around a C firmware struct. > >> > +/// > >> > +/// This is a simple abstraction around the C firmware API. Just > >> > like with the C

RE: [PATCH v13] drm/bridge: it6505: fix hibernate to resume no display issue

2024-05-22 Thread kuro.chung
-Original Message- From: Robert Foss Sent: Wednesday, May 22, 2024 8:13 PM To: Maxime Ripard ; Thomas Zimmermann ; Jonas Karlman ; Daniel Vetter ; AngeloGioacchino Del Regno ; Allen Chen ; Neil Armstrong ; Laurent Pinchart ; Maarten Lankhorst ; David Airlie ; Kuro Chung (鐘仕廷) ; K

Re: [PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-22 Thread Abhinav Kumar
On 5/22/2024 1:01 PM, Dmitry Baryshkov wrote: On Wed, 22 May 2024 at 21:41, Abhinav Kumar wrote: On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: Add enum dpu_vsync_source instead of a series of defines. Use this enum to pass vsync information. Signed-off-by: Dmitry Baryshkov --- drive

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-22 Thread Abhinav Kumar
On 5/22/2024 1:05 PM, Dmitry Baryshkov wrote: On Wed, 22 May 2024 at 21:38, Abhinav Kumar wrote: On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: Command mode panels provide TE signal back to the DSI host to signal that the frame display has completed and update of the image will not cause

Re: [PATCH v9 3/8] x86/vmware: Introduce VMware hypercall API

2024-05-22 Thread Alexey Makhalov
Hi Simon, apologize for long delay On 5/11/24 8:02 AM, Simon Horman wrote: diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h ... +static inline +unsigned long vmware_hypercall3(unsigned long cmd, unsigned long in1, + uint32_t *out1, uint

Re: [RFC PATCH 7/8] rust: add firmware abstractions

2024-05-22 Thread FUJITA Tomonori
Hi, On Wed, 22 May 2024 09:37:30 +0200 Philipp Stanner wrote: >> > +/// Abstraction around a C firmware struct. >> > +/// >> > +/// This is a simple abstraction around the C firmware API. Just >> > like with the C API, firmware can >> > +/// be requested. Once requested the abstraction provides

[PATCH] drm/panel-edp: Add CMN N116BCJ-EAK

2024-05-22 Thread Haikun Zhou
Add support for the CMN N116BCJ-EAK, place the raw EDID here for subsequent reference. 00 ff ff ff ff ff ff 00 0d ae 60 11 00 00 00 00 04 22 01 04 95 1a 0e 78 02 67 75 98 59 53 90 27 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 da 1d 56 e2 50 00 20 30 30 20 a6 00 00 90 10 00 00

Re: [PATCH v14 05/28] drm/connector: hdmi: Add output BPC to the connector state

2024-05-22 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:38PM +0200, Maxime Ripard wrote: > We'll add automatic selection of the output BPC in a following patch, > but let's add it to the HDMI connector state already. > > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/display/drm_hdmi_

Re: [PATCH v14 04/28] drm/connector: hdmi: Create an HDMI sub-state

2024-05-22 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:37PM +0200, Maxime Ripard wrote: > The next features we will need to share across drivers will need to > store some parameters for drivers to use, such as the selected output > format. > > Let's create a new connector sub-state dedicated to HDMI controllers, > that wi

Re: [PATCH v14 03/28] drm/tests: connector: Add tests for drmm_connector_hdmi_init

2024-05-22 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:36PM +0200, Maxime Ripard wrote: > We just introduced a new initialization function for our connectors, so > let's build a kunit test suite for it as well. > > Reviewed-by: Dave Stevenson > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_connector_te

Re: [PATCH v14 02/28] drm/mode_object: Export drm_mode_obj_find_prop_id for tests

2024-05-22 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:35PM +0200, Maxime Ripard wrote: > We'll need to use drm_mode_obj_find_prop_id() for kunit tests to make > sure a given property has been properly created. Let's export it for > tests only. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_mode_object.c |

Re: [PATCH v14 01/28] drm/connector: Introduce an HDMI connector initialization function

2024-05-22 Thread Dmitry Baryshkov
On Tue, May 21, 2024 at 12:13:34PM +0200, Maxime Ripard wrote: > A lot of the various HDMI drivers duplicate some logic that depends on > the HDMI spec itself and not really a particular hardware > implementation. > > Output BPC or format selection, infoframe generation are good examples > of such

[PATCH v2 4/4] tests/amdgpu/amd_psr: Add support for `power saving policy` property

2024-05-22 Thread Mario Limonciello
Verify that the property has disabled PSR --- tests/amdgpu/amd_psr.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c index 9da161a09..a9f4a6aa5 100644 --- a/tests/amdgpu/amd_psr.c +++ b/tests/amdgpu/amd

[PATCH v2 3/4] tests/amdgpu/amd_abm: Add support for panel_power_saving property

2024-05-22 Thread Mario Limonciello
From: Mario Limonciello When the "panel power saving" property is set to forbidden the compositor has indicated that userspace prefers to have color accuracy and fidelity instead of power saving. Verify that the sysfs file behaves as expected in this situation. Signed-off-by: Mario Limonciello

[PATCH v2 2/4] tests/amdgpu/amd_abm: Make set_abm_level return type int

2024-05-22 Thread Mario Limonciello
From: Mario Limonciello In order to bubble of cases of expeted errors on set_abm_level() change the return type to int. Signed-off-by: Mario Limonciello --- tests/amdgpu/amd_abm.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/tests/amdg

[PATCH v2 0/4] Add support for testing power saving policy DRM property

2024-05-22 Thread Mario Limonciello
During the Display Next hackfest 2024 one of the topics discussed was the need for compositor to be able to relay intention to drivers that color fidelity or low latency is preferred over power savings. To accomplish this a new optional DRM property is being introduced called "power saving policy"

[PATCH v2 1/4] Add support for API for drivers to set power saving policy

2024-05-22 Thread Mario Limonciello
--- lib/igt_kms.c | 26 ++ lib/igt_kms.h | 6 ++ 2 files changed, 32 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index af63d13b1..4ce5e4a95 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -6581,3 +6581,29 @@ int get_num_scalers(int drm_fd, enum pipe pip

[PATCH RFC] drm/panel-edp: add fat warning against adding new panel compatibles

2024-05-22 Thread Dmitry Baryshkov
Add a fat warning against adding new panel compatibles to the panel-edp driver. All new users of the eDP panels are supposed to use the generic "edp-panel" compatible device on the AUX bus. The remaining compatibles are either used by the existing DT or were used previously and are retained for bac

[PATCH v2 1/2] drm: Introduce 'power saving policy' drm property

2024-05-22 Thread Mario Limonciello
The `power saving policy` DRM property is an optional property that can be added to a connector by a driver. This property is for compositors to indicate intent of policy of whether a driver can use power saving features that may compromise the experience intended by the compositor. Signed-off-by

[PATCH v2 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-05-22 Thread Mario Limonciello
When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Require low latency" PSR should be disabled. When the

[PATCH v2 0/2] Add support for 'power saving policy' property

2024-05-22 Thread Mario Limonciello
During the Display Next hackfest 2024 one of the topics discussed was the need for compositor to be able to relay intention to drivers that color fidelity is preferred over power savings. To accomplish this a new optional DRM property is being introduced called "power saving policy". This propert

[PATCH v3 1/2] iommu/io-pgtable-arm: Add way to debug pgtable walk

2024-05-22 Thread Rob Clark
From: Rob Clark Add an io-pgtable method to walk the pgtable returning the raw PTEs that would be traversed for a given iova access. Signed-off-by: Rob Clark --- drivers/iommu/io-pgtable-arm.c | 50 -- include/linux/io-pgtable.h | 4 +++ 2 files changed, 45

[PATCH v3 2/2] drm/msm: Extend gpu devcore dumps with pgtbl info

2024-05-22 Thread Rob Clark
From: Rob Clark In the case of iova fault triggered devcore dumps, include additional debug information based on what we think is the current page tables, including the TTBR0 value (which should match what we have in adreno_smmu_fault_info unless things have gone horribly wrong), and the pagetabl

[PATCH v3 0/2] io-pgtable-arm + drm/msm: Extend iova fault debugging

2024-05-22 Thread Rob Clark
From: Rob Clark This series extends io-pgtable-arm with a method to retrieve the page table entries traversed in the process of address translation, and then beefs up drm/msm gpu devcore dump to include this (and additional info) in the devcore dump. This is a respin of https://patchwork.freedes

Re: 6.10/regression/bisected commit c4cb23111103 causes sleeping function called from invalid context at kernel/locking/mutex.c:585

2024-05-22 Thread Chris Bainbridge
On Tue, May 21, 2024 at 02:39:06PM +0500, Mikhail Gavrilov wrote: > Hi, > Yesterday on the fresh kernel snapshot > I spotted a new bug message with follow stacktrace: > [4.307097] BUG: sleeping function called from invalid context at > kernel/locking/mutex.c:585 > [4.307135] in_atomic(): 1,

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-22 Thread Dmitry Baryshkov
On Wed, 22 May 2024 at 21:38, Abhinav Kumar wrote: > > > > On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: > > Command mode panels provide TE signal back to the DSI host to signal > > that the frame display has completed and update of the image will not > > cause tearing. Usually it is connected to

Re: [PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-22 Thread Dmitry Baryshkov
On Wed, 22 May 2024 at 21:41, Abhinav Kumar wrote: > > > > On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: > > Add enum dpu_vsync_source instead of a series of defines. Use this enum > > to pass vsync information. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/disp/dpu1/d

Re: [PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-22 Thread Dmitry Baryshkov
On Wed, 22 May 2024 at 21:39, Abhinav Kumar wrote: > > > > On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: > > Command-mode DSI panels need to signal the display controlller when > > vsync happens, so that the device can start sending the next frame. Some > > devices (Google Pixel 3) use a non-defau

Re: [PATCH 5/7] drm/msm/dpu: rework vsync_source handling

2024-05-22 Thread Abhinav Kumar
On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: The struct msm_display_info has is_te_using_watchdog_timer field which is neither used anywhere nor is flexible enough to specify different sources. Replace it with the field specifying the vsync source using enum dpu_vsync_source. Signed-off-by:

[PATCH v2 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-05-22 Thread Detlev Casanova
Add the documentation for VOP2 video ports reset clocks. One reset can be set per video port. Signed-off-by: Detlev Casanova --- .../display/rockchip/rockchip-vop2.yaml | 40 +++ 1 file changed, 40 insertions(+) diff --git a/Documentation/devicetree/bindings/display/rockc

[PATCH v2 2/3] arm64: dts: rockchip: Add VOP clock resets for rk3588s

2024-05-22 Thread Detlev Casanova
This adds the needed clock resets for all rk3588(s) based SOCs. Signed-off-by: Detlev Casanova --- arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi in

[PATCH v2 1/3] vop2: Add clock resets support

2024-05-22 Thread Detlev Casanova
At the end of initialization, each VP clock needs to be reset before they can be used. Failing to do so can put the VOP in an undefined state where the generated HDMI signal is either lost or not matching the selected mode. Signed-off-by: Detlev Casanova --- drivers/gpu/drm/rockchip/rockchip_dr

[PATCH v2 0/3] drm: rockchip: vop2: Add VP clock resets support

2024-05-22 Thread Detlev Casanova
The clock reset must be used when the VOP is configured. Skipping it can put the VOP in an unknown state where the HDMI signal is either lost or not matching the selected mode. This adds support for rk3588(s) based SoCs. Changes since v1: - Add AXI and AHB clock resets - Set maxItems for !rk3588

[pull] amdgpu, amdkfd drm-fixes-6.10

2024-05-22 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.10. The following changes since commit 5a5a10d9db77939a22e1d65fc0a4ba6b5d8f4fce: drm/buddy: Fix the warn on's during force merge (2024-05-20 06:42:12 +1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes

Re: [PATCH 4/7] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()

2024-05-22 Thread Abhinav Kumar
On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: Setting vsync source makes sense only for DSI CMD panels. Pull the is_cmd_mode condition out of the function into the calling code, so that it becomes more explicit. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.

Re: [PATCH 3/7] drm/msm/dsi: drop unused GPIOs handling

2024-05-22 Thread Abhinav Kumar
On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: Neither disp-enable-gpios nor disp-te-gpios are defined in the schema. None of the board DT files use those GPIO pins. Drop them from the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_host.c | 37 --

Re: [PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum

2024-05-22 Thread Abhinav Kumar
On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: Add enum dpu_vsync_source instead of a series of defines. Use this enum to pass vsync information. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 2 +- d

Re: [PATCH 0/7] drm/msm/dpu: handle non-default TE source pins

2024-05-22 Thread Abhinav Kumar
On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: Command-mode DSI panels need to signal the display controlller when vsync happens, so that the device can start sending the next frame. Some devices (Google Pixel 3) use a non-default pin, so additional configuration is required. Add a way to speci

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-22 Thread Abhinav Kumar
On 5/20/2024 5:12 AM, Dmitry Baryshkov wrote: Command mode panels provide TE signal back to the DSI host to signal that the frame display has completed and update of the image will not cause tearing. Usually it is connected to the first GPIO with the mdp_vsync function, which is the default. I

Re: [PATCH v2] dma-buf: handle testing kthreads creation failure

2024-05-22 Thread T.J. Mercier
On Wed, May 22, 2024 at 11:14 AM Fedor Pchelkin wrote: > > kthread creation may possibly fail inside race_signal_callback(). In > such a case stop the already started threads, put the already taken > references to them and return with error code. > > Found by Linux Verification Center (linuxtestin

RE: [PATCH] drm: xlnx: zynqmp_dpsub: Enable plane in atomic update

2024-05-22 Thread Klymenko, Anatoliy
> -Original Message- > From: Laurent Pinchart > Sent: Wednesday, May 22, 2024 11:11 AM > To: Klymenko, Anatoliy > Cc: Tomi Valkeinen ; Maarten > Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; > David Airlie ; Daniel Vetter ; > Simek, Michal ; dri- > de...@lists.freedesktop.org; linux

[PATCH v2] dma-buf: handle testing kthreads creation failure

2024-05-22 Thread Fedor Pchelkin
kthread creation may possibly fail inside race_signal_callback(). In such a case stop the already started threads, put the already taken references to them and return with error code. Found by Linux Verification Center (linuxtesting.org). Fixes: 2989f6451084 ("dma-buf: Add selftests for dma-fence

Re: [PATCH] drm: xlnx: zynqmp_dpsub: Enable plane in atomic update

2024-05-22 Thread Laurent Pinchart
On Wed, May 22, 2024 at 05:52:56PM +, Klymenko, Anatoliy wrote: > On Wednesday, May 22, 2024 8:32 AM, Laurent Pinchart wrote: > > On Mon, May 20, 2024 at 08:22:31PM -0700, Anatoliy Klymenko wrote: > > > Unconditionally enable the DPSUB layer in the corresponding atomic plane > > > update callba

Re: [PATCH v4 1/5] clk: sunxi-ng: common: Support minimum and maximum rate

2024-05-22 Thread Måns Rullgård
Frank Oltmanns writes: > Hi Måns, > > 21.05.2024 15:43:10 Måns Rullgård : > >> Frank Oltmanns writes: >> >>> The Allwinner SoC's typically have an upper and lower limit for their >>> clocks' rates. Up until now, support for that has been implemented >>> separately for each clock type. >>> >>> Im

[PATCH] drm/xe: remove unused struct 'xe_gt_desc'

2024-05-22 Thread linux
From: "Dr. David Alan Gilbert" 'xe_gt_desc' is unused since commit 1e6c20be6c83 ("drm/xe: Drop extra_gts[] declarations and XE_GT_TYPE_REMOTE"). Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/xe/xe_pci.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gp

RE: [PATCH] drm: xlnx: zynqmp_dpsub: Enable plane in atomic update

2024-05-22 Thread Klymenko, Anatoliy
Hi Laurent, Thanks a lot for the review. > -Original Message- > From: Laurent Pinchart > Sent: Wednesday, May 22, 2024 8:32 AM > To: Klymenko, Anatoliy > Cc: Tomi Valkeinen ; Maarten > Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; > David Airlie ; Daniel Vetter ; > Simek, Michal ; d

Re: [RFC PATCH v3 13/21] drm/exec: Rework contended locking

2024-05-22 Thread Thomas Hellström
On Wed, 2024-05-22 at 18:52 +0200, Christian König wrote: > Am 22.05.24 um 16:32 schrieb Thomas Hellström: > > On Wed, 2024-05-22 at 07:52 +0200, Christian König wrote: > > > Am 21.05.24 um 09:16 schrieb Thomas Hellström: > > > > If contention and backoff occurs during a drm_exec ww > > > > transac

Re: [PATCH] dma-buf: handle testing kthreads creation failure

2024-05-22 Thread T.J. Mercier
On Wed, May 22, 2024 at 5:24 AM Fedor Pchelkin wrote: > > kthread creation may possibly fail inside race_signal_callback(). In > such case stop the already started threads and return with error code. > > Found by Linux Verification Center (linuxtesting.org). > > Fixes: 2989f6451084 ("dma-buf: Add

RE: [PATCH] drm: xlnx: zynqmp_disp: Fix WARN_ON build warning

2024-05-22 Thread Klymenko, Anatoliy
Hi Laurent and Palmer, > -Original Message- > From: Laurent Pinchart > Sent: Wednesday, May 22, 2024 7:44 AM > To: Palmer Dabbelt > Cc: tomi.valkei...@ideasonboard.com; > maarten.lankho...@linux.intel.com; mrip...@kernel.org; > tzimmerm...@suse.de; airl...@gmail.com; dan...@ffwll.ch; Sim

Re: [RFC PATCH v3 13/21] drm/exec: Rework contended locking

2024-05-22 Thread Christian König
Am 22.05.24 um 16:32 schrieb Thomas Hellström: On Wed, 2024-05-22 at 07:52 +0200, Christian König wrote: Am 21.05.24 um 09:16 schrieb Thomas Hellström: If contention and backoff occurs during a drm_exec ww transaction, the contended lock is not locked again until the next orinary attempt to loc

[linux-next:master] BUILD REGRESSION 8314289a8d50a4e05d8ece1ae0445a3b57bb4d3b

2024-05-22 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 8314289a8d50a4e05d8ece1ae0445a3b57bb4d3b Add linux-next specific files for 20240522 Error/Warning: (recently discovered and may have been fixed) m68k-linux-ld: regmap-spi.c:(.text+0x272

Re: [PATCH] drm: zynqmp_dpsub: Fix an error handling path in zynqmp_dpsub_probe()

2024-05-22 Thread Laurent Pinchart
Hi Christophe, Thank you for the patch. On Mon, May 20, 2024 at 11:40:37AM +0200, Christophe JAILLET wrote: > If zynqmp_dpsub_drm_init() fails, we must undo the previous > drm_bridge_add() call. > > Fixes: be3f3042391d ("drm: zynqmp_dpsub: Always register bridge") > Signed-off-by: Christophe JAI

Re: [PATCH] drm: xlnx: zynqmp_disp: Fix WARN_ON build warning

2024-05-22 Thread Laurent Pinchart
On Wed, May 22, 2024 at 06:45:29PM +0300, Laurent Pinchart wrote: > On Wed, May 22, 2024 at 05:44:02PM +0300, Laurent Pinchart wrote: > > Hi Palmer, > > > > (CC'ing Anatoliy) > > > > Thank you for the patch. > > > > On Tue, May 21, 2024 at 07:28:15AM -0700, Palmer Dabbelt wrote: > > > From: Palm

Re: [PATCH] drm: xlnx: zynqmp_disp: Fix WARN_ON build warning

2024-05-22 Thread Laurent Pinchart
On Wed, May 22, 2024 at 05:44:02PM +0300, Laurent Pinchart wrote: > Hi Palmer, > > (CC'ing Anatoliy) > > Thank you for the patch. > > On Tue, May 21, 2024 at 07:28:15AM -0700, Palmer Dabbelt wrote: > > From: Palmer Dabbelt > > > > Without this I get warnings along the lines of > > > > dri

Re: [PATCH 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-05-22 Thread Conor Dooley
On Wed, May 22, 2024 at 11:31:36AM -0400, Detlev Casanova wrote: > On Tuesday, May 21, 2024 2:31:51 P.M. EDT Conor Dooley wrote: > > On Tue, May 21, 2024 at 01:15:46PM -0400, Detlev Casanova wrote: > > > On Wednesday, May 15, 2024 12:33:22 P.M. EDT Heiko Stübner wrote: > > > > Am Mittwoch, 15. Mai

Re: [PATCH] drm: xlnx: zynqmp_dpsub: Enable plane in atomic update

2024-05-22 Thread Laurent Pinchart
Hi Anatoliy, Thank you for the patch. On Mon, May 20, 2024 at 08:22:31PM -0700, Anatoliy Klymenko wrote: > Unconditionally enable the DPSUB layer in the corresponding atomic plane > update callback. Setting the new display mode may require disabling and > re-enabling the CRTC. This effectively re

Re: [PATCH 3/3] dt-bindings: display: vop2: Add VP clock resets

2024-05-22 Thread Detlev Casanova
On Tuesday, May 21, 2024 2:31:51 P.M. EDT Conor Dooley wrote: > On Tue, May 21, 2024 at 01:15:46PM -0400, Detlev Casanova wrote: > > On Wednesday, May 15, 2024 12:33:22 P.M. EDT Heiko Stübner wrote: > > > Am Mittwoch, 15. Mai 2024, 18:19:29 CEST schrieb Conor Dooley: > > > > On Tue, May 14, 2024 at

Re: [PATCH] drm/display/dp: fix all kernel-doc warnings

2024-05-22 Thread Randy Dunlap
On 5/22/24 2:37 AM, Dmitry Baryshkov wrote: > On Tue, May 21, 2024 at 08:59:06PM -0700, Randy Dunlap wrote: >> Hi Dmitry, >> >> On 5/20/24 3:37 AM, Dmitry Baryshkov wrote: >>> On Wed, May 15, 2024 at 05:26:42PM -0700, Randy Dunlap wrote: Fix a struct member name in &struct drm_dp_as_sdp. >>

Re: [PATCH] drm/vc4: remove all usages of of_node_put()

2024-05-22 Thread Amer Al Shanawany
On 27/04/2024 15.40, Amer Al Shanawany wrote: Use the scope-based cleanup feature to clean up 'struct device_node *' when they go out of scope, and remove all instances of of_node_put() within the same scope, to simplify function exit and avoid potential memory leaks. Suggested-by: Julia Lawall

Re: [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source

2024-05-22 Thread Rob Herring
On Mon, May 20, 2024 at 03:12:43PM +0300, Dmitry Baryshkov wrote: > Command mode panels provide TE signal back to the DSI host to signal > that the frame display has completed and update of the image will not > cause tearing. Usually it is connected to the first GPIO with the > mdp_vsync function,

Re: [PATCH] drm: xlnx: zynqmp_disp: Fix WARN_ON build warning

2024-05-22 Thread Laurent Pinchart
Hi Palmer, (CC'ing Anatoliy) Thank you for the patch. On Tue, May 21, 2024 at 07:28:15AM -0700, Palmer Dabbelt wrote: > From: Palmer Dabbelt > > Without this I get warnings along the lines of > > drivers/gpu/drm/xlnx/zynqmp_disp.c:949:14: error: logical not is only > applied to the left

Re: [RFC PATCH v3 15/21] drm/exec: Add a snapshot capability

2024-05-22 Thread Thomas Hellström
On Wed, 2024-05-22 at 15:54 +0200, Thomas Hellström wrote: > On Wed, 2024-05-22 at 13:27 +0200, Christian König wrote: > > Am 21.05.24 um 09:16 schrieb Thomas Hellström: > > > When validating a buffer object for submission, we might need to > > > lock > > > a number of object for eviction to make r

Re: [RFC PATCH v3 13/21] drm/exec: Rework contended locking

2024-05-22 Thread Thomas Hellström
On Wed, 2024-05-22 at 07:52 +0200, Christian König wrote: > Am 21.05.24 um 09:16 schrieb Thomas Hellström: > > If contention and backoff occurs during a drm_exec ww transaction, > > the contended lock is not locked again until the next orinary > > attempt to lock a dma_resv lock. However, with the

Re: [PATCH] drm/panel-edp: Add CMN N116BCJ-EAK

2024-05-22 Thread Douglas Anderson
On Wed, 22 May 2024 19:39:24 +0800, Haikun Zhou wrote: > Add support for the CMN N116BCJ-EAK, place the raw EDID here for > subsequent reference. > 00 ff ff ff ff ff ff 00 0d ae 60 11 00 00 00 00 > 04 22 01 04 95 1a 0e 78 02 67 75 98 59 53 90 27 > 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 >

Re: [PATCH] drm/panel-edp: Add CMN N116BCJ-EAK

2024-05-22 Thread Doug Anderson
Hi, On Wed, May 22, 2024 at 4:39 AM Haikun Zhou wrote: > > Add support for the CMN N116BCJ-EAK, place the raw EDID here for > subsequent reference. > 00 ff ff ff ff ff ff 00 0d ae 60 11 00 00 00 00 > 04 22 01 04 95 1a 0e 78 02 67 75 98 59 53 90 27 > 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01

Re: [RFC PATCH v3 15/21] drm/exec: Add a snapshot capability

2024-05-22 Thread Thomas Hellström
On Wed, 2024-05-22 at 13:27 +0200, Christian König wrote: > Am 21.05.24 um 09:16 schrieb Thomas Hellström: > > When validating a buffer object for submission, we might need to > > lock > > a number of object for eviction to make room for the validation. > > > > This makes it pretty likely that val

Re: [PATCH v3 2/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-22 Thread Marijn Suijten
On 2024-05-22 09:25:54, Dmitry Baryshkov wrote: > This panel driver uses DSC PPS functions and as such depends on the > DRM_DISPLAY_DP_HELPER. Select this symbol to make required functions Here and in the title: maybe this is a remnant from v2, but you split out a DRM_DISPLAY_DSC_HELPER and should

Re: [RFC PATCH v3 16/21] drm/exec: Introduce an evict mode

2024-05-22 Thread Thomas Hellström
On Wed, 2024-05-22 at 15:28 +0200, Christian König wrote: > Am 21.05.24 um 09:16 schrieb Thomas Hellström: > > Locking for eviction is in some way different from locking for > > submission: > > > > 1) We can't lock objects that are already locked for submission, > > hence DRM_EXEC_IGNORE_DUPLICATE

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Simon Ser
On Wednesday, May 22nd, 2024 at 15:36, Mario Limonciello wrote: > > To be perfectly honest with you, I haven't given that much though. I > > used the 'bpc' and 'colorspace' property in debugfs, since I could not > > find that information anywhere else. And since I also needed to verify > > the p

Re: [PATCH v2] drm/amd/display: Add pixel encoding info to debugfs

2024-05-22 Thread Mario Limonciello
+ Simon On 5/22/2024 05:07, Rino André Johnsen wrote: To be perfectly honest with you, I haven't given that much though. I used the 'bpc' and 'colorspace' property in debugfs, since I could not find that information anywhere else. And since I also needed to verify the pixel encoding being used,

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-22 Thread Maxime Ripard
Hi, On Mon, May 06, 2024 at 03:38:24PM GMT, Daniel Vetter wrote: > On Mon, May 06, 2024 at 02:05:12PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Mon, May 06, 2024 at 01:49:17PM GMT, Hans de Goede wrote: > > > Hi dma-buf maintainers, et.al., > > > > > > Various people have been working on mak

Re: [RFC PATCH v3 16/21] drm/exec: Introduce an evict mode

2024-05-22 Thread Christian König
Am 21.05.24 um 09:16 schrieb Thomas Hellström: Locking for eviction is in some way different from locking for submission: 1) We can't lock objects that are already locked for submission, hence DRM_EXEC_IGNORE_DUPLICATES must be unset. 2) We must be able to re-lock objects locked for eviction, ei

Re: [PATCH v3 2/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-22 Thread Neil Armstrong
On 22/05/2024 08:25, Dmitry Baryshkov wrote: This panel driver uses DSC PPS functions and as such depends on the DRM_DISPLAY_DP_HELPER. Select this symbol to make required functions available to the driver. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/2024042008

Re: [PATCH v3 3/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-22 Thread Neil Armstrong
On 22/05/2024 08:25, Dmitry Baryshkov wrote: Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Reviewed-by: Neil Armstrong Fixes: 069a6c0e94f9 ("drm:

Re: [PATCH 0/8] dma-buf: heaps: Support carved-out heaps and ECC related-flags

2024-05-22 Thread Maxime Ripard
On Tue, May 21, 2024 at 02:06:19PM GMT, Daniel Vetter wrote: > On Thu, May 16, 2024 at 09:51:35AM -0700, John Stultz wrote: > > On Thu, May 16, 2024 at 3:56 AM Daniel Vetter wrote: > > > On Wed, May 15, 2024 at 11:42:58AM -0700, John Stultz wrote: > > > > But it makes me a little nervous to add a

Re: Safety of opening up /dev/dma_heap/* to physically present users (udev uaccess tag) ?

2024-05-22 Thread Nicolas Dufresne
Le jeudi 16 mai 2024 à 14:20 +0300, Laurent Pinchart a écrit : > On Thu, May 16, 2024 at 07:00:31AM +, Simon Ser wrote: > > On Tuesday, May 14th, 2024 at 22:42, Laurent Pinchart wrote: > > > > > My experience on Arm platforms is that the KMS drivers offer allocation > > > for scanout buffers,

Re: [v5,3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-22 Thread Sui Jingfeng
Hi, On 5/21/24 15:57, AngeloGioacchino Del Regno wrote: +static int mtk_drm_of_ddp_path_build(struct device *dev, struct device_node *node, +struct mtk_mmsys_driver_data *data) +{ + struct device_node *ep_node; + struct of_endpoint of_ep; +

Re: [PATCH v6,14/24] media: mediatek: vcodec: Add capture format to support one plane memory

2024-05-22 Thread Andrzej Pietrasiewicz
Hi Yunfei, W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: Define one uncompressed capture format V4L2_PIX_FMT_MS21 in order to support one plane memory. The buffer size is luma + chroma, luma is stored at the start and chrome is stored at the end. Signed-off-by: Yunfei Dong --- Documentation/

Re: [PATCH v6,12/24] media: mediatek: vcodec: add interface to allocate/free secure memory

2024-05-22 Thread Andrzej Pietrasiewicz
Hi Yunfei, W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: Need to call dma heap interface to allocate/free secure memory when playing secure video. Signed-off-by: Yunfei Dong --- .../media/platform/mediatek/vcodec/Kconfig| 1 + .../mediatek/vcodec/common/mtk_vcodec_util.c | 122 ++

[PATCH] dma-buf: handle testing kthreads creation failure

2024-05-22 Thread Fedor Pchelkin
kthread creation may possibly fail inside race_signal_callback(). In such case stop the already started threads and return with error code. Found by Linux Verification Center (linuxtesting.org). Fixes: 2989f6451084 ("dma-buf: Add selftests for dma-fence") Cc: sta...@vger.kernel.org Signed-off-by:

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-05-22 Thread Andrzej Pietrasiewicz
Hi Yunfei & Jeffrey, W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: From: Jeffrey Kardatzke Adds documentation for V4L2_MEMORY_FLAG_RESTRICTED. Why not in the patch where the flag is actually being added? From that commit until this commit it would be undocumented. While at it... Signed-o

Re: [PATCH v6,09/24] media: mediatek: vcodec: allocate tee share memory

2024-05-22 Thread Andrzej Pietrasiewicz
Hi Yunfei, W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: Allocate two share memory for each lat and core hardware used to share information with optee-os. Msg buffer used to send ipi command and get ack command with optee-os, data buffer used to store vsi information which used for hardware deco

Re: [PATCH v6, 10/24] media: mediatek: vcodec: send share memory data to optee

2024-05-22 Thread Andrzej Pietrasiewicz
Hi Yunfei & Jeffrey, W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: Setting msg and vsi information to shared buffer, then call tee invoke function to send it to optee-os. Signed-off-by: Yunfei Dong --- .../vcodec/decoder/mtk_vcodec_dec_optee.c | 140 ++ .../vcodec/decode

Re: [PATCH v6,08/24] media: mediatek: vcodec: add tee client interface to communiate with optee-os

2024-05-22 Thread Andrzej Pietrasiewicz
Hi Yunfei & Jeffrey, W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: Open tee context to initialize the environment in order to communication with optee-os, then open tee session as the communication pipeline for lat and core to send data for hardware decode. Signed-off-by: Yunfei Dong --- ...

Re: [PATCH v6,02/24] v4l2: handle restricted memory flags in queue setup

2024-05-22 Thread Andrzej Pietrasiewicz
Hi Yunfei & Jeffrey, W dniu 16.05.2024 o 14:20, Yunfei Dong pisze: From: Jeffrey Kardatzke Validates the restricted memory flags when setting up a queue and ensures the queue has the proper capability. Signed-off-by: Jeffrey Kardatzke Signed-off-by: Yunfei Dong --- .../media/common/videob

Re: [v5,3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-22 Thread Sui Jingfeng
Hi, On 5/21/24 15:57, AngeloGioacchino Del Regno wrote: +static int mtk_drm_of_get_ddp_comp_type(struct device_node *node, enum mtk_ddp_comp_type *ctype) +{ + const struct of_device_id *of_id = of_match_node(mtk_ddp_comp_dt_ids, node); + + if (!of_id) + return -EINVA

Re: [PATCH v13] drm/bridge: it6505: fix hibernate to resume no display issue

2024-05-22 Thread Robert Foss
On Wed, 22 May 2024 14:55:28 +0800, kuro wrote: > From: Kuro Chung > > When the system power resumes, the TTL input of IT6505 may experience > some noise before the video signal stabilizes, necessitating a video > reset. This patch is implemented to prevent a loop of video error > interrupts, whi

Re: [v5,3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-22 Thread Sui Jingfeng
Hi, On 5/22/24 19:48, Sui Jingfeng wrote: if the not bridge is not ready 'not' -> 'next'

Re: [v5,3/3] drm/mediatek: Implement OF graphs support for display paths

2024-05-22 Thread Sui Jingfeng
Hi, Looks good to me in overall! On 5/21/24 15:57, AngeloGioacchino Del Regno wrote: It is impossible to add each and every possible DDP path combination for each and every possible combination of SoC and board: right now, this driver hardcodes configuration for 10 SoCs and this is going to gro

Re: [RFC PATCH v3 15/21] drm/exec: Add a snapshot capability

2024-05-22 Thread Christian König
Am 21.05.24 um 09:16 schrieb Thomas Hellström: When validating a buffer object for submission, we might need to lock a number of object for eviction to make room for the validation. This makes it pretty likely that validation will eventually succeed, since eventually the validating process will

Re: [PATCH v6,04/24] v4l: add documentation for restricted memory flag

2024-05-22 Thread Laurent Pinchart
Hi Jefrey, Thank you for the patch. On Thu, May 16, 2024 at 08:20:42PM +0800, Yunfei Dong wrote: > From: Jeffrey Kardatzke > > Adds documentation for V4L2_MEMORY_FLAG_RESTRICTED. > > Signed-off-by: Jeffrey Kardatzke > Signed-off-by: Yunfei Dong > --- > Documentation/userspace-api/media/v4l/

[PATCH v2 14/14] drm/msm/hdmi: wire in hpd_enable/hpd_disable bridge ops

2024-05-22 Thread Dmitry Baryshkov
The HDMI driver already has msm_hdmi_hpd_enable() and msm_hdmi_hpd_disable() functions. Wire them into the msm_hdmi_bridge_funcs, so that HPD can be enabled and disabled dynamically rather than always having HPD events generation enabled. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/

  1   2   >