Re: [RFC PATCH 16/18] drm/amdgpu: Implement SET_PRIORITY GEM op

2024-04-24 Thread Christian König
Am 25.04.24 um 08:46 schrieb Friedrich Vock: On 25.04.24 08:32, Christian König wrote: Am 24.04.24 um 18:57 schrieb Friedrich Vock: Used by userspace to adjust buffer priorities in response to changes in application demand and memory pressure. Yeah, that was discussed over and over again. One

Re: [RFC PATCH 00/18] TTM interface for managing VRAM oversubscription

2024-04-24 Thread Christian König
In general: Yes please :) But are exercising a lot of ideas we have already thrown over board over the years. The general idea Marek and I have been working on for a while now is rather to make TTM aware of userspace "clients". In other words we should start with having a TTM structure in t

Re: [PATCH v6 05/14] drm/mediatek: Set DRM mode configs accordingly

2024-04-24 Thread 胡俊光

Re: [RFC PATCH 16/18] drm/amdgpu: Implement SET_PRIORITY GEM op

2024-04-24 Thread Friedrich Vock
On 25.04.24 08:32, Christian König wrote: Am 24.04.24 um 18:57 schrieb Friedrich Vock: Used by userspace to adjust buffer priorities in response to changes in application demand and memory pressure. Yeah, that was discussed over and over again. One big design criteria is that we can't have glo

Re: [PATCH v3 03/18] ASoC: dt-bindings: mt6357: Add audio codec document

2024-04-24 Thread Krzysztof Kozlowski
On 23/04/2024 19:07, Alexandre Mergnat wrote: > > > On 09/04/2024 17:55, Krzysztof Kozlowski wrote: >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> +codec { >>> +mediatek,micbias0-microvolt = <190>; >>> +mediatek,micbias1-microvolt = <170>; >

Re: [RFC PATCH 08/18] drm/amdgpu: Don't try moving BOs to preferred domain before submit

2024-04-24 Thread Christian König
Am 24.04.24 um 18:56 schrieb Friedrich Vock: TTM now takes care of moving buffers to the best possible domain. Yeah, I've been planning to do this for a while as well. The problem is really that we need to keep the functionality. For example TTM currently doesn't have a concept of an userspa

Re: [RFC PATCH 16/18] drm/amdgpu: Implement SET_PRIORITY GEM op

2024-04-24 Thread Christian König
Am 24.04.24 um 18:57 schrieb Friedrich Vock: Used by userspace to adjust buffer priorities in response to changes in application demand and memory pressure. Yeah, that was discussed over and over again. One big design criteria is that we can't have global priorities from userspace! The backg

Re: [RFC PATCH 13/18] drm/ttm: Implement ttm_bo_update_priority

2024-04-24 Thread Christian König
Am 24.04.24 um 18:57 schrieb Friedrich Vock: Used to dynamically adjust priorities of buffers at runtime, to react to changes in memory pressure/usage patterns. And another big NAK. TTM priorities are meant to be static based on in kernel decisions which are not exposed to userspace. In othe

Re: [PATCH 10/10] arm64: dts: qcom: Add AYN Odin 2

2024-04-24 Thread Krzysztof Kozlowski
On 24/04/2024 17:29, Xilin Wu via B4 Relay wrote: > From: Xilin Wu > > AYN Odin 2 is a gaming handheld based on QCS8550, which is derived > from SM8550 but without modem RF system. > > + > +/ { > + model = "AYN Odin 2"; > + compatible = "ayn,odin2", "qcom,qcs8550", "qcom,sm8550"; > +

Re: [RFC PATCH 12/18] drm/ttm: Do not evict BOs with higher priority

2024-04-24 Thread Christian König
Am 24.04.24 um 18:57 schrieb Friedrich Vock: This makes buffer eviction significantly more stable by avoiding ping-ponging caused by low-priority buffers evicting high-priority buffers and vice versa. And creates a deny of service for the whole system by fork() bombing. This is another very bi

Re: [RFC PATCH 10/18] drm/amdgpu: Don't add GTT to initial domains after failing to allocate VRAM

2024-04-24 Thread Christian König
Am 24.04.24 um 18:57 schrieb Friedrich Vock: This adds GTT to the "preferred domains" of this buffer object, which will also prevent any attempts at moving the buffer back to VRAM if there is space. If VRAM is full, GTT will already be chosen as a fallback. Big NAK to that one, this is mandator

Re: [RFC PATCH 09/18] drm/amdgpu: Don't mark VRAM as a busy placement for VRAM|GTT resources

2024-04-24 Thread Christian König
Am 24.04.24 um 18:56 schrieb Friedrich Vock: We will never try evicting things from VRAM for these resources anyway. This affects TTM buffer uneviction logic, which would otherwise try to move these buffers into VRAM (clashing with VRAM-only allocations). You are working on outdated code. That

Re: [RFC PATCH 05/18] drm/ttm: Add option to evict no BOs in operation

2024-04-24 Thread Christian König
Am 24.04.24 um 18:56 schrieb Friedrich Vock: When undoing evictions because of decreased memory pressure, it makes no sense to try evicting other buffers. That duplicates some functionality. If a driver doesn't want eviction to happen it just needs to mark the desired placements as non-evicta

Re: [RFC PATCH 02/18] drm/ttm: Add per-BO eviction tracking

2024-04-24 Thread Christian König
Am 24.04.24 um 18:56 schrieb Friedrich Vock: Make each buffer object aware of whether it has been evicted or not. That reverts some changes we made a couple of years ago. In general the idea is that eviction isn't something we need to reverse in TTM. Rather the driver gives the desired plac

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-24 Thread Aravind Iddamsetty
On 25/04/24 04:59, Michał Winiarski wrote: > On Wed, Apr 24, 2024 at 10:42:59AM +0530, Aravind Iddamsetty wrote: >> On 24/04/24 05:19, Michał Winiarski wrote: >>> On Mon, Apr 22, 2024 at 12:27:56PM +0530, Aravind Iddamsetty wrote: PCI subsystem provides callbacks to inform the driver about a

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-24 Thread Uwe Kleine-König
Hello, On Wed, Apr 24, 2024 at 09:37:25PM +0200, Konrad Dybcio wrote: > On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: > > + > > + /* use random value to apply changes */ > > + ret = sn3112_write_reg(priv, SN3112_REG_APPLY, 0x66); > > "a random value"? sounds suspicious.. I smiled about that

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-24 Thread Uwe Kleine-König
Hello, On Wed, Apr 24, 2024 at 04:55:26PM +0100, Bryan O'Donoghue wrote: > On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > Includes should be alphabetised

Re: [PATCH 01/10] dt-bindings: pwm: Add SI-EN SN3112 PWM support

2024-04-24 Thread Uwe Kleine-König
Hello, On Wed, Apr 24, 2024 at 11:29:06PM +0800, Xilin Wu via B4 Relay wrote: > From: Junhao Xie > > Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. > > Signed-off-by: Junhao Xie Missing S-o-b for patch submitter. > + "#pwm-cells": > +const: 1 please use 3 he

Re: [PATCH v3 1/7] dt-bindings: display: panel: Add himax hx83102 panel bindings

2024-04-24 Thread cong yang
Hi, Thanks for review. Conor Dooley 于2024年4月25日周四 00:55写道: > > On Wed, Apr 24, 2024 at 10:30:04AM +0800, Cong Yang wrote: > > In V1, discussed with Doug and Linus [1], we need break out as separate > > driver for the himax83102-j02 controller. Beacuse "starry,himax83102-j02" > > and in this seri

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-24 Thread Uwe Kleine-König
Hello, On Wed, Apr 24, 2024 at 11:29:07PM +0800, Xilin Wu via B4 Relay wrote: > From: Junhao Xie > > Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. > > Signed-off-by: Junhao Xie Missing S-o-b for patch sender. > --- > drivers/pwm/Kconfig | 10 ++ > drivers/

[PATCH 3/5] gpu: host1x: Complete stream ID entry tables

2024-04-24 Thread Mikko Perttunen
From: Mikko Perttunen These tables contain fixed values to program the host1x hardware with, so fill in the missing entries. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.c | 150 +++ 1 file changed, 72 insertions(+), 78 deletions(-) diff --git

[PATCH 5/5] gpu: host1x: fence: Disable timeout on pre-silicon

2024-04-24 Thread Mikko Perttunen
From: Mikko Perttunen Timing can be wonky on pre-silicon platforms, so disable fence timeouts on pre-silicon platforms. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/fence.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fen

[PATCH 4/5] gpu: host1x: Add MLOCK recovery for rest of engines

2024-04-24 Thread Mikko Perttunen
From: Mikko Perttunen Add class IDs / MLOCKs for MLOCK recovery for rest of engines present on Tegra234. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/hw/cdma_hw.c | 12 include/linux/host1x.h | 5 + 2 files changed, 17 insertions(+) diff --git a/drivers/gpu

[PATCH 1/5] gpu: host1x: Fix _writel function declarations

2024-04-24 Thread Mikko Perttunen
From: Mikko Perttunen Some of the _writel functions in dev.h had the r and v parameters swapped. Fix this to avoid confusion. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/dev.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/host1x/dev.h b/drivers

[PATCH 2/5] gpu: host1x: Handle CDMA wraparound when debug printing

2024-04-24 Thread Mikko Perttunen
From: Mikko Perttunen During channel debug information dump, when printing CDMA opcodes, the circular nature of the CDMA pushbuffer wasn't being taken into account, sometimes accessing past the end. Change the printing to take this into account. Signed-off-by: Mikko Perttunen --- drivers/gpu/h

Re: [PATCH RESEND v9 3/8] drm: atmel_hlcdc: replace regmap_read with regmap_read_poll_timeout

2024-04-24 Thread Dharma.B
On 24/04/24 11:03 am, Manikandan Muralidharan wrote: > Replace regmap_read with regmap_read_poll_timeout to neatly handle > retries > > Signed-off-by: Manikandan Muralidharan Acked-by: Dharma Balasubiramani > --- > .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c| 44 +++ > 1

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-24 Thread Aravind Iddamsetty
On 24/04/24 16:42, Nilawar, Badal wrote: > > > On 24-04-2024 08:42, Aravind Iddamsetty wrote: >> >> On 23/04/24 20:34, Nilawar, Badal wrote: >>> >>> >>> On 22-04-2024 12:27, Aravind Iddamsetty wrote: PCI subsystem provides callbacks to inform the driver about a request to do function le

[GIT PULL] exynos-drm-next

2024-04-24 Thread Inki Dae
Hi Dave and Daniel, Just two cleanups - one is remove the .owner field from the platform_driver declarations in Exynos DRM modules and other is to drop the device_node cleanup code in exynos_hdmi.c using the scope-based resource management. Please kindly let me know if there is any probl

[PATCH] drm/amd/display: Remove duplicate dcn401/dcn401_clk_mgr.h header

2024-04-24 Thread Jiapeng Chong
./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_mgr.c: dcn401/dcn401_clk_mgr.h is included more than once. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8885 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn401/dcn401_clk_m

Re: [PATCH v2 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-04-24 Thread 胡俊光

[PATCH] drm/amd/display: Remove duplicate spl/dc_spl_types.h header

2024-04-24 Thread Jiapeng Chong
./drivers/gpu/drm/amd/display/dc/inc/hw/transform.h: spl/dc_spl_types.h is included more than once. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8884 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/dc/inc/hw/transform.h | 2 -- 1 file changed, 2

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-24 Thread Jason Gunthorpe
On Wed, Apr 24, 2024 at 11:59:18PM +, Zeng, Oak wrote: > Hi Jason, > > I went through the conversation b/t you and Matt. I think we are pretty much > aligned. Here is what I get from this threads: > > 1) hmm range fault size, gpu page table map size : you prefer bigger > gpu vma size and vma

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-24 Thread Junhao Xie
On 2024/4/25 03:37, Konrad Dybcio wrote: > On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: >> From: Junhao Xie >> >> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. >> >> Signed-off-by: Junhao Xie >> --- >[...] >> +    return sn3112_write_reg(priv, SN3112_REG_PWM_EN + re

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Wed, Apr 24, 2024 at 4:37 PM Dmitry Baryshkov wrote: > > On Thu, 25 Apr 2024 at 02:25, Doug Anderson wrote: > > > > Hi, > > > > On Wed, Apr 24, 2024 at 3:51 PM Dmitry Baryshkov > > wrote: > > > > > > On Thu, 25 Apr 2024 at 01:15, Hsin-Yi Wang wrote: > > > > > > > > On Wed, Apr 24, 2024

[PATCH] drm/mipi-dsi: Reduce driver bloat of mipi_dsi_*_write_seq()

2024-04-24 Thread Douglas Anderson
The consensus of many DRM folks is that we want to move away from DSI drivers defining tables of init commands. Instead, we want to move to init functions that can use common DRM functions. The issue thus far has been that using the macros mipi_dsi_generic_write_seq() and mipi_dsi_dcs_write_seq() b

RE: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-24 Thread Zeng, Oak
Hi Jason, I went through the conversation b/t you and Matt. I think we are pretty much aligned. Here is what I get from this threads: 1) hmm range fault size, gpu page table map size : you prefer bigger gpu vma size and vma can be sparsely mapped to gpu. Our vma size is configurable through a

[linux-next:master] BUILD REGRESSION 5e4f84f18c4ee9b0ccdc19e39b7de41df21699dd

2024-04-24 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 5e4f84f18c4ee9b0ccdc19e39b7de41df21699dd Add linux-next specific files for 20240424 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404242144.8931hnhx-...@intel.com https

Re: [PATCH] video: fbdev: au1200fb: replace deprecated strncpy with strscpy

2024-04-24 Thread Kees Cook
On Wed, Mar 20, 2024 at 11:48:52PM +0100, Helge Deller wrote: > On 3/20/24 23:35, Justin Stitt wrote: > > Hi, > > > > On Wed, Mar 20, 2024 at 12:56 AM Helge Deller wrote: > > > > > > On 3/19/24 00:46, Justin Stitt wrote: > > > > strncpy() is deprecated for use on NUL-terminated destination strin

Re: [PATCH 06/10] arm64: dts: qcom: sm8550: Add UART15

2024-04-24 Thread Dmitry Baryshkov
On Wed, 24 Apr 2024 at 18:30, Xilin Wu via B4 Relay wrote: > > From: Xilin Wu > > Add uart15 node for UART bus present on sm8550 SoC. > > Signed-off-by: Molly Sophia > Signed-off-by: Xilin Wu > --- > arch/arm64/boot/dts/qcom/sm8550.dtsi | 22 ++ > 1 file changed, 22 inserti

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 02:25, Doug Anderson wrote: > > Hi, > > On Wed, Apr 24, 2024 at 3:51 PM Dmitry Baryshkov > wrote: > > > > On Thu, 25 Apr 2024 at 01:15, Hsin-Yi Wang wrote: > > > > > > On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov > > > wrote: > > > > > > > > On Thu, 25 Apr 2024 at 00:

Re: [PATCH v3 4/4] drm/xe/FLR: Support PCIe FLR

2024-04-24 Thread Michał Winiarski
On Wed, Apr 24, 2024 at 10:42:59AM +0530, Aravind Iddamsetty wrote: > > On 24/04/24 05:19, Michał Winiarski wrote: > > On Mon, Apr 22, 2024 at 12:27:56PM +0530, Aravind Iddamsetty wrote: > >> PCI subsystem provides callbacks to inform the driver about a request to > >> do function level reset by u

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Wed, Apr 24, 2024 at 3:51 PM Dmitry Baryshkov wrote: > > On Thu, 25 Apr 2024 at 01:15, Hsin-Yi Wang wrote: > > > > On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov > > wrote: > > > > > > On Thu, 25 Apr 2024 at 00:04, Doug Anderson wrote: > > > > > > > > Hi, > > > > > > > > On Tue, Apr 2

[PATCH v9 2/8] x86/vmware: Move common macros to vmware.h

2024-04-24 Thread Alexey Makhalov
Move VMware hypercall macros to vmware.h. This is a prerequisite for the introduction of vmware_hypercall API. No functional changes besides exporting vmware_hypercall_mode symbol. Signed-off-by: Alexey Makhalov Reviewed-by: Nadav Amit --- arch/x86/include/asm/vmware.h | 72

[PATCH v9 1/8] x86/vmware: Correct macro names

2024-04-24 Thread Alexey Makhalov
VCPU_RESERVED and LEGACY_X2APIC are not VMware hypercall commands. These are bits in return value of VMWARE_CMD_GETVCPU_INFO command. Change VMWARE_CMD_ prefix to GETVCPU_INFO_ one. And move bit-shift operation to the macro body. Signed-off-by: Alexey Makhalov --- arch/x86/kernel/cpu/vmware.c |

Re: [PATCH v8 1/7] x86/vmware: Move common macros to vmware.h

2024-04-24 Thread Alexey Makhalov
On 4/24/24 9:06 AM, Borislav Petkov wrote: On Mon, Apr 22, 2024 at 03:56:50PM -0700, Alexey Makhalov wrote: Move VMware hypercall macros to vmware.h. This is a prerequisite for the introduction of vmware_hypercall API. No functional changes besides exporting vmware_hypercall_mode symbol. We

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 01:15, Hsin-Yi Wang wrote: > > On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov > wrote: > > > > On Thu, 25 Apr 2024 at 00:04, Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov > > > wrote: > > > > > > > > On Tue, Apr 23, 20

Re: [PATCH 07/10] arm64: dts: qcom: sm8550: Update EAS properties

2024-04-24 Thread Bryan O'Donoghue
On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote: From: Xilin Wu The original values provided by Qualcomm appear to be quite inaccurate. Specifically, some heavy gaming tasks could be improperly assigned to the A510 cores by the scheduler, resulting in a CPU bottleneck. This update to the EAS p

Re: [PATCH v2 2/7] drm/panel: himax-hx83102: Break out as separate driver

2024-04-24 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 7:42 PM cong yang wrote: > > Hi, > Thanks reply. > > Doug Anderson 于2024年4月24日周三 00:26写道: > > > > Hi, > > > > On Tue, Apr 23, 2024 at 2:37 AM cong yang > > wrote: > > > > > > > > +static int starry_init_cmd(struct hx83102 *ctx) > > > > > +{ > > > > > + struct

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov wrote: > > > The problem is that with these panels that need big init sequences the > > code based solution is _a lot_ bigger. If it were a few bytes or a > > 1-2KB then fine, but when Hsin-Yi measured Linus W's attempt to move > > from a table

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Hsin-Yi Wang
On Wed, Apr 24, 2024 at 2:49 PM Dmitry Baryshkov wrote: > > On Thu, 25 Apr 2024 at 00:04, Doug Anderson wrote: > > > > Hi, > > > > On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov > > wrote: > > > > > > On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > > > > Hi, > > > > > > > > On

Re: [RFC PATCH net-next v8 04/14] netdev: support binding dma-buf to netdevice

2024-04-24 Thread Mina Almasry
On Wed, Apr 24, 2024 at 10:36 AM David Wei wrote: > > On 2024-04-02 5:20 pm, Mina Almasry wrote: > > + /* We hold the rtnl_lock while binding/unbinding dma-buf, so we can't > > + * race with another thread that is also modifying this value. > > However, > > + * the driver may read t

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Dmitry Baryshkov
On Thu, 25 Apr 2024 at 00:04, Doug Anderson wrote: > > Hi, > > On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov > wrote: > > > > On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Tue, Apr 23, 2024 at 11:10 AM Hsin-Yi Wang wrote: > > > > > > > > > > > > +#def

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Hsin-Yi Wang
On Wed, Apr 24, 2024 at 2:05 PM Doug Anderson wrote: > > Hi, > > On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov > wrote: > > > > On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Tue, Apr 23, 2024 at 11:10 AM Hsin-Yi Wang wrote: > > > > > > > > > > > > +#d

Re: [PATCH v1 2/2] drm/panel: kd101ne3: add new panel driver

2024-04-24 Thread Doug Anderson
Hi, On Tue, Apr 23, 2024 at 2:20 PM Dmitry Baryshkov wrote: > > On Tue, Apr 23, 2024 at 01:41:59PM -0700, Doug Anderson wrote: > > Hi, > > > > On Tue, Apr 23, 2024 at 11:10 AM Hsin-Yi Wang wrote: > > > > > > > > > > +#define _INIT_DCS_CMD(...) { \ > > > > > > > + .type = INIT_DCS_CMD, \ > >

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-24 Thread Lucas De Marchi
On Mon, Apr 22, 2024 at 03:10:10PM GMT, Jani Nikula wrote: drivers/gpu/drm/xe/xe_debugfs.c | 1 + drivers/gpu/drm/xe/xe_gt_debugfs.c | 2 ++ drivers/gpu/drm/xe/xe_uc_debugfs.c | 2 ++ Acked-by: Lucas De Marchi thanks Lucas De Marchi

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-24 Thread Lyude Paul
For the nouveau bits: Reviewed-by: Lyude Paul On Mon, 2024-04-22 at 15:10 +0300, Jani Nikula wrote: > Surprisingly many places depend on debugfs.h to be included via > drm_print.h. Fix them. > > v3: Also fix armada, ite-it6505, imagination, msm, sti, vc4, and xe > > v2: Also fix ivpu and vmwgf

Re: [PATCH v8 0/6] drm/{i915,xe}: Convert fbdev to DRM client

2024-04-24 Thread Lucas De Marchi
On Tue, Apr 09, 2024 at 10:04:22AM GMT, Thomas Zimmermann wrote: (was: drm/i915: Convert fbdev to DRM client) Convert i915's fbdev code to struct drm_client. Replaces the current ad-hoc integration. The conversion includes a number of cleanups. Also update the xe driver accordingly. As with the

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-04-24 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. The following changes since commit ed30a4a51bb196781c8058073ea720133a65596f: Linux 6.9-rc5 (2024-04-21 12:35:54 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.9-2024-04-24 for you to fetch c

Re: [PATCH v6 03/10] PCI: Warn users about complicated devres nature

2024-04-24 Thread Bjorn Helgaas
On Mon, Apr 08, 2024 at 10:44:15AM +0200, Philipp Stanner wrote: > The PCI region-request functions become managed functions when > pcim_enable_device() has been called previously instead of > pci_enable_device(). > > This has already caused bugs by confusing users, who came to believe > that all

Re: [PATCH v6 04/10] PCI: Make devres region requests consistent

2024-04-24 Thread Bjorn Helgaas
On Mon, Apr 08, 2024 at 10:44:16AM +0200, Philipp Stanner wrote: > Now that pure managed region request functions are available, the > implementation of the hybrid-functions which are only sometimes managed > can be made more consistent and readable by wrapping those > always-managed functions. >

Re: [PATCH v6 00/10] Make PCI's devres API more consistent

2024-04-24 Thread Bjorn Helgaas
On Mon, Apr 08, 2024 at 10:44:12AM +0200, Philipp Stanner wrote: > ... > PCI's devres API suffers several weaknesses: > > 1. There are functions prefixed with pcim_. Those are always managed >counterparts to never-managed functions prefixed with pci_ – or so one >would like to think. There

Re: [PATCH 05/10] arm64: dts: qcom: pmk8550: Add PWM controller

2024-04-24 Thread Konrad Dybcio
On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: From: Xilin Wu Add the PWM function to the pmk8550 dtsi, which is usually used to control PWM backlight on platforms using this PMIC. Signed-off-by: Xilin Wu --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-24 Thread Konrad Dybcio
On 4/24/24 17:29, Xilin Wu via B4 Relay wrote: From: Junhao Xie Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. Signed-off-by: Junhao Xie --- [...] +static int sn3112_set_en_reg(struct sn3112 *priv, unsigned int channel, +bool enab

Re: [PATCH 1/1] video: Handle HAS_IOPORT dependencies

2024-04-24 Thread Helge Deller
On 4/22/24 21:28, Arnd Bergmann wrote: On Mon, Apr 22, 2024, at 10:34, Niklas Schnelle wrote: On Thu, 2024-04-11 at 16:00 +0200, Helge Deller wrote: * Niklas Schnelle : In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to #ifdef functions and th

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-24 Thread Dmitry Baryshkov
On Wed, 24 Apr 2024 at 19:45, Andy Shevchenko wrote: > > On Wed, Apr 24, 2024 at 07:34:54PM +0300, Dmitry Baryshkov wrote: > > On Wed, Apr 24, 2024 at 05:52:03PM +0300, Andy Shevchenko wrote: > > > On Wed, Apr 24, 2024 at 04:34:39PM +0300, Dmitry Baryshkov wrote: > > > > On Wed, 24 Apr 2024 at 16:

Re: [PATCH 02/10] pwm: Add SI-EN SN3112 PWM support

2024-04-24 Thread BigfootACA
On 24/4/2024 23:55, Bryan O'Donoghue wrote: > On 24/04/2024 16:29, Xilin Wu via B4 Relay wrote: >> From: Junhao Xie >> >> Add a new driver for the SI-EN SN3112 12-channel 8-bit PWM LED controller. >> >> Signed-off-by: Junhao Xie >> --- >>   drivers/pwm/Kconfig  |  10 ++ >>   drivers/pwm/Makef

RE: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-24 Thread Deucher, Alexander
[Public] > -Original Message- > From: Jani Nikula > Sent: Wednesday, April 24, 2024 9:55 AM > To: dri-devel@lists.freedesktop.org > Cc: Andrzej Hajda ; Maxime Ripard > ; Jacek Lawrynowicz > ; Stanislaw Gruszka > ; Oded Gabbay ; > Russell King ; David Airlie ; Daniel > Vetter ; Neil Armstr

[PATCH v3 6/6] drm/i915/alpm: Add debugfs for LOBF

2024-04-24 Thread Animesh Manna
For validation purpose add debugfs for LOBF. Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_alpm.c | 48 +++ drivers/gpu/drm/i915/display/intel_alpm.h | 2 + .../drm/i915/display/intel_display_debugfs.c | 2 + 3 files changed, 52 insertions(+) dif

[PATCH v3 5/6] drm/i915/alpm: Enable lobf from source in ALPM_CTL

2024-04-24 Thread Animesh Manna
Set the Link Off Between Frames Enable bit in ALPM_CTL register. Note: Lobf need to be enabled adaptive sync fixed refresh mode where vmin = vmax = flipline, which will arise after cmmr feature enablement. Will add enabling sequence in a separate patch. Signed-off-by: Animesh Manna --- drivers/

Re: [PATCH v4 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support

2024-04-24 Thread Tomi Valkeinen
Hi Sean, On 23/04/2024 20:18, Sean Anderson wrote: This series cleans up the zyqnmp_dp IRQ and locking situation. Once that's done, it adds debugfs support. The intent is to enable compliance testing or to help debug signal-integrity issues. Last time I discussed converting the HPD work(s) to a

[PATCH v3 4/6] drm/i915/alpm: Add compute config for lobf

2024-04-24 Thread Animesh Manna
Link Off Between Active Frames, is a new feature for eDP that allows the panel to go to lower power state after transmission of data. This is a feature on top of ALPM, AS SDP. Add compute config during atomic-check phase. v1: RFC version. v2: Add separate flag for auxless-alpm. [Jani] v3: - intel_

[PATCH v3 3/6] drm/display: Add missing aux less alpm wake related bits

2024-04-24 Thread Animesh Manna
From: Jouni Högander eDP1.5 adds some more bits into DP_RECEIVER_ALPM_CAP and DP_RECEIVER_ALPM_CONFIG registers. Add definitions for these. Signed-off-by: Jouni Högander --- include/drm/display/drm_dp.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/drm/display

[PATCH v3 2/6] drm/i915/alpm: Move alpm related code to a new file

2024-04-24 Thread Animesh Manna
Move ALPM feature related code as it will be used for non-psr panel also thorugh LOBF feature. v1: Initial version. v2: Correct ordering in makefile. [Jani] Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_alpm.c | 292 ++

[PATCH v3 1/6] drm/i915/alpm: Move alpm parameters from intel_psr

2024-04-24 Thread Animesh Manna
ALPM can be enabled for non psr panel and currenly aplm-params are encapsulated under intel_psr struct, so moving out to intel_dp struct. Signed-off-by: Animesh Manna --- .../drm/i915/display/intel_display_types.h| 21 + drivers/gpu/drm/i915/display/intel_psr.c | 43 +---

[PATCH v3 0/6] Link off between frames for edp

2024-04-24 Thread Animesh Manna
Link Off Between Active Frames (LOBF) allows an eDP link to be turned Off and On durning long VBLANK durations without enabling any of the PSR/PSR2/PR modes of operation. Bspec: 71477 Note: These patches are not tested, sending early for review feedback. Signed-off-by: Animesh Manna Animesh M

Re: [PATCH 2/2] drm/amd/display: Fix CFLAGS for dml2_core_dcn4_calcs.o

2024-04-24 Thread Pillai, Aurabindo
[AMD Official Use Only - General] Thanks for the fix. Reviewed-by: Aurabindo Pillai -- Regards, Jay From: Nathan Chancellor Sent: Wednesday, April 24, 2024 2:19 PM To: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira, Rodrigo ; Deucher, Alexander ; Koenig, Ch

Re: [PATCH v2] software node: Implement device_get_match_data fwnode callback

2024-04-24 Thread Sui Jingfeng
Hi, On 2024/4/25 00:34, Dmitry Baryshkov wrote: On Wed, Apr 24, 2024 at 05:52:03PM +0300, Andy Shevchenko wrote: On Wed, Apr 24, 2024 at 04:34:39PM +0300, Dmitry Baryshkov wrote: On Wed, 24 Apr 2024 at 16:11, Andy Shevchenko wrote: On Wed, Apr 24, 2024 at 12:37:16AM +0300, Dmitry Baryshkov

[PATCH 2/2] drm/amd/display: Fix CFLAGS for dml2_core_dcn4_calcs.o

2024-04-24 Thread Nathan Chancellor
-Wframe-larger-than=2048 is a part of both CFLAGS and CFLAGS_REMOVE for dml2_core_dcn4_calcs.o, which means that it ultimately gets removed altogether for 64-bit targets, as 2048 is the default FRAME_WARN value for 64-bit platforms, resulting in no -Wframe-larger-than coverage for this file. Remov

[PATCH 1/2] drm/amd/display: Add frame_warn_flag to dml2_core_shared.o

2024-04-24 Thread Nathan Chancellor
When building with tip of tree Clang, there are some new instances of -Wframe-larger-than from the new display code (which become fatal with CONFIG_WERROR=y): drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:754:6: error: stack frame size (2488) exceeds limi

[PATCH 0/2] drm/amd/display: Use frame_warn_flag consistently in dml2 Makefile

2024-04-24 Thread Nathan Chancellor
-id: 20240424-amdgpu-dml2-fix-frame-larger-than-dcn401-48ff7e1f51ea Best regards, -- Nathan Chancellor

Re: [PATCH 06/23] drm/xe/svm: Introduce a helper to build sg table from hmm range

2024-04-24 Thread Jason Gunthorpe
On Wed, Apr 24, 2024 at 04:56:57PM +, Matthew Brost wrote: > > What "meta data" is there for a SVA mapping? The entire page table is > > an SVA. > > If we have allocated memory for GPU page tables in the range, This is encoded directly in the radix tree. > if range > has been invalidated,

Re: [RFC PATCH net-next v8 04/14] netdev: support binding dma-buf to netdevice

2024-04-24 Thread David Wei
On 2024-04-02 5:20 pm, Mina Almasry wrote: > Add a netdev_dmabuf_binding struct which represents the > dma-buf-to-netdevice binding. The netlink API will bind the dma-buf to > rx queues on the netdevice. On the binding, the dma_buf_attach > & dma_buf_map_attachment will occur. The entries in the sg

Re: [PATCH v2 3/3] drm/panthor: Enable fdinfo for memory stats

2024-04-24 Thread Liviu Dudau
Hello, On Tue, Apr 23, 2024 at 10:32:36PM +0100, Adrián Larumbe wrote: > When vm-binding an already-created BO, the entirety of its virtual size is > then backed by system memory, so its RSS is always the same as its virtual > size. How is that relevant to this patch? Or to put it differently: ho

Re: [PATCH v3 0/4] Add display support for stm32mp135f-dk board

2024-04-24 Thread Alexandre TORGUE
Hi Raphael On 2/23/24 13:36, Raphael Gallais-Pou wrote: This serie aims to enable display support for the stm32mp135f-dk board Those are only patches of the device-tree since the driver support has already been added [1]. It respectivelly: - adds support for the display controller on s

[RFC PATCH 17/18] drm/amdgpu: Implement EVICTED_VRAM query

2024-04-24 Thread Friedrich Vock
Used by userspace to gauge the severity of memory overcommit and make prioritization decisions based on it. Used by userspace to gauge the severity of memory overcommit and make prioritization decisions based on it. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 +

[RFC PATCH 16/18] drm/amdgpu: Implement SET_PRIORITY GEM op

2024-04-24 Thread Friedrich Vock
Used by userspace to adjust buffer priorities in response to changes in application demand and memory pressure. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 20 include/uapi/drm/amdgpu_drm.h | 1 + 2 files changed, 21 insertions(+)

[RFC PATCH 11/18] drm/ttm: Bump BO priority count

2024-04-24 Thread Friedrich Vock
For adjustable priorities by userspace, it is nice to have a bit more granularity. Signed-off-by: Friedrich Vock --- include/drm/ttm/ttm_resource.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/ttm/ttm_resource.h b/include/drm/ttm/ttm_resource.h index 7d1ce059c8

[RFC PATCH 10/18] drm/amdgpu: Don't add GTT to initial domains after failing to allocate VRAM

2024-04-24 Thread Friedrich Vock
This adds GTT to the "preferred domains" of this buffer object, which will also prevent any attempts at moving the buffer back to VRAM if there is space. If VRAM is full, GTT will already be chosen as a fallback. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 4 --

[RFC PATCH 15/18] drm/amdgpu: Set a default priority for user/kernel BOs

2024-04-24 Thread Friedrich Vock
Reserve the highest priority for the kernel, and choose a balanced value as userspace default. Userspace is intended to be able to modify these later to mark buffers as important/unimportant. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c| 1 + drivers/gpu/drm/amd/

[RFC PATCH 07/18] drm/amdgpu: Add TTM uneviction control functions

2024-04-24 Thread Friedrich Vock
Try unevicting only VRAM/GTT BOs. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 50 + 1 file changed, 50 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 64f5001a7dc5d..98e8a

[RFC PATCH 00/18] TTM interface for managing VRAM oversubscription

2024-04-24 Thread Friedrich Vock
Hi everyone, recently I've been looking into remedies for apps (in particular, newer games) that experience significant performance loss when they start to hit VRAM limits, especially on older or lower-end cards that struggle to fit both desktop apps and all the game data into VRAM at once. The r

[RFC PATCH 01/18] drm/ttm: Add tracking for evicted memory

2024-04-24 Thread Friedrich Vock
These utilities will be used to keep track of what buffers have been evicted from any particular place, to try and decide when to try undoing the eviction. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_device.c | 1 + drivers/gpu/drm/ttm/ttm_resource.c | 14 ++ include

[RFC PATCH 14/18] drm/ttm: Consider BOs placed in non-favorite locations evicted

2024-04-24 Thread Friedrich Vock
If we didn't get the favorite placement because it was full, we should try moving it into the favorite placement once there is space. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_bo.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/dr

[RFC PATCH 18/18] drm/amdgpu: Bump minor version

2024-04-24 Thread Friedrich Vock
Indicates support for EVICTED_VRAM queries and AMDGPU_GEM_OP_SET_PRIORITY Signed-off-by: Friedrich Vock --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_d

[RFC PATCH 03/18] drm/ttm: Implement BO eviction tracking

2024-04-24 Thread Friedrich Vock
For each buffer object, remember evictions and try undoing them if memory pressure gets lower again. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_bo.c | 28 +++- drivers/gpu/drm/ttm/ttm_bo_util.c | 3 +++ 2 files changed, 30 insertions(+), 1 deletion(-)

[RFC PATCH 13/18] drm/ttm: Implement ttm_bo_update_priority

2024-04-24 Thread Friedrich Vock
Used to dynamically adjust priorities of buffers at runtime, to react to changes in memory pressure/usage patterns. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_bo.c | 17 + include/drm/ttm/ttm_bo.h | 2 ++ 2 files changed, 19 insertions(+) diff --git a/drivers

[RFC PATCH 12/18] drm/ttm: Do not evict BOs with higher priority

2024-04-24 Thread Friedrich Vock
This makes buffer eviction significantly more stable by avoiding ping-ponging caused by low-priority buffers evicting high-priority buffers and vice versa. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_bo.c | 9 +++-- drivers/gpu/drm/ttm/ttm_resource.c | 5 +++-- include/dr

[RFC PATCH 06/18] drm/ttm: Add public buffer eviction/uneviction functions

2024-04-24 Thread Friedrich Vock
For now, they are only used internally inside TTM, but this will change with the introduction of dynamic buffer priorities. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_bo.c | 168 ++- include/drm/ttm/ttm_bo.h | 6 ++ 2 files changed, 172 insert

[RFC PATCH 02/18] drm/ttm: Add per-BO eviction tracking

2024-04-24 Thread Friedrich Vock
Make each buffer object aware of whether it has been evicted or not. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_bo.c | 1 + include/drm/ttm/ttm_bo.h | 11 +++ 2 files changed, 12 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c i

[RFC PATCH 05/18] drm/ttm: Add option to evict no BOs in operation

2024-04-24 Thread Friedrich Vock
When undoing evictions because of decreased memory pressure, it makes no sense to try evicting other buffers. Signed-off-by: Friedrich Vock --- drivers/gpu/drm/ttm/ttm_bo.c | 2 ++ include/drm/ttm/ttm_bo.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/

  1   2   >