Re: [PATCH v3 2/2] misc: sram: Add DMA-BUF Heap exporting of SRAM areas

2024-04-19 Thread Greg Kroah-Hartman
On Fri, Apr 19, 2024 at 06:57:47PM +0200, Christian Gmeiner wrote: > Am Di., 9. Apr. 2024 um 14:14 Uhr schrieb Greg Kroah-Hartman > : > > > > On Tue, Apr 09, 2024 at 02:06:05PM +0200, Pascal FONTAIN wrote: > > > From: Andrew Davis > > > > > > This new export type exposes to userspace the SRAM area

[PATCH v2 6/9] drm/msm: convert msm_format::unpack_tight to the flag

2024-04-19 Thread Dmitry Baryshkov
Instead of having a u8 or bool field unpack_tight, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 22 drivers/gp

[PATCH v2 4/9] drm/msm/dpu: pull format flag definitions to mdp_format.h

2024-04-19 Thread Dmitry Baryshkov
In preparation to merger of formats databases, pull format flag definitions to mdp_format.h header, so that they are visibile to both dpu and mdp drivers. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 98 ++--- drivers/gpu/drm/msm/disp/

[PATCH v2 9/9] drm/msm: drop msm_kms_funcs::get_format() callback

2024-04-19 Thread Dmitry Baryshkov
Now as all subdrivers were converted to use common database of formats, drop the get_format() callback and use mdp_get_format() directly. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 4 ++-- drivers/gpu/drm/msm/disp/dpu1/d

[PATCH v2 8/9] drm/msm: merge dpu format database to MDP formats

2024-04-19 Thread Dmitry Baryshkov
Finally remove duplication between DPU and generic MDP code by merging DPU format lists to the MDP format database. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 4 +- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 7 +- drivers/gpu/drm/msm/di

[PATCH v2 3/9] drm/msm/dpu: in dpu_format replace bitmap with unsigned long field

2024-04-19 Thread Dmitry Baryshkov
Using bitmap for the flags results in a clumsy syntax on test_bit, replace it with unsigned long type and simple binary ops. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_m

[PATCH v2 7/9] drm/msm: convert msm_format::unpack_align_msb to the flag

2024-04-19 Thread Dmitry Baryshkov
Instead of having a u8 or bool field unpack_align_msb, convert it to the flag, this save space in the tables and allows us to handle all booleans in the same way. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 12 ++-- driver

[PATCH v2 5/9] drm/msm: merge dpu_format and mdp_format in struct msm_format

2024-04-19 Thread Dmitry Baryshkov
Structures dpu_format and mdp_format are largely the same structures. In order to remove duplication between format databases, merge these two stucture definitions into the global struct msm_format. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu

[PATCH v2 1/9] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-19 Thread Dmitry Baryshkov
Instead of having DPU-specific defines, switch to the definitions from the mdp_common.xml.h file. This is the preparation for merged of DPU and MDP format tables. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c| 8 +- .../gpu/

[PATCH v2 2/9] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Dmitry Baryshkov
MDP4 and MDP5 drivers enumerate supported formats each time the plane is created. In preparation to merger of MDP DPU format databases, define precise formats list, so that changes to the database do not cause the driver to add unsupported format to the list. Reviewed-by: Abhinav Kumar Signed-off

[PATCH v2 0/9] drm/msm: fold dpu_format into mdp_formats database

2024-04-19 Thread Dmitry Baryshkov
During the review of [1] Abhinav pointed out that mdp_rgb_formats and mdp_rgb_yuv_formats arrays from patch 1 are directly based on the struct mdp_format formats array. This was true, because MDP4 / MDP5 drivers used their own (small) list of supported formats. The DPU driver, supporting more forma

Re: [PATCH 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 8:06 PM, Dmitry Baryshkov wrote: On Sat, 20 Apr 2024 at 06:05, Abhinav Kumar wrote: On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Signed-off-by: Dmitry Baryshkov --- dri

Re: [PATCH 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-04-19 Thread Dmitry Baryshkov
On Sat, 20 Apr 2024 at 06:05, Abhinav Kumar wrote: > > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Lift mode_config limits set by the DPU driver to the actual FB limits as > > handled by the dpu_plane.c. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/disp/dpu1

Re: [PATCH 9/9] drm/msm/dpu: sync mode_config limits to the FB limits in dpu_plane.c

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Lift mode_config limits set by the DPU driver to the actual FB limits as handled by the dpu_plane.c. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) di

Re: [PATCH 8/9] drm/msm/dpu: merge MAX_IMG_WIDTH/HEIGHT with DPU_MAX_IMG_WIDTH/HEIGHT

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: dpu_formats.c defines DPU_MAX_IMG_WIDTH and _HEIGHT, while dpu_hw_catalog.h defines just MAX_IMG_WIDTH and _HEIGHT. Merge these constants to remove duplication. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c

[PATCH 1/2] drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER

2024-04-19 Thread Dmitry Baryshkov
This panel driver uses DSC PPS functions and as such depends on the DRM_DISPLAY_DP_HELPER. Add missing dependency Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200800.kysryyli-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/Kconfig

[PATCH 2/2] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-04-19 Thread Dmitry Baryshkov
Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/panel/panel-lg-sw43408.c | 2 +- 1 file changed,

[PATCH 0/2] drm/panel: two fixes for lg-sw43408

2024-04-19 Thread Dmitry Baryshkov
Fix two issues with the panel-lg-sw43408 driver reported by the kernel test robot. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (2): drm/panel/lg-sw43408: depends on CONFIG_DRM_DISPLAY_DP_HELPER drm/panel/lg-sw43408: mark sw43408_backlight_ops as static drivers/gpu/drm/panel

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 6:34 PM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as ear

[PATCH 1/3] drm/msm: don't clean up priv->kms prematurely

2024-04-19 Thread Dmitry Baryshkov
MSM display drivers provide kms structure allocated during probe(). Don't clean up priv->kms field in case of an error. Otherwise probe functions might fail after KMS probe deferral. Fixes: a2ab5d5bb6b1 ("drm/msm: allow passing struct msm_kms to msm_drv_probe()") Signed-off-by: Dmitry Baryshkov -

[PATCH 2/3] drm/msm/mdp4: don't destroy mdp4_kms in mdp4_kms_init error path

2024-04-19 Thread Dmitry Baryshkov
Since commit 3c74682637e6 ("drm/msm/mdp4: move resource allocation to the _probe function") the mdp4_kms data is allocated during probe. It is an error to destroy it during mdp4_kms_init(), as the data is still referenced by the drivers's data and can be used later in case of probe deferral. Fixes

[PATCH 3/3] drm/msm/mdp4: correct LCDC regulator name

2024-04-19 Thread Dmitry Baryshkov
Correct c&p error from the conversion of LCDC regulators to the bulk API. Fixes: 54f1fbcb47d4 ("drm/msm/mdp4: use bulk regulators API for LCDC encoder") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH 0/3] drm/msm/mdp4: fix probe deferral issues

2024-04-19 Thread Dmitry Baryshkov
While testing MDP4 LVDS support I noticed several issues (two are related to probe deferral case and last one is a c&p error in LCDC part). Fix those issues. Signed-off-by: Dmitry Baryshkov --- Dmitry Baryshkov (3): drm/msm: don't clean up priv->kms prematurely drm/msm/mdp4: don't des

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 6:26 PM, Dmitry Baryshkov wrote: On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote: On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --

Re: [PATCH 5/9] drm/msm/dpu: check for the plane pitch overflow

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 05:16:30PM -0700, Abhinav Kumar wrote: > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Check that the plane pitch doesn't overflow the maximum pitch size > > allowed by the hardware. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/disp/d

Re: [PATCH v3 12/17] clk: mediatek: mt8365-mm: fix DPI0 parent

2024-04-19 Thread Stephen Boyd
Quoting Alexandre Mergnat (2024-04-18 07:17:00) > To have a working display through DPI, a workaround has been > implemented downstream to add "mm_dpi0_dpi0" and "dpi0_sel" to > the DPI node. Shortly, that add an extra clock. > > It seems consistent to have the "dpi0_sel" as parent. > Additionnaly

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 05:14:01PM -0700, Abhinav Kumar wrote: > > > On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: > > Move a call to dpu_format_populate_plane_sizes() to the atomic_check > > step, so that any issues with the FB layout can be reported as early as > > possible. > > > > Signed-off

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 04:43:20PM -0700, Abhinav Kumar wrote: > > > On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: > > The msm_kms_funcs::check_modified_format() callback is not used by the > > driver. Drop it completely. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm

Re: [PATCH 5/9] drm/msm/dpu: check for the plane pitch overflow

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Check that the plane pitch doesn't overflow the maximum pitch size allowed by the hardware. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 6 +- 2 file

Re: [PATCH 4/9] drm/msm/dpu: move dpu_format_populate_plane_sizes to atomic_check

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Move a call to dpu_format_populate_plane_sizes() to the atomic_check step, so that any issues with the FB layout can be reported as early as possible. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++

Re: [PATCH 3/9] drm/msm/dpu: split dpu_format_populate_layout

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: Split dpu_format_populate_layout() into addess-related and pitch/format-related parts. Signed-off-by: Dmitry Baryshkov --- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c| 8 +++- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c| 44 ++

Re: [PATCH 2/9] drm/msm/dpu: drop dpu_format_populate_layout from dpu_plane_sspp_atomic_update

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:22 AM, Dmitry Baryshkov wrote: The dpu_plane_prepare_fb() already calls dpu_format_populate_layout(). Store the generated layour in the plane state and drop this call from dpu_plane_sspp_update(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

Re: [PATCH 1/9] drm/msm/dpu: drop dpu_format_check_modified_format

2024-04-19 Thread Abhinav Kumar
On 3/19/2024 6:21 AM, Dmitry Baryshkov wrote: The msm_kms_funcs::check_modified_format() callback is not used by the driver. Drop it completely. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 45 - drivers/gpu/drm/msm/disp/dpu1

Re: [PATCH 2/7] drm/msm/dsi: Pass bonded-DSI hdisplay/2 to DSC timing configuration

2024-04-19 Thread Dmitry Baryshkov
On Sat, Apr 20, 2024 at 12:18:39AM +0200, Marijn Suijten wrote: > On 2024-04-17 14:58:25, Dmitry Baryshkov wrote: > > On Wed, 17 Apr 2024 at 02:57, Marijn Suijten > > wrote: > > > > > > When configuring the timing of DSI hosts (interfaces) in > > > dsi_timing_setup() all values written to register

[pull] amdgpu, amdkfd, radeon drm-next-6.10

2024-04-19 Thread Alex Deucher
Hi Dave, Sima, More new stuff for 6.10. The following changes since commit ab956ed95b8bc4a65c913d7057075866d5fc3724: drm/amd/display: Add a function for checking tmds mode (2024-04-12 00:36:47 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git t

Re: [PATCH 2/7] drm/msm/dsi: Pass bonded-DSI hdisplay/2 to DSC timing configuration

2024-04-19 Thread Marijn Suijten
On 2024-04-17 14:58:25, Dmitry Baryshkov wrote: > On Wed, 17 Apr 2024 at 02:57, Marijn Suijten > wrote: > > > > When configuring the timing of DSI hosts (interfaces) in > > dsi_timing_setup() all values written to registers are taking bonded > > DSI into account by dividing the original mode width

Re: [PATCH 04/12] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Abhinav Kumar
On 4/19/2024 2:21 PM, Dmitry Baryshkov wrote: On Sat, 20 Apr 2024 at 00:06, Abhinav Kumar wrote: On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: MDP4 and MDP5 drivers enumerate supported formats each time the plane is created. In preparation to merger of MDP DPU format databases, define pr

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

2024-04-19 Thread Rob Herring
On Thu, Apr 18, 2024 at 10:55:39PM +0200, Heiner Kallweit wrote: > 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based device > instantiation") removed the last call to i2c_mux_add_adapter() with a > non-null class argument. Therefore the class argument can be removed. > > Note: Class-ba

Re: [PATCH v4 2/2] drm/panel: Add driver for EDO RM69380 OLED panel

2024-04-19 Thread Marijn Suijten
On 2024-04-17 18:29:34, David Wronek wrote: > Add support for the 2560x1600@90Hz OLED panel by EDO bundled with a > Raydium RM69380 controller, as found on the Lenovo Xiaoxin Pad Pro 2021. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: David Wronek Reviewed-by: Marijn Suijten > --- > dri

Re: [PATCH 04/12] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Dmitry Baryshkov
On Sat, 20 Apr 2024 at 00:06, Abhinav Kumar wrote: > > > > On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: > > MDP4 and MDP5 drivers enumerate supported formats each time the plane is > > created. In preparation to merger of MDP DPU format databases, define > > precise formats list, so that changes

Re: [PATCH 04/12] drm/msm: add arrays listing formats supported by MDP4/MDP5 hardware

2024-04-19 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: MDP4 and MDP5 drivers enumerate supported formats each time the plane is created. In preparation to merger of MDP DPU format databases, define precise formats list, so that changes to the database do not cause the driver to add unsupported format t

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-19 Thread Abhinav Kumar
On 4/10/2024 7:38 PM, Dmitry Baryshkov wrote: On Thu, 11 Apr 2024 at 02:54, Abhinav Kumar wrote: On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote: On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote: On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote: On Wed, 10 Apr 2024 at 23:00, Ab

Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing

2024-04-19 Thread Doug Anderson
Hi, On Thu, Apr 18, 2024 at 5:48 AM lvzhaoxiong wrote: > > ILI2900 requires reset to pull down time greater than 10ms, > so the configuration post_power_delay_ms is 10, and the chipset > initial time is required to be greater than 100ms, > so the post_gpio_reset_on_delay_ms is set to 100. > > Sig

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

2024-04-19 Thread Markus Elfring
… > Add a mutex unlock call. How do you think about a wording variant like the following? Extend the exception handling so that the missed mutex_unlock() call will be performed finally. Regards, Markus

Re: [PATCH][next] drivers: video: Simplify device_node cleanup using __free

2024-04-19 Thread Dmitry Baryshkov
On Sat, Apr 20, 2024 at 12:22:41AM +0530, Shresth Prasad wrote: > > > Please fix the subject line to be "backlight: : ...". I came > > very close to deleting this patch without reading it ;-) . > > Really sorry about that, I'll fix it. > > > Do we need to get dev->of_node at all? The device, whi

[linux-next:master] BUILD REGRESSION a35e92ef04c07bd473404b9b73d489aea19a60a8

2024-04-19 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: a35e92ef04c07bd473404b9b73d489aea19a60a8 Add linux-next specific files for 20240419 Error/Warning: (recently discovered and may have been fixed) WARNING: modpost: vmlinux: section mismatch in

[PATCH] fbdev: fix incorrect address computation in deferred IO

2024-04-19 Thread Nam Cao
With deferred IO enabled, a page fault happens when data is written to the framebuffer device. Then driver determines which page is being updated by calculating the offset of the written virtual address within the virtual memory area, and uses this offset to get the updated page within the internal

Re: [PATCH][next] drivers: video: Simplify device_node cleanup using __free

2024-04-19 Thread Shresth Prasad
> Please fix the subject line to be "backlight: : ...". I came > very close to deleting this patch without reading it ;-) . Really sorry about that, I'll fix it. > Do we need to get dev->of_node at all? The device, which we are > borrowing, already owns a reference to the node so I don't see >

[PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses

2024-04-19 Thread A
>From 51e98164e314a2d1d834d2a9baea21a9823650bb Mon Sep 17 00:00:00 2001 From: Ashok Kumar Date: Fri, 19 Apr 2024 10:32:48 -0700 Subject: [PATCH] staging:fbtft:fb_ili9320 Removed redundant Parentheses Adhere to Linux kernel coding style. Reported by checkpatch CHECK: Unnecessary parentheses arou

[PATCH] drm: fix drm lastclose ignoring closed active fbs

2024-04-19 Thread Bob Beckett
From: Robert Beckett when fb's have been marked as closed, if there is still something active then don't restore fbdev during lastclose Signed-off-by: Robert Beckett --- drivers/gpu/drm/drm_fb_helper.c | 3 +++ drivers/gpu/drm/drm_plane.c | 21 + include/drm/drm_plane.

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

2024-04-19 Thread Jonathan Cameron
On Thu, 18 Apr 2024 22:55:39 +0200 Heiner Kallweit wrote: > 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based device > instantiation") removed the last call to i2c_mux_add_adapter() with a > non-null class argument. Therefore the class argument can be removed. > > Note: Class-based d

Re: [PATCH v3 2/2] misc: sram: Add DMA-BUF Heap exporting of SRAM areas

2024-04-19 Thread Christian Gmeiner
Am Di., 9. Apr. 2024 um 14:14 Uhr schrieb Greg Kroah-Hartman : > > On Tue, Apr 09, 2024 at 02:06:05PM +0200, Pascal FONTAIN wrote: > > From: Andrew Davis > > > > This new export type exposes to userspace the SRAM area as a DMA-BUF > > Heap, > > this allows for allocations of DMA-BUFs that can be c

Re: [git pull] drm fixes for 6.9-rc5

2024-04-19 Thread pr-tracker-bot
The pull request you sent on Fri, 19 Apr 2024 10:53:05 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2024-04-19 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ce944f3f97cf1bc813003ea2f3bf2abefa87dbd7 Thank you! -- Deet-doot-dot, I am a bot. h

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
On 19/04/24 21:53, Nam Cao wrote: On 2024-04-19 Harshit Mogalapalli wrote: +CC stable( heads up as this is a regression affecting 5.15.y and probably others, Greg: this was reproducible upstream so reported everything w.r.t upstream code but initially found on 5.15.y) No worry about this, I wi

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-19 Harshit Mogalapalli wrote: > +CC stable( heads up as this is a regression affecting 5.15.y and > probably others, Greg: this was reproducible upstream so reported > everything w.r.t upstream code but initially found on 5.15.y) No worry about this, I will add a "Cc: " tag to the pat

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
Hi Nam, +CC stable( heads up as this is a regression affecting 5.15.y and probably others, Greg: this was reproducible upstream so reported everything w.r.t upstream code but initially found on 5.15.y) On 19/04/24 20:29, Nam Cao wrote: On 2024-04-18 Harshit Mogalapalli wrote: While fuzzing

Re: [PATCH] drm/amd/display: Remove duplicate dcn32/dcn32_clk_mgr.h header

2024-04-19 Thread Alex Deucher
Reviewed-by: Alex Deucher And applied. Thanks! Alex On Thu, Apr 18, 2024 at 10:37 PM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/clk_mgr/dcn32/dcn32_clk_mgr.c: > dcn32/dcn32_clk_mgr.h is included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanoli

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-19 Patrik Jakobsson wrote: > Neither cancel_delayed_work_sync() or flush_delayed_work() prevent new > work from being scheduled after they return. flush_delayed_work() is called during device closing. And because no writes are performed after the device has been closed, no new work shou

[PATCH] Fix for kernel doc warning [linux-next]

2024-04-19 Thread sundar
Fixed the kernel doc warning due to typo error in field name. ./include/drm/drm_mode_config.h:973: warning: Function parameter or struct member 'size_hints_property' not described in 'drm_mode_config' ./include/drm/drm_mode_config.h:973: warning: Excess struct member 'size_hints_propertty' descr

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-18 Patrik Jakobsson wrote: > On Thu, Apr 18, 2024 at 4:05 PM Nam Cao wrote: > > > > On 2024-04-18 Patrik Jakobsson wrote: > > > This sounds similar to the SUSE bug [1]. We fixed it by reverting [2] > > > in the SUSE kernel. The problem seems to be that flush_delayed_work() > > > kills

Re: [PATCH] drm/atomic-helper: fix parameter order in drm_format_conv_state_copy() call

2024-04-19 Thread Thomas Zimmermann
Hi, thanks for this fix. Am 04.04.24 um 10:17 schrieb Lucas Stach: Old and new state parameters are swapped, so the old state was cleared instead of the new duplicated state. Fixes: 903674588a48 ("drm/atomic-helper: Add format-conversion state to shadow-plane state") Signed-off-by: Lucas Stac

Re: [PATCH] drm/msm: Fix gen_header.py for older python3 versions

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 12, 2024 at 05:54:07PM +0100, Jon Hunter wrote: > The gen_header.py script is failing for older versions of python3 such > as python 3.5. Two issues observed with python 3.5 are ... > > 1. Python 3 versions prior to 3.6 do not support the f-string format. > 2. Early python 3 versions

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 02:36:37PM +0300, Aleksandr Mishin wrote: > In cdns_mhdp_atomic_enable(), there is an error return on failure of > drm_mode_duplicate() which leads to the mutex remaining locked. > Add a mutex unlock call. > > Found by Linux Verification Center (linuxtesting.org) with SVACE

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Nam Cao
On 2024-04-18 Harshit Mogalapalli wrote: > While fuzzing 5.15.y kernel with Syzkaller, we noticed a INFO: task hung > bug in fb_deferred_io_work() I think the problem is because of improper offset address calculation. The kernel calculate address offset with: offset = vmf->address - vmf->

Re: ✗ Fi.CI.IGT: failure for drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4)

2024-04-19 Thread Imre Deak
On Thu, Apr 18, 2024 at 12:22:53PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dp: Few MTL/DSC and a UHBR monitor fix (rev4) > URL : https://patchwork.freedesktop.org/series/131386/ > State : failure I pushed the patchset to drm-intel-next, amending the code comment in p

Re: [bug-report] task info hung problem in fb_deferred_io_work()

2024-04-19 Thread Harshit Mogalapalli
Hi Takashi, On 19/04/24 13:15, Takashi Iwai wrote: On Fri, 19 Apr 2024 09:39:09 +0200, Then later on, the commit 33cd6ea9c067 changed cancel_*() to flush_delayed_work() blindly, and the known problem resurfaced again. I have reverted that commit, but still could see some other task hung messa

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Maxime Ripard
On Fri, Apr 19, 2024 at 05:09:29PM +0300, Jani Nikula wrote: > On Fri, 19 Apr 2024, Maxime Ripard wrote: > > On Fri, Apr 19, 2024 at 03:35:55PM +0300, Jani Nikula wrote: > >> On Thu, 04 Apr 2024, "Nautiyal, Ankit K" > >> wrote: > >> > On 3/19/2024 3:16 PM, Maxime Ripard wrote: > >> >> On Mon, Ma

Re: [PATCH] drm/msm: Fix gen_header.py for older python3 versions

2024-04-19 Thread Jon Hunter
Hi all, On 12/04/2024 17:54, Jon Hunter wrote: The gen_header.py script is failing for older versions of python3 such as python 3.5. Two issues observed with python 3.5 are ... 1. Python 3 versions prior to 3.6 do not support the f-string format. 2. Early python 3 versions do not support th

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Jani Nikula
On Fri, 19 Apr 2024, Maxime Ripard wrote: > On Fri, Apr 19, 2024 at 03:35:55PM +0300, Jani Nikula wrote: >> On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote: >> > On 3/19/2024 3:16 PM, Maxime Ripard wrote: >> >> On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote: >> >>> On Mon, 11 Mar 2024

Re: [PATCH] drm/dp: Fix documentation of DP tunnel functions

2024-04-19 Thread Imre Deak
On Fri, Apr 19, 2024 at 03:40:39PM +0300, Jani Nikula wrote: > On Wed, 28 Feb 2024, Imre Deak wrote: > > Fix the documentation issues below, also reported by 'make htmldocs': > > > > drivers/gpu/drm/display/drm_dp_tunnel.c:447: warning: Function parameter or > > struct member 'tunnel' not describ

Re: [PATCH v2 0/3] Move blender setup from individual planes to crtc commit in sun4i-drm

2024-04-19 Thread Ondřej Jirman
Hi, On Sat, Feb 24, 2024 at 04:05:57PM GMT, megi xff wrote: > From: Ondrej Jirman > > This series refactors blender setup from individual planes to a common > place where it can be performed at once and is easier to reason about. > > In the process this fixes a few bugs that allowed blender pip

[PATCH] lib/fonts: Allow to select fonts for drm_panic

2024-04-19 Thread Jocelyn Falempe
drm_panic has been introduced recently, and uses the same fonts as FRAMEBUFFER_CONSOLE. Signed-off-by: Jocelyn Falempe --- lib/fonts/Kconfig | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/fonts/Kconfig b/lib/fonts/Kconfig index 7e945fdcbf11..befcb4

Re: [PATCH v11 15/28] drm/connector: hdmi: Compute bpc and format automatically

2024-04-19 Thread Maxime Ripard
On Tue, Apr 16, 2024 at 04:50:58PM +0300, Ville Syrjälä wrote: > On Tue, Mar 26, 2024 at 04:40:19PM +0100, Maxime Ripard wrote: > > Now that we have all the infrastructure needed, we can add some code > > that will, for a given connector state and mode, compute the best output > > format and bpc. >

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Maxime Ripard
On Fri, Apr 19, 2024 at 03:35:55PM +0300, Jani Nikula wrote: > On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote: > > On 3/19/2024 3:16 PM, Maxime Ripard wrote: > >> On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote: > >>> On Mon, 11 Mar 2024, Mitul Golani > >>> wrote: > An Adaptiv

Re: [PATCH] drm/dp: Fix documentation of DP tunnel functions

2024-04-19 Thread Jani Nikula
On Wed, 28 Feb 2024, Imre Deak wrote: > Fix the documentation issues below, also reported by 'make htmldocs': > > drivers/gpu/drm/display/drm_dp_tunnel.c:447: warning: Function parameter or > struct member 'tunnel' not described in 'drm_dp_tunnel_put' > drivers/gpu/drm/display/drm_dp_tunnel.c:447

Re: [PATCH v17 0/9] Enable Adaptive Sync SDP Support for DP

2024-04-19 Thread Jani Nikula
On Thu, 04 Apr 2024, "Nautiyal, Ankit K" wrote: > On 3/19/2024 3:16 PM, Maxime Ripard wrote: >> On Mon, Mar 18, 2024 at 04:37:58PM +0200, Jani Nikula wrote: >>> On Mon, 11 Mar 2024, Mitul Golani >>> wrote: An Adaptive-Sync-capable DP protocol converter indicates its support by settin

Re: [PULL] drm-intel-next

2024-04-19 Thread Maxime Ripard
Hi, On Wed, Apr 17, 2024 at 09:38:55AM -0400, Rodrigo Vivi wrote: > Another thing that it is important to highlight is that we have 3 drm level > patches in this pull request where I didn't see any explicit recorded > ack from you (drm maintainers) nor from drm-misc maintainers. > The patches look

Re: [PATCH v2 1/4] drm: add devm release action

2024-04-19 Thread Maxime Ripard
On Wed, Apr 17, 2024 at 09:55:55AM -0400, Rodrigo Vivi wrote: > On Wed, Apr 17, 2024 at 02:11:42PM +0530, Aravind Iddamsetty wrote: > > In scenarios where drm_dev_put is directly called by driver we want to > > release devm_drm_dev_init_release action associated with struct > > drm_device. > > > >

[PULL] drm-misc-next

2024-04-19 Thread Maarten Lankhorst
Hi Dave, Sima, Bit late, but with slightly more content. Cheers, ~Maarten drm-misc-next-2024-04-19: drm-misc-next for v6.10-rc1: UAPI Changes: - Add SIZE_HINTS property for cursor planes. Cross-subsystem Changes: Core Changes: - Document the requirements and expectations of adding new driv

[PATCH] drm: bridge: cdns-mhdp8546: Fix missing mutex unlock on error path

2024-04-19 Thread Aleksandr Mishin
In cdns_mhdp_atomic_enable(), there is an error return on failure of drm_mode_duplicate() which leads to the mutex remaining locked. Add a mutex unlock call. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 935a92a1c400 ("drm: bridge: cdns-mhdp8546: Fix possible null point

Re: [PATCH v11 17/28] drm/connector: hdmi: Add Broadcast RGB property

2024-04-19 Thread Maxime Ripard
On Tue, Apr 16, 2024 at 05:00:26PM +0300, Ville Syrjälä wrote: > On Tue, Mar 26, 2024 at 04:40:21PM +0100, Maxime Ripard wrote: > > The i915 driver has a property to force the RGB range of an HDMI output. > > The vc4 driver then implemented the same property with the same > > semantics. KWin has su

Re: [PATCH] gpu: host1x: mipi: Benefit from devm_clk_get_prepared()

2024-04-19 Thread Thierry Reding
On Tue Apr 9, 2024 at 6:50 PM CEST, Uwe Kleine-König wrote: > When using devm_clk_get_prepared() instead of devm_clk_get() the clock > is already returned prepared. So probe doesn't need to call > clk_prepare() and at remove time the call to clk_unprepare() can be > dropped. The latter makes the re

Re: [PATCH 3/4] gpu: host1x: Convert to platform remove callback returning void

2024-04-19 Thread Thierry Reding
On Tue Apr 9, 2024 at 7:02 PM CEST, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a

Re: [PATCH 0/4] gpu: Convert to platform remove callback returning void

2024-04-19 Thread Thierry Reding
On Fri Apr 19, 2024 at 9:20 AM CEST, Uwe Kleine-König wrote: > Hello, > > On Tue, Apr 09, 2024 at 07:02:47PM +0200, Uwe Kleine-König wrote: > > with some patches sent earlier[1], this series converts all platform > > drivers below drivers/gpu to not use struct platform_device::remove() > > any more

Re: [PATCH v5 1/1] UPSTREAM: drm/bridge: it6505: fix hibernate to resume no display issue

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 03:38:07PM +0800, kuro wrote: > From: Kuro > > ITE added a FIFO reset bit for input video. When system power resume, > the TTL input of it6505 may get some noise before video signal stable > and the hardware function reset is required. > But the input FIFO reset will also

Re: [PATCH] drm: vop2: Do not divide height twice for YUV

2024-04-19 Thread Heiko Stuebner
On Sun, 14 Apr 2024 14:27:06 -0400, Detlev Casanova wrote: > For the cbcr format, gt2 and gt4 are computed again after src_h has been > divided by vsub. > > As src_h as already been divided by 2 before, introduce cbcr_src_h and > cbcr_src_w to keep a copy of those values to be used for cbcr gt2 an

Re: [PATCH] drm/rockchip: cdn-dp: drop driver owner assignment

2024-04-19 Thread Heiko Stuebner
On Sat, 30 Mar 2024 21:27:54 +0100, Krzysztof Kozlowski wrote: > Core in platform_driver_register() already sets the .owner, so driver > does not need to. Whatever is set here will be anyway overwritten by > main driver calling platform_driver_register(). > > Applied, thanks! [1/1] drm/rockchi

Re: [PATCH v1 1/3] dt-bindings: display: add #sound-dai-cells property to rockchip dw hdmi

2024-04-19 Thread Heiko Stuebner
On Sat, 13 Apr 2024 17:38:05 +0200, Johan Jonker wrote: > The Rockchip DWC HDMI TX Encoder can take one I2S input and transmit it > over the HDMI output. Add #sound-dai-cells (= 0) to the binding for it. > > Applied, thanks! [1/3] dt-bindings: display: add #sound-dai-cells property to rockchip

Re: [PATCH] drm/rockchip: lvds: Remove include of drm_dp_helper.h

2024-04-19 Thread Heiko Stuebner
On Sun, 14 Apr 2024 20:08:41 +0800, Andy Yan wrote: > From: Andy Yan > > drm_dp_helper.h is not used by lvds driver > > Applied, thanks! [1/1] drm/rockchip: lvds: Remove include of drm_dp_helper.h commit: 685ba01ebedb8f87673f587f540ba84c42d4 Best regards, -- Heiko Stuebner

Re: [PATCH][next] drivers: video: Simplify device_node cleanup using __free

2024-04-19 Thread Daniel Thompson
^^^ Please fix the subject line to be "backlight: : ...". I came very close to deleting this patch without reading it ;-) . On Fri, Apr 19, 2024 at 01:13:02AM +0530, Shresth Prasad wrote: > diff --git a/drivers/video/backlight/sky81452-backlight.c > b/drivers/video/backlight/sky81452-backlight.

Re: [PATCH v3 31/43] drm/rockchip: Use fbdev-dma

2024-04-19 Thread Heiko Stuebner
Am Freitag, 19. April 2024, 10:29:24 CEST schrieb Thomas Zimmermann: > Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports > damage handling, which is required by rockchip. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by:

Re: [PATCH] component: Support masters with no subcomponents

2024-04-19 Thread Dmitry Baryshkov
On Fri, Apr 19, 2024 at 10:22:19AM +0200, Linus Walleij wrote: > On Thu, Apr 18, 2024 at 1:36 AM Dmitry Baryshkov > wrote: > > > I have LVDS working on apq8064, but it requires fixes in the MMCC > > driver, in the MDP4 driver and in DTS. I need to clean up them first > > before even attempting to

Re: [PATCH 15/15] drm/rockchip: rk3066_hdmi: switch to struct drm_edid

2024-04-19 Thread Heiko Stuebner
Am Dienstag, 16. April 2024, 15:22:29 CEST schrieb Jani Nikula: > Prefer struct drm_edid based functions over struct edid. > > Signed-off-by: Jani Nikula Acked-by: Heiko Stuebner

Re: [PATCH 14/15] drm/rockchip: inno_hdmi: switch to struct drm_edid

2024-04-19 Thread Heiko Stuebner
Am Dienstag, 16. April 2024, 15:22:28 CEST schrieb Jani Nikula: > Prefer struct drm_edid based functions over struct edid. > > Signed-off-by: Jani Nikula Acked-by: Heiko Stuebner

Re: [PATCH 13/15] drm/rockchip: cdn-dp: switch to struct drm_edid

2024-04-19 Thread Heiko Stuebner
Am Dienstag, 16. April 2024, 15:22:27 CEST schrieb Jani Nikula: > Prefer struct drm_edid based functions over struct edid. > > Signed-off-by: Jani Nikula Acked-by: Heiko Stuebner

Re: [PATCH v3 28/43] drm/renesas/rcar-du: Use fbdev-dma

2024-04-19 Thread Kieran Bingham
Quoting Thomas Zimmermann (2024-04-19 09:29:21) > Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports > damage handling, which is required by rcar-du. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > C

Re: [PATCH 3/3] drm/i915: Fix gt reset with GuC submission disabled

2024-04-19 Thread Nirmoy Das
Hi John, On 4/19/2024 1:38 AM, John Harrison wrote: On 4/18/2024 10:10, Nirmoy Das wrote: Currently intel_gt_reset() happens as follows: reset_prepare() ---> Sends GDRST to GuC, GuC is in GS_MIA_IN_RESET do_reset()    intel_gt_reset_all_engines() *_engine_reset_prepare() -->RESET_CTL expe

Re: [PATCH v3 14/17] drm/mediatek: add MT8365 SoC support

2024-04-19 Thread Alexandre Mergnat
On 19/04/2024 10:01, AngeloGioacchino Del Regno wrote: Il 18/04/24 16:17, amerg...@baylibre.com ha scritto: From: Fabien Parent Add DRM support for MT8365 SoC. Signed-off-by: Fabien Parent Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Alexandre Mergnat There are two things t

Re: [PATCH v2 1/4] drm: add devm release action

2024-04-19 Thread Maxime Ripard
On Fri, Apr 19, 2024 at 02:28:23PM +0530, Aravind Iddamsetty wrote: > In scenarios where drm_dev_put is directly called by driver we want to > release devm_drm_dev_init_release action associated with struct > drm_device. > > v2: Directly expose the original function, instead of introducing a > hel

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

2024-04-19 Thread Peter Rosin
Hi! 2024-04-18 at 22:55, Heiner Kallweit wrote: > 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based device > instantiation") removed the last call to i2c_mux_add_adapter() with a > non-null class argument. Therefore the class argument can be removed. > > Note: Class-based device insta

  1   2   >