Re: [PATCH v1 1/1] drm/mediatek/dp: The register is written with the parsed DTS SSC value.

2024-04-10 Thread Krzysztof Kozlowski
On 11/04/2024 08:30, LIANKUN YANG (杨连坤) wrote: > On Wed, 2024-04-03 at 16:56 +0200, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 03/04/2024 08:41, Krzysztof Kozlowski wrote: >>> On

Re: [PATCH] MAINTAINERS: adjust DRM DRIVERS FOR EXYNOS after dt-binding conversion

2024-04-10 Thread Krzysztof Kozlowski
On 11/04/2024 08:30, Lukas Bulwahn wrote: > Commit ad6d17e10306 ("dt-bindings: display: samsung,exynos5-dp: convert to > DT Schema") converts the last exynos display devicetree binding to json. > With that, all exynos display devicetree bindings are now located in > Documentation/devicetree/binding

[PATCH] MAINTAINERS: adjust DRM DRIVERS FOR EXYNOS after dt-binding conversion

2024-04-10 Thread Lukas Bulwahn
Commit ad6d17e10306 ("dt-bindings: display: samsung,exynos5-dp: convert to DT Schema") converts the last exynos display devicetree binding to json. With that, all exynos display devicetree bindings are now located in Documentation/devicetree/bindings/display/samsung/ and the directory with the prev

Re: [PATCH] drm/bridge: ti-sn65dsi86: Fix ti_sn_bridge_set_dsi_rate function

2024-04-10 Thread Doug Anderson
Hi, On Wed, Apr 10, 2024 at 4:42 AM Jayesh Choudhary wrote: > > Hello Doug, > > Thanks for the review. > > On 08/04/24 14:33, Doug Anderson wrote: > > Hi, > > > > On Mon, Apr 8, 2024 at 12:36 AM Jayesh Choudhary wrote: > >> > >> Due to integer calculations, the rounding off can cause errors in t

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Dmitry Baryshkov
On Thu, 11 Apr 2024 at 02:54, Abhinav Kumar wrote: > > > > On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote: > > On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote: > >> > >> > >> On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote: > >>> On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar > >>> wrote:

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-04-10 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. Two weeks worth. There is a fairly big update for SMU 14.0.1, but that is a new IP for 6.9 so it should be isolated to that. The following changes since commit 718c4fb221dbeff9072810841b949413c5ffc345: nouveau: fix devinit paths to only handle display on GSP. (2

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-10 Thread Dmitry Baryshkov
void gpu_write(struct msm_gpu *gpu, u32 reg, u32 data) > { > - msm_writel(data, gpu->mmio + (reg << 2)); > + writel(data, gpu->mmio + (reg << 2)); > } > > static inline u32 gpu_read(struct msm_gpu *gpu, u32 reg) > { > - return msm_readl(gpu->mmio + (reg << 2)); > + return readl(gpu->mmio + (reg << 2)); > } > > static inline void gpu_rmw(struct msm_gpu *gpu, u32 reg, u32 mask, u32 or) > @@ -586,8 +586,8 @@ static inline u64 gpu_read64(struct msm_gpu *gpu, u32 reg) >* when the lo is read, so make sure to read the lo first to trigger >* that >*/ > - val = (u64) msm_readl(gpu->mmio + (reg << 2)); > - val |= ((u64) msm_readl(gpu->mmio + ((reg + 1) << 2)) << 32); > + val = (u64) readl(gpu->mmio + (reg << 2)); > + val |= ((u64) readl(gpu->mmio + ((reg + 1) << 2)) << 32); > > return val; > } > @@ -595,8 +595,8 @@ static inline u64 gpu_read64(struct msm_gpu *gpu, u32 reg) > static inline void gpu_write64(struct msm_gpu *gpu, u32 reg, u64 val) > { > /* Why not a writeq here? Read the screed above */ > - msm_writel(lower_32_bits(val), gpu->mmio + (reg << 2)); > - msm_writel(upper_32_bits(val), gpu->mmio + ((reg + 1) << 2)); > + writel(lower_32_bits(val), gpu->mmio + (reg << 2)); > + writel(upper_32_bits(val), gpu->mmio + ((reg + 1) << 2)); > } > > int msm_gpu_pm_suspend(struct msm_gpu *gpu); > > --- > base-commit: 6ebf211bb11dfc004a2ff73a9de5386fa309c430 > change-id: 20240410-topic-msm_rw-cdc1d85b2ece > > Best regards, > -- > Konrad Dybcio > -- With best wishes Dmitry

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Dmitry Baryshkov
On Thu, 11 Apr 2024 at 04:20, Dmitry Baryshkov wrote: > > On Thu, 11 Apr 2024 at 02:54, Abhinav Kumar wrote: > > > > > > > > On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote: > > > On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote: > > >> > > >> > > >> On 4/10/2024 1:16 PM, Dmitry Baryshk

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Dmitry Baryshkov
On Thu, 11 Apr 2024 at 02:54, Abhinav Kumar wrote: > > > > On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote: > > On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote: > >> > >> > >> On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote: > >>> On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar > >>> wrote:

[PATCH] nouveau: fix instmem race condition around ptr stores

2024-04-10 Thread Dave Airlie
From: Dave Airlie Running a lot of VK CTS in parallel against nouveau, once every few hours you might see something like this crash. BUG: kernel NULL pointer dereference, address: 0008 PGD 800114e6e067 P4D 800114e6e067 PUD 109046067 PMD 0 Oops: [#1] PREEMPT SMP PTI CPU:

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Abhinav Kumar
On 4/10/2024 2:12 PM, Dmitry Baryshkov wrote: On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote: On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote: On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar wrote: On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Instead of having DPU-specific d

Re: [PATCH 20/21] drm/rcar-du: Allow build with COMPILE_TEST=y

2024-04-10 Thread Laurent Pinchart
Hi Ville, Thank you for the patch. On Mon, Apr 08, 2024 at 08:04:25PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Allow rcar-du to be built with COMPILE_TEST=y for greater > coverage. Builds fine on x86/x86_64 at least. > > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: linux-rene

Re: [PATCH 00/10] drm: move Intel drm headers to a subdirectory

2024-04-10 Thread Lucas De Marchi
On Wed, Apr 10, 2024 at 01:05:07PM +0300, Jani Nikula wrote: We've accumulated enough Intel specific header files under include/drm that they warrant a subdirectory of their own. Clean up the top drm header directory by moving the Intel files under include/drm/intel. Since i915 is most impacted,

Re: [PATCH] drm/msm: Drop msm_read/writel

2024-04-10 Thread Andrew Halaney
bd6d1d5b 100644 > --- a/drivers/gpu/drm/msm/msm_gpu.h > +++ b/drivers/gpu/drm/msm/msm_gpu.h > @@ -555,12 +555,12 @@ struct msm_gpu_state { > > static inline void gpu_write(struct msm_gpu *gpu, u32 reg, u32 data) > { > - msm_writel(data, gpu->mmio + (reg <&l

[PATCH] drm/msm: Drop msm_read/writel

2024-04-10 Thread Konrad Dybcio
here? Read the screed above */ - msm_writel(lower_32_bits(val), gpu->mmio + (reg << 2)); - msm_writel(upper_32_bits(val), gpu->mmio + ((reg + 1) << 2)); + writel(lower_32_bits(val), gpu->mmio + (reg << 2)); + writel(upper_32_bits(val), gpu->mmio + ((reg + 1) << 2)); } int msm_gpu_pm_suspend(struct msm_gpu *gpu); --- base-commit: 6ebf211bb11dfc004a2ff73a9de5386fa309c430 change-id: 20240410-topic-msm_rw-cdc1d85b2ece Best regards, -- Konrad Dybcio

[PULL] drm-intel-fixes

2024-04-10 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes drm-intel-fixes-2024-04-10: Display fixes: - Couple CDCLK programming fixes (Ville) - HDCP related fix (Suraj) - 4 Bigjoiner related fixes (Ville) Core fix: - Fix for a circular locking around GuC on reset+wedged case (John) Thanks, Rodrigo. The following changes si

Re: [PATCH] drm: nv04: Add check to avoid out of bounds access

2024-04-10 Thread Mikhail Kobuk
On 08/04/2024 16:23, Danilo Krummrich wrote: On 4/5/24 22:05, Lyude Paul wrote: On Fri, 2024-04-05 at 17:53 +0200, Danilo Krummrich wrote: On 3/31/24 08:45, Mikhail Kobuk wrote: Output Resource (dcb->or) value is not guaranteed to be non-zero (i.e. in drivers/gpu/drm/nouveau/nouveau_bios.c, in

[PATCH] drm/kmb: Replace of_node_put() with automatic cleanup handler

2024-04-10 Thread Javier Carrasco
Make use of the __free() cleanup handler to automatically free nodes when they get out of scope. Suggested-by: Julia Lawall Signed-off-by: Javier Carrasco --- The patch is based on the latest linux-next tag (next-20240410). --- drivers/gpu/drm/kmb/kmb_drv.c | 13 - drivers/gpu/drm

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Dmitry Baryshkov
On Wed, Apr 10, 2024 at 01:18:42PM -0700, Abhinav Kumar wrote: > > > On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote: > > On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar > > wrote: > > > > > > > > > > > > On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: > > > > Instead of having DPU-specific defines,

Re: [PATCH 05/12] drm/msm/dpu: in dpu_format replace bitmap with unsigned long field

2024-04-10 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Using bitmap for the flags results in a clumsy syntax on test_bit, replace it with unsigned long type and simple binary ops. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 18 +- drivers/gpu/d

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Abhinav Kumar
On 4/10/2024 1:16 PM, Dmitry Baryshkov wrote: On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar wrote: On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Instead of having DPU-specific defines, switch to the definitions from the mdp_common.xml.h file. This is the preparation for merged of DPU and M

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Dmitry Baryshkov
On Wed, 10 Apr 2024 at 23:00, Abhinav Kumar wrote: > > > > On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: > > Instead of having DPU-specific defines, switch to the definitions from > > the mdp_common.xml.h file. This is the preparation for merged of DPU and > > MDP format tables. > > > > Adding MDP

Re: [PATCH 03/12] drm/msm/dpu: use format-related definitions from mdp_common.xml.h

2024-04-10 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Instead of having DPU-specific defines, switch to the definitions from the mdp_common.xml.h file. This is the preparation for merged of DPU and MDP format tables. Adding MDP_***__ usages in DPU driver is quite confusing. Can we align to a commo

Re: [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on

2024-04-10 Thread Diederik de Haas
On Tuesday, 9 April 2024 11:26:25 CEST Geert Uytterhoeven wrote: > Hi Maxime, > > On Wed, 27 Mar 2024, Maxime Ripard wrote: > > Jani recently pointed out that the Kconfig symbols are a bit difficult > > to work with at the moment when they depend on each other, and that > > using depends on

Re: [PATCH v12 4/7] drm/meson: gate px_clk when setting rate

2024-04-10 Thread Martin Blumenstingl
Hi Neil, On Wed, Apr 3, 2024 at 9:46 AM Neil Armstrong wrote: > > Disable the px_clk when setting the rate to recover a fully > configured and correctly reset VCLK clock tree after the rate > is set. > > Fixes: 77d9e1e6b846 ("drm/meson: add support for MIPI-DSI transceiver") > Signed-off-by: Neil

Re: [PATCH] drm/xe: Add xe_guc_ads.c to uses_generated_oob

2024-04-10 Thread Lucas De Marchi
On Wed, Apr 10, 2024 at 11:16:11AM -0700, Nathan Chancellor wrote: A recent change added a use of xe_wa_oob.h without adding the file that uses it to uses_generated_oob, which means xe_wa_oob.h does not get properly generated before attempting to build the object file: LINK resolve_btfids

Re: [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin

2024-04-10 Thread Dmitry Baryshkov
On Wed, Apr 10, 2024 at 01:42:33PM +0200, Konrad Dybcio wrote: > > > On 4/6/24 05:23, Dmitry Baryshkov wrote: > > On Fri, Apr 05, 2024 at 10:41:32AM +0200, Konrad Dybcio wrote: > > > On recent (SM8550+) Snapdragon platforms, the GPU speed bin data is > > > abstracted through SMEM, instead of bein

Re: [PATCH 02/12] drm/msm/disp: add mdp_fetch_mode enum

2024-04-10 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Pull in new enum from the mesa registers. This commit should be replaced with the registers sync with Mesa instead. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp_common.xml.h | 6 ++ 1 file changed, 6 insertions(+) Re

Re: [PATCH 01/12] drm/msm: fix BPC1 -> BPC4

2024-04-10 Thread Abhinav Kumar
On 12/2/2023 1:40 PM, Dmitry Baryshkov wrote: Fix enum mdp_bpc::BPC1 value to be BPC4 instead (as shown in the DPU driver). This commit should be replaced with the registers sync with Mesa instead. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp_common.xml.h | 2 +- 1 fil

Re: [PATCH v2 2/3] dt-bindings: arm: mediatek: mmsys: Add OF graph support for board path

2024-04-10 Thread Rob Herring
On Tue, Apr 09, 2024 at 02:02:10PM +0200, AngeloGioacchino Del Regno wrote: > Document OF graph on MMSYS/VDOSYS: this supports up to three DDP paths > per HW instance (so potentially up to six displays for multi-vdo SoCs). > > The MMSYS or VDOSYS is always the first component in the DDP pipeline,

Re: [PATCH v2 1/3] dt-bindings: display: mediatek: Add OF graph support for board path

2024-04-10 Thread Rob Herring
On Tue, Apr 09, 2024 at 02:02:09PM +0200, AngeloGioacchino Del Regno wrote: > The display IPs in MediaTek SoCs support being interconnected with > different instances of DDP IPs (for example, merge0 or merge1) and/or > with different DDP IPs (for example, rdma can be connected with either > color,

Re: [PATCH 1/2] dt-bindings: panel-simple-dsi: add New Khadas TS050 panel bindings

2024-04-10 Thread Rob Herring
On Wed, Apr 10, 2024 at 08:22:25AM +0400, Christian Hewitt wrote: > > On 9 Apr 2024, at 12:26 PM, Jacobe Zang wrote: > > > > This add the bindings for the New Khadas TS050 1080x1920 5" LCD DSI panel > > designed to work with the Khadas VIM3 and VIM3L Single Board Computers. > > > > Signed-off-by

[PATCH] drm/xe: Add xe_guc_ads.c to uses_generated_oob

2024-04-10 Thread Nathan Chancellor
$(obj)/xe_gen_wa_oob \ uses_generated_oob := \ $(obj)/xe_gsc.o \ $(obj)/xe_guc.o \ + $(obj)/xe_guc_ads.o \ $(obj)/xe_migrate.o \ $(obj)/xe_ring_ops.o \ $(obj)/xe_vm.o \ --- base-commit: 9c1857d587e91dfc10875a8c1083360db047404f change-id: 20240410-drm-xe-fix-xe_guc

Re: [PATCH 0/7] drm/display: Fix display helpers depends on fallouts

2024-04-10 Thread Mark Brown
On Wed, Apr 03, 2024 at 12:56:18PM +0200, Maxime Ripard wrote: > Hi, > > Here's a series addressing the various regressions that were reported > after the Kconfig rework for the DRM display helpers. > > Let me know what you think, > Maxime Is there any news on getting the rest of this merged? I

[PATCH] drm/edid: Parse topology block for all DispID structure v1.x

2024-04-10 Thread Ville Syrjala
From: Ville Syrjälä DisplayID spec v1.3 revision history notes do claim that the toplogy block was added in v1.3 so requiring structure v1.2 would seem correct, but there is at least one EDID in edid.tv with a topology block and structure v1.0. And there are also EDIDs with DisplayID structure v1

[linux-next:master] BUILD REGRESSION 6ebf211bb11dfc004a2ff73a9de5386fa309c430

2024-04-10 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 6ebf211bb11dfc004a2ff73a9de5386fa309c430 Add linux-next specific files for 20240410 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202404102353.cv1gujk3-...@intel.com Error

Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

2024-04-10 Thread Tomi Valkeinen
On 10/04/2024 20:04, Ville Syrjälä wrote: On Wed, Apr 10, 2024 at 06:25:17PM +0300, Ville Syrjälä wrote: On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote: On 08/04/2024 20:04, Ville Syrjala wrote: From: Ville Syrjälä __iowmb() isn't available on most architectures. Make its use

Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

2024-04-10 Thread Ville Syrjälä
On Wed, Apr 10, 2024 at 06:25:17PM +0300, Ville Syrjälä wrote: > On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote: > > On 08/04/2024 20:04, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > __iowmb() isn't available on most architectures. Make > > > its use optional so that

Re: [RESEND v7 28/37] dt-bindings: soc: renesas: sh: Add SH7751 based target

2024-04-10 Thread Rob Herring
On Thu, 04 Apr 2024 14:14:39 +0900, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > .../devicetree/bindings/soc/renesas/sh.yaml | 27 +++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/renesas/sh.yaml > Reviewed-b

Re: [RESEND v7 25/37] dt-binding: sh: cpus: Add SH CPUs json-schema

2024-04-10 Thread Rob Herring
On Thu, Apr 04, 2024 at 02:14:36PM +0900, Yoshinori Sato wrote: > Renesas SH series and compatible ISA CPUs. > > Signed-off-by: Yoshinori Sato > --- > .../devicetree/bindings/sh/cpus.yaml | 63 +++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/de

Re: [RESEND v7 22/37] dt-bindings: display: smi,sm501: SMI SM501 binding json-schema

2024-04-10 Thread Rob Herring
On Thu, Apr 04, 2024 at 02:14:33PM +0900, Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato > --- > .../bindings/display/smi,sm501.yaml | 398 ++ > 1 file changed, 398 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/smi,sm501.yaml > > d

Re: [PATCH] drm: nv04: Add check to avoid out of bounds access

2024-04-10 Thread Danilo Krummrich
On 4/10/24 17:39, Mikhail Kobuk wrote: On 08/04/2024 16:23, Danilo Krummrich wrote: On 4/5/24 22:05, Lyude Paul wrote: On Fri, 2024-04-05 at 17:53 +0200, Danilo Krummrich wrote: On 3/31/24 08:45, Mikhail Kobuk wrote: Output Resource (dcb->or) value is not guaranteed to be non-zero (i.e. in dr

Re: [PATCH] drm/dp: correct struct member name in documentation

2024-04-10 Thread Rodrigo Vivi
On Fri, Apr 05, 2024 at 12:21:59PM +0530, Mitul Golani wrote: > Correct struct member name to 'mode' instead of 'operation mode' > in 'drm_dp_as_sdp' structure description. > > Fixes: 0bbb8f594e33 ("drm/dp: Add Adaptive Sync SDP logging") Probably good to avoid this 'Fixes:' tag, and only use tha

Re: [RESEND v7 17/37] dt-bindings: interrupt-controller: renesas,sh7751-intc: Add json-schema

2024-04-10 Thread Rob Herring
On Thu, 04 Apr 2024 14:14:28 +0900, Yoshinori Sato wrote: > Renesas SH7751 INTC json-schema. > > Signed-off-by: Yoshinori Sato > --- > .../renesas,sh7751-intc.yaml | 53 +++ > 1 file changed, 53 insertions(+) > create mode 100644 > Documentation/devicetree/bi

Re: [RESEND v7 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header.

2024-04-10 Thread Rob Herring
On Thu, Apr 04, 2024 at 02:14:24PM +0900, Yoshinori Sato wrote: > SH7750 CPG Clock output define. This and the subject don't match what the patch does. > > Signed-off-by: Yoshinori Sato > --- > .../bindings/clock/renesas,sh7750-cpg.yaml| 105 ++ > include/dt-bindings/clock/

Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

2024-04-10 Thread Tomi Valkeinen
On 10/04/2024 18:25, Ville Syrjälä wrote: On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote: On 08/04/2024 20:04, Ville Syrjala wrote: From: Ville Syrjälä __iowmb() isn't available on most architectures. Make its use optional so that the driver can be built on other architectures

Re: [PATCH 12/21] drm/tilcdc: Allow build without __iowmb()

2024-04-10 Thread Ville Syrjälä
On Wed, Apr 10, 2024 at 12:06:29PM +0300, Tomi Valkeinen wrote: > On 08/04/2024 20:04, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > __iowmb() isn't available on most architectures. Make > > its use optional so that the driver can be built on > > other architectures with COMPILE_TEST=y. >

Re: [PATCH RESEND] drm/armada: drop unneeded MODULE_ALIAS

2024-04-10 Thread Neil Armstrong
On 10/04/2024 10:22, Krzysztof Kozlowski wrote: The MODULE_DEVICE_TABLE already creates proper alias for platform driver. Having another MODULE_ALIAS causes the alias to be duplicated. Signed-off-by: Krzysztof Kozlowski --- Resent third time https://lore.kernel.org/all/20220407202443.23000-1

Re: [PATCH v12 2/9] drm/panic: Add a drm panic handler

2024-04-10 Thread Jocelyn Falempe
Hi, On 10/04/2024 10:10, Daniel Vetter wrote: On Tue, Apr 09, 2024 at 06:30:41PM +0200, Jocelyn Falempe wrote: This module displays a user friendly message when a kernel panic occurs. It currently doesn't contain any debug information, but that can be added later. v2 * Use get_scanout_buffer

Re: [PATCH] dma-buf: add DMA_BUF_IOCTL_SYNC_PARTIAL support

2024-04-10 Thread T.J. Mercier
On Wed, Apr 10, 2024 at 7:22 AM Christian König wrote: > > Am 09.04.24 um 18:37 schrieb T.J. Mercier: > > On Tue, Apr 9, 2024 at 12:34 AM Rong Qianfeng <11065...@vivo.com> wrote: > >> > >> 在 2024/4/8 15:58, Christian König 写道: > >>> Am 07.04.24 um 09:50 schrieb Rong Qianfeng: > [SNIP] > >

Re: [PATCH net-next v8 3/3] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-04-10 Thread Jakub Kicinski
On Wed, 10 Apr 2024 16:02:00 +0200 Julien Panis wrote: > > You shouldn't build the skb upfront any more. Give the page to the HW, > > once HW sends you a completion - build the skbs. If build fails > > (allocation failure) just give the page back to HW. If it succeeds, > > however, you'll get a skb

Re: [PATCH v2 25/43] drm/ingenic: Use fbdev-dma

2024-04-10 Thread Paul Cercueil
Le mercredi 10 avril 2024 à 15:02 +0200, Thomas Zimmermann a écrit : > Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports > damage handling, which is required by ingenic. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: T

[PULL] drm-misc-next

2024-04-10 Thread Maarten Lankhorst
Hi Dave, Sima, Still low amount of patches this week! Cheers, ~Maarten drm-misc-next-2024-04-10: drm-misc-next for v6.10: Cross-subsystem Changes: - Add Tomi as Xilinx maintainer. - Add sound bindings to DT. Core Changes: - Make DP helper depend on KMS helper. Driver Changes: - Assorted smal

Re: [PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-10 Thread Andrzej Hajda
On 10.04.2024 16:14, Jani Nikula wrote: Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. Signed-off-by: Jani Nikula --- Reviewed-by: Andrzej Hajda Regards Andrzej Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: J

Re: [bug report] drm/panthor: Add the scheduler logical block

2024-04-10 Thread Steven Price
On 10/04/2024 15:34, Dan Carpenter wrote: > On Wed, Apr 10, 2024 at 03:11:52PM +0100, Steven Price wrote: >> On 08/04/2024 08:35, Dan Carpenter wrote: >>> Hello Boris Brezillon, >>> >>> Commit de8548813824 ("drm/panthor: Add the scheduler logical block") >>> from Feb 29, 2024 (linux-next), leads to

Re: [PATCH] drm/bridge: imx8mp-hdmi-tx: Convert to platform remove callback returning void

2024-04-10 Thread Uwe Kleine-König
Hello Rob, On Wed, Apr 10, 2024 at 03:40:30PM +0200, Robert Foss wrote: > On Mon, 4 Mar 2024 10:10:06 +0100, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returnin

Re: [bug report] drm/panthor: Add the scheduler logical block

2024-04-10 Thread Dan Carpenter
On Wed, Apr 10, 2024 at 03:11:52PM +0100, Steven Price wrote: > On 08/04/2024 08:35, Dan Carpenter wrote: > > Hello Boris Brezillon, > > > > Commit de8548813824 ("drm/panthor: Add the scheduler logical block") > > from Feb 29, 2024 (linux-next), leads to the following Smatch static > > checker war

Re: [PATCH v10 4/9] drm/ttm/tests: Add tests with mock resource managers

2024-04-10 Thread Matthew Auld
On 22/03/2024 14:29, Karolina Stolarek wrote: Add mock resource manager to test ttm_bo_validate() with non-system placements. Update KConfig entry to enable DRM Buddy allocator, used by the mock manager. Update move function to do more than just assign a resource. Signed-off-by: Karolina Stolare

[PATCH 0/1] video: Handle HAS_IOPORT dependencies

2024-04-10 Thread Niklas Schnelle
Hi Helge (again ;-)), This is a follow up in my ongoing effort of making inb()/outb() and similar I/O port accessors compile-time optional. Previously I sent this as a treewide series titled "treewide: Remove I/O port accessors for HAS_IOPORT=n" with the latest being its 5th version[0]. With a sig

[PATCH 1/1] video: Handle HAS_IOPORT dependencies

2024-04-10 Thread Niklas Schnelle
In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to #ifdef functions and their callsites which unconditionally use these I/O accessors. In the include/video/vga.h these are conveniently all those functions with the vga_io_* prefix. Co-developed-by:

Re: [PATCH] dma-buf: add DMA_BUF_IOCTL_SYNC_PARTIAL support

2024-04-10 Thread Christian König
Am 09.04.24 um 18:37 schrieb T.J. Mercier: On Tue, Apr 9, 2024 at 12:34 AM Rong Qianfeng <11065...@vivo.com> wrote: 在 2024/4/8 15:58, Christian König 写道: Am 07.04.24 um 09:50 schrieb Rong Qianfeng: [SNIP] Am 13.11.21 um 07:22 schrieb Jianqun Xu: Add DMA_BUF_IOCTL_SYNC_PARTIAL support for us

Re: [PATCH 02/10] drm: move intel-gtt.h under include/drm/intel

2024-04-10 Thread Andi Shyti
On Wed, Apr 10, 2024 at 01:05:09PM +0300, Jani Nikula wrote: > Clean up the top level include/drm directory by grouping all the Intel > specific files under a common subdirectory. > > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Lucas De Marchi > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyt

[PATCH 1/2] drm/print: drop include debugfs.h and include where needed

2024-04-10 Thread Jani Nikula
Surprisingly many places depend on debugfs.h to be included via drm_print.h. Fix them. Signed-off-by: Jani Nikula --- Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Robert Foss Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmerm

[PATCH 2/2] drm/print: drop include seq_file.h

2024-04-10 Thread Jani Nikula
Never include where a forward declaration will suffice. Signed-off-by: Jani Nikula --- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 561c3b96b6fd..089950ad8681 100644 --- a/include/drm/drm_print

Re: [bug report] drm/panthor: Add the scheduler logical block

2024-04-10 Thread Steven Price
On 08/04/2024 08:35, Dan Carpenter wrote: > Hello Boris Brezillon, > > Commit de8548813824 ("drm/panthor: Add the scheduler logical block") > from Feb 29, 2024 (linux-next), leads to the following Smatch static > checker warning: > > drivers/gpu/drm/panthor/panthor_sched.c:1153 > csg_slot_

Re: [PATCH 01/10] drm/i915: use system include for drm headers

2024-04-10 Thread Andi Shyti
Hi Jani, On Wed, Apr 10, 2024 at 01:05:08PM +0300, Jani Nikula wrote: > Use <> instead of "" for including headers from include/, even if the > file is in the same directory. > > Signed-off-by: Jani Nikula Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH net-next v8 3/3] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-04-10 Thread Julien Panis
On 4/10/24 02:49, Jakub Kicinski wrote: On Mon, 08 Apr 2024 11:38:04 +0200 Julien Panis wrote: +static struct sk_buff *am65_cpsw_alloc_skb(struct am65_cpsw_rx_chn *rx_chn, + struct net_device *ndev, + unsigned int

Re: [PATCH v10 3/9] drm/ttm/tests: Test simple BO creation and validation

2024-04-10 Thread Matthew Auld
On 22/03/2024 14:29, Karolina Stolarek wrote: Add tests for ttm_bo_init_reserved() and ttm_bo_validate() that use sys manager. Define a simple move function in ttm_device_funcs. Expose destroy callback of the buffer object to make testing of ttm_bo_init_reserved() behaviour easier. Signed-off-by

Re: [PATCH] drm/bridge: imx8mp-hdmi-tx: Convert to platform remove callback returning void

2024-04-10 Thread Robert Foss
On Mon, 4 Mar 2024 10:10:06 +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a w

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Convert to platform remove callback returning void

2024-04-10 Thread Uwe Kleine-König
Hello Rob, On Wed, Apr 10, 2024 at 03:10:26PM +0200, Robert Foss wrote: > On Mon, 4 Mar 2024 10:05:56 +0100, Uwe Kleine-König wrote: > > The .remove() callback for a platform driver returns an int which makes > > many driver authors wrongly assume it's possible to do error handling by > > returnin

Re: [PATCH v12 1/9] drm/panic: Add drm panic locking

2024-04-10 Thread Jocelyn Falempe
Hi, On 10/04/2024 09:59, Daniel Vetter wrote: On Tue, Apr 09, 2024 at 06:30:40PM +0200, Jocelyn Falempe wrote: From: Daniel Vetter Rough sketch for the locking of drm panic printing code. The upshot of this approach is that we can pretty much entirely rely on the atomic commit flow, with the

Re: [PATCH v2 1/1] fbdev: add HAS_IOPORT dependencies

2024-04-10 Thread Helge Deller
On 4/10/24 12:56, Niklas Schnelle wrote: In a future patch HAS_IOPORT=n will disable inb()/outb() and friends at compile time. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Niklas Schnelle

Re: [PATCH net-next v8 2/3] net: ethernet: ti: Add desc_infos member to struct k3_cppi_desc_pool

2024-04-10 Thread Jakub Kicinski
On Wed, 10 Apr 2024 10:36:16 +0200 Julien Panis wrote: > Also, about mem alloc failures, shouldn't we free 'pool' on kstrdup_const() > error at the beginning of k3_cppi_desc_pool_create_name() ? > I mean, it's not visible in my patch but I now wonder if this was done > properly even before I modify

Re: [PATCH v2 15/43] drm/tiny/gm12u320: Use fbdev-shmem

2024-04-10 Thread Hans de Goede
Hi, On 4/10/24 3:02 PM, Thomas Zimmermann wrote: > Implement fbdev emulation with fbdev-shmem. Avoids the overhead of > fbdev-generic's additional shadow buffering. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Hans de Goede Thanks, patch looks good to me: Reviewed-by: Han

Re: [PATCH] drm/msm/dpu: Add callback function pointer check before its call

2024-04-10 Thread Dmitry Baryshkov
On Wed, 10 Apr 2024 at 14:53, Aleksandr Mishin wrote: > On 08.04.2024 12:03, Dmitry Baryshkov wrote: > > On Mon, 8 Apr 2024 at 11:57, Aleksandr Mishin wrote: > >> > >> In dpu_core_irq_callback_handler() callback function pointer is compared > >> to NULL, > >> but then callback function is uncond

Re: [PATCH] fbdev/sh7760fb: allow modular build

2024-04-10 Thread Helge Deller
On 4/10/24 06:54, Randy Dunlap wrote: Hi, Will someone be merging this patch? I've just added it to the fbdev git tree. Thanks! Helge thanks. On 2/10/24 1:31 AM, John Paul Adrian Glaubitz wrote: On Fri, 2024-02-09 at 21:39 -0800, Randy Dunlap wrote: There is no reason to prohibit sh776

Re: [PATCH] drm/bridge: imx8mp-hdmi-pvi: Convert to platform remove callback returning void

2024-04-10 Thread Robert Foss
On Mon, 4 Mar 2024 10:05:56 +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a w

[PATCH v2 05/43] fbdev/deferred-io: Test smem_start for I/O memory

2024-04-10 Thread Thomas Zimmermann
Test smem_start before looking up pages from its value. Return NULL if it is unset. This will result in a SIGBUS signal. Signed-off-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/core/fb_defio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 15/43] drm/tiny/gm12u320: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede --- drivers/gpu/drm/tiny/gm12u320.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v2 16/43] drm/tiny/ofdrm: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ofdrm.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH v2 42/43] drm/fbdev-generic: Convert to fbdev-ttm

2024-04-10 Thread Thomas Zimmermann
Only TTM-based drivers use fbdev-generic. Rename it to fbdev-ttm and change the symbol infix from _generic_ to _ttm_. Link the source file into TTM helpers, so that it is only build if TTM-based drivers have been selected. Select DRM_TTM_HELPER for loongson. Signed-off-by: Thomas Zimmermann ---

[PATCH v2 29/43] drm/renesas/rz-du: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rz-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Biju Das Tested-by: Biju Das --- drivers/gpu/drm/renesas

[PATCH v2 00/43] drm: Provide fbdev emulation per memory manager

2024-04-10 Thread Thomas Zimmermann
DRM provides 3 different memory managers with slightly different characteristics: DMA-based, SHMEM-based and TTM. This affects fbdev emulation as each requires different handling of mmap(). This series reworks fbdev emulation to provide an optimized emulation for each of the memory managers. Patch

[PATCH v2 38/43] drm/tiny/panel-mipi-dbi: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by panel-mipi-dbi. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- d

[PATCH v2 18/43] drm/udl: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Sean Paul Cc: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_drv.c | 4 ++-- 1 file changed, 2 insertions(

Re: [PATCH v10 2/9] drm/ttm/tests: Use an init function from the helpers lib

2024-04-10 Thread Matthew Auld
On 22/03/2024 14:29, Karolina Stolarek wrote: Add a new helper function that also initializes the device. Use it in ttm_tt test suite and delete the local definition. Signed-off-by: Karolina Stolarek Reviewed-by: Matthew Auld

[PATCH v2 14/43] drm/tiny/cirrus: Use fbdev-shmem

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-shmem. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/c

[PATCH v2 37/43] drm/tiny/mi0283qt: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by mi0283qt. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: "Noralf Trønnes" Acked-by: Noralf Trønnes --- drivers

[PATCH v2 28/43] drm/renesas/rcar-du: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rcar-du. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Kieran Bingham --- drivers/gpu/dr

[PATCH v2 31/43] drm/rockchip: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by rockchip. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan --- dri

[PATCH v2 26/43] drm/mediatek: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ingenic. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Chun-Kuang Hu Cc: Philipp Zabel --- drivers/gpu/drm/me

[PATCH v2 25/43] drm/ingenic: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ingenic. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Paul Cercueil --- drivers/gpu/drm/ingenic/ingenic-drm-d

[PATCH v2 22/43] drm/arm/komeda: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by komeda. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Liviu Dudau Acked-by: Liviu Dudau --- drivers/gpu/drm/a

[PATCH v2 36/43] drm/tiny/ili9486: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9486. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/ili9486.c | 4 ++-- 1 file changed,

[PATCH v2 30/43] drm/renesas/shmobile: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by shmobile. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Geert Uytterhoeven --- drivers/g

[PATCH v2 32/43] drm/tiny/hx8357d: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by hx8357d. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/hx8357d.c | 4 ++-- 1 file changed,

[PATCH v2 40/43] drm/tiny/st7586: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by st7586. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: David Lechner Acked-by: David Lechner --- drivers/gpu/d

[PATCH v2 24/43] drm/imx/lcdc: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by lcdc. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc

[PATCH v2 43/43] drm/fbdev: Clean up fbdev documentation

2024-04-10 Thread Thomas Zimmermann
Rewrite some docs that are not up-to-date any longer. Remove the TODO item for fbdev-generic conversion, as the helper has been replaced. Make documentation for DMA, SHMEM and TTM emulation available. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet --- Documentation/gpu/drm-kms-helpers.rst

[PATCH v2 35/43] drm/tiny/ili9341: Use fbdev-dma

2024-04-10 Thread Thomas Zimmermann
Implement fbdev emulation with fbdev-dma. Fbdev-dma now supports damage handling, which is required by ili9341. Avoids the overhead of fbdev-generic's additional shadow buffering. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Kamlesh Gurudasani --- drivers/gpu/drm/tiny/ili9341.c |

  1   2   3   >