Re: [PATCH v6 08/14] drm/mediatek: Support "Pre-multiplied" alpha blending in OVL

2024-03-21 Thread 胡俊光

Re: [PATCH v5 12/13] drm/ast: Implement polling for VGA and SIL164 connectors

2024-03-21 Thread Thomas Zimmermann
Hi Am 21.03.24 um 15:09 schrieb Maxime Ripard: Hi, On Wed, Mar 20, 2024 at 10:34:17AM +0100, Thomas Zimmermann wrote: +/** + * drm_connector_helper_detect_ctx - Read EDID and detect connector status. + * @connector: The connector + * @ctx: Acquire context + * @force: Perform screen-destructive

[PATCH] drm/amd/display: clean up some inconsistent indenting

2024-03-21 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn351/dcn351_fpu.c:569 dcn351_decide_zstate_support() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8608 Signed-off-by: Jiapeng Chong --- drivers/

Re: [PATCH] drm: zynqmp_dpsub: Always register bridge

2024-03-21 Thread Tomi Valkeinen
Hi, On 08/03/2024 22:47, Sean Anderson wrote: We must always register the DRM bridge, since zynqmp_dp_hpd_work_func calls drm_bridge_hpd_notify, which in turn expects hpd_mutex to be initialized. We do this before zynqmp_dpsub_drm_init since that calls drm_bridge_attach. This fixes the following

Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-21 Thread Krzysztof Kozlowski
On 21/03/2024 21:43, Anatoliy Klymenko wrote: > diff --git a/include/dt-bindings/media/media-bus-format.h > b/include/dt-bindings/media/media-bus-format.h > new file mode 100644 > index ..60fc6e11dabc > --- /dev/null > +++ b/include/dt-bindings/media/media-bus-format.h > @@ -0,0 +1,177

Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-21 Thread Krzysztof Kozlowski
On 21/03/2024 21:43, Anatoliy Klymenko wrote: > DO NOT MERGE. REFERENCE ONLY. Why? What are you doing here and why nothing about this is explained? > > Add binding for AMD/Xilinx Video Timing Controller and Test Pattern > Generator. > > Copy media-bus-formats.h into dt-bindings/media to suplem

Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-21 Thread Tomi Valkeinen
On 21/03/2024 17:33, Sean Anderson wrote: On 3/20/24 02:05, Randy Dunlap wrote: On 3/19/24 22:42, Tomi Valkeinen wrote: On 20/03/2024 00:51, Sean Anderson wrote: Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed members. Signed-off-by: Sean Anderson --- Changes in v

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-21 Thread Tomi Valkeinen
On 21/03/2024 21:17, Sean Anderson wrote: On 3/21/24 15:08, Tomi Valkeinen wrote: On 21/03/2024 20:01, Sean Anderson wrote: On 3/21/24 13:25, Tomi Valkeinen wrote: On 21/03/2024 17:52, Sean Anderson wrote: On 3/20/24 02:53, Tomi Valkeinen wrote: On 20/03/2024 00:51, Sean Anderson wrote: Ret

[PATCH v6 13/14] drm/mediatek: Support CRC in OVL

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung We choose OVL as the CRC generator from other hardware components that are also capable of calculating CRCs, since its frame done event triggers vblanks, it can be used as a signal to know when is safe to retrieve CRC of the frame. Please note that position of the hardware

[PATCH v6 12/14] drm/mediatek: Support CRC in display driver

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Register CRC related function pointers to support CRC retrieval. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 260 drivers/gpu/drm/mediatek/mtk_crtc.h | 38 drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 3

[PATCH v6 14/14] drm/mediatek: Support CRC in OVL adaptor

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung We choose Mixer as CRC generator in OVL adaptor since its frame done event will trigger vblanks, we can know when is safe to retrieve CRC of the frame. In OVL adaptor, there's no image procession after Mixer, unlike the OVL in VDOSYS0, Mixer's CRC will include all the effe

[PATCH v6 02/14] drm/mediatek: Add OVL compatible name for MT8195

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Add OVL compatible name for MT8195. Without this commit, DRM won't work after modifying the device tree. Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ 1 file changed, 2 ins

[PATCH v6 09/14] drm/mediatek: Support "Pre-multiplied" alpha blending in Mixer

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" blend mode on MediaTek's chips. Before this patch, only the "Coverage" mode is supported. Please refer to the description of the commit "drm/mediatek: Support alpha blending in display driver" for more information. Signed-off-by: Hsiao Chien Sung

[PATCH v6 04/14] drm/mediatek: Add DRM_MODE_ROTATE_0 to rotation property

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Always add DRM_MODE_ROTATE_0 to rotation property to meet IGT's (Intel GPU Tools) requirement. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 6 +- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21

[PATCH v6 00/14] Support IGT in display driver

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung This series is based on 20240322012808.26234-1-shawn.s...@mediatek.com. This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs f

[PATCH v6 05/14] drm/mediatek: Set DRM mode configs accordingly

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Set DRM mode configs limitation according to the hardware capabilities and pass the IGT checks as below: - The test "graphics.IgtKms.kms_plane" requires a frame buffer with width of 4512 pixels (> 4096). - The test "graphics.IgtKms.kms_cursor_crc" checks if the cursor si

[PATCH v6 08/14] drm/mediatek: Support "Pre-multiplied" alpha blending in OVL

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" blend mode on MediaTek's chips. Before this patch, only the "coverage" mode is supported. Please refer to the description of the commit "drm/mediatek: Support alpha blending in display driver" for more information. Signed-off-by: Hsiao Chien Sung

[PATCH v6 07/14] drm/mediatek: Support alpha blending in display driver

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by adding correct blend mode property when the planes init. Before this patch, only the "Coverage" mode (default) is supported. For more information, there are three pixel blend modes in DRM driver: "None",

[PATCH v6 11/14] drm/mediatek: Support "None" alpha blending in Mixer

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" blend mode on MediaTek's chips. Please refer to the description of the commit "drm/mediatek: Support alpha blending in display driver" for more information. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ethdr.c | 3 ++- 1 file changed,

[PATCH v6 10/14] drm/mediatek: Support "None" alpha blending in OVL

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Support "None" blend mode on MediaTek's chips. Please refer to the description of the commit "drm/mediatek: Support alpha blending in display driver" for more information. Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 3 ++- 1 file change

[PATCH v6 03/14] drm/mediatek: Add missing plane settings when async update

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Fix an issue that plane coordinate was not saved when calling async update. Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update") Reviewed-by: CK Hu Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/gpu/d

[PATCH v6 06/14] drm/mediatek: Turn off the layers with zero width or height

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung We found that IGT (Intel GPU Tool) will try to commit layers with zero width or height and lead to undefined behaviors in hardware. Disable the layers in such a situation. Fixes: 777b7bc86a0a ("UPSTREAM: drm/mediatek: Add ovl_adaptor support for MT8195") Fixes: fa97fe71f6

[PATCH v6 01/14] soc: mediatek: Disable 9-bit alpha in ETHDR

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung ETHDR 9-bit alpha should be disabled by default, otherwise alpha blending will not work. Reviewed-by: AngeloGioacchino Del Regno Signed-off-by: Hsiao Chien Sung --- drivers/soc/mediatek/mtk-mmsys.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/mediate

[PATCH] accel/qaic: Add Sahara implementation for firmware loading

2024-03-21 Thread Jeffrey Hugo
The AIC100 secondary bootloader uses the Sahara protocol for two purposes - loading the runtime firmware images from the host, and offloading crashdumps to the host. The crashdump functionality is only invoked when the AIC100 device encounters a crash and dumps are enabled. Also the collection of t

Re: [git pull] drm fixes for 6.9-rc1

2024-03-21 Thread pr-tracker-bot
The pull request you sent on Fri, 22 Mar 2024 11:34:13 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-next-2024-03-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7ee04901215b3cab8fa35aa5bf4692d7aa312e36 Thank you! -- Deet-doot-dot, I am a bot. ht

[git pull] drm fixes for 6.9-rc1

2024-03-21 Thread Dave Airlie
Hey Linus, Fixes from the last week (or 3 weeks in amdgpu case), after amdgpu, it's xe and nouveau then a few scattered core fixes. Regards, Dave. drm-next-2024-03-22: drm fixes for 6.9-rc1 core: - fix rounding in drm_fixp2int_round() bridge: - fix documentation for DRM_BRIDGE_OP_EDID sun4i:

[PATCH v4 09/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.c" to "mtk_ddp_comp.c"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_ddp_comp.c to mtk_ddp_comp.c and modify the Makefile accordingly. Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 2 +- drivers/gpu/dr

[PATCH v4 14/14] drm/mediatek: Rename mtk_ddp_comp functions

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename functions of mtk_ddp_comp: - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 45 ++--- drivers/gpu/dr

[PATCH v4 05/14] drm/mediatek: Rename "mtk_drm_hdmi" to "mtk_hdmi"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_hdmi" to "mtk_hdmi": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 14 +++--- 1 file changed, 7 inse

[PATCH v4 00/14] Rename mtk_drm_* to mtk_*

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename some unnecessary "mtk_drm_*" to "mtk_*" to: - Lower the matches when searching the native drm_* codes - Reduce the code size Changes in v4: - Fix patch error Changes in v3: - Fix typo and patch error Changes in v2: - Sort header files alphabetically - Seperate pa

[PATCH v4 06/14] drm/mediatek: Rename files "mtk_drm_crtc.h" to "mtk_crtc.h"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.h to mtk_crtc.h. Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/{mtk_drm_crtc.h => mtk_crtc.h} | 0 drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +- drive

[PATCH v4 02/14] drm/mediatek: Rename "mtk_drm_ddp_comp" to "mtk_ddp_comp"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 16 +++- driv

[PATCH v4 04/14] drm/mediatek: Rename "mtk_drm_gem" to "mtk_gem"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_gem" to "mtk_gem": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +-- drivers/gpu/drm/mediatek/mtk_d

[PATCH v4 08/14] drm/mediatek: Rename files "mtk_drm_ddp_comp.h" to "mtk_ddp_comp.h"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_ddp_comp.h to mtk_ddp_comp.h. Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_crtc.h

[PATCH v4 01/14] drm/mediatek: Rename "mtk_drm_crtc" to "mtk_crtc"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_crtc" to "mtk_crtc" due to the following benefits: - Lower the matches when searching the native drm_crtc* codes - Reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/m

[PATCH v4 12/14] drm/mediatek: Rename files "mtk_drm_gem.h" to "mtk_gem.h"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.h to mtk_gem.h. Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 +- drivers/

[PATCH v4 13/14] drm/mediatek: Rename files "mtk_drm_gem.c" to "mtk_gem.c"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_gem.c to mtk_gem.c. Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 2 +- drivers/gpu/drm/mediatek/{mtk_drm_gem.c => mtk_gem.c} | 0 2 files cha

[PATCH v4 03/14] drm/mediatek: Rename "mtk_drm_plane" to "mtk_plane"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename all "mtk_drm_plane" to "mtk_plane": - To align the naming rule - To reduce the code size Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 6 +++--- drivers/gpu/drm/mediatek

[PATCH v4 11/14] drm/mediatek: Rename files "mtk_drm_plane.c" to "mtk_plane.c"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.c to mtk_plane.c and modify the Makefile accordingly. Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek

[PATCH v4 10/14] drm/mediatek: Rename files "mtk_drm_plane.h" to "mtk_plane.h"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_plane.h to mtk_plane.h. Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/mtk_crtc.c | 2 +- drivers/gpu/drm/mediatek/mtk_crtc.h | 2

[PATCH v4 07/14] drm/mediatek: Rename files "mtk_drm_crtc.c" to "mtk_crtc.c"

2024-03-21 Thread Shawn Sung
From: Hsiao Chien Sung Rename files mtk_drm_crtc.c to mtk_crtc.c and modify the Makefile accordingly. Reviewed-by: AngeloGiaocchino Del Regno Reviewed-by: CK Hu Signed-off-by: Hsiao Chien Sung --- drivers/gpu/drm/mediatek/Makefile | 4 ++-- drivers/gpu/drm/mediatek/{mt

Re: [PATCH v3 5/5] drm/msm/dpu: drop dpu_core_perf_params::max_per_pipe_ib

2024-03-21 Thread Abhinav Kumar
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: The max_per_pipe_ib is a constant across all CRTCs and is read from the catalog. Drop corresponding calculations and read the value directly at icc_set_bw() time. Suggested-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/

Re: [PATCH v3 4/5] drm/msm/dpu: rework core_perf debugfs overrides

2024-03-21 Thread Abhinav Kumar
On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: Currently debugfs provides separate 'modes' to override calculated MDP_CLK rate and interconnect bandwidth votes. Change that to allow overriding individual values (e.g. one can override just clock or just average bandwidth vote). I am not oppos

Re: [PATCH v3 3/5] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

2024-03-21 Thread Abhinav Kumar
On 3/19/2024 3:25 PM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 23:35, Abhinav Kumar wrote: On 3/19/2024 1:43 PM, Dmitry Baryshkov wrote: On Tue, 19 Mar 2024 at 22:34, Abhinav Kumar wrote: On 3/13/2024 6:10 PM, Dmitry Baryshkov wrote: Move perf mode handling for the bandwidth

Re: [v10,03/27] drm/connector: hdmi: Create an HDMI sub-state

2024-03-21 Thread Sui Jingfeng
Hi, On 2024/3/21 23:28, Maxime Ripard wrote: The next features we will need to share across drivers will need to store some parameters for drivers to use, such as the selected output format. Let's create a new connector sub-state dedicated to HDMI controllers, that will eventually store everyt

Re: [PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-21 Thread Rob Herring
ion /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/xlnx/xlnx,vtc.yaml: xlnx,pixels-per-clock: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240321-dp-live-fmt-v3-8-d5090d7

[PATCH] drm/debugfs: Drop conditionals around of_node pointers

2024-03-21 Thread Sui Jingfeng
Having conditional around the of_node pointer of the drm_bridge structure turns out to make driver code use ugly #ifdef blocks. Drop the conditionals to simplify debugfs. Fixes: d8dfccde2709 ("drm/bridge: Drop conditionals around of_node pointers") Signed-off-by: Sui Jingfeng --- drivers/gpu/drm

Re: [PATCH v2] drm/i915/gt: Report full vm address range

2024-03-21 Thread Nirmoy Das
Hi Andi, On 3/21/2024 4:17 PM, Andi Shyti wrote: Commit 9bb66c179f50 ("drm/i915: Reserve some kernel space per vm") has reserved an object for kernel space usage. Userspace, though, needs to know the full address range. In the former patch the reserved space was substructed from the total amou

[pull] amdgpu, amdkfd drm-fixes-6.9

2024-03-21 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.9. Fairly big because it's about 3 weeks of fixes. The following changes since commit 119b225f01e4d3ce974cd3b4d982c76a380c796d: Merge tag 'amd-drm-next-6.9-2024-03-08-1' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2024-03-11 13:32:12 +1000) are a

Re: [v10,20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-21 Thread Sui Jingfeng
Hi, On 2024/3/21 23:29, Maxime Ripard wrote: Infoframes in KMS is usually handled by a bunch of low-level helpers that require quite some boilerplate for drivers. This leads to discrepancies with how drivers generate them, and which are actually sent. Now that we have everything needed to gene

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-03-21 Thread Harry Wentland
On 2024-03-15 13:09, sunpeng...@amd.com wrote: > From: Leo Li > > [Why] > > DCN is the display hardware for amdgpu. DRM planes are backed by DCN > hardware pipes, which carry pixel data from one end (memory), to the > other (output encoder). > > Each DCN pipe has the ability to blend in a cu

Re: [PATCH 2/2] drm/amd/display: Move PRIMARY plane zpos higher

2024-03-21 Thread Harry Wentland
On 2024-03-15 13:09, sunpeng...@amd.com wrote: > From: Leo Li > > [Why] > > Compositors have different ways of assigning surfaces to DRM planes for > render offloading. It may decide between various strategies: overlay, > underlay, or a mix of both > > One way for compositors to implement th

Re: [v5,13/13] drm/ast: Automatically clean up poll helper

2024-03-21 Thread Sui Jingfeng
Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: + +/** + * devm_drm_kms_helper_poll_init - initialize and enable output polling Should be drmm_kms_helper_poll_init() here. + * @dev: drm_device + * + * This function initializes and then also enables output polling support for + * @dev si

[PATCH v3 9/9] drm: xlnx: Intoduce TPG CRTC driver

2024-03-21 Thread Anatoliy Klymenko
DO NOT MERGE. REFERENCE ONLY. Add CRTC driver based on AMD/Xilinx Video Test Pattern Generator IP. TPG based FPGA design represents minimalistic harness useful for testing links between FPGA based CRTC and external DRM encoders, both FPGA and hardened IP based. Add driver for AMD/Xilinx Video Tim

[PATCH v3 8/9] dt-bindings: xlnx: Add VTC and TPG bindings

2024-03-21 Thread Anatoliy Klymenko
DO NOT MERGE. REFERENCE ONLY. Add binding for AMD/Xilinx Video Timing Controller and Test Pattern Generator. Copy media-bus-formats.h into dt-bindings/media to suplement TPG DT node. Signed-off-by: Anatoliy Klymenko --- .../bindings/display/xlnx/xlnx,v-tpg.yaml | 87 ++ .../d

[PATCH v3 3/9] drm: xlnx: zynqmp_dpsub: Add connected live layer helper

2024-03-21 Thread Anatoliy Klymenko
Add a helper function capturing the first connected live display layer discovery logic. Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp

[PATCH v3 7/9] drm/atomic-helper: Add select_output_bus_format callback

2024-03-21 Thread Anatoliy Klymenko
Add optional drm_crtc_helper_funcs.select_output_bus_format callback. This callback allows to negotiate compatible media bus format on the link between CRTC and connected DRM encoder or DRM bridge chain. A good usage example is the CRTC implemented as FPGA soft IP. This kind of CRTC will most certa

[PATCH v3 6/9] drm: xlnx: zynqmp_dpsub: Set input live format

2024-03-21 Thread Anatoliy Klymenko
Program live video input format according to selected media bus format. In the bridge mode of operation, DPSUB is connected to FPGA CRTC which almost certainly supports a single media bus format as its output. Expect this to be delivered via the new bridge atomic state. Program DPSUB registers acc

[PATCH v3 5/9] drm: xlnx: zynqmp_dpsub: Minimize usage of global flag

2024-03-21 Thread Anatoliy Klymenko
Avoid usage of global zynqmp_dpsub.dma_enabled flag in DPSUB layer context. This flag signals whether the driver runs in DRM CRTC or DRM bridge mode, assuming that all display layers share the same live or non-live mode of operation. Using per-layer mode instead of global flag will simplify future

[PATCH v3 4/9] drm: xlnx: zynqmp_dpsub: Anounce supported input formats

2024-03-21 Thread Anatoliy Klymenko
DPSUB in bridge mode supports multiple input media bus formats. Announce the list of supported input media bus formats via drm_bridge.atomic_get_input_bus_fmts callback. Introduce a set of live input formats, supported by DPSUB. Rename zynqmp_disp_layer_drm_formats() to zynqmp_disp_layer_formats()

[PATCH v3 2/9] drm: xlnx: zynqmp_dpsub: Update live format defines

2024-03-21 Thread Anatoliy Klymenko
Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG register layout. Reviewed-by: Laurent Pinchart Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_di

[PATCH v3 1/9] drm: xlnx: zynqmp_dpsub: Set layer mode during creation

2024-03-21 Thread Anatoliy Klymenko
Set layer mode of operation (live or dma-based) during layer creation. Each DPSUB layer mode of operation is defined by corresponding DT node port connection, so it is possible to assign it during layer object creation. Previously it was set in layer enable functions, although it is too late as se

[PATCH v3 0/9] Setting live video input format for ZynqMP DPSUB

2024-03-21 Thread Anatoliy Klymenko
Implement live video input format setting for ZynqMP DPSUB. ZynqMP DPSUB can operate in 2 modes: DMA-based and live. In the live mode, DPSUB receives a live video signal from FPGA-based CRTC. DPSUB acts as a DRM encoder bridge in such a scenario. To properly tune into the incoming video signal, D

Re: [PATCH] drm/amdgpu: fix function implicit declaration error

2024-03-21 Thread Alex Deucher
Acked-by: Alex Deucher On Thu, Mar 21, 2024 at 2:14 PM Sunil Khatri wrote: > > when CONFIG_DEV_COREDUMP is not defined in that case > when amdgpu_coredump() is called it does not find it's > definition and the build fails. > > This happens as the header is defined without the > CONFIG_DEV_COREDU

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-21 Thread Sean Anderson
On 3/21/24 15:08, Tomi Valkeinen wrote: > On 21/03/2024 20:01, Sean Anderson wrote: >> On 3/21/24 13:25, Tomi Valkeinen wrote: >>> On 21/03/2024 17:52, Sean Anderson wrote: On 3/20/24 02:53, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: >> Retraining the link can ta

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-21 Thread Tomi Valkeinen
On 21/03/2024 20:01, Sean Anderson wrote: On 3/21/24 13:25, Tomi Valkeinen wrote: On 21/03/2024 17:52, Sean Anderson wrote: On 3/20/24 02:53, Tomi Valkeinen wrote: On 20/03/2024 00:51, Sean Anderson wrote: Retraining the link can take a while, and might involve waiting for DPCD reads/writes t

Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-03-21 Thread Dmitry Baryshkov
On Thu, 21 Mar 2024 at 20:28, Abhinav Kumar wrote: > > > > On 3/21/2024 11:09 AM, Dmitry Baryshkov wrote: > > On Thu, 21 Mar 2024 at 19:36, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/21/2024 8:43 AM, Dmitry Baryshkov wrote: > >>> On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar > >>> wrote:

Re: [GIT PULL] fbdev fixes and cleanups for v6.9-rc1

2024-03-21 Thread Helge Deller
On 3/21/24 19:29, Helge Deller wrote: Hi Linus, please pull fixes and cleanups for the fbdev subsystem for kernel 6.9-rc1. Linus, please wait There is one new "unused variable warning" introduced with those patches. I'll fix it up and send a new pull request tomorrow... Helge Beside

[GIT PULL] fbdev fixes and cleanups for v6.9-rc1

2024-03-21 Thread Helge Deller
Hi Linus, please pull fixes and cleanups for the fbdev subsystem for kernel 6.9-rc1. Beside the typical bunch of smaller fixes, the Linux console now allows fonts up to a size of 64 x 128 pixels. Thanks! Helge The following change

Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-03-21 Thread Abhinav Kumar
On 3/21/2024 11:09 AM, Dmitry Baryshkov wrote: On Thu, 21 Mar 2024 at 19:36, Abhinav Kumar wrote: On 3/21/2024 8:43 AM, Dmitry Baryshkov wrote: On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar wrote: On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote: The DPU driver provides support for 4:2:0

Re: [PATCH v2 0/6] backlight: Remove struct backlight_properties.fb_blank

2024-03-21 Thread Lee Jones
On Tue, 19 Mar 2024, Thomas Zimmermann wrote: > The field fb_blank in struct backlight_properties has been marked for > removal. Remove it in favor of the power and state fields. > > Patches 1 to 5 prepare several backlight drivers. They remove fb_blank > or replace driver code with existing help

[PATCH] drm/amdgpu: fix function implicit declaration error

2024-03-21 Thread Sunil Khatri
when CONFIG_DEV_COREDUMP is not defined in that case when amdgpu_coredump() is called it does not find it's definition and the build fails. This happens as the header is defined without the CONFIG_DEV_COREDUMP ifdef and due to which header isn't enabled. Pulling the header out of such ifdef so in

Re: (subset) [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode()

2024-03-21 Thread Lee Jones
On Sat, 16 Mar 2024 12:45:27 +0300, Dan Carpenter wrote: > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't > cause an issue at runtime because devm_kcalloc() won't allocate negative > sizes. However, it's still worth

Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-03-21 Thread Dmitry Baryshkov
On Thu, 21 Mar 2024 at 19:36, Abhinav Kumar wrote: > > > > On 3/21/2024 8:43 AM, Dmitry Baryshkov wrote: > > On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote: > >>> The DPU driver provides support for 4:2:0 planar YCbCr plane

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-21 Thread Sean Anderson
On 3/21/24 13:25, Tomi Valkeinen wrote: > On 21/03/2024 17:52, Sean Anderson wrote: >> On 3/20/24 02:53, Tomi Valkeinen wrote: >>> On 20/03/2024 00:51, Sean Anderson wrote: Retraining the link can take a while, and might involve waiting for DPCD reads/writes to complete. This is inappropr

Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-03-21 Thread Abhinav Kumar
On 3/21/2024 8:43 AM, Dmitry Baryshkov wrote: On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar wrote: On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote: The DPU driver provides support for 4:2:0 planar YCbCr plane formats. Extend it to also support 4:2:2 and 4:4:4 plat formats. I checked myself

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-21 Thread Tomi Valkeinen
On 21/03/2024 17:52, Sean Anderson wrote: On 3/20/24 02:53, Tomi Valkeinen wrote: On 20/03/2024 00:51, Sean Anderson wrote: Retraining the link can take a while, and might involve waiting for DPCD reads/writes to complete. This is inappropriate for an IRQ handler. Just schedule this work for la

Re: [v3,5/5] drm/xe: Enable 32bits build

2024-03-21 Thread Guenter Roeck
On 3/18/24 06:28, Lucas De Marchi wrote: On Sun, Mar 17, 2024 at 09:14:14AM -0700, Guenter Roeck wrote: Hi, On Thu, Jan 18, 2024 at 04:16:12PM -0800, Lucas De Marchi wrote: Now that all the issues with 32bits are fixed, enable it again. Reviewed-by: Matt Roper Signed-off-by: Lucas De Marchi

Re: [PATCH] drm/msm/dp: move link_ready out of HPD event thread

2024-03-21 Thread Johan Hovold
On Mon, Mar 18, 2024 at 11:01:25AM -0700, Abhinav Kumar wrote: > On 3/15/2024 8:57 AM, Johan Hovold wrote: > > On Thu, Mar 14, 2024 at 09:30:57AM -0700, Abhinav Kumar wrote: > >> The race condition is between the time we get disconnect event and set > >> link_ready to false, a commit can come in.

Re: [PATCH v2 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-21 Thread Sean Anderson
On 3/21/24 12:31, Tomi Valkeinen wrote: > On 21/03/2024 18:08, Sean Anderson wrote: >> On 3/20/24 03:49, Tomi Valkeinen wrote: >>> On 20/03/2024 00:51, Sean Anderson wrote: >>> +/** + * enum test_pattern - Test patterns for test testing >>> >>> "for test testing"? =) >>> @@ -1655,6 +

Re: [PATCH v2 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-21 Thread Tomi Valkeinen
On 21/03/2024 18:08, Sean Anderson wrote: On 3/20/24 03:49, Tomi Valkeinen wrote: On 20/03/2024 00:51, Sean Anderson wrote: +/** + * enum test_pattern - Test patterns for test testing "for test testing"? =) @@ -1655,6 +2321,9 @@ static void zynqmp_dp_hpd_irq_work_func(struct work_struct *

Re: [PATCH] drm/sun4i: tcon: Support keeping dclk rate upon ancestor clock changes

2024-03-21 Thread Maxime Ripard
On Thu, Mar 14, 2024 at 06:20:58PM +0100, Jernej Škrabec wrote: > Dne četrtek, 14. marec 2024 ob 15:42:24 CET je Maxime Ripard napisal(a): > > On Sun, Mar 10, 2024 at 02:32:29PM +0100, Frank Oltmanns wrote: > > > Allow the dclk to reset its rate when a rate change is initiated from an > > > ancesto

[PULL] drm-misc-next-fixes

2024-03-21 Thread Thomas Zimmermann
Hi Dave, Sima, here's the drm-misc-next-fixes PR for this week. Best regards Thomas drm-misc-next-fixes-2024-03-21: Short summary of fixes pull: core: - fix rounding in drm_fixp2int_round() bridge: - fix documentation for DRM_BRIDGE_OP_EDID nouveau: - don't check devinit disable on GSP sun4i

Re: [PATCH v4 00/10] backlight: Replace struct fb_info in interfaces

2024-03-21 Thread Lee Jones
On Thu, 21 Mar 2024, Lee Jones wrote: > On Tue, 05 Mar 2024 17:22:33 +0100, Thomas Zimmermann wrote: > > Backlight drivers implement struct backlight_ops.check_fb, which > > uses struct fb_info in its interface. Replace the callback with one > > that does not use fb_info. > > > > In DRM, we have

Re: [PATCH v4 00/10] backlight: Replace struct fb_info in interfaces

2024-03-21 Thread Lee Jones
On Tue, 05 Mar 2024 17:22:33 +0100, Thomas Zimmermann wrote: > Backlight drivers implement struct backlight_ops.check_fb, which > uses struct fb_info in its interface. Replace the callback with one > that does not use fb_info. > > In DRM, we have several drivers that implement backlight support. B

Re: [PATCH v2 8/8] drm: zynqmp_dp: Add debugfs interface for compliance testing

2024-03-21 Thread Sean Anderson
On 3/20/24 03:49, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: > >> +/** >> + * enum test_pattern - Test patterns for test testing > > "for test testing"? =) > >> @@ -1655,6 +2321,9 @@ static void zynqmp_dp_hpd_irq_work_func(struct >> work_struct *work) >> u8 status[D

Re: [PATCH v2 5/8] drm: zynqmp_dp: Don't retrain the link in our IRQ

2024-03-21 Thread Sean Anderson
On 3/20/24 02:53, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: >> Retraining the link can take a while, and might involve waiting for >> DPCD reads/writes to complete. This is inappropriate for an IRQ handler. >> Just schedule this work for later completion. This is racy, but w

Re: [PATCH v2 4/8] drm: zynqmp_dp: Rearrange zynqmp_dp for better padding

2024-03-21 Thread Sean Anderson
On 3/20/24 02:14, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: >> Sort the members of struct zynqmp_dp to reduce padding necessary for >> alignment. >> >> Signed-off-by: Sean Anderson >> --- >> >> Changes in v2: >> - New >> >> drivers/gpu/drm/xlnx/zynqmp_dp.c | 28 ++

Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-03-21 Thread Dmitry Baryshkov
On Fri, 23 Feb 2024 at 22:48, Abhinav Kumar wrote: > > > > On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote: > > The DPU driver provides support for 4:2:0 planar YCbCr plane formats. > > Extend it to also support 4:2:2 and 4:4:4 plat formats. > > > > I checked myself and also internally on this. On sm

Re: [PATCH] drm/i915: use READ_ONCE() to read vma->iomap in concurrent environment

2024-03-21 Thread linke li
Hi, I want to confirm the status of this patch and whether need any additional information.

[PATCH] Fix duplicate C declaration warnings

2024-03-21 Thread Amogh Cheluvaraj
Fix the duplicate C declaration warnings found on Documentation/gpu/drm-kms.rst that was found by compiling htmldocs Signed-off-by: Amogh Cheluvaraj --- Documentation/gpu/drm-kms.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-km

Re: [PATCH] Fix duplicate C declaration warnings

2024-03-21 Thread Jani Nikula
On Thu, 21 Mar 2024, Amogh Cheluvaraj wrote: > Fix the duplicate C declaration warnings found on > Documentation/gpu/drm-kms.rst that was found by > compiling htmldocs Please paste the warnings here. BR, Jani. > > Signed-off-by: Amogh Cheluvaraj > --- > Documentation/gpu/drm-kms.rst | 6

Re: [PATCH v2 3/8] drm: zynqmp_dp: Adjust training values per-lane

2024-03-21 Thread Sean Anderson
On 3/20/24 01:57, Tomi Valkeinen wrote: > On 20/03/2024 00:51, Sean Anderson wrote: >> The feedback we get from the DPRX is per-lane. Make changes using this >> information, instead of picking the maximum values from all lanes. This >> results in more-consistent training on marginal links. >> >> Si

Re: [PATCH v2 1/8] drm: xlnx: Fix kerneldoc

2024-03-21 Thread Sean Anderson
On 3/20/24 02:05, Randy Dunlap wrote: > > > On 3/19/24 22:42, Tomi Valkeinen wrote: >> On 20/03/2024 00:51, Sean Anderson wrote: >>> Fix a few errors in the kerneldoc. Mostly this addresses missing/renamed >>> members. >>> >>> Signed-off-by: Sean Anderson >>> --- >>> >>> Changes in v2: >>> - New

[PATCH v10 25/27] drm/vc4: tests: Convert to plane creation helper

2024-03-21 Thread Maxime Ripard
Now that we have a plane create helper for kunit mocked drivers, let's convert to it in vc4. Reviewed-by: Maíra Canal Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/tests/vc4_mock_plane.c | 34 +++--- 1 file changed, 8 insertions(+), 26 deletions(-) diff --git a/d

[PATCH v10 22/27] drm/connector: hdmi: Create Infoframe DebugFS entries

2024-03-21 Thread Maxime Ripard
There has been some discussions recently about the infoframes sent by drivers and if they were properly generated. In parallel, there's been some interest in creating an infoframe-decode tool similar to edid-decode. Both would be much easier if we were to expose the infoframes programmed in the h

[PATCH v10 26/27] drm/rockchip: inno_hdmi: Switch to HDMI connector

2024-03-21 Thread Maxime Ripard
The new HDMI connector infrastructure allows to remove some boilerplate, especially to generate infoframes. Let's switch to it. Reviewed-by: Heiko Stuebner Acked-by: Heiko Stuebner Signed-off-by: Maxime Ripard --- drivers/gpu/drm/rockchip/inno_hdmi.c | 143 +--

[PATCH v10 27/27] drm/sun4i: hdmi: Switch to HDMI connector

2024-03-21 Thread Maxime Ripard
The new HDMI connector infrastructure allows to remove some boilerplate, especially to generate infoframes. Let's switch to it. Reviewed-by: Jernej Skrabec Acked-by: Sui Jingfeng Signed-off-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 80 ++ 1

[PATCH v10 20/27] drm/connector: hdmi: Add Infoframes generation

2024-03-21 Thread Maxime Ripard
Infoframes in KMS is usually handled by a bunch of low-level helpers that require quite some boilerplate for drivers. This leads to discrepancies with how drivers generate them, and which are actually sent. Now that we have everything needed to generate them in the HDMI connector state, we can gen

[PATCH v10 21/27] drm/tests: Add infoframes test

2024-03-21 Thread Maxime Ripard
The previous patch added the generation of the infoframes matching an HDMI connector state. Let's add a few tests to make sure it works as expected. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_connector_test.c | 219 + 1 file changed, 219 insertions(+)

  1   2   >