Re: [PATCH] Revert "drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"

2024-02-27 Thread Johan Hovold
On Wed, Feb 28, 2024 at 12:08:08AM +0200, Dmitry Baryshkov wrote: > This reverts commit e467e0bde881 ("drm/msm/dp: use > drm_bridge_hpd_notify() to report HPD status changes"). > > The commit changed the way how the MSM DP driver communicates > HPD-related events to the userspace. The mentioned co

Re: [PATCH 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-02-27 Thread Krzysztof Kozlowski
On 27/02/2024 16:18, Alexandre Mergnat wrote: >> >>> +type: boolean >>> + >>> + mediatek,dmic-iir-on: >>> +description: >>> + Boolean which specifies whether the DMIC IIR is enabled. >>> + If this property is not present the IIR is disabled. >> >> "is enabled" or "enable it"? >>

Re: [PATCH 1/6] drm/tests/drm_buddy: fix 32b build

2024-02-27 Thread Christian König
Am 26.02.24 um 10:58 schrieb Matthew Auld: On 19/02/2024 12:24, Matthew Auld wrote: On 19/02/2024 10:48, Matthew Auld wrote: On 19/02/2024 10:30, Christian König wrote: Am 19.02.24 um 11:28 schrieb Matthew Auld: On 19/02/2024 09:53, Christian König wrote: Am 19.02.24 um 10:42 schrieb Matthew

Re: [PATCH] dt-bindings: display: atmel,lcdc: convert to dtschema

2024-02-27 Thread Krzysztof Kozlowski
On 28/02/2024 07:59, dharm...@microchip.com wrote: > >> >> I don't know what's this exactly, but if embedded display then maybe >> could be part of this device node. If some other display, then maybe you >> need another schema, with compatible? But first I would check how others >> are doing this.

Re: [PATCH] dt-bindings: display: atmel,lcdc: convert to dtschema

2024-02-27 Thread Dharma.B
Hi Krzysztof, On 27/02/24 5:33 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 23/02/2024 10:14, Dharma Balasubiramani wrote: >> Convert the atmel,lcdc bindings to DT schema. >> Changes during conversion: add mi

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Fix enable error path

2024-02-27 Thread Alexander Stein
Hi Luca, Am Dienstag, 27. Februar 2024, 18:41:44 CET schrieb Luca Ceresoli: > Hi Alexander, > > thanks for your feedback! > > On Tue, 27 Feb 2024 13:05:46 +0100 > Alexander Stein wrote: > > > Hi Luca, > > > > Am Donnerstag, 22. Februar 2024, 16:36:37 CET schrieb Luca Ceresoli: > > > Hello Ale

Re: [PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions

2024-02-27 Thread Christian König
Am 28.02.24 um 02:44 schrieb Lu Yao: uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer. Yeah, but that is completely irrelevant here. We usually don't use the & for function pointers since that is unnecessary in C. Regards, Christian. Signed-off-by: Lu Yao --- drivers/g

Re: [PATCH] drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED

2024-02-27 Thread Christian König
Am 27.02.24 um 21:26 schrieb Ville Syrjala: From: Ville Syrjälä inlined from ‘i915_ttm_get_pages’ at ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:847:2: ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:165:18: warning: ‘places[0].flags’ is used uninitialized [-Wuninitialized] 165 | places[

[PATCH v3 2/2] drm/omapdrm: Fix console with deferred ops

2024-02-27 Thread Tony Lindgren
Commit 95da53d63dcf ("drm/omapdrm: Use regular fbdev I/O helpers") stopped console from updating for command mode displays because there is no damage handling in fb_sys_write() unlike we had earlier in drm_fb_helper_sys_write(). Let's fix the issue by adding FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS and

[PATCH v3 1/2] drm/omapdrm: Fix console by implementing fb_dirty

2024-02-27 Thread Tony Lindgren
The framebuffer console stopped updating with commit f231af498c29 ("drm/fb-helper: Disconnect damage worker from update logic"). Let's fix the issue by implementing fb_dirty similar to what was done with commit 039a72ce7e57 ("drm/i915/fbdev: Implement fb_dirty for intel custom fb helper"). Fixes:

[PATCH v3 0/2] Fixes for omapdrm console

2024-02-27 Thread Tony Lindgren
Here are two fixes for omapdrm for missing drm_framebuffer_funcs.dirty that needs to be paired with omap_framebuffer_dirty(), and to add FB_GEN_DEFAULT_DEFERRED_DMAMEM_OPS so things behave as earlier with drm_fb_helper_sys_write(). Without these fixes, the console won't update for the command mode

[PATCH v2] drm: tests: Fix invalid printf format specifiers in KUnit tests

2024-02-27 Thread David Gow
The drm_buddy_test's alloc_contiguous test used a u64 for the page size, which was then updated to be an 'unsigned long' to avoid 64-bit multiplication division helpers. However, the variable is logged by some KUNIT_ASSERT_EQ_MSG() using the '%d' or '%llu' format specifiers, the former of which is

Re: [PATCH v2 2/3] drm/panel: panel-edp: Match edp_panels with panel name

2024-02-27 Thread Dmitry Baryshkov
On Wed, 28 Feb 2024 at 03:11, Hsin-Yi Wang wrote: > > It's found that some panels have variants that they share the same panel id > although their EDID and names are different. When matching generic edp > panels, we should first match with both panel id and panel name by checking > if edid contain

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-27 Thread Zack Rusin
On Tue, Feb 27, 2024 at 6:38 AM Thomas Zimmermann wrote: > > Dma-buf locking semantics require the caller of pin and unpin to hold > the buffer's reservation lock. Fix DRM to adhere to the specs. This > enables to fix the locking in DRM's console emulation. Similar changes > for vmap and mmap have

Re: [PATCH 09/13] drm/gem: Acquire reservation lock in drm_gem_{pin/unpin}()

2024-02-27 Thread Zack Rusin
On Tue, Feb 27, 2024 at 6:39 AM Thomas Zimmermann wrote: > > Acquire the buffer object's reservation lock in drm_gem_pin() and > remove locking the drivers' GEM callbacks where necessary. Same for > unpin(). > > DRM drivers and memory managers modified by this patch will now have > correct dma-buf

Re: [PATCH 08/13] drm/qxl: Acquire reservation lock in GEM pin/unpin callbacks

2024-02-27 Thread Zack Rusin
On Tue, Feb 27, 2024 at 6:39 AM Thomas Zimmermann wrote: > > Acquire the reservation lock directly in GEM pin callback. Same for > unpin. Prepares for further changes. > > Dma-buf locking semantics require callers to hold the buffer's > reservation lock when invoking the pin and unpin callbacks. P

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-27 Thread Daniel van Vugt
On 27/2/24 21:47, Hans de Goede wrote: > Hi, > > On 2/27/24 02:06, Daniel van Vugt wrote: >> On 27/2/24 02:23, Hans de Goede wrote: >>> Hi All, >>> >>> On 2/2/24 09:53, Daniel van Vugt wrote: Until now, deferred console takeover only meant defer until there is output. But that risks step

[PATCH] drm/amdgpu: Fix assignment errors in 'si_common_early_init' functions

2024-02-27 Thread Lu Yao
uvd_ctx_rreg/uvd_ctx_wreg correct value requires function pointer. Signed-off-by: Lu Yao --- drivers/gpu/drm/amd/amdgpu/si.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/si.c b/drivers/gpu/drm/amd/amdgpu/si.c index a757526153e5..455d49f7bd9c

[PATCH] drm/imagination: Kconfig: add 'PAGE_SIZE=4K' dependency

2024-02-27 Thread Lu Yao
When 'PAGE_SIZE=64K',the following compilation error occurs: " ../drivers/gpu/drm/imagination/pvr_fw_mips.c: In function ‘pvr_mips_fw_process’: ../drivers/gpu/drm/imagination/pvr_fw_mips.c:140:60: error: array subscript 0 is outside the bounds of an interior zero-length array ‘dma_addr_t[0]’ {a

Re: [PATCH v2 1/3] drm_edid: Support getting EDID through ddc without connector

2024-02-27 Thread Hsin-Yi Wang
On Tue, Feb 27, 2024 at 5:11 PM Hsin-Yi Wang wrote: > > Some panels are interested in the EDID during early probe when connector > is still unknown. > > Add a function drm_get_edid_no_connector() to get edid without connector. > No functional change for existing usage. > > Signed-off-by: Hsin-Yi W

Re: [PATCH 1/2] drm_edid: Add a function to get EDID base block

2024-02-27 Thread Hsin-Yi Wang
On Tue, Feb 27, 2024 at 1:09 AM Jani Nikula wrote: > > On Fri, 23 Feb 2024, Hsin-Yi Wang wrote: > > It's found that some panels have variants that they share the same panel id > > although their EDID and names are different. Besides panel id, now we need > > the hash of entire EDID base block to

[PATCH v2 1/3] drm_edid: Support getting EDID through ddc without connector

2024-02-27 Thread Hsin-Yi Wang
Some panels are interested in the EDID during early probe when connector is still unknown. Add a function drm_get_edid_no_connector() to get edid without connector. No functional change for existing usage. Signed-off-by: Hsin-Yi Wang --- v1->v2: add a function to return the entire edid without u

[PATCH v2 2/3] drm/panel: panel-edp: Match edp_panels with panel name

2024-02-27 Thread Hsin-Yi Wang
It's found that some panels have variants that they share the same panel id although their EDID and names are different. When matching generic edp panels, we should first match with both panel id and panel name by checking if edid contains the name string. If not found, match with panel id only. S

[PATCH v2 0/3] Match panel with id and name

2024-02-27 Thread Hsin-Yi Wang
This series is a follow up for 1a5e81de180e ("Revert "drm/panel-edp: Add auo_b116xa3_mode""). It's found that 2 different AUO panels use the same product id. One of them requires an overridden mode, while the other should use the mode directly from edid. Match the panel for both name and id. If no

[PATCH v2 3/3] drm/panel: panel-edp: Fix AUO 0x405c panel naming and add a variant

2024-02-27 Thread Hsin-Yi Wang
There are 2 different AUO panels using the same panel id. One of the variants requires using overridden modes to resolve glitching issue as described in commit 70e0d5550f5c ("drm/panel-edp: Add auo_b116xa3_mode"). Other variants should use the modes parsed from EDID. Signed-off-by: Hsin-Yi Wang -

[PATCH v2] drm/i915/guc: Use context hints for GT freq

2024-02-27 Thread Vinay Belgaumkar
Allow user to provide a low latency context hint. When set, KMD sends a hint to GuC which results in special handling for this context. SLPC will ramp the GT frequency aggressively every time it switches to this context. The down freq threshold will also be lower so GuC will ramp down the GT freq f

Re: [PATCH 0/9] kunit: Fix printf format specifier issues in KUnit assertions

2024-02-27 Thread Shuah Khan
On 2/21/24 02:27, David Gow wrote: KUnit has several macros which accept a log message, which can contain printf format specifiers. Some of these (the explicit log macros) already use the __printf() gcc attribute to ensure the format specifiers are valid, but those which could fail the test, and

Re: [PATCH] drm/udl: Add ARGB8888 as a format

2024-02-27 Thread Dmitry Baryshkov
On Wed, 28 Feb 2024 at 00:19, Douglas Anderson wrote: > > Even though the UDL driver converts to RGB565 internally (see > pixel32_to_be16() in udl_transfer.c), it advertises XRGB for > compatibility. Let's add ARGB to that list. > > This makes UDL devices work on ChromeOS again after commi

Re: [PATCH 7/9] drm: tests: Fix invalid printf format specifiers in KUnit tests

2024-02-27 Thread Shuah Khan
On 2/21/24 14:29, Justin Stitt wrote: Hi, On Wed, Feb 21, 2024 at 05:27:20PM +0800, David Gow wrote: The drm_buddy_test's alloc_contiguous test used a u64 for the page size, which was then updated to be an 'unsigned long' to avoid 64-bit multiplication division helpers. However, the variable i

Re: [PATCH] Revert "drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"

2024-02-27 Thread Paloma Arellano
On 2/27/2024 2:11 PM, Abhinav Kumar wrote: On 2/27/2024 2:08 PM, Dmitry Baryshkov wrote: This reverts commit e467e0bde881 ("drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"). The commit changed the way how the MSM DP driver communicates HPD-related events to the userspa

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Alexandre Belloni
On 27/02/2024 14:23:29-0700, Shuah Khan wrote: > On 2/27/24 13:32, Alexandre Belloni wrote: > > Hello, > > > > On 21/02/2024 17:27:18+0800, David Gow wrote: > > > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > > > > > This was found by extending KUnit's assertion macros t

Re: [PATCH v7 29/36] drm/vc4: tests: Remove vc4_dummy_plane structure

2024-02-27 Thread Maíra Canal
Hi Maxime, On 2/27/24 10:02, Maxime Ripard wrote: Hi Maíra, Thanks for you reviews! On Mon, Feb 26, 2024 at 09:29:32AM -0300, Maíra Canal wrote: On 2/22/24 15:14, Maxime Ripard wrote: The vc4_dummy_plane structure is an exact equivalent to vc4_plane, so we Maybe I understood incorrectly, b

DisplayPort: handling of HPD events / link training

2024-02-27 Thread Dmitry Baryshkov
Hello, We are currently looking at checking and/or possibly redesigning the way the MSM DRM driver handles the HPD events and link training. After a quick glance at the drivers implementing DP support, I noticed following main approaches: - Perform link training at the atomic_enable time, don't r

Re: [PATCH V2 1/2] drm/bridge: samsung-dsim: Set P divider based on min/max of fin pll

2024-02-27 Thread Adam Ford
On Sun, Feb 11, 2024 at 5:09 PM Adam Ford wrote: > > The P divider should be set based on the min and max values of > the fin pll which may vary between different platforms. > These ranges are defined per platform, but hard-coded values > were used instead which resulted in a smaller range availab

[PATCH] drm/udl: Add ARGB8888 as a format

2024-02-27 Thread Douglas Anderson
Even though the UDL driver converts to RGB565 internally (see pixel32_to_be16() in udl_transfer.c), it advertises XRGB for compatibility. Let's add ARGB to that list. This makes UDL devices work on ChromeOS again after commit c91acda3a380 ("drm/gem: Check for valid formats"). Prior to that

Re: [PATCH] Revert "drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"

2024-02-27 Thread Abhinav Kumar
On 2/27/2024 2:08 PM, Dmitry Baryshkov wrote: This reverts commit e467e0bde881 ("drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"). The commit changed the way how the MSM DP driver communicates HPD-related events to the userspace. The mentioned commit made some of the HPD

[PATCH] Revert "drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"

2024-02-27 Thread Dmitry Baryshkov
This reverts commit e467e0bde881 ("drm/msm/dp: use drm_bridge_hpd_notify() to report HPD status changes"). The commit changed the way how the MSM DP driver communicates HPD-related events to the userspace. The mentioned commit made some of the HPD events being reported earlier. This way userspace

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Shuah Khan
On 2/27/24 13:32, Alexandre Belloni wrote: Hello, On 21/02/2024 17:27:18+0800, David Gow wrote: 'days' is a s64 (from div_s64), and so should use a %lld specifier. This was found by extending KUnit's assertion macros to use gcc's __printf attribute. Fixes: 1d1bb12a8b18 ("rtc: Improve performa

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-27 Thread Alexandre Belloni
Hello, On 21/02/2024 17:27:18+0800, David Gow wrote: > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > This was found by extending KUnit's assertion macros to use gcc's > __printf attribute. > > Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm(). Add >

Re: [PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-27 Thread Sebastian Wick
On Tue, Feb 27, 2024 at 09:35:22PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a new immutable plane property by which a plane can advertise > a handful of recommended plane sizes. This would be mostly exposed > by cursor planes as a slightly more capable replacement for > the DRM_C

[PATCH] drm/i915/ttm: Fix TTM_PL_FLAG_DESIRED

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä inlined from ‘i915_ttm_get_pages’ at ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:847:2: ../drivers/gpu/drm/i915/gem/i915_gem_ttm.c:165:18: warning: ‘places[0].flags’ is used uninitialized [-Wuninitialized] 165 | places[0].flags |= TTM_PL_FLAG_DESIRED; |

Re: [PATCH v2 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-27 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 05:55:07PM +0200, Abel Vesa wrote: > Instead of relying on different compatibles for eDP and DP, use > the is-edp property from DT to figure out the connector type and > then pass on that information to the PHY. > > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Abel Vesa

Re: [PATCH v2 6/9] drm/vkms: Add YUV support

2024-02-27 Thread Arthur Grillo
On 27/02/24 12:02, Louis Chauvet wrote: > Hi Pekka, > > For all the comment related to the conversion part, maybe Arthur have an > opinion on it, I took his patch as a "black box" (I did not want to > break (and debug) it). > > Le 26/02/24 - 14:19, Pekka Paalanen a écrit : >> On Fri, 23 Feb

[linux-next:master] BUILD REGRESSION 22ba90670a51a18c6b36d285fddf92b9887c0bc3

2024-02-27 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 22ba90670a51a18c6b36d285fddf92b9887c0bc3 Add linux-next specific files for 20240227 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202402271629.7zzu8scf-...@intel.com Error

[PATCH v2 2/2] drm/i915: Add SIZE_HINTS property for cursors

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä Advertize more suitable cursor sizes via the new SIZE_HINTS plane property. We can't really enumerate all supported cursor sizes on the platforms where the cursor height can vary freely, so for simplicity we'll just expose all square+POT sizes between each platform's min and

[PATCH v2 1/2] drm: Introduce plane SIZE_HINTS property

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä Add a new immutable plane property by which a plane can advertise a handful of recommended plane sizes. This would be mostly exposed by cursor planes as a slightly more capable replacement for the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare a one size fits all lim

[PATCH v2 0/2] drm: Add plane SIZE_HINTS property

2024-02-27 Thread Ville Syrjala
From: Ville Syrjälä Final version for a new plane SIZE_HINTS property to essentially replace the cursor size caps, based on recent discussion in this gitlab bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7687 As for userspace, so far I only did a quick modetest blob decoder (mainly to ve

[PATCH] drm/amd/display: check dc_link before dereferencing

2024-02-27 Thread Melissa Wen
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:6683 amdgpu_dm_connector_funcs_force() warn: variable dereferenced before check 'dc_link' (see line 6663) Fixes: 967176179215 ("drm/amd/display: fix null-pointer dereference on edid reading") Reported-by: Dan Carpenter Signed-off-by: M

Re: [PATCH] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-02-27 Thread Adrián Larumbe
Hi Boris, On 26.02.2024 09:51, Boris Brezillon wrote: > On Wed, 21 Feb 2024 16:12:32 + > Adrián Larumbe wrote: > > > Debugfs isn't always available in production builds that try to squeeze > > every single byte out of the kernel image, but we still need a way to > > toggle the timestamp and

Re: DRM Migration to Gitlab

2024-02-27 Thread Maxime Ripard
Hi, On Tue, Feb 27, 2024 at 09:16:35AM +0100, Maxime Ripard wrote: > Sima, after becoming aware of the drm-misc transition to Gitlab in the > next couple of weeks, to do the same for DRM today. > > This is now done and all the various bits (nightly.conf, MAINTAINERS, > doc, etc.) should be there.

Re: [PATCH] drm/i915/guc: Correct capture of EIR register on hang

2024-02-27 Thread Teres Alexis, Alan Previn
On Fri, 2024-02-23 at 12:32 -0800, john.c.harri...@intel.com wrote: > From: John Harrison alan:snip > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c > @@ -51,6 +51,7 @@ > { RING_ESR(0),  0,  0, "ESR" }, \ >  

Re: [DO NOT MERGE v6 34/37] sh: Add dtbs target support.

2024-02-27 Thread Geert Uytterhoeven
On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical

Re: [PATCH v3 3/9] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-02-27 Thread Arthur Grillo
On 27/02/24 12:02, Louis Chauvet wrote: > Le 26/02/24 - 10:07, Arthur Grillo a écrit : >> >> >> On 26/02/24 05:46, Louis Chauvet wrote: >>> Add some documentation on pixel conversion functions. >>> Update of outdated comments for pixel_write functions. >>> >>> Signed-off-by: Louis Chauvet >>> -

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-27 Thread Christian König
Am 27.02.24 um 19:14 schrieb Dmitry Osipenko: Hello, Thank you for the patches! On 2/27/24 13:14, Thomas Zimmermann wrote: Dma-buf locking semantics require the caller of pin and unpin to hold the buffer's reservation lock. Fix DRM to adhere to the specs. This enables to fix the locking in DRM

Re: [PATCH] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-02-27 Thread Adrián Larumbe
Hi Steve, On 21.02.2024 16:52, Steven Price wrote: > On 21/02/2024 16:12, Adrián Larumbe wrote: > > Debugfs isn't always available in production builds that try to squeeze > > every single byte out of the kernel image, but we still need a way to > > toggle the timestamp and cycle counter registers

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-27 Thread Dmitry Osipenko
Hello, Thank you for the patches! On 2/27/24 13:14, Thomas Zimmermann wrote: > Dma-buf locking semantics require the caller of pin and unpin to hold > the buffer's reservation lock. Fix DRM to adhere to the specs. This > enables to fix the locking in DRM's console emulation. Similar changes > for

Re: [PATCH v4 6/8] usb: misc: onboard_dev: use device supply names

2024-02-27 Thread Matthias Kaehlcke
On Tue, Feb 20, 2024 at 03:05:50PM +0100, Javier Carrasco wrote: > The current mechanism uses generic names for the power supplies, which > conflicts with proper name definitions in the device bindings. > > Add a per-device property to include real supply names and keep generic > names as a fallba

Re: [PATCH v4 2/8] usb: misc: onboard_dev: add support for non-hub devices

2024-02-27 Thread Matthias Kaehlcke
On Thu, Feb 22, 2024 at 03:42:26PM +0100, Javier Carrasco wrote: > On 21.02.24 20:24, Matthias Kaehlcke wrote: > > On Tue, Feb 20, 2024 at 03:05:46PM +0100, Javier Carrasco wrote: > >> Most of the functionality this driver provides can be used by non-hub > >> devices as well. > >> > >> To account f

Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Fix enable error path

2024-02-27 Thread Luca Ceresoli
Hi Alexander, thanks for your feedback! On Tue, 27 Feb 2024 13:05:46 +0100 Alexander Stein wrote: > Hi Luca, > > Am Donnerstag, 22. Februar 2024, 16:36:37 CET schrieb Luca Ceresoli: > > Hello Alexander, > > > > On Thu, 4 May 2023 08:53:16 +0200 > > Alexander Stein wrote: > > > > > If PLL

Re: [PATCH] net: ethernet: ti: am65-cpsw: Add minimal XDP support

2024-02-27 Thread Simon Horman
On Mon, Feb 26, 2024 at 06:48:25PM +0100, Julien Panis wrote: > Hello Simon, > > Thank you for the review. > > On 2/26/24 18:25, Simon Horman wrote: > > On Fri, Feb 23, 2024 at 12:01:37PM +0100, Julien Panis wrote: > > > This patch adds XDP (eXpress Data Path) support to TI AM65 CPSW > > > Ethern

amdgpu kmemleaks

2024-02-27 Thread Borislav Petkov
Hi folks, anyone interested in a bunch of amdgpu kmemleak reports from latest Linus tree + tip? GPU is: [ 11.317312] [drm] amdgpu kernel modesetting enabled. [ 11.363627] [drm] initializing kernel modesetting (CARRIZO 0x1002:0x9874 0x103C:0x807E 0xC4). [ 11.364077] [drm] register mmio bas

Re: [PATCH] drm/vkms: Add information on how to benchmark

2024-02-27 Thread Arthur Grillo
On 27/02/24 12:02, Louis Chauvet wrote: > Le 27/02/24 - 15:26, Pekka Paalanen a écrit : >> On Tue, 27 Feb 2024 09:29:58 -0300 >> Arthur Grillo wrote: >> >>> On 27/02/24 08:55, Pekka Paalanen wrote: On Tue, 27 Feb 2024 08:44:52 -0300 Arthur Grillo wrote: > On 27/02/24 06:1

Re: [PATCH 1/2] drm_edid: Add a function to get EDID base block

2024-02-27 Thread Doug Anderson
Hi, On Tue, Feb 27, 2024 at 1:09 AM Jani Nikula wrote: > > On Fri, 23 Feb 2024, Hsin-Yi Wang wrote: > > It's found that some panels have variants that they share the same panel id > > although their EDID and names are different. Besides panel id, now we need > > the hash of entire EDID base bloc

Re: [DO NOT MERGE v6 13/37] dt-bindings: clock: sh7750-cpg: Add renesas,sh7750-cpg header.

2024-02-27 Thread Geert Uytterhoeven
Hi Sato-san, Thanks for your patch! On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > SH7750 CPG Clock output define. Please improve the patch description. > Signed-off-by: Yoshinori Sato > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/renesas,sh7750-cpg.yaml > @@ -0,0 +

Re: [DO NOT MERGE v6 15/37] clk: renesas: Add SH7750/7751 CPG Driver

2024-02-27 Thread Geert Uytterhoeven
Hi Sato-san, On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Renesas SH7750 and SH7751 series CPG driver. > This driver supported frequency control and clock gating. > > Signed-off-by: Yoshinori Sato Thanks for your patch! > --- a/drivers/clk/renesas/Kconfig > +++ b/drivers/clk/renesas/

Re: [PATCH] drm/test/shmem: set a DMA mask for the mock device

2024-02-27 Thread Maxime Ripard
Hi, On Mon, Feb 26, 2024 at 04:48:51PM +0100, Marco Pagani wrote: > > On 2024-02-26 12:26, Maxime Ripard wrote: > > Hi, > > > > On Mon, Feb 26, 2024 at 12:00:27PM +0100, Marco Pagani wrote: > >> Set a DMA mask for the mock device to avoid warnings generated in > >> dma_map_sgtable(). > >> > >> R

[PULL] drm-intel-next

2024-02-27 Thread Jani Nikula
Hi Dave & Sima - Final i915 feature pull for v6.9. drm-intel-next-2024-02-27-1: drm/i915 feature pull #2 for v6.9: Features and functionality: - DP tunneling and bandwidth allocation support (Imre) - Add more ADL-N PCI IDs (Gustavo) - Enable fastboot also on older platforms (Ville) - Bigjoiner

Re: [DO NOT MERGE v6 33/37] sh: j2_mimas_v2.dts update

2024-02-27 Thread Geert Uytterhoeven
Hi Sato-san, On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Thanks for your patch! Please enhance the one-line summary, e.g. sh: j2_mimas_v2: Update CPU compatible value For the actual changes: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s,

Re: [DO NOT MERGE v6 28/37] dt-bindings: soc: renesas: sh: Add SH7751 based target

2024-02-27 Thread Geert Uytterhoeven
Hi Sato-san, On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > Signed-off-by: Yoshinori Sato Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/renesas/sh.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 >

RE: Making drm_gpuvm work across gpu devices

2024-02-27 Thread Zeng, Oak
From: Christian König Sent: Tuesday, February 27, 2024 1:54 AM To: Zeng, Oak ; Danilo Krummrich ; Dave Airlie ; Daniel Vetter ; Felix Kuehling ; jgli...@redhat.com Cc: Welty, Brian ; dri-devel@lists.freedesktop.org; intel...@lists.freedesktop.org; Bommu, Krishnaiah ; Ghimiray, Himal Prasad ;

Re: ✗ Fi.CI.IGT: failure for drm/i915: Add Display Port tunnel BW allocation support (rev6)

2024-02-27 Thread Imre Deak
On Tue, Feb 27, 2024 at 02:21:29PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add Display Port tunnel BW allocation support (rev6) > URL : https://patchwork.freedesktop.org/series/129082/ > State : failure Thanks for the reviews,acks, patchset is pushed to drm-intel-ne

Re: [PATCH v2 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-27 Thread Krzysztof Kozlowski
On 22/02/2024 16:55, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and document the is-edp > flag. The controllers are expected to operate in DP mode by default, > and this flag can be used to select eDP mode. > > Signed-off-by: Abel Vesa > --- > Documentation/devicetree/binding

Re: [DO NOT MERGE v6 14/37] clk: Compatible with narrow registers

2024-02-27 Thread Geert Uytterhoeven
Hi Sato-san, On Tue, Jan 9, 2024 at 9:24 AM Yoshinori Sato wrote: > divider and gate only support 32-bit registers. > Older hardware uses narrower registers, so I want to be able to handle > 8-bit and 16-bit wide registers. > > Seven clk_divider flags are used, and if I add flags for 8bit access

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-27 Thread Thomas Zimmermann
Hi Am 27.02.24 um 15:03 schrieb Christian König: Nice, looks totally valid to me. Feel free to add to patch #2, #9, #10, #11 and #12 Reviewed-by: Christian König And Acked-by: Christian König to the rest. Oh, wow. That was quick! Thanks a lot. Best regards Thomas Regards, Christian.

Re: [PATCH 01/18] ASoC: dt-bindings: mediatek,mt8365-afe: Add audio afe document

2024-02-27 Thread Alexandre Mergnat
On 27/02/2024 10:01, Krzysztof Kozlowski wrote: On 26/02/2024 15:01, Alexandre Mergnat wrote: Add MT8365 audio front-end bindings Signed-off-by: Alexandre Mergnat --- .../bindings/sound/mediatek,mt8365-afe.yaml| 164 + 1 file changed, 164 insertions(+) diff -

Re: [PATCH 4/6] arm64: dts: renesas: r8a77951: Enable GPU

2024-02-27 Thread Adam Ford
On Tue, Feb 27, 2024 at 2:11 AM Geert Uytterhoeven wrote: > > Hi Adam, > > Thanks for your patch! > > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford wrote: > > The GPU on the R-Car H3 is a Rogue GX6650 which uses firmware > > rogue_4.46.6.61_v1.fw available from Imagination. > > s/61/62/ > > > > > Whe

Re: [PATCH 00/18] Add audio support for the MediaTek Genio 350-evk board

2024-02-27 Thread Mark Brown
On Mon, Feb 26, 2024 at 03:01:38PM +0100, Alexandre Mergnat wrote: > This serie aim to add the following audio support for the Genio 350-evk: > - Playback > - 2ch Headset Jack (Earphone) > - 1ch Line-out Jack (Speaker) > - 8ch HDMI Tx > - Capture > - 1ch DMIC (On-board Digital Microphone) >

Re: [PATCH v2 6/9] drm/vkms: Add YUV support

2024-02-27 Thread Louis Chauvet
Hi Pekka, For all the comment related to the conversion part, maybe Arthur have an opinion on it, I took his patch as a "black box" (I did not want to break (and debug) it). Le 26/02/24 - 14:19, Pekka Paalanen a écrit : > On Fri, 23 Feb 2024 12:37:26 +0100 > Louis Chauvet wrote: > > > From: A

Re: [PATCH v3 4/9] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-02-27 Thread Louis Chauvet
[...] > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c > > b/drivers/gpu/drm/vkms/vkms_plane.c > > index d5203f531d96..f68b1b03d632 100644 > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > @@ -106,6 +106,13 @@ static void vkms_plane_atomic_update(struct

Re: [PATCH v3 5/9] drm/vkms: Re-introduce line-per-line composition algorithm

2024-02-27 Thread Louis Chauvet
Le 26/02/24 - 11:14, Arthur Grillo a écrit : > > > On 26/02/24 05:46, Louis Chauvet wrote: > > Re-introduce a line-by-line composition algorithm for each pixel format. > > This allows more performance by not requiring an indirection per pixel > > read. This patch is focused on readability of the

Re: [PATCH v2 9/9] drm/vkms: Create KUnit tests for YUV conversions

2024-02-27 Thread Louis Chauvet
Le 26/02/24 - 13:39, Arthur Grillo a écrit : > > > On 23/02/24 08:37, Louis Chauvet wrote: > > From: Arthur Grillo > > > > Create KUnit tests to test the conversion between YUV and RGB. Test each > > conversion and range combination with some common colors. > > > > Signed-off-by: Arthur Grillo

Re: [PATCH v2 4/9] drm/vkms: Add typedef and documentation for pixel_read and pixel_write functions

2024-02-27 Thread Louis Chauvet
Le 26/02/24 - 13:36, Pekka Paalanen a écrit : > On Fri, 23 Feb 2024 12:37:24 +0100 > Louis Chauvet wrote: > > > Introduce two typedefs: pixel_read_t and pixel_write_t. It allows the > > compiler to check if the passed functions take the correct arguments. > > Such typedefs will help ensuring cons

Re: [PATCH] drm/vkms: Add information on how to benchmark

2024-02-27 Thread Louis Chauvet
Le 27/02/24 - 15:26, Pekka Paalanen a écrit : > On Tue, 27 Feb 2024 09:29:58 -0300 > Arthur Grillo wrote: > > > On 27/02/24 08:55, Pekka Paalanen wrote: > > > On Tue, 27 Feb 2024 08:44:52 -0300 > > > Arthur Grillo wrote: > > > > > >> On 27/02/24 06:19, Pekka Paalanen wrote: > > >>> On Mon,

Re: [PATCH v3 3/9] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-02-27 Thread Louis Chauvet
Le 26/02/24 - 10:07, Arthur Grillo a écrit : > > > On 26/02/24 05:46, Louis Chauvet wrote: > > Add some documentation on pixel conversion functions. > > Update of outdated comments for pixel_write functions. > > > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/vkms/vkms_composer.c

Re: [PATCH v2 3/9] drm/vkms: write/update the documentation for pixel conversion and pixel write functions

2024-02-27 Thread Louis Chauvet
[...] > > diff --git a/drivers/gpu/drm/vkms/vkms_formats.c > > b/drivers/gpu/drm/vkms/vkms_formats.c > > index 172830a3936a..cb7a49b7c8e7 100644 > > --- a/drivers/gpu/drm/vkms/vkms_formats.c > > +++ b/drivers/gpu/drm/vkms/vkms_formats.c > > @@ -9,6 +9,17 @@ > > > > #include "vkms_formats.h" >

Re: [PATCH v2 7/9] drm/vkms: Add range and encoding properties to pixel_read function

2024-02-27 Thread Louis Chauvet
(same as for PATCHv2 6/9, I took the patch from Arthur with no modifications) Le 26/02/24 - 14:23, Pekka Paalanen a écrit : > On Fri, 23 Feb 2024 12:37:27 +0100 > Louis Chauvet wrote: > > > From: Arthur Grillo > > > > Create range and encoding properties. This should be noop, as none of > > t

Re: [PATCH v2 5/9] drm/vkms: Re-introduce line-per-line composition algorithm

2024-02-27 Thread Louis Chauvet
[...] > > -static void pre_mul_alpha_blend(struct vkms_frame_info *frame_info, > > - struct line_buffer *stage_buffer, > > - struct line_buffer *output_buffer) > > +static void pre_mul_alpha_blend( > > + struct line_buffer *stage_buffer, > > +

Re: [PATCH RFC 01/12] kbuild: create destination directory for _shipped handling

2024-02-27 Thread Masahiro Yamada
On Mon, Feb 26, 2024 at 8:01 PM Dmitry Baryshkov wrote: > > On Mon, 26 Feb 2024 at 08:33, Masahiro Yamada wrote: > > > > On Mon, Feb 26, 2024 at 11:11 AM Dmitry Baryshkov > > wrote: > > > > > > The driver might decide to put the _shipped files to the subdir. > > > > > > > > Please stop this sent

Re: [PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP

2024-02-27 Thread Rob Herring
On Mon, Feb 26, 2024 at 11:59:42AM +0100, Paweł Anikiel wrote: > On Mon, Feb 26, 2024 at 10:13 AM Krzysztof Kozlowski > wrote: > > > > On 21/02/2024 17:02, Paweł Anikiel wrote: > > > The Intel Displayport RX IP is a part of the DisplayPort Intel FPGA IP > > > Core. It implements a DisplayPort 1.4

Re: [PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP

2024-02-27 Thread Rob Herring
On Tue, Feb 27, 2024 at 02:11:27PM +0100, Paweł Anikiel wrote: > On Mon, Feb 26, 2024 at 6:29 PM Krzysztof Kozlowski > wrote: > > > > On 26/02/2024 13:43, Paweł Anikiel wrote: > > > + intel,max-stream-count: > > > +$ref: /schemas/types.yaml#/definitions/uint32 > > > +descripti

[PATCH 6.1 085/195] drm/ttm: Fix an invalid freeing on already freed page in error path

2024-02-27 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Hellström commit 40510a941d27d405a82dc3320823d875f94625df upstream. If caching mode change fails due to, for example, OOM we free the allocated pages in a two-step process. First the pag

Re: [RFC PATCH v4 06/42] drm/vkms: Add kunit tests for VKMS LUT handling

2024-02-27 Thread Harry Wentland
On 2024-02-27 07:14, Arthur Grillo wrote: > > > On 26/02/24 18:10, Harry Wentland wrote: >> Debugging LUT math is much easier when we can unit test >> it. Add kunit functionality to VKMS and add tests for >> - get_lut_index >> - lerp_u16 >> >> v4: >> - Test the critical points of the lerp f

[PATCH 5.15 078/245] drm/ttm: Fix an invalid freeing on already freed page in error path

2024-02-27 Thread Greg Kroah-Hartman
5.15-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Hellström commit 40510a941d27d405a82dc3320823d875f94625df upstream. If caching mode change fails due to, for example, OOM we free the allocated pages in a two-step process. First the pa

Re: [PATCH 00/13] drm: Fix reservation locking for pin/unpin and console

2024-02-27 Thread Christian König
Nice, looks totally valid to me. Feel free to add to patch #2, #9, #10, #11 and #12 Reviewed-by: Christian König And Acked-by: Christian König to the rest. Regards, Christian. Am 27.02.24 um 11:14 schrieb Thomas Zimmermann: Dma-buf locking semantics require the caller of pin and unpin to

Re: [PATCH v7 19/36] drm/connector: hdmi: Compute bpc and format automatically

2024-02-27 Thread Maxime Ripard
Hi Alex, On Sun, Feb 25, 2024 at 02:56:02PM +0100, Alex Bee wrote: > Am 22.02.24 um 19:14 schrieb Maxime Ripard: > > Now that we have all the infrastructure needed, we can add some code > > that will, for a given connector state and mode, compute the best output > > format and bpc. > > > > The al

Re: [RFC PATCH v4 00/42] Color Pipeline API w/ VKMS

2024-02-27 Thread Harry Wentland
On 2024-02-27 05:26, Joshua Ashton wrote: > > > On 2/26/24 21:10, Harry Wentland wrote: >> This is an RFC set for a color pipeline API, along with a sample >> implementation in VKMS. All the key API bits are here. VKMS now >> supports two named transfer function colorops and two matrix >> colo

[PATCH 6.6 140/299] drm/ttm: Fix an invalid freeing on already freed page in error path

2024-02-27 Thread Greg Kroah-Hartman
6.6-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Hellström commit 40510a941d27d405a82dc3320823d875f94625df upstream. If caching mode change fails due to, for example, OOM we free the allocated pages in a two-step process. First the pag

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-27 Thread Hans de Goede
Hi, On 2/27/24 02:06, Daniel van Vugt wrote: > On 27/2/24 02:23, Hans de Goede wrote: >> Hi All, >> >> On 2/2/24 09:53, Daniel van Vugt wrote: >>> Until now, deferred console takeover only meant defer until there is >>> output. But that risks stepping on the toes of userspace splash screens, >>> a

[PATCH 6.7 148/334] drm/ttm: Fix an invalid freeing on already freed page in error path

2024-02-27 Thread Greg Kroah-Hartman
6.7-stable review patch. If anyone has any objections, please let me know. -- From: Thomas Hellström commit 40510a941d27d405a82dc3320823d875f94625df upstream. If caching mode change fails due to, for example, OOM we free the allocated pages in a two-step process. First the pag

drm/msm: DisplayPort hard-reset on hotplug regression in 6.8-rc1

2024-02-27 Thread Johan Hovold
Hi, Since 6.8-rc1 I have seen (and received reports) of hard resets of the Lenovo ThinkPad X13s after connecting and disconnecting an external display. I have triggered this on a simple disconnect while in a VT console, but also when stopping Xorg after having repeatedly connected and disconnecte

  1   2   >