Re: [PATCH v2 2/3] Subject: [PATCH] drm/mediatek/dp: Add HDCP2.x feature for DisplayPort

2024-02-21 Thread 胡俊光

Re: [PATCH v2 2/3] Subject: [PATCH] drm/mediatek/dp: Add HDCP2.x feature for DisplayPort

2024-02-21 Thread 胡俊光

Re: [PATCH] drm/ttm: Fix an invalid freeing on already freed page in error path

2024-02-21 Thread Thomas Hellström
On Wed, 2024-02-21 at 11:26 +0100, Christian König wrote: > Am 21.02.24 um 08:33 schrieb Thomas Hellström: > > If caching mode change fails due to, for example, OOM we > > free the allocated pages in a two-step process. First the pages > > for which the caching change has already succeeded. Secondl

Re: [PATCH 2/9] lib/cmdline: Fix an invalid format specifier in an assertion msg

2024-02-21 Thread David Gow
On Thu, 22 Feb 2024 at 04:10, 'Justin Stitt' via KUnit Development wrote: > > Hi, > > On Wed, Feb 21, 2024 at 05:27:15PM +0800, David Gow wrote: > > The correct format specifier for p - n (both p and n are pointers) is > > %td, as the type should be ptrdiff_t. > > I think %tu is better. d specifie

Re: [PATCH 8/9] drm/xe/tests: Fix printf format specifiers in xe_migrate test

2024-02-21 Thread Linus Torvalds
On Wed, 21 Feb 2024 at 21:05, Lucas De Marchi wrote: > > this has a potential to cause conflicts with upcoming work, so I think > it's better to apply this through drm-xe-next. Let me know if you agree. I disagree. Violently. For this to be fixed, we need to have the printf format checking enabl

Re: [PATCH 8/9] drm/xe/tests: Fix printf format specifiers in xe_migrate test

2024-02-21 Thread Lucas De Marchi
On Wed, Feb 21, 2024 at 05:27:21PM +0800, David Gow wrote: KUNIT_FAIL() is used to fail the xe_migrate test when an error occurs. However, there's a mismatch in the format specifier: '%li' is used to log 'err', which is an 'int'. Use '%i' instead of '%li', and for the case where we're printing a

Re: [PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 05:47, Bjorn Andersson wrote: > > On Thu, Feb 22, 2024 at 01:38:45AM +0200, Dmitry Baryshkov wrote: > > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > > wrote: > > > > > > When upstreamed the SC7280 DP controllers where described as one being > > > DP and one eDP, but the

Re: [PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:50:12AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > With the ADSP remoteproc loaded pmic_glink can be introduced and wired > > up to provide role and orientation switching signals. > > > > Signed-off-by: Bjorn Andersso

Re: [PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Bjorn Andersson
On Thu, Feb 22, 2024 at 01:38:45AM +0200, Dmitry Baryshkov wrote: > On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson > wrote: > > > > When upstreamed the SC7280 DP controllers where described as one being > > DP and one eDP, but they can infact both be DP or eDP. > > > > Extend the list of DP contro

Re: [PATCH RFC 3/3] drm/msm/dp: Add support for the X1E80100

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:33AM +0200, Abel Vesa wrote: > Add the X1E80100 DP descs and compatible. This platform will be using > a single compatible for both eDP and DP mode. The actual mode will > be set in devicetree via is-edp flag. > > Signed-off-by: Abel Vesa > --- > drivers/gpu/drm/msm

Re: [PATCH RFC 1/3] dt-bindings: display: msm: dp-controller: document X1E80100 compatible

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:31AM +0200, Abel Vesa wrote: > Add the X1E80100 to the list of compatibles and docoment the is-edp s/docoment/document/ > flag. This new flag will be used from now on to dictate the mode from s/from now on// Perhaps cleaner to spell out that the controllers are exp

Re: [PATCH RFC 2/3] drm/msm/dp: Add support for setting the eDP mode from devicetree

2024-02-21 Thread Bjorn Andersson
On Wed, Feb 21, 2024 at 12:50:32AM +0200, Abel Vesa wrote: > diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h > b/drivers/gpu/drm/msm/dp/dp_ctrl.h > index fa014cee7e21..a10d1b19d172 100644 > --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h > +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h > @@ -32,6 +32,7 @@ struct dp_

Re: [PATCH] drm: ci: uprev IGT

2024-02-21 Thread Dmitry Baryshkov
On Tue, 20 Feb 2024 at 16:31, Helen Koike wrote: > > > > On 20/02/2024 09:17, Dmitry Baryshkov wrote: > > Bump IGT revision to pick up Rob Clark's fixes for the msm driver: > > > > - msm_submit@invalid-duplicate-bo-submit,Fail > > > > Signed-off-by: Dmitry Baryshkov > > Do you have a gitlab pipel

Re: [PATCH 6/6] phy: qcom-qmp-combo: fix type-c switch registration

2024-02-21 Thread Bjorn Andersson
On Sat, Feb 17, 2024 at 04:02:28PM +0100, Johan Hovold wrote: > Due to a long-standing issue in driver core, drivers may not probe defer > after having registered child devices to avoid triggering a probe > deferral loop (see fbc35b45f9f6 ("Add documentation on meaning of > -EPROBE_DEFER")). > > M

Re: [PATCH 5/6] phy: qcom-qmp-combo: fix drm bridge registration

2024-02-21 Thread Bjorn Andersson
On Sat, Feb 17, 2024 at 04:02:27PM +0100, Johan Hovold wrote: > Due to a long-standing issue in driver core, drivers may not probe defer > after having registered child devices to avoid triggering a probe > deferral loop (see fbc35b45f9f6 ("Add documentation on meaning of > -EPROBE_DEFER")). > > T

Re: [PATCH 4/6] soc: qcom: pmic_glink: Fix boot when QRTR=m

2024-02-21 Thread Bjorn Andersson
On Sat, Feb 17, 2024 at 04:02:26PM +0100, Johan Hovold wrote: > From: Rob Clark > > We need to bail out before adding/removing devices if we are going to > -EPROBE_DEFER. Otherwise boot can get stuck in a probe deferral loop due > to a long-standing issue in driver core (see fbc35b45f9f6 ("Add >

Re: [PATCH 3/6] soc: qcom: pmic_glink_altmode: fix drm bridge use-after-free

2024-02-21 Thread Bjorn Andersson
On Sat, Feb 17, 2024 at 04:02:25PM +0100, Johan Hovold wrote: > A recent DRM series purporting to simplify support for "transparent > bridges" and handling of probe deferrals ironically exposed a > use-after-free issue on pmic_glink_altmode probe deferral. > > This has manifested itself as the dis

Re: [PATCH 2/6] drm/bridge: aux-hpd: separate allocation and registration

2024-02-21 Thread Bjorn Andersson
On Sat, Feb 17, 2024 at 04:02:24PM +0100, Johan Hovold wrote: > diff --git a/drivers/gpu/drm/bridge/aux-hpd-bridge.c > b/drivers/gpu/drm/bridge/aux-hpd-bridge.c [..] > +/** > + * devm_drm_dp_hpd_bridge_add - register a HDP DisplayPort bridge kernel-doc wants () after function names. > + * @dev:

linux-next: build failure after merge of the drm-misc tree

2024-02-21 Thread Stephen Rothwell
7;rzg2l_du_vsp_init' with type 'int(struct rzg2l_du_vsp *, struct device_node *, unsigned int)' 66 | static inline int rzg2l_du_vsp_init(struct rzg2l_du_vsp *vsp, struct device_node *np, | ^ Caused by commit 768e9e61b3b9 ("drm: rene

Re: [PATCH 1/6] drm/bridge: aux-hpd: fix OF node leaks

2024-02-21 Thread Bjorn Andersson
On Sat, Feb 17, 2024 at 04:02:23PM +0100, Johan Hovold wrote: > The two device node references taken during allocation need to be > dropped when the auxiliary device is freed. > > Fixes: 6914968a0b52 ("drm/bridge: properly refcount DT nodes in aux bridge > drivers") > Cc: Dmitry Baryshkov > Cc:

[PATCH v2] drivers/i915/intel_bios: Fix parsing backlight BDB data

2024-02-21 Thread Karthikeyan Ramasubramanian
Starting BDB version 239, hdr_dpcd_refresh_timeout is introduced to backlight BDB data. Commit 700034566d68 ("drm/i915/bios: Define more BDB contents") updated the backlight BDB data accordingly. This broke the parsing of backlight BDB data in VBT for versions 236 - 238 (both inclusive) and hence t

[PATCH] gpu: host1x: Skip reset assert on Tegra186

2024-02-21 Thread Mikko Perttunen
From: Mikko Perttunen On Tegra186, secure world applications may need to access host1x during suspend/resume, and rely on the kernel to keep Host1x out of reset during the suspend cycle. As such, as a quirk, skip asserting Host1x's reset on Tegra186. We don't need to keep the clocks enabled, as

Re: [PATCH v2 1/3] drm/syncobj: call drm_syncobj_fence_add_wait when WAIT_AVAILABLE flag is set

2024-02-21 Thread Dave Airlie
Can someone pick these up into misc? Dave. On Thu, 22 Feb 2024 at 04:48, Erik Kurzinger wrote: > > It looks these these patches have still not been merged after one month, is > there anything more that needs to be done for this to happen? > > On 1/25/24 10:12, Daniel Vetter wrote: > > On Fri, J

Re: [PATCH 7/9] arm64: dts: qcom: qcs6490-rb3gen2: Introduce USB redriver

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > The RB3gen2 has a USB redriver on APPS_I2C, enable the bus and introduce > the redriver. The plumbing with other components is kept separate for > clarity. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2

Re: [PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > With the ADSP remoteproc loaded pmic_glink can be introduced and wired > up to provide role and orientation switching signals. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 48 >

Re: [PATCH 4/9] arm64: dts: qcom: qcs6490-rb3gen2: Add DP output

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > The RB3Gen2 board comes with a mini DP connector, describe this, enable > MDSS, DP controller and the PHY that drives this. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 23 ++

Re: [PATCH 9/9] arm64: defconfig: Enable sc7280 display and gpu clock controllers

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > Enable the SC7280 display and gpu clock controllers to enable display > support on the QCS6490 RB3gen2. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Dmitry

Re: [PATCH 2/9] arm64: dts: qcom: sc7280: Make eDP/DP controller default DP

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > The newly introduced mechanism for selecting eDP mode allow us to make a > DisplayPort controller operate in eDP mode, but not the other way > around. The qcom,sc7280-edp compatible is obviously tied to eDP, so this > would not allow us to s

Re: [PATCH 5/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable adsp and cdsp

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > Define firmware paths and enable the ADSP and CDSP remoteprocs. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dt

Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > The max frequency listed in the DPU opp-table is 506MHz, this is not > sufficient to drive a 4k@60 display, resulting in constant underrun. > > Add the missing MDP_CLK turbo frequency of 608MHz to the opp-table to > fix this. I think we mig

Re: [PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Dmitry Baryshkov
On Thu, 22 Feb 2024 at 01:19, Bjorn Andersson wrote: > > When upstreamed the SC7280 DP controllers where described as one being > DP and one eDP, but they can infact both be DP or eDP. > > Extend the list of DP controllers to cover both instances, and rely on > the newly introduced mechanism for s

[PATCH 4/9] arm64: dts: qcom: qcs6490-rb3gen2: Add DP output

2024-02-21 Thread Bjorn Andersson
The RB3Gen2 board comes with a mini DP connector, describe this, enable MDSS, DP controller and the PHY that drives this. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot/d

[PATCH 9/9] arm64: defconfig: Enable sc7280 display and gpu clock controllers

2024-02-21 Thread Bjorn Andersson
Enable the SC7280 display and gpu clock controllers to enable display support on the QCS6490 RB3gen2. Signed-off-by: Bjorn Andersson --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index b8adb28185

[PATCH 1/9] drm/msm/dp: Add DP support to combo instance in SC7280

2024-02-21 Thread Bjorn Andersson
When upstreamed the SC7280 DP controllers where described as one being DP and one eDP, but they can infact both be DP or eDP. Extend the list of DP controllers to cover both instances, and rely on the newly introduced mechanism for selecting which mode they should operate in. Move qcom,sc7280-edp

[PATCH 5/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable adsp and cdsp

2024-02-21 Thread Bjorn Andersson
Define firmware paths and enable the ADSP and CDSP remoteprocs. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2

[PATCH 8/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB Type-C display

2024-02-21 Thread Bjorn Andersson
With MDSS, pmic_glink, and the redriver in place, wire up the various components to enable USB Type-C display on the RB3gen2. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 63 +++- 1 file changed, 61 insertions(+), 2 deletions(-) diff

[PATCH 2/9] arm64: dts: qcom: sc7280: Make eDP/DP controller default DP

2024-02-21 Thread Bjorn Andersson
The newly introduced mechanism for selecting eDP mode allow us to make a DisplayPort controller operate in eDP mode, but not the other way around. The qcom,sc7280-edp compatible is obviously tied to eDP, so this would not allow us to select DisplayPort-mode. Switch the compatible of the mdss_edp i

[PATCH 7/9] arm64: dts: qcom: qcs6490-rb3gen2: Introduce USB redriver

2024-02-21 Thread Bjorn Andersson
The RB3gen2 has a USB redriver on APPS_I2C, enable the bus and introduce the redriver. The plumbing with other components is kept separate for clarity. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 14 ++ 1 file changed, 14 insertions(+) diff --gi

[PATCH 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable USB role switching

2024-02-21 Thread Bjorn Andersson
With the ADSP remoteproc loaded pmic_glink can be introduced and wired up to provide role and orientation switching signals. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --

[PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-21 Thread Bjorn Andersson
The max frequency listed in the DPU opp-table is 506MHz, this is not sufficient to drive a 4k@60 display, resulting in constant underrun. Add the missing MDP_CLK turbo frequency of 608MHz to the opp-table to fix this. Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 +

[PATCH 0/9] arm64: dts: qcom: qcs6490-rb3gen2: Enable two displays

2024-02-21 Thread Bjorn Andersson
RB3Gen2 is capable of producing DisplayPort output on a dedicated mini-DP connector and USB Type-C. Utilize Abel's work for DP vs eDP selection to allow configuring both controllers in DP-mode, then enable the two output paths. Tested by driving fbcon to 4k@60 + 4k@30 concurrently. Depends on h

Re: [PATCH] drm/amd/display: Use kcalloc() instead of kzalloc()

2024-02-21 Thread Rodrigo Siqueira Jordao
On 1/28/24 02:04, Lenko Donchev wrote: We are trying to get rid of all multiplications from allocation functions to prevent integer overflows. Here the multiplication is obviously safe, but using kcalloc() is more appropriate and improves readability. This patch has no effect on runtime behavi

Re: Future handling of complex RGB devices on Linux v2

2024-02-21 Thread Pavel Machek
Hi! > so after more feedback from the OpenRGB maintainers I came up with an even > more generic proposal: > https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916#note_1753072869 > >evaluate-set-command ioctl taking: > >{ > >    enum command                /* one of supported_commands */ > >   

Re: [PATCH] phy: constify of_phandle_args in xlate

2024-02-21 Thread Florian Fainelli
On 2/17/24 01:39, Krzysztof Kozlowski wrote: The xlate callbacks are supposed to translate of_phandle_args to proper provider without modifying the of_phandle_args. Make the argument pointer to const for code safety and readability. Signed-off-by: Krzysztof Kozlowski Acked-by: Florian Fainel

Re: [PATCH] phy: constify of_phandle_args in xlate

2024-02-21 Thread Linus Walleij
On Sat, Feb 17, 2024 at 10:39 AM Krzysztof Kozlowski wrote: > The xlate callbacks are supposed to translate of_phandle_args to proper > provider without modifying the of_phandle_args. Make the argument > pointer to const for code safety and readability. > > Signed-off-by: Krzysztof Kozlowski (.

Re: [PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-21 Thread Stephen Rothwell
Hi Lucas, On Wed, 21 Feb 2024 13:45:35 -0600 Lucas De Marchi wrote: > > I don't think it's needed since drm-xe-next covers what is in > drm-xe-fixes. Please add other maintainers and mailing list: > > M: Oded Gabbay > M: Thomas Hellström > L: intel...@lists.freedesktop.org Add

Re: Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-21 Thread Lucas De Marchi
On Wed, Feb 21, 2024 at 11:04:22PM +0200, Andy Shevchenko wrote: On Wed, Feb 21, 2024 at 10:30:02PM +0200, Dmitry Baryshkov wrote: On Thu, 8 Feb 2024 at 09:45, Lucas De Marchi wrote: ... > +#define BITS_PER_TYPE(type)(sizeof(type) * BITS_PER_BYTE) Can sizeof() be used in assembly? ..

Re: [PATCH v4 6/8] usb: misc: onboard_dev: use device supply names

2024-02-21 Thread Matthias Kaehlcke
On Wed, Feb 21, 2024 at 10:33:53PM +0100, Javier Carrasco wrote: > On 21.02.24 22:18, Matthias Kaehlcke wrote: > +/* > + * Fallback supply names for backwards compatibility. If the device > requires > + * more than the currently supported supplies, add a new one here, and > >>

Re: [PATCH v4 6/8] usb: misc: onboard_dev: use device supply names

2024-02-21 Thread Javier Carrasco
On 21.02.24 22:18, Matthias Kaehlcke wrote: +/* + * Fallback supply names for backwards compatibility. If the device requires + * more than the currently supported supplies, add a new one here, and if + * possible, the real name supplies to the device-specific data. +

Re: [PATCH 7/9] drm: tests: Fix invalid printf format specifiers in KUnit tests

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:20PM +0800, David Gow wrote: > The drm_buddy_test's alloc_contiguous test used a u64 for the page size, > which was then updated to be an 'unsigned long' to avoid 64-bit > multiplication division helpers. > > However, the variable is logged by some KUNIT_ASSERT_EQ

Re: [PATCH] drm/i915/guc: Add Compute context hint

2024-02-21 Thread Rodrigo Vivi
On Wed, Feb 21, 2024 at 09:42:34AM +, Tvrtko Ursulin wrote: > > On 21/02/2024 00:14, Vinay Belgaumkar wrote: > > Allow user to provide a context hint. When this is set, KMD will > > send a hint to GuC which results in special handling for this > > context. SLPC will ramp the GT frequency aggre

Re: [PATCH 6/9] net: test: Fix printf format specifier in skb_segment kunit test

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:19PM +0800, David Gow wrote: > KUNIT_FAIL() accepts a printf-style format string, but previously did > not let gcc validate it with the __printf() attribute. The use of %lld > for the result of PTR_ERR() is not correct. > > Instead, use %pe and pass the actual err

Re: [PATCH v4 6/8] usb: misc: onboard_dev: use device supply names

2024-02-21 Thread Matthias Kaehlcke
Hi Javier, On Wed, Feb 21, 2024 at 09:40:38PM +0100, Javier Carrasco wrote: > On 21.02.24 21:25, Matthias Kaehlcke wrote: > > On Tue, Feb 20, 2024 at 03:05:50PM +0100, Javier Carrasco wrote: > >> The current mechanism uses generic names for the power supplies, which > >> conflicts with proper name

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-21 Thread Andy Shevchenko
On Wed, Feb 21, 2024 at 11:06:10PM +0200, Andy Shevchenko wrote: > On Wed, Feb 21, 2024 at 10:37:30PM +0200, Dmitry Baryshkov wrote: > > On Wed, 21 Feb 2024 at 22:30, Dmitry Baryshkov > > wrote: ... > > Excuse me, it seems a c&p from gitlab didn't work as expected. > > No problem, it's clear th

Re: [PATCH 5/9] rtc: test: Fix invalid format specifier.

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:18PM +0800, David Gow wrote: > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > This was found by extending KUnit's assertion macros to use gcc's > __printf attribute. > > Fixes: 1d1bb12a8b18 ("rtc: Improve performance of rtc_time64_to_tm().

Re: [PATCH 4/9] time: test: Fix incorrect format specifier

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:17PM +0800, David Gow wrote: > 'days' is a s64 (from div_s64), and so should use a %lld specifier. > > This was found by extending KUnit's assertion macros to use gcc's > __printf attribute. > > Fixes: 276010551664 ("time: Improve performance of time64_to_tm()") >

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-21 Thread Andy Shevchenko
On Wed, Feb 21, 2024 at 10:37:30PM +0200, Dmitry Baryshkov wrote: > On Wed, 21 Feb 2024 at 22:30, Dmitry Baryshkov > wrote: ... > Excuse me, it seems a c&p from gitlab didn't work as expected. No problem, it's clear that the patch has not been properly tested and obviously wrong. Has to be drop

Re: [PATCH 3/9] lib: memcpy_kunit: Fix an invalid format specifier in an assertion msg

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:16PM +0800, David Gow wrote: > The 'i' passed as an assertion message is a size_t, so should use '%zu', > not '%d'. > > This was found by annotating the _MSG() variants of KUnit's assertions > to let gcc validate the format strings. > > Fixes: bb95ebbe89a7 ("lib:

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-21 Thread Andy Shevchenko
On Wed, Feb 21, 2024 at 10:30:02PM +0200, Dmitry Baryshkov wrote: > On Thu, 8 Feb 2024 at 09:45, Lucas De Marchi wrote: ... > > +#define BITS_PER_TYPE(type)(sizeof(type) * BITS_PER_BYTE) Can sizeof() be used in assembly? ... > > -#define __GENMASK(h, l) \ > > - (((~UL(0)) - (UL(1) <

Re: [PATCH v2 2/2] drm/i915/gt: Enable only one CCS for compute workload

2024-02-21 Thread Matt Roper
On Wed, Feb 21, 2024 at 01:12:18AM +0100, Andi Shyti wrote: > Hi Matt, > > thanks a lot for looking into this. > > On Tue, Feb 20, 2024 at 03:39:18PM -0800, Matt Roper wrote: > > On Tue, Feb 20, 2024 at 03:35:26PM +0100, Andi Shyti wrote: > > [...] > > > > diff --git a/drivers/gpu/drm/i915/gt/i

Re: [PATCH v4 6/8] usb: misc: onboard_dev: use device supply names

2024-02-21 Thread Javier Carrasco
On 21.02.24 21:25, Matthias Kaehlcke wrote: > On Tue, Feb 20, 2024 at 03:05:50PM +0100, Javier Carrasco wrote: >> The current mechanism uses generic names for the power supplies, which >> conflicts with proper name definitions in the device bindings. >> >> Add a per-device property to include real

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-21 Thread Dmitry Baryshkov
On Wed, 21 Feb 2024 at 22:30, Dmitry Baryshkov wrote: > > On Thu, 8 Feb 2024 at 09:45, Lucas De Marchi wrote: > > > > From: Yury Norov > > > > Generalize __GENMASK() to support different types, and implement > > fixed-types versions of GENMASK() based on it. The fixed-type version > > allows mor

Re: [PATCH] drm/amd/display: Add prefix to functions inside dnc10_cm_common.h

2024-02-21 Thread Alex Deucher
On Wed, Feb 21, 2024 at 2:31 PM Joao Paulo Pereira da Silva wrote: > > While debugging with ftrace, it's useful to create filters to search > within the codebase. However, since some function names lack prefixes, > creating a good filter may become more difficult. > > Because of this, add prefix t

Re: [PATCH 0/3] drm/amdgpu: Use KMEM_CACHE instead of kmem_cache_create

2024-02-21 Thread Alex Deucher
Applied. Thanks! On Wed, Feb 21, 2024 at 6:08 AM Christian König wrote: > > Am 21.02.24 um 10:59 schrieb Kunwu Chan: > > For where the cache name and the structure name match. > > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create > > to simplify the creation of SLAB caches. > >

Re: [PATCH v3 1/3] bits: introduce fixed-type genmasks

2024-02-21 Thread Dmitry Baryshkov
On Thu, 8 Feb 2024 at 09:45, Lucas De Marchi wrote: > > From: Yury Norov > > Generalize __GENMASK() to support different types, and implement > fixed-types versions of GENMASK() based on it. The fixed-type version > allows more strict checks to the min/max values accepted, which is > useful for d

Re: [PATCH 1/9] kunit: test: Log the correct filter string in executor_test

2024-02-21 Thread Daniel Latypov
On Wed, Feb 21, 2024 at 1:28 AM David Gow wrote: > > KUnit's executor_test logs the filter string in KUNIT_ASSERT_EQ_MSG(), > but passed a random character from the filter, rather than the whole > string. Note: it's worse than that, afaict. It's printing from a random bit of memory. I was curiou

Re: [PATCH v4 6/8] usb: misc: onboard_dev: use device supply names

2024-02-21 Thread Matthias Kaehlcke
On Tue, Feb 20, 2024 at 03:05:50PM +0100, Javier Carrasco wrote: > The current mechanism uses generic names for the power supplies, which > conflicts with proper name definitions in the device bindings. > > Add a per-device property to include real supply names and keep generic > names as a fallba

Re: [PATCH 2/9] lib/cmdline: Fix an invalid format specifier in an assertion msg

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:15PM +0800, David Gow wrote: > The correct format specifier for p - n (both p and n are pointers) is > %td, as the type should be ptrdiff_t. I think %tu is better. d specifies a signed type. I don't doubt that the warning is fixed but I think %tu represents the t

Re: [PATCH 1/9] kunit: test: Log the correct filter string in executor_test

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:14PM +0800, David Gow wrote: > KUnit's executor_test logs the filter string in KUNIT_ASSERT_EQ_MSG(), > but passed a random character from the filter, rather than the whole > string. > > This was found by annotating KUNIT_ASSERT_EQ_MSG() to let gcc validate > the

Re: [PATCH 9/9] kunit: Annotate _MSG assertion variants with gnu printf specifiers

2024-02-21 Thread Justin Stitt
Hi, On Wed, Feb 21, 2024 at 05:27:22PM +0800, David Gow wrote: > KUnit's assertion macros have variants which accept a printf format > string, to allow tests to specify a more detailed message on failure. > These (and the related KUNIT_FAIL() macro) ultimately wrap the > __kunit_do_failed_assertio

Re: Re: [PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n

2024-02-21 Thread Lucas De Marchi
On Wed, Feb 21, 2024 at 05:21:17PM +1100, Stephen Rothwell wrote: Hi Lucas, On Tue, 20 Feb 2024 23:29:54 -0600 Lucas De Marchi wrote: Looking at https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e it seems we still don't ha

[PATCH] drm/amd/display: Add prefix to functions inside dnc10_cm_common.h

2024-02-21 Thread Joao Paulo Pereira da Silva
While debugging with ftrace, it's useful to create filters to search within the codebase. However, since some function names lack prefixes, creating a good filter may become more difficult. Because of this, add prefix to functions declared inside the header dcn10/dcn10_cm_common.h to facilitate cr

Re: [PATCH v4 2/8] usb: misc: onboard_dev: add support for non-hub devices

2024-02-21 Thread Matthias Kaehlcke
On Tue, Feb 20, 2024 at 03:05:46PM +0100, Javier Carrasco wrote: > Most of the functionality this driver provides can be used by non-hub > devices as well. > > To account for the hub-specific code, add a flag to the device data > structure and check its value for hub-specific code. Please mention

Re: [PATCH v4 1/8] usb: misc: onboard_hub: rename to onboard_dev

2024-02-21 Thread Matthias Kaehlcke
On Tue, Feb 20, 2024 at 03:05:45PM +0100, Javier Carrasco wrote: > This patch prepares onboad_hub to support non-hub devices by renaming > the driver files and their content, the headers and their references. > > The comments and descriptions have been slightly modified to keep > coherence and acc

Re: [PATCH] drm/msm/a6xx: specify UBWC config for sc7180

2024-02-21 Thread Connor Abbott
On Tue, Feb 20, 2024 at 5:12 PM Dmitry Baryshkov wrote: > > Historically the Adreno driver has not been updating memory > configuration registers on a618 (SC7180 platform) implying that the > default configuration is fine. After the rework performed in the commit > 8814455a0e54 ("drm/msm: Refactor

[PATCH RESEND v2] drm/syncobj: handle NULL fence in syncobj_eventfd_entry_func

2024-02-21 Thread Erik Kurzinger
During syncobj_eventfd_entry_func, dma_fence_chain_find_seqno may set the fence to NULL if the given seqno is signaled and a later seqno has already been submitted. In that case, the eventfd should be signaled immediately which currently does not happen. This is a similar issue to the one addresse

Re: [PATCH v7 3/3] drm/buddy: Add defragmentation support

2024-02-21 Thread Matthew Auld
On 21/02/2024 12:18, Arunpravin Paneer Selvam wrote: Add a function to support defragmentation. v1: - Defragment the memory beginning from min_order till the required memory space is available. v2(Matthew): - add amdgpu user for defragmentation - add a warning if the two blocks ar

Re: [PATCH v2 1/3] drm/syncobj: call drm_syncobj_fence_add_wait when WAIT_AVAILABLE flag is set

2024-02-21 Thread Erik Kurzinger
It looks these these patches have still not been merged after one month, is there anything more that needs to be done for this to happen? On 1/25/24 10:12, Daniel Vetter wrote: > On Fri, Jan 19, 2024 at 08:32:06AM -0800, Erik Kurzinger wrote: >> When waiting for a syncobj timeline point whose fen

[linux-next:master] BUILD REGRESSION 4893c639cc3659cefaa675bf1e59f4e7571afb5c

2024-02-21 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 4893c639cc3659cefaa675bf1e59f4e7571afb5c Add linux-next specific files for 20240221 Error/Warning: (recently discovered and may have been fixed) ld.lld: error: undefined symbol

Re: [PATCH v1] drivers/i915/intel_bios: Fix parsing backlight BDB data

2024-02-21 Thread Ville Syrjälä
On Tue, Feb 20, 2024 at 02:12:57PM -0700, Karthikeyan Ramasubramanian wrote: > Starting BDB version 239, hdr_dpcd_refresh_timeout is introduced to > backlight BDB data. Commit 700034566d68 ("drm/i915/bios: Define more BDB > contents") updated the backlight BDB data accordingly. This broke the > par

Re: [PATCH] drm/amd/display: clean unnecessary braces

2024-02-21 Thread Rodrigo Siqueira Jordao
Hi Túlio, First of all thanks for your patch. See my comments inline. On 2/17/24 13:20, Túlio Fernandes wrote: Clean unnecessary braces in dc/dcn32/dcn32_resource_helpers.c and dc/dcn32/dcn201_link_encoder.c Did you identify this issue with checkpatch? If so, I recommend you paste the error

Re: [PATCH v6 1/3] drm/buddy: Implement tracking clear page feature

2024-02-21 Thread Matthew Auld
On 21/02/2024 12:40, Paneer Selvam, Arunpravin wrote: On 2/16/2024 5:33 PM, Matthew Auld wrote: On 08/02/2024 15:49, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks in the free path. O

[PATCH] drm/mediatek: Add MT8188 Overlay Driver Data

2024-02-21 Thread Justin Green
Add MT8188 overlay driver configuration data. This change consequently enables 10-bit overlay support on MT8188 devices. Tested by running ChromeOS UI on MT8188 and using modetest -P. AR30 and BA30 overlays are confirmed to work from modetest. Signed-off-by: Justin Green Tested-by: Justin Green

Re: [PATCH] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-02-21 Thread Steven Price
On 21/02/2024 16:12, Adrián Larumbe wrote: > Debugfs isn't always available in production builds that try to squeeze > every single byte out of the kernel image, but we still need a way to > toggle the timestamp and cycle counter registers so that jobs can be > profiled for fdinfo's drm engine and

Re: [PATCH v2 01/10] backlight: Match backlight device against struct fb_info.bl_dev

2024-02-21 Thread Andy Shevchenko
On Wed, Feb 21, 2024 at 5:45 PM Thomas Zimmermann wrote: > Am 21.02.24 um 15:34 schrieb Andy Shevchenko: > > On Wed, Feb 21, 2024 at 10:41:28AM +0100, Thomas Zimmermann wrote: > >> Framebuffer drivers for devices with dedicated backlight are supposed > >> to set struct fb_info.bl_dev to the backli

Re: [PATCH 8/9] media: dt-bindings: Add Intel Displayport RX IP

2024-02-21 Thread Paweł Anikiel
On Thu, Feb 15, 2024 at 6:26 PM Conor Dooley wrote: > > Yo, > > On Mon, Feb 12, 2024 at 01:13:22PM +, Paweł Anikiel wrote: > > The Intel Displayport RX IP is a part of the DisplayPort Intel FPGA IP > > Core. It implements a DisplayPort 1.4 receiver capable of HBR3 video > > capture and Multi-S

Re: [PATCH v17 0/5] Add RZ/{G2L, G2LC} and RZ/V2L Display Unit support

2024-02-21 Thread Maxime Ripard
On Sun, 18 Feb 2024 16:48:35 +, Biju Das wrote: > This path series aims to add support for RZ/G2L DU DRM driver. > > RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video > signal processor (VSPD) and Display unit(DU). The output of LCDC is > connected to Display parallel

Re: [PATCH v15 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2024-02-21 Thread Maxime Ripard
On Tue, 28 Nov 2023 10:51:24 +, Biju Das wrote: > This path series aims to add support for RZ/G2L DU DRM driver. > > RZ/G2L LCD controller composed of Frame compression Processor(FCPVD), Video > signal processor (VSPD) and Display unit(DU). The output of LCDC is > connected to Display parallel

Re: [PATCH 7/9] media: dt-bindings: Add Chameleon v3 framebuffer

2024-02-21 Thread Paweł Anikiel
On Thu, Feb 15, 2024 at 6:29 PM Conor Dooley wrote: > > On Mon, Feb 12, 2024 at 01:13:21PM +, Paweł Anikiel wrote: > > The Chameleon v3 uses the framebuffer IP core to take the video signal > > from different sources and directly write frames into memory. > > > > Signed-off-by: Paweł Anikiel

[PATCH 3/3] arch: Rename fbdev header and source files

2024-02-21 Thread Thomas Zimmermann
The per-architecture fbdev code has no dependencies on fbdev and can be used for any video-related subsystem. Rename the files to 'video'. Use video-sti.c on parisc as the source file depends on CONFIG_STI_CORE. Further update all includes statements, includ guards, and Makefiles. Also update a fe

[PATCH 1/3] arch: Select fbdev helpers with CONFIG_VIDEO

2024-02-21 Thread Thomas Zimmermann
Various Kconfig options selected the per-architecture helpers for fbdev. But none of the contained code depends on fbdev. Standardize on CONFIG_VIDEO, which will allow to add more general helpers for video functionality. CONFIG_VIDEO protects each architecture's video/ directory. This allows for t

[PATCH 2/3] arch: Remove struct fb_info from video helpers

2024-02-21 Thread Thomas Zimmermann
The per-architecture video helpers do not depend on struct fb_info or anything else from fbdev. Remove it from the interface and replace fb_is_primary_device() with video_is_primary_device(). The new helper is similar in functionality, but can operate on non-fbdev devices. Signed-off-by: Thomas Zi

[PATCH 0/3] arch: Remove fbdev dependency from video helpers

2024-02-21 Thread Thomas Zimmermann
Make architecture helpers for display functionality depend on general video functionality instead of fbdev. This avoid the dependency on fbdev and makes the functionality available for non-fbdev code. Patch 1 replaces the variety of Kconfig options that control the Makefiles with CONFIG_VIDEO. Mor

[PATCH] drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs

2024-02-21 Thread Adrián Larumbe
Debugfs isn't always available in production builds that try to squeeze every single byte out of the kernel image, but we still need a way to toggle the timestamp and cycle counter registers so that jobs can be profiled for fdinfo's drm engine and cycle calculations. Drop the debugfs knob and repl

[PATCH v2 8/9] media: dt-bindings: Add Intel Displayport RX IP

2024-02-21 Thread Paweł Anikiel
The Intel Displayport RX IP is a part of the DisplayPort Intel FPGA IP Core. It implements a DisplayPort 1.4 receiver capable of HBR3 video capture and Multi-Stream Transport. The user guide can be found here: https://www.intel.com/programmable/technical-pdfs/683273.pdf Signed-off-by: Paweł Aniki

[PATCH v2 4/9] lib: Move DisplayPort CRC functions to common lib

2024-02-21 Thread Paweł Anikiel
The CRC functions found in drivers/gpu/drm/display/drm_dp_mst_topology.c may be useful for other non-DRM code that deals with DisplayPort, e.g. v4l2 drivers for DP receivers. Move these functions to /lib. Signed-off-by: Paweł Anikiel --- drivers/gpu/drm/display/Kconfig | 1 + driv

[PATCH v2 9/9] ARM: dts: chameleonv3: Add video device nodes

2024-02-21 Thread Paweł Anikiel
Add device nodes for the video system present on the Chameleon v3. It consists of six framebuffers and two Intel Displayport receivers. Signed-off-by: Paweł Anikiel --- .../socfpga/socfpga_arria10_chameleonv3.dts | 152 ++ 1 file changed, 152 insertions(+) diff --git a/arch/ar

[PATCH v2 7/9] media: dt-bindings: Add Chameleon v3 framebuffer

2024-02-21 Thread Paweł Anikiel
The Chameleon v3 uses the framebuffer IP core to take the video signal from different sources and directly write frames into memory. Signed-off-by: Paweł Anikiel --- .../bindings/media/google,chv3-fb.yaml| 67 +++ 1 file changed, 67 insertions(+) create mode 100644 Docum

[PATCH v2 5/9] drm/display: Add mask definitions for DP_PAYLOAD_ALLOCATE_* registers

2024-02-21 Thread Paweł Anikiel
Each of these registers contains a single value, but not the entire 8 bits: DP_PAYLOAD_ALLOCATE_SET - Bit 7 Reserved DP_PAYLOAD_ALLOCATE_START_TIME_SLOT - Bits 7:6 Reserved DP_PAYLOAD_ALLOCATE_TIME_SLOT_COUNT - Bits 7:6 Reserved Add definitions to properly mask off values read from these register

[PATCH v2 6/9] media: intel: Add Displayport RX IP driver

2024-02-21 Thread Paweł Anikiel
Add driver for the Intel DisplayPort RX FPGA IP Signed-off-by: Paweł Anikiel --- drivers/media/platform/intel/Kconfig | 12 + drivers/media/platform/intel/Makefile |1 + drivers/media/platform/intel/intel-dprx.c | 2176 + 3 files changed, 2189 insertions(+) cr

  1   2   3   >