[PATCH v4, 2/2] drm: Check polling initialized before enabling in drm_helper_probe_single_connector_modes

2024-02-01 Thread Shradha Gupta
In function drm_helper_probe_single_connector_modes() when we enable polling again, if it is already uninitialized, a warning is reported. This patch fixes the warning message by checking if poll is initialized before enabling it. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe

[PATCH v4, 1/2] drm: Check output polling initialized before disabling

2024-02-01 Thread Shradha Gupta
In drm_kms_helper_poll_disable() check if output polling support is initialized before disabling polling. If not flag this as a warning. Additionally in drm_mode_config_helper_suspend() and drm_mode_config_helper_resume() calls, that re the callers of these functions, avoid invoking them if polling

[PATCH v4 0/2] drm: Check polling initialized before

2024-02-01 Thread Shradha Gupta
This patchset consists of sanity checks before enabling/disabling output polling to make sure we do not call polling enable and disable functions when polling for the device is not initialized or is now uninitialized(by drm_kms_helper_poll_fini() function) The first patch consists of these checks

Re: [PATCH 11/17] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-01 Thread Abhinav Kumar
On 1/31/2024 8:36 PM, Dmitry Baryshkov wrote: On Thu, 1 Feb 2024 at 03:56, Abhinav Kumar wrote: On 1/27/2024 9:39 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:34, Paloma Arellano wrote: On 1/25/2024 1:48 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote

[drm-misc:drm-misc-next 2/6] drivers/gpu/drm/drm_managed.c:200:22-24: WARNING !A || A && B is equivalent to !A || B

2024-02-01 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 041261ac4c365e03b07427569d6735f8adfd21c8 commit: 42d6196f6a948aaecfedf72326925dcbd054f9db [2/6] drm/managed: Add drmm_release_action config: x86_64-randconfig-103-20240201 (https://download.01.org/0day-ci/archive/20240202

[linux][PATCH v6 3/3] dt-bindings: mfd: atmel, hlcdc: Convert to DT schema format

2024-02-01 Thread Dharma Balasubiramani
Convert the atmel,hlcdc binding to DT schema format. Align clocks and clock-names properties to clearly indicate that the LCD controller expects lvds_pll_clk when interfaced with the lvds display. This alignment with the specific hardware requirements ensures accurate device tree configuration for

[linux][PATCH v6 2/3] dt-bindings: atmel, hlcdc: convert pwm bindings to json-schema

2024-02-01 Thread Dharma Balasubiramani
Convert device tree bindings for Atmel's HLCDC PWM controller to YAML format. Signed-off-by: Dharma Balasubiramani Reviewed-by: Conor Dooley --- Changelog v5 -> v6 - Drop the example as we have one complete example in mfd binding. v4 -> v5 v3 -> v4 - No changes Note: The clean up patch will be s

[linux][PATCH v6 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-02-01 Thread Dharma Balasubiramani
Convert the existing DT binding to DT schema of the Atmel's HLCDC display controller. Signed-off-by: Dharma Balasubiramani Reviewed-by: Conor Dooley --- Changelog v5 -> v6 - Drop example as we have one complete example in mfd binding. v4 -> v5 - No change. v3 -> v4 - Add bus-width property to ha

[linux][PATCH v6 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

2024-02-01 Thread Dharma Balasubiramani
Converted the text bindings to YAML and validated them individually using following commands $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ changelogs are available in respective patches. Dharma Bal

Re: [syzbot] [dri?] WARNING in vkms_get_vblank_timestamp (2)

2024-02-01 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:6764c317b6bb Merge tag 'scsi-fixes' of git://git.kernel.or.. git tree: upstream console+strace: https://syzkaller.appspot.com/x/log.txt?x=12be332818 kernel config: https://syzkaller.appspot.com/x/.config?x=2c0ac5d

[PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

2024-02-01 Thread Jessica Zhang
The DSI host must be enabled for the panel to be initialized in prepare(). Set the prepare_prev_first flag to guarantee this. Signed-off-by: Jessica Zhang --- To: Neil Armstrong To: Sam Ravnborg To: David Airlie To: Daniel Vetter To: Jessica Zhang To: Maarten Lankhorst To: Maxime Ripard To

[PATCH 2/2] drm/nouveau: omit to create schedulers using the legacy uAPI

2024-02-01 Thread Danilo Krummrich
Omit to create scheduler instances when using the legacy uAPI. When using the legacy NOUVEAU_GEM_PUSHBUF ioctl no scheduler instance is required, hence omit creating scheduler instances in nouveau_abi16_ioctl_channel_alloc(). Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_ab

[PATCH 1/2] drm/nouveau: don't fini scheduler if not initialized

2024-02-01 Thread Danilo Krummrich
nouveau_abi16_ioctl_channel_alloc() and nouveau_cli_init() simply call their corresponding *_fini() counterpart. This can lead to nouveau_sched_fini() being called without struct nouveau_sched ever being initialized in the first place. Instead of embedding struct nouveau_sched into struct nouveau_

Re: [linux][PATCH v5 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

2024-02-01 Thread Dharma.B
On 02/02/24 4:06 am, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, Feb 01, 2024 at 03:38:37AM +, dharm...@microchip.com wrote: >> Hi Rob, >> >> On 31/01/24 9:05 am, Dharma B - I70843 wrote: >>> Converted the text

Re: [PATCH] drm/panel: novatek-nt36523: Set prepare_prev_first

2024-02-01 Thread Jessica Zhang
el.backlight = nt36523_create_backlight(dsi); if (IS_ERR(pinfo->panel.backlight)) --- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20240201-topic-3623_fix-9198419e5e47 Best regards, -- Konrad Dybcio

Re: [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: remove port property

2024-02-01 Thread Rob Herring
On Wed, 31 Jan 2024 22:14:29 +0100, Johan Jonker wrote: > The hdmi-connector nodes are now functional and the new way to model > hdmi ports nodes with both in and output port subnodes. Unfortunately > with the conversion to YAML the old method with only an input port node > was used. Later the ne

Re: [linux][PATCH v5 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

2024-02-01 Thread Rob Herring
On Thu, Feb 01, 2024 at 03:38:37AM +, dharm...@microchip.com wrote: > Hi Rob, > > On 31/01/24 9:05 am, Dharma B - I70843 wrote: > > Converted the text bindings to YAML and validated them individually using > > following commands > > > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/d

Re: [PATCH 0/2] Better support for complex pixel formats

2024-02-01 Thread Maira Canal
lpers. [1]: https://lore.kernel.org/dri-devel/20240110-vkms-yuv-v2-0-952fcaa5a...@riseup.net/ [2]: https://lore.kernel.org/igt-dev/20240201-kms_tests-v1-0-bc34c5d28...@bootlin.com/T/#t Signed-off-by: Louis Chauvet --- Louis Chauvet (2): drm/vkms: Create a type to check a function pointer valid

[PATCH] drm/panel: novatek-nt36523: Set prepare_prev_first

2024-02-01 Thread Konrad Dybcio
--- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20240201-topic-3623_fix-9198419e5e47 Best regards, -- Konrad Dybcio

[PATCH v3 2/5] drm: Add drm_get_acpi_edid() helper

2024-02-01 Thread Mario Limonciello
Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Drivers can call this helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method. Signed-off-by: Mario Limonciello --- v1->v2: * Split code from previous amdgpu specific help

[PATCH v3 4/5] drm/nouveau: Use drm_get_acpi_edid() helper

2024-02-01 Thread Mario Limonciello
Rather than inventing a wrapper to acpi_video_get_edid() use the one provided by drm. This fixes two problems: 1. A memory leak that the memory provided by the ACPI call was never freed. 2. Validation of the BIOS provided blob. Signed-off-by: Mario Limonciello --- v1->v2: * New patch --- dri

[PATCH v3 5/5] drm: Drop unneeded selects in DRM drivers

2024-02-01 Thread Mario Limonciello
All of the selects on ACPI_VIDEO are unnecessary when DRM does the select for ACPI_VIDEO as it provides a helper for acpi based EDID. Signed-off-by: Mario Limonciello --- v2->v3: * new patch --- drivers/gpu/drm/amd/amdgpu/Kconfig | 7 --- drivers/gpu/drm/gma500/Kconfig | 6 -- drive

[PATCH v3 1/5] ACPI: video: Handle fetching EDID that is longer than 256 bytes

2024-02-01 Thread Mario Limonciello
The ACPI specification allows for an EDID to be up to 512 bytes but the _DDC EDID fetching code will only try up to 256 bytes. Modify the code to instead start at 512 bytes and work it's way down instead. As _DDC is now called up to 4 times on a machine debugging messages are noisier than necessa

[PATCH v3 3/5] drm/amd: Fetch the EDID from _DDC if available for eDP

2024-02-01 Thread Mario Limonciello
Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Attempt to fetch this EDID if it exists and prefer it over the EDID that is provided by the panel. Signed-off-by: Mario Limonciello --- v2: * Use drm helper which will run more validat

[PATCH v3 0/5] Add support for fetching EDID from ACPI _DDC

2024-02-01 Thread Mario Limonciello
Some laptops ship an EDID in the BIOS encoded in the _DDC method that differs than the EDID directly on the laptop panel for $REASONS. This is the EDID that is used by the AMD Windows driver, and so sometimes different results are found in different operating systems. This series adds a new DRM h

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-02-01 Thread Jarkko Sakkinen
On Wed Jan 24, 2024 at 7:22 PM EET, Mark Brown wrote: > On Wed, Jan 24, 2024 at 09:13:49AM -0800, Greg Kroah-Hartman wrote: > > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > > didn't appear in a p

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

2024-02-01 Thread Jason Gunthorpe
On Thu, Feb 01, 2024 at 07:35:24PM +, Jon Hunter wrote: > > You mean this sequence? > > > > err = device_add(&ctx->dev); > > if (err) { > > dev_err(host1x->dev, "could not add context device %d: > > %d\n", i, err); > > put_device

[PATCH v2 1/3] backlight: mp3309c: Make use of device properties

2024-02-01 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Add mod_devicetable.h include. Tested-by: Flavio Suligoi Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 44 +-- 1 file changed, 18 insertions(+),

Re: [PATCH v2 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: remove port property

2024-02-01 Thread Conor Dooley
On Wed, Jan 31, 2024 at 10:14:29PM +0100, Johan Jonker wrote: > The hdmi-connector nodes are now functional and the new way to model > hdmi ports nodes with both in and output port subnodes. Unfortunately > with the conversion to YAML the old method with only an input port node > was used. Later th

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

2024-02-01 Thread Jon Hunter
On 31/01/2024 15:33, Jason Gunthorpe wrote: On Tue, Jan 30, 2024 at 09:55:18PM +, Jon Hunter wrote: On 30/01/2024 16:15, Jason Gunthorpe wrote: This was added in commit c95469aa5a18 ("gpu: host1x: Set DMA ops on device creation") with the note: Currently host1x-instanciated device

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-01 Thread Abhinav Kumar
On 1/31/2024 7:17 PM, Dmitry Baryshkov wrote: On Thu, 1 Feb 2024 at 03:30, Abhinav Kumar wrote: On 1/29/2024 3:44 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 09:08, Abhinav Kumar wrote: On 1/28/2024 10:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar

Re: [PATCH v19 09/30] drm/shmem-helper: Add and use lockless drm_gem_shmem_get_pages()

2024-02-01 Thread Dmitry Osipenko
On 1/30/24 13:10, Boris Brezillon wrote: > On Tue, 30 Jan 2024 09:34:29 +0100 > Daniel Vetter wrote: > >> On Fri, Jan 26, 2024 at 07:43:29PM +0300, Dmitry Osipenko wrote: >>> On 1/26/24 13:18, Boris Brezillon wrote: On Thu, 25 Jan 2024 18:24:04 +0100 Daniel Vetter wrote:

Re: [PATCH v3 3/3] drm/amdgpu: Implement check_async_props for planes

2024-02-01 Thread André Almeida
Hi Sima, Em 30/01/2024 07:56, Daniel Vetter escreveu: On Sun, Jan 28, 2024 at 06:25:15PM -0300, André Almeida wrote: AMD GPUs can do async flips with changes on more properties than just the FB ID, so implement a custom check_async_props for AMD planes. Allow amdgpu to do async flips with over

Re: [PATCH v3 1/3] drm/atomic: Allow drivers to write their own plane check for async flips

2024-02-01 Thread André Almeida
Hi Pekka, Em 29/01/2024 05:49, Pekka Paalanen escreveu: On Sun, 28 Jan 2024 18:25:13 -0300 André Almeida wrote: Some hardware are more flexible on what they can flip asynchronously, so rework the plane check so drivers can implement their own check, lifting up some of the restrictions. Signe

[pull] amdgpu, amdkfd drm-fixes-6.8

2024-02-01 Thread Alex Deucher
Hi Dave, Sima, Fixes for 6.8. The following changes since commit 41bccc98fb7931d63d03f326a746ac4d429c1dd3: Linux 6.8-rc2 (2024-01-28 17:01:12 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.8-2024-02-01 for you to fetch c

Re: [PATCH v2 6/7] drm/vkms: Drop YUV formats TODO

2024-02-01 Thread Louis Chauvet
Le 10/01/24 - 14:44, Arthur Grillo a écrit : > VKMS has support for YUV formats now. Remove the task from the TODO > list. > > Signed-off-by: Arthur Grillo > --- > Documentation/gpu/vkms.rst | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/gpu/vkms.rst b/

Re: [PATCH v2 5/7] drm/vkms: Add YUV support

2024-02-01 Thread Louis Chauvet
Le 10/01/24 - 14:44, Arthur Grillo a écrit : > Add support to the YUV formats bellow: > > - NV12 > - NV16 > - NV24 > - NV21 > - NV61 > - NV42 > - YUV420 > - YUV422 > - YUV444 > - YVU420 > - YVU422 > - YVU444 > > The conversion matrices of each encoding and range were obtained by > rounding the va

Re: [PATCH v2 3/7] drm/vkms: Add range and encoding properties to pixel_read function

2024-02-01 Thread Louis Chauvet
Le 10/01/24 - 14:44, Arthur Grillo a écrit : > Create range and encoding properties. This should be noop, as none of > the conversion functions need those properties. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/vkms/vkms_drv.h | 3 ++- > drivers/gpu/drm/vkms/vkms_formats.c | 20

Re: [PATCH v2 1/7] drm/vkms: Use drm_frame directly

2024-02-01 Thread Louis Chauvet
Le 10/01/24 - 14:44, Arthur Grillo a écrit : > Remove intermidiary variables and access the variables directly from > drm_frame. These changes should be noop. > > Signed-off-by: Arthur Grillo > --- > drivers/gpu/drm/vkms/vkms_drv.h | 3 --- > drivers/gpu/drm/vkms/vkms_formats.c | 12 +++

Re: [PATCH v2 7/7] drm/vkms: Create KUnit tests for YUV conversions

2024-02-01 Thread Louis Chauvet
[...] > + { > + .encoding = DRM_COLOR_YCBCR_BT709, > + .range = DRM_COLOR_YCBCR_FULL_RANGE, > + .n_colors = 4, > + .colors = { > + {"white", {0xff, 0x80, 0x80}, {0x, 0x, 0x, > 0x}}, > + {"g

Re: [PATCH v2 4/7] drm/vkms: Add chroma subsampling

2024-02-01 Thread Louis Chauvet
In the series [1] I proposed to change the pattern to detect this kind of issue. [...] [1]: https://lore.kernel.org/dri-devel/20240201-yuv-v1-0-3ca376f27...@bootlin.com/T/#t -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 2/7] drm/vkms: Add support for multy-planar framebuffers

2024-02-01 Thread Louis Chauvet
believe it still is an intersting trade-off. In the future, if performance is actally critical, the whole composition loop will have to be specialized for each pixel formats: some can be treated line by line (as it's done today), but with blocks or packed pixels it's more complex. > + for (size_t i = 0; i < frame_format->num_planes; i++) > + src_pixels[i] += frame_format->cpp[i]; This is likely working with format with block_w != 1, see explanation above. [...] [1]: https://lore.kernel.org/dri-devel/20240201-yuv-v1-0-3ca376f27...@bootlin.com/T/#t -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[PATCH 1/2] drm/vkms: Create a type to check a function pointer validity

2024-02-01 Thread Louis Chauvet
Add the pixel_read_t type to check function prototype in structures and functions. It avoids casting to (void *) and at the same occasion allows the compiler to check the type properly. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_drv.h | 17 +++-- drivers/gpu/drm/v

[PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-01 Thread Louis Chauvet
n_crc@multiplane-rotation-cropping-* - See [1] [1]: https://lore.kernel.org/igt-dev/20240201-kms_tests-v1-0-bc34c5d28...@bootlin.com/T/#t Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_composer.c | 97 +- drivers/gpu/drm/vkms/vkms_drv.h | 21 ++- drivers/gpu/drm

[PATCH 0/2] Better support for complex pixel formats

2024-02-01 Thread Louis Chauvet
h case in different places and instead of copy/pasting rotation formula I used drm_rect_* helpers. [1]: https://lore.kernel.org/dri-devel/20240110-vkms-yuv-v2-0-952fcaa5a...@riseup.net/ [2]: https://lore.kernel.org/igt-dev/20240201-kms_tests-v1-0-bc34c5d28...@bootlin.com/T/#t Signed-off-by: Louis

Re: RE: Re: [PATCH 0/4] Fixing live video input in ZynqMP DPSUB

2024-02-01 Thread Maxime Ripard
On Fri, Jan 26, 2024 at 11:18:30PM +, Klymenko, Anatoliy wrote: > > > > -Original Message- > > From: Maxime Ripard > > Sent: Friday, January 26, 2024 4:26 AM > > To: Laurent Pinchart > > Cc: Klymenko, Anatoliy ; > > maarten.lankho...@linux.intel.com; tzimmerm...@suse.de; airl...@gma

Re: Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-01 Thread Maxime Ripard
On Thu, Feb 01, 2024 at 03:33:24PM +, Dave Stevenson wrote: > Hi Maxime > > On Thu, 1 Feb 2024 at 12:51, Maxime Ripard wrote: > > > > On Thu, Dec 14, 2023 at 03:10:43PM +, Dave Stevenson wrote: > > > > +static bool > > > > +sink_supports_format_bpc(const struct drm_connector *connector, >

[PATCH v2 3/3] backlight: mp3309c: Utilise temporary variable for struct device

2024-02-01 Thread Andy Shevchenko
We have a temporary variable to keep pointer to struct device. Utilise it where it makes sense. Reviewed-by: Daniel Thompson Tested-by: Flavio Suligoi Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 30 -- 1 file changed, 12 insertions(+), 18

Re: Re: [PATCH 09/10] drm/xe: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-02-01 Thread Lucas De Marchi
On Thu, Feb 01, 2024 at 02:52:55PM +0200, Jani Nikula wrote: On Tue, 16 Jan 2024, Jani Nikula wrote: Prefer the device specific debug printer. Signed-off-by: Jani Nikula Xe maintainers, ack for merging this via drm-misc along with the rest of the series? Do you plan to also merge the last

Re: [PATCH v4 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2

2024-02-01 Thread Diederik de Haas
On Saturday, 27 January 2024 10:48:45 CET Manuel Traut wrote: > This includes support for both the v0.1 units that were sent to developers > and the v2.0 units from production. > > v1.0 is not included as no units are known to exist. > > Working/Tested: > - SDMMC > - UART > - Buttons > - Charging

[PATCH v2 1/4] backlight: hx8357: Make use of device properties

2024-02-01 Thread Andy Shevchenko
Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Include mod_devicetable.h explicitly to replace the dropped of.h which included mod_devicetable.h indirectly. Reviewed-by: Javier Martinez Canillas Signed-off-by: Andy Shevchenko --- drivers/video/

[PATCH v2 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-02-01 Thread Andy Shevchenko
Move OF table near to the user. While at it, drop comma at terminator entry. Reviewed-by: Daniel Thompson Reviewed-by: Javier Martinez Canillas Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-

Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-01 Thread Dave Stevenson
Hi Maxime On Thu, 1 Feb 2024 at 12:51, Maxime Ripard wrote: > > On Thu, Dec 14, 2023 at 03:10:43PM +, Dave Stevenson wrote: > > > +static bool > > > +sink_supports_format_bpc(const struct drm_connector *connector, > > > +const struct drm_display_info *info, > > > +

[PATCH v2 2/3] backlight: mp3309c: use dev_err_probe() instead of dev_err()

2024-02-01 Thread Andy Shevchenko
Replace dev_err() with dev_err_probe(). This helps in simplifing code and standardizing the error output. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/mp3309c.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/video/backlight/mp3309c.

[PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-01 Thread Andy Shevchenko
Allow to use driver on non-OF platforms and other cleanups. Changelog v2: - rename pm3309c_parse_dt_node() --> mp3309c_parse_fwnode() (Daniel) - add tags (Daniel, Flavio) - new patch 2 Andy Shevchenko (3): backlight: mp3309c: Make use of device properties backlight: mp3309c: use dev_err_probe

Re: [PATCH] drm/i915/display: Include debugfs.h in intel_display_debugfs_params.c

2024-02-01 Thread Jani Nikula
On Thu, 01 Feb 2024, Paz Zcharya wrote: > Thank you so much for the super prompt reply! FYI, looks like we've got some hiccup in CI, will merge after we get results. BR, Jani. -- Jani Nikula, Intel

[PATCH v2 4/4] backlight: hx8357: Utilise temporary variable for struct device

2024-02-01 Thread Andy Shevchenko
We have a temporary variable to keep pointer to struct device. Utilise it inside the ->probe() implementation. Reviewed-by: Daniel Thompson Reviewed-by: Javier Martinez Canillas Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH v2 3/4] backlight: hx8357: Make use of dev_err_probe()

2024-02-01 Thread Andy Shevchenko
Simplify the error handling in probe function by switching from dev_err() to dev_err_probe(). Reviewed-by: Daniel Thompson Reviewed-by: Javier Martinez Canillas Signed-off-by: Andy Shevchenko --- drivers/video/backlight/hx8357.c | 12 1 file changed, 4 insertions(+), 8 deletions(-

[PATCH v2 0/4] backlight: hx8357: Clean up and make OF-independent

2024-02-01 Thread Andy Shevchenko
A few ad-hoc cleanups and one patch to make driver OF-independent. Chagelog v2: - renamed init to init_fn and typedef accordingly (Daniel) - added tags (Daniel, Javier) Andy Shevchenko (4): backlight: hx8357: Make use of device properties backlight: hx8357: Move OF table closer to its consume

Re: [PATCH] drm/i915/display: Include debugfs.h in intel_display_debugfs_params.c

2024-02-01 Thread Paz Zcharya
On Thu, Feb 01, 2024 at 11:22:16AM +0200, Jani Nikula wrote: > On Wed, 31 Jan 2024, Paz Zcharya wrote: > > Commit 8015bee0bfec ("drm/i915/display: Add framework to add parameters > > specific to display") added the file intel_display_debugfs_params.c, > > which calls the functions "debugfs_create_

Re: Re: [PATCH 00/10] drm: drm debug and error logging improvements

2024-02-01 Thread Maxime Ripard
On Thu, Feb 01, 2024 at 02:51:13PM +0200, Jani Nikula wrote: > On Tue, 16 Jan 2024, Jani Nikula wrote: > > This is resend and more patches on top of [1]. I don't think I've > > changed anything since then. > > Hi drm-misc maintainers - > > I've got R-b from Luca, but given there's no comments ou

Re: [PATCH v3 1/2] drm: enable (most) W=1 warnings by default across the subsystem

2024-02-01 Thread Danilo Krummrich
On 2/1/24 15:33, Jani Nikula wrote: At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend most of the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with s/KBUILD_CFLAGS/subdir

[PATCH v3 2/2] drm: Add CONFIG_DRM_WERROR

2024-02-01 Thread Jani Nikula
Add kconfig to enable -Werror subsystem wide. This is useful for development and CI to keep the subsystem warning free, while avoiding issues outside of the subsystem that kernel wide CONFIG_WERROR=y might hit. v2: Don't depend on COMPILE_TEST Reviewed-by: Hamza Mahfooz # v1 Signed-off-by: Jani

[PATCH v3 1/2] drm: enable (most) W=1 warnings by default across the subsystem

2024-02-01 Thread Jani Nikula
At least the i915 and amd drivers enable a bunch more compiler warnings than the kernel defaults. Extend most of the W=1 warnings to the entire drm subsystem by default. Use the copy-pasted warnings from scripts/Makefile.extrawarn with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it easier to compare

[PATCH v3 0/2] drm: enable W=1 warnings by default across the subsystem

2024-02-01 Thread Jani Nikula
This is v3 of [1], with the warning fixes already merged, and rebased on upstream warning changes. I built this on x86-64 (both gcc and clang), arm and arm64, and everything passed. BR, Jani. [1] https://lore.kernel.org/r/cover.1704908087.git.jani.nik...@intel.com Jani Nikula (2): drm: enable

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-02-01 Thread Maarten Lankhorst
On 2024-01-31 16:07, Jani Nikula wrote: On Wed, 31 Jan 2024, Lucas De Marchi wrote: +Jani On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: intel_power_domains_init has been called twice in xe_device_probe: xe_device_probe -> xe_display_init_nommio -> intel_power_domains_ini

Re: [PATCH] drm/sched: Add Matthew Brost to maintainers

2024-02-01 Thread Christian König
Am 31.01.24 um 18:11 schrieb Daniel Vetter: On Tue, Jan 30, 2024 at 07:03:02PM -0800, Matthew Brost wrote: Add Matthew Brost to DRM scheduler maintainers. Cc: Luben Tuikov Cc: Daniel Vetter Cc: Dave Airlie Cc: Christian König Signed-off-by: Matthew Brost Definitely need more people taking

[PATCH 3/3] drm/mediatek: drm_ddp_comp: Add mtk_ddp_is_simple_comp() internal helper

2024-02-01 Thread AngeloGioacchino Del Regno
Move the simple component check to a new mtk_ddp_is_simple_comp() internal helper to reduce code duplication. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 57 +++-- 1 file changed, 31 insertions(+), 26 deletions(-) diff --git a/dri

[PATCH 1/3] drm/mediatek: drm_ddp_comp: Fix and cleanup DDP component CRTC search

2024-02-01 Thread AngeloGioacchino Del Regno
Finding a possible CRTC by DDP component is done by first checking static routes in three paths (main, external, third/extra path) and then, if not found, we check for dynamic connection on a per-route basis because, for example, on some SoCs the main route may output to either a DSI display or Dis

[PATCH 2/3] drm/mediatek: Perform iounmap on simple DDP component destruction

2024-02-01 Thread AngeloGioacchino Del Regno
Add a new mtk_ddp_comp_destroy() function and call it in the teardown path of mtk_drm_drv to make sure that we unmap the iospace of the simple DDP components. While at it, also fix iounmapping on mtk_ddp_comp_init() error path. Fixes: ff1395609e20 ("drm/mediatek: Move mtk_ddp_comp_init() from sub

[PATCH 0/3] drm/mediatek: Fixes for DDP component search/destroy

2024-02-01 Thread AngeloGioacchino Del Regno
This series performs some cleanups for DDP component CRTC search and correctly iounmaps the previously of_iomap() calls from drm_ddp_comp. Tested on MT8195 Cherry Tomato AngeloGioacchino Del Regno (3): drm/mediatek: drm_ddp_comp: Fix and cleanup DDP component CRTC search drm/mediatek: Perform

Re: [PATCH 09/10] drm/xe: switch from drm_debug_printer() to device specific drm_dbg_printer()

2024-02-01 Thread Jani Nikula
On Tue, 16 Jan 2024, Jani Nikula wrote: > Prefer the device specific debug printer. > > Signed-off-by: Jani Nikula Xe maintainers, ack for merging this via drm-misc along with the rest of the series? BR, Jani. > --- > drivers/gpu/drm/xe/xe_gt.c | 2 +- > drivers/gpu/drm/xe/xe_gt_topo

Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-01 Thread Maxime Ripard
On Thu, Dec 14, 2023 at 03:10:43PM +, Dave Stevenson wrote: > > +static bool > > +sink_supports_format_bpc(const struct drm_connector *connector, > > +const struct drm_display_info *info, > > +const struct drm_display_mode *mode, > > +

Re: [PATCH 00/10] drm: drm debug and error logging improvements

2024-02-01 Thread Jani Nikula
On Tue, 16 Jan 2024, Jani Nikula wrote: > This is resend and more patches on top of [1]. I don't think I've > changed anything since then. Hi drm-misc maintainers - I've got R-b from Luca, but given there's no comments outside of Intel, are you okay with me merging this to drm-misc? BR, Jani.

Re: [PATCH rc] drm/tegra: Do not assume that a NULL domain means no DMA IOMMU

2024-02-01 Thread Joerg Roedel
On Tue, Jan 30, 2024 at 12:14:54PM -0400, Jason Gunthorpe wrote: > Previously with tegra-smmu, even with CONFIG_IOMMU_DMA, the default domain > could have been left as NULL. The NULL domain is specially recognized by > host1x_client_iommu_attach() as meaning it is not the DMA domain and > should be

[PATCH] drm/imagination: Fix an IS_ERR vs NULL bug in pvr_context_create()

2024-02-01 Thread Dan Carpenter
The pvr_vm_context_lookup() function returns NULL on error (not error pointers). Update the check accordingly. Fixes: d2d79d29bb98 ("drm/imagination: Implement context creation/destruction ioctls") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/imagination/pvr_context.c | 4 ++-- 1 file chan

Re: [PATCH v5 0/4] Kinetic ExpressWire library and KTD2801 backlight driver

2024-02-01 Thread Lee Jones
On Thu, 25 Jan 2024 16:30:52 +0100, Duje Mihanović wrote: > This series adds support for the Kinetic KTD2801 LED backlight driver > IC found in samsung,coreprimevelte. > > Support is already upstream for the somewhat similar KTD2692 flash > driver, and this series since v3 also moves its ExpressWi

Re: [PULL] drm-xe-fixes

2024-02-01 Thread Thomas Hellström
On Thu, 2024-02-01 at 12:37 +0100, Thomas Hellstrom wrote: > Hi Dave and Sima, > > The xe fixes for 6.8-rc2. > Should ofc be 6.8-rc3. /Thomas

[PULL] drm-xe-fixes

2024-02-01 Thread Thomas Hellstrom
Hi Dave and Sima, The xe fixes for 6.8-rc2. drm-xe-fixes-2024-02-01: UAPI Changes: - Only allow a single user-fence per exec / bind. The reason for this clarification fix is a limitation in the implementation which can be lifted moving forward, if needed. Driver Changes: - A crash fix - A fi

Re: [PATCH] drm/imagination: On device loss, handle unplug after critical section

2024-02-01 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 05:22:26PM +, Matt Coster wrote: > On 25/01/2024 18:44, Daniel Vetter wrote: > > On Tue, Jan 23, 2024 at 01:04:24PM +, Matt Coster wrote: > >> From: Donald Robson > >> > >> When the kernel driver 'loses' the device, for instance if the firmware > >> stops communicat

Re: [PATCH 00/23] [RFC] drm/format-helper: Introduce drm_pixmap, font support and filling

2024-02-01 Thread Jocelyn Falempe
Hi Thomas, Thanks for taking the time to write this series. I find the drm_pixmap is a nice improvement, and simplifies a bit the code. Regarding the font blit, I'm not convinced by this approach. I don't see the benefit of using the same function between fonts and framebuffer copy, as it's un

Re: [PATCH v4 00/17] Support IGT in display driver

2024-02-01 Thread AngeloGioacchino Del Regno
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: This series is based on mediatek-drm-next. This series adds support for running IGT (Intel GPU Tool) tests with MediaTek display driver. The following changes will be applied: 1. Add a new API for creating GCE thread loop to retrieve CRCs from

Re: [PATCH] drm/modes: Replace deprecated simple_strtol with kstrtol

2024-02-01 Thread Jani Nikula
On Thu, 01 Feb 2024, Cong Liu wrote: > This patch replaces the use of the deprecated simple_strtol [1] function > in the drm_modes.c file with the recommended kstrtol function. This change > improves error handling and boundary checks. > > [1] > https://www.kernel.org/doc/html/latest/process/depr

Re: [PATCH] fbdev/sh_mobile_lcdcfb: Replace deprecated simple_strtol with kstrtol

2024-02-01 Thread Jani Nikula
On Thu, 01 Feb 2024, Cong Liu wrote: > This patch replaces the use of the deprecated simple_strtol [1] function > in the sh_mobile_lcdcfb.c file with the recommended kstrtol function. > This change improves error handling and boundary checks. > > [1] > https://www.kernel.org/doc/html/latest/proce

Re: [PATCH] fbdev/core: Replace deprecated simple_strtol with kstrtol

2024-02-01 Thread Jani Nikula
On Thu, 01 Feb 2024, Cong Liu wrote: > This patch replaces the use of the deprecated simple_strtol [1] function > in the modedb.c file with the recommended kstrtol function. This change > improves error handling and boundary checks. > > [1] > https://www.kernel.org/doc/html/latest/process/depreca

[PULL] drm-misc-fixes

2024-02-01 Thread Maxime Ripard
Hi! Here's this week drm-misc-fixes PR Maxime drm-misc-fixes-2024-02-01: A quiet week: one fix for CMA dma-buf pages accounting, and one to virtio to set the segment size of the virtio_gpu device. The following changes since commit 27d19268cf394f2c78db732be0cb31852eeadb0a: accel/ivpu: Improve

Re: [PATCH v3] drm: Check output polling initialized before disabling

2024-02-01 Thread Shradha Gupta
On Mon, Jan 22, 2024 at 02:49:59AM -0800, Shradha Gupta wrote: > Hi all, > to me it seems like the patch has uncovered a genuine warning in > drm_helper_probe_single_connector_modes() function. > Before calling drm_kms_helper_poll_enable() there should be check to see if > mode_config.poll_enabl

Re: [PATCH 2/6] drm/nouveau/svm: remove unused but set variables

2024-02-01 Thread Jani Nikula
On Wed, 31 Jan 2024, Danilo Krummrich wrote: > On 1/10/24 18:39, Jani Nikula wrote: >> Fix the W=1 warning -Wunused-but-set-variable. >> >> Cc: Karol Herbst >> Cc: Lyude Paul >> Cc: Danilo Krummrich >> Cc: nouv...@lists.freedesktop.org >> Signed-off-by: Jani Nikula > > Reviewed-by: Danilo Kru

Re: [PATCH 1/6] drm/nouveau/acr/ga102: remove unused but set variable

2024-02-01 Thread Jani Nikula
On Wed, 31 Jan 2024, Danilo Krummrich wrote: > On 1/10/24 18:39, Jani Nikula wrote: >> Fix the W=1 warning -Wunused-but-set-variable. >> >> Cc: Karol Herbst >> Cc: Lyude Paul >> Cc: Danilo Krummrich >> Cc: nouv...@lists.freedesktop.org >> Signed-off-by: Jani Nikula > > Reviewed-by: Danilo Kru

Re: [PATCH] drm/i915/display: Include debugfs.h in intel_display_debugfs_params.c

2024-02-01 Thread Jani Nikula
On Wed, 31 Jan 2024, Paz Zcharya wrote: > Commit 8015bee0bfec ("drm/i915/display: Add framework to add parameters > specific to display") added the file intel_display_debugfs_params.c, > which calls the functions "debugfs_create_{bool, ulong, str}" -- all of > which are defined in . The missing in

Re: [PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible

2024-02-01 Thread Dharma.B
On 01/02/24 1:09 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 01/02/2024 05:10, dharm...@microchip.com wrote: >> On 31/01/24 12:42 am, Rob Herring wrote: >>> EXTERNAL EMAIL: Do not click links or open attachme

Re: Making drm_gpuvm work across gpu devices

2024-02-01 Thread Christian König
Hi Oak, Am 31.01.24 um 21:17 schrieb Zeng, Oak: Hi Sima, Dave, I am well aware nouveau driver is not what Nvidia do with their customer. The key argument is, can we move forward with the concept shared virtual address space b/t CPU and GPU? This is the foundation of HMM. We already have split

Re: [PATCH v3 14/24] of: property: add of_graph_get_next_endpoint()

2024-02-01 Thread Kuninori Morimoto
Hi Luca Thank you for your review > > To handle endpoint more intuitive, create of_graph_get_next_endpoint() > > > > of_graph_get_next_endpoint(port1, NULL); // A1 > > of_graph_get_next_endpoint(port1, A1); // A2 > > of_graph_get_next_endpoint(port1, A2); // NULL > > The idea

Re: [PATCH v3 02/24] of: property: use unsigned int return on of_graph_get_endpoint_count()

2024-02-01 Thread Kuninori Morimoto
Hi Dmitry Thank you for your review > > The return type and the variable of of_graph_get_endpoint_count() > > should be unsigned. Tidyup it. > > 'the variable'? > > I'd have added a few words telling that return type can be unsigned > because there is no error reporting for this function. I

Re: [PATCH 1/1] fbdev/hyperv_fb: Fix logic error for Gen2 VMs in hvfb_getmem()

2024-02-01 Thread Thomas Zimmermann
Hi Am 01.02.24 um 07:00 schrieb mhkelle...@gmail.com: From: Michael Kelley A recent commit removing the use of screen_info introduced a logic error. The error causes hvfb_getmem() to always return -ENOMEM for Generation 2 VMs. As a result, the Hyper-V frame buffer device fails to initialize. T