Re: [PATCH 4/4] drm: xlnx: zynqmp_dpsub: Set live video in format

2024-01-31 Thread Tomi Valkeinen
On 19/01/2024 07:54, Klymenko, Anatoliy wrote: diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h index f92a006d5070..926e07c255bb 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h +++ b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h @@ -165,10 +165,10 @@

Re: Flaky tests for vkms

2024-01-31 Thread Vignesh Raman
Hi Maintainers, vkms test patch (https://lore.kernel.org/dri-devel/20240201065346.801038-1-vignesh.ra...@collabora.com/) was retested with latest drm-misc-next and xfails have been updated, Pipeline url: https://gitlab.freedesktop.org/vigneshraman/linux/-/jobs/54431093 https://gitlab.freedesk

Re: [PATCH v3 4/5] drm: xlnx: zynqmp_dpsub: Filter interrupts against mask

2024-01-31 Thread Tomi Valkeinen
On 24/01/2024 04:54, Anatoliy Klymenko wrote: Filter out status register against the interrupts' mask. Some events are being reported via DP status register, even if corresponding interrupts have been disabled. One instance of such event leads to generation of VBLANK when the driver is in DRM br

Re: [PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible

2024-01-31 Thread Krzysztof Kozlowski
On 01/02/2024 05:10, dharm...@microchip.com wrote: > On 31/01/24 12:42 am, Rob Herring wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On Tue, Jan 23, 2024 at 03:39:13AM +, dharm...@microchip.com wrote: >>> Hi Conor, >>> >>> On 22/0

Re: [PATCH v3 3/5] drm: xlnx: zynqmp_dpsub: Clear status register ASAP

2024-01-31 Thread Tomi Valkeinen
On 24/01/2024 04:54, Anatoliy Klymenko wrote: Clear status register as soon as we read it. Addressing comments from https://lore.kernel.org/dri-devel/beb551c7-bb7e-4cd0-b166-e9aad90c4...@ideasonboard.com/ Signed-off-by: Anatoliy Klymenko --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 4 ++-- 1 file

[PATCH] drm/modes: Replace deprecated simple_strtol with kstrtol

2024-01-31 Thread Cong Liu
This patch replaces the use of the deprecated simple_strtol [1] function in the drm_modes.c file with the recommended kstrtol function. This change improves error handling and boundary checks. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-s

[PATCH] fbdev/core: Replace deprecated simple_strtol with kstrtol

2024-01-31 Thread Cong Liu
This patch replaces the use of the deprecated simple_strtol [1] function in the modedb.c file with the recommended kstrtol function. This change improves error handling and boundary checks. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strt

[PATCH] fbdev/sh_mobile_lcdcfb: Replace deprecated simple_strtol with kstrtol

2024-01-31 Thread Cong Liu
This patch replaces the use of the deprecated simple_strtol [1] function in the sh_mobile_lcdcfb.c file with the recommended kstrtol function. This change improves error handling and boundary checks. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-s

[PATCH v4] drm/ci: add tests on vkms

2024-01-31 Thread Vignesh Raman
Add job that runs igt on top of vkms. Signed-off-by: Vignesh Raman Acked-by: Jessica Zhang Tested-by: Jessica Zhang Acked-by: Maxime Ripard Signed-off-by: Helen Koike --- v2: - do not mv modules to /lib/modules in the job definition, leave it to crosvm-runner.sh v3: - Enable CONFIG_DRM_VK

[PATCH 1/1] fbdev/hyperv_fb: Fix logic error for Gen2 VMs in hvfb_getmem()

2024-01-31 Thread mhkelley58
From: Michael Kelley A recent commit removing the use of screen_info introduced a logic error. The error causes hvfb_getmem() to always return -ENOMEM for Generation 2 VMs. As a result, the Hyper-V frame buffer device fails to initialize. The error was introduced by removing an "else if" clause,

Re: [PATCH 11/17] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-01-31 Thread Dmitry Baryshkov
On Thu, 1 Feb 2024 at 03:56, Abhinav Kumar wrote: > > > > On 1/27/2024 9:39 PM, Dmitry Baryshkov wrote: > > On Sun, 28 Jan 2024 at 07:34, Paloma Arellano > > wrote: > >> > >> > >> On 1/25/2024 1:48 PM, Dmitry Baryshkov wrote: > >>> On 25/01/2024 21:38, Paloma Arellano wrote: > Add support t

Re: [PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible

2024-01-31 Thread Dharma.B
On 31/01/24 12:42 am, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Jan 23, 2024 at 03:39:13AM +, dharm...@microchip.com wrote: >> Hi Conor, >> >> On 22/01/24 10:07 pm, Conor Dooley wrote: >>> On Mon, Jan 22, 2024

Re: [linux][PATCH v5 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

2024-01-31 Thread Dharma.B
Hi Rob, On 31/01/24 9:05 am, Dharma B - I70843 wrote: > Converted the text bindings to YAML and validated them individually using > following commands > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ > $ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindi

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-31 Thread Dmitry Baryshkov
On Thu, 1 Feb 2024 at 03:30, Abhinav Kumar wrote: > > > > On 1/29/2024 3:44 PM, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 09:08, Abhinav Kumar > > wrote: > >> > >> On 1/28/2024 10:12 PM, Dmitry Baryshkov wrote: > >>> On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar > >>> wrote: > > >>

Re: [PATCH 11/17] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-01-31 Thread Abhinav Kumar
On 1/27/2024 9:39 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:34, Paloma Arellano wrote: On 1/25/2024 1:48 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of fo

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-31 Thread Abhinav Kumar
On 1/29/2024 3:44 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 09:08, Abhinav Kumar wrote: On 1/28/2024 10:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar wrote: On 1/28/2024 7:42 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 04:58, Abhinav Kumar

Re: [PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Abhinav Kumar
On 1/31/2024 5:05 PM, Dmitry Baryshkov wrote: On Thu, 1 Feb 2024 at 02:48, Abhinav Kumar wrote: Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement of widebus but this is incorrect because we should be enabling this bit independent of widebus except for cases where compression i

Re: [PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Dmitry Baryshkov
On Thu, 1 Feb 2024 at 02:48, Abhinav Kumar wrote: > > Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement > of widebus but this is incorrect because we should be enabling > this bit independent of widebus except for cases where compression > is enabled in one pixel per clock mode. > >

[PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Abhinav Kumar
Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement of widebus but this is incorrect because we should be enabling this bit independent of widebus except for cases where compression is enabled in one pixel per clock mode. Fix this by making the condition checks more explicit and enabli

Re: [PATCH v4 3/7] dma-buf: heaps: restricted_heap: Add private heap ops

2024-01-31 Thread John Stultz
On Wed, Jan 31, 2024 at 6:15 AM Joakim Bech wrote: > On Fri, Jan 12, 2024 at 05:23:07PM -0800, John Stultz wrote: > > So we need some clarity in what "restricted" really means. For > > instance, it being not cpu mappable vs other potential variations like > > being cpu mappable, but not cpu acces

Re: [PATCH] drm/i915/gt: Restart the heartbeat timer when forcing a pulse

2024-01-31 Thread John Harrison
On 1/31/2024 10:48, Janusz Krzysztofik wrote: Hi John, On Wednesday, 10 January 2024 22:02:16 CET john.c.harri...@intel.com wrote: From: John Harrison The context persistence code does things like send super high priority heartbeat pulses to ensure any leaked context can still be pre-empted a

[PATCH v2 6/6] arm64: dts: rockchip: fix rk3399 hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk3399 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/

[PATCH v2 5/6] arm64: dts: rockchip: fix rk3328 hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk3328 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/ar

[PATCH v2 4/6] ARM: dts: rockchip: fix rk322x hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk322x hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg --- arch/arm/boot/dts/rockchip/rk322x.dtsi | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/arc

[PATCH v2 3/6] ARM: dts: rockchip: fix rk3288 hdmi ports node

2024-01-31 Thread Johan Jonker
Fix rk3288 hdmi ports node so that it matches the rockchip,dw-hdmi.yaml binding with some reordering to align with the (new) documentation about property ordering. Signed-off-by: Johan Jonker --- Changed V2: keep reg-io-width together with reg reword --- arch/arm/boot/dts/rockchip/rk3288.dt

[PATCH v2 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-31 Thread Johan Jonker
Most Rockchip hdmi nodes are part of a power domain. Add a power-domains property and include it to the example with some reordering to align with the (new) documentation about property ordering. Signed-off-by: Johan Jonker Acked-by: Conor Dooley --- Changed V2: keep reg-io-width together wit

[PATCH v2 1/6] dt-bindings: display: rockchip: rockchip,dw-hdmi: remove port property

2024-01-31 Thread Johan Jonker
The hdmi-connector nodes are now functional and the new way to model hdmi ports nodes with both in and output port subnodes. Unfortunately with the conversion to YAML the old method with only an input port node was used. Later the new method was also added to the binding. A binding must be unambigu

Re: Future handling of complex RGB devices on Linux

2024-01-31 Thread Roderick Colenbrander
On Wed, Jan 31, 2024 at 3:42 AM Werner Sembach wrote: > > Hi, > > so I combined Hans last draft, with the discussion since then and the comments > from the OpenRGB maintainers from here > https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916 and my own experience > and came up witrh this rough

RE: Making drm_gpuvm work across gpu devices

2024-01-31 Thread Zeng, Oak
Fixed one typo: GPU VA != GPU VA should be GPU VA can != CPU VA > -Original Message- > From: Zeng, Oak > Sent: Wednesday, January 31, 2024 3:17 PM > To: Daniel Vetter ; David Airlie > Cc: Christian König ; Thomas Hellström > ; Brost, Matthew > ; Felix Kuehling ; Welty, > Brian ; dri-devel

[PATCH] drm/i915/display: Include debugfs.h in intel_display_debugfs_params.c

2024-01-31 Thread Paz Zcharya
Commit 8015bee0bfec ("drm/i915/display: Add framework to add parameters specific to display") added the file intel_display_debugfs_params.c, which calls the functions "debugfs_create_{bool, ulong, str}" -- all of which are defined in . The missing inclusion of this header file is breaking the Chrom

RE: Making drm_gpuvm work across gpu devices

2024-01-31 Thread Zeng, Oak
Hi Sima, Dave, I am well aware nouveau driver is not what Nvidia do with their customer. The key argument is, can we move forward with the concept shared virtual address space b/t CPU and GPU? This is the foundation of HMM. We already have split address space support with other driver API. SVM,

Re: [PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Helge Deller
On 1/31/24 17:08, Geert Uytterhoeven wrote: Since commit f402f7a02af6956d ("staging: board: Remove Armadillo-800-EVA board staging code"), there are no more users of the legacy SuperH Mobile LCDC framebuffer driver on Renesas ARM platforms. All former users on these platforms have been converted

Re: [PATCH 2/6] drm/nouveau/svm: remove unused but set variables

2024-01-31 Thread Danilo Krummrich
On 1/10/24 18:39, Jani Nikula wrote: Fix the W=1 warning -Wunused-but-set-variable. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula Reviewed-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_svm.c | 10 +++---

Re: [PATCH 1/6] drm/nouveau/acr/ga102: remove unused but set variable

2024-01-31 Thread Danilo Krummrich
On 1/10/24 18:39, Jani Nikula wrote: Fix the W=1 warning -Wunused-but-set-variable. Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Cc: nouv...@lists.freedesktop.org Signed-off-by: Jani Nikula Reviewed-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Imre Deak
On Wed, Jan 31, 2024 at 06:09:04PM +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > > Add support for Display Port DP tunneling. For now this includes the > > support for Bandwidth Allocation Mode, leaving adding Panel Replay > > support for later. > > > >

Re: [PATCH] drm/i915/gt: Restart the heartbeat timer when forcing a pulse

2024-01-31 Thread Janusz Krzysztofik
Hi John, On Wednesday, 10 January 2024 22:02:16 CET john.c.harri...@intel.com wrote: > From: John Harrison > > The context persistence code does things like send super high priority > heartbeat pulses to ensure any leaked context can still be pre-empted > and thus isn't a total denial of service

Re: [PATCH v3 1/2] drm/buddy: Implement tracking clear page feature

2024-01-31 Thread Matthew Auld
On 30/01/2024 20:30, Arunpravin Paneer Selvam wrote: Hi Matthew, On 12/21/2023 12:51 AM, Matthew Auld wrote: Hi, On 14/12/2023 13:42, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it    successfully clears the blocks i

Re: [PATCH v5 1/3] drm/buddy: Implement tracking clear page feature

2024-01-31 Thread Matthew Auld
On 30/01/2024 19:48, Arunpravin Paneer Selvam wrote: - Add tracking clear page feature. - Driver should enable the DRM_BUDDY_CLEARED flag if it successfully clears the blocks in the free path. On the otherhand, DRM buddy marks each block as cleared. - Track the available cleared pages siz

Re: [PATCH] drm/imagination: On device loss, handle unplug after critical section

2024-01-31 Thread Matt Coster
On 25/01/2024 18:44, Daniel Vetter wrote: > On Tue, Jan 23, 2024 at 01:04:24PM +, Matt Coster wrote: >> From: Donald Robson >> >> When the kernel driver 'loses' the device, for instance if the firmware >> stops communicating, the driver calls drm_dev_unplug(). This is >> currently done inside

Re: [PATCH] drm/sched: Add Matthew Brost to maintainers

2024-01-31 Thread Daniel Vetter
On Tue, Jan 30, 2024 at 07:03:02PM -0800, Matthew Brost wrote: > Add Matthew Brost to DRM scheduler maintainers. > > Cc: Luben Tuikov > Cc: Daniel Vetter > Cc: Dave Airlie > Cc: Christian König > Signed-off-by: Matthew Brost Definitely need more people taking care of drm/sched, so thanks for

Re: [linux][PATCH v5 2/3] dt-bindings: atmel,hlcdc: convert pwm bindings to json-schema

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 09:05:22AM +0530, Dharma Balasubiramani wrote: > Convert device tree bindings for Atmel's HLCDC PWM controller to YAML > format. > > Signed-off-by: Dharma Balasubiramani > Reviewed-by: Conor Dooley Same comment about the examples here FWIW. > +examples: > + - | > +

Re: [PATCH 4/5] drm/msm/dp: Try looking for link-frequencies into the port@0's endpoint first

2024-01-31 Thread Dmitry Baryshkov
On Wed, 31 Jan 2024 at 19:04, Abel Vesa wrote: > > On 24-01-29 17:08:29, Dmitry Baryshkov wrote: > > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > > > From: Abhinav Kumar > > > > > > On platforms where the endpoint used is on port@0, looking for port@1 > > > instead results in just igno

Re: [PATCH 4/5] drm/msm/dp: Try looking for link-frequencies into the port@0's endpoint first

2024-01-31 Thread Abel Vesa
On 24-01-29 17:08:29, Dmitry Baryshkov wrote: > On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: > > > > From: Abhinav Kumar > > > > On platforms where the endpoint used is on port@0, looking for port@1 > > instead results in just ignoring the max link-frequencies altogether. > > Look at port@0 fir

Re: [linux][PATCH v5 1/3] dt-bindings: display: convert Atmel's HLCDC to DT schema

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 09:05:21AM +0530, Dharma Balasubiramani wrote: > Convert the existing DT binding to DT schema of the Atmel's HLCDC display > controller. I feel like I recall a request to only have a complete example in the mfd binding but nowhere else. Otherwise, Reviewed-by: Conor Dooley

Re: [PATCH 18/19] drm/i915/dp: Suspend/resume DP tunnels

2024-01-31 Thread Imre Deak
On Wed, Jan 31, 2024 at 06:18:22PM +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 12:28:49PM +0200, Imre Deak wrote: > > Suspend and resume DP tunnels during system suspend/resume, disabling > > the BW allocation mode during suspend, re-enabling it after resume. This > > reflects the link's

Re: [linux][PATCH v5 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 09:05:23AM +0530, Dharma Balasubiramani wrote: > Convert the atmel,hlcdc binding to DT schema format. > > Align clocks and clock-names properties to clearly indicate that the LCD > controller expects lvds_pll_clk when interfaced with the lvds display. This > alignment with

Re: [PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Wolfram Sang
On Wed, Jan 31, 2024 at 05:08:23PM +0100, Geert Uytterhoeven wrote: > Since commit f402f7a02af6956d ("staging: board: Remove Armadillo-800-EVA > board staging code"), there are no more users of the legacy SuperH > Mobile LCDC framebuffer driver on Renesas ARM platforms. All former > users on these

dri-devel@lists.freedesktop.org

2024-01-31 Thread Maxime Ripard
On Wed, Jan 31, 2024 at 08:57:21AM +, Keith Zhao wrote: > > > +static const struct vs_dc_info dc8200_info = { > > > + .name = "DC8200", > > > + .panel_num = 2, > > > + .plane_num = 8, > > > + .planes = dc_hw_planes_rev0, > > > + .layer

Re: [PATCH 18/19] drm/i915/dp: Suspend/resume DP tunnels

2024-01-31 Thread Ville Syrjälä
On Tue, Jan 23, 2024 at 12:28:49PM +0200, Imre Deak wrote: > Suspend and resume DP tunnels during system suspend/resume, disabling > the BW allocation mode during suspend, re-enabling it after resume. This > reflects the link's BW management component (Thunderbolt CM) disabling > BWA during suspend

Re: [PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert, > Since commit f402f7a02af6956d ("staging: board: Remove Armadillo-800-EVA > board staging code"), there are no more users of the legacy SuperH > Mobile LCDC framebuffer driver on Renesas ARM platforms. All former > users on these platforms have been conv

RE: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()

2024-01-31 Thread Flavio Suligoi
Hi Sean, I've just tested your change on my board that uses the mp3309c. All ok, thanks! ... > Subject: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep() > > pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: > Rename > pwm_apply_state() to pwm_apply_might_sleep()"). This i

[PATCH] fbdev: Restrict FB_SH_MOBILE_LCDC to SuperH

2024-01-31 Thread Geert Uytterhoeven
Since commit f402f7a02af6956d ("staging: board: Remove Armadillo-800-EVA board staging code"), there are no more users of the legacy SuperH Mobile LCDC framebuffer driver on Renesas ARM platforms. All former users on these platforms have been converted to the SH-Mobile DRM driver, using DT. Sugge

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Ville Syrjälä
On Tue, Jan 23, 2024 at 12:28:33PM +0200, Imre Deak wrote: > Add support for Display Port DP tunneling. For now this includes the > support for Bandwidth Allocation Mode, leaving adding Panel Replay > support for later. > > BWA allows using displays that share the same (Thunderbolt) link with > th

Re: [drm-drm-misc:drm-misc-next v2] dt-bindings: nt35510: document 'port' property

2024-01-31 Thread Conor Dooley
On Wed, Jan 31, 2024 at 10:28:44AM +0100, Dario Binacchi wrote: > Allow 'port' property (coming from panel-common.yaml) to be used in DTS: > > st/stm32f769-disco-mb1166-reva09.dtb: panel@0: 'port' does not match any of > the regexes: 'pinctrl-[0-9]+' > > Signed-off-by: Dario Binacchi > Cc: Al

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

2024-01-31 Thread Jason Gunthorpe
On Tue, Jan 30, 2024 at 09:55:18PM +, Jon Hunter wrote: > > On 30/01/2024 16:15, Jason Gunthorpe wrote: > > This was added in commit c95469aa5a18 ("gpu: host1x: Set DMA ops on device > > creation") with the note: > > > > Currently host1x-instanciated devices have their dma_ops left to NU

[PATCH v3] drm/msm/gem: Fix double resv lock aquire

2024-01-31 Thread Rob Clark
From: Rob Clark Since commit 79e2cf2e7a19 ("drm/gem: Take reservation lock for vmap/vunmap operations"), the resv lock is already held in the prime vmap path, so don't try to grab it again. v2: This applies to vunmap path as well v3: Fix fixes commit Fixes: 79e2cf2e7a19 ("drm/gem: Take reservat

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-31 Thread Jani Nikula
On Wed, 31 Jan 2024, Lucas De Marchi wrote: > +Jani > > On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: >>intel_power_domains_init has been called twice in xe_device_probe: >>xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) >>xe_device_probe -> xe_display_

Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

2024-01-31 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build warnings: [auto build test WARNING on rafael-pm/linux-next] [also build test WARNING on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131] [cannot apply to drm-misc/drm-misc-next rafael-pm/devprop] [If your patch is applied to the

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-31 Thread Lucas De Marchi
+Jani On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: intel_power_domains_init has been called twice in xe_device_probe: xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq -> inte

Re: [PATCH] backlight: mp3309c: Use pwm_apply_might_sleep()

2024-01-31 Thread Daniel Thompson
On Sun, Jan 28, 2024 at 03:49:04PM +, Sean Young wrote: > pwm_apply_state() is deprecated since commit c748a6d77c06a ("pwm: Rename > pwm_apply_state() to pwm_apply_might_sleep()"). This is the final user > in the tree. > > Signed-off-by: Sean Young Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH] backlight: ktz8866: Correct the check for of_property_read_u32

2024-01-31 Thread Daniel Thompson
On Mon, Jan 29, 2024 at 08:28:29PM +0800, Jianhua Lu wrote: > of_property_read_u32 returns 0 when success, so reverse the > return value to get the true value. > > Fixes: f8449c8f7355 ("backlight: ktz8866: Add support for Kinetic KTZ8866 > backlight") > Signed-off-by: Jianhua Lu Reviewed-by: Dan

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-01-31 Thread Christian König
Am 31.01.24 um 11:20 schrieb Zhang, Julia: On 2024/1/30 22:23, Christian König wrote: Am 30.01.24 um 12:16 schrieb Daniel Vetter: On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: [SNIP] Hi Sima, Christian, Yeah, that is really just speculative. All importers need to set the pe

Re: [PATCH] dma-buf: heaps: Don't track CMA dma-buf pages under RssFile

2024-01-31 Thread Sumit Semwal
Hi TJ, On Thu, 18 Jan 2024 at 15:32, Christian König wrote: > Am 17.01.24 um 19:11 schrieb T.J. Mercier: > > DMA buffers allocated from the CMA dma-buf heap get counted under > RssFile for processes that map them and trigger page faults. In > addition to the incorrect accounting reported to user

Re: [PATCH v4 3/7] dma-buf: heaps: restricted_heap: Add private heap ops

2024-01-31 Thread Joakim Bech
On Fri, Jan 12, 2024 at 05:23:07PM -0800, John Stultz wrote: > On Fri, Jan 12, 2024 at 4:13 PM Jeffrey Kardatzke > wrote: > > On Fri, Jan 12, 2024 at 3:51 PM John Stultz wrote: > > > > > > On Fri, Jan 12, 2024 at 3:27 PM Jeffrey Kardatzke > > > wrote: > > > > On Fri, Jan 12, 2024 at 2:52 PM Jo

Re: [PATCH v1 1/6] dt-bindings: display: rockchip: rockchip, dw-hdmi: deprecate port property

2024-01-31 Thread Rob Herring
On Tue, Jan 30, 2024 at 06:18:49PM +, Conor Dooley wrote: > On Tue, Jan 30, 2024 at 03:55:43PM +0100, Johan Jonker wrote: > > The hdmi-connector nodes are now functional and the new way to model > > hdmi nodes with, so deprecate the port property and > > This doesn't really explain what makes

Re: [PATCH v1 2/6] dt-bindings: display: rockchip,dw-hdmi: add power-domains property

2024-01-31 Thread Rob Herring
On Tue, Jan 30, 2024 at 03:57:23PM +0100, Johan Jonker wrote: > Most Rockchip hdmi nodes are part of a power domain. > Add a power-domains property. Fix example. > > Signed-off-by: Johan Jonker > --- > .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 11 --- > 1 file changed, 8 in

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Imre Deak
On Wed, Jan 31, 2024 at 02:50:16PM +0200, Hogander, Jouni wrote: > [...] > > + > > +struct drm_dp_tunnel_group; > > + > > +struct drm_dp_tunnel { > > + struct drm_dp_tunnel_group *group; > > + > > + struct list_head node; > > + > > + struct kref kref; > > +#ifdef CONFIG_DRM_DISPLA

Re: [PATCH v4 3/7] dma-buf: heaps: restricted_heap: Add private heap ops

2024-01-31 Thread Joakim Bech
On Fri, Jan 12, 2024 at 05:20:10PM +0800, Yong Wu wrote: > Add "struct restricted_heap_ops". For the restricted memory, totally there > are two steps: > a) memory_alloc: Allocate the buffer in kernel; > b) memory_restrict: Restrict/Protect/Secure that buffer. > The memory_alloc is mandatory while m

Re: [PATCH v3 14/24] of: property: add of_graph_get_next_endpoint()

2024-01-31 Thread Luca Ceresoli
Hello Kuninori Morimoto, On Wed, 31 Jan 2024 05:06:36 + Kuninori Morimoto wrote: > To handle endpoint more intuitive, create of_graph_get_next_endpoint() > > of_graph_get_next_endpoint(port1, NULL); // A1 > of_graph_get_next_endpoint(port1, A1); // A2 > of_graph_get_next

Re: [PATCH v4 2/7] dma-buf: heaps: Initialize a restricted heap

2024-01-31 Thread Joakim Bech
On Fri, Jan 12, 2024 at 05:20:09PM +0800, Yong Wu wrote: > Initialize a restricted heap. Currently just add a null heap, Prepare for > the later patches. > > Signed-off-by: Yong Wu > --- > drivers/dma-buf/heaps/Kconfig | 9 > drivers/dma-buf/heaps/Makefile | 3 +- > dri

dri-devel@lists.freedesktop.org

2024-01-31 Thread Maxime Ripard
On Wed, Jan 31, 2024 at 09:33:06AM +, Keith Zhao wrote: > > > > -邮件原件- > > 发件人: Maxime Ripard > > 发送时间: 2023年12月6日 16:56 > > 收件人: Keith Zhao > > 抄送: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org; > > linux-ker...@vger.kernel.org; linux-ri...@lists.infradead.org; > > tz

Re: [PATCH 2/6] drm/nouveau/svm: remove unused but set variables

2024-01-31 Thread Jani Nikula
On Wed, 10 Jan 2024, Jani Nikula wrote: > Fix the W=1 warning -Wunused-but-set-variable. > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: nouv...@lists.freedesktop.org > Signed-off-by: Jani Nikula Ping? > --- > drivers/gpu/drm/nouveau/nouveau_svm.c | 10 +++--- > 1 fil

Re: [PATCH 1/6] drm/nouveau/acr/ga102: remove unused but set variable

2024-01-31 Thread Jani Nikula
On Wed, 10 Jan 2024, Jani Nikula wrote: > Fix the W=1 warning -Wunused-but-set-variable. > > Cc: Karol Herbst > Cc: Lyude Paul > Cc: Danilo Krummrich > Cc: nouv...@lists.freedesktop.org > Signed-off-by: Jani Nikula Ping? > --- > drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- > 1 fi

Re: [PATCH 02/19] drm/dp: Add support for DP tunneling

2024-01-31 Thread Hogander, Jouni
On Tue, 2024-01-23 at 12:28 +0200, Imre Deak wrote: > Add support for Display Port DP tunneling. For now this includes the > support for Bandwidth Allocation Mode, leaving adding Panel Replay > support for later. > > BWA allows using displays that share the same (Thunderbolt) link with > their max

Re: [PATCH 4/6] drm/imx: prefer snprintf over sprintf

2024-01-31 Thread Jani Nikula
On Fri, 12 Jan 2024, Philipp Zabel wrote: > Hi Jani, > > On Mi, 2024-01-10 at 19:39 +0200, Jani Nikula wrote: >> This will trade the W=1 warning -Wformat-overflow to >> -Wformat-truncation. This lets us enable -Wformat-overflow subsystem >> wide. >> >> Cc: Philipp Zabel >> Signed-off-by: Jani Nik

Re: [PATCH 3/6] drm/amdgpu: prefer snprintf over sprintf

2024-01-31 Thread Jani Nikula
On Fri, 12 Jan 2024, Alex Deucher wrote: > On Wed, Jan 10, 2024 at 12:39 PM Jani Nikula wrote: >> >> This will trade the W=1 warning -Wformat-overflow to >> -Wformat-truncation. This lets us enable -Wformat-overflow subsystem >> wide. >> >> Cc: Alex Deucher >> Cc: Christian König >> Cc: Pan, Xi

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2024-01-31 Thread AngeloGioacchino Del Regno
Il 31/01/24 13:25, Jiaxin Yu (俞家鑫) ha scritto: On Wed, 2024-01-31 at 12:42 +0100, AngeloGioacchino Del Regno wrote: Il 03/08/23 21:33, Mark Brown ha scritto: On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote: I agree with you, in fact the speaker is indeed doing this way. But ab

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2024-01-31 Thread 俞家鑫

Re: [v3 2/3] ASoC: mediatek: mt8186: correct the HDMI widgets

2024-01-31 Thread AngeloGioacchino Del Regno
Il 03/08/23 21:33, Mark Brown ha scritto: On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote: I agree with you, in fact the speaker is indeed doing this way. But about the hdmi that on the board, I did not find a defination link snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to repl

Future handling of complex RGB devices on Linux

2024-01-31 Thread Werner Sembach
Hi, so I combined Hans last draft, with the discussion since then and the comments from the OpenRGB maintainers from here https://gitlab.com/CalcProgrammer1/OpenRGB/-/issues/3916 and my own experience and came up witrh this rough updated draft for the new uapi: Future handling of complex RGB

[PATCH v3 3/7] drm/mediatek: dsi: Use bitfield macros where useful

2024-01-31 Thread AngeloGioacchino Del Regno
Instead of open coding bitshifting for various register fields, use the bitfield macro FIELD_PREP(): this allows to enhance the human readability, decrease likeliness of mistakes (and register field overflowing) and also to simplify the code. The latter is especially seen in mtk_dsi_rxtx_control(),

[PATCH v3 6/7] drm/mediatek: dsi: Simplify with dev_err_probe and remove gotos

2024-01-31 Thread AngeloGioacchino Del Regno
Most of the functions that are called in the probe callback are devm managed, or all but mipi_dsi_host_register(): simplify the probe function's error paths with dev_err_probe() and remove the lonely instance of `goto err_unregister_host` by just directly calling the mipi_dsi_host_unregister() func

[PATCH v3 4/7] drm/mediatek: dsi: Replace open-coded instance of HZ_PER_MHZ

2024-01-31 Thread AngeloGioacchino Del Regno
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable, expressed in Hz to retrieve a value in MHz: instead of open-coding, use the HZ_PER_MHZ definition, available in linux/units.h. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++- 1 file ch

[PATCH v3 2/7] drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}()

2024-01-31 Thread AngeloGioacchino Del Regno
Function mtk_dsi_ps_control() is a subset of mtk_dsi_ps_control_vact(): merge the two in one mtk_dsi_ps_control() function by adding one function parameter `config_vact` which, when true, writes the VACT related registers. Reviewed-by: Fei Shao Signed-off-by: AngeloGioacchino Del Regno --- dri

[PATCH v3 1/7] drm/mediatek: dsi: Use GENMASK() for register mask definitions

2024-01-31 Thread AngeloGioacchino Del Regno
Change magic numerical masks with usage of the GENMASK() macro to improve readability. While at it, also fix the DSI_PS_SEL mask to include all bits instead of just a subset of them. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediat

[PATCH v3 5/7] drm/mediatek: dsi: Register DSI host after acquiring clocks and PHY

2024-01-31 Thread AngeloGioacchino Del Regno
Registering the dsi host with its ops before getting dsi->regs is simply wrong: even though there's nothing (for now) asynchronously calling those ops before the end of the probe function, installing ops that are using iospace(s) and clocks before even initializing those is too fragile. Register t

[PATCH v3 7/7] drm/mediatek: dsi: Compress of_device_id entries and add sentinel

2024-01-31 Thread AngeloGioacchino Del Regno
All entries fit in 82 columns, which is acceptable: compress all of the mtk_dsi_of_match[] entries to a single line for each. While at it, also add the usual sentinel comment to the last entry. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_dsi.c | 17 ++

[PATCH v3 0/7] MediaTek DRM - DSI driver cleanups

2024-01-31 Thread AngeloGioacchino Del Regno
Changes in v3: - Rebased over next-20240131 - Added bitfield.h inclusion in patch 3 - Added three more cleanup commits to the mix to simplify the probe function and remove gotos. Changes in v2: - Rebased over next-20231213 This series performs some cleanups for mtk_dsi, enhancing human

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Daniel Vetter
On Wed, Jan 31, 2024 at 12:26:45PM +0200, Dmitry Baryshkov wrote: > On Wed, 31 Jan 2024 at 11:11, Daniel Vetter wrote: > > > > On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > > > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > > > > > > > External email : Please d

Re: [PATCH AUTOSEL 6.1 04/53] drm: Fix color LUT rounding

2024-01-31 Thread Ville Syrjälä
On Tue, Jan 30, 2024 at 06:00:18PM -0500, Sasha Levin wrote: > On Mon, Jan 22, 2024 at 06:50:00PM +0200, Ville Syrjälä wrote: > >On Mon, Jan 22, 2024 at 10:08:05AM -0500, Sasha Levin wrote: > >> From: Ville Syrjälä > >> > >> [ Upstream commit c6fbb6bca10838485b820e8a26c23996f77ce580 ] > > > >Why i

Re: Re: Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread mrip...@kernel.org
Hi, On Wed, Jan 31, 2024 at 05:27:14AM +, Jason-JH Lin (林睿祥) wrote: > > On Sun, 2024-01-28 at 10:24 +0100, Maxime Ripard wrote: > > On Thu, Jan 25, 2024 at 07:17:21PM +0100, Daniel Vetter wrote: > > > On Tue, Jan 23, 2024 at 06:09:05AM +, Jason-JH Lin (林睿祥) wrote: > > > > Hi Maxime, Danie

Re: [PATCH v2 2/4] drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}()

2024-01-31 Thread AngeloGioacchino Del Regno
Il 26/12/23 11:48, Fei Shao ha scritto: Hi Angelo, On Wed, Dec 20, 2023 at 9:57 PM AngeloGioacchino Del Regno wrote: Function mtk_dsi_ps_control() is a subset of mtk_dsi_ps_control_vact(): merge the two in one mtk_dsi_ps_control() function by adding one function parameter `config_vact` which,

Re: [PATCH v2 1/4] drm/mediatek: dsi: Use GENMASK() for register mask definitions

2024-01-31 Thread AngeloGioacchino Del Regno
Il 26/12/23 11:46, Fei Shao ha scritto: Hi Angelo, On Wed, Dec 20, 2023 at 9:57 PM AngeloGioacchino Del Regno wrote: Change magic numerical masks with usage of the GENMASK() macro to improve readability. This commit brings no functional changes. Signed-off-by: AngeloGioacchino Del Regno -

Re: [PATCH v2 2/4] drm: Add drm_get_acpi_edid() helper

2024-01-31 Thread kernel test robot
Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on rafael-pm/linux-next] [also build test ERROR on rafael-pm/acpi-bus linus/master v6.8-rc2 next-20240131] [cannot apply to drm-misc/drm-misc-next rafael-pm/devprop] [If your patch is applied to the wrong git

[PATCHv2 1/2] drm/display/dp: Check for MSTM_CAP before MSTM_CTRL write

2024-01-31 Thread Arun R Murthy
With DP2.1, multistream packetization and the underneth MST protocol will be required for SST. So check for MSTM_CAP to see if MST is really required and skip the MSTM_CTRL write so that we ensure that only the underneth protocol and the multistream packetization will be enabled and sink will not b

[PATCHv2 2/2] drm/i915/display/dp: 128/132b DP-capable with SST

2024-01-31 Thread Arun R Murthy
With a value of '0' read from MSTM_CAP register MST to be enabled. DP2.1 SCR updates the spec for 128/132b DP capable supporting only one stream and not supporting single stream sideband MSG. The underlying protocol will be MST to enable use of MTP. Signed-off-by: Arun R Murthy --- drivers/gpu/d

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2024-01-31 Thread Dmitry Baryshkov
On Wed, 31 Jan 2024 at 11:11, Daniel Vetter wrote: > > On Wed, Jan 31, 2024 at 05:17:08AM +, Jason-JH Lin (林睿祥) wrote: > > On Thu, 2024-01-25 at 19:17 +0100, Daniel Vetter wrote: > > > > > > External email : Please do not click links or open attachments until > > > you have verified the sender

Re: [PATCH v2 1/1] drm/virtio: Implement device_attach

2024-01-31 Thread Zhang, Julia
On 2024/1/30 22:23, Christian König wrote: > Am 30.01.24 um 12:16 schrieb Daniel Vetter: >> On Tue, Jan 30, 2024 at 12:10:31PM +0100, Daniel Vetter wrote: >>> On Mon, Jan 29, 2024 at 06:31:19PM +0800, Julia Zhang wrote: As vram objects don't have backing pages and thus can't implement d

[Bug 218435] UBSAN: array-index-out-of-bounds in radeon_atombios.c:2620:43

2024-01-31 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218435 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Kernel V

Re: [PATCH] drm/msm/gem: Fix double resv lock aquire

2024-01-31 Thread Christian König
Am 30.01.24 um 23:35 schrieb Rob Clark: From: Rob Clark Since commit 56e5abba8c3e ("dma-buf: Add unlocked variant of vmapping functions"), the resv lock is already held in the prime vmap path, so don't try to grab it again. Fixes: 56e5abba8c3e ("dma-buf: Add unlocked variant of vmapping functi

  1   2   >