Re: [PATCH v19 03/30] drm/gem: Document locking rule of vmap and evict callbacks

2024-01-24 Thread Boris Brezillon
On Fri, 5 Jan 2024 21:45:57 +0300 Dmitry Osipenko wrote: > The vmap/vunmap/evict GEM callbacks are always invoked with a held GEM's > reservation lock. Document this locking rule for clarity. > > Signed-off-by: Dmitry Osipenko Reviewed-by: Boris Brezillon > --- > include/drm/drm_gem.h | 9

Re: BUG [RESEND][NEW BUG]: kernel NULL pointer dereference, address: 0000000000000008

2024-01-24 Thread Ma, Jun
Hi Mirsad, On 1/25/2024 1:48 AM, Mirsad Todorovac wrote: > Hi, Ma Jun, > > Normally, I would reply under the quoted text, but I will adjust to your > convention. > > I have just discovered that your patch causes Ubuntu 22.04 LTS GNOME XWayland > session > to block at typing password and ENTER

Re: [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-24 Thread Dharma.B
Hi Conor, On 24/01/24 10:09 pm, Conor Dooley wrote: > On Wed, Jan 24, 2024 at 05:18:26AM +,dharm...@microchip.com wrote: >> Hi Conor & All, >> >> On 22/01/24 2:46 pm, Conor Dooley wrote: >>> On Mon, Jan 22, 2024 at 03:38:41AM +,dharm...@microchip.com wrote: Hi Conor, On 19/01/2

[PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-24 Thread wangxiaoming321
In the call stack xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init Power_domains hasn't been cleaned up if return error, which has do the clean in i915_driver_late_release call from i915_driver_probe. unreferenced object 0x88811150ee00 (size 512): comm "systemd-udevd"

RE: Making drm_gpuvm work across gpu devices

2024-01-24 Thread Zeng, Oak
Hi Dave, Let me step back. When I wrote " shared virtual address space b/t cpu and all gpu devices is a hard requirement for our system allocator design", I meant this is not only Intel's design requirement. Rather this is a common requirement for both Intel, AMD and Nvidia. Take a look at cuda

Re: [syzbot] [dri?] [virtualization?] upstream boot error: INFO: task hung in virtio_gpu_queue_fenced_ctrl_buffer

2024-01-24 Thread Hillf Danton
On Wed, 24 Jan 2024 02:15:21 -0800 > Hello, > > syzbot found the following issue on: > > HEAD commit:615d30064886 Merge tag 'trace-v6.8-rc1' of git://git.kerne.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=167456f7e8 > kernel config: https://syz

RE: Making drm_gpuvm work across gpu devices

2024-01-24 Thread Zeng, Oak
Thank you Felix for sharing. See a few comments inline > -Original Message- > From: Felix Kuehling > Sent: Tuesday, January 23, 2024 3:17 PM > To: Zeng, Oak ; Christian König > ; > Danilo Krummrich ; Dave Airlie ; Daniel > Vetter > Cc: Welty, Brian ; dri-devel@lists.freedesktop.org; >

Re: Making drm_gpuvm work across gpu devices

2024-01-24 Thread David Airlie
> > > For us, Xekmd doesn't need to know it is running under bare metal or > virtualized environment. Xekmd is always a guest driver. All the virtual > address used in xekmd is guest virtual address. For SVM, we require all the > VF devices share one single shared address space with guest CPU pr

RE: Making drm_gpuvm work across gpu devices

2024-01-24 Thread Zeng, Oak
Hi Christian, Even though I mentioned KFD design, I didn’t mean to copy the KFD design. I also had hard time to understand the difficulty of KFD under virtualization environment. For us, Xekmd doesn't need to know it is running under bare metal or virtualized environment. Xekmd is always a gue

Re: linux-next: build warning after merge of the drm tree

2024-01-24 Thread Stephen Rothwell
Hi all, On Fri, 5 Jan 2024 17:47:45 +1100 Stephen Rothwell wrote: > > After merging the drm tree, today's linux-next build (htmldocs) produced > this warning: > > Warning: /sys/devices/.../hwmon/hwmon/curr1_crit is defined 2 times: > Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:35

Re: [PATCH] drm/i915/guc: Remove usage of the deprecated ida_simple_xx() API

2024-01-24 Thread Matthew Brost
On Sun, Jan 14, 2024 at 04:15:34PM +0100, Christophe JAILLET wrote: > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > Note that the upper limit of ida_simple_get() is exclusive, but the one of > ida_alloc_range() is inclusive. So a -

RE: [PATCH 2/3] udmabuf: Sync buffer mappings for attached devices

2024-01-24 Thread Kasireddy, Vivek
Hi Andrew, > Currently this driver creates a SGT table using the CPU as the > target device, then performs the dma_sync operations against > that SGT. This is backwards to how DMA-BUFs are supposed to behave. > This may have worked for the case where these buffers were given > only back to the sam

RE: [PATCH 3/3] udmabuf: Use module_misc_device() to register this device

2024-01-24 Thread Kasireddy, Vivek
Acked-by: Vivek Kasireddy > > Now that we do not need to call dma_coerce_mask_and_coherent() on our > miscdevice device, use the module_misc_device() helper for registering and > module init/exit. > > Signed-off-by: Andrew Davis > --- > drivers/dma-buf/udmabuf.c | 30 +

RE: [PATCH 1/3] udmabuf: Keep track current device mappings

2024-01-24 Thread Kasireddy, Vivek
Hi Andrew, > When a device attaches to and maps our buffer we need to keep track > of this mapping/device. This is needed for synchronization with these > devices when beginning and ending CPU access for instance. Add a list > that tracks device mappings as part of {map,unmap}_udmabuf(). > > Sign

Re: [PATCH v1] drm/msms/dp: fixed link clock divider bits be over written in BPC unknown case

2024-01-24 Thread Abhinav Kumar
On 1/10/2024 12:18 PM, Kuogee Hsieh wrote: Since the value of DP_TEST_BIT_DEPTH_8 is already left shifted, in the BPC unknown case, the additional shift causes spill over to the other bits of the [DP_CONFIGURATION_CTRL] register. Fix this by changing the return value of dp_link_get_test_bits_d

Re: [PATCH] drm/msm/dpu: fix kernel-doc warnings

2024-01-24 Thread Abhinav Kumar
On 12/30/2023 10:08 PM, Randy Dunlap wrote: Correct all kernel-doc warnings in dpu_encoder.c and dpu_rm.c: dpu_encoder.c:212: warning: Excess struct member 'crtc_kickoff_cb' description in 'dpu_encoder_virt' dpu_encoder.c:212: warning: Excess struct member 'crtc_kickoff_cb_data' description

Re: [PATCH] drm/msm/dpu: drop obsolete documentation for dpu_encoder_virt

2024-01-24 Thread Abhinav Kumar
On 12/18/2023 9:57 AM, Abhinav Kumar wrote: On 12/16/2023 4:01 PM, Dmitry Baryshkov wrote: Drop obsolete kerneldoc for several fields in struct dpu_encoder_virt Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312170641.5exlvqqx-...@intel.com/ Fixes: 62d356

Re: linux-next: Tree for Jan 23 (drm/xe/)

2024-01-24 Thread Randy Dunlap
On 1/24/24 01:17, Jani Nikula wrote: > On Tue, 23 Jan 2024, Randy Dunlap wrote: >> On 1/22/24 18:29, Stephen Rothwell wrote: >>> Hi all, >>> >>> News: there will be no linux-next release on Friday >>> >>> Changes since 20240122: >>> >> >> on ARM64, when >> DRM_I915 is not set >> DRM_XE=m >> DEB

RE: [PATCH RESEND] drm/virtio: set segment size for virtio_gpu device

2024-01-24 Thread Kasireddy, Vivek
> Hej, > > debug dma code is not happy with virtio gpu (arm64 VM): > > [ 305.881733] [ cut here ] > [ 305.883117] DMA-API: virtio-pci :07:00.0: mapping sg segment longer > than device claims to support [len=262144] [max=65536] > [ 305.885976] WARNING: CPU: 8 PID: 20

[PATCH] drm/sched: Drain all entities in DRM sched run job worker

2024-01-24 Thread Matthew Brost
All entities must be drained in the DRM scheduler run job worker to avoid the following case. An entity found that is ready, no job found ready on entity, and run job worker goes idle with other entities + jobs ready. Draining all ready entities (i.e. loop over all ready entities) in the run job wo

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-24 Thread Jonathan Cameron
On Mon, 22 Jan 2024 19:23:43 + Jonathan Cameron wrote: > On Mon, 22 Jan 2024 18:18:22 + > Mark Brown wrote: > > > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > > > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > > didn't appear in

Re: [GIT PULL] fbdev fix for v6.8-rc2

2024-01-24 Thread pr-tracker-bot
The pull request you sent on Wed, 24 Jan 2024 17:11:35 +0100: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.8-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1110ebe058268b5425c69a23a99456f2331063bf Thank you! -- Deet

Re: [PATCH v3 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-01-24 Thread Dmitry Baryshkov
On Wed, 24 Jan 2024 at 00:23, Abhinav Kumar wrote: > On 12/25/2023 5:08 AM, Dmitry Baryshkov wrote: > > dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. > > Move corresponding checks to drm_writeback_connector's implementation > > and drop the dpu_encoder_phys_wb_atomic_che

Re: [git pull] drm for 6.8

2024-01-24 Thread Mario Limonciello
On 1/24/2024 11:52, Mario Limonciello wrote: On 1/24/2024 11:51, Thorsten Leemhuis wrote: Linus, if you have a minute, I'd really like to know... On 24.01.24 17:41, Mario Limonciello wrote: On 1/24/2024 10:24, Vlastimil Babka wrote: On 1/24/24 16:31, Donald Carr wrote: On Wed, Jan 24, 2024 at

Re: [git pull] drm for 6.8

2024-01-24 Thread Donald Carr
On Wed, Jan 24, 2024 at 7:31 AM Donald Carr wrote: > I am experiencing the exact same symptoms; sddm (on weston) starts > perfectly, launching a KDE wayland session freezes at various points > (leading to plenty of premature celebration), but normally on the > handoff from sddm to kde (replete wit

Re: [git pull] drm for 6.8

2024-01-24 Thread Donald Carr
On Wed, Jan 24, 2024 at 7:06 AM Vlastimil Babka wrote: > When testing the rc1 on my openSUSE Tumbleweed desktop, I've started > experiencing "frozen desktop" (KDE/Wayland) issues. The symptoms are that > everything freezes including mouse cursor. After a while it either resolves, > or e.g. firefox

Re: [git pull] drm for 6.8

2024-01-24 Thread Mario Limonciello
On 1/24/2024 11:51, Thorsten Leemhuis wrote: Linus, if you have a minute, I'd really like to know... On 24.01.24 17:41, Mario Limonciello wrote: On 1/24/2024 10:24, Vlastimil Babka wrote: On 1/24/24 16:31, Donald Carr wrote: On Wed, Jan 24, 2024 at 7:06 AM Vlastimil Babka wrote: When testin

Re: [git pull] drm for 6.8

2024-01-24 Thread Thorsten Leemhuis
Linus, if you have a minute, I'd really like to know... On 24.01.24 17:41, Mario Limonciello wrote: > On 1/24/2024 10:24, Vlastimil Babka wrote: >> On 1/24/24 16:31, Donald Carr wrote: >>> On Wed, Jan 24, 2024 at 7:06 AM Vlastimil Babka wrote: When testing the rc1 on my openSUSE Tumbleweed d

Re: BUG [RESEND][NEW BUG]: kernel NULL pointer dereference, address: 0000000000000008

2024-01-24 Thread Mirsad Todorovac
Hi, Ma Jun, Normally, I would reply under the quoted text, but I will adjust to your convention. I have just discovered that your patch causes Ubuntu 22.04 LTS GNOME XWayland session to block at typing password and ENTER in the graphical logon screen (tested several times). After that, I was

Re: [PATCH v2 25/33] staging: fbtft: Follow renaming of SPI "master" to "controller"

2024-01-24 Thread Greg Kroah-Hartman
On Mon, Jan 22, 2024 at 07:07:20PM +0100, Uwe Kleine-König wrote: > In commit 8caab75fd2c2 ("spi: Generalize SPI "master" to "controller"") > some functions and struct members were renamed. To not break all drivers > compatibility macros were provided. > > To be able to remove these compatibility

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-24 Thread Greg Kroah-Hartman
On Wed, Jan 24, 2024 at 05:22:00PM +, Mark Brown wrote: > On Wed, Jan 24, 2024 at 09:13:49AM -0800, Greg Kroah-Hartman wrote: > > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > > didn't appear

Re: [PATCH v1 4/4] backlight: hx8357: Utilise temporary variable for struct device

2024-01-24 Thread Daniel Thompson
On Sun, Jan 14, 2024 at 05:25:11PM +0200, Andy Shevchenko wrote: > We have a temporary variable to keep pointer to struct device. > Utilise it inside the ->probe() implementation. > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v1 3/4] backlight: hx8357: Make use of dev_err_probe()

2024-01-24 Thread Daniel Thompson
On Sun, Jan 14, 2024 at 05:25:10PM +0200, Andy Shevchenko wrote: > Simplify the error handling in probe function by switching from > dev_err() to dev_err_probe(). > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-24 Thread Mark Brown
On Wed, Jan 24, 2024 at 09:13:49AM -0800, Greg Kroah-Hartman wrote: > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > didn't appear in a public tree though yet. I still included it here to > > make the

Re: [PATCH v1 2/4] backlight: hx8357: Move OF table closer to its consumer

2024-01-24 Thread Daniel Thompson
On Sun, Jan 14, 2024 at 05:25:09PM +0200, Andy Shevchenko wrote: > Move OF table near to the user. > > While at it, drop comma at terminator entry. > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v1 1/4] backlight: hx8357: Make use of device properties

2024-01-24 Thread Daniel Thompson
On Sun, Jan 14, 2024 at 05:25:08PM +0200, Andy Shevchenko wrote: > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Include mod_devicetable.h explicitly to replace the dropped of.h > which included mod_devicetable.h indirectly. > > Signed-off-by

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

2024-01-24 Thread Greg Kroah-Hartman
On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > Hello, > > this is v2 of this patch set. > > Changes since (implicit) v1, sent with Message-Id: > cover.1705348269.git.u.kleine-koe...@pengutronix.de: > > - Rebase to v6.8-rc1 > - Fix a build failure on sh > - Added the tags

Re: [git pull] drm for 6.8

2024-01-24 Thread Mario Limonciello
On 1/24/2024 10:24, Vlastimil Babka wrote: On 1/24/24 16:31, Donald Carr wrote: On Wed, Jan 24, 2024 at 7:06 AM Vlastimil Babka wrote: When testing the rc1 on my openSUSE Tumbleweed desktop, I've started experiencing "frozen desktop" (KDE/Wayland) issues. The symptoms are that everything freez

Re: [PATCH v4 0/3] Convert Microchip's HLCDC Text based DT bindings to JSON schema

2024-01-24 Thread Conor Dooley
On Wed, Jan 24, 2024 at 03:30:16PM +0530, Dharma Balasubiramani wrote: > Converted the text bindings to YAML and validated them individually using > following commands > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/ > $ make dtbs_check DT_SCHEMA_FILES=Documentation/

Re: [RFC] Revert "drm/sched: Split free_job into own work item"

2024-01-24 Thread Mario Limonciello
On 1/24/2024 10:26, Vlastimil Babka wrote: On 1/23/24 03:11, Mario Limonciello wrote: commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") causes graphics hangs at GDM or right after logging in on a Framework 13 AMD laptop (containing a Phoenix APU). This reverts commit f7fe64ad

Re: [PATCH v3 3/3] dt-bindings: mfd: atmel,hlcdc: Convert to DT schema format

2024-01-24 Thread Conor Dooley
On Wed, Jan 24, 2024 at 05:18:26AM +, dharm...@microchip.com wrote: > Hi Conor & All, > > On 22/01/24 2:46 pm, Conor Dooley wrote: > > On Mon, Jan 22, 2024 at 03:38:41AM +,dharm...@microchip.com wrote: > >> Hi Conor, > >> On 19/01/24 5:33 pm, Conor Dooley - M52691 wrote: > >>> On Fri, Jan

Re: [RFC] Revert "drm/sched: Split free_job into own work item"

2024-01-24 Thread Vlastimil Babka
On 1/23/24 03:11, Mario Limonciello wrote: > commit f7fe64ad0f22 ("drm/sched: Split free_job into own work item") > causes graphics hangs at GDM or right after logging in on a > Framework 13 AMD laptop (containing a Phoenix APU). > > This reverts commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7. >

Re: [git pull] drm for 6.8

2024-01-24 Thread Vlastimil Babka
On 1/24/24 16:31, Donald Carr wrote: > On Wed, Jan 24, 2024 at 7:06 AM Vlastimil Babka wrote: >> When testing the rc1 on my openSUSE Tumbleweed desktop, I've started >> experiencing "frozen desktop" (KDE/Wayland) issues. The symptoms are that >> everything freezes including mouse cursor. After a w

[GIT PULL] fbdev fix for v6.8-rc2

2024-01-24 Thread Helge Deller
Hi Linus, please pull a small patch set with 3 fixes and 2 small cleanups for fbdev for kernel 6.8-rc2: A crash fix in stifb which was missed to be included in the drm-misc tree, two checks to prevent wrong userspace input in sisfb and savagefb and two trivial printk cleanups. Thanks! Helge ---

Re: [PATCH 2/2] drm/etnaviv: Disable SH_EU clock gating on VIPNano-Si+

2024-01-24 Thread Lucas Stach
Am Mittwoch, dem 24.01.2024 um 10:22 +0100 schrieb Philipp Zabel: > Disable SH_EU clock gating for the VIPNano-Si+ NPU on i.MX8MP. > Taken from linux-imx lf-6.1.36-2.1.0, specifically [1]. > > [1] > https://github.com/nxp-imx/linux-imx/blob/lf-6.1.36-2.1.0/drivers/mxc/gpu-viv/hal/kernel/arch/gc_h

Re: [Linaro-mm-sig] [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-24 Thread Paul Cercueil
Hi Andrew, Le mercredi 24 janvier 2024 à 09:38 -0600, Andrew Davis a écrit : > On 1/24/24 4:58 AM, Paul Cercueil wrote: > > Hi Christian, > > > > Le mardi 23 janvier 2024 à 14:28 +0100, Christian König a écrit : > > >   Am 23.01.24 um 14:02 schrieb Paul Cercueil: > > >   > > > > [SNIP] > > > >  

Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-24 Thread Gustavo Sousa
Quoting Yury Norov (2024-01-24 12:27:58-03:00) >On Wed, Jan 24, 2024 at 08:03:53AM -0600, Lucas De Marchi wrote: >> On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: >> > On Tue, 23 Jan 2024, Lucas De Marchi wrote: >> > > From: Yury Norov >> > > >> > > Generalize __GENMASK() to suppor

Re: regression/bisected/6.8 commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7 leads to GPU hang when I open GNOME activities

2024-01-24 Thread Mario Limonciello
On 1/24/2024 08:37, Mikhail Gavrilov wrote: On Wed, Jan 24, 2024 at 7:19 AM Mikhail Gavrilov wrote: Who could dig into it, please? You decided to revert it? https://lkml.org/lkml/2024/1/22/1866 It's not a straight "git revert" on 6.8-rc1 because of some other contextual changes. I poste

Re: [Linaro-mm-sig] [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-24 Thread Andrew Davis
On 1/24/24 4:58 AM, Paul Cercueil wrote: Hi Christian, Le mardi 23 janvier 2024 à 14:28 +0100, Christian König a écrit :  Am 23.01.24 um 14:02 schrieb Paul Cercueil: [SNIP] That an exporter has to call extra functions to access his own buffers is a complete no-go for the desi

Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-24 Thread Yury Norov
On Wed, Jan 24, 2024 at 08:03:53AM -0600, Lucas De Marchi wrote: > On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: > > On Tue, 23 Jan 2024, Lucas De Marchi wrote: > > > From: Yury Norov > > > > > > Generalize __GENMASK() to support different types, and implement > > > fixed-types ve

Re: [git pull] drm for 6.8

2024-01-24 Thread Vlastimil Babka
On 1/10/24 20:49, Dave Airlie wrote: > Hi Linus, > > This is the main drm pull request for 6.8. When testing the rc1 on my openSUSE Tumbleweed desktop, I've started experiencing "frozen desktop" (KDE/Wayland) issues. The symptoms are that everything freezes including mouse cursor. After a while i

Re: Re: [PATCH 3/5] drm/bridge: simple-bridge: Allow acquiring the next bridge with fwnode API

2024-01-24 Thread Maxime Ripard
On Tue, Jan 23, 2024 at 08:18:22PM +0800, Sui Jingfeng wrote: > Hi, > > > On 2024/1/23 09:18, Laurent Pinchart wrote: > > On Tue, Jan 23, 2024 at 12:32:18AM +0800, Sui Jingfeng wrote: > > > Which make it possible to use this driver on non-DT based systems, > > > meanwhile, made no functional chan

Re: [PATCH] drm/Makefile: Move tiny drivers before native drivers

2024-01-24 Thread Huacai Chen
Hi, Thomas, On Wed, Jan 24, 2024 at 5:44 PM Thomas Zimmermann wrote: > > Hi > > Am 24.01.24 um 10:24 schrieb Huacai Chen: > > Hi, Thomas, > > > > On Wed, Jan 24, 2024 at 4:16 PM Thomas Zimmermann > > wrote: > >> > >> Hi > >> > >> Am 24.01.24 um 04:00 schrieb Huacai Chen: > >>> Hi, Javier and Th

Re: regression/bisected/6.8 commit f7fe64ad0f22ff034f8ebcfbd7299ee9cc9b57d7 leads to GPU hang when I open GNOME activities

2024-01-24 Thread Mikhail Gavrilov
On Wed, Jan 24, 2024 at 7:19 AM Mikhail Gavrilov wrote: > > Who could dig into it, please? You decided to revert it? https://lkml.org/lkml/2024/1/22/1866 Also I forgot to attach the kernel build .config in the previous message. I'm going to fix it here. It may be useful for reproducing my bug sc

Re: [PATCH v2 2/2] drm/amdgpu: Implement check_async_props for planes

2024-01-24 Thread André Almeida
Hi Ville, Em 19/01/2024 15:25, Ville Syrjälä escreveu: On Fri, Jan 19, 2024 at 03:12:35PM -0300, André Almeida wrote: AMD GPUs can do async flips with changes on more properties than just the FB ID, so implement a custom check_async_props for AMD planes. Allow amdgpu to do async flips with IN_

Re: Re: [PATCH 1/3] bits: introduce fixed-type genmasks

2024-01-24 Thread Lucas De Marchi
On Wed, Jan 24, 2024 at 09:58:26AM +0200, Jani Nikula wrote: On Tue, 23 Jan 2024, Lucas De Marchi wrote: From: Yury Norov Generalize __GENMASK() to support different types, and implement fixed-types versions of GENMASK() based on it. The fixed-type version allows more strict checks to the min

Re: [PATCH 0/2] drm/etnaviv: Disable SH_EU clock gating on the i.MX8MP NPU

2024-01-24 Thread Christian Gmeiner
h | 20 +++ > drivers/gpu/drm/etnaviv/state_hi.xml.h | 28 + > 6 files changed, 174 insertions(+), 43 deletions(-) > --- > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d > change-id: 20240124-etnaviv-npu-627f6881322c > > Best regards, > -- > Phi

[PATCH v5 3/3] Revert "drm/i915: Wait for active retire before i915_active_fini()"

2024-01-24 Thread Janusz Krzysztofik
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik Cc: Nirmoy Das --- drivers/gpu/drm/i915/i915_vma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_

[PATCH v5 2/3] drm/i915: Remove extra multi-gt pm-references

2024-01-24 Thread Janusz Krzysztofik
There was an attempt to fix an issue of illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle, reported by CI on 2-GT Meteor Lake. As a solution, an extra wakeref for a Primary GT was acquired from i915_gem_do_execbuffer() -- see commit f56fe3e91787 ("drm/i9

[PATCH v5 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-01-24 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915] [161.360082

[PATCH v5 0/3] drm/i915: Fix VMA UAF on destroy against deactivate race

2024-01-24 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GT believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915] [161.360082

Re: [PATCH v2 5/8] drm/lima: handle spurious timeouts due to high irq latency

2024-01-24 Thread Qiang Yu
On Wed, Jan 24, 2024 at 11:00 AM Erico Nunes wrote: > > There are several unexplained and unreproduced cases of rendering > timeouts with lima, for which one theory is high IRQ latency coming from > somewhere else in the system. > This kind of occurrence may cause applications to trigger unnecessa

[PATCH v11 26/26] locking/lockdep, fs/jbd2: Use a weaker annotation in journal handling

2024-01-24 Thread Byungchul Park
jbd2 journal handling code doesn't want any jbd2_might_wait_for_commit() to be between start_this_handle() and stop_this_handle(). So it marks the region with rwsem_acquire_read() and rwsem_release(). However, the annotation is too strong for that purpose. We don't have to use more than try lock a

[PATCH v11 14/26] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread

2024-01-24 Thread Byungchul Park
cb92173d1f0 ("locking/lockdep, cpu/hotplug: Annotate AP thread") was introduced to make lockdep_assert_cpus_held() work in AP thread. However, the annotation is too strong for that purpose. We don't have to use more than try lock annotation for that. Furthermore, now that Dept was introduced, fal

[PATCH v11 19/26] dept: Apply timeout consideration to waitqueue wait

2024-01-24 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to waitqueue wait, assuming an input 'ret' in ___wait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v11 04/26] dept: Add lock dependency tracker APIs

2024-01-24 Thread Byungchul Park
Wrapped the base APIs for easier annotation on typical lock. Signed-off-by: Byungchul Park --- include/linux/dept_ldt.h | 77 1 file changed, 77 insertions(+) create mode 100644 include/linux/dept_ldt.h diff --git a/include/linux/dept_ldt.h b/include/li

[PATCH v11 06/26] dept: Add proc knobs to show stats and dependency graph

2024-01-24 Thread Byungchul Park
It'd be useful to show Dept internal stats and dependency graph on runtime via proc for better information. Introduced the knobs. Signed-off-by: Byungchul Park --- kernel/dependency/Makefile| 1 + kernel/dependency/dept.c | 24 +++- kernel/dependency/dept_internal.h | 26 ++

[PATCH v11 20/26] dept: Apply timeout consideration to hashed-waitqueue wait

2024-01-24 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to hashed-waitqueue wait, assuming an input 'ret' in ___wait_var_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v11 25/26] dept: Print event context requestor's stacktrace on report

2024-01-24 Thread Byungchul Park
Currently, print nothing in place of [S] in report, which means stacktrace of event context's start if the event is not an unlock thing by typical lock but general event because it's not easy to specify the point in a general way, where the event context has started from. However, unfortunately it

[PATCH v11 23/26] dept: Make Dept able to work with an external wgen

2024-01-24 Thread Byungchul Park
There is a case where total maps for its wait/event is so large in size. For instance, struct page for PG_locked and PG_writeback is the case. The additional memory size for the maps would be 'the # of pages * sizeof(struct dept_map)' if each struct page keeps its map all the way, which might be to

[PATCH v11 24/26] dept: Track PG_locked with dept

2024-01-24 Thread Byungchul Park
Makes Dept able to track PG_locked waits and events. It's going to be useful in practice. See the following link that shows dept worked with PG_locked and can detect real issues: https://lore.kernel.org/lkml/1674268856-31807-1-git-send-email-byungchul.p...@lge.com/ Signed-off-by: Byungchul Pa

[PATCH v11 21/26] dept: Apply timeout consideration to dma fence wait

2024-01-24 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to dma fence wait. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c

[PATCH v11 10/26] dept: Apply sdt_might_sleep_{start, end}() to hashed-waitqueue wait

2024-01-24 Thread Byungchul Park
Makes Dept able to track dependencies by hashed-waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait_bit.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait_bit.h b/include/linux/wait_bit.h index 7725b7579b78..fe89282c3e96 100644 --- a/include/linux/wait_

[PATCH v11 22/26] dept: Record the latest one out of consecutive waits of the same class

2024-01-24 Thread Byungchul Park
The current code records all the waits for later use to track relation between waits and events in each context. However, since the same class is handled the same way, it'd be okay to record only one on behalf of the others if they all have the same class. Even though it's the ideal to search the

[PATCH v11 17/26] dept: Apply timeout consideration to wait_for_completion()/complete()

2024-01-24 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 4 ++-- kernel/sched/completion.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/inclu

[PATCH v11 07/26] dept: Apply sdt_might_sleep_{start, end}() to wait_for_completion()/complete()

2024-01-24 Thread Byungchul Park
Makes Dept able to track dependencies by wait_for_completion()/complete(). Signed-off-by: Byungchul Park --- include/linux/completion.h | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/include/linux/completion.h b/include/linux/completion.h inde

[PATCH v11 11/26] dept: Distinguish each syscall context from another

2024-01-24 Thread Byungchul Park
It enters kernel mode on each syscall and each syscall handling should be considered independently from the point of view of Dept. Otherwise, Dept may wrongly track dependencies across different syscalls. That might be a real dependency from user mode. However, now that Dept just started to work,

[PATCH v11 02/26] dept: Implement Dept(Dependency Tracker)

2024-01-24 Thread Byungchul Park
CURRENT STATUS -- Lockdep tracks acquisition order of locks in order to detect deadlock, and IRQ and IRQ enable/disable state as well to take accident acquisitions into account. Lockdep should be turned off once it detects and reports a deadlock since the data structure and algorithm a

[PATCH v11 18/26] dept: Apply timeout consideration to swait

2024-01-24 Thread Byungchul Park
Now that CONFIG_DEPT_AGGRESSIVE_TIMEOUT_WAIT was introduced, apply the consideration to swait, assuming an input 'ret' in ___swait_event() macro is used as a timeout value. Signed-off-by: Byungchul Park --- include/linux/swait.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v11 16/26] dept: Track timeout waits separately with a new Kconfig

2024-01-24 Thread Byungchul Park
Waits with valid timeouts don't actually cause deadlocks. However, Dept has been reporting the cases as well because it's worth informing the circular dependency for some cases where, for example, timeout is used to avoid a deadlock but not meant to be expired. However, yes, there are also a lot o

[PATCH v11 12/26] dept: Distinguish each work from another

2024-01-24 Thread Byungchul Park
Workqueue already provides concurrency control. By that, any wait in a work doesn't prevents events in other works with the control enabled. Thus, each work would better be considered a different context. So let Dept assign a different context id to each work. Signed-off-by: Byungchul Park ---

[PATCH v11 15/26] dept: Apply sdt_might_sleep_{start, end}() to dma fence wait

2024-01-24 Thread Byungchul Park
Makes Dept able to track dma fence waits. Signed-off-by: Byungchul Park --- drivers/dma-buf/dma-fence.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c index 8aa8f8cb7071..76dba11f0dab 100644 --- a/drivers/dma-buf/dma-fence.c +++

[PATCH v11 05/26] dept: Tie to Lockdep and IRQ tracing

2024-01-24 Thread Byungchul Park
How to place Dept this way looks so ugly. But it's inevitable for now. The way should be enhanced gradually. Signed-off-by: Byungchul Park --- include/linux/irqflags.h| 7 +- include/linux/local_lock_internal.h | 1 + include/linux/lockdep.h | 102

[PATCH v11 13/26] dept: Add a mechanism to refill the internal memory pools on running out

2024-01-24 Thread Byungchul Park
Dept engine works in a constrained environment. For example, Dept cannot make use of dynamic allocation e.g. kmalloc(). So Dept has been using static pools to keep memory chunks Dept uses. However, Dept would barely work once any of the pools gets run out. So implemented a mechanism for the refill

[PATCH v11 09/26] dept: Apply sdt_might_sleep_{start, end}() to waitqueue wait

2024-01-24 Thread Byungchul Park
Makes Dept able to track dependencies by waitqueue waits. Signed-off-by: Byungchul Park --- include/linux/wait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/wait.h b/include/linux/wait.h index 3473b663176f..ebeb4678859f 100644 --- a/include/linux/wait.h +++ b/include/lin

[PATCH v11 08/26] dept: Apply sdt_might_sleep_{start,end}() to swait

2024-01-24 Thread Byungchul Park
Makes Dept able to track dependencies by swaits. Signed-off-by: Byungchul Park --- include/linux/swait.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/swait.h b/include/linux/swait.h index d324419482a0..277ac74f61c3 100644 --- a/include/linux/swait.h +++ b/include/linux/sw

[PATCH v11 00/26] DEPT(Dependency Tracker)

2024-01-24 Thread Byungchul Park
>From now on, I can work on LKML again! I'm wondering if DEPT has been helping kernel debugging well even though it's a form of patches yet. I'm happy to see that DEPT reports a real problem in practice. See: https://lore.kernel.org/lkml/6383cde5-cf4b-facf-6e07-1378a4856...@i-love.sakura.ne.j

[PATCH v11 03/26] dept: Add single event dependency tracker APIs

2024-01-24 Thread Byungchul Park
Wrapped the base APIs for easier annotation on wait and event. Start with supporting waiters on each single event. More general support for multiple events is a future work. Do more when the need arises. How to annotate (the simplest way): 1. Initaialize a map for the interesting wait. /*

[PATCH v11 01/26] llist: Move llist_{head, node} definition to types.h

2024-01-24 Thread Byungchul Park
llist_head and llist_node can be used by very primitives. For example, Dept for tracking dependency uses llist things in its header. To avoid header dependency, move those to types.h. Signed-off-by: Byungchul Park --- include/linux/llist.h | 8 include/linux/types.h | 8 2 file

Re: [V2] drm/loongson: Error out if no VRAM detected

2024-01-24 Thread Sui Jingfeng
Hi, On 2024/1/24 18:16, Huacai Chen wrote: If there is no VRAM (it can be true if there is a discreted card, this is probably a hardware configuration issue in BIOS but it is observed in GDC-1401 laptop, L71 laptop and some Loongson-3C5000L based servers), we get such an error and Xorg fails to

[PATCH v4 2/2] drm/imx/dcss: have all init functions use devres

2024-01-24 Thread Philipp Stanner
dcss currently allocates and ioremaps quite a few resources in its probe function's call graph. Devres now provides convenient functions which perform the same task but do the cleanup automatically. Port all memory allocations and ioremap() calls to the devres counterparts. Signed-off-by: Philipp

[PATCH v4 0/2] drm/imx/dcss: implement region request and devres

2024-01-24 Thread Philipp Stanner
@Laurentiu: Thank you very much for the review. I was indeed on an older branch. As Linus's master is currently broken for ARM64 [1], unfortunately, I built it instead against: 60096f0a77600ac2cc92b82fee279d1905576950 Hope that's fine. Changes in v4: - Add Laurentiu's Reviewed-by to patch #1 - R

[PATCH v4 1/2] drm/imx/dcss: request memory region

2024-01-24 Thread Philipp Stanner
The driver's memory regions are currently just ioremap()ed, but not reserved through a request. That's not a bug, but having the request is a little more robust. Implement the region-request through the corresponding managed devres-function. Signed-off-by: Philipp Stanner Reviewed-by: Laurentiu

Re: [PATCH] mm: Remove double faults once write a device pfn

2024-01-24 Thread Alistair Popple
"Zhou, Xianrong" writes: > [AMD Official Use Only - General] > >> > The vmf_insert_pfn_prot could cause unnecessary double faults on a >> > device pfn. Because currently the vmf_insert_pfn_prot does not >> > make the pfn writable so the pte entry is normally read-only or >> > di

Re: [Linaro-mm-sig] [PATCH v5 1/6] dma-buf: Add dma_buf_{begin,end}_access()

2024-01-24 Thread Paul Cercueil
Hi Christian, Le mardi 23 janvier 2024 à 14:28 +0100, Christian König a écrit : >  Am 23.01.24 um 14:02 schrieb Paul Cercueil: >   > > [SNIP] > >   > > >   > > > >    > > > > >   > > > > > That an exporter has to call extra functions to access his > > > > > own > > > > > buffers > > > > > is a com

[PATCH V2] drm/loongson: Error out if no VRAM detected

2024-01-24 Thread Huacai Chen
If there is no VRAM (it can be true if there is a discreted card, this is probably a hardware configuration issue in BIOS but it is observed in GDC-1401 laptop, L71 laptop and some Loongson-3C5000L based servers), we get such an error and Xorg fails to start: [ 136.401131] loongson :00:06.1:

[syzbot] [dri?] [virtualization?] upstream boot error: INFO: task hung in virtio_gpu_queue_fenced_ctrl_buffer

2024-01-24 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:615d30064886 Merge tag 'trace-v6.8-rc1' of git://git.kerne.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=167456f7e8 kernel config: https://syzkaller.appspot.com/x/.config?x=e6c3b3d5f71246cb das

Re: drm/loongson: Error out if no VRAM detected

2024-01-24 Thread Huacai Chen
Hi, Jingfeng, On Sat, Jan 20, 2024 at 12:19 AM Sui JIngfeng wrote: > > Hi, > > Thanks a lot for contribution. > > On 2024/1/19 18:40, Huacai Chen wrote: > > If there is no VRAM (it is true if there is a discreted card), > > > Why the dedicated VRAM is gone whenthere is a discrete card? > > As far

[PATCH v4 3/3] dt-bindings: mfd: atmel, hlcdc: Convert to DT schema format

2024-01-24 Thread Dharma Balasubiramani
Convert the atmel,hlcdc binding to DT schema format. Signed-off-by: Dharma Balasubiramani --- changelog v3 -> v4 - Drop lvds_pll_clk, It can be enabled in lvds driver itself. - Update commit message. Note: Since there is no complexities now, I believe that specifying maxitems in the clocks proper

[PATCH v4 2/3] dt-bindings: atmel, hlcdc: convert pwm bindings to json-schema

2024-01-24 Thread Dharma Balasubiramani
Convert device tree bindings for Atmel's HLCDC PWM controller to YAML format. Signed-off-by: Dharma Balasubiramani Reviewed-by: Conor Dooley --- changelog v3 -> v4 - No changes Note: The clean up patch will be sent later as Sam suggested. v2 -> v3 - Remove '|' in description, as there is no form

  1   2   >