[PATCH v2.1 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen

Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:25, Andi Shyti wrote: > Hi Randy, > > ... > >> /** >> * struct intel_gsc - graphics security controller >> * >> - * @gem_obj: scratch memory GSC operations >> - * @intf : gsc interface >> + * @intf : gsc interface >> + * @intf.adev : MEI aux. device for this @in

Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Randy Dunlap
Hi Andi, On 12/28/23 08:40, Andi Shyti wrote: > Hi Randy, > > [...] > >> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h >> @@ -105,61 +105,67 @@ struct intel_guc { >> */ > > > struct { } interrupts is missing here. > >> struct { >>

[PATCH v4 6/6] x86/vmware: Add TDX hypercall support

2023-12-28 Thread Alexey Makhalov
From: Alexey Makhalov VMware hypercalls use I/O port, VMCALL or VMMCALL instructions. Add __tdx_hypercall path to support TDX guests. No change in high bandwidth hypercalls, as only low bandwidth ones are supported for TDX guests. Co-developed-by: Tim Merrifield Signed-off-by: Tim Merrifield

[PATCH v4 4/6] input/vmmouse: Use VMware hypercall API

2023-12-28 Thread Alexey Makhalov
From: Alexey Makhalov Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. No functional changes intended. Signed-off-by: Alexey Makhalov Reviewed-by: Nadav Amit Reviewed-by: Zack Rusin Acked-by: Dmitry Torokhov --- drivers/input/mouse/vmmouse.c | 76 +++

[PATCH v4 5/6] drm/vmwgfx: Use VMware hypercall API

2023-12-28 Thread Alexey Makhalov
From: Alexey Makhalov Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. drivers/gpu/drm/vmwgfx/vmwgfx_msg_arm64.h: implement arm64 variant of vmware_hypercall. And keep it here until introduction of ARM64 VMWare hypervisor interface. Signed-off-by: Alexey

[PATCH v4 2/6] x86/vmware: Introduce VMware hypercall API

2023-12-28 Thread Alexey Makhalov
From: Alexey Makhalov Introduce vmware_hypercall family of functions. It is a common implementation to be used by the VMware guest code and virtual device drivers in architecture independent manner. The API consists of vmware_hypercallX and vmware_hypercall_hb_{out,in} set of functions by analog

[PATCH v4 1/6] x86/vmware: Move common macros to vmware.h

2023-12-28 Thread Alexey Makhalov
From: Alexey Makhalov Move VMware hypercall macros to vmware.h. This is a prerequisite for the introduction of vmware_hypercall API. No functional changes besides exporting vmware_hypercall_mode symbol. Signed-off-by: Alexey Makhalov Reviewed-by: Nadav Amit --- arch/x86/include/asm/vmware.h |

[PATCH v4 3/6] ptp/vmware: Use VMware hypercall API

2023-12-28 Thread Alexey Makhalov
From: Alexey Makhalov Switch from VMWARE_HYPERCALL macro to vmware_hypercall API. Eliminate arch specific code. No functional changes intended. Signed-off-by: Alexey Makhalov Reviewed-by: Nadav Amit Reviewed-by: Jeff Sipek --- drivers/ptp/ptp_vmw.c | 12 +++- 1 file changed, 3 insert

[PATCH v4 0/6] VMware hypercalls enhancements

2023-12-28 Thread Alexey Makhalov
VMware hypercalls invocations were all spread out across the kernel implementing same ABI as in-place asm-inline. With encrypted memory and confidential computing it became harder to maintain every changes in these hypercall implementations. Intention of this patchset is to introduce arch independ

Re: [PATCH] drm/tilcdc: request and mapp iomem with devres

2023-12-28 Thread jyri . sarha
December 22, 2023 at 1:52 PM, "Philipp Stanner" mailto:pstan...@redhat.com?to=%22Philipp%20Stanner%22%20%3Cpstanner%40redhat.com%3E > wrote: > > tilcdc currently just ioremaps its iomem, without doing the (a bit more > robust) request on the memory first. The devm_ functions provide a handy > wa

Re: [PATCH v2 4/4] arm64: dts: rockchip: Add devicetree for Pine64 Pinetab2

2023-12-28 Thread Jonas Karlman
Hi Manuel, On 2023-12-23 16:20, Manuel Traut wrote: > From: Alexander Warnecke > > This includes support for both the v0.1 units that were sent to developers and > the v2.0 units from production. > > v1.0 is not included as no units are known to exist. > > Working/Tested: > - SDMMC > - UART >

Re: [PATCH] drm/debugfs: fix memory leak in drm_debugfs_remove_files()

2023-12-28 Thread Stanislaw Gruszka
On Thu, Dec 28, 2023 at 04:07:40PM +0800, Yaxiong Tian wrote: > From: Yaxiong Tian > > The dentry returned by debugfs_lookup() needs to be released by calling > dput() which is missing in drm_debugfs_remove_files(). Fix this by adding > dput(). > > Signed-off-by: Yaxiong Tian Reviewed-by: Stani

Re: [PATCH v2 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Andi Shyti
Hi Randy, On Tue, Dec 26, 2023 at 11:54:32AM -0800, Randy Dunlap wrote: > Document nested struct members with full names as described in > Documentation/doc-guide/kernel-doc.rst. > > i915_perf_types.h:341: warning: Excess struct member 'ptr_lock' description > in 'i915_perf_stream' > i915_perf_t

Re: [PATCH v2 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Andi Shyti
Hi Randy, [...] > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h > @@ -105,61 +105,67 @@ struct intel_guc { >*/ struct { } interrupts is missing here. > struct { > /** > - * @lock: protects everything in subm

Re: [PATCH v2 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Andi Shyti
Hi Randy, ... > /** > * struct intel_gsc - graphics security controller > * > - * @gem_obj: scratch memory GSC operations > - * @intf : gsc interface > + * @intf : gsc interface > + * @intf.adev : MEI aux. device for this @intf > + * @intf.gem_obj : scratch memory GSC operations > + *

Re: [PATCH v2 1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings

2023-12-28 Thread Andi Shyti
Hi Randy, On Tue, Dec 26, 2023 at 11:54:29AM -0800, Randy Dunlap wrote: > Document nested struct members with full names as described in > Documentation/doc-guide/kernel-doc.rst. > > i915_gem_context_types.h:420: warning: Excess struct member 'lock' > description in 'i915_gem_context' > > Signe

[PULL] drm-intel-fixes

2023-12-28 Thread Jani Nikula
Hi Dave & Sima - A couple of more fixes towards v6.7. drm-intel-fixes-2023-12-28: drm/i915 fixes for v6.7-rc8: - Fix bogus DPCD rev usage for DP phy test pattern setup - Fix handling of MMIO triggered reports in the OA buffer BR, Jani. The following changes since commit 861deac3b092f37b2c5e68

Re: [PATCH 1/3] drm/i915/gt: Support fixed CCS mode

2023-12-28 Thread Andi Shyti
Hi Joonas, > > + /* > > +* Track fixed mapping between CCS engines and compute slices. > > +* > > +* In order to w/a HW that has the inability to dynamically load > > +* balance between CCS engines and EU in the compute slices, we > > have to > > +* r

[PATCH] drm/debugfs: fix memory leak in drm_debugfs_remove_files()

2023-12-28 Thread Yaxiong Tian
From: Yaxiong Tian The dentry returned by debugfs_lookup() needs to be released by calling dput() which is missing in drm_debugfs_remove_files(). Fix this by adding dput(). Signed-off-by: Yaxiong Tian --- drivers/gpu/drm/drm_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

[PATCH] drm: Check output polling initialized before disabling

2023-12-28 Thread Shradha Gupta
In drm_mode_config_helper_suspend() check if output polling support is initialized before enabling/disabling polling. For drivers like hyperv-drm, that do not initialize connector polling, if suspend is called without this check, it leads to suspend failure with following stack [ 770.719392] Free