Re: [PATCH v8 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v8)

2023-12-15 Thread Matthew Wilcox
On Fri, Dec 15, 2023 at 10:05:33PM -0800, Vivek Kasireddy wrote: > +++ b/include/linux/memfd.h > @@ -6,11 +6,16 @@ > > #ifdef CONFIG_MEMFD_CREATE > extern long memfd_fcntl(struct file *file, unsigned int cmd, unsigned int > arg); > +extern struct folio *memfd_alloc_folio(struct file *memfd, pg

[PATCH v8 4/6] udmabuf: Convert udmabuf driver to use folios (v2)

2023-12-15 Thread Vivek Kasireddy
This is mainly a preparatory patch to use memfd_pin_folios() API for pinning folios. Using folios instead of pages makes sense as the udmabuf driver needs to handle both shmem and hugetlb cases. However, the function vmap_udmabuf() still needs a list of pages; so, we collect all the head pages into

[PATCH v8 3/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v8)

2023-12-15 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the folios associated with a memfd, the memfd_pin_folios() API provides an option to not only pin the folios via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with memfds but it should wo

[PATCH v8 5/6] udmabuf: Pin the pages using memfd_pin_folios() API (v6)

2023-12-15 Thread Vivek Kasireddy
Using memfd_pin_folios() will ensure that the pages are pinned correctly using FOLL_PIN. And, this also ensures that we don't accidentally break features such as memory hotunplug as it would not allow pinning pages in the movable zone. Using this new API also simplifies the code as we no longer ha

[PATCH v8 6/6] selftests/dma-buf/udmabuf: Add tests to verify data after page migration

2023-12-15 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful completion

[PATCH v8 2/6] udmabuf: Add back support for mapping hugetlb pages (v6)

2023-12-15 Thread Vivek Kasireddy
A user or admin can configure a VMM (Qemu) Guest's memory to be backed by hugetlb pages for various reasons. However, a Guest OS would still allocate (and pin) buffers that are backed by regular 4k sized pages. In order to map these buffers and create dma-bufs for them on the Host, we first need to

[PATCH v8 0/6] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios (v8)

2023-12-15 Thread Vivek Kasireddy
The first two patches were previously reviewed but not yet merged. These ones need to be merged first as the fourth patch depends on the changes introduced in them and they also fix bugs seen in very specific scenarios (running Qemu with hugetlb=on, blob=true and rebooting guest VM). The third pat

[PATCH v8 1/6] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2023-12-15 Thread Vivek Kasireddy
Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel V

Re: [v5, 02/16] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume"

2023-12-15 Thread Andy Yan
+ Mark Hi Marek andy Mark: On 12/15/23 16:33, Andy Yan wrote: Hi Marek: On 12/15/23 08:59, Andy Yan wrote: Hi Marek:    Sorry for this issue.    I also tested this series on RK3568/6 before I send them out. But I didn't find anyahing unusal, would you please share the linux kernel defconfig y

[Bug 218274] AMD r9 m380, 2015,27 imac - amdgpu wont work

2023-12-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218274 --- Comment #1 from Pukurasa (pukur...@gmail.com) --- Kernel 6.6 and up, havn`t used anything earlier than that -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[Bug 218274] New: AMD r9 m380, 2015,27 imac - amdgpu wont work

2023-12-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=218274 Bug ID: 218274 Summary: AMD r9 m380, 2015,27 imac - amdgpu wont work Product: Drivers Version: 2.5 Hardware: All OS: Linux Status: NEW Severity: high

Re: [PATCH 3/4] drm/ttm: improve idle/busy handling

2023-12-15 Thread kernel test robot
Hi Christian, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.7-rc5 next-20231215] [If your patch is applied to the

[PATCH] drm/vmwgfx: fix kernel-doc Excess struct member 'base'

2023-12-15 Thread Randy Dunlap
Fix a new kernel-doc warning reported by kernel test robot: vmwgfx_surface.c:55: warning: Excess struct member 'base' description in 'vmw_user_surface' The other warning is not correct: it is confused by "__counted_by". Kees has made a separate patch for that. In -Wall mode, kernel-doc still re

[PATCH] drm/vmwgfx: fix all kernel-doc warnings in stdu

2023-12-15 Thread Randy Dunlap
kernel test robot reports one kernel-doc warning in stdu, but running scripts/kernel-doc in -Wall mode reports several more, so fix all of them at one time: vmwgfx_stdu.c:76: warning: Excess struct member 'transfer' description in 'vmw_stdu_dirty' vmwgfx_stdu.c:103: warning: missing initial short

[PULL] drm-xe-next

2023-12-15 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes the first pull request for the drm/xe driver. Our team was focused on putting together a driver that uses most, if not all, of the key drm concepts and has a functional display that is shared with i915. All the platforms are still protected by the force_probe protectio

Re: (subset) [PATCH v5 00/16] Add VOP2 support on rk3588

2023-12-15 Thread Heiko Stuebner
On Mon, 11 Dec 2023 19:55:47 +0800, Andy Yan wrote: > From: Andy Yan > > This patch sets aims at enable the VOP2 support on rk3588. > > Main feature of VOP2 on rk3588: > Four video ports: > VP0 Max 4096x2160 > VP1 Max 4096x2160 > VP2 Max 4096x2160 > VP3 Max 2048x1080 > > [...] Applied, thanks!

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Fabio Estevam
On Fri, Dec 15, 2023 at 4:01 PM Adam Ford wrote: > Thanks for the list. I was able to successfully build the stable 6.6 > branch with those patches applied and I have the HDMI working. > Unfortunately, I get build errors on the linux-next, so it's going to > take me a little time to sort through

Re: [git pull] drm fixes for 6.7-rc6

2023-12-15 Thread pr-tracker-bot
The pull request you sent on Fri, 15 Dec 2023 16:42:01 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-12-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/595609b2ad023088dfd0ae74abb4602ea267e739 Thank you! -- Deet-doot-dot, I am a bot. https://k

[pull] amdgpu, amdkfd, radeon, drm drm-next-6.8

2023-12-15 Thread Alex Deucher
Hi Dave, Sima, More stuff for 6.8. The big ones here are a merge of an immutable platform-x86 branch for the WBRF RF interference stuff and the AMD color API (currently disabled behind an ifdef in the driver). The platform-x86 changes are the baseline dependency for the GPU and wifi changes. Th

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Adam Ford
On Fri, Dec 15, 2023 at 10:47 AM Fabio Estevam wrote: > > Hi Adam, > > On Fri, Dec 15, 2023 at 1:40 PM Adam Ford wrote: > > > I started looking into this today, but there appears to be some > > dependencies missing because the PVI is just one small portion of > > this. The PVI needs to interact w

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-15 Thread Uwe Kleine-König
Hello again, On Fri, Dec 15, 2023 at 04:15:47PM +0100, Uwe Kleine-König wrote: > On Fri, Dec 15, 2023 at 01:34:26PM +0100, Maxime Ripard wrote: > > On Wed, Dec 13, 2023 at 04:52:52PM +0100, Uwe Kleine-König wrote: > > > On Wed, Dec 13, 2023 at 12:54:14PM +0100, Maxime Ripard wrote: > > > > On Wed,

Re: [PATCH 6/7] accel/qaic: Leverage DRM managed APIs to release resources

2023-12-15 Thread Jeffrey Hugo
On 12/8/2023 9:34 AM, Jeffrey Hugo wrote: From: Pranjal Ramajor Asha Kanojiya Offload the balancing of init and destroy calls to DRM managed APIs. mutex destroy for ->cntl_mutex is not called during device release and destroy workqueue is not called in error path of create_qdev(). So, use DRM m

Re: [PATCH 0/7] qaic cleanups for 6.8

2023-12-15 Thread Jeffrey Hugo
On 12/8/2023 9:34 AM, Jeffrey Hugo wrote: A set of cleanups to the driver to improve error cases and reduce some code duplication. Jeffrey Hugo (2): accel/qaic: Fix MHI channel struct field order accel/qaic: Order pci_remove() operations in reverse of probe() Pranjal Ramajor Asha Kanojiya

Re: [PATCH 0/2] qaic fixes for 6.7

2023-12-15 Thread Jeffrey Hugo
On 12/8/2023 9:30 AM, Jeffrey Hugo wrote: A pair of fixes to the driver. First one is an improvement to dma_buf handling based on a greater understanding of that framework. The second is a reliability fix that allows some cards to boot. Jeffrey Hugo (1): accel/qaic: Implement quirk for SOC_HW

Re: [PATCH topic/core-for-CI] perf: Fix perf_event_validate_size() lockdep splat

2023-12-15 Thread Rodrigo Vivi
On Fri, Dec 15, 2023 at 08:22:17AM -0800, Lucas De Marchi wrote: > From: Mark Rutland > > When lockdep is enabled, the for_each_sibling_event(sibling, event) > macro checks that event->ctx->mutex is held. When creating a new group > leader event, we call perf_event_validate_size() on a partially

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Fabio Estevam
Hi Adam, On Fri, Dec 15, 2023 at 1:40 PM Adam Ford wrote: > I started looking into this today, but there appears to be some > dependencies missing because the PVI is just one small portion of > this. The PVI needs to interact with the hdmi_blk_ctrl and the hdmi > transmitter itself. > > It looks

Re: [PATCH] drm/virtio: add definition for venus capset

2023-12-15 Thread Dmitry Osipenko
On 11/19/23 06:46, Dmitry Osipenko wrote: > On 9/21/23 00:16, Dmitry Osipenko wrote: >> On 9/15/23 13:59, Huang Rui wrote: >>> This definition is used fro qemu, and qemu imports this marco in the >>> headers to enable venus for virtio gpu. So it should add it even kernel >>> doesn't use this. >>> >

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Adam Ford
On Fri, Dec 15, 2023 at 8:23 AM Laurent Pinchart wrote: > > On Fri, Dec 15, 2023 at 10:31:27AM -0300, Fabio Estevam wrote: > > On Sun, Dec 10, 2023 at 2:35 PM Adam Ford wrote: > > > > > Lucas, > > > > > > It's been a few months since there has been any action. If you want, > > > I can help apply

Re: [PATCH v3 3/3] drm/tests: managed: Add a simple test for drmm_managed_release

2023-12-15 Thread Maxime Ripard
Hi, On Mon, Dec 11, 2023 at 11:09:39PM +0100, Michał Winiarski wrote: > Add a simple test that checks whether the action is indeed called right > away and that it is not called on the final drm_dev_put(). > > Signed-off-by: Michał Winiarski > --- > drivers/gpu/drm/tests/drm_managed_test.c | 29

Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-15 Thread Andy Shevchenko
On Fri, Dec 15, 2023 at 04:11:02PM +, Daniel Thompson wrote: > On Thu, Dec 14, 2023 at 09:51:13PM +0200, Andy Shevchenko wrote: ... > > static int pm3309c_parse_dt_node(struct mp3309c_chip *chip, > > Pretty minor... but I wonder if it should be renamed: > mp3309c_parse_fwnode(). I am fine

[PATCH topic/core-for-CI] perf: Fix perf_event_validate_size() lockdep splat

2023-12-15 Thread Lucas De Marchi
From: Mark Rutland When lockdep is enabled, the for_each_sibling_event(sibling, event) macro checks that event->ctx->mutex is held. When creating a new group leader event, we call perf_event_validate_size() on a partially initialized event where event->ctx is NULL, and so when for_each_sibling_ev

Re: [PATCH v1 2/2] backlight: mp3309c: Utilise temporary variable for struct device

2023-12-15 Thread Daniel Thompson
On Thu, Dec 14, 2023 at 09:51:14PM +0200, Andy Shevchenko wrote: > We have a temporary variable to keep pointer to struct device. > Utilise it where it makes sense. > > Signed-off-by: Andy Shevchenko Reviewed-by: Daniel Thompson Daniel.

Re: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-15 Thread Daniel Thompson
On Thu, Dec 14, 2023 at 09:51:13PM +0200, Andy Shevchenko wrote: > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Add mod_devicetable.h include. > > Signed-off-by: Andy Shevchenko > --- > drivers/video/backlight/mp3309c.c | 38 --

Re: [PATCH] gpu: drm: amd: fixed typos

2023-12-15 Thread Alex Deucher
On Fri, Dec 15, 2023 at 3:40 AM Ghanshyam Agrawal wrote: > > On Fri, Dec 15, 2023 at 10:59 AM Randy Dunlap wrote: > > > > Hi-- > > > > On 12/14/23 21:20, Ghanshyam Agrawal wrote: > > > Fixed multiple typos in atomfirmware.h > > > > > > Signed-off-by: Ghanshyam Agrawal > > > --- > > > drivers/gp

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-15 Thread Uwe Kleine-König
Hello, On Fri, Dec 15, 2023 at 01:34:26PM +0100, Maxime Ripard wrote: > On Wed, Dec 13, 2023 at 04:52:52PM +0100, Uwe Kleine-König wrote: > > On Wed, Dec 13, 2023 at 12:54:14PM +0100, Maxime Ripard wrote: > > > On Wed, Dec 13, 2023 at 12:08:29PM +0100, Uwe Kleine-König wrote: > > > > On Wed, Dec 1

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
> Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > Hi Maxime Ripard, > > > -Original Message- > > From: Maxime Ripard > > Sent: Friday, December 15, 2023 2:18 PM > > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > > > On Fri, Dec 15, 2023 at 01:52

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, December 15, 2023 2:18 PM > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Fri, Dec 15, 2023 at 01:52:28PM +, Biju Das wrote: > > > > > > > > +static int rzg2l_du_crtc_enable_vblank(

Re: [PATCH v2 4/5] drm/atomic: Make the drm_atomic_state documentation less ambiguous

2023-12-15 Thread Pekka Paalanen
On Thu, 14 Dec 2023 11:09:15 +0100 Maxime Ripard wrote: > The current documentation of drm_atomic_state says that it's the "global > state object". This is confusing since, while it does contain all the > objects affected by an update and their respective states, if an object > isn't affected by

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, December 15, 2023 2:23 PM > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Fri, Dec 15, 2023 at 02:19:25PM +, Biju Das wrote: > > Hi Maxime Ripard, > > > > > -Original Message---

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Maxime Ripard
On Fri, Dec 15, 2023 at 01:25:48PM +, Biju Das wrote: > Hi Maxime Ripard, > > > -Original Message- > > From: Maxime Ripard > > Sent: Friday, December 15, 2023 10:24 AM > > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > > > On Thu, Dec 14, 2023 at 03:24:17PM +000

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Maxime Ripard
On Fri, Dec 15, 2023 at 02:19:25PM +, Biju Das wrote: > Hi Maxime Ripard, > > > -Original Message- > > From: Biju Das > > Sent: Friday, December 15, 2023 1:52 PM > > Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > > > Hi Maxime Ripard, > > > > > -Original Mes

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Laurent Pinchart
On Fri, Dec 15, 2023 at 10:31:27AM -0300, Fabio Estevam wrote: > On Sun, Dec 10, 2023 at 2:35 PM Adam Ford wrote: > > > Lucas, > > > > It's been a few months since there has been any action. If you want, > > I can help apply the suggestions that Laurent has and re-submit with > > both of our name

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Biju Das > Sent: Friday, December 15, 2023 1:52 PM > Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > Hi Maxime Ripard, > > > -Original Message- > > From: Maxime Ripard > > Sent: Friday, December 15, 2023 12:58 P

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Maxime Ripard
On Fri, Dec 15, 2023 at 01:52:28PM +, Biju Das wrote: > > > > > > > +static int rzg2l_du_crtc_enable_vblank(struct drm_crtc *crtc) { > > > > > > > + struct rzg2l_du_crtc *rcrtc = to_rzg2l_crtc(crtc); > > > > > > > + > > > > > > > + rcrtc->vblank_enable = true; > > > > > > > + > > > > > > > + re

RE: [PATCH v1 2/2] backlight: mp3309c: Utilise temporary variable for struct device

2023-12-15 Thread Flavio Suligoi
> Subject: [PATCH v1 2/2] backlight: mp3309c: Utilise temporary variable > for struct device > > We have a temporary variable to keep pointer to struct device. > Utilise it where it makes sense. > > Signed-off-by: Andy Shevchenko > --- > drivers/video/backlight/mp3309c.c | 38 +-

RE: [PATCH v1 1/2] backlight: mp3309c: Make use of device properties

2023-12-15 Thread Flavio Suligoi
> Subject: [PATCH v1 1/2] backlight: mp3309c: Make use of device > properties > > Convert the module to be property provider agnostic and allow > it to be used on non-OF platforms. > > Add mod_devicetable.h include. > > Signed-off-by: Andy Shevchenko > --- > drivers/video/backlight/mp3309c.c |

Re: [PATCH] drm/bridge: samsung-dsim: check the return value only if necessary

2023-12-15 Thread Robert Foss
On Thu, 7 Dec 2023 17:10:43 +0100, Dario Binacchi wrote: > It was useless to check again the "ret" variable if the function > register_host() was not called. > > Applied, thanks! [1/1] drm/bridge: samsung-dsim: check the return value only if necessary https://cgit.freedesktop.org/drm/drm-

Re: [PATCH v3 0/7] Improve tc358767 regmap usage

2023-12-15 Thread Robert Foss
On Tue, Dec 12, 2023 at 8:53 AM Alexander Stein wrote: > > Hi, > > this series improves the regmap usage by cleaning up current usage as well as > adding more registers to the list of volatile registers. SYSSTAT is added > to the list of precious registers as it is cleared upon read. > This series

Re: [PATCH v3 7/7] drm/bridge: tc358767: Add descriptions to register definitions

2023-12-15 Thread Robert Foss
On Tue, Dec 12, 2023 at 8:53 AM Alexander Stein wrote: > > Use the register names from the datasheet. No functional change intended. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/tc358767.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, December 15, 2023 12:58 PM > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Fri, Dec 15, 2023 at 11:37:07AM +, Biju Das wrote: > > Hi Maxime Ripard, > > > > > -Original Message--

Re: [PATCH v3 6/7] drm/bridge: tc358767: Add precious register SYSSTAT

2023-12-15 Thread Robert Foss
On Tue, Dec 12, 2023 at 8:53 AM Alexander Stein wrote: > > This is the single register which clears its value upon read operation. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/tc358767.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/bri

Re: [PATCH v3 5/7] drm/bridge: tc358767: Add more volatile registers

2023-12-15 Thread Robert Foss
On Tue, Dec 12, 2023 at 8:53 AM Alexander Stein wrote: > > These registers might change their value without any host write operation. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/tc358767.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/bridg

Re: [PATCH v3 4/7] drm/bridge: tc358767: Sort volatile registers according to address

2023-12-15 Thread Robert Foss
On Tue, Dec 12, 2023 at 8:53 AM Alexander Stein wrote: > > Sort the list by the starting address to ease adding new entries. > No functional change intended. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/tc358767.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH v3 3/7] drm/bridge: tc358767: Add more registers to non-writeable range

2023-12-15 Thread Robert Foss
On Tue, Dec 12, 2023 at 8:53 AM Alexander Stein wrote: > > While at it, also add missing register definitions. HDCP registers are > skipped as they are not named, range 0x0980 - 0x09ac. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/tc358767.c | 87

Re: [PATCH v3 2/7] drm/bridge: tc358767: Fix order of register defines

2023-12-15 Thread Robert Foss
On Tue, Dec 12, 2023 at 8:53 AM Alexander Stein wrote: > > 0x0510 is bigger than 0x50c, order them accordingly. > No functional change intended. > > Signed-off-by: Alexander Stein > --- > drivers/gpu/drm/bridge/tc358767.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > >

[PATCH] drm: cleanup for including

2023-12-15 Thread Wang Jinchao
remove duplicated include merge two \#ifdef Signed-off-by: Wang Jinchao --- drivers/gpu/drm/drm_gem_shmem_helper.c | 1 - include/uapi/drm/drm.h | 8 +--- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/d

[PATCH] drm/nouveau/fifo: remove duplicated including

2023-12-15 Thread Wang Jinchao
rm second including of chid.h Signed-off-by: Wang Jinchao --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/chan.c index 87a62d4ff4bd..7d4716dcd512 100

Re: [PATCH 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

2023-12-15 Thread Jan Kiszka
On 31.10.23 14:26, Tomi Valkeinen wrote: > These two patches are needed to make tc358767 work in the > DRM_BRIDGE_ATTACH_NO_CONNECTOR case, at least when using a DP connector. > The first patch, "drm/bridge: tc358767: Support input format negotiation > hook" was already sent separately, but I inclu

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-15 Thread Maxime Ripard
On Thu, Dec 07, 2023 at 11:33:53AM +0100, H. Nikolaus Schaller wrote: > Hi Maxime, > > > Am 07.12.2023 um 10:20 schrieb Maxime Ripard : > > > > On Tue, Dec 05, 2023 at 02:50:08PM +0100, H. Nikolaus Schaller wrote: > >> Hi, > >> > >>> Am 05.12.2023 um 14:29 schrieb Maxime Ripard : > >>> > >>> Hi

Re: [PATCH v3 2/2] drm/bridge: imx: add driver for HDMI TX Parallel Video Interface

2023-12-15 Thread Fabio Estevam
Hi Adam, On Sun, Dec 10, 2023 at 2:35 PM Adam Ford wrote: > Lucas, > > It's been a few months since there has been any action. If you want, > I can help apply the suggestions that Laurent has and re-submit with > both of our names if you want. It would be nice to get this > integrated. It wou

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, December 15, 2023 10:24 AM > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Thu, Dec 14, 2023 at 03:24:17PM +, Biju Das wrote: > > Hi Maxime Ripard, > > > > Thanks for the feedback.

Re: (subset) [PATCH 1/2] drm/imagination: Fix ERR_PTR test on pointer to pointer.

2023-12-15 Thread Maxime Ripard
On Wed, 13 Dec 2023 14:44:30 +, Donald Robson wrote: > drivers/gpu/drm/imagination/pvr_vm.c:631 pvr_vm_create_context() > error: 'vm_ctx->mmu_ctx' dereferencing possible ERR_PTR() > > 612 vm_ctx->mmu_ctx = pvr_mmu_context_create(pvr_dev); > 613 err = PTR_ERR_OR_ZERO(&vm_ctx->

Re: (subset) [PATCH 2/2] drm/imagination: Fix error path in pvr_vm_create_context

2023-12-15 Thread Maxime Ripard
On Wed, 13 Dec 2023 14:44:31 +, Donald Robson wrote: > It is possible to double free the vm_ctx->mmu_ctx object in this > function. > >     630 err_page_table_destroy: > --> 631 pvr_mmu_context_destroy(vm_ctx->mmu_ctx); > > The pvr_vm_context_put() function does: > > [...] Applied t

Re: (subset) [PATCH] drm/imagination: Fixed oops when misusing ioctl CREATE_HWRT_DATASET

2023-12-15 Thread Maxime Ripard
On Fri, 08 Dec 2023 16:30:19 +, Donald Robson wrote: > While writing the matching IGT suite I discovered that it's possible to > cause a kernel oops when using DRM_IOCTL_PVR_CREATE_HWRT_DATASET when > the call to hwrt_init_common_fw_structure() fails. > > Use an unwind-type error path to avoid

Re: (subset) [PATCH] drm/imagination: Fixed infinite loop in pvr_vm_mips_map()

2023-12-15 Thread Maxime Ripard
On Fri, 08 Dec 2023 16:08:25 +, Donald Robson wrote: > Unwinding loop in error path for this function uses unsigned limit > variable, causing the promotion of the signed counter variable. > > --> 204 for (; pfn >= start_pfn; pfn--) > > If start_p

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Maxime Ripard
On Fri, Dec 15, 2023 at 11:37:07AM +, Biju Das wrote: > Hi Maxime Ripard, > > > -Original Message- > > From: Maxime Ripard > > Sent: Friday, December 15, 2023 10:24 AM > > To: Biju Das > > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > > > On Thu, Dec 14, 2023

Re: amdgpu didn't start with pci=nocrs parameter, get error "Fatal error during GPU init"

2023-12-15 Thread Christian König
Am 15.12.23 um 12:45 schrieb Mikhail Gavrilov: On Tue, Feb 28, 2023 at 5:43 PM Christian König wrote: The point is it doesn't need to talk to the amdgpu hardware. What it does is that it talks to the good old VGA/VESA emulation and that just happens to be still enabled by the BIOS/GRUB. And th

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-15 Thread Maxime Ripard
On Wed, Dec 13, 2023 at 04:52:52PM +0100, Uwe Kleine-König wrote: > On Wed, Dec 13, 2023 at 12:54:14PM +0100, Maxime Ripard wrote: > > On Wed, Dec 13, 2023 at 12:08:29PM +0100, Uwe Kleine-König wrote: > > > On Wed, Dec 13, 2023 at 09:36:49AM +0100, Maxime Ripard wrote: > > > > On Wed, Dec 13, 2023

[PULL] drm-intel-gt-next

2023-12-15 Thread Joonas Lahtinen
Hi Dave & Sima, Final drm-intel-gt-next PR for v6.8. Elimination of kmap_atomic() from the driver to allow kernel wide cleanup. One new DG2 W/A and static checker/spelling fixes. Best Regards, Joonas *** drm-intel-gt-next-2023-12-15: Driver Changes: - Eliminate use of kmap_atomic() in i915 (

Re: amdgpu didn't start with pci=nocrs parameter, get error "Fatal error during GPU init"

2023-12-15 Thread Mikhail Gavrilov
On Tue, Feb 28, 2023 at 5:43 PM Christian König wrote: > > The point is it doesn't need to talk to the amdgpu hardware. What it > does is that it talks to the good old VGA/VESA emulation and that just > happens to be still enabled by the BIOS/GRUB. > > And that VGA/VESA emulation doesn't need any

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, December 15, 2023 10:24 AM > To: Biju Das > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Thu, Dec 14, 2023 at 03:24:17PM +, Biju Das wrote: > > Hi Maxime Ripard, > > > > Thanks fo

Re: [PATCH] drm/mm: Allow CONFIG_DRM_MM_DEBUG with DRM=m

2023-12-15 Thread Javier Martinez Canillas
Ville Syrjala writes: Hello Ville, > From: Ville Syrjälä > > The original rationale for > commit cd456f8d06d2 ("drm: Restrict stackdepot usage to builtin drm.ko") > was that depot_save_stack() (which is what we used back then) > wasn't exported. stack_depot_save() (which is what we use now) is

RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Biju Das
Hi Maxime Ripard, > -Original Message- > From: Maxime Ripard > Sent: Friday, December 15, 2023 9:25 AM > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > On Fri, Dec 15, 2023 at 07:47:07AM +, Biju Das wrote: > > Hi Maxime Ripard, > > > > > -Original Message--

[PATCH] drm/mm: Allow CONFIG_DRM_MM_DEBUG with DRM=m

2023-12-15 Thread Ville Syrjala
From: Ville Syrjälä The original rationale for commit cd456f8d06d2 ("drm: Restrict stackdepot usage to builtin drm.ko") was that depot_save_stack() (which is what we used back then) wasn't exported. stack_depot_save() (which is what we use now) is exported however, so relax the dependency allow C

Re: [RFC PATCH] dma-buf: Fix dma reservation with zero fences

2023-12-15 Thread Mika Kuoppala
Christian König writes: > Am 14.12.23 um 13:08 schrieb Mika Kuoppala: >> Driver can initialize without any fences. If so >> roundup_power_of_two will overflow as it will try to >> subtract one from initial value before shift, >> (1 << fls_long(-1)). > > Ah, yes that reminds me that I wanted to ta

Re: [PATCH v3 2/3] drm/tests: managed: Extract device initialization into test init

2023-12-15 Thread Maxime Ripard
On Mon, Dec 11, 2023 at 11:09:38PM +0100, Michał Winiarski wrote: > It simplifies the process of extending the test suite with additional > test cases without unnecessary duplication. > > Signed-off-by: Michał Winiarski > --- > drivers/gpu/drm/tests/drm_managed_test.c | 51 +-

Re: [PATCH v3 1/3] drm/managed: Add drmm_release_action

2023-12-15 Thread Maxime Ripard
On Mon, 11 Dec 2023 23:09:37 +0100, Michał Winiarski wrote: > Similar to devres equivalent, it allows to call the "release" action > directly and remove the resource from the managed resources list. > > Signed-off-by: Michał Winiarski Reviewed-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Maxime Ripard
On Thu, Dec 14, 2023 at 03:24:17PM +, Biju Das wrote: > Hi Maxime Ripard, > > Thanks for the feedback. > > > -Original Message- > > From: Maxime Ripard > > Sent: Wednesday, December 13, 2023 3:47 PM > > To: Biju Das > > Subject: Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Suppor

Re: [Nouveau] Kernel problem with multiseat on one card - Wil be more than one window manager on one card

2023-12-15 Thread Gert Vanhaerents
Op 4/12/2023 om 15:11 schreef Timur Tabi: On Mon, 2023-12-04 at 09:51 +0100, Gert Vanhaerents wrote: OK  i will report it to nvidia. But with the nouveau drivers it's also not working. Are you sure it's not a kernel problem? Because according to systemd it would be a kernel problem.  (personal

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-15 Thread Jerome Brunet
On Wed 13 Dec 2023 at 17:44, Neil Armstrong wrote: > Hi Maxime, > > Le 13/12/2023 à 09:36, Maxime Ripard a écrit : >> Hi, >> On Wed, Dec 13, 2023 at 08:43:00AM +0100, Uwe Kleine-König wrote: >>> On Wed, Dec 13, 2023 at 08:16:04AM +0100, Maxime Ripard wrote: On Tue, Dec 12, 2023 at 06:26:37

[PATCH] drm/tegra: put drm_gem_object ref on error in tegra_fb_create

2023-12-15 Thread Fedor Pchelkin
Inside tegra_fb_create(), drm_gem_object_lookup() increments ref count of the found object. But if the following size check fails then the last found object's ref count should be put there as the unreferencing loop can't detect this situation. Found by Linux Verification Center (linuxtesting.org).

Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page()

2023-12-15 Thread Tvrtko Ursulin
On 14/12/2023 15:04, Zhao Liu wrote: On Thu, Dec 14, 2023 at 02:35:26PM +, Tvrtko Ursulin wrote: Date: Thu, 14 Dec 2023 14:35:26 + From: Tvrtko Ursulin Subject: Re: [PATCH v3 0/9] drm/i915: Replace kmap_atomic() with kmap_local_page() On 14/12/2023 13:45, Tvrtko Ursulin wrote: H

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Maxime Ripard
On Fri, Dec 15, 2023 at 07:47:07AM +, Biju Das wrote: > Hi Maxime Ripard, > > > -Original Message- > > From: Biju Das > > Sent: Thursday, December 14, 2023 8:50 PM > > Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > > > Hi Maxime Ripard, > > > > > > > -Origi

Re: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support

2023-12-15 Thread Maxime Ripard
On Thu, Dec 14, 2023 at 08:50:14PM +, Biju Das wrote: > Hi Maxime Ripard, > > > > -Original Message- > > From: Biju Das > > Sent: Thursday, December 14, 2023 3:24 PM > > Subject: RE: [PATCH v15 3/5] drm: renesas: Add RZ/G2L DU Support > > > > > > > > > + > > > > + for (i = 0; i

RE: [PATCH v2] drm: rcar-du: Fix memory leak in rcar_du_vsps_init()

2023-12-15 Thread Biju Das
Hi All, Gentle ping. > -Original Message- > From: Biju Das > Sent: Thursday, November 16, 2023 12:24 PM > Subject: [PATCH v2] drm: rcar-du: Fix memory leak in rcar_du_vsps_init() > > The rcar_du_vsps_init() doesn't free the np allocated by > of_parse_phandle_with_fixed_args() for the no

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-15 Thread Maxime Ripard
Hi Neil, On Wed, Dec 13, 2023 at 05:44:28PM +0100, Neil Armstrong wrote: > Le 13/12/2023 à 09:36, Maxime Ripard a écrit : > > On Wed, Dec 13, 2023 at 08:43:00AM +0100, Uwe Kleine-König wrote: > > > On Wed, Dec 13, 2023 at 08:16:04AM +0100, Maxime Ripard wrote: > > > > On Tue, Dec 12, 2023 at 06:26

Re: [PATCH 0/5] clk: Make clk_rate_exclusive_get() return void

2023-12-15 Thread Jerome Brunet
On Wed 13 Dec 2023 at 08:16, Maxime Ripard wrote: > [[PGP Signed Part:Undecided]] > Hi, > > On Tue, Dec 12, 2023 at 06:26:37PM +0100, Uwe Kleine-König wrote: >> Hello, >> >> clk_rate_exclusive_get() returns zero unconditionally. Most users "know" >> that and don't check the return value. This

Re: [PATCH] drivers: gpu: drm: vmwgfx: fixed typos

2023-12-15 Thread Ghanshyam Agrawal
On Fri, Dec 15, 2023 at 11:05 AM Randy Dunlap wrote: > > > > On 12/14/23 21:30, Ghanshyam Agrawal wrote: > > Fixed some typos in vmwgfx_execbuf.c > > > > Signed-off-by: Ghanshyam Agrawal > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletion

[PATCH] drivers: gpu: drm: vmwgfx: fixed typos

2023-12-15 Thread Ghanshyam Agrawal
Fixed some typos in vmwgfx_execbuf.c Signed-off-by: Ghanshyam Agrawal --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c index 36987ef3fc30..272141b

[PATCH] gpu: drm: amd: fixed typos

2023-12-15 Thread Ghanshyam Agrawal
Fixed multiple typos in atomfirmware.h Signed-off-by: Ghanshyam Agrawal --- drivers/gpu/drm/amd/include/atomfirmware.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/atomfirmware.h b/drivers/gpu/drm/amd/include/atomfirmware.h index fa7d6c

[PATCH V2] drivers: gpu: drm: vmwgfx: fixed typos

2023-12-15 Thread Ghanshyam Agrawal
Fixed multiple typos in vmwgfx_execbuf.c Signed-off-by: Ghanshyam Agrawal --- V2: Fixed some more typos suggested by codespell and the community. V1: Fixed multiple typos drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH] gpu: drm: amd: fixed typos

2023-12-15 Thread Ghanshyam Agrawal
On Fri, Dec 15, 2023 at 10:59 AM Randy Dunlap wrote: > > Hi-- > > On 12/14/23 21:20, Ghanshyam Agrawal wrote: > > Fixed multiple typos in atomfirmware.h > > > > Signed-off-by: Ghanshyam Agrawal > > --- > > drivers/gpu/drm/amd/include/atomfirmware.h | 8 > > 1 file changed, 4 insertions(

Re: [v5, 02/16] Revert "drm/rockchip: vop2: Use regcache_sync() to fix suspend/resume"

2023-12-15 Thread Andy Yan
Hi Marek: On 12/15/23 08:59, Andy Yan wrote: Hi Marek:   Sorry for this issue.   I also tested this series on RK3568/6 before I send them out. But I didn't find anyahing unusal, would you please share the linux kernel defconfig you used for this test and it would be greatly appreciated if you