Re: [PATCH 3/3] drm/tests: Fix a use-after-free bug in __drm_kunit_helper_alloc_drm_device()

2023-09-19 Thread Arthur Grillo
On 20/09/23 03:40, Maxime Ripard wrote: > Hi, > > On Wed, Sep 20, 2023 at 03:11:38AM -0300, Arthur Grillo wrote: >> In __drm_kunit_helper_alloc_drm_device_with_driver(), a drm_driver is >> allocated with kunit_kzalloc. If the dev argument was allocated by >> drm_kunit_helper_alloc_device, its d

Re: [RESEND PATCH v6 12/20] drm/mediatek: Refine device table of OVL adaptor

2023-09-19 Thread 胡俊光

Re: [PATCH 3/3] drm/tests: Fix a use-after-free bug in __drm_kunit_helper_alloc_drm_device()

2023-09-19 Thread Maxime Ripard
Hi, On Wed, Sep 20, 2023 at 03:11:38AM -0300, Arthur Grillo wrote: > In __drm_kunit_helper_alloc_drm_device_with_driver(), a drm_driver is > allocated with kunit_kzalloc. If the dev argument was allocated by > drm_kunit_helper_alloc_device, its deferred actions would access the > already deallocat

Re: [PATCH 1/3] drm/tests: Fix kunit_release_action ctx argument

2023-09-19 Thread Maxime Ripard
On Wed, 20 Sep 2023 03:11:36 -0300, Arthur Grillo wrote: > The kunit_action_platform_driver_unregister is added with > &fake_platform_driver as ctx, but the kunit_release_action is called > pdev as ctx. Fix that by replacing it with &fake_platform_driver. > > Fixes: 4f2b0b583baa ("drm/tests: helpe

Re: [RESEND PATCH v6 04/20] dt-bindings: display: mediatek: padding: Add MT8188

2023-09-19 Thread 胡俊光

Re: [PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-09-19 Thread Maxime Ripard
Hi, On Tue, Sep 19, 2023 at 03:22:49PM -0300, Helen Koike wrote: > DRM CI keeps track of which tests are failing, flaking or being skipped > by the ci in the expectations files. Add entries for those files to the > corresponding driver maintainer, so they can be notified when they > change. > > S

[PATCH 3/3] drm/tests: Fix a use-after-free bug in __drm_kunit_helper_alloc_drm_device()

2023-09-19 Thread Arthur Grillo
In __drm_kunit_helper_alloc_drm_device_with_driver(), a drm_driver is allocated with kunit_kzalloc. If the dev argument was allocated by drm_kunit_helper_alloc_device, its deferred actions would access the already deallocated drm_driver. To fix that, move the deferred to the top of the resource st

[PATCH 2/3] kunit: Add kunit_move_action_to_top_or_reset() to reorder actions

2023-09-19 Thread Arthur Grillo
On Kunit, if we allocate a resource A and B on this order, with its deferred actions to free them. The resource stack would be something like this: +-+ | free(B) | +-+ | ... | +-+ | free(A) | +-+ If

[PATCH 1/3] drm/tests: Fix kunit_release_action ctx argument

2023-09-19 Thread Arthur Grillo
The kunit_action_platform_driver_unregister is added with &fake_platform_driver as ctx, but the kunit_release_action is called pdev as ctx. Fix that by replacing it with &fake_platform_driver. Fixes: 4f2b0b583baa ("drm/tests: helpers: Switch to kunit actions") Signed-off-by: Arthur Grillo --- dr

[PATCH 0/3] Fix a couble of bugs in drm_kunit_helpers.c

2023-09-19 Thread Arthur Grillo
This patchset started when I found a use-after-free error reported by KASAN while running some tests that did some mocking. When trying to fix the initial problem, I found another noon-related one. The second bug is just a wrong argument passed to a kunit_release_action call. Patch #1 solves that.

Re: [RESEND PATCH v6 03/20] dt-bindings: display: mediatek: merge: Add compatible for MT8188

2023-09-19 Thread 胡俊光

Re: [Intel-gfx] [PATCH] i915: Limit the length of an sg list to the requested length

2023-09-19 Thread Andrzej Hajda
On 19.09.2023 21:48, Matthew Wilcox (Oracle) wrote: The folio conversion changed the behaviour of shmem_sg_alloc_table() to put the entire length of the last folio into the sg list, even if the sg list should have been shorter. gen8_ggtt_insert_entries() relied on the list being the right langth

Re: [RESEND PATCH v6 02/20] dt-bindings: display: mediatek: mdp-rdma: Add compatible for MT8188

2023-09-19 Thread 胡俊光

Re: [RESEND PATCH v6 01/20] dt-bindings: display: mediatek: ethdr: Add compatible for MT8188

2023-09-19 Thread 胡俊光

Re: [PATCH] omap: dsi: do not WARN on detach if dsidev was never attached

2023-09-19 Thread Tony Lindgren
* H. Nikolaus Schaller [230919 13:38]: > dsi_init_output() called by dsi_probe() may fail. In that > case mipi_dsi_host_unregister() is called which may call > omap_dsi_host_detach() with uninitialized dsi->dsidev > because omap_dsi_host_attach() was never called before. > > This happens if the p

Re: [PATCH drm-misc-next v3 6/7] drm/gpuvm: generalize dma_resv/extobj handling and GEM validation

2023-09-19 Thread Christian König
Am 19.09.23 um 17:23 schrieb Thomas Hellström: On 9/19/23 17:16, Danilo Krummrich wrote: On 9/19/23 14:21, Thomas Hellström wrote: Hi Christian On 9/19/23 14:07, Christian König wrote: Am 13.09.23 um 17:46 schrieb Danilo Krummrich: On 9/13/23 17:33, Christian König wrote: Am 13.09.23 um 17

Re: [PATCH 00/10] Add mediate-drm secure flow for SVP

2023-09-19 Thread 胡俊光

[PATCH] drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail

2023-09-19 Thread Ashutosh Dixit
There is no reason to add gtt_offset to the cached head/tail pointers stream->oa_buffer.head and stream->oa_buffer.tail. This causes the code to constantly add gtt_offset and subtract gtt_offset and is error prone. It is much simpler to maintain stream->oa_buffer.head and stream->oa_buffer.tail wi

Re: Decrypting tt maps in ttm

2023-09-19 Thread Zack Rusin
On Tue, 2023-09-19 at 09:47 +0200, Christian König wrote: > !! External Email > > Am 19.09.23 um 08:56 schrieb Thomas Hellström: > > > > On 9/19/23 07:39, Christian König wrote: > > > Am 19.09.23 um 03:26 schrieb Zack Rusin: > > > > On Mon, 2023-09-18 at 16:21 -0400, Alex Deucher wrote: > > > > > !

Re: [PATCH 00/15] Add CMDQ secure driver for SVP

2023-09-19 Thread 胡俊光

Re: [PATCH 0/5] Add the pci_get_base_class() helper and use it

2023-09-19 Thread suijingfeng
Hi, On 2023/8/25 21:18, Deucher, Alexander wrote: [Public] -Original Message- From: amd-gfx On Behalf Of Sui Jingfeng Sent: Friday, August 25, 2023 2:27 AM To: Bjorn Helgaas Cc: alsa-de...@alsa-project.org; Sui Jingfeng ; nouv...@lists.freedesktop.org; linux-ker...@vger.kernel.org;

Re: [PATCH v2 0/4] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
On Thu, 17 Aug 2023 17:59:36 +0300, Dmitry Baryshkov wrote: > Implement DisplayPort support for the Qualcomm RB5 platform. > > Note: while testing this, I had link training issues with several > dongles with DP connectors. Other DisplayPort-USB-C dongles (with HDMI > or VGA connectors) work perf

Re: (subset) [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-09-19 Thread Bjorn Andersson
On Sun, 09 Jul 2023 07:19:21 +0300, Dmitry Baryshkov wrote: > Implement DisplayPort support for the Qualcomm RB5 platform. > > Note: while testing this, I had link training issues with several > dongles with DP connectors. Other DisplayPort-USB-C dongles (with HDMI > or VGA connectors) work perf

Re: [PATCH v2 1/4] arm64: dts: qcom: sm8250: Add DisplayPort device node

2023-09-19 Thread Bjorn Andersson
On Thu, Aug 17, 2023 at 05:59:37PM +0300, Dmitry Baryshkov wrote: > Declare the displayport controller present on the Qualcomm SM8250 SoC. > > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 89 > 1 file changed, 89 insertions(+) > > d

PROBLEM: MT8192 panel_edp_probe trace despite recent eDP and aux-bus support patches

2023-09-19 Thread Leonard Lausen
Dear AngeloGioacchino, Dear Maintainers, on MT8192 Asurada Spherion (Acer 514), I observe the following trace related to eDP and aux-bus during bootup with tags/mediatek-drm-next-6.6 merged to v6.5.4 as well as on plain v6.5.4. Despite the trace, the laptop display works. Given your recent eDP and

[PATCH -next] drm/bridge: clean up some inconsistent indentings

2023-09-19 Thread Yang Li
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:336 dw_hdmi_cec_suspend() warn: inconsistent indenting Signed-off-by: Yang Li --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c

Re: [PATCH 00/10] Add mediate-drm secure flow for SVP

2023-09-19 Thread Jeffrey Kardatzke
On Mon, Sep 18, 2023 at 11:33 PM Daniel Stone wrote: > > Hi Jason, CK, > > On Tue, 19 Sept 2023 at 04:04, Jason-JH.Lin wrote: > > The patch series provides drm driver support for enabling secure video > > path (SVP) playback on MediaiTek hardware in the Linux kernel. > > > > [...] > > > > Memory

[PATCH v6 0/6] Add fdinfo support to Panfrost

2023-09-19 Thread Adrián Larumbe
This patch series adds fdinfo support to the Panfrost DRM driver. It will display a series of key:value pairs under /proc/pid/fdinfo/fd for render processes that open the Panfrost DRM file. The pairs contain basic drm gpu engine and memory region information that can either be cat by a privileged

[PATCH v6 4/6] drm/drm_file: Add DRM obj's RSS reporting function for fdinfo

2023-09-19 Thread Adrián Larumbe
Some BO's might be mapped onto physical memory chunkwise and on demand, like Panfrost's tiler heap. In this case, even though the drm_gem_shmem_object page array might already be allocated, only a very small fraction of the BO is currently backed by system memory, but drm_show_memory_stats will the

[PATCH v6 2/6] drm/panfrost: Add fdinfo support GPU load metrics

2023-09-19 Thread Adrián Larumbe
The drm-stats fdinfo tags made available to user space are drm-engine, drm-cycles, drm-max-freq and drm-curfreq, one per job slot. This deviates from standard practice in other DRM drivers, where a single set of key:value pairs is provided for the whole render engine. However, Panfrost has separat

[PATCH v6 6/6] drm/drm-file: Show finer-grained BO sizes in drm_show_memory_stats

2023-09-19 Thread Adrián Larumbe
The current implementation will try to pick the highest available size display unit as soon as the BO size exceeds that of the previous multiplier. That can lead to loss of precision in contexts of low memory usage. The new selection criteria try to preserve precision, whilst also increasing the d

[PATCH v6 5/6] drm/panfrost: Implement generic DRM object RSS reporting function

2023-09-19 Thread Adrián Larumbe
BO's RSS is updated every time new pages are allocated on demand and mapped for the object at GPU page fault's IRQ handler, but only for heap buffers. The reason this is unnecessary for non-heap buffers is that they are mapped onto the GPU's VA space and backed by physical memory in their entirety

[PATCH v6 1/6] drm/panfrost: Add cycle count GPU register definitions

2023-09-19 Thread Adrián Larumbe
These GPU registers will be used when programming the cycle counter, which we need for providing accurate fdinfo drm-cycles values to user space. Signed-off-by: Adrián Larumbe Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_regs.h | 5 + 1 file

[PATCH v6 3/6] drm/panfrost: Add fdinfo support for memory stats

2023-09-19 Thread Adrián Larumbe
A new DRM GEM object function is added so that drm_show_memory_stats can provide more accurate memory usage numbers. Ideally, in panfrost_gem_status, the BO's purgeable flag would be checked after locking the driver's shrinker mutex, but drm_show_memory_stats takes over the drm file's object handl

Re: (subset) [PATCH v4 00/17] drm/msm: Add SM6125 MDSS/DPU hardware and enable Sony Xperia 10 II panel

2023-09-19 Thread Bjorn Andersson
On Sun, 23 Jul 2023 18:08:38 +0200, Marijn Suijten wrote: > Bring up the SM6125 DPU now that all preliminary series (such as INTF > TE) have been merged (for me to test the hardware properly), and most > other conflicting work (barring ongoing catalog *improvements*) has made > its way in as well

Re: (subset) [PATCH v4 00/11] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-09-19 Thread Bjorn Andersson
On Thu, 27 Jul 2023 10:16:27 -0700, Douglas Anderson wrote: > The big motivation for this patch series is mostly described in the patch > ("drm/panel: Add a way for other devices to follow panel state"), but to > quickly summarize here: for touchscreens that are connected to a panel we > need the

Re: [PATCH] drm: remove drm_bridge_hpd_disable() from drm_bridge_connector_destroy()

2023-09-19 Thread Abhinav Kumar
Hi Laurent On 9/19/2023 11:12 AM, Laurent Pinchart wrote: Hi Abhinav, Thank you for the patch. On Tue, Sep 19, 2023 at 10:48:12AM -0700, Abhinav Kumar wrote: drm_bridge_hpd_enable()/drm_bridge_hpd_disable() callbacks call into the respective driver's hpd_enable()/hpd_disable() ops. These ops

Re: [Nouveau] [PATCH] nouveau/u_memcpya: fix NULL vs error pointer bug

2023-09-19 Thread Danilo Krummrich
On 9/16/23 16:24, Dan Carpenter wrote: On Sat, Sep 16, 2023 at 01:41:43AM +0200, Danilo Krummrich wrote: Hi Dan, On 9/15/23 14:59, Dan Carpenter wrote: The u_memcpya() function is supposed to return error pointers on error. Returning NULL will lead to an Oops. Fixes: 68132cc6d1bc ("nouveau/u

Re: [PATCH 8/9] dt-bindings: reserved-memory: MediaTek: Add reserved memory for SVP

2023-09-19 Thread Jeffrey Kardatzke
On Mon, Sep 18, 2023 at 3:47 AM Yong Wu (吴勇) wrote: > > On Tue, 2023-09-12 at 10:53 -0500, Rob Herring wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Tue, Sep 12, 2023 at 11:13:50AM +0100, Robin Murphy wr

[PATCH v3 44/44] drm/nouveau/kms/nv50-: disable dcb parsing

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - nvkm should provide all this info now - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_bios.c| 8 +--- drivers/gpu/drm/nouveau/nouveau_display.c | 8

[PATCH v3 43/44] drm/nouveau/kms/nv50-: create outputs based on nvkm info

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 97 ++- drivers/gpu/drm/nouveau/dispnv50/disp.h | 2 - drivers/gpu/drm/

[PATCH v3 41/44] drm/nouveau/kms/nv50-: name aux channels after their connector

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - removes use of VBIOS data for naming - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_connector.c | 25 - 1 file changed, 9 insertions(+)

[PATCH v3 39/44] drm/nouveau/kms/nv50-: create heads based on nvkm head mask

2023-09-19 Thread Lyude Paul
From: Ben Skeggs No need to go poking HW directly, and probably shouldn't on GSP-RM. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 18 +++--- 1 file changed, 3 insertions(+), 1

[PATCH v3 38/44] drm/nouveau/disp/nv50-: skip DCB_OUTPUT_TV

2023-09-19 Thread Lyude Paul
From: Ben Skeggs We've never supported it. Signed-off-by: Ben Skeggs Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/nv50.c b

[PATCH v3 40/44] drm/nouveau/kms/nv50-: create heads after outps/conns

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - output info will be used later to determine MST support Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 64 - 1 file changed, 32 insertions(+), 32

[PATCH v3 37/44] drm/nouveau/disp: move outp init/fini paths to chipset code

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - pre-nv5x doesn't use any of this - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- .../gpu/drm/nouveau/nvkm/engine/disp/base.c | 31 +++ .../gpu/drm/nouveau/nvkm/engine/dis

[PATCH v3 36/44] drm/nouveau/disp: move outp/conn construction to chipset code

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - pre-nv5x doesn't use any of this, has its own version DRM-side - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- .../gpu/drm/nouveau/nvkm/engine/disp/base.c | 117 + .../gp

[PATCH v3 35/44] drm/nouveau/disp: add dp mst id get/put methods

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 32 --- drivers/gpu/drm/nouveau/dispnv50/head.h | 1 + drivers/gpu/drm/

[PATCH v3 34/44] drm/nouveau/disp: add dp sst config method

2023-09-19 Thread Lyude Paul
From: Ben Skeggs This is presently unused on HW, we read a bunch of regs and calculate the watermark during the second supervisor interrupt. I don't want to change this yet as I need to re-remember how older HW works exactly, but RM wants this info via RPC. Signed-off-by: Ben Skeggs Reviewed-b

[PATCH v3 29/44] drm/nouveau/kms/nv50-: split DP disable+enable into two modesets

2023-09-19 Thread Lyude Paul
From: Ben Skeggs Link training can finally be moved out of the supervisor sequence, but first we need to split DP modesets into separate disable and enable sequences to be able to perform link training between them instead. - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude

[PATCH v3 33/44] drm/nouveau/disp: move link training out of supervisor

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/include/nvif/if0012.h | 11 ++ drivers/gpu/drm/nouveau/include/nvif/outp.h | 1 + drivers/gpu/drm/nouveau/nouveau

[PATCH v3 32/44] drm/nouveau/disp: add dp train method

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - passes DPCD information from DRM to NVKM - removes NVKM's own sink caps handling - link still trained from supervisor, more patches to come Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/d

[PATCH v3 31/44] drm/nouveau/kms/nv50-: fixup sink D3 before tearing down link

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - fixes bug preventing this on SST - implement for MST Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 13 +++-- drivers/gpu/drm/nouveau/nouveau_dp.c | 15 +++

[PATCH v3 30/44] drm/nouveau/kms/nv50-: flush mst disables together

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - fixes some issues tearing down modes on tiled displays Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 11 +-- drivers/gpu/drm/nouveau/dispnv50/disp.h | 1 - 2 fi

[PATCH v3 28/44] drm/nouveau/disp: add dp rates method

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - moves building of link rates table from NVKM to DRM - preparing to move link training out of supervisor Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/include/nvif/if0012.h | 13 ++ drive

[PATCH v3 27/44] drm/nouveau/disp: add dp aux xfer method

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 32 +-- drivers/gpu/drm/nouveau/include/nvif/if0012.h | 12 +++ drivers/gp

[PATCH v3 26/44] drm/nouveau/disp: move dp aux pwr method to HAL

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/engine/disp/dp.c| 9 + drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.h | 4 drivers/gpu/drm/nou

[PATCH v3 25/44] drm/nouveau/disp: add hdmi audio hal function

2023-09-19 Thread Lyude Paul
From: Ben Skeggs This just adds a hook for RM to use, HW paths remain untouched, but should probably be cleaned up to use this too at some point. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/engine/di

[PATCH v3 24/44] drm/nouveau/disp: add output lvds config method

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - was previously part of acquire() Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 +- drivers/gpu/drm/nouveau/include/nvif/if0012.h| 16 ++-- dr

[PATCH v3 23/44] drm/nouveau/disp: add output backlight control methods

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/include/nvif/if0012.h | 17 drivers/gpu/drm/nouveau/include/nvif/outp.h | 3 + drivers/gpu/drm/nouveau/nouveau

[PATCH v3 14/44] drm/nouveau/disp: update SOR routing immediately on acquire()

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - was previously delayed until second supervisor interrupt Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/engine/disp/outp.c | 2 +- drivers/gpu/drm/nouveau/nvkm/engine/disp/uoutp.c |

[PATCH v3 22/44] drm/nouveau/disp: remove SOR routing updates from supervisor

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - these shouldn't be necessary now, and are done in acquire()/release() - preparation for GSP-RM, where we don't control the supervisor Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/en

[PATCH v3 21/44] drm/nouveau/disp: release outputs post-modeset

2023-09-19 Thread Lyude Paul
From: Ben Skeggs Prior to this commit, KMS would call release() prior to modeset, and the second supervisor interrupt would update SOR routing if needed. Now, KMS will call release() post-modeset and update routing immediately. - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: L

[PATCH v3 18/44] drm/nouveau/kms/nv50-: move audio enable post-modeset

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - adds tracking for post-UPDATE modeset operations, similar to mst[mo]'s - audio won't work on RM without this - we should probably have been doing this anyway Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers

[PATCH v3 20/44] drm/nouveau/disp: move hdmi disable out of release()

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - release() is being moved post-modeset, preserve hdmi behaviour for now Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 8 drivers/gpu/drm/nouveau/nouvea

[PATCH v3 19/44] drm/nouveau/disp: add output hdmi config method

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - was previously part of acquire() - preparation for GSP-RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 ++--- drivers/gpu/drm/nouveau/include/nvif/if0012.h | 2

[PATCH v3 17/44] drm/nouveau/kms/nv50-: keep output state around until modeset complete

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - we'll want this info post-UPDATE for later patches Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --g

[PATCH v3 15/44] drm/nouveau/kms/nv50-: pull some common init out of OR-specific code

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - cleanup before additional changes Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 69 --- drivers/gpu/drm/nouveau/nouveau_encoder.h | 2 + 2 files c

[PATCH v3 16/44] drm/nouveau/kms/nv50-: remove nv_encoder.audio.connector

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - use nv_encoder.conn instead, outp->conn never changes Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 4 +--- drivers/gpu/drm/nouveau/nouveau_encoder.h | 1 - 2 files ch

[PATCH v3 13/44] drm/nouveau/disp: add acquire_sor/pior()

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparing to move protocol-specific args out of acquire() again - avoid re-acquiring acquired output, will matter when enforced later - sor/pior done at same time due to shared tmds/dp handling Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Sig

[PATCH v3 12/44] drm/nouveau/disp: add acquire_dac()

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparing to move protocol-specific args out of acquire() again - avoid re-acquiring acquired output, will matter when enforced later - this one is basically just a rename Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul

[PATCH v3 11/44] drm/nouveau/disp: shuffle to make upcoming diffs prettier

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparing to move protocol-specific args out of acquire() again - no code changes Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvif/outp.c | 106 +- .../gpu/drm

[PATCH v3 09/44] drm/nouveau/disp: rename internal output acquire/release functions

2023-09-19 Thread Lyude Paul
From: Ben Skeggs These will be made static later in the patch series, after the code that uses them has been cleaned up in preparation for GSP-RM support. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/

[PATCH v3 10/44] drm/nouveau/kms: Add INHERIT ioctl to nvkm/nvif for reading IOR state

2023-09-19 Thread Lyude Paul
Now that we're supporting things like Ada and the GSP, there's situations where we really need to actually know the display state that we're starting with when loading the driver in order to prevent breaking GSP expectations. The first step in doing this is making it so that we can read the current

[PATCH v3 07/44] drm/nouveau/disp: add output detect method

2023-09-19 Thread Lyude Paul
From: Ben Skeggs This will check the relevant hotplug pin and skip the DDC probe we currently do if a display is present. - preparation for GSP-RM. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/include/nvi

[PATCH v3 08/44] drm/nouveau/disp: add output method to fetch edid

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - needed to support TMDS EDID on RM Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/include/nvif/if0012.h | 10 +++ drivers/gpu/drm/nouveau/include/nvif/outp.h | 1 + drivers/gpu/drm/n

[PATCH v3 02/44] drm/nouveau/imem: support allocations not preserved across suspend

2023-09-19 Thread Lyude Paul
From: Ben Skeggs Will initially be used to tag some large grctx allocations which don't need to be saved, to speedup suspend/resume. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- .../drm/nouveau/include/nvkm/core/memory.h| 1

[PATCH v3 04/44] drm/nouveau/mmu/gp100-: always invalidate TLBs at CACHE_LEVEL_ALL

2023-09-19 Thread Lyude Paul
From: Ben Skeggs Fixes some issues when running on top of RM. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +- drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmtu102.c | 2 +- 2 fi

[PATCH v3 06/44] drm/nouveau/disp: rearrange output methods

2023-09-19 Thread Lyude Paul
From: Ben Skeggs - preparation for a bunch of API changes, to make diffs prettier Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/include/nvif/if0012.h | 19 +++ .../gpu/drm/nouveau/nvkm/engin

[PATCH v3 05/44] drm/nouveau/kms/nv50-: fix mst payload alloc fail crashing evo

2023-09-19 Thread Lyude Paul
From: Ben Skeggs Programming -1 (vc_start_slot, if alloc fails) into HW probably isn't the best idea. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 10 +++--- 1 file changed, 7 inserti

[PATCH v3 03/44] drm/nouveau/gr/gf100-: lose contents of global ctxbufs across suspend

2023-09-19 Thread Lyude Paul
From: Ben Skeggs Some of these buffers are quite large, and there's no need to preserve them across suspend. Mark the contents as lost to speedup suspend/resume. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouve

[PATCH v3 00/44] drm/nouveau: initial support for GSP-RM 535.54.04 (and Ada GPUs)

2023-09-19 Thread Lyude Paul
Hey everyone! I'm just going through and rebasing Ben's display patches so I can push them in just a moment :). (*the rest of this email can be read in Ben Skegg's voice*) The primary issue being tackled here is that, for historical reasons (we didn't know any better / couldn't make it work relia

[PATCH v3 01/44] drm/nouveau/devinit/tu102-: remove attempt at loading PreOS

2023-09-19 Thread Lyude Paul
From: Ben Skeggs >From Turing, HW will already have handled this and locked-down the falcon before we get control. So this *should* be a no-op. Signed-off-by: Ben Skeggs Reviewed-by: Lyude Paul Acked-by: Danilo Krummrich Signed-off-by: Lyude Paul --- drivers/gpu/drm/nouveau/nvkm/subdev/dev

Re: [PATCH] gpu: drm: amd: display: fix kernel-doc warnings

2023-09-19 Thread Randy Dunlap
Hi, On 9/19/23 02:33, Swarup Laxman Kotiaklapudi wrote: > Fix kernel-doc warnings discovered in AMD gpu display driver. > Fixes these warnings: > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:110: warning: > Function parameter or member 'overlap_only' > not described in 'mpcc_blnd_cfg'. > > ./dri

Re: [PATCH] drm/mst: check connector state before dereference

2023-09-19 Thread Mario Limonciello
On 9/19/2023 15:51, Fangzhi Zuo wrote: We are seeing the crash in the wild that we cannot repro ourselves. We want to be able to gather more data and the code should never be allowed to crash. [8.433306] BUG: kernel NULL pointer dereference, address: 0008 [8.433318] #PF: supe

[PATCH] drm/mst: check connector state before dereference

2023-09-19 Thread Fangzhi Zuo
We are seeing the crash in the wild that we cannot repro ourselves. We want to be able to gather more data and the code should never be allowed to crash. [8.433306] BUG: kernel NULL pointer dereference, address: 0008 [8.433318] #PF: supervisor read access in kernel mode [8.

Re: [PATCH] drm/imx/lcdc: Fix double-free of driver data

2023-09-19 Thread Uwe Kleine-König
Hello, On Thu, Jul 06, 2023 at 11:27:31AM +0200, Uwe Kleine-König wrote: > The struct imx_lcdc driver data is allocated using devm_drm_dev_alloc() > so it must not be explicitly kfree()d. > > Also drm_kms_helper_poll_fini() should not be called as there is no > matching drm_kms_helper_poll_init()

Re: [PATCH 1/2] kunit: Warn if tests are slow

2023-09-19 Thread Rae Moar
On Mon, Sep 11, 2023 at 5:51 AM Maxime Ripard wrote: > > Kunit recently gained support to setup attributes, the first one being > the speed of a given test, then allowing to filter out slow tests. > > A slow test is defined in the documentation as taking more than one > second. There's an another

[PATCH] i915: Limit the length of an sg list to the requested length

2023-09-19 Thread Matthew Wilcox (Oracle)
The folio conversion changed the behaviour of shmem_sg_alloc_table() to put the entire length of the last folio into the sg list, even if the sg list should have been shorter. gen8_ggtt_insert_entries() relied on the list being the right langth and would overrun the end of the page tables. Other f

Re: [REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-19 Thread Matthew Wilcox
On Tue, Sep 19, 2023 at 08:11:47PM +0200, Oleksandr Natalenko wrote: > I can confirm this one fixes the issue for me on T460s laptop. Thank you! Yay! > Should you submit it, please add: > > Fixes: 0b62af28f2 ("i915: convert shmem_sg_free_table() to use a folio_batch") Thanks for collecting all

Re: [PATCH 1/2] video: fbdev: core: cfbcopyarea: fix sloppy typing

2023-09-19 Thread Helge Deller
On 9/19/23 20:55, Sergey Shtylyov wrote: On 9/19/23 10:05 AM, Helge Deller wrote: In cfb_copyarea(), when initializing *unsigned long const* bits_per_line __u32 typed fb_fix_screeninfo::line_length gets multiplied by 8u -- which might overflow __u32; multiplying by 8UL instead should fix that...

Re: [PATCH 1/2] video: fbdev: core: cfbcopyarea: fix sloppy typing

2023-09-19 Thread Sergey Shtylyov
Hello! On 9/19/23 10:05 AM, Helge Deller wrote: >> In cfb_copyarea(), when initializing *unsigned long const* bits_per_line >> __u32 typed fb_fix_screeninfo::line_length gets multiplied by 8u -- which >> might overflow __u32; multiplying by 8UL instead should fix that... >> Also, that bits_per_li

[PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-09-19 Thread Helen Koike
DRM CI keeps track of which tests are failing, flaking or being skipped by the ci in the expectations files. Add entries for those files to the corresponding driver maintainer, so they can be notified when they change. Signed-off-by: Helen Koike --- For reference: https://www.mail-archive.com/d

Re: [PATCH] drm: remove drm_bridge_hpd_disable() from drm_bridge_connector_destroy()

2023-09-19 Thread Laurent Pinchart
Hi Abhinav, Thank you for the patch. On Tue, Sep 19, 2023 at 10:48:12AM -0700, Abhinav Kumar wrote: > drm_bridge_hpd_enable()/drm_bridge_hpd_disable() callbacks call into > the respective driver's hpd_enable()/hpd_disable() ops. These ops control > the HPD enable/disable logic which in some cases

Re: [REGRESSION] [BISECTED] Panic in gen8_ggtt_insert_entries() with v6.5

2023-09-19 Thread Oleksandr Natalenko
Hello. On úterý 19. září 2023 17:43:40 CEST Matthew Wilcox wrote: > On Tue, Sep 19, 2023 at 10:26:42AM +0200, Oleksandr Natalenko wrote: > > Andrzej asked me to try to revert commits 0b62af28f249, e0b72c14d8dc and > > 1e0877d58b1e, and reverting those fixed the i915 crash for me. The > > e0b72c1

[PATCH v4] drm/i915/pxp: Add drm_dbgs for critical PXP events.

2023-09-19 Thread Alan Previn
Debugging PXP issues can't even begin without understanding precedding sequence of important events. Add drm_dbg into the most important PXP events. v3 : - move gt_dbg to after mutex block in function i915_gsc_proxy_component_bind. (Vivaik) v2 : - remove __func__ since drm_dbg covers tha

Re: [PATCH] dt-bindings: display: anx7814: Add definition for anx7816

2023-09-19 Thread Rob Herring
On Mon, 18 Sep 2023 23:49:44 +0200, Alicja Michalska wrote: > As requested by Robert Foss , this patch adds > definition for anx7816. It supplements the patch submitted to dri-devel. > > Signed-off-by: Alicja Michalska > --- > .../devicetree/bindings/display/bridge/analogix,anx7814.yaml |

Re: [PATCH] dt-bindings: display: anx7814: Add definition for anx7816

2023-09-19 Thread Rob Herring
On Mon, Sep 18, 2023 at 11:49:44PM +0200, Alicja Michalska wrote: > As requested by Robert Foss , this patch adds > definition for anx7816. It supplements the patch submitted to dri-devel. Please apply with the driver change. > > Signed-off-by: Alicja Michalska > --- > .../devicetree/bindings/

[PATCH] drm: remove drm_bridge_hpd_disable() from drm_bridge_connector_destroy()

2023-09-19 Thread Abhinav Kumar
drm_bridge_hpd_enable()/drm_bridge_hpd_disable() callbacks call into the respective driver's hpd_enable()/hpd_disable() ops. These ops control the HPD enable/disable logic which in some cases like MSM can be a dedicate hardware block to control the HPD. During probe_defer cases, a connector can be

Re: [PATCH v3 1/1] backlight: hid_bl: Add VESA VCP HID backlight driver

2023-09-19 Thread Julius Zint
On Wed, 6 Sep 2023, Hans de Goede wrote: > Hi Julius, > > On 9/4/23 21:02, Julius Zint wrote: > > > > > > On Mon, 4 Sep 2023, Thomas Weißschuh wrote: > > > >> +Cc Hans who ins involved with the backlight subsystem > >> > >> Hi Julius, > >> > >> today I stumbled upon a mail from Hans [0], whi

  1   2   >