Re: [PATCH v3 00/12] drm/bridge: tc358768: Fixes and timings improvements

2023-08-28 Thread Tomi Valkeinen
Hi Maxim, On 22/08/2023 19:19, Tomi Valkeinen wrote: This series contains various fixes and cleanups for TC358768. The target of this work is to get TC358768 working on Toradex's AM62 based board, which has the following display pipeline: AM62 DPI -> TC358768 -> LT8912B -> HDMI connector The m

[PATCH v6 6/7] drm/vkms: Add a module param to enable/disable the default device

2023-08-28 Thread Brandon Pollack
From: Jim Shargo In many testing circumstances, we will want to just create a new device and test against that. If we create a default device, it can be annoying to have to manually select the new device instead of choosing the only one that exists. The param, enable_default, is defaulted to tru

[PATCH v6 7/7] drm/vkms Add hotplug support via configfs to VKMS.

2023-08-28 Thread Brandon Pollack
This change adds the ability to read or write a "1" or a "0" to the newly added "connected" attribute of a connector in the vkms entry in configfs. A write will trigger a call to drm_kms_helper_hotplug_event, causing a hotplug uevent. With this we can write virtualized multidisplay tests that inv

[PATCH v6 3/7] drm/vkms: Provide platform data when creating VKMS devices

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_drv.c| 14 -- drivers/gpu/drm/vkms/vkms_drv.h| 9 ++--- drivers/gpu/drm/v

[PATCH v6 5/7] drm/vkms: Support enabling ConfigFS devices

2023-08-28 Thread Brandon Pollack
From: Jim Shargo VKMS now supports creating and using virtual devices! In addition to the enabling logic, this commit also prevents users from adding new objects once a card is registered. Signed-off-by: Jim Shargo Signed-off-by: Brandon Pollack --- drivers/gpu/drm/vkms/vkms_configfs.c | 37

[PATCH v6 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This change adds the basic scaffolding for ConfigFS, including setting up the default directories. It does not allow for the registration of configfs-backed devices, which is complex and provided in a follow-up commit. This CL includes docs about using ConfigFS with VKMS, but I'

[PATCH v6 2/7] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This change supports multiple CRTCs, encoders, connectors instead of one of each per device. Since ConfigFS-based devices will support multiple crtcs, it's useful to move all of the writeback/composition data from being per-"output" to being per-CRTC. Since there's still only e

[PATCH v6 1/7] drm/vkms: Back VKMS with DRM memory management instead of static objects

2023-08-28 Thread Brandon Pollack
From: Jim Shargo This is a small refactor to make ConfigFS support easier. Once we support ConfigFS, there can be multiple devices instantiated by the driver, and so moving everything into managed memory makes things much easier. This should be a no-op refactor. Signed-off-by: Jim Shargo Signe

[PATCH v6 0/7] Adds support for ConfigFS to VKMS!

2023-08-28 Thread Brandon Pollack
Since Jim is busy with other work and I'm working on some things that rely on this, I've taken up the task of doing the iterations. I've addressed the comments as best I can (those replies are to each individual change) and here is the patch set to go with those. I added my own signoff to each co

Re: [PATCH v5 4/7] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-28 Thread Brandon Ross Pollack
silly mistake, I should have been more cautious. Thank you for pickup up my slack On Mon, Aug 28, 2023 at 11:10 PM Marius Vlad wrote: > > Hi Brandon, > > See some minor missing rmdirs for connector_other and encoder_other. > > On Mon, Aug 28, 2023 at 08:17:06AM +, Brandon Pollack wrote: > >

[PATCH v3] fs: clean up usage of noop_dirty_folio

2023-08-28 Thread Xueshi Hu
In folio_mark_dirty(), it can automatically fallback to noop_dirty_folio() if a_ops->dirty_folio is not registered. In anon_aops, dev_dax_aops and fb_deferred_io_aops, replacing .dirty_folio with NULL makes them identical to default (empty_aops) and since we never compare ->a_ops pointer with eith

Re: [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 18:24, Helen Mae Koike Fornazier wrote: > On Monday, August 28, 2023 11:37 -03, "Helen Mae Koike Fornazier" > wrote: > >> On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko >> wrote: >> >>> This series: >>> >>> 1. Adds common drm-shmem memory shrinker >>> 2. Enables shrinker

Re: [PATCH v15 17/23] drm/shmem-helper: Add and use drm_gem_shmem_resv_assert_held() helper

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 13:12, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:43 +0300 > Dmitry Osipenko wrote: > >> In a preparation of adding drm-shmem memory shrinker, move all reservation >> locking lockdep checks to use new drm_gem_shmem_resv_assert_held() that >> will resolve spurious lockdep warnin

Re: [PATCH v15 12/23] drm/shmem-helper: Add and use pages_pin_count

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 14:46, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:38 +0300 > Dmitry Osipenko wrote: > >> Add separate pages_pin_count for tracking of whether drm-shmem pages are >> moveable or not. With the addition of memory shrinker support to drm-shmem, >> the pages_use_count will no longer

Re: [PATCH v15 10/23] locking/refcount, kref: Add kref_put_ww_mutex()

2023-08-28 Thread Dmitry Osipenko
On 8/28/23 12:26, Boris Brezillon wrote: > On Sun, 27 Aug 2023 20:54:36 +0300 > Dmitry Osipenko wrote: > >> Introduce kref_put_ww_mutex() helper that will handle the wait-wound >> mutex auto-locking on kref_put(). This helper is wanted by DRM drivers >> that extensively use dma-reservation lockin

RE: [PATCH] drm/bridge: imx: fix potential NULL pointer dereference in imx8qxp_ldb_parse_dt_companion()

2023-08-28 Thread Ying Liu
On Tuesday, August 29, 2023 2:38 AM Laurent Pinchart wrote: > On Tue, Aug 29, 2023 at 02:01:25AM +0800, Zhang Shurong wrote: > > 在 2023年8月29日星期二 CST 上午1:28:22,Laurent Pinchart 写道: > > > Hi Zhang, > > > > > > Thank you for the patch. > > > > > > On Tue, Aug 29, 2023 at 12:55:01AM +0800, Zhang Shur

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-28 Thread Danilo Krummrich
On 8/28/23 20:41, Matthew Brost wrote: On Mon, Aug 28, 2023 at 08:04:31PM +0200, Danilo Krummrich wrote: On 8/11/23 04:31, Matthew Brost wrote: Rather than call free_job and run_job in same work item have a dedicated work item for each. This aligns with the design and intended use of work queue

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-28 Thread Dmitry Baryshkov
On Tue, 29 Aug 2023 at 02:45, Jessica Zhang wrote: > > > > On 8/8/2023 3:57 PM, Jessica Zhang wrote: > > > > > > On 8/7/2023 6:07 PM, Dmitry Baryshkov wrote: > >> > >> > >> On 8 August 2023 00:41:07 GMT+03:00, Jessica Zhang > >> wrote: > >>> > >>> > >>> On 8/4/2023 6:27 AM, Dmitry Baryshkov wrote

[PATCH RFC v6 10/10] drm/msm/dpu: Add solid fill and pixel source properties

2023-08-28 Thread Jessica Zhang
Add solid_fill and pixel_source properties to DPU plane Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_p

[PATCH RFC v6 08/10] drm/msm/dpu: Allow NULL FBs in atomic commit

2023-08-28 Thread Jessica Zhang
Since solid fill planes allow for a NULL framebuffer in a valid commit, add NULL framebuffer checks to atomic commit calls within DPU. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 9 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

[PATCH RFC v6 05/10] drm/atomic: Add solid fill data to plane state dump

2023-08-28 Thread Jessica Zhang
Add solid_fill property data to the atomic plane state dump. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 4 drivers/gpu/drm/drm_plane.c | 8 include/drm/drm_plane.h | 3 +++ 3 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/dri

[PATCH RFC v6 00/10] Support for Solid Fill Planes

2023-08-28 Thread Jessica Zhang
Some drivers support hardware that have optimizations for solid fill planes. This series aims to expose these capabilities to userspace as some compositors have a solid fill flag (ex. SOLID_COLOR in the Android hardware composer HAL) that can be set by apps like the Android Gears app. In order to

[PATCH RFC v6 01/10] drm: Introduce pixel_source DRM plane property

2023-08-28 Thread Jessica Zhang
Add support for pixel_source property to drm_plane and related documentation. In addition, force pixel_source to DRM_PLANE_PIXEL_SOURCE_FB in DRM_IOCTL_MODE_SETPLANE as to not break legacy userspace. This enum property will allow user to specify a pixel source for the plane. Possible pixel sources

[PATCH RFC v6 09/10] drm/msm/dpu: Use DRM solid_fill property

2023-08-28 Thread Jessica Zhang
Drop DPU_PLANE_COLOR_FILL_FLAG and check the DRM solid_fill property to determine if the plane is solid fill. In addition drop the DPU plane color_fill field as we can now use drm_plane_state.solid_fill instead, and pass in drm_plane_state.alpha to _dpu_plane_color_fill_pipe() to allow userspace to

[PATCH RFC v6 03/10] drm: Add solid fill pixel source

2023-08-28 Thread Jessica Zhang
Add "SOLID_FILL" as a valid pixel source. If the pixel_source property is set to "SOLID_FILL", it will display data from the drm_plane "solid_fill" blob property. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_blend.c | 10 +- include/drm/drm_plane.h

[PATCH RFC v6 04/10] drm/atomic: Add pixel source to plane state dump

2023-08-28 Thread Jessica Zhang
Add pixel source to the atomic plane state dump Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c| 1 + drivers/gpu/drm/drm_blend.c | 1 + drivers/gpu/drm/drm_crtc_internal.h | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/

[PATCH RFC v6 06/10] drm/atomic: Move framebuffer checks to helper

2023-08-28 Thread Jessica Zhang
Currently framebuffer checks happen directly in drm_atomic_plane_check(). Move these checks into their own helper method. Reviewed-by: Dmitry Baryshkov Signed-off-by: Jessica Zhang --- drivers/gpu/drm/drm_atomic.c | 130 --- 1 file changed, 73 insertions(

[PATCH RFC v6 07/10] drm/atomic: Loosen FB atomic checks

2023-08-28 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where pixel_source != FB, the commit can still go through. This includes adding framebuffer NULL checks in other areas to account for FB being NULL when non-FB pixel sources are enabled. To disable a plane, the pixel_source mu

[PATCH RFC v6 02/10] drm: Introduce solid fill DRM plane property

2023-08-28 Thread Jessica Zhang
Document and add support for solid_fill property to drm_plane. In addition, add support for setting and getting the values for solid_fill. To enable solid fill planes, userspace must assign a property blob to the "solid_fill" plane property containing the following information: struct drm_mode_so

Re: [PATCH RFC v5 02/10] drm: Introduce solid fill DRM plane property

2023-08-28 Thread Jessica Zhang
On 8/8/2023 3:57 PM, Jessica Zhang wrote: On 8/7/2023 6:07 PM, Dmitry Baryshkov wrote: On 8 August 2023 00:41:07 GMT+03:00, Jessica Zhang wrote: On 8/4/2023 6:27 AM, Dmitry Baryshkov wrote: On Fri, 28 Jul 2023 at 20:03, Jessica Zhang wrote: Document and add support for solid_fill

Re: [PATCH -next] drm/exynos: fix a potential error pointer dereference

2023-08-28 Thread Inki Dae
2023년 8월 12일 (토) 오후 4:17, Xiang Yang 님이 작성: > From: Xiang Yang > > Smatch reports the warning below: > drivers/gpu/drm/exynos/exynos_hdmi.c:1864 hdmi_bind() > error: 'crtc' dereferencing possible ERR_PTR() > > The return value of exynos_drm_crtc_get_by_type maybe ERR_PTR(-ENODEV), > which can not

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-08-28 Thread Adam Ford
On Mon, Aug 28, 2023 at 11:13 AM Adam Ford wrote: > > On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter > wrote: > > > > I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, > > which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few > > modes were working, but in many

Re: [Intel-gfx] [PATCH v5] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-08-28 Thread John Harrison
On 8/23/2023 10:37, John Harrison wrote: On 8/23/2023 09:00, Daniel Vetter wrote: On Tue, Aug 22, 2023 at 11:53:24AM -0700, John Harrison wrote: On 8/11/2023 11:20, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. When intel

Re: [PATCH 5/5] drm/bridge: samsung-dsim: calculate porches in Hz

2023-08-28 Thread Adam Ford
On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter wrote: > > Calculating the byte_clk in kHz is imprecise for a hs_clock of 55687500 > Hz, which may be used with a pixel clock of 74.25 MHz with mode > 1920x1080-30. > > Fix the calculation by using HZ instead of kHZ. > > This requires to change the

Re: [PATCH 4/5] drm/bridge: samsung-dsim: adjust porches by rounding up

2023-08-28 Thread Adam Ford
On Mon, Aug 28, 2023 at 1:26 PM Fabio Estevam wrote: > > Hi Michael, > > On Mon, Aug 28, 2023 at 12:59 PM Michael Tretter > wrote: > > > > The porches must be rounded up to make the samsung-dsim work. ...at some resolutions and refresh rates. > > The commit log could be improved here. > > The w

Re: [PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

2023-08-28 Thread Adam Ford
On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter wrote: > > From: Marco Felsch > > Since the MIPI configuration can be changed on demand it is very useful > to print more MIPI settings during the MIPI device attach step. > > Signed-off-by: Marco Felsch > Signed-off-by: Michael Tretter Reviewed

Re: [PATCH 2/7] drm: adv7511: Add max_mode_clock variable to struct adv7511_chip_info

2023-08-28 Thread Adam Ford
On Sun, Aug 13, 2023 at 1:05 PM Biju Das wrote: > > The ADV7533 supports a maximum pixel clock of 80MHz whereas it is 148.5MHz > for ADV7535. Add max_mode_clock variable to struct adv7511_chip_info to > handle this difference. > > Signed-off-by: Biju Das For the series: Reviewed-by: Adam Ford

Re: [PATCH v4 0/3] drm: simplify support for transparent DRM bridges

2023-08-28 Thread Dmitry Baryshkov
On Tue, 22 Aug 2023 at 17:19, Laurent Pinchart wrote: > > On Tue, Aug 22, 2023 at 05:17:37PM +0300, Laurent Pinchart wrote: > > Hi Dmitry, > > > > Thank you for the patches. > > > > On Thu, Aug 17, 2023 at 05:55:13PM +0300, Dmitry Baryshkov wrote: > > > Supporting DP/USB-C can result in a chain of

[Bug 217664] Medion AMD Laptop doesn't wake up from s2idle with SATA disk

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Assignee|drivers_video-dri@kernel-bu |t...

[Bug 217664] Medion AMD Laptop doesn't wake up from s2idle with SATA disk

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Summary|Laptop doesnt wake up from |Medi

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed: What|Removed |Added Component|Power-Sleep-Wake|Seri

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #46 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- (In reply to popus_czy_to_ty from comment #43) > Created attachment 304974 [details] > acpi dump It appears that your system doesn't have the StorageD3Enable _DSD on any

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #45 from popus_czy_to_ty (pentelja...@o2.pl) --- also i changed value from =3 to =0 on CONFIG_SATA_MOBILE_LPM_POLICY and i was able to compile it smoothly and run, but still no change -- You may reply to this email to add a comment.

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #44 from popus_czy_to_ty (pentelja...@o2.pl) --- SAMSUNG MZVLB512HBJQ-0 512,1 GB (came in bundle (as laptop) Samsung SSD 860 EVO 250GB 250,0 GB -sata (added just for linux) i will reply after to you other questions later if i can.

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #43 from popus_czy_to_ty (pentelja...@o2.pl) --- Created attachment 304974 --> https://bugzilla.kernel.org/attachment.cgi?id=304974&action=edit acpi dump -- You may reply to this email to add a comment. You are receiving this mail

Re: [PATCH v6 1/4] drm: Use XArray instead of IDR for minors

2023-08-28 Thread Michał Winiarski
On Fri, Aug 25, 2023 at 12:59:26PM -0400, James Zhu wrote: > > On 2023-07-24 17:14, Michał Winiarski wrote: > > IDR is deprecated, and since XArray manages its own state with internal > > locking, it simplifies the locking on DRM side. > > Additionally, don't use the IRQ-safe variant, since operat

Re: [PATCH v2 2/3] drm/i915/guc: Close deregister-context race against CT-loss

2023-08-28 Thread Teres Alexis, Alan Previn
Additional update from the most recent testing. When relying solely on guc_lrc_desc_unpin getting a failure from deregister_context as a means for identifying that we are in the "deregister-context-vs-suspend-late" race, it is too late a location to handle this safely. This is because one of the

Re: [PATCH v2 9/9] accel/ivpu: Move MMU register definitions to ivpu_mmu.c

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz MMU registers are not platform specific so they should be defined separate to platform regs. Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 8/9] accel/ivpu/37xx: White space cleanup

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: No functional change, adjust code formatting after previous changes. This feels incomplete. You are doing an adjustment, but to what, and why? Maybe - No functional change, adjust code formatting so that defines line up nicely to improve code r

Re: [PATCH v2 7/9] accel/ivpu/37xx: Change register rename leftovers

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: Change remaining MTL_VPU_ register names to generation based names. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 6/9] accel/ivpu: Add ivpu_bo_vaddr() and ivpu_bo_size()

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz Use: - ivpu_bo_vaddr(bo) instead of bo->kvaddr - ivpu_bo_size(bo) instead of bo->base.size This is a preparation for switch to a drm_gem_shmem_object as a base for ivpu_bo, where: - bo->kvaddr becomes bo->base.vadd

Re: [PATCH v2 5/9] accel/ivpu: Move ivpu_fw_load() to ivpu_fw_init()

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz ivpu_fw_load() doesn't have to be called separately in ivpu_dev_init(). Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signed-off-by: Stanislaw Gruszka --- drivers/accel/ivpu/ivpu_drv.c | 4 driv

Re: [PATCH v2 4/9] accel/ivpu: Initialize context with SSID = 1

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: From: Karol Wachowski Context with SSID = 1 is reserved and accesses on that context happen only when context is uninitialized on the VPU side. Such access triggers MMU fault (0xa) "Invalid CD Fetch", which doesn't contain any useful information be

Re: [PATCH v2 3/9] accel/ivpu: Print information about used workarounds

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: Use ivpu_dbg(MISC) to print information about workarounds. Reviewed-by: Karol Wachowski Signed-off-by: Stanislaw Gruszka Reviewed-by: Jeffrey Hugo

Re: [PATCH v2 2/9] accel/ivpu: Remove duplicated error messages

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: From: Jacek Lawrynowicz Reduce the number of error messages per single failure in ivpu_dev_init(). Error messages are already printed by functions called from ivpu_dev_init(). Signed-off-by: Jacek Lawrynowicz Reviewed-by: Stanislaw Gruszka Signe

Re: [PATCH v2 1/9] accel/ivpu: Move set autosuspend delay to HW specific code

2023-08-28 Thread Jeffrey Hugo
On 8/28/2023 3:47 AM, Stanislaw Gruszka wrote: From: Krystian Pradzynski Configure autosuspend values per HW generation and per platform. For non silicon platforms disable autosuspend for now, for silicon reduce it to 10 ms. Signed-off-by: Krystian Pradzynski Reviewed-by: Stanislaw Gruszka

Re: [PATCH v3 0/7] GPU workload hints for better performance

2023-08-28 Thread Helen Koike
On 28/08/2023 17:14, Yadav, Arvind wrote: On 8/28/2023 9:13 PM, Helen Mae Koike Fornazier wrote: On Monday, August 28, 2023 09:26 -03, Arvind Yadav wrote: AMDGPU SOCs supports dynamic workload based power profiles, which can provide fine-tuned performance for a particular type of workloa

Re: [PATCH v3 0/7] GPU workload hints for better performance

2023-08-28 Thread Yadav, Arvind
On 8/28/2023 9:13 PM, Helen Mae Koike Fornazier wrote: On Monday, August 28, 2023 09:26 -03, Arvind Yadav wrote: AMDGPU SOCs supports dynamic workload based power profiles, which can provide fine-tuned performance for a particular type of workload. This patch series adds an interface to set/

Re: [PATCH v2] drm: Update file owner during use

2023-08-28 Thread Rob Clark
On Wed, Jun 21, 2023 at 2:48 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > With the typical model where the display server opens the file descriptor > and then hands it over to the client(*), we were showing stale data in > debugfs. > > Fix it by updating the drm_file->pid on ioctl access

Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp

2023-08-28 Thread Randy Dunlap
Hi-- On 8/28/23 09:39, Laurent Pinchart wrote: > Hi Lee, > > Thank you for the patch. > > On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote: >> Fixes the following W=1 kernel build warning(s): >> >> drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or >> member 'blend

Re: [PATCH v4 1/3] dt-bindings: display: panel: add common dual-link schema

2023-08-28 Thread Laurent Pinchart
Hi Krzysztof, Thank you for the patch. On Fri, Aug 25, 2023 at 02:11:40PM +0200, Krzysztof Kozlowski wrote: > Add schema with common properties shared among dual-link panel ICs. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart > --- > > Changes since v3: > 1. Re-phrase d

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #42 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- s/NVME/SATA/ -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #41 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) --- Was that NVME something you added to the system or it came with it? I am suspecting that your platform or the NVME doesn't end up activating a feature needed for s2idle

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-28 Thread Matthew Brost
On Mon, Aug 28, 2023 at 08:04:31PM +0200, Danilo Krummrich wrote: > On 8/11/23 04:31, Matthew Brost wrote: > > Rather than call free_job and run_job in same work item have a dedicated > > work item for each. This aligns with the design and intended use of work > > queues. > > > > Signed-off-by: Ma

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-28 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #40 from popus_czy_to_ty (pentelja...@o2.pl) --- 1) sorry for very long spam but im not into compiling own kernel too much, first https://cateee.net/lkddb/web-lkddb/SATA_MOBILE_LPM_POLICY.html i seen that page what you wrote then i sto

Re: [PATCH] drm/bridge: imx: fix potential NULL pointer dereference in imx8qxp_ldb_parse_dt_companion()

2023-08-28 Thread Laurent Pinchart
On Tue, Aug 29, 2023 at 02:01:25AM +0800, Zhang Shurong wrote: > 在 2023年8月29日星期二 CST 上午1:28:22,Laurent Pinchart 写道: > > Hi Zhang, > > > > Thank you for the patch. > > > > On Tue, Aug 29, 2023 at 12:55:01AM +0800, Zhang Shurong wrote: > > > of_match_device() may fail and returns a NULL pointer. >

Re: [PATCH 4/5] drm/bridge: samsung-dsim: adjust porches by rounding up

2023-08-28 Thread Fabio Estevam
Hi Michael, On Mon, Aug 28, 2023 at 12:59 PM Michael Tretter wrote: > > The porches must be rounded up to make the samsung-dsim work. The commit log could be improved here. The way it is written gives the impression that samsung-dsim does not work currently.

Re: [PATCH 3/5] drm/bridge: samsung-dsim: update PLL reference clock

2023-08-28 Thread Adam Ford
On Mon, Aug 28, 2023 at 11:42 AM Marco Felsch wrote: > > On 23-08-28, Michael Tretter wrote: > > The PLL requires a clock between 2 MHz and 30 MHz after the pre-divider. > > The reference clock for the PLL may change due to changes to it's parent > > clock. Thus, the frequency may be out of range

Re: [PATCH] drm/bridge: imx: fix potential NULL pointer dereference in imx8qxp_ldb_parse_dt_companion()

2023-08-28 Thread Zhang Shurong
在 2023年8月29日星期二 CST 上午1:28:22,Laurent Pinchart 写道: > Hi Zhang, > > Thank you for the patch. > > On Tue, Aug 29, 2023 at 12:55:01AM +0800, Zhang Shurong wrote: > > of_match_device() may fail and returns a NULL pointer. > > How can it return a NULL pointer here ? > > > Fix this by checking the re

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-28 Thread Danilo Krummrich
On 8/11/23 04:31, Matthew Brost wrote: Rather than call free_job and run_job in same work item have a dedicated work item for each. This aligns with the design and intended use of work queues. Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sched_main.c | 137 ++

Re: [PATCH] drm/bridge: imx: fix potential NULL pointer dereference in imx8qxp_ldb_parse_dt_companion()

2023-08-28 Thread Laurent Pinchart
Hi Zhang, Thank you for the patch. On Tue, Aug 29, 2023 at 12:55:01AM +0800, Zhang Shurong wrote: > of_match_device() may fail and returns a NULL pointer. How can it return a NULL pointer here ? > Fix this by checking the return value of of_match_device(). > > Fixes: 3818715f62b4 ("drm/bridge:

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-28 Thread Abhinav Kumar
Hi Neil Sorry I didnt respond earlier on this thread. On 8/28/2023 1:49 AM, neil.armstr...@linaro.org wrote: Hi Jessica, On 25/08/2023 20:37, Jessica Zhang wrote: On 8/21/2023 3:01 AM, neil.armstr...@linaro.org wrote: Hi Maxime, On 21/08/2023 10:17, Maxime Ripard wrote: Hi, On Fri, Aug

[PATCH] drm/bridge: imx: fix potential NULL pointer dereference in imx8qxp_ldb_parse_dt_companion()

2023-08-28 Thread Zhang Shurong
of_match_device() may fail and returns a NULL pointer. Fix this by checking the return value of of_match_device(). Fixes: 3818715f62b4 ("drm/bridge: imx: Add LDB support for i.MX8qxp") Signed-off-by: Zhang Shurong --- drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-08-28 Thread Marco Felsch
On 23-08-28, Michael Tretter wrote: > I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, > which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few > modes were working, but in many modes my monitor stayed dark. > > This series fixes the Samsung DSIM bridge driver to

Re: [PATCH 3/5] drm/bridge: samsung-dsim: update PLL reference clock

2023-08-28 Thread Marco Felsch
On 23-08-28, Michael Tretter wrote: > The PLL requires a clock between 2 MHz and 30 MHz after the pre-divider. > The reference clock for the PLL may change due to changes to it's parent > clock. Thus, the frequency may be out of range or unsuited for > generating the high speed clock for MIPI DSI.

Re: [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp

2023-08-28 Thread Laurent Pinchart
Hi Lee, Thank you for the patch. On Thu, Aug 24, 2023 at 08:36:46AM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/xlnx/zynqmp_disp.c:151: warning: Function parameter or > member 'blend' not described in 'zynqmp_disp' > drivers/gpu/drm/xlnx/zynq

Re: [PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-08-28 Thread Adam Ford
On Mon, Aug 28, 2023 at 10:59 AM Michael Tretter wrote: > > I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, > which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few > modes were working, but in many modes my monitor stayed dark. > > This series fixes the Samsung

Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

2023-08-28 Thread Michel Dänzer
On 8/24/23 14:07, Lee Jones wrote: > On Thu, 24 Aug 2023, Jani Nikula wrote: >> On Thu, 24 Aug 2023, Lee Jones wrote: >>> This set is part of a larger effort attempting to clean-up W=1 >>> kernel builds, which are currently overwhelmingly riddled with >>> niggly little warnings. >> >> The next que

Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper

2023-08-28 Thread Doug Anderson
Hi, On Mon, Aug 28, 2023 at 12:45 AM Maxime Ripard wrote: > > > For removal I'd be fine with just dropping the call and saying it's > > the responsibility of the driver to call drm_atomic_helper_shutdown(), > > as you suggest. I'd tend to believe that removal of DRM drivers is not > > used anywhe

Re: [PATCH 2/2] ARM: dts: imx: add support for the ATM0700D4 panel attached to sk-imx53

2023-08-28 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sun, Aug 27, 2023 at 12:54:29AM +0300, Dmitry Baryshkov wrote: > The SK-ATM0700D4-Plug is an extension board (provided by the same > manufacturer, [1]) which can be connected to the SK-IMX53 panel kit. The > panel can be connected either using the RGB parall

Re: [PATCH 1/2] dt-bindings: display/lvds-codec: add ti,sn65lvds94

2023-08-28 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Sun, Aug 27, 2023 at 12:54:28AM +0300, Dmitry Baryshkov wrote: > Add compatible strings for TI sn65lvds94, LVDS serdes receiver. > > Signed-off-by: Dmitry Baryshkov Reviewed-by: Laurent Pinchart > --- > Documentation/devicetree/bindings/display/bridge/

[PATCH 5/5] drm/bridge: samsung-dsim: calculate porches in Hz

2023-08-28 Thread Michael Tretter
Calculating the byte_clk in kHz is imprecise for a hs_clock of 55687500 Hz, which may be used with a pixel clock of 74.25 MHz with mode 1920x1080-30. Fix the calculation by using HZ instead of kHZ. This requires to change the type to u64 to prevent overflows of the integer type. Signed-off-by: M

[PATCH 3/5] drm/bridge: samsung-dsim: update PLL reference clock

2023-08-28 Thread Michael Tretter
The PLL requires a clock between 2 MHz and 30 MHz after the pre-divider. The reference clock for the PLL may change due to changes to it's parent clock. Thus, the frequency may be out of range or unsuited for generating the high speed clock for MIPI DSI. Try to keep the pre-devider small, and set

[PATCH 4/5] drm/bridge: samsung-dsim: adjust porches by rounding up

2023-08-28 Thread Michael Tretter
The porches must be rounded up to make the samsung-dsim work. Signed-off-by: Michael Tretter --- drivers/gpu/drm/bridge/samsung-dsim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 4d

[PATCH 1/5] drm/bridge: samsung-dsim: add more mipi-dsi device debug information

2023-08-28 Thread Michael Tretter
From: Marco Felsch Since the MIPI configuration can be changed on demand it is very useful to print more MIPI settings during the MIPI device attach step. Signed-off-by: Marco Felsch Signed-off-by: Michael Tretter --- drivers/gpu/drm/bridge/samsung-dsim.c | 5 - 1 file changed, 4 insertio

[PATCH 2/5] drm/bridge: samsung-dsim: reread ref clock before configuring PLL

2023-08-28 Thread Michael Tretter
The PLL reference clock may change at runtime. Thus, reading the clock rate during probe is not sufficient to correctly configure the PLL for the expected hs clock. Read the actual rate of the reference clock before calculating the PLL configuration parameters. Signed-off-by: Michael Tretter ---

[PATCH 0/5] drm/bridge: samsung-dsim: fix various modes with ADV7535 bridge

2023-08-28 Thread Michael Tretter
I tested the i.MX8M Nano EVK with the NXP supplied MIPI-DSI adapter, which uses an ADV7535 MIPI-DSI to HDMI converter. I found that a few modes were working, but in many modes my monitor stayed dark. This series fixes the Samsung DSIM bridge driver to bring up a few more modes: The driver read th

Re: [PATCH 1/2] dt-bindings: display/lvds-codec: add ti,sn65lvds94

2023-08-28 Thread Conor Dooley
On Sun, Aug 27, 2023 at 02:45:30PM +0200, Krzysztof Kozlowski wrote: > On 27/08/2023 14:19, Conor Dooley wrote: > > On Sun, Aug 27, 2023 at 12:54:28AM +0300, Dmitry Baryshkov wrote: > >> Add compatible strings for TI sn65lvds94, LVDS serdes receiver. > >> > >> Signed-off-by: Dmitry Baryshkov > >

Re: [PATCH v3 0/7] GPU workload hints for better performance

2023-08-28 Thread Helen Mae Koike Fornazier
On Monday, August 28, 2023 09:26 -03, Arvind Yadav wrote: > AMDGPU SOCs supports dynamic workload based power profiles, which can > provide fine-tuned performance for a particular type of workload. > This patch series adds an interface to set/reset these power profiles > based on the submitted jo

Re: [PATCH] drm/prime: Support page array >= 4GB

2023-08-28 Thread Felix Kuehling
On 2023-08-21 16:02, Philip Yang wrote: Without unsigned long typecast, the size is passed in as zero if page array size >= 4GB, nr_pages >= 0x10, then sg list converted will have the first and the last chunk lost. Signed-off-by: Philip Yang The patch looks reasonable to me. I don't have

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

2023-08-28 Thread Helen Mae Koike Fornazier
On Friday, August 25, 2023 08:02 -03, Jai Luthra wrote: > Fix the NULL pointer dereference when no monitor is connected, and the > sound card is opened from userspace. > > Instead return an error as EDID information cannot be provided to > the sound framework if there is no connector attached. >

Re: [PATCH] spi: tegra: Fix missing IRQ check in tegra_slink_probe()

2023-08-28 Thread Helen Mae Koike Fornazier
On Saturday, August 26, 2023 07:02 -03, Zhang Shurong wrote: > This func misses checking for platform_get_irq()'s call and may passes the > negative error codes to request_irq(), which takes unsigned IRQ #, > causing it to fail with -EINVAL, overriding an original error code. > > Fix this by st

Re: [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Helen Mae Koike Fornazier
On Monday, August 28, 2023 11:37 -03, "Helen Mae Koike Fornazier" wrote: > On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko > wrote: > > > This series: > > > > 1. Adds common drm-shmem memory shrinker > > 2. Enables shrinker for VirtIO-GPU driver > > 3. Switches Panfrost driver to

Re: [PATCH v4 1/3] dt-bindings: display: panel: add common dual-link schema

2023-08-28 Thread Rob Herring
On Fri, 25 Aug 2023 14:11:40 +0200, Krzysztof Kozlowski wrote: > Add schema with common properties shared among dual-link panel ICs. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v3: > 1. Re-phrase description of binding and ports (Laurent) > v3: > https://lore.kernel.org/

Re: [PATCH v3 0/7] GPU workload hints for better performance

2023-08-28 Thread Lazar, Lijo
[AMD Official Use Only - General] As mentioned with an older version of this series, this is an 'abuse' of power profile interface. This series is oversimplifying what PMFW algorithms are supposed to be doing. Whatever this series is doing, FW can do it better. To explain in simpler terms - it

Re: [PATCH v2 6/6] drm/drm-file: Allow size unit selection in drm_show_memory_stats

2023-08-28 Thread Rob Clark
On Wed, Aug 23, 2023 at 6:36 PM Adrián Larumbe wrote: > > The current implementation will try to pick the highest available > unit. This is rather unflexible, and allowing drivers to display BO size > statistics through fdinfo in units of their choice might be desirable. > > The new argument to dr

Re: [PATCH 8/8] staging/fbtft: Use fb_ops helpers for deferred I/O

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:24PM +0200, Thomas Zimmermann wrote: > Generate callback functions for struct fb_ops with the fbdev macro > FB_GEN_DEFAULT_DEFERRED_SYSMEM_OPS(). Initialize struct fb_ops to > the generated functions with an fbdev initializer macro. > > Signed-off-by: Thomas Zimmerman

Re: [PATCH 7/8] staging/fbtft: Initialize fb_op struct as static const

2023-08-28 Thread Greg KH
On Mon, Aug 28, 2023 at 03:14:23PM +0200, Thomas Zimmermann wrote: > Replace dynamic allocation of the fb_ops instance with static > allocation. Initialize the fields at module-load time. The owner > field changes to THIS_MODULE, as in all other fbdev drivers. > > Signed-off-by: Thomas Zimmermann

Re: [PATCH v2] fs: clean up usage of noop_dirty_folio

2023-08-28 Thread Al Viro
On Mon, Aug 28, 2023 at 03:54:49PM +0800, Xueshi Hu wrote: > In folio_mark_dirty(), it can automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove > them too. I'd put the last sentence as

Re: [PATCH v15 00/23] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers

2023-08-28 Thread Helen Mae Koike Fornazier
On Sunday, August 27, 2023 14:54 -03, Dmitry Osipenko wrote: > This series: > > 1. Adds common drm-shmem memory shrinker > 2. Enables shrinker for VirtIO-GPU driver > 3. Switches Panfrost driver to the common shrinker Hi Dmitry, Would you mind testing with drm-ci? We virt-io tests ther

  1   2   >