Re: [PATCH v3 1/2] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2023-08-17 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v6.5-rc6 next-20230817] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v2 5/6] drm/vkms: Support enabling ConfigFS devices

2023-08-17 Thread Marius Vlad
Hi, Seem my comments below. On 8/18/23 08:24, Brandon Ross Pollack wrote: On 8/15/23 23:01, Marius Vlad wrote: Hi, See below some minor comments: On Fri, Jun 23, 2023 at 06:23:47PM -0400, Jim Shargo wrote: VKMS now supports creating and using virtual devices! In addition to the enabling l

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-17 Thread Christian König
Am 18.08.23 um 05:08 schrieb Matthew Brost: On Thu, Aug 17, 2023 at 01:13:31PM +0200, Danilo Krummrich wrote: On 8/17/23 07:33, Christian König wrote: Am 16.08.23 um 18:33 schrieb Danilo Krummrich: On 8/16/23 16:59, Christian König wrote: Am 16.08.23 um 14:30 schrieb Danilo Krummrich: On 8/1

Re: [PATCH v2 6/6] drm/vkms: Add a module param to enable/disable the default device

2023-08-17 Thread Brandon Ross Pollack
On 6/26/23 03:04, Maira Canal wrote: Hi Jim, On 6/23/23 19:23, Jim Shargo wrote: In many testing circumstances, we will want to just create a new device and test against that. If we create a default device, it can be annoying to have to manually select the new device instead of choosing the o

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-17 Thread Christian König
Am 17.08.23 um 19:54 schrieb Matthew Brost: On Thu, Aug 17, 2023 at 03:39:40PM +0200, Christian König wrote: Am 11.08.23 um 04:31 schrieb Matthew Brost: Rather than call free_job and run_job in same work item have a dedicated work item for each. This aligns with the design and intended use of w

Re: [PATCH v2 2/6] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-17 Thread Brandon Ross Pollack
Silly addition but I need to apologize for mispelling somone's name in my reply. Maira, please accept my sincere apology. On 8/18/23 12:36, Brandon Pollack wrote: Thanks for taking the time, everyone! Sorry it took so long, we had some internal shuffling etc going on and I was building out wha

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-17 Thread Simon Ser
On Thursday, August 17th, 2023 at 21:33, Dmitry Baryshkov wrote: > We have been looking for a way to document that the corresponding DP > port is represented by the USB connector on the device. > > Consequently, I believe the best way to document it, would be to use > DisplayPort / USB, when th

Re: linux-next: Tree for Aug 17 (DRM_TTM KUNIT tests)

2023-08-17 Thread Christian König
Am 17.08.23 um 20:44 schrieb Randy Dunlap: On 8/16/23 21:47, Stephen Rothwell wrote: Hi all, Changes since 20230816: on risc-v 32-bit: when # CONFIG_MMU is not set Patch to fix this is already queued up for the next pull request. Sorry for the noise, Christian. WARNING: unmet direct d

Re: [PATCH v2 5/6] drm/vkms: Support enabling ConfigFS devices

2023-08-17 Thread Brandon Ross Pollack
On 8/15/23 23:01, Marius Vlad wrote: Hi, See below some minor comments: On Fri, Jun 23, 2023 at 06:23:47PM -0400, Jim Shargo wrote: VKMS now supports creating and using virtual devices! In addition to the enabling logic, this commit also prevents users from adding new objects once a card is

Re: [git pull] drm fixes for 6.5-rc7

2023-08-17 Thread pr-tracker-bot
The pull request you sent on Fri, 18 Aug 2023 07:36:16 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-08-18-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1ada9c07407d66679967fe5c2cbb7eda2e0addbf Thank you! -- Deet-doot-dot, I am a bot. https:/

[PATCH] drm/display/dp: Fix the DP DSC Receiver cap size

2023-08-17 Thread Ankit Nautiyal
DP DSC Receiver Capabilities are exposed via DPCD 60h-6Fh. Fix the DSC RECEIVER CAP SIZE accordingly. Fixes: ffddc4363c28 ("drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT") Cc: Anusha Srivatsa Cc: Manasi Navare Cc: # v5.0+ Signed-off-by: Ankit Nautiyal Reviewed-by:

Re: [PATCH v2 4/6] drm/vkms: Add ConfigFS scaffolding to VKMS

2023-08-17 Thread Brandon Pollack
From: Maira Canal Hi Jim, On 6/23/23 19:23, Jim Shargo wrote: > This change adds the basic scaffolding for ConfigFS, including setting > up the default directories. It does not allow for the registration of > configfs-backed devices, which is complex and provided in a follow-up > commit. > >

[PATCH] drm/vmwgfx: Fix possible invalid drm gem put calls

2023-08-17 Thread Zack Rusin
From: Zack Rusin vmw_bo_unreference sets the input buffer to null on exit, resulting in null ptr deref's on the subsequent drm gem put calls. This went unnoticed because only very old userspace would be exercising those paths but it wouldn't be hard to hit on old distros with brand new kernels.

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-17 Thread suijingfeng
Hi, On 2023/8/18 06:08, Bjorn Helgaas wrote: On Wed, Aug 16, 2023 at 06:05:27AM +0800, Sui Jingfeng wrote: Currently, the vga_is_firmware_default() function only works on x86 and ia64, it is a no-op on ARM, ARM64, PPC, RISC-V, etc. This patch completes the implementation for the rest of the ar

Re: [PATCH v2 2/6] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device

2023-08-17 Thread Brandon Pollack
Thanks for taking the time, everyone! Sorry it took so long, we had some internal shuffling etc going on and I was building out what we needed these chagnes for in the first place, this will be the first of a few replies followed by a new version of the series to be sent out. First up is a respons

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-17 Thread Matthew Brost
On Thu, Aug 17, 2023 at 01:13:31PM +0200, Danilo Krummrich wrote: > On 8/17/23 07:33, Christian König wrote: > > Am 16.08.23 um 18:33 schrieb Danilo Krummrich: > > > On 8/16/23 16:59, Christian König wrote: > > > > Am 16.08.23 um 14:30 schrieb Danilo Krummrich: > > > > > On 8/16/23 16:05, Christian

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #19 from popus_czy_to_ty (pentelja...@o2.pl) --- now nvidia using some intel driver somehow xD sd@Crawler-E25:~$ lspci -knn | grep VGA -A 5 01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GA107M [GeForce RTX 3050 Mobile]

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 popus_czy_to_ty (pentelja...@o2.pl) changed: What|Removed |Added Kernel Version||6.2.0-27-generic --

Re: [RFC PATCH 1/3] drm/virtio: .release ops for virtgpu fence release

2023-08-17 Thread Kim, Dongwon
On 8/16/2023 10:05 PM, Dmitry Osipenko wrote: On 8/16/23 21:10, Kim, Dongwon wrote: Hi, On 8/14/2023 9:18 PM, Dmitry Osipenko wrote: On 7/13/23 01:44, Dongwon Kim wrote: virtio_gpu_fence_release is added to free virtio-gpu-fence upon release of dma_fence. Cc: Gerd Hoffmann Cc: Vivek Kasir

Re: [RFC PATCH 3/3] drm/virtio: drm_gem_plane_helper_prepare_fb for obj synchronization

2023-08-17 Thread Dmitry Osipenko
On 7/13/23 01:44, Dongwon Kim wrote: > This helper is needed for framebuffer synchronization. Old framebuffer data > is often displayed on the guest display without this helper. > > Cc: Gerd Hoffmann > Cc: Vivek Kasireddy > Signed-off-by: Dongwon Kim > --- > drivers/gpu/drm/virtio/virtgpu_plan

Re: [RFC PATCH 2/3] drm/virtio: new fence for every plane update

2023-08-17 Thread Dmitry Osipenko
... > +static struct > +drm_plane_state *virtio_gpu_plane_duplicate_state(struct drm_plane *plane) > +{ > + struct virtio_gpu_plane_state *new; > + > + if (WARN_ON(!plane->state)) > + return NULL; When plane->state can be NULL? > + new = kzalloc(sizeof(*new), GFP_KERNEL);

Re: [RFC PATCH 1/3] drm/virtio: .release ops for virtgpu fence release

2023-08-17 Thread Dmitry Osipenko
On 8/17/23 08:25, Kim, Dongwon wrote: ... > Yeah, I know it frees 'struct dma_fence *f' but what about 'struct > virtio_gpu_fence *fence'? This is a device specific fence that contains > struct dma_fence *f. But hold on... so when fence->ops->release is > called then dma_fence_free won't be called

linux-next: manual merge of the drm tree with the drm-fixes tree

2023-08-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c between commits: 61319b8e3b58 ("drm/amd/pm: disable the SMU13 OD feature support temporarily") b6360a5ec31d ("drm/amd/pm: disallow the fan setting if there is no fan on

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-17 Thread suijingfeng
Hi, On 2023/8/18 06:08, Bjorn Helgaas wrote: + if (resource_type(res) != IORESOURCE_MEM) + continue; + + if (!res->start || !res->end) + continue; + + if (res->start <= fb_start && fb_end <= res->end) { +

[PATCH -next RESEND] backlight: led_bl: Remove redundant of_match_ptr()

2023-08-17 Thread Ruan Jinjie
The driver depends on CONFIG_OF, it is not necessary to use of_match_ptr() here. Signed-off-by: Ruan Jinjie Reviewed-by: Daniel Thompson --- drivers/video/backlight/led_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/led_bl.c b/drivers/video/back

Re: [PATCH v5 03/17] drm/imagination/uapi: Add PowerVR driver UAPI

2023-08-17 Thread Faith Ekstrand
On Wed, Aug 16, 2023 at 3:26 AM Sarah Walker wrote: > Add the UAPI implementation for the PowerVR driver. > > Changes from v4 : > - Remove CREATE_ZEROED flag for BO creation (all buffers are now zeroed) > > Co-developed-by: Frank Binns > Signed-off-by: Frank Binns > Co-developed-by: Boris Brezi

Re: [PATCH v3 1/2] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2023-08-17 Thread kernel test robot
Hi Vivek, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip linus/master v6.5-rc6 next-20230817] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v5 14/17] drm/imagination: Implement job submission and scheduling

2023-08-17 Thread Jann Horn
On Wed, Aug 16, 2023 at 10:25 AM Sarah Walker wrote: > Implement job submission ioctl. Job scheduling is implemented using > drm_sched. [...] > +/** > + * pvr_job_data_fini() - Cleanup all allocs used to set up job submission. > + * @job_data: Job data array. > + * @job_count: Number of members of

Re: [PATCH v5 13/17] drm/imagination: Implement context creation/destruction ioctls

2023-08-17 Thread Jann Horn
On Wed, Aug 16, 2023 at 10:25 AM Sarah Walker wrote: > > Implement ioctls for the creation and destruction of contexts. Contexts are > used for job submission and each is associated with a particular job type. [...] > +/** > + * pvr_context_create() - Create a context. > + * @pvr_file: File to att

Re: [PATCH v5 08/17] drm/imagination: Add GEM and VM related code

2023-08-17 Thread Jann Horn
Hi! Thanks, I think it's great that Imagination is writing an upstream driver for PowerVR. :) On Wed, Aug 16, 2023 at 10:25 AM Sarah Walker wrote: > Add a GEM implementation based on drm_gem_shmem, and support code for the > PowerVR GPU MMU. The GPU VA manager is used for address space managemen

Re: [RFC PATCH v2 00/11] Device Memory TCP

2023-08-17 Thread Mina Almasry
On Thu, Aug 17, 2023 at 11:04 AM Pavel Begunkov wrote: > > On 8/14/23 02:12, David Ahern wrote: > > On 8/9/23 7:57 PM, Mina Almasry wrote: > >> Changes in RFC v2: > >> -- > ... > >> ** Test Setup > >> > >> Kernel: net-next with this RFC and memory provider API cherry-picked > >> lo

Re: [Patch v2 2/3] drm/mst: Refactor the flow for payload allocation/removement

2023-08-17 Thread Lyude Paul
Two small comments: On Mon, 2023-08-07 at 10:56 +0800, Wayne Lin wrote: > [Why] > Today, the allocation/deallocation steps and status is a bit unclear. > > For instance, payload->vc_start_slot = -1 stands for "the failure of > updating DPCD payload ID table" and can also represent as "payload is

Re: [PATCH v4] PCI/VGA: Make the vga_is_firmware_default() less arch-dependent

2023-08-17 Thread Bjorn Helgaas
On Wed, Aug 16, 2023 at 06:05:27AM +0800, Sui Jingfeng wrote: > Currently, the vga_is_firmware_default() function only works on x86 and > ia64, it is a no-op on ARM, ARM64, PPC, RISC-V, etc. This patch completes > the implementation for the rest of the architectures. The added code tries > to ident

Re: [PATCH 3/3] drm/mst: adjust the function drm_dp_remove_payload_part2()

2023-08-17 Thread Lyude Paul
On Mon, 2023-08-07 at 18:59 +0300, Imre Deak wrote: > On Mon, Aug 07, 2023 at 02:43:02AM +, Lin, Wayne wrote: > > [AMD Official Use Only - General] > > > > > -Original Message- > > > From: Imre Deak > > > Sent: Friday, August 4, 2023 11:32 PM > > > To: Lin, Wayne > > > Cc: dri-devel@

[PATCH] dma-buf/sw_sync: Avoid recursive lock during fence signal

2023-08-17 Thread Rob Clark
From: Rob Clark If a signal callback releases the sw_sync fence, that will trigger a deadlock as the timeline_fence_release recurses onto the fence->lock (used both for signaling and the the timeline tree). To avoid that, temporarily hold an extra reference to the signalled fences until after we

[git pull] drm fixes for 6.5-rc7

2023-08-17 Thread Dave Airlie
Hi Linus, Regular enough week, mostly the usual amdgpu and i915 fixes. Then qaic, nouveau, qxl and a revert for an EDID patch that had some side effects, along with a couple of panel fixes. Dave. drm-fixes-2023-08-18-1: drm fixes for 6.5-rc7 edid: - revert mode parsing fix that had side effects

Re: [PATCH v2] drm/i915/guc: Force a reset on internal GuC error

2023-08-17 Thread Ceraolo Spurio, Daniele
On 8/15/2023 5:39 PM, john.c.harri...@intel.com wrote: From: John Harrison If GuC hits an internal error (and survives long enough to report it to the KMD), it is basically toast and will stop until a GT reset and subsequent GuC reload is performed. Previously, the KMD just printed an error

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix init during host transfer

2023-08-17 Thread Tim Harvey
On Thu, Aug 17, 2023 at 1:59 PM Fabio Estevam wrote: > > Hi Tim, > > On Thu, Aug 17, 2023 at 5:53 PM Tim Harvey wrote: > > > Frieder, > > > > Sorry for the delay. Yes this resolves the regression I ran into. I > > tested it on top of v6.5-rc6 on a gw72xx-0x with a DFROBOT DRF0678 7in > > 800x480

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix init during host transfer

2023-08-17 Thread Fabio Estevam
Hi Tim, On Thu, Aug 17, 2023 at 5:53 PM Tim Harvey wrote: > Frieder, > > Sorry for the delay. Yes this resolves the regression I ran into. I > tested it on top of v6.5-rc6 on a gw72xx-0x with a DFROBOT DRF0678 7in > 800x480 (Raspberry Pi) display which has the Toshiba TC358762 > compatible DSI t

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix init during host transfer

2023-08-17 Thread Tim Harvey
On Mon, Jul 24, 2023 at 8:16 AM Frieder Schrempf wrote: > > From: Frieder Schrempf > > In case the downstream bridge or panel uses DSI transfers before the > DSI host was actually initialized through samsung_dsim_atomic_enable() > which clears the stop state (LP11) mode, all transfers will fail.

Re: [PATCH] clk: Annotate struct clk_hw_onecell_data with __counted_by

2023-08-17 Thread Gustavo A. R. Silva
On 8/17/23 14:30, Kees Cook wrote: Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIF

Re: [PATCH v2 2/4] arm64: dts: qcom: qrb5165-rb5: add onboard USB-C redriver

2023-08-17 Thread Bryan O'Donoghue
On 17/08/2023 15:59, Dmitry Baryshkov wrote: Add the nb7vpq904m, onboard USB-C redriver / retimer. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 52 +++- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qc

[PATCH] clk: Annotate struct clk_hw_onecell_data with __counted_by

2023-08-17 Thread Kees Cook
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family funct

[BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-17 Thread Mirsad Todorovac
Hi, This is your friendly bug reporter. The environment is vanilla torvalds tree kernel on Ubuntu 22.04 LTS and a Ryzen 7950X box. Please find attached the complete dmesg output from the ring buffer and lshw output. NOTE: The kernel reports tainted kernel, but to my knowledge there are no p

Re: [PATCH 3/4] drm/uapi: document the USB subconnector type

2023-08-17 Thread Dmitry Baryshkov
Simon, Laurent, On 03/08/2023 23:46, Simon Ser wrote: On Thursday, August 3rd, 2023 at 22:44, Laurent Pinchart wrote: On Thu, Aug 03, 2023 at 03:31:16PM +, Simon Ser wrote: On Thursday, August 3rd, 2023 at 17:22, Simon Ser cont...@emersion.fr wrote: The KMS docs describe "subconnecto

Re: [Freedreno] [PATCH 3/3] drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set

2023-08-17 Thread Abhinav Kumar
On 8/17/2023 11:50 AM, Dmitry Baryshkov wrote: On 08/08/2023 02:49, Abhinav Kumar wrote: On 6/4/2023 7:45 AM, Dmitry Baryshkov wrote: The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the INTF and WB are statically allocated to each encoder/phys_enc, drop the atomic_mode

Re: [PATCH 3/3] drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set

2023-08-17 Thread Dmitry Baryshkov
On 08/08/2023 02:49, Abhinav Kumar wrote: On 6/4/2023 7:45 AM, Dmitry Baryshkov wrote: The atomic_mode_set() callback only sets the phys_enc's IRQ data. As the INTF and WB are statically allocated to each encoder/phys_enc, drop the atomic_mode_set callback and set the IRQs during encoder init.

Re: linux-next: Tree for Aug 17 (DRM_TTM KUNIT tests)

2023-08-17 Thread Randy Dunlap
On 8/16/23 21:47, Stephen Rothwell wrote: > Hi all, > > Changes since 20230816: > on risc-v 32-bit: when # CONFIG_MMU is not set WARNING: unmet direct dependencies detected for DRM_TTM Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && MMU [=n] Selected by [y]: - DRM_TTM_KUNIT_TEST [=y] &&

Re: [PATCH] drm/panel: Add prepare_prev_first flag to Visionox VTDR6130

2023-08-17 Thread Dmitry Baryshkov
On 16/08/2023 10:51, neil.armstr...@linaro.org wrote: Hi Abhinav, On 14/08/2023 20:02, Abhinav Kumar wrote: Hi Neil On 8/14/2023 1:01 AM, neil.armstr...@linaro.org wrote: Hi Abhinav, On 10/08/2023 18:26, Abhinav Kumar wrote: Hi Neil On 8/3/2023 10:19 AM, Jessica Zhang wrote: On 7/31/202

[PATCH v5 5/5] drm/amdgpu: Create version number for coredumps

2023-08-17 Thread André Almeida
Even if there's nothing currently parsing amdgpu's coredump files, if we eventually have such tools they will be glad to find a version field to properly read the file. Create a version number to be displayed on top of coredump file, to be incremented when the file format or content get changed.

[PATCH v5 4/5] drm/amdgpu: Move coredump code to amdgpu_reset file

2023-08-17 Thread André Almeida
Giving that we use codedump just for device resets, move it's functions and structs to a more semantic file, the amdgpu_reset.{c, h}. Signed-off-by: André Almeida --- v5: no change --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 78 --

[PATCH v5 3/5] drm/amdgpu: Encapsulate all device reset info

2023-08-17 Thread André Almeida
To better organize struct amdgpu_device, keep all reset information related fields together in a separated struct. Signed-off-by: André Almeida --- v5: new patch, as requested by Shashank Sharma --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 34 + drivers/gpu/drm/amd/amdgp

[PATCH v5 2/5] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread André Almeida
Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically. This will make it easier to further expand the logged information. Signed-off-by: André Almeida --- v5: no change v4: change kmalloc to kzalloc --- drivers/gpu/d

[PATCH v5 0/5] drm/amdgpu: Rework coredump memory allocation

2023-08-17 Thread André Almeida
Hi, The patches of this set are a rework to alloc devcoredump dynamically and to move it to a better source file. Thanks, André Changelog: v4: https://lore.kernel.org/dri-devel/20230815195100.294458-1-andrealm...@igalia.com/ - New patch to encapsulate all reset info in a struct v3: h

[PATCH v5 1/5] drm/amdgpu: Allocate coredump memory in a nonblocking way

2023-08-17 Thread André Almeida
During a GPU reset, a normal memory reclaim could block to reclaim memory. Giving that coredump is a best effort mechanism, it shouldn't disturb the reset path. Change its memory allocation flag to a nonblocking one. Signed-off-by: André Almeida Reviewed-by: Christian König --- v5: no change ---

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-17 Thread Matthew Brost
On Thu, Aug 17, 2023 at 03:39:40PM +0200, Christian König wrote: > Am 11.08.23 um 04:31 schrieb Matthew Brost: > > Rather than call free_job and run_job in same work item have a dedicated > > work item for each. This aligns with the design and intended use of work > > queues. > > I would rather sa

[linux-next:master] BUILD REGRESSION 47762f08697484cf0c2f2904b8c52375ed26c8cb

2023-08-17 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 47762f08697484cf0c2f2904b8c52375ed26c8cb Add linux-next specific files for 20230817 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202307281049.40t8s0uv-...@intel.com https

Re: [PATCH v2 2/2] drm/edid: Fix "Analog composite sync!" for current eDP display panels

2023-08-17 Thread Dirk Lehmann
Hey Jani, On 8/17/23 15:05, Jani Nikula wrote: On Thu, 17 Aug 2023, Dirk Lehmann wrote: VESA Enhanced EDID Standard does not clearly describe how display panel vendors should setup the Sync Signal Defintions (bit 4 & 3) in the Detailed Timing Definition (relative offset 17, absolute offset 47h

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #17 from Alex Deucher (alexdeuc...@gmail.com) --- *blacklisted -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #16 from Alex Deucher (alexdeuc...@gmail.com) --- Does suspend work with gpu drivers backlisted? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH v3 2/4] drm/msm/dpu: Enable widebus for DSI INTF

2023-08-17 Thread Dmitry Baryshkov
On 08/08/2023 00:40, Jessica Zhang wrote: On 8/2/2023 11:20 AM, Dmitry Baryshkov wrote: On Wed, 2 Aug 2023 at 21:09, Jessica Zhang wrote: diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c index df88358e7037..dace6168be

[PATCH] drm/bridge: Fix kernel-doc typo in desc of output_bus_cfg in drm_bridge_state

2023-08-17 Thread Douglas Anderson
There's an obvious copy-paste error in the description of output_bus_cfg. Fix it. Fixes: f32df58acc68 ("drm/bridge: Add the necessary bits to support bus format negotiation") Signed-off-by: Douglas Anderson --- include/drm/drm_atomic.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-08-17 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #15 from popus_czy_to_ty (pentelja...@o2.pl) --- https://www.youtube.com/watch?v=8ttEvWNcMXM -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-17 Thread Christian König
Am 17.08.23 um 14:48 schrieb Danilo Krummrich: On 8/17/23 15:35, Christian König wrote: Am 17.08.23 um 13:13 schrieb Danilo Krummrich: On 8/17/23 07:33, Christian König wrote: [SNIP] My proposal would be to just keep the hw_submission_limit (maybe rename it to submission_unit_limit) and add a

[PATCH 11/17] drm/dp_mst: Add helper to determine if an MST port is downstream of another port

2023-08-17 Thread Imre Deak
Add drm_dp_mst_port_downstream_of_parent() required by the i915 driver in a follow-up patch to resolve a BW overallocation of MST streams going through a given MST port. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Signed-off-by: Imre Deak --- drivers/gpu/drm/display/drm_dp_mst_topology.c

[PATCH 13/17] drm/dp_mst: Swap the order of checking root vs. non-root port BW limitations

2023-08-17 Thread Imre Deak
drm_dp_mst_atomic_check_mgr() should check for BW limitation starting from sink ports continuing towards the root port, so that drivers can use the @failing_port returned to resolve a BW overallocation in an ideal way. For instance from streams A,B,C in a topology A,B going through @failing_port an

[PATCH 12/17] drm/dp_mst: Factor out a helper to check the atomic state of a topology manager

2023-08-17 Thread Imre Deak
Factor out a helper to check the atomic state for one MST topology manager, returning the MST port where the BW limit check has failed. This will be used in a follow-up patch by the i915 driver to improve the BW sharing between MST streams. Cc: Lyude Paul Cc: dri-devel@lists.freedesktop.org Signe

[PATCH 10/17] drm/dp_mst: Add a way to calculate PBN values with FEC overhead

2023-08-17 Thread Imre Deak
Add a way for drivers to calculate the MST PBN values with FEC overhead. This is required by 8b/10b links both for DSC and non-DSC (the latter needed if there are both DSC and non-DSC streams on the same MST link). Also add kunit test cases for PBN values calculated with FEC overhead. Cc: Lyude P

[PATCH 09/17] drm/dp_mst: Fix fractional bpp scaling in drm_dp_calc_pbn_mode()

2023-08-17 Thread Imre Deak
For fractional bpp values passed to the function in a .4 fixed point format, the fractional part is currently ignored due to scaling bpp too early. Fix this by scaling the overhead factor instead and to avoid an overflow multiplying bpp with the overhead factor instead of the clock rate. While at

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread Shashank Sharma
On 17/08/2023 17:38, André Almeida wrote: Em 17/08/2023 12:26, Shashank Sharma escreveu: On 17/08/2023 17:17, André Almeida wrote: Em 17/08/2023 12:04, Shashank Sharma escreveu: On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu: Hel

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread André Almeida
Em 17/08/2023 12:26, Shashank Sharma escreveu: On 17/08/2023 17:17, André Almeida wrote: Em 17/08/2023 12:04, Shashank Sharma escreveu: On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu: Hello Andre, On 15/08/2023 21:50, André Almeid

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread Shashank Sharma
On 17/08/2023 17:17, André Almeida wrote: Em 17/08/2023 12:04, Shashank Sharma escreveu: On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu: Hello Andre, On 15/08/2023 21:50, André Almeida wrote: Instead of storing coredump information

Re: [PATCH] dt-bindings: mxsfb: Exclude i.MX8MQ from power-domains requirement

2023-08-17 Thread Guido Günther
Hi, On Sun, Jul 30, 2023 at 09:41:20PM +0300, David Heidelberg wrote: > i.MX8MQ uses as secondary compatible fsl,imx6sx-lcdif, which triggers > requirement of power-domains, thou it's not required. > > Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL > power-domains prope

Re: [PATCH v3 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

2023-08-17 Thread kernel test robot
Hi Manikandan, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on lee-mfd/for-mfd-next lee-leds/for-leds-next lee-mfd/for-mfd-fixes linus/master v6.5-rc6 next-20230817] [If your patch is applied to the wrong

Re: [PATCH] drm/nouveau/disp: fix use-after-free in error handling of nouveau_connector_create

2023-08-17 Thread Borislav Petkov
On Thu, Aug 17, 2023 at 12:24:45PM +0200, Karol Herbst wrote: > simply throw a > > printk(KERN_WARNING "nvkm_uconn_uevent %u\n", outp->info.location); > > inside drivers/gpu/drm/nouveau/nvkm/engine/disp/uconn.c:104 after that > mentioned comment. diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread André Almeida
Em 17/08/2023 12:04, Shashank Sharma escreveu: On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu: Hello Andre, On 15/08/2023 21:50, André Almeida wrote: Instead of storing coredump information inside amdgpu_device struct, move if to a pr

Re: [PATCH v3 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

2023-08-17 Thread kernel test robot
Hi Manikandan, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on lee-mfd/for-mfd-next lee-leds/for-leds-next lee-mfd/for-mfd-fixes linus/master v6.5-rc6 next-20230817] [If your patch is applied to the wrong

mt8183 (google/krane): Resolution over USB-C adapter limited to 1280x720

2023-08-17 Thread Paul Menzel
Dear Linux folks, Using the ten inch tablet Lenovo IdeaPad Duet Chromebook 2in1 with recent ChromeOS, connecting a Dell DA200 (strange display chip inside) or Dell DA300z the available resolutions are limited to 1280x720 and not the supported 1920x1080. The Dell monitor is connected over HDMI

Re: [PATCH V2 1/2] dt-bindings: display: newvision,nv3051d: Add Anbernic 351V Support

2023-08-17 Thread Chris Morgan
On Fri, Aug 11, 2023 at 09:41:50AM -0500, Chris Morgan wrote: > On Thu, Aug 10, 2023 at 05:24:09PM -0600, Rob Herring wrote: > > On Wed, Aug 09, 2023 at 10:39:40AM -0500, Chris Morgan wrote: > > > From: Chris Morgan > > > > > > Document the Anbernic RG351V panel, which appears to be identical to

Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically

2023-08-17 Thread Shashank Sharma
On 17/08/2023 15:45, André Almeida wrote: Hi Shashank, Em 17/08/2023 03:41, Shashank Sharma escreveu: Hello Andre, On 15/08/2023 21:50, André Almeida wrote: Instead of storing coredump information inside amdgpu_device struct, move if to a proper separated struct and allocate it dynamically.

Re: [PATCH v1 0/3] udmabuf: Add support for page migration out of movable zone or CMA

2023-08-17 Thread Jason Gunthorpe
On Wed, Aug 16, 2023 at 11:49:31PM -0700, Vivek Kasireddy wrote: > This patch series adds support for migrating pages associated with > a udmabuf out of the movable zone or CMA to avoid breaking features > such as memory hotunplug. > > The first patch exports check_and_migrate_movable_pages() func

[PATCH v2 4/4] arm64: dts: qcom: qrb5165-rb5: enable DP altmode

2023-08-17 Thread Dmitry Baryshkov
Add displayport altmode declaration to the Type-C controller node to enable DP altmode negotiation. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/

[PATCH v2 3/4] arm64: dts: qcom: qrb5165-rb5: enable displayport controller

2023-08-17 Thread Dmitry Baryshkov
Enable the onboard displayport controller, connect it to QMP PHY. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts i

[PATCH v2 1/4] arm64: dts: qcom: sm8250: Add DisplayPort device node

2023-08-17 Thread Dmitry Baryshkov
Declare the displayport controller present on the Qualcomm SM8250 SoC. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 89 1 file changed, 89 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm825

[PATCH v2 2/4] arm64: dts: qcom: qrb5165-rb5: add onboard USB-C redriver

2023-08-17 Thread Dmitry Baryshkov
Add the nb7vpq904m, onboard USB-C redriver / retimer. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 52 +++- 1 file changed, 50 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qr

[PATCH v2 0/4] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-08-17 Thread Dmitry Baryshkov
Implement DisplayPort support for the Qualcomm RB5 platform. Note: while testing this, I had link training issues with several dongles with DP connectors. Other DisplayPort-USB-C dongles (with HDMI or VGA connectors) work perfectly. Dependencies: [1] Soft-dependencies: [2], [3] [1] https://lore

[PATCH v4 2/3] phy: qcom: qmp-combo: switch to DRM_AUX_BRIDGE

2023-08-17 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 2 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 44 ++---

[PATCH v4 3/3] usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE

2023-08-17 Thread Dmitry Baryshkov
Switch to using the new DRM_AUX_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Reviewed-by: Heikki Krogerus Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/mux/Kconfig | 2 +- drivers/usb/typec/mux/nb7vpq904m.c | 44 ++---

[PATCH v4 1/3] drm/bridge: add transparent bridge helper

2023-08-17 Thread Dmitry Baryshkov
Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. This is especially useful for DP/USB-C bridge chains, which can span across several devices, but do not require any additio

[PATCH v4 0/3] drm: simplify support for transparent DRM bridges

2023-08-17 Thread Dmitry Baryshkov
Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). This results in drivers having similar boilerplate code for such bridges. Next, these drivers are susceptible to -EPROBE_DEFER loops: the next bridge can either be probed from the bridge->attach ca

[PULL] drm-intel-fixes

2023-08-17 Thread Rodrigo Vivi
Hi Dave and Daniel, I'm covering for Tvrtko on this week's fixes flow. These 3 patches were queued since last week, but I had hold because I had some doubts about the CI results. I have confirmed those issues were not related to these 3 patches, so, here they are. drm-intel-fixes-2023-08-17: - F

Re: [PATCH v2 1/9] drm/sched: Convert drm scheduler to use a work queue rather than kthread

2023-08-17 Thread Danilo Krummrich
On 8/17/23 15:35, Christian König wrote: Am 17.08.23 um 13:13 schrieb Danilo Krummrich: On 8/17/23 07:33, Christian König wrote: [SNIP] The hardware seems to work mostly the same for all vendors, but you somehow seem to think that filling the ring is somehow beneficial which is really not the

[PATCH 16/18] drm/i915/dp: Get optimal link config to have best compressed bpp

2023-08-17 Thread Ankit Nautiyal
Currently, we take the max lane, rate and pipe bpp, to get the maximum compressed bpp possible. We then set the output bpp to this value. This patch provides support to have max bpp, min rate and min lanes, that can support the min compressed bpp. v2: -Avoid ending up with compressed bpp, same as

[PATCH 18/18] drm/i915/dp: Check if force_dsc_output_format is possible

2023-08-17 Thread Ankit Nautiyal
Currently for testing an output format with DSC, we just force the output format, without checking if it can be supported. This also creates an issue where there is a PCON which might need to convert from forced output format to the format to sink format. Signed-off-by: Ankit Nautiyal Reviewed-by

[PATCH 13/18] drm/i915/dp: Separate out functions for edp/DP for computing DSC bpp

2023-08-17 Thread Ankit Nautiyal
Refactor code to separate functions for eDP and DP for computing pipe_bpp/compressed bpp when DSC is involved. This will help to optimize the link configuration for DP later. v2: Fix checkpatch warning. Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/di

[PATCH 11/18] drm/i915/dp: Avoid left shift of DSC output bpp by 4

2023-08-17 Thread Ankit Nautiyal
To make way for fractional bpp support, avoid left shifting the output_bpp by 4 in helper intel_dp_dsc_get_output_bpp. Signed-off-by: Ankit Nautiyal Reviewed-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/display/intel_dp.c | 10 +++--- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2

[PATCH 14/18] drm/i915/dp: Add DSC BPC/BPP constraints while selecting pipe bpp with DSC

2023-08-17 Thread Ankit Nautiyal
Currently we check if the pipe_bpp selected is >= the min DSC bpc/bpp requirement. We do not check if it is <= the max DSC bpc/bpp requirement. Add checks for max DSC BPC/BPP constraints while computing the pipe_bpp when DSC is in use. v2: Fix the commit message. Signed-off-by: Ankit Nautiyal R

[PATCH 04/18] drm/i915/dp: Use consistent name for link bpp and compressed bpp

2023-08-17 Thread Ankit Nautiyal
Currently there are many places where we use output_bpp for link bpp and compressed bpp. Lets use consistent naming: output_bpp : The intermediate value taking into account the output_format chroma subsampling. compressed_bpp : target bpp for the DSC encoder. link_bpp : final bpp used in the link.

[PATCH 05/18] drm/i915/dp: Update Bigjoiner interface bits for computing compressed bpp

2023-08-17 Thread Ankit Nautiyal
In Bigjoiner check for DSC, bigjoiner interface bits for DP for DISPLAY > 13 is 36 (Bspec: 49259). v2: Corrected Display ver to 13. v3: Follow convention for conditional statement. (Ville) v4: Fix check for display ver. (Ville) v5: Added note for 2 PPC. (Stan) Signed-off-by: Ankit Nautiyal Re

[PATCH 10/18] drm/i915/dp: Check min bpc DSC limits for dsc_force_bpc also

2023-08-17 Thread Ankit Nautiyal
For DSC the min BPC is 8 for ICL+ and so the min pipe_bpp is 24. Check this condition for cases where bpc is forced by debugfs flag dsc_force_bpc. If the check fails, then WARN and ignore the debugfs flag. For MST case the pipe_bpp is already computed (hardcoded to be 24), and this check is not re

  1   2   >