[PATCH] drm/amdgpu: Clean up errors in uvd_v7_0.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that ':' (ctx:VxE) that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH] drm/amd: Clean up errors in amdgpu_cgs.c

Fix the following errors reported by checkpatch: ERROR: switch and case should be at the same indent Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH] drm/amdgpu/atomfirmware: Clean up errors in amdgpu_atomfirmware.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '>=' (ctx:WxV) ERROR: spaces required around that '!=' (ctx:WxV) ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 1 file

[PATCH] drm/amdgpu: Clean up errors in mmhub_v9_4.c

Fix the following errors reported by checkpatch: ERROR: code indent should use tabs where possible ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/mmhub_v9_4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH] drm/amdgpu: Clean up errors in vega20_ih.c

Fix the following errors reported by checkpatch: ERROR: trailing statements should be on next line ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

[PATCH] drm/amdgpu: Clean up errors in ih_v6_0.c

Fix the following errors reported by checkpatch: ERROR: trailing statements should be on next line ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dr

[PATCH] drm/amdgpu: Clean up errors in amdgpu_psp.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: open brace '{' following enum go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 12 1 file changed, 4 insertions(+), 8 deletions

[PATCH] drm/amdgpu: Clean up errors in vce_v3_0.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v3_0.c b/drivers

[PATCH] accel/ivpu: Add set_pages_array_wc/uc for internal buffers

From: Karol Wachowski Buffers mapped with pgprot_writecombined() are not correctly flushed. This triggers issues on VPU access using random memory content such as MMU translation faults, invalid context descriptors being fetched and can lead to VPU FW crashes. Fixes: 647371a6609d ("accel/ivpu: A

[PATCH] drm/amd/display: Clean up errors in dmub_cmd.h

Fix the following errors reported by checkpatch: ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/a

[PATCH] drm/amd/display: Clean up errors in dce_clk_mgr.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '?' (ctx:VxE) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c b/d

Re: [PATCH] PCI/VGA: Fixup the firmware fb address om demanding time

Hi, On 2023/8/2 11:40, kernel test robot wrote: Hi Sui, kernel test robot noticed the following build errors: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus linus/master v6.5-rc4 next-20230801] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH 1/3] drm/mediatek: Dynamically allocate CMDQ and use helper functions

[PATCH] drm/amd/display: Clean up errors in display_mode_vba_30.c

Fix the following errors reported by checkpatch: ERROR: else should follow close brace '}' Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/dml/dcn30/display_mode_vba_30.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn30/di

[PATCH] drm/amd/display: Clean up errors in dc_stream.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream

Re: [PATCH v7 3/4] drm/mediatek: Add ability to support dynamic connector selection

Re: [PATCH v2] dma-contiguous: define proper name for global cma region

On Tue, Aug 1, 2023 at 10:18 AM Christoph Hellwig wrote: > > On Tue, Aug 01, 2023 at 10:42:42PM +0530, Pintu Agarwal wrote: > > > I agree that reserved is not a very useful name. Unfortuately the > > > name of the region leaks to userspace through cma_heap. > > > > > > So I think we need prep pat

linux-next: build warning after merge of the drm-misc tree

Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/drm_panel.h:270: warning: Function parameter or member 'follower_lock' not described in 'drm_panel' Introduced by commit de0874165b83 ("drm/panel: Add a way for other devices to fo

linux-next: build warning after merge of the drm-misc tree

Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/todo.rst:469: ERROR: Unexpected indentation. Introduced by commit d2aacaf07395 ("drm/panel: Check for already prepared/enabled in drm_panel") -- Cheers, Stephen Rothwell p

Re: [PATCH v8 08/13] drm/mediatek: gamma: Support multi-bank gamma LUT

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

On Mon, Jul 17, 2023 at 01:40:38PM -0400, Luben Tuikov wrote: > On 2023-07-16 03:51, Asahi Lina wrote: > > On 15/07/2023 16.14, Luben Tuikov wrote: > >> On 2023-07-14 04:21, Asahi Lina wrote: > >>> drm_sched_fini() currently leaves any pending jobs dangling, which > >>> causes segfaults and other b

Re: [PATCH v8 07/13] drm/mediatek: gamma: Support specifying number of bits per LUT component

Re: [PATCH] PCI/VGA: Fixup the firmware fb address om demanding time

Hi Sui, kernel test robot noticed the following build errors: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus linus/master v6.5-rc4 next-20230801] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/amd/display: Clean up errors in bios_parser2.c

Fix the following errors reported by checkpatch: ERROR: switch and case should be at the same indent ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../drm/amd/display/dc/bios/bios_parser2.c| 32 +-- 1 file changed, 16 insertions(+), 16 deletion

[PATCH] drm/amd/display: Clean up errors in dcn316_smu.c

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 18 -- 1 file changed, 8 insertions(+), 10 de

[PATCH] drm/amd/display: Clean up errors in dcn315_smu.c

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: code indent should use tabs where possible Signed-off-by: Ran Sun --- .../display/dc/clk_mgr/dcn315/dcn315_smu.c| 26 +-- 1 file changed, 12 insertions(+), 14 d

[PATCH] drm/amd/display: Clean up errors in dce112_hw_sequencer.c

Fix the following errors reported by checkpatch: ERROR: space required before the open brace '{' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce112/dce112_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce11

[PATCH] drm/amd/display: Clean up errors in dce110_hw_sequencer.c

Fix the following errors reported by checkpatch: ERROR: space required before the open brace '{' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce11

[PATCH] drm/amd/display: Clean up errors in dce110_timing_generator.c

Fix the following errors reported by checkpatch: ERROR: spaces required around that '=' (ctx:WxV) Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/dce110/dce110_timing_generator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce11

[PATCH] drm/amd/dc: Clean up errors in hpd_regs.h

Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/hpd_regs.h

[PATCH] drm/amd/display: Clean up errors in ddc_regs.h

Fix the following errors reported by checkpatch: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Ran Sun --- .../gpu/drm/amd/display/dc/gpio/ddc_regs.h| 40 +-- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/

[PATCH] drm/amd/display: Clean up errors in color_gamma.c

Fix the following errors reported by checkpatch: ERROR: trailing whitespace ERROR: else should follow close brace '}' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/d

Re: [PATCH v14 02/12] drm/shmem-helper: Add pages_pin_count field

On 7/31/23 15:35, Boris Brezillon wrote: +Danilo, to confirm my understanding of the gpuva remap operation is correct. Your understanding is correct. Unfortunately, re-mapping things has such implications. I'm currently working on tracking external GEM objects in the GPUVA manager, where, id

[PATCH] drm/amd/pm: Clean up errors in amdgpu_pm.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space required before the open parenthesis '(' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH] PCI/VGA: Fixup the firmware fb address om demanding time

Hi Sui, kernel test robot noticed the following build warnings: [auto build test WARNING on pci/next] [also build test WARNING on pci/for-linus linus/master v6.5-rc4 next-20230801] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

[PATCH] drm/amd/pm: Clean up errors in sislands_smc.h

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/legacy-dpm/sislands_smc.h | 63 +++ 1 file changed, 21 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/lega

[PATCH] drm/amd/pm: Clean up errors in kv_dpm.c

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) ERROR: need consistent spacing around '-' (ctx:WxV) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 48 -

[PATCH] drm/amd/pm: Clean up errors in r600_dpm.h

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/r600_dpm.h b/

[PATCH] drivers/amd/pm: Clean up errors in smu8_smumgr.h

Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 48 -- 1 file changed, 17 insertions(+), 31 dele

[PATCH] drm/amd/pm: Clean up errors in smu8_smumgr.h

Fix the following errors reported by checkpatch: ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/smu8_smumgr.h b/drivers/g

[PATCH] drm/amd/pm: Clean up errors in smu75.h

Fix the following errors reported by checkpatch: ERROR: space prohibited before open square bracket '[' ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu75.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH] drm/amd/pm: Clean up errors in smu73.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu73.h | 45 ---

[PATCH] drm/amd/pm: Clean up errors in hwmgr.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: Use C99 flexible arrays Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/

Re: [PATCH -next] drm/tests: Fix one kernel-doc comment

On 8/1/23 17:46, Yang Li wrote: > Make @drm_kunit_helper_context_alloc to > @drm_kunit_helper_acquire_ctx_alloc, to silence the warning: > > drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype > for drm_kunit_helper_context_alloc(). Prototype was for > drm_kunit_helper

[PATCH] drm/amd/pm: Clean up errors in hardwaremanager.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/hardwaremanager.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/in

[PATCH] drm/amd/pm: Clean up errors in pp_thermal.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/pp_thermal.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc

[PATCH] drm/amd/pm: Clean up errors in smu7.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.

[PATCH] drm/amd/pm: Clean up errors in smu7_fusion.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- .../drm/amd/pm/powerplay/inc/smu7_fusion.h| 42 +++ 1 file changed, 16 insertions(+),

[PATCH] drm/amd/pm: Clean up errors in smu71.h

Fix the following errors reported by checkpatch: ERROR: open brace '{' following struct go on the same line ERROR: space prohibited before open square bracket '[' Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/powerplay/inc/smu71.h | 22 +++- 1 file changed, 8 insertions(+),

Re: [PATCH v2 4/7] drm/msm/mdss: populate missing data

On 7/28/2023 2:33 PM, Dmitry Baryshkov wrote: As we are going to use MDSS data for DPU programming, populate missing MDSS data. The UBWC 1.0 and no UBWC cases do not require MDSS programming, so skip them. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 21

[PATCH v3 2/3] phy: qcom: qmp-combo: switch to DRM_SIMPLE_BRIDGE

Switch to using the new DRM_SIMPLE_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Signed-off-by: Dmitry Baryshkov --- drivers/phy/qualcomm/Kconfig | 2 +- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 44 ++

[PATCH v3 3/3] usb: typec: nb7vpq904m: switch to DRM_SIMPLE_BRIDGE

Switch to using the new DRM_SIMPLE_BRIDGE helper to create the transparent DRM bridge device instead of handcoding corresponding functionality. Signed-off-by: Dmitry Baryshkov --- drivers/usb/typec/mux/Kconfig | 2 +- drivers/usb/typec/mux/nb7vpq904m.c | 44 ++

[PATCH v3 0/3] drm/display: simplify support for transparent DRM bridges

Supporting DP/USB-C can result in a chain of several transparent bridges (PHY, redrivers, mux, etc). This results in drivers having similar boilerplate code for such bridges. Next, these drivers are susceptible to -EPROBE_DEFER loops: the next bridge can either be probed from the bridge->attach ca

[PATCH v3 1/3] drm/display: add transparent bridge helper

Define a helper for creating simple transparent bridges which serve the only purpose of linking devices into the bridge chain up to the last bridge representing the connector. This is especially useful for DP/USB-C bridge chains, which can span across several devices, but do not require any additio

Re: [PATCH] drm/amd/pm: Clean up errors in smu73_discrete.h

On 01/08/2023 18:34, Jani Nikula wrote: > On Tue, 01 Aug 2023, Bagas Sanjaya wrote: >> And it is unfortunate that you and @208suo.com people doesn't reply to >> review comments (try searching lore.kernel.org) > > Essentially a one-way firehose of patches pointed at our general > direction is not

[PATCH -next] drm/tests: Fix one kernel-doc comment

Make @drm_kunit_helper_context_alloc to @drm_kunit_helper_acquire_ctx_alloc, to silence the warning: drivers/gpu/drm/tests/drm_kunit_helpers.c:172: warning: expecting prototype for drm_kunit_helper_context_alloc(). Prototype was for drm_kunit_helper_acquire_ctx_alloc() instead Reported-by: Abac

RE: [PATCH -next] drm/amd/pm: Remove many unnecessary NULL values

[AMD Official Use Only - General] Reviewed-by: Evan Quan > -Original Message- > From: Ruan Jinjie > Sent: Tuesday, August 1, 2023 8:55 PM > To: Quan, Evan ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@gmail.com; dan...@ffwll.ch; mrip...@kernel.org; > tzimmerm...

Re: [PATCH v5 22/22] checkpatch: reword long-line warn about commit-msg

On Tue, 2023-08-01 at 17:35 -0600, Jim Cromie wrote: > Reword the warning to complain about line length 1st, since thats > whats actually tested. [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -3272,7 +3272,7 @@ sub process { > # A Fixe

[PATCH v5 20/22] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers

Add a DRM_CLASSMAP_USE declaration to 2nd batch of helpers and *_drv.c files. For drivers, add the decl just above the module's PARAMs, since it identifies the "inherited" drm.debug param. Note: with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, a module not also declaring DRM_CLASSMAP_USE will have its class'

[PATCH v5 21/23] drm-drivers: DRM_CLASSMAP_USE in 2nd batch of drivers, helpers

Add a DRM_CLASSMAP_USE declaration to 2nd batch of helpers and *_drv.c files. For drivers, add the decl just above the module's PARAMs, since it identifies the "inherited" drm.debug param. Note: with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, a module not also declaring DRM_CLASSMAP_USE will have its class'

[PATCH v5 22/22] checkpatch: reword long-line warn about commit-msg

Reword the warning to complain about line length 1st, since thats whats actually tested. Cc: a...@canonical.com Cc: j...@perches.com Signed-off-by: Jim Cromie --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.

[PATCH v5 19/23] dyndbg-test: build it with just CONFIG_DYNAMIC_DEBUG_CORE

Make the test-module buildable with CONFIG_DYNAMIC_DEBUG_CORE; add CFLAGS_$ofile defns to supply -DDYNAMIC_DEBUG_MODULE to cc. Change the Kconfig entry to allow building with just _CORE, and fix the help text. Signed-off-by: Jim Cromie --- lib/Kconfig.debug | 10 +- lib/Makefile |

[PATCH v5 22/23] dyndbg-doc: add classmap info to howto

Add some basic info on classmap usage and api Signed-off-by: Jim Cromie --- v5- adjustments per Randy Dunlap --- .../admin-guide/dynamic-debug-howto.rst | 64 ++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst

[PATCH v5 23/23] checkpatch: reword long-line warn about commit-msg

Reword the warning to complain about line length 1st, since thats whats actually tested. Cc: a...@canonical.com Cc: j...@perches.com Signed-off-by: Jim Cromie --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.

[PATCH v5 21/22] dyndbg-doc: add classmap info to howto

Add some basic info on classmap usage and api Signed-off-by: Jim Cromie --- .../admin-guide/dynamic-debug-howto.rst | 64 ++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic

[PATCH v5 20/23] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

Lots of burn-in testing needed before signing, upstreaming. NOTE: I set default Y to maximize testing by default. Is there a better way to do this ? Signed-off-by: Jim Cromie --- drivers/gpu/drm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/Kconfi

[PATCH v5 15/23] dyndbg: add for_each_boxed_vector

Add a for_each iterator to walk a counted vector member in a struct (ie the box), and use it to replace 8 open-coded loops. Signed-off-by: Jim Cromie --- v5- parens-on-box-force-precedence --- lib/dynamic_debug.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff -

[PATCH v5 19/22] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN

Lots of burn-in testing needed before signing, upstreaming. NOTE: I set default Y to maximize testing by default. Is there a better way to do this ? Signed-off-by: Jim Cromie --- drivers/gpu/drm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/Kconfi

[PATCH v5 16/23] dyndbg: refactor ddebug_classparam_clamp_input

Extract input validation code, from param_set_dyndbg_module_classes() (the sys-node >handler) to new: ddebug_classparam_clamp_input(kp), call it from former. It takes kernel-param arg, so it can complain about "foo: bad input". Reuse ddparam_clamp_input(kp) in ddebug_sync_classbits(), to validate

[PATCH v5 18/23] parens-on-PARAM

--- include/linux/dynamic_debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 871de0c32034..9b86c49173f9 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -172,9 +172,9 @

[PATCH v5 18/22] dyndbg-test: build it with just CONFIG_DYNAMIC_DEBUG_CORE

Make the test-module buildable with CONFIG_DYNAMIC_DEBUG_CORE; add CFLAGS_$ofile defns to supply -DDYNAMIC_DEBUG_MODULE to cc. Change the Kconfig entry to allow building with just _CORE, and fix the help text. Signed-off-by: Jim Cromie --- lib/Kconfig.debug | 10 +- lib/Makefile |

[PATCH v5 17/23] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API

move macro from test-dynamic-debug.c into header, and refine it. Distinguish the 2 use cases of DYNDBG_CLASSMAP_PARAM* 1.DYNDBG_CLASSMAP_PARAM_REF for DRM, to pass in extern __drm_debug by name. dyndbg keeps bits in it, so drm can still use it as before 2.DYNDBG_CLASSMAP_PARAM new us

[PATCH v5 14/23] dyndbg-API: fix CONFIG_DRM_USE_DYNAMIC_DEBUG regression

DECLARE_DYNDBG_CLASSMAP() has a design error; it fails a basic K&R rule: "define once, refer many times". When DRM_USE_DYNAMIC_DEBUG=y, DECLARE_DYNDBG_CLASSMAP() is used across DRM core & drivers; they all repeat the same classmap-defn args, which must match for the modules to respond together whe

[PATCH v5 13/23] checkpatch: special case for file-scoped extern linker-symbol

"externs should be avoided in .c files" needs an exception for linker symbols, like those that mark the start, stop of many kernel sections. Since code already checks REALNAME to avoid linker-scripts entirely, add a new else-if block to look at them instead. As a simple heuristic, treat all words

[PATCH v5 13/22] checkpatch: file-scoped extern special case for linker-symbol

"externs should be avoided in .c files" needs an exception for linker symbols, like those that mark the start, stop of many kernel sections. Since code already checks REALNAME to avoid linker-scripts entirely, add a new else-if block to look at them instead. As a simple heuristic, treat all words

[PATCH v5 11/23] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap

old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-

[PATCH v5 08/23] dyndbg: reduce verbose/debug clutter

currently, for verbose=3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op='+' dyndbg: flags=0x1 dyndbg: *flagsp=0x1 *maskp=0x dyndbg: parsed: func="" file="" module="" format="

[PATCH v5 12/23] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code

Remove the NAMED class types; these 2 classmap types accept class names at the PARAM interface, for example: echo +DRM_UT_CORE,-DRM_UT_KMS > /sys/module/drm/parameters/debug_names The code works, but its only used by test-dynamic-debug, and wasn't asked for by anyone else, so simplify things fo

[PATCH v5 06/23] dyndbg: split param_set_dyndbg_classes to module/wrapper fns

rename param_set_dyndbg_classes: add _module_ name & arg, old name is wrapper to new. New arg allows caller to specify that only one module is affected by a prdbgs update. Outer fn preserves kernel_param interface, passing NULL to inner fn. This selectivity will be used later to narrow the scope

[PATCH v5 09/23] dyndbg: silence debugs with no-change updates

check for actual changes before announcing them, declutter logs. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 4200c72fed09..7430add36423 100644 --- a/lib/dynamic_

[PATCH v5 10/23] dyndbg: tighten ddebug_class_name() 1st arg type

Change function's 1st arg-type, and deref in the caller. The fn doesn't need any other fields in the struct. no functional change. Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_d

[PATCH v5 05/23] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it

Add query_module param to ddebug_apply_class_bitmap(). This allows its caller to update just one module, or all (as currently). We'll use this later to propagate drm.debug to each USEr as they're modprobed. No functional change. Signed-off-by: Jim Cromie --- after `modprobe i915`, heres the m

[PATCH v5 07/23] dyndbg: drop NUM_TYPE_ARRAY

ARRAY_SIZE works here, since array decl is complete. no functional change Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 596d0664c29f..719c5b6a

[PATCH v5 03/23] dyndbg: make ddebug_class_param union members same size

struct ddebug_class_param keeps a ref to the state-storage of the param, make both flavors use the same unsigned long under-type. ISTM this is simpler and safer. Signed-off-by: Jim Cromie --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertion

[PATCH v5 04/23] dyndbg: replace classmap list with a vector

Classmaps are stored/linked in a section/array, but are each added to the module's ddebug_table.maps list-head. This is unnecessary; even when ddebug_attach_classmap() is handling the builtin section (with classmaps for multiple builtin modules), its contents are ordered, so a module's possibly mu

[PATCH v5 02/23] test-dyndbg: fixup CLASSMAP usage error

more careful reading of test output reveals: lib/test_dynamic_debug.c:103 [test_dynamic_debug]do_cats =pmf "doing categories\n" lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n" class:MID lib/test_dynamic_debug.c:106 [test_dynamic_debug]do_cats =p "MID msg\n" class:HI lib/t

[PATCH v5 01/23] drm: use correct ccflags-y syntax

Incorrect CFLAGS- usage failed to add -DDYNAMIC_DEBUG_MODULE, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=y CONFIG_DYNAMIC_DEBUG_CORE=y but without DYNAMIC_DEBUG Nobody noticed because a larger regression emerged. Also add subdir-ccflags so that all drivers pick up the addition. Fixes

[PATCH v5 00/22] fix DRM_USE_DYNAMIC_DEBUG regression

Hi Jason, Daniel Since patchwork puked on v5 just sent, Im calling this v5b. Its also on github remote: Create a pull request for 'dd-fix-5b' on GitHub by visiting: remote: https://github.com/jimc/linux/pull/new/dd-fix-5b remote: To github.com:jimc/linux.git * [new branch]d

Re: [PATCH] drm/nouveau: fixup the uapi header file.

Hi Dave, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.5-rc4 next-20230801] [If

Re: [PATCH] PCI/VGA: Fixup the firmware fb address om demanding time

Hi Sui, kernel test robot noticed the following build warnings: [auto build test WARNING on pci/next] [also build test WARNING on pci/for-linus linus/master v6.5-rc4 next-20230801] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH v5 02/10] drm/msm/dpu: bail from _dpu_core_perf_crtc_update_bus if there are no ICC paths

On 7/29/2023 6:00 PM, Dmitry Baryshkov wrote: Skip bandwidth aggregation and return early if there are no interconnect paths defined for the DPU device. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletio

[GIT PULL FOR v6.6] drm: xilinx: Miscellaneous fixes

Hello, The following changes since commit 52920704df878050123dfeb469aa6ab8022547c1: Merge tag 'drm-misc-next-2023-07-27' of git://anongit.freedesktop.org/drm/drm-misc into drm-next (2023-07-27 15:01:26 +0200) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kerne

Re: [PATCH 02/37] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp

Jon, Mauro, would you have any feedback on this ? On Tue, Mar 21, 2023 at 01:15:51AM +0200, Laurent Pinchart wrote: > Hi Lee, > > (CC'ing Jon and Mauro) > > On Mon, Mar 20, 2023 at 08:17:00AM +, Lee Jones wrote: > > On Sun, 19 Mar 2023, Laurent Pinchart wrote: > > > Thank you for the patch. >

Re: [PATCH] drm/modes: Fix division by zero error

Hi Jani, Thank you so much for the suggestions! I've submitted a V2 patch with the updated code, and also a patch test request which should come back soon. Please let me know if the new version looks good. Best regards, Ziqi

Re: [RFC v1 1/3] mm/mmu_notifier: Add a new notifier for mapping updates (new pages)

On Tue, Aug 01, 2023 at 07:11:09AM +, Kasireddy, Vivek wrote: > Ok, I'll keep your use-case in mind but AFAICS, the process that creates > the udmabuf can be considered the owner. So, I think it makes sense that > the owner's VMA range can be registered (via mmu_notifiers) for updates. No need

[PATCH v2] drm/modes: Fix division by zero error

In the bug reported by Syzbot, the variable `den == (1 << 22)` and `mode->vscan == (1 << 10)`, causing the multiplication to overflow and accidentally make `den == 0`. To prevent any chance of overflow, we replace `num` and `den` with 64-bit unsigned integers, and explicitly check if the divisor `d

Re: [PATCH -next] drm: xlnx: zynqmp_dpsub: Use devm_platform_ioremap_resource_byname()

Hi Li, Thank you for the patch. On Tue, Aug 01, 2023 at 04:32:20PM +0800, Li Zetao wrote: > Convert platform_get_resource_byname() + devm_ioremap_resource() to a > single call to devm_platform_ioremap_resource_byname(), as this is > exactly what this function does. > > Signed-off-by: Li Zetao

Re: [PATCH] drm/nouveau: fixup the uapi header file.

Hi Dave, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.5-rc4 next-20230801] [If

Re: [PATCH v3] drm/bridge: Add debugfs print for bridge chains

Hi Tomi, Thank you for the patch. On Mon, Jul 31, 2023 at 03:13:14PM +0300, Tomi Valkeinen wrote: > DRM bridges are not visible to the userspace and it may not be > immediately clear if the chain is somehow constructed incorrectly. I > have had two separate instances of a bridge driver failing to

Re: [PATCH] drm/msm/dpu: Drop encoder vsync_event

On 8/1/2023 1:37 PM, Dmitry Baryshkov wrote: On 01/08/2023 23:18, Jessica Zhang wrote: Drop vsync_event and vsync_event_work handlers as they are unnecessary. Signed-off-by: Jessica Zhang ---   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 65 +   drivers/gpu/dr

  1   2   3   4   >