Re: [PATCH 0/5] arm64: dts: qcom: qrb5165-rb5: enable DP support

2023-07-21 Thread Bjorn Andersson
On Tue, Jul 18, 2023 at 09:09:41AM +0300, Dmitry Baryshkov wrote: > On 18/07/2023 07:37, Bjorn Andersson wrote: > > On Sun, Jul 09, 2023 at 07:19:21AM +0300, Dmitry Baryshkov wrote: > > > Implement DisplayPort support for the Qualcomm RB5 platform. > > > > > > Note: while testing this, I had link

Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

2023-07-21 Thread Miguel Ojeda
On Sat, Jul 22, 2023 at 2:50 AM Javier Martinez Canillas wrote: > > Got it. Then that's yet another argument for adding the auxdisplay > drivers under the same "Graphics support" menu. Just in case it matters for Helge/you: these may also register an input device, e.g. the ht16k33 has a matrix ke

Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

2023-07-21 Thread Javier Martinez Canillas
Miguel Ojeda writes: > On Sat, Jul 22, 2023 at 2:13 AM Javier Martinez Canillas > wrote: >> >> Oh, interesting. I wonder why that couldn't had been a fbdev driver then >> using FB_VISUAL_MONO01? I'll reword then the commit message before apply >> to the following instead: > > It is :) > > .t

Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

2023-07-21 Thread Miguel Ojeda
On Sat, Jul 22, 2023 at 2:13 AM Javier Martinez Canillas wrote: > > Oh, interesting. I wonder why that couldn't had been a fbdev driver then > using FB_VISUAL_MONO01? I'll reword then the commit message before apply > to the following instead: It is :) .type = FB_TYPE_PACKED_PIXELS, .vis

Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

2023-07-21 Thread Javier Martinez Canillas
Miguel Ojeda writes: Hello Miguel, > On Sat, Jul 22, 2023 at 12:46 AM Javier Martinez Canillas > wrote: >> >> Javier Martinez Canillas writes: >> >> [adding Miguel Ojeda who was not in the Cc list] >> >> Hello Miguel, could you please ack this patch so that I can take the whole >> patch-set th

Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

2023-07-21 Thread Miguel Ojeda
On Sat, Jul 22, 2023 at 12:46 AM Javier Martinez Canillas wrote: > > Javier Martinez Canillas writes: > > [adding Miguel Ojeda who was not in the Cc list] > > Hello Miguel, could you please ack this patch so that I can take the whole > patch-set through the drm-misc tree? A note below... > > Th

Re: [PATCH drm-misc-next v8 03/12] drm/nouveau: new VM_BIND uapi interfaces

2023-07-21 Thread Faith Ekstrand
On Wed, Jul 19, 2023 at 7:15 PM Danilo Krummrich wrote: > This commit provides the interfaces for the new UAPI motivated by the > Vulkan API. It allows user mode drivers (UMDs) to: > > 1) Initialize a GPU virtual address (VA) space via the new >DRM_IOCTL_NOUVEAU_VM_INIT ioctl. UMDs can provid

Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

2023-07-21 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: [adding Miguel Ojeda who was not in the Cc list] Hello Miguel, could you please ack this patch so that I can take the whole patch-set through the drm-misc tree? > The drivers in this subsystem are for character-based LCD displays, which > can fall into the same

Re: [PATCH 1/8] drm/ssd130x: Fix pitch calculation in ssd130x_fb_blit_rect()

2023-07-21 Thread Javier Martinez Canillas
Javier Martinez Canillas writes: Hello Geert, > Geert Uytterhoeven writes: > [...] >> >> My point is that the 8 as used here is related to the number of bits per >> pixel, >> not to the page height. The page height might also be impacted by the >> number of bits per pixel, but that is ortho

Re: [PATCH 16/17] cgroup/drm: Expose memory stats

2023-07-21 Thread Tejun Heo
On Wed, Jul 12, 2023 at 12:46:04PM +0100, Tvrtko Ursulin wrote: > $ cat drm.memory.stat > card0 region=system total=12898304 shared=0 active=0 resident=12111872 > purgeable=167936 > card0 region=stolen-system total=0 shared=0 active=0 resident=0 purgeable=0 > > Data is generated on demand f

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Belgaumkar, Vinay
On 7/21/2023 3:08 PM, Belgaumkar, Vinay wrote: On 7/21/2023 2:23 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 01:44:34PM -0700, Belgaumkar, Vinay wrote: On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: This should be done before

Re: [PATCH 15/17] cgroup/drm: Expose GPU utilisation

2023-07-21 Thread Tejun Heo
On Fri, Jul 21, 2023 at 12:19:32PM -1000, Tejun Heo wrote: > On Wed, Jul 12, 2023 at 12:46:03PM +0100, Tvrtko Ursulin wrote: > > + drm.active_us > > + GPU time used by the group recursively including all child groups. > > Maybe instead add drm.stat and have "usage_usec" inside? That'd be more >

Re: [PATCH 15/17] cgroup/drm: Expose GPU utilisation

2023-07-21 Thread Tejun Heo
On Wed, Jul 12, 2023 at 12:46:03PM +0100, Tvrtko Ursulin wrote: > + drm.active_us > + GPU time used by the group recursively including all child groups. Maybe instead add drm.stat and have "usage_usec" inside? That'd be more consistent with cpu side. Thanks. -- tejun

Re: [PATCH 12/17] cgroup/drm: Introduce weight based drm cgroup control

2023-07-21 Thread Tejun Heo
On Wed, Jul 12, 2023 at 12:46:00PM +0100, Tvrtko Ursulin wrote: > +DRM scheduling soft limits > +~~ Please don't say soft limits for this. It means something different for memcg, so it gets really confusing. Call it "weight based CPU time control" and maybe call the trigger

Re: [PATCH 08/17] drm/cgroup: Track DRM clients per cgroup

2023-07-21 Thread Tejun Heo
Hello, On Wed, Jul 12, 2023 at 12:45:56PM +0100, Tvrtko Ursulin wrote: > +void drmcgroup_client_migrate(struct drm_file *file_priv) > +{ > + struct drm_cgroup_state *src, *dst; > + struct cgroup_subsys_state *old; > + > + mutex_lock(&drmcg_mutex); > + > + old = file_priv->__css; >

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Belgaumkar, Vinay
On 7/21/2023 2:23 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 01:44:34PM -0700, Belgaumkar, Vinay wrote: On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: This should be done before the soft min/max frequencies are restored. When

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Rodrigo Vivi
On Fri, Jul 21, 2023 at 01:44:34PM -0700, Belgaumkar, Vinay wrote: > > On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: > > On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: > > > This should be done before the soft min/max frequencies are restored. > > > When we disable the "Ignore effic

dri-devel@lists.freedesktop.org

2023-07-21 Thread Uwe Kleine-König
to_i915 is defined as container_of(dev, struct drm_i915_private, drm); So for a struct drm_device *dev, to_i915(dev)->drm is just dev. Simplify accordingly. Signed-off-by: Uwe Kleine-König --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 6 ++ drivers/gpu/drm/i915/gt/inte

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-21 Thread Fabio Estevam
On Fri, Jul 21, 2023 at 8:28 AM Marek Szyprowski wrote: > > Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) > doesn't report empty level of packer header FIFO. In case of those SoCs, > use the old way of waiting for empty command tranfsfer FIFO, removed > recently by commit 1

Re: [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Belgaumkar, Vinay
On 7/21/2023 1:41 PM, Rodrigo Vivi wrote: On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: This should be done before the soft min/max frequencies are restored. When we disable the "Ignore efficient frequency" flag, GuC does not actually bring the requested freq down to RPn.

Re: [PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Rodrigo Vivi
On Fri, Jul 21, 2023 at 11:03:49AM -0700, Vinay Belgaumkar wrote: > This should be done before the soft min/max frequencies are restored. > When we disable the "Ignore efficient frequency" flag, GuC does not > actually bring the requested freq down to RPn. > > Specifically, this scenario- > > - i

Re: [PATCH v2] drm: bridge: samsung-dsim: Fix waiting for empty cmd transfer FIFO on older Exynos

2023-07-21 Thread Marek Vasut
On 7/21/23 13:28, Marek Szyprowski wrote: Samsung DSIM used in older Exynos SoCs (like Exynos 4210, 4x12, 3250) doesn't report empty level of packer header FIFO. In case of those SoCs, use the old way of waiting for empty command tranfsfer FIFO, removed recently by commit 14806c641582 ("Drain com

Re: [PATCH v2 2/2] drm/bridge: tc358767: give VSDELAY some positive value

2023-07-21 Thread Marek Vasut
On 7/21/23 18:53, Lucas Stach wrote: From: David Jander The documentation is not clear about how this delay works. Empirical tests have shown that with a VSDELAY of 0, the first scanline is not properly formatted in the output stream when DSI->DP mode is used. The calculation spreadsheets from

Re: [PATCH] accel/qaic: Fix slicing memory leak

2023-07-21 Thread Markus Elfring
> Slicing configuration data from user is stored in a temporary buffer > which should be freed unconditionally. Are imperative change descriptions still preferred? See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5

[PATCH 6.1 155/223] drm/ttm: Dont leak a resource on swapout move error

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Hellström commit a590f03d8de7c4cb7ce4916dc7f2fd10711faabe upstream. If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc:

[PATCH 6.1 069/223] drm/client: Send hotplug event after registering a client

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 27655b9bb9f0d9c32b8de8bec649b676898c52d5 upstream. Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between

Re: [PATCH v8 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Matt Roper
On Fri, Jul 21, 2023 at 06:15:10PM +0200, Andi Shyti wrote: > Enable the CCS_FLUSH bit 13 in the control pipe for render and > compute engines in platforms starting from Meteor Lake (BSPEC > 43904 and 47112). > > Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all > engines") >

[PATCH 5.15 492/532] drm/ttm: Dont leak a resource on swapout move error

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Hellström commit a590f03d8de7c4cb7ce4916dc7f2fd10711faabe upstream. If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc:

Re: [PATCH v8 2/9] drm/i915: Add the gen12_needs_ccs_aux_inv helper

2023-07-21 Thread Matt Roper
On Fri, Jul 21, 2023 at 06:15:07PM +0200, Andi Shyti wrote: > We always assumed that a device might either have AUX or FLAT > CCS, but this is an approximation that is not always true, e.g. > PVC represents an exception. > > Set the basis for future finer selection by implementing a > boolean gen1

[PATCH v3] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread Erik Kurzinger
These new ioctls perform a task similar to DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD/FD_TO_HANDLE with the IMPORT/EXPORT_SYNC_FILE flag set, except that they allow specifying the timeline point to import or export the fence to or from on a timeline syncobj. This eliminates the need to use a temporary binary

Re: [PATCH 1/2] drm/v3d: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-21 Thread Nick Desaulniers
On Tue, Jul 18, 2023 at 2:44 PM Nathan Chancellor wrote: > > A proposed update to clang's -Wconstant-logical-operand to warn when the > left hand side is a constant shows the following instance in > nsecs_to_jiffies_timeout() when NSEC_PER_SEC is not a multiple of HZ, > such as CONFIG_HZ=300: > >

[PATCH] accel/qaic: Fix slicing memory leak

2023-07-21 Thread Jeffrey Hugo
From: Pranjal Ramajor Asha Kanojiya Slicing configuration data from user is stored in a temporary buffer which should be freed unconditionally. Fixes: ff13be830333 ("accel/qaic: Add datapath") Signed-off-by: Pranjal Ramajor Asha Kanojiya Reviewed-by: Carl Vanderlip Reviewed-by: Jeffrey Hugo S

[PATCH 5/6] drm/format-helper-test: Add multi-plane support to conversion_buf_size()

2023-07-21 Thread Arthur Grillo
The drm_fb_memcpy() supports multi-plane formats. To fully test it in the future, add multi-plane support to the conversion_buf_size() helper. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 28 +-- 1 file changed, 14 insertions(+), 14 deletions(-

[PATCH 6/6] drm/format-helper: Add KUnit tests for drm_fb_memcpy()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_memcpy() to ensure correctness and prevent future regressions. The test case can accept different formats. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 391 ++ 1 file changed, 391 insertions(+) diff --g

[PATCH 4/6] drm/format-helper: Add KUnit tests for drm_fb_build_fourcc_list()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_build_fourcc_list() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 143 ++ 1 file changed, 143 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_fo

[PATCH 3/6] drm/format-helper: Add KUnit tests for drm_fb_clip_offset()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_clip_offset() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 91 +++ 1 file changed, 91 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_he

[PATCH 2/6] drm/format-helper: Add KUnit tests for drm_fb_swab()

2023-07-21 Thread Arthur Grillo
Insert parameterized test for the drm_fb_swab() to ensure correctness and prevent future regressions. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 66 +++ 1 file changed, 66 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_format_helper_te

[PATCH 1/6] drm/format-helper: Test default pitch fallback

2023-07-21 Thread Arthur Grillo
Test the default pitch fallback when NULL is passed as the dst_pitch on the conversion procedures. Signed-off-by: Arthur Grillo --- .../gpu/drm/tests/drm_format_helper_test.c| 132 -- 1 file changed, 87 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_fo

[PATCH 0/6] Increase code coverage on drm_format_helper.c

2023-07-21 Thread Arthur Grillo
The following series include improvements and new KUnit tests to some functions on drm_format_helper.c. The first patch improves existing conversion tests to assure that the default pitch is used when NULL is used on the `dst_pitch` argument. Patches 2, 3, 4, and 6 add the new parametrized tests

Re: [PATCH v2] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread kernel test robot
Hi Erik, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm-tip/drm-tip next-20230721] [cannot apply to drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes linus/master

[PATCH] drm/i915/guc/slpc: Restore efficient freq earlier

2023-07-21 Thread Vinay Belgaumkar
This should be done before the soft min/max frequencies are restored. When we disable the "Ignore efficient frequency" flag, GuC does not actually bring the requested freq down to RPn. Specifically, this scenario- - ignore efficient freq set to true - reduce min to RPn (from efficient) - suspend

Re: [GIT PULL] fbdev fixes and cleanups for v6.5-rc3

2023-07-21 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Jul 2023 16:12:51 +0200: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.5-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/55c225fbd8532a1bac6fd93c5085031650083a4a Thank you! -- Deet

[PATCH v2 1/2] drm/bridge: tc358767: increase PLL lock time delay

2023-07-21 Thread Lucas Stach
From: David Jander The PLL often fails to lock with this delay. The new value was determined by trial and error increasing the delay bit by bit until the error did not occurr anymore even after several tries. Then double that value was taken as the minimum delay to be safe. Signed-off-by: David

[PATCH v2 2/2] drm/bridge: tc358767: give VSDELAY some positive value

2023-07-21 Thread Lucas Stach
From: David Jander The documentation is not clear about how this delay works. Empirical tests have shown that with a VSDELAY of 0, the first scanline is not properly formatted in the output stream when DSI->DP mode is used. The calculation spreadsheets from Toshiba seem to always make this value

Re: [PATCH] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread Erik Kurzinger
That's a fair point. With my IGT patch I don't think we would have coverage of the old path any more. I'll try to fix that somehow, and I think your suggestion of including some "invalid" cases is also a good one. Anyway, apart from that I've posted a v2 of the kernel patch addressing your feed

[Bug 217692] amdgpu crashes on resume from standby - amdgpu-reset-dev drm_sched_job_timedout

2023-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217692 --- Comment #2 from Michal Turecki (ture...@gmail.com) --- Thanks, posted on https://gitlab.freedesktop.org/drm/amd/-/issues/2711. Apologies for confusing DRI and DRM. Please feel free to close/delete the issue. -- You may reply to this email to

Re: [PATCH v2] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread Simon Ser
Reviewed-by: Simon Ser

[PATCH v2] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-21 Thread Erik Kurzinger
These new ioctls perform a task similar to DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD/FD_TO_HANDLE with the IMPORT/EXPORT_SYNC_FILE flag set, except that they allow specifying the timeline point to import or export the fence to or from on a timeline syncobj. This eliminates the need to use a temporary binary

[PATCH 6.4 212/292] drm/ttm: Dont leak a resource on swapout move error

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Hellström commit a590f03d8de7c4cb7ce4916dc7f2fd10711faabe upstream. If moving the bo to system for swapout failed, we were leaking a resource. Fix. Fixes: bfa3357ef9ab ("drm/ttm: allocate resource object instead of embedding it v2") Cc: Christian König Cc: "Christian König" Cc:

[PATCH 6.4 211/292] drm/ttm: Dont leak a resource on eviction error

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Hellström commit e8188c461ee015ba0b9ab2fc82dbd5ebca5a5532 upstream. On eviction errors other than -EMULTIHOP we were leaking a resource. Fix. v2: - Avoid yet another goto (Andi Shyti) Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") Cc: Andrey Grodzovsky Cc: Chri

[PATCH v8 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-21 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: #

[PATCH v8 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-21 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed

[PATCH v8 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Nirmoy Das Cc: # v5.

[PATCH v8 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-21 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper Cc: # v5.8+ --- drive

[PATCH v8 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-21 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Meantime, propagate the error to the above layers if we fail to emit the pipe control. Signed-off-by: Andi Shyti Cc: # v5.8+ --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 47

[PATCH v8 3/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-21 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by: Nir

[PATCH v8 4/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-21 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTR

[PATCH v8 2/9] drm/i915: Add the gen12_needs_ccs_aux_inv helper

2023-07-21 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true, e.g. PVC represents an exception. Set the basis for future finer selection by implementing a boolean gen12_needs_ccs_aux_inv() function that tells whether aux invalidation is ne

[PATCH v8 1/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-21 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist and

[PATCH v8 0/9] Update AUX invalidation sequence

2023-07-21 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

[PATCH] drm/crtc: Fix uninit-value bug in drm_mode_setcrtc

2023-07-21 Thread Ziqi Zhao
The connector_set contains uninitialized values when allocated with kmalloc_array. However, in the "out" branch, the logic assumes that any element in connector_set would be equal to NULL if failed to initialize, which causes the bug reported by Syzbot. The fix is to use an extra variable to keep t

[PATCH 6.4 111/292] drm/client: Send hotplug event after registering a client

2023-07-21 Thread Greg Kroah-Hartman
From: Thomas Zimmermann commit 27655b9bb9f0d9c32b8de8bec649b676898c52d5 upstream. Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between

[PATCH] drm/modes: Fix division by zero error

2023-07-21 Thread Ziqi Zhao
In the bug reported by Syzbot, the variable `den == (1 << 22)` and `mode->vscan == (1 << 10)`, causing the multiplication to overflow and accidentally make `den == 0`. To prevent any chance of overflow, we replace `num` and `den` with 64-bit unsigned integers, and explicitly check if the divisor `d

Re: [PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-21 Thread Alex Deucher
Applied. Thanks! On Fri, Jul 21, 2023 at 2:10 AM wrote: > > Fix nine occurrences of the checkpatch.pl error: > ERROR: "foo * bar" should be "foo *bar" > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/radeon/atom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
On Thu, Jul 20, 2023 at 11:53 PM wrote: > > ERROR: open brace '{' following struct go on the same line > The description doesn't match what the patch is doing. Alex > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 8 > 1 file changed, 4 insertions(+), 4 de

Re: [PATCH] drm/amdgpu: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 20, 2023 at 11:32 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/a

Re: [PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
This applied properly. Applied. Thanks! Alex On Thu, Jul 20, 2023 at 11:27 PM wrote: > > ERROR: open brace '{' following struct go on the same line > > Signed-off-by: Ran Sun > --- > .../gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h | 21 +++ > 1 file changed, 7 insertions(+),

Re: [PATCH] drm/amd: open brace '{' following struct go on the same line

2023-07-21 Thread Alex Deucher
On Thu, Jul 20, 2023 at 9:31 PM wrote: > > Fix the checkpatch error as open brace '{' following struct should > go on the same line. > > Signed-off-by: Ran Sun git am didn't seem to like the patch, but I was able to apply it cleanly manually with no fuzz. Not sure what's up, but I've applied it

RE: [PATCH] drm/i915: Use the i915_vma_flush_writes helper

2023-07-21 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Tvrtko > Ursulin > Sent: Friday, July 21, 2023 6:08 AM > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Ursulin, Tvrtko > Subject: [PATCH] drm/i915: Use the i915_vma_flush_writes helper > > From: Tvrtko Ur

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-21 Thread Matt Roper
On Thu, Jul 20, 2023 at 09:28:56PM -0700, Yang, Fei wrote: > >>> [snip] > > @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct > > drm_i915_gem_object *obj) > > The code change here looks accurate, but while we're here, I have a > side question about this function

Re: [PATCH] MAINTAINERS: Update Alain Volmat's email address for drm/sti

2023-07-21 Thread Philippe CORNU
On 4/19/23 08:33, Patrice CHOTARD wrote: Hi Alain On 4/16/23 22:27, Alain Volmat wrote: Update my email address for maintainer of the STi DRM driver. Signed-off-by: Alain Volmat --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

Re: (subset) [PATCH v2 0/4] video: backlight: lp855x: modernize bindings

2023-07-21 Thread Thierry Reding
From: Thierry Reding On Fri, 19 May 2023 20:07:24 +0200, Artur Weber wrote: > Convert TI LP855X backlight controller bindings from TXT to YAML and, > while we're at it, rework some of the code related to PWM handling. > Also correct existing DTS files to avoid introducing new dtb_check > errors.

[PATCH v2] drm/bridge: Add debugfs print for bridge chains

2023-07-21 Thread Tomi Valkeinen
issue when !CONFIG_OF - Link to v1: https://lore.kernel.org/r/20230721-drm-bridge-chain-debugfs-v1-1-8614ff7e8...@ideasonboard.com --- drivers/gpu/drm/drm_bridge.c | 50 +++ drivers/gpu/drm/drm_debugfs.c | 3 +++ include/drm/drm_bridge.h | 5 + 3

[PATCH] drm/managed: Clean up GFP_ flag usage in drmm_kmalloc()

2023-07-21 Thread Dan Carpenter
This code is not using the correct gfp flags which were passed in. However, this does not affect runtime because kstrdup_const() is a no-op in this context. (It just returns the "kmalloc" string literal without doing an allocation.) Signed-off-by: Dan Carpenter --- drivers/gpu/drm/drm_managed.c

[PATCH] drm: bridge: samsung-dsim: Clean up a call to request_irq()

2023-07-21 Thread Dan Carpenter
This is calling request_threaded_irq() but the thread parameter is NULL so it's actually not a threaded irq. Which is a bit misleading. Call request_irq() instead. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/bridge/samsung-dsim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-21 Thread Alex Deucher
On Fri, Jul 21, 2023 at 4:18 AM Ilpo Järvinen wrote: > > On Thu, 20 Jul 2023, Bjorn Helgaas wrote: > > > On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > > > Don't assume that only the driver would be accessing LNKCTL. ASPM > > > policy changes can trigger write to LNKCTL outside o

[Bug 217692] amdgpu crashes on resume from standby - amdgpu-reset-dev drm_sched_job_timedout

2023-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217692 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

[PULL] drm-misc-next

2023-07-21 Thread Maxime Ripard
Hi, Here's this week drm-misc-next PR Thanks! Maxime The following changes since commit 36672dda2eb715af99e9abbcdc400d46598b691c: drm/loongson: Remove a useless check in cursor_plane_atomic_async_check() (2023-07-13 01:24:42 +0800) are available in the Git repository at: ssh://git.freede

[GIT PULL] fbdev fixes and cleanups for v6.5-rc3

2023-07-21 Thread Helge Deller
Hi Linus, please pull some fbdev fixes & cleanups for kernel 6.5-rc3. Just the usual bunch of code cleanups in various drivers, this time mostly in vgacon and imxfb. Thanks! Helge -- The following changes since commit 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5: Linux 6.5-rc1 (2023

Re: [v7,9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-21 Thread Andi Shyti
Hi Janusz, > > diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > index 3ded597f002a2..30fb4e0af6134 100644 > > --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > > @@ -165,9 +165,36 @@ static u

[PATCH v2 1/1] drm/i915: Move abs_diff() to math.h

2023-07-21 Thread Andy Shevchenko
abs_diff() belongs to math.h. Move it there. This will allow others to use it. Signed-off-by: Andy Shevchenko --- v2: better header location on ipu-v3, converted omap-serial as well drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 7 ---

Re: [PATCH v1 1/1] drm/i915: Move abs_diff() to math.h

2023-07-21 Thread Andy Shevchenko
On Fri, Jul 21, 2023 at 04:42:35PM +0300, Andy Shevchenko wrote: > abs_diff() belongs to math.h. Move it there. > This will allow others to use it. Sorry, forgot omap-serial case. Will be v2 soon. -- With Best Regards, Andy Shevchenko

[PATCH v1 1/1] drm/i915: Move abs_diff() to math.h

2023-07-21 Thread Andy Shevchenko
abs_diff() belongs to math.h. Move it there. This will allow others to use it. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 1 + drivers/gpu/drm/i915/display/intel_dpll_mgr.h | 7 --- drivers/gpu/ipu-v3/ipu-image-convert.c| 14 ++ d

Re: [v7,9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:37 CEST Andi Shyti wrote: > Perform some refactoring with the purpose of keeping in one > single place all the operations around the aux table > invalidation. > > With this refactoring add more engines where the invalidation > should be performed. > > Fix

Re: [PATCH] drm/bridge: Add debugfs print for bridge chains

2023-07-21 Thread kernel test robot
Hi Tomi, kernel test robot noticed the following build errors: [auto build test ERROR on c7a472297169156252a50d76965eb36b081186e2] url: https://github.com/intel-lab-lkp/linux/commits/Tomi-Valkeinen/drm-bridge-Add-debugfs-print-for-bridge-chains/20230721-174615 base

[PATCH] drm/amd/display: set stream gamut remap matrix to MPC for DCN3+

2023-07-21 Thread Melissa Wen
dc->caps.color.mpc.gamut_remap says there is a post-blending color block for gamut remap matrix for DCN3 HW family and newer versions. However, those drivers still follow DCN10 programming that remap stream gamut_remap_matrix to DPP (pre-blending). To enable pre-blending and post-blending gamut_re

[PATCH] drm/i915: Use the i915_vma_flush_writes helper

2023-07-21 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can use the existing helper in flush_write_domain() and save some lines of code. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_domain.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_doma

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-21 Thread Tvrtko Ursulin
On 21/07/2023 05:28, Yang, Fei wrote: [snip] @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj) The code change here looks accurate, but while we're here, I have a side question about this function in general...it was originally introduced in commit 48004

Re: [v7, 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-21 Thread Andi Shyti
Hi Janusz, On Fri, Jul 21, 2023 at 12:10:22PM +, Krzysztofik, Janusz wrote: > Hi Andi, > > On Thursday, 20 July 2023 23:07:35 CEST Andi Shyti wrote: > > Commit af9e423a8aae > > You can't use this commit ID, it is invalid (the patch you are referring to > belongs to your series, then is not

[PATCH] drm: bridge: dw_hdmi: Add cec suspend/resume functions

2023-07-21 Thread Sandor Yu
CEC interrupt status/mask and logical address registers will be reset when device enter suspend. It will cause cec fail to work after device resume. Add CEC suspend/resume functions, reinitialize logical address registers and restore interrupt status/mask registers after resume. Signed-off-by: San

Re: [PATCH 6/9] drm/verisilicon: Add drm crtc funcs

2023-07-21 Thread Sam Ravnborg
Hi Keith, On Fri, Jul 21, 2023 at 07:57:24PM +0800, Keith Zhao wrote: > >> + > >> +struct vs_crtc_funcs { > >> +    void (*enable)(struct device *dev, struct drm_crtc *crtc); > >> +    void (*disable)(struct device *dev, struct drm_crtc *crtc); > >> +    bool (*mode_fixup)(struct device *dev, > >>

Re: [PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

2023-07-21 Thread Viktar Simanenka
On Fri, Jul 21, 2023 at 11:42 AM Krzysztof Kozlowski wrote: > > On 20/07/2023 14:40, Viktar Simanenka wrote: > > +allOf: > > + - $ref: panel/panel-common.yaml# > > This is not a panel, is it? I can't clearly tell the difference between LCD display and panel. I've added panel-common because of 'b

[PATCH -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()

2023-07-21 Thread YueHaibing
Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs") this inline helper not used anymore. Signed-off-by: YueHaibing --- include/drm/drm_fb_helper.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_

[Bug 217692] New: amdgpu crashes on resume from standby - amdgpu-reset-dev drm_sched_job_timedout

2023-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217692 Bug ID: 217692 Summary: amdgpu crashes on resume from standby - amdgpu-reset-dev drm_sched_job_timedout Product: Drivers Version: 2.5 Hardware: AMD OS: Linu

Re: [v7, 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:35 CEST Andi Shyti wrote: > Commit af9e423a8aae You can't use this commit ID, it is invalid (the patch you are referring to belongs to your series, then is not available in any official repository, hence no stable commit ID yet). > ("drm/i915/gt: Ensur

Re: [v7,5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-21 Thread Andi Shyti
Hi Janusz, > > Enable the CCS_FLUSH bit 13 in the control pipe for render and > > compute engines in platforms starting from Meteor Lake (BSPEC > > 43904 and 47112). > > > > Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all > > engines") > > I'm not sure why you think that

Re: [PATCH 0/3] MediaTek DRM: Clean up CMDQ support and ifdefs

2023-07-21 Thread Alexandre Mergnat
On 19/07/2023 09:41, AngeloGioacchino Del Regno wrote: Il 23/06/23 14:49, Alexandre Mergnat ha scritto: On 23/06/2023 11:49, AngeloGioacchino Del Regno wrote: This series changes MediaTek CMDQ support to use the mtk-cmdq-helper functions, removing duplicated cmdq setup code in mtk-drm and

[Bug 217690] consistent amdgpu failures on Lenovo ThinkPad Z16: "[drm:amdgpu_dm_process_dmub_aux_transfer_sync [amdgpu]] *ERROR* wait_for_completion_timeout timeout!"

2023-07-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217690 Artem S. Tashkinov (a...@gmx.com) changed: What|Removed |Added Status|NEW |RESOLVED Reso

Re: [PATCH 6/9] drm/verisilicon: Add drm crtc funcs

2023-07-21 Thread Keith Zhao
On 2023/6/30 19:55, Thomas Zimmermann wrote: > Hi > > Am 02.06.23 um 09:40 schrieb Keith Zhao: >> Add crtc driver which implements crtc related operation functions. >> >> Signed-off-by: Keith Zhao >> --- >>   drivers/gpu/drm/verisilicon/Makefile  |   1 + >>   drivers/gpu/drm/verisilicon/vs_crt

Re: [v7, 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-21 Thread Krzysztofik, Janusz
Hi Andi, On Thursday, 20 July 2023 23:07:34 CEST Andi Shyti wrote: > Just a trivial refactoring for reducing the number of code > duplicate. This will come at handy in the next commits. > > Signed-off-by: Andi Shyti > Cc: # v5.8+ > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 ++

  1   2   >