Re: [PATCH] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-20 Thread Simon Ser
I had a look at the IGT and I'm not sure about the approach. It seems like the patch replaces occurrences of the old FLAGS_IMPORT_SYNC_FILE and FLAGS_EXPORT_SYNC_FILE plus TRANSFER with the new IOCTLs. However we still want to test the functionality of that old codepath: we need to continue to test

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-20 Thread sunran001
Fix two occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Jianghui Xu --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 11a1

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-20 Thread sunran001
Fix two occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 11a1940b

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Andy Shevchenko
On Fri, Jul 21, 2023 at 8:17 AM Ying Liu wrote: > On Thursday, July 20, 2023 7:28 PM Daniel Thompson > wrote: > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > > Bootloader may leave gpio direction as input and gpio value as logical > > > low. > > > It hints that initial backlig

[PATCH] drm/radeon: ERROR: "foo * bar" should be "foo *bar"

2023-07-20 Thread sunran001
Fix nine occurrences of the checkpatch.pl error: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- drivers/gpu/drm/radeon/atom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/atom.c b/drivers/gpu/drm/radeon/atom.c index 11a1940

RE: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Ying Liu
Hi Daniel, On Thursday, July 20, 2023 7:28 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > Bootloader may leave gpio direction as input and gpio value as logical low. > > It hints that initial backlight power state should be > FB_BLANK_POWERDOWN > > s

Re: [PATCH v2 1/9] vgacon: rework Kconfig dependencies

2023-07-20 Thread Michael Ellerman
Arnd Bergmann writes: > From: Arnd Bergmann > > The list of dependencies here is phrased as an opt-out, but this is missing > a lot of architectures that don't actually support VGA consoles, and some > of the entries are stale: > > - powerpc used to support VGA consoles in the old arch/ppc codeb

RE: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-20 Thread Yang, Fei
>>> [snip] > @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct > drm_i915_gem_object *obj) The code change here looks accurate, but while we're here, I have a side question about this function in general...it was originally introduced in commit 48004881f693 (

[PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-20 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h b/drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.h index ddc

Re: [git pull] drm fixes for 6.5-rc3

2023-07-20 Thread pr-tracker-bot
The pull request you sent on Fri, 21 Jul 2023 13:14:05 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-07-21 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f7e3a1bafdea735050dfde00523cf505dc7fd309 Thank you! -- Deet-doot-dot, I am a bot. https://k

[PATCH] drm/amdgpu: open brace '{' following struct go on the same line

2023-07-20 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h b/drivers/gpu/drm/amd/pm/inc/amdgpu_pm.h index 52045ad59bed

[PATCH] drm/amd/pm: open brace '{' following struct go on the same line

2023-07-20 Thread sunran001
ERROR: open brace '{' following struct go on the same line Signed-off-by: Ran Sun --- .../gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h | 21 +++ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v13_0_0_pptable.h b/drivers/gpu/drm/amd/pm

[git pull] drm fixes for 6.5-rc3

2023-07-20 Thread Dave Airlie
Hi Linus, This week's fixes pull, just realise the tag says for rc2, but it's meant to be rc3. Mostly amdgpu fixes, a couple of i915 fixes, some nouveau and then a few misc accel and other fixes. Dave. drm-fixes-2023-07-21: drm fixes for 6.5-rc2 client: - memory leak fix dma-buf: - memory leak

[Bug 217690] New: consistent amdgpu failures on Lenovo ThinkPad Z16: "[drm:amdgpu_dm_process_dmub_aux_transfer_sync [amdgpu]] *ERROR* wait_for_completion_timeout timeout!"

2023-07-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217690 Bug ID: 217690 Summary: consistent amdgpu failures on Lenovo ThinkPad Z16: "[drm:amdgpu_dm_process_dmub_aux_transfer_sync [amdgpu]] *ERROR* wait_for_completion_timeout

linux-next: manual merge of the accel tree with the drm-fixes tree

2023-07-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the accel tree got a conflict in: drivers/accel/habanalabs/common/habanalabs.h between commit: 78e9b217d78e ("accel/habanalabs: add more debugfs stub helpers") from the drm-fixes tree and commit: 32055d39a2bb ("accel/habanalabs: register compute devic

[PATCH] drm/amd: open brace '{' following struct go on the same line

2023-07-20 Thread sunran001
Fix the checkpatch error as open brace '{' following struct should go on the same line. Signed-off-by: Ran Sun --- drivers/gpu/drm/amd/include/yellow_carp_offset.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h b/drive

[PATCH] drm/i915/huc: silence injected failure in the load via GSC path

2023-07-20 Thread Daniele Ceraolo Spurio
If we can't load the HuC due to an injected failure, we don't want to throw and error and trip CI. Using the gt_probe_error macro for logging ensure that the error is only printed if it wasn't explicitly injected. Link: https://gitlab.freedesktop.org/drm/intel/-/issues/7061 Signed-off-by: Daniele

[PATCH v7] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems th

Re: [PATCH v6] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Teres Alexis, Alan Previn
On Thu, 2023-07-20 at 14:52 -0700, Ceraolo Spurio, Daniele wrote: > > On 7/20/2023 2:40 PM, Alan Previn wrote: > > On MTL, if the GSC Proxy init flows haven't completed, submissions to the > > GSC engine will fail. Those init flows are dependent on the mei's > > gsc_proxy component that is loaded

Re: [PATCH v3] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-07-20 Thread Ceraolo Spurio, Daniele
On 6/29/2023 6:44 PM, Alan Previn wrote: After recent discussions with Mesa folks, it was requested that we optimize i915's GET_PARAM for the PXP_STATUS without changing the UAPI spec. Add these additional optimizations: - If any PXP initializatoin flow failed, then ensure that we c

Re: [PATCH v1 5/5] drm/msm/dp: move of_dp_aux_populate_bus() to probe for eDP

2023-07-20 Thread Dmitry Baryshkov
On 20/07/2023 23:27, Kuogee Hsieh wrote: On 7/10/2023 11:24 AM, Dmitry Baryshkov wrote: [Restored CC list] On Mon, 10 Jul 2023 at 20:08, Kuogee Hsieh wrote: On 7/7/2023 5:32 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Move of_dp_aux_populate_bus() to dp_display_p

Re: [PATCH drm-misc-next v8 01/12] drm: manager to keep track of GPUs VA mappings

2023-07-20 Thread Danilo Krummrich
On 7/20/23 12:44, Steven Price wrote: On 20/07/2023 01:14, Danilo Krummrich wrote: Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers start implementing, a

Re: [PATCH v5 05/11] drm/amdgpu: Use RMW accessors for changing LNKCTL

2023-07-20 Thread Bjorn Helgaas
On Mon, Jul 17, 2023 at 03:04:57PM +0300, Ilpo Järvinen wrote: > Don't assume that only the driver would be accessing LNKCTL. ASPM > policy changes can trigger write to LNKCTL outside of driver's control. > And in the case of upstream bridge, the driver does not even own the > device it's changing

Re: [PATCH v6] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Ceraolo Spurio, Daniele
On 7/20/2023 2:40 PM, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 dri

[PATCH v6] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Alan Previn
On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 driver init is done. That said, all subsytems th

[PATCH v7 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-20 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed

[PATCH v7 7/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper Cc: # v5.8+ --- drive

[PATCH v7 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: #

[PATCH v7 4/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-20 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTR

[PATCH v7 6/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Signed-off-by: Andi Shyti Cc: # v5.8+ --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/dr

[PATCH v7 5/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-20 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Nirmoy Das Cc: # v5.

[PATCH v7 3/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by: Nir

[PATCH v7 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-20 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true as it requires some further per device checks. Add the "has_aux_ccs" flag in the intel_device_info structure in order to have a per device flag indicating of the AUX CCS. Signed

[PATCH v7 1/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-20 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist and

[PATCH v7 0/9] Update AUX invalidation sequence

2023-07-20 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

Re: [PATCH v6 0/9] Update AUX invalidation sequence

2023-07-20 Thread Andi Shyti
Ops... sorry... I am realizing that I sent again V6... please ignore this series! Andi On Thu, Jul 20, 2023 at 06:44:45PM +0200, Andi Shyti wrote: > Hi, > > as there are new hardware directives, we need a little adaptation > for the AUX invalidation sequence. > > In this version we support all

Re: [PATCH v6 7/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-20 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:07:27PM +0200, Andi Shyti wrote: > Enable the CCS_FLUSH bit 13 in the control pipe for render and > compute engines in platforms starting from Meteor Lake (BSPEC > 43904 and 47112). The VE and BCS engines need to add the flush > part in their command streamer. > > Fixes:

Re: [PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-07-20 Thread Matthew Brost
On Sat, Jul 15, 2023 at 05:45:43PM +0200, Thomas Hellström wrote: > Add a motivation for and description of asynchronous VM_BIND operation > > v2: > - Fix typos (Nirmoy Das) > - Improve the description of a memory fence (Oak Zeng) > - Add a reference to the document in the Xe RFC. > - Add pointers

Re: [PATCH v6 5/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:07:25PM +0200, Andi Shyti wrote: > Just a trivial refactoring for reducing the number of code > duplicate. This will come at handy in the next commits. > > Signed-off-by: Andi Shyti > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- > 1 fil

Re: [PATCH v5] drm/i915/selftest/gsc: Ensure GSC Proxy init completes before selftests

2023-07-20 Thread Ceraolo Spurio, Daniele
On 7/12/2023 4:12 PM, Alan Previn wrote: On MTL, if the GSC Proxy init flows haven't completed, submissions to the GSC engine will fail. Those init flows are dependent on the mei's gsc_proxy component that is loaded in parallel with i915 and a worker that could potentially start after i915 dri

Re: [PATCH v6 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-20 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:07:22PM +0200, Andi Shyti wrote: > We always assumed that a device might either have AUX or FLAT > CCS, but this is an approximation that is not always true as it > requires some further per device checks. > > Add the "has_aux_ccs" flag in the intel_device_info structure

Re: [PATCH v1 5/5] drm/msm/dp: move of_dp_aux_populate_bus() to probe for eDP

2023-07-20 Thread Kuogee Hsieh
On 7/10/2023 11:24 AM, Dmitry Baryshkov wrote: [Restored CC list] On Mon, 10 Jul 2023 at 20:08, Kuogee Hsieh wrote: On 7/7/2023 5:32 PM, Dmitry Baryshkov wrote: On 08/07/2023 02:52, Kuogee Hsieh wrote: Move of_dp_aux_populate_bus() to dp_display_probe() for eDP from dp_display_bind() so t

Re: [PATCH v5 9/9] drm: Introduce documentation for hotspot properties

2023-07-20 Thread Simon Ser
On Thursday, July 20th, 2023 at 21:28, Zack Rusin wrote: > On Thu, 2023-07-20 at 09:07 +, Simon Ser wrote: > > > !! External Email > > > > On Thursday, July 20th, 2023 at 10:50, Javier Martinez Canillas > > javi...@redhat.com wrote: > > > > > > On Thursday, July 20th, 2023 at 07:03, Zack R

Re: [PATCH v5 9/9] drm: Introduce documentation for hotspot properties

2023-07-20 Thread Zack Rusin
On Thu, 2023-07-20 at 09:07 +, Simon Ser wrote: > !! External Email > > On Thursday, July 20th, 2023 at 10:50, Javier Martinez Canillas > wrote: > > > > On Thursday, July 20th, 2023 at 07:03, Zack Rusin za...@vmware.com wrote: > > > > > > > I'll give this series a few more hours on the list an

Re: [PATCH v3 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-07-20 Thread Marijn Suijten
On 2023-07-20 01:24:27, Dmitry Baryshkov wrote: > On Thu, 20 Jul 2023 at 01:09, Marijn Suijten > wrote: > > > > On 2023-07-19 01:06:03, Dmitry Baryshkov wrote: > > > On 19/07/2023 00:24, Marijn Suijten wrote: > > > > SM6125 is identical to SM6375 except that while downstream also defines > > > > a

Re: [Freedreno] [PATCH] drm/msm: Check for the GPU IOMMU during bind

2023-07-20 Thread Bjorn Andersson
On Mon, Jul 10, 2023 at 03:20:44AM +0530, Akhil P Oommen wrote: > On Fri, Jul 07, 2023 at 08:27:18PM +0300, Dmitry Baryshkov wrote: > > > > On 07/07/2023 18:03, Jordan Crouse wrote: > > > On Thu, Jul 06, 2023 at 09:55:13PM +0300, Dmitry Baryshkov wrote: > > > > > > > > On 10/03/2023 00:20, Jordan

Patch "drm/client: Send hotplug event after registering a client" has been added to the 6.4-stable tree

2023-07-20 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/client: Send hotplug event after registering a client to the 6.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "drm/client: Send hotplug event after registering a client" has been added to the 6.1-stable tree

2023-07-20 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/client: Send hotplug event after registering a client to the 6.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH v2 06/11] drm/tests: helpers: Create a helper to allocate an atomic state

2023-07-20 Thread kernel test robot
Hi Maxime, kernel test robot noticed the following build warnings: [auto build test WARNING on c58c49dd89324b18a812762a2bfa5a0458e4f252] url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/drm-tests-helpers-Switch-to-kunit-actions/20230720-191901 base

[drm-misc:for-linux-next 2/2] drivers/gpu/drm/drm_debugfs.c:212:33: sparse: sparse: non size-preserving pointer to integer cast

2023-07-20 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: c7a472297169156252a50d76965eb36b081186e2 commit: 4f66feeab173bd73e71028b8c2e1dcea07e32dd5 [2/2] drm: debugfs: provide infrastructure to dump a DRM GPU VA space config: i386-randconfig-r092-20230720 (https://download.01.org

Re: [PATCH] drm/panel: simple: Drop prepared_time

2023-07-20 Thread Doug Anderson
Hi, On Tue, Jul 18, 2023 at 7:23 AM Doug Anderson wrote: > > Hi, > > On Sun, Jul 9, 2023 at 9:23 AM Marek Vasut wrote: > > > > This has been superseded by RPM in commit > > 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive > > unprepare / prepare") > > and the last user

Re: [PATCH] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-20 Thread Erik Kurzinger
On 7/20/23 02:43, Simon Ser wrote: > On Wednesday, July 19th, 2023 at 19:05, Erik Kurzinger > wrote: > >> These new ioctls perform a task similar to >> DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD/FD_TO_HANDLE with the >> IMPORT/EXPORT_SYNC_FILE flag set, except that they allow specifying the >> timeline p

Re: [RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-20 Thread T.J. Mercier
On Thu, Jul 20, 2023 at 3:55 AM Tvrtko Ursulin wrote: > > > Hi, > > On 19/07/2023 21:31, T.J. Mercier wrote: > > On Wed, Jul 12, 2023 at 4:47 AM Tvrtko Ursulin > > wrote: > >> > >>drm.memory.stat > >> A nested file containing cumulative memory statistics for the > >> whole > >>

Re: [PATCH v2 01/11] drm/tests: helpers: Switch to kunit actions

2023-07-20 Thread kernel test robot
Hi Maxime, kernel test robot noticed the following build warnings: [auto build test WARNING on c58c49dd89324b18a812762a2bfa5a0458e4f252] url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/drm-tests-helpers-Switch-to-kunit-actions/20230720-191901 base

Re: [PATCH] drm/msm: Check for the GPU IOMMU during bind

2023-07-20 Thread Dmitry Baryshkov
On 20/07/2023 18:52, Rob Clark wrote: On Thu, Jul 6, 2023 at 11:55 AM Dmitry Baryshkov wrote: On 10/03/2023 00:20, Jordan Crouse wrote: While booting with amd,imageon on a headless target the GPU probe was failing with -ENOSPC in get_pages() from msm_gem.c. Investigation showed that the driv

[linux-next:master] BUILD REGRESSION c58c49dd89324b18a812762a2bfa5a0458e4f252

2023-07-20 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: c58c49dd89324b18a812762a2bfa5a0458e4f252 Add linux-next specific files for 20230720 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202306260401.qzlyqpv2-...@intel.com https

[PATCH v6 9/9] drm/i915/gt: Support aux invalidation on all engines

2023-07-20 Thread Andi Shyti
Perform some refactoring with the purpose of keeping in one single place all the operations around the aux table invalidation. With this refactoring add more engines where the invalidation should be performed. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed

[PATCH v6 8/9] drm/i915/gt: Poll aux invalidation register bit on invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt For platforms that use Aux CCS, wait for aux invalidation to complete by checking the aux invalidation register bit is cleared. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: #

[PATCH v6 6/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Andi Shyti
Commit af9e423a8aae ("drm/i915/gt: Ensure memory quiesced before invalidation") has made sure that the memory is quiesced before invalidating the AUX CCS table. Do it for all the other engines and not just RCS. Signed-off-by: Andi Shyti Cc: Jonathan Cavitt Cc: Matt Roper --- drivers/gpu/drm/i9

[PATCH v6 7/9] drm/i915/gt: Enable the CCS_FLUSH bit in the pipe control

2023-07-20 Thread Andi Shyti
Enable the CCS_FLUSH bit 13 in the control pipe for render and compute engines in platforms starting from Meteor Lake (BSPEC 43904 and 47112). The VE and BCS engines need to add the flush part in their command streamer. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines

[PATCH v6 5/9] drm/i915/gt: Refactor intel_emit_pipe_control_cs() in a single function

2023-07-20 Thread Andi Shyti
Just a trivial refactoring for reducing the number of code duplicate. This will come at handy in the next commits. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 44 +--- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v6 4/9] drm/i915/gt: Rename flags with bit_group_X according to the datasheet

2023-07-20 Thread Andi Shyti
In preparation of the next patch align with the datasheet (BSPEC 47112) with the naming of the pipe control set of flag values. The variable "flags" in gen12_emit_flush_rcs() is applied as a set of flags called Bit Group 1. Define also the Bit Group 0 as bit_group_0 where currently only PIPE_CONTR

[PATCH v6 3/9] drm/i915/gt: Ensure memory quiesced before invalidation

2023-07-20 Thread Andi Shyti
From: Jonathan Cavitt All memory traffic must be quiesced before requesting an aux invalidation on platforms that use Aux CCS. Fixes: 972282c4cf24 ("drm/i915/gen12: Add aux table invalidate for all engines") Signed-off-by: Jonathan Cavitt Signed-off-by: Andi Shyti Cc: # v5.8+ Reviewed-by: Nir

[PATCH v6 0/9] Update AUX invalidation sequence

2023-07-20 Thread Andi Shyti
Hi, as there are new hardware directives, we need a little adaptation for the AUX invalidation sequence. In this version we support all the engines affected by this change. The stable backport has some challenges because the original patch that this series fixes has had more changes in between.

[PATCH v6 2/9] drm/i915: Add the has_aux_ccs device property

2023-07-20 Thread Andi Shyti
We always assumed that a device might either have AUX or FLAT CCS, but this is an approximation that is not always true as it requires some further per device checks. Add the "has_aux_ccs" flag in the intel_device_info structure in order to have a per device flag indicating of the AUX CCS. Signed

[PATCH v6 1/9] drm/i915/gt: Cleanup aux invalidation registers

2023-07-20 Thread Andi Shyti
Fix the 'NV' definition postfix that is supposed to be INV. Take the chance to also order properly the registers based on their address and call the GEN12_GFX_CCS_AUX_INV address as GEN12_CCS_AUX_INV like all the other similar registers. Remove also VD1, VD3 and VE1 registers that don't exist and

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Andy Shevchenko
On Thu, Jul 20, 2023 at 2:27 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > Bootloader may leave gpio direction as input and gpio value as logical low. > > It hints that initial backlight power state should be FB_BLANK_POWERDOWN > > since the gpio value

Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment

2023-07-20 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 19, 2023 at 9:27 PM Randy Dunlap wrote: > > > > On 7/19/23 18:05, Yang Li wrote: > > Use colon to separate parameter name from their specific meaning. > > silence the warning: > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter > > or

Re: [PATCH v6 05/11] drm/mediatek: dp: Move AUX_P0 setting to mtk_dp_initialize_aux_settings()

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: Move the register write to MTK_DP_AUX_P0_3690 to set the AUX reply mode to function mtk_dp_initialize_aux_settings(), as this is effectively part of the DPTX AUX setup sequence. -- Regards, Alexandre

Re: [PATCH v6 04/11] drm/mediatek: dp: Use devm variant of drm_bridge_add()

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: In preparation for adding support for aux-bus, which will add a code path that may fail after the drm_bridge_add() call, change that to devm_drm_bridge_add() to simplify failure paths later. -- Regards, Alex

Re: [PATCH v6 03/11] drm/mediatek: dp: Change logging to dev for mtk_dp_aux_transfer()

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: Change logging from drm_{err,info}() to dev_{err,info}() in functions mtk_dp_aux_transfer() and mtk_dp_aux_do_transfer(): this will be essential to avoid getting NULL pointer kernel panics if any kind of error

Re: [PATCH v6 02/11] drm/mediatek: dp: Move AUX and panel poweron/off sequence to function

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: Everytime we run bridge detection and/or EDID read we run a poweron and poweroff sequence for both the AUX and the panel; moreover, this is also done when enabling the bridge in the .atomic_enable() callback.

Re: [PATCH v6 01/11] drm/mediatek: dp: Add missing error checks in mtk_dp_parse_capabilities

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: If reading the RX capabilities fails the training pattern will be set wrongly: add error checking for drm_dp_read_dpcd_caps() and return if anything went wrong with it. While at it, also add a less critical e

Re: [PATCH v6 11/11] drm/mediatek: dp: Don't register HPD interrupt handler for eDP case

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: The interrupt handler for HPD is useful only if a display is actually supposed to be hotpluggable, as that manages the machinery to perform cable (un)plug detection, debouncing and setup for re-training. Sinc

Re: [PATCH] drm/msm: Check for the GPU IOMMU during bind

2023-07-20 Thread Rob Clark
On Thu, Jul 6, 2023 at 11:55 AM Dmitry Baryshkov wrote: > > On 10/03/2023 00:20, Jordan Crouse wrote: > > While booting with amd,imageon on a headless target the GPU probe was > > failing with -ENOSPC in get_pages() from msm_gem.c. > > > > Investigation showed that the driver was using the default

[PATCH 6.4] drm/client: Send hotplug event after registering a client

2023-07-20 Thread Mario Limonciello
From: Thomas Zimmermann Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between registering a client and receiving events from the DRM core

[PATCH 6.1] drm/client: Send hotplug event after registering a client

2023-07-20 Thread Mario Limonciello
From: Thomas Zimmermann Generate a hotplug event after registering a client to allow the client to configure its display. Remove the hotplug calls from the existing clients for fbdev emulation. This change fixes a concurrency bug between registering a client and receiving events from the DRM core

Re: [PATCH 2/2] drm/i915: Avoid -Wconstant-logical-operand in nsecs_to_jiffies_timeout()

2023-07-20 Thread Nathan Chancellor
On Thu, Jul 20, 2023 at 09:43:05AM +0100, Tvrtko Ursulin wrote: > > On 18/07/2023 22:44, Nathan Chancellor wrote: > > A proposed update to clang's -Wconstant-logical-operand to warn when the > > left hand side is a constant shows the following instance in > > nsecs_to_jiffies_timeout() when NSEC_P

Re: [PATCH v6 10/11] drm/mediatek: dp: Add .wait_hpd_asserted() for AUX bus

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: In order to support usecases in which the panel regulator can be switched on and off to save power, and usecases in which the panel regulator is off at boot, add a .wait_hpd_asserted() callback for the AUX bus

Re: [PATCH v6 6/9] drm/i915/gt: Ensure memory quiesced before invalidation for all engines

2023-07-20 Thread Andi Shyti
Hi Nirmoy, > + if (aux_inv) { > + u32 bit_group_0 = 0; > + u32 bit_group_1 = 0; > + > + cmd += 4; > + > + bit_group_0 |= PIPE_CONTROL0_HDC_PIPELINE_FLUSH; > + > + switch (rq->engine->cla

Re: [PATCH v2 05/11] drm/tests: helpers: Create a helper to allocate a locking ctx

2023-07-20 Thread kernel test robot
Hi Maxime, kernel test robot noticed the following build warnings: [auto build test WARNING on c58c49dd89324b18a812762a2bfa5a0458e4f252] url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/drm-tests-helpers-Switch-to-kunit-actions/20230720-191901 base

Re: [PATCH v6 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: For the eDP case we can support using aux-bus on MediaTek DP: this gives us the possibility to declare our panel as generic "panel-edp" which will automatically configure the timings and available modes via th

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-20 Thread Tvrtko Ursulin
[Here let me just focus on the points which did not get further discussion in follow ups yet.] On 19/07/2023 23:31, Matt Roper wrote: On Wed, Jul 19, 2023 at 01:37:30PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level")

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-20 Thread Tvrtko Ursulin
On 20/07/2023 01:22, Matt Roper wrote: On Wed, Jul 19, 2023 at 05:07:15PM -0700, Yang, Fei wrote: [snip] @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct drm_i915_gem_object *obj) The code change here looks accurate, but while we're here, I have a side question about this func

Re: [PATCH v6 08/11] drm/mediatek: dp: Move PHY registration to new function

2023-07-20 Thread Alexandre Mergnat
Reviewed-by: Alexandre Mergnat On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: In preparation for adding support for eDP, move the PHY registration code to a new mtk_dp_register_phy() function for better readability. This commit brings no functional changes. -- Regards, Alexandre

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

2023-07-20 Thread Luca Ceresoli
Hello Rob, thanks for reviewing. On Wed, 19 Jul 2023 13:02:54 -0600 Rob Herring wrote: > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > connected over SPI and the "ShenZhen New Display Co NDS04048080

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

2023-07-20 Thread Luca Ceresoli
Hello Krzysztof, thanks for reviewing. On Wed, 19 Jul 2023 21:12:14 +0200 Krzysztof Kozlowski wrote: > On 19/07/2023 17:21, Luca Ceresoli wrote: > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" >

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

2023-07-20 Thread Luca Ceresoli
Hello Conor, thanks for reviewing. On Wed, 19 Jul 2023 17:44:45 +0100 Conor Dooley wrote: > Hey Luca, > > On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > > connected over SPI and the "ShenZhen New Disp

[pull] amdgpu drm-fixes-6.5

2023-07-20 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.5. The following changes since commit fdf0eaf11452d72945af31804e2a1048ee1b574c: Linux 6.5-rc2 (2023-07-16 15:10:37 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.5-2023-07-20 for you to fetch

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Bartosz Golaszewski
On Thu, Jul 20, 2023 at 3:10 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 02:56:32PM +0200, Bartosz Golaszewski wrote: > > On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson > > wrote: > > > > > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > > > Bootloader may leave gpio di

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Daniel Thompson
On Thu, Jul 20, 2023 at 02:56:32PM +0200, Bartosz Golaszewski wrote: > On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson > wrote: > > > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > > Bootloader may leave gpio direction as input and gpio value as logical > > > low. > > > It hints

Re: [PATCH v6 07/11] drm/mediatek: dp: Avoid mutex locks if audio is not supported/enabled

2023-07-20 Thread Alexandre Mergnat
On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: If a controller (usually, eDP!) does not support audio, or audio is not enabled because the endpoint has no audio support, it's useless to lock a mutex only to unlock it right after because there's no .plugged_cb(). Check if the audio is

Re: [PATCH v6 06/11] drm/mediatek: dp: Enable event interrupt only when bridge attached

2023-07-20 Thread Alexandre Mergnat
On 17/07/2023 16:14, AngeloGioacchino Del Regno wrote: It is useless and error-prone to enable the DisplayPort event interrupt before finishing to probe and install the driver, as the DP training cannot happen before the entire pipeline is correctly set up, as the interrupt handler also requir

Re: [PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-20 Thread Bartosz Golaszewski
On Thu, Jul 20, 2023 at 1:27 PM Daniel Thompson wrote: > > On Thu, Jul 20, 2023 at 06:06:27AM +, Ying Liu wrote: > > Bootloader may leave gpio direction as input and gpio value as logical low. > > It hints that initial backlight power state should be FB_BLANK_POWERDOWN > > since the gpio value

[PATCH v2 3/5] drm/i915: Fix HPD polling, reenabling the output poll work as needed

2023-07-20 Thread Imre Deak
After the commit in the Fixes: line below, HPD polling stopped working on i915, since after that change calling drm_kms_helper_poll_enable() doesn't restart drm_mode_config::output_poll_work if the work was stopped (no connectors needing polling) and enabling polling for a connector (during runtime

[PATCH v2 2/5] drm: Add an HPD poll helper to reschedule the poll work

2023-07-20 Thread Imre Deak
Add a helper to reschedule drm_mode_config::output_poll_work after polling has been enabled for a connector (and needing a reschedule, since previously polling was disabled for all connectors and hence output_poll_work was not running). This is needed by the next patch fixing HPD polling on i915.

Re: [PATCH v3,3/3] drm/mediatek: dp: Add the audio divider to mtk_dp_data struct

2023-07-20 Thread AngeloGioacchino Del Regno
Il 20/07/23 14:29, Alexandre Mergnat ha scritto: On 20/07/2023 14:08, AngeloGioacchino Del Regno wrote: Il 20/07/23 14:07, Alexandre Mergnat ha scritto: On 20/07/2023 13:54, AngeloGioacchino Del Regno wrote: Il 20/07/23 12:14, Alexandre Mergnat ha scritto: On 20/07/2023 10:26, Shuijing

[PATCH v3 2/2] drm/tiny: add display driver for philips pcd8544 display controller

2023-07-20 Thread Viktar Simanenka
Add support for monochrome LCD SPI displays (such as Nokia 5110/3310 LCD) based on PCD8544 LCD display controller. Signed-off-by: Viktar Simanenka --- v3:nothing changed from v2 v2:checked and fixed with sparse and smatch changed param prefixes v2 link: https://lore.kernel.org/linux-devicetre

[PATCH v3 1/2] dt-bindings: display: add bindings for pcd8544 displays

2023-07-20 Thread Viktar Simanenka
Add device tree binding documentation for PCD8544 LCD display controller. Signed-off-by: Viktar Simanenka --- v3:add a little more description to the exposed vendor properties add commit message finally v2 link: https://lore.kernel.org/linux-devicetree/20230719154450.620410-1-viteo...@gmail.c

[PATCH next] drm/loongson: Fix error handling in lsdc_pixel_pll_setup()

2023-07-20 Thread Harshit Mogalapalli
There are two problems in lsdc_pixel_pll_setup() 1. If kzalloc() fails then call iounmap() to release the resources. 2. Both kzalloc and ioremap doesnot return error pointers on failure, so using IS_ERR_OR_NULL() checks is a bit confusing and not very right, fix this by changing those to NULL

  1   2   >