Re: [PATCH v5 9/9] drm: Introduce documentation for hotspot properties

2023-07-19 Thread Simon Ser
On Thursday, July 20th, 2023 at 07:03, Zack Rusin wrote: > I'll give this series a few more hours on the list and if no one objects I'll > push > it to drm-misc later today. Thanks! Sorry, but this doesn't seem to be enough to satisfy the DRM merge requirements. This introduces a new uAPI but i

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-19 Thread Frieder Schrempf
On 19.07.23 18:34, Tim Harvey wrote: > On Wed, Jul 19, 2023 at 12:05 AM Frieder Schrempf > wrote: >> >> Hi Tim, >> >> On 19.07.23 01:03, Tim Harvey wrote: >>> On Thu, Jul 13, 2023 at 3:01 AM Frieder Schrempf >>> wrote: Hi Tim, On 13.07.23 09:18, Frieder Schrempf wrote: > H

[drm-misc:for-linux-next 2/2] drivers/gpu/drm/drm_debugfs.c:212:28: warning: cast from pointer to integer of different size

2023-07-19 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 4f66feeab173bd73e71028b8c2e1dcea07e32dd5 commit: 4f66feeab173bd73e71028b8c2e1dcea07e32dd5 [2/2] drm: debugfs: provide infrastructure to dump a DRM GPU VA space config: m68k-allyesconfig (https://download.01.org/0day-ci/arch

[drm-misc:for-linux-next 1/2] drivers/gpu/drm/drm_gpuva_mgr.c:622:48: warning: format specifies type 'unsigned long' but the argument has type 'unsigned int'

2023-07-19 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc for-linux-next head: 4f66feeab173bd73e71028b8c2e1dcea07e32dd5 commit: e6303f323b1ad9c02ae813fc3dedeaa9dadfd3b0 [1/2] drm: manager to keep track of GPUs VA mappings config: hexagon-randconfig-r004-20230720 (https://download.01.org/0day-ci/archiv

Re: [PATCH v2] fb: Explicitly include correct DT includes

2023-07-19 Thread Helge Deller
On 7/18/23 16:32, Rob Herring wrote: The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform

Re: [PATCH 1/7] vgacon: switch vgacon_scrolldelta() and vgacon_restore_screen()

2023-07-19 Thread Helge Deller
On 7/12/23 10:59, Jiri Slaby (SUSE) wrote: Switch vgacon_scrolldelta() and vgacon_restore_screen() positions, so that the former is not needed to be forward-declared. Signed-off-by: Jiri Slaby (SUSE) Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Thanks

[PATCH] backlight: gpio_backlight: Drop output gpio direction check for initial power state

2023-07-19 Thread Ying Liu
Bootloader may leave gpio direction as input and gpio value as logical low. It hints that initial backlight power state should be FB_BLANK_POWERDOWN since the gpio value is literally logical low. So, let's drop output gpio direction check and only check gpio value to set the initial power state.

Re: [PATCH][next][V2] video: fbdev: kyro: make some const read-only arrays static and reduce type size

2023-07-19 Thread Helge Deller
On 7/12/23 18:11, Colin Ian King wrote: Don't populate the const read-only arrays on the stack but instead make them static const. Use smaller types to use less storage for the arrays. Also makes the object code a little smaller. Signed-off-by: Colin Ian King applied. Thanks! Helge --- V

Re: [PATCH v5 9/9] drm: Introduce documentation for hotspot properties

2023-07-19 Thread Zack Rusin
On Wed, 2023-07-19 at 11:15 +0300, Pekka Paalanen wrote: > On Tue, 18 Jul 2023 21:42:18 -0400 > Zack Rusin wrote: > > > From: Michael Banack > > > > To clarify the intent and reasoning behind the hotspot properties > > introduce userspace documentation that goes over cursor handling > > in para

[PATCH] vt: remove spaces after '*'

2023-07-19 Thread sunran001
remove redundant spaces to clear checkpatch errors. ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Ran Sun --- include/linux/kbd_kern.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/linux/kbd_kern.h b/include/linux/kbd_kern.h index c

[PATCH v2 2/2] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-07-19 Thread Carlos Eduardo Gallo Filho
The functions drm_framebuffer_plane_{width,height} and fb_plane_{width,height} do exactly the same job of its equivalents drm_format_info_plane_{width,height} from drm_fourcc. The only reason to have these functions on drm_framebuffer would be if they would added a abstraction layer to call it jus

[PATCH v2 1/2] drm: Remove plane hsub/vsub alignment requirement for core helpers

2023-07-19 Thread Carlos Eduardo Gallo Filho
The drm_format_info_plane_{height,width} functions was implemented using regular division for the plane size calculation, which cause issues [1][2] when used on contexts where the dimensions are misaligned with relation to the subsampling factors. So, replace the regular division by the DIV_ROUND_U

[PATCH v2 0/2] drm: Refactor plane size calculation by core helper functions

2023-07-19 Thread Carlos Eduardo Gallo Filho
There's duplicated functions on drm that do the same job of calculating the size of planes from a drm_format_info and the size of its first plane. So this patchset throw away the more specific version intended to be used from a given framebuffer and make the generic version way more portable agains

Re: [PATCH v6 05/11] drm/mediatek: dp: Move AUX_P0 setting to mtk_dp_initialize_aux_settings()

2023-07-19 Thread 胡俊光

Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment

2023-07-19 Thread Randy Dunlap
On 7/19/23 18:05, Yang Li wrote: > Use colon to separate parameter name from their specific meaning. > silence the warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or > member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags' > > Signed-off-by

[PATCH -next] drm/amdgpu: Fix one kernel-doc comment

2023-07-19 Thread Yang Li
Use colon to separate parameter name from their specific meaning. silence the warning: drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags' Signed-off-by: Yang Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-19 Thread Matt Roper
On Wed, Jul 19, 2023 at 05:07:15PM -0700, Yang, Fei wrote: > [snip] > >> @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct > >> drm_i915_gem_object *obj) > > > > The code change here looks accurate, but while we're here, I have a side > > question about this function in general...it wa

[PATCH drm-misc-next v8 12/12] drm/nouveau: debugfs: implement DRM GPU VA debugfs

2023-07-19 Thread Danilo Krummrich
Provide the driver indirection iterating over all DRM GPU VA spaces to enable the common 'gpuvas' debugfs file for dumping DRM GPU VA spaces. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a

[PATCH drm-misc-next v8 11/12] drm/nouveau: implement new VM_BIND uAPI

2023-07-19 Thread Danilo Krummrich
This commit provides the implementation for the new uapi motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address (VA) space via the new DRM_IOCTL_NOUVEAU_VM_INIT ioctl for UMDs to specify the portion of VA space managed by the kernel and usersp

[PATCH drm-misc-next v8 09/12] drm/nouveau: chan: provide nouveau_channel_kill()

2023-07-19 Thread Danilo Krummrich
The new VM_BIND UAPI implementation introduced in subsequent commits will allow asynchronous jobs processing push buffers and emitting fences. If a job times out, we need a way to recover from this situation. For now, simply kill the channel to unblock all hung up jobs and signal userspace that th

[PATCH drm-misc-next v8 10/12] drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm

2023-07-19 Thread Danilo Krummrich
The new VM_BIND UAPI uses the DRM GPU VA manager to manage the VA space. Hence, we a need a way to manipulate the MMUs page tables without going through the internal range allocator implemented by nvkm/vmm. This patch adds a raw interface for nvkm/vmm to pass the resposibility for managing the add

[PATCH drm-misc-next v8 08/12] drm/nouveau: fence: fail to emit when fence context is killed

2023-07-19 Thread Danilo Krummrich
The new VM_BIND UAPI implementation introduced in subsequent commits will allow asynchronous jobs processing push buffers and emitting fences. If a fence context is killed, e.g. due to a channel fault, jobs which are already queued for execution might still emit new fences. In such a case a job wo

[PATCH drm-misc-next v8 06/12] drm/nouveau: move usercopy helpers to nouveau_drv.h

2023-07-19 Thread Danilo Krummrich
Move the usercopy helpers to a common driver header file to make it usable for the new API added in subsequent commits. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_drv.h | 26 ++ drivers/gpu/drm/nouveau/nouveau_gem.c | 26 --

[PATCH drm-misc-next v8 07/12] drm/nouveau: fence: separate fence alloc and emit

2023-07-19 Thread Danilo Krummrich
The new (VM_BIND) UAPI exports DMA fences through DRM syncobjs. Hence, in order to emit fences within DMA fence signalling critical sections (e.g. as typically done in the DRM GPU schedulers run_job() callback) we need to separate fence allocation and fence emitting. Signed-off-by: Danilo Krummric

[PATCH drm-misc-next v8 05/12] drm/nouveau: bo: initialize GEM GPU VA interface

2023-07-19 Thread Danilo Krummrich
Initialize the GEM's DRM GPU VA manager interface in preparation for the (u)vmm implementation, provided by subsequent commits, to make use of it. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_bo.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/nouve

[PATCH drm-misc-next v8 04/12] drm/nouveau: get vmm via nouveau_cli_vmm()

2023-07-19 Thread Danilo Krummrich
Provide a getter function for the client's current vmm context. Since we'll add a new (u)vmm context for UMD bindings in subsequent commits, this will keep the code clean. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +- drivers/gpu/drm/nouveau/nouveau_chan.c |

[PATCH drm-misc-next v8 02/12] drm: debugfs: provide infrastructure to dump a DRM GPU VA space

2023-07-19 Thread Danilo Krummrich
This commit adds a function to dump a DRM GPU VA space and a macro for drivers to register the struct drm_info_list 'gpuvas' entry. Most likely, most drivers might maintain one DRM GPU VA space per struct drm_file, but there might also be drivers not having a fixed relation between DRM GPU VA spac

[PATCH drm-misc-next v8 03/12] drm/nouveau: new VM_BIND uapi interfaces

2023-07-19 Thread Danilo Krummrich
This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address (VA) space via the new DRM_IOCTL_NOUVEAU_VM_INIT ioctl. UMDs can provide a kernel reserved VA area. 2) Bind and unbind GPU VA space ma

[PATCH drm-misc-next v8 01/12] drm: manager to keep track of GPUs VA mappings

2023-07-19 Thread Danilo Krummrich
Add infrastructure to keep track of GPU virtual address (VA) mappings with a decicated VA space manager implementation. New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers start implementing, allow userspace applications to request multiple and arbitrary GPU VA mappings of buffe

[PATCH drm-misc-next v8 00/12] DRM GPUVA Manager & Nouveau VM_BIND UAPI

2023-07-19 Thread Danilo Krummrich
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch series provides a new UAPI for the Nouveau driver in order to support Vulkan features, such as sparse bindings and sparse residency. Furthermore, with the DRM GPUVA manager it provides a new DRM c

RE: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-19 Thread Yang, Fei
[snip] >> @@ -27,15 +28,8 @@ static bool gpu_write_needs_clflush(struct >> drm_i915_gem_object *obj) > > The code change here looks accurate, but while we're here, I have a side > question about this function in general...it was originally introduced > in commit 48004881f693 ("drm/i915: Mark CPU c

Re: [RFC PATCH 00/10] Device Memory TCP

2023-07-19 Thread Jason Gunthorpe
On Wed, Jul 19, 2023 at 10:57:11AM -0700, Stephen Hemminger wrote: > Naive idea. > Would it be possible for process to use mmap() on the GPU memory and then > do zero copy TCP receive some how? Or is this what is being proposed. It could be possible, but currently there is no API to recover the u

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread suijingfeng
On 2023/7/20 03:32, Bjorn Helgaas wrote: but I think it's just confusing to mention this in the commit log, so I would just remove it. Ok, will be done at the next version.

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread Sui Jingfeng
On 2023/7/20 06:32, suijingfeng wrote: it will be works no matter CONFIG_DRM_AST=m or CONFIG_DRM_AST=y It will be works regardless of CONFIG_DRM_AST=m or CONFIG_DRM_AST=y. When vgaarb call to the device driver, device driver already loaded successfully. and the PCI(e) device emulation al

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread suijingfeng
Hi, On 2023/7/20 03:32, Bjorn Helgaas wrote: [+cc linux-pci (please cc in the future since the bulk of this patch is in drivers/pci/)] On Wed, Jul 12, 2023 at 12:43:05AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng Currently, the strategy of selecting the default boot on a multiple video ca

Re: [PATCH v3] drm/i915: Refactor PAT/object cache handling

2023-07-19 Thread Matt Roper
On Wed, Jul 19, 2023 at 01:37:30PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit 9275277d5324 ("drm/i915: use pat_index instead of cache_level") has > introduced PAT indices to i915 internal APIs, partially replacing the > usage of driver internal cache_level, but has also added

Re: [PATCH v3 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-07-19 Thread Dmitry Baryshkov
On Thu, 20 Jul 2023 at 01:09, Marijn Suijten wrote: > > On 2023-07-19 01:06:03, Dmitry Baryshkov wrote: > > On 19/07/2023 00:24, Marijn Suijten wrote: > > > SM6125 is identical to SM6375 except that while downstream also defines > > > a throttle clock, its presence results in timeouts whereas SM63

Re: [PATCH v3 06/15] dt-bindings: display/msm: sc7180-dpu: Describe SM6125

2023-07-19 Thread Marijn Suijten
On 2023-07-19 01:06:03, Dmitry Baryshkov wrote: > On 19/07/2023 00:24, Marijn Suijten wrote: > > SM6125 is identical to SM6375 except that while downstream also defines > > a throttle clock, its presence results in timeouts whereas SM6375 > > requires it to not observe any timeouts. This is repres

Re: [PATCH v2 02/41] dt-bindings: display: Add Renesas SH-Mobile LCDC bindings

2023-07-19 Thread Rob Herring
On Tue, 18 Jul 2023 18:54:07 +0200, Geert Uytterhoeven wrote: > Add device tree bindings for the LCD Controller (LCDC) found in Renesas > SuperH SH-Mobile and ARM SH/R-Mobile SOCs. > > Based on a plain text prototype by Laurent Pinchart. > > Signed-off-by: Geert Uytterhoeven > --- > Cc: Rob He

Re: [Intel-gfx] [PATCH v3 3/9] PCI/VGA: Switch to aperture_contain_firmware_fb_nonreloc()

2023-07-19 Thread suijingfeng
Hi, On 2023/7/20 04:43, Bjorn Helgaas wrote: [+cc linux-pci; I don't apply or ack PCI patches unless they appear there] On Wed, Jul 12, 2023 at 12:43:04AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng The observation behind this is that we should avoid accessing the global screen_info direct

Re: [PATCH v3 02/15] arm64: dts: qcom: sm6125: Sort spmi_bus node numerically by reg

2023-07-19 Thread Marijn Suijten
On 2023-07-19 01:02:56, Dmitry Baryshkov wrote: > On 19/07/2023 00:24, Marijn Suijten wrote: > > This node has always resided in the wrong spot, making it somewhat > > harder to contribute new node entries while maintaining proper sorting > > around it. Move the node up to sit after hsusb_phy1 whe

Re: [PATCH v2 10/15] dt-bindings: msm: dsi-phy-14nm: Document SM6125 variant

2023-07-19 Thread Marijn Suijten
On 2023-07-19 01:01:54, Dmitry Baryshkov wrote: > On 19/07/2023 00:00, Marijn Suijten wrote: > > On 2023-06-29 13:54:13, Dmitry Baryshkov wrote: > >> On 27/06/2023 23:14, Marijn Suijten wrote: > >>> Document availability of the 14nm DSI PHY on SM6125. Note that this > >>> compatible uses the SoC-s

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-19 Thread suijingfeng
Hi, On 2023/7/20 05:13, Sui Jingfeng wrote: Otherwise there 30+ noisy(useless) events got snooped. See below: ``` [    0.246077] pci :01:00.0: vgaarb: setting as boot VGA device [    0.246077] pci :01:00.0: vgaarb: bridge control possible [    0.246077] pci :01:00.0: vgaarb: VGA d

[Bug 217664] Laptop doesnt wake up from suspend mode.

2023-07-19 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217664 --- Comment #6 from popus_czy_to_ty (pentelja...@o2.pl) --- tested debian 12 - dead tested mx linux with card choose during instalation, chosen amdgpu - dead -- You may reply to this email to add a comment. You are receiving this mail because:

Re: [PATCH v3 1/9] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-07-19 Thread suijingfeng
Hi, On 2023/7/20 04:43, Bjorn Helgaas wrote: On Wed, Jul 12, 2023 at 12:43:02AM +0800, Sui Jingfeng wrote: From: Sui Jingfeng This patch adds the aperture_contain_firmware_fb() function to do the determination. Unfortunately, due to the fact that the apertures list will be freed dynamically,

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-19 Thread Sui Jingfeng
Hi, On 2023/7/20 02:26, Bjorn Helgaas wrote: On Tue, Jul 11, 2023 at 09:43:50PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng Currently, vgaarb only cares about PCI VGA-compatible class devices. While vga_arbiter_del_pci_device() gets called unbalanced when some PCI device is about to be rem

Re: [PATCH] drm/pl111: Fix missing unwind goto in pl111_amba_probe()

2023-07-19 Thread Javier Martinez Canillas
Harshit Mogalapalli writes: > Smatch reports: > drivers/gpu/drm/pl111/pl111_drv.c:300 > pl111_amba_probe() warn: missing unwind goto? > > When devm_request_irq() returns non-zero value, we need to drop the > reference for drm device and also release reserved memory which is > done in

Re: [PATCH] drm/shmem-helper: Remove duplicate include

2023-07-19 Thread Javier Martinez Canillas
Jiapeng Chong writes: > ./drivers/gpu/drm/drm_gem_shmem_helper.c: linux/module.h is included more > than once. > > Reported-by: Abaci Robot > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4567 > Signed-off-by: Jiapeng Chong > --- Reviewed-by: Javier Martinez Canillas -- Best regards

Re: [PATCH v3 1/9] video/aperture: Add a helper to detect if an aperture contains firmware FB

2023-07-19 Thread Bjorn Helgaas
On Wed, Jul 12, 2023 at 12:43:02AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > This patch adds the aperture_contain_firmware_fb() function to do the > determination. Unfortunately, due to the fact that the apertures list > will be freed dynamically, the location and size information of th

Re: [Intel-gfx] [PATCH v3 3/9] PCI/VGA: Switch to aperture_contain_firmware_fb_nonreloc()

2023-07-19 Thread Bjorn Helgaas
[+cc linux-pci; I don't apply or ack PCI patches unless they appear there] On Wed, Jul 12, 2023 at 12:43:04AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > The observation behind this is that we should avoid accessing the global > screen_info directly. Call the aperture_contain_firmware_fb

Re: [PATCH 1/2] drm/mipi-dbi: Lock SPI bus before setting D/C GPIO

2023-07-19 Thread kernel test robot
Hi Otto, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.5-rc2 next-20230719] [If

Re: [RFC PATCH 00/10] Device Memory TCP

2023-07-19 Thread Jakub Kicinski
On Wed, 19 Jul 2023 08:10:58 -0700 Mina Almasry wrote: > From Jakub and David's comments it sounds (if I understood correctly), > you'd like to tie the dma-buf bind/unbind functions to the lifetime of > a netlink socket, rather than a struct file like I was thinking. That > does sound cleaner, but

Re: [RFC v5 00/17] DRM cgroup controller with scheduling control and memory stats

2023-07-19 Thread T.J. Mercier
On Wed, Jul 12, 2023 at 4:47 AM Tvrtko Ursulin wrote: > > drm.memory.stat > A nested file containing cumulative memory statistics for the whole > sub-hierarchy, broken down into separate GPUs and separate memory > regions supported by the latter. > > For example::

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-19 Thread suijingfeng
On 2023/7/20 03:58, Sui Jingfeng wrote: On the other hand, even though the lest significant 8 but if pdev->class is really matter. If the low eight bits of pdev->class is really matters, maybe we should wait the potential problems became severe. Currently, it is not obvious.

Re: [PATCH v5 1/2] dt-bindings: display/msm: mdss-common: add memory-region property

2023-07-19 Thread Rob Herring
On Thu, 13 Jul 2023 22:22:37 +0530, Amit Pundir wrote: > Add and document the reserved memory region property in the > mdss-common schema. > > For now (sdm845-db845c), it points to a framebuffer memory > region reserved by the bootloader for splash screen. > > Signed-off-by: Amit Pundir > ---

Re: [PATCH 11/11] drm/vc4: tests: pv-muxing: Document test scenario

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > We've had a couple of tests that weren't really obvious, nor did they > document what they were supposed to test. Document that to make it > hopefully more obvious. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier M

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-19 Thread suijingfeng
On 2023/7/20 03:58, Sui Jingfeng wrote: My explanation about the minor tweak being made before this version and previous version is that  I want to keep my patch *less distraction*. The minor tweak being made between this version and previous version is to keep my patch *less distraction

Re: [PATCH 10/11] drm/vc4: tests: Switch to atomic state allocation helper

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > Now that we have a helper that takes care of an atomic state allocation > and cleanup, we can migrate to it to simplify our tests. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Re

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-19 Thread suijingfeng
On 2023/7/20 03:58, Sui Jingfeng wrote: What this version adds here is *same* before this patch set is applied. The filter method is *same* , in the cases of before this patch is applied and after this patch is applied.

Re: [PATCH 09/11] drm/vc4: tests: pv-muxing: Switch to managed locking init

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > The new helper to init the locking context allows to remove some > boilerplate. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat

Re: [PATCH 08/11] drm/vc4: tests: mock: Use a kunit action to unregister DRM device

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > The *_mock_device functions allocate a DRM device that needs to be > released using drm_dev_unregister. > > Now that we have a kunit release action API, we can switch to it and > don't require any kind of garbage collection from the caller. > > Signed-off-by: Maxime Ripard

Re: [PATCH 07/11] drm/vc4: tests: pv-muxing: Remove call to drm_kunit_helper_free_device()

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > Calling drm_kunit_helper_free_device() to clean up the resources > allocated by drm_kunit_helper_alloc_device() is now optional and not > needed in most cases. > > Remove it. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards,

Re: [PATCH 06/11] drm/tests: helpers: Create an helper to allocate an atomic state

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > As we gain more tests, boilerplate to allocate an atomic state and free > it starts to be there more and more as well. > > In order to reduce the allocation boilerplate, we can create an helper > to create that atomic state, and call an action when the test is done. > This

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-19 Thread Sui Jingfeng
Hi, On 2023/7/20 02:26, Bjorn Helgaas wrote: On Tue, Jul 11, 2023 at 09:43:50PM +0800, Sui Jingfeng wrote: [...] Reviewed-by: Mario Limonciello Signed-off-by: Sui Jingfeng I do not see Mario's Reviewed-by on the list. I do see Mario's Reviewed-by [2] for a previous version, but that versi

Re: [Intel-xe] [PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-07-19 Thread Zanoni, Paulo R
On Sat, 2023-07-15 at 17:45 +0200, Thomas Hellström wrote: > Add a motivation for and description of asynchronous VM_BIND operation I think I may have missed some other documentation, which would explain some of my questions below, so please be patient with my misunderstandings. But here's a revie

Re: [PATCH v3 0/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread Bjorn Helgaas
[+cc linux-pci] On Wed, Jul 12, 2023 at 12:43:01AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Currently, the default VGA device selection is not perfect. Potential > problems are: > > 1) This function is a no-op on non-x86 architectures. > 2) It does not take the PCI Bar may get reloca

Re: [PATCH v3 4/9] PCI/VGA: Improve the default VGA device selection

2023-07-19 Thread Bjorn Helgaas
[+cc linux-pci (please cc in the future since the bulk of this patch is in drivers/pci/)] On Wed, Jul 12, 2023 at 12:43:05AM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Currently, the strategy of selecting the default boot on a multiple video > card coexistence system is not perfect. Pot

Re: [05/11] drm/tests: helpers: Create an helper to allocate a locking ctx

2023-07-19 Thread Javier Martinez Canillas
suijingfeng writes: > Hi, > > On 2023/7/10 15:47, Maxime Ripard wrote: >> As we get more and more tests, the locking context initialisation [...] >> +/** >> + * drm_kunit_helper_context_alloc - Allocates an acquire context >> + * @test: The test context object >> + * >> + * Allocates and initia

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

2023-07-19 Thread Krzysztof Kozlowski
On 19/07/2023 17:21, Luca Ceresoli wrote: > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > 480x800 panel based on it. > diff --git a/MAINTAINERS b/MAINTAINERS > index aee340630eca..3c38699ee821 10064

Re: [05/11] drm/tests: helpers: Create an helper to allocate a locking ctx

2023-07-19 Thread Javier Martinez Canillas
suijingfeng writes: > Hi, > > On 2023/7/10 15:47, Maxime Ripard wrote: [...] >> + >> +/** >> + * drm_kunit_helper_context_alloc - Allocates an acquire context >> + * @test: The test context object >> + * >> + * Allocates and initializes a modeset acquire context. >> + * >> + * The context is ti

Re: [PATCH 05/11] drm/tests: helpers: Create an helper to allocate a locking ctx

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > As we get more and more tests, the locking context initialisation > creates more and more boilerplate, both at creation and destruction. > > Let's create a helper that will allocate, initialise a context, and > register kunit actions to clean up once the test is done. > >

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

2023-07-19 Thread Rob Herring
On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > 480x800 panel based on it. > > Signed-off-by: Luca Ceresoli > --- > .../display/panel/

Re: [PATCH 3/3] drm/scheduler: Clean up jobs when the scheduler is torn down.

2023-07-19 Thread Luben Tuikov
On 2023-07-19 14:16, Konstantin Ryabitsev wrote: > July 18, 2023 at 1:14 AM, "Luben Tuikov" wrote: Not sure about other drivers--they can speak for themselves and the CC list should include them--please use "dim add-missing-cc" and make sure that the Git commit description contain

Re: [PATCH v6 3/3] drm/virtio: Support sync objects

2023-07-19 Thread Dmitry Osipenko
27.06.2023 15:01, Geert Uytterhoeven пишет: > Hi Dmitry, > > On Mon, Jun 26, 2023 at 6:11 PM Dmitry Osipenko > wrote: >> On 6/25/23 18:36, Geert Uytterhoeven wrote: >>> On Sun, Jun 25, 2023 at 2:41 PM Dmitry Osipenko >>> wrote: On 6/25/23 11:47, Geert Uytterhoeven wrote: > On Sun, Apr 1

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-07-19 Thread Dmitry Osipenko
27.06.2023 20:16, Rob Clark пишет: ... >> Now these are just suggestions, and while I think they are good, you can >> safely ignore them. >> >> But there's also the DRM requirements, which state "userspace side must be >> fully reviewed and tested to the standards of that user-space project.". S

Re: [PATCH] drm/panel: r66451: select CONFIG_DRM_DISPLAY_DP_HELPER

2023-07-19 Thread Jessica Zhang
On 7/19/2023 6:09 AM, Arnd Bergmann wrote: From: Arnd Bergmann The newly added driver only builds when DRM_DISPLAY_DP_HELPER is enabled: x86_64-linux-ld: drivers/gpu/drm/panel/panel-visionox-r66451.o: in function `visionox_r66451_enable': panel-visionox-r66451.c:(.text+0x105): undefined re

Re: [PATCH 04/11] drm/tests: probe-helper: Remove call to drm_kunit_helper_free_device()

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > Calling drm_kunit_helper_free_device() to clean up the resources > allocated by drm_kunit_helper_alloc_device() is now optional and not > needed in most cases. > > Remove it. > > Signed-off-by: Maxime Ripard > --- I wonder if makes sense to just squash 2-3 and this one a

Re: [PATCH 03/11] drm/tests: modes: Remove call to drm_kunit_helper_free_device()

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > Calling drm_kunit_helper_free_device() to clean up the resources > allocated by drm_kunit_helper_alloc_device() is now optional and not > needed in most cases. > > Remove it. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards,

Re: [PATCH 02/11] drm/tests: client-modeset: Remove call to drm_kunit_helper_free_device()

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: > Calling drm_kunit_helper_free_device() to clean up the resources > allocated by drm_kunit_helper_alloc_device() is now optional and not > needed in most cases. > > Remove it. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Javier Martinez Canillas -- Best regards,

Re: [PATCH 01/11] drm/tests: helpers: Switch to kunit actions

2023-07-19 Thread Javier Martinez Canillas
Maxime Ripard writes: Hello Maxime, The patch looks good to me. I've two questions below though. Reviewed-by: Javier Martinez Canillas > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/tests/drm_kunit_helpers.c | 32 > +++ > 1 file changed, 28 insertions(+)

Re: [PATCH 2/6] PCI/VGA: Deal with PCI VGA compatible devices only

2023-07-19 Thread Bjorn Helgaas
On Tue, Jul 11, 2023 at 09:43:50PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > Currently, vgaarb only cares about PCI VGA-compatible class devices. > > While vga_arbiter_del_pci_device() gets called unbalanced when some PCI > device is about to be removed. This happens even during the bo

Re: [PATCH 2/4] PCI/VGA: Deal only with PCI VGA class devices

2023-07-19 Thread Bjorn Helgaas
On Tue, Jul 18, 2023 at 06:14:00PM -0500, Bjorn Helgaas wrote: > On Fri, Jun 30, 2023 at 06:17:29PM +0800, Sui Jingfeng wrote: > > From: Sui Jingfeng > > > > VGAARB should only care about PCI VGA class devices (pdev->class == 0x0300) > > since only those devices might have VGA routed to them. >

Re: [RFC PATCH 00/10] Device Memory TCP

2023-07-19 Thread Stephen Hemminger
On Wed, 19 Jul 2023 08:10:58 -0700 Mina Almasry wrote: > On Tue, Jul 18, 2023 at 3:45 PM Jakub Kicinski wrote: > > > > On Tue, 18 Jul 2023 16:35:17 -0600 David Ahern wrote: > > > I do not see how 1 RSS context (or more specifically a h/w Rx queue) can > > > be used properly with memory from di

Re: [PATCH v6 0/4] Allow disabling all native fbdev drivers and only keeping DRM emulation

2023-07-19 Thread Javier Martinez Canillas
Helge Deller writes: Hello Helge, > Hi Javier, > > On 7/19/23 10:15, Javier Martinez Canillas wrote: >> This patch series splits the fbdev core support in two different Kconfig >> symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to >> be disabled, while still having the the

Re: [PATCH v6 0/4] Allow disabling all native fbdev drivers and only keeping DRM emulation

2023-07-19 Thread Helge Deller
Hi Javier, On 7/19/23 10:15, Javier Martinez Canillas wrote: This patch series splits the fbdev core support in two different Kconfig symbols: FB and FB_CORE. The motivation for this is to allow CONFIG_FB to be disabled, while still having the the core fbdev support needed for the One "the" to

Re: [PATCH v2 1/2] dt-bindings: add bindings for pcd8544 displays

2023-07-19 Thread Krzysztof Kozlowski
On 19/07/2023 17:44, Viktar Simanenka wrote: > Signed-off-by: Viktar Simanenka You still miss commit msg. > > V2: deleted oneOf property from compatible > changed prefix from 'philips' to existing vendor prefix 'nxp' > placed `reg = <0>` right after `compatible` That's not where the changelog

[PATCH] drm/syncobj: add DRM_IOCTL_SYNCOBJ_IMPORT/EXPORT_SYNC_FILE

2023-07-19 Thread Erik Kurzinger
These new ioctls perform a task similar to DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD/FD_TO_HANDLE with the IMPORT/EXPORT_SYNC_FILE flag set, except that they allow specifying the timeline point to import or export the fence to or from on a timeline syncobj. This eliminates the need to use a temporary binary

Re: [PATCH 2/3] dt-bindings: display: panel: Add panels based on ILITEK ILI9806E

2023-07-19 Thread Conor Dooley
Hey Luca, On Wed, Jul 19, 2023 at 05:21:46PM +0200, Luca Ceresoli wrote: > Add bindings for LCD panels based on the ILITEK ILI9806E RGB controller > connected over SPI and the "ShenZhen New Display Co NDS040480800-V3" > 480x800 panel based on it. > > Signed-off-by: Luca Ceresoli > --- > .../dis

Re: [PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-07-19 Thread Tim Harvey
On Wed, Jul 19, 2023 at 12:05 AM Frieder Schrempf wrote: > > Hi Tim, > > On 19.07.23 01:03, Tim Harvey wrote: > > On Thu, Jul 13, 2023 at 3:01 AM Frieder Schrempf > > wrote: > >> > >> Hi Tim, > >> > >> On 13.07.23 09:18, Frieder Schrempf wrote: > >>> Hi Tim, > >>> > >>> On 13.07.23 00:34, Tim Har

Re: [PATCH v2 2/4] drm/tests: Add test for drm_framebuffer_check_src_coords()

2023-07-19 Thread Carlos
Hi Maxime, thanks for the reviews! On 7/19/23 04:49, Maxime Ripard wrote: Hi, On Tue, Jul 18, 2023 at 03:17:24PM -0300, Carlos Eduardo Gallo Filho wrote: Add a parametrized test for the drm_framebuffer_check_src_coords function. Signed-off-by: Carlos Eduardo Gallo Filho --- drivers/gpu/drm

Re: [PATCH v5] Documentation/gpu: Add a VM_BIND async draft document

2023-07-19 Thread Danilo Krummrich
On 7/15/23 17:45, Thomas Hellström wrote: Add a motivation for and description of asynchronous VM_BIND operation v2: - Fix typos (Nirmoy Das) - Improve the description of a memory fence (Oak Zeng) - Add a reference to the document in the Xe RFC. - Add pointers to sample uAPI suggestions v3: - Ad

[PATCH v2 1/2] dt-bindings: add bindings for pcd8544 displays

2023-07-19 Thread Viktar Simanenka
Signed-off-by: Viktar Simanenka V2: deleted oneOf property from compatible changed prefix from 'philips' to existing vendor prefix 'nxp' placed `reg = <0>` right after `compatible` About parameters exposed for controller: inverted - I had an unbranded display that after reset had all pixels blac

[PATCH v2 2/2] drm/tiny: add display driver for philips pcd8544 display controller

2023-07-19 Thread Viktar Simanenka
Support for common monochrome LCD displays based on PCD8544 (such as Nokia 5110/3310 LCD) SPI controlled displays. Signed-off-by: Viktar Simanenka V2: checked and fixed with sparse and smatch changed param prefixes v1 link: https://lore.kernel.org/linux-devicetree/20230718080727.323426-1-viteo

Re: [PATCH] drm: mediatek: mtk_dsi: Fix NO_EOT_PACKET settings/handling

2023-07-19 Thread Chun-Kuang Hu
Hi, Jitao: Do you have any comment? If you have no comment, I would apply this patch. Regards, Chun-Kuang. AngeloGioacchino Del Regno 於 2023年5月23日 週二 下午6:42寫道: > > Due to the initial confusion about MIPI_DSI_MODE_EOT_PACKET, properly > renamed to MIPI_DSI_MODE_NO_EOT_PACKET, reflecting its actu

[PATCH v3 3/4] drm: Remove references to removed transitional helpers

2023-07-19 Thread Geert Uytterhoeven
The transitional helpers were removed a long time ago, but some references stuck. Remove them. Fixes: 21ebe615c16994f3 ("drm: Remove transitional helpers") Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v3: - Add Reviewed-by, v2: - Drop "first part" in drivers/gpu/drm/

[PATCH v3 1/4] drm/todo: Add atomic modesetting references

2023-07-19 Thread Geert Uytterhoeven
The section about converting existing KMS drivers to atomic modesetting mentions the existence of a conversion guide, but does not reference it. While the guide is old and rusty, it still contains useful information, so add a link to it. Also link to the LWN.net articles that give an overview abou

[PATCH v3 0/4] drm: Atomic modesetting doc and comment improvements

2023-07-19 Thread Geert Uytterhoeven
Hi all, This patch series contains various improvements to the documentation and comments related to atomic modesetting. Hopefully, it will ease the job of DRM novice who want to tackle the daunting task of converting a legacy DRM driver to atomic modesetting. Changes compared to v2[1]:

[PATCH v3 2/4] drm/todo: Convert list of fbconv links to footnotes

2023-07-19 Thread Geert Uytterhoeven
Convert the references to fbconv links to footnotes, so they can be navigated. Signed-off-by: Geert Uytterhoeven --- v3: - Make main text read correctly when ignoring the footnotes, v2: - New. --- Documentation/gpu/todo.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH v3 4/4] drm: Fix references to drm_plane_helper_check_state()

2023-07-19 Thread Geert Uytterhoeven
As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer exists, but is part of drm_atomic_helper_check_plane_state(). Signed-off-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart --- v3: - No changes, v2:

[PATCH 3/3] DRM: panel: add Ilitek ILI9806E driver

2023-07-19 Thread Luca Ceresoli
Add a driver for the ILITEK ILI9806E 480x864 RGB LCD controller connected over SPI, and implement the ShenZhen New Display Co NDS040480800-V3 480x800 panel. Signed-off-by: Luca Ceresoli --- MAINTAINERS | 1 + drivers/gpu/drm/panel/Kconfig | 13

  1   2   3   >