Re: [PATCH 0/1] Backlight driver for the Apple Studio Display

I appreciate all of the feedback, this should be plenty for a v2. Thanks, Julius

Re: [PATCH v5 1/1] drm/doc: Document DRM device reset expectations

On Tue, Jul 4, 2023, 03:55 Michel Dänzer wrote: > On 7/4/23 04:34, Marek Olšák wrote: > > On Mon, Jul 3, 2023, 03:12 Michel Dänzer > wrote: > > On 6/30/23 22:32, Marek Olšák wrote: > > > On Fri, Jun 30, 2023 at 11:11 AM Michel Dänzer < > michel.daen...@

Missing AMDGPU drm-fixes-6.4 merges

Hi Dave, Alex, it seems that the last PR for AMDGPU 6.4 fixes wasn't taken by Linus due to the missing signed tag: https://lore.kernel.org/lkml/CAHk-=wiOCgiwzVPOwORHPML9eBphnbtM2DhRcv+v=-tnrrg...@mail.gmail.com/ And more importantly, this series isn't seen on linux-next, either; so the whole f

[v5, PATCH] drm/mediatek: add dma buffer control for drm plane disable

dma buffer release before overlay disable, that will cause m4u translation fault warning. add dma buffer control flow in mediatek driver: get dma buffer when drm plane disable put dma buffer when overlay really disable Fixes: 41016fe1028e ("drm: Rename plane->state variables in atomic update and

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

On Wed, Jul 5, 2023 at 11:09 AM Dmitry Baryshkov wrote: > > [Adding freedreno@ to cc list] > > On Wed, 5 Jul 2023 at 08:31, Jagan Teki wrote: > > > > Hi Amit, > > > > On Wed, Jul 5, 2023 at 10:15 AM Amit Pundir wrote: > > > > > > Hi Marek, > > > > > > On Wed, 5 Jul 2023 at 01:48, Marek Vasut wr

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

[Adding freedreno@ to cc list] On Wed, 5 Jul 2023 at 08:31, Jagan Teki wrote: > > Hi Amit, > > On Wed, Jul 5, 2023 at 10:15 AM Amit Pundir wrote: > > > > Hi Marek, > > > > On Wed, 5 Jul 2023 at 01:48, Marek Vasut wrote: > > > > > > Do not generate the HS front and back porch gaps, the HSA gap a

[PATCH] drm/ttm: fix one use-after-free

[ 67.399887] refcount_t: underflow; use-after-free. [ 67.399901] WARNING: CPU: 0 PID: 3172 at lib/refcount.c:28 refcount_warn_saturate+0xc2/0x110 [ 67.400124] RIP: 0010:refcount_warn_saturate+0xc2/0x110 [ 67.400173] Call Trace: [ 67.400176] [ 67.400181] ttm_mem_evict_first+0x4fe/0x5

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

Hi Amit, On Wed, Jul 5, 2023 at 10:15 AM Amit Pundir wrote: > > Hi Marek, > > On Wed, 5 Jul 2023 at 01:48, Marek Vasut wrote: > > > > Do not generate the HS front and back porch gaps, the HSA gap and > > EOT packet, as these packets are not required. This makes the bridge > > work with Samsung D

Re: [PATCH 2/2] drm/bridge: lt9611: Do not generate HFP/HBP/HSA and EOT packet

Hi Marek, On Wed, 5 Jul 2023 at 01:48, Marek Vasut wrote: > > Do not generate the HS front and back porch gaps, the HSA gap and > EOT packet, as these packets are not required. This makes the bridge > work with Samsung DSIM on i.MX8MM and i.MX8MP. This patch broke display on Dragonboard 845c (SD

[PATCH] virtio-gpu: Remove stride and layer_stride check for dGPU prime on VM

Remove stride and layer_stride check in virtio-gpu so that virgl can send transfer data command with non zero stride to sync up data from guest to host for dGPU prime on VM. Link: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23896 Signed-off-by: Julia Zhang --- drivers/gpu/drm/virt

Re: [PATCH 24/29] mm: vmscan: make global slab shrink lockless

On 2023/7/4 11:45, Qi Zheng wrote: On 2023/7/4 00:39, Paul E. McKenney wrote: On Fri, Jun 23, 2023 at 04:29:39PM +1000, Dave Chinner wrote: On Thu, Jun 22, 2023 at 05:12:02PM +0200, Vlastimil Babka wrote: On 6/22/23 10:53, Qi Zheng wrote: @@ -1067,33 +1068,27 @@ static unsigned long shrin

RE: [PATCH 05/10] drm/exynos: Use fbdev DMA helpers

Hi, > -Original Message- > From: Thomas Zimmermann > Sent: Wednesday, July 5, 2023 12:50 AM > To: javi...@redhat.com; maarten.lankho...@linux.intel.com; > mrip...@kernel.org > Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org; > linux-samsung-...@vger.kernel.org; l

Re: [11/12] fbdev/core: Protect edid_info with CONFIG_ARCH_HAS_EDID_INFO

Hi, On 2023/6/29 19:45, Thomas Zimmermann wrote: Guard usage of edid_info with CONFIG_ARCH_HAS_EDID_INFO instead of CONFIG_X86. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Cc: Daniel Vetter Cc: Helge Deller Cc: Randy Dunlap --- drivers/video/f

Re: [03/12] sysfb: Do not include from sysfb header

On 2023/6/29 19:45, Thomas Zimmermann wrote: The header file does not need anything from . Declare struct screen_info and remove the include statements. Signed-off-by: Thomas Zimmermann Cc: Ard Biesheuvel Cc: Hans de Goede Cc: Javier Martinez Canillas Reviewed-by: Javier Martinez Canillas

Re: [01/12] efi: Do not include from EFI header

Hi, Thomas I love your patch, LoongArch also have UEFI GOP support, Maybe the arch/loongarch/kernel/efi.c don't include the '#include ' explicitly. ``` diff --git a/arch/loongarch/kernel/efi.c b/arch/loongarch/kernel/efi.c index 3d448fef3af4..04f4d217aefb 100644 --- a/arch/loongarch/kernel

Re: [08/12] drivers/firmware: Remove trailing whitespaces

Hi, On 2023/6/29 19:45, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng --- drivers/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/Kconfig b/drivers/fir

Re: [05/12] arch: Remove trailing whitespaces

On 2023/6/29 19:45, Thomas Zimmermann wrote: Fix coding style. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Yoshinori Sato Cc: Rich Felker Cc: John Paul Adrian Glaubitz Cc: Andrew Morton Cc: Geert Uytterhoeven Cc: Arnd Bergmann Cc: "Kirill A. Shutemov" Cc: Anshuman Khand

Re: [06/12] arch: Declare screen_info in

Hi, Thomas I love your patch, yet after applied your patch, the linux kernel fail to compile on my LoongArch machine. ```   CC  arch/loongarch/kernel/efi.o arch/loongarch/kernel/efi.c: In function ‘init_screen_info’: arch/loongarch/kernel/efi.c:77:54: error: invalid application of ‘siz

Re: [PATCH v2] drm/i915: Refactor PAT/cache handling

>>> From: Tvrtko Ursulin >>> >>> Informal commit message for now. >>> >>> I got a bit impatient and curious to see if the idea we discussed would >>> work so sketched something out. I think it is what I was describing back >>> then.. >>> >>> So high level idea is to teach the driver what caching m

Re: [PATCH] drm/vmwgfx: Fix shader stage validation

What tree has/is this landing via, not seeing it upstream yet. Dave. On Sat, 17 Jun 2023 at 20:25, Martin Krastev (VMware) wrote: > > From: Martin Krastev > > > Looks good! > > > Reviewed-by: Martin Krastev > > > Regards, > > Martin > > > On 16.06.23 г. 22:09 ч., Zack Rusin wrote: > > From: Za

Re: [v4, PATCH] drm/mediatek: add dma buffer control for drm plane disable

Hi Yongqiang, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.4 next-20230704] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v4 04/19] drm/msm/dpu: drop dpu_mdss_cfg::mdp_count field

On 7/4/2023 10:28 AM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 19:10, Abhinav Kumar wrote: On 7/4/2023 4:52 AM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 13:06, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 07:04, Abhinav Kumar wrote: On 7/3/2023 7:20 PM, Dmitry Baryshko

Re: drm/drm_gem.c: Remove surplus else after return

Hi, On 2023/7/5 02:14, Sui Jingfeng wrote: I have merge this patch with the dim tool, by using the following command, I have merged(pushed) this patch just now to drm-misc-next branch.

Re: drm/drm_gem.c: Remove surplus else after return

Hi,  Thomas On 2023/6/22 18:18, Sui Jingfeng wrote: else is not generally useful after return Signed-off-by: Sui Jingfeng Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/driver

[PATCH v2] backlight: led_bl: fix initial power state

The condition for the initial power state based on the default brightness value is reversed. Fix it. Furthermore, use the actual state of the LEDs rather than the default brightness specified in the devicetree as the latter should not cause the backlight to be automatically turned on. If the bac

[PATCH] backlight: led_bl: fix initial power state

The condition for the initial power state based on the default brightness value is reversed. Fix it. Fixes: ae232e45acf9 ("backlight: add led-backlight driver") Signed-off-by: Mans Rullgard --- drivers/video/backlight/led_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On Sun, 2 Jul 2023 at 20:24, Krzysztof Kozlowski wrote: > > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Rob, > > Maybe this could go via your tree? Rebased on your for-next: > v6.4-rc2-45-gf0ac35049606 > --- > .../bindings/arm/arm,

[PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()

Use devm_platform_ioremap_resource() to simplify code. Signed-off-by: Yangtao Li --- drivers/video/fbdev/imxfb.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c index adf36690c342..517eb65bbaa6 100644 --- a/driv

Re: [PATCH] backlight: led_bl: fix initial power state

Daniel Thompson writes: > On Tue, Jul 04, 2023 at 03:07:50PM +0100, Mans Rullgard wrote: >> The condition for the initial power state based on the default >> brightness value is reversed. Fix it. >> >> Fixes: ae232e45acf9 ("backlight: add led-backlight driver") >> Signed-off-by: Mans Rullgard >

Re: [PATCH v4 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

On Tuesday, July 4th, 2023 at 19:06, Sebastian Wick wrote: > > + * When used with atomic uAPI, the driver will return an error if the > > hardware > > + * doesn't support performing an asynchronous page-flip for this update. > > + * User-space should handle this, e.g. by falling back to a regul

[PATCH v4 4/4] drm/msm/mdp5: move resource allocation to the _probe function

To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 100 ++- 1 file chan

[PATCH v4 3/4] drm/msm/mdp4: move resource allocation to the _probe function

To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers

[PATCH v4 1/4] drm/msm: allow passing struct msm_kms to msm_drv_probe()

In preparation of moving resource allocation to the probe time, allow MSM KMS drivers to pass struct msm_kms pointer via msm_drv_probe(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 2 +- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 2 +- drivers/gpu/drm/msm/disp

[PATCH v4 2/4] drm/msm/dpu: move resource allocation to the _probe function

To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). This also drops devm_iounmap() calls. It is too early to have them _dpu_k

[PATCH v4 0/4] drm/msm: move resource allocation to the _probe function

This patchset was left untouched for almost a year. Let's reiterate it in attempt to solve the long-standing issue. As discussed several times on IRC, move display subdriver resource allocation from kms_init to probe time to let it bail early. Changes since v3: - Fixed MMIO unmaping in the DPU ca

Re: [PATCH v2 05/14] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

On Tue, 4 Jul 2023 at 18:55, Abhinav Kumar wrote: > > > > On 7/4/2023 8:03 AM, Dmitry Baryshkov wrote: > > Move perf mode handling for the bandwidth to > > _dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data > > and then aggregating known values. > > > > Note, this changes the fi

Re: [PATCH v4 04/19] drm/msm/dpu: drop dpu_mdss_cfg::mdp_count field

On Tue, 4 Jul 2023 at 19:10, Abhinav Kumar wrote: > > > > On 7/4/2023 4:52 AM, Dmitry Baryshkov wrote: > > On Tue, 4 Jul 2023 at 13:06, Dmitry Baryshkov > > wrote: > >> > >> On Tue, 4 Jul 2023 at 07:04, Abhinav Kumar > >> wrote: > >>> > >>> > >>> > >>> On 7/3/2023 7:20 PM, Dmitry Baryshkov wrot

Re: [PATCH 1/2] drm/msm/adreno: Fix warn splat for devices without revn

On Tue, 4 Jul 2023 at 19:36, Rob Clark wrote: > > From: Rob Clark > > Recently, a WARN_ON() was introduced to ensure that revn is filled before > adreno_is_aXYZ is called. This however doesn't work very well when revn is > 0 by design (such as for A635). > > Cc: Konrad Dybcio > Fixes: cc943f43ec

Re: [PATCH] backlight: led_bl: fix initial power state

Hi Daniel, > > @@ -200,8 +200,8 @@ static int led_bl_probe(struct platform_device *pdev) > > props.type = BACKLIGHT_RAW; > > props.max_brightness = priv->max_brightness; > > props.brightness = priv->default_brightness; > > - props.power = (priv->default_brightness > 0) ? FB_BLANK_POW

Re: [PATCH v4 1/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

On Sat, Jul 1, 2023 at 4:09 AM André Almeida wrote: > > From: Simon Ser > > If the driver supports it, allow user-space to supply the > DRM_MODE_PAGE_FLIP_ASYNC flag to request an async page-flip. > Set drm_crtc_state.async_flip accordingly. > > Document that drivers will reject atomic commits if

Re: [PATCH] drm/arm/komeda: Remove component framework and add a simple encoder

Hi Mohammed, On Tue, Jul 04, 2023 at 07:19:04PM +0530, Mohammad Faiz Abbas Rizvi wrote: > Hi Liviu, > > On 6/29/2023 3:21 PM, Liviu Dudau wrote: > > Hi Faiz, > > > > Thanks for the patch and for addressing what was at some moment on my "nice > > to > > improve / cleanup" list. Sorry for the dela

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

On 04/07/2023 16:54, Jani Nikula wrote: On Fri, 23 Jun 2023, Jocelyn Falempe wrote: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP") The default resolution is now 640x480 when no monitor is connected. But Aspeed graphics is mostly used in servers, where no m

[PATCH 1/2] drm/msm/adreno: Fix warn splat for devices without revn

From: Rob Clark Recently, a WARN_ON() was introduced to ensure that revn is filled before adreno_is_aXYZ is called. This however doesn't work very well when revn is 0 by design (such as for A635). Cc: Konrad Dybcio Fixes: cc943f43ece7 ("drm/msm/adreno: warn if chip revn is verified before bein

[PATCH 2/2] drm/msm/a690: Remove revn and name

From: Rob Clark These fields are deprecated. But any userspace new enough to support a690 also knows how to identify the GPU based on chip-id. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/adreno_device.c | 2 -- drivers/gpu/drm/msm/adreno/adreno_gpu.h| 3 ++- 2 files changed, 2

[PATCH v2] drm/arm/komeda: Remove component framework and add a simple encoder

The Komeda driver always expects the remote connector node to initialize an encoder. It uses the component aggregator framework which consists of component->bind() calls used to initialize the remote encoder and attach it to the crtc. This makes it incompatible with connector drivers which implemen

Re: [PATCH 05/12] arch: Remove trailing whitespaces

Thomas Zimmermann writes: > Fix coding style. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz > Cc: Andrew Morton > Cc: Geert Uytterhoeven > Cc: Arnd Bergmann > Cc: "Kirill A. Shutemov" > Cc: Anshuman Khand

Re: [PATCH 04/12] staging/sm750fb: Do not include

Thomas Zimmermann writes: > The sm750fb driver does not need anything from . > Remove the include statements. > > Signed-off-by: Thomas Zimmermann > Cc: Sudip Mukherjee > Cc: Teddy Wang > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Re

Re: [PATCH 03/12] sysfb: Do not include from sysfb header

Thomas Zimmermann writes: > The header file does not need anything from > . Declare struct screen_info and remove > the include statements. > > Signed-off-by: Thomas Zimmermann > Cc: Ard Biesheuvel > Cc: Hans de Goede > Cc: Javier Martinez Canillas > --- Reviewed-by: Javier Martinez Canilla

Re: [PATCH 02/12] fbdev/sm712fb: Do not include

Thomas Zimmermann writes: > Sm712fb's dependency on is artificial in that > it only uses struct screen_info for its internals. Replace the use of > struct screen_info with a custom data structure and remove the include > of . > > Signed-off-by: Thomas Zimmermann > Cc: Sudip Mukherjee > Cc: Ted

Re: [PATCH 01/12] efi: Do not include from EFI header

Thomas Zimmermann writes: > The header file does not need anything from > . Declare struct screen_info and remove > the include statements. Update a number of source files that > require struct screen_info's definition. > > Signed-off-by: Thomas Zimmermann > Cc: Ard Biesheuvel > Cc: Russell Ki

Re: [PATCH] drm/msm/dpu: add missing flush and fetch bits for DMA4/DMA5 planes

On 7/4/2023 9:01 AM, Jonathan Marek wrote: Note that with this, DMA4/DMA5 are still non-functional, but at least display *something* in modetest instead of nothing or underflow. Fixes: efcd0107727c ("drm/msm/dpu: add support for SM8550") Signed-off-by: Jonathan Marek --- Reviewed-by: Abhin

Re: [PATCH v4 3/5] drm/arm: Make ARM devices menu depend on DRM

On Tue, Jul 04, 2023 at 01:05:27AM +0200, Javier Martinez Canillas wrote: > Otherwise if CONFIG_DRM is disabled, menuconfig will show an empty menu. > > Signed-off-by: Javier Martinez Canillas Acked-by: Liviu Dudau Best regards, Liviu > --- > > (no changes since v1) > > drivers/gpu/drm/arm

Re: [PATCH v4 04/19] drm/msm/dpu: drop dpu_mdss_cfg::mdp_count field

On 7/4/2023 4:52 AM, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 13:06, Dmitry Baryshkov wrote: On Tue, 4 Jul 2023 at 07:04, Abhinav Kumar wrote: On 7/3/2023 7:20 PM, Dmitry Baryshkov wrote: On 03/07/2023 05:01, Abhinav Kumar wrote: On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote:

Re: [PATCH V2] drm/bridge: adv7533: Fix adv7533_mode_valid for adv7533 and adv7535

Hi, Adam, All On Sun, 19 Mar 2023 at 20:55, Adam Ford wrote: > > When dynamically switching lanes was removed, the intent of the code > was to check to make sure that higher speed items used 4 lanes, but > it had the unintended consequence of removing the slower speeds for > 4-lane users. > > Thi

[PATCH] drm/msm/dpu: add missing flush and fetch bits for DMA4/DMA5 planes

Note that with this, DMA4/DMA5 are still non-functional, but at least display *something* in modetest instead of nothing or underflow. Fixes: efcd0107727c ("drm/msm/dpu: add support for SM8550") Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 8 +++- 1 file cha

[PATCH 08/10] drm/omapdrm: Use GEM mmap for fbdev emulation

The fbdev emulation currently uses fbdev's default mmap code, which has been written for I/O memory. Provide an mmap that uses GEM's mmap infrastructure. Utilize fine-grained fbdev macros to initialize struct fb_ops. The macros set the read/write and the draw callbacks for DMA memory. Set the fb_m

[PATCH 10/10] fbdev: Remove FB_DEFAULT_SYS_OPS

Remove the initializer macro FB_DEFAULT_SYS_OPS and its helper macro __FB_DEFAULT_SYS_OPS_MMAP. There are no users. Signed-off-by: Thomas Zimmermann Cc: Helge Deller (maintainer:FRAMEBUFFER LAYER) --- include/linux/fb.h | 8 1 file changed, 8 deletions(-) diff --git a/include/linux/fb

[PATCH 06/10] drm/exynos: Set fbdev flags

Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. Signed-off-by: Thomas Zimmermann Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Krzysztof Kozlowski Cc

[PATCH 09/10] drm/omapdrm: Set fbdev flags

Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. Signed-off-by: Thomas Zimmermann Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_fbdev.c | 2 ++ 1 file ch

[PATCH 04/10] drm/tegra: Set fbdev flags

Set fbdev default flags FBNFO_DEFAULT and mark the framebuffer with FBINFO_VIRTFB. The framebuffer range is in DMA-able memory and should be accessed with the CPU's regular memory ops. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen --- drivers/gpu/drm/tegra/fbdev.c | 3

[PATCH 07/10] drm/omapdrm: Set VM flags in GEM-object mmap function

Use the mmap callback in struct drm_gem_object_funcs to set the VM flags. Replace a number of mmap helpers in omapdrm with their GEM helper counterparts. Generate DRM's file-operations instance with GEM's DEFINE_DRM_GEM_FOPS. Signed-off-by: Thomas Zimmermann Cc: Tomi Valkeinen --- drivers/gpu/d

[PATCH 03/10] drm/tegra: Use fbdev DMA helpers

Use fbdev's DMA helpers for fbdev emulation. They are equivalent to the previously used system-memory helpers, so no functional changes here. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen --- drivers/gpu/drm/tegra/Kconfig | 2 +- drivers/gpu/drm/tegra/fbdev.c | 4 ++--

[PATCH 05/10] drm/exynos: Use fbdev DMA helpers

Use fbdev's DMA helpers for fbdev emulation. They drivers previously used the I/O-memory helpers, while allocating DMA-able system memory. This could (in theory) result in bus errors from accessing the memory range. This bug has been present since the exynos driver was first added. Signed-off-by:

[PATCH 00/10] drm: Improve fbdev emulation for DMA-able framebuffers

Add fbdev helpers for framebuffers in DMA-able memory and update fbdev emulation in the respective DRM drivers. DMA memory used to handled as system memory. Improve this and prepare for possible future changes. Patch 1 adds initializer macros for struct fb_ops and a Kconfig token for framebuffers

[PATCH 02/10] drm/fbdev-dma: Use fbdev DMA helpers

Use fbdev's DMA helpers for fbdev-dma. They are equivalent to the previously used system-memory helpers, so no functional changes here. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 2 +- drivers/gpu/drm/drm_fbdev_dma.c | 4 ++-- 2 files changed, 3 insertions(+), 3 delet

[PATCH 01/10] fbdev: Add fb_ops init macros for framebuffers in DMA-able memory

Add initializer macros for struct fb_ops for framebuffers in DMA-able memory areas. Also add a corresponding Kconfig token. As of now, this is equivalent to system framebuffers and mostly useful for labeling drivers correctly. A later patch may add a generic DMA-specific mmap operation. Linux offe

Re: [PATCH v2 14/14] drm/msm/dpu: drop dpu_core_perf_destroy()

On 7/4/2023 8:03 AM, Dmitry Baryshkov wrote: This function does nothing, just clears several data pointers. Drop it now. Now, it doesnt even do that. Just resets the clk_rate to 0. Acked-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.

Re: [PATCH v2 05/14] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

On 7/4/2023 8:03 AM, Dmitry Baryshkov wrote: Move perf mode handling for the bandwidth to _dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data and then aggregating known values. Note, this changes the fix_core_ab_vote. Previously it would be multiplied per the CRTC number, no

Re: [PATCH v2 06/14] drm/msm/dpu: rework core_perf debugfs overrides

On 7/4/2023 8:03 AM, Dmitry Baryshkov wrote: Currently debugfs provides separate 'modes' to override calculated MDP_CLK rate and interconnect bandwidth votes. Change that to allow overriding individual values (e.g. one can override just clock or just average bandwidth vote). Signed-off-by: Dm

Re: [PATCH] backlight: led_bl: fix initial power state

On Tue, Jul 04, 2023 at 04:31:51PM +0100, Måns Rullgård wrote: > Daniel Thompson writes: > > > On Tue, Jul 04, 2023 at 03:07:50PM +0100, Mans Rullgard wrote: > >> The condition for the initial power state based on the default > >> brightness value is reversed. Fix it. > >> > >> Fixes: ae232e45acf

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

On Tue, Jul 4, 2023, at 16:51, Christian König wrote: > Am 04.07.23 um 16:31 schrieb Arnd Bergmann: >> On Tue, Jul 4, 2023, at 14:33, Christian König wrote: >>> >>> Modern AMD GPUs have 16GiB of local memory (VRAM), making those >>> accessible to a CPU which can only handle 32bit addresses by resiz

Re: [PATCH v3 02/17] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

Hi Linus, On Fri, 2023-06-16 at 14:48 +0200, Linus Walleij wrote: > Hi Sarah, > > thanks for your patch! > > On Tue, Jun 13, 2023 at 5:20 PM Sarah Walker wrote: > > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > Signed-off-by: Sarah Walker

[PATCH v2 13/14] drm/msm/dpu: move max clock decision to dpu_kms.

dpu_core_perf should not make decisions on the maximum possible core clock rate. Pass the value from dpu_kms_hw_init(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 11 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 8 ++-- drivers/gpu/drm

[PATCH v2 10/14] drm/msm/dpu: use dpu_perf_cfg in DPU core_perf code

Simplify dpu_core_perf code by using only dpu_perf_cfg instead of using full-featured catalog data. Acked-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 58 +++ drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 8 +-- drivers

[PATCH v2 14/14] drm/msm/dpu: drop dpu_core_perf_destroy()

This function does nothing, just clears several data pointers. Drop it now. Acked-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 10 -- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -- drivers/gpu/drm/msm/disp/dpu1/dpu_kms

[PATCH v2 12/14] drm/msm/dpu: core_perf: remove extra clk_round_rate() call

The dev_pm_opp_set_rate() already contains a call for clk_round_rate for the passed value. Stop calling it manually from _dpu_core_perf_get_core_clk_rate(). It is slightly incorrect to call it this way, as we should round the final calculated clock rate rather than rounding all the intermediate val

[PATCH v2 09/14] drm/msm/dpu: drop the dpu_core_perf_crtc_update()'s stop_req param

The stop_req is true only in the dpu_crtc_disable() case, when crtc->enable has already been set to false. This renders the stop_req argument useless. Remove it completely. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 12 ++--

[PATCH v2 11/14] drm/msm/dpu: remove unused fields from struct dpu_core_perf

Remove dpu_core_perf::dev and dpu_core_perf::debugfs_root fields, they are not used by the code. Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 3 --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 6 -- drivers/gpu/drm/msm/di

[PATCH v2 07/14] drm/msm/dpu: drop dpu_core_perf_params::max_per_pipe_ib

The max_per_pipe_ib is a constant across all CRTCs and is read from the catalog. Drop corresponding calculations and read the value directly at icc_set_bw() time. Suggested-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +

[PATCH v2 08/14] drm/msm/dpu: rework indentation in dpu_core_perf

dpu_core_perf.c contains several multi-line conditions which are hard to comprehent because of the indentation. Rework the identation of these conditions to make it easier to understand them. Reviewed-by: Abhinav Kumar Acked-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm

[PATCH v2 04/14] drm/msm/dpu: drop separate dpu_core_perf_tune overrides

The values in struct dpu_core_perf_tune are fixed per the core perf mode. Drop the 'tune' values and substitute them with known values when performing perf management. Note: min_bus_vote was not used at all, so it is just silently dropped. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm

[PATCH v2 06/14] drm/msm/dpu: rework core_perf debugfs overrides

Currently debugfs provides separate 'modes' to override calculated MDP_CLK rate and interconnect bandwidth votes. Change that to allow overriding individual values (e.g. one can override just clock or just average bandwidth vote). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1

[PATCH v2 02/14] drm/msm/dpu: core_perf: extract bandwidth aggregation function

In preparation to refactoring the dpu_core_perf debugfs interface, extract the bandwidth aggregation function from _dpu_core_perf_crtc_update_bus(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 39 +++ 1 file changed, 22 insertions(+), 17 de

[PATCH v2 05/14] drm/msm/dpu: handle perf mode in _dpu_core_perf_crtc_update_bus()

Move perf mode handling for the bandwidth to _dpu_core_perf_crtc_update_bus() rather than overriding per-CRTC data and then aggregating known values. Note, this changes the fix_core_ab_vote. Previously it would be multiplied per the CRTC number, now it will be used directly for interconnect voting

[PATCH v2 03/14] drm/msm/dpu: core_perf: bail earlier if there are no ICC paths

Skip bandwidth aggregation and return early if there are no interconnect paths defined for the DPU device. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_c

[PATCH v2 01/14] drm/msm/dpu: drop enum dpu_core_perf_data_bus_id

Drop the leftover of bus-client -> interconnect conversion, the enum dpu_core_perf_data_bus_id. Fixes: cb88482e2570 ("drm/msm/dpu: clean up references of DPU custom bus scaling") Reviewed-by: Konrad Dybcio Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp

[PATCH v2 00/14] drm/msm/dpu: cleanup dpu_core_perf module

Apply several cleanups to the DPU's core_perf module. Changes since v1: - Reworked overrides for the perf parameters instead of completely dropping them. Abhinav described why these overrides are useful. - Moved max clock rate determination to dpu_kms.c Dmitry Baryshkov (14): drm/msm/dpu: dro

Re: [PATCH] backlight: led_bl: fix initial power state

On Tue, Jul 04, 2023 at 03:07:50PM +0100, Mans Rullgard wrote: > The condition for the initial power state based on the default > brightness value is reversed. Fix it. > > Fixes: ae232e45acf9 ("backlight: add led-backlight driver") > Signed-off-by: Mans Rullgard > --- > drivers/video/backlight/l

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

On Fri, 23 Jun 2023, Jocelyn Falempe wrote: > Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no > EDID on DP") > The default resolution is now 640x480 when no monitor is connected. > But Aspeed graphics is mostly used in servers, where no monitor > is attached. This also affe

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

Am 04.07.23 um 16:31 schrieb Arnd Bergmann: On Tue, Jul 4, 2023, at 14:33, Christian König wrote: Am 04.07.23 um 14:24 schrieb Arnd Bergmann: On Tue, Jul 4, 2023, at 08:54, Christian König wrote: Am 03.07.23 um 14:35 schrieb Arnd Bergmann: Not sure I understand the specific requirement. Do yo

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

On Tue, Jul 4, 2023, at 14:33, Christian König wrote: > Am 04.07.23 um 14:24 schrieb Arnd Bergmann: >> On Tue, Jul 4, 2023, at 08:54, Christian König wrote: >>> Am 03.07.23 um 14:35 schrieb Arnd Bergmann: >> Not sure I understand the specific requirement. Do you mean the entire >> amdgpu driver req

Re: [PATCH 7/8] drm/msm/dpu: drop dpu_core_perf_destroy()

On Tue, 4 Jul 2023 at 03:19, Abhinav Kumar wrote: > > > > On 7/3/2023 3:59 PM, Dmitry Baryshkov wrote: > > On Tue, 4 Jul 2023 at 01:57, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote: > >>> This function does nothing, just clears several data pointers.

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

(cc: some people from commit fae7d186403e) Am 04.07.23 um 16:19 schrieb Thomas Zimmermann: Hi Jocelyn Am 23.06.23 um 11:46 schrieb Jocelyn Falempe: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no   EDID on DP") The default resolution is now 640x480 when no monitor is con

Re: [PATCH] drm/ast: Fix default resolution when no monitor is connected on DP

Hi Jocelyn Am 23.06.23 um 11:46 schrieb Jocelyn Falempe: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP") The default resolution is now 640x480 when no monitor is connected. But Aspeed graphics is mostly used in servers, where no monitor is attached. This als

Re: [PATCH] drm/arm/komeda: Remove component framework and add a simple encoder

Hi Liviu, On 6/29/2023 3:21 PM, Liviu Dudau wrote: > Hi Faiz, > > Thanks for the patch and for addressing what was at some moment on my "nice to > improve / cleanup" list. Sorry for the delay in responding, I had to revive > the bits of an old setup to be able to test this properly, with 2 encoder

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On Sun, 2 Jul 2023 at 21:23, Krzysztof Kozlowski wrote: > > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Rob, > > Maybe this could go via your tree? Rebased on your for-next: > v6.4-rc2-45-gf0ac35049606 > --- > .../bindings/arm/arm,

Re: [PATCH V5 1/9] drivers core: Add support for Wifi band RF mitigations

> > What is the purpose of this stage? Why would it not be supported for this > > device? > This is needed for wbrf support via ACPI mechanism. If BIOS(AML code) does > not support the wbrf adding/removing for some device, > it should speak that out so that the device can be aware of that. How mu

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On 02/07/2023 20:23, Krzysztof Kozlowski wrote: The DTS code coding style expects spaces around '=' sign. Signed-off-by: Krzysztof Kozlowski --- Rob, Maybe this could go via your tree? Rebased on your for-next: v6.4-rc2-45-gf0ac35049606 --- [...] .../bindings/net/mediatek-dwmac.yaml

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

Am 04.07.23 um 14:24 schrieb Arnd Bergmann: On Tue, Jul 4, 2023, at 08:54, Christian König wrote: Am 03.07.23 um 14:35 schrieb Arnd Bergmann: From: Arnd Bergmann On 32-bit architectures comparing a resource against a value larger than U32_MAX can cause a warning: drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH] drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()

On Tue, Jul 4, 2023, at 08:54, Christian König wrote: > Am 03.07.23 um 14:35 schrieb Arnd Bergmann: >> From: Arnd Bergmann >> >> On 32-bit architectures comparing a resource against a value larger than >> U32_MAX can cause a warning: >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1344:18: error:

  1   2   >