[PATCH] drm/amd/display: clean up some inconsistent indenting

2023-06-01 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_dpms.c:2377 link_set_dpms_on() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5376 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/displa

[PATCH] drm/amdgpu: clean up some inconsistent indenting

2023-06-01 Thread Jiapeng Chong
No functional modification involved. drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:614 amdgpu_gfx_enable_kcq() warn: inconsistent indenting. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5377 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c

[git pull] drm fixes for 6.4-rc5

2023-06-01 Thread Dave Airlie
Hi Linus, Quiet enough week, though the misc fixes tree didn't get to me when I was sending this, so maybe it'll be a bit bigger next week, just one i915 fix and some scattered amdgpu fixes. Dave. drm-fixes-2023-06-02: drm fixes for v6.4-rc5 amdgpu: - Fix mclk and fclk output ordering on some A

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration

2023-06-01 Thread Ying Liu
On Fri, Jun 2, 2023 at 1:45 AM Krzysztof Kozlowski wrote: > > On 31/05/2023 11:32, Liu Ying wrote: > > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > > field. Add device tree bindings for the display

[PATCH] dim: Disallow remote branch deletions with 'dim push'

2023-06-01 Thread Ashutosh Dixit
An inadvertent 'dim push -d' can delete remote branches. Disallow such remote branch deletions. Signed-off-by: Ashutosh Dixit --- dim | 6 ++ 1 file changed, 6 insertions(+) diff --git a/dim b/dim index 126568e..e5899e6 100755 --- a/dim +++ b/dim @@ -1029,6 +1029,12 @@ function dim_push_bra

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-06-01 Thread Leonard Lausen
Hi Abhinav, June 1, 2023 at 3:20 PM, "Abhinav Kumar" wrote: > > > > [drm:drm_mode_config_helper_resume] *ERROR* Failed to resume (-107) > > > > We are not able to recreate this on sc7280 chromebooks , will need to check > on sc7180. This does not seem directly related to any of the hotplug c

[Bug 90091] Computer freeze

2023-06-01 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=90091 --- Comment #5 from Marc Collin (marc.col...@protonmail.com) --- i don't have this computer anymore -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

RE: [PATCH] drm/exynos: fix race condition UAF in exynos_g2d_exec_ioctl

2023-06-01 Thread SR
Andi~ :) > -Original Message- > From: Andi Shyti > Sent: Thursday, June 1, 2023 5:29 PM > To: 대인기/Tizen Platform Lab(SR)/삼성전자 > Cc: 'lm0963' ; sw0312@samsung.com; > kyungmin.p...@samsung.com; airl...@gmail.com; dan...@ffwll.ch; > krzysztof.kozlow...@linaro.org; alim.akh...@samsung.co

Re: [PATCH 0/2] drm/i915/gt: Fix recent kCFI violations

2023-06-01 Thread Andi Shyti
Hi Nathan, On Tue, May 30, 2023 at 11:24:37AM -0700, Nathan Chancellor wrote: > Hi all, > > This series fixes a few clang kernel Control Flow Integrity (kCFI) > violations that appear after commit 9275277d5324 ("drm/i915: use > pat_index instead of cache_level"). They were found between run time

Re: [Intel-gfx] [PATCH] drm/i915/pxp: use correct format string for size_t

2023-06-01 Thread Andi Shyti
Hi Arnd, On Thu, Jun 01, 2023 at 10:00:27PM +, Teres Alexis, Alan Previn wrote: > On Thu, 2023-06-01 at 23:36 +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > While 'unsigned long' needs the %ld format string, size_t needs the %z > > modifier: > > alan:snip > > > > +++ b/driver

Re: [PATCH v5 5/7] drm/i915/mtl/huc: auth HuC via GSC

2023-06-01 Thread Teres Alexis, Alan Previn
On Wed, 2023-05-31 at 16:54 -0700, Ceraolo Spurio, Daniele wrote: > The full authentication via the GSC requires an heci packet submission > to the GSC FW via the GSC CS. The GSC has new PXP command for this > (literally called NEW_HUC_AUTH). > The intel_huc_auth function is also updated to handle

[PATCH v3] amdgpu: validate offset_in_bo of drm_amdgpu_gem_va

2023-06-01 Thread Chia-I Wu
This is motivated by OOB access in amdgpu_vm_update_range when offset_in_bo+map_size overflows. v2: keep the validations in amdgpu_vm_bo_map v3: add the validations to amdgpu_vm_bo_map/amdgpu_vm_bo_replace_map rather than to amdgpu_gem_va_ioctl Fixes: 9f7eb5367d00 ("drm/amdgpu: actually use t

Re: [PATCH v2 1/2] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-06-01 Thread Dmitry Baryshkov
On 02/06/2023 01:08, Kuogee Hsieh wrote: At current implementation, DSI DSC struct is populated at display setup during system bootup. This mechanism works fine with embedded display. But will run into problem with plugin/unplug oriented external display, such as DP, due to DSC struct will become

[PATCH net-next v6 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers

2023-06-01 Thread Justin Chen
Add maintainers entry for ASP 2.0 Ethernet driver. Reviewed-by: Simon Horman Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- v3 - Change from gmail to broadcom emails MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS inde

[PATCH net-next v6 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165

2023-06-01 Thread Justin Chen
From: Florian Fainelli 74165 is a 16nm process SoC with a 10/100 integrated Ethernet PHY, utilize the recently defined 16nm EPHY macro to configure that PHY. Reviewed-by: Simon Horman Reviewed-by: Andrew Lunn Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- drivers/net/phy/bcm

[PATCH net-next v6 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support

2023-06-01 Thread Justin Chen
Add mdio compat string for ASP 2.0 ethernet driver. Reviewed-by: Simon Horman Reviewed-by: Andrew Lunn Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- drivers/net/mdio/mdio-bcm-unimac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/

[PATCH net-next v6 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-06-01 Thread Justin Chen
Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. This controller features two distinct Ethernet ports that can be independently operated. This patch supports: - Wake-on-LAN using magic packets - basic ethtool operations (link, counters, message level)

[PATCH net-next v6 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-06-01 Thread Justin Chen
From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Reviewed-by: Conor Dooley Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- v6 - Moved compatible to the top - Changed quotes to be consistent - Elaborated on brcm,

[PATCH net-next v6 1/6] dt-bindings: net: brcm, unimac-mdio: Add asp-v2.0

2023-06-01 Thread Justin Chen
The ASP 2.0 Ethernet controller uses a brcm unimac. Reviewed-by: Simon Horman Acked-by: Conor Dooley Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/d

[PATCH net-next v6 0/6] Brcm ASP 2.0 Ethernet Controller

2023-06-01 Thread Justin Chen
Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. Florian Fainelli (2): dt-bindings: net: Brcm ASP 2.0 Ethernet controller net: phy: bcm7xxx: Add EPHY entry for 74165 Justin Chen (4): dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0 net: bcmasp

Re: [PATCH v2 0/2] retrieve DSI DSC through DRM bridge

2023-06-01 Thread Dmitry Baryshkov
On 02/06/2023 01:08, Kuogee Hsieh wrote: move retrieving DSC from setup_display to atomic_check() and delete struct drm_dsc_config from struct msm_display_info. This is obvious from the patches themselves. You should be describing _why_ the changes are necessary, not what is changed. What

[PATCH v2 2/2] drm/msm/dpu: remove struct drm_dsc_config from struct msm_display_info

2023-06-01 Thread Kuogee Hsieh
Since struct drm_dsc_config is retrieved at atomic_check() instead of at display setup time during bootup. Saving struct drm_dsc_config at struct msm_display_info is not necessary and become redundant. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 -- drivers/gp

[PATCH v2 0/2] retrieve DSI DSC through DRM bridge

2023-06-01 Thread Kuogee Hsieh
move retrieving DSC from setup_display to atomic_check() and delete struct drm_dsc_config from struct msm_display_info. Kuogee Hsieh (2): drm/msm/dpu: retrieve DSI DSC struct at atomic_check() drm/msm/dpu: remove struct drm_dsc_config from struct msm_display_info drivers/gpu/drm/msm/disp/dp

[PATCH v2 1/2] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-06-01 Thread Kuogee Hsieh
At current implementation, DSI DSC struct is populated at display setup during system bootup. This mechanism works fine with embedded display. But will run into problem with plugin/unplug oriented external display, such as DP, due to DSC struct will become stale once external display unplugged. New

Re: [GIT PULL] fbdev fixes for v6.4-rc5

2023-06-01 Thread pr-tracker-bot
The pull request you sent on Thu, 1 Jun 2023 21:28:24 +0200: > http://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git > tags/fbdev-for-6.4-rc5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9e87b63ed37e202c77aa17d4112da6ae0c7c097c Thank you! -- Deet-

Re: [Intel-gfx] [PATCH] drm/i915/pxp: use correct format string for size_t

2023-06-01 Thread Teres Alexis, Alan Previn
On Thu, 2023-06-01 at 23:36 +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > While 'unsigned long' needs the %ld format string, size_t needs the %z > modifier: alan:snip > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c > @@ -143,7 +143,7 @@ gsccs_send_message(struct intel_pxp *pxp, >

How to fetch the implicit sync fence for a GPU buffer?

2023-06-01 Thread Hoosier, Matt
Hi, In the past there has been writing about Wayland's model using implicit synchronization of GPU renderbuffers and KMS commits [1] [2]. It would sometimes be nice to do that waiting explicitly in a compositor before enqueueing a KMS pageflip that references a buffer who may go on rendering fo

[PATCH] drm/amdgpu: fix xclk freq on CHIP_STONEY

2023-06-01 Thread Chia-I Wu
According to Alex, most APUs from that time seem to have the same issue (vbios says 48Mhz, actual is 100Mhz). I only have a CHIP_STONEY so I limit the fixup to CHIP_STONEY --- drivers/gpu/drm/amd/amdgpu/vi.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/g

[PATCH] drm/i915/pxp: use correct format string for size_t

2023-06-01 Thread Arnd Bergmann
From: Arnd Bergmann While 'unsigned long' needs the %ld format string, size_t needs the %z modifier: drivers/gpu/drm/i915/pxp/intel_pxp_gsccs.c: In function 'gsccs_send_message': include/drm/drm_print.h:456:39: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'si

Re: [PATCH v5 3/7] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-06-01 Thread John Harrison
On 5/31/2023 16:54, Daniele Ceraolo Spurio wrote: In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the HuC via DMA if the fuse is set that way. Note that we now need to differentiate between "GSC-enabl

Re: [PATCH v5 4/7] drm/i915/huc: differentiate the 2 steps of the MTL HuC auth flow

2023-06-01 Thread John Harrison
On 5/31/2023 16:54, Daniele Ceraolo Spurio wrote: Before we add the second step of the MTL HuC auth (via GSC), we need to have the ability to differentiate between them. To do so, the huc authentication check is duplicated for GuC and GSC auth, with GSC-enabled binaries being considered fully aut

Re: [PATCH v5 3/7] drm/i915/huc: Load GSC-enabled HuC via DMA xfer if the fuse says so

2023-06-01 Thread John Harrison
On 5/31/2023 16:54, Daniele Ceraolo Spurio wrote: In the previous patch we extracted the offset of the legacy-style HuC binary located within the GSC-enabled blob, so now we can use that to load the HuC via DMA if the fuse is set that way. Note that we now need to differentiate between "GSC-enabl

Re: [PATCH v5 2/7] drm/i915/huc: Parse the GSC-enabled HuC binary

2023-06-01 Thread John Harrison
On 5/31/2023 16:54, Daniele Ceraolo Spurio wrote: The new binaries that support the 2-step authentication contain the legacy-style binary, which we can use for loading the HuC via DMA. To find out where this is located in the image, we need to parse the manifest of the GSC-enabled HuC binary. The

Re: [PATCH 21/36] drm/amd/display: add CRTC 3D LUT support

2023-06-01 Thread Harry Wentland
On 5/23/23 18:15, Melissa Wen wrote: > Wire up DC 3D LUT to DM CRTC color management (post-blending). On AMD > display HW, we have to set a shaper LUT to delinearize or normalize the > color space before applying a 3D LUT (since we have a reduced number of > LUT entries). Therefore, we map DC sh

Re: [PATCH -next] drm/amdkfd: clean up one inconsistent indenting

2023-06-01 Thread Felix Kuehling
On 2023-05-30 22:08, Yang Li wrote: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_device.c:1036 kgd2kfd_interrupt() warn: inconsistent indenting Signed-off-by: Yang Li Reviewed-by: Felix Kuehling I'm applying the patch to amd-staging-drm-next. Thanks! --- drivers/gpu/drm/amd/amdkfd/kfd_dev

Re: [PATCH v3 7/7] drm/msm/dpu: simplify dpu_encoder_phys_wb_init()

2023-06-01 Thread Abhinav Kumar
On 6/1/2023 10:22 AM, Dmitry Baryshkov wrote: There is no need to assign a result to temp varable just to return it after a goto. Drop the temporary variable and goto and return the result directly. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Tested-by: Abhinav Kumar #

Re: [PATCH v3 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init()

2023-06-01 Thread Abhinav Kumar
On 6/1/2023 10:22 AM, Dmitry Baryshkov wrote: There is no need to assign a result to temp varable just to return it two lines below. Drop the temporary variable. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Tested-by: Abhinav Kumar # sc7280

Re: [PATCH v3 5/7] drm/msm/dpu: call dpu_rm_get_intf() from dpu_encoder_get_intf()

2023-06-01 Thread Abhinav Kumar
On 6/1/2023 10:22 AM, Dmitry Baryshkov wrote: There is little sense to get intf index just to call dpu_rm_get_intf() on it. Move dpu_rm_get_intf() call to dpu_encoder_get_intf() function. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Tested-by: Abhinav Kumar # sc7280

Re: [PATCH v3 4/7] drm/msm/dpu: inline dpu_encoder_get_wb()

2023-06-01 Thread Abhinav Kumar
On 6/1/2023 10:22 AM, Dmitry Baryshkov wrote: The function dpu_encoder_get_wb() returns controller_id if the corresponding WB is present in the catalog. We can inline this function and rely on dpu_rm_get_wb() returning NULL for indices for which the WB is not present on the device. Reviewed-b

Re: [PATCH v3 3/7] drm/msm/dpu: drop duplicated intf/wb indices from encoder structs

2023-06-01 Thread Abhinav Kumar
On 6/1/2023 10:22 AM, Dmitry Baryshkov wrote: Remove intf_idx and wb_idx fields from struct dpu_encoder_phys and struct dpu_enc_phys_init_params. Set the hw_intf and hw_wb directly and use them to get the instance index. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Teste

Re: [Freedreno] [PATCH v3 2/7] drm/msm/dpu: separate common function to init physical encoder

2023-06-01 Thread Abhinav Kumar
On 6/1/2023 10:22 AM, Dmitry Baryshkov wrote: Move common DPU physical encoder initialization code to the new function dpu_encoder_phys_init(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Tested-by: Abhinav Kumar # sc7280

Re: [PATCH 09/36] drm/amd/display: add plane HDR multiplier driver-specific property

2023-06-01 Thread Harry Wentland
On 5/23/23 18:14, Melissa Wen wrote: > From: Joshua Ashton > > Multiplier to 'gain' the plane. When PQ is decoded using the fixed func > transfer function to the internal FP16 fb, 1.0 -> 80 nits (on AMD at > least) When sRGB is decoded, 1.0 -> 1.0. Therefore, 1.0 multiplier = 80 > nits for SD

Re: [PATCH 5/6] drm/panel: simple: add support for Rocktech RK043FN48H panel

2023-06-01 Thread kernel test robot
Hi Dario, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-intel/for-linux-next-fixes] [also build test WARNING on drm-tip/drm-tip linus/master v6.4-rc4 next-20230601] [cannot apply to atorgue-stm32/stm32-next drm-misc/drm-misc-next drm-intel/for-linux

Re: [PATCH v3 1/7] drm/msm/dpu: merge dpu_encoder_init() and dpu_encoder_setup()

2023-06-01 Thread Abhinav Kumar
On 6/1/2023 10:22 AM, Dmitry Baryshkov wrote: There is no reason to split the dpu_encoder interface into separate _init() and _setup() phases. Merge them into a single function. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Tested-by: Abhinav Kumar # sc7280

[GIT PULL] fbdev fixes for v6.4-rc5

2023-06-01 Thread Helge Deller
Hi Linus, please pull some fbdev fixes & cleanups for kernel 6.4-rc5. Most noteably is a fix for a null-ptr-deref in fbcon's soft_cursor function which was found by syzbot. Thanks! Helge -- The following changes since commit 44c026a73be8038f03dbdeef028b642880cf1511: Linux 6.4-rc3

Re: [PATCH 07/36] drm/amd/display: add plane driver-specific properties for degamma LUT

2023-06-01 Thread Harry Wentland
On 5/23/23 18:14, Melissa Wen wrote: > Create and attach driver-private properties for plane color management. > First add plane degamma LUT properties that means user-blob and its > size. We will add more plane color properties in the next commits. In > addition, we keep these driver-private pl

Re: [Freedreno] [PATCH] Revert "drm/msm/dp: Remove INIT_SETUP delay"

2023-06-01 Thread Abhinav Kumar
Hi Leonard On 5/24/2023 5:58 AM, Leonard Lausen wrote: [  275.025497] [drm:dpu_encoder_phys_vid_wait_for_commit_done:488] [dpu error]vblank timeout [  275.025514] [drm:dpu_kms_wait_for_commit_done:510] [dpu error]wait for commit done returned -110 [  275.064141] [drm:dpu_encoder_frame_done_timeo

Re: [PATCH 06/36] drm/amd/display: add CRTC driver-specific property for gamma TF

2023-06-01 Thread Harry Wentland
On 5/23/23 18:14, Melissa Wen wrote: > Hook up driver-specific atomic operations for managing AMD color > properties and create AMD driver-specific color management properties > and attach them according to HW capabilities defined by `struct > dc_color_caps`. Add enumerated transfer function pro

Re: [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-06-01 Thread Akhil P Oommen
On Tue, May 30, 2023 at 08:35:14AM -0700, Bjorn Andersson wrote: > > On Mon, May 29, 2023 at 02:16:14PM +0530, Manivannan Sadhasivam wrote: > > On Mon, May 29, 2023 at 09:38:59AM +0200, Konrad Dybcio wrote: > > > On 28.05.2023 19:07, Manivannan Sadhasivam wrote: > > > > On Tue, May 23, 2023 at 09:

Re: [PATCH v2 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-06-01 Thread Akhil P Oommen
On Mon, May 29, 2023 at 09:38:59AM +0200, Konrad Dybcio wrote: > > > > On 28.05.2023 19:07, Manivannan Sadhasivam wrote: > > On Tue, May 23, 2023 at 09:59:53AM +0200, Konrad Dybcio wrote: > >> > >> > >> On 23.05.2023 03:15, Bjorn Andersson wrote: > >>> From: Bjorn Andersson > >>> > >>> Add Adre

Re: [PATCH v3 1/3] drm/msm/adreno: Add Adreno A690 support

2023-06-01 Thread Akhil P Oommen
On Wed, May 31, 2023 at 10:30:09PM +0200, Konrad Dybcio wrote: > > > > On 31.05.2023 05:09, Bjorn Andersson wrote: > > From: Bjorn Andersson > > > > Introduce support for the Adreno A690, found in Qualcomm SC8280XP. > > > > Tested-by: Steev Klimaszewski > > Reviewed-by: Konrad Dybcio > > Si

Re: [PATCH 4/6] dt-bindings: display: simple: add Rocktech RK043FN48H

2023-06-01 Thread Conor Dooley
On Thu, Jun 01, 2023 at 07:03:18PM +0200, Dario Binacchi wrote: > Add compatible to panel-simple for Rocktech Displays Limited > RK043FN48H 4.3" 480x272 LCD-TFT panel. > > Signed-off-by: Dario Binacchi > --- > > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file ch

[PATCH] drm/i915/pxp: Optimize GET_PARAM:PXP_STATUS

2023-06-01 Thread Alan Previn
After recent discussions with Mesa folks, it was requested that we optimize i915's GET_PARAM for the PXP_STATUS without changing the UAPI spec. This patch adds this additional optimizations: - If any PXP initializatoin flow failed, then ensure that we catch it so that we can change the ret

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add NXP i.MX93 parallel display format configuration

2023-06-01 Thread Krzysztof Kozlowski
On 31/05/2023 11:32, Liu Ying wrote: > NXP i.MX93 mediamix blk-ctrl contains one DISPLAY_MUX register which > configures parallel display format by using the "PARALLEL_DISP_FORMAT" > field. Add device tree bindings for the display format configuration. > > Signed-off-by: Liu Ying > --- > v1->v2:

[linux-next:master] BUILD REGRESSION 571d71e886a5edc89b4ea6d0fe6f445282938320

2023-06-01 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 571d71e886a5edc89b4ea6d0fe6f445282938320 Add linux-next specific files for 20230601 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202305230552.wobyqyya-...@intel.com https

[PATCH v3 6/7] drm/msm/dpu: drop temp variable from dpu_encoder_phys_cmd_init()

2023-06-01 Thread Dmitry Baryshkov
There is no need to assign a result to temp varable just to return it two lines below. Drop the temporary variable. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH v3 7/7] drm/msm/dpu: simplify dpu_encoder_phys_wb_init()

2023-06-01 Thread Dmitry Baryshkov
There is no need to assign a result to temp varable just to return it after a goto. Drop the temporary variable and goto and return the result directly. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 10 ++ 1 file cha

[PATCH v3 5/7] drm/msm/dpu: call dpu_rm_get_intf() from dpu_encoder_get_intf()

2023-06-01 Thread Dmitry Baryshkov
There is little sense to get intf index just to call dpu_rm_get_intf() on it. Move dpu_rm_get_intf() call to dpu_encoder_get_intf() function. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 20 1 file changed, 8 i

[PATCH v3 3/7] drm/msm/dpu: drop duplicated intf/wb indices from encoder structs

2023-06-01 Thread Dmitry Baryshkov
Remove intf_idx and wb_idx fields from struct dpu_encoder_phys and struct dpu_enc_phys_init_params. Set the hw_intf and hw_wb directly and use them to get the instance index. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 72 ++

[PATCH v3 4/7] drm/msm/dpu: inline dpu_encoder_get_wb()

2023-06-01 Thread Dmitry Baryshkov
The function dpu_encoder_get_wb() returns controller_id if the corresponding WB is present in the catalog. We can inline this function and rely on dpu_rm_get_wb() returning NULL for indices for which the WB is not present on the device. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov

[PATCH v3 1/7] drm/msm/dpu: merge dpu_encoder_init() and dpu_encoder_setup()

2023-06-01 Thread Dmitry Baryshkov
There is no reason to split the dpu_encoder interface into separate _init() and _setup() phases. Merge them into a single function. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 55 + drivers/gpu/drm/msm/disp/dpu1/dpu_en

[PATCH v3 2/7] drm/msm/dpu: separate common function to init physical encoder

2023-06-01 Thread Dmitry Baryshkov
Move common DPU physical encoder initialization code to the new function dpu_encoder_phys_init(). Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 29 +-- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 3 ++ .../drm

[PATCH v3 0/7] drm/msm/dpu: simplify DPU encoder init

2023-06-01 Thread Dmitry Baryshkov
Rework dpu_encoder initialization code, simplifying calling sequences and separating common init parts. Changes since v2: - Rebased on top of msm-next-lumag branch Changes since v1: - Withdrawn two pathes for a later consideration - Changed dpu_encoder_phys_init() to return void (Abhinav) - Added

Re: [Intel-gfx] [PATCH v8 0/7] drm/i915: use ref_tracker library for tracking wakerefs

2023-06-01 Thread Jakub Kicinski
On Thu, 1 Jun 2023 19:14:50 +0200 Andrzej Hajda wrote: > Ping on the series, everything reviewed. > Eric, Dave, Jakub, could you take patches 1-4 via net tree? Sure thing, would you mind reposting them separately? Easier for us to apply and it's been over a month since posting, a fresh run of buil

[PATCH v4 2/2] drm/mediatek: Add DSI support for mt8188 vdosys0

2023-06-01 Thread Jason-JH . Lin
Add DSI as main display output for mt8188 vdosys0. Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin Reviewed-by: Matthias Brugger --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +

[PATCH v4 0/2] Add dynamic connector selection mechanism

2023-06-01 Thread Jason-JH . Lin
To support DSI and eDP as main display connector without modifying mtk-drm driver, we add the dynamic connector selection mechanism. Change in v4: 1. Change variable naming of connector routes number from conn_route_num to num_conn_routes. 2. Chnage he encoder_index function return valuew from in

[PATCH v4 1/2] drm/mediatek: Add ability to support dynamic connector selection

2023-06-01 Thread Jason-JH . Lin
1. Move output drm connector from each ddp_path array to connector array. 2. Add dynamic select available connector flow in crtc create and enable. Signed-off-by: Nancy Lin Signed-off-by: Nathan Lu Signed-off-by: Jason-JH.Lin --- drivers/gpu/drm/mediatek/mtk_disp_drv.h | 1 + drivers/gpu

Re: [Intel-gfx] [PATCH v8 0/7] drm/i915: use ref_tracker library for tracking wakerefs

2023-06-01 Thread Andrzej Hajda
On 08.05.2023 19:16, Andrzej Hajda wrote: On 05.05.2023 22:06, Rodrigo Vivi wrote: On Thu, May 04, 2023 at 06:27:53PM +0200, Andrzej Hajda wrote: Hi maintainers of net and i915, On 25.04.2023 00:05, Andrzej Hajda wrote: This is revived patchset improving ref_tracker library and converting i

[PATCH v3 7/7] ARM: dts: qcom: msm8226: Add mdss nodes

2023-06-01 Thread Luca Weiss
Add the nodes that describe the mdss so that display can work on MSM8226. Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom-msm8226.dtsi | 127 1 file changed, 127 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8226.dtsi b/arch/arm/boot/dts/qcom-ms

[PATCH v3 0/7] Display support for MSM8226

2023-06-01 Thread Luca Weiss
This series adds the required configs for MDP5 and DSI blocks that are needed for MDSS on MSM8226. Finally we can add the new nodes into the dts. Tested on apq8026-lg-lenok and msm8926-htc-memul. Signed-off-by: Luca Weiss --- Changes in v3: - Adjust mdss labels to new style (Stephan) - Link to v

[PATCH v3 1/7] dt-bindings: msm: dsi-phy-28nm: Document msm8226 compatible

2023-06-01 Thread Luca Weiss
The MSM8226 SoC uses a slightly different 28nm dsi phy. Add a new compatible for it. And while we're at it, in the dsi-phy-28nm.yaml move the 8960 compatible to its correct place so its sorted alphabetically. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devicetree/binding

[PATCH v3 4/7] drm/msm/mdp5: Add MDP5 configuration for MSM8226

2023-06-01 Thread Luca Weiss
Add the required config for the v1.1 MDP5 found on MSM8226. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 82 1 file changed, 82 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/driv

[PATCH v3 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-06-01 Thread Luca Weiss
MSM8226 uses a modified PLL lock sequence compared to MSM8974, which is based on the function dsi_pll_enable_seq_m in the msm-3.10 kernel. Worth noting that the msm-3.10 downstream kernel also will try other sequences in case this one doesn't work, but during testing it has shown that the _m seque

[PATCH v3 5/7] drm/msm/dsi: Add configuration for MSM8226

2023-06-01 Thread Luca Weiss
Add the config for the v1.0.2 DSI found on MSM8226. We can reuse existing bits from other revisions that are identical for v1.0.2. Reviewed-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio Signed-off-by: Luca Weiss --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h

[PATCH v3 2/7] dt-bindings: display/msm: dsi-controller-main: Add msm8226 compatible

2023-06-01 Thread Luca Weiss
Add the compatible for the DSI found on MSM8226. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.y

[PATCH v3 3/7] dt-bindings: display/msm: qcom,mdp5: Add msm8226 compatible

2023-06-01 Thread Luca Weiss
Add the compatible for the MDP5 found on MSM8226. Acked-by: Conor Dooley Signed-off-by: Luca Weiss --- Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml b/Documentation/d

Re: [PATCH v2] drm/msm/dpu: clean up dpu_kms_get_clk_rate() returns

2023-06-01 Thread Abhinav Kumar
On 5/26/2023 4:51 AM, Dan Carpenter wrote: Static analysis tools complain about the -EINVAL error code being stored in an unsigned variable. Let's change this to match the clk_get_rate() function which is type unsigned long and returns zero on error. Fixes: 25fdd5933e4c ("drm/msm: Add SDM845

Re: [Freedreno] [PATCH] drm/msm: Remove unnecessary (void*) conversions

2023-06-01 Thread Abhinav Kumar
On 5/21/2023 6:32 PM, Su Hui wrote: Pointer variables of (void*) type do not require type cast. Signed-off-by: Su Hui --- Reviewed-by: Abhinav Kumar

Re: [PATCH v5 11/13] drm/msm: Use regular fbdev I/O helpers

2023-06-01 Thread Abhinav Kumar
On 5/30/2023 8:02 AM, Thomas Zimmermann wrote: Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Msm does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can

Re: [PATCH] gpu: drm/panel: Optimize the workflow of s6d7aa0_lock

2023-06-01 Thread kernel test robot
Hi Lu, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on next-20230601] [cannot apply to linus/master v6.4-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

Re: DRM debugfs cleanup take 4

2023-06-01 Thread Oded Gabbay
On Wed, Apr 12, 2023 at 5:52 PM Christian König wrote: > > Hi guys, > > took me some tries to get the Intel CI happy with this patch set. > > This is the version rebased on drm-misc-next, for a CI run you actually > need to rebase the last patch to drm-tip. So I'm planning to merge 1-4 > for this

[PATCH] drm/i915/pxp/mtl: intel_pxp_init_hw needs runtime-pm inside pm-complete

2023-06-01 Thread Alan Previn
In the case of failed suspend flow or cases where the kernel does not go into full suspend but goes from suspend_prepare back to resume_complete, we get called for a pm_complete but without runtime_pm guaranteed. Thus, ensure we take the runtime_pm when calling intel_pxp_init_hw from within intel_

Re: [PATCH] accel/ivpu: Use struct_size()

2023-06-01 Thread Marco Pagani
On 2023-05-29 15:28, Christophe JAILLET wrote: > Use struct_size() instead of hand-writing it. It is less verbose, more > robust and more informative. > > Signed-off-by: Christophe JAILLET Reviewed-by: Marco Pagani > --- > drivers/accel/ivpu/ivpu_job.c | 4 +--- > 1 file changed, 1 insertio

Re: [v4 4/4] drm/panel: Support for Starry-ili9882t TDDI MIPI-DSI panel

2023-06-01 Thread Doug Anderson
Hi, On Thu, May 25, 2023 at 2:32 AM Cong Yang wrote: > > The Starry-ili9882 is a 10.51" WUXGA TFT panel. which fits in nicely with > the existing panel-boe-tv101wum-nl6 driver. From the datasheet,MIPI need > to keep the LP11 state before the lcm_reset pin is pulled high. So add > lp11_before_rese

Re: [v4 3/4] dt-bindings: display: panel: Add compatible for Starry ili9882t

2023-06-01 Thread Doug Anderson
Hi, On Thu, May 25, 2023 at 2:32 AM Cong Yang wrote: > > The STARRY ili9882t is a 10.51" WUXGA TFT LCD panel, > which fits in nicely with the existing panel-boe-tv101wum-nl6 > driver. Hence, we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang > Reviewed-by: Douglas A

Re: [v4 2/4] drm/panel: Support for Starry-himax83102-j02 TDDI MIPI-DSI panel

2023-06-01 Thread Doug Anderson
Hi, On Thu, May 25, 2023 at 2:32 AM Cong Yang wrote: > > The Starry-himax83102-j02 is a 10.51" WUXGA TFT panel. which fits in nicely > with the existing panel-boe-tv101wum-nl6 driver. From the datasheet[1], MIPI > needs to keep the LP11 state before the lcm_reset pin is pulled high, so > increase

Re: [v4 1/4] dt-bindings: display: panel: Add compatible for Starry himax83102-j02

2023-06-01 Thread Doug Anderson
Hi, On Thu, May 25, 2023 at 2:32 AM Cong Yang wrote: > > The STARRY himax83102-j02 is a 10.51" WUXGA TFT LCD panel, > which fits in nicely with the existing panel-boe-tv101wum-nl6 > driver. Hence, we add a new compatible with panel specific config. > > Signed-off-by: Cong Yang > Reviewed-by: Dou

Re: [v4 0/4] Support Starry-himax83102-j02 and Starry-ili9882t TDDI MIPI-DSI panel

2023-06-01 Thread Doug Anderson
Hi, On Thu, May 25, 2023 at 2:32 AM Cong Yang wrote: > > Copare V3:Resend without Conor's acks on patches 2 and 4. > > Cong Yang (4): > dt-bindings: display: panel: Add compatible for Starry himax83102-j02 > drm/panel: Support for Starry-himax83102-j02 TDDI MIPI-DSI panel > dt-bindings: dis

Re: [PATCH v5 08/12] drm/msm/dpu: Add SM6375 support

2023-06-01 Thread Marijn Suijten
On 2023-05-23 09:46:19, Konrad Dybcio wrote: > Add basic SM6375 support to the DPU1 driver to enable display output. Nit: The SM6350 commit doesn't use the word "basic" here: what does it mean? Is this addition not complete (because it seems so)? > Reviewed-by: Dmitry Baryshkov > Signed-off-by:

Re: [PATCH v3 1/2] drm/mediatek: Add ability to support dynamic connector selection

2023-06-01 Thread 林睿祥

Re: [PATCH] gpu: drm/panel: Optimize the workflow of s6d7aa0_lock

2023-06-01 Thread kernel test robot
Hi Lu, kernel test robot noticed the following build errors: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on next-20230601] [cannot apply to linus/master v6.4-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

RE: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails

2023-06-01 Thread Upadhyay, Tejas
> -Original Message- > From: Intel-gfx On Behalf Of > Andrzej Hajda > Sent: Thursday, June 1, 2023 6:14 PM > To: Andi Shyti ; Intel GFX g...@lists.freedesktop.org>; DRI Devel > Cc: Chris Wilson ; sta...@vger.kernel.org; Dan > Carpenter ; Andi Shyti > Subject: Re: [Intel-gfx] [PATCH] d

Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails

2023-06-01 Thread Andi Shyti
Hi Tejas, > > > @@ -1530,8 +1530,8 @@ static int live_busywait_preempt(void *arg) > > > struct drm_i915_gem_object *obj; > > > struct i915_vma *vma; > > > enum intel_engine_id id; > > > - int err = -ENOMEM; > > > u32 *map; > > > + int err; > > We could init

Re: [PATCH] drm/radeon: fix race condition UAF in radeon_gem_set_domain_ioctl

2023-06-01 Thread Christian König
Am 26.05.23 um 14:37 schrieb Min Li: Userspace can race to free the gobj(robj converted from), robj should not be accessed again after drm_gem_object_put, otherwith it will result in use-after-free. Signed-off-by: Min Li --- drivers/gpu/drm/radeon/radeon_gem.c | 2 +- 1 file changed, 1 inser

Re: (subset) [PATCH v5 00/17] drm/meson: add support for MIPI DSI Display

2023-06-01 Thread Neil Armstrong
Hi, On Tue, 30 May 2023 09:38:01 +0200, Neil Armstrong wrote: > The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver > (ver 1.21a), > with a custom glue managing the IP resets, clock and data input similar to > the DW-HDMI > glue on the same Amlogic SoCs. > > This adds su

Re: [PATCH] drm/panel: khadas-ts050: update timings to achieve 60Hz refresh rate

2023-06-01 Thread Neil Armstrong
Hi, On Thu, 26 Jan 2023 10:39:42 +0100, Neil Armstrong wrote: > This updates the panel timings to achieve a clean 60Hz refresh rate. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/panel: khadas-ts050: update timings to achieve 60Hz refres

[PULL] drm-intel-fixes

2023-06-01 Thread Joonas Lahtinen
Hi Dave & Daniel, One fix appeared this morning, related to OA API for non-power-of-two reports. Full CI results not in yet, BAT is looking good so please check before pulling the trigger. Regards, Joonas *** drm-intel-fixes-2023-06-01: - Fix for OA reporting to allow detecting non-power-of-t

Re: [PATCH v6 2/6] drm/etnaviv: add a dedicated function to get various clocks

2023-06-01 Thread Sui Jingfeng
Hi, On 2023/6/1 02:07, Lucas Stach wrote: +static int etnaviv_gpu_clk_get(struct etnaviv_gpu *gpu) +{ + struct device *dev = gpu->dev; + + if (gpu->no_clk) + return 0; + + gpu->clk_reg = devm_clk_get_optional(dev, "reg"); + DBG("clk_reg: %p", gpu->clk_reg);

Re: [PATCH 1/2] dt-bindings: display: bridge: tc358762: Document reset-gpios

2023-06-01 Thread rfoss
From: Robert Foss On Tue, 30 May 2023 21:28:04 +0200, Marek Vasut wrote: > This chip has one reset GPIO input, document it. The reset GPIO > is optional as it is sometimes not connected on some hardware. > > Applied, thanks! [1/2] dt-bindings: display: bridge: tc358762: Document reset-gpios

Re: [Intel-gfx] [PATCH] drm/i915/gt: Use the correct error value when kernel_context() fails

2023-06-01 Thread Andrzej Hajda
On 26.05.2023 14:41, Andi Shyti wrote: kernel_context() returns an error pointer. Use pointer-error conversion functions to evaluate its return value, rather than checking for a '0' return. Fixes: eb5c10cbbc2f ("drm/i915: Remove I915_USER_PRIORITY_SHIFT") Reported-by: Dan Carpenter Signed-off-b

  1   2   >