Re: [PATCH 2/4] mei: gsc_proxy: add gsc proxy driver

2023-04-18 Thread Teres Alexis, Alan Previn
On Wed, 2023-03-29 at 09:56 -0700, Ceraolo Spurio, Daniele wrote: > From: Alexander Usyskin > > Add GSC proxy driver. It to allows messaging between GSC component > on Intel on board graphics card and CSE device. alan:nit: isn't "Intel integrated GPU" clearer than "Intel on-board graphics card"?

Re: [PATCH net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-04-18 Thread Heiner Kallweit
On 19.04.2023 02:10, Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN using magic packets > -

Re: [PATCH] drm/mediatek: Clarify/finish documentation for some driver structures

2023-04-18 Thread AngeloGioacchino Del Regno
Il 21/03/23 12:14, AngeloGioacchino Del Regno ha scritto: The documentation for some of the driver structures in mediatek-drm was set to be kerneldoc but some code additions didn't actually update the comments accordingly and this caused triggering some warnings. Add comments for the remaining u

Re: [PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-18 Thread Christophe JAILLET
Le 19/04/2023 à 06:59, Dan Carpenter a écrit : On Sat, Apr 15, 2023 at 04:09:03PM +0300, Dan Carpenter wrote: On Thu, Apr 13, 2023 at 09:33:17PM +0200, Christophe JAILLET wrote: When dev_err_probe() is called, 'ret' holds the value of the previous successful devm_request_irq() call. 'ret' shoul

Re: [PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-18 Thread Dan Carpenter
On Sat, Apr 15, 2023 at 04:09:03PM +0300, Dan Carpenter wrote: > On Thu, Apr 13, 2023 at 09:33:17PM +0200, Christophe JAILLET wrote: > > When dev_err_probe() is called, 'ret' holds the value of the previous > > successful devm_request_irq() call. > > 'ret' should be assigned with a meaningful value

[PATCH v2] firmware/sysfb: Fix VESA format selection

2023-04-18 Thread Pierre Asselin
Some legacy BIOSes report no reserved bits in their 32-bit rgb mode, breaking the calculation of bits_per_pixel in commit f35cd3fa7729 [firmware/sysfb: Fix EFI/VESA format selection]. However they report lfb_depth correctly for those modes. Keep the computation but set bits_per_pixel to lfb_depth

[PATCH] modules/firmware: add a new option to denote a firmware group to choose one.

2023-04-18 Thread Dave Airlie
From: Dave Airlie This adds a tag that will go into the module info, only one firmware from the group given needs to be available for this driver to work. This allows dracut to avoid adding in firmware that aren't needed. This just brackets a module list in the modinfo, the modules in the list w

[Bug 217278] ast 0000:03:00.0: PM: **** DPM device timeout **** during S4 resuming

2023-04-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217278 --- Comment #10 from wendy.w...@intel.com --- https://lore.kernel.org/lkml/20230414074204.5787-1-jammy_hu...@aspeedtech.com/T/ -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee o

Re: [PATCH] firmware/sysfb: Fix VESA format selection

2023-04-18 Thread kernel test robot
Hi Pierre, kernel test robot noticed the following build warnings: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on drm-misc/drm-misc-next linus/master v6.3-rc7 next-20230418] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH v2] drm/scheduler: set entity to NULL in drm_sched_entity_pop_job()

2023-04-18 Thread Luben Tuikov
Reviewed-by: Luben Tuikov and applied to drm-misc-next. Thanks! Regards, Luben On 2023-04-18 06:04, Danilo Krummrich wrote: > It already happend a few times that patches slipped through which > implemented access to an entity through a job that was already removed > from the entities queue. Si

Re: [PATCH net-next 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165

2023-04-18 Thread Andrew Lunn
On Tue, Apr 18, 2023 at 05:10:17PM -0700, Justin Chen wrote: > From: Florian Fainelli > > 74165 is a 16nm process SoC with a 10/100 integrated Ethernet PHY, > utilize the recently defined 16nm EPHY macro to configure that PHY. > > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen R

Re: [PATCH net-next 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support

2023-04-18 Thread Andrew Lunn
On Tue, Apr 18, 2023 at 05:10:16PM -0700, Justin Chen wrote: > Add mdio compat string for ASP 2.0 ethernet driver. > > Signed-off-by: Justin Chen > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-04-18 Thread Andrew Lunn
On Tue, Apr 18, 2023 at 05:10:15PM -0700, Justin Chen wrote: > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced with 72165. This controller features two distinct Ethernet > ports that can be independently operated. > > This patch supports: > > - Wake-on-LAN usi

Re: [PATCH net-next 0/6] Brcm ASP 2.0 Ethernet controller

2023-04-18 Thread Justin Chen
On Tue, Apr 18, 2023 at 5:10 PM Justin Chen wrote: > > From: Justin Chen Woops, looks like I screwed up on some of my email addresses in the patch set. Will fix in v2 after first round of reviews. Justin > > Add support for the Broadcom ASP 2.0 Ethernet controller which is first > introduced wit

Re: [PATCH v5 3/5] drm/tests: Add test cases for drm_rect_calc_vscale()

2023-04-18 Thread Maíra Canal
On 4/18/23 20:01, Arthur Grillo wrote: Insert parameterized test for the drm_rect_calc_vscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. It uses the same struct from drm_rect_calc_hscale(). Signed-off-by: Arthur Grillo T

Re: [PATCH v5 2/5] drm/tests: Add test cases for drm_rect_calc_hscale()

2023-04-18 Thread Maíra Canal
On 4/18/23 20:01, Arthur Grillo wrote: Insert parameterized test for the drm_rect_calc_hscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. Signed-off-by: Arthur Grillo Thanks for the quick fix! Reviewed-by: Maíra Canal B

[PATCH net-next 5/6] net: phy: bcm7xxx: Add EPHY entry for 74165

2023-04-18 Thread Justin Chen
From: Florian Fainelli 74165 is a 16nm process SoC with a 10/100 integrated Ethernet PHY, utilize the recently defined 16nm EPHY macro to configure that PHY. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- drivers/net/phy/bcm7xxx.c | 1 + include/linux/brcmphy.h | 1 + 2 file

[PATCH net-next 3/6] net: bcmasp: Add support for ASP2.0 Ethernet controller

2023-04-18 Thread Justin Chen
Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. This controller features two distinct Ethernet ports that can be independently operated. This patch supports: - Wake-on-LAN using magic packets - basic ethtool operations (link, counters, message level)

[PATCH net-next 6/6] MAINTAINERS: ASP 2.0 Ethernet driver maintainers

2023-04-18 Thread Justin Chen
Add maintainers entry for ASP 2.0 Ethernet driver. Signed-off-by: Justin Chen Signed-off-by: Florian Fainelli --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4fc57dfd5fd0..24cbe1c0fc06 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -41

[PATCH net-next 4/6] net: phy: mdio-bcm-unimac: Add asp v2.0 support

2023-04-18 Thread Justin Chen
Add mdio compat string for ASP 2.0 ethernet driver. Signed-off-by: Justin Chen Signed-off-by: Florian Fainelli --- drivers/net/mdio/mdio-bcm-unimac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c index bfc9be23c973

[PATCH net-next 2/6] dt-bindings: net: brcm, unimac-mdio: Add asp-v2.0

2023-04-18 Thread Justin Chen
From: Justin Chen The ASP 2.0 Ethernet controller uses a brcm unimac. Signed-off-by: Justin Chen Signed-off-by: Florian Fainelli --- Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/brcm,uni

[PATCH net-next 1/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-04-18 Thread Justin Chen
From: Florian Fainelli Add a binding document for the Broadcom ASP 2.0 Ethernet controller. Signed-off-by: Florian Fainelli Signed-off-by: Justin Chen --- .../devicetree/bindings/net/brcm,asp-v2.0.yaml | 146 + 1 file changed, 146 insertions(+) create mode 100644 Docu

[PATCH net-next 0/6] Brcm ASP 2.0 Ethernet controller

2023-04-18 Thread Justin Chen
From: Justin Chen Add support for the Broadcom ASP 2.0 Ethernet controller which is first introduced with 72165. Add support for 74165 10/100 integrated Ethernet PHY which also uses the ASP 2.0 Ethernet controller. Florian Fainelli (2): dt-bindings: net: Brcm ASP 2.0 Ethernet controller net

Re: [PATCH 1/4] drm/i915/mtl: Define GSC Proxy component interface

2023-04-18 Thread Teres Alexis, Alan Previn
On Wed, 2023-03-29 at 09:56 -0700, Ceraolo Spurio, Daniele wrote: > From: Alexander Usyskin > > GSC Proxy component is used for communication between the > Intel graphics driver and MEI driver. > diff --git a/include/drm/i915_gsc_proxy_mei_interface.h > b/include/drm/i915_gsc_proxy_mei_interf

Re: [Intel-gfx] [PATCH 5/5] drm/i915/uc: Reject doplicate entries in firmware table

2023-04-18 Thread Ceraolo Spurio, Daniele
Typo doplicate in patch title On 4/14/2023 5:57 PM, john.c.harri...@intel.com wrote: From: John Harrison It was noticed that duplicte entries in the firmware table could cause typo duplicte an infinite loop in the firmware loading code if that entry failed to load. Duplicate entries are a

Re: [PATCH 4/5] drm/i915/uc: Split firmware table validation to a separate function

2023-04-18 Thread Ceraolo Spurio, Daniele
On 4/14/2023 5:57 PM, john.c.harri...@intel.com wrote: From: John Harrison The validation of the firmware table was being done inside the code for scanning the table for the next available firmware blob. Which is unnecessary. Potentially, it should be a selftest. But either way, the first st

[PATCH v5 5/5] drm/test: Add test cases for drm_rect_rotate_inv()

2023-04-18 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate_inv() to ensure its correctness and prevent future regressions. The test covers all rotation modes. It uses the same test cases from drm_test_rect_rotate(). Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_r

[PATCH v5 4/5] drm/tests: Add test cases for drm_rect_rotate()

2023-04-18 Thread Arthur Grillo
Insert a parameterized test for the drm_rect_rotate() to ensure correctness and prevent future regressions. All possible rotation modes are covered by the test. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 f

[PATCH v5 3/5] drm/tests: Add test cases for drm_rect_calc_vscale()

2023-04-18 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_vscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. It uses the same struct from drm_rect_calc_hscale(). Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c |

[PATCH v5 2/5] drm/tests: Add test cases for drm_rect_calc_hscale()

2023-04-18 Thread Arthur Grillo
Insert parameterized test for the drm_rect_calc_hscale() to ensure correctness and prevent future regressions. Besides the test for the usual case, tests the exceptions. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/tests/drm_rect_test.c | 72 +++ 1 file changed, 72 in

[PATCH v5 1/5] drm/tests: Add test cases for drm_rect_intersect()

2023-04-18 Thread Arthur Grillo
Insert parameterized tests for the drm_rect_intersect() to ensure correctness and prevent future regressions. Also, create a helper for testing if two drm_rects are equal. Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- drivers/gpu/drm/tests/drm_rect_test.c | 148

[PATCH v5 0/5] Create tests for the drm_rect functions

2023-04-18 Thread Arthur Grillo
This patchset seeks to add unit tests for the rest of the functions on the drm_rect.c. The test coverage report generated by the gcov[1] tool states that this set reaches 100% of coverage on the drm_rect.c file. This would be very good for future development on the file. If you want to see the co

Re: [Intel-gfx] [PATCH 3/5] drm/i915/uc: Track patch level versions on reduced version firmware files

2023-04-18 Thread Ceraolo Spurio, Daniele
On 4/14/2023 5:57 PM, john.c.harri...@intel.com wrote: From: John Harrison When reduced version firmware files were added (matching major component being the only strict requirement), the minor version was still tracked and a notification reported if it was older. However, the patch version

Re: [PATCH] dt-bindings: display: panel: add common definition of ports

2023-04-18 Thread Rob Herring
On Sun, Apr 16, 2023 at 05:39:29PM +0200, Krzysztof Kozlowski wrote: > Few panel bindings for dual-link connections just type "ports: true", > which does not enforce any type. Add common definition of ports, so the > type will be fixed. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Cc: Ko

Re: [PATCH v3 1/3] dt-bindings: display: panel: Add Samsung S6D7AA0 LCD panel controller

2023-04-18 Thread Rob Herring
On Sun, Apr 16, 2023 at 03:16:30PM +0200, Artur Weber wrote: > Add bindings for the S6D7AA0 LCD panel controller, including the > S6D7AA0-LSL080AL02 panel used in the Samsung Galaxy Tab 3 8.0 family > of tablets. > > Signed-off-by: Artur Weber > --- > Changed in v2: > - Updated commit message >

Re: [PATCH] accel/qaic: initialize ret variable to 0

2023-04-18 Thread Jeffrey Hugo
On 4/18/2023 2:48 PM, Nick Desaulniers wrote: On Tue, Apr 18, 2023 at 1:46 PM Jeffrey Hugo wrote: On 4/18/2023 1:20 PM, Tom Rix wrote: clang static analysis reports drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn

Re: [PATCH 1/3] dt-bindings: panel: Add Samsung S6D7AA0 LCD controller bindings

2023-04-18 Thread Rob Herring
On Sun, Apr 16, 2023 at 12:01:37PM +0200, Artur Weber wrote: > Signed-off-by: Artur Weber > --- > .../display/panel/samsung,s6d7aa0.yaml| 51 +++ > 1 file changed, 51 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/samsung,s6d7aa0.yam

Re: [PATCH 1/3] dt-bindings: display: synopsys, dw-hdmi: Add property for disabling CEC

2023-04-18 Thread Rob Herring
On Sat, Apr 15, 2023 at 12:46:11PM +0200, Jernej Skrabec wrote: > Even though some DW-HDMI controllers have perfectly usable HDMI-CEC > implementation, some boards might prefer not to use it or even use > software implementation instead. > > Add property for disabling CEC so driver doesn't expose

Re: [PATCH 1/2] dt-bindings: display: simple: support non-default data-mapping

2023-04-18 Thread Rob Herring
On Fri, Apr 14, 2023 at 06:11:15PM +0200, Johannes Zink wrote: > Some Displays support more than just a single default lvds data mapping, > which can be used to run displays on only 3 LVDS lanes in the jeida-18 > data-mapping mode. > > Add an optional data-mapping property, analogously to panel-lv

Re: [PATCH 1/2] gpu: Move ASPEED vendor ID definition to pci_ids.h

2023-04-18 Thread Bjorn Helgaas
On Tue, Apr 18, 2023 at 04:14:03PM -0500, Bjorn Helgaas wrote: > Most subject lines for pci_ids.h look like this: > > PCI: Add ASPEED vendor ID > > On Mon, Apr 17, 2023 at 06:17:19PM -0700, Patrick McLean wrote: > > Currently the ASPEED PCI vendor ID is defined in > > drivers/gpu/drm/ast/ast_d

Re: [PATCH 1/2] gpu: Move ASPEED vendor ID definition to pci_ids.h

2023-04-18 Thread Bjorn Helgaas
Most subject lines for pci_ids.h look like this: PCI: Add ASPEED vendor ID On Mon, Apr 17, 2023 at 06:17:19PM -0700, Patrick McLean wrote: > Currently the ASPEED PCI vendor ID is defined in > drivers/gpu/drm/ast/ast_drv.c, > move that to include/linux/pci_ids.h with all the rest of the PCI ven

Re: [PATCH] dt-bindings: display: simplify compatibles syntax

2023-04-18 Thread Rob Herring
On Fri, 14 Apr 2023 12:42:30 +0200, Krzysztof Kozlowski wrote: > Lists (items) with one item should be just const or enum because it is > shorter and simpler. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Rebased on next-20230406. I hope it applies cleanly... > --- > .../display/bridge/

Re: [PATCH] dt-bindings: display: mediatek: simplify compatibles syntax

2023-04-18 Thread Rob Herring
On Fri, 14 Apr 2023 10:33:11 +0200, Krzysztof Kozlowski wrote: > Lists (items) with one item should be just enum because it is shorter, > simpler and does not confuse, if one wants to add new entry with a > fallback. Convert all of them to enums. OTOH, leave unused "oneOf" > entries in anticipa

Re: [PATCH] accel/qaic: initialize ret variable to 0

2023-04-18 Thread Nick Desaulniers
On Tue, Apr 18, 2023 at 1:46 PM Jeffrey Hugo wrote: > > On 4/18/2023 1:20 PM, Tom Rix wrote: > > clang static analysis reports > > drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage > >value returned to caller [core.uninitialized.UndefReturn] > > return ret; > >

Re: [PATCH] accel/qaic: initialize ret variable to 0

2023-04-18 Thread Jeffrey Hugo
On 4/18/2023 1:20 PM, Tom Rix wrote: clang static analysis reports drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return ret; ^~ The ret variable is only set some of the time but is always

Re: [PATCH] drm/qxl: remove variable count

2023-04-18 Thread Nick Desaulniers
On Sat, Apr 8, 2023 at 9:50 AM Tom Rix wrote: > > clang with W=1 reports > drivers/gpu/drm/qxl/qxl_cmd.c:424:6: error: variable > 'count' set but not used [-Werror,-Wunused-but-set-variable] > int count = 0; > ^ > This variable is not used so remove it. Thanks for the patch!

[PATCH] accel/qaic: initialize ret variable to 0

2023-04-18 Thread Tom Rix
clang static analysis reports drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return ret; ^~ The ret variable is only set some of the time but is always returned. So initialize ret to 0. Fixes:

Re: [PATCH 1/3] drm: bridge: icn6211: Only warn on invalid chip IDs

2023-04-18 Thread Marek Vasut
On 4/18/23 15:42, Jagan Teki wrote: On Tue, Apr 18, 2023 at 5:52 PM Brandon Cheo Fusi wrote: Avoid aborting chip configuration after reading invalid IDs and instead issue a warning. I have a bunch of these chips and they all report "Vendor=0x00 Device=0x00:0x00 Version=0x00" but are successful

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix the video-interfaces.yaml references

2023-04-18 Thread Rob Herring
On Wed, 12 Apr 2023 14:58:00 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > video-interface.txt does not exist anymore, as it has been converted > to video-interfaces.yaml. > > Instead of referencing video-interfaces.yaml multiple times, > pass it as a $ref to the schema. > > Signed-of

[PATCH] drm/fb-helper: Fix height, width, and accel_flags in fb_var

2023-04-18 Thread Geert Uytterhoeven
Fbtest contains some very simple validation of the fbdev userspace API contract. When used with shmob-drm, it reports the following warnings and errors: height changed from 68 to 0 height was rounded down width changed from 111 to 0 width was rounded down accel_flags changed f

Re: [Intel-gfx] [PATCH 1/5] drm/i915/guc: Decode another GuC load failure case

2023-04-18 Thread Ceraolo Spurio, Daniele
On 4/14/2023 5:57 PM, john.c.harri...@intel.com wrote: From: John Harrison Explain another potential firmware failure mode and early exit the long wait if hit. Signed-off-by: John Harrison Reviewed-by: Daniele Ceraolo Spurio Daniele --- drivers/gpu/drm/i915/gt/uc/abi/guc_errors_ab

Re: [PATCH v7 6/8] drm/i915/uapi/pxp: Fix UAPI spec comments and add GET_PARAM for PXP

2023-04-18 Thread Teres Alexis, Alan Previn
On Tue, 2023-04-18 at 21:06 +0300, Landwerlin, Lionel G wrote: > On 14/04/2023 18:17, Teres Alexis, Alan Previn wrote: > > Hi Lionel, does this patch work for you? > > > Hi, Sorry for the late answer. > > That looks good : alan: Great - thanks Lionel! :) I'll help get the MESA side PR out in com

Re: [Intel-gfx] [PATCH 2/5] drm/i915/guc: Print status register when waiting for GuC to load

2023-04-18 Thread Ceraolo Spurio, Daniele
On 4/14/2023 5:57 PM, john.c.harri...@intel.com wrote: From: John Harrison If the GuC load is taking an excessively long time, the wait loop currently prints the GT frequency. Extend that to include the GuC status as well so we can see if the GuC is actually making progress or not. Signed-o

Re: linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-18 Thread Mark Brown
On Sun, Apr 16, 2023 at 09:58:50AM +0200, Daniel Vetter wrote: > Note there was a ppc compile fail, which is why we pushed the ttm revert. > That /should/ be fixed now, but would be good if you can confirm? According to Nathan (CCed) there's still issues with the interaction with the PowerPC tree

[PATCH] firmware/sysfb: Fix VESA format selection

2023-04-18 Thread Pierre Asselin
Some legacy BIOSes report no reserved bits in their 32-bit rgb mode, breaking the calculation of bits_per_pixel in commit f35cd3fa7729 [firmware/sysfb: Fix EFI/VESA format selection]. However they report lfb_depth correctly for those modes. Recompute bits_per_pixel from the color and reserved bit

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Nathan Chancellor
oks like this > > regressed in next-20230417 and next-20230418 though. > > Someone sent a mail saying they thought they'd fixed the DRM tree - is > that not the case? Does not seem like it: $ git show -s --format='%h ("%s")' 67d5d9f013d6 ("Add linux-ne

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Mark Brown
On Tue, Apr 18, 2023 at 11:21:45AM -0700, Nathan Chancellor wrote: > On Fri, Apr 14, 2023 at 05:55:10PM +0100, Mark Brown wrote: > > Done. > Thanks a lot, sorry for not saying it sooner! It looks like this > regressed in next-20230417 and next-20230418 though. Someone sent a m

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Nathan Chancellor
was rather > > surprised that my AMD test machine's graphical output was not working > > until I noticed the configuration difference :) > > Done. Thanks a lot, sorry for not saying it sooner! It looks like this regressed in next-20230417 and next-20230418 though. Cheers, Nathan

[PATCH v2 2/2] drm/i915/guc: Dump error capture to dmesg on CTB error

2023-04-18 Thread John . C . Harrison
From: John Harrison In the past, There have been sporadic CTB failures which proved hard to reproduce manually. The most effective solution was to dump the GuC log at the point of failure and let the CI system do the repro. It is preferable not to dump the GuC log via dmesg for all issues as it i

[PATCH v2 1/2] drm/i915: Dump error capture to kernel log

2023-04-18 Thread John . C . Harrison
From: John Harrison This is useful for getting debug information out in certain situations, such as failing kernel selftests and CI runs that don't log error captures. It is especially useful for things like retrieving GuC logs as GuC operation can't be tracked by adding printk or ftrace entries.

[PATCH v2 0/2] Add support for dumping error captures via kernel logging

2023-04-18 Thread John . C . Harrison
From: John Harrison Sometimes, the only effective way to debug an issue is to dump all the interesting information at the point of failure. So add support for doing that. v2: Extra CONFIG wrapping (review feedback from Rodrigo) Signed-off-by: John Harrison John Harrison (2): drm/i915: Dump

Re: [PATCH v3] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-18 Thread Sui Jingfeng
Hi, On 2023/4/19 01:52, Sui Jingfeng wrote: Hi, On 2023/4/18 16:32, Daniel Vetter wrote: On Mon, Apr 17, 2023 at 07:32:19PM +0800, Sui Jingfeng wrote: The fbdev test of IGT may write after EOF, which lead to out-of-bound access for the drm drivers using fbdev-generic. For example, on a x86 +

Re: [PATCH v7 6/8] drm/i915/uapi/pxp: Fix UAPI spec comments and add GET_PARAM for PXP

2023-04-18 Thread Lionel Landwerlin
On 14/04/2023 18:17, Teres Alexis, Alan Previn wrote: Hi Lionel, does this patch work for you? Hi, Sorry for the late answer. That looks good : Acked-by: Lionel Landwerlin Thanks, -Lionel On Mon, 2023-04-10 at 10:22 -0700, Ceraolo Spurio, Daniele wrote: On 4/6/2023 10:44 AM, Alan

Re: [PATCH] phy: mediatek/mt8195: fx mtk_hdmi_pll_calc() return code

2023-04-18 Thread Matthias Brugger
Hi Arnd, On 14/04/2023 09:58, Arnd Bergmann wrote: From: Arnd Bergmann The newly added function returns an uninitialized variable: drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable 'ret' is uninitialized when used here [-Werror,-Wuninitialized] Wire it up to the return code

Re: [PATCH v3] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-18 Thread Sui Jingfeng
Hi, On 2023/4/18 16:32, Daniel Vetter wrote: On Mon, Apr 17, 2023 at 07:32:19PM +0800, Sui Jingfeng wrote: The fbdev test of IGT may write after EOF, which lead to out-of-bound access for the drm drivers using fbdev-generic. For example, on a x86 + aspeed bmc card platform, with a 1680x1050 res

Re: [PATCH] drm/amdkfd: Fix potential deallocation of previously deallocated memory.

2023-04-18 Thread Andi Shyti
> Daniil will you look into this? and, because this is a bug fix, if you do want to send a real fix, plase add to the commit message: Fixes: d1f8f0d17d40 ("drm/amdkfd: Move non-sdma mqd allocation out of init_mqd") Cc: Oak Zeng Cc: # v5.3+ Andi PS: please note that Oak's e-mail has changed.

Re: [PATCH 3/3] drm/i915/hwmon: Block waiting for GuC reset to complete

2023-04-18 Thread Dixit, Ashutosh
On Mon, 17 Apr 2023 22:35:58 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Mon, Apr 10, 2023 at 03:35:09PM -0700, Ashutosh Dixit wrote: > > Instead of erroring out when GuC reset is in progress, block waiting for > > GuC reset to complete which is a more reasonable uapi behavior. > > > > v2: Avoi

Re: [RFC 4/6] drm: Add simple fdinfo memory helpers

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > For drivers who only wish to show one memory region called 'system, > and only account the GEM buffer object handles under it. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/drm_file.c | 45 +++

[PATCH] kunit: drm: make DRM buddy test compatible with other pages sizes

2023-04-18 Thread Nico Pache
The DRM buddy test uses a fixed 12 bit shift to covert from pages to bytes. This number is then used to confirm that (chunk_size < PAGE_SIZE) which can lead to a failing drm_buddy_init on systems with PAGE_SIZE > 4k. Fixes: 92937f170d3f ("drm/selftests: add drm buddy alloc range testcase") Signed

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 9:44 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 17:13, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin > > wrote: > >> On 18/04/2023 15:36, Rob Clark wrote: > >>> On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin > >>> wrote: > > > On 18/

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 17:13, Rob Clark wrote: On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin wrote: On 18/04/2023 15:36, Rob Clark wrote: On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: On 18/04/2023 14:49, Rob Clark wrote: On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: On 17/0

[PATCH] drm/msm/atomic: Don't try async if crtc not active

2023-04-18 Thread Rob Clark
From: Rob Clark For a similar reason as commit f2c7ca890182 ("drm/atomic-helper: Don't set deadline for modesets"), we need the crtc to be already active in order to compute a target vblank time for an async commit. Otherwise we get this splat reminding us that we are doing it wrong: ---

Re: [Intel-gfx] [PATCH 0/2] Add support for dumping error captures via kernel logging

2023-04-18 Thread Rodrigo Vivi
On Tue, Apr 11, 2023 at 06:50:53PM +0200, Daniel Vetter wrote: > On Tue, Apr 11, 2023 at 09:41:04AM -0700, John Harrison wrote: > > On 4/11/2023 07:41, Rodrigo Vivi wrote: > > > On Mon, Apr 10, 2023 at 12:25:21PM -0700, john.c.harri...@intel.com wrote: > > > > From: John Harrison > > > > > > > >

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:46 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:36, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 18/04/2023 14:49, Rob Clark wrote: > >>> On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin > >>> wrote: > > > >

Re: [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:58 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 15:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Show how more driver specific set of memory stats could be shown, > >> more specifically where

Re: [PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

2023-04-18 Thread Abhinav Kumar
On 4/17/2023 4:14 PM, Marijn Suijten wrote: The WB debug log mask ended up never being assigned, leading to writes to this block to never be logged even if the mask is enabled in dpu_hw_util_log_mask via sysfs. This should be debugfs not sysfs. Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_h

Re: [PATCH] dt-bindings: display: Fix lvds.yaml references

2023-04-18 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Tue, Apr 18, 2023 at 10:06:57AM -0500, Rob Herring wrote: > The trailing "/" in "lvds.yaml/#" is not a valid JSON pointer. The existing > jsonschema package allows it, but coming changes make allowed "$ref" URIs > stricter. > > Signed-off-by: Rob Herring Rev

Re: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-18 Thread Liviu Dudau
On Mon, Apr 03, 2023 at 05:22:01PM -0700, Matthew Brost wrote: > Hello, Hello, Jumping a bit late on this thread as I was waiting on some approvals and then holidays kicked in, but I would like to (re)introduce myself and the people I work with and to let you know that we are interested in the ch

[PATCH] dt-bindings: display: Fix lvds.yaml references

2023-04-18 Thread Rob Herring
The trailing "/" in "lvds.yaml/#" is not a valid JSON pointer. The existing jsonschema package allows it, but coming changes make allowed "$ref" URIs stricter. Signed-off-by: Rob Herring --- .../devicetree/bindings/display/panel/advantech,idk-1110wr.yaml | 2 +- .../devicetree/bindings/display/p

Re: [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 15:39, Rob Clark wrote: On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Show how more driver specific set of memory stats could be shown, more specifically where object can reside in multiple regions, showing all the supported stats, and where there

Re: [RFC 3/3] drm/msm: Add comm/cmdline fields

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 1:53 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 21:12, Rob Clark wrote: > > From: Rob Clark > > > > Normally this would be the same information that can be obtained in > > other ways. But in some cases the process opening the drm fd is merely > > a sort of proxy for the

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 15:36, Rob Clark wrote: On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: On 18/04/2023 14:49, Rob Clark wrote: On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: On 17/04/2023 20:39, Rob Clark wrote: On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: From:

Re: [PATCH] drm/doc/rfc: Introduce the merge plan for the Xe driver.

2023-04-18 Thread Rodrigo Vivi
On Tue, Apr 18, 2023 at 11:31:30AM -0300, Gustavo Sousa wrote: > Quoting Rodrigo Vivi (2023-04-18 10:31:33) > > Let’s establish a merge plan for Xe, by writing down clear pre-merge goals, > > in > > order to avoid unnecessary delays. > > > > This initial document starts with a TODO list containin

Re: [RFC 6/6] drm/i915: Implement fdinfo memory stats printing

2023-04-18 Thread Rob Clark
On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Show how more driver specific set of memory stats could be shown, > more specifically where object can reside in multiple regions, showing all > the supported stats, and where there is more to show than just user v

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 7:19 AM Tvrtko Ursulin wrote: > > > On 18/04/2023 14:49, Rob Clark wrote: > > On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin > > wrote: > >> > >> > >> On 17/04/2023 20:39, Rob Clark wrote: > >>> On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > >>> wrote: > > Fro

Re: [PATCH] drm/doc/rfc: Introduce the merge plan for the Xe driver.

2023-04-18 Thread Gustavo Sousa
Quoting Rodrigo Vivi (2023-04-18 10:31:33) > Let’s establish a merge plan for Xe, by writing down clear pre-merge goals, in > order to avoid unnecessary delays. > > This initial document starts with a TODO list containing items with clear and > measurable key results. Xe’s initial pull request sho

Re: [RFC 2/3] drm/msm: Rework get_comm_cmdline() helper

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 1:34 AM Daniel Vetter wrote: > > On Tue, Apr 18, 2023 at 09:27:49AM +0100, Tvrtko Ursulin wrote: > > > > On 17/04/2023 21:12, Rob Clark wrote: > > > From: Rob Clark > > > > > > Make it work in terms of ctx so that it can be re-used for fdinfo. > > > > > > Signed-off-by: Ro

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Tvrtko Ursulin
On 18/04/2023 14:49, Rob Clark wrote: On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: On 17/04/2023 20:39, Rob Clark wrote: On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add support to dump GEM stats to fdinfo. Signed-off-by: Tvrtko Ursulin ---

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 3:47 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 17:20, Christian König wrote: > > Am 17.04.23 um 17:56 schrieb Tvrtko Ursulin: > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM stats to fdinfo. > >> > >> Signed-off-by: Tvrtko Ursulin > >> --- > >> Documentat

Re: [PATCH] [v2] drm/amd/display: fix is_timing_changed() prototype

2023-04-18 Thread Hamza Mahfooz
On 4/17/23 18:07, Arnd Bergmann wrote: From: Arnd Bergmann Three functions in the amdgpu display driver cause -Wmissing-prototype warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1858:6: error: no previous prototype for 'is_timing_changed' [-Werror=missing-prototypes] is

[PATCH] drm/i915/dp: prevent potential div-by-zero

2023-04-18 Thread Nikita Zhandarovich
drm_dp_dsc_sink_max_slice_count() may return 0 if something goes wrong on the part of the DSC sink and its DPCD register. This null value may be later used as a divisor in intel_dsc_compute_params(), which will lead to an error. In the unlikely event that this issue occurs, fix it by testing the re

Re: [PATCH] drm/dp_mst: Clear MSG_RDY flag before sending new message

2023-04-18 Thread Ville Syrjälä
On Tue, Apr 18, 2023 at 02:09:05PM +0800, Wayne Lin wrote: > [Why & How] > The sequence for collecting down_reply/up_request from source > perspective should be: > > Request_n->repeat (get partial reply of Request_n->clear message ready > flag to ack DPRX that the message is received) till all par

Re: [RFC 3/6] drm: Add fdinfo memory stats

2023-04-18 Thread Rob Clark
On Tue, Apr 18, 2023 at 2:00 AM Tvrtko Ursulin wrote: > > > On 17/04/2023 20:39, Rob Clark wrote: > > On Mon, Apr 17, 2023 at 8:56 AM Tvrtko Ursulin > > wrote: > >> > >> From: Tvrtko Ursulin > >> > >> Add support to dump GEM stats to fdinfo. > >> > >> Signed-off-by: Tvrtko Ursulin > >> --- > >>

Re: [PATCH] drm/bridge:Fix the panic problem caused by bridge->funcs->attach

2023-04-18 Thread Jagan Teki
On Mon, Apr 17, 2023 at 12:52 PM logic.yu wrote: > > When the code is executed to bridge->funcs->attach,bridge->funcs is NULL. > Although the function entry checks whether the bridge pointer is NULL,it > does not detect whether the bridge->funcs is NULL, so a panic error > occurs. > > Signed-off-b

Re: [PATCH 1/3] drm: bridge: icn6211: Only warn on invalid chip IDs

2023-04-18 Thread Jagan Teki
On Tue, Apr 18, 2023 at 5:52 PM Brandon Cheo Fusi wrote: > > Avoid aborting chip configuration after reading invalid IDs and > instead issue a warning. I have a bunch of these chips and they all > report "Vendor=0x00 Device=0x00:0x00 Version=0x00" but are successfully > configured and go on to wor

[PATCH] drm/doc/rfc: Introduce the merge plan for the Xe driver.

2023-04-18 Thread Rodrigo Vivi
Let’s establish a merge plan for Xe, by writing down clear pre-merge goals, in order to avoid unnecessary delays. This initial document starts with a TODO list containing items with clear and measurable key results. Xe’s initial pull request should only be sent to dri-devel after all the items are

Re: [PATCH v2 1/5] dt-bindings: display/msm: Add reg bus interconnect

2023-04-18 Thread Krzysztof Kozlowski
On 18/04/2023 14:10, Konrad Dybcio wrote: > Apart from the already handled data bus (MAS_MDP_Pn<->DDR), there's > another path that needs to be handled to ensure MDSS functions properly, > namely the "reg bus", a.k.a the CPU-MDSS interconnect. > > Gating that path may have a variety of effects.. f

Re: [PATCH] [v2] drm/amd/display: fix is_timing_changed() prototype

2023-04-18 Thread Aurabindo Pillai
On 4/17/2023 6:07 PM, Arnd Bergmann wrote: From: Arnd Bergmann Three functions in the amdgpu display driver cause -Wmissing-prototype warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1858:6: error: no previous prototype for 'is_timing_changed' [-Werror=missing-prototyp

Re: [RFC PATCH 3/3] drm: bridge: samsung-dsim: Remove init quirk for Exynos

2023-04-18 Thread Frieder Schrempf
On 18.04.23 15:12, Marek Szyprowski wrote: > On 18.04.2023 12:42, Frieder Schrempf wrote: >> From: Frieder Schrempf >> >> Assuming that with the init flow fixed to meet the documentation at >> [1] and the pre_enable_prev_first flag set in downstream bridge/panel >> drivers which require it, we can

Re: [PATCH v2 17/17] drm/msm/dpu: Remove intr_rdptr from DPU >= 5.0.0 pingpong config

2023-04-18 Thread Konrad Dybcio
On 17.04.2023 22:21, Marijn Suijten wrote: > Now that newer DPU platforms use a readpointer-done interrupt on the > INTF block, stop providing the unused interrupt on the PINGPONG block. > > Signed-off-by: Marijn Suijten > Reviewed-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konra

  1   2   3   >