Re: [PATCH] dma-buf/dma-resv.c: fix a typo

2023-04-16 Thread Christian König
Am 16.04.23 um 16:38 schrieb Sui Jingfeng: The dma_resv_wait_timeout() function return a value greater than zero on success. Signed-off-by: Sui Jingfeng Reviewed and pushed to drm-misc-next. Thanks, Christian. --- drivers/dma-buf/dma-resv.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-16 Thread Christian König
Am 11.04.23 um 16:13 schrieb Daniel Vetter: On Tue, Apr 11, 2023 at 11:02:55AM +0200, Christian König wrote: The point is that this not only requires some work in the drm_scheduler, but rather it then makes only little sense to use the drm_scheduler in the first place. The whole point of the dr

RE: [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-16 Thread Yang, Fei
> fei.y...@intel.com kirjoitti 17.4.2023 klo 9.24: >> From: Fei Yang >> >> The series includes patches needed to enable MTL. >> Also add new extension for GEM_CREATE uAPI to let user space set cache >> policy for buffer objects. > > if I'm counting right, this would be version 5 of the series, y

Re: [Intel-gfx] [PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-16 Thread Timo Aaltonen
fei.y...@intel.com kirjoitti 17.4.2023 klo 9.24: From: Fei Yang The series includes patches needed to enable MTL. Also add new extension for GEM_CREATE uAPI to let user space set cache policy for buffer objects. if I'm counting right, this would be version 5 of the series, yet that is not sh

Re: [PATCH] gpu: gma500: psb_drv: add missing unwind goto

2023-04-16 Thread Dan Carpenter
On Mon, Apr 17, 2023 at 02:01:05PM +0800, Hongqi Chen wrote: > Smatch reports that missing unwind goto in psb_driver_load(). > drivers/gpu/drm/gma500/psb_drv.c:350 psb_driver_load() warn: missing > unwind goto? > > psb_driver_unload() and psb_driver_load() exist in correspondence, > and psb_drive

[PATCH 3/8] drm/i915/mtl: Add PTE encode function

2023-04-16 Thread fei . yang
From: Fei Yang PTE encode functions are platform dependent. This patch implements PTE functions for MTL, and ensures the correct PTE encode function is used by calling pte_encode function pointer instead of the hardcoded gen8 version of PTE encode. Signed-off-by: Fei Yang --- drivers/gpu/drm/i

[PATCH 7/8] drm/i915: use pat_index instead of cache_level

2023-04-16 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent, ha

[PATCH 5/8] drm/i915/mtl: end support for set caching ioctl

2023-04-16 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[PATCH 0/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-16 Thread fei . yang
From: Fei Yang The series includes patches needed to enable MTL. Also add new extension for GEM_CREATE uAPI to let user space set cache policy for buffer objects. Fei Yang (7): drm/i915/mtl: Set has_llc=0 drm/i915/mtl: Add PTE encode function drm/i915/mtl: workaround coherency issue for Me

[PATCH 4/8] drm/i915/mtl: workaround coherency issue for Media

2023-04-16 Thread fei . yang
From: Fei Yang This patch implements Wa_22016122933. In MTL, memory writes initiated by Media tile update the whole cache line even for partial writes. This creates a coherency problem for cacheable memory if both CPU and GPU are writing data to different locations within a single cache line. CT

[PATCH 6/8] drm/i915: preparation for using PAT index

2023-04-16 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by a

[PATCH 8/8] drm/i915: Allow user to set cache at BO creation

2023-04-16 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out its life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a defau

[PATCH 2/8] drm/i915/mtl: Define MOCS and PAT tables for MTL

2023-04-16 Thread fei . yang
From: Madhumitha Tolakanahalli Pradeep On MTL, GT can no longer allocate on LLC - only the CPU can. This, along with addition of support for L4 cache calls a MOCS/PAT table update. Alos the PAT index registers are multicasted for primary GT, and there is an address jump from index 7 to 8. This p

[PATCH 1/8] drm/i915/mtl: Set has_llc=0

2023-04-16 Thread fei . yang
From: Fei Yang On MTL, GT is no longer allocated on LLC, set has_llc=0. Signed-off-by: Fei Yang --- drivers/gpu/drm/i915/i915_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index cddb6e197972..025d32c0b161 100644 ---

Re: [PATCH] drm/amd/display: fix flickering caused by S/G mode

2023-04-16 Thread Christian König
Am 14.04.23 um 21:33 schrieb Hamza Mahfooz: Currently, we allow the framebuffer for a given plane to move between memory domains, however when that happens it causes the screen to flicker, it is even possible for the framebuffer to change memory domains on every plane update (causing a continuous

Re: [PATCH v3] drm/nouveau: fix incorrect conversion to dma_resv_wait_timeout()

2023-04-16 Thread Christian König
Am 15.04.23 um 04:02 schrieb John Ogness: Commit 41d351f29528 ("drm/nouveau: stop using ttm_bo_wait") converted from ttm_bo_wait_ctx() to dma_resv_wait_timeout(). However, dma_resv_wait_timeout() returns greater than zero on success as opposed to ttm_bo_wait_ctx(). As a result, relocs will fail a

Re: [drm-tip:drm-tip 4/8] drivers/gpu/drm/msm/msm_drv.c:458:15: error: too many arguments to function 'drm_aperture_remove_framebuffers'

2023-04-16 Thread Thomas Zimmermann
-next' into drm-tip config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230416/202304162325.yltnxysy-...@intel.com/config) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/mak

Re: [PATCH 2/2] drm/panel-simple: allow LVDS format override

2023-04-16 Thread Dan Carpenter
/20230416/202304160359.4lhmfolu-...@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Link: https://lore.kernel.org/r/202304160359.4lhmfolu-...@intel.com

Re: [GIT PULL] exynos-drm-next

2023-04-16 Thread Inki Dae
Hi Daniel, 2023년 3월 29일 (수) 오후 2:39, 대인기 님이 작성: > > > > > -Original Message- > > From: Daniel Vetter > > Sent: Wednesday, March 29, 2023 2:31 AM > > To: Inki Dae > > Cc: airl...@linux.ie; dan...@ffwll.ch; dri-devel@lists.freedesktop.org; > > linux-samsung-...@vger.kernel.org > > Subject:

Re: [RFC PATCH 00/10] Xe DRM scheduler and long running workload plans

2023-04-16 Thread Matthew Brost
On Sat, Apr 08, 2023 at 04:05:20PM +0900, Asahi Lina wrote: > On 04/04/2023 10.58, Matthew Brost wrote: > > On Tue, Apr 04, 2023 at 10:07:48AM +0900, Asahi Lina wrote: > > > Hi, thanks for the Cc! > > > > > > > No problem. > > > > > On 04/04/2023 09.22, Matthew Brost wrote: > > > > Hello, > > >

[PATCH v3] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-16 Thread Andi Shyti
In multi-gt systems IRQs need to be reset and enabled per GT. This might add some redundancy when handling interrupts for engines that might not exist in every tile, but helps to keep the code cleaner and more understandable. Signed-off-by: Andi Shyti Cc: Tvrtko Ursulin --- Hi, Following the m

Re: [PATCH 2/6] drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp]

2023-04-16 Thread Adam Ford
On Sun, Apr 16, 2023 at 5:07 PM Marek Vasut wrote: > > On 4/15/23 12:40, Adam Ford wrote: > > According to Table 13-45 of the i.MX8M Mini Reference Manual, the min > > and max values for M and the frequency range for the VCO_out > > calculator were incorrect. This also appears to be the case for

Re: [PATCH 5/6] drm: bridge: samsung-dsim: Support non-burst mode

2023-04-16 Thread Marek Vasut
On 4/15/23 12:41, Adam Ford wrote: The high-speed clock is hard-coded to the burst-clock frequency specified in the device tree. However, when using devices like certain bridge chips without burst mode and varying resolutions and refresh rates, it may be necessary to set the high-speed clock dyn

Re: [PATCH 4/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-04-16 Thread Marek Vasut
On 4/15/23 12:41, Adam Ford wrote: NXP uses a lookup table to determine the various values for the PHY Timing based on the clock rate in their downstream kernel. Since the input clock can be variable, the phy settings need to be variable too. Add an additional variable to the driver data to ena

Re: [PATCH 3/6] drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically

2023-04-16 Thread Marek Vasut
On 4/15/23 12:41, Adam Ford wrote: Fetch the clock rate of "sclk_mipi" (or "pll_clk") instead of having an entry in the device tree for samsung,pll-clock-frequency. Signed-off-by: Adam Ford --- drivers/gpu/drm/bridge/samsung-dsim.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deleti

Re: [PATCH 2/6] drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp]

2023-04-16 Thread Marek Vasut
On 4/15/23 12:40, Adam Ford wrote: According to Table 13-45 of the i.MX8M Mini Reference Manual, the min and max values for M and the frequency range for the VCO_out calculator were incorrect. This also appears to be the case for the imx8mn and imx8mp. To fix this, make new variables to hold t

Re: [PATCH 1/6] drm: bridge: samsung-dsim: Support multi-lane calculations

2023-04-16 Thread Marek Vasut
On 4/15/23 12:40, Adam Ford wrote: If there is more than one lane, the HFP, HBP, and HSA is calculated in bytes/pixel, then they are divided amongst the different lanes with some additional overhead. This is necessary to achieve higher resolutions while keeping the pixel clocks lower as the numbe

Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-04-16 Thread Javier Martinez Canillas
Uwe Kleine-König writes: [...] >> >> This issue was already fixed by Dave in commit b24343eaceed ("Merge tag >> 'drm-misc-next-2023-03-16' of git://anongit.freedesktop.org/drm/drm-misc >> into drm-next"). > > FTR: s/b24343eaceed/c6265f5c2f50/ > Ups indeed. I pasted the wrong commit :) > Thank

Re: [PATCH] drm/imx/lcdc: Fix compilation with CONFIG_OF=n

2023-04-16 Thread Uwe Kleine-König
Hello Javier, On Sat, Apr 15, 2023 at 11:47:22PM +0200, Javier Martinez Canillas wrote: > Javier Martinez Canillas writes: > > > Uwe Kleine-König writes: > > > > Hello Uwe, > > > >> Hello, > >> > >> On Sat, Mar 18, 2023 at 11:10:27PM +0100, Uwe Kleine-König wrote: > >>> The driver needs the inc

[drm-tip:drm-tip 4/8] drivers/gpu/drm/msm/msm_drv.c:458:15: error: too many arguments to function 'drm_aperture_remove_framebuffers'

2023-04-16 Thread kernel test robot
ci/archive/20230416/202304162325.yltnxysy-...@intel.com/config) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote a

Re: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3

2023-04-16 Thread Tomer Tayar
On 12/04/2023 17:52, Christian König wrote: > /** > - * accel_debugfs_init() - Initialize debugfs for accel minor > + * accel_debugfs_init() - Register debugfs for accel minor > + * @dev: Pointer to the device instance. > + * > + * This function creates a root directory for the device in debugfs.

[PATCH] drm/bridge: it6505: Move a variable assignment behind a null pointer check in receive_timing_debugfs_show()

2023-04-16 Thread Markus Elfring
Date: Sun, 16 Apr 2023 17:30:46 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “receive_timing_debugfs_show”. Thus avoid the risk for undefined behaviour by moving the assignment for the variable “vid” be

Re: [PATCH v9 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check

2023-04-16 Thread kernel test robot
01 (https://download.01.org/0day-ci/archive/20230416/202304162307.7pcvuwlb-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.4-39-gce1a6720-dirty # https://github.com/intel-lab-lkp/li

[PATCH] dt-bindings: display: panel: add common definition of ports

2023-04-16 Thread Krzysztof Kozlowski
Few panel bindings for dual-link connections just type "ports: true", which does not enforce any type. Add common definition of ports, so the type will be fixed. Signed-off-by: Krzysztof Kozlowski --- Cc: Konrad Dybcio --- .../bindings/display/panel/panel-common.yaml | 16 +++

Re: [PATCH v2 1/5] dt-bindings: display: panel: nt36523: Allow 'port' instead of 'ports'

2023-04-16 Thread Krzysztof Kozlowski
On 13/04/2023 12:09, Konrad Dybcio wrote: > Using 'port' instead of 'ports' for single-DSI usecases allows for saving > a couple of DTS LoC, including a level of indentation. Allow that. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/panel/novatek,nt36523.yaml | 15 > ++

Re: [PATCH v2 2/5] dt-bindings: display: panel: nt36523: Add Lenovo J606F panel

2023-04-16 Thread Krzysztof Kozlowski
On 13/04/2023 12:09, Konrad Dybcio wrote: > Some Lenovo J606F tablets come with a 2K (2000x1200) 60Hz 11" 5:3 > video mode display. Document it and allow rotation while at it (Lenovo > mounted it upside down!). > > Reviewed-by: Linus Walleij > Signed-off-by: Konrad Dybcio Reviewed-by: Krzysztof

Re: [PATCH v3 10/11] iio: buffer-dmaengine: Support new DMABUF based userspace API

2023-04-16 Thread Jonathan Cameron
On Mon, 3 Apr 2023 17:49:54 +0200 Paul Cercueil wrote: > Use the functions provided by the buffer-dma core to implement the > DMABUF userspace API in the buffer-dmaengine IIO buffer implementation. > > Since we want to be able to transfer an arbitrary number of bytes and > not necesarily the fu

Re: [PATCH v3 09/11] iio: buffer-dma: Enable support for DMABUFs

2023-04-16 Thread Jonathan Cameron
On Mon, 3 Apr 2023 17:47:58 +0200 Paul Cercueil wrote: > Implement iio_dma_buffer_attach_dmabuf(), iio_dma_buffer_detach_dmabuf() > and iio_dma_buffer_transfer_dmabuf(), which can then be used by the IIO > DMA buffer implementations. > > Signed-off-by: Paul Cercueil Hi Paul, A few superficial

Re: [PATCH v3 07/11] iio: core: Add new DMABUF interface infrastructure

2023-04-16 Thread Jonathan Cameron
On Mon, 3 Apr 2023 17:47:56 +0200 Paul Cercueil wrote: > Add the necessary infrastructure to the IIO core to support a new > optional DMABUF based interface. > > With this new interface, DMABUF objects (externally created) can be > attached to a IIO buffer, and subsequently used for data transf

[PATCH] dma-buf/dma-resv.c: fix a typo

2023-04-16 Thread Sui Jingfeng
The dma_resv_wait_timeout() function return a value greater than zero on success. Signed-off-by: Sui Jingfeng --- drivers/dma-buf/dma-resv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c index 2a594b754af1..b6f71eb0086

Re: [PATCH v3 06/11] iio: buffer-dmaengine: Enable write support

2023-04-16 Thread Jonathan Cameron
On Mon, 3 Apr 2023 17:47:55 +0200 Paul Cercueil wrote: > Use the iio_dma_buffer_write() and iio_dma_buffer_space_available() > functions provided by the buffer-dma core, to enable write support in > the buffer-dmaengine code. > > Signed-off-by: Paul Cercueil > Reviewed-by: Alexandru Ardelean

Re: [PATCH v3 05/11] iio: buffer-dmaengine: Support specifying buffer direction

2023-04-16 Thread Jonathan Cameron
On Mon, 3 Apr 2023 17:47:54 +0200 Paul Cercueil wrote: > Update the devm_iio_dmaengine_buffer_setup() function to support > specifying the buffer direction. > > Update the iio_dmaengine_buffer_submit() function to handle input > buffers as well as output buffers. > > Signed-off-by: Paul Cercue

Re: [PATCH v3 04/11] iio: buffer-dma: Enable buffer write support

2023-04-16 Thread Jonathan Cameron
On Mon, 3 Apr 2023 17:47:53 +0200 Paul Cercueil wrote: > Adding write support to the buffer-dma code is easy - the write() > function basically needs to do the exact same thing as the read() > function: dequeue a block, read or write the data, enqueue the block > when entirely processed. > > Th

Re: [PATCH v3 03/11] iio: buffer-dma: Get rid of outgoing queue

2023-04-16 Thread Jonathan Cameron
On Mon, 3 Apr 2023 17:47:52 +0200 Paul Cercueil wrote: > The buffer-dma code was using two queues, incoming and outgoing, to > manage the state of the blocks in use. > > While this totally works, it adds some complexity to the code, > especially since the code only manages 2 blocks. It is much

Re: [PATCH 3/3] ARM: dts: sun8i: h3: beelink-x2: Disable DW-HDMI CEC

2023-04-16 Thread Laurent Pinchart
On Sun, Apr 16, 2023 at 03:31:56PM +0200, Jernej Škrabec wrote: > Dne nedelja, 16. april 2023 ob 15:25:31 CEST je Laurent Pinchart napisal(a): > > Hi Jernej, > > > > Thank you for the patch. > > > > On Sat, Apr 15, 2023 at 12:46:13PM +0200, Jernej Skrabec wrote: > > > Beelink X2 uses software imp

Re: [PATCH 3/3] ARM: dts: sun8i: h3: beelink-x2: Disable DW-HDMI CEC

2023-04-16 Thread Jernej Škrabec
Dne nedelja, 16. april 2023 ob 15:25:31 CEST je Laurent Pinchart napisal(a): > Hi Jernej, > > Thank you for the patch. > > On Sat, Apr 15, 2023 at 12:46:13PM +0200, Jernej Skrabec wrote: > > Beelink X2 uses software implementation of CEC even though DW-HDMI has > > working hardware implementation

Re: [PATCH 3/3] ARM: dts: sun8i: h3: beelink-x2: Disable DW-HDMI CEC

2023-04-16 Thread Laurent Pinchart
Hi Jernej, Thank you for the patch. On Sat, Apr 15, 2023 at 12:46:13PM +0200, Jernej Skrabec wrote: > Beelink X2 uses software implementation of CEC even though DW-HDMI has > working hardware implementation. Why ? The reason should be explained in the commit message. > Disable unused DW-HDMI CE

Re: [PATCH 1/2] fbdev/offb: Update expected device name

2023-04-16 Thread Salvatore Bonaccorso
Hi looping in as well the regressions list (hoping not doing any mistake with the regzbot commands): On Wed, Apr 12, 2023 at 11:55:08AM +0200, Cyril Brulebois wrote: > Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), > as spotted by Frédéric Bonnard, the historical "of-d

Re: [PATCH v3 01/13] firmware/sysfb: Fix EFI/VESA format selection

2023-04-16 Thread Linux regression tracking #update (Thorsten Leemhuis)
[TLDR: This mail in primarily relevant for Linux regression tracking. A change or fix related to the regression discussed in this thread was posted or applied, but it did not use a Link: tag to point to the report, as Linus and the documentation call for. Things happen, no worries -- but now the re

[PATCH v6 1/3] drm/virtio: Refactor and optimize job submission code path

2023-04-16 Thread Dmitry Osipenko
Move virtio_gpu_execbuffer_ioctl() into separate virtgpu_submit.c file, refactoring and optimizing the code along the way to ease addition of new features to the ioctl. The optimization is done by using optimal ordering of the job's submission steps, reducing code path from the start of the ioctl

[PATCH v6 3/3] drm/virtio: Support sync objects

2023-04-16 Thread Dmitry Osipenko
Add sync object DRM UAPI support to VirtIO-GPU driver. Sync objects support is needed by native context VirtIO-GPU Mesa drivers, it also will be used by Venus and Virgl contexts. Reviewed-by; Emil Velikov Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/virtio/virtgpu_drv.c| 3 +- drive

[PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-04-16 Thread Dmitry Osipenko
We have multiple Vulkan context types that are awaiting for the addition of the sync object DRM UAPI support to the VirtIO-GPU kernel driver: 1. Venus context 2. Native contexts (virtio-freedreno, virtio-intel, virtio-amdgpu) Mesa core supports DRM sync object UAPI, providing Vulkan drivers wit

[PATCH v6 2/3] drm/virtio: Wait for each dma-fence of in-fence array individually

2023-04-16 Thread Dmitry Osipenko
Use dma-fence-unwrap API for waiting each dma-fence of the in-fence array individually. Sync file's in-fence array always has a non-matching fence context ID, which doesn't allow to skip waiting of fences with a matching context ID in a case of a merged sync file fence. Suggested-by: Rob Clark Re

[PATCH 4/4] accel/habanalabs: fix bug in free scratchpad memory

2023-04-16 Thread Oded Gabbay
From: Moti Haimovski This commit fixes a bug in Gaudi2 when freeing the scratchpad memory in case software init fails. Signed-off-by: Moti Haimovski Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi2/gaudi2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 d

[PATCH 2/4] accel/habanalabs: allow user to modify EDMA RL register

2023-04-16 Thread Oded Gabbay
From: Rakesh Ughreja EDMA transpose workload requires to signal for every activation. User FW sends all the dummy signals to RD_LBW_RATE_LIM_CFG, to save lbw bandwidth. We need the user to be able to access that register to configure it. Signed-off-by: Rakesh Ughreja Reviewed-by: Oded Gabbay S

[PATCH 3/4] accel/habanalabs: remove commented code that won't be used

2023-04-16 Thread Oded Gabbay
From: Koby Elbaz Once it was decided that these security settings are to be done by FW rather than by the driver, there's no reason to keep them in the code. Signed-off-by: Koby Elbaz Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/accel/habanalabs/gaudi2/gaudi2_security.c |

[PATCH 1/4] accel/habanalabs: ignore false positive razwi

2023-04-16 Thread Oded Gabbay
From: Tal Cohen In Gaudi2 asic, PSOC RAZWI may cause in HBW or LBW. The address that caused the error is read from HW register and printed by the Driver. There are cases where the Driver receives an indication on PSOC RAZWI error but the address value is zero. In that case, the indication is a fa

Re: [PATCH 3/3] MAINTAINERS: Add myself as Samsung S6D7AA0 panel driver maintainer

2023-04-16 Thread Krzysztof Kozlowski
On 16/04/2023 12:01, Artur Weber wrote: > Signed-off-by: Artur Weber Missing commit msg. Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: panel: Add Samsung S6D7AA0 LCD controller bindings

2023-04-16 Thread Krzysztof Kozlowski
On 16/04/2023 12:01, Artur Weber wrote: > Signed-off-by: Artur Weber Missing commit msg. Subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. > --- > .../display/panel/samsung,s6d7aa0.yaml| 51 +++ > 1 fi

[PATCH 9/9] drm/nouveau/therm: Move an assignment statement behind a null pointer check in two functions

2023-04-16 Thread Markus Elfring
Date: Sun, 16 Apr 2023 10:50:12 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the functions “nvkm_fanpwm_create” and “nvkm_fantog_create”. Thus avoid the risk for undefined behaviour by moving the assignment for the

[PATCH 8/9] drm/nouveau/pci: Move an expression into a function call parameter in nvkm_pcie_set_link()

2023-04-16 Thread Markus Elfring
Date: Sun, 16 Apr 2023 08:45:31 +0200 The variable “pbus” was read only once in the implementation of the function “nvkm_pcie_set_link”. Thus move the usage of an expression into a parameter for a function call. Signed-off-by: Markus Elfring --- drivers/gpu/drm/nouveau/nvkm/subdev/pci/pcie.c |

[PATCH 7/9] drm/nouveau/pci: Move a variable assignment behind condition checks in nvkm_pcie_set_link()

2023-04-16 Thread Markus Elfring
Date: Sun, 16 Apr 2023 08:18:40 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “nvkm_pcie_set_link”. Thus avoid the risk for undefined behaviour by moving the assignment for the variable “subdev” behind s

[PATCH 6/9] drm/nouveau/clk: Move a variable assignment behind a null pointer check in nvkm_pstate_new()

2023-04-16 Thread Markus Elfring
Date: Sun, 16 Apr 2023 07:45:54 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “nvkm_pstate_new”. Thus avoid the risk for undefined behaviour by moving the assignment for the variable “cstate” behind the

[PATCH 5/9] drm/nouveau/bios/power_budget: Move an expression into a macro call parameter in nvbios_power_budget_header()

2023-04-16 Thread Markus Elfring
Date: Sat, 15 Apr 2023 22:30:30 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “nvbios_power_budget_header”. Thus avoid the risk for undefined behaviour by moving the usage of an expression into a paramet

[PATCH 4/9] drm/nouveau/debugfs: Replace five seq_printf() calls by seq_puts() in nouveau_debugfs_pstate_get()

2023-04-16 Thread Markus Elfring
Date: Sat, 15 Apr 2023 22:02:31 +0200 Five strings which did not contain a data format specification should be put into a sequence. Thus use the corresponding function “seq_puts”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/nouvea

[PATCH 3/9] drm/nouveau/debugfs: Use seq_putc() in nouveau_debugfs_pstate_get()

2023-04-16 Thread Markus Elfring
Date: Sat, 15 Apr 2023 21:48:47 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function “seq_putc”. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/nouveau/nouveau_debugfs.c | 2 +- 1 f

Re: [PATCH v2] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-16 Thread Sui Jingfeng
Hi, On 2023/4/16 15:57, Daniel Vetter wrote: On Fri, Apr 14, 2023 at 06:58:53PM +0800, Sui Jingfeng wrote: Hi, On 2023/4/14 03:16, Thomas Zimmermann wrote: Hi, thanks for the patch. This is effectively a revert of commit 8fbc9af55de0 ("drm/fbdev-generic: Set screen size to size of GEM buffer

[PATCH 2/9] drm/nouveau/debugfs: Move a variable assignment behind a null pointer check in nouveau_debugfs_pstate_get()

2023-04-16 Thread Markus Elfring
Date: Sat, 15 Apr 2023 21:24:43 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “nouveau_debugfs_pstate_get”. Thus avoid the risk for undefined behaviour by moving the assignment for the variable “ctrl” be

[PATCH 1/9] drm/nouveau/debugfs: Move an expression into a function call parameter in nouveau_debugfs_pstate_set()

2023-04-16 Thread Markus Elfring
Date: Sat, 15 Apr 2023 21:06:06 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “nouveau_debugfs_pstate_set”. Thus avoid the risk for undefined behaviour by moving the usage of an expression into a paramet

[PATCH 0/9] GPU-DRM-nouveau: Adjustments for seven function implementations

2023-04-16 Thread Markus Elfring
Date: Sun, 16 Apr 2023 11:22:23 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (9): debugfs: Move an expression into a function call parameter in nouveau_debugfs_pstate_set() debugfs: Move a variable assignment behind a null point

Re: [PATCH] accel/habanalabs: remove variable gaudi_irq_name

2023-04-16 Thread Oded Gabbay
On Tue, Apr 11, 2023 at 5:09 PM Tom Rix wrote: > > gcc with W=1 reports > drivers/accel/habanalabs/gaudi/gaudi.c:117:19: error: > ‘gaudi_irq_name’ defined but not used [-Werror=unused-const-variable=] > 117 | static const char > gaudi_irq_name[GAUDI_MSI_ENTRIES][GAUDI_MAX_STRING_LEN] = { >

[PING PATCH] drm/pl111: fix drm and dev leak when irq request failed.

2023-04-16 Thread Gencen Gan
Smatch reports: pl111_amba_probe() warn: missing unwind goto? Code segment for dev_put is: dev_put: drm_dev_put(drm); of_reserved_mem_device_release(dev); When err happened, jumping to dev_put will release drm and dev resources allocated or initiali

Re: linux-next: manual merge of the drm-misc tree with the mm-stable tree

2023-04-16 Thread Daniel Vetter
On Fri, Apr 14, 2023 at 01:59:12PM +0100, broo...@kernel.org wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/ttm/ttm_pool.c > > between commit: > > 23baf831a32c0 ("mm, treewide: redefine MAX_ORDER sanely") > > from the mm-stable tre

Re: [PATCH v2] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-16 Thread Daniel Vetter
On Fri, Apr 14, 2023 at 06:58:53PM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/4/14 03:16, Thomas Zimmermann wrote: > > Hi, > > > > thanks for the patch. This is effectively a revert of commit > > 8fbc9af55de0 ("drm/fbdev-generic: Set screen size to size of GEM > > buffer"). Please add a Fixes t

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-16 Thread Daniel Vetter
On Fri, Apr 14, 2023 at 07:30:53PM +0800, Sui Jingfeng wrote: > Hi, > > On 2023/4/14 15:56, Daniel Vetter wrote: > > On Fri, 14 Apr 2023 at 09:34, Thomas Zimmermann wrote: > > > Hi > > > > > > Am 14.04.23 um 07:36 schrieb Daniel Vetter: > > > > On Fri, 14 Apr 2023 at 06:24, Sui Jingfeng <1533027

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-16 Thread Daniel Vetter
On Fri, Apr 14, 2023 at 06:40:27AM -0700, Rob Clark wrote: > On Fri, Apr 14, 2023 at 1:57 AM Tvrtko Ursulin > wrote: > > > > > > On 13/04/2023 21:05, Daniel Vetter wrote: > > > On Thu, Apr 13, 2023 at 05:40:21PM +0100, Tvrtko Ursulin wrote: > > >> > > >> On 13/04/2023 14:27, Daniel Vetter wrote: >

Re: [Intel-gfx] [PATCH v2] drm/i915: avoid flush_scheduled_work() usage

2023-04-16 Thread Daniel Vetter
On Fri, Apr 14, 2023 at 07:52:12PM +0900, Tetsuo Handa wrote: > On 2023/04/14 19:13, Jani Nikula wrote: > > On Fri, 14 Apr 2023, Tetsuo Handa > > wrote: > >> On 2023/03/15 19:47, Luca Coelho wrote: > >>> On Tue, 2023-03-14 at 20:21 +0900, Tetsuo Handa wrote: > Like commit c4f135d643823a86 ("