Re: [PATCH] misc: sram: Add dma-heap-export reserved SRAM area type

2023-04-13 Thread Christian Gmeiner
Hi Andrew Am Di., 4. Apr. 2023 um 17:02 Uhr schrieb Christian Gmeiner : > > > > Hi Andrew > > > > > >> > > >> > > >> Okay, will split for v2. > > >> > > >> > > > > > > Was there a follow-up v2 of this patchset? AFAICT this series did not > > > make it into the mainline kernel. > > > Do you have an

Re: [PATCH 01/27] dt-bindings: pwm: Add compatible for MediaTek MT6795

2023-04-13 Thread Uwe Kleine-König
Hello, On Wed, Apr 12, 2023 at 01:27:13PM +0200, AngeloGioacchino Del Regno wrote: > Add a compatible string for MediaTek Helio X10 MT6795's display PWM > block: this is the same as MT8173. > > Signed-off-by: AngeloGioacchino Del Regno > Acked-by: Uwe Kleine-König I assume this patch will go

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Daniel Vetter
On Fri, 14 Apr 2023 at 06:24, Sui Jingfeng <15330273...@189.cn> wrote: > > Hi, > > On 2023/4/14 04:01, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 09:20:23PM +0200, Thomas Zimmermann wrote: > >> Hi > >> > >> Am 13.04.23 um 20:56 schrieb Daniel Vetter: > >> [...] > >>> This should switch the ex

RE: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Lin, Wayne
[Public] Hi Jeff, Thanks. I might need more information to understand why we can't retrieve the drm atomic state. Also , "Failed to create MST payload for port" indicates error while configuring DPCD payload ID table. Could you help to provide log with KMS + ATOMIC + DP debug on please? Thanks in

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Sui Jingfeng
Hi, On 2023/4/14 04:01, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 09:20:23PM +0200, Thomas Zimmermann wrote: Hi Am 13.04.23 um 20:56 schrieb Daniel Vetter: [...] This should switch the existing code over to using drm_framebuffer instead of fbdev: diff --git a/drivers/gpu/drm/drm_fb_helpe

[Bug 217278] ast 0000:03:00.0: PM: **** DPM device timeout **** during S4 resuming

2023-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217278 --- Comment #9 from wendy.w...@intel.com --- Thanks Thorsten for your information, I sent email and got response. Jammy Huang gave me the patch and ast driver rpm package, we confirmed that it can unblock the kernel panic during S4 entry. -- Yo

[Bug 217278] ast 0000:03:00.0: PM: **** DPM device timeout **** during S4 resuming

2023-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=217278 --- Comment #8 from wendy.w...@intel.com --- Created attachment 304133 --> https://bugzilla.kernel.org/attachment.cgi?id=304133&action=edit 0001-drm-ast-Fix-long-timeout-which-could-lead-to-panic.patch_v6.3-rc5 -- You may reply to this email t

Re: [PATCH] drm/ast: Fix long time waiting on s3/s4 resume

2023-04-13 Thread kernel test robot
Hi Jammy, kernel test robot noticed the following build errors: [auto build test ERROR on e62252bc55b6d4eddc6c2bdbf95a448180d6a08d] url: https://github.com/intel-lab-lkp/linux/commits/Jammy-Huang/drm-ast-Fix-long-time-waiting-on-s3-s4-resume/20230414-091312 base: e62252bc55b6d4eddc6c2bdbf9

[PATCH] drm/ast: Fix long time waiting on s3/s4 resume

2023-04-13 Thread Jammy Huang
In resume, DP's launch function, ast_dp_launch, could wait at most 30 seconds before timeout to check if DP is enabled. To avoid this problem, we only check if DP enable or not at driver probe. Link: https://bugzilla.kernel.org/show_bug.cgi?id=217278 Signed-off-by: Jammy Huang --- drivers/gpu/d

Re: [PATCH v15 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support

2023-04-13 Thread Stephen Boyd
Quoting Pin-yen Lin (2023-04-13 02:50:44) > Hi Stephen, > > On Wed, Apr 12, 2023 at 10:38 AM Stephen Boyd wrote: > > > > Quoting Pin-yen Lin (2023-03-31 02:11:39) > > > diff --git > > > a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > > > b/Documentation/devicetree/bind

Re: [PULL] drm-fixes for 6.3-rc7

2023-04-13 Thread pr-tracker-bot
The pull request you sent on Thu, 13 Apr 2023 21:51:38 +0200: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2023-04-13 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f1be7b6c165f0d451c3ea2062f506bf5f130bd5e Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH v3 00/65] clk: Make determine_rate mandatory for muxes

2023-04-13 Thread Stephen Boyd
Quoting Maxime Ripard (2023-04-04 03:10:50) > Hi, > > This is a follow-up to a previous series that was printing a warning > when a mux has a set_parent implementation but is missing > determine_rate(). > > The rationale is that set_parent() is very likely to be useful when > changing the rate, b

Re: [PATCH 2/2] drm/nouveau: constify pointers to hwmon_channel_info

2023-04-13 Thread Lyude Paul
Reviewed-by: Lyude Paul On Fri, 2023-04-07 at 17:00 +0200, Krzysztof Kozlowski wrote: > Statically allocated array of pointed to hwmon_channel_info can be made > const for safety. > > Signed-off-by: Krzysztof Kozlowski > > --- > > This depends on hwmon core patch: > https://lore.kernel.org/al

RE: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at BO creation

2023-04-13 Thread Yang, Fei
> Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user to set cache at BO > creation > > On 2023-04-05 13:26:43, Jordan Justen wrote: >> On 2023-04-05 00:45:24, Lionel Landwerlin wrote: >>> On 04/04/2023 19:04, Yang, Fei wrote: > Subject: Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow user t

[Bug 204241] amdgpu fails to resume from suspend

2023-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204241 TheRinger (tyrell.rutle...@icloud.com) changed: What|Removed |Added CC||tyrell.rutle...@i

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 05:40:21PM +0100, Tvrtko Ursulin wrote: > > On 13/04/2023 14:27, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > > > > > > On 12/04/2023 20:18, Daniel Vetter wrote: > > > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 09:20:23PM +0200, Thomas Zimmermann wrote: > Hi > > Am 13.04.23 um 20:56 schrieb Daniel Vetter: > [...] > > > > This should switch the existing code over to using drm_framebuffer instead > > of fbdev: > > > > > > diff --git a/drivers/gpu/drm/drm_fb_helper.c > > b/driver

[PULL] drm-fixes for 6.3-rc7

2023-04-13 Thread Daniel Vetter
Hi Linus, People seem back, still not much. -Daniel drm-fixes-2023-04-13: drm-fixes for -rc7 - two fbcon regressions - amdgpu: dp mst, smu13 - i915: dual link dsi for tgl+ - armada, nouveau, drm/sched, fbmem The following changes since commit 09a9639e56c01c7a00d6c0ca63f4c7c41abe075d: Linux 6

[PATCH] video: au1100fb: Move a variable assignment behind a null pointer check in au1100fb_setmode()

2023-04-13 Thread Markus Elfring
Date: Thu, 13 Apr 2023 21:35:36 +0200 The address of a data structure member was determined before a corresponding null pointer check in the implementation of the function “au1100fb_setmode”. Thus avoid the risk for undefined behaviour by moving the assignment for the variable “info” behind the n

[PATCH] video: fbdev: mmp: Fix deferred clk handling in mmphw_probe()

2023-04-13 Thread Christophe JAILLET
When dev_err_probe() is called, 'ret' holds the value of the previous successful devm_request_irq() call. 'ret' should be assigned with a meaningful value before being used in dev_err_probe(). While at it, use and return "PTR_ERR(ctrl->clk)" instead of a hard-coded "-ENOENT" so that -EPROBE_DEFER

Re: [RFC PATCH 0/2] drm/mgag200: Use 24bit format in VRAM

2023-04-13 Thread Thomas Zimmermann
Hi Am 12.04.23 um 15:39 schrieb Jocelyn Falempe: The bandwidth between system memory and VRAM is very limited on G200. So when using a 32bit framebuffer on system memory, convert it to 24bit when copying the frame to the VRAM, this allows to go 33% faster. Converting the format on the fly is neg

Re: [PULL] drm-misc-fixes

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 08:42:33PM +0200, Thomas Zimmermann wrote: > Hi Dave and Daniel, > > this is the PR for drm-misc-fixes for this week. > > Best regards > Thomas > > drm-misc-fixes-2023-04-13: > Short summary of fixes pull: > > * armada: Fix double free > * fb: Clear FB_ACTIVATE_KD_TEXT

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Thomas Zimmermann
Hi Am 13.04.23 um 20:56 schrieb Daniel Vetter: [...] This should switch the existing code over to using drm_framebuffer instead of fbdev: diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index ef4eb8b12766..99ca69dd432f 100644 --- a/drivers/gpu/drm/drm_fb_helper.

Re: [PATCH v2] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-13 Thread Thomas Zimmermann
Hi, thanks for the patch. This is effectively a revert of commit 8fbc9af55de0 ("drm/fbdev-generic: Set screen size to size of GEM buffer"). Please add a Fixes tag. Am 13.04.23 um 20:06 schrieb Sui Jingfeng: From: Sui Jingfeng The crazy fbdev test of IGT may write after EOF, which lead to o

Re: [PATCH] drm/bridge: ti-sn65dsi86: Implement wait_hpd_asserted

2023-04-13 Thread Doug Anderson
Hi, On Wed, Apr 12, 2023 at 9:19 PM Nikita Travkin wrote: > > Doug Anderson писал(а) 13.04.2023 01:22: > > Hi, > > > > On Sat, Apr 8, 2023 at 1:20 AM Nikita Travkin wrote: > >> > >> This bridge doesn't actually implement HPD due to it being way too slow > >> but instead expects the panel driver

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Daniel Vetter
On Fri, Apr 14, 2023 at 01:00:07AM +0800, Sui Jingfeng wrote: > > On 2023/4/13 23:56, Daniel Vetter wrote: > > On Thu, 13 Apr 2023 at 17:35, Sui Jingfeng <15330273...@189.cn> wrote: > > > Hi, > > > > > > On 2023/4/13 01:44, Daniel Vetter wrote: > > > > On Thu, Apr 13, 2023 at 01:13:37AM +0800, Su

Re: [PATCH v10 00/23] drm/i915/vm_bind: Add VM_BIND functionality

2023-04-13 Thread Niranjana Vishwanathapura
On Tue, Jan 17, 2023 at 11:15:46PM -0800, Niranjana Vishwanathapura wrote: DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physica

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-13 Thread Nathan Chancellor
ing tree to minimise any particularly complex conflicts. This resolution is not quite right on next-20230412 and next-20230413, as the drm tree's rename was not taken into account on the conflicting line. In other words, I need this diff for everything to work properly. diff --git a/driver

Re: [PULL] drm-intel-next-fixes

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 03:12:19PM +0300, Joonas Lahtinen wrote: > Hi Dave & Daniel, > > Just one Cc:stable fix for indirect sampler state this week on > drm-intel-next-fixes. > > Regards, Joonas > > *** > > drm-intel-next-fixes-2023-04-13: > > Short summary of fixes pull (less than what git s

[PULL] drm-misc-fixes

2023-04-13 Thread Thomas Zimmermann
Hi Dave and Daniel, this is the PR for drm-misc-fixes for this week. Best regards Thomas drm-misc-fixes-2023-04-13: Short summary of fixes pull: * armada: Fix double free * fb: Clear FB_ACTIVATE_KD_TEXT in ioctl * nouveau: Add missing callbacks * scheduler: Fix use-after-free error The foll

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 9:40 AM Tvrtko Ursulin wrote: > > > On 13/04/2023 14:27, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > >> > >> On 12/04/2023 20:18, Daniel Vetter wrote: > >>> On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > On W

[PATCH v2] drm/fbdev-generic: prohibit potential out-of-bounds access

2023-04-13 Thread Sui Jingfeng
From: Sui Jingfeng The crazy fbdev test of IGT may write after EOF, which lead to out-of-bound access for the drm drivers using fbdev-generic. For example, run fbdev test on a x86-64+ast2400 platform with 1680x1050 resolution will cause the linux kernel hang with following call trace: Oops: 00

Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated

2023-04-13 Thread Javier Martinez Canillas
"Pierre Asselin" writes: >> diff --git a/drivers/firmware/sysfb_simplefb.c >> b/drivers/firmware/sysfb_simplefb.c >> index 82c64cb9f531..0ab8c542b1f5 100644 >> --- a/drivers/firmware/sysfb_simplefb.c >> +++ b/drivers/firmware/sysfb_simplefb.c >> @@ -55,14 +55,10 @@ __init bool sysfb_parse_mode(co

RE: [PATCH v4 08/12] drm/display/dsc: add YCbCr 4:2:2 and 4:2:0 RC parameters

2023-04-13 Thread Kandpal, Suraj
Hi, > Include RC parameters for YCbCr 4:2:2 and 4:2:0 configurations. > Looks Good to me Reviewed-by: Suraj Kandpal > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/display/drm_dsc_helper.c | 438 > +++ > include/drm/display/drm_dsc_helper.h | 2 + > 2 files

Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated

2023-04-13 Thread Pierre Asselin
> diff --git a/drivers/firmware/sysfb_simplefb.c > b/drivers/firmware/sysfb_simplefb.c > index 82c64cb9f531..0ab8c542b1f5 100644 > --- a/drivers/firmware/sysfb_simplefb.c > +++ b/drivers/firmware/sysfb_simplefb.c > @@ -55,14 +55,10 @@ __init bool sysfb_parse_mode(const struct screen_info > *si, >

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Sui Jingfeng
On 2023/4/13 23:56, Daniel Vetter wrote: On Thu, 13 Apr 2023 at 17:35, Sui Jingfeng <15330273...@189.cn> wrote: Hi, On 2023/4/13 01:44, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 01:13:37AM +0800, Sui Jingfeng wrote: Hi, On 2023/4/11 22:53, Daniel Vetter wrote: On Sun, Apr 09, 2023 at 0

[PATCH v2 7/7] drm/i915: Do state check for color management changes

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä In order to validate LUT programming more thoroughly let's do a state check for all color management updates as well. Not sure we really want this outside CI. It is rather heavy and color management updates could become rather common with all the HDR/etc. stuff happening. May

[PATCH v2 6/7] drm/i915: No 10bit gamma on desktop gen3 parts

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä Apparently desktop gen3 parts don't support the 10bit gamma mode at all. Stop claiming otherwise. As is the case with pipe A on gen3 mobile parts, the PIPECONF gamma mode bit can be set but it has no effect on the output. PNV seems to be the only slight exception, but genera

[PATCH v2 5/7] drm/i915: Implement CTM property support for VLV

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä VLV has a so called "wide gamut color correction" unit (WGC). What it is is a 3x3 matrix similar to the later CHV CGM CSC, which less precisions/range. In fact CHV also has the WGC but using it there doesn't reall make sense when you have the superior CGM CSC around. Hook up

[PATCH v2 4/7] drm/i915: Always enable CGM CSC on CHV

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä On CHV toggling the CGM CSC on/off while the pipe is running leads to underruns. Looks like we'd have to do the toggling strictly inside the start_of_vblank-frame_start window to avoid this, but that window is less than a scanline so there's no way we can guarantee hitting it.

[PATCH v2 2/7] drm/i915: Expose crtc CTM property on ilk/snb

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä The ilk/snb code is internally fully capable of handling the CTM property, so expose it. Note that we still choose not to expose DEGAMMA_LUT though. The hardware is capable if degamma or gamma, but not both similtanously due to lack of the split gamma mode. Exposing both LUTs

[PATCH v2 3/7] drm/i915: Fix CHV CGM CSC coefficient sign handling

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä The CHV CGM CSC coefficients are in s4.12 two's complement format. Fix the CTM->CGM conversion to handle that correctly instead of pretending that the hw coefficients are also in some sign-magnitude format. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel

[PATCH v2 1/7] drm/uapi: Document CTM matrix better

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä Document in which order the CTM matrix elements are stored. Signed-off-by: Ville Syrjälä --- include/uapi/drm/drm_mode.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 46becedf5b2f..43691058d28f 10064

[PATCH v2 0/7] drm/i915: CTM stuff mostly

2023-04-13 Thread Ville Syrjala
From: Ville Syrjälä Mostly some CTM stuff: - document the uapi better - fix CHV CSC negative coefficients - expose CTM on ilk/snb/vlv - a bonus gamma patch for gen3 - cure CGM CSC underruns on CHV (new in v2) Test-with: 20230411161555.10001-1-ville.syrj...@linux.intel.com Ville Syrjälä (7): d

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Alex Deucher
On Wed, Apr 12, 2023 at 10:42 AM Tvrtko Ursulin wrote: > > > On 11/04/2023 23:56, Rob Clark wrote: > > From: Rob Clark > > > > Add support to dump GEM stats to fdinfo. > > > > v2: Fix typos, change size units to match docs, use div_u64 > > v3: Do it in core > > > > Signed-off-by: Rob Clark > > R

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 14:27, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: On 12/04/2023 20:18, Daniel Vetter wrote: On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: On Wed, Apr 12, 2023 at 10:

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Matt Roper
On Thu, Apr 13, 2023 at 06:19:16PM +0200, Andi Shyti wrote: > On Thu, Apr 13, 2023 at 09:03:29AM -0700, Ceraolo Spurio, Daniele wrote: > > > > > > On 4/13/2023 8:52 AM, Matt Roper wrote: > > > On Thu, Apr 13, 2023 at 03:56:21PM +0200, Andi Shyti wrote: > > > > Hi Tvrtko, > > > > > > > > (I forgo

Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated

2023-04-13 Thread Javier Martinez Canillas
"Pierre Asselin" writes: >> p...@panix.com (Pierre Asselin) writes: [...] >>> - bits_per_pixel = max(max3(si->red_size + si->red_pos, >>> + bits_per_pixel = max3(max3(si->red_size + si->red_pos, >>> si->green_size + si->green_pos, >>>

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Matt Roper
On Thu, Apr 13, 2023 at 09:03:29AM -0700, Ceraolo Spurio, Daniele wrote: > > > On 4/13/2023 8:52 AM, Matt Roper wrote: > > On Thu, Apr 13, 2023 at 03:56:21PM +0200, Andi Shyti wrote: > > > Hi Tvrtko, > > > > > > (I forgot to CC Daniele) > > > > > > On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrt

Re: [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Andi Shyti
Hi Paulo, > https://en.wikipedia.org/wiki/Ship_of_Theseus > > My original patch was written in 2018. Since then, the implementation > has been rebased and changed multiple times, the commit message has > been changed, the subject line has been changed, yet none of that is > documented in the patc

Re: [PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated

2023-04-13 Thread Pierre Asselin
> p...@panix.com (Pierre Asselin) writes: > >> After careful reading of the comments in f35cd3fa7729, would this >> be an appropriate fix ? Does it still address all the issues raised >> by Thomas ? >> >> (not tested) >> >> diff --git a/drivers/firmware/sysfb_simplefb.c >> b/drivers/firmware/sysfb

Re: [BUG?] INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 3 jiffies s: 309 root: 0x1/.

2023-04-13 Thread Paul E. McKenney
On Thu, Apr 13, 2023 at 04:32:32PM +0100, Rui Salvaterra wrote: > Hi, Paul, > > On Thu, 13 Apr 2023 at 15:43, Paul E. McKenney wrote: > > > > My guess would be that you have CONFIG_RCU_EXP_CPU_STALL_TIMEOUT set to > > some small non-zero number, for example, you might have set up a recent > > And

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Andi Shyti
On Thu, Apr 13, 2023 at 09:03:29AM -0700, Ceraolo Spurio, Daniele wrote: > > > On 4/13/2023 8:52 AM, Matt Roper wrote: > > On Thu, Apr 13, 2023 at 03:56:21PM +0200, Andi Shyti wrote: > > > Hi Tvrtko, > > > > > > (I forgot to CC Daniele) > > > > > > On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrt

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Ceraolo Spurio, Daniele
On 4/13/2023 8:52 AM, Matt Roper wrote: On Thu, Apr 13, 2023 at 03:56:21PM +0200, Andi Shyti wrote: Hi Tvrtko, (I forgot to CC Daniele) On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: On 13/04/2023 10:20, Andi Shyti wrote: From: Paulo Zanoni In multitile systems IRQ need

Re: [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Zanoni, Paulo R
On Thu, 2023-04-13 at 11:20 +0200, Andi Shyti wrote: > From: Paulo Zanoni Hi https://en.wikipedia.org/wiki/Ship_of_Theseus My original patch was written in 2018. Since then, the implementation has been rebased and changed multiple times, the commit message has been changed, the subject line has

[PATCH v2] drm/msm/dpu: always program dsc active bits

2023-04-13 Thread Kuogee Hsieh
In current code, the DSC active bits are written only if cfg->dsc is set. However, for displays which are hot-pluggable, there can be a use-case of disconnecting a DSC supported sink and connecting a non-DSC sink. For those cases we need to clear DSC active bits during tear down. Changes in V2: 1

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Daniel Vetter
On Thu, 13 Apr 2023 at 17:35, Sui Jingfeng <15330273...@189.cn> wrote: > > Hi, > > On 2023/4/13 01:44, Daniel Vetter wrote: > > On Thu, Apr 13, 2023 at 01:13:37AM +0800, Sui Jingfeng wrote: > >> Hi, > >> > >> On 2023/4/11 22:53, Daniel Vetter wrote: > >>> On Sun, Apr 09, 2023 at 09:21:10PM +0800, S

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Matt Roper
On Thu, Apr 13, 2023 at 03:56:21PM +0200, Andi Shyti wrote: > Hi Tvrtko, > > (I forgot to CC Daniele) > > On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: > > > > On 13/04/2023 10:20, Andi Shyti wrote: > > > From: Paulo Zanoni > > > > > > In multitile systems IRQ need to be rese

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 5:58 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 20:18, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > >> On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > >>> > >>> On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote: >

Re: [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Rob Clark
On Thu, Apr 13, 2023 at 6:07 AM Tvrtko Ursulin wrote: > > > On 12/04/2023 23:42, Rob Clark wrote: > > From: Rob Clark > > There is more do to here to remove my client->id fully (would now be > dead code) so maybe easiest if you drop this patch and I do it after you > land this and it propagates t

Re: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3

2023-04-13 Thread kernel test robot
ownload.01.org/0day-ci/archive/20230413/202304132344.9oz5dfji-...@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 9638da200e00bd069e6dd63604e14cbafede9324) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/m

Re: [PATCH] drm/fbdev-generic: fix potential out-of-bounds access

2023-04-13 Thread Sui Jingfeng
Hi, On 2023/4/13 01:44, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 01:13:37AM +0800, Sui Jingfeng wrote: Hi, On 2023/4/11 22:53, Daniel Vetter wrote: On Sun, Apr 09, 2023 at 09:21:10PM +0800, Sui Jingfeng wrote: From: Sui Jingfeng We should setting the screen buffer size according to the

Re: [PATCH] drm/rockchip: vop2: fix suspend/resume

2023-04-13 Thread Chris Morgan
On Thu, Apr 13, 2023 at 04:43:47PM +0200, Sascha Hauer wrote: > During a suspend/resume cycle the VO power domain will be disabled and > the VOP2 registers will reset to their default values. After that the > cached register values will be out of sync and the read/modify/write > operations we do on

[PATCH v2] radeon: avoid double free in ci_dpm_init()

2023-04-13 Thread Nikita Zhandarovich
Several calls to ci_dpm_fini() will attempt to free resources that either have been freed before or haven't been allocated yet. This may lead to undefined or dangerous behaviour. For instance, if r600_parse_extended_power_table() fails, it might call r600_free_extended_power_table() as will ci_dpm

Re: [BUG?] INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 0-.... } 3 jiffies s: 309 root: 0x1/.

2023-04-13 Thread Paul E. McKenney
On Thu, Apr 13, 2023 at 08:30:02AM +0100, Rui Salvaterra wrote: > Hi again, everyone. > > So, while preparing to file the bug report with the requested > information, I got a trace completely unrelated to DRM (on a swapon > call, it seems). > > [4.868340] rcu: INFO: rcu_sched detected expedit

[PATCH] drm/rockchip: vop2: fix suspend/resume

2023-04-13 Thread Sascha Hauer
During a suspend/resume cycle the VO power domain will be disabled and the VOP2 registers will reset to their default values. After that the cached register values will be out of sync and the read/modify/write operations we do on the window registers will result in bogus values written. Fix this by

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 14:56, Andi Shyti wrote: Hi Tvrtko, (I forgot to CC Daniele) On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: On 13/04/2023 10:20, Andi Shyti wrote: From: Paulo Zanoni In multitile systems IRQ need to be reset and enabled per GT. Although in MTL the GUnit mi

Re: [PATCH 0/7] Enable YCbCr420 format for VDSC

2023-04-13 Thread Dmitry Baryshkov
Hi Suraj, On 07/04/2023 06:11, Kandpal, Suraj wrote: Hi Dmitry -Original Message- From: Dmitry Baryshkov Sent: Friday, April 7, 2023 8:28 AM To: Kandpal, Suraj ; Jani Nikula ; dri-devel@lists.freedesktop.org; intel- g...@lists.freedesktop.org Cc: Nautiyal, Ankit K ; Shankar, Uma ; Ma

Re: [RFC PATCH v2 2/2] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-04-13 Thread Krzysztof Kozlowski
On 13/04/2023 12:34, Sarah Walker wrote: > Signed-off-by: Sarah Walker NAK, multiple problems. Missing commit msg. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Th

[PATCH v2] video/hdmi: minor fixes for *_infoframe_init functions

2023-04-13 Thread Nikita Zhandarovich
Multiple hdmi_*_infoframe_init() functions that initialize different types of hdmi infoframes only return default 0 value (contrary to their descriptions). Yet these functions are still checked against possible errors in case of failure. This patch removes redundant checks for errors in calls to f

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Andi Shyti
Hi Tvrtko, (I forgot to CC Daniele) On Thu, Apr 13, 2023 at 11:41:28AM +0100, Tvrtko Ursulin wrote: > > On 13/04/2023 10:20, Andi Shyti wrote: > > From: Paulo Zanoni > > > > In multitile systems IRQ need to be reset and enabled per GT. > > > > Although in MTL the GUnit misc interrupts registe

Re: [PATCH 3/5] drm/debugfs: remove dev->debugfs_list and debugfs_mutex v2

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 11:34:45AM +0200, Christian König wrote: > Am 12.04.23 um 17:11 schrieb Daniel Vetter: > > On Wed, Apr 12, 2023 at 04:52:04PM +0200, Christian König wrote: > > > The mutex was completely pointless in the first place since any > > > parallel adding of files to this list would

Re: [PATCH] drm/stm: ltdc: fix late dereference check

2023-04-13 Thread Yannick FERTRE
Hi Raphael, thanks for the patch. Reviewed-by: Yannick Fertre On 4/12/23 11:25, Raphael GALLAIS-POU wrote: Attention: Sender not authenticated -- In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a container_of() before the po

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 01:58:34PM +0100, Tvrtko Ursulin wrote: > > On 12/04/2023 20:18, Daniel Vetter wrote: > > On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: > > > On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: > > > > > > > > On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob C

Re: [PATCH RESEND v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-04-13 Thread Daniel Vetter
On Thu, 13 Apr 2023 at 11:46, Christian König wrote: > > Am 13.04.23 um 10:48 schrieb Daniel Vetter: > > On Wed, 12 Apr 2023 at 16:18, Christian König > > wrote: > >> Am 12.04.23 um 11:08 schrieb Daniel Vetter: > >>> On Tue, 11 Apr 2023 at 15:45, Daniel Vetter wrote: > On Tue, Apr 11, 2023

Re: [PULL] drm-intel-fixes

2023-04-13 Thread Daniel Vetter
On Thu, Apr 13, 2023 at 10:13:57AM +0300, Jani Nikula wrote: > > Hi Dave & Daniel - > > One DSI fix, stable material. > > drm-intel-fixes-2023-04-13: > drm/i915 fixes for v6.3-rc7: > - Fix dual link DSI for TGL+ > > BR, > Jani. > > The following changes since commit 09a9639e56c01c7a00d6c0ca63f

Re: [PATCH v4 4/6] drm/i915: Switch to fdinfo helper

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 23:42, Rob Clark wrote: From: Rob Clark There is more do to here to remove my client->id fully (would now be dead code) so maybe easiest if you drop this patch and I do it after you land this and it propagates to our branches? I'd like to avoid pain with conflicts if possibl

Re: [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 09:46, Daniel Vetter wrote: On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stat

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Alex Deucher
+ Wayne On Thu, Apr 13, 2023 at 8:31 AM Jani Nikula wrote: > > On Thu, 13 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to c

Re: [PATCH v3 6/7] drm: Add fdinfo memory stats

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 20:18, Daniel Vetter wrote: On Wed, Apr 12, 2023 at 11:42:07AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 11:17 AM Daniel Vetter wrote: On Wed, Apr 12, 2023 at 10:59:54AM -0700, Rob Clark wrote: On Wed, Apr 12, 2023 at 7:42 AM Tvrtko Ursulin wrote: On 11/04/2023 23:5

[PATCH 2/2] phy: mediatek: hdmi: mt8195: fix wrong pll calculus

2023-04-13 Thread Guillaume Ranquet
The clock rate calculus in mtk_hdmi_pll_calc() was wrong when it has been replaced by 'div_u64'. Fix the issue by multiplying the values in the denominator instead of dividing them. Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Signed-off-by: Guillaume Ranquet ---

[PATCH 1/2] phy: mediatek: hdmi: mt8195: fix uninitialized variable usage in pll_calc

2023-04-13 Thread Guillaume Ranquet
The ret variable in mtk_hdmi_pll_calc() was used unitialized as reported by the kernel test robot. Fix the issue by removing the variable altogether and testing out the return value of mtk_hdmi_pll_set_hw() Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") Reported-by: k

[PATCH 0/2] Fix mtk-hdmi-mt8195 unitialized variable usage and clock rate calculation

2023-04-13 Thread Guillaume Ranquet
x uninitialized variable usage in pll_calc phy: mediatek: hdmi: mt8195: fix wrong pll calculus drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) --- base-commit: 45810d486bb44bd60213d5f09a713df81b987972 change-id: 20230413-fixes-for-

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jeff Layton
On Thu, 2023-04-13 at 15:31 +0300, Jani Nikula wrote: > On Thu, 13 Apr 2023, Jeff Layton wrote: > > I've been experiencing some intermittent crashes down in the display > > driver code. The symptoms are ususally a line like this in dmesg: > > > > amdgpu :30:00.0: [drm] Failed to create MS

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 12:56, Tvrtko Ursulin wrote: On 12/04/2023 12:33, Andi Shyti wrote: Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize

Re: [RFC PATCH v2 0/2] Imagination Technologies PowerVR DRM driver

2023-04-13 Thread Jani Nikula
On Thu, 13 Apr 2023, Sarah Walker wrote: > The code in this patch, along with some of its history, can also be found > here: > https://gitlab.freedesktop.org/frankbinns/powervr/-/tree/powervr-next FYI patch 1/2 is likely so big that it gets dropped by the list. BR, Jani. -- Jani Nikula, Intel

Re: [PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jani Nikula
On Thu, 13 Apr 2023, Jeff Layton wrote: > I've been experiencing some intermittent crashes down in the display > driver code. The symptoms are ususally a line like this in dmesg: > > amdgpu :30:00.0: [drm] Failed to create MST payload for port > 6d3a3885: -5 > > ...followed by an

[PULL] drm-intel-next-fixes

2023-04-13 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one Cc:stable fix for indirect sampler state this week on drm-intel-next-fixes. Regards, Joonas *** drm-intel-next-fixes-2023-04-13: Short summary of fixes pull (less than what git shortlog provides): Just one Cc:stable fix for sampler indirect state in bindless heap.

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 12:33, Andi Shyti wrote: Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these requests fails, we may not realize it unless it happens to be the last request i

Re: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3

2023-04-13 Thread kernel test robot
3/20230412-235231 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230412145206.2483-3-christian.koenig%40amd.com patch subject: [PATCH 2/5] drm/debugfs: rework debugfs directory creation v3 config: arc-randconfig-r043-20230413 (https://downl

Re: [Intel-gfx] [PATCH v4 5/5] drm/i915/gt: Make sure that errors are propagated through request chains

2023-04-13 Thread Tvrtko Ursulin
On 12/04/2023 14:10, Rodrigo Vivi wrote: On Wed, Apr 12, 2023 at 12:56:26PM +0200, Andi Shyti wrote: Hi Rodrigo, Currently, when we perform operations such as clearing or copying large blocks of memory, we generate multiple requests that are executed in a chain. However, if one of these req

[PATCH] drm: make drm_dp_add_payload_part2 gracefully handle NULL state pointer

2023-04-13 Thread Jeff Layton
I've been experiencing some intermittent crashes down in the display driver code. The symptoms are ususally a line like this in dmesg: amdgpu :30:00.0: [drm] Failed to create MST payload for port 6d3a3885: -5 ...followed by an Oops due to a NULL pointer dereference. The real bug

[RFC PATCH v2 2/2] dt-bindings: gpu: Add Imagination Technologies PowerVR GPU

2023-04-13 Thread Sarah Walker
Signed-off-by: Sarah Walker --- .../devicetree/bindings/gpu/img,powervr.yaml | 105 ++ 1 file changed, 105 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpu/img,powervr.yaml diff --git a/Documentation/devicetree/bindings/gpu/img,powervr.yaml b/Documentatio

[RFC PATCH v2 0/2] Imagination Technologies PowerVR DRM driver

2023-04-13 Thread Sarah Walker
This patch adds the initial DRM driver for Imagination Technologies PowerVR GPUs, starting with those based on our Rogue architecture. It's worth pointing out that this is a new driver, written from the ground up, rather than a refactored version of our existing downstream driver (pvrsrvkm). This

Re: [Intel-gfx] [PATCH v2] drm/i915: Make IRQ reset and postinstall multi-gt aware

2023-04-13 Thread Tvrtko Ursulin
On 13/04/2023 10:20, Andi Shyti wrote: From: Paulo Zanoni In multitile systems IRQ need to be reset and enabled per GT. Although in MTL the GUnit misc interrupts register set are available only in GT-0, we need to loop through all the GT's in order to initialize the media engine which lies o

Re: [PATCH v4 3/6] drm/amdgpu: Switch to fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Signed-off-by: Rob Clark Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.c | 16 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_fdinfo.h | 2 +-

Re: [PATCH v4 1/6] drm: Add common fdinfo helper

2023-04-13 Thread Christian König
Am 13.04.23 um 10:46 schrieb Daniel Vetter: On Thu, Apr 13, 2023 at 10:07:11AM +0200, Christian König wrote: Am 13.04.23 um 00:42 schrieb Rob Clark: From: Rob Clark Handle a bit of the boiler-plate in a single case, and make it easier to add some core tracked stats. v2: Update drm-usage-stat

Re: [PATCH] Revert "accel/qaic: Add mhi_qaic_cntl"

2023-04-13 Thread Jacek Lawrynowicz
Hi, On 13.04.2023 10:49, Daniel Vetter wrote: > On Wed, Apr 12, 2023 at 04:05:42PM +0200, Stanislaw Gruszka wrote: >> On Wed, Apr 12, 2023 at 07:57:44AM -0600, Jeffrey Hugo wrote: >>> This reverts commit 566fc96198b4bb07ca6806386956669881225271. >>> >>> This exposes a userspace API that is still

Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests

2023-04-13 Thread Cong Liu
Hi Andi, thank you for your reminder, next time I will pay attention to my format, and when someone has already reviewed, add the Reviewed-by field Regards. On 2023/4/13 16:44, Andi Shyti wrote: On Thu, Apr 13, 2023 at 03:55:26PM +0800, Cong Liu wrote: This patch fixes memory leaks on error

[PATCH v2 3/5] drm/panel: nt36523: Add DCS backlight support

2023-04-13 Thread Konrad Dybcio
This chip supports controlling the backlight via DCS commands, on at least some panels. Add support for doing so. Note this may only concern the NT36523*W* variant. Nobody knows, really, there's no docs. Reviewed-by: Linus Walleij Reviewed-by: Jianhua Lu Signed-off-by: Konrad Dybcio --- drive

  1   2   >