[PATCH] drm/amdgpu: Use uncached ioremap() for LoongArch

2023-03-04 Thread Huacai Chen
LoongArch maintains cache coherency in hardware, but its WUC attribute (Weak-ordered UnCached, which is similar to WC) is out of the scope of cache coherency machanism. This means WUC can only used for write-only memory regions. So use uncached ioremap() for LoongArch in the amdgpu driver. Signed-

Re: [PATCH] drm/amd/display: Simplify same effect if/else blocks

2023-03-04 Thread Joe Perches
On Fri, 2023-03-03 at 15:35 -0500, Harry Wentland wrote: > Actually I was wrong. Too many similar-looking snippets in this > function made me look at the wrong thing. This change is fine and > Reviewed-by: Harry Wentland

Re: [PATCH] MAINTAINERS: Update the URI for MSM DRM bugs

2023-03-04 Thread Rob Clark
On Sat, Mar 4, 2023 at 3:27 PM Abhinav Kumar wrote: > > Update the URI for MSM DRM bugs for users to be able > to file bugs at a centralized location. > > Signed-off-by: Abhinav Kumar Acked-by: Rob Clark > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS

[PATCH] MAINTAINERS: Update the URI for MSM DRM bugs

2023-03-04 Thread Abhinav Kumar
Update the URI for MSM DRM bugs for users to be able to file bugs at a centralized location. Signed-off-by: Abhinav Kumar --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a47d963af3b8..504138e294ef 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -

[PATCH v1] drm/virtio: Fix handling CONFIG_DRM_VIRTIO_GPU_KMS option

2023-03-04 Thread Dmitry Osipenko
VirtIO-GPU got a new config option for disabling KMS. There were two problems left unnoticed during review when the new option was added: 1. The IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) check in the code was inverted, hence KMS was disabled when it should be enabled and vice versa. 2. The disabled K

Re: [PATCH 11/22] drm/meson: Use GEM DMA fbdev emulation

2023-03-04 Thread Martin Blumenstingl
On Wed, Mar 1, 2023 at 4:31 PM Thomas Zimmermann wrote: > > Use the fbdev emulation that is optimized for DMA helpers. Avoids > possible shadow buffering and makes the code simpler. > > Signed-off-by: Thomas Zimmermann Acked-by: Martin Blumenstingl

Re: [PATCH v2] drm/meson: fix 1px pink line on GXM when scaling video overlay

2023-03-04 Thread Martin Blumenstingl
On Fri, Mar 3, 2023 at 1:33 PM Christian Hewitt wrote: > > Playing media with a resolution smaller than the crtc size requires the > video overlay to be scaled for output and GXM boards display a 1px pink > line on the bottom of the scaled overlay. Comparing with the downstream > vendor driver rev

Re: [PATCH v6] drm/virtio: Add option to disable KMS support

2023-03-04 Thread Dmitry Osipenko
On 3/3/23 02:35, Rob Clark wrote: > @@ -223,12 +223,15 @@ int virtio_gpu_init(struct virtio_device *vdev, struct > drm_device *dev) > num_scanouts, &num_scanouts); > vgdev->num_scanouts = min_t(uint32_t, num_scanouts, > VIRTIO_GPU_MAX_S

Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'

2023-03-04 Thread Mark Brown
On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote: > Enable yamllint to check the prefered commenting style of requiring a > space after a comment character '#'. Fix the cases in the tree which > have a warning with this enabled. Most cases just need a space after the > '#'. A couple of c

Re: [PATCH] drm/etnaviv: fix reference leak when mmaping imported buffer

2023-03-04 Thread Dmitry Osipenko
On 2/28/23 19:55, Lucas Stach wrote: > drm_gem_prime_mmap() takes a reference on the GEM object, but before that > drm_gem_mmap_obj() already takes a reference, which will be leaked as only > one reference is dropped when the mapping is closed. Drop the extra > reference when dma_buf_mmap() succeed

Re: [PATCH v15 00/16] drm: Add Samsung MIPI DSIM bridge

2023-03-04 Thread Jagan Teki
Hi Marek, On Sat, Mar 4, 2023 at 3:56 AM Marek Szyprowski wrote: > > Hi Jagan, > > On 03.03.2023 15:51, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8

Re: Linux 6.2.1 hits a display driver bug (list_del corruption, ffff88811b4af298->next is NULL)

2023-03-04 Thread Ammar Faizi
On Fri, Mar 03, 2023 at 03:06:18PM +0700, Bagas Sanjaya wrote: > Can you please try v6.1? It's reproducible in v6.1.9. I finally can reliably reproduce it, it only happens when I start a VM with qemu. Specifically adding this device to the qemu instance: And that slo

Re: [PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-04 Thread Bryan O'Donoghue
On 04/03/2023 17:45, Bryan O'Donoghue wrote: On 04/03/2023 17:35, Konrad Dybcio wrote: you'll see no error. However if you just do this diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 0733c2f4f3798..829fbe05b5713 100644 --- a/arch/arm64/boot/dt

Re: [PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-04 Thread Bryan O'Donoghue
On 04/03/2023 17:35, Konrad Dybcio wrote: you'll see no error. However if you just do this diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi index 0733c2f4f3798..829fbe05b5713 100644 --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi +++ b/arch/arm64/boot/dts/q

Re: [PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-04 Thread Konrad Dybcio
On 4.03.2023 17:59, Bryan O'Donoghue wrote: > On 04/03/2023 15:55, Konrad Dybcio wrote: >> The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" >> alone. This however didn't quite work out and the property became >> undocumented instead of deprecated. Fix that. >> >> Fixes: 0c0

Re: [PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-04 Thread Bryan O'Donoghue
On 04/03/2023 15:55, Konrad Dybcio wrote: The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" alone. This however didn't quite work out and the property became undocumented instead of deprecated. Fix that. Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compat

[PATCH] drm/amd/display: change several dcn20 variables storage-class-specifier to static

2023-03-04 Thread Tom Rix
smatch reports these similar problems in dcn20 drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dsc.c:53:24: warning: symbol 'dcn20_dsc_funcs' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_dwb.c:304:25: warning: symbol 'dcn20_dwbc_funcs' was not

[PATCH v3 1/2] dt-bindings: display/msm: dsi-controller-main: Fix deprecated compatible

2023-03-04 Thread Konrad Dybcio
The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" alone. This however didn't quite work out and the property became undocumented instead of deprecated. Fix that. Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC") Signed

[PATCH v3 2/2] dt-bindings: display: msm: sm6115-mdss: Fix DSI compatible

2023-03-04 Thread Konrad Dybcio
Since the DSI autodetection is bound to work correctly on 6115 now, switch to using the correct per-SoC + generic fallback compatible combo. Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 8 +++- 1 file changed, 7 insertions(+), 1 deletio

[PATCH v3 0/2] Fix up Qualcomm DSI bindings

2023-03-04 Thread Konrad Dybcio
gs/display/msm/dsi-controller-main.yaml | 2 +- .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 8 +++- 2 files changed, 8 insertions(+), 2 deletions(-) --- base-commit: 9a33780f72f64c1cd151d84a9959f58a13b0c970 change-id: 20230304-topic-dsi_fixup-ecaf0bd3b767 Best regards, -- Konrad Dybcio

[PATCH] drm/amd/display: change several dcn201 variables storage-class-specifier to static

2023-03-04 Thread Tom Rix
smatch reports these similar problems in dcn201 drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn201/dcn201_clk_mgr.c:165:22: warning: symbol 'dcn201_funcs' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_resource.c:77:30: warning: symbol 'dcn201

Re: [PATCH v4 1/4] drm/msm/dpu: Move TE setup to prepare_for_kickoff()

2023-03-04 Thread Marijn Suijten
On 2023-03-01 13:42:55, Abhinav Kumar wrote: > >>> Then, for some patch hygiene, starting here: > >>> > Depends on: "Implement tearcheck support on INTF block" [3] > > Changes in V3: > - Added function prototypes > - Reordered function definitions to make change more legib