[PATCH v7 7/7] drm: Remove usage of deprecated DRM_DEBUG_KMS

2023-02-25 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_KMS is deprecated in favor of drm_dbg_kms(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 112 ++--- drivers/gpu/drm/drm_color_mgmt.c | 4 +- drivers/gpu/drm/drm_connector.c| 21 ++--- drivers/gpu/drm

[PATCH v7 3/7] drm: Remove usage of deprecated DRM_NOTE

2023-02-25 Thread Siddh Raman Pant
drm_print.h says DRM_NOTE is deprecated in favor of drm_notice(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_displayid.c | 2 +- drivers/gpu/drm/drm_kms_helper_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_displayid.c b/d

[PATCH v7 0/7] drm: Remove usage of deprecated DRM_* macros

2023-02-25 Thread Siddh Raman Pant
This patchset aims to remove usages of deprecated DRM_* macros from the files residing in drivers/gpu/drm root. In process, I found out that NULL as first argument of drm_dbg_* wasn't working, but it was listed as the alternative in deprecation comment, so I fixed that before removing usages of DR

[PATCH v7 6/7] drm: Remove usage of deprecated DRM_DEBUG_DRIVER

2023-02-25 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG_DRIVER is deprecated. Thus, use newer drm_dbg_driver(). Also fix the deprecation comment in drm_print.h which mentions drm_dbg() instead of drm_dbg_driver(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_mipi_dbi.c | 10 +- include/drm/drm_print.h

[PATCH v7 5/7] drm: Remove usage of deprecated DRM_DEBUG

2023-02-25 Thread Siddh Raman Pant
drm_print.h says DRM_DEBUG is deprecated in favor of drm_dbg_core(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_agpsupport.c | 4 +- drivers/gpu/drm/drm_bufs.c| 114 +++--- drivers/gpu/drm/drm_context.c | 14 ++-- drivers/gpu/drm/drm_dma.c

[PATCH v7 1/7] drm/print: Fix and add support for NULL as first argument in drm_* macros

2023-02-25 Thread Siddh Raman Pant
Comments say macros DRM_DEBUG_* are deprecated in favor of drm_dbg_*(NULL, ...), but they have broken support for it, as the macro will result in `(NULL) ? (NULL)->dev : NULL`. Thus, fix them by separating logic to get dev ptr in a new function, which will return the dev ptr if arg is not NULL. Us

[PATCH v7 2/7] drm: Remove usage of deprecated DRM_INFO

2023-02-25 Thread Siddh Raman Pant
drm_print.h says DRM_INFO is deprecated in favor of drm_info(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_client_modeset.c | 2 +- drivers/gpu/drm/drm_connector.c | 7 --- drivers/gpu/drm/drm_drv.c| 2 +- drivers/gpu/drm/drm_pci.c| 2 +- 4 files cha

[PATCH v7 4/7] drm: Remove usage of deprecated DRM_ERROR

2023-02-25 Thread Siddh Raman Pant
drm_print.h says DRM_ERROR is deprecated in favor of drm_err(). Signed-off-by: Siddh Raman Pant --- drivers/gpu/drm/drm_bridge.c | 8 drivers/gpu/drm/drm_bufs.c | 8 drivers/gpu/drm/drm_client_modeset.c | 4 ++-- drivers/gpu/drm/drm_context.c| 4 ++

Re: [PATCH v2 06/50] drm/msm/dpu: correct sm8550 scaler

2023-02-25 Thread Abhinav Kumar
On 2/25/2023 4:06 PM, Dmitry Baryshkov wrote: On 26/02/2023 01:27, Abhinav Kumar wrote: Hi Dmitry On 2/25/2023 3:06 PM, Dmitry Baryshkov wrote: On 24/02/2023 22:51, Abhinav Kumar wrote: On 2/13/2023 9:36 AM, neil.armstr...@linaro.org wrote: On 13/02/2023 12:16, Dmitry Baryshkov wrote:

Re: [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-25 Thread Abhinav Kumar
Hi Dmitry On 2/25/2023 7:23 AM, Dmitry Baryshkov wrote: On 25/02/2023 02:36, Abhinav Kumar wrote: On 2/24/2023 3:53 PM, Dmitry Baryshkov wrote: On Sat, 25 Feb 2023 at 00:26, Abhinav Kumar wrote: On 2/24/2023 1:36 PM, Dmitry Baryshkov wrote: 24 февраля 2023 г. 23:23:03 GMT+02:00, Abhinav Ku

Re: [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-25 Thread Abhinav Kumar
Hi Dmitry On 2/24/2023 3:57 PM, Dmitry Baryshkov wrote: On Sat, 25 Feb 2023 at 01:51, Kuogee Hsieh wrote: On 2/24/2023 1:13 PM, Dmitry Baryshkov wrote: On 24/02/2023 21:40, Kuogee Hsieh wrote: Add DSC helper functions based on DSC configuration profiles to produce DSC related runtime param

[PATCH v2 2/2] drm/msm: simplify msm_parse_deps() and msm_parse_post_deps()

2023-02-25 Thread Dmitry Baryshkov
Simplify two functions msm_parse_deps() and msm_parse_post_deps(): extract single item parsing function and clean up error path. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_gem_submit.c | 196 +++ 1 file changed, 106 insertions(+), 90 deletions(-) diff --

[PATCH v2 1/2] drm/msm: drop unused ring variable in msm_ioctl_gem_submit()

2023-02-25 Thread Dmitry Baryshkov
The variable ring is not used by msm_parse_deps() and msm_ioctl_gem_submit() and thus can be dropped. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_gem_submit.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/

[PATCH v2 0/2] drm/msm: rework msm_parse_deps() and

2023-02-25 Thread Dmitry Baryshkov
As discusssed in the the review of [1], rework these two functions to separate single point parser and provide clean error path. Depenencies: [1] [1] https://lore.kernel.org/all/20230215235048.1166484-1-robdcl...@gmail.com Changes since v1: - Restored dumping of ring->id in trace_msm_gpu_submit

Re: [PATCH v2 06/50] drm/msm/dpu: correct sm8550 scaler

2023-02-25 Thread Dmitry Baryshkov
On 26/02/2023 01:27, Abhinav Kumar wrote: Hi Dmitry On 2/25/2023 3:06 PM, Dmitry Baryshkov wrote: On 24/02/2023 22:51, Abhinav Kumar wrote: On 2/13/2023 9:36 AM, neil.armstr...@linaro.org wrote: On 13/02/2023 12:16, Dmitry Baryshkov wrote: On 13/02/2023 12:41, Neil Armstrong wrote: On 12/

Re: [PATCH v2 10/50] drm/msm/dpu: correct sm6115 scaler

2023-02-25 Thread Dmitry Baryshkov
On 26/02/2023 01:11, Abhinav Kumar wrote: On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote: QSEED4 is a newer variant of QSEED3LITE, which should be used on sm6115. Fix the used feature masks. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Fixes tag is wrong here. It should be Fix

Re: [PATCH] media: Fix building pdfdocs

2023-02-25 Thread Akira Yokosawa
[+CC: Jon, linux-doc] On Wed, 8 Feb 2023 10:29:16 +0200, Tomi Valkeinen wrote: > Commit 8d0e3fc61abd ("media: Add 2-10-10-10 RGB formats") added > documatation for a few new RGB formats. For some reason these break the > pdfdocs build, even if the same style seems to work elsewhere in the > file.

Re: [PATCH v2 12/50] drm/msm/dpu: fix clocks settings for msm8998 SSPP blocks

2023-02-25 Thread Abhinav Kumar
On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote: DMA2 and DMA3 planes on msm8998 should use corresponding DMA2 and DMA3 clocks rather than CURSOR0/1 clocks (which are used for the CURSOR planes). Correct corresponding SSPP declarations. Fixes: 94391a14fc27 ("drm/msm/dpu1: Add MSM8998 to hw catal

Re: [PATCH v2 06/50] drm/msm/dpu: correct sm8550 scaler

2023-02-25 Thread Abhinav Kumar
Hi Dmitry On 2/25/2023 3:06 PM, Dmitry Baryshkov wrote: On 24/02/2023 22:51, Abhinav Kumar wrote: On 2/13/2023 9:36 AM, neil.armstr...@linaro.org wrote: On 13/02/2023 12:16, Dmitry Baryshkov wrote: On 13/02/2023 12:41, Neil Armstrong wrote: On 12/02/2023 00:12, Dmitry Baryshkov wrote: QSE

Re: [PATCH v2 10/50] drm/msm/dpu: correct sm6115 scaler

2023-02-25 Thread Abhinav Kumar
On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote: QSEED4 is a newer variant of QSEED3LITE, which should be used on sm6115. Fix the used feature masks. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Fixes tag is wrong here. It should be Fixes: 3581b7062cec ("drm/msm/disp/dpu1: add

Re: [PATCH v2 06/50] drm/msm/dpu: correct sm8550 scaler

2023-02-25 Thread Dmitry Baryshkov
On 24/02/2023 22:51, Abhinav Kumar wrote: On 2/13/2023 9:36 AM, neil.armstr...@linaro.org wrote: On 13/02/2023 12:16, Dmitry Baryshkov wrote: On 13/02/2023 12:41, Neil Armstrong wrote: On 12/02/2023 00:12, Dmitry Baryshkov wrote: QSEED4 is a newer variant of QSEED3LITE, which should be used

Re: [PATCH v2 09/50] drm/msm/dpu: correct sm8250 and sm8350 scaler

2023-02-25 Thread Abhinav Kumar
On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote: QSEED4 is a newer variant of QSEED3LITE, which should be used on sm8250 and sm8350. Fix the DPU caps structure and used feature masks. Fixes: d21fc5dfc3df ("drm/msm/dpu1: add support for qseed3lite used on sm8250") Fixes: 0e91bcbb0016 ("drm/msm/dp

Re: [PATCH v2 07/50] drm/msm/dpu: correct sc8280xp scaler

2023-02-25 Thread Abhinav Kumar
On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote: QSEED4 is a newer variant of QSEED3LITE, which should be used on sc8280xp. Fix the DPU caps structure and used feature masks. Fixes: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/d

Re: [PATCH v2 08/50] drm/msm/dpu: correct sm8450 scaler

2023-02-25 Thread Abhinav Kumar
On 2/11/2023 3:12 PM, Dmitry Baryshkov wrote: QSEED4 is a newer variant of QSEED3LITE, which should be used on sm8450. Fix the used feature masks. Fixes: 100d7ef6995d ("drm/msm/dpu: add support for SM8450") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

[PATCH v2] drm/i915/active: Fix misuse of non-idle barriers as fence trackers

2023-02-25 Thread Janusz Krzysztofik
Users reported oopses on list corruptions when using i915 perf with a number of concurrently running graphics applications. Root cause analysis pointed at an issue in barrier processing code -- a race among perf open / close replacing active barriers with perf requests on kernel context and concur

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-25 Thread Dmitry Osipenko
On 2/5/23 15:51, Asahi Lina wrote: > -EXPORT_SYMBOL_GPL(drm_gem_shmem_get_pages_sgt); > +EXPORT_SYMBOL(drm_gem_shmem_get_pages_sgt); Note it was a GPL symbol. I expect that all drm-shmem exports should be GPL. -- Best regards, Dmitry

Re: [PATCH] fbdev: omapfb: cleanup inconsistent indentation

2023-02-25 Thread Helge Deller
Hi Lucy, there were some more things wrong in your patch: On 2/25/23 18:23, Helge Deller wrote: On 2/7/23 11:06, Lucy Mielke wrote: This cleans up the indentation according to the Linux kernel coding style, and should fix the warning created by the kernel test robot. Fixes: 8b08cf2b64f5a60594

Re: [PATCH] fbdev: omapfb: cleanup inconsistent indentation

2023-02-25 Thread Helge Deller
Hi Lucy, On 2/7/23 11:06, Lucy Mielke wrote: This cleans up the indentation according to the Linux kernel coding style, and should fix the warning created by the kernel test robot. Fixes: 8b08cf2b64f5a60594b07795b2ad518c6d044566 ("OMAP: add TI OMAP framebuffer driver") Reported-by: ker

[PATCH 1/2] dt-bindings: display/bridge: toshiba, tc358764: convert to dtschema

2023-02-25 Thread Krzysztof Kozlowski
Convert the Toshiba TC358764 bridge bindings to DT schema. Signed-off-by: Krzysztof Kozlowski --- .../display/bridge/toshiba,tc358764.txt | 35 .../display/bridge/toshiba,tc358764.yaml | 89 +++ 2 files changed, 89 insertions(+), 35 deletions(-) delete mode 1

[PATCH 2/2] ARM: dts: exynos: add ports to TC358764 bridge on Arndale

2023-02-25 Thread Krzysztof Kozlowski
The Toshiba TC358764 bridge binding expect up two ports as it is a bridge, thus add ports property to encapsulate them. Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5250-arndale.dts | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/arm/boo

Re: [PATCH] drm/tests: helpers: Drop empty platform remove function

2023-02-25 Thread Maíra Canal
On 2/24/23 19:14, Uwe Kleine-König wrote: A remove callback just returning 0 is equivalent to no remove callback at all. So drop the useless function. Signed-off-by: Uwe Kleine-König Reviewed-by: Maíra Canal Best Regards, - Maíra Canal --- Hello, the remove function was introduced in com

Re: [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions

2023-02-25 Thread Dmitry Baryshkov
On 25/02/2023 02:36, Abhinav Kumar wrote: On 2/24/2023 3:53 PM, Dmitry Baryshkov wrote: On Sat, 25 Feb 2023 at 00:26, Abhinav Kumar wrote: On 2/24/2023 1:36 PM, Dmitry Baryshkov wrote: 24 февраля 2023 г. 23:23:03 GMT+02:00, Abhinav Kumar пишет: On 2/24/2023 1:13 PM, Dmitry Baryshkov wrote

Re: [PATCH v1 1/1] drm/virtio: Support sync objects

2023-02-25 Thread Dmitry Osipenko
On 1/19/23 03:41, Dmitry Osipenko wrote: > + ret = drm_syncobj_find_fence(file, syncobj_desc.handle, > + syncobj_desc.point, 0, &in_fence); > + if (ret) > + break; > + > + if (!dma_fence_match_context(i

Re: [PATCH] drm/virtio: Add option to disable KMS support

2023-02-25 Thread Dmitry Osipenko
On 2/24/23 21:02, Rob Clark wrote: > obj-$(CONFIG_DRM_VIRTIO_GPU) += virtio-gpu.o > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c > b/drivers/gpu/drm/virtio/virtgpu_drv.c > index ae97b98750b6..9cb7d6dd3da6 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_drv.c > +++ b/drivers/gpu/drm/virtio/virt

Re: [PATCH] drm/virtio: Pass correct device to dma_sync_sgtable_for_device()

2023-02-25 Thread Dmitry Osipenko
On 2/24/23 18:34, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > The "vdev->dev.parent" should be used instead of "vdev->dev" as a device > for which to perform the DMA operation in both > virtio_gpu_cmd_transfer_to_host_2d(3d). > > Because the virtio-gpu device "vdev->dev" doesn't

Re: [PATCH] drm/prime: Fix documentation of drm_gem_prime_fd_to_handle()

2023-02-25 Thread Simon Ser
Reviewed-by: Simon Ser

Re: drm next for 6.3-rc1

2023-02-25 Thread Slade Watkins
On Fri, Feb 24, 2023 at 8:35 PM Linus Torvalds wrote: > If you were waiting for a pr-tracker-bot reply, I think you need to > put "{GIT PULL]" in the subject line for the automation to trigger on > it. Had to double check, but yes, that's exactly it: PULL_SUBJECT_RE = [ re.compile(r'^\S*:?\s

Re: [PATCH v2] drm/vmwgfx: Work around VMW_ALLOC_DMABUF

2023-02-25 Thread Meng Tang
On 2023/2/24 11:13, Zack Rusin wrote: That's correct. That's the way this works. The ioctl is allocating a buffer, there's no infinite space for buffers on a system and, given that your app just allocates and never frees buffers, at some point the space will run out and the ioctl will retur

[PATCH] drm/vmwgfx: Work around VMW_ALLOC_DMABUF

2023-02-25 Thread Meng Tang
A privilege escalation vulnerability was found in vmwgfx driver in drivers/gpu/drm/vmwgfx/vmwgfx_drv.c in GPU component of Linux kernel with device file '/dev/dri/renderD128 (or Dxxx)'. This flaw allows a local attacker with a user account on the system to gain privilege, causing a denial of servic

[PATCH] drm/prime: Fix documentation of drm_gem_prime_fd_to_handle()

2023-02-25 Thread Petr Tesarik
From: Petr Tesarik The DRM device passed to drm_gem_prime_fd_to_handle() is where the dma-buf is being imported, not the device where it was exported. Also fix a trivial typo in drm_gem_prime_import_dev(). Signed-off-by: Petr Tesarik --- drivers/gpu/drm/drm_prime.c | 4 ++-- 1 file changed, 2

[PATCH v2] drm/vmwgfx: Work around VMW_ALLOC_DMABUF

2023-02-25 Thread Meng Tang
A privilege escalation vulnerability was found in vmwgfx driver in drivers/gpu/drm/vmwgfx/vmwgfx_drv.c in GPU component of Linux kernel with device file '/dev/dri/renderD128 (or Dxxx)'. This flaw allows a local attacker with a user account on the system to gain privilege, causing a denial of servic

Re: [PATCH v2] drm/vmwgfx: Work around VMW_ALLOC_DMABUF

2023-02-25 Thread Meng Tang
On 2023/2/23 20:50, Zack Rusin wrote: On Thu, 2023-02-23 at 15:04 +0800, Meng Tang wrote: A privilege escalation vulnerability was found in vmwgfx driver in drivers/gpu/drm/vmwgfx/vmwgfx_drv.c in GPU component of Linux kernel with device file '/dev/dri/renderD128 (or Dxxx)'. This flaw allows a l