Re: [PATCH v3 1/7] media: Add 2-10-10-10 RGB formats

2023-02-07 Thread Tomi Valkeinen
On 08/02/2023 03:53, Akira Yokosawa wrote: [+CC: Maruo and Hans, who are listed in the SOB area of offending commit] Hi Tomi, I'm observing build failure of "make pdfdocs" against linux-next due to this change whose commitid is 8d0e3fc61abd. Add XBGR2101010, ABGR2101010 and BGRA1010102 format

[PATCH] gpu: ipu-v3: prg: use devm_platform_get_and_ioremap_resource()

2023-02-07 Thread ye.xingchen
From: Ye Xingchen Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Ye Xingchen --- drivers/gpu/ipu-v3/ipu-prg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH] gpu: ipu-v3: pre: use devm_platform_get_and_ioremap_resource()

2023-02-07 Thread ye.xingchen
From: Ye Xingchen Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Ye Xingchen --- drivers/gpu/ipu-v3/ipu-pre.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH] gpu: host1x: mipi: use devm_platform_get_and_ioremap_resource()

2023-02-07 Thread ye.xingchen
From: Ye Xingchen Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does. Signed-off-by: Ye Xingchen --- drivers/gpu/host1x/mipi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

Re: [PATCH v2 02/17] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-02-07 Thread Imre Deak
On Tue, Feb 07, 2023 at 07:21:48PM -0500, Lyude Paul wrote: > On Tue, 2023-02-07 at 14:11 +0200, Imre Deak wrote: > > On Mon, Feb 06, 2023 at 07:42:32PM -0500, Lyude Paul wrote: > > > On Wed, 2023-02-01 at 17:04 +0200, Imre Deak wrote: > > > > > > > > Yes, this patch should have no functional chan

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-07 Thread kernel test robot
Hi Ville, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-Introduce-plane-SIZE_HINTS-property/20230208-121141 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip pa

Re: [Intel-gfx] [PATCH 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-07 Thread kernel test robot
Hi Ville, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Ville-Syrjala/drm-Introduce-plane-SIZE_HINTS-property/20230208-121141 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip pa

[PATCH 2/2] drm/i915: Add SIZE_HINTS property for cursors

2023-02-07 Thread Ville Syrjala
From: Ville Syrjälä Advertize more suitable cursor sizes via the new SIZE_HINTS plane property. We can't really enumerate all supported cursor sizes on the platforms where the cursor height can vary freely, so for simplicity we'll just expose all square+POT sizes between each platform's min and

[PATCH 1/2] drm: Introduce plane SIZE_HINTS property

2023-02-07 Thread Ville Syrjala
From: Ville Syrjälä Add a new immutable plane property by which a plane can advertise a handful of recommended plane sizes. This would be mostly exposed by cursor planes as a slightly more capable replacement for the DRM_CAP_CURSOR_WIDTH/HEIGHT caps, which can only declare a one size fits all lim

[PATCH 0/2] drm: Add plane SIZE_HINTS property

2023-02-07 Thread Ville Syrjala
From: Ville Syrjälä Proposal for a new plane SIZE_HINTS property to essentially replace the cursor size caps, based on recent discussion in this gitlab bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7687 As for userspace, so far I only did a quick modetest blob decoder (mainly to verify

[PATCH 3/3] arm64: dts: qcom: sc8280xp: Enable GPU related nodes

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Add memory reservation for the zap-shader and enable the Adreno SMMU, GPU clock controller, GMU and the GPU nodes for the SC8280XP CRD and the Lenovo ThinkPad X13s. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dt

[PATCH 1/3] drm/msm/adreno: Add Adreno A690 support

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Introduce support for the Adreno A690, found in Qualcomm SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 120 - drivers/gpu/drm/msm/adreno/a6xx_hfi.c | 34 ++ drivers/g

[PATCH 2/3] arm64: dts: qcom: sc8280xp: Add GPU related nodes

2023-02-07 Thread Bjorn Andersson
From: Bjorn Andersson Add Adreno SMMU, GPU clock controller, GMU and GPU nodes for the SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 171 + 1 file changed, 171 insertions(+) diff --git a/arch/arm64

[PATCH 0/3] drm/msm/adreno: GPU support on SC8280XP

2023-02-07 Thread Bjorn Andersson
This series introduces support for A690 in the DRM/MSM driver and enables it for the two SC8280XP laptops. Bjorn Andersson (3): drm/msm/adreno: Add Adreno A690 support arm64: dts: qcom: sc8280xp: Add GPU related nodes arm64: dts: qcom: sc8280xp: Enable GPU related nodes arch/arm64/boot/dts

[PATCH] drm/rockchip: dsi: Remove the unused function dsi_read()

2023-02-07 Thread Jiapeng Chong
The function dsi_read is defined in the dw-mipi-dsi-rockchip.c file, but not called elsewhere, so remove this unused function. drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:362:19: warning: unused function 'dsi_read'. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?

Re: remove arch/sh

2023-02-07 Thread Randy Dunlap
On 2/7/23 01:06, John Paul Adrian Glaubitz wrote: > Hello Christoph! > > On Fri, 2023-02-03 at 08:14 +0100, Christoph Hellwig wrote: >> On Mon, Jan 16, 2023 at 09:52:10AM +0100, John Paul Adrian Glaubitz wrote: >>> We have had a discussion between multiple people invested in the SuperH >>> por

Re: [PATCH v2 02/17] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-02-07 Thread Lyude Paul
On Tue, 2023-02-07 at 14:11 +0200, Imre Deak wrote: > On Mon, Feb 06, 2023 at 07:42:32PM -0500, Lyude Paul wrote: > > On Wed, 2023-02-01 at 17:04 +0200, Imre Deak wrote: > > > > > > Yes, this patch should have no functional change, so please check what > > > would apply to other drivers as well. >

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-07 Thread Asahi Lina
Sorry, I accidentally sent this reply offlist! Resending, my apologies... On 07/02/2023 20.29, Thomas Zimmermann wrote: > Hi > > Am 05.02.23 um 13:51 schrieb Asahi Lina: >> Other functions touching shmem->sgt take the pages lock, so do that here > > Really? I was just locking at the Lima driver

[PATCH] drm/amd/display: fix glitches on hw rotation without pipe split

2023-02-07 Thread Melissa Wen
Fix glitches when moving cursor close to the edge on a rotated screen for drivers with one pipe (without pipe split) by halving dst_x_offset. Reported-by: Xaver Hugl Signed-off-by: Melissa Wen --- Hi, I'm not sure if having dst_x_offset (or only for the one pipe case) is the right solution, bu

Re: [Intel-gfx] [PATCH 4/4] drm/i915/selftest: Use forcewake to sanity check engine wa lists

2023-02-07 Thread Gustavo Sousa
On Wed, Feb 01, 2023 at 02:28:31PM -0800, Matt Roper wrote: > Although register information in the bspec includes a field that is > supposed to reflect a register's reset characteristics (i.e., whether a > register maintains its value through engine resets), it's been > discovered that this informa

Re: [PATCH v2 0/6] More drm_dbg to guc_dbg changes

2023-02-07 Thread Michal Wajdeczko
On 07.02.2023 06:07, john.c.harri...@intel.com wrote: > From: John Harrison > > Update more print messages to the new scheme. > > v2: Also change all errors to %pe rather than %d (MichalW). > Few other tweaks. > > Signed-off-by: John Harrison LGTM, series is Reviewed-by: Michal Wajdeczko

Re: [PATCH v11 3/9] drm/display: Add Type-C switch helpers

2023-02-07 Thread Andi Shyti
Hi Pin-yen, [...] > +static int drm_dp_register_mode_switch(struct device *dev, > +struct fwnode_handle *fwnode, > +struct drm_dp_typec_switch_desc > *switch_desc, > +void *data, typec_mux

Re: [PATCH] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property

2023-02-07 Thread Sam Ravnborg
On Tue, Feb 07, 2023 at 02:37:16PM -0600, Rob Herring wrote: > On Tue, Feb 07, 2023 at 07:36:00PM +0100, Sam Ravnborg wrote: > > Hi Neil. > > > > > > On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote: > > > Add missing reg property and update example to add dsi top node. > > > > > >

Re: [PATCH v3 24/27] drm/msm/dpu: rework plane CSC setting

2023-02-07 Thread Abhinav Kumar
On 2/7/2023 12:44 PM, Dmitry Baryshkov wrote: On Tue, 7 Feb 2023 at 22:05, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework the code flushing CSC settings for the plane. Separate out the pipe and pipe_cfg as a preparation for r_pipe support. Signed-off-by: Dmitr

Re: [PATCH v11 7/9] dt-bindings: display: bridge: it6505: Add mode-switch support

2023-02-07 Thread Rob Herring
On Sat, Feb 04, 2023 at 09:30:38PM +0800, Pin-yen Lin wrote: > ITE IT6505 can be used in systems to switch the DP traffic between > two downstreams, which can be USB Type-C DisplayPort alternate mode > lane or regular DisplayPort output ports. > > Update the binding to accommodate this usage by in

Re: [PATCH v3 24/27] drm/msm/dpu: rework plane CSC setting

2023-02-07 Thread Dmitry Baryshkov
On Tue, 7 Feb 2023 at 22:05, Abhinav Kumar wrote: > > > > On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: > > Rework the code flushing CSC settings for the plane. Separate out the > > pipe and pipe_cfg as a preparation for r_pipe support. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > driver

Re: [PATCH v2 3/8] dt-bindings: display/msm/gmu: add Adreno 660 support

2023-02-07 Thread Rob Herring
On Mon, 06 Feb 2023 16:57:02 +0200, Dmitry Baryshkov wrote: > Add Adreno A660 to the A635 clause to define all version-specific > properties. There is no need to add it to the top-level clause, since > top-level compatible uses pattern to define compatible strings. > > Signed-off-by: Dmitry Bary

Re: [PATCH v2 1/8] dt-bindings: clock: Merge qcom,gpucc-sm8350 into qcom,gpucc.yaml

2023-02-07 Thread Rob Herring
On Mon, 06 Feb 2023 16:57:00 +0200, Dmitry Baryshkov wrote: > The GPU clock controller bindings for the Qualcomm sm8350 platform are > not correct. The driver uses .fw_name instead of using indices to bind > parent clocks, thus demanding the clock-names usage. With the proper > clock-names in pla

Re: [PATCH] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property

2023-02-07 Thread Rob Herring
On Tue, Feb 07, 2023 at 07:36:00PM +0100, Sam Ravnborg wrote: > Hi Neil. > > > On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote: > > Add missing reg property and update example to add dsi top node. > > > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox >

Re: [PATCH 3/4] drm/i915/xehp: LNCF/LBCF workarounds should be on the GT list

2023-02-07 Thread Gustavo Sousa
On Wed, Feb 01, 2023 at 02:28:30PM -0800, Matt Roper wrote: > Although registers in the L3 bank/node configuration ranges are marked > as having "DEV" reset characteristics in the bspec, this appears to be a > hold-over from pre-Xe_HP platforms. In reality, these registers > maintain their values

Re: [PATCH v3 24/27] drm/msm/dpu: rework plane CSC setting

2023-02-07 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Rework the code flushing CSC settings for the plane. Separate out the pipe and pipe_cfg as a preparation for r_pipe support. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 45 +-- 1 file cha

Re: [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 20:08, Abhinav Kumar wrote: On 2/7/2023 9:59 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:57, Abhinav Kumar wrote: On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent cod

Re: [Intel-gfx] [PATCH 2/4] drm/i915/gen11: Wa_1408615072/Wa_1407596294 should be on GT list

2023-02-07 Thread Gustavo Sousa
On Wed, Feb 01, 2023 at 02:28:29PM -0800, Matt Roper wrote: > The UNSLICE_UNIT_LEVEL_CLKGATE register programmed by this workaround > has 'BUS' style reset, indicating that it does not lose its value on > engine resets. Furthermore, this register is part of the GT forcewake > domain rather than th

Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-07 Thread Matthew Auld
On Tue, 7 Feb 2023 at 17:19, Dixit, Ashutosh wrote: > > On Tue, 07 Feb 2023 08:12:25 -0800, Dixit, Ashutosh wrote: > > > > On Tue, 07 Feb 2023 01:32:44 -0800, Matthew Auld wrote: > > > > > > On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit > > > wrote: > > > > > > > > Previous documentation suggested

Re: [PATCH] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property

2023-02-07 Thread Sam Ravnborg
Hi Neil. On Tue, Feb 07, 2023 at 11:04:36AM +0100, Neil Armstrong wrote: > Add missing reg property and update example to add dsi top node. > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox > VTDR6130 AMOLED DSI Panel") > Signed-off-by: Neil Armstrong > --- > .../bi

Re: [Intel-gfx] [PATCH 1/4] drm/i915/pvc: Annotate two more workaround/tuning registers as MCR

2023-02-07 Thread Gustavo Sousa
On Wed, Feb 01, 2023 at 02:28:28PM -0800, Matt Roper wrote: > XEHPC_LNCFMISCCFGREG0 and XEHPC_L3SCRUB are both in MCR register ranges > on PVC (with HALFBSLICE and L3BANK replication respectively), so they > should be explicitly declared as MCR registers and use MCR-aware > workaround handlers. >

Re: [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Abhinav Kumar
On 2/7/2023 9:59 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:57, Abhinav Kumar wrote: On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the s

Re: [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 19:57, Abhinav Kumar wrote: On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). T

Re: [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Abhinav Kumar
On 2/7/2023 9:51 AM, Dmitry Baryshkov wrote: On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). This is one of Same comment as prev patch

Re: [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 19:49, Abhinav Kumar wrote: On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). This is one of Same comment as prev patch, dpu_plane_atomic_check_pipe() ---> dpu_plane_a

Re: [PATCH v3 23/27] drm/msm/dpu: rework dpu_plane_atomic_check()

2023-02-07 Thread Abhinav Kumar
On 2/3/2023 10:21 AM, Dmitry Baryshkov wrote: Split pipe-dependent code from dpu_plane_atomic_check() into the separate function dpu_plane_atomic_check_pipe(). This is one of Same comment as prev patch, dpu_plane_atomic_check_pipe() ---> dpu_plane_atomic_check_sspp() preparational steps

Re: [PATCH] drm: Disable dynamic debug as broken

2023-02-07 Thread Greg Kroah-Hartman
On Tue, Feb 07, 2023 at 04:33:37PM +0200, Jani Nikula wrote: > From: Ville Syrjälä > > CONFIG_DRM_USE_DYNAMIC_DEBUG breaks debug prints for (at least modular) > drm drivers. The debug prints can be reinstated by manually frobbing > /sys/module/drm/parameters/debug after the fact, but at that poin

[PATCH] drm: Disable dynamic debug as broken

2023-02-07 Thread Jani Nikula
From: Ville Syrjälä CONFIG_DRM_USE_DYNAMIC_DEBUG breaks debug prints for (at least modular) drm drivers. The debug prints can be reinstated by manually frobbing /sys/module/drm/parameters/debug after the fact, but at that point the damage is done and all debugs from driver probe are lost. This ma

Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-07 Thread Dixit, Ashutosh
On Tue, 07 Feb 2023 08:12:25 -0800, Dixit, Ashutosh wrote: > > On Tue, 07 Feb 2023 01:32:44 -0800, Matthew Auld wrote: > > > > On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit > > wrote: > > > > > > Previous documentation suggested that PL1 power limit is always > > > enabled. However we now find this

[PATCH] fbdev: omapfb: cleanup inconsistent indentation

2023-02-07 Thread Lucy Mielke
This cleans up the indentation according to the Linux kernel coding style, and should fix the warning created by the kernel test robot. Fixes: 8b08cf2b64f5a60594b07795b2ad518c6d044566 ("OMAP: add TI OMAP framebuffer driver") Reported-by: kernel test robot Signed-off-by: Lucy Mielke ---

[PATCH] fbdev: omapfb: cleanup inconsistent indentation

2023-02-07 Thread Lucy Mielke
This cleans up the indentation according to the Linux kernel coding style, and should fix the warning created by the kernel test robot. Fixes: 8b08cf2b64f5a60594b07795b2ad518c6d044566 ("OMAP: add TI OMAP framebuffer driver") Reported-by: kernel test robot Signed-off-by: Lucy Mielke ---

Re: [PATCH v4 4/4] drm/rockchip: dw_hdmi: discard modes with unachievable pixelclocks

2023-02-07 Thread Jonas Karlman
Hi Sascha, On 2023-02-07 13:51, Sascha Hauer wrote: > On Tue, Feb 07, 2023 at 11:01:26AM +, Jonas Karlman wrote: >> Hi Sascha, >> >> On 2023-02-07 09:44, Sascha Hauer wrote: >>> The Rockchip PLL drivers are currently table based and support only >>> the most common pixelclocks. Discard all mod

Re: [PATCH] drm/i915/hwmon: Enable PL1 power limit

2023-02-07 Thread Dixit, Ashutosh
On Tue, 07 Feb 2023 01:32:44 -0800, Matthew Auld wrote: > > On Fri, 3 Feb 2023 at 15:54, Ashutosh Dixit wrote: > > > > Previous documentation suggested that PL1 power limit is always > > enabled. However we now find this not to be the case on some > > platforms (such as ATSM). Therefore enable PL1

Re: DRM accel and debugfs/sysfs

2023-02-07 Thread Maíra Canal
On 2/7/23 12:43, Jeffrey Hugo wrote: On 2/7/2023 4:31 AM, Maíra Canal wrote: Hi Stanislaw, On 2/1/23 12:20, Stanislaw Gruszka wrote: Hi I was about to send debugfs support for ivpu and noticed that there are current changes that deprecate drm_devel->debugfs_init callback. Further I looked at

Re: [PATCH 1/2] backlight: hx8357: switch to using gpiod API

2023-02-07 Thread Daniel Thompson
On Mon, Feb 06, 2023 at 08:15:56PM -0800, Dmitry Torokhov wrote: > On Mon, Feb 06, 2023 at 11:35:32AM +, Daniel Thompson wrote: > > On Tue, Jan 31, 2023 at 02:57:06PM -0800, Dmitry Torokhov wrote: > > > + dev_info(&spi->dev, "im gpio[%d] is not here > > > yet, deferring

Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet 3 10IGL5

2023-02-07 Thread Darrell Kavanagh
Further information: With the above fix, the very early boot console messages are not rotated. adding "fbcon=rotate:1" to the kernel command line corrects this. But these early boot console messages are still garbled - it looks like the display driver in use at the time cannot write to the screen

Re: DRM accel and debugfs/sysfs

2023-02-07 Thread Jeffrey Hugo
On 2/7/2023 4:31 AM, Maíra Canal wrote: Hi Stanislaw, On 2/1/23 12:20, Stanislaw Gruszka wrote: Hi I was about to send debugfs support for ivpu and noticed that there are current changes that deprecate drm_devel->debugfs_init callback. Further I looked at this commit [1], that stated we shoul

Re: [PATCH] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property

2023-02-07 Thread Krzysztof Kozlowski
On 07/02/2023 11:04, Neil Armstrong wrote: > Add missing reg property and update example to add dsi top node. > > Fixes: ef85db911134 ("dt-bindings: display: panel: document the Visionox > VTDR6130 AMOLED DSI Panel") > Signed-off-by: Neil Armstrong > --- Reviewed-by: Krzysztof Kozlowski Best

Re: [PATCH v12 13/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:26, Vinod Polimera wrote: -Original Message- From: Dmitry Baryshkov Sent: Tuesday, January 31, 2023 6:29 PM To: Vinod Polimera (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc: lin

Re: [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:28, Vinod Polimera wrote: -Original Message- From: Dmitry Baryshkov Sent: Tuesday, January 31, 2023 6:19 PM To: Vinod Polimera (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc: San

Re: [PATCH v2 4/4] drm/msm/dpu: reserve the resources on topology change

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Some features like CTM can be enabled dynamically. Release and reserve the DPU resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- Changes in v1: - Avoid mode_set call dire

Re: [PATCH v2 3/4] drm/msm/dpu: avoid unnecessary check in DPU reservations

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Return immediately on failure, this will make dpu reservations part look cleaner. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) Reviewed-by:

Re: [PATCH v2 2/4] drm/msm/dpu: add DSPPs into reservation upon a CTM request

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Add DSPP blocks into the topology for reservation, if there is a CTM request for that composition. Signed-off-by: Kalyan Thota --- Changes in v1: - Minor nits (Dmitry) Changes in v2: - Populate DSPPs into the reservation only if CTM is requested (Dmitry

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-07 Thread Laurent Pinchart
Hello Pin-yen, On Tue, Feb 07, 2023 at 06:30:36PM +0800, Pin-yen Lin wrote: > On Tue, Feb 7, 2023 at 6:25 PM Laurent Pinchart wrote: > > On Tue, Feb 07, 2023 at 06:07:44PM +0800, Pin-yen Lin wrote: > > > On Wed, Jan 18, 2023 at 4:17 AM Rob Herring wrote: > > > > On Mon, Jan 16, 2023 at 07:08:19PM

Re: [PATCH v2 1/4] drm/msm/dpu: clear DSPP reservations in rm release

2023-02-07 Thread Dmitry Baryshkov
On 07/02/2023 16:29, Kalyan Thota wrote: Clear DSPP reservations from the global state during rm release Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") This should fit into a single line (even it is longer than the recommended l

Re: [RFC PATCH] drm: Create documentation about device resets

2023-02-07 Thread Michel Dänzer
On 2/7/23 14:30, Pekka Paalanen wrote: > On Mon, 23 Jan 2023 21:38:11 +0100 > Christian König wrote: >> Am 23.01.23 um 21:26 schrieb André Almeida: >>> >>> diff --git a/Documentation/gpu/drm-reset.rst >>> b/Documentation/gpu/drm-reset.rst >>> new file mode 100644 >>> index ..0dd11a469

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Neil Armstrong
nabled") in next-20230127 next-20230130 next-20230131 but not in any later version? $ git log --oneline --author=dmitry next-20230207 drivers/gpu/drm/drm_probe_helper.c c8268795c9a9 drm/probe-helper: enable and disable HPD on connectors 78b991ccfa64 drm/poll-helper: merge drm_kms_helper_poll_disa

[PATCH v2 3/4] drm/msm/dpu: avoid unnecessary check in DPU reservations

2023-02-07 Thread Kalyan Thota
Return immediately on failure, this will make dpu reservations part look cleaner. Signed-off-by: Kalyan Thota --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

[PATCH v2 4/4] drm/msm/dpu: reserve the resources on topology change

2023-02-07 Thread Kalyan Thota
Some features like CTM can be enabled dynamically. Release and reserve the DPU resources whenever a topology change occurs such that required hw blocks are allocated appropriately. Signed-off-by: Kalyan Thota --- Changes in v1: - Avoid mode_set call directly (Dmitry) Changes in v2: - Minor nits

[PATCH v2 1/4] drm/msm/dpu: clear DSPP reservations in rm release

2023-02-07 Thread Kalyan Thota
Clear DSPP reservations from the global state during rm release Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in dpu driver") Signed-off-by: Kalyan Thota Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/dp

[PATCH v2 0/4] Reserve DSPPs based on user request

2023-02-07 Thread Kalyan Thota
This series will enable color features on sc7280 target which has primary panel as eDP The series removes DSPP allocation based on encoder type and allows the DSPP reservation based on user request via CTM. The series will release/reserve the dpu resources when ever there is a topology change

[PATCH v2 2/4] drm/msm/dpu: add DSPPs into reservation upon a CTM request

2023-02-07 Thread Kalyan Thota
Add DSPP blocks into the topology for reservation, if there is a CTM request for that composition. Signed-off-by: Kalyan Thota --- Changes in v1: - Minor nits (Dmitry) Changes in v2: - Populate DSPPs into the reservation only if CTM is requested (Dmitry) --- drivers/gpu/drm/msm/disp/dpu1/dpu_en

RE: [PATCH v12 09/14] drm/msm/dp: disable self_refresh_aware after entering psr

2023-02-07 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, January 31, 2023 6:19 PM > To: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org > Cc: Sankeerth Billakanti (QUIC) ; linux

RE: [PATCH v12 13/14] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2023-02-07 Thread Vinod Polimera
> -Original Message- > From: Dmitry Baryshkov > Sent: Tuesday, January 31, 2023 6:29 PM > To: Vinod Polimera (QUIC) ; dri- > de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; > freedr...@lists.freedesktop.org; devicet...@vger.kernel.org > Cc: linux-ker...@vger.kernel.org; robdc

Re: [RFC PATCH] drm: Create documentation about device resets

2023-02-07 Thread Pekka Paalanen
On Mon, 23 Jan 2023 21:38:11 +0100 Christian König wrote: > Am 23.01.23 um 21:26 schrieb André Almeida: > > Create a document that specifies how to deal with DRM device resets for > > kernel and userspace drivers. > > > > Signed-off-by: André Almeida > > --- > > Documentation/gpu/drm-reset.rst

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread neil . armstrong
t in any later version? $ git log --oneline --author=dmitry next-20230207 drivers/gpu/drm/drm_probe_helper.c c8268795c9a9 drm/probe-helper: enable and disable HPD on connectors 78b991ccfa64 drm/poll-helper: merge drm_kms_helper_poll_disable() and _fini() $

Re: [Intel-gfx] [CI 1/4] drm/i915/dp_mst: Add the MST topology state for modesetted CRTCs

2023-02-07 Thread Imre Deak
Hi all, On Mon, Feb 06, 2023 at 01:48:53PM +0200, Imre Deak wrote: > Add the MST topology for a CRTC to the atomic state if the driver > needs to force a modeset on the CRTC after the encoder compute config > functions are called. > > Later the MST encoder's disable hook also adds the state, but

Re: [PATCH v4 4/4] drm/rockchip: dw_hdmi: discard modes with unachievable pixelclocks

2023-02-07 Thread Sascha Hauer
On Tue, Feb 07, 2023 at 11:01:26AM +, Jonas Karlman wrote: > Hi Sascha, > > On 2023-02-07 09:44, Sascha Hauer wrote: > > The Rockchip PLL drivers are currently table based and support only > > the most common pixelclocks. Discard all modes we cannot achieve > > at all. Normally the desired pix

Re: [PATCH v2 00/21] Enable Colorspace connector property in amdgpu

2023-02-07 Thread Pekka Paalanen
On Fri, 13 Jan 2023 11:24:07 -0500 Harry Wentland wrote: > This patchset enables the DP and HDMI infoframe properties > in amdgpu. > > The first two patches are not completely related to the rest. The > first patch allows for HDR_OUTPUT_METADATA with EOTFs that are > unknown in the kernel. > >

Re: [PATCH v2 18/21] drm/amd/display: Fallback to 2020_YCBCR if the pixel encoding is not RGB

2023-02-07 Thread Pekka Paalanen
On Wed, 25 Jan 2023 12:59:53 + Joshua Ashton wrote: > On 1/23/23 20:30, Sebastian Wick wrote: > > A new property to control YCC and subsampling would be the more > > complete path here. If we actually want to fix this in the short-term > > though, we should handle the YCC and RGB Colorspace v

Re: [PATCH v4 1/4] drm/rockchip: vop: limit maximium resolution to hardware capabilities

2023-02-07 Thread Sascha Hauer
On Tue, Feb 07, 2023 at 10:46:49AM +, Jonas Karlman wrote: > Hi Sascha, > On 2023-02-07 09:44, Sascha Hauer wrote: > > The different VOP variants support different maximum resolutions. Reject > > resolutions that are not supported by a specific variant. > > > > This hasn't been a problem in th

Re: [PATCH v2 02/17] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-02-07 Thread Imre Deak
On Mon, Feb 06, 2023 at 07:42:32PM -0500, Lyude Paul wrote: > On Wed, 2023-02-01 at 17:04 +0200, Imre Deak wrote: > > > > Yes, this patch should have no functional change, so please check what > > would apply to other drivers as well. > > > > Could you also check Ville's comment about storing sta

Re: [PATCH] drm/ast: Fix start address computation

2023-02-07 Thread Jocelyn Falempe
On 07/02/2023 12:17, Thomas Zimmermann wrote: Hi Am 07.02.23 um 11:53 schrieb Jocelyn Falempe: During the driver conversion to shmem, there is a missing page shift when computing the start address in GPU memory. This leads to graphic garbage when connecting to the remote BMC, depending on the

Re: DRM accel and debugfs/sysfs

2023-02-07 Thread Maíra Canal
Hi Stanislaw, On 2/1/23 12:20, Stanislaw Gruszka wrote: Hi I was about to send debugfs support for ivpu and noticed that there are current changes that deprecate drm_devel->debugfs_init callback. Further I looked at this commit [1], that stated we should not use drm_minor for debugfs and sysfs

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-07 Thread Thomas Zimmermann
Hi Am 05.02.23 um 13:51 schrieb Asahi Lina: Other functions touching shmem->sgt take the pages lock, so do that here Really? I was just locking at the Lima driver and it apparently access sgt without locking in [1]. Not that I disagree with the patch in general. Best regards Thomas [1] ht

Re: [PATCH] drm/ast: Fix start address computation

2023-02-07 Thread Thomas Zimmermann
Hi Am 07.02.23 um 11:53 schrieb Jocelyn Falempe: During the driver conversion to shmem, there is a missing page shift when computing the start address in GPU memory. This leads to graphic garbage when connecting to the remote BMC, depending on the PCI start address. Tested on a sr645 affected b

Re: [PATCH v4 4/4] drm/rockchip: dw_hdmi: discard modes with unachievable pixelclocks

2023-02-07 Thread Jonas Karlman
Hi Sascha, On 2023-02-07 09:44, Sascha Hauer wrote: > The Rockchip PLL drivers are currently table based and support only > the most common pixelclocks. Discard all modes we cannot achieve > at all. Normally the desired pixelclocks have an exact match in the > PLL driver, nevertheless allow for a

[PATCH] drm/ast: Fix start address computation

2023-02-07 Thread Jocelyn Falempe
During the driver conversion to shmem, there is a missing page shift when computing the start address in GPU memory. This leads to graphic garbage when connecting to the remote BMC, depending on the PCI start address. Tested on a sr645 affected by this bug. Fixes: f2fa5a99ca81 ("drm/ast: Convert

Re: [Nouveau] [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-02-07 Thread Danilo Krummrich
On 2/7/23 10:35, Christian König wrote: Am 06.02.23 um 19:20 schrieb Danilo Krummrich: On 2/6/23 17:14, Christian König wrote: Concentrating this discussion on a very big misunderstanding first. Am 06.02.23 um 14:27 schrieb Danilo Krummrich: [SNIP] My understanding is that userspace is fully

Re: [PATCH v4 1/4] drm/rockchip: vop: limit maximium resolution to hardware capabilities

2023-02-07 Thread Jonas Karlman
Hi Sascha, On 2023-02-07 09:44, Sascha Hauer wrote: > The different VOP variants support different maximum resolutions. Reject > resolutions that are not supported by a specific variant. > > This hasn't been a problem in the upstream driver so far as 1920x1080 > has been the maximum resolution sup

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-07 Thread Javier Martinez Canillas
On 2/7/23 11:33, Asahi Lina wrote: > On 07/02/2023 03.47, Javier Martinez Canillas wrote: >> Hello Lina, >> >> On 2/5/23 13:51, Asahi Lina wrote: >>> Other functions touching shmem->sgt take the pages lock, so do that here >>> too. drm_gem_shmem_get_pages() & co take the same lock, so move to the >

Re: [Intel-gfx] [PATCH v2] drm/i915/pcode: Give the punit time to settle before fatally failing

2023-02-07 Thread Andi Shyti
Hi Andrzej, > > During module load the punit might still be busy with its booting > > routines. During this time we try to communicate with it but we > > fail because we don't receive any feedback from it and we return > > immediately with a -EINVAL fatal error. > > > > At this point the driver l

Re: [PATCH] drm/shmem-helper: Fix locking for drm_gem_shmem_get_pages_sgt()

2023-02-07 Thread Asahi Lina
On 07/02/2023 03.47, Javier Martinez Canillas wrote: > Hello Lina, > > On 2/5/23 13:51, Asahi Lina wrote: >> Other functions touching shmem->sgt take the pages lock, so do that here >> too. drm_gem_shmem_get_pages() & co take the same lock, so move to the >> _locked() variants to avoid recursive l

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-07 Thread Pin-yen Lin
Hi Laurent, On Tue, Feb 7, 2023 at 6:25 PM Laurent Pinchart wrote: > > On Tue, Feb 07, 2023 at 06:07:44PM +0800, Pin-yen Lin wrote: > > On Wed, Jan 18, 2023 at 4:17 AM Rob Herring wrote: > > > On Mon, Jan 16, 2023 at 07:08:19PM +0800, Pin-yen Lin wrote: > > > > From: Nicolas Boichat > > > > > >

Re: [Intel-gfx] [PATCH v3 2/2] drm/probe_helper: sort out poll_running vs poll_enabled

2023-02-07 Thread Geert Uytterhoeven
Hi Dmitry, On Tue, 24 Jan 2023, Dmitry Baryshkov wrote: There are two flags attemting to guard connector polling: poll_enabled and poll_running. While poll_enabled semantics is clearly defined and fully adhered (mark that drm_kms_helper_poll_init() was called and not finalized by the _fi

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-07 Thread Laurent Pinchart
On Tue, Feb 07, 2023 at 06:07:44PM +0800, Pin-yen Lin wrote: > On Wed, Jan 18, 2023 at 4:17 AM Rob Herring wrote: > > On Mon, Jan 16, 2023 at 07:08:19PM +0800, Pin-yen Lin wrote: > > > From: Nicolas Boichat > > > > > > Add bindings for Generic GPIO mux driver. > > > > > > Signed-off-by: Nicolas Bo

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 11:02 AM Geert Uytterhoeven wrote: > On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong > wrote: > > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > > wrote: > > >> On 10/01/2023 08:57, Laurentiu Palcu wrote:

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread neil . armstrong
On 07/02/2023 11:02, Geert Uytterhoeven wrote: Hi Neil, On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong wrote: On 07/02/2023 10:40, Geert Uytterhoeven wrote: On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov wrote: On 10/01/2023 08:57, Laurentiu Palcu wrote: On Mon, Jan 09, 2023 at 10:26:28P

Re: [PATCH v9 0/9] Register Type-C mode-switch in DP bridge endpoints

2023-02-07 Thread Pin-yen Lin
Hi Lyude, Thanks for letting me know! I just sent out a v11 and already received some review comments, but reviews are always welcomed if you have time to take a look. Regards, Pin-yen On Tue, Jan 31, 2023 at 7:10 AM Lyude Paul wrote: > > Don't know if this still needs reviews from me (feel fr

Re: [PATCH v2 1/2] dt-bindings: display: bridge: Add GPIO display mux binding

2023-02-07 Thread Pin-yen Lin
Hi Rob, Thanks for the review. On Wed, Jan 18, 2023 at 4:17 AM Rob Herring wrote: > > On Mon, Jan 16, 2023 at 07:08:19PM +0800, Pin-yen Lin wrote: > > From: Nicolas Boichat > > > > Add bindings for Generic GPIO mux driver. > > > > Signed-off-by: Nicolas Boichat > > Signed-off-by: Pin-yen Lin

[PATCH] dt-bindings: display: panel: visionox,vtdr6130: add missing reg property

2023-02-07 Thread Neil Armstrong
vdd-supply = <&vreg_l11b_1p2>; + +reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>; + +port { +panel0_in: endpoint { +remote-endpoint = <&dsi0_out>; +}; }; }; };

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Neil, On Tue, Feb 7, 2023 at 10:59 AM Neil Armstrong wrote: > On 07/02/2023 10:40, Geert Uytterhoeven wrote: > > On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov > > wrote: > >> On 10/01/2023 08:57, Laurentiu Palcu wrote: > >>> On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote:

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Neil Armstrong
Hi Geert, On 07/02/2023 10:40, Geert Uytterhoeven wrote: Hi Dmitry, On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov wrote: On 10/01/2023 08:57, Laurentiu Palcu wrote: On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: On 09/01/2023 18:21, Laurentiu Palcu wrote: It looks lik

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
On Tue, Jan 10, 2023 at 11:20 AM Geert Uytterhoeven wrote: > On Tue, Jan 10, 2023 at 8:07 AM Laurentiu Palcu > wrote: > > On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > > > On 09/01/2023 18:21, Laurentiu Palcu wrote: > > > > It looks like there are some issues with this patch

Re: [PATCH v3 0/7] drm/bridge_connector: perform HPD enablement automatically

2023-02-07 Thread Geert Uytterhoeven
Hi Dmitry, On Tue, Jan 10, 2023 at 5:37 PM Dmitry Baryshkov wrote: > On 10/01/2023 08:57, Laurentiu Palcu wrote: > > On Mon, Jan 09, 2023 at 10:26:28PM +0200, Dmitry Baryshkov wrote: > >> On 09/01/2023 18:21, Laurentiu Palcu wrote: > >>> It looks like there are some issues with this patchset... :

  1   2   >