Re: [PATCH v2 1/4] dt-bindings: display: panel: jadard,jd9365da-h3: Add Radxa Display 10HD

2023-01-26 Thread Linus Walleij
On Mon, Jan 23, 2023 at 7:33 PM Jagan Teki wrote: > Radxa Display 10HD is a family of DSI panels from Radxa that > uses jd9365da-h3 IC. > > Add compatible string for it. > > Signed-off-by: Jagan Teki The v2 series all look good to me so I have applied the patches to drm-misc-next. Yours, Linus

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-26 Thread Christian König
Am 27.01.23 um 02:26 schrieb Danilo Krummrich: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU v

Re: [PATCH] dma-buf: actually set signaling bit for private sub fences

2023-01-26 Thread Christian König
Am 26.01.23 um 23:25 schrieb Danilo Krummrich: On 1/26/23 07:58, Christian König wrote: Am 26.01.23 um 01:28 schrieb Danilo Krummrich: In dma_fence_allocate_private_stub() set the signaling bit of the newly allocated private stub fence rather than the signaling bit of the shared dma_fence_stub.

Re: [PATCH] Revert "drm/display/dp_mst: Move all payload info into the atomic state"

2023-01-26 Thread Greg KH
On Fri, Jan 20, 2023 at 11:51:04AM -0600, Limonciello, Mario wrote: > On 1/20/2023 11:46, Guenter Roeck wrote: > > On Thu, Jan 12, 2023 at 04:50:44PM +0800, Wayne Lin wrote: > > > This reverts commit 4d07b0bc403403438d9cf88450506240c5faf92f. > > > > > > [Why] > > > Changes cause regression on amdg

Re: [PATCH] drm/i915/pcode: Wait 10 seconds for pcode to settle

2023-01-26 Thread Gwan-gyeong Mun
On 1/11/23 5:36 PM, Andi Shyti wrote: On Wed, Jan 11, 2023 at 03:18:38PM +0200, Jani Nikula wrote: On Wed, 11 Jan 2023, Andi Shyti wrote: From: Aravind Iddamsetty During module load not all the punit transaction have completed and we might end up timing out, as shown by the following warn

[PATCH 07/35] Documentation: fb: correct spelling

2023-01-26 Thread Randy Dunlap
Correct spelling problems for Documentation/fb/ as reported by codespell. Signed-off-by: Randy Dunlap Cc: Helge Deller Cc: linux-fb...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/fb/sm712fb.rst |2 +- Documentation

linux-next: build failure after merge of the mm tree

2023-01-26 Thread Stephen Rothwell
Hi all, After merging the mm tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/accel/ivpu/ivpu_gem.c: In function 'ivpu_bo_mmap': drivers/accel/ivpu/ivpu_gem.c:449:23: error: assignment of read-only member 'vm_flags' 449 | vma->vm_flags |= VM_PFNMAP | VM_DO

Re: [PATCH v2 05/27] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout

2023-01-26 Thread Dmitry Baryshkov
On Fri, 27 Jan 2023 at 02:52, Abhinav Kumar wrote: > > > > On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: > > The pipe's layout is not cached, corresponding data structure is zeroed > > out each time in the dpu_plane_sspp_atomic_update(), right before the > > call to _dpu_plane_set_scanout() -> d

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-26 Thread Ben Skeggs
On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo > > wrote: > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > > > As a quick check can you try changing > > > > > > > >

Re: [PATCH v2 03/27] drm/msm/dpu: move SSPP allocation to the RM

2023-01-26 Thread Dmitry Baryshkov
On Fri, 27 Jan 2023 at 01:29, Abhinav Kumar wrote: > > > > On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: > > Follow the example of all other hw blocks and initialize SSPP blocks in > > Resource Manager. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/msm/disp/dpu1/dpu_plan

Re: [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-26 Thread Dmitry Baryshkov
Hi, On Sat, 14 Jan 2023 at 01:56, Douglas Anderson wrote: > > In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > time"), we moved powering up DSI hosts to modeset time. This wasn't > because it was an elegant design, but there were no better options. > > That commit actually

linux-next: manual merge of the mm tree with the drm tree

2023-01-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the mm tree got a conflict in: drivers/gpu/drm/i810/i810_dma.c between commit: cab18866fead ("drm: Remove the obsolete driver-i810") from the drm tree and commit: 6fe0afd07701 ("mm: replace vma->vm_flags direct modifications with modifier calls") fr

[git pull] drm fixes for 6.2-rc6

2023-01-26 Thread Dave Airlie
Hi Linus, Fairly small this week as well, i915 has a memory leak fix and some minor changes, and amdgpu has some MST fixes, and some other minor ones. Dave. drm-fixes-2023-01-27: drm fixes for 6.2-rc6 drm: - DP MST kref fix - fb_helper: check return value i915: - Fix BSC default context for Me

Re: [PATCH] drm/amdgpu/display/mst: fix an unused-variable warning

2023-01-26 Thread Dave Airlie
On Fri, 27 Jan 2023 at 07:06, Hamza Mahfooz wrote: > > On 1/26/23 11:35, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The newly added code is in an #ifdef, so the variables that > > are only used in there cause a warning if CONFIG_DRM_AMD_DC_DCN > > is disabled: > > > > drivers/gpu/drm/am

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-26 Thread Danilo Krummrich
On 1/27/23 04:21, Matthew Brost wrote: On Fri, Jan 27, 2023 at 02:43:30AM +0100, Danilo Krummrich wrote: On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UAPI motivated by the Vulkan API.

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-26 Thread Matthew Brost
On Fri, Jan 27, 2023 at 02:43:30AM +0100, Danilo Krummrich wrote: > > > On 1/27/23 02:05, Matthew Brost wrote: > > On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: > > > This commit provides the interfaces for the new UAPI motivated by the > > > Vulkan API. It allows user mode dr

Re: [PATCH] drm/mediatek: Drop unbalanced obj unref

2023-01-26 Thread Chun-Kuang Hu
Hi, Rob: Rob Clark 於 2023年1月20日 週五 上午7:12寫道: > > From: Rob Clark > > In the error path, mtk_drm_gem_object_mmap() is dropping an obj > reference that it doesn't own. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=med

Re: Re: [PATCH] PM / devfreq: Fix build issues with devfreq disabled

2023-01-26 Thread Rob Clark
On Tue, Jan 24, 2023 at 9:46 PM MyungJoo Ham wrote: > > >On Tue, Jan 24, 2023 at 8:04 PM MyungJoo Ham > >wrote: > >> > >> >Sender : Rob Clark > >> >Date : 2023-01-24 00:37 (GMT+9) > >> >Title : [PATCH] PM / devfreq: Fix build issues with devfreq disabled > >> > > >> >From: Rob Clark > >> > > >

Re: [PATCH] drm/mediatek: Remove dependency on GEM DMA helper

2023-01-26 Thread Chun-Kuang Hu
Hi, Rob: Rob Clark 於 2023年1月20日 週五 上午6:40寫道: > > From: Rob Clark > > It appears that the dependency on the DMA helpers was only for > drm_gem_dma_vm_ops. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-ne

Re: [PATCH] drm/mediatek: dp: Remove extra semicolon

2023-01-26 Thread Chun-Kuang Hu
Hi, Deepak: Deepak R Varma 於 2023年1月14日 週六 下午11:41寫道: > > Remove unnecessary semicolon at the end of switch block closing brace. > Issue identified using semicolon Coccinelle semantic patch. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang

linux-next: manual merge of the drm-misc tree with the drm-misc-fixes tree

2023-01-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/drm_fbdev_generic.c between commits: cc88ad784e42 ("drm/fb-helper: Check fb_deferred_io_init() return value") d6591da5f3ff ("drm/fb-helper: Use a per-driver FB deferred I/O handler") from the drm-mis

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-26 Thread Danilo Krummrich
On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address (VA) space via the new DRM

[PATCH] drm/amd/display: reduce else-if to else in dcn10_blank_pixel_data()

2023-01-26 Thread Tom Rix
checkpatch reports drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c:2902:13: style: Expression is always true because 'else if' condition is opposite to previous condition at line 2895. [multiCondition] } else if (blank) { ^ drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_seq

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-26 Thread Danilo Krummrich
On 1/27/23 02:05, Matthew Brost wrote: On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: This commit provides the interfaces for the new UAPI motivated by the Vulkan API. It allows user mode drivers (UMDs) to: 1) Initialize a GPU virtual address (VA) space via the new DRM_IO

Re: [RFT PATCH 2/2] drm/msm/dsi: Stop unconditionally powering up DSI hosts at modeset

2023-01-26 Thread Doug Anderson
Hi, On Fri, Jan 13, 2023 at 3:56 PM Douglas Anderson wrote: > > In commit 7d8e9a90509f ("drm/msm/dsi: move DSI host powerup to modeset > time"), we moved powering up DSI hosts to modeset time. This wasn't > because it was an elegant design, but there were no better options. > > That commit actual

Re: [PATCH 1/2] drm/msm/dp: Clean up handling of DP AUX interrupts

2023-01-26 Thread Doug Anderson
Hi, On Wed, Jan 25, 2023 at 9:13 AM Kuogee Hsieh wrote: > > > On 1/19/2023 2:53 PM, Douglas Anderson wrote: > > The DP AUX interrupt handling was a bit of a mess. > > * There were two functions (one for "native" transfers and one for > >"i2c" transfers) that were quite similar. It was hard to

[PATCH v2 2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts

2023-01-26 Thread Douglas Anderson
If our interrupt handler gets called and we don't really handle the interrupt then we should return IRQ_NONE. The current interrupt handler didn't do this, so let's fix it. NOTE: for some of the cases it's clear that we should return IRQ_NONE and some cases it's clear that we should return IRQ_HAN

[PATCH v2 1/2] drm/msm/dp: Clean up handling of DP AUX interrupts

2023-01-26 Thread Douglas Anderson
The DP AUX interrupt handling was a bit of a mess. * There were two functions (one for "native" transfers and one for "i2c" transfers) that were quite similar. It was hard to say how many of the differences between the two functions were on purpose and how many of them were just an accident o

Re: [PATCH drm-next 05/14] drm/nouveau: new VM_BIND uapi interfaces

2023-01-26 Thread Matthew Brost
On Wed, Jan 18, 2023 at 07:12:47AM +0100, Danilo Krummrich wrote: > This commit provides the interfaces for the new UAPI motivated by the > Vulkan API. It allows user mode drivers (UMDs) to: > > 1) Initialize a GPU virtual address (VA) space via the new >DRM_IOCTL_NOUVEAU_VM_INIT ioctl. UMDs c

Re: [PATCH v2 05/27] drm/msm/dpu: drop EAGAIN check from dpu_format_populate_layout

2023-01-26 Thread Abhinav Kumar
On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: The pipe's layout is not cached, corresponding data structure is zeroed out each time in the dpu_plane_sspp_atomic_update(), right before the call to _dpu_plane_set_scanout() -> dpu_format_populate_layout(). Drop plane_addr comparison against pr

Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable

2023-01-26 Thread Doug Anderson
Hi, On Wed, Jan 18, 2023 at 1:34 PM Doug Anderson wrote: > > Hi, > > On Thu, Jan 5, 2023 at 7:01 PM Stephen Boyd wrote: > > > > The unprepare sequence has started to fail after moving to panel bridge > > code in the msm drm driver (commit 007ac0262b0d ("drm/msm/dsi: switch to > > DRM_PANEL_BRIDG

Re: [PATCH v2] drm/mediatek: stop using 0 as NULL pointer

2023-01-26 Thread Chun-Kuang Hu
Hi, Miles: Miles Chen 於 2023年1月11日 週三 上午10:52寫道: > > Use NULL for NULL pointer to fix the following sparse warning: > drivers/gpu/drm/mediatek/mtk_drm_gem.c:265:27: sparse: warning: Using plain > integer as NULL pointer Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/

Re: [PATCH v2] drm/mediatek: Add support for AR30 and BA30

2023-01-26 Thread Chun-Kuang Hu
Hi, Justin: Justin Green 於 2023年1月11日 週三 上午4:47寫道: > > Add support for AR30 and BA30 pixel formats to the Mediatek DRM driver. > > Tested using "modetest -P" on an MT8195. > > Signed-off-by: Justin Green > --- > v2: > * Rebase and resolve merge conflicts with the AFBC patch. > > drivers/gpu/dr

[PATCH v6 8/8] drm/i915/guc: Rename GuC register state capture node to be more obvious

2023-01-26 Thread John . C . Harrison
From: John Harrison The GuC specific register state entry in the error capture object was just called 'capture'. Although the companion 'node' entry was called 'guc_capture_node'. Rename the base entry to be 'guc_capture' instead so that it is a) more consistent and b) more obvious what it is. S

[PATCH v6 0/8] Allow error capture without a request & fix locking issues

2023-01-26 Thread John . C . Harrison
From: John Harrison It is technically possible to get a hung context without a valid request. In such a situation, try to provide as much information in the error capture as possible rather than just aborting and capturing nothing. Similarly, in the case of an engine reset failure the GuC is not

[PATCH v6 5/8] drm/i915: Allow error capture of a pending request

2023-01-26 Thread John . C . Harrison
From: John Harrison A hang situation has been observed where the only requests on the context were either completed or not yet started according to the breaadcrumbs. However, the register state claimed a batch was (maybe) in progress. So, allow capture of the pending request on the grounds that t

[PATCH v6 6/8] drm/i915/guc: Look for a guilty context when an engine reset fails

2023-01-26 Thread John . C . Harrison
From: John Harrison Engine resets are supposed to never fail. But in the case when one does (due to unknown reasons that normally come down to a missing w/a), it is useful to get as much information out of the system as possible. Given that the GuC intentionally dies on such a situation, it is no

[PATCH v6 3/8] drm/i915: Fix up locking around dumping requests lists

2023-01-26 Thread John . C . Harrison
From: John Harrison The debugfs dump of requests was confused about what state requires the execlist lock versus the GuC lock. There was also a bunch of duplicated messy code between it and the error capture code. So refactor the hung request search into a re-usable function. And reduce the span

[PATCH v6 4/8] drm/i915: Allow error capture without a request

2023-01-26 Thread John . C . Harrison
From: John Harrison There was a report of error captures occurring without any hung context being indicated despite the capture being initiated by a 'hung context notification' from GuC. The problem was not reproducible. However, it is possible to happen if the context in question has no active r

[PATCH v6 2/8] drm/i915: Fix request ref counting during error capture & debugfs dump

2023-01-26 Thread John . C . Harrison
From: John Harrison When GuC support was added to error capture, the reference counting around the request object was broken. Fix it up. The context based search manages the spinlocking around the search internally. So it needs to grab the reference count internally as well. The execlist only re

[PATCH v6 7/8] drm/i915/guc: Add a debug print on GuC triggered reset

2023-01-26 Thread John . C . Harrison
From: John Harrison For understanding bug reports, it can be useful to have an explicit dmesg print when a reset notification is received from GuC. As opposed to simply inferring that this happened from other messages. Signed-off-by: John Harrison Reviewed-by: Tvrtko Ursulin --- drivers/gpu/d

[PATCH v6 1/8] drm/i915/guc: Fix locking when searching for a hung request

2023-01-26 Thread John . C . Harrison
From: John Harrison intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up. While at it, add some extra whitespace padding for readability. Fixes: dc0dad365c5e ("drm/i915/guc: Fix for error capture after full GPU reset with GuC") S

Re: [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings

2023-01-26 Thread Matthew Brost
On Wed, Jan 18, 2023 at 07:12:45AM +0100, Danilo Krummrich wrote: > This adds the infrastructure for a manager implementation to keep track > of GPU virtual address (VA) mappings. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace appli

Re: [PATCH v3 2/8] drm/i915/pxp: Add MTL hw-plumbing enabling for KCR operation

2023-01-26 Thread Ceraolo Spurio, Daniele
On 1/25/2023 12:06 AM, Alan Previn wrote: Add MTL hw-plumbing enabling for KCR operation under PXP which includes: 1. Updating 'pick-gt' to get the media tile for KCR interrupt handling 2. Adding MTL's KCR registers for PXP operation (init, status-checking, etc.). While doing #2, let

Re: [PATCH v3 1/8] drm/i915/pxp: Add GSC-CS back-end resource init and cleanup

2023-01-26 Thread Ceraolo Spurio, Daniele
On 1/25/2023 12:06 AM, Alan Previn wrote: For MTL, the PXP back-end transport uses the GSC engine to submit HECI packets through the HW to the GSC firmware for PXP arb session management. This submission uses a non-priveleged batch buffer, a buffer for the command packet and of course a contex

Re: [PATCH v2 1/3] drm/mediatek: dsi: Reduce the time of dsi from LP11 to sending cmd

2023-01-26 Thread Chun-Kuang Hu
Hi, Xinlei: 於 2023年1月10日 週二 下午1:55寫道: > > From: Xinlei Lee > > According to Figure 16 Turnaround Procedure on page 36 in [1], you > can see the status of LP-00 -> LP10 -> LP11. This state can correspond > to the state of DSI from LP00 -> LP11 in mtk_dsi_lane_ready function > in mtk_dsi.c. > > LP

Re: [PATCH v5 1/8] drm/i915/guc: Fix locking when searching for a hung request

2023-01-26 Thread Ceraolo Spurio, Daniele
On 1/25/2023 4:54 PM, john.c.harri...@intel.com wrote: From: John Harrison intel_guc_find_hung_context() was not acquiring the correct spinlock before searching the request list. So fix that up. While at it, add some extra whitespace padding for readability. Fixes: dc0dad365c5e ("drm/i915/g

Re: [PATCH drm-next 03/14] drm: manager to keep track of GPUs VA mappings

2023-01-26 Thread Matthew Brost
On Wed, Jan 18, 2023 at 07:12:45AM +0100, Danilo Krummrich wrote: > This adds the infrastructure for a manager implementation to keep track > of GPU virtual address (VA) mappings. > > New UAPIs, motivated by Vulkan sparse memory bindings graphics drivers > start implementing, allow userspace appli

Re: [PATCH v2 03/27] drm/msm/dpu: move SSPP allocation to the RM

2023-01-26 Thread Abhinav Kumar
On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: Follow the example of all other hw blocks and initialize SSPP blocks in Resource Manager. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 17 - drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c| 22 ++

Re: [PATCH v2 02/27] drm/msm/dpu: rename struct dpu_hw_pipe to dpu_hw_sspp

2023-01-26 Thread Abhinav Kumar
On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: For all hardware blocks except SSPP the corresponding struct is named after the block. Rename dpu_hw_pipe (SSPP structure) to dpu_hw_sspp. Signed-off-by: Dmitry Baryshkov Idea seems okay but then we should also rename dpu_hw_pipe_cfg to dpu_

[PATCH v2 3/4] drm/bridge: tfp410: Fix logic to configured polled HPD

2023-01-26 Thread Jonathan Cormier
From: Michael Williamson The logic to configure polling (vs async/irq notification) of hot-plug events was not correct. If the connected bridge requires polling, then inform the upstream bridge we also require polling. Signed-off-by: Michael Williamson Signed-off-by: Jonathan Cormier --- dri

[PATCH v2 4/4] drm/bridge: tfp410: If connected, use I2C for polled HPD status.

2023-01-26 Thread Jonathan Cormier
From: Michael Williamson If the I2C bus is connected on the TFP410, then use the register status bit to determine connection state. This is needed, in particular, for polling the state when the Hot Plug detect is not connected to a controlling CPU via GPIO/IRQ lane. Signed-off-by: Michael Willi

[PATCH v2 2/4] drm/bridge: tfp410: Support basic I2C interface

2023-01-26 Thread Jonathan Cormier
From: Michael Williamson The TFP410 driver does not support I2C. As such, the device remains in Power Down if the I2C is enabled by the bootstrap pins. Add basic support for the I2C interface, and provide support to take the device out of power down when enabled. Also read the bootstrap mode p

[PATCH v2 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example

2023-01-26 Thread Jonathan Cormier
Add a i2c example with HDMI connector Signed-off-by: Jonathan Cormier --- .../bindings/display/bridge/ti,tfp410.yaml | 30 ++ 1 file changed, 30 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,tfp410.yaml b/Documentation/devicetree/bin

[PATCH v2 0/4] drm/bridge: tfp410: Add i2c support

2023-01-26 Thread Jonathan Cormier
The TFP410 driver does not support I2C. As such, the device remains in Power Down if the I2C is enabled by the bootstrap pins. Add basic support for the I2C interface, and provide support to take the device out of power down when enabled. Also read the bootstrap mode pins via the CTL_1_MODE regi

Re: [PATCH] dma-buf: actually set signaling bit for private sub fences

2023-01-26 Thread Danilo Krummrich
On 1/26/23 07:58, Christian König wrote: Am 26.01.23 um 01:28 schrieb Danilo Krummrich: In dma_fence_allocate_private_stub() set the signaling bit of the newly allocated private stub fence rather than the signaling bit of the shared dma_fence_stub. Fixes: c85d00d4fd8b ("dma-buf: set signaling b

[git pull] habanalabs pull request for kernel 6.3

2023-01-26 Thread Oded Gabbay
Hi Dave, Daniel. This is habanalabs and accel pull request for the merge window of kernel 6.3. First I want to say that it's been 4 years and 6 months since my last pull request to drm-next (for amdkfd) :) My pull request is formatted according to how Greg liked to get it. I hope the format is a

[PATCH] [v2] vfio-mdev: add back CONFIG_VFIO dependency

2023-01-26 Thread Arnd Bergmann
From: Arnd Bergmann CONFIG_VFIO_MDEV cannot be selected when VFIO itself is disabled, otherwise we get a link failure: WARNING: unmet direct dependencies detected for VFIO_MDEV Depends on [n]: VFIO [=n] Selected by [y]: - SAMPLE_VFIO_MDEV_MTTY [=y] && SAMPLES [=y] - SAMPLE_VFIO_MDEV_MDPY

Re: [PATCH] drm/amdgpu/display/mst: fix an unused-variable warning

2023-01-26 Thread Hamza Mahfooz
On 1/26/23 11:35, Arnd Bergmann wrote: From: Arnd Bergmann The newly added code is in an #ifdef, so the variables that are only used in there cause a warning if CONFIG_DRM_AMD_DC_DCN is disabled: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_atomic_check'

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Suren Baghdasaryan
On Thu, Jan 26, 2023 at 7:09 AM Matthew Wilcox wrote: > > On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote: > > On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > > > +/* Use when VMA is not part

Re: [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:47AM -0800, Suren Baghdasaryan wrote: > To simplify the usage of VM_LOCKED_CLEAR_MASK in clear_vm_flags(), > replace it with VM_LOCKED_MASK bitmask and convert all users. > > Signed-off-by: Suren Baghdasaryan Acked-by: Mike Rapoport (IBM) > --- > include/linux/mm

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Mike Rapoport
On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > vm_flags are among VMA attributes which affect decisions like VMA merging > > and splitting. Therefore all vm_flags modifications are performed after > > taking e

[PATCH] fbcon: Check font dimension limits

2023-01-26 Thread Samuel Thibault
blit_x and blit_y are uint32_t, so fbcon currently cannot support fonts larger than 32x32. The 32x32 case also needs shifting an unsigned int, to properly set bit 31, otherwise we get "UBSAN: shift-out-of-bounds in fbcon_set_font", as reported on http://lore.kernel.org/all/ia1pr07mb98308653e259a6

Re: [PATCH v2 6/6] mm: export dump_mm()

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:51AM -0800, Suren Baghdasaryan wrote: > mmap_assert_write_locked() is used in vm_flags modifiers. Because > mmap_assert_write_locked() uses dump_mm() and vm_flags are sometimes > modified from from inside a module, it's necessary to export > dump_mm() function. > > Si

UBSAN: shift-out-of-bounds in fbcon_set_font

2023-01-26 Thread Sanan Hasanov
Good day, dear maintainers, We found a bug using a modified kernel configuration file used by syzbot. We enhanced the coverage of the configuration file using our tool, klocalizer. Kernel Branch: 6.2.0-rc5-next-20230124 Kernel config:  https://drive.google.com/file/d/1F-LszDAizEEH0ZX0HcSR06v5q8F

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Matthew Wilcox
On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote: > On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote: > > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > > > +/* Use when VMA is not part of the VMA tree and needs no locking */ > > > +static inline voi

Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Sebastian Reichel
Hi, On Wed, Jan 25, 2023 at 12:38:48AM -0800, Suren Baghdasaryan wrote: > Replace direct modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan > --- > [...] > drivers/hsi/cl

Re: [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:49AM -0800, Suren Baghdasaryan wrote: > Replace indirect modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. Add a BUG_ON check in ksm_madvise() to catch indirect > vm_flags modificat

Re: [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:50AM -0800, Suren Baghdasaryan wrote: > In cases when VMA flags are modified after VMA was isolated and mmap_lock > was downgraded, flags modifications would result in an assertion because > mmap write lock is not held. > Introduce mod_vm_flags_nolock to be used in suc

Re: [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:48AM -0800, Suren Baghdasaryan wrote: > Replace direct modifications to vma->vm_flags with calls to modifier > functions to be able to track flag changes and to keep vma locking > correctness. > > Signed-off-by: Suren Baghdasaryan Acked-by: Mike Rapoport (IBM) > -

Re: [PATCH] fbcon: Check font dimension limits

2023-01-26 Thread Samuel Thibault
(FYI, the UB was already a problem before my big-font patch submission, the checks I add here are already making sense in previous versions anyway) Samuel Thibault, le jeu. 26 janv. 2023 01:49:12 +0100, a ecrit: > blit_x and blit_y are uint32_t, so fbcon currently cannot support fonts > larger tha

Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions

2023-01-26 Thread Mike Rapoport
On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote: > vm_flags are among VMA attributes which affect decisions like VMA merging > and splitting. Therefore all vm_flags modifications are performed after > taking exclusive mmap_lock to prevent vm_flags updates racing with such > opera

[PATCH] drm/amd/display: reduce else-if to else in dcn32_calculate_dlg_params()

2023-01-26 Thread Tom Rix
cppcheck reports drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c:1403:76: style: Expression is always true because 'else if' condition is opposite to previous condition at line 1396. [multiCondition] } else if (context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type == SUBVP_PHANTO

Re: [PATCH 3/9] drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state()

2023-01-26 Thread Imre Deak
On Thu, Jan 26, 2023 at 08:36:20PM +0200, Ville Syrjälä wrote: > On Wed, Jan 25, 2023 at 01:48:46PM +0200, Imre Deak wrote: > > Add a function to get the old MST topology state, required by a > > follow-up i915 patch. > > > > While at it clarify the code comment of > > drm_atomic_get_new_mst_topol

Re: [Intel-gfx] [PATCH 2/9] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-01-26 Thread Imre Deak
On Thu, Jan 26, 2023 at 08:33:42PM +0200, Ville Syrjälä wrote: > On Thu, Jan 26, 2023 at 07:37:04PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 25, 2023 at 01:48:45PM +0200, Imre Deak wrote: > > > Atm, drm_dp_remove_payload() uses the same payload state to both get the > > > vc_start_slot required

Re: [Lsf-pc] [LSF/MM/BPF proposal]: Physr discussion

2023-01-26 Thread Jason Gunthorpe
On Mon, Jan 23, 2023 at 12:50:52PM -0800, Dan Williams wrote: > Matthew Wilcox wrote: > > On Mon, Jan 23, 2023 at 11:36:51AM -0800, Dan Williams wrote: > > > Jason Gunthorpe via Lsf-pc wrote: > > > > I would like to have a session at LSF to talk about Matthew's > > > > physr discussion starter: > >

Re: [PATCH v2 01/27] drm/msm/dpu: set pdpu->is_rt_pipe early in dpu_plane_sspp_atomic_update()

2023-01-26 Thread Abhinav Kumar
On 12/29/2022 11:18 AM, Dmitry Baryshkov wrote: The function dpu_plane_sspp_atomic_update() updates pdpu->is_rt_pipe flag, but after the commit 854f6f1c653b ("drm/msm/dpu: update the qos remap only if the client type changes") it sets the flag late, after all the qos functions have updated QoS

Re: [PATCH] drm/ssd130x: Init display before the SSD130X_DISPLAY_ON command

2023-01-26 Thread Javier Martinez Canillas
On 1/25/23 20:56, Thomas Zimmermann wrote: > > > Am 25.01.23 um 19:42 schrieb Javier Martinez Canillas: >> Commit 622113b9f11f ("drm/ssd130x: Replace simple display helpers with the >> atomic helpers") changed the driver to just use the atomic helpers instead >> of the simple KMS abstraction laye

Re: [PATCH] drm/i915/guc: Fix missing ecodes

2023-01-26 Thread Teres Alexis, Alan Previn
Firstly, thanks for catching this miss. Since I only have one trivial nit and one non-blocker ask. and the non-blocker ask will not impact the patch intent as it merely tweaks an existing debug message, I believe we have an rb: Reviewed-by: Alan Previn On Tue, 2023-01-24 at 16:49 -0800, Harrison

Re: [PATCH] drm/msm/dpu: sc7180: add missing WB2 clock control

2023-01-26 Thread Dmitry Baryshkov
On Mon, 16 Jan 2023 12:30:55 +0200, Dmitry Baryshkov wrote: > Add missing DPU_CLK_CTRL_WB2 to sc7180_mdp clocks array. > > Applied, thanks! [1/1] drm/msm/dpu: sc7180: add missing WB2 clock control https://gitlab.freedesktop.org/lumag/msm/-/commit/255f056181ac Best regards, -- Dmitry B

Re: [PATCH] drm/msm/dpu: fix sm8450 CTL configuration

2023-01-26 Thread Dmitry Baryshkov
On Mon, 23 Jan 2023 10:08:18 +0200, Dmitry Baryshkov wrote: > Correct the CTL size on sm8450 platform. This fixes the incorrect merge > of sm8350 support, which unfortunately also touched the SM8450 setup. > > Applied, thanks! [1/1] drm/msm/dpu: fix sm8450 CTL configuration https://gitl

Re: [PATCH] drm/msm/mdp5: Add check for kzalloc

2023-01-26 Thread Dmitry Baryshkov
On Tue, 06 Dec 2022 15:48:19 +0800, Jiasheng Jiang wrote: > As kzalloc may fail and return NULL pointer, > it should be better to check the return value > in order to avoid the NULL pointer dereference. > > Applied, thanks! [1/1] drm/msm/mdp5: Add check for kzalloc https://gitlab.freede

Re: [PATCH v2] drm/msm/dpu: Add DSC hardware blocks to register snapshot

2023-01-26 Thread Dmitry Baryshkov
On Wed, 25 Jan 2023 11:14:11 +0100, Marijn Suijten wrote: > Add missing DSC hardware block register ranges to the snapshot utility > to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the > kms debugfs file. > > Applied, thanks! [1/1] drm/msm/dpu: Add DSC hardware blocks to r

Re: [PATCH] drm/msm: use strscpy instead of strncpy

2023-01-26 Thread Dmitry Baryshkov
On Wed, 18 Jan 2023 04:01:52 +0200, Dmitry Baryshkov wrote: > Using strncpy can result in non-NULL-terminated destination string. Use > strscpy instead. This fixes following warning: > > drivers/gpu/drm/msm/msm_fence.c: In function ‘msm_fence_context_alloc’: > drivers/gpu/drm/msm/msm_fence.c:25:

Re: [PATCH] drm/msm/dpu: Add check for pstates

2023-01-26 Thread Dmitry Baryshkov
On Tue, 06 Dec 2022 16:02:36 +0800, Jiasheng Jiang wrote: > As kzalloc may fail and return NULL pointer, > it should be better to check pstates > in order to avoid the NULL pointer dereference. > > Applied, thanks! [1/1] drm/msm/dpu: Add check for pstates https://gitlab.freedesktop.org/

Re: [PATCH v2] drm/msm/dpu: add missing ubwc_swizzle setting to catalog

2023-01-26 Thread Dmitry Baryshkov
On Mon, 23 Jan 2023 08:24:15 +0200, Dmitry Baryshkov wrote: > Use the values from the vendor DTs to set ubwc_swizzle in the catalog. > > Applied, thanks! [1/1] drm/msm/dpu: add missing ubwc_swizzle setting to catalog https://gitlab.freedesktop.org/lumag/msm/-/commit/31c318051040 Best r

Re: [PATCH] drm/msm/dpu: Add check for cstate

2023-01-26 Thread Dmitry Baryshkov
On Tue, 06 Dec 2022 16:05:17 +0800, Jiasheng Jiang wrote: > As kzalloc may fail and return NULL pointer, > it should be better to check cstate > in order to avoid the NULL pointer dereference > in __drm_atomic_helper_crtc_reset. > > Applied, thanks! [1/1] drm/msm/dpu: Add check for cstate

Re: [PATCH 0/4] dt-bindings: display/msm: more dsi-controller fixes

2023-01-26 Thread Dmitry Baryshkov
On Wed, 18 Jan 2023 05:24:28 +0200, Dmitry Baryshkov wrote: > A small set of patches to go on top of Bryan's changes to fix a small > number of remaining issues. > > Dependencies: [1] > > [1] > https://lore.kernel.org/linux-arm-msm/20230116225217.1056258-1-bryan.odonog...@linaro.org/ > > [...

Re: [PATCH 0/6] drm/msm/hdmi: integrate msm8960 HDMI PHY with DT clocks infrastructure

2023-01-26 Thread Dmitry Baryshkov
On Thu, 19 Jan 2023 15:22:13 +0200, Dmitry Baryshkov wrote: > Make msm8960's HDMI PHY accept clocks from DT and also register it as a > DT clock provider. > > Dmitry Baryshkov (6): > dt-bindings: phy: qcom,hdmi-phy-other: use pxo clock > dt-bindings: phy: qcom,hdmi-phy-other: mark it as cloc

Re: [PATCH] drm/msm/dsi: properly handle the case of empty OPP table in dsi_mgr_bridge_mode_valid

2023-01-26 Thread Dmitry Baryshkov
On Tue, 24 Jan 2023 22:36:00 +0200, Dmitry Baryshkov wrote: > It was left unnoticed during the review that even if there is no OPP > table in device tree, one will be created by a call to the function > devm_pm_opp_set_clkname(). This leads to dsi_mgr_bridge_mode_valid() > rejecting all modes if

Re: [PATCH] drm/msm/dpu: drop stale comment from struct dpu_mdp_cfg doc

2023-01-26 Thread Dmitry Baryshkov
On Sat, 21 Jan 2023 15:54:57 +0200, Dmitry Baryshkov wrote: > The field ubwc_static was removed from struct dpu_mdp_cfg some time ago. > Drop the corresponding kerneldoc now. > > Applied, thanks! [1/1] drm/msm/dpu: drop stale comment from struct dpu_mdp_cfg doc https://gitlab.freedeskto

Re: [PATCH 0/3] drm/msm/dpu: several fixes for UBWC setup

2023-01-26 Thread Dmitry Baryshkov
On Wed, 07 Dec 2022 16:28:30 +0200, Dmitry Baryshkov wrote: > Several small corrections for the UBWC setup and related data. > > Dmitry Baryshkov (3): > drm/msm/dpu: handle UBWC 1.0 in dpu_hw_sspp_setup_format > drm/msm/dpu: correct the UBWC version on sm6115 > drm/msm/dpu: add missing ubw

Re: [PATCH v9 0/2] mdss-dsi-ctrl binding and dts fixes

2023-01-26 Thread Dmitry Baryshkov
On Wed, 18 Jan 2023 17:16:19 +, Bryan O'Donoghue wrote: > V9: > - Adds Rob's RB to #1 > - Fixes two check splats - Dmitry > > V8: > - Squash first and last patch to fix bisectability > > [...] Applied, thanks! [1/2] dt-bindings: msm: dsi-controller-main: Add compatible strings for every

[PATCH 2/2] gpu: ipu-v3: pre: add dynamic buffer layout reconfiguration

2023-01-26 Thread Lucas Stach
imx-drm doesn't mandate a modeset when the framebuffer modifier changes, but currently the tile prefetch and resolve (TPR) configuration of the PRE is only set up on the initial modeset. As the TPR configuration is double buffered, same as all the other PRE states, we can support dynamic reconfigu

[PATCH 1/2] gpu: ipu-v3: pre: move state into struct

2023-01-26 Thread Lucas Stach
Move the variables tracking the current dynamic state into a struct to separate it a bit better from the static device properties. Signed-off-by: Lucas Stach --- drivers/gpu/ipu-v3/ipu-pre.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/drivers

Re: [PATCH 2/4] DRM: BRIDGE: TFP410: Support basic I2C interface

2023-01-26 Thread Jon Cormier
On Thu, Jan 26, 2023 at 10:41 AM Krzysztof Kozlowski < krzysztof.kozlow...@linaro.org> wrote: > On 25/01/2023 22:09, Jonathan Cormier wrote: > > From: Michael Williamson > > > > The TFP410 driver does not support I2C. As such, the device remains in > > Power Down if the I2C is enabled by the boo

[PULL] drm-intel-fixes

2023-01-26 Thread Rodrigo Vivi
Hi Dave and Daniel, nothing major or critical this round... Here goes drm-intel-fixes-2023-01-26: - Fix BSC default context for Meteor Lake (Lucas) - Fix selftest-scheduler's modify_type (Andi) Thanks, Rodrigo. The following changes since commit 2241ab53cbb5cdb08a6b2d4688feb13971058f65: Lin

Re: [PATCH 3/9] drm/display/dp_mst: Add drm_atomic_get_old_mst_topology_state()

2023-01-26 Thread Ville Syrjälä
On Wed, Jan 25, 2023 at 01:48:46PM +0200, Imre Deak wrote: > Add a function to get the old MST topology state, required by a > follow-up i915 patch. > > While at it clarify the code comment of > drm_atomic_get_new_mst_topology_state(). > > Cc: Lyude Paul > Cc: sta...@vger.kernel.org # 6.1 > Cc:

Re: [PATCH 1/4] dt-bindings: display: bridge: tfp410: Add tfp410 i2c example

2023-01-26 Thread Jon Cormier
On Thu, Jan 26, 2023 at 10:40 AM Krzysztof Kozlowski < krzysztof.kozlow...@linaro.org> wrote: > On 25/01/2023 22:09, Jonathan Cormier wrote: > > Add a i2c example with HDMI connector > > Why? It's the same - but more on this below. > The existing example is for the previous setup where it was conf

Re: [Intel-gfx] [PATCH 2/9] drm/display/dp_mst: Handle old/new payload states in drm_dp_remove_payload()

2023-01-26 Thread Ville Syrjälä
On Thu, Jan 26, 2023 at 07:37:04PM +0200, Ville Syrjälä wrote: > On Wed, Jan 25, 2023 at 01:48:45PM +0200, Imre Deak wrote: > > Atm, drm_dp_remove_payload() uses the same payload state to both get the > > vc_start_slot required for the payload removal DPCD message and to > > deduct time_slots from

  1   2   3   >