Re: [RFC PATCH v7] media: mediatek: vcodec: support stateless AV1 decode

2022-11-17 Thread Andrzej Pietrasiewicz
Hi, Did you receive my comments for v6? Regards, Andrzej W dniu 17.11.2022 o 10:43, Xiaoyong Lu pisze: Add mediatek av1 decoder linux driver which use the stateless API in MT8195. Signed-off-by: Xiaoyong Lu --- Changes from v6: - change slot_id type from u8 to s8 - test by av1 fluster, resu

[PATCH] drm/amdgpu: add mb for si

2022-11-17 Thread Zhenneng Li
During reboot test on arm64 platform, it may failure on boot, so add this mb in smc. The error message are as follows: [6.996395][ 7] [ T295] [drm:amdgpu_device_ip_late_init [amdgpu]] *ERROR* late_init of IP block failed -22 [7.006919][ 7] [ T295] amdgpu

linux-next: build warnings after merge of the amdgpu tree

2022-11-17 Thread Stephen Rothwell
Hi all, After merging the amdgpu tree, today's linux-next build (htmldocs) produced these warnings: drivers/gpu/drm/amd/display/dc/dc.h:548: warning: Function parameter or member 'dispclk_khz' not described in 'dc_clocks' drivers/gpu/drm/amd/display/dc/dc.h:548: warning: Function parameter or me

Re: [PATCH v8 03/14] drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge

2022-11-17 Thread Jagan Teki
On Thu, Nov 17, 2022 at 10:31 AM Marek Vasut wrote: > > On 11/10/22 19:38, Jagan Teki wrote: > > [...] > > > +static int samsung_dsim_wait_for_hdr_fifo(struct samsung_dsim *dsi) > > +{ > > + int timeout = 2000; > > + > > + do { > > + u32 reg = samsung_dsim_read(dsi, DSIM_FIFOCT

[PATCH v1] drm/mediatek: add dma buffer control for drm plane disable

2022-11-17 Thread Yongqiang Niu
get dma buffer when drm plane disable put dma buffer when overlay really disable Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 11 +++ drivers/gpu/drm/mediatek/mtk_drm_plane.c | 12 drivers/gpu/drm/mediatek/mtk_drm_plane.h | 1 + 3 files change

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-17 Thread Nilawar, Badal
On 18-11-2022 03:44, Rodrigo Vivi wrote: On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: From: Vinay Belgaumkar By defaut idle mesaging is disabled for GSC CS so to unblock RC6 entry on media tile idle messaging need to be enabled. v2: - Fix review comments (Vinay) - Set

Re: [PATCH] dma-buf: Fix possible UAF in dma_buf_export

2022-11-17 Thread T.J. Mercier
On Thu, Nov 17, 2022 at 2:16 AM Christian König wrote: > > Am 17.11.22 um 08:48 schrieb Charan Teja Kalla: > > Sometime back Dan also reported the same issue[1] where I do mentioned > > that fput()-->dma_buf_file_release() will remove it from the list. > > > > But it seems that I failed to notice

[PATCH] drm: Fix potential null-ptr-deref due to drmm_mode_config_init()

2022-11-17 Thread Shang XiaoJing
drmm_mode_config_init() will call drm_mode_create_standard_properties() and won't check the ret value. When drm_mode_create_standard_properties() failed due to alloc, property will be a NULL pointer and may causes the null-ptr-deref. Fix the null-ptr-deref by adding the ret value check. Found null

[PATCH v2 4/5] drm/i915/guc: Add GuC CT specific debug print wrappers

2022-11-17 Thread John . C . Harrison
From: John Harrison Re-work the existing GuC CT printers and extend as required to match the new wrapping scheme. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 222 +++--- 1 file changed, 113 insertions(+), 109 deletions(-) diff --git a/drivers/g

[PATCH v2 5/5] drm/i915/uc: Update the gt/uc code to use gt_err and friends

2022-11-17 Thread John . C . Harrison
From: John Harrison Use the new module oriented output message helpers where possible. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_uc.c| 108 +++ drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 98 ++-- 2 files changed, 99 insertions(+)

[PATCH v2 2/5] drm/i915/huc: Add HuC specific debug print wrappers

2022-11-17 Thread John . C . Harrison
From: John Harrison Create a set of HuC printers and start using them. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_huc.c | 31 ++ drivers/gpu/drm/i915/gt/uc/intel_huc.h | 23 +++ 2 files changed, 35 insertions(+), 19 deletions(-) d

[PATCH v2 3/5] drm/i915/guc: Add GuC specific debug print wrappers

2022-11-17 Thread John . C . Harrison
From: John Harrison Create a set of GuC printers and start using them. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.c| 32 -- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 35 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c| 8 +-- .../gpu

[PATCH v2 0/5] Add module oriented dmesg output

2022-11-17 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

[PATCH v2 1/5] drm/i915/gt: Start adding module oriented dmesg output

2022-11-17 Thread John . C . Harrison
From: John Harrison When trying to analyse bug reports from CI, customers, etc. it can be difficult to work out exactly what is happening on which GT in a multi-GT system. So add GT oriented debug/error message wrappers. If used instead of the drm_ equivalents, you get the same output but with a

[PATCH v1 2/2] drm/virtio: Add the hotplug_mode_update property for rescanning of modes

2022-11-17 Thread Vivek Kasireddy
Setting this property will allow the userspace to look for new modes or position info when a hotplug event occurs. This is really helpful for virtual GPU drivers to handle Host window resizing events which are propogated as hotplug interrupts to the Guest drivers. Mutter already uses this property

[PATCH v1 1/2] drm/virtio: Attach and set suggested_x/y properties for the connector

2022-11-17 Thread Vivek Kasireddy
These properties provide a way to suggest to the userspace the preferred positions for the outputs. Mutter already uses these properties to determine the best positions for the outputs. Cc: Gerd Hoffmann Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- drivers/gpu/drm/virtio/virtgpu_display.

[PATCH v1 0/2] drm/virtio: Add hotplug_mode_update and suggested_x/y properties

2022-11-17 Thread Vivek Kasireddy
These properties provide a way to influence the userspace with regard to positioning of the outputs and also enable it to look for new preferred modes when hotplug interrupts occur. These properties are currently used by other virtual GPU drivers such as vmwgfx and qxl. Testcase: After positioni

[PATCH 1/3] drm/tiny: rpi-lcd-35: Enable driver module autoloading

2022-11-17 Thread Carlo Caione
SPI devices use the spi_device_id for module autoloading even on systems using device tree. Add the spi_device_id entry to enable autoloading for the 3.5inch RPi Display (rpi-lcd-35). Signed-off-by: Carlo Caione --- drivers/gpu/drm/tiny/ili9486.c | 1 + 1 file changed, 1 insertion(+) diff --gi

Re: [PATCH v3 1/6] dt-bindings: media: Add macros for video interface bus types

2022-11-17 Thread Paul Elder
On Thu, Jun 16, 2022 at 01:14:05AM +0300, Laurent Pinchart wrote: > Add a new dt-bindings/media/video-interfaces.h header that defines > macros corresponding to the bus types from media/video-interfaces.yaml. > This allows avoiding hardcoded constants in device tree sources. > > Signed-off-by: Lau

Re: [PATCH 3/3] spi: meson-spicc: Lower CS between bursts

2022-11-17 Thread Carlo Caione
On 17/11/2022 09:54, Neil Armstrong wrote: I'm afraid this will actually break SPI NORs for example where CS actually splits transactions. Isn't Amjad change enough ? The CLK pull-up should avoid this. It looks like it is not enough unfortunately. If it's not the case, then it's an HW issue

[PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Carlo Caione
The ILI9486 driver is wrongly assuming that the SPI panel is interfaced only with 8-bit SPI controllers and consequently that the pixel data passed by the MIPI DBI subsystem are already swapped before being sent over SPI using 8 bits-per-word. This is not always true for all the SPI controllers.

[PATCH 0/3] Fix SPICC and ILI9486 drivers

2022-11-17 Thread Carlo Caione
This patchset is trying to fix problems seen on S905X boards when interfacing with an ILI9486 equipped SPI panel. The color corruption and the performance issues are actually due to two different problems in the SPICC driver and in the ILI9486 tiny DRM driver. We try to fix both in the same patch

Re: [PATCH 2/3] drm/tiny: ili9486: Do not assume 8-bit only SPI controllers

2022-11-17 Thread Carlo Caione
On 17/11/2022 12:09, Mark Brown wrote: I don't understand what the commit log is saying here. The meson-spicc driver advertises support for 8 bit words, if the driver is sending data formatted as a byte stream everything should be fine. It may be that there is some optimisation available from

[PATCH 3/3] spi: meson-spicc: Lower CS between bursts

2022-11-17 Thread Carlo Caione
On some hardware (reproduced on S905X) when a large payload is transmitted over SPI in bursts at the end of each burst, the clock line briefly fluctuates creating spurious clock transitions that are being recognised by the connected device as a genuine pulses, creating an offset in the data being t

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-17 Thread Kees Cook
On Thu, Nov 17, 2022 at 03:20:01PM -0800, Linus Torvalds wrote: > On Thu, Nov 17, 2022 at 2:58 PM Kees Cook wrote: > > > > Oh, er, why does get_arg_page() even need FOLL_FORCE? This is writing the > > new stack contents to the nascent brpm->vma, which was newly allocated > > with VM_STACK_FLAGS, w

Re: linux-next: manual merge of the drm-misc tree with the origin tree

2022-11-17 Thread Nathan Chancellor
On Fri, Nov 18, 2022 at 09:06:36AM +1100, Stephen Rothwell wrote: > Hi Nathan, > > On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor > wrote: > > > > This resolution is not quite right, as pointed out by clang: > > > > drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-17 Thread Linus Torvalds
On Thu, Nov 17, 2022 at 2:58 PM Kees Cook wrote: > > Oh, er, why does get_arg_page() even need FOLL_FORCE? This is writing the > new stack contents to the nascent brpm->vma, which was newly allocated > with VM_STACK_FLAGS, which an arch can override, but they all appear to > include > VM_WRITE |

Re: [PATCH] drm/sti: Fix return type of sti_{dvo,hda,hdmi}_connector_mode_valid()

2022-11-17 Thread Kees Cook
On Mon, Nov 14, 2022 at 03:03:47PM -0700, Nathan Chancellor wrote: > Hi all, > > On Wed, Nov 02, 2022 at 08:56:23AM -0700, Nathan Chancellor wrote: > > With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), > > indirect call targets are validated against the expected function > > poi

Re: [PATCH] drm/fsl-dcu: Fix return type of fsl_dcu_drm_connector_mode_valid()

2022-11-17 Thread Kees Cook
On Mon, Nov 14, 2022 at 03:03:05PM -0700, Nathan Chancellor wrote: > Hi all, > > On Wed, Nov 02, 2022 at 08:42:15AM -0700, Nathan Chancellor wrote: > > With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG), > > indirect call targets are validated against the expected function > > poi

Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE

2022-11-17 Thread Kees Cook
On Wed, Nov 16, 2022 at 10:16:34AM -0800, Linus Torvalds wrote: > There _are_ also small random cases too, like get_cmdline(). Maybe > that counts as ptrace, but the execve() case most definitely does not. Oh, er, why does get_arg_page() even need FOLL_FORCE? This is writing the new stack contents

[PATCH v3 2/2] drm/msm/dp: add support of max dp link rate

2022-11-17 Thread Kuogee Hsieh
dp_out endpoint contains both data-lanes and link-frequencies properties. This patch parser dp_out endpoint properties and acquire dp_max_lanes and dp_max_link_rate from respective property. Finally, comparing them against both data lane and link rate read back from sink to ensure both data lane an

[PATCH v3 0/2] Add data-lanes and link-frequencies to dp_out endpoint

2022-11-17 Thread Kuogee Hsieh
Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (2): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint drm/msm/dp: add support of max dp link rate arch/arm64/boot/dts/qcom/sc7180-trogdor.dts

[PATCH v3 1/2] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-11-17 Thread Kuogee Hsieh
Add both data-lanes and link-frequencies property to dp_out endpoint. Also set link-frequencies to 81 khz at herobrine platform to have max link rate limited at 81 khz (HBR3). Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 9 - arch/arm64/boot/d

Re: [PATCH] drm/i915: rename intel_gsc to intel_heci_gsc

2022-11-17 Thread Ceraolo Spurio, Daniele
On 11/3/2022 3:41 AM, Winkler, Tomas wrote: Starting on MTL, the GSC FW is loaded at runtime and will be managed directly by i915. This means we now have a naming clash around the GSC, as we have 2 different aspects of it that we need to handle: the HECI interfaces we export pre-mtl and the ne

[GIT PULL] drm/tegra: Fixes for v6.1-rc6

2022-11-17 Thread Thierry Reding
Hi Dave, Daniel, The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/tegra.git tags/drm/tegra/for-6.1-rc6 for you to fetch changes up to ce071fc9cea

Re: [PATCH -next] drm/amd/display: fix kernel-doc issues in dc.h

2022-11-17 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Nov 17, 2022 at 2:39 PM Harry Wentland wrote: > > > > On 11/17/22 12:20, Randy Dunlap wrote: > > Fix these kernel-doc complaints: > > > > drivers/gpu/drm/amd/display/dc/dc.h:505: warning: cannot understand > > function prototype: 'struct dc_clocks ' > > dc.h:472:

Coverity: drm_mode_parse_cmdline_named_mode(): Security best practices violations

2022-11-17 Thread coverity-bot
Hello! This is an experimental semi-automated report about issues detected by Coverity from a scan of next-20221117 as part of the linux-next scan project: https://scan.coverity.com/projects/linux-next-weekly-scan You're getting this email because you were associated with the identified lin

Re: [Intel-gfx] [PATCH 1/1] drm/i915/mtl: Enable Idle Messaging for GSC CS

2022-11-17 Thread Rodrigo Vivi
On Tue, Nov 15, 2022 at 07:14:40PM +0530, Badal Nilawar wrote: > From: Vinay Belgaumkar > > By defaut idle mesaging is disabled for GSC CS so to unblock RC6 > entry on media tile idle messaging need to be enabled. > > v2: > - Fix review comments (Vinay) > - Set GSC idle hysterisis to 5 us (Bad

Re: linux-next: manual merge of the drm-misc tree with the origin tree

2022-11-17 Thread Stephen Rothwell
Hi Nathan, On Thu, 17 Nov 2022 10:29:33 -0700 Nathan Chancellor wrote: > > This resolution is not quite right, as pointed out by clang: > > drivers/gpu/drm/vc4/vc4_hdmi.c:351:14: error: variable 'vc4_hdmi' is > uninitialized when used here [-Werror,-Wuninitialized] > mutex_lock(

Re: [Intel-gfx] [PATCH 0/5] i915: CAGF and RC6 changes for MTL

2022-11-17 Thread Rodrigo Vivi
On Mon, Nov 14, 2022 at 06:03:43PM +0530, Badal Nilawar wrote: > This series includes the code changes to get CAGF, RC State and C6 > Residency of MTL. > > v3: Included "Use GEN12 RPSTAT register" patch > > v4: > - Rebased > - Dropped "Use GEN12 RPSTAT register" patch from this series > g

Re: [PATCH] drm/amd/dc/dce120: Fix audio register mapping, stop triggering KASAN

2022-11-17 Thread Alex Deucher
On Mon, Nov 14, 2022 at 5:21 PM Lyude Paul wrote: > > There's been a very long running bug that seems to have been neglected for > a while, where amdgpu consistently triggers a KASAN error at start: > > BUG: KASAN: global-out-of-bounds in read_indirect_azalia_reg+0x1d4/0x2a0 > [amdgpu] > Read

Re: The state of Quantization Range handling

2022-11-17 Thread Sebastian Wick
On Wed, Nov 16, 2022 at 1:34 PM Pekka Paalanen wrote: > > On Tue, 15 Nov 2022 00:11:56 +0100 > Sebastian Wick wrote: > > > There are still regular bug reports about monitors (sinks) and sources > > disagreeing about the quantization range of the pixel data. In > > particular sources sending full

Re: The state of Quantization Range handling

2022-11-17 Thread Sebastian Wick
Hi Yussuf, On Tue, Nov 15, 2022 at 5:26 PM Yussuf Khalil wrote: > > Hello Sebastian, > > I've previously done some work on this topic [1]. My efforts were mostly about > fixing the situation regarding overrides and providing proper means for > userspace. I am affected by the issue myself as I own

Re: [PATCH 5/5] drm/panel-samsung-atna33xc20: Extend autosuspend delay

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport wrote: > > Avoid the panel oscillating on and off during boot. In some cases it > will be more than 1000ms between powering the panel to read the EDID early > during boot, and enabling the panel for display. Extending the > autosuspend delay avo

Re: [PATCH 4/5] drm/bridge/parade-ps8640: Extend autosuspend

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport wrote: > > Same change as done for panel-samsung-atna33xc20. Extend the autosuspend > delay to avoid oscillating between power status during boot. > > Signed-off-by: Drew Davenport > --- > > drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++-- > 1

Re: [PATCH 3/5] drm/panel-simple: Use ktime_get_boottime for delays

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport wrote: > > ktime_get_boottime continues while the device is suspended. This change > ensures that the resume path will not be delayed if the power off delay > has already been met while the device is suspended > > Signed-off-by: Drew Davenport

Re: [PATCH 2/5] drm/panel-samsung-atna33xc20: Use ktime_get_boottime for delays

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport wrote: > > ktime_get_boottime continues while the device is suspended. This change > ensures that the resume path will not be delayed if the power off delay > has already been met while the device is suspended > > Signed-off-by: Drew Davenport

Re: [PATCH 1/5] drm/panel-edp: Use ktime_get_boottime for delays

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport wrote: > > ktime_get is based on CLOCK_MONOTONIC which stops on suspend. On > suspend, the time that the panel was powerd off is recorded with > ktime_get, and on resume this time is compared to the current ktime_get > time to determine if the d

Re: [PATCH] drm/panel-edp: Use ktime_get_boottime for delays

2022-11-17 Thread Doug Anderson
Hi, On Fri, Nov 11, 2022 at 12:44 PM Doug Anderson wrote: > > Hi, > > On Thu, Nov 10, 2022 at 1:51 PM Drew Davenport > wrote: > > > > ktime_get is based on CLOCK_MONOTONIC which stops on suspend. On > > suspend, the time that the panel was powerd off is recorded with > > ktime_get, and on resum

Re: The state of Quantization Range handling

2022-11-17 Thread Sebastian Wick
Hi Dave, I noticed that I didn't get the Broadcast RGB property thanks to you (more below) On Tue, Nov 15, 2022 at 2:16 PM Dave Stevenson wrote: > > Hi Sebastian > > Thanks for starting the conversation - it's stalled a number of times > previously. > > On Mon, 14 Nov 2022 at 23:12, Sebastian Wi

[PATCH 5/5] drm/panel-samsung-atna33xc20: Extend autosuspend delay

2022-11-17 Thread Drew Davenport
Avoid the panel oscillating on and off during boot. In some cases it will be more than 1000ms between powering the panel to read the EDID early during boot, and enabling the panel for display. Extending the autosuspend delay avoids autosuspending during this interval. Signed-off-by: Drew Davenport

[PATCH 2/5] drm/panel-samsung-atna33xc20: Use ktime_get_boottime for delays

2022-11-17 Thread Drew Davenport
ktime_get_boottime continues while the device is suspended. This change ensures that the resume path will not be delayed if the power off delay has already been met while the device is suspended Signed-off-by: Drew Davenport --- drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 8 1 f

[PATCH 3/5] drm/panel-simple: Use ktime_get_boottime for delays

2022-11-17 Thread Drew Davenport
ktime_get_boottime continues while the device is suspended. This change ensures that the resume path will not be delayed if the power off delay has already been met while the device is suspended Signed-off-by: Drew Davenport --- drivers/gpu/drm/panel/panel-simple.c | 6 +++--- 1 file changed, 3

[PATCH 4/5] drm/bridge/parade-ps8640: Extend autosuspend

2022-11-17 Thread Drew Davenport
Same change as done for panel-samsung-atna33xc20. Extend the autosuspend delay to avoid oscillating between power status during boot. Signed-off-by: Drew Davenport --- drivers/gpu/drm/bridge/parade-ps8640.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH 1/5] drm/panel-edp: Use ktime_get_boottime for delays

2022-11-17 Thread Drew Davenport
ktime_get is based on CLOCK_MONOTONIC which stops on suspend. On suspend, the time that the panel was powerd off is recorded with ktime_get, and on resume this time is compared to the current ktime_get time to determine if the driver should wait for the panel to power down completely before re-enab

Re: [PATCH -next] drm/amd/display: fix kernel-doc issues in dc.h

2022-11-17 Thread Harry Wentland
On 11/17/22 12:20, Randy Dunlap wrote: > Fix these kernel-doc complaints: > > drivers/gpu/drm/amd/display/dc/dc.h:505: warning: cannot understand function > prototype: 'struct dc_clocks ' > dc.h:472: warning: Enum value 'MPC_SPLIT_AVOID' not described in enum > 'pipe_split_policy' > dc.h:472:

[PATCH v3 3/8] dt-bindings: reserved-memory: Support framebuffer reserved memory

2022-11-17 Thread Thierry Reding
From: Thierry Reding Document the "framebuffer" compatible string for reserved memory nodes to annotate reserved memory regions used for framebuffer carveouts. Reviewed-by: Rob Herring Signed-off-by: Thierry Reding --- Changes in v2: - use four spaces for indentation in example (as recommended

[PATCH v3 6/8] drm/format-helper: Support the XB24 format

2022-11-17 Thread Thierry Reding
From: Thierry Reding Add a conversion helper for the XB24 format to use in drm_fb_blit(). Signed-off-by: Thierry Reding --- Changes in v3: - rebase onto latest drm-next Changes in v2: - support XB24 format instead of AB24 drivers/gpu/drm/drm_format_helper.c | 39 +

[PATCH v3 8/8] arm64: tegra: Add simple framebuffer on Jetson Xavier NX

2022-11-17 Thread Thierry Reding
From: Thierry Reding Add the framebuffer carveout reserved memory node as well as a simple- framebuffer node that is used to bind to the framebuffer that the bootloader has set up. Signed-off-by: Thierry Reding --- Changes in v2: - clear out dynamic fields and leave it up to firmware to fill th

[PATCH v3 4/8] drm/simpledrm: Use struct iosys_map consistently

2022-11-17 Thread Thierry Reding
From: Thierry Reding The majority of the driver already uses struct iosys_map to encapsulate accesses to I/O remapped vs. system memory. Accesses via the screen base pointer still use __iomem annotations, which can lead to inconsistencies and conflicts with subsequent patches. Convert the screen

[PATCH v3 7/8] drm/simpledrm: Support the XB24/AB24 format

2022-11-17 Thread Thierry Reding
From: Thierry Reding Add XB24 and AB24 to the list of supported formats. The format helpers support conversion to these formats and they are documented in the simple-framebuffer device tree bindings. Signed-off-by: Thierry Reding --- Changes in v2: - treat AB24 as XB24 and support both at the s

[PATCH v3 2/8] dt-bindings: display: simple-framebuffer: Document 32-bit BGR format

2022-11-17 Thread Thierry Reding
From: Thierry Reding This is a variant of the 32-bit RGB format where the red and blue components are swapped. Reviewed-by: Rob Herring Signed-off-by: Thierry Reding --- .../devicetree/bindings/display/simple-framebuffer.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Docum

[PATCH v3 5/8] drm/simpledrm: Add support for system memory framebuffers

2022-11-17 Thread Thierry Reding
From: Thierry Reding Simple framebuffers can be set up in system memory, which cannot be requested and/or I/O remapped using the I/O resource helpers. Add a separate code path that obtains system memory framebuffers from the reserved memory region referenced in the memory-region property. Signed

[PATCH v3 1/8] dt-bindings: display: simple-framebuffer: Support system memory framebuffers

2022-11-17 Thread Thierry Reding
From: Thierry Reding In order to support framebuffers residing in system memory, allow the memory-region property to override the framebuffer memory specification in the "reg" property. Reviewed-by: Rob Herring Signed-off-by: Thierry Reding --- .../devicetree/bindings/display/simple-framebuff

[PATCH v3 0/8] drm/simpledrm: Support system memory framebuffers

2022-11-17 Thread Thierry Reding
From: Thierry Reding Hi, this series of patches adds support for framebuffers residing in system memory to the simple-framebuffer DRM driver. To do this, the DT bindings are extended do accept the memory-region property in addition to the reg property for specifying the framebuffer memory. This

[PULL] drm-misc-fixes

2022-11-17 Thread Maarten Lankhorst
Hi Dave, Daniel, A few fixes for v6.1-rc6. Most important one apears to be reverting a change that breaks DP-MST. drm-misc-fixes-2022-11-17: drm-misc-fixes for v6.1-rc6: - Fix error handling in vc4_atomic_commit_tail() - Set bpc for logictechno panels. - Fix potential memory leak in drm_dev_ini

Re: [PATCH v1 2/8] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-11-17 Thread Krzysztof Kozlowski
On 17/11/2022 13:25, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Extend the Renesas DSI display bindings to support the r8a779g0 V4H. > > Signed-off-by: Tomi Valkeinen Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 1/8] dt-bindings: display: renesas, du: Provide bindings for r8a779g0

2022-11-17 Thread Krzysztof Kozlowski
On 17/11/2022 13:25, Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Extend the Renesas DU display bindings to support the r8a779g0 V4H. > > Signed-off-by: Tomi Valkeinen > --- > Documentation/devicetree/bindings/display/renesas,du.yaml | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Kr

Re: [PATCH v4] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-17 Thread Christian König
Am 17.11.22 um 18:32 schrieb Dmitry Osipenko: On 11/17/22 20:08, Lukasz Wiecaszek wrote: On Thu, Nov 17, 2022 at 12:04:35PM +0300, Dmitry Osipenko wrote: Hi, On 11/17/22 07:58, Lukasz Wiecaszek wrote: The reason behind that patch is associated with videobuf2 subsystem (or more genrally with v

Re: [PATCH v1] dt-bindings: display: Convert fsl,imx-fb.txt to dt-schema

2022-11-17 Thread Krzysztof Kozlowski
On 16/11/2022 18:49, Philipp Zabel wrote: > On Thu, Nov 10, 2022 at 10:49:45AM +0100, Uwe Kleine-König wrote: > [...] >> new file mode 100644 >> index ..c3cf6f92a766 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml >> @@ -0,0 +1,110 @@ >> +# SPDX

[PATCH] drm/i915/gt: Manage uncore->lock while waiting on MCR register

2022-11-17 Thread Matt Roper
The GT MCR code currently relies on uncore->lock to avoid race conditions on the steering control register during MCR operations. The *_fw() versions of MCR operations expect the caller to already hold uncore->lock, while the non-fw variants manage the lock internally. However the sole callsite of

Re: [PATCH v4] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-17 Thread Dmitry Osipenko
On 11/17/22 20:08, Lukasz Wiecaszek wrote: > On Thu, Nov 17, 2022 at 12:04:35PM +0300, Dmitry Osipenko wrote: >> Hi, >> >> On 11/17/22 07:58, Lukasz Wiecaszek wrote: >>> The reason behind that patch is associated with videobuf2 subsystem >>> (or more genrally with v4l2 framework) and user created >

Re: [PATCH v2 2/2] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-17 Thread Nathan Chancellor
On Thu, Nov 17, 2022 at 09:28:49AM -0800, Nick Desaulniers wrote: > On Thu, Nov 10, 2022 at 02:47:52PM +0100, José Expósito wrote: > > Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduced > > the vc4_hdmi_reset_link() function. This function dereferences the > > "connector" point

Re: [PATCH] drm/amd/display: add FB_DAMAGE_CLIPS support

2022-11-17 Thread Leo Li
On 11/15/22 15:24, Hamza Mahfooz wrote: Currently, userspace doesn't have a way to communicate selective updates to displays. So, enable support for FB_DAMAGE_CLIPS for DCN ASICs newer than DCN301, convert DRM damage clips to dc dirty rectangles and fill them into dirty_rects in fill_dc_dirty_

Re: linux-next: manual merge of the drm-misc tree with the origin tree

2022-11-17 Thread Nathan Chancellor
Hi Stephen, On Wed, Nov 16, 2022 at 10:57:02AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/vc4/vc4_hdmi.c > > between commit: > > 682f99b8ae88 ("drm/vc4: hdmi: Take our lock to reset the link") > > from

Re: [PATCH v2 2/2] drm/vc4: hdmi: Fix pointer dereference before check

2022-11-17 Thread Nick Desaulniers
On Thu, Nov 10, 2022 at 02:47:52PM +0100, José Expósito wrote: > Commit 6bed2ea3cb38 ("drm/vc4: hdmi: Reset link on hotplug") introduced > the vc4_hdmi_reset_link() function. This function dereferences the > "connector" pointer before checking whether it is NULL or not. > > Rework variable assignm

Re: [PATCH v6 1/3] drm_bridge: register content protect property

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 9:12 AM Hsin-Yi Wang wrote: > > On Thu, Nov 17, 2022 at 11:57 PM Doug Anderson wrote: > > > > Hi, > > > > On Thu, Nov 17, 2022 at 3:08 AM Hsin-Yi Wang wrote: > > > > > > Some bridges are able to update HDCP status from userspace request if > > > they support HDCP. >

Re: [v2,5/6] drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer

2022-11-17 Thread Marek Szyprowski
On 17.11.2022 17:07, Thomas Zimmermann wrote: > Am 17.11.22 um 13:57 schrieb Marek Szyprowski: >> On 15.11.2022 12:58, Thomas Zimmermann wrote: >>> Schedule the deferred-I/O worker instead of the damage worker after >>> writing to the fbdev framebuffer. The deferred-I/O worker then performs >>> the

[PATCH -next] drm/amd/display: fix kernel-doc issues in dc.h

2022-11-17 Thread Randy Dunlap
Fix these kernel-doc complaints: drivers/gpu/drm/amd/display/dc/dc.h:505: warning: cannot understand function prototype: 'struct dc_clocks ' dc.h:472: warning: Enum value 'MPC_SPLIT_AVOID' not described in enum 'pipe_split_policy' dc.h:472: warning: Enum value 'MPC_SPLIT_AVOID_MULT_DISP' not des

[PATCH v5] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-17 Thread Lukasz Wiecaszek
The reason behind that patch is associated with videobuf2 subsystem (or more genrally with v4l2 framework) and user created dma buffers (udmabuf). In some circumstances when dealing with V4L2_MEMORY_DMABUF buffers videobuf2 subsystem wants to use dma_buf_vmap() method on the attached dma buffer. As

Re: [PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards

2022-11-17 Thread Maxime Ripard
On Thu, Nov 17, 2022 at 04:49:28PM +0100, Mauro Carvalho Chehab wrote: > On Thu, 17 Nov 2022 10:29:01 +0100 > Maxime Ripard wrote: > > > From: Mateusz Kwiatkowski > > > > Add support for the following composite output modes (all of them are > > somewhat more obscure than the previously defined

Re: [PATCH v6 1/3] drm_bridge: register content protect property

2022-11-17 Thread Hsin-Yi Wang
On Thu, Nov 17, 2022 at 11:57 PM Doug Anderson wrote: > > Hi, > > On Thu, Nov 17, 2022 at 3:08 AM Hsin-Yi Wang wrote: > > > > Some bridges are able to update HDCP status from userspace request if > > they support HDCP. > > > > HDCP property is the same as other connector properties that needs to

Re: [PATCH v4] udmabuf: add vmap and vunmap methods to udmabuf_ops

2022-11-17 Thread Lukasz Wiecaszek
On Thu, Nov 17, 2022 at 12:04:35PM +0300, Dmitry Osipenko wrote: > Hi, > > On 11/17/22 07:58, Lukasz Wiecaszek wrote: > > The reason behind that patch is associated with videobuf2 subsystem > > (or more genrally with v4l2 framework) and user created > > dma buffers (udmabuf). In some circumstances

DRM-managed resources / devm_drm_dev_alloc leaking resources

2022-11-17 Thread Maxime Ripard
Hi, After trying to get more kunit tests for KMS, I found out that the recent kunit helpers we merged to create a DRM device [1] are broken and won't free their device-managed and DRM-managed resources. With some help from Thomas, we've dug into this and it turns out that if we allocate a device

Re: [v2,5/6] drm/fb-helper: Schedule deferred-I/O worker after writing to framebuffer

2022-11-17 Thread Thomas Zimmermann
sha256_arm cfg80211 snd_soc_core ac97_bus snd_pcm_dmaengine hci_uart btbcm snd_pcm snd_timer snd crc32_arm_ce soundcore raspberrypi_hwmon drm_dma_helper bluetooth bcm2835_thermal ecdh_generic ecc libaes CPU: 0 PID: 220 Comm: systemd-udevd Not tainted 6.1.0-rc5-next-20221117-00041-g13334c897c2b #5953 Har

Re: [PATCH v6 1/3] drm_bridge: register content protect property

2022-11-17 Thread Doug Anderson
Hi, On Thu, Nov 17, 2022 at 3:08 AM Hsin-Yi Wang wrote: > > Some bridges are able to update HDCP status from userspace request if > they support HDCP. > > HDCP property is the same as other connector properties that needs to be > created after the connecter is initialized and before the connector

Re: [PATCH] drm/i915/huc: fix leak of debug object in huc load fence on driver unload

2022-11-17 Thread Ceraolo Spurio, Daniele
On 11/16/2022 5:29 PM, Brian Norris wrote: Hi Daniele, On Thu, Nov 10, 2022 at 04:56:51PM -0800, Daniele Ceraolo Spurio wrote: The fence is always initialized in huc_init_early, but the cleanup in huc_fini is only being run if HuC is enabled. This causes a leaking of the debug object when Hu

Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 15:49:36) > On 17/11/2022 17:46, Kieran Bingham wrote: > >> + if (ret) > >> + return ret; > >> + > >> + if (setup_info->hsfreq <= MHZ(1000)) > >> + ret = WRITE_PHTW(0x01020100, 0x01910170, 0x01020171, > >> +

Re: [PATCH v10 18/19] drm/vc4: vec: Add support for more analog TV standards

2022-11-17 Thread Mauro Carvalho Chehab
On Thu, 17 Nov 2022 10:29:01 +0100 Maxime Ripard wrote: > From: Mateusz Kwiatkowski > > Add support for the following composite output modes (all of them are > somewhat more obscure than the previously defined ones): > > - NTSC_443 - NTSC-style signal with the chroma subcarrier shifted to >

Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-17 Thread Tomi Valkeinen
On 17/11/2022 17:46, Kieran Bingham wrote: + if (ret) + return ret; + + if (setup_info->hsfreq <= MHZ(1000)) + ret = WRITE_PHTW(0x01020100, 0x01910170, 0x01020171, +0x01110172); The <=1Gbps reads: <=1Gbps Set PHTW=H’010201

Re: [PATCH v1 7/8] drm: rcar-du: dsi: Add r8A779g0 support

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:46) > From: Tomi Valkeinen > > Add DSI support for r8a779g0. The main differences to r8a779a0 are in > the PLL and PHTW setups. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_mipi_dsi.c | 484 +++ > drivers/g

Re: Try to address the DMA-buf coherency problem

2022-11-17 Thread Nicolas Dufresne
Le jeudi 17 novembre 2022 à 13:10 +0100, Christian König a écrit : > > > DMA-Buf let's the exporter setup the DMA addresses the importer uses to > > > be able to directly decided where a certain operation should go. E.g. we > > > have cases where for example a P2P write doesn't even go to memory, b

Re: [PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-11-17 Thread Daniel Vetter
On Fri, Nov 18, 2022 at 12:27:58AM +0900, Tetsuo Handa wrote: > A kernel built with syzbot's config file reported that > > scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)) > > causes uninitialized "save" to be copied. > > -- > [drm] Initialized vgem 1.0.0 20120112 for vge

[PATCH] fbcon: Use kzalloc() in fbcon_prepare_logo()

2022-11-17 Thread Tetsuo Handa
A kernel built with syzbot's config file reported that scr_memcpyw(q, save, array3_size(logo_lines, new_cols, 2)) causes uninitialized "save" to be copied. -- [drm] Initialized vgem 1.0.0 20120112 for vgem on minor 0 [drm] Initialized vkms 1.0.0 20180514 for vkms on minor 1 Con

Re: [PATCH] drm/atomic: add quirks for blind save/restore

2022-11-17 Thread Daniel Vetter
On Thu, Nov 17, 2022 at 07:54:40AM +, Simon Ser wrote: > Two quirks to make blind atomic save/restore [1] work correctly: > > - Mark the DPMS property as immutable for atomic clients, since > atomic clients cannot change it. > - Allow user-space to set content protection to "enabled", interp

Re: [PATCH v1 2/8] dt-bindings: display: bridge: renesas, dsi-csi2-tx: Add r8a779g0

2022-11-17 Thread Geert Uytterhoeven
Hi Tomi, On Thu, Nov 17, 2022 at 1:26 PM Tomi Valkeinen wrote: > From: Tomi Valkeinen > > Extend the Renesas DSI display bindings to support the r8a779g0 V4H. > > Signed-off-by: Tomi Valkeinen > --- > .../bindings/display/bridge/renesas,dsi-csi2-tx.yaml | 3 ++- > 1 file changed, 2 i

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Dmitry Osipenko
On 11/17/22 18:09, Christian König wrote: > Am 17.11.22 um 15:41 schrieb Dmitry Osipenko: >> [SNIP] >>> drm_sched_entity_flush() should be called from the flush callback from >>> the file_operations structure of panfrost. See amdgpu_flush() and >>> amdgpu_ctx_mgr_entity_flush(). This makes sure tha

Re: [PATCH v1] dt-bindings: display: Convert fsl, imx-fb.txt to dt-schema

2022-11-17 Thread Rob Herring
On Wed, Nov 16, 2022 at 11:49 AM Philipp Zabel wrote: > > On Thu, Nov 10, 2022 at 10:49:45AM +0100, Uwe Kleine-König wrote: > [...] > > new file mode 100644 > > index ..c3cf6f92a766 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml > > @@ -0,0

Re: [PATCH 12/13] drm/scheduler: rework entity flush, kill and fini

2022-11-17 Thread Christian König
Am 17.11.22 um 15:41 schrieb Dmitry Osipenko: [SNIP] drm_sched_entity_flush() should be called from the flush callback from the file_operations structure of panfrost. See amdgpu_flush() and amdgpu_ctx_mgr_entity_flush(). This makes sure that we wait for all entities of the process/file descripto

Re: [PATCH v1 6/8] drm: rcar-du: Add r8a779g0 support

2022-11-17 Thread Kieran Bingham
Quoting Tomi Valkeinen (2022-11-17 12:25:45) > From: Tomi Valkeinen > > Add support for DU on r8a779g0, which is identical to DU on r8a779a0. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 22 ++ > 1 file changed, 22 insertions(+) > > dif

  1   2   >