Re: [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-09 Thread Dmitry Baryshkov
On 10/11/2022 02:47, Kuogee Hsieh wrote: On 11/2/2022 11:04 AM, Dmitry Baryshkov wrote: On 02/11/2022 20:28, Doug Anderson wrote: Hi, On Wed, Nov 2, 2022 at 10:23 AM Dmitry Baryshkov wrote: 1. Someone figures out how to model this with the bridge chain and then we only allow HBR3 if we de

Re: [PATCH v3 08/10] phy: cadence: Add driver for HDP-TX DisplyPort PHY

2022-11-09 Thread Vinod Koul
On 08-11-22, 21:00, Sandor Yu wrote: > Add Cadence HDP-TX DisplayPort PHY driver. > > Cadence HDP-TX PHY could be put in either DP mode or > HDMI mode base on the configuration chosen. > DisplayPort PHY mode is configurated in the driver. > > Signed-off-by: Sandor Yu > --- > drivers/phy/cadence

Re: [PATCH v3 04/10] phy: Add HDMI configuration options

2022-11-09 Thread Vinod Koul
On 08-11-22, 21:00, Sandor Yu wrote: > Allow HDMI PHYs to be configured through the generic > functions through a custom structure added to the generic union. > > The parameters added here are based on HDMI PHY > implementation practices. The current set of parameters > should cover the potential

Re: [PATCH v3 10/12] phy: mediatek: add support for phy-mtk-hdmi-mt8195

2022-11-09 Thread Vinod Koul
On 04-11-22, 15:09, Guillaume Ranquet wrote: > Add basic support for the mediatek hdmi phy on MT8195 SoC Are phy patches in this series dependent upon changes in drm/, if not consider splitting them up! > > Signed-off-by: Guillaume Ranquet > --- > drivers/phy/mediatek/Makefile |

RE: [PATCH v2 11/11] iommufd: Allow iommufd to supply /dev/vfio/vfio

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, November 8, 2022 8:53 AM > > If the VFIO container is compiled out, give a kconfig option for iommufd > to provide the miscdev node with the same name and permissions as vfio > uses. > > The compatibility node supports the same ioctls as VFIO and automati

RE: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, November 10, 2022 3:53 AM > > On Wed, Nov 09, 2022 at 10:18:09AM -0700, Alex Williamson wrote: > > > DPDK supports no-iommu mode. > > Er? Huh? How? I thought no-iommu was for applications that didn't do > DMA? How is DPDK getting packets in/out without

Re: [Intel-gfx] [PATCH] drm/i915: Don't wait forever in drop_caches

2022-11-09 Thread John Harrison
On 11/9/2022 03:35, Tvrtko Ursulin wrote: On 08/11/2022 19:37, John Harrison wrote: On 11/8/2022 01:08, Tvrtko Ursulin wrote: On 07/11/2022 19:45, John Harrison wrote: On 11/7/2022 06:09, Tvrtko Ursulin wrote: On 04/11/2022 17:45, John Harrison wrote: On 11/4/2022 03:01, Tvrtko Ursulin wrote

Re: [PATCH v6 00/20] drm/i915/vm_bind: Add VM_BIND functionality

2022-11-09 Thread Niranjana Vishwanathapura
On Wed, Nov 09, 2022 at 04:16:25PM -0800, Zanoni, Paulo R wrote: On Mon, 2022-11-07 at 00:51 -0800, Niranjana Vishwanathapura wrote: DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified addres

RE: [PATCH v2 09/11] vfio: Move container related MODULE_ALIAS statements into container.c

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, November 8, 2022 8:53 AM > > The miscdev is in container.c, so should these related MODULE_ALIAS > statements. This is necessary for the next patch to be able to fully > disable /dev/vfio/vfio. > > Fixes: cdc71fe4ecbf ("vfio: Move container code into > dr

RE: [PATCH v2 08/11] vfio-iommufd: Support iommufd for emulated VFIO devices

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, November 8, 2022 8:53 AM > > Emulated VFIO devices are calling vfio_register_emulated_iommu_dev() and > consist of all the mdev drivers. > > Like the physical drivers, support for iommufd is provided by the driver > supplying the correct standard ops. Pro

[Bug 204181] NULL pointer dereference regression in amdgpu

2022-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=204181 buro (francesco.bure...@proton.me) changed: What|Removed |Added CC||francesco.bure...@pro

Re: [RFC] Approaches to deal with a struct with multiple fake flexible arrays members

2022-11-09 Thread Alex Deucher
On Wed, Nov 9, 2022 at 8:31 PM Paulo Miguel Almeida wrote: > > On Wed, Nov 09, 2022 at 06:45:57PM -0600, Gustavo A. R. Silva wrote: > > On Wed, Nov 09, 2022 at 04:45:42PM +1300, Paulo Miguel Almeida wrote: > > > > Adding Alex, Christian and DRM lists to the thread. > > Thanks so much for your repl

RE: [PATCH v2 07/11] vfio-iommufd: Support iommufd for physical VFIO devices

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, November 9, 2022 1:52 AM > > On Tue, Nov 08, 2022 at 03:41:25PM +0800, Yi Liu wrote: > > On 2022/11/8 14:10, Nicolin Chen wrote: > > > On Mon, Nov 07, 2022 at 08:52:51PM -0400, Jason Gunthorpe wrote: > > > > > > > @@ -795,6 +800,10 @@ static int vfio_dev

RE: [PATCH v2 07/11] vfio-iommufd: Support iommufd for physical VFIO devices

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, November 8, 2022 8:53 AM > > + > +int vfio_iommufd_bind(struct vfio_device *vdev, struct iommufd_ctx *ictx) > +{ > + u32 ioas_id; > + u32 device_id; > + int ret; > + > + lockdep_assert_held(&vdev->dev_set->lock); > + > + /* > + * I

RE: [PATCH v2 06/11] vfio-iommufd: Allow iommufd to be used in place of a container fd

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, November 8, 2022 8:53 AM > > This makes VFIO_GROUP_SET_CONTAINER accept both a vfio container FD > and an > iommufd. > > In iommufd mode an IOAS will exist after the SET_CONTAINER, but it will > not be attached to any groups. > > For VFIO this means that

RE: [PATCH v2 05/11] vfio: Use IOMMU_CAP_ENFORCE_CACHE_COHERENCY for vfio_file_enforced_coherent()

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Tuesday, November 8, 2022 8:53 AM > > iommufd doesn't establish the iommu_domains until after the device FD is > opened, even if the container has been set. This design is part of moving > away from the group centric iommu APIs. > > This is fine, except that the n

RE: [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, November 9, 2022 9:11 PM > > > If all agree that VFIO_CONTAINER=n is a process to evolve, does it make > > more sense to remove this patch from this series i.e. let it buried in > > VFIO_CONTAINER=y for now? Then resolve it in a follow up patch if > > no

RE: [PATCH v2 00/11] Connect VFIO to IOMMUFD

2022-11-09 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Wednesday, November 9, 2022 8:48 PM > > On Wed, Nov 09, 2022 at 09:03:52AM +, Tian, Kevin wrote: > > every mail in this series is shown thrice in lore: > > > > https://lore.kernel.org/all/0-v2-65016290f146+33e- > vfio_iommufd_...@nvidia.com/ > > > > not sure wh

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Jessica Zhang
On 11/9/2022 5:59 AM, Daniel Vetter wrote: On Wed, Nov 09, 2022 at 04:53:45PM +0300, Dmitry Baryshkov wrote: On 09/11/2022 16:52, Daniel Vetter wrote: On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov wrote: On 29/10/20

Re: [RFC] Approaches to deal with a struct with multiple fake flexible arrays members

2022-11-09 Thread Paulo Miguel Almeida
On Wed, Nov 09, 2022 at 06:45:57PM -0600, Gustavo A. R. Silva wrote: > On Wed, Nov 09, 2022 at 04:45:42PM +1300, Paulo Miguel Almeida wrote: > > Adding Alex, Christian and DRM lists to the thread. Thanks so much for your reply Gustavo Yep, that's a good idea. > > > struct _ATOM_INIT_REG_BLOCK

Re: [PATCH v6 05/20] drm/i915/vm_bind: Implement bind and unbind of object

2022-11-09 Thread Zanoni, Paulo R
On Mon, 2022-11-07 at 00:51 -0800, Niranjana Vishwanathapura wrote: > Add uapi and implement support for bind and unbind of an > object at the specified GPU virtual addresses. > > The vm_bind mode is not supported in legacy execbuf2 ioctl. > It will be supported only in the newer execbuf3 ioctl. >

Re: Nested AVIC design (was:Re: [RFC PATCH v3 04/19] KVM: x86: mmu: allow to enable write tracking externally)

2022-11-09 Thread Sean Christopherson
Sorry for the super slow reply, I don't have a good excuse other than I needed to take break from AVIC code... On Mon, Oct 03, 2022, Maxim Levitsky wrote: > On Thu, 2022-09-29 at 22:38 +, Sean Christopherson wrote: > > On Mon, Aug 08, 2022, Maxim Levitsky wrote: > > > Hi Sean, Paolo, and ever

Re: [RFC] Approaches to deal with a struct with multiple fake flexible arrays members

2022-11-09 Thread Gustavo A. R. Silva
On Wed, Nov 09, 2022 at 04:45:42PM +1300, Paulo Miguel Almeida wrote: Adding Alex, Christian and DRM lists to the thread. > Hi KSPP community, > > I've been working on replacing 1-element arrays with flex array members > on the drm/amdgpu files. I came across one insteresting case which I > may

Re: [PATCH v6 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-09 Thread Niranjana Vishwanathapura
On Wed, Nov 09, 2022 at 10:13:36PM +0100, Andi Shyti wrote: Hi Niranjana, ... -static void force_unbind(struct i915_vma *vma) +static void force_unbind(struct i915_vma *vma, bool async) { if (!drm_mm_node_allocated(&vma->node)) return; @@ -1725,7 +1727,21 @@ static voi

Re: [PATCH v6 00/20] drm/i915/vm_bind: Add VM_BIND functionality

2022-11-09 Thread Zanoni, Paulo R
On Mon, 2022-11-07 at 00:51 -0800, Niranjana Vishwanathapura wrote: > DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM > buffer objects (BOs) or sections of a BOs at specified GPU virtual > addresses on a specified address space (VM). Multiple mappings can map > to the same physical

linux-next: build failure after merge of the drm-misc tree

2022-11-09 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/gpu/drm/nouveau/nouveau_drm.c: In function 'nouveau_drm_probe': drivers/gpu/drm/nouveau/nouveau_drm.c:797:17: error: implicit declaration of function 'drm_fbdev_generic_setup' [-W

Re: [PATCH 5/6] drm/i915: Extract VESA DSC bpp alignment to separate function

2022-11-09 Thread Navare, Manasi
On Thu, Nov 03, 2022 at 03:21:46PM +0200, Stanislav Lisovskiy wrote: > We might to use that function separately from intel_dp_dsc_compute_config > for DP DSC over MST case, because allocating bandwidth in that > case can be a bit more tricky. So in order to avoid code copy-pasta > lets extract this

linux-next: manual merge of the drm-misc tree with the drm tree

2022-11-09 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/nouveau/nouveau_fbcon.c between commit: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") from the drm tree and commits: 9877d8f6bc37 ("drm/fb_helper: Rename field fbdev to info in struc

Re: [PATCH v3 2/2] drm/msm: Hangcheck progress detection

2022-11-09 Thread Chia-I Wu
On Fri, Nov 4, 2022 at 8:08 AM Rob Clark wrote: > > From: Rob Clark > > If the hangcheck timer expires, check if the fw's position in the > cmdstream has advanced (changed) since last timer expiration, and > allow it up to three additional "extensions" to it's alotted time. > The intention is to

Re: [PATCH] drm/msm/dp: remove limitation of link rate at 5.4G to support HBR3

2022-11-09 Thread Kuogee Hsieh
On 11/2/2022 11:04 AM, Dmitry Baryshkov wrote: On 02/11/2022 20:28, Doug Anderson wrote: Hi, On Wed, Nov 2, 2022 at 10:23 AM Dmitry Baryshkov wrote: 1. Someone figures out how to model this with the bridge chain and then we only allow HBR3 if we detect we've got a TCPC that supports it. T

[pull] amdgpu, amdkfd drm-fixes-6.1

2022-11-09 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.1. The following changes since commit 6295f1d8b4503ad8a18519b781dd2d1fe5e88c52: Merge tag 'drm-intel-fixes-2022-11-03' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes (2022-11-04 09:30:18 +1000) are available in the Git repository at: https://gi

Re: [PATCH v6 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-09 Thread Andi Shyti
Hi Niranjana, ... > -static void force_unbind(struct i915_vma *vma) > +static void force_unbind(struct i915_vma *vma, bool async) > { > if (!drm_mm_node_allocated(&vma->node)) > return; > @@ -1725,7 +1727,21 @@ static void force_unbind(struct i915_vma *vma) > i9

Re: [PATCH] docs/sphinx: More depth in the rtd sidebar toc

2022-11-09 Thread Jonathan Corbet
Daniel Vetter writes: > We love to nest our documenation for good structure, but that means > the table of contents needs to keep up or you can't navigate them. > > Realized this trying to find the drm property documentation, which > with some shuffling around disappeared. Why I didn't realize we

Re: [PATCH v6 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-09 Thread Niranjana Vishwanathapura
On Wed, Nov 09, 2022 at 05:52:54PM +, Matthew Auld wrote: On Mon, 7 Nov 2022 at 08:53, Niranjana Vishwanathapura wrote: Asynchronously unbind the vma upon vm_unbind call. Fall back to synchronous unbind if backend doesn't support async unbind or if async unbind fails. No need for vm_unbin

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-09 Thread Michal Wajdeczko
On 09.11.2022 18:46, John Harrison wrote: > On 11/9/2022 03:05, Tvrtko Ursulin wrote: >> On 08/11/2022 20:15, John Harrison wrote: >>> On 11/8/2022 01:01, Tvrtko Ursulin wrote: On 07/11/2022 19:14, John Harrison wrote: > On 11/7/2022 08:17, Tvrtko Ursulin wrote: >> On 07/11/2022 09:

Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-09 Thread Jason Gunthorpe
On Wed, Nov 09, 2022 at 10:18:09AM -0700, Alex Williamson wrote: > DPDK supports no-iommu mode. Er? Huh? How? I thought no-iommu was for applications that didn't do DMA? How is DPDK getting packets in/out without DMA? I guess it snoops in /proc/ or something to learn PFNs of mlock'd memory? > I

Re: [PATCH v2 1/2] arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 21:34, Kuogee Hsieh wrote: This patch add link-frequencies property to allow each platform to specify its DP max link rate. Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qco

Re: [PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Leo Li
On 11/9/22 13:20, Hamza Mahfooz wrote: Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(), this is undesirable especially because when drm.debug is enabled we are printing messages in fill_dc_dirty_rects() that are only

Re: [PATCH v2] drm: xlnx: Fix return type of zynqmp_dp_bridge_mode_valid

2022-11-09 Thread Kees Cook
On Tue, Nov 08, 2022 at 05:14:25PM -0700, Nathan Chancellor wrote: > From: Nathan Huckleberry > > The mode_valid field in drm_bridge_helper_funcs is expected to be of > type > enum drm_mode_status (* mode_valid) (struct drm_bridge *bridge, > struct drm_display

Re: [PATCH v8 4/7] drm/shmem-helper: Add memory shrinker

2022-11-09 Thread Dmitry Osipenko
Hello Thomas, On 11/9/22 13:28, Thomas Zimmermann wrote: >> +int drm_gem_shmem_set_evictable(struct drm_gem_shmem_object *shmem) >> +{ >> +    dma_resv_lock(shmem->base.resv, NULL); >> + >> +    if (shmem->madv < 0) { >> +    dma_resv_unlock(shmem->base.resv); >> +    return -ENOMEM; > >

[PATCH v2 1/2] arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed

2022-11-09 Thread Kuogee Hsieh
This patch add link-frequencies property to allow each platform to specify its DP max link rate. Signed-off-by: Kuogee Hsieh --- arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dt

[PATCH v2 2/2] drm/msm/dp: add support of max dp link rate

2022-11-09 Thread Kuogee Hsieh
Since it is not every platform supports HBR3 link rate, this patch limit the DP link rate at max link rate if it is specified at DTS file. Otherwise, the max dp link rate will be limited at HBR2 as before. Changes in v2: -- add max link rate from dtsi Signed-off-by: Kuogee Hsieh --- drivers/gpu

[PATCH v2 0/2] Add DP max link rate support

2022-11-09 Thread Kuogee Hsieh
dd DP link-frequencies property to DTS file and support function to DP driver. Kuogee Hsieh (2): arm64: dts: qcom: Add link-frequencies property to specify the max link rate allowed drm/msm/dp: add support of max dp link rate arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 1 + drivers/

Re: [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-09 Thread Alex Williamson
On Tue, 8 Nov 2022 21:05:21 -0400 Jason Gunthorpe wrote: > On Tue, Nov 08, 2022 at 03:55:20PM -0700, Alex Williamson wrote: > > > > > So why exactly isn't this an issue for VDPA? Are we just burying our > > > > head in the sand that such platforms exists and can still be useful > > > > given th

Re: [syzbot] memory leak in drm_vma_node_allow

2022-11-09 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:f141df371335 Merge tag 'audit-pr-20221107' of git://git.ke.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=123bdcd188 kernel config: https://syzkaller.appspot.com/x/.config?x=f7ebe38

[PATCH v2] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Hamza Mahfooz
Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(), this is undesirable especially because when drm.debug is enabled we are printing messages in fill_dc_dirty_rects() that are only useful for debugging PSR (and confusing oth

Re: [PATCH 0/3] add guard padding around i915_vma

2022-11-09 Thread Andi Shyti
Hi Thomas, On Wed, Nov 09, 2022 at 07:03:03PM +0100, Thomas Hellström wrote: > Hi, Andi, > > This has been on the list before (three times I think) and at that > point it (the guard pages) was NAK'd by Daniel as yet another > complication, and a VT-d > scanout workaround was implemented and pushe

Re: [PATCH 0/3] add guard padding around i915_vma

2022-11-09 Thread Thomas Hellström
Hi, Andi, This has been on the list before (three times I think) and at that point it (the guard pages) was NAK'd by Daniel as yet another complication, and a VT-d scanout workaround was implemented and pushed using a different approach, initially outlined by Daniel. Patch is 2ef6efa79fecd. Those

Re: [PATCH v6 20/20] drm/i915/vm_bind: Async vm_unbind support

2022-11-09 Thread Matthew Auld
On Mon, 7 Nov 2022 at 08:53, Niranjana Vishwanathapura wrote: > > Asynchronously unbind the vma upon vm_unbind call. > Fall back to synchronous unbind if backend doesn't support > async unbind or if async unbind fails. > > No need for vm_unbind out fence support as i915 will internally > handle al

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add GT oriented dmesg output

2022-11-09 Thread John Harrison
On 11/9/2022 03:05, Tvrtko Ursulin wrote: On 08/11/2022 20:15, John Harrison wrote: On 11/8/2022 01:01, Tvrtko Ursulin wrote: On 07/11/2022 19:14, John Harrison wrote: On 11/7/2022 08:17, Tvrtko Ursulin wrote: On 07/11/2022 09:33, Tvrtko Ursulin wrote: On 05/11/2022 01:03, Ceraolo Spurio, Da

[PATCH] drm/amd/display: only fill dirty rectangles when PSR is enabled

2022-11-09 Thread Hamza Mahfooz
Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(). So, we can instead limit the filling of dirty rectangles to only when PSR is enabled. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 0/3] add guard padding around i915_vma

2022-11-09 Thread Andi Shyti
Hi, This series adds guards around vma's but setting a pages at the beginning and at the end that work as padding. The first user of the vma guard are scanout objects which don't need anymore to add scratch to all the unused ggtt's and speeding up up considerably the boot and resume by several hu

[PATCH 1/3] drm/i915: Wrap all access to i915_vma.node.start|size

2022-11-09 Thread Andi Shyti
From: Chris Wilson We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pages around the objects _inside_ the drm_mm_n

[PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2022-11-09 Thread Andi Shyti
From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that su

[PATCH 3/3] drm/i915: Refine VT-d scanout workaround

2022-11-09 Thread Andi Shyti
From: Chris Wilson VT-d may cause overfetch of the scanout PTE, both before and after the vma (depending on the scanout orientation). bspec recommends that we provide a tile-row in either directions, and suggests using 168 PTE, warning that the accesses will wrap around the ends of the GGTT. Curr

Re: [PATCH] drm/tidss: Set max DMA segment size

2022-11-09 Thread Andrew Davis
On 8/22/22 7:16 PM, Andrew Davis wrote: We have no segment size limitations. Set to unlimited. Signed-off-by: Andrew Davis --- Ping, still valid. Andrew drivers/gpu/drm/tidss/tidss_dispc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers

Re: [PATCH v2 10/11] vfio: Make vfio_container optionally compiled

2022-11-09 Thread Alex Williamson
On Tue, 8 Nov 2022 20:54:58 -0400 Jason Gunthorpe wrote: > On Tue, Nov 08, 2022 at 03:28:31PM -0700, Alex Williamson wrote: > > > Perhaps this should have been obvious, but I'm realizing that > > vfio-noiommu mode is completely missing without VFIO_CONTAINER, which > > seems a barrier to depreca

Re: [PATCH 0/3] add guard patting around i915_vma

2022-11-09 Thread Andi Shyti
Please ignore, this series is rebased on the wrong branch. Andi On Wed, Nov 09, 2022 at 05:49:10PM +0100, Andi Shyti wrote: > Hi, > > This patch series adds a padding around i915_vma's reducing > consequently the need to add scratch to the unused GGTT. > > This speeds up considerably the boot a

Re: [PATCH v3] drm/nouveau: Add support to control backlight using bl_power for nva3.

2022-11-09 Thread Karol Herbst
On Fri, Nov 4, 2022 at 11:04 PM Antonio Gomes wrote: > > From: antoniospg > > Summary: > > * Add support to turn on/off backlight when changing values in bl_power > file. This is achieved by using function backlight_get_brightness() > in nva3_set_intensity to get current brightness. > > Test

Re: [PATCH v2 00/11] Connect VFIO to IOMMUFD

2022-11-09 Thread Jason Gunthorpe
On Tue, Nov 08, 2022 at 11:18:03PM +0800, Yi Liu wrote: > On 2022/11/8 17:19, Nicolin Chen wrote: > > On Mon, Nov 07, 2022 at 08:52:44PM -0400, Jason Gunthorpe wrote: > > > > > This is on github: > > > https://github.com/jgunthorpe/linux/commits/vfio_iommufd > > [...] > > > v2: > > > - Rebase t

[PATCH 3/3] drm/i915: Refine VT-d scanout workaround

2022-11-09 Thread Andi Shyti
From: Chris Wilson VT-d may cause overfetch of the scanout PTE, both before and after the vma (depending on the scanout orientation). bspec recommends that we provide a tile-row in either directions, and suggests using 168 PTE, warning that the accesses will wrap around the ends of the GGTT. Curr

[PATCH 2/3] drm/i915: Introduce guard pages to i915_vma

2022-11-09 Thread Andi Shyti
From: Chris Wilson Introduce the concept of padding the i915_vma with guard pages before and after. The major consequence is that all ordinary uses of i915_vma must use i915_vma_offset/i915_vma_size and not i915_vma.node.start/size directly, as the drm_mm_node will include the guard pages that su

[PATCH 1/3] drm/i915: Wrap all access to i915_vma.node.start|size

2022-11-09 Thread Andi Shyti
From: Chris Wilson We already wrap i915_vma.node.start for use with the GGTT, as there we can perform additional sanity checks that the node belongs to the GGTT and fits within the 32b registers. In the next couple of patches, we will introduce guard pages around the objects _inside_ the drm_mm_n

[PATCH 0/3] add guard patting around i915_vma

2022-11-09 Thread Andi Shyti
Hi, This patch series adds a padding around i915_vma's reducing consequently the need to add scratch to the unused GGTT. This speeds up considerably the boot and resume by several hundreds of milliseconds up to over a full second in slower machines. Andi Chris Wilson (3): drm/i915: Wrap all a

[PULL] drm-misc-fixes

2022-11-09 Thread Maarten Lankhorst
Hey Daniel & Dave, Another small pull request. Various small assorted fixes. drm-misc-fixes-2022-11-09: drm-misc-fixes for v6.1-rc5: - HDMI fixes to vc4. - Make panfrost's uapi header compile with C++. - Add rotation quirks for 2 panels. - Fix s/r in amdgpu_vram_mgr_new - Handle 1 gb boundary

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-09 Thread Greg Kroah-Hartman
On Wed, Nov 09, 2022 at 08:30:52PM +0530, Deepak R Varma wrote: > On Fri, Nov 04, 2022 at 08:12:11PM +0530, Deepak R Varma wrote: > > On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote: > > > On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > > > > > > > > > > I took a

Re: [PATCH v3] drm/vmwgfx: Fix race issue calling pin_user_pages

2022-11-09 Thread Martin Krastev (VMware)
From: Martin Krastev Looks great! Reviewed-by: Martin Krastev Regards, Martin On 9.11.22 г. 17:37 ч., Dawei Li wrote: pin_user_pages() is unsafe without protection of mmap_lock, fix it by calling pin_user_pages_fast(). Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats"

Re: [PATCH v7 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-11-09 Thread Maxime Ripard
Hi Noralf, On Mon, Nov 07, 2022 at 07:11:27PM +0100, Noralf Trønnes wrote: > > > Den 07.11.2022 15.16, skrev Maxime Ripard: > > From: Noralf Trønnes > > > > Most of the TV connectors will need a similar get_modes implementation > > that will, depending on the drivers' capabilities, register th

RE: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Kalyan Thota >Sent: Wednesday, November 9, 2022 6:53 PM >To: dmitry.barysh...@linaro.org; Kalyan Thota (QUIC) >; dri-devel@lists.freedesktop.org; linux-arm- >m...@vger.kernel.org; freedr...@lists.freedesktop.org; >devicet...@vger.kernel.org >Cc: linux-ker...@vg

[PATCH v3] drm/vmwgfx: Fix race issue calling pin_user_pages

2022-11-09 Thread Dawei Li
pin_user_pages() is unsafe without protection of mmap_lock, fix it by calling pin_user_pages_fast(). Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats") Signed-off-by: Dawei Li --- v1: https://lore.kernel.org/all/tycp286mb23235c9a9fcf85c045f95ea7ca...@tycp286mb2323.jpnp286.prod.o

Re: [PATCH 16/26] drm: panfrost: Remove #ifdef guards for PM related functions

2022-11-09 Thread Steven Price
On 07/11/2022 17:52, Paul Cercueil wrote: > Use the EXPORT_GPL_RUNTIME_DEV_PM_OPS() and pm_ptr() macros to handle > the PM callbacks. > > These macros allow the PM functions to be automatically dropped by the > compiler when CONFIG_PM is disabled, without having to use #ifdef > guards. > > This h

Re: [PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-11-09 Thread Deepak R Varma
On Fri, Nov 04, 2022 at 08:12:11PM +0530, Deepak R Varma wrote: > On Fri, Nov 04, 2022 at 05:31:24PM +0530, Deepak R Varma wrote: > > On Mon, Oct 31, 2022 at 01:05:32PM +0100, Julia Lawall wrote: > > > > > > > > > I took a look, but it's pretty complex. You could take the code and > > > reorganize

[GIT PULL FOR v6.2] Renesas and Xilinx changes

2022-11-09 Thread Laurent Pinchart
/pinchartl/media.git tags/drm-next-20221109 for you to fetch changes up to cec9e59cae6071e58140baf54e47c00aaa39851b: drm: xlnx: Fix return type of zynqmp_dp_bridge_mode_valid (2022-11-09 16:50:21 +0200) - Renesas RZ/G2L DSI support

[GIT PULL FOR v6.1] R-Car DU fixes

2022-11-09 Thread Laurent Pinchart
inuxtv.org/pinchartl/media.git tags/drm-fixes-20221109 for you to fetch changes up to a830a15678593948f3271a5a398c9b67d8beedb9: drm: rcar-du: Fix Kconfig dependency between RCAR_DU and RCAR_MIPI_DSI (2022-11-09 16:32:46 +0200) R-Car D

[Bug 216673] Recurring amdgpu freeze on kernel 6.0.6 only

2022-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216673 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [PATCH v2] drm: xlnx: Fix return type of zynqmp_dp_bridge_mode_valid

2022-11-09 Thread Laurent Pinchart
Hi Nathan, Thank you for the patch. On Tue, Nov 08, 2022 at 05:14:25PM -0700, Nathan Chancellor wrote: > From: Nathan Huckleberry > > The mode_valid field in drm_bridge_helper_funcs is expected to be of > type > enum drm_mode_status (* mode_valid) (struct drm_bridge *bridge, >

Re: [PATCH] drm/panfrost: Split io-pgtable requests properly

2022-11-09 Thread Steven Price
On 08/11/2022 17:06, Robin Murphy wrote: > Although we don't use 1GB block mappings, we still need to split > map/unmap requests at 1GB boundaries to match what io-pgtable expects. > Fix that, and add some explanation to make sense of it all. > > Fixes: 3740b081795a ("drm/panfrost: Update io-pgtab

Re: [PATCH v7 15/23] drm/modes: Introduce more named modes

2022-11-09 Thread Noralf Trønnes
Den 07.11.2022 15.16, skrev Maxime Ripard: > Now that we can easily extend the named modes list, let's add a few more > analog TV modes that were used in the wild, and some unit tests to make > sure it works as intended. > > Signed-off-by: Maxime Ripard > > --- > Changes in v6: > - Renamed th

Re: [PATCH] drm: rcar_du: DRM_RCAR_DU optionally depends on RCAR_MIPI_DSI

2022-11-09 Thread Laurent Pinchart
Hi Randy, Thank you for the patch. On Tue, Oct 18, 2022 at 11:18:28AM -0700, Randy Dunlap wrote: > When CONFIG_DRM_RCAR_DU=y and CONFIG_DRM_RCAR_MIPI_DSI=m, calls > from the builtin driver to the mipi driver fail due to linker > errors. > Since the RCAR_MIPI_DSI driver is not always required, fix

Re: [PATCH v2] drm: fix crash in drm_minor_alloc_release

2022-11-09 Thread Daniel Vetter
On Tue, Nov 08, 2022 at 07:38:23PM +0100, Stanislaw Gruszka wrote: > If drm_sysfs_minor_alloc() fail in drm_minor_alloc() we can end up > freeing invalid minor->kdev pointer and drm_minor_alloc_release() > will crash like below: > > RIP: 0010:kobject_put+0x19/0x1c0 > RSP: 0018:bc7001637c38 EFL

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Daniel Vetter
On Wed, Nov 09, 2022 at 04:53:45PM +0300, Dmitry Baryshkov wrote: > On 09/11/2022 16:52, Daniel Vetter wrote: > > On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: > > > On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov > > > wrote: > > > > > > > On 29/10/2022 01:59, Jessica Zh

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 16:52, Daniel Vetter wrote: On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov wrote: On 29/10/2022 01:59, Jessica Zhang wrote: Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for drm_plane. In add

Re: [RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-11-09 Thread Daniel Vetter
On Tue, Nov 08, 2022 at 06:25:29PM +, Simon Ser wrote: > On Saturday, October 29th, 2022 at 13:23, Dmitry Baryshkov > wrote: > > > On 29/10/2022 01:59, Jessica Zhang wrote: > > > > > Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for > > > drm_plane. In addition, add support fo

[PATCH] drm/amd/display: delete the duplicate .set_odm_bypass initialization in dcn314_tg_funcs

2022-11-09 Thread Liu Jian
Fix below sparse warning: drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:244:18: warning: Initializer entry defined twice drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:257:18: also defined here Fixes: 5ade1b951dec ("drm/amd/display: Add OTG/ODM functions") Signed

[PATCH] drm/vkms: change min cursor size to accept smaller values

2022-11-09 Thread Alaa Mohamed
change min cursor size of vkms driver from 20 to 10, to increase the IGT test coverage of vkms by enabling 32x10 cursor size subtests in kms_cursor_crc Signed-off-by: Alaa Mohamed --- drivers/gpu/drm/vkms/vkms_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

Re: [Nouveau] [PATCH v7 06/23] drm/modes: Add a function to generate analog display modes

2022-11-09 Thread Lukas Satin
Hi, your statement: "However, analog display usually have fairly loose timings requirements, the only discrete parameters being the total number of lines and pixel clock frequency." Please do not make it as a rule. You said yourself: "usually". Arcade CRT have more loose timings, but professional

Re: [Nouveau] [PATCH v7 22/23] drm/vc4: vec: Add support for more analog TV standards

2022-11-09 Thread Lukas Satin
They are important for retrogaming and connecting TV out to CRT TV or using emulator. I have PS1 that is using PAL-60 for example. Can you add 240p and 288p non-interlaced modes for NTSC and PAL, please? Lukas On Mon, Nov 7, 2022 at 3:19 PM Maxime Ripard wrote: > From: Mateusz Kwiatkowski >

Re: [Nouveau] [PATCH v7 00/23] drm: Analog TV Improvements

2022-11-09 Thread Lukas Satin
One can switch from NTSC to PAL now using (on vc4) modetest -M vc4 -s 53:720x480i -w 53:'TV mode':1 # NTSC modetest -M vc4 -s 53:720x576i -w 53:'TV mode':4 # PAL NTSC should be 640x480i, not 720. It will probably work on most TV's, but NTSC by the spec is 640x480i. On Mon, Nov 7, 2022 at 3:16

Re: [PATCH drm-misc-next v4 0/4] drm/arm/hdlcd: use drm managed resources

2022-11-09 Thread Liviu Dudau
On Tue, Nov 08, 2022 at 08:57:55PM +0100, Danilo Krummrich wrote: > Hi Liviu, Hi, > > > The only issue that I'm seeing that is not critical is that at > > reboot/shutdown time > > I'm getting an "Unexpected global fault, this could be serious" from the > > smmu: > > > > [ 6893.467910] arm-smm

Re: [PATCH] drm/vkms: change min cursor size to accept smaller values

2022-11-09 Thread aemad
Sorry, for the noise. I had some issues in my git send-email setup. Please, consider this version. - Alaa On 2022-11-09 12:39, Alaa Emad wrote: > change min cursor size of vkms driver from 20 to 10, to increase the IGT test > coverage of vkms by enabling 32x10 cursor size subtests in kms_cursor_c

Re: [Intel-gfx] [PATCH v2] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-09 Thread Jani Nikula
On Wed, 09 Nov 2022, Aravind Iddamsetty wrote: > On XE_LPM+ platforms the media engines are carved out into a separate > GT but have a common GGTMMADR address range which essentially makes > the GGTT address space to be shared between media and render GT. As a > result any updates in GGTT shall in

[PATCH v2] drm/i915/mtl: Media GT and Render GT share common GGTT

2022-11-09 Thread Aravind Iddamsetty
On XE_LPM+ platforms the media engines are carved out into a separate GT but have a common GGTMMADR address range which essentially makes the GGTT address space to be shared between media and render GT. As a result any updates in GGTT shall invalidate TLB of GTs sharing it and similarly any operati

RE: [EXT] Re: [v2 06/10] drm: bridge: cadence: Add MHDP HDMI driver for i.MX8MQ

2022-11-09 Thread Sandor Yu
Thanks for your comments. > -Original Message- > From: Alexander Stein > Sent: 2022年11月8日 21:17 > To: jo...@kwiboo.se; Sandor Yu > Cc: dri-devel@lists.freedesktop.org; devicet...@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org; > linux-...@lists.infr

RE: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 9, 2022 6:02 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@ch

Re: [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-11-09 Thread Jason Gunthorpe
On Wed, Nov 09, 2022 at 03:21:29AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, November 9, 2022 9:05 AM > > > > On Tue, Nov 08, 2022 at 03:55:20PM -0700, Alex Williamson wrote: > > > > > > > So why exactly isn't this an issue for VDPA? Are we just burying our > > >

[Bug 216673] Recurring amdgpu freeze on kernel 6.0.6 only

2022-11-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216673 --- Comment #3 from Stanislav Modrak (stanislav.mod...@gmail.com) --- (In reply to Artem S. Tashkinov from comment #2) > https://gitlab.freedesktop.org is where it should be anyways. Can you please explain why it belongs there and not here? Thx!

Re: [PATCH v2 00/11] Connect VFIO to IOMMUFD

2022-11-09 Thread Jason Gunthorpe
On Wed, Nov 09, 2022 at 09:03:52AM +, Tian, Kevin wrote: > every mail in this series is shown thrice in lore: > > https://lore.kernel.org/all/0-v2-65016290f146+33e-vfio_iommufd_...@nvidia.com/ > > not sure what caused it but it's annoying to check the conversation there. It is sort of a lore

Re: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:39, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Wednesday, November 9, 2022 6:02 PM To: Kalyan Thota (QUIC) ; dri- de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org Cc: linux

Re: [v8] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-11-09 Thread Dmitry Baryshkov
On 09/11/2022 15:14, Kalyan Thota wrote: Flush mechanism for DSPP blocks has changed in sc7280 family, it allows individual sub blocks to be flushed in coordination with master flush control. Representation: master_flush && (PCC_flush | IGC_flush .. etc ) This change adds necessary support for

RE: [PATCH 4/4] drm/msm/disp/dpu1: add color management support for the crtc

2022-11-09 Thread Kalyan Thota
>-Original Message- >From: Dmitry Baryshkov >Sent: Wednesday, November 9, 2022 6:02 PM >To: Kalyan Thota (QUIC) ; dri- >de...@lists.freedesktop.org; linux-arm-...@vger.kernel.org; >freedr...@lists.freedesktop.org; devicet...@vger.kernel.org >Cc: linux-ker...@vger.kernel.org; robdcl...@ch

  1   2   >