Re: [PATCH v2] drm/format-helper: Only advertise supported formats for conversion

2022-10-28 Thread Hector Martin
On 28/10/2022 17.07, Thomas Zimmermann wrote: > In yesterday's discussion on IRC, it was said that several devices > advertise ARGB framebuffers when the hardware actually uses XRGB? Is > there hardware that supports transparent primary planes? ARGB hardware probably exists in the form of embedd

Re: [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

2022-10-28 Thread Gwan-gyeong Mun
Hi Kees, I've updated to v5 with the last comment of Nathan. Could you please kindly review what more is needed as we move forward with this patch? Br, G.G. On 10/24/22 11:11 PM, Gwan-gyeong Mun wrote: From: Kees Cook Implement a robust overflows_type() macro to test if a variable or cons

Re: [PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-10-28 Thread Kees Cook
On Sat, Oct 29, 2022 at 04:32:05PM +1300, Paulo Miguel Almeida wrote: > One-element arrays are deprecated, and we are replacing them with > flexible array members instead. So, replace one-element array with > flexible-array member in struct _ATOM_FAKE_EDID_PATCH_RECORD and > refactor the rest of th

[PATCH v2] [next] drm/radeon: Replace one-element array with flexible-array member

2022-10-28 Thread Paulo Miguel Almeida
One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct _ATOM_FAKE_EDID_PATCH_RECORD and refactor the rest of the code accordingly. It's worth mentioning that doing a build before/after thi

[PATCH] drm/amd/display: fix an incorrect comment

2022-10-28 Thread Alex Hung
This is a copy-and-paste error. Fix the comment to match the macro definition. Signed-off-by: Alex Hung --- drivers/gpu/drm/amd/display/dc/dml/dcn10/dcn10_fpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn10/dcn10_fpu.h b/drivers/gpu

[PATCH -next] drm: xlnx: zynqmp_dpsub: fix missing clk_disable_unprepare() in error path in zynqmp_dpsub_init_clocks()

2022-10-28 Thread Yang Yingliang
If get video or audio clock failed, it should call clk_disable_unprepare() in error path. Fixes: c979296ef60c ("drm: xlnx: zynqmp_dpsub: Move audio clk from zynqmp_disp to zynqmp_dpsub") Fixes: 1682ade66308 ("drm: xlnx: zynqmp_dpsub: Move pclk from zynqmp_disp to zynqmp_dpsub") Signed-off-by: Ya

Re: [PATCH V4 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-10-28 Thread Chris Morgan
On Fri, Oct 28, 2022 at 07:01:12PM -0400, Krzysztof Kozlowski wrote: > On 28/10/2022 16:50, Chris Morgan wrote: > > From: Chris Morgan > > > > Add documentation for the NewVision NV3051D panel bindings. > > Note that for the two expected consumers of this panel binding > > the underlying LCD mode

[PATCH v2] [next] drm/amdgpu: Replace one-element array with flexible-array member

2022-10-28 Thread Paulo Miguel Almeida
One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct _ATOM_FAKE_EDID_PATCH_RECORD and refactor the rest of the code accordingly. Important to mention is that doing a build before/after t

Re: [PATCH] [next] drm/amdgpu: Replace one-element array with flexible-array member

2022-10-28 Thread Paulo Miguel Almeida
On Fri, Oct 28, 2022 at 07:33:17PM +0200, Christian König wrote: > Am 28.10.22 um 18:36 schrieb Kees Cook: > > > All that said, converting away from them can be tricky, and I think such > > conversions need to explicitly show how they were checked for binary > > differences[2]. > > Oh, that's a g

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add missing steering table terminators

2022-10-28 Thread Matt Roper
On Fri, Oct 28, 2022 at 04:04:18PM -0700, Lucas De Marchi wrote: > On Fri, Oct 28, 2022 at 03:40:22PM -0700, Matt Roper wrote: > > The termination entries were missing for a couple of the recently-added > > MTL steering tables. > > > > Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering")

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-10-28 Thread Nicolin Chen
On Fri, Oct 28, 2022 at 04:53:21PM -0700, Nicolin Chen wrote: > On Tue, Oct 25, 2022 at 03:17:06PM -0300, Jason Gunthorpe wrote: > > This series provides an alternative container layer for VFIO implemented > > using iommufd. This is optional, if CONFIG_IOMMUFD is not set then it will > > not be com

Re: [PATCH 00/10] Connect VFIO to IOMMUFD

2022-10-28 Thread Nicolin Chen
On Tue, Oct 25, 2022 at 03:17:06PM -0300, Jason Gunthorpe wrote: > This series provides an alternative container layer for VFIO implemented > using iommufd. This is optional, if CONFIG_IOMMUFD is not set then it will > not be compiled in. > > At this point iommufd can be injected by passing in a i

Re: [Intel-gfx] [PULL] drm-intel-next

2022-10-28 Thread Ville Syrjälä
On Fri, Oct 28, 2022 at 02:22:33PM -0400, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Here goes the first chunk of drm-intel-next targeting 6.2 > > The highlight goes to Ville with many display related clean-up > and improvement, some other MTL enabling work and many other > fixes and small cle

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Add missing steering table terminators

2022-10-28 Thread Lucas De Marchi
On Fri, Oct 28, 2022 at 03:40:22PM -0700, Matt Roper wrote: The termination entries were missing for a couple of the recently-added MTL steering tables. Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering") Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") I

Re: [PATCH V4 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 16:50, Chris Morgan wrote: > From: Chris Morgan > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. Name "anbernic,rg353p-panel" > is used because the hardware itself

[RFC PATCH 3/3] drm/msm/dpu: Use color_fill property for DPU planes

2022-10-28 Thread Jessica Zhang
Initialize and use the color_fill properties for planes in DPU driver. In addition, relax framebuffer requirements within atomic commit path and add checks for NULL framebuffers. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 7 ++- drivers/gpu/drm/msm/disp/dpu1/dp

[RFC PATCH 2/3] drm: Adjust atomic checks for solid fill color

2022-10-28 Thread Jessica Zhang
Loosen the requirements for atomic and legacy commit so that, in cases where solid fill planes is enabled (and FB_ID is NULL), the commit can still go through. In addition, add framebuffer NULL checks in other areas to account for FB being NULL when solid fill is enabled. Signed-off-by: Jessica Z

[RFC PATCH 1/3] drm: Introduce color fill properties for drm plane

2022-10-28 Thread Jessica Zhang
Add support for COLOR_FILL and COLOR_FILL_FORMAT properties for drm_plane. In addition, add support for setting and getting the values of these properties. COLOR_FILL represents the color fill of a plane while COLOR_FILL_FORMAT represents the format of the color fill. Userspace can set enable soli

[RFC PATCH 0/3] Support for Solid Fill Planes

2022-10-28 Thread Jessica Zhang
Introduce and add support for COLOR_FILL and COLOR_FILL_FORMAT properties. When the color fill value is set, and the framebuffer is set to NULL, memory fetch will be disabled. In addition, loosen the NULL FB checks within the atomic commit callstack to allow a NULL FB when color_fill is nonzero an

[PATCH 2/2] drm/amdgpu: Set PROBE_PREFER_ASYNCHRONOUS

2022-10-28 Thread Brian Norris
This driver often takes over 200ms to start, so it can improve boot speed to probe it asynchronously. I did a short review of the driver, and apart from an issue fixed in the parent patch ("drm/amdgpu: Move racy global PMU list into device"), there don't appear to be many cross-device dependencies

[PATCH 1/2] drm/amdgpu: Move racy global PMU list into device

2022-10-28 Thread Brian Norris
If there are multiple amdgpu devices, this list processing can be racy. We're really treating this like a per-device list, so make that explicit and remove the global list. Signed-off-by: Brian Norris --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.

[PATCH] drm/i915/mtl: Add missing steering table terminators

2022-10-28 Thread Matt Roper
The termination entries were missing for a couple of the recently-added MTL steering tables. Fixes: f32898c94a10 ("drm/i915/xelpg: Add multicast steering") Fixes: a7ec65fc7e83 ("drm/i915/xelpmp: Add multicast steering for media GT") Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt_

[PATCH v5] drm/tests: Add back seed value information

2022-10-28 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they were refactored into KUnit. Add kunit_info with seed value information to assure reproducibility. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.org/

Re: [PATCH v4 00/10] drm/msm: Fix math issues in MSM DSC implementation

2022-10-28 Thread Abhinav Kumar
On 10/28/2022 1:09 PM, Marijn Suijten wrote: Hi Abhinav, On 2022-10-28 11:33:21, Abhinav Kumar wrote: Hi Marijn On 10/26/2022 11:28 AM, Marijn Suijten wrote: Various removals of complex yet unnecessary math, fixing all uses of drm_dsc_config::bits_per_pixel to deal with the fact that this

Re: [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. > > In order to toggle the board to enable the HDMI output, > switch #7 & #8 on the rightmost multi-switch package have > to be toggled to On. > > Signed-off-by: Robert Foss > --- > arch/arm

Re: [PATCH v1 8/9] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > Enable the display subsystem and the dsi0 output for > the sm8350-hdk board. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/

Re: [PATCH v1 7/9] arm64: dts: qcom: sm8350: Add display system nodes

2022-10-28 Thread Krzysztof Kozlowski
On 28/10/2022 08:08, Robert Foss wrote: > Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these > nodes the display subsystem is configured to support > one DSI output. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 196 ++- > 1 file changed,

[PATCH] drm/i915: Set PROBE_PREFER_ASYNCHRONOUS

2022-10-28 Thread Brian Norris
This driver often takes a good 100ms to start, but in some particularly bad cases takes more than 1 second. In surveying risk for this driver, I poked around for cross-device shared state, which can be a source of race conditions. GVT support (intel_gvt_devices) seems potentially suspect, but it h

Re: [git pull] drm fixes for 6.1-rc3

2022-10-28 Thread pr-tracker-bot
The pull request you sent on Fri, 28 Oct 2022 13:53:24 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-10-28 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e3493d682516e2b7ef69587ddf91b0371a1511d0 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH v4] drm/tests: Add back seed value information

2022-10-28 Thread Maíra Canal
Hi Arthur, Just a small nit below, but besides that: Reviewed-by: Maíra Canal On 10/28/22 11:17, Arthur Grillo wrote: > As reported by Michał the drm_mm and drm_buddy unit tests lost the > printk with seed value after they were refactored into KUnit. > > Add kunit_info with seed value informat

[PATCH V4 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel

2022-10-28 Thread Chris Morgan
From: Chris Morgan Support NewVision NV3051D panels as found on the Anbernic RG353P and RG353V. The underlying LCD part number for the RG353x devices is unknown, so the device name and a fallback for the driver IC is used instead. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/Kconfig

[PATCH V4 0/3] drm/panel: Add NewVision NV3051D Panels

2022-10-28 Thread Chris Morgan
From: Chris Morgan Add the NewVision NV3051D panel as found on the Anbernic RG353P and RG353V. The underlying LCD panel itself is unknown (the NV3051D is the controller), so the device name is used for the panel with a fallback to the driver IC. Changes from V3: - Changed driver remove function

[PATCH V4 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

2022-10-28 Thread Chris Morgan
From: Chris Morgan Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Name "anbernic,rg353p-panel" is used because the hardware itself is known as "anbernic,rg353p". Signed-off-by: Chris

[PATCH V4 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix

2022-10-28 Thread Chris Morgan
From: Chris Morgan NewVision (also sometimes written as New Vision) is a company based in Shenzen that manufactures ICs for controlling LCD panels. https://www.newvisiondisplay.com/ Signed-off-by: Chris Morgan Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/vendor-prefixe

[PATCH] drm/amd/display: drop vblank_lock from struct amdgpu_display_manager

2022-10-28 Thread Hamza Mahfooz
As of commit 09a5df6c444c ("drm/amd/display: Fix multi-display support for idle opt workqueue"), vblank_lock is no longer being used. So, don't init it in amdgpu_dm_init() and remove it from struct amdgpu_display_manager. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/amdgpu_dm/amd

Re: [PATCH v4 00/10] drm/msm: Fix math issues in MSM DSC implementation

2022-10-28 Thread Marijn Suijten
Hi Abhinav, On 2022-10-28 11:33:21, Abhinav Kumar wrote: > Hi Marijn > > On 10/26/2022 11:28 AM, Marijn Suijten wrote: > > Various removals of complex yet unnecessary math, fixing all uses of > > drm_dsc_config::bits_per_pixel to deal with the fact that this field > > includes four fractional bit

[PATCH 2/2] drm/i915/guc: Don't deadlock busyness stats vs reset

2022-10-28 Thread John . C . Harrison
From: John Harrison The engine busyness stats has a worker function to do things like 64bit extend the 32bit hardware counters. The GuC's reset prepare function flushes out this worker function to ensure no corruption happens during the reset. Unforunately, the worker function has an infinite wai

[PATCH 1/2] drm/i915/guc: Properly initialise kernel contexts

2022-10-28 Thread John . C . Harrison
From: John Harrison If a context has already been registered prior to first submission then context init code was not being called. The noticeable effect of that was the scheduling priority was left at zero (meaning super high priority) instead of being set to normal. This would occur with kernel

[PATCH 0/2] Fix for two GuC issues

2022-10-28 Thread John . C . Harrison
From: John Harrison Fix for a deadlock issue between the GuC busyness stats worker and GT resets. Also fix kernel contexts not getting the correct scheduling priority at start of day. Signed-off-by: John Harrison John Harrison (2): drm/i915/guc: Properly initialise kernel contexts drm/i91

[PATCH] drm/i915/mtl: Add MC6 Wa_14017210380 for SAMedia

2022-10-28 Thread Badal Nilawar
This workaround is added for Media Tile of MTL A step. It is to help pcode workaround which handles the hardware bug seen on CXL splitter during package C2/C3 transitins due to MC6 entry/exit. As a part of workaround pcode expect kmd to send mailbox message "media busy" when components of Media til

Re: [PATCH v1 3/7] vfio/ccw: move private initialization to callback

2022-10-28 Thread Eric Farman
On Fri, 2022-10-28 at 14:52 -0400, Matthew Rosato wrote: > On 10/19/22 12:21 PM, Eric Farman wrote: > > There's already a device initialization callback that is > > used to initialize the release completion workaround. > > As discussed off-list, maybe clarify what callback you're talking > about h

Re: [PATCH v1 3/7] vfio/ccw: move private initialization to callback

2022-10-28 Thread Matthew Rosato
On 10/19/22 12:21 PM, Eric Farman wrote: > There's already a device initialization callback that is > used to initialize the release completion workaround. As discussed off-list, maybe clarify what callback you're talking about here and/or reference the commit that added it. > > Move the other

Re: Try to address the DMA-buf coherency problem

2022-10-28 Thread Daniel Stone
Hi Christian, On Fri, 28 Oct 2022 at 18:50, Christian König wrote: > Am 28.10.22 um 17:46 schrieb Nicolas Dufresne: > > Though, its not generically possible to reverse these roles. If you want to > > do > > so, you endup having to do like Android (gralloc) and ChromeOS (minigbm), > > because you

Re: [PATCH 10/10] iommufd: Allow iommufd to supply /dev/vfio/vfio

2022-10-28 Thread Jason Gunthorpe
On Wed, Oct 26, 2022 at 03:31:33PM -0600, Alex Williamson wrote: > On Tue, 25 Oct 2022 15:50:45 -0300 > Jason Gunthorpe wrote: > > > If the VFIO container is compiled out, give a kconfig option for iommufd > > to provide the miscdev node with the same name and permissions as vfio > > uses. > > >

Re: [PATCH v1 2/7] vfio/ccw: remove private->sch

2022-10-28 Thread Matthew Rosato
On 10/19/22 12:21 PM, Eric Farman wrote: > These places all rely on the ability to jump from a private > struct back to the subchannel struct. Rather than keeping a > copy in our back pocket, let's use the relationship provided > by the vfio_device embedded within the private. > > Signed-off-by: E

Re: [PATCH 04/10] vfio: Move storage of allow_unsafe_interrupts to vfio_main.c

2022-10-28 Thread Jason Gunthorpe
On Wed, Oct 26, 2022 at 03:24:42PM -0600, Alex Williamson wrote: > On Tue, 25 Oct 2022 15:17:10 -0300 > Jason Gunthorpe wrote: > > > This legacy module knob has become uAPI, when set on the vfio_iommu_type1 > > it disables some security protections in the iommu drivers. Move the > > storage for t

Re: [PATCH v4 00/10] drm/msm: Fix math issues in MSM DSC implementation

2022-10-28 Thread Abhinav Kumar
Hi Marijn On 10/26/2022 11:28 AM, Marijn Suijten wrote: Various removals of complex yet unnecessary math, fixing all uses of drm_dsc_config::bits_per_pixel to deal with the fact that this field includes four fractional bits, and finally making sure that range_bpg_offset contains values 6-bits wi

Re: [PATCH] mm/memremap: Introduce pgmap_request_folio() using pgmap offsets

2022-10-28 Thread Jason Gunthorpe
On Thu, Oct 20, 2022 at 02:56:39PM -0700, Dan Williams wrote: > A 'struct dev_pagemap' (pgmap) represents a collection of ZONE_DEVICE > pages. The pgmap is a reference counted object that serves a similar > role as a 'struct request_queue'. Live references are obtained for each > in flight request

[PULL] drm-intel-next

2022-10-28 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes the first chunk of drm-intel-next targeting 6.2 The highlight goes to Ville with many display related clean-up and improvement, some other MTL enabling work and many other fixes and small clean-ups. drm-intel-next-2022-10-28: - Hotplug code clean-up and organization

Re: [PATCH] docs/sphinx: More depth in the rtd sidebar toc

2022-10-28 Thread Jonathan Corbet
Daniel Vetter writes: > We love to nest our documenation for good structure, but that means > the table of contents needs to keep up or you can't navigate them. > > Realized this trying to find the drm property documentation, which > with some shuffling around disappeared. Why I didn't realize we

Re: [PATCH 5/5] drm/i915/mtl: don't expose GSC command streamer to the user

2022-10-28 Thread Matt Roper
On Fri, Oct 28, 2022 at 10:14:05AM -0700, Ceraolo Spurio, Daniele wrote: > > > On 10/27/2022 8:40 PM, Matt Roper wrote: > > On Thu, Oct 27, 2022 at 03:15:54PM -0700, Daniele Ceraolo Spurio wrote: > > > There is no userspace user for this CS yet, we only need it for internal > > > kernel ops (e.g.

Re: Try to address the DMA-buf coherency problem

2022-10-28 Thread Christian König
Hi Nicolas, Am 28.10.22 um 17:46 schrieb Nicolas Dufresne: Hi, just dropping some real live use case, sorry I'm not really proposing solutions, I believe you are much more knowledgeable in this regard. Well, I think each of us has a lot of specialized knowledge. For example I don't know to m

Re: [PATCH v1 1/7] vfio/ccw: create a parent struct

2022-10-28 Thread Matthew Rosato
On 10/19/22 12:21 PM, Eric Farman wrote: > Move the stuff associated with the mdev parent (and thus the > subchannel struct) into its own struct, and leave the rest in > the existing private structure. > > The subchannel will point to the parent, and the parent will point > to the private, for the

[PATCH] staging: fbtft: Use ARRAY_SIZE() to get argument count

2022-10-28 Thread Deepak R Varma
The ARRAY_SIZE(foo) macro should be preferred over sizeof operator based computation such as sizeof(foo)/sizeof(foo[0]) for finding number of elements in an array. Issue identified using coccicheck. Signed-off-by: Deepak R Varma --- drivers/staging/fbtft/fbtft.h | 2 +- 1 file changed, 1 inserti

[PATCH v3] drm/tests: Add back seed value information

2022-10-28 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they were refactored into KUnit. Add kunit_info with seed value information to assure reproducibility. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.org/

Re: [PATCH v3] dma-buf: cma_heap: Remove duplicated 'by' in comment

2022-10-28 Thread Mukesh Ojha
Hi, On 10/28/2022 12:25 PM, Mark-PK Tsai wrote: Remove duplicated 'by' from comment in cma_heap_allocate(). Signed-off-by: Mark-PK Tsai --- drivers/dma-buf/heaps/cma_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf

Re: [PATCH v7 00/10] drm: bridge: Add Samsung MIPI DSIM bridge

2022-10-28 Thread Sébastien Szymanski
Hello Jagan, On 10/5/22 17:12, Jagan Teki wrote: This series supports common bridge support for Samsung MIPI DSIM which is used in Exynos and i.MX8MM SoC's. The final bridge supports both the Exynos and i.MX8MM DSI devices. Changes for v7: * fix the drm bridge attach chain for exynos drm dsi d

[PATCH v4] drm/tests: Add back seed value information

2022-10-28 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they were refactored into KUnit. Add kunit_info with seed value information to assure reproducibility. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo --- v1->v2: https://lore.kernel.org/

Re: [PATCH] [next] drm/amdgpu: Replace one-element array with flexible-array member

2022-10-28 Thread Christian König
Am 28.10.22 um 18:36 schrieb Kees Cook: On Fri, Oct 28, 2022 at 09:18:39AM +0200, Christian König wrote: Am 28.10.22 um 07:10 schrieb Paulo Miguel Almeida: One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexib

Re: [PATCH v1 1/7] vfio/ccw: create a parent struct

2022-10-28 Thread Eric Farman
On Fri, 2022-10-28 at 12:51 -0400, Matthew Rosato wrote: > On 10/19/22 12:21 PM, Eric Farman wrote: > > Move the stuff associated with the mdev parent (and thus the > > subchannel struct) into its own struct, and leave the rest in > > the existing private structure. > > > > The subchannel will poi

Re: [PATCH 5/5] drm/i915/mtl: don't expose GSC command streamer to the user

2022-10-28 Thread Ceraolo Spurio, Daniele
On 10/27/2022 8:40 PM, Matt Roper wrote: On Thu, Oct 27, 2022 at 03:15:54PM -0700, Daniele Ceraolo Spurio wrote: There is no userspace user for this CS yet, we only need it for internal kernel ops (e.g. HuC, PXP), so don't expose it. Signed-off-by: Daniele Ceraolo Spurio Cc: Matt Roper Si

Re: [Intel-gfx] [PATCH 3/5] drm/i915/mtl: add GSC CS interrupt support

2022-10-28 Thread Ceraolo Spurio, Daniele
On 10/28/2022 1:38 AM, Tvrtko Ursulin wrote: On 27/10/2022 23:15, Daniele Ceraolo Spurio wrote: The GSC CS re-uses the same interrupt bits that the GSC used in older platforms. This means that we can now have an engine interrupt coming out of OTHER_CLASS, so we need to handle that appropriat

Re: [PATCH] [next] drm/amdgpu: Replace one-element array with flexible-array member

2022-10-28 Thread Kees Cook
On Fri, Oct 28, 2022 at 09:18:39AM +0200, Christian König wrote: > Am 28.10.22 um 07:10 schrieb Paulo Miguel Almeida: > > One-element arrays are deprecated, and we are replacing them with > > flexible array members instead. So, replace one-element array with > > flexible-array member in struct _ATO

Re: [PATCH v3] dma-buf: cma_heap: Remove duplicated 'by' in comment

2022-10-28 Thread John Stultz
On Thu, Oct 27, 2022 at 11:55 PM Mark-PK Tsai wrote: > > Remove duplicated 'by' from comment in cma_heap_allocate(). > > Signed-off-by: Mark-PK Tsai Thanks for sending this and going through a few iterations! Acked-by: John Stultz -john

Re: [PATCH v3 1/7] drm/ivpu: Introduce a new DRM driver for Intel VPU

2022-10-28 Thread Jacek Lawrynowicz
Hi, thanks for in-depth review. On 10/25/2022 2:38 PM, Thomas Zimmermann wrote: > Hi, > > please find some review comments below. > > Am 24.09.22 um 17:11 schrieb Jacek Lawrynowicz: >> +static int ivpu_irq_init(struct ivpu_device *vdev) >> +{ >> +    struct pci_dev *pdev = to_pci_dev(vdev->drm.d

Re: [Intel-gfx] Developing a new backlight driver for specific OLED screen

2022-10-28 Thread Aurélien
Hi, I come back on my problem regarding the development of a specific driver which controls the brightness of my OLED device. > If it's eDP and uses some proprietary DPCD brightness control mechanism, > I think in practice it usually is somewhat dependent on the GPU. > > (OTOH I realize you do

Re: Try to address the DMA-buf coherency problem

2022-10-28 Thread Nicolas Dufresne
Hi, just dropping some real live use case, sorry I'm not really proposing solutions, I believe you are much more knowledgeable in this regard. Le vendredi 28 octobre 2022 à 16:26 +0200, Christian König a écrit : > Am 28.10.22 um 13:42 schrieb Lucas Stach: > > Am Freitag, dem 28.10.2022 um 10:40 +

Re: [v6] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-10-28 Thread Marijn Suijten
On 2022-10-01 20:15:06, Kalyan Thota wrote: > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > Representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds necessa

Re: [PATCH v2] dma-buf: cma_heap: Fix typo in comment

2022-10-28 Thread Jonathan Corbet
Mark-PK Tsai writes: >> [-- Attachment #1: Type: text/plain, Size: 349 bytes --] >> >> On Fri, Oct 28, 2022 at 09:44:17AM +0800, Mark-PK Tsai wrote: >> > Remove duplicated "by" from comment in cma_heap_allocate(). >> > >> >> This patch isn't typofix but duplicate word stripping, right? If so,

Re: [PATCH v2] drm: bridge: adv7511: use dev_err_probe in probe function

2022-10-28 Thread Neil Armstrong
Hi, On Wed, 26 Oct 2022 14:52:46 +0200, Ahmad Fatoum wrote: > adv7511 probe may need to be attempted multiple times before no > -EPROBE_DEFER is returned. Currently, every such probe results in > an error message: > > [4.534229] adv7511 1-003d: failed to find dsi host > [4.580288] adv7511

Re: Try to address the DMA-buf coherency problem

2022-10-28 Thread Christian König
Am 28.10.22 um 13:42 schrieb Lucas Stach: Am Freitag, dem 28.10.2022 um 10:40 +0200 schrieb Christian König: But essentially the right thing to do. The only alternative I can see is to reverse the role of exporter and importer. I don't think that would work generally either, as buffer exporter

Re: [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-10-28 Thread Bjorn Andersson
On Fri, Oct 28, 2022 at 02:08:12PM +0200, Robert Foss wrote: > The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. > > In order to toggle the board to enable the HDMI output, > switch #7 & #8 on the rightmost multi-switch package have > to be toggled to On. > > Signed-off-by: Robert Fo

Re: [PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-10-28 Thread Dmitry Baryshkov
On 28/10/2022 15:08, Robert Foss wrote: The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. In order to toggle the board to enable the HDMI output, switch #7 & #8 on the rightmost multi-switch package have to be toggled to On. Since this doesn't look like a default setup, it would p

Re: [PATCH v1 8/9] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-10-28 Thread Bjorn Andersson
On Fri, Oct 28, 2022 at 02:08:11PM +0200, Robert Foss wrote: > Enable the display subsystem and the dsi0 output for > the sm8350-hdk board. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22 ++ > 1 file changed, 22 insertions(+) > > diff --g

Re: [PATCH v1 7/9] arm64: dts: qcom: sm8350: Add display system nodes

2022-10-28 Thread Bjorn Andersson
On Fri, Oct 28, 2022 at 02:08:10PM +0200, Robert Foss wrote: > Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these > nodes the display subsystem is configured to support > one DSI output. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 196 +

Re: [PATCH v1 6/9] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-10-28 Thread Bjorn Andersson
On Fri, Oct 28, 2022 at 02:08:09PM +0200, Robert Foss wrote: > Use two interconnect cells in order to optionally > support a path tag. > > Signed-off-by: Robert Foss > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > d

[PATCH RESEND] gpu: host1x: fix memory leak of device names

2022-10-28 Thread Yang Yingliang
The device names allocated by dev_set_name() need be freed before module unloading, but they can not be freed because the kobject's refcount which was set in device_initialize() has not be decreased to 0. Fix the name leak by calling put_device() to give up the refcount, so the name can be freed i

Re: [PATCH -next] gpu: host1x: fix memory leak of device names

2022-10-28 Thread Yang Yingliang
Sorry for the noisy, it should for linux master, not next, I will resend it with right title, please ignore this patch. Thanks, Yang On 2022/10/28 20:52, Yang Yingliang wrote: The device names allocated by dev_set_name() need be freed before module unloading, but they can not be freed because t

[PATCH -next] gpu: host1x: fix memory leak of device names

2022-10-28 Thread Yang Yingliang
The device names allocated by dev_set_name() need be freed before module unloading, but they can not be freed because the kobject's refcount which was set in device_initialize() has not be decreased to 0. Fix the name leak by calling put_device() to give up the refcount, so the name can be freed i

Re: [PATCH v3 0/6] Add support for atomic async page-flips

2022-10-28 Thread André Almeida
On 10/13/22 13:02, Simon Ser wrote: So no tests that actually verify that the kernel properly rejects stuff stuff like modesets, gamma LUT updates, plane movement, etc.? Pondering this a bit more, it just occurred to me the current driver level checks might easily lead to confusing behaviour. E

Re: [PATCH v1 1/9] drm/msm: Add compatibles for SM8350 display

2022-10-28 Thread Dmitry Baryshkov
On 28/10/2022 15:19, Dmitry Baryshkov wrote: On 28/10/2022 15:08, Robert Foss wrote: Add compatible string for "qcom,sm8350-dpu" and "qcom,sm8350-mdss". Signed-off-by: Robert Foss ---   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 +   drivers/gpu/drm/msm/msm_mdss.c  | 1 +   2 files chan

Re: [PATCH v1 3/9] drm/msm/dpu: Add SM8350 to hw catalog

2022-10-28 Thread Dmitry Baryshkov
On 28/10/2022 15:08, Robert Foss wrote: Add compatibility for SM8350 display subsystem, including required entries in DPU hw catalog. --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 217 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 1 + 2 files changed, 218 inserti

Re: [v6] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-10-28 Thread Dmitry Baryshkov
On 07/10/2022 17:34, Kalyan Thota wrote: -Original Message- From: Dmitry Baryshkov Sent: Tuesday, October 4, 2022 8:03 PM To: Kalyan Thota (QUIC) Cc: dri-devel@lists.freedesktop.org; linux-arm-...@vger.kernel.org; freedr...@lists.freedesktop.org; devicet...@vger.kernel.org; linux- ke

[PATCH v2 1/2] drm/ofdrm: Convert PCI IDs to CPU endianness for comparing

2022-10-28 Thread Thomas Zimmermann
Properties of 32-bit integers are returned from the OF device tree as type __be32. Convert PCI vendor and device IDs from __be32 to host endianness before comparing them to constants. All relevant machines are old, big-endian Macintosh systems; hence the bug never happened in practice. Fixes spars

[PATCH v2 0/2] drm/ofdrm: Fix sparse warnings

2022-10-28 Thread Thomas Zimmermann
Fix two types of sparse warnings in ofdrm. Reported by the LKP bot. v2: * convert PCI ID endianness (Alex) Thomas Zimmermann (2): drm/ofdrm: Convert PCI IDs to CPU endianness for comparing drm/ofdrm: Cast error pointers to void __iomem * drivers/gpu/drm/tiny/ofdrm.c | 27 +++

[PATCH v2 2/2] drm/ofdrm: Cast error pointers to void __iomem *

2022-10-28 Thread Thomas Zimmermann
Cast error pointers when returning them as void __iomem *. Fixes a number of Sparse warnings, such as the ones shown below. ../drivers/gpu/drm/tiny/ofdrm.c:439:31: warning: incorrect type in return expression (different address spaces) ../drivers/gpu/drm/tiny/ofdrm.c:439:31:expected void [nod

Re: [PATCH v1 1/9] drm/msm: Add compatibles for SM8350 display

2022-10-28 Thread Dmitry Baryshkov
On 28/10/2022 15:08, Robert Foss wrote: Add compatible string for "qcom,sm8350-dpu" and "qcom,sm8350-mdss". Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + drivers/gpu/drm/msm/msm_mdss.c | 1 + 2 files changed, 2 insertions(+) [skipped] diff --git

Re: [PATCH v1 2/9] drm/msm/dpu: Refactor sc7280_pp location

2022-10-28 Thread Dmitry Baryshkov
On 28/10/2022 15:08, Robert Foss wrote: The sc7280_pp declaration is not located by the other _pp declarations, but rather hidden around the _merge_3d declarations. Let's fix this to avoid confusion. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 14 +++---

Re: [PATCH v1 1/9] drm/msm: Add compatibles for SM8350 display

2022-10-28 Thread Dmitry Baryshkov
On 28/10/2022 15:08, Robert Foss wrote: Add compatible string for "qcom,sm8350-dpu" and "qcom,sm8350-mdss". Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + drivers/gpu/drm/msm/msm_mdss.c | 1 + 2 files changed, 2 insertions(+) Reviewed-by: Dmitry Bar

Re: [PATCH v7 01/10] drm: bridge: Add Samsung DSIM bridge driver

2022-10-28 Thread Jagan Teki
On Tue, Oct 18, 2022 at 8:35 AM Jagan Teki wrote: > > On Mon, Oct 17, 2022 at 2:31 PM Marek Szyprowski > wrote: > > > > Hi, > > > > On 17.10.2022 10:48, Marek Vasut wrote: > > > On 10/17/22 09:43, Jagan Teki wrote: > > >> On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut wrote: > > >>> On 10/17/22 04

[PATCH v1 9/9] arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge

2022-10-28 Thread Robert Foss
The sm8350-hdk ships with the LT9611 UXC DSI/HDMI bridge chip. In order to toggle the board to enable the HDMI output, switch #7 & #8 on the rightmost multi-switch package have to be toggled to On. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 106

[PATCH v1 8/9] arm64: dts: qcom: sm8350-hdk: Enable display & dsi nodes

2022-10-28 Thread Robert Foss
Enable the display subsystem and the dsi0 output for the sm8350-hdk board. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350

[PATCH v1 7/9] arm64: dts: qcom: sm8350: Add display system nodes

2022-10-28 Thread Robert Foss
Add mdss, mdss_mdp, dsi0, dsi0_phy nodes. With these nodes the display subsystem is configured to support one DSI output. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 196 ++- 1 file changed, 192 insertions(+), 4 deletions(-) diff --git a/arch/ar

[PATCH v1 5/9] arm64: dts: qcom: sm8350: Remove mmxc power-domain-name

2022-10-28 Thread Robert Foss
The mmxc power-domain-name is not required, and is not used by either earlier or later SoC versions (sm8250 / sm8450). Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dt

[PATCH v1 6/9] arm64: dts: qcom: sm8350: Use 2 interconnect cells

2022-10-28 Thread Robert Foss
Use two interconnect cells in order to optionally support a path tag. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350.dtsi | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm

[PATCH v1 1/9] drm/msm: Add compatibles for SM8350 display

2022-10-28 Thread Robert Foss
Add compatible string for "qcom,sm8350-dpu" and "qcom,sm8350-mdss". Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + drivers/gpu/drm/msm/msm_mdss.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/d

[PATCH v1 2/9] drm/msm/dpu: Refactor sc7280_pp location

2022-10-28 Thread Robert Foss
The sc7280_pp declaration is not located by the other _pp declarations, but rather hidden around the _merge_3d declarations. Let's fix this to avoid confusion. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 14 +++--- 1 file changed, 7 insertions(+), 7 de

[PATCH v1 4/9] arm64: dts: qcom: sm8350: Add &tlmm gpio-line-names

2022-10-28 Thread Robert Foss
Add GPIO line names as described by the sm8350-hdk schematic. Signed-off-by: Robert Foss --- arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 205 1 file changed, 205 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts

[PATCH v1 3/9] drm/msm/dpu: Add SM8350 to hw catalog

2022-10-28 Thread Robert Foss
Add compatibility for SM8350 display subsystem, including required entries in DPU hw catalog. --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 217 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h| 1 + 2 files changed, 218 insertions(+) diff --git a/drivers/gpu/drm/msm/disp

[PATCH v1 0/9] Enable Display for SM8350

2022-10-28 Thread Robert Foss
This series implements display support for SM8350 and enables HDMI output for the SM8350-HDK platform. Robert Foss (9): drm/msm: Add compatibles for SM8350 display drm/msm/dpu: Refactor sc7280_pp location drm/msm/dpu: Add SM8350 to hw catalog arm64: dts: qcom: sm8350: Add &tlmm gpio-line-n

  1   2   >