Re: [PATCH] drm/rockchip: vop2: Fix Null Pointer Dereference on Multiple VPs

2022-09-13 Thread Sascha Hauer
On Tue, Sep 13, 2022 at 08:55:22AM +0200, Michael Riesch wrote: > Hi, > > On 9/12/22 20:02, Chris Morgan wrote: > > From: Chris Morgan > > Cc: Sascha -> any thoughts on this one? > > Best regards, > Michael > > > If I use more than one VP to output on an RK3566 based device I > > receive the f

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-13 Thread Johan Hovold
On Tue, Sep 13, 2022 at 03:23:10PM -0500, Steev Klimaszewski wrote: > Hi Johan, > > On 9/13/22 3:53 AM, Johan Hovold wrote: > > The MSM DRM driver is currently broken in multiple ways with respect to > > probe deferral. Not only does the driver currently fail to probe again > > after a late deferr

[PATCH 7/8] drm/amd/display: make some functions static

2022-09-13 Thread Jiapeng Chong
These functions are not used outside the file dcn32_dccg.c, so the modification is defined as static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_dccg.c:257:6: warning: no previous prototype for ‘dccg32_otg_drop_pixel’. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_dccg.c:248:6: w

[PATCH 8/8] drm/amd/display: make optc32_phantom_crtc_post_enable, optc32_setup_manual_trigger and optc32_set_drr static

2022-09-13 Thread Jiapeng Chong
These three functions are not used outside the function dcn32_optc.c, so the modification is defined as static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_optc.c:159:6: warning: no previous prototype for function 'optc32_phantom_crtc_post_enable'. drivers/gpu/drm/amd/amdgpu/../display/d

[PATCH 3/8] drm/amd/display: make optc314_phantom_crtc_post_enable static

2022-09-13 Thread Jiapeng Chong
This symbol is not used outside of dcn314_optc.c, so marks it static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_optc.c:153:6: warning: no previous prototype for ‘optc314_phantom_crtc_post_enable’. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2147 Reported-by: Abaci Robot Si

[PATCH 5/8] drm/amd/display: make mmhubbub32_config_mcif_buf static

2022-09-13 Thread Jiapeng Chong
This symbol is not used outside of dcn32_mmhubbub.c, so marks it static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mmhubbub.c:103:6: warning: no previous prototype for ‘mmhubbub32_config_mcif_buf’. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2145 Reported-by: Abaci Robot Sig

[PATCH 6/8] drm/amd/display: make some functions static

2022-09-13 Thread Jiapeng Chong
These functions are not used outside the file dcn32_hubbub.c, so the modification is defined as static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_hubbub.c:912:6: warning: no previous prototype for ‘hubbub32_force_wm_propagate_to_pipes’. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dc

[PATCH 4/8] drm/amd/display: make some functions static

2022-09-13 Thread Jiapeng Chong
These functions are not used outside the file dcn32_hubbub.c, so the modification is defined as static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:223:6: warning: no previous prototype for ‘dccg314_set_valid_pixel_rate’. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dc

[PATCH 2/8] drm/amd/display: make enc314_stream_encoder_dvi_set_stream_attribute static

2022-09-13 Thread Jiapeng Chong
This symbol is not used outside of dcn314_dio_stream_encoder.c, so marks it static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dio_stream_encoder.c:84:6: warning: no previous prototype for ‘enc314_stream_encoder_dvi_set_stream_attribute’. Link: https://bugzilla.openanolis.cn/show_bu

[PATCH 1/8] drm/amd/display: make some functions static

2022-09-13 Thread Jiapeng Chong
These functions are not used outside the file dcn30_resource.c, so the modification is defined as static. drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_resource.c:1949:6: warning: no previous prototype for ‘is_refresh_rate_support_mclk_switch_using_fw_based_vblank_stretch’. drivers/gpu/dr

Re: [PATCH v2 2/3] drm/i915/gt: Extract per-platform function for frequency read

2022-09-13 Thread Gustavo Sousa
On Tue, Sep 13, 2022 at 02:09:57PM -0700, Lucas De Marchi wrote: > Instead of calling read_clock_frequency() to walk the if/else ladder > per platform, move the ladder to intel_gt_init_clock_frequency() and > use one function per branch. > > With the new logic, it's now clear the call to > gen9_ge

回复: Re: 回复: Re: [PATCH] drm:Fix the blank screen problem of some 1920x1080 75Hz monitors using R520 graphics card

2022-09-13 Thread 钟沛
Sorry to trouble you, we ran some tests on this patch and want to communicate with you.static void amdgpu_pll_get_fb_ref_div(struct amdgpu_device *adev, unsigned nom, unsigned den, unsigned post_div,unsigned fb_div_max, unsigned ref_div_ma

[PATCH v2 1/1] drm/i915/uc: Fix issues with overriding firmware files

2022-09-13 Thread John . C . Harrison
From: John Harrison The earlier update to support reduced versioning of firmware files introduced an issue with the firmware override module parameter. If an invalid file was specified then an infinite loop could occur trying to find a backup firmware. The fix is that if an explicit override has

[PATCH v2 0/1] Fix bug in version reduced firmware update

2022-09-13 Thread John . C . Harrison
From: John Harrison The earlier patch to support firmware files with reduced versioning introduced an issue with the firmware override module parameter. So fix that. v2: Also remove ANSI colour codes that accidentally got left in an error message in the original patch. Signed-off-by: John Harri

Re: [Freedreno] [PATCH] drm/msm: Fix return type of mdp4_lvds_connector_mode_valid

2022-09-13 Thread Abhinav Kumar
Hi Nathan Thanks for the patch. On 9/13/2022 1:55 PM, Nathan Huckleberry wrote: The mode_valid field in drm_connector_helper_funcs is expected to be of type: enum drm_mode_status (* mode_valid) (struct drm_connector *connector, struct drm_display_mode *mode

[PATCH] drm/i915/huc: stall media submission until HuC is loaded

2022-09-13 Thread Daniele Ceraolo Spurio
Wait on the fence to be signalled to avoid the submissions finding HuC not yet loaded. v2: use dedicaded wait_queue_entry for waiting in HuC load, as submitq can't be re-used for it. Signed-off-by: Daniele Ceraolo Spurio Cc: Tony Ye Reviewed-by: Alan Previn #v1 Acked-by: Tony Ye --- drivers/

Re: [PATCH] drm: xlnx: Fix return type of zynqmp_dp_connector_mode_valid

2022-09-13 Thread Nathan Chancellor
On Tue, Sep 13, 2022 at 01:56:00PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode *mode); > > Th

Re: [PATCH] drm/rockchip: Fix return type of cdn_dp_connector_mode_valid

2022-09-13 Thread Nathan Chancellor
On Tue, Sep 13, 2022 at 01:55:55PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, >struct drm_display_mode *mode); > > The

Re: [PATCH] drm/msm: Fix return type of mdp4_lvds_connector_mode_valid

2022-09-13 Thread Nathan Chancellor
On Tue, Sep 13, 2022 at 01:55:48PM -0700, Nathan Huckleberry wrote: > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode *mode); > > T

Re: [PATCH] drm/i915: Fix return type of mode_valid function hook

2022-09-13 Thread Nathan Chancellor
On Tue, Sep 13, 2022 at 01:55:27PM -0700, Nathan Huckleberry wrote: > All of the functions used for intel_dvo_dev_ops.mode_valid have a return > type of enum drm_mode_status, but the mode_valid field in the struct > definition has a return type of int. > > The mismatched return type breaks forward

Re: [PATCH] drm/exynos: Fix return type for mixer_mode_valid and hdmi_mode_valid

2022-09-13 Thread Nathan Chancellor
On Tue, Sep 13, 2022 at 01:54:49PM -0700, Nathan Huckleberry wrote: > The field mode_valid in exynos_drm_crtc_ops is expected to be of type > enum drm_mode_status (*mode_valid)(struct exynos_drm_crtc *crtc, >const struct drm_display_mode *mode); > > Likewise for

Re: [PATCH 0/5] drm/amd/display: Reduce stack usage for clang

2022-09-13 Thread Rodrigo Siqueira Jordao
On 2022-09-12 18:02, Nathan Chancellor wrote: Hi Rodrigo, On Mon, Sep 12, 2022 at 05:50:31PM -0400, Rodrigo Siqueira Jordao wrote: On 2022-08-30 16:34, Nathan Chancellor wrote: Hi all, This series aims to address the following warnings, which are visible when building x86_64 allmodconfig

[linux-next:master] BUILD REGRESSION 0caac1da994900d12a9be6106edb8e98696712a3

2022-09-13 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 0caac1da994900d12a9be6106edb8e98696712a3 Add linux-next specific files for 20220913 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.fqi69rlv-...@intel.com https

Re: [PATCH] drm/imx: imx-tve: Fix return type of imx_tve_connector_mode_valid

2022-09-13 Thread Fabio Estevam
Hi Nathan, On Tue, Sep 13, 2022 at 5:55 PM Nathan Huckleberry wrote: > > The mode_valid field in drm_connector_helper_funcs is expected to be of > type: > enum drm_mode_status (* mode_valid) (struct drm_connector *connector, > struct drm_display_mode *mode); >

[PATCH drm-misc-next v2 5/6] drm/arm/hdlcd: crtc: protect device resources after removal

2022-09-13 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical sectio

[PATCH drm-misc-next v2 1/6] drm/arm/hdlcd: use drmm_* to allocate driver structures

2022-09-13 Thread Danilo Krummrich
Use drm managed resources to allocate driver structures and get rid of the deprecated drm_dev_alloc() call and replace it with devm_drm_dev_alloc(). This also serves as preparation to get rid of drm_device->dev_private and to fix use-after-free issues on driver unload. Signed-off-by: Danilo Krumm

[PATCH drm-misc-next v2 6/6] drm/arm/hdlcd: debugfs: protect device resources after removal

2022-09-13 Thread Danilo Krummrich
(Hardware) resources which are bound to the driver and device lifecycle must not be accessed after the device and driver are unbound. However, the DRM device isn't freed as long as the last user didn't close it, hence userspace can still call into the driver. Therefore protect the critical sectio

[PATCH drm-misc-next v2 3/6] drm/arm/hdlcd: plane: use drm managed resources

2022-09-13 Thread Danilo Krummrich
Use drm managed resource allocation (drmm_universal_plane_alloc()) in order to get rid of the explicit destroy hook in struct drm_plane_funcs. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/hdlcd_crtc.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --

[PATCH drm-misc-next v2 4/6] drm/arm/hdlcd: use drm_dev_unplug()

2022-09-13 Thread Danilo Krummrich
When the driver is unbound, there might still be users in userspace having an open fd and are calling into the driver. While this is fine for drm managed resources, it is not for resources bound to the device/driver lifecycle, e.g. clocks or MMIO mappings. To prevent use-after-free issues we need

[PATCH drm-misc-next v2 2/6] drm/arm/hdlcd: replace drm->dev_private with drm_to_hdlcd_priv()

2022-09-13 Thread Danilo Krummrich
Using drm_device->dev_private is deprecated. Since we've switched to devm_drm_dev_alloc(), struct drm_device is now embedded in struct hdlcd_drm_private, hence we can use container_of() to get the struct drm_device instance instead. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/arm/hdlcd_c

[PATCH drm-misc-next v2 0/6] drm/arm/hdlcd: use drm managed resources

2022-09-13 Thread Danilo Krummrich
Hi, This patch series converts the driver to use drm managed resources to prevent potential use-after-free issues on driver unbind/rebind and to get rid of the usage of deprecated APIs. Changes in v2: - drop patch "drm/arm/hdlcd: crtc: use drmm_crtc_init_with_planes()" Danilo Krummrich (6):

Re: [PATCH RESEND drm-misc-next 4/7] drm/arm/hdlcd: plane: use drm managed resources

2022-09-13 Thread Danilo Krummrich
On 9/13/22 10:58, Liviu Dudau wrote: On Mon, Sep 12, 2022 at 09:50:26PM +0200, Danilo Krummrich wrote: Hi Liviu, Hi Danilo, Thanks for having a look! This is not about this patch, it's about patch 3/7 "drm/arm/hdlcd: crtc: use drmm_crtc_init_with_planes()". Agree! However, this is the pa

[PATCH v2 2/3] drm/i915/gt: Extract per-platform function for frequency read

2022-09-13 Thread Lucas De Marchi
Instead of calling read_clock_frequency() to walk the if/else ladder per platform, move the ladder to intel_gt_init_clock_frequency() and use one function per branch. With the new logic, it's now clear the call to gen9_get_crystal_clock_freq() was just dead code, as gen9 is handled by another func

[PATCH v2 0/3] drm/i915: A couple of if/else ladder refactors

2022-09-13 Thread Lucas De Marchi
Refactor code to follow the same convention as last platform first. This series includes one patch that had already been reviewed, for frequency read and 2 more refactors. v2: Fix patch 2 not considering intel_gt_check_clock_frequency() call to read frequency (Gustavo) Signed-off-by: Lucas De Ma

[PATCH v2 3/3] drm/i915: Invert if/else ladder for stolen init

2022-09-13 Thread Lucas De Marchi
Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first branch. Reviewed-by: Gustavo Sousa Signed-off-by: Lucas De Marchi diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/dri

[PATCH v2 1/3] drm/i915: Invert if/else ladder for frequency read

2022-09-13 Thread Lucas De Marchi
Continue converting the driver to the convention of last version first, extending it to the future platforms. Now, any GRAPHICS_VER >= 11 will be handled by the first branch. With the new ranges it's easier to see what platform a branch started to be taken. Besides the >= 11 change, the branch tak

[PATCH v3] drm/sched: Add FIFO sched policy to run queue v3

2022-09-13 Thread Andrey Grodzovsky
Given many entities competing for same run queue on the same scheduler and unacceptably long wait time for some jobs waiting stuck in the run queue before being picked up are observed (seen using  GPUVis). The issue is due to the Round Robin policy used by schedulers to pick up the next entity's jo

Re: [Intel-gfx] [PATCH v5 5/5] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-09-13 Thread Matt Roper
On Tue, Sep 13, 2022 at 11:33:41AM -0700, Radhakrishna Sripada wrote: > From: Madhumitha Tolakanahalli Pradeep > > > In Display version 14, Transcoder Chicken Registers have updated address. > This patch performs checks to use the right register when required. > > v2: Omit display version check

Re: [PATCH v5 4/5] drm/i915/mtl: Update MBUS_DBOX credits

2022-09-13 Thread Matt Roper
On Tue, Sep 13, 2022 at 11:33:40AM -0700, Radhakrishna Sripada wrote: > Display version 14 platforms have different credits values > compared to ADL-P. Update the credits based on pipe usage. > > v2: Simplify DBOX BW Credit definition(MattR) > v3: > - Simplify only pipe per dbuf bank check(MattR)

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-13 Thread Steev Klimaszewski
Hi Johan, On 9/13/22 3:53 AM, Johan Hovold wrote: The MSM DRM driver is currently broken in multiple ways with respect to probe deferral. Not only does the driver currently fail to probe again after a late deferral, but due to a related use-after-free bug this also triggers NULL-pointer derefere

Re: [PATCH v5 3/5] drm/i915/mtl: Define engine context layouts

2022-09-13 Thread Matt Roper
On Tue, Sep 13, 2022 at 11:33:39AM -0700, Radhakrishna Sripada wrote: > From: Matt Roper > > The part of the media and blitter engine contexts that we care about for > setting up an initial state are the same on MTL as they were on DG2 > (and PVC), so we need to update the driver conditions to re

Re: [PATCH v5 2/5] drm/i915: Parse and set stepping for platforms with GMD

2022-09-13 Thread Matt Roper
On Tue, Sep 13, 2022 at 11:33:38AM -0700, Radhakrishna Sripada wrote: > From: José Roberto de Souza > > The GMD step field do not properly match the current stepping convention > that we use(STEP_A0, STEP_A1, STEP_B0...). > > One platform could have { arch = 12, rel = 70, step = 1 } and the > ac

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915: Read graphics/media/display arch version from hw

2022-09-13 Thread Jani Nikula
On Tue, 13 Sep 2022, Radhakrishna Sripada wrote: > From: Matt Roper > > Going forward, the hardware teams no longer consider new platforms to > have a "generation" in the way we've defined it for past platforms. > Instead, each IP block (graphics, media, display) will have their own > architectu

[PATCH v5 20/21] media: videobuf2: Stop using internal dma-buf lock

2022-09-13 Thread Dmitry Osipenko
All drivers that use dma-bufs have been moved to the updated locking specification and now dma-buf reservation is guaranteed to be locked by importers during the mapping operations. There is no need to take the internal dma-buf lock anymore. Remove locking from the videobuf2 memory allocators. Ack

[PATCH v5 13/21] media: videobuf2: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare V4L2 memory allocators to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Tomasz Figa Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/media/common/videobuf2/videobuf2-dma-contig.c | 11 +

[PATCH v5 21/21] dma-buf: Remove obsoleted internal lock

2022-09-13 Thread Dmitry Osipenko
The internal dma-buf lock isn't needed anymore because the updated locking specification claims that dma-buf reservation must be locked by importers, and thus, the internal data is already protected by the reservation lock. Remove the obsoleted internal lock. Acked-by: Christian König Reviewed-by

[PATCH v5 18/21] dma-buf: Move dma_buf_mmap() to dynamic locking specification

2022-09-13 Thread Dmitry Osipenko
Move dma_buf_mmap() function to the dynamic locking specification by taking the reservation lock. Neither of the today's drivers take the reservation lock within the mmap() callback, hence it's safe to enforce the locking. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma

[PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification

2022-09-13 Thread Dmitry Osipenko
Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking specification by asserting that the reservation lock is held. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/dma-buf/dma-b

[PATCH v5 19/21] dma-buf: Document dynamic locking convention

2022-09-13 Thread Dmitry Osipenko
Add documentation for the dynamic locking convention. The documentation tells dma-buf API users when they should take the reservation lock and when not. Reviewed-by: Christian König Signed-off-by: Dmitry Osipenko --- Documentation/driver-api/dma-buf.rst | 6 +++ drivers/dma-buf/dma-buf.c

[PATCH v5 14/21] media: tegra-vde: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare Tegra video decoder driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/media/platform/nvidia/tegra-vde/dmabuf-cache.c | 6 +++--- 1 file changed,

[PATCH v5 16/21] dma-buf: Move dma_buf_attach() to dynamic locking specification

2022-09-13 Thread Dmitry Osipenko
Move dma-buf attachment API functions to the dynamic locking specification by taking the reservation lock around the mapping operations. The strict locking convention prevents deadlock situations for dma-buf importers and exporters. Reviewed-by: Christian König Signed-off-by: Dmitry Osipenko ---

[PATCH v5 12/21] xen/gntdev: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare gntdev driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Juergen Gross Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/xen/gntdev-dmabuf.c | 8 1 file changed, 4 insertions(

[PATCH v5 17/21] dma-buf: Move dma_buf_map_attachment() to dynamic locking specification

2022-09-13 Thread Dmitry Osipenko
Move dma-buf attachment mapping functions to the dynamic locking specification by asserting that the reservation lock is held. Reviewed-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a

[PATCH v5 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare Etnaviv driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH v5 11/21] misc: fastrpc: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare fastrpc to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Acked-by: Srinivas Kandagatla Signed-off-by: Dmitry Osipenko --- drivers/misc/fastrpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 d

[PATCH v5 10/21] RDMA/umem: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare InfiniBand drivers to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/infiniband/core/umem_dmabuf.c | 7 --- 1 file changed, 4 insertions(+), 3 delet

[PATCH v5 08/21] drm/tegra: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare Tegra DRM driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/tegra/gem.c | 17 + 1 file changed, 9 insertions(+), 8 deleti

[PATCH v5 07/21] drm/omapdrm: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare OMAP DRM driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/omapdrm/omap_gem_dmabuf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v5 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare i915 driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions and handling cases where importer now holds the reservation lock. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/i915/gem/i915_gem

[PATCH v5 05/21] drm/armada: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare Armada driver to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/armada/armada_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-

[PATCH v5 03/21] drm/gem: Take reservation lock for vmap/vunmap operations

2022-09-13 Thread Dmitry Osipenko
The new common dma-buf locking convention will require buffer importers to hold the reservation lock around mapping operations. Make DRM GEM core to take the lock around the vmapping operations and update DRM drivers to use the locked functions for the case where DRM core now holds the lock. This p

[PATCH v5 01/21] dma-buf: Add unlocked variant of vmapping functions

2022-09-13 Thread Dmitry Osipenko
Add unlocked variant of dma_buf_vmap/vunmap() that will be utilized by drivers that don't take the reservation lock explicitly. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 38 ++ include/linux/dma-buf.h | 2 ++

[PATCH v5 04/21] drm/prime: Prepare to dynamic dma-buf locking specification

2022-09-13 Thread Dmitry Osipenko
Prepare DRM prime core to the common dynamic dma-buf locking convention by starting to use the unlocked versions of dma-buf API functions. Reviewed-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/gpu/drm/drm_prime.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[PATCH v5 02/21] dma-buf: Add unlocked variant of attachment-mapping functions

2022-09-13 Thread Dmitry Osipenko
Add unlocked variant of dma_buf_map/unmap_attachment() that will be used by drivers that don't take the reservation lock explicitly. Acked-by: Christian König Signed-off-by: Dmitry Osipenko --- drivers/dma-buf/dma-buf.c | 53 +++ include/linux/dma-buf.h |

[PATCH v5 00/21] Move all drivers to a common dma-buf locking convention

2022-09-13 Thread Dmitry Osipenko
Hello, This series moves all drivers to a dynamic dma-buf locking specification. >From now on all dma-buf importers are made responsible for holding dma-buf's reservation lock around all operations performed over dma-bufs in accordance to the locking specification. This allows us to utilize reserv

Re: [PATCH 0/6] Remove unused declarations for gpu/drm

2022-09-13 Thread Alex Deucher
Pushed patches 1-5 to drm-misc-next. Alex On Tue, Sep 13, 2022 at 2:14 AM Christian König wrote: > > Nice cleanup. Acked-by: Christian König for > the whole series. > > Thanks, > Christian. > > Am 13.09.22 um 04:48 schrieb Gaosheng Cui: > > This series contains a few cleanup patches, to remove

[PATCH v5 5/5] drm/i915/mtl: Update CHICKEN_TRANS* register addresses

2022-09-13 Thread Radhakrishna Sripada
From: Madhumitha Tolakanahalli Pradeep In Display version 14, Transcoder Chicken Registers have updated address. This patch performs checks to use the right register when required. v2: Omit display version check in i915_reg.h(Jani) v3: - Remove extra whitespace introduced - Fix reg definition

[PATCH v5 1/5] drm/i915: Read graphics/media/display arch version from hw

2022-09-13 Thread Radhakrishna Sripada
From: Matt Roper Going forward, the hardware teams no longer consider new platforms to have a "generation" in the way we've defined it for past platforms. Instead, each IP block (graphics, media, display) will have their own architecture major.minor versions and stepping ID's which should be read

[PATCH v5 0/5] Initial Meteorlake Support

2022-09-13 Thread Radhakrishna Sripada
The PCI Id's and platform definition are posted earlier. This series adds handful of early enablement patches including support for display power wells, VBT and AUX Channel mapping, PCH and gmbus support, dbus, mbus, sagv and memory bandwidth support. This series also add the support for a new way

[PATCH v5 3/5] drm/i915/mtl: Define engine context layouts

2022-09-13 Thread Radhakrishna Sripada
From: Matt Roper The part of the media and blitter engine contexts that we care about for setting up an initial state are the same on MTL as they were on DG2 (and PVC), so we need to update the driver conditions to re-use the DG2 context table. For render/compute engines, the part of the context

[PATCH v5 2/5] drm/i915: Parse and set stepping for platforms with GMD

2022-09-13 Thread Radhakrishna Sripada
From: José Roberto de Souza The GMD step field do not properly match the current stepping convention that we use(STEP_A0, STEP_A1, STEP_B0...). One platform could have { arch = 12, rel = 70, step = 1 } and the actual stepping is STEP_B0 but without the translation of the step field would mean ST

[PATCH v5 4/5] drm/i915/mtl: Update MBUS_DBOX credits

2022-09-13 Thread Radhakrishna Sripada
Display version 14 platforms have different credits values compared to ADL-P. Update the credits based on pipe usage. v2: Simplify DBOX BW Credit definition(MattR) v3: - Simplify only pipe per dbuf bank check(MattR) - Skip modeset check to ahndle the case when a new pipe within dbuf bank gets

Re: [PATCH 6/6] drm/i915: remove unused i915_gem_lmem_obj_ops declaration

2022-09-13 Thread Jani Nikula
On Tue, 13 Sep 2022, Gaosheng Cui wrote: > i915_gem_lmem_obj_ops has been removed since > commit 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 > gem object backend"), so remove it. Thanks, pushed this one patch to drm-intel-gt-next. BR, Jani. > > Signed-off-by: Gaosheng Cui > --- > driver

Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver

2022-09-13 Thread Jagan Teki
On Wed, Sep 7, 2022 at 3:34 PM Marek Szyprowski wrote: > > Hi Jagan, > > On 06.09.2022 21:07, Jagan Teki wrote: > > On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski > > wrote: > >> On 02.09.2022 12:47, Marek Szyprowski wrote: > >>> On 29.08.2022 20:40, Jagan Teki wrote: > Samsung MIPI DSIM co

Re: [PATCH v7 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-09-13 Thread Dmitry Baryshkov
On 13/09/2022 20:04, Dmitry Baryshkov wrote: On 13/09/2022 17:51, Vinod Polimera wrote: Update crtc retrieval from dpu_enc to dpu_enc connector state, since new links get set as part of the dpu enc virt mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change

Re: [PATCH v7 01/15] drm/msm/disp/dpu: clear dpu_assign_crtc and get crtc from connector state instead of dpu_enc

2022-09-13 Thread Dmitry Baryshkov
On 13/09/2022 17:51, Vinod Polimera wrote: Update crtc retrieval from dpu_enc to dpu_enc connector state, since new links get set as part of the dpu enc virt mode set. The dpu_enc->crtc cache is no more needed, hence cleaning it as part of this change. Signed-off-by: Vinod Polimera --- driver

[PATCH v3] drm/plane-helper: Add a drm_plane_helper_atomic_check() helper

2022-09-13 Thread Javier Martinez Canillas
Provides a default plane state check handler for primary planes that are a fullscreen scanout buffer and whose state scale and position can't change. There are some drivers that duplicate this logic in their helpers, such as simpledrm and ssd130x. Factor out this common code into a plane helper an

Re: [PATCH v2 4/7] drm/ivpu: Add IPC driver and JSM messages

2022-09-13 Thread kernel test robot
Hi Jacek, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm/drm-next drm-intel/for-linux-next drm-tip/drm-tip linus/master v6.0-rc5 next-20220913] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v7 1/9] drm_print: condense enum drm_debug_category

2022-09-13 Thread jim . cromie
On Mon, Sep 12, 2022 at 4:17 AM Jani Nikula wrote: > > On Sun, 11 Sep 2022, Jim Cromie wrote: > > enum drm_debug_category has 10 categories, but is initialized with > > bitmasks which require 10 bits of underlying storage. By using > > natural enumeration, and moving the BIT(cat) into drm_debug_

Re: [Freedreno] [PATCH 0/2] Add support for HDR color formats

2022-09-13 Thread Jessica Zhang
Hi Dmitry, On 9/12/2022 11:33 AM, Dmitry Baryshkov wrote: On 01/09/2022 23:34, Jessica Zhang wrote: Add support for HDR color formats. XR30 linear/compressed format has been validated with null_platform_test on SC7180, and P010 linear has been validated with plane_test (also on SC7180). Are

Re: [PATCH v1 1/2] Revert "dt-bindings: Add byteswap order to chrontel ch7033"

2022-09-13 Thread Rob Herring
On Mon, Sep 12, 2022 at 01:38:57PM +0200, Robert Foss wrote: > As reported by Laurent in response to this commit[1], this functionality > should > not be implemented using the devicetree, because of this let's revert this > series > for now. > > This reverts commit a4be71430c76eca43679e8485085c2

Re: [PATCH] drm/fourcc: Fix vsub/hsub for Q410 and Q401

2022-09-13 Thread Liviu Dudau
On Tue, Sep 13, 2022 at 03:43:06PM +0100, Brian Starkey wrote: > These formats are not subsampled, but that means hsub and vsub should be > 1, not 0. > > Fixes: 94b292b27734 ("drm: drm_fourcc: add NV15, Q410, Q401 YUV formats") > Reported-by: George Kennedy > Reported-by: butt3rflyh4ck > Signed-

Re: [PATCH] drm/rockchip: vop2: Fix Null Pointer Dereference on Multiple VPs

2022-09-13 Thread Chris Morgan
On Tue, Sep 13, 2022 at 11:10:16AM +0200, Piotr Oniszczuk wrote: > > > > Wiadomość napisana przez Michael Riesch w > > dniu 13.09.2022, o godz. 08:55: > > > > Hi, > > > > On 9/12/22 20:02, Chris Morgan wrote: > >> From: Chris Morgan > > > > Cc: Sascha -> any thoughts on this one? > > > > B

Re: [PATCH v4 0/8] drm/vc4: Reset HDMI link at hotplug

2022-09-13 Thread Maxime Ripard
On Mon, 29 Aug 2022 15:47:23 +0200, Maxime Ripard wrote: > This is a follow-up of the work to support the interactions between the > hotplug > and the scrambling support for vc4: > > https://lore.kernel.org/dri-devel/20210507150515.257424-11-max...@cerno.tech/ > https://lore.kernel.org/dri-devel/

Re: [PATCH] drm/hyperv: Don't rely on screen_info.lfb_base for Gen1 VMs

2022-09-13 Thread Thomas Zimmermann
Hi Am 13.09.22 um 17:15 schrieb Saurabh Singh Sengar: On Mon, Sep 12, 2022 at 09:03:53AM +0200, Thomas Zimmermann wrote: Hi Am 11.09.22 um 18:21 schrieb Saurabh Singh Sengar: On Sat, Sep 10, 2022 at 08:11:24PM +0200, Thomas Zimmermann wrote: Hi Am 09.09.22 um 16:43 schrieb Saurabh Sengar:

Re: [PATCH v2] drm/plane-helper: Add a drm_plane_helper_atomic_check() helper

2022-09-13 Thread Thomas Zimmermann
Hi Am 13.09.22 um 15:49 schrieb Harry Wentland: On 2022-09-13 05:33, Javier Martinez Canillas wrote: Provides a default plane state check handler for primary planes that are a fullscreen scanout buffer and whose state scale and position can't change. Even though this might be how some driv

Re: [PATCH] drm/hyperv: Don't rely on screen_info.lfb_base for Gen1 VMs

2022-09-13 Thread Saurabh Singh Sengar
On Mon, Sep 12, 2022 at 09:03:53AM +0200, Thomas Zimmermann wrote: > Hi > > Am 11.09.22 um 18:21 schrieb Saurabh Singh Sengar: > >On Sat, Sep 10, 2022 at 08:11:24PM +0200, Thomas Zimmermann wrote: > >>Hi > >> > >>Am 09.09.22 um 16:43 schrieb Saurabh Sengar: > >>>hyperv_setup_vram tries to remove c

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-13 Thread Wang Yugui
Hi, > Hi > > Am 13.09.22 um 16:25 schrieb Wang Yugui: > > Hi, > > > >> Hi > >> > >> Am 07.09.22 um 06:16 schrieb Wang Yugui: > >>> Hi, > >>> > Am 02.09.22 um 07:52 schrieb Wang Yugui: > > Hi, > > > > mgag200 broken on kernel-6.0-rc3 on DELL/T620. > > > > See the attacheme

Re: [PATCH v2] drm/plane-helper: Add a drm_plane_helper_atomic_check() helper

2022-09-13 Thread Harry Wentland
On 2022-09-13 10:46, Javier Martinez Canillas wrote: > On 9/13/22 15:49, Harry Wentland wrote: >> >> >> On 2022-09-13 05:33, Javier Martinez Canillas wrote: >>> Provides a default plane state check handler for primary planes that are a >>> fullscreen scanout buffer and whose state scale and posi

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

2022-09-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216455 --- Comment #8 from Alex Deucher (alexdeuc...@gmail.com) --- Patch: https://patchwork.freedesktop.org/patch/501912/ -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[PATCH v7 12/15] drm/msm/disp/dpu: get timing engine status from intf status register

2022-09-13 Thread Vinod Polimera
Timing gen status can be read reliablly from intf status register rather than from the timing gen control register, which will readback as "0" after disable though the timing gen is still under going disable path. This support was added from DPU version 5.0.0. Signed-off-by: Vinod Polimera --- d

[PATCH v7 06/15] drm/msm/dp: disable self_refresh_aware after entering psr

2022-09-13 Thread Vinod Polimera
From: Sankeerth Billakanti Updated frames get queued if self_refresh_aware is set when the sink is in psr. To support bridge enable and avoid queuing of update frames, reset the self_refresh_aware state after entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera ---

[PATCH v7 09/15] drm/msm/disp/dpu: use atomic enable/disable callbacks for encoder functions

2022-09-13 Thread Vinod Polimera
Use atomic variants for encoder callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 ++-

[PATCH v7 08/15] drm/bridge: add psr support for panel bridge callbacks

2022-09-13 Thread Vinod Polimera
This change will handle the psr entry exit cases in the panel bridge atomic callback functions. For example, the panel power should not turn off if the panel is entering psr. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera --- drivers/gpu/drm/bridge/panel.c | 48 ++

[PATCH v7 11/15] drm/msm/disp/dpu: add PSR support for eDP interface in dpu driver

2022-09-13 Thread Vinod Polimera
Enable PSR on eDP interface using drm self-refresh librabry. This patch uses a trigger from self-refresh library to enter/exit into PSR, when there are no updates from framework. Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dis

[PATCH v7 10/15] drm/msm/disp/dpu: check for crtc enable rather than crtc active to release shared resources

2022-09-13 Thread Vinod Polimera
According to KMS documentation, The driver must not release any shared resources if active is set to false but enable still true. Fixes: ccc862b957c6 ("drm/msm/dpu: Fix reservation failures in modeset") Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu

[PATCH v7 07/15] drm/bridge: use atomic enable/disable callbacks for panel bridge

2022-09-13 Thread Vinod Polimera
Use atomic variants for panel bridge callback functions such that certain states like self-refresh can be accessed as part of enable/disable sequence. Signed-off-by: Sankeerth Billakanti Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/panel.c | 20 +++

[PATCH v7 13/15] drm/msm/disp/dpu: wait for extra vsync till timing engine status is disabled

2022-09-13 Thread Vinod Polimera
There can be a race between timing gen disable and vblank irq. The wait post timing gen disable may return early but intf disable sequence might not be completed. Ensure that, intf status is disabled before we retire the function. Signed-off-by: Vinod Polimera --- .../gpu/drm/msm/disp/dpu1/dpu_e

[PATCH v7 15/15] drm/msm/disp/dpu: clear active interface in the datapath cleanup

2022-09-13 Thread Vinod Polimera
Clear interface active register from the datapath for a clean shutdown of the datapath. Signed-off-by: Vinod Polimera --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu

[PATCH v7 00/15] Add PSR support for eDP

2022-09-13 Thread Vinod Polimera
Changes in v2: - Use dp bridge to set psr entry/exit instead of dpu_enocder. - Don't modify whitespaces. - Set self refresh aware from atomic_check. - Set self refresh aware only if psr is supported. - Provide a stub for msm_dp_display_set_psr. - Move dp functions to bridge code. Chang

  1   2   >