Patch "drm/amd/display: fix memory leak when using debugfs_lookup()" has been added to the 5.19-stable tree

2022-09-09 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amd/display: fix memory leak when using debugfs_lookup() to the 5.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is

Patch "drm/amd/display: fix memory leak when using debugfs_lookup()" has been added to the 5.15-stable tree

2022-09-09 Thread gregkh
This is a note to let you know that I've just added the patch titled drm/amd/display: fix memory leak when using debugfs_lookup() to the 5.15-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is

Re: [PATCH] drm/vkms: fix 32bit compilation error by replacing macros

2022-09-09 Thread Igor Matheus Andrade Torrente
Hi Mellisa, Thanks for the patch fixing my mistakes. On 9/9/22 08:41, Melissa Wen wrote: Replace vkms_formats macros for fixed-point operations with functions from drm/drm_fixed.h to do the same job and fix 32-bit compilation errors. Fixes: a19c2ac9858 ("drm: vkms: Add support to the RGB565 fo

Re: [PATCH v4 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-09-09 Thread Teres Alexis, Alan Previn
Nit: wish some of those macro param names were more descriptive, example : fw_def -> fw_namer or prefix -> gen But that's irrelevant here, so Reviewed-by: Alan Previn On Thu, 2022-09-08 at 17:16 -0700, Ceraolo Spurio, Daniele wrote: > The fw name is different and we need to record the fact tha

[PATCH] drm/i915/mtl: Add MTL forcewake support

2022-09-09 Thread Matt Roper
MTL has separate forcewake tables for the primary/render GT and the media GT; each GT's intel_uncore will use a separate forcewake table and should only initialize the domains that are relevant to that GT. The GT ack register also moves to a new location of (GSI base + 0xDFC) on this platform. No

[PATCH 3/3] drm/i915/rps: Freq caps for MTL

2022-09-09 Thread Ashutosh Dixit
For MTL, when reading from HW, RP0, RP1 (actuall RPe) and RPn freq use an entirely different set of registers with different fields, bitwidths and units. v2: Move MTL check into a separate function (Jani) Cc: Jani Nikula Cc: Badal Nilawar Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi

[PATCH 1/3] drm/i915/debugfs: Add perf_limit_reasons in debugfs

2022-09-09 Thread Ashutosh Dixit
From: Tilak Tangudu Add perf_limit_reasons in debugfs. The upper 16 perf_limit_reasons RW "log" bits are identical to the lower 16 RO "status" bits except that the "log" bits remain set until cleared, thereby ensuring the throttling occurrence is not missed. The clear fop clears the upper 16 "log

[PATCH 2/3] drm/i915/mtl: PERF_LIMIT_REASONS changes for MTL

2022-09-09 Thread Ashutosh Dixit
PERF_LIMIT_REASONS register for MTL media gt is different now. v2: Avoid static inline for intel_gt_perf_limit_reasons_reg() (Jani) Cc: Jani Nikula Cc: Badal Nilawar Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_gt.c| 6 ++ drivers/

[PATCH 0/3] i915: freq caps and perf_limit_reasons changes for MTL

2022-09-09 Thread Ashutosh Dixit
Since https://patchwork.freedesktop.org/series/107908/ is now merged, rebase this series on latest drm-tip and post a clean series. Ashutosh Dixit (2): drm/i915/mtl: PERF_LIMIT_REASONS changes for MTL drm/i915/rps: Freq caps for MTL Tilak Tangudu (1): drm/i915/debugfs: Add perf_limit_reason

Re: [PATCH v3 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-09 Thread Jason Gunthorpe
On Fri, Sep 09, 2022 at 08:42:25AM +, Tian, Kevin wrote: > I think it's quite common to have an alloc() helper initialize refcount, e.g. > vfio_group_alloc() both initialize its user refcount and also call > device_initialize() to gets kref initialized. Similar example in > ib_alloc_device(),

Re: [PATCH v6 28/57] drm_print: refine drm_debug_enabled for jump-label

2022-09-09 Thread jim . cromie
On Wed, Sep 7, 2022 at 12:40 AM Daniel Vetter wrote: > > On Sun, Sep 04, 2022 at 03:41:05PM -0600, Jim Cromie wrote: > > In order to use dynamic-debug's jump-label optimization in drm-debug, > > its clarifying to refine drm_debug_enabled into 3 uses: > > > > 1. drm_debug_enabled - legacy, public

[PATCH v2 2/2] drm/i915/gt: Extract function to apply media fuses

2022-09-09 Thread Lucas De Marchi
Just like is done for compute and copy engines, extract a function to handle media engines. While at it, be consistent on using or not the uncore/gt/info variable aliases. Reviewed-by: Matt Roper Signed-off-by: Lucas De Marchi diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gp

[PATCH v2 0/2] drm/i915: Media fuses future-proofing

2022-09-09 Thread Lucas De Marchi
-- 1 file changed, 74 insertions(+), 68 deletions(-) --- base-commit: ff8b32fbe64a79b380b1cca4232d30c0b29df069 change-id: 20220909-media-87cd0701e0d8 Best regards, -- Lucas De Marchi

[PATCH v2 1/2] drm/i915/gt: Use MEDIA_VER() when handling media fuses

2022-09-09 Thread Lucas De Marchi
Check for media IP version instead of graphics since this is figuring out the media engines' configuration. Currently the only platform with non-matching graphics/media version is Meteor Lake: update the check in gen11_vdbox_has_sfc() so it considers not only version 12, but also any later version

Re: [PATCH v6 01/12] dt-bindings: display/msm: split qcom, mdss bindings

2022-09-09 Thread Rob Herring
On Thu, Sep 8, 2022 at 3:20 PM Dmitry Baryshkov wrote: > > On 08/09/2022 22:37, Rob Herring wrote: > > On Thu, Sep 08, 2022 at 03:37:38PM +0200, Krzysztof Kozlowski wrote: > >> On 01/09/2022 12:23, Dmitry Baryshkov wrote: > >>> Split Mobile Display SubSystem (MDSS) root node bindings to the separa

Re: [PATCH v2 2/2] pci_ids: Add the various Microsoft PCI device IDs

2022-09-09 Thread Easwar Hariharan
On 9/9/22 19:38, Bjorn Helgaas wrote: Please follow the PCI subject line conventions. Discover it with "git log --oneline include/linux/pci_ids.h". On Fri, Sep 09, 2022 at 11:50:25AM -0700, Easwar Hariharan wrote: From: Easwar Hariharan Needs a commit log, even if it is nothing more than the

Re: [PATCH v2 2/2] pci_ids: Add the various Microsoft PCI device IDs

2022-09-09 Thread Easwar Hariharan
On 9/9/22 19:38, Bjorn Helgaas wrote: Please follow the PCI subject line conventions. Discover it with "git log --oneline include/linux/pci_ids.h". Thanks, updated. On Fri, Sep 09, 2022 at 11:50:25AM -0700, Easwar Hariharan wrote: From: Easwar Hariharan Needs a commit log, even if it is no

[linux-next:master] BUILD REGRESSION 9a82ccda91ed2b40619cb3c10d446ae1f97bab6e

2022-09-09 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9a82ccda91ed2b40619cb3c10d446ae1f97bab6e Add linux-next specific files for 20220909 Error/Warning reports: https://lore.kernel.org/linux-mm/202209042337.fqi69rlv-...@intel.com https

Re: [PATCH v4 12/15] drm/i915/huc: stall media submission until HuC is loaded

2022-09-09 Thread Ye, Tony
On 9/8/2022 5:16 PM, Daniele Ceraolo Spurio wrote: Wait on the fence to be signalled to avoid the submissions finding HuC not yet loaded. Signed-off-by: Daniele Ceraolo Spurio Cc: Tony Ye Reviewed-by: Alan Previn --- drivers/gpu/drm/i915/gt/uc/intel_huc.h | 6 ++ drivers/gpu/drm/i91

Re: [PATCH v4 14/15] drm/i915/huc: define gsc-compatible HuC fw for DG2

2022-09-09 Thread Ye, Tony
On 9/8/2022 5:16 PM, Daniele Ceraolo Spurio wrote: The fw name is different and we need to record the fact that the blob is gsc-loaded, so add a new macro to help. Note: A-step DG2 G10 does not support HuC loading via GSC and would require a separate firmware to be loaded the legacy way, but t

Re: [PATCH v4 11/15] drm/i915/huc: track delayed HuC load with a fence

2022-09-09 Thread Teres Alexis, Alan Previn
Reviewed-by: Alan Previn On Thu, 2022-09-08 at 17:16 -0700, Ceraolo Spurio, Daniele wrote: > Given that HuC load is delayed on DG2, this patch adds support for a fence > that can be used to wait for load completion. No waiters are added in this > patch (they're coming up in the next one), to keep

Re: [PATCH] drm/amdgpu/display: remove unneeded "default n" options

2022-09-09 Thread Alex Deucher
Applied. Thanks, Alex On Fri, Sep 9, 2022 at 3:54 PM Jingyu Wang wrote: > > Remove "default n" options. If the "default" line is removed, it > defaults to 'n'. > > Signed-off-by: Jingyu Wang > --- > drivers/gpu/drm/amd/display/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/

Re: [PATCH] drm/amd/display: Remove var declaration in dcn32_full_validate_bw_helper()

2022-09-09 Thread Alex Deucher
Already fixed a few days ago. Thanks for the patch. Alex On Thu, Sep 8, 2022 at 4:51 AM Jocelyn Falempe wrote: > > The variable i is already declared as uint32_t in the same function. > > This fixes the following error, when compiling this code on older kernel: > drivers/gpu/drm/amd/amdgpu/../d

Re: [PATCH] drm/amd/display: fix repeated words in comments

2022-09-09 Thread Alex Deucher
Applied. Thanks! On Wed, Sep 7, 2022 at 12:11 AM Jilin Yuan wrote: > > Delete the redundant word 'in'. > > Signed-off-by: Jilin Yuan > --- > drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c

2022-09-09 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Sep 6, 2022 at 2:48 PM Deucher, Alexander wrote: > > [Public] > > > Yeah, seems to be a mix. I don't have a strong opinion as long as it has MIT. > > Alex > > > From: Kuehling, Felix > Sent: Tuesday, September 6, 2022 9:46 AM > To

RE: [PATCH v3 07/14] drm/i915: Use a DRM-managed action to release the PCI bridge device

2022-09-09 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Matt > Roper > Sent: Tuesday, September 6, 2022 4:49 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Subject: [PATCH v3 07/14] drm/i915: Use a DRM-managed action to release the > PCI bridge device > >

Re: [PATCH v3 5/6] drm/sched: Use parent fence instead of finished

2022-09-09 Thread Andrey Grodzovsky
Got it. Reviewed-by: Andrey Grodzovsky Andrey On 2022-09-09 16:30, Yadav, Arvind wrote: On 9/9/2022 11:02 PM, Andrey Grodzovsky wrote: What exactly is the scenario which this patch fixes in more detail please  ? GPU reset issue started after adding [PATCH 6/6]. Root cause -> In drm_sche

Re: [PATCH v4 10/15] drm/i915/dg2: setup HuC loading via GSC

2022-09-09 Thread Teres Alexis, Alan Previn
Nearly identical as before: Reviewed-by: Alan Previn On Thu, 2022-09-08 at 17:16 -0700, Ceraolo Spurio, Daniele wrote: > The GSC will perform both the load and the authentication, so we just > need to check the auth bit after the GSC has replied. > Since we require the PXP module to load the HuC

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd.c

2022-09-09 Thread Alex Deucher
Applied. Thanks! On Mon, Sep 5, 2022 at 3:57 AM Jingyu Wang wrote: > > Fix everything checkpatch.pl complained about in amdgpu_amdkfd.c > > Signed-off-by: Jingyu Wang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/a

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_sync.c file

2022-09-09 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Sep 5, 2022 at 2:29 AM Jingyu Wang wrote: > > This is a patch to the amdgpu_sync.c file that fixes some warnings found by > the checkpatch.pl tool > > Signed-off-by: Jingyu Wang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 4 +++- > 1 file changed, 3 inser

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_acpi.c

2022-09-09 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Sep 5, 2022 at 2:29 AM Jingyu Wang wrote: > > Fix everything checkpatch.pl complained about in amdgpu_acpi.c > > Signed-off-by: Jingyu Wang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > di

Re: [PATCH linux-next] drm/amdgpu: Remove the unneeded result variable

2022-09-09 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Sep 2, 2022 at 4:04 AM wrote: > > From: zhang songyi > > Return the sdma_v6_0_start() directly instead of storing it in another > redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: zhang songyi > --- > drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 5 +-

Re: [PATCH linux-next] drm/radeon: Remove the unneeded result variable

2022-09-09 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Sep 2, 2022 at 3:33 AM wrote: > > From: ye xingchen > > Return the value radeon_drm_ioctl() directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen > --- > drivers/gpu/drm/radeon/radeon_drv.c | 5

Re: [PATCH linux-next] drm/radeon/ci_dpm: Remove the unneeded result variable

2022-09-09 Thread Alex Deucher
Applied. Thanks! On Fri, Sep 2, 2022 at 3:32 AM wrote: > > From: ye xingchen > > Return the value ci_load_smc_ucode() directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen > --- > drivers/gpu/drm/radeon/ci_dpm.c | 6 ++ >

Re: [PATCH v6 17/57] dyndbg: validate class FOO by checking with module

2022-09-09 Thread jim . cromie
On Wed, Sep 7, 2022 at 12:19 PM Jason Baron wrote: > > > > On 9/4/22 17:40, Jim Cromie wrote: > > Add module-to-class validation: > > > > #> echo class DRM_UT_KMS +p > /proc/dynamic_debug/control > > > > If a query has "class FOO", then ddebug_find_valid_class(), called > > from ddebug_change(),

Re: [PATCH -next] drm/amd/display: remove possible condition with no effect (if == else)

2022-09-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Sep 1, 2022 at 4:34 AM Yang Li wrote: > > Conditional statements have no effect to next process.So remove it. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2028 > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > .../drm/amd/display/dc/dml/dcn

Re: [PATCH -next] drm/amd/display: Simplify bool conversion

2022-09-09 Thread Alex Deucher
Applied. Thanks! On Thu, Sep 1, 2022 at 4:11 AM Yang Li wrote: > > The result of relational operation is Boolean, and the question mark > expression is redundant. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2027 > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > .../gpu/

Re: [Intel-gfx] [PATCH v2] Revert "drm/i915/dg2: extend Wa_1409120013 to DG2"

2022-09-09 Thread Lucas De Marchi
On Wed, Sep 07, 2022 at 04:25:42PM -0700, Lucas De Marchi wrote: This reverts commit 487970e8bb776c989013bb59d6cbb22e45b9afc6. Updated bspec and workaround database note Wa_1409120013 is not needed for DG2 (or any Xe_LPD) platform. Simply check by display version 12. v2: Simplify condition chec

Re: [PATCH -next] drm/amd/display: clean up some inconsistent indentings

2022-09-09 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Sep 1, 2022 at 3:57 AM Yang Li wrote: > > This if statement is the content of the for statement above it. It > should be indented. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2026 > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > drivers/g

Re: [PATCH v3 5/6] drm/sched: Use parent fence instead of finished

2022-09-09 Thread Yadav, Arvind
On 9/9/2022 11:02 PM, Andrey Grodzovsky wrote: What exactly is the scenario which this patch fixes in more detail please  ? GPU reset issue started after adding [PATCH 6/6]. Root cause -> In drm_sched_get_cleanup_job(), We use the finished fence status bit to check the job status dma_fence

[PATCH] drm/amdgpu/display: remove unneeded "default n" options

2022-09-09 Thread Jingyu Wang
Remove "default n" options. If the "default" line is removed, it defaults to 'n'. Signed-off-by: Jingyu Wang --- drivers/gpu/drm/amd/display/Kconfig | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig index 413d8c6d592f.

Re: [PATCH v2 2/2] pci_ids: Add the various Microsoft PCI device IDs

2022-09-09 Thread Bjorn Helgaas
Please follow the PCI subject line conventions. Discover it with "git log --oneline include/linux/pci_ids.h". On Fri, Sep 09, 2022 at 11:50:25AM -0700, Easwar Hariharan wrote: > From: Easwar Hariharan > Needs a commit log, even if it is nothing more than the subject line. Also read the top of

Re: [PATCH 2/2] drm/format: Split into more granular test cases

2022-09-09 Thread Maíra Canal
On 8/31/22 18:56, Michał Winiarski wrote: > While we have multiple test cases, most of them check multiple > conditions, calling the function that is tested multiple times with > different arguments (with comments that indicate test case boundary). > This usually means that it can be easily convert

Re: [git pull] drm fixes for 6.0-rc5

2022-09-09 Thread pr-tracker-bot
The pull request you sent on Sat, 10 Sep 2022 01:57:22 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2022-09-10 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b7e00d6f55015f6995f41c60a5367f1065d37622 Thank you! -- Deet-doot-dot, I am a bot. https://k

Re: [PATCH v6 23/57] drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers.

2022-09-09 Thread jim . cromie
On Wed, Sep 7, 2022 at 12:13 AM Daniel Vetter wrote: > > On Sun, Sep 04, 2022 at 03:41:00PM -0600, Jim Cromie wrote: > > Use DECLARE_DYNDBG_CLASSMAP across DRM: > > > > - in .c files, since macro defines/initializes a record > > > > - in drivers, $mod_{drv,drm,param}.c > >ie where param setu

[PATCH v2 2/2] pci_ids: Add the various Microsoft PCI device IDs

2022-09-09 Thread Easwar Hariharan
From: Easwar Hariharan Signed-off-by: Easwar Hariharan --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 2 +- drivers/net/ethernet/microsoft/mana/gdma.h | 3 --- drivers/net/ethernet/microsoft/mana/gdma_main.c | 6 +++--- drivers/video/fbdev/hyperv_fb.c | 4 ++-- inclu

Re: [PATCH 0/4] drm/plane: Remove drm_plane_init(), plus other cleanups

2022-09-09 Thread Lyude Paul
For the nouveau bits on 1, 2 and 4: Reviewed-by: Lyude Paul On Fri, 2022-09-09 at 12:59 +0200, Thomas Zimmermann wrote: > This patchset does cleanups to the plane code, most noteably it removes > drm_plane_init(). The function is a small wrapper, which can easily be > inlined into the few caller

Re: [PATCH 1/4] drm/plane: Remove drm_plane_init()

2022-09-09 Thread Lyude Paul
Reviewed-by: Lyude Paul for common and nouveau bits On Fri, 2022-09-09 at 12:59 +0200, Thomas Zimmermann wrote: > Open-code drm_plane_init() and remove the function from DRM. The > implementation of drm_plane_init() is a simple wrapper around a call > to drm_universal_plane_init(), so drivers can

Re: [Intel-gfx] Developing a new backlight driver for specific OLED screen

2022-09-09 Thread Lyude Paul
On Fri, 2022-09-09 at 15:49 +, Aurélien wrote: > Hi, > > > + dri-devel mailing list that looks more appropriated. > > + Hans and Lyude who were recently working to standardize some of the > > backlight stuff. > > Thank you for these contacts. I'll try there if I need. > > > I don't believe

Re: [PATCH v4 06/21] drm/i915: Prepare to dynamic dma-buf locking specification

2022-09-09 Thread Dmitry Osipenko
On 9/2/22 19:26, Ruhl, Michael J wrote: >> 02.09.2022 13:31, Dmitry Osipenko пишет: >>> 01.09.2022 17:02, Ruhl, Michael J пишет: >>> ... > --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c > @@ -331,7 +331,19 @@ static void __i915_gem_fr

Re: [PATCH v3 5/6] drm/sched: Use parent fence instead of finished

2022-09-09 Thread Andrey Grodzovsky
What exactly is the scenario which this patch fixes in more detail please  ? Andrey On 2022-09-09 13:08, Arvind Yadav wrote: Using the parent fence instead of the finished fence to get the job status. This change is to avoid GPU scheduler timeout error which can cause GPU reset. Signed-off-by:

Re: [PATCH v8] drm: Add initial ci/ subdirectory

2022-09-09 Thread Daniel Stone
Hi, On Fri, 9 Sept 2022 at 15:15, Tomeu Vizoso wrote: > Also include a configuration file that points to the out-of-tree CI > scripts. > I think this para is outdated given ... v8: > - Move all files specific to testing the kernel into the kernel tree > (thus I have dropped the r-bs I h

[PATCH v2] drm/msm/dp: add atomic_check to bridge ops

2022-09-09 Thread Kuogee Hsieh
DRM commit_tails() will disable downstream crtc/encoder/bridge if both disable crtc is required and crtc->active is set before pushing a new frame downstream. There is a rare case that user space display manager issue an extra screen update immediately followed by close DRM device while down strea

Re: [Intel-gfx] [PATCH v4 11/11] drm/i915/mtl: Do not update GV point, mask value

2022-09-09 Thread Balasubramani Vivekanandan
On 01.09.2022 23:03, Radhakrishna Sripada wrote: > Display 14 and future platforms do not directly communicate to Pcode > via mailbox the SAGV bandwidth information. PM Demand registers are > used to communicate display power requirements to the PUnit which would > include GV point and mask value.

[PATCH v3 6/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-09 Thread Arvind Yadav
Fence signaling must be enabled to make sure that the dma_fence_is_signaled() function ever returns true. Since drivers and implementations sometimes mess this up, this ensures correct behaviour when DEBUG_WW_MUTEX_SLOWPATH is used during debugging. This should make any implementation bugs resultin

[PATCH v3 5/6] drm/sched: Use parent fence instead of finished

2022-09-09 Thread Arvind Yadav
Using the parent fence instead of the finished fence to get the job status. This change is to avoid GPU scheduler timeout error which can cause GPU reset. Signed-off-by: Arvind Yadav --- changes in v1,v2 - Enable signaling for finished fence in sche_main() is removed --- drivers/gpu/drm/schedu

[PATCH v3 4/6] drm/amdgpu: Enable signaling on fence.

2022-09-09 Thread Arvind Yadav
Here's enabling software signaling on fence because amdgpu_ctx_add_fence() is checking the status of fence and emits warning. Signed-off-by: Arvind Yadav --- Changes in v1, v2: This new patch was not part of previous series. --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 2 ++ 1 file changed, 2

[PATCH v3 3/6] dma-buf: Enable signaling on fence for selftests

2022-09-09 Thread Arvind Yadav
Here's enabling software signaling on fence for selftest. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressing Christian's comment to remove unnecessary callback. 2- Replacing CONFIG_DEBUG_WW_MUTEX_SLOWPATH instead of CONFIG_DEBUG_FS. 3- The version of this patch is also changed and pre

[PATCH v3 2/6] dma-buf: set signaling bit for the stub fence

2022-09-09 Thread Arvind Yadav
Here's setting software signaling bit for the stub fence which is always signaled. If this fence signaling bit is not set then the AMD GPU scheduler will cause a GPU reset due to a GPU scheduler cleanup activity timeout. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressing Christian's c

[PATCH v3 1/6] dma-buf: Remove the signaled bit status check

2022-09-09 Thread Arvind Yadav
Remove the signaled bit status check because it is returning early when the fence is already signaled and __dma_fence_enable_signaling is checking the status of signaled bit again. Signed-off-by: Arvind Yadav --- Changes in v1, v2: This new patch was not part of previous series. --- drivers/dm

[PATCH v3 0/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-09 Thread Arvind Yadav
Fence signaling must be enabled to make sure that the dma_fence_is_signaled() function ever returns true. Since drivers and implementations sometimes mess this up, this ensures correct behaviour when DEBUG_WW_MUTEX_SLOWPATH is used during debugging. This should make any implementation bugs resultin

Re: [PATCH v2 2/4] dma-buf: enable signaling for the stub fence on debug

2022-09-09 Thread Yadav, Arvind
On 9/6/2022 12:39 PM, Christian König wrote: Am 05.09.22 um 18:35 schrieb Arvind Yadav: Here's on debug enabling software signaling for the stub fence which is always signaled. This fence should enable software signaling otherwise the AMD GPU scheduler will cause a GPU reset due to a GPU sch

[git pull] drm fixes for 6.0-rc5

2022-09-09 Thread Dave Airlie
Hi Linus, >From a train in the Irish countryside, regular drm fixes for 6.0-rc5. This is mostly amdgpu/amdkfd and i915 fixes, then one panfrost, one ttm and one edid fix. Nothing too major going on. Hopefully a quiet week next week for LPC. Dave. drm-fixes-2022-09-10: drm fixes for 6.0-rc5 edid

Re: [PATCH] drm/rockchip: fix repeated words in comments

2022-09-09 Thread Heiko Stuebner
On Thu, 8 Sep 2022 20:36:16 +0800, wangjianli wrote: > Delete the redundant word 'in'. Applied, thanks! [1/1] drm/rockchip: fix repeated words in comments commit: fe53d167129e19ce01c056d85262427146cacf88 Best regards, -- Heiko Stuebner

Re: (subset) [PATCH v2 0/5] rockchip-dsi for rk3568

2022-09-09 Thread Heiko Stuebner
On Tue, 6 Sep 2022 12:48:18 -0500, Chris Morgan wrote: > This series adds support for the dsi and dphy controllers on the > Rockchip RK3568. I can confirm that for the Rockchip RK3568 this > current series DOES WORK now, but it requires rolling back clk changes > made for the HDMI driver. If the cl

[PATCH] drm/msm/mdp5: fix kernel panic during shutdown

2022-09-09 Thread Fabien Parent
The kernel is panicking when rebooting on MSM8939: # reboot -f [ 87.280853] Unable to handle kernel write to read-only memory at virtual address 88ed5810 ... snip ... [ 87.445142] Call trace: [ 87.452253] mutex_lock+0x1c/0x50

Re: [Intel-gfx] Developing a new backlight driver for specific OLED screen

2022-09-09 Thread Jani Nikula
On Fri, 09 Sep 2022, Rodrigo Vivi wrote: > On Fri, Sep 09, 2022 at 11:35:28AM +0200, Aurélien wrote: >>Hi, >>I hope this mailing-mist is the right place for this question. > > + dri-devel mailing list that looks more appropriated. > + Hans and Lyude who were recently working to standardize

Re: [igt-dev] [PATCH i-g-t v2 3/4] lib/igt_kmod: add compatibility for KUnit

2022-09-09 Thread Janusz Krzysztofik
Hi Isabella, On Monday, 29 August 2022 02:09:19 CEST Isabella Basso wrote: > This adds functions for both executing the tests as well as parsing (K)TAP > kmsg output, as per the KTAP spec [1]. > > [1] https://www.kernel.org/doc/html/latest/dev-tools/ktap.html > > Signed-off-by: Isabella Basso >

Re: [igt-dev] [PATCH i-g-t v2 2/4] lib/igt_kmod.c: check if module is builtin before attempting to unload it

2022-09-09 Thread Janusz Krzysztofik
On Monday, 29 August 2022 02:09:18 CEST Isabella Basso wrote: > This change makes `igt_module_unload_r` safer as it checks whether the s/igt_module_unload_r/igt_kmod_unload_r/ > module can be unloaded before attempting it. > > Signed-off-by: Isabella Basso > --- > lib/igt_kmod.c | 3 +++ > 1 f

[PATCH] drm/hyperv: Add ratelimit on error message

2022-09-09 Thread Saurabh Sengar
Due to a full ring buffer, the driver may be unable to send updates to the Hyper-V host. But outputing the error message can make the problem worse because console output is also typically written to the frame buffer. Rate limiting the error message, also output the error code for additional diagn

Re: [igt-dev] [PATCH i-g-t v2 1/4] lib/igt_kmod: rename kselftest functions to ktest

2022-09-09 Thread Janusz Krzysztofik
On Monday, 29 August 2022 02:09:17 CEST Isabella Basso wrote: > This aims at making IGT's structure more general to different kernel > testing frameworks such as KUnit, as they use a lot of the same > functionality. > > Signed-off-by: Isabella Basso LGTM Reviewed-by: Janusz Krzysztofik > ---

Re: [PATCH v2 2/2] drm/etnaviv: fix power register offset on GC300

2022-09-09 Thread Doug Brown
Hi Lucas, On 9/9/2022 1:48 AM, Lucas Stach wrote: @@ -83,10 +83,15 @@ static void etnaviv_core_dump_registers(struct core_dump_iterator *iter, { struct etnaviv_dump_registers *reg = iter->data; unsigned int i; + u32 addr; for (i = 0; i < ARRAY_SIZE(etnaviv_dump_re

Re: [PATCH v4 4/8] drm/vc4: hdmi: Simplify the hotplug handling

2022-09-09 Thread Ville Syrjälä
On Fri, Sep 09, 2022 at 04:36:44PM +0200, Maxime Ripard wrote: > Hi Ville > > Thanks for your review > > On Mon, Sep 05, 2022 at 08:38:11PM +0300, Ville Syrjälä wrote: > > On Mon, Aug 29, 2022 at 03:47:27PM +0200, Maxime Ripard wrote: > > > Our detect callback has a bunch of operations to perform

Re: [igt-dev] [PATCH i-g-t v2 0/4] Add support for KUnit tests

2022-09-09 Thread Janusz Krzysztofik
Hi Isabella, On Monday, 29 August 2022 02:09:16 CEST Isabella Basso wrote: > This patch series was first developed as part of the LKCamp hackathon > that happened last year[1], mainly focusing on refactoring DRM tests to > use KUnit. > > KUnit[2][3] is a unified test framework that provides helpe

[PATCH] drm/hyperv: Don't rely on screen_info.lfb_base for Gen1 VMs

2022-09-09 Thread Saurabh Sengar
hyperv_setup_vram tries to remove conflicting framebuffer based on 'screen_info'. As observed in past due to some bug or wrong setting in grub, the 'screen_info' fields may not be set for Gen1, and in such cases drm_aperture_remove_conflicting_framebuffers will not do anything useful. For Gen1 VMs,

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-09 Thread Hans de Goede
Hi, On 9/9/22 15:39, Simon Ser wrote: > On Friday, September 9th, 2022 at 12:12, Hans de Goede > wrote: > >> Phase 3: Deprecate /sys/class/backlight uAPI >> >> >> Once most userspace has moved over to using the new drm_connector >> brightness props,

Re: Meeting (BOF) at Plumbers Dublin to discuss backlight brightness as connector object property RFC?

2022-09-09 Thread Daniel Stone
On Fri, 9 Sept 2022 at 12:50, Simon Ser wrote: > On Friday, September 9th, 2022 at 12:23, Hans de Goede < > hdego...@redhat.com> wrote: > > "people using > > non fully integrated desktop environments like e.g. sway often use custom > > scripts binded to hotkeys to get functionality like the brigh

Re: [PATCH v4 4/8] drm/vc4: hdmi: Simplify the hotplug handling

2022-09-09 Thread Maxime Ripard
Hi Ville Thanks for your review On Mon, Sep 05, 2022 at 08:38:11PM +0300, Ville Syrjälä wrote: > On Mon, Aug 29, 2022 at 03:47:27PM +0200, Maxime Ripard wrote: > > Our detect callback has a bunch of operations to perform depending on > > the current and last status of the connector, such a settin

Re: [PATCH v2 4/5] phy/rockchip: inno-dsidphy: Add support for rk3568

2022-09-09 Thread Heiko Stübner
Am Dienstag, 6. September 2022, 19:48:22 CEST schrieb Chris Morgan: > From: Chris Morgan > > Add support for the Rockchip RK3568 DSI-DPHY. Registers were taken from > the BSP kernel driver and wherever possible cross referenced with the > TRM. With the amount of refactoring done below, I'd expec

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-09 Thread Jason Gunthorpe
On Fri, Sep 09, 2022 at 06:24:35AM -0700, Christoph Hellwig wrote: > On Wed, Sep 07, 2022 at 01:12:52PM -0300, Jason Gunthorpe wrote: > > The PCI offset is some embedded thing - I've never seen it in a server > > platform. > > That's not actually true, e.g. some power system definitively had it, >

Re: [PATCH 2/3] pci_ids: Add Microsoft PCI Vendor ID, and remove redundant definitions

2022-09-09 Thread Vitaly Kuznetsov
eahar...@linux.microsoft.com writes: > From: Easwar Hariharan > > Move the Microsoft PCI Vendor ID from the various drivers to the pci_ids > file > > Signed-off-by: Easwar Hariharan > --- > drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 - > drivers/net/ethernet/microsoft/mana/gdma_main.c

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-09 Thread Simon Ser
On Friday, September 9th, 2022 at 15:53, Pekka Paalanen wrote: > On Fri, 09 Sep 2022 13:39:37 + > Simon Ser cont...@emersion.fr wrote: > > > On Friday, September 9th, 2022 at 12:12, Hans de Goede hdego...@redhat.com > > wrote: > > > > > Phase 3: Deprecate /sys/class/backlight uAPI > > > =

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-09 Thread Maxime Ripard
On Wed, Sep 07, 2022 at 11:31:21PM +0200, Mateusz Kwiatkowski wrote: > The "canonical" modelines (at least for vc4's VEC, see the notes below): > > - (vfp==4, vsync==6, vbp==39) for 576i > - (vfp==7, vsync==6, vbp==32) for 480i > - (vfp==5, vsync==6, vbp==28) for 486i (full frame NTSC as originall

Re: [PATCH v2 2/5] dt-bindings: phy-rockchip-inno-dsidphy: add compatible for rk3568

2022-09-09 Thread Heiko Stübner
Am Dienstag, 6. September 2022, 19:48:20 CEST schrieb Chris Morgan: > From: Chris Morgan > > Add a compatible string for the rk3568 dsi-dphy. > > Signed-off-by: Chris Morgan Reviewed-by: Heiko Stuebner > --- > .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml | 1 + > 1 file

Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes

2022-09-09 Thread Maxime Ripard
Hi, On Wed, Sep 07, 2022 at 11:31:21PM +0200, Mateusz Kwiatkowski wrote: > W dniu 7.09.2022 o 16:34, Maxime Ripard pisze: > > On Mon, Sep 05, 2022 at 06:44:42PM +0200, Mateusz Kwiatkowski wrote: > >> Hi Maxime, > >> > >> W dniu 5.09.2022 o 15:37, Maxime Ripard pisze: > > +    vfp = vfp_min + (

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-09 Thread Pekka Paalanen
On Fri, 09 Sep 2022 13:39:37 + Simon Ser wrote: > On Friday, September 9th, 2022 at 12:12, Hans de Goede > wrote: > > > Phase 3: Deprecate /sys/class/backlight uAPI > > > > > > Once most userspace has moved over to using the new drm_connector >

Re: [RFC v2] drm/kms: control display brightness through drm_connector properties

2022-09-09 Thread Simon Ser
On Friday, September 9th, 2022 at 12:12, Hans de Goede wrote: > Phase 3: Deprecate /sys/class/backlight uAPI > > > Once most userspace has moved over to using the new drm_connector > brightness props, a Kconfig option can be added to stop exporting >

Re: [PATCH] drm/rockchip: vop2: Fix eDP/HDMI sync polarities

2022-09-09 Thread Heiko Stuebner
On Mon, 15 Aug 2022 15:39:42 +0200, Sascha Hauer wrote: > The hsync/vsync polarities were not honoured for the eDP and HDMI ports. > Add the register settings to configure the polarities as requested by the > DRM_MODE_FLAG_PHSYNC/DRM_MODE_FLAG_PVSYNC flags. Applied, thanks! [1/1] drm/rockchip: vo

Re: [PATCH] drm/vkms: fix 32bit compilation error by replacing macros

2022-09-09 Thread Alex Deucher
On Fri, Sep 9, 2022 at 7:42 AM Melissa Wen wrote: > > Replace vkms_formats macros for fixed-point operations with functions > from drm/drm_fixed.h to do the same job and fix 32-bit compilation > errors. > > Fixes: a19c2ac9858 ("drm: vkms: Add support to the RGB565 format") > Tested-by: Sudip Mukhe

Re: [PATCH v2] drm: omapdrm: Improve check for contiguous buffers

2022-09-09 Thread Tomi Valkeinen
On 25/08/2022 19:26, Andrew Davis wrote: While a scatter-gather table having only 1 entry does imply it is contiguous, it is a logic error to assume the inverse. Tables can have more than 1 entry and still be contiguous. Use a proper check here. Signed-off-by: Andrew Davis --- Changes from v1:

Re: [PATCH] drm/tidss: fix repeated words in comments

2022-09-09 Thread Tomi Valkeinen
On 24/08/2022 16:04, Jilin Yuan wrote: Delete the redundant word 'to'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/tidss/tidss_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tidss/tidss_kms.c b/drivers/gpu/drm/tidss/tidss_kms.c index 666e527a0a

Re: [PATCH] drm/omap: dss: Fix refcount leak bugs

2022-09-09 Thread Tomi Valkeinen
On 22/07/2022 17:43, Liang He wrote: In dss_init_ports() and __dss_uninit_ports(), we should call of_node_put() for the reference returned by of_graph_get_port_by_id() in fail path or when it is not used anymore. Fixes: 09bffa6e5192 ("drm: omap: use common OF graph helpers") Signed-off-by: Liang

Re: [PATCH] drm: omapdrm: dss: replace ternary operator with max()

2022-09-09 Thread Tomi Valkeinen
On 17/05/2022 08:02, Guo Zhengkui wrote: Fix the following coccicheck warning: drivers/gpu/drm/omapdrm/dss/dispc.c:2454:21-22: WARNING opportunity for max() Signed-off-by: Guo Zhengkui --- drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: Meeting (BOF) at Plumbers Dublin to discuss backlight brightness as connector object property RFC?

2022-09-09 Thread Ville Syrjälä
On Fri, Sep 09, 2022 at 12:23:53PM +0200, Hans de Goede wrote: > Hi All, > > I will be at Plumbers Dublin next week and I was wondering if > anyone interested in this wants to get together for a quick > discussion / birds of a feather session about this? > > I have just posted version 2 of the RF

[PATCH 4/6] drm/gma500: Remove a couple of not useful function wrappers

2022-09-09 Thread Hans de Goede
The gma_crtc_set_config() and psb_unlocked_ioctl() functions are 1:1 wrappers for drm_helpers. Drop these wrappers. Signed-off-by: Hans de Goede --- drivers/gpu/drm/gma500/gma_display.c | 8 +--- drivers/gpu/drm/gma500/gma_display.h | 2 -- drivers/gpu/drm/gma500/psb_drv.c | 8 +---

[PATCH 5/6] drm/gma500: Rewrite power management code

2022-09-09 Thread Hans de Goede
Rewrite the power.c code. For some reason this was doing locking + refcounting + state (suspended or not) bookkeeping all by itself. But there is no reason for this, this is all taken care of by the runtime-pm core, through pm_runtime_get()/_put(). Besides this not being necessary the DIY code is

[PATCH 6/6] drm/gma500: Remove unnecessary suspend/resume wrappers

2022-09-09 Thread Hans de Goede
The psb_runtime_suspend/resume/thaw/freeze/restore functions are all just 1:1 wrappers around gma_power_suspend/_resume. Drop these wrappers and use the DEFINE_RUNTIME_DEV_PM_OPS() macro to define the dev_pm_ops struct. Signed-off-by: Hans de Goede --- drivers/gpu/drm/gma500/power.c | 25

[PATCH 2/6] drm/gma500: Remove runtime_allowed dead code in psb_unlocked_ioctl()

2022-09-09 Thread Hans de Goede
runtime_allowed is initialized to 0, so the runtime_allowed == 1 condition is never true making this dead code. Remove it. Signed-off-by: Hans de Goede --- drivers/gpu/drm/gma500/psb_drv.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/

[PATCH 0/6] drm/gma500: 1 fix + further cleanups

2022-09-09 Thread Hans de Goede
Hi Patrik, Here is another gma500 patch-series with one more bugfix and a bunch of other cleanups of stuff which I noticed while doing the previous set of bugfixes. Regards, Hans Hans de Goede (6): drm/gma500: Wait longer for the GPU to power-down drm/gma500: Remove runtime_allowed dead co

[PATCH 3/6] drm/gma500: Remove never set dev_priv->rpm_enabled flag

2022-09-09 Thread Hans de Goede
The rpm_enabled flag is never set, remove it. Signed-off-by: Hans de Goede --- drivers/gpu/drm/gma500/gma_display.c | 13 + drivers/gpu/drm/gma500/psb_drv.h | 3 --- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gp

  1   2   >