Re: [PATCH] drm/udl: Enable damage clipping

2022-09-06 Thread Thomas Zimmermann
Hi Am 06.09.22 um 21:35 schrieb Daniel Vetter: On Thu, Jul 28, 2022 at 09:47:56AM +0200, Thomas Zimmermann wrote: Call drm_plane_enable_fb_damage_clips() and give userspace a chance of minimizing the updated display area. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_modeset.

Re: [PATCH v2 02/11] drm/udl: Add reset_resume

2022-09-06 Thread Daniel Vetter
On Tue, Sep 06, 2022 at 09:39:42AM +0200, Takashi Iwai wrote: > From: Thomas Zimmermann > > Implement the reset_resume callback of struct usb_driver. Set the > standard channel when called. > > Signed-off-by: Thomas Zimmermann > Signed-off-by: Takashi Iwai > --- > drivers/gpu/drm/udl/udl_drv.

Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem

2022-09-06 Thread Thomas Zimmermann
Hi Am 06.09.22 um 23:52 schrieb Daniel Vetter: On Sat, Aug 06, 2022 at 07:32:24PM +0300, Markuss Broks wrote: Add early console support for generic linear framebuffer devices. This driver supports probing from cmdline early parameters or from the device-tree using information in simple-framebuf

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-09-06 Thread Christian König
Am 06.09.22 um 22:05 schrieb Daniel Vetter: On Tue, Sep 06, 2022 at 10:01:47PM +0200, Daniel Vetter wrote: On Mon, Aug 15, 2022 at 12:05:19PM +0200, Christian König wrote: Am 15.08.22 um 11:54 schrieb Dmitry Osipenko: Higher order pages allocated using alloc_pages() aren't refcounted and they

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-06 Thread Zheng Hacker
Hi Zhenyu, Very glad for your reply. I agree that the bug is hard to trigger in userspace. But it is possible to happen in some specific scene. For example, if calling pfn_valid failed, the bug will be triggered. And it did happened as the [1] commit description illustrates. As for the patch, I t

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-06 Thread Thomas Zimmermann
Hi Am 07.09.22 um 06:16 schrieb Wang Yugui: Hi, Am 02.09.22 um 07:52 schrieb Wang Yugui: Hi, mgag200 broken on kernel-6.0-rc3 on DELL/T620. See the attachementment file for the graph output. Thanks for reporting the bug. We recently refactored some code of the driver. Can you bisect to t

Re: [PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-09-06 Thread Christian König
Am 06.09.22 um 21:58 schrieb Daniel Vetter: On Tue, Aug 16, 2022 at 10:33:16AM +0530, Arunpravin Paneer Selvam wrote: On 8/15/2022 4:35 PM, Christian König wrote: Am 12.08.22 um 15:30 schrieb Arunpravin Paneer Selvam: We are adding two new callbacks to ttm resource manager function to handle

Re: [PATCH v6 28/57] drm_print: refine drm_debug_enabled for jump-label

2022-09-06 Thread Daniel Vetter
On Sun, Sep 04, 2022 at 03:41:05PM -0600, Jim Cromie wrote: > In order to use dynamic-debug's jump-label optimization in drm-debug, > its clarifying to refine drm_debug_enabled into 3 uses: > > 1. drm_debug_enabled - legacy, public > 2. __drm_debug_enabled - optimized for dyndbg jump-label enabl

Re: [PATCH v2 1/4] drm/sched: Enable signaling for finished fence

2022-09-06 Thread Christian König
Am 06.09.22 um 21:55 schrieb Andrey Grodzovsky: On 2022-09-06 02:34, Christian König wrote: Am 05.09.22 um 18:34 schrieb Arvind Yadav: Here's enabling software signaling for finished fence. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressing Christian's comment to remove CONFIG_DE

Re: [PATCH v6 23/57] drm: POC drm on dyndbg - use in core, 2 helpers, 3 drivers.

2022-09-06 Thread Daniel Vetter
On Sun, Sep 04, 2022 at 03:41:00PM -0600, Jim Cromie wrote: > Use DECLARE_DYNDBG_CLASSMAP across DRM: > > - in .c files, since macro defines/initializes a record > > - in drivers, $mod_{drv,drm,param}.c >ie where param setup is done, since a classmap is param related > > - in drm/drm_prin

Re: [PATCH v6 22/57] drm_print: condense enum drm_debug_category

2022-09-06 Thread Daniel Vetter
On Sun, Sep 04, 2022 at 03:40:59PM -0600, Jim Cromie wrote: > enum drm_debug_category has 10 categories, but is initialized with > bitmasks which require 10 bits of underlying storage. By using > natural enumeration, and moving the BIT(cat) into drm_debug_enabled(), > the enum fits in 4 bits, allo

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-06 Thread Daniel Vetter
On Wed, Sep 07, 2022 at 07:47:10AM +0200, Greg KH wrote: > On Tue, Sep 06, 2022 at 09:18:09PM +0200, Daniel Vetter wrote: > > On Fri, Aug 12, 2022 at 08:03:47AM +0200, Greg KH wrote: > > > On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > > > > On Wed, Aug 03, 2022 at 04:13:05PM -040

Re: mgag200 broken on kernel-6.0-rc3 on DELL/T620

2022-09-06 Thread Wang Yugui
Hi, > Am 02.09.22 um 07:52 schrieb Wang Yugui: > > Hi, > > > > mgag200 broken on kernel-6.0-rc3 on DELL/T620. > > > > See the attachementment file for the graph output. > > Thanks for reporting the bug. We recently refactored some code of the driver. > Can you bisect to the change that introduce

[PATCH] drm/ttm: Remove unnecessary '0' values from ret

2022-09-06 Thread Li zeming
The variable ret is assigned in the judgment branch statement, he does not need to initialize the assignment. Signed-off-by: Li zeming --- include/drm/ttm/ttm_bo_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_

Re: [PATCH 01/12] drm/udl: Restore display mode on resume

2022-09-06 Thread Takashi Iwai
On Tue, 06 Sep 2022 22:06:55 +0200, Daniel Vetter wrote: > > On Tue, Aug 16, 2022 at 05:36:44PM +0200, Takashi Iwai wrote: > > From: Thomas Zimmermann > > > > Restore the display mode whne resuming from suspend. Currently, the > > display remains dark. > > > > On resume, the CRTC's mode does no

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-06 Thread Daniel Vetter
te: > > > > > > > > Hi All, > > > > > > > > The builds of next-20220906 fails for mips, xtensa and arm allmodconfig. > > > > > > > > The errors in mips and xtensa are: > > > > > > > > ERROR: modpost: "

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-06 Thread Daniel Vetter
On Tue, Sep 06, 2022 at 08:35:49PM -0300, Igor Matheus Andrade Torrente wrote: > On 9/6/22 18:26, Sudip Mukherjee wrote: > > On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) > > wrote: > > > > > > Hi All, > > > > > > The bui

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-06 Thread Greg KH
On Tue, Sep 06, 2022 at 09:18:09PM +0200, Daniel Vetter wrote: > On Fri, Aug 12, 2022 at 08:03:47AM +0200, Greg KH wrote: > > On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > > > On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > > > > > > > > > > On 8/3/22 15:56,

Re: [PATCH 0/8] Support for NVDEC on Tegra234

2022-09-06 Thread Mikko Perttunen
On 9/6/22 20:50, Krzysztof Kozlowski wrote: On 06/09/2022 15:28, Mikko Perttunen wrote: From: Mikko Perttunen Hi all, this series adds support for the HW video decoder, NVDEC, on Tegra234 (Orin). The main change is a switch from Falcon to RISC-V for the internal microcontroller, which brings

[PATCH] drm/amd/display: fix repeated words in comments

2022-09-06 Thread Jilin Yuan
Delete the redundant word 'in'. Signed-off-by: Jilin Yuan --- drivers/gpu/drm/amd/display/dc/dce/dce_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c b/drivers/gpu/drm/amd/display/dc/dce/dce_audio.c index bdb6bac8dd97..c9

Re: [PATCH v2 08/15] drm/i915/gvt: Use the new device life cycle helpers

2022-09-06 Thread Zhenyu Wang
On 2022.09.01 22:37:40 +0800, Kevin Tian wrote: > Move vfio_device to the start of intel_vgpu as required by the new > helpers. > > Change intel_gvt_create_vgpu() to use intel_vgpu as the first param > as other vgpu helpers do. > > Signed-off-by: Kevin Tian > Reviewed-by: Jason Gunthorpe > ---

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-06 Thread Zhenyu Wang
On 2022.09.06 19:36:56 +0800, Zheng Hacker wrote: > Hi Greg, > > Alex has explained how we figured out the patch. We did analyze the > code and found it possible to reach the vulnerability code. But we > have no physical device in hand to test the driver. So we'd like to > discuss with developers

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-06 Thread Dmitry Torokhov
On Mon, Sep 05, 2022 at 03:09:05PM -0700, Guenter Roeck wrote: > On 9/5/22 12:47, Dmitry Torokhov wrote: > [ ... ] > > > We know that count is either 1 or 2 here, so strictly speaking > > > if (count == 1) { > > > } else { > > > } > > > would be sufficient. On the other side, that depends on

RE: [PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle

2022-09-06 Thread Tian, Kevin
> From: Christoph Hellwig > Sent: Tuesday, September 6, 2022 5:42 PM > > What is the point? This adds indirect calls, and actually creates > more boilerplate code in the drivers. i.g. when using this code there > is more, and harder to read code. The point is to align with struct device life cy

[linux-next:master] BUILD REGRESSION 840126e36e8ff272cb63158646433fa1324533d9

2022-09-06 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 840126e36e8ff272cb63158646433fa1324533d9 Add linux-next specific files for 20220906 Error/Warning reports: https://lore.kernel.org/linux-mm/202209021204.dclzollr-...@intel.com https

Re: [PATCH v3 04/14] drm/i915: Drop intel_gt_tile_cleanup()

2022-09-06 Thread Lucas De Marchi
On Tue, Sep 06, 2022 at 04:49:24PM -0700, Matt Roper wrote: Unmapping of the MMIO range can be done as a DRM-managed action, which will take care of the unmapping on device teardown and error paths. This will also ensure proper ordering with respect to other DRM-managed actions that we'll be usin

[PATCH v3 11/14] drm/i915/mtl: Add gsi_offset when emitting aux table invalidation

2022-09-06 Thread Matt Roper
The aux table invalidation registers are a bit unique --- they're engine-centric registers that reside in the GSI register space rather than within the engines' regular MMIO ranges. That means that when issuing invalidation on engines in the standalone media GT, the GSI offset must be added to the

[PATCH v3 12/14] drm/i915/xelpmp: Expose media as another GT

2022-09-06 Thread Matt Roper
Xe_LPM+ platforms have "standalone media." I.e., the media unit is designed as an additional GT with its own engine list, GuC, forcewake, etc. Let's allow platforms to include media GTs in their device info. v2: - Simplify GSI register handling and split it out to a separate patch for ease o

[PATCH v3 14/14] drm/i915/mtl: Hook up interrupts for standalone media

2022-09-06 Thread Matt Roper
Top-level handling of standalone media interrupts will be processed as part of the primary GT's interrupt handler (since primary and media GTs share an MMIO space, unlike remote tile setups). When we get down to the point of handling engine interrupts, we need to take care to lookup VCS and VECS e

[PATCH v3 05/14] drm/i915: Prepare more multi-GT initialization

2022-09-06 Thread Matt Roper
We're going to introduce an additional intel_gt for MTL's media unit soon. Let's provide a bit more multi-GT initialization framework in preparation for that. The initialization will pull the list of GTs for a platform from the device info structure. Although necessary for the immediate MTL medi

[PATCH v3 02/14] drm/i915: Only hook up uncore->debug for primary uncore

2022-09-06 Thread Matt Roper
The original intent of intel_uncore_mmio_debug as described in commit 0a9b26306d6a ("drm/i915: split out uncore_mmio_debug") was to be a singleton structure that could be shared between multiple GTs' uncore objects in a multi-tile system. Somehow we went off track and started allocating separate i

[PATCH v3 08/14] drm/i915: Initialize MMIO access for each GT

2022-09-06 Thread Matt Roper
In a multi-GT system we need to initialize MMIO access for each GT, not just the primary GT. Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_driver.c | 27 ++- drivers/gpu/drm/i915/intel_uncore.c | 5 - drivers/gpu/drm/i915/intel_

[PATCH v3 13/14] drm/i915/mtl: Use primary GT's irq lock for media GT

2022-09-06 Thread Matt Roper
When we hook up interrupts (in the next patch), interrupts for the media GT are still processed as part of the primary GT's interrupt flow. As such, we should share the same IRQ lock with the primary GT. Let's convert gt->irq_lock into a pointer and just point the media GT's instance at the same

[PATCH v3 06/14] drm/i915: Rename and expose common GT early init routine

2022-09-06 Thread Matt Roper
The common early GT init is needed for initialization of all GT types (root/primary, remote tile, standalone media). Since standalone media (coming in a future patch) will be implemented in a separate file, rename and expose the function for use. Signed-off-by: Matt Roper Reviewed-by: Radhakrish

[PATCH v3 09/14] drm/i915: Handle each GT on init/release and suspend/resume

2022-09-06 Thread Matt Roper
In preparation for enabling a second GT, there are a number of GT/uncore operations that happen during initialization or suspend flows that need to be performed on each GT, not just the primary, Cc: Daniele Ceraolo Spurio Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_driver.c | 59 +++

[PATCH v3 04/14] drm/i915: Drop intel_gt_tile_cleanup()

2022-09-06 Thread Matt Roper
Unmapping of the MMIO range can be done as a DRM-managed action, which will take care of the unmapping on device teardown and error paths. This will also ensure proper ordering with respect to other DRM-managed actions that we'll be using to clean up non-primary GTs in upcoming patches. We have no

[PATCH v3 10/14] drm/i915/uncore: Add GSI offset to uncore

2022-09-06 Thread Matt Roper
GT non-engine registers (referred to as "GSI" registers by the spec) have the same relative offsets on standalone media as they do on the primary GT, just with an additional "GSI offset" added to their MMIO address. If we store this GSI offset in the standalone media's intel_uncore structure, it c

[PATCH v3 03/14] drm/i915: Use managed allocations for extra uncore objects

2022-09-06 Thread Matt Roper
We're slowly transitioning the init-time kzalloc's of the driver over to DRM-managed allocations; let's make sure the uncore objects allocated for non-root GTs are thus allocated. Signed-off-by: Matt Roper Reviewed-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/gt/intel_gt.c | 6 ++ 1 fi

[PATCH v3 01/14] drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume}

2022-09-06 Thread Matt Roper
Moving the locking for MMIO debug (and the final check for unclaimed accesses when resuming debug after a userspace-initiated forcewake) will make it simpler to completely skip MMIO debug handling on uncores that don't support it in future patches. Signed-off-by: Matt Roper Reviewed-by: Radhakris

[PATCH v3 07/14] drm/i915: Use a DRM-managed action to release the PCI bridge device

2022-09-06 Thread Matt Roper
As we start supporting multiple uncore structures in future patches, the MMIO cleanup (which make also get called mid-init if there's a failure) will become more complicated. Moving to DRM-managed actions will help keep things simple. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_driv

[PATCH v3 00/14] i915: Add "standalone media" support for MTL

2022-09-06 Thread Matt Roper
Starting with MTL, media functionality has moved into a new, second GT at the hardware level. This new GT, referred to as "standalone media" in the spec, has its own GuC, power management/forcewake, etc. The general non-engine GT registers for standalone media start at 0x38, but otherwise use

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-06 Thread Igor Matheus Andrade Torrente
On 9/6/22 18:26, Sudip Mukherjee wrote: On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) wrote: Hi All, The builds of next-20220906 fails for mips, xtensa and arm allmodconfig. The errors in mips and xtensa are: ERROR: modpost: "__divdi3" [drivers/gpu/drm/vkms/vkms.ko]

Re: [PATCH 2/2] drm: get lock before accessing vblank refcount

2022-09-06 Thread Daniel Vetter
On Tue, Sep 06, 2022 at 08:18:30PM +, Li, Yunxiang (Teddy) wrote: > [Public] > > Hi Daniel, > > I added the check because I saw that the refcount was always > updated/read with lock held elsewhere, and the pattern looked very > similar to in the put e.g. drm_crtc_vblank_reset. This patchset i

Re: [PATCH v2 3/3] efi: earlycon: Add support for generic framebuffers and move to console subsystem

2022-09-06 Thread Daniel Vetter
On Sat, Aug 06, 2022 at 07:32:24PM +0300, Markuss Broks wrote: > Add early console support for generic linear framebuffer devices. > This driver supports probing from cmdline early parameters > or from the device-tree using information in simple-framebuffer node. > The EFI functionality should be r

Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 panel bindings

2022-09-06 Thread Rob Herring
On Tue, 06 Sep 2022 13:36:41 -0500, Chris Morgan wrote: > From: Chris Morgan > > Add documentation for the Samsung AMS495QA01 panel. > > Signed-off-by: Chris Morgan > --- > .../display/panel/samsung,ams495qa01.yaml | 49 +++ > 1 file changed, 49 insertions(+) > create mode

Re: [PATCH v2 0/5] rockchip-dsi for rk3568

2022-09-06 Thread Chris Morgan
On Tue, Sep 06, 2022 at 07:57:28PM +0200, Maya Matuszczyk wrote: > Hello, > What other patches would I need to apply to test this series > on Anbernic RG503? In addition to these patches you'd need the devicetree series: https://lore.kernel.org/linux-rockchip/20220906210324.28986-1-macroalph...@gm

Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format")

2022-09-06 Thread Sudip Mukherjee
On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) wrote: > > Hi All, > > The builds of next-20220906 fails for mips, xtensa and arm allmodconfig. > > The errors in mips and xtensa are: > > ERROR: modpost: "__divdi3" [drivers/gpu/drm/vkms/vkms.ko] undef

Re: [PATCH v4 1/3] drm: Use XArray instead of IDR for minors

2022-09-06 Thread Matthew Wilcox
On Tue, Sep 06, 2022 at 10:16:27PM +0200, Michał Winiarski wrote: > IDR is deprecated, and since XArray manages its own state with internal > locking, it simplifies the locking on DRM side. > Additionally, don't use the IRQ-safe variant, since operating on drm > minor is not done in IRQ context. >

Re: [PATCH v2] drm/scheduler: quieten kernel-doc warnings

2022-09-06 Thread Andrey Grodzovsky
Pushed to drm-misc-next Andrey On 2022-09-06 13:57, Alex Deucher wrote: On Tue, Sep 6, 2022 at 1:38 PM Andrey Grodzovsky wrote: I RBed, see bellow. Can you push the patch to drm-misc? Alex Andrey On 2022-08-31 14:34, Randy Dunlap wrote: ping? On 4/4/22 14:58, Andrey Grodzovsky wrote:

[PATCH v2 1/3] drm/gma500: Fix BUG: sleeping function called from invalid context errors

2022-09-06 Thread Hans de Goede
gma_crtc_page_flip() was holding the event_lock spinlock while calling crtc_funcs->mode_set_base() which takes ww_mutex. The only reason to hold event_lock is to clear gma_crtc->page_flip_event on mode_set_base() errors. Instead unlock it after setting gma_crtc->page_flip_event and on errors re-t

[PATCH v2 0/3] drm/gma500: Fix 2 locking related WARNs + IRQ handling

2022-09-06 Thread Hans de Goede
Hi All, I have been testing the gma500 code on a Packard Bell Dot SC (Intel Atom N2600, cedarview) laptop because I'm working on aligning the gma500 backlight code with the changes done to other drivers in the recent backlight refactoring. During the testing I noticed dmesg filling with a WARN_ON

[PATCH v2 2/3] drm/gma500: Fix WARN_ON(lock->magic != lock) error

2022-09-06 Thread Hans de Goede
psb_gem_unpin() calls dma_resv_lock() but the underlying ww_mutex gets destroyed by drm_gem_object_release() move the drm_gem_object_release() call in psb_gem_free_object() to after the unpin to fix the below warning: [ 79.693962] [ cut here ] [ 79.693992] DEBUG_LOCKS_W

[PATCH v2 3/3] drm/gma500: Fix (vblank) IRQs not working after suspend/resume

2022-09-06 Thread Hans de Goede
Fix gnome-shell (and other page-flip users) hanging after suspend/resume because of the gma500's IRQs not working. This fixes 2 problems with the IRQ handling: 1. gma_power_off() calls gma_irq_uninstall() which does a free_irq(), but gma_power_on() called gma_irq_preinstall() + gma_irq_postins

Re: [Intel-gfx] [PATCH v3 3/3] drm/i915/uc: Enable version reduced firmware files for newest platforms

2022-09-06 Thread Ceraolo Spurio, Daniele
On 8/26/2022 6:17 PM, john.c.harri...@intel.com wrote: From: John Harrison Going forwards, the intention is for GuC firmware files to be named for their major version only and HuC firmware files to have no version number in the name at all. This patch adds those entries for DG1/2 and ADL-P/S

Re: [Intel-gfx] [PATCH v3 2/3] drm/i915/uc: Add patch level version number support

2022-09-06 Thread Ceraolo Spurio, Daniele
On 8/26/2022 6:17 PM, john.c.harri...@intel.com wrote: From: John Harrison With the move to un-versioned filenames, it becomes more difficult to know exactly what version of a given firmware is being used. So add the patch level version number to the debugfs output. Also, support matching b

RE: [PATCH 2/2] drm: get lock before accessing vblank refcount

2022-09-06 Thread Li, Yunxiang (Teddy)
[Public] Hi Daniel, I added the check because I saw that the refcount was always updated/read with lock held elsewhere, and the pattern looked very similar to in the put e.g. drm_crtc_vblank_reset. This patchset is outdated by now and I've sent a fix to amd-gfx for the specific issue in amdgpu

[PATCH v4 3/3] drm: Introduce skip_legacy_minors modparam

2022-09-06 Thread Michał Winiarski
While there is support for >64 DRM devices on kernel side, existing userspace may still have some hardcoded assumptions and it's possible that it will require changes to be able to use more than 64 devices. Add a modparam to simplify testing and development of >64 devices support on userspace side

[PATCH v4 1/3] drm: Use XArray instead of IDR for minors

2022-09-06 Thread Michał Winiarski
IDR is deprecated, and since XArray manages its own state with internal locking, it simplifies the locking on DRM side. Additionally, don't use the IRQ-safe variant, since operating on drm minor is not done in IRQ context. Signed-off-by: Michał Winiarski Suggested-by: Matthew Wilcox --- drivers

[PATCH v4 2/3] drm: Expand max DRM device number to full MINORBITS

2022-09-06 Thread Michał Winiarski
Having a limit of 64 DRM devices is not good enough for modern world where we have multi-GPU servers, SR-IOV virtual functions and virtual devices used for testing. Let's utilize full minor range for DRM devices. To avoid regressing the existing userspace, we're still maintaining the numbering sche

[PATCH v4 0/3] drm: Use full allocated minor range for DRM

2022-09-06 Thread Michał Winiarski
64 DRM device nodes is not enough for everyone. Upgrade it to ~512K (which definitely is more than enough). To allow testing userspace support for >64 devices, add additional DRM modparam (skip_legacy_minors) which causes DRM to skip allocating minors in 0-192 range. Additionally - convert minors

Re: [PATCH 01/12] drm/udl: Restore display mode on resume

2022-09-06 Thread Daniel Vetter
On Tue, Aug 16, 2022 at 05:36:44PM +0200, Takashi Iwai wrote: > From: Thomas Zimmermann > > Restore the display mode whne resuming from suspend. Currently, the > display remains dark. > > On resume, the CRTC's mode does not change, but the 'active' flag > changes to 'true'. Taking this into acco

Re: [PATCH v2 37/41] drm/sun4i: tv: Remove useless function

2022-09-06 Thread Jernej Škrabec
Dne ponedeljek, 29. avgust 2022 ob 15:11:51 CEST je Maxime Ripard napisal(a): > The drm_connector_to_sun4i_tv() function isn't used anywhere in the driver, > so let's remove it. > > Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec Best regards, Jernej

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-09-06 Thread Daniel Vetter
On Tue, Sep 06, 2022 at 10:01:47PM +0200, Daniel Vetter wrote: > On Mon, Aug 15, 2022 at 12:05:19PM +0200, Christian König wrote: > > Am 15.08.22 um 11:54 schrieb Dmitry Osipenko: > > > Higher order pages allocated using alloc_pages() aren't refcounted and > > > they > > > need to be refcounted, o

Re: [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable

2022-09-06 Thread Jernej Škrabec
Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard napisal(a): > Our mode_set implementation can be merged into our atomic_enable > implementation to simplify things, so let's do this. Are you sure this is a good thing in long term? What if user wants to change mode? Unlikely, but

Re: [PATCH v2 35/41] drm/sun4i: tv: Convert to atomic hooks

2022-09-06 Thread Jernej Škrabec
Dne ponedeljek, 29. avgust 2022 ob 15:11:49 CEST je Maxime Ripard napisal(a): > The sun4i TV driver still uses legacy enable and disable hook > implementation. Let's convert to the atomic variants. > > Signed-off-by: Maxime Ripard Acked-by: Jernej Skrabec BTW, I suggest you merge fixes/cleanup

Re: [PATCH v1] drm/ttm: Refcount allocated tail pages

2022-09-06 Thread Daniel Vetter
On Mon, Aug 15, 2022 at 12:05:19PM +0200, Christian König wrote: > Am 15.08.22 um 11:54 schrieb Dmitry Osipenko: > > Higher order pages allocated using alloc_pages() aren't refcounted and they > > need to be refcounted, otherwise it's impossible to map them by KVM. This > > patch sets the refcount

Re: [PATCH v2 0/1] tee: Add tee_shm_register_fd

2022-09-06 Thread Daniel Vetter
On Fri, Aug 19, 2022 at 01:54:31PM +0530, Sumit Garg wrote: > Hi Olivier, > > On Fri, 12 Aug 2022 at 20:01, Olivier Masse wrote: > > > > Add a new ioctl called TEE_IOC_SHM_REGISTER_FD to register a > > shared memory from a dmabuf file descriptor. > > This new ioctl will allow the Linux Kernel to

[PATCH] drm/amdgpu: use dirty framebuffer helper

2022-09-06 Thread Hamza Mahfooz
Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs struct. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/am

Re: [PATCH v6 1/6] drm/ttm: Add new callbacks to ttm res mgr

2022-09-06 Thread Daniel Vetter
On Tue, Aug 16, 2022 at 10:33:16AM +0530, Arunpravin Paneer Selvam wrote: > > > On 8/15/2022 4:35 PM, Christian König wrote: > > Am 12.08.22 um 15:30 schrieb Arunpravin Paneer Selvam: > > > We are adding two new callbacks to ttm resource manager > > > function to handle intersection and compatibi

Re: [PATCH v2 1/4] drm/sched: Enable signaling for finished fence

2022-09-06 Thread Andrey Grodzovsky
On 2022-09-06 02:34, Christian König wrote: Am 05.09.22 um 18:34 schrieb Arvind Yadav: Here's enabling software signaling for finished fence. Signed-off-by: Arvind Yadav --- Changes in v1 : 1- Addressing Christian's comment to remove CONFIG_DEBUG_FS check from this patch. 2- The version of

Re: [ldv-project] [PATCH v2] drm/fb-helper: add virtual screen size check to drm_fb_helper_check_var()

2022-09-06 Thread Daniel Vetter
On Thu, Aug 11, 2022 at 11:59:00PM +0300, Alexey Khoroshilov wrote: > For v2 I would suggest to update description to something like this: > > Make sure that virtual screen size is not less than physical screen one. > > and comment to: > /* make sure that virtual resolution >= physical resolu

Re: [Intel-gfx] [PATCH v2 30/39] docs: gpu: i915.rst: gt: add more kernel-doc markups

2022-09-06 Thread Mauro Carvalho Chehab
On Tue, 9 Aug 2022 06:01:53 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:18AM +0100, Mauro Carvalho Chehab wrote: > > There are several documented GT kAPI that aren't currently part > > of the docs. Add them, as this allows identifying issues with > > badly-formatted tags. > > > > S

Re: [Intel-gfx] [PATCH v2 35/39] docs: gpu: i915.rst: add the remaining kernel-doc markup files

2022-09-06 Thread Mauro Carvalho Chehab
On Tue, 9 Aug 2022 06:20:57 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:23AM +0100, Mauro Carvalho Chehab wrote: > > There are other files with kernel-doc markups: > > > > $ git grep -l "/\*\*" $(git ls-files|grep drivers/gpu/drm/i915/) > > >kernel-doc-files > > $ for i in

Re: [Intel-gfx] [PATCH v2 18/39] drm/i915: intel_pm.c: fix some ascii artwork at kernel-doc

2022-09-06 Thread Mauro Carvalho Chehab
On Tue, 9 Aug 2022 05:55:10 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:06AM +0100, Mauro Carvalho Chehab wrote: > > Preserving ascii artwork on kernel-docs is tricky, as it needs > > to respect both the Sphinx rules and be properly parsed by > > kernel-doc script. > > > > The Sphi

Re: [Intel-gfx] [PATCH v2 16/39] drm/i915: intel_fb: fix a kernel-doc issue with Sphinx

2022-09-06 Thread Mauro Carvalho Chehab
On Fri, 15 Jul 2022 17:40:25 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:04AM +0100, Mauro Carvalho Chehab wrote: > > We can't use %foo[] as this produces a bad markup. > > Use instead, the emphasis markup directly. > > > > Fix this issue: > > Documentation/gpu/i915:136: > > .

Re: [Intel-gfx] [PATCH v2 15/39] drm/i915: intel_dp_link_training.c: fix kernel-doc markup

2022-09-06 Thread Mauro Carvalho Chehab
On Tue, 9 Aug 2022 05:51:39 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:03AM +0100, Mauro Carvalho Chehab wrote: > > The return code table is not properly marked, causing warnings > > and being badly parsed by Sphinx: > > > > Documentation/gpu/i915:130: > > ./drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH v2 38/39] drm/i915: add descriptions for some RPM macros at intel_gt_pm.h

2022-09-06 Thread Mauro Carvalho Chehab
On Tue, 9 Aug 2022 06:12:06 -0400 Rodrigo Vivi wrote: > On Wed, Jul 13, 2022 at 09:12:26AM +0100, Mauro Carvalho Chehab wrote: > > The intel_gt_pm.h file contains some convenient macros to be used > > in GT code in order to get/put runtime PM references and for > > checking them. > > > > Add des

Re: [Linaro-mm-sig] [PATCH v2 1/3] dma-buf: Add ioctl to query mmap info

2022-09-06 Thread Daniel Vetter
On Mon, Aug 01, 2022 at 10:04:55AM -0700, Rob Clark wrote: > From: Rob Clark > > This is a fairly narrowly focused interface, providing a way for a VMM > in userspace to tell the guest kernel what pgprot settings to use when > mapping a buffer to guest userspace. > > For buffers that get mapped

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-06 Thread Oded Gabbay
On Tue, Sep 6, 2022 at 8:59 PM Jason Gunthorpe wrote: > > On Tue, Sep 06, 2022 at 03:34:02PM +0300, Oded Gabbay wrote: > > > > > > > + /* > > > > > > + * Since the memory being mapped is a device memory it could > > > > > > never be in > > > > > > + * CPU caches. > > > > > > + */ > > > > > DMA

Re: [PATCH 2/2] efi: earlycon: Add support for generic framebuffers and move to fbdev subsystem

2022-09-06 Thread Daniel Vetter
On Sun, Aug 07, 2022 at 08:53:14AM +0200, Greg Kroah-Hartman wrote: > On Sat, Aug 06, 2022 at 07:26:07PM +0300, Markuss Broks wrote: > > Hi Greg, > > > > On 7/28/22 18:01, Greg Kroah-Hartman wrote: > > > On Thu, Jul 28, 2022 at 05:52:04PM +0300, Markuss Broks wrote: > > > > Hi Greg, > > > > > > >

Re: [PATCH] drm/udl: Enable damage clipping

2022-09-06 Thread Daniel Vetter
On Thu, Jul 28, 2022 at 09:47:56AM +0200, Thomas Zimmermann wrote: > Call drm_plane_enable_fb_damage_clips() and give userspace a chance > of minimizing the updated display area. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/udl/udl_modeset.c | 1 + > 1 file changed, 1 insertion(+

Re: [PATCH] drm/udl: Restore display mode on resume

2022-09-06 Thread Daniel Vetter
On Thu, Jul 28, 2022 at 09:31:09AM +0200, Thomas Zimmermann wrote: > Restore the display mode whne resuming from suspend. Currently, the > display remains dark. > > On resume, the CRTC's mode does not change, but the 'active' flag > changes to 'true'. Taking this into account when considering a mo

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915/uncore: Add GSI offset to uncore

2022-09-06 Thread Matt Roper
On Tue, Sep 06, 2022 at 04:14:21PM +0530, Iddamsetty, Aravind wrote: > > > On 03-09-2022 05:02, Matt Roper wrote: > > GT non-engine registers (referred to as "GSI" registers by the spec) > > have the same relative offsets on standalone media as they do on the > > primary GT, just with an addition

Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table

2022-09-06 Thread Clément Péron
Hi Jernej, On Tue, 6 Sept 2022 at 21:10, Jernej Škrabec wrote: > > Dne torek, 06. september 2022 ob 17:30:32 CEST je Clément Péron napisal(a): > > Add an Operating Performance Points table for the GPU to > > enable Dynamic Voltage & Frequency Scaling on the H6. > > > > The voltage range is set wi

Re: [PATCH] drm/via: Add new condition to via_dma_cleanup()

2022-09-06 Thread Daniel Vetter
On Fri, Jul 29, 2022 at 12:06:43PM +0300, Alisa Khabibrakhmanova wrote: > Pointer dev_priv->mmio, which was checked for NULL at via_do_init_map(), > is passed to via_do_cleanup_map() and is dereferenced there without check. > > The patch adds the condition in via_dma_cleanup() which prevents poten

Re: [PATCH] drm: Prevent modeset helpers to access an uninitialized drm_mode_config

2022-09-06 Thread Daniel Vetter
On Mon, Jul 25, 2022 at 10:28:21AM +0200, Javier Martinez Canillas wrote: > Hello Thomas, > > On 7/25/22 09:12, Thomas Zimmermann wrote: > > [...] > > > Let make the DRM core more robust and prevent this to happen, by marking > a > struct drm_mode_config as initialized durin

Re: [PATCH 2/2] drm: get lock before accessing vblank refcount

2022-09-06 Thread Daniel Vetter
On Fri, Jul 22, 2022 at 05:52:34PM -0400, Yunxiang Li wrote: > Acquire vbl_lock before accessing vblank refcount in drm_vblank_put, > just like everywhere else that access the refcount. > > Signed-off-by: Yunxiang Li The entire point of using atomic for the refcount is that we can check it lockl

Re: [PATCH v4 00/41] DYNDBG: opt-in class'd debug for modules, use in drm.

2022-09-06 Thread Daniel Vetter
On Fri, Aug 12, 2022 at 08:03:47AM +0200, Greg KH wrote: > On Thu, Aug 11, 2022 at 06:52:40PM +0200, Daniel Vetter wrote: > > On Wed, Aug 03, 2022 at 04:13:05PM -0400, Jason Baron wrote: > > > > > > > > > On 8/3/22 15:56, jim.cro...@gmail.com wrote: > > > > On Wed, Jul 20, 2022 at 9:32 AM Jim Cro

Re: [PATCH v2 04/10] drm/simpledrm: Compute framebuffer stride if not set

2022-09-06 Thread Daniel Vetter
On Thu, Aug 11, 2022 at 08:27:42PM +0200, Thomas Zimmermann wrote: > > > Am 11.08.22 um 20:26 schrieb Thomas Zimmermann: > > Hi Daniel > > > > Am 11.08.22 um 19:23 schrieb Daniel Vetter: > > > On Wed, 27 Jul 2022 at 09:53, Thomas Zimmermann > > > wrote: > > > > > > > > Hi > > > > > > > > Am 2

Re: [PATCH 5/7] drm/plane-helper: Export individual helpers

2022-09-06 Thread Daniel Vetter
On Thu, Aug 11, 2022 at 08:32:19PM +0200, Thomas Zimmermann wrote: > Hi > > Am 11.08.22 um 18:41 schrieb Daniel Vetter: > > On Wed, Jul 20, 2022 at 10:30:56AM +0200, Thomas Zimmermann wrote: > > > Export the individual plane helpers that make up the plane functions and > > > align the naming with

Re: [PATCH v4 3/5] arm64: dts: allwinner: h6: Add GPU OPP table

2022-09-06 Thread Jernej Škrabec
Dne torek, 06. september 2022 ob 17:30:32 CEST je Clément Péron napisal(a): > Add an Operating Performance Points table for the GPU to > enable Dynamic Voltage & Frequency Scaling on the H6. > > The voltage range is set with minimal voltage set to the target > and the maximal voltage set to 1.2V.

Re: [PATCH v4 02/12] drm: bridge: Add Samsung DSIM bridge driver

2022-09-06 Thread Jagan Teki
On Mon, Sep 5, 2022 at 4:54 PM Marek Szyprowski wrote: > > Hi All, > > On 02.09.2022 12:47, Marek Szyprowski wrote: > > On 29.08.2022 20:40, Jagan Teki wrote: > >> Samsung MIPI DSIM controller is common DSI IP that can be used in > >> various > >> SoCs like Exynos, i.MX8M Mini/Nano. > >> > >> In o

[PATCH 1/2] dt-bindings: display: panel: Add NewVision NV3051D panel bindings

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add documentation for the NewVision NV3051D panel bindings. Note that for the two expected consumers of this panel binding the underlying LCD model is unknown. Signed-off-by: Chris Morgan --- .../display/panel/newvision,nv3051d.yaml | 48 +++ 1 file chan

[PATCH 2/2] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel

2022-09-06 Thread Chris Morgan
From: Chris Morgan Support NewVision NV3051D panels as found on the Anbernic RG353P and RG353V. The underlying panel part number for the RG353x devices is unknown, so the device name is used instead. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/Kconfig | 9 + drivers

[PATCH 0/2] drm/panel: Add NewVision NV3051D Panels

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add the NewVision NV3051D panel as found on the Anbernic RG353P and RG353V. The underlying LCD panel itself is unknown (the NV3051D is the controller), so the device name is used for the panel. Chris Morgan (2): dt-bindings: display: panel: Add NewVision NV3051D panel bindi

Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_amdkfd_gpuvm.c

2022-09-06 Thread Deucher, Alexander
[Public] Yeah, seems to be a mix. I don't have a strong opinion as long as it has MIT. Alex From: Kuehling, Felix Sent: Tuesday, September 6, 2022 9:46 AM To: Jingyu Wang ; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; airl...@linux.ie ; dan...@ffwl

[PATCH 2/2] drm/panel: Add Samsung AMS495QA01 MIPI-DSI LCD panel

2022-09-06 Thread Chris Morgan
From: Chris Morgan Support Samsung AMS495QA01 panel as found on the Anbernic RG503. Note This panel receives video signals via DSI, however it receives commands via 3-wire SPI. Signed-off-by: Chris Morgan --- drivers/gpu/drm/panel/Kconfig | 10 + drivers/gpu/drm/panel/Makefile

[PATCH 0/2] drm/panel: Add Samsung AMS495QA01 Panel

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add the Samsung AMS495QA01 panel as found on the Anbernic RG503. This panel uses DSI to receive video signals, but 3-wire SPI to receive command signals. Chris Morgan (2): dt-bindings: display: panel: Add Samsung AMS495QA01 panel bindings drm/panel: Add Samsung AMS495QA01

[PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS495QA01 panel bindings

2022-09-06 Thread Chris Morgan
From: Chris Morgan Add documentation for the Samsung AMS495QA01 panel. Signed-off-by: Chris Morgan --- .../display/panel/samsung,ams495qa01.yaml | 49 +++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,ams495qa0

Re: [PATCH v2 4/4] vfio/pci: Allow MMIO regions to be exported through dma-buf

2022-09-06 Thread Jason Gunthorpe
On Tue, Sep 06, 2022 at 03:34:02PM +0300, Oded Gabbay wrote: > > > > > + /* > > > > > + * Since the memory being mapped is a device memory it could never > > > > > be in > > > > > + * CPU caches. > > > > > + */ > > > > DMA_ATTR_SKIP_CPU_SYNC doesn't even apply to dma_map_resource, not sure > >

  1   2   3   >