Hi Sam,
Thanks for your suggestions.
Sam Ravnborg 于 2022年7月10日周日 上午4:47写道：
> Hi Molly,
>
> thanks for the quick response to the review comments.
>
> On Sat, Jul 09, 2022 at 10:11:35PM +0800, MollySophia wrote:
> > Add documentation for "novatek,nt35596s" panel.
> >
> > Signed-off-by: MollySophi
On Fri, Jul 08, 2022 at 03:20:01PM +, Hellstrom, Thomas wrote:
On Fri, 2022-07-08 at 07:51 -0700, Niranjana Vishwanathapura wrote:
> Since we don't loop over the vm_bound_list, there is a need to
> check
> whether the rebind_list is empty here under the notifier_lock in
> read
> mode, and in
Hi Molly,
thanks for the quick response to the review comments.
On Sat, Jul 09, 2022 at 10:11:35PM +0800, MollySophia wrote:
> Add documentation for "novatek,nt35596s" panel.
>
> Signed-off-by: MollySophia
The s-o-b needs your real name - guess the above is a concatenation of
first name and sur
On Fri, Jul 08, 2022 at 06:03:28AM -0700, Hellstrom, Thomas wrote:
On Fri, 2022-07-08 at 05:44 -0700, Niranjana Vishwanathapura wrote:
On Thu, Jul 07, 2022 at 07:54:16AM -0700, Hellstrom, Thomas wrote:
> On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote:
> > Handle persistent (V
On Fri, Jul 08, 2022 at 07:37:30AM -0700, Hellstrom, Thomas wrote:
Hi,
On Fri, 2022-07-08 at 06:47 -0700, Niranjana Vishwanathapura wrote:
On Thu, Jul 07, 2022 at 07:41:54AM -0700, Hellstrom, Thomas wrote:
> On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote:
> > Add new execbuf
On Fri, Jul 08, 2022 at 07:32:54PM +0200, Christian König wrote:
Am 08.07.22 um 15:23 schrieb Niranjana Vishwanathapura:
On Thu, Jul 07, 2022 at 03:27:43PM +0200, Christian König wrote:
Am 02.07.22 um 00:50 schrieb Niranjana Vishwanathapura:
Add uapi allowing user to specify a BO as private to
On Fri, Jul 08, 2022 at 07:44:54AM -0700, Hellstrom, Thomas wrote:
On Fri, 2022-07-08 at 15:43 +0200, Thomas Hellström wrote:
> The vm_bind/bound_list and the non_priv_vm_bind_list are there for
> very different reasons.
>
> The reason for having separate vm_bind_list and vm_bound_list is
> that
Update debug print to report bridge timings over connector ones.
Drop missed comment commit from mxsfb.
Acked-by: Sam Ravnborg
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Marek Vas
Drop unneeded headers, sort rest alphabetically, no functional change.
Acked-by: Sam Ravnborg
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Marek Vasut
Cc: Alexander Stein
Cc: Laur
The function "drm_of_find_panel_or_bridge" has been deprecated in
favor of "devm_drm_of_get_bridge".
Switch to the new function and reduce boilerplate.
Acked-by: Sam Ravnborg
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for
Drop the crtc_ prefix from mode, consistently use the plain one.
Acked-by: Sam Ravnborg
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Marek Vasut
Cc: Alexander Stein
Cc: Laurent Pi
Hello Sam,
On Sat, Jul 09, 2022 at 10:50:55AM +0200, Sam Ravnborg wrote:
> On Fri, Jul 08, 2022 at 11:49:22AM +0200, Uwe Kleine-König wrote:
> > All implementations return 0 and the return value of mipi_dsi_drv_remove()
> > is ignored anyhow.
> >
> > So change the prototype of the remove function
Hi Marek,
On Sat, Jul 09, 2022 at 04:48:23PM +0200, Marek Vasut wrote:
> Drop unneeded headers, sort rest alphabetically, no functional change.
>
> Reviewed-by: Liu Ying
> Reported-by: Liu Ying
> Tested-by: Martyn Welch
> Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant
Novatek NT35596s is a generic DSI IC that drives command and video mode
panels. Add the driver for it. Currently add support for the LCD panel
from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones.
Signed-off-by: MollySophia
---
drivers/gpu/drm/panel/Kconfig | 9 +
Add documentation for "novatek,nt35596s" panel.
Signed-off-by: MollySophia
---
.../display/panel/novatek,nt35596s.yaml | 83 +++
1 file changed, 83 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/novatek,nt35596s.yaml
diff --git
a/Docume
Add documentation for "novatek,nt35596s" panel.
Signed-off-by: MollySophia
---
.../display/panel/novatek,nt35596s.yaml | 83 +++
1 file changed, 83 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/panel/novatek,nt35596s.yaml
diff --git
a/Docume
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: usleep_range is preferred over udelay
Signed-off-by: Christos Kollintzas
---
drivers/staging/fbtft/fb_upd161704.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/fbtft/fb_
Novatek NT35596s is a generic DSI IC that drives command and video mode
panels. Add the driver for it. Currently add support for the LCD panel
from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones.
Signed-off-by: MollySophia
---
drivers/gpu/drm/panel/Kconfig | 9 +
The function "drm_of_find_panel_or_bridge" has been deprecated in
favor of "devm_drm_of_get_bridge".
Switch to the new function and reduce boilerplate.
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Drop unneeded headers, sort rest alphabetically, no functional change.
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Marek Vasut
Cc: Alexander Stein
Cc: Laurent Pinchart
Cc: Liu Yi
Drop the crtc_ prefix from mode, consistently use the plain one.
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Marek Vasut
Cc: Alexander Stein
Cc: Laurent Pinchart
Cc: Liu Ying
Cc
Update debug print to report bridge timings over connector ones.
Drop missed comment commit from mxsfb.
Reviewed-by: Liu Ying
Reported-by: Liu Ying
Tested-by: Martyn Welch
Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF variant")
Signed-off-by: Marek Vasut
Cc: Alexander Stein
Hi, Dave & Daniel:
This includes:
1. Add Mediatek Soc DRM (vdosys0) support for mt8195
2. Cooperate with DSI RX devices to modify dsi funcs and delay mipi high to
cooperate with panel sequence
3. Add mt8186 dsi compatible and convert dsi_dtbinding to .yaml
4. Add MediaTek SoC DRM (vdosys1) suppo
On Sat, 2022-07-09 at 03:17 +0200, Marek Vasut wrote:
> Drop the crtc_ prefix from mode, consistently use the plain one.
>
> Reviewed-by: Liu Ying
> Reported-by: Liu Ying
> Fixes: 9db35bb349a0e ("drm: lcdif: Add support for i.MX8MP LCDIF
> variant")
> Signed-off-by: Marek Vasut
> Cc: Alexander
Hi Geert,
On Wed, Jul 06, 2022 at 03:16:18PM +0200, Geert Uytterhoeven wrote:
> Fix various spelling and grammar mistakes in the kerneldoc comments
> documenting the offsets member in the drm_framebuffer structure:
> - s/laytou/layout/,
> - Add missing "is",
> - s/it/its/.
>
> Signed-off-by
Hi Martin, the patch looks good.
On Mon, May 16, 2022 at 09:37:08PM +0200, Martin Jücker wrote:
> Add timings and panel description for the Samsung LTL101AL01 panel.
>
> Signed-off-by: Martin Jücker
Applied to drm-misc (drm-misc-next).
Sam
Hi Martin,
On Mon, May 16, 2022 at 09:37:07PM +0200, Martin Jücker wrote:
> Add the Samsung LTL101AL01 WXGA LCD panel to the list.
>
> Signed-off-by: Martin Jücker
Applied to drm-misc (drm-misc-next).
Sam
https://bugzilla.kernel.org/show_bug.cgi?id=195581
Mario Limonciello (AMD) (mario.limoncie...@amd.com) changed:
What|Removed |Added
Status|NEW |NEED
Hi Geert,
On Wed, Jul 06, 2022 at 03:20:18PM +0200, Geert Uytterhoeven wrote:
> Fix various grammar mistakes in the kerneldoc comments documenting the
> drm_mode_fb_cmd2 structure:
> - s/is/are/,
> - s/8 bit/8-bit/.
>
> Signed-off-by: Geert Uytterhoeven
> Acked-by: Sam Ravnborg
> Reviewed-b
Hi Geert,
On Fri, Jul 08, 2022 at 08:20:45PM +0200, Geert Uytterhoeven wrote:
> Hi all,
>
> A long outstanding issue with the DRM subsystem has been the lack of
> support for low-color displays, as used typically on older desktop
> systems, and on small embedded displays.
IT is super to ha
https://bugzilla.kernel.org/show_bug.cgi?id=216224
Artem S. Tashkinov (a...@gmx.com) changed:
What|Removed |Added
Status|NEW |RESOLVED
Reso
https://bugzilla.kernel.org/show_bug.cgi?id=216226
Artem S. Tashkinov (a...@gmx.com) changed:
What|Removed |Added
Status|NEW |RESOLVED
Reso
Extend the existing test cases to test the conversion from XRGB to
RGB565.
The documentation and the color picker available on [1] are useful
resources to understand this patch and validate the values returned by
the conversion function.
Tested-by: Tales L. Aparecida
Acked-by: Thomas Zimmerm
The tests fail on big endian architectures, like PowerPC:
$ ./tools/testing/kunit/kunit.py run \
--kunitconfig=drivers/gpu/drm/tests \
--arch=powerpc --cross_compile=powerpc64-linux-gnu-
Transform the XRGB buffer from little endian to the CPU endian
before calling the conversion functi
In order to support multiple destination format conversions, store the
destination pitch and the expected result in its own structure.
Tested-by: Tales L. Aparecida
Acked-by: Thomas Zimmermann
Signed-off-by: José Expósito
---
.../gpu/drm/tests/drm_format_helper_test.c| 53 -
The tests available at the moment only check the conversion from
XRGB to RGB332. However, more conversions will be tested in the
future.
In order to make the struct and functions present in the tests more
generic, rename xrgb_to_rgb332_* to convert_xrgb_*.
Tested-by: Tales L. Aparecid
Hello everyone,
This series is a follow up of the XRGB to RGB332 conversion KUnit
tests.
The first patch fixes a bug reported by David Gow in the XRGB to
RGB332 tests.
Note that the fix is required for this format because internally, the
drm_fb_xrgb_to_rgb332_line() function, calls le
https://bugzilla.kernel.org/show_bug.cgi?id=216226
--- Comment #1 from spassw...@web.de ---
Created attachment 301379
--> https://bugzilla.kernel.org/attachment.cgi?id=301379&action=edit
kernel config
Of course it's /dev/kfd in the message above.
--
You may reply to this email to add a commen
https://bugzilla.kernel.org/show_bug.cgi?id=216226
Bug ID: 216226
Summary: [amdgpu] BUG: kernel NULL pointer dereference
Product: Drivers
Version: 2.5
Kernel Version: 5.19.0-rc5-next-20220708
Hardware: All
OS: Linux
Hi Sam,
Le sam., juil. 9 2022 at 10:31:45 +0200, Sam Ravnborg
a écrit :
Hi Paul,
On Fri, Jul 08, 2022 at 09:54:00PM +0100, Paul Cercueil wrote:
Hi,
A small set of changes to the ingenic-drm driver.
The most notable thing is that ingenic-ipu is now its own platform
driver.
It would be
On Sat, Jul 09, 2022 at 01:06:56PM +0300, Christos Kollintzas wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: usleep_range is preferred over udelay
>
> Signed-off-by: Christos Kollintzas
> ---
> drivers/staging/fbtft/fb_upd161704.c | 18 +-
>
The kernel-doc markup is missing the slab pointer description:
include/linux/kfence.h:221: warning: Function parameter or member
'slab' not described in '__kfence_obj_info'
Document it.
Reviewed-by: Marco Elver
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large
The dev field was not documented:
include/drm/gpu_scheduler.h:463: warning: Function parameter or member
'dev' not described in 'drm_gpu_scheduler'
Document it.
Reviewed-by: Alex Deucher
Signed-off-by: Mauro Carvalho Chehab
---
To avoid mailbombing on a large number of people, only m
This series fix almost all fixable issues when building the html docs at
linux-next (next-20220608):
- Address some broken cross-references;
- Fix kernel-doc warnings;
- Fix bad tags on ReST files.
With this series applied, plus other pending patches that should hopefully
be merged in time for th
Add a description for struct device at drm_sched_init(), in order
to solve this warning:
drivers/gpu/drm/scheduler/sched_main.c:999: warning: Function parameter
or member 'dev' not described in 'drm_sched_init'
Reviewed-by: Alex Deucher
Signed-off-by: Mauro Carvalho Chehab
---
To avoi
Hi Molly,
Thanks for submitting this driver.
A few comments follows - the most relevant is the error handling when
unprepare/disable.
Please take a look and re-submit.
Sam
On Fri, Jul 08, 2022 at 10:18:23AM +0800, MollySophia wrote:
> Novatek NT35596s is a generic DSI IC that drives com
Hi Molly,
On Fri, Jul 08, 2022 at 10:18:24AM +0800, MollySophia wrote:
> Add documentation for "novatek,nt35596s" panel.
As a general note, we cannot apply a driver without the binding.
So this patch should be the first in the series.
Not a big deal, but it makes it easier on the committer later
Hi Uwe,
On Fri, Jul 08, 2022 at 11:49:21AM +0200, Uwe Kleine-König wrote:
> Returning an error code from a mipi_dsi remove callback fails, this is
> silently ignored. (mipi_dsi_drv_remove() propagates the return value to
> device_remove() which ignores it.) So emit an error code in the driver
> re
Hi Uwe,
On Fri, Jul 08, 2022 at 11:49:20AM +0200, Uwe Kleine-König wrote:
> panel_simple_remove() returns zero unconditionally. Make it return no value
> instead making more obvious what happens in the callers.
>
> This is a preparation for making platform and mipi-dsi remove callbacks
> return v
On Fri, Jul 08, 2022 at 11:49:22AM +0200, Uwe Kleine-König wrote:
> All implementations return 0 and the return value of mipi_dsi_drv_remove()
> is ignored anyhow.
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passin
Hi Marek,
On Sat, Jul 09, 2022 at 03:17:43AM +0200, Marek Vasut wrote:
> Drop unneeded headers, sort rest alphabetically, no functional change.
This and the following 3 patches are all:
Acked-by: Sam Ravnborg
Sam
Hi Paul,
On Fri, Jul 08, 2022 at 09:54:00PM +0100, Paul Cercueil wrote:
> Hi,
>
> A small set of changes to the ingenic-drm driver.
>
> The most notable thing is that ingenic-ipu is now its own platform
> driver.
It would be nice to know what is achieved by this change, I could
see the code bein
On Thu, Jul 7, 2022 at 5:37 AM Javier Martinez Canillas
wrote:
>
> Hello Ezequiel,
>
> Thanks a lot for your patch.
>
> On 7/6/22 20:41, Ezequiel Garcia wrote:
> > Fix small typo which causes the mask for the 'precharge1' setting
> > to be used with the 'precharge2' value.
> >
> > Signed-off-by: E
53 matches
Mail list logo
