On Thu, May 05, 2022 at 02:28:24AM +0200, Heiko Stübner wrote:
> Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer:
> > The VOP2 is the display output controller on the RK3568. Add the node
> > for it to the dtsi file along with the required display-subsystem node
> > and the iommu nod
Hi Dave, Daniel,
Here goes the final drm-intel-gt-next PR towards 5.19.
A fix for a security issue affecting Tigerlake onwards and a plain fix for
a race in VMA handling have landed since the previous pull.
Also last two bits of DG2 enablement are included - GuC firmware version
has been defin
Am 04.05.22 um 22:34 schrieb Jason Ekstrand:
Modern userspace APIs like Vulkan are built on an explicit
synchronization model. This doesn't always play nicely with the
implicit synchronization used in the kernel and assumed by X11 and
Wayland. The client -> compositor half of the synchronizatio
On Wed, May 4, 2022 at 11:59 PM Linus Walleij wrote:
> On Mon, May 2, 2022 at 9:08 AM Arnd Bergmann wrote:
> > On Sun, May 1, 2022 at 11:41 PM Linus Walleij
> > wrote:
> > >
> > > (...)
> > > > +static struct gpiod_lookup_table hx4700_audio_gpio_table = {
> > > > + .dev_id = "hx4700-audio
SLPC min/max frequency updates require H2G calls. We are seeing
timeouts when GuC channel is backed up and it is unable to respond
in a timely fashion causing warnings and affecting CI.
This is seen when waitboosting happens during a stress test.
this patch updates the waitboost path to use a non-
Hi Luke,
Please help on the EVB request that DRM reviewer, Thomas, needs one AST2600 EVB
to ease Display-Port verification on ASPEED DRM diver.
Thanks
Regards,
Kuo-Hsiang Chou
-Original Message-
From: Thomas Zimmermann [mailto:tzimmerm...@suse.de]
Sent: Wednesday, May 04, 2022
Applied. Thanks!
Alex
On Wed, May 4, 2022 at 10:22 PM wrote:
>
> From: Minghao Chi
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot
> Signed-off-by: Minghao Chi
> ---
> drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> di
Applied. Thanks!
On Wed, May 4, 2022 at 10:11 PM wrote:
>
> From: Minghao Chi
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot
> Signed-off-by: Minghao Chi
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 13 ++---
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
>
From: Minghao Chi
Simplify the return expression.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vega10_ih.c
b/drivers/gpu/drm/amd/amdgpu/vega10
From: Minghao Chi
Simplify the return expression.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
drivers/gpu/drm/ast/ast_drv.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index 7465c4f0156a..76
From: Minghao Chi
Simplify the return expression.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
drivers/gpu/drm/i915/i915_driver.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_driver.c
b/drivers/gpu/drm/i915/i915_driver.c
index
From: Minghao Chi
Simplify the return expression.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
---
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
b/drivers/gpu/drm/amd/amdg
On Wed, May 4, 2022 at 6:55 PM Jessica Zhang wrote:
>
> mdp5_get_global_state runs the risk of hitting a -EDEADLK when acquiring
> the modeset lock, but currently mdp5_pipe_release doesn't check for if
> an error is returned. Because of this, there is a possibility of
> mdp5_pipe_release hitting a
mdp5_get_global_state runs the risk of hitting a -EDEADLK when acquiring
the modeset lock, but currently mdp5_pipe_release doesn't check for if
an error is returned. Because of this, there is a possibility of
mdp5_pipe_release hitting a NULL dereference error.
To avoid this, let's have mdp5_pipe_r
Hi all,
After merging the drm-msm tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from drivers/gpu/drm/msm/msm_gpu.h:17,
from drivers/gpu/drm/msm/adreno/adreno_gpu.h:15,
from drivers/gpu/drm/msm/adreno/a3xx_gpu.h:10,
Hi all,
After merging the drm-msm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/gpu/drm/msm/dp/dp_display.c:13:10: fatal error:
drm/dp/drm_dp_aux_bus.h: No such file or directory
13 | #include
| ^
Caused by commit
mdp5_get_global_state runs the risk of hitting an EDEADLK when aqcuiring
the modeset lock, but currently mdp5_pipe_release doesn't check for if
an error is returned. Because of this, there is a possibility of
mdp5_pipe_release hitting a NULL dereference error.
To avoid this, let's have mdp5_pipe_r
Hi all,
Today's linux-next merge of the drm-msm tree got conflicts in:
drivers/gpu/drm/msm/edp/edp.h
drivers/gpu/drm/msm/edp/edp_ctrl.c
between commit:
da68386d9edb ("drm: Rename dp/ to display/")
from the drm tree and commit:
f1fc2b87de47 ("drm/msm: drop old eDP block support (again)
Hi all,
Today's linux-next merge of the drm-msm tree got a conflict in:
drivers/gpu/drm/msm/Kconfig
between commit:
1e0f66420b13 ("drm/display: Introduce a DRM display-helper module")
from the drm tree and commit:
f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
On Mon, May 02, 2022 at 03:33:53PM -0700, Summers, Stuart wrote:
> On Mon, 2022-05-02 at 09:34 -0700, Matt Roper wrote:
> > Add PVC's forcewake ranges.
> >
> > Bspec: 67609
> > Cc: Daniele Ceraolo Spurio
> > Signed-off-by: Matt Roper
> > ---
> > drivers/gpu/drm/i915/intel_uncore.c | 15
Am Freitag, 22. April 2022, 09:28:33 CEST schrieb Sascha Hauer:
> The VOP2 is the display output controller on the RK3568. Add the node
> for it to the dtsi file along with the required display-subsystem node
> and the iommu node.
>
> Signed-off-by: Sascha Hauer
> Acked-by: Rob Herring
> ---
>
MDP5 and DPU drivers have the same piece of code now to initialize
IOMMU and GEM address space. Move it to the msm_drv.c
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 32 ++
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 33 ---
driver
Change msm_kms_init_aspace() to use generic function
device_iommu_mapped() instead of the fwnode-specific interface
dev_iommu_fwspec_get(). While we are at it, stop referencing
platform_bus_type directly and use the bus of the IOMMU device.
Suggested-by: Robin Murphy
Signed-off-by: Dmitry Baryshk
Move iommu_domain_alloc() in front of adress space/IOMMU initialization.
This allows us to drop final bits of struct mdp5_cfg_platform which
remained from the pre-DT days.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 16
drivers/gpu/drm/msm/disp
Even if some IOMMU has registered itself on the platform "bus", that
doesn't necessarily mean it provides translation for the device we
care about. Replace iommu_present() with a more appropriate check.
On Qualcomm platforms the IOMMU can be specified either for the MDP/DPU
device or for its paren
Follow the lead of MDP5 driver and check both DPU and MDSS devices for
the IOMMU specifiers.
Historically DPU devices had IOMMU specified in the MDSS device tree
node, but as some of MDP5 devices are being converted to the supported
by the DPU driver, the driver should adapt and check both devices
This series started from the applied and then reverted [2] patch by
Robin Murphy [1]. After the MDSS rework [3] has landed it is now
possible to reapply the extended version of the original patch. While we
are at it, also rework the IOMMU init code for DPU and MDP5 drivers.
For MDP5 this moves iom
From: Matthew Brost
In GuC submission mode the EU priority must be updated by the GuC rather
than the driver as the GuC owns the programming of the context descriptor.
Given that the GuC code uses the GuC priorities, we can't use a generic
function using i915 priorities for both execlists and Gu
When rebooting on my sc7280-herobrine based device, I got a
crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
"pdev" was the one associated with mdss_probe().
>From source, I found that mdss_probe() has the line:
platform_set_drvdata(pdev, mdss);
...where "mdss" is of type "
Hi,
On Wed, May 4, 2022 at 4:29 PM Dmitry Baryshkov
wrote:
>
> On Thu, 5 May 2022 at 01:49, Douglas Anderson wrote:
> >
> > When rebooting on my sc7280-herobrine based device, I got a
> > crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
> > "pdev" was the one associated wit
On 5/4/2022 4:30 PM, Dmitry Baryshkov wrote:
On Thu, 5 May 2022 at 02:29, Abhinav Kumar wrote:
On 5/4/2022 3:49 PM, Douglas Anderson wrote:
When rebooting on my sc7280-herobrine based device, I got a
crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
"pdev" was the on
On Thu, 5 May 2022 at 02:29, Abhinav Kumar wrote:
>
>
>
> On 5/4/2022 3:49 PM, Douglas Anderson wrote:
> > When rebooting on my sc7280-herobrine based device, I got a
> > crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
> > "pdev" was the one associated with mdss_probe().
> >
On Thu, 5 May 2022 at 01:49, Douglas Anderson wrote:
>
> When rebooting on my sc7280-herobrine based device, I got a
> crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
> "pdev" was the one associated with mdss_probe().
>
> From source, I found that mdss_probe() has the line:
On 5/4/2022 3:49 PM, Douglas Anderson wrote:
When rebooting on my sc7280-herobrine based device, I got a
crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
"pdev" was the one associated with mdss_probe().
From source, I found that mdss_probe() has the line:
platform_se
On Wed, May 04, 2022 at 03:34:04PM -0500, Jason Ekstrand wrote:
> This patch is analogous to the previous sync file export patch in that
> it allows you to import a sync_file into a dma-buf. Unlike the previous
> patch, however, this does add genuinely new functionality to dma-buf.
> Without this,
When rebooting on my sc7280-herobrine based device, I got a
crash. Upon debugging, I found that I was in msm_drv_shutdown() and my
"pdev" was the one associated with mdss_probe().
>From source, I found that mdss_probe() has the line:
platform_set_drvdata(pdev, mdss);
...where "mdss" is of type "
On Wed, May 04, 2022 at 03:34:03PM -0500, Jason Ekstrand wrote:
> Modern userspace APIs like Vulkan are built on an explicit
> synchronization model. This doesn't always play nicely with the
> implicit synchronization used in the kernel and assumed by X11 and
> Wayland. The client -> compositor h
Eliminate the following coccicheck warning:
./drivers/gpu/drm/i915/gt/intel_migrate.c:643:2-3: Unneeded semicolon
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/
Fix following includecheck warning:
./drivers/gpu/drm/i915/gt/intel_sseu.c: linux/string_helpers.h is
included more than once.
Reported-by: Abaci Robot
Signed-off-by: Yang Li
---
drivers/gpu/drm/i915/gt/intel_sseu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/in
On Wed, May 04, 2022 at 10:58:57PM +0200, Michael Walle wrote:
> Am 2022-05-04 11:02, schrieb Lucas Stach:
> > While the labels may mislead the casual reader, the tail of the function
> > etnaviv_ioctl_gem_submit is always executed, as a lot of the structures
> > set up in this function need to be
On Tue, May 03, 2022 at 12:23:45PM +0300, Jani Nikula wrote:
> I've kind of lost track of the version numbers on some of the iterator
> patches, but this is the next version (or mostly a resend) of
> [1]. There's an additional rename patch for SCDS.
>
> BR,
> Jani.
>
>
> [1] https://patchwork.fr
Hi, Dave & Daniel:
This includes:
1. Add display support for MT8186
2. Miscellaneous refinement and fixup.
Regards,
Chun-Kuang.
The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17:
Linux 5.18-rc1 (2022-04-03 14:08:21 -0700)
are available in the git repository at:
On Mon, May 2, 2022 at 9:08 AM Arnd Bergmann wrote:
> On Sun, May 1, 2022 at 11:41 PM Linus Walleij
> wrote:
> >
> > (...)
> > > +static struct gpiod_lookup_table hx4700_audio_gpio_table = {
> > > + .dev_id = "hx4700-audio",
> > > + .table = {
> > > + GPIO_LOOKUP("gpio-
The driver is calling framebuffer_release() in its .remove callback, but
this will cause the struct fb_info to be freed too early. Since it could
be that a reference is still hold to it if user-space opened the fbdev.
This would lead to a use-after-free error if the framebuffer device was
unregist
The driver is calling framebuffer_release() in its .remove callback, but
this will cause the struct fb_info to be freed too early. Since it could
be that a reference is still hold to it if user-space opened the fbdev.
This would lead to a use-after-free error if the framebuffer device was
unregist
From: Daniel Vetter
Most fbdev drivers have issues with the fb_info lifetime, because call to
framebuffer_release() from their driver's .remove callback, rather than
doing from fbops.fb_destroy callback.
Doing that will destroy the fb_info too early, while references to it may
still exist, leadi
Hello,
This series contains patches suggested by Daniel Vetter to fix a use-after-free
error in the fb_release() function, due a fb_info associated with a fbdev being
freed too early while a user-space process still has the fbdev dev node opened.
The is cuused by a wrong management of the struct
On Tue, 03 May 2022 11:27:38 -0500, Rob Herring wrote:
> Another round of removing redundant minItems/maxItems when 'items' list is
> specified. This time it is in if/then schemas as the meta-schema was
> failing to check this case.
>
> If a property has an 'items' list, then a 'minItems' or 'maxI
On Tue, 3 May 2022 11:27:38 -0500
Rob Herring wrote:
> Another round of removing redundant minItems/maxItems when 'items' list is
> specified. This time it is in if/then schemas as the meta-schema was
> failing to check this case.
>
> If a property has an 'items' list, then a 'minItems' or 'max
Am 2022-05-04 11:02, schrieb Lucas Stach:
While the labels may mislead the casual reader, the tail of the
function
etnaviv_ioctl_gem_submit is always executed, as a lot of the structures
set up in this function need to be cleaned up regardless of whether the
submit succeeded or failed.
An excep
The previous patch introduced new failure cases in the HuC init flow
that can be hit by simply changing the config, so we want to avoid
failing the probe in those scenarios. HuC load failure is already
considered a non-fatal error and we have a way to report to userspace
if the HuC is not available
HuC loading via GSC is performed via a PXP command sent through the mei
modules, so we need both MEI_GSC and MEI_PXP to be available. Given that
the GSC will do both the transfer and the authentication, the legacy HuC
loading paths can be safely skipped.
Also note that the GSC-loaded HuC survives G
On newer platforms (starting DG2 G10 B-step and G11 A-step), ownership of
HuC loading has been moved from the GuC to the GSC. As part of the
change, the header format of the HuC binary has been updated and does not
match the GuC anymore. The GSC will perform all the required checks on
the binary si
The fuction name is confusing, because it doesn't check the actual auth
status in HW but the SW status. Given that there is only one user (the
huc_auth function itself), just get rid of it and use the FW status
checker directly.
Signed-off-by: Daniele Ceraolo Spurio
---
drivers/gpu/drm/i915/gt/u
On newer platforms (starting DG2 G10 B-step and G11 A-step), ownership of
HuC loading and authentication has been moved from the GuC to the GSC, with
both actions being performed via a single PXP command.
Given that the mei code has not fully landed yet (see [1]), we can't
implement the new load me
Applied patch 3. Thanks!
Alex
On Wed, May 4, 2022 at 12:50 PM Mike Lothian wrote:
>
> This stops clang complaining:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:5895:2: warning: unannotated
> fall-through between switch labels [-Wimplicit-fallthrough]
> default:
> ^
> drivers/gpu
On Wed, May 4, 2022 at 12:50 PM Mike Lothian wrote:
>
> This stops clang complaining:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3846:6: warning: variable 'index' is
> used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
> if (ring->is_mes_queue) {
>
This pull request contains few tiny fixes targeting 5.19. The biggest one is
the fix for the dp event thread wait condition.
The following changes since commit 36a1d1bda77e1851bddfa9cf4e8ada94476dbaff:
drm/msm: Fix null pointer dereferences without iommu (2022-05-02 10:11:44
-0700)
are availa
Hi Dave, Daniel,
Fixes for 5.18.
The following changes since commit 9d9f720733b7e8d11e4cc53b53f461b117dab839:
Merge tag 'amd-drm-fixes-5.18-2022-04-27' of
https://gitlab.freedesktop.org/agd5f/linux into drm-fixes (2022-04-29 10:27:05
+1000)
are available in the Git repository at:
https:/
Mhhh - looks like it goes far back enough I probably should just Cc it without
a version tag and see how far it applies for greg. Will do that
On Wed, 2022-05-04 at 14:49 -0400, Lyude Paul wrote:
> On Tue, 2022-05-03 at 21:23 +0200, Karol Herbst wrote:
> > not able to hit any error on my machine,
On Tue, 2022-05-03 at 21:23 +0200, Karol Herbst wrote:
> not able to hit any error on my machine, but regardless:
>
> Reviewed-by: Karol Herbst
>
> I suspect there are more places where we could put it, but we can add
> those later.
>
> Anyway, I think it's valuable to push it through fixes, no
Quoting Kuogee Hsieh (2022-05-03 09:25:36)
> Event thread supposed to exit from its while loop after kthread_stop().
> However there may has possibility that event thread is pending in the
> middle of wait_event due to condition checking never become true.
> To make sure event thread exit its loop
On 02/05/2022 20:29, Rob Clark wrote:
From: Rob Clark
Running the GPU without an IOMMU is not really a supported (or sane)
configuration. Yet it can be useful during SoC bringup (ie. if the
iommu driver doesn't work yet).
Lets limit it to users who already have /dev/mem access, to avoid the
c
On 03/05/2022 19:25, Kuogee Hsieh wrote:
Event thread supposed to exit from its while loop after kthread_stop().
However there may has possibility that event thread is pending in the
middle of wait_event due to condition checking never become true.
To make sure event thread exit its loop after kt
On 03/05/2022 19:25, Kuogee Hsieh wrote:
Event thread supposed to exit from its while loop after kthread_stop().
However there may has possibility that event thread is pending in the
middle of wait_event due to condition checking never become true.
To make sure event thread exit its loop after kt
On Wed, May 4, 2022 at 1:19 AM Byungchul Park wrote:
>
> Hi Linus and folks,
>
> I've been developing a tool for detecting deadlock possibilities by
> tracking wait/event rather than lock(?) acquisition order to try to
> cover all synchonization machanisms.
So what is the actual status of reports
On Wed, May 04, 2022 at 06:59:32PM +0100, Tvrtko Ursulin wrote:
>
> On 04/05/2022 17:48, Matt Roper wrote:
> > On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed
> > > t
On Wed, May 04, 2022 at 06:42:37PM +0200, Daniel Vetter wrote:
> On Wed, May 04, 2022 at 07:59:27AM -0700, Matt Roper wrote:
> > On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote:
> > > On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe
> > > wrote:
> > > > I915_PARAM_HAS_CONTEXT_ISOLATION w
On Wed, 2022-05-04 at 09:04 -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, May 4, 2022 at 5:21 AM Ville Syrjälä
> wrote:
> >
> > On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote:
> > > When doing DP AUX transfers there are two actors that need to be
> > > powered in order for the
On 04/05/2022 17:48, Matt Roper wrote:
On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed
to exercise a certain code path, so in case of values coming from MMIO
reads we cannot be sur
Hi!
> Linux code for running as a Hyper-V guest includes special cases for the
> first released versions of Hyper-V: 2008 and 2008R2/Windows 7. These
> versions were very thinly used for running Linux guests when first
> released more than 12 years ago, and they are now out of support
> (except fo
Reviewed-by: Lyude Paul
Will push to the appropriate branch in a little bit
On Thu, 2022-05-05 at 00:09 +0800, Guo Zhengkui wrote:
> Fix the following coccicheck warnings:
>
> drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gf100.c:71:5-12:
> Unneeded variable: "disable". Return "0ULL" on line 90.
Resources needed for output poll workers are destroyed in
nouveau_fbcon_fini() before output poll workers are cleared in
nouveau_display_fini(). This means there is a time between fbcon_fini
and display_fini, where if output poll happens, it crashes.
BUG: KASAN: use-after-free in
__drm_fb_helper_i
> From: Haiyang Zhang
> > > ...
> > > - if (gen2vm) {
> > > - pot_start = 0;
> > > - pot_end = -1;
> > > - } else {
> > > - if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) ||
> > > - pci_resource_len(pdev, 0) < screen_fb_size) {
> > > - pr_er
On 5/4/22 18:50, Alex Deucher wrote:
> On Wed, May 4, 2022 at 12:46 PM Javier Martinez Canillas
> wrote:
>>
>> Hello Alex,
>>
>> On 5/4/22 15:48, Alex Deucher wrote:
>>> This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b.
>>>
>>> This workaround is no longer necessary. We have a better
On Wed, May 4, 2022 at 12:46 PM Javier Martinez Canillas
wrote:
>
> Hello Alex,
>
> On 5/4/22 15:48, Alex Deucher wrote:
> > This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b.
> >
> > This workaround is no longer necessary. We have a better workaround
> > in commit f95af4a9236695 ("drm
This stops clang complaining:
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:5895:2: warning: unannotated
fall-through between switch labels [-Wimplicit-fallthrough]
default:
^
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:5895:2: note: insert 'break;' to avoid
fall-through
default:
This stops clang complaining:
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:376:6: warning: variable 'index' is used
uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (ring->is_mes_queue) {
^~
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:433:30: n
This stops clang complaining:
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3846:6: warning: variable 'index' is
used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (ring->is_mes_queue) {
^~
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3903:30:
Just a few simple fixes to get rid of warnings seen with clang 14
Mike Lothian (3):
drm/amdgpu/gfx10: Initalise index
drm/amdgpu/gfx11: Initalise index
drm/amdgpu/gfx11: Add missing break
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 3 ++-
2 files
On 5/4/22 15:48, Alex Deucher wrote:
> This reverts commit 9a45ac2320d0a6ae01880a30d4b86025fce4061b.
>
> This was added a helper for amdgpu to workaround a runtime pm regression
> caused by a runtime pm fix in efifb. We now have a better workarouund
s/workarouund/workaround
> in amdgpu in
> com
On Wed, May 04, 2022 at 01:07:14PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> DRM_DEBUG_WARN_ON should only be used when we are certain CI is guaranteed
> to exercise a certain code path, so in case of values coming from MMIO
> reads we cannot be sure CI will have all the possible SK
On Wed, May 04, 2022 at 09:48:32AM -0400, Alex Deucher wrote:
> This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b.
>
> This workaround is no longer necessary. We have a better workaround
> in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are
> displays attached (v
Hello Alex,
On 5/4/22 15:48, Alex Deucher wrote:
> This reverts commit b95dc06af3e683d6b7ddbbae178b2b2a21ee8b2b.
>
> This workaround is no longer necessary. We have a better workaround
> in commit f95af4a9236695 ("drm/amdgpu: don't runtime suspend if there are
> displays attached (v3)").
>
I w
> -Original Message-
> From: Wei Liu
> Sent: Thursday, April 28, 2022 10:38 AM
> To: Saurabh Sengar
> Cc: Saurabh Singh Sengar ; KY Srinivasan
> ; Haiyang Zhang ; Stephen
> Hemminger ; wei@kernel.org; Dexuan Cui
> ; del...@gmx.de; linux-hyp...@vger.kernel.org; linux-
> fb...@vger.k
On Wed, May 04, 2022 at 07:59:27AM -0700, Matt Roper wrote:
> On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote:
> > On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe
> > wrote:
> > > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by
> > > both Iris and Vulkan , and st
Fix the following coccicheck warnings:
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gf100.c:71:5-12:
Unneeded variable: "disable". Return "0ULL" on line 90.
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/gm107.c:35:5-12:
Unneeded variable: "disable". Return "0ULL" on line 44.
drivers/gpu/drm/nouveau/n
On 04/05/2022 16:59, Thomas Zimmermann wrote:
Hi Jocelyn,
with my comment on 3/3 considered, you can add
Reviewed-by: Thomas Zimemrmann
to this patchset.
You should get commit access for drm-misc, so that you can land the
patchset on your own. Please see
https://drm.pages.freedesktop.o
Hi,
On Wed, May 4, 2022 at 5:21 AM Ville Syrjälä
wrote:
>
> On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote:
> > When doing DP AUX transfers there are two actors that need to be
> > powered in order for the DP AUX transfer to work: the DP source and
> > the DP sync. Commit bacbab
On 03/05/2022 22:43, Dmitry Baryshkov wrote:
Correct a typo in the address of the second DSI PHY in the SDM660 device
config.
Fixes: 694dd304cc29 ("drm/msm/dsi: Add phy configuration for SDM630/636/660")
Cc: Konrad Dybcio
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Abhinav Kumar
---
Gah
On 5/4/22 11:21, Daniel Vetter wrote:
...
>>> - Maybe also do what you suggest and keep a separate lock for this, but
>>> the fundamental issue is that this doesn't really work - if you share
>>> buffers both ways with two drivers using shmem helpers, then the
>>> ordering of this vmap_count_
On 20/04/2022 10:57, Karol Herbst wrote:
i915_vma_reopen checked if the vma is closed before without taking the
lock. So multiple threads could attempt removing the vma.
Instead the lock needs to be taken before actually checking.
v2: move struct declaration
Cc: Chris Wilson
Cc: intel-...@l
On Fri, 29 Apr 2022 14:29:47 +0530, Jagan Teki wrote:
> commit <3d7039e1e649> ("drm: bridge: mcde_dsi: Switch to
> devm_drm_of_get_bridge")
> switched to devm_drm_of_get_bridge for looking up if child node has panel
> or bridge.
>
> However commit ("Revert "drm: of: Lookup if child node
> has pa
On Fri, 29 Apr 2022 14:29:46 +0530, Jagan Teki wrote:
> commit <3730bc6147b0> ("drm: bridge: mcde_dsi: Drop explicit bridge
> remove") has removed downstream bridge as it's prior commit <3d7039e1e649>
> ("drm: bridge: mcde_dsi: Switch to devm_drm_of_get_bridge") added
> devm_drm_of_get_bridge for l
On Thu, 28 Apr 2022 15:18:08 +0530, Jagan Teki wrote:
> commit <711c7adc4687> ("drm: exynos: dsi: Use drm panel_bridge API")
> added devm_drm_of_get_bridge for looking up if child node has panel
> or bridge.
>
> However commit ("Revert "drm: of: Lookup if child node
> has panel or bridge") has re
On Fri, Apr 29, 2022 at 07:05:59PM +0300, Laurent Pinchart wrote:
> Hi Maxime,
>
> On Fri, Apr 29, 2022 at 05:46:45PM +0200, Maxime Ripard wrote:
> > On Fri, Apr 29, 2022 at 01:17:26AM +0300, Laurent Pinchart wrote:
> > > On Thu, Apr 28, 2022 at 02:09:42PM +0530, Jagan Teki wrote:
> > > > On Wed,
On Wed, 04 May 2022 03:26:01 +0200, Marek Vasut wrote:
> Add missing reg and reg-names properties for both 'LDB_CTRL'
> and 'LVDS_CTRL' registers.
>
> Fixes: 463db5c2ed4ae ("drm: bridge: ldb: Implement simple Freescale i.MX8MP
> LDB bridge")
> Signed-off-by: Marek Vasut
> Cc: Laurent Pinchart
>
Hi Jocelyn,
with my comment on 3/3 considered, you can add
Reviewed-by: Thomas Zimemrmann
to this patchset.
You should get commit access for drm-misc, so that you can land the
patchset on your own. Please see
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html
for how
On Wed, May 04, 2022 at 02:24:07PM +0200, Daniel Vetter wrote:
> On Fri, 29 Apr 2022 at 17:11, Adrian Larumbe
> wrote:
> > I915_PARAM_HAS_CONTEXT_ISOLATION was already being used as a boolean by
> > both Iris and Vulkan , and stood for the guarantee that, when creating a
> > new context, all state
Hi,
On Wed, May 4, 2022 at 3:41 AM Dmitry Baryshkov
wrote:
>
> > - We had forgotten a EXPORT_SYMBOL_GPL on the non "devm" populate
> >function.
>
> This can go to a separate patch, so that the fix can be backported to
> earlier kernels. Please don't forget the Fixes: tag.
Sure. Will do for v
1 - 100 of 265 matches
Mail list logo