[PATCH v7 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-13 Thread Liu Ying
i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports either a MIPI DSI display or a LVDS display. The PHY mode is controlled by SCU firmware and the driver would call a SCU firmware function to configure the PHY mode. The single LVDS PHY has 4 data lanes to support a LVDS display

[PATCH v7 4/5] dt-bindings: phy: mixel: mipi-dsi-phy: Add Mixel combo PHY support for i.MX8qxp

2022-04-13 Thread Liu Ying
Add support for Mixel MIPI DPHY + LVDS PHY combo IP as found on Freescale i.MX8qxp SoC. Cc: Guido Günther Cc: Kishon Vijay Abraham I Cc: Vinod Koul Cc: Rob Herring Cc: NXP Linux Team Reviewed-by: Rob Herring Reviewed-by: Guido Günther Signed-off-by: Liu Ying --- v6->v7: * No change. v5->v

[PATCH v7 3/5] dt-bindings: phy: Convert mixel, mipi-dsi-phy to json-schema

2022-04-13 Thread Liu Ying
This patch converts the mixel,mipi-dsi-phy binding to DT schema format using json-schema. Comparing to the plain text version, the new binding adds the 'assigned-clocks', 'assigned-clock-parents' and 'assigned-clock-rates' properites, otherwise 'make dtbs_check' would complain that there are mis-m

[PATCH v7 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
This patch allows LVDS PHYs to be configured through the generic functions and through a custom structure added to the generic union. The parameters added here are based on common LVDS PHY implementation practices. The set of parameters should cover all potential users. Cc: Kishon Vijay Abraham

[PATCH v7 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set()

2022-04-13 Thread Liu Ying
The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp works with a Mixel MIPI DPHY + LVDS PHY combo to support either a MIPI DSI display or a LVDS display. So, this patch calls phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY explicitly. Cc: Guido Günther Cc: Rober

[PATCH v7 0/5] phy: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-13 Thread Liu Ying
Hi, This is the v7 series to add i.MX8qxp LVDS PHY mode support for the Mixel PHY in the Freescale i.MX8qxp SoC. The Mixel PHY is MIPI DPHY + LVDS PHY combo, which can works in either MIPI DPHY mode or LVDS PHY mode. The PHY mode is controlled by i.MX8qxp SCU firmware. The PHY driver would call

Re: [Intel-gfx] [PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-13 Thread Anshuman Gupta
On 2022-04-13 at 04:18:52 +0530, Vinay Belgaumkar wrote: > This will ensure we don't have false positives when we run > error injection tests. > > Signed-off-by: Vinay Belgaumkar > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42 ++--- > 1 file changed, 21 insertions(+), 2

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Liu Ying
On Thu, 2022-04-14 at 11:07 +0530, Vinod Koul wrote: > On 13-04-22, 20:39, Liu Ying wrote: > > On Wed, 2022-04-13 at 16:19 +0530, Vinod Koul wrote: > > > On 13-04-22, 18:04, Liu Ying wrote: > > > > Hi Vinod, > > > > > > > > On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote: > > > > > On 02-04-22

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-13 Thread François Valenduc
Le 14/04/22 à 08:31, Lisovskiy, Stanislav a écrit : On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote: On Wed, 13 Apr 2022, François Valenduc wrote: Commit 15512021eb3975a8c2366e3883337e252bb0eee5 (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots to appears on th

Re: linux-next: manual merge of the drm-misc tree with the drm-misc-fixes tree

2022-04-13 Thread Christian König
Am 14.04.22 um 01:47 schrieb Stephen Rothwell: Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/radeon/radeon_sync.c between commit: 022074918042 ("drm/radeon: fix logic inversion in radeon_sync_resv") from the drm-misc-fixes tree and commit:

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-13 Thread Lisovskiy, Stanislav
On Wed, Apr 13, 2022 at 08:12:20PM +0300, Jani Nikula wrote: > On Wed, 13 Apr 2022, François Valenduc wrote: > > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots > > to appears on the right upper corner of all console scre

Re: [PATCH] drm/radeon: Add build directory to include path

2022-04-13 Thread Christian König
Am 13.04.22 um 18:14 schrieb Michel Dänzer: From: Michel Dänzer Fixes compile errors with out-of-tree builds, e.g. ../drivers/gpu/drm/radeon/r420.c:38:10: fatal error: r420_reg_safe.h: No such file or directory 38 | #include "r420_reg_safe.h" | ^ Well st

[RESEND][PATCH] omapdrm: fix missing check on list iterator

2022-04-13 Thread Xiaomeng Tong
The bug is here: bus_flags = connector->display_info.bus_flags; The list iterator 'connector-' will point to a bogus position containing HEAD if the list is empty or no element is found. This case must be checked before any use of the iterator, otherwise it will lead to a invalid memory ac

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-13 Thread Vinod Koul
On 13-04-22, 20:39, Liu Ying wrote: > On Wed, 2022-04-13 at 16:19 +0530, Vinod Koul wrote: > > On 13-04-22, 18:04, Liu Ying wrote: > > > Hi Vinod, > > > > > > On Wed, 2022-04-13 at 11:41 +0530, Vinod Koul wrote: > > > > On 02-04-22, 13:24, Liu Ying wrote: > > > > > This patch allows LVDS PHYs to b

[pull] amdgpu drm-fixes-5.18

2022-04-13 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.18. The following changes since commit 88711fa9a14f6f473f4a7645155ca51386e36c21: Merge tag 'drm-misc-fixes-2022-04-07' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes (2022-04-08 09:22:16 +1000) are available in the Git repository at: https://git

Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-04-13 Thread Xin Ji
On Wed, Apr 13, 2022 at 04:28:51PM +0200, Robert Foss wrote: > On Sat, 9 Apr 2022 at 06:47, Xin Ji wrote: > > > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > > > Change bus-type define for DPI. > > > > > > > > Fixes

RE: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Tian, Kevin
> From: Wang, Zhi A > Sent: Thursday, April 14, 2022 5:09 AM > > > Or is it that only the page table levels themselves are GFNs and the > > actual DMA's are IOVA? The unclear mixing of GFN as IOVA in the code > > makes it inscrutible. > > > > No. Even the HW is capable of controlling the level o

RE: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, April 14, 2022 7:12 AM > > On Wed, Apr 13, 2022 at 09:08:40PM +, Wang, Zhi A wrote: > > On 4/13/22 8:04 PM, Jason Gunthorpe wrote: > > > On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote: > > >> On 4/13/22 5:37 PM, Jason Gunthorpe wrote: > >

Re: [PATCH v2] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-13 Thread Stephen Boyd
The subject is still misleading. It is fixing something. It may be enhancing it as well but it is clearly fixing it first. Quoting Kuogee Hsieh (2022-04-06 14:28:13) > dp_hpd_plug_handle() is responsible for setting up main link and send > uevent to notify user space framework to start video strea

linux-next: manual merge of the drm-misc tree with the drm-misc-fixes tree

2022-04-13 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/radeon/radeon_sync.c between commit: 022074918042 ("drm/radeon: fix logic inversion in radeon_sync_resv") from the drm-misc-fixes tree and commit: 7bc80a5462c3 ("dma-buf: add enum dma_resv_usage v4"

Re: [PATCH v2] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-13 Thread Dmitry Baryshkov
On 14/04/2022 00:04, Kuogee Hsieh wrote: Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Changes in v2: -- start event thread at dp_display_

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 11:13:06PM +, Wang, Zhi A wrote: > Hi folks: > > Thanks so much for the efforts. I prepared a branch which contains all our > patches.The aim of the branch is for the VFIO maintainers to pull the whole > bunch easily after the drm-intel-next got merged through drm (as

Re: [PATCH v2] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-13 14:04:25) > Current DP driver implementation, event thread is kept running > after DP display is unbind. This patch fix this problem by disabling > DP irq and stop event thread to exit gracefully at dp_display_unbind(). > > Changes in v2: > -- start event thread at

[Bug 215618] vblank related lockup during start of SteamVR using Valve Index HMD

2022-04-13 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215618 Pierre Choffet (ct@peuc.net) changed: What|Removed |Added CC||ct@peuc.net --- Co

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Wang, Zhi A
Hi folks: Thanks so much for the efforts. I prepared a branch which contains all our patches.The aim of the branch is for the VFIO maintainers to pull the whole bunch easily after the drm-intel-next got merged through drm (as one of the MMIO patches depends on a patch in drm-intel-next). I dro

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 09:08:40PM +, Wang, Zhi A wrote: > On 4/13/22 8:04 PM, Jason Gunthorpe wrote: > > On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote: > >> On 4/13/22 5:37 PM, Jason Gunthorpe wrote: > >>> On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: >

Re: [PATCH V2 3/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8192 and MT8195

2022-04-13 Thread Rob Herring
On Mon, 11 Apr 2022 11:58:43 +0800, Rex-BC Chen wrote: > Disp_aal of MT8192 and MT8195 are fully compatible with disp_aal of > MT8183. Therefore, we move the them to item "mediatek,mt8183-disp-aal". > > Signed-off-by: Rex-BC Chen > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml

Re: [PATCH V2 1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

2022-04-13 Thread Rob Herring
On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote: > The driver data of MT8183 and MT8173 are different. > > For MT8173, the gamma module is inside disp_aal. When we need to adjust > gamma value, we need to use "has_gamma" to control gamma function > inside disp_aal to adjust the gamma value.

Re: [PATCH v8 2/2] drm/msm/disp/dpu1: add inline rotation support for sc7280

2022-04-13 Thread Dmitry Baryshkov
On 11/04/2022 19:37, Vinod Polimera wrote: - Some DPU versions support inline rot90. It is supported only for limited amount of UBWC formats. - There are two versions of inline rotators, v1 (present on sm8250 and sm7250) and v2 (sc7280). These versions differ in the list of supported formats and

Re: [PATCH v8 1/2] drm/msm/disp/dpu1: add inline function to validate format support

2022-04-13 Thread Dmitry Baryshkov
On 11/04/2022 19:37, Vinod Polimera wrote: Check if the dpu format is supported or not using dpu_find_format. Co-developed-by: Kalyan Thota Signed-off-by: Kalyan Thota Signed-off-by: Vinod Polimera Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h | 22 +

Re: [PATCH v2] drm/tegra: Stop using iommu_present()

2022-04-13 Thread Dmitry Osipenko
On 4/11/22 16:46, Robin Murphy wrote: > Refactor the confusing logic to make it both clearer and more robust. If > the host1x parent device does have an IOMMU domain then iommu_present() > is redundantly true, while otherwise for the 32-bit DMA mask case it > still doesn't say whether the IOMMU dri

[RFC PATCH 12/16] drm/rockchip: ebc: Add support for direct mode

2022-04-13 Thread Samuel Holland
Currently, 3-window mode causes some artifacting. Until the cause is determined, provide an option to use direct mode instead. Direct mode does the waveform lookups in software, so it has much higher CPU usage. This limits the frame rate below the panel's ideal 85 Hz, so it leads to slightly lower

[RFC PATCH 16/16] [DO NOT MERGE] arm64: dts: rockchip: pinenote: Enable EBC display pipeline

2022-04-13 Thread Samuel Holland
The PineNote contains an eInk ED103TC2 panel connected to the EBC, powered by a TI TPS651851 PMIC. Signed-off-by: Samuel Holland --- .../boot/dts/rockchip/rk3566-pinenote.dtsi| 80 +++ 1 file changed, 80 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenot

[RFC PATCH 15/16] arm64: dts: rockchip: rk356x: Add EBC node

2022-04-13 Thread Samuel Holland
The RK356x SoCs contain an EBC. Add its node. Signed-off-by: Samuel Holland --- arch/arm64/boot/dts/rockchip/rk356x.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index 7cdef800cb3c..5

[RFC PATCH 14/16] drm/panel-simple: Add eInk ED103TC2

2022-04-13 Thread Samuel Holland
ED103TC2 is a 10.3" 1872x1404 eInk panel which supports up to 16 levels of grayscale and an 85 Hz frame rate. The timings and polarities here were taken from the manufacturer's datasheet. Since this panel is an electrophoretic display (EPD), the color depth is independent from the bus width. Inste

[RFC PATCH 10/16] drm/rockchip: ebc: Implement partial refreshes

2022-04-13 Thread Samuel Holland
Several areas of the display can be refreshed concurrently, but only if they do not overlap. This commit adds a queue of damaged areas, and schedules them for refresh based on collision with other areas. While the queue is unbounded, there is logic to quickly drop duplicate areas. Because three-wi

[RFC PATCH 09/16] drm/rockchip: ebc: Implement global refreshes

2022-04-13 Thread Samuel Holland
The global refresh mode is used to initialize and clear the screen. It is the most efficient refresh mode. It uses two pixel buffers (old and new) and a frame count. The frame count is set to the number of phases in the waveform. The hardware then looks up the combination of (old pixel value, new p

[RFC PATCH 13/16] drm/rockchip: ebc: Add a panel reflection option

2022-04-13 Thread Samuel Holland
Some panels, like the one in the PineNote, are reflected. Since the driver already has to copy pixels, the driver can handle this with little additional overhead. Currently, there is no devicetree binding for this situation, so control the behavior via a module parameter. Signed-off-by: Samuel Ho

[RFC PATCH 05/16] drm/rockchip: ebc: Add CRTC mode setting

2022-04-13 Thread Samuel Holland
EPDs require some additional timing data beyond what is normally provided by drm_display_mode, as that struct is designed for CRTs/LCDs. For example, EPDs care about the width and position of the gate driver (vertical) clock pulse within a line. EPDs also update some number of pixels in parallel,

[RFC PATCH 11/16] drm/rockchip: ebc: Enable diff mode for partial refreshes

2022-04-13 Thread Samuel Holland
Some waveforms, such as GC16, cause the display to flash even when the previous and next pixel values are the same. This can be helpful, because it produces more consistent brightness, but usually it is more distracting. Add an option, enabled by default, for the hardware to ignore the LUT and alwa

[RFC PATCH 06/16] drm/rockchip: ebc: Add CRTC refresh thread

2022-04-13 Thread Samuel Holland
EPD refreshes are extremely slow; they take anywhere between hundreds of milliseconds and several seconds. To avoid blocking userspace, perform these refreshes on a separate thread. The thread will also take care of initializing the display before first use and clearing it when the CRTC is disabled

[RFC PATCH 07/16] drm/rockchip: ebc: Add CRTC buffer management

2022-04-13 Thread Samuel Holland
This commit adds the "context" structure which holds all buffers needed to refresh the display. It is allocated separately from the CRTC state because it is reused as long as no mode change occurs. There are three buffers holding Y4 (grayscale 4 bits/pixel) pixel data: - "prev" - contents of the

[RFC PATCH 08/16] drm/rockchip: ebc: Add LUT loading

2022-04-13 Thread Samuel Holland
The EBC contains a 16 KiB SRAM which stores the current LUT. It needs to be programmed any time the LUT changes or the hardware block is enabled. Since both of these triggers can happen at the same time, use a flag to avoid writing the LUT twice. Signed-off-by: Samuel Holland --- drivers/gpu/dr

[RFC PATCH 03/16] drm/rockchip: Add EBC platform driver skeleton

2022-04-13 Thread Samuel Holland
The Rockchip E-Book Controller (EBC) is a timing controller (TCON) responsible for sending timing signals and pixel update waveforms to an electrophoretic display (EPD). The EBC has several modes of operation. In direct mode, it reads precomputed source driver polarity data from a series of buffers

[RFC PATCH 04/16] drm/rockchip: ebc: Add DRM driver skeleton

2022-04-13 Thread Samuel Holland
The Rockchip E-Book Controller (EBC) has a relatively simple and self- contained display pipeline. The pipeline consists of a single CRTC, encoder, and bridge, with the bridge normally attached to a panel. Initially, there is also a single plane. Since all blitting is done in software, the driver

[RFC PATCH 01/16] drm: Add a helper library for EPD drivers

2022-04-13 Thread Samuel Holland
Currently, this library is focused on LUTs and LUT files, specifically the PVI wbf-format files shipped with E-Ink displays. It provides helpers to load and validate LUT files, and extract LUTs from them. Since EPD controllers need the LUTs in various formats, this library allows drivers to declar

[RFC PATCH 02/16] dt-bindings: display: rockchip: Add EBC binding

2022-04-13 Thread Samuel Holland
The Rockchip E-Book Controller (EBC) is a controller for Electrophoretic Displays (EPDs). It is self-contained; it does not interact directly with the VOP or the RGA. While two of the regulator consumers here actually power the display panel, not the EBC hardware, they are consumed here because th

[RFC PATCH 00/16] drm/rockchip: Rockchip EBC ("E-Book Controller") display driver

2022-04-13 Thread Samuel Holland
This series adds a DRM driver for the electrophoretic display controller found in a few different Rockchip SoCs, specifically the RK3566/RK3568 variant[0] used by the PineNote tablet[1]. This is my first real involvement with the DRM subsystem, so please let me know where I am misunderstanding thi

Re: [PATCH 1/4] drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc

2022-04-13 Thread Francisco Jerez
Looks good to me, series is: Reviewed-by: Francisco Jerez Matt Roper writes: > This structure has a great comment describing the fields, but it's not > currently in kerneldoc form and does not show up in the generated > documentation. Let's fix that and also clarify the description of what >

Re: [PATCH v4,2/3] dt-bindings: display: mediatek: dsi: Add compatible for MediaTek MT8186

2022-04-13 Thread Rob Herring
On Sat, 09 Apr 2022 17:11:53 +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Add dt-binding documentation of dsi for MediaTek MT8186 SoC. > > Signed-off-by: Xinlei Lee > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Rex-BC Chen > --- > .../devicetree/bindings/display

Re: [PATCH v4,1/3] dt-bindings: display: mediatek: dsi: Convert dsi_dtbinding to .yaml

2022-04-13 Thread Rob Herring
On Sat, Apr 09, 2022 at 05:11:52PM +0800, xinlei@mediatek.com wrote: > From: Xinlei Lee > > Convert mediatek,dsi.txt to mediatek,dsi.yaml format > > Signed-off-by: Xinlei Lee > --- > .../display/mediatek/mediatek,dsi.txt | 62 - > .../display/mediatek/mediatek,dsi.yaml

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Wang, Zhi A
On 4/13/22 8:04 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote: >> On 4/13/22 5:37 PM, Jason Gunthorpe wrote: >>> On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: >

[PATCH v2] drm/msm/dp: stop event kernel thread when DP unbind

2022-04-13 Thread Kuogee Hsieh
Current DP driver implementation, event thread is kept running after DP display is unbind. This patch fix this problem by disabling DP irq and stop event thread to exit gracefully at dp_display_unbind(). Changes in v2: -- start event thread at dp_display_bind() Fixes: e91e3065a806 ("drm/msm/dp: A

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 07:17:52PM +, Wang, Zhi A wrote: > On 4/13/22 5:37 PM, Jason Gunthorpe wrote: > > On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: > >> On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: > >>> Yeah, I was thinking about that too, but on th

Re: AMDGPU: regression on 5.17.1

2022-04-13 Thread Michele Ballabio
On Wed, 13 Apr 2022 14:14:42 -0400 Alex Deucher wrote: > On Wed, Apr 13, 2022 at 1:33 PM Michele Ballabio > wrote: > > > > On Mon, 11 Apr 2022 14:34:37 -0400 > > Alex Deucher wrote: > > > > > On Sat, Apr 9, 2022 at 12:28 PM Michele Ballabio > > > wrote: > > > > > > > > On Tue, 5 Apr 2022 1

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Wang, Zhi A
On 4/13/22 5:37 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: >> On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: >>> Yeah, I was thinking about that too, but on the other hand I think it >>> is completely wrong that gvt requires kvm

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Rob Herring
eOn Wed, Apr 13, 2022 at 1:46 PM Rob Herring wrote: > > On Wed, Apr 13, 2022 at 12:58 PM Thomas Zimmermann > wrote: > > > > Hi > > > > Am 13.04.22 um 14:51 schrieb Rob Herring: > > > On Wed, Apr 13, 2022 at 4:24 AM Thomas Zimmermann > > > wrote: > > >> > > >> Create a platform device for each

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Rob Herring
On Wed, Apr 13, 2022 at 12:58 PM Thomas Zimmermann wrote: > > Hi > > Am 13.04.22 um 14:51 schrieb Rob Herring: > > On Wed, Apr 13, 2022 at 4:24 AM Thomas Zimmermann > > wrote: > >> > >> Create a platform device for each OF-declared framebuffer and have > >> offb bind to these devices. Allows for

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-13 Thread Nicolas Dufresne
Le mercredi 13 avril 2022 à 09:57 +0200, AngeloGioacchino Del Regno a écrit : > Il 13/04/22 09:03, allen-kh.cheng ha scritto: > > Hi Nicolas, > > > > On Tue, 2022-04-12 at 10:48 -0400, Nicolas Dufresne wrote: > > > Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d...@mediatek.com a > > > écrit : > >

Re: AMDGPU: regression on 5.17.1

2022-04-13 Thread Alex Deucher
On Wed, Apr 13, 2022 at 1:33 PM Michele Ballabio wrote: > > On Mon, 11 Apr 2022 14:34:37 -0400 > Alex Deucher wrote: > > > On Sat, Apr 9, 2022 at 12:28 PM Michele Ballabio > > wrote: > > > > > > On Tue, 5 Apr 2022 10:23:16 -0400 > > > Alex Deucher wrote: > > > > > > > On Mon, Apr 4, 2022 at 3:3

Re: [PATCH 2/2] fbdev: Remove hot-unplug workaround for framebuffers without device

2022-04-13 Thread Thomas Zimmermann
Hi Am 13.04.22 um 18:05 schrieb Daniel Vetter: On Wed, Apr 13, 2022 at 12:50:50PM +0200, Javier Martinez Canillas wrote: On 4/13/22 11:24, Thomas Zimmermann wrote: A workaround makes fbdev hot-unplugging work for framebuffers without device. The only user for this feature was offb. As each OF

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Javier Martinez Canillas
On 4/13/22 19:58, Thomas Zimmermann wrote: > Hi [snip] >>> >>> /* Populate everything else. */ >>> of_platform_default_populate(NULL, NULL, NULL); >> >> I'm pretty sure it's just this call that's the problem for PPC though >> none of the above existed when adding this caused a r

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Thomas Zimmermann
Hi Am 13.04.22 um 14:51 schrieb Rob Herring: On Wed, Apr 13, 2022 at 4:24 AM Thomas Zimmermann wrote: Create a platform device for each OF-declared framebuffer and have offb bind to these devices. Allows for real hot-unplugging and other drivers besides offb. Originally, offb created framebu

Re: [PATCH] dt-bindings: display: panel-timing: Define a single type for properties

2022-04-13 Thread Sam Ravnborg
Hi Rob, On Wed, Apr 13, 2022 at 09:00:15AM -0500, Rob Herring wrote: > It's not good practice to define multiple types for the same property, so > factor out the type reference making the properties always an uint32-array > with a length of 1 or 3 items. > > Signed-off-by: Rob Herring Looks goo

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 06:29:46PM +0200, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 01:18:14PM -0300, Jason Gunthorpe wrote: > > Yeah, I was thinking about that too, but on the other hand I think it > > is completely wrong that gvt requires kvm at all. A vfio_device is not > > supposed to

Re: AMDGPU: regression on 5.17.1

2022-04-13 Thread Michele Ballabio
On Mon, 11 Apr 2022 14:34:37 -0400 Alex Deucher wrote: > On Sat, Apr 9, 2022 at 12:28 PM Michele Ballabio > wrote: > > > > On Tue, 5 Apr 2022 10:23:16 -0400 > > Alex Deucher wrote: > > > > > On Mon, Apr 4, 2022 at 3:39 PM Michele Ballabio > > > wrote: > > > > > > > > On Mon, 4 Apr 2022 13:

[pull] drm/msm: drm-msm-fixes-2022-04-13 for v5.18

2022-04-13 Thread Rob Clark
Hi Dave & Daniel, A few fixes for v5.18. The following changes since commit 05afd57f4d34602a652fdaf58e0a2756b3c20fd4: drm/msm/gpu: Fix crash on devices without devfreq support (v2) (2022-03-08 13:55:23 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.gi

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes with spots in console screeens.

2022-04-13 Thread Jani Nikula
On Mon, 11 Apr 2022, François Valenduc wrote: > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots > to appears on the right upper corner of all console screens see the > attached photo). git-bisect shows that this is the off

Re: [PATCH] drm/i915: Remove intel_gvt_init_host declaration

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, Cong Liu wrote: > this function has been deleted since commit 9bdb073464d6 ("drm/i915/gvt: > Change KVMGT as self load module"), remove the deprecated function > declaration. I don't want to push this right now avoid conflicts in other pending work. Cc'd Zhi & Zhenyu to pick

Re: commit 15512021eb3975a8c2366e3883337e252bb0eee5 causes white spots in console screens

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, François Valenduc wrote: > Commit 15512021eb3975a8c2366e3883337e252bb0eee5 > (15512021eb3975a8c2366e3883337e252bb0eee5) causes a lof of white spots > to appears on the right upper corner of all console screens (see > https://drive.google.com/file/d/13GabEvOIKSAj5yox6ybAZEDu

Re: [PATCH v4 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-13 Thread Javier Martinez Canillas
On 4/13/22 19:02, Andy Shevchenko wrote: > On Wed, Apr 13, 2022 at 06:23:57PM +0200, Javier Martinez Canillas wrote: >> These are declared in the ssd130x-i2c transport driver but the information >> is not I2C specific, and could be used by other SSD130x transport drivers. >> >> Move them to the ssd

Re: [PATCH v4 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-13 Thread Andy Shevchenko
On Wed, Apr 13, 2022 at 06:23:57PM +0200, Javier Martinez Canillas wrote: > These are declared in the ssd130x-i2c transport driver but the information > is not I2C specific, and could be used by other SSD130x transport drivers. > > Move them to the ssd130x core driver and just set the OF device en

[PATCH v4 0/5] drm/solomon: Add SSD130x OLED displays SPI support

2022-04-13 Thread Javier Martinez Canillas
Hello, This series adds a ssd130x-spi driver that provides a 4-wire SPI transport support for SSD130x OLED controllers that can be accessed over a SPI bus. The driver is quite similar to existing ssd130x-i2c driver that is used by I2C controllers, but there is a difference in the protocol used by

[PATCH v4 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-13 Thread Javier Martinez Canillas
These are declared in the ssd130x-i2c transport driver but the information is not I2C specific, and could be used by other SSD130x transport drivers. Move them to the ssd130x core driver and just set the OF device entries to an ID that could be used to lookup the correct device info from an array.

[PATCH v4 5/5] drm/solomon: Add SSD130x OLED displays SPI support

2022-04-13 Thread Javier Martinez Canillas
The ssd130x driver only provides the core support for these devices but it does not have any bus transport logic. Add a driver to interface over SPI. There is a difference in the communication protocol when using 4-wire SPI instead of I2C. For the latter, a control byte that contains a D/C# field

[PATCH v4 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-13 Thread Javier Martinez Canillas
The Solomon SSD130x OLED displays can either have an I2C or SPI interface, add to the schema the properties and examples for OLED devices under SPI. Signed-off-by: Javier Martinez Canillas Acked-by: Mark Brown Reviewed-by: Geert Uytterhoeven --- Changes in v4: - Add a description for the dc-gp

[PATCH v4 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones.

2022-04-13 Thread Javier Martinez Canillas
The current compatible strings for SSD130x I2C controllers contain an "fb" and "-i2c" suffixes. These have been deprecated and more correct ones were added, that don't encode a subsystem or bus used to interface the devices. Signed-off-by: Javier Martinez Canillas Acked-by: Mark Brown Reviewed-b

[PATCH v4 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-13 Thread Javier Martinez Canillas
The current compatible strings for SSD130x I2C controllers contain both an "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver and also that are for devices that can be accessed over an I2C bus. But a DT is supposed to describe the hardware and not Linux implementation detai

[RFC] drm/kms: Stop registering multiple /sys/class/backlight devs for a single display

2022-04-13 Thread Hans de Goede
Hi All, As discussed in the "[RFC] drm/kms: control display brightness through drm_connector properties" thread, step 1 of the plan is to stop registering multiple /sys/class/backlight devs for a single display. On x86 there can be multiple firmware + direct-hw-access methods for controlling the

Re: [PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 06:06:01PM +0200, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 08:39:52AM -0300, Jason Gunthorpe wrote: > > I already looked into that for a while, it is a real mess too because > > of how the notifiers are used by the current drivers, eg gvt assumes > > the notifier i

[PATCH] drm/radeon: Add build directory to include path

2022-04-13 Thread Michel Dänzer
From: Michel Dänzer Fixes compile errors with out-of-tree builds, e.g. ../drivers/gpu/drm/radeon/r420.c:38:10: fatal error: r420_reg_safe.h: No such file or directory 38 | #include "r420_reg_safe.h" | ^ Signed-off-by: Michel Dänzer --- drivers/gpu/drm/radeon

[PATCH] drm/bochs: Explicitly include linux/module.h

2022-04-13 Thread Michel Dänzer
From: Michel Dänzer Instead of relying on it getting pulled in indirectly. Signed-off-by: Michel Dänzer --- drivers/gpu/drm/tiny/bochs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index ed971c8bb446..4f8bf86633df 100644 --- a

Re: [PATCH 2/2] fbdev: Remove hot-unplug workaround for framebuffers without device

2022-04-13 Thread Daniel Vetter
On Wed, Apr 13, 2022 at 12:50:50PM +0200, Javier Martinez Canillas wrote: > On 4/13/22 11:24, Thomas Zimmermann wrote: > > A workaround makes fbdev hot-unplugging work for framebuffers without > > device. The only user for this feature was offb. As each OF framebuffer > > now has an associated plat

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Jani Nikula
On Wed, 13 Apr 2022, Christoph Hellwig wrote: > On Wed, Apr 13, 2022 at 01:47:05PM +, Wang, Zhi A wrote: >> > the GVT code in the i915 is a bit of a mess right now due to strange >> > abstractions and lots of indirect calls. This series refactors various >> > bits to clean that up. The main

[PULL] drm-intel-next

2022-04-13 Thread Jani Nikula
Hi Dave & Daniel - The first drm/i915 pull for v5.19. BR, Jani. drm-intel-next-2022-04-13-1: drm/i915 feature pull for v5.19: Features and functionality: - Add support for new Tile 4 format on DG2 (Stan) - Add support for new CCS clear color compression on DG2 (Mika, Juha-Pekka) - Add suppor

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Nathan Chancellor
Hi Richard, On Tue, Apr 12, 2022 at 04:50:00PM -0500, Richard Gong wrote: > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > There are some AMD GFX cards (such as WX3200 and RX640) that won't work > with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards

Re: [PATCH] fbcon: Fix delayed takeover locking

2022-04-13 Thread Nathan Chancellor
On Wed, Apr 13, 2022 at 11:25:02AM +0200, Daniel Vetter wrote: > On Wed, Apr 13, 2022 at 10:21:28AM +0200, Daniel Vetter wrote: > > I messed up the delayed takover path in the locking conversion in > > 6e7da3af008b ("fbcon: Move console_lock for register/unlink/unregister"). > > > > Fix it by re-e

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 02:26:23PM +, Wang, Zhi A wrote: > On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > > On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > > > >> It seems Jani's makefile clean patch has already included this one, I can > >> just simply drop this one so that Chris

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 1:43 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > >> It seems Jani's makefile clean patch has already included this one, I can >> just simply drop this one so that Christoph won't need to re-send everything. >> >> For the branch to move on,

Re: [PATCH 3/4] dt-bindings: drm/bridge: anx7625: Change bus-type to 7 (DPI)

2022-04-13 Thread Robert Foss
On Sat, 9 Apr 2022 at 06:47, Xin Ji wrote: > > On Mon, Apr 04, 2022 at 12:52:14PM -0500, Rob Herring wrote: > > On Mon, Mar 28, 2022 at 08:09:54PM +0800, Xin Ji wrote: > > > Change bus-type define for DPI. > > > > > > Fixes: a43661e7e819 ("dt-bindings:drm/bridge:anx7625:add vendor define") > > > >

Re: [PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 08:11:05AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:36PM -0300, Jason Gunthorpe wrote: > > + if (WARN_ON(!READ_ONCE(vdev->open_count))) > > + return -EINVAL; > > I think all the WARN_ON()s in this patch need to be WARN_ON_ONCE, > otherwise

[PATCH] dt-bindings: display: panel-timing: Define a single type for properties

2022-04-13 Thread Rob Herring
It's not good practice to define multiple types for the same property, so factor out the type reference making the properties always an uint32-array with a length of 1 or 3 items. Signed-off-by: Rob Herring --- .../bindings/display/panel/panel-timing.yaml | 42 --- 1 file change

Re: refactor the i915 GVT support and move to the modern mdev API v3

2022-04-13 Thread Wang, Zhi A
On 4/11/22 2:13 PM, Christoph Hellwig wrote: > Hi all, > > the GVT code in the i915 is a bit of a mess right now due to strange > abstractions and lots of indirect calls. This series refactors various > bits to clean that up. The main user visible change is that almost all > of the GVT code move

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 01:39:35PM +, Wang, Zhi A wrote: > It seems Jani's makefile clean patch has already included this one, I can > just simply drop this one so that Christoph won't need to re-send everything. > > For the branch to move on, I am merging the patches and will re-generate the

Re: [PATCH 4/9] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 08:01:10AM +0200, Christoph Hellwig wrote: > On Tue, Apr 12, 2022 at 12:53:31PM -0300, Jason Gunthorpe wrote: > > Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no > > reason to use a group interface here, kvmgt has easy access to a > > vfio_device.

Re: [PATCH 05/34] drm/i915/gvt: cleanup the Makefile

2022-04-13 Thread Wang, Zhi A
On 4/13/22 12:33 PM, Jani Nikula wrote: > On Mon, 11 Apr 2022, Christoph Hellwig wrote: >> On Mon, Apr 11, 2022 at 07:11:03PM +0300, Jani Nikula wrote: Up to you but I usually sort these lists >>> >>> Yeah, please do. Otherwise matches what I sent, so ack. >> >> Let's just merge your 2 patch

Re: [PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()

2022-04-13 Thread Jason Gunthorpe
On Wed, Apr 13, 2022 at 08:00:08AM +0200, Christoph Hellwig wrote: > This looks good execept the extern nitpick: > > Reviewed-by: Christoph Hellwig > > However I'd move this before the previous patch. More of the explanation > there. Yes, that looks good, done Thanks, Jason

RE: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Limonciello, Mario
[Public] > On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel > wrote: > > > > Dear Richard, > > > > > > Thank you for sending out v4. > > > > Am 12.04.22 um 23:50 schrieb Richard Gong: > > > Active State Power Management (ASPM) feature is enabled since kernel > 5.14. > > > There are some AMD GFX card

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Alex Deucher
On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel wrote: > > Dear Richard, > > > Thank you for sending out v4. > > Am 12.04.22 um 23:50 schrieb Richard Gong: > > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > > There are some AMD GFX cards (such as WX3200 and RX640) that wo

Re: [PATCH 1/2] of: Create platform devices for OF framebuffers

2022-04-13 Thread Rob Herring
On Wed, Apr 13, 2022 at 4:24 AM Thomas Zimmermann wrote: > > Create a platform device for each OF-declared framebuffer and have > offb bind to these devices. Allows for real hot-unplugging and other > drivers besides offb. > > Originally, offb created framebuffer devices while initializing its > m

  1   2   >