Re: [PATCH v6 resend 5/5] phy: freescale: phy-fsl-imx8-mipi-dphy: Add i.MX8qxp LVDS PHY mode support

2022-04-12 Thread Vinod Koul
On 02-04-22, 13:24, Liu Ying wrote: > i.MX8qxp SoC embeds a Mixel MIPI DPHY + LVDS PHY combo which supports > either a MIPI DSI display or a LVDS display. The PHY mode is controlled > by SCU firmware and the driver would call a SCU firmware function to > configure the PHY mode. The single LVDS PH

Re: [PATCH v6 resend 2/5] phy: Add LVDS configuration options

2022-04-12 Thread Vinod Koul
On 02-04-22, 13:24, Liu Ying wrote: > This patch allows LVDS PHYs to be configured through > the generic functions and through a custom structure > added to the generic union. > > The parameters added here are based on common LVDS PHY > implementation practices. The set of parameters > should cov

Re: [PATCH v18 03/10] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2022-04-12 Thread Dan Carpenter
Hi "jason-jh.lin", url: https://github.com/intel-lab-lkp/linux/commits/jason-jh-lin/Add-Mediatek-Soc-DRM-vdosys0-support-for-mt8195/20220412-183359 base: git://anongit.freedesktop.org/drm/drm drm-next config: arc-randconfig-m031-20220411 (https://download.01.org/0day-ci/archiv

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/13/22 01:59, Erico Nunes wrote: > On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky > wrote: >> >> >> On 2022-04-12 14:20, Dmitry Osipenko wrote: >>> On 4/12/22 19:51, Andrey Grodzovsky wrote: On 2022-04-11 18:15, Dmitry Osipenko wrote: > Interrupt context can't sleep. Drivers like P

[PULL] drm-intel-fixes

2022-04-12 Thread Joonas Lahtinen
Hi Dave & Daniel, Just one fix towards v5.18-rc3. Fix to align code with drm-tip to make sure full graphics IP version is used for legacy mmap disable check. Regards, Joonas *** drm-intel-fixes-2022-04-13: - Correct legacy mmap disabling to use GRAPHICS_VER_FULL The following changes since c

Re: [PATCH] drm/tidss: Soft Reset DISPC on startup

2022-04-12 Thread Tony Lindgren
* Nishanth Menon [220412 21:18]: > On 17:24-20220412, Tomi Valkeinen wrote: > > Hi, > > > > On 14/03/2022 13:37, Devarsh Thakkar wrote: > > > Soft reset the display subsystem controller on startup and wait for > > > the reset to complete. This helps the s

Re: [PATCH v2] drm/gma500: fix a potential repeat execution in psb_driver_load

2022-04-12 Thread Xiaomeng Tong
On Tue, 12 Apr 2022 16:58:24 +0200, Patrik Jakobsson wrote: > Hi, > This would work but using gotos like this easily turns the code into > spaghetti. See "7. Centralized exiting of functions" in > Documentation/process/coding-style.rst for when to use gotos. > > In this particular case I think we

[PATCH v3] drm/gma500: fix a potential repeat execution in psb_driver_load

2022-04-12 Thread Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the list_for_each_entry() continues until the traversal is complete. To avoid potential executing 'ret = gma_backlight_init(dev);' repeatly, goto outside the loop when found entry by replacing switch/case with if statement. Signed-off

Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-12 Thread Lazar, Lijo
On 4/13/2022 3:20 AM, Richard Gong wrote: Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as video/display output, Intel Al

Re: [PATCH v2 1/2] drm/panel: lvds: Simplify mode parsing

2022-04-12 Thread Marek Vasut
On 4/7/22 13:16, Laurent Pinchart wrote: Hi Marek, Thank you for the patch. On Fri, Apr 01, 2022 at 06:21:53PM +0200, Marek Vasut wrote: The mode parsing is currently implemented in three steps: of_get_display_timing() - DT panel-timing to struct display_timing videomode_from_timing() - struct

Re: [PATCH] drm: bridge: icn6211: Convert to regmap

2022-04-12 Thread Marek Vasut
On 4/7/22 13:38, Mark Brown wrote: On Sun, Apr 03, 2022 at 07:10:04PM +0200, Marek Vasut wrote: To make debugging easier, convert driver to regmap. Implement read and write regmap tables for known registers, keep all known register readable and mark those which are obviously read-only as not wri

Re: linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 10:34:05 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the amdgpu tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c > > between commit: > > fee2ede15542 ("drm/ttm: rework bulk move handling v5") > > from the drm-misc tree and co

Re: linux-next: build warnings after merge of the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 15:44:31 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) htmldocs > produced these warnings: > > drivers/gpu/drm/drm_edid.c:1589: warn

Re: linux-next: build warning after merge of the drm-misc tree

2022-04-12 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 15:50:30 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (htmldocs) > produced this warning: > > include/drm/ttm/ttm_resource.h:226: warning: Function parameter or member > 'pos' not described in 'ttm_lru_bulk_move' > > In

Re: [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks

2022-04-12 Thread Abhinav Kumar
Hi Daniel On 4/8/2022 9:04 PM, Abhinav Kumar wrote: On 4/7/2022 4:12 PM, Rob Clark wrote: On Thu, Apr 7, 2022 at 3:59 PM Abhinav Kumar wrote: Hi Rob and Daniel On 4/7/2022 3:51 PM, Rob Clark wrote: On Wed, Apr 6, 2022 at 6:27 PM Jessica Zhang wrote: On 3/31/2022 8:20 AM, Daniel Vett

Re: [PATCH 3/6] drm/sun4i: sun8i-hdmi-phy: Used device-managed clocks/resets

2022-04-12 Thread Samuel Holland
On 4/12/22 8:23 AM, Maxime Ripard wrote: > Hi, > > On Mon, Apr 11, 2022 at 11:35:08PM -0500, Samuel Holland wrote: >> Now that the HDMI PHY is using a platform driver, it can use device- >> managed resources. Use these, as well as the dev_err_probe helper, to >> simplify the probe function and get

[PATCH 1/1] drm/i915/guc: Update to GuC version 70.1.1

2022-04-12 Thread John . C . Harrison
From: John Harrison The latest GuC firmware drops the context descriptor pool in favour of passing all creation data in the create H2G. It also greatly simplifies the work queue and removes the process descriptor used for multi-LRC submission. So, remove all mention of LRC and process descriptors

[PATCH 0/1] Update to GuC v70

2022-04-12 Thread John . C . Harrison
From: John Harrison Update to the latest GuC firmware release. Note that this includes some significant backwards breaking API changes. One is about context registration - the descriptor pool is gone, all parameters are passed via the CTB instead. The second is about scheduling policy updates -

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Erico Nunes
On Tue, Apr 12, 2022 at 9:41 PM Andrey Grodzovsky wrote: > > > On 2022-04-12 14:20, Dmitry Osipenko wrote: > > On 4/12/22 19:51, Andrey Grodzovsky wrote: > >> On 2022-04-11 18:15, Dmitry Osipenko wrote: > >>> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking > >>> mutex when

[PATCH] drm/i915/guc/slpc: Use i915_probe_error instead of drm_err

2022-04-12 Thread Vinay Belgaumkar
This will ensure we don't have false positives when we run error injection tests. Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 42 ++--- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.

[PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-12 Thread Richard Gong
Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as video/display output, Intel Alder Lake based systems will hang during suspend

[PATCH v2] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-12 Thread Chia-I Wu
In practice, trace_dma_fence_init called from dma_fence_init is good enough and almost no driver calls trace_dma_fence_emit. But drm_sched and virtio both have cases where trace_dma_fence_init and trace_dma_fence_emit can be apart. It is easier for visualization tools to always use the more corre

Re: [Bug 215807] Bad page state in process systemd-udevd

2022-04-12 Thread Matthew Wilcox
On Tue, Apr 12, 2022 at 02:08:04PM -0700, Andrew Morton wrote: > hm, that's my third `bad page' report in three emails. But I'm not > seeing a pattern - this one might be a DRM thing. I noticed it was an order-9 page and was set to take responsibility for it, but it's clearly not a filesystem pag

Re: [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles

2022-04-12 Thread Rob Herring
On Mon, Apr 11, 2022 at 11:27:54PM -0500, Samuel Holland wrote: > Allwinner D1 contains a display engine 2.0. It features two mixers, a > TCON TOP (with DSI and HDMI), one TCON LCD, and one TCON TV. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Samuel Holland > --- > > (no changes since

Re: [Bug 215807] Bad page state in process systemd-udevd

2022-04-12 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). hm, that's my third `bad page' report in three emails. But I'm not seeing a pattern - this one might be a DRM thing. On Tue, 12 Apr 2022 20:52:18 + bugzilla-dae...@kernel.org wrote: > https://

Re: [PATCH 34/34] vfio/mdev: Remove mdev drvdata

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe This is no longer used, remove it. All usages were moved over to either use container_of() from a vfio_device or to use dev_drvdata() directly on the mdev. Signed-off-by: Jason Gunthorpe Signed-off-by: Christoph Hellwig

Re: [PATCH 33/34] vfio/mdev: Use the driver core to create the 'remove' file

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe The device creator is supposed to use the dev.groups value to add sysfs files before device_add is called, not call sysfs_create_files() after device_add() returns. This creates a race with uevent delivery where the extra a

Re: [PATCH 32/34] vfio/mdev: Remove mdev_parent_ops

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe The last useful member in this struct is the supported_type_groups, move it to the mdev_driver and delete mdev_parent_ops. Replace it with mdev_driver as an argument to mdev_register_device() Signed-off-by: Jason Gunthorp

Re: [PATCH 31/34] vfio/mdev: Remove mdev_parent_ops dev_attr_groups

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:44 PM, Christoph Hellwig wrote: From: Jason Gunthorpe This is only used by one sample to print a fixed string that is pointless. In general, having a device driver attach sysfs attributes to the parent is horrific. This should never happen, and always leads to some kind of li

Re: [PATCH 30/34] vfio/mdev: Remove vfio_mdev.c

2022-04-12 Thread Kirti Wankhede
On 4/11/2022 7:43 PM, Christoph Hellwig wrote: From: Jason Gunthorpe Now that all mdev drivers directly create their own mdev_device driver and directly register with the vfio core's vfio_device_ops this is all dead code. Delete vfio_mdev.c and the mdev_parent_ops members that are connected

[PATCH v2 2/2] drm/sched: use __string in tracepoints

2022-04-12 Thread Chia-I Wu
Otherwise, ring names are marked [UNSAFE-MEMORY]. Signed-off-by: Chia-I Wu Cc: Rob Clark Reviewed-by: Andrey Grodzovsky --- drivers/gpu/drm/scheduler/gpu_scheduler_trace.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_t

[PATCH v2 1/2] drm/sched: use DECLARE_EVENT_CLASS

2022-04-12 Thread Chia-I Wu
drm_sched_job and drm_run_job have the same prototype. v2: rename the class from drm_sched_job_entity to drm_sched_job (Andrey) Signed-off-by: Chia-I Wu Cc: Rob Clark Reviewed-by: Andrey Grodzovsky --- .../gpu/drm/scheduler/gpu_scheduler_trace.h | 31 +-- 1 file changed, 7 i

Re: [PATCH] video: fbdev-MMP: replace usage of found with dedicated list iterator variable

2022-04-12 Thread Helge Deller
On 4/1/22 00:35, Jakob Koschel wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a se

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/12/22 22:40, Andrey Grodzovsky wrote: > > On 2022-04-12 14:20, Dmitry Osipenko wrote: >> On 4/12/22 19:51, Andrey Grodzovsky wrote: >>> On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Andrey Grodzovsky
On 2022-04-12 14:20, Dmitry Osipenko wrote: On 4/12/22 19:51, Andrey Grodzovsky wrote: On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and thus, that code can sleep. This results into "BUG: schedul

Re: [PATCH] drm/msm: add trace_dma_fence_emit to msm_gpu_submit

2022-04-12 Thread Rob Clark
On Sat, Apr 9, 2022 at 7:33 AM Christian König wrote: > > Am 08.04.22 um 23:12 schrieb Chia-I Wu: > > In practice, trace_dma_fence_init is good enough and almost no driver > > calls trace_dma_fence_emit. But this is still more correct in theory. > > Well, the reason why basically no driver is cal

[PATCH v3 5/5] drm/i915: stolen memory use ttm backend

2022-04-12 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

[PATCH v3 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-12 Thread Robert Beckett
stolen regions are not page backed or considered iomem. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_mo

[PATCH v3 3/5] drm/i915: ttm move/clear logic fix

2022-04-12 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[PATCH v3 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-12 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH v3 0/5] drm/i915: ttm for stolen region

2022-04-12 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. v3: rebase to latest drm-tip. fix v2 code

[PATCH v3 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-12 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++- 2 files changed, 27 insertio

[linux-next:master] BUILD REGRESSION d0c745e7b2d6ce8bcc768b32361ab8ef520821ee

2022-04-12 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: d0c745e7b2d6ce8bcc768b32361ab8ef520821ee Add linux-next specific files for 20220412 Error/Warning reports: https://lore.kernel.org/linux-mm/202203160358.yulpl6b4-...@intel.com https

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Dmitry Osipenko
On 4/12/22 19:51, Andrey Grodzovsky wrote: > > On 2022-04-11 18:15, Dmitry Osipenko wrote: >> Interrupt context can't sleep. Drivers like Panfrost and MSM are taking >> mutex when job is released, and thus, that code can sleep. This results >> into "BUG: scheduling while atomic" if locks are conte

Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-12 Thread Rob Herring
On Tue, Apr 12, 2022 at 10:12:32AM +0200, Javier Martinez Canillas wrote: > On 4/12/22 10:07, Geert Uytterhoeven wrote: > > Hi Javier, > > [snip] > > >> > >> Do you have any hints here on how I should enforce this in the schema ? > >> > >> Or if you think that a comment is enough, then I will add

Re: [PATCH] dma-buf-map: remove renamed header file

2022-04-12 Thread Thomas Zimmermann
Am 11.04.22 um 15:44 schrieb Karol Herbst: commit 7938f4218168 ("dma-buf-map: Rename to iosys-map") already renamed this file, but it got brought back by a merge. Delete it for real this time. Fixes: 30424ebae8df ("Merge tag 'drm-intel-gt-next-2022-02-17' of git://anongit.freedesktop.org/drm

Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context

2022-04-12 Thread Andrey Grodzovsky
On 2022-04-11 18:15, Dmitry Osipenko wrote: Interrupt context can't sleep. Drivers like Panfrost and MSM are taking mutex when job is released, and thus, that code can sleep. This results into "BUG: scheduling while atomic" if locks are contented while job is freed. There is no good reason for

[PATCH v3 5/5] drm/solomon: Add SSD130x OLED displays SPI support

2022-04-12 Thread Javier Martinez Canillas
The ssd130x driver only provides the core support for these devices but it does not have any bus transport logic. Add a driver to interface over SPI. There is a difference in the communication protocol when using 4-wire SPI instead of I2C. For the latter, a control byte that contains a D/C# field

[PATCH v3 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-12 Thread Javier Martinez Canillas
These are declared in the ssd130x-i2c transport driver but the information is not I2C specific, and could be used by other SSD130x transport drivers. Move them to the ssd130x core driver and just set the OF device entries to an ID that could be used to lookup the correct device info from an array.

[PATCH v3 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones.

2022-04-12 Thread Javier Martinez Canillas
The current compatible strings for SSD130x I2C controllers contain an "fb" and "-i2c" suffixes. These have been deprecated and more correct ones were added, that don't encode a subsystem or bus used to interface the devices. Signed-off-by: Javier Martinez Canillas Acked-by: Mark Brown Reviewed-b

[PATCH v3 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers

2022-04-12 Thread Javier Martinez Canillas
The Solomon SSD130x OLED displays can either have an I2C or SPI interface, add to the schema the properties and examples for OLED devices under SPI. Signed-off-by: Javier Martinez Canillas Acked-by: Mark Brown Reviewed-by: Geert Uytterhoeven --- Changes in v3: - Add a comment to the properties

[PATCH v3 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-12 Thread Javier Martinez Canillas
The current compatible strings for SSD130x I2C controllers contain both an "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver and also that are for devices that can be accessed over an I2C bus. But a DT is supposed to describe the hardware and not Linux implementation detai

[PATCH v3 0/5] drm/solomon: Add SSD130x OLED displays SPI support

2022-04-12 Thread Javier Martinez Canillas
Hello, This series adds a ssd130x-spi driver that provides a 4-wire SPI transport support for SSD130x OLED controllers that can be accessed over a SPI bus. The driver is quite similar to existing ssd130x-i2c driver that is used by I2C controllers, but there is a difference in the protocol used by

[PATCH 0/9] Make the rest of the VFIO driver interface use vfio_device

2022-04-12 Thread Jason Gunthorpe
Prior series have transformed other parts of VFIO from working on struct device or struct vfio_group into working directly on struct vfio_device. Based on that work we now have vfio_device's readily available in all the drivers. Update the rest of the driver facing API to use vfio_device as an inp

[PATCH 8/9] vfio: Remove dead code

2022-04-12 Thread Jason Gunthorpe
Now that callers have been updated to use the vfio_device APIs the driver facing group interface is no longer used, delete it: - vfio_group_get_external_user_from_dev() - vfio_group_pin_pages() - vfio_group_unpin_pages() - vfio_group_iommu_domain() Signed-off-by: Jason Gunthorpe --- drivers/vfi

[PATCH 4/9] drm/i915/gvt: Change from vfio_group_(un)pin_pages to vfio_(un)pin_pages

2022-04-12 Thread Jason Gunthorpe
Use the existing vfio_device versions of vfio_(un)pin_pages(). There is no reason to use a group interface here, kvmgt has easy access to a vfio_device. Signed-off-by: Jason Gunthorpe --- drivers/gpu/drm/i915/gvt/kvmgt.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a

[PATCH 6/9] drm/i915/gvt: Add missing module_put() in error unwind

2022-04-12 Thread Jason Gunthorpe
try_module_get() must be undone if kvmgt_guest_init() fails or we leak the module reference count on the failure path since the close_device op is never called in this case. Fixes: 9bdb073464d6 ("drm/i915/gvt: Change KVMGT as self load module") Signed-off-by: Jason Gunthorpe --- drivers/gpu/drm/

[PATCH 9/9] vfio: Remove calls to vfio_group_add_container_user()

2022-04-12 Thread Jason Gunthorpe
When the open_device() op is called the container_users is incremented and held incremented until close_device(). Thus, so long as drivers call functions within their open_device()/close_device() region they do not need to worry about the container_users. These functions can all only be called bet

[PATCH 2/9] vfio/ccw: Remove mdev from struct channel_program

2022-04-12 Thread Jason Gunthorpe
The next patch wants the vfio_device instead. There is no reason to store a pointer here since we can container_of back to the vfio_device. Signed-off-by: Jason Gunthorpe --- drivers/s390/cio/vfio_ccw_cp.c | 44 +++-- drivers/s390/cio/vfio_ccw_cp.h | 4 +-- drivers

[PATCH 7/9] drm/i915/gvt: Delete kvmgt_vdev::vfio_group

2022-04-12 Thread Jason Gunthorpe
Nothing references this struct member any more, delete it completely. Signed-off-by: Jason Gunthorpe --- drivers/gpu/drm/i915/gvt/kvmgt.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c inde

[PATCH 5/9] vfio: Pass in a struct vfio_device * to vfio_dma_rw()

2022-04-12 Thread Jason Gunthorpe
Every caller has a readily available vfio_device pointer, use that instead of passing in a generic struct device. The struct vfio_device already contains the group we need so this avoids complexity, extra refcountings, and a confusing lifecycle model. Signed-off-by: Jason Gunthorpe --- drivers/g

[PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

2022-04-12 Thread Jason Gunthorpe
Every caller has a readily available vfio_device pointer, use that instead of passing in a generic struct device. The struct vfio_device already contains the group we need so this avoids complexity, extra refcountings, and a confusing lifecycle model. Signed-off-by: Jason Gunthorpe --- .../drive

[PATCH 1/9] vfio: Make vfio_(un)register_notifier accept a vfio_device

2022-04-12 Thread Jason Gunthorpe
All callers have a struct vfio_device trivially available, pass it in directly and avoid calling the expensive vfio_group_get_from_dev(). To support the unconverted kvmgt mdev driver add mdev_legacy_get_vfio_device() which will return the vfio_device pointer vfio_mdev.c puts in the drv_data. Sign

Re: [PATCHv3] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-12 Thread Alex Deucher
On Tue, Apr 12, 2022 at 10:59 AM Richard Gong wrote: > > Active State Power Management (ASPM) feature is enabled since kernel 5.14. > There are some AMD GFX cards (such as WX3200 and RX640) that won't work > with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as > video/display

Re: AMD Display Core (DC) patches (was: [PATCH 13/16] drm/amd/display: Revert FEC check in validation)

2022-04-12 Thread Alex Deucher
On Tue, Apr 12, 2022 at 2:52 AM Paul Menzel wrote: > > [Cc: +dri-devel@lists.freedesktop.org, +Daniel Vetter, +Alexander > Deucher, +Greg KH] > > > Dear Alex, > > > I am a little confused and upset about how Display Core patches are > handled in the Linux kernel. > > > Am 25.03.22 um 23:53 schrieb

[PATCH 4.19 2/2] drm/amdgpu: Ensure the AMDGPU file descriptor is legitimate

2022-04-12 Thread Lee Jones
[ Upstream commit b40a6ab2cf9213923bf8e821ce7fa7f6a0a26990 ] This is a partial cherry-pick of the above upstream commit. It ensures the file descriptor passed in by userspace is a valid one. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd

[PATCH 4.19 1/2] drm/amdgpu: Check if fd really is an amdgpu fd.

2022-04-12 Thread Lee Jones
From: Bas Nieuwenhuizen [ Upstream commit 021830d24ba55a578f602979274965344c8e6284 ] Otherwise we interpret the file private data as drm & amdgpu data while it might not be, possibly allowing one to get memory corruption. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: David Ai

[PATCH 5.10 1/1] drm/amdgpu: Ensure the AMDGPU file descriptor is legitimate

2022-04-12 Thread Lee Jones
[ Upstream commit b40a6ab2cf9213923bf8e821ce7fa7f6a0a26990 ] This is a partial cherry-pick of the above upstream commit. It ensures the file descriptor passed in by userspace is a valid one. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd

[PATCH v2 5/5] drm/i915: stolen memory use ttm backend

2022-04-12 Thread Robert Beckett
refactor stolen memory region to use ttm. this necessitates using ttm resources to track reserved stolen regions instead of drm_mm_nodes. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/display/intel_fbc.c | 78 ++-- .../gpu/drm/i915/gem/i915_gem_object_types.h | 2 - drivers/gpu

[PATCH v2 4/5] drm/i915: ttm backend dont provide mmap_offset for kernel buffers

2022-04-12 Thread Robert Beckett
stolen/kernel buffers should not be mmapable by userland. do not provide callbacks to facilitate this for these buffers. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 32 + 1 file changed, 27 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH v2 3/5] drm/i915: ttm move/clear logic fix

2022-04-12 Thread Robert Beckett
ttm managed buffers start off with system resource definitions and ttm_tt tracking structures allocated (though unpopulated). currently this prevents clearing of buffers on first move to desired placements. The desired behaviour is to clear user allocated buffers and any kernel buffers that specif

[PATCH v2 1/5] drm/i915: instantiate ttm ranger manager for stolen memory

2022-04-12 Thread Robert Beckett
prepare for ttm based stolen region by using ttm range manager as the resource manager for stolen region. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 6 ++-- drivers/gpu/drm/i915/intel_region_ttm.c | 31 +++- 2 files changed, 27 insertio

[PATCH v2 2/5] drm/i915: sanitize mem_flags for stolen buffers

2022-04-12 Thread Robert Beckett
stolen regions are not page backed or considered iomem. Signed-off-by: Robert Beckett --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_mo

[PATCH v2 0/5] drm/i915: ttm for stolen region

2022-04-12 Thread Robert Beckett
This series refactors i915's stolen memory region to use ttm. v2: handle disabled stolen similar to legacy version. relying on ttm to fail allocs works fine, but is dmesg noisy and causes testing dmesg warning regressions. Robert Beckett (5): drm/i915: instantiate ttm range

[PATCHv3] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-12 Thread Richard Gong
Active State Power Management (ASPM) feature is enabled since kernel 5.14. There are some AMD GFX cards (such as WX3200 and RX640) that won't work with ASPM-enabled Intel Alder Lake based systems. Using these GFX cards as video/display output, Intel Alder Lake based systems will hang during suspend

Re: [PATCH v2] drm/gma500: fix a potential repeat execution in psb_driver_load

2022-04-12 Thread Patrik Jakobsson
On Wed, Apr 6, 2022 at 1:31 PM Xiaomeng Tong wrote: > > Instead of exiting the loop as expected when an entry is found, the > list_for_each_entry() continues until the traversal is complete. To > avoid potential executing 'ret = gma_backlight_init(dev);' repeatly, > goto outside the loop when the

Re: [PATCH v8, 00/15] media: mtk-vcodec: support for M8192 decoder

2022-04-12 Thread Nicolas Dufresne
Le lundi 11 avril 2022 à 11:41 +0800, yunfei.d...@mediatek.com a écrit : > Hi Nicolas, > > On Thu, 2022-03-31 at 16:48 -0400, Nicolas Dufresne wrote: > > Hi Yunfei, > > > > thanks for the update, I should be testing this really soon. > > > > Le jeudi 31 mars 2022 à 10:47 +0800, Yunfei Dong a écr

Re: [PATCH] drm/tidss: Soft Reset DISPC on startup

2022-04-12 Thread Tomi Valkeinen
Hi, On 14/03/2022 13:37, Devarsh Thakkar wrote: Soft reset the display subsystem controller on startup and wait for the reset to complete. This helps the scenario where display was already in use by some other core before the linux was booted. The reason the omapdrm doesn't do a reset is that

Re: [PATCH] drm/gma500: add comments to register definitions

2022-04-12 Thread Patrik Jakobsson
On Tue, Apr 12, 2022 at 3:42 AM James Hilliard wrote: > > Extracted from various sources such EMGD releases. > > Signed-off-by: James Hilliard Hi James, These registers are documented in the Intel 965/G35 and G45 documentation [1]. I don't see a clear benefit of duplicating the names of the regi

Re: [PATCH v5 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:29PM +, Sean Paul wrote: > From: Sean Paul > > Rebased set from November. Fixed a nit from Stephen in the msm patch and > moved hdcp registers into the trogdor dtsi file to avoid differences > with sc7180-based windows devices. The set is 4 patches lighter since

Re: [PATCH v5 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:34PM +, Sean Paul wrote: > From: Sean Paul > > Stick all of the setup for HDCP into a dedicated function. No functional > change, but this will facilitate moving HDCP logic into helpers. Reviewed-by: Rodrigo Vivi > > Acked-by: Jani Nikula > Signed-off-by:

Re: [PATCH v5 06/10] drm/i915/hdcp: Retain hdcp_capable return codes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:35PM +, Sean Paul wrote: > From: Sean Paul > > The shim functions return error codes, but they are discarded in > intel_hdcp.c. This patch plumbs the return codes through so they are > properly handled. Reviewed-by: Rodrigo Vivi > > Acked-by: Jani Nikula > S

Re: [PATCH v5 03/10] drm/hdcp: Update property value on content type and user changes

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:32PM +, Sean Paul wrote: > From: Sean Paul > > This patch updates the connector's property value in 2 cases which were > previously missed: > > 1- Content type changes. The value should revert back to DESIRED from >ENABLED in case the driver must re-authenti

Re: [PATCH 3/6] drm/sun4i: sun8i-hdmi-phy: Used device-managed clocks/resets

2022-04-12 Thread Maxime Ripard
Hi, On Mon, Apr 11, 2022 at 11:35:08PM -0500, Samuel Holland wrote: > Now that the HDMI PHY is using a platform driver, it can use device- > managed resources. Use these, as well as the dev_err_probe helper, to > simplify the probe function and get rid of the remove function. > > Signed-off-by: S

Re: [PATCH v5 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:31PM +, Sean Paul wrote: > From: Sean Paul > > Instead of forcing a modeset in the hdcp atomic check, simply return > true if the content protection value is changing and let the driver > decide whether a modeset is required or not. > > Acked-by: Jani Nikula >

Re: [PATCH v5 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2022-04-12 Thread Rodrigo Vivi
On Mon, Apr 11, 2022 at 08:47:30PM +, Sean Paul wrote: > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the > code when moving it over. Reviewed-by: Rodrigo Vivi > > Acked-by:

Re: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-12 Thread Javier Martinez Canillas
Hello Chen-Yu, On 4/12/22 14:07, Chen-Yu Tsai wrote: > On Tue, Apr 12, 2022 at 5:12 AM Javier Martinez Canillas > wrote: [snip] > > I think you can just drop this one, since it was just merged and isn't > part of any release yet. It's not even in -rc. > I believe you are correct and we could

Re: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-12 Thread Javier Martinez Canillas
Hello Maxime, On 4/12/22 13:28, Maxime Ripard wrote: > On Mon, Apr 11, 2022 at 11:12:39PM +0200, Javier Martinez Canillas wrote: [snip] >> >>reg: >> maxItems: 1 >> @@ -136,7 +147,7 @@ allOf: >>properties: >> compatible: >>contains: >> -const: s

Re: [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-12 Thread Javier Martinez Canillas
On 4/12/22 13:22, Andy Shevchenko wrote: > On Tue, Apr 12, 2022 at 02:21:08PM +0300, Andy Shevchenko wrote: >> On Tue, Apr 12, 2022 at 10:07:02AM +0200, Javier Martinez Canillas wrote: >>> On 4/12/22 09:23, Geert Uytterhoeven wrote: On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas >>>

Re: [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-12 Thread Javier Martinez Canillas
Hello Andy, Thanks for your feedback. On 4/12/22 13:21, Andy Shevchenko wrote: > On Tue, Apr 12, 2022 at 10:07:02AM +0200, Javier Martinez Canillas wrote: >> On 4/12/22 09:23, Geert Uytterhoeven wrote: >>> On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas >>> wrote: > > ... > -

Re: [PATCH v6 0/6] drm: exynos: dsi: Convert drm bridge

2022-04-12 Thread Marek Szyprowski
Dear All, On 07.04.2022 13:24, Marek Szyprowski wrote: > On 31.03.2022 16:22, Robert Foss wrote: >> On Fri, 25 Mar 2022 at 17:04, Adam Ford wrote: >>> On Fri, Mar 25, 2022 at 10:00 AM Marek Szyprowski >>> wrote: On 03.03.2022 17:36, Jagan Teki wrote: > Updated series about drm bridge co

Re: [PATCH] drm/ttm: stop passing NULL fence in ttm_bo_move_sync_cleanup

2022-04-12 Thread Matthew Auld
On 11/04/2022 13:39, Christian König wrote: Am 11.04.22 um 10:56 schrieb Matthew Auld: If we hit the sync case, like when skipping clearing for kernel internal objects, or when falling back to cpu clearing, like in i915, we end up trying to add a NULL fence, but with some recent changes in this

Re: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-12 Thread Chen-Yu Tsai
On Tue, Apr 12, 2022 at 5:12 AM Javier Martinez Canillas wrote: > > The current compatible strings for SSD130x I2C controllers contain both an > "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver > and also that are for devices that can be accessed over an I2C bus. > > But

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-12 Thread Daniel Stone
On Tue, 12 Apr 2022 at 11:14, Piotr Oniszczuk wrote: > > Wiadomość napisana przez Lucas Stach w dniu > > 12.04.2022, o godz. 10:10: > > 1. The application feeds a wrong modifier list to the GBM > > implementation, as it may have queried another plane in the assumption > > that supported modifier

Re: [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings

2022-04-12 Thread Maxime Ripard
On Mon, Apr 11, 2022 at 11:12:39PM +0200, Javier Martinez Canillas wrote: > The current compatible strings for SSD130x I2C controllers contain both an > "fb" and "-i2c" suffixes. It seems to indicate that are for a fbdev driver > and also that are for devices that can be accessed over an I2C bus. >

Re: [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-12 Thread Andy Shevchenko
On Tue, Apr 12, 2022 at 02:21:08PM +0300, Andy Shevchenko wrote: > On Tue, Apr 12, 2022 at 10:07:02AM +0200, Javier Martinez Canillas wrote: > > On 4/12/22 09:23, Geert Uytterhoeven wrote: > > > On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas > > > wrote: ... > > >> - ssd130x->de

Re: [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver

2022-04-12 Thread Andy Shevchenko
On Tue, Apr 12, 2022 at 10:07:02AM +0200, Javier Martinez Canillas wrote: > On 4/12/22 09:23, Geert Uytterhoeven wrote: > > On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas > > wrote: ... > >> - ssd130x->device_info = device_get_match_data(dev); > >> + > >> + variant = (enum

RE: [PATCH v2 1/7] dt-bindings: display: renesas,du: Document r9a07g044l bindings

2022-04-12 Thread Biju Das
Hi Geert, Thanks for the feedback > Subject: Re: [PATCH v2 1/7] dt-bindings: display: renesas,du: Document > r9a07g044l bindings > > Hi Biju, > > On Wed, Mar 16, 2022 at 2:11 PM Biju Das > wrote: > > Extend the Renesas DU display bindings to support the r9a07g044l DU > > module found on RZ/G2L

Re: [PATCH] dma-buf-map: remove renamed header file

2022-04-12 Thread Michel Dänzer
On 2022-04-11 15:44, Karol Herbst wrote: > commit 7938f4218168 ("dma-buf-map: Rename to iosys-map") already renamed > this file, but it got brought back by a merge. > > Delete it for real this time. > > Fixes: 30424ebae8df ("Merge tag 'drm-intel-gt-next-2022-02-17' of > git://anongit.freedesktop

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-12 Thread Piotr Oniszczuk
> Wiadomość napisana przez Lucas Stach w dniu > 12.04.2022, o godz. 10:10: > > This could be both a Mesa/Panfrost or application issue. The > application is supposed to try to allocate with a arbitrary chosen > format and the valid modifiers queried from the plane it wants to put > the surfac

  1   2   >