Re: [PATCH v6 14/14] drm/msm/dsi: Add support for DSC configuration

2022-04-05 Thread Vinod Koul
On 06-04-22, 02:42, Dmitry Baryshkov wrote: > On 04/04/2022 19:34, Vinod Koul wrote: > > When DSC is enabled, we need to configure DSI registers accordingly and > > configure the respective stream compression registers. > > > > Add support to calculate the register setting based on DSC params and

Re: linux-next: build warnings after merge of the drm-misc tree

2022-04-05 Thread Stephen Rothwell
Hi all, On Wed, 6 Apr 2022 15:44:31 +1000 Stephen Rothwell wrote: > > After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) This was an "htmldocs" build. -- Cheers, Stephen Rothwell pgp39xz7JeYg4.pgp Description: OpenPGP digital signature

linux-next: build warning after merge of the drm-misc tree

2022-04-05 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (htmldocs) produced this warning: include/drm/ttm/ttm_resource.h:226: warning: Function parameter or member 'pos' not described in 'ttm_lru_bulk_move' Introduced by commit b0e2c9ea5afc ("drm/ttm: allow bulk moves for all domai

linux-next: build warnings after merge of the drm-misc tree

2022-04-05 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (KCONFIG_NAME) produced these warnings: drivers/gpu/drm/drm_edid.c:1589: warning: Function parameter or member '_edid' not described in 'drm_edid_header_is_valid' drivers/gpu/drm/drm_edid.c:1589: warning: Excess function parameter

Re: [PATCH 3/3] drm/msm: don't store created planes, connectors and encoders

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:50:59) > diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/gpu/drm/msm/msm_drv.h > index d661debb50f1..ee3093890d97 100644 > --- a/drivers/gpu/drm/msm/msm_drv.h > +++ b/drivers/gpu/drm/msm/msm_drv.h > @@ -184,23 +184,14 @@ struct msm_drm_private { > >

Re: [PATCH 2/3] drm/msm: loop over encoders using drm_for_each_encoder()

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:50:58) > Rather than manually looping over encoders array, use standard > drm_for_each_encoder() macro. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/3] drm/msm/dpu: remove manual destruction of DRM objects

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:50:57) > Remove manual removal of DRM modesetting objects, it is done anyway by > the drm_mode_config_cleanup() called from msm_drm_uninit(). Other > MSM display drivers (MDP4, MDP5) do not manually destroy objects and > trust generic code to do it's work. >

Re: [PATCH 1/4] drm/msm/hdmi: properly add and remove created bridges

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:45:48) > Add calls to drm_bridge_add()/drm_bridge_remove() for the internal HDMI > bridges. This fixes the following warning. > > [2.195003] [ cut here ] Usually this line is left out > [2.195044] WARNING: CPU: 0 PID: 1 at ke

Re: [PATCH v1 8/8] ARM: dts: imx6qdl-victgo: add CAN termination support

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:12AM +0100, Oleksij Rempel wrote: > From: David Jander > > The gpio1 0 pin is controlling CAN termination, not USB H1 VBUS. So, > remove wrong regulator and assign this gpio to new DT CAN termination > property. > > Signed-off-by: David Jander > Signed-off-by: Olek

Re: [PATCH v1 7/8] ARM: dts: imx6dl-victgo: The TGO uses a lg,lb070wv8 compatible 7" display

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:11AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > This series of devices is using lg,lb070wv8 instead of kyo,tcg121xglp. > > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel Applied, thanks!

Re: [PATCH v1 6/8] ARM: dts: imx6dl-victgo: Add interrupt-counter nodes

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:10AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > Interrupt counter is mainlined, now we can add missing counter nodes. > > Signed-off-by: Robin van der Gracht > Signed-off-by: Oleksij Rempel Applied, thanks!

Re: [PATCH v1 4/8] ARM: dts: imx6qdl-vicut1: update gpio-line-names for some GPIOs

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:08AM +0100, Oleksij Rempel wrote: > From: David Jander > > countedX lines have different board names (YACO_x). And REV_ and BOARD_ pins > have multiple functions. So, use names exposed to the OS. > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel App

Re: [PATCH v1 3/8] ARM: dts: imx6qdl-vicut1/vicutgo: Add backlight_led node

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:07AM +0100, Oleksij Rempel wrote: > From: David Jander > > backlight_led is the dimmable backlight for the rubber border on the case. It > is also used to highlight the power- and some other buttons. > > MX6QDL_PAD_SD4_DAT1__PWM3_OUT is also assigned as output for p

Re: [PATCH v1 2/8] ARM: dts: imx6qdl-vicut1/vicutgo: Rename backlight to backlight_lcd

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:06AM +0100, Oleksij Rempel wrote: > From: David Jander > > We have two backlight sources on this boards. Use more specific name for > the LCD backlight to see the difference. > > Signed-off-by: David Jander > Signed-off-by: Robin van der Gracht > Signed-off-by: Ol

Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote: > From: David Jander > > Recover default behavior of the device and set maximal brightness > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel Applied, thanks!

Re: [PATCH v1 5/8] ARM: dts: imx6qdl-vicut1/vicutgo: The sgtl5000 uses i2s not ac97

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:09AM +0100, Oleksij Rempel wrote: > From: Robin van der Gracht > > According to Documentation/devicetree/bindings/sound/fsl,ssi.txt > 'fsl,mode' should be specified for AC97 mode only. > > The 'fsl,ssi' documentation doesn't say anything about specifying > 'sound-da

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-04-05 Thread Andy Yan
Hi: On 4/5/22 17:37, Sascha Hauer wrote: On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote: Hi Sacha: On 4/1/22 20:52, Sascha Hauer wrote: -- >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 From: Sascha Hauer Date: Fri, 1 Apr 2022 14:48:49 +0200 Subject: [PATCH]

Re: [PATCH] drm/msm: remove unused plane_property field from msm_drm_private

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-05 16:41:21) > Remove from struct msm_drm_private unused field plane_property. > > Fixes: 7d36db0be3b9 ("drm/msm/mdp5: switch to standard zpos property") > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_drv.h | 3 --- > 1 file changed, 3 deletion

Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum

2022-04-05 Thread Shawn Guo
On Wed, Apr 6, 2022 at 9:23 AM Shawn Guo wrote: > > On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote: > > From: David Jander > > > > Recover default behavior of the device and set maximal brightness > > > > Signed-off-by: David Jander > > Signed-off-by: Oleksij Rempel > > --- > >

Re: [PATCH v2 4/4] drm/msm/dp: make dp_connector_mode_valid() more precise

2022-04-05 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-03-30 15:30:08) > Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather > than generic MODE_BAD in case the mode clock is higher than > DP_MAX_PIXEL_CLK_KHZ (675 MHz). > > Signed-off-by: Dmitry Baryshkov > --- Suggested-by: Stephen Boyd Reviewed-by:

Re: linux-next: build warning after merge of the drm-misc tree

2022-04-05 Thread Marek Vasut
On 4/6/22 02:58, Stephen Rothwell wrote: Hi all, Hi, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: drivers/gpu/drm/bridge/chipone-icn6211.prelink.o(.exit.data+0x0): Section mismatch in reference from the variable __

Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional

2022-04-05 Thread Andy Yan
Hi Sacha: On 4/5/22 17:05, Sascha Hauer wrote: On Sat, Apr 02, 2022 at 09:25:33AM +0800, Andy Yan wrote: Hi Sascha: On 4/1/22 20:55, Sascha Hauer wrote: On Thu, Mar 31, 2022 at 07:00:34PM +0800, Andy Yan wrote: Hi: On 3/31/22 16:18, Sascha Hauer wrote: On Thu, Mar 31, 2022 at 03:20:37PM +0

[PATCH] drm: bridge: icn6211: Mark module exit callback with __exit

2022-04-05 Thread Marek Vasut
Fix copy-paste error, module exit function should be marked with __exit instead of __init. Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support") Reported-by: Stephen Rothwell Signed-off-by: Marek Vasut Cc: Jagan Teki Cc: Maxime Ripard Cc: Robert Foss Cc: Sam Ravnborg Cc

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-05 Thread Zheyu Ma
On Wed, Apr 6, 2022 at 2:23 AM Helge Deller wrote: > > On 4/5/22 19:46, Ondrej Zary wrote: > > On Tuesday 05 April 2022 08:33:57 Helge Deller wrote: > >> Hello Geert, > >> > >> On 4/4/22 13:46, Geert Uytterhoeven wrote: > >>> Hi Helge, > >>> > >>> On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote

Re: [PATCH v1 1/8] ARM: dts: imx6qdl-vicut1/vicutgo: Set default backlight brightness to maximum

2022-04-05 Thread Shawn Guo
On Mon, Feb 21, 2022 at 10:53:05AM +0100, Oleksij Rempel wrote: > From: David Jander > > Recover default behavior of the device and set maximal brightness > > Signed-off-by: David Jander > Signed-off-by: Oleksij Rempel > --- > arch/arm/boot/dts/imx6dl-victgo.dts | 2 +- > arch/arm/boot/dts/

linux-next: build warning after merge of the drm-misc tree

2022-04-05 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: drivers/gpu/drm/bridge/chipone-icn6211.prelink.o(.exit.data+0x0): Section mismatch in reference from the variable __cfi_jt_cleanup_module to the function .init.text:

linux-next: build failure after merge of the drm-misc tree

2022-04-05 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/panel/panel-newvision-nv3052c.c:478:19: error: initialization of 'void (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *)' [-Werror=incom

linux-next: manual merge of the amdgpu tree with the drm-misc tree

2022-04-05 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the amdgpu tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c between commit: fee2ede15542 ("drm/ttm: rework bulk move handling v5") from the drm-misc tree and commit: 184a69ca4d41 ("drm/amdgpu: separate VM PT handling into amdgpu_vm_pt.c"

[PATCH 3/3] drm/msm: don't store created planes, connectors and encoders

2022-04-05 Thread Dmitry Baryshkov
There is no point now in storing arrays of creates planes, connectors and encoders. Remove them from struct msm_drm_private. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 12 ++-- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 7 --- drivers/gpu/drm/msm/

[PATCH 2/3] drm/msm: loop over encoders using drm_for_each_encoder()

2022-04-05 Thread Dmitry Baryshkov
Rather than manually looping over encoders array, use standard drm_for_each_encoder() macro. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +++-- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a

[PATCH 0/3] drm/msm: remove DRM mode setting object arrays

2022-04-05 Thread Dmitry Baryshkov
MSM DRM driver stores connectors, encoders and planes in the arrays inside struct msm_drm_private. They are not really necessary, as drm_devices also references lists of these objects. Drop private arrays and use drm_mode_foo() macros. Note, the crtc array is kept intact as it is used in vblank ha

[PATCH 1/3] drm/msm/dpu: remove manual destruction of DRM objects

2022-04-05 Thread Dmitry Baryshkov
Remove manual removal of DRM modesetting objects, it is done anyway by the drm_mode_config_cleanup() called from msm_drm_uninit(). Other MSM display drivers (MDP4, MDP5) do not manually destroy objects and trust generic code to do it's work. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/ms

[PATCH 4/4] drm/msm: unregister all internal bridges

2022-04-05 Thread Dmitry Baryshkov
Unwind all drm_bridge_add() calls for internal bridges and remove all bridges added by the msm driver itself by calling drm_bridge_remove(). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/dr

[PATCH 3/4] drm/msm/dp: properly add and remove created bridges

2022-04-05 Thread Dmitry Baryshkov
Add calls to drm_bridge_add()/drm_bridge_remove() for the internal DP bridges. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_drm.c index 80f59cf99089..a7415f

[PATCH 2/4] drm/msm/dsi: properly add and remove created bridges

2022-04-05 Thread Dmitry Baryshkov
Add calls to drm_bridge_add()/drm_bridge_remove() for the internal DSI bridges. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 0c

[PATCH 1/4] drm/msm/hdmi: properly add and remove created bridges

2022-04-05 Thread Dmitry Baryshkov
Add calls to drm_bridge_add()/drm_bridge_remove() for the internal HDMI bridges. This fixes the following warning. [2.195003] [ cut here ] [2.195044] WARNING: CPU: 0 PID: 1 at kernel/locking/mutex.c:579 __mutex_lock+0x840/0x9f4 [2.198774] DEBUG_LOCKS_WARN_ON(lo

[PATCH 0/4] drm/msm: properly add and remove internal bridges

2022-04-05 Thread Dmitry Baryshkov
While running the kernel with the mutex debugging enabled, I noticed the warning reported in the first commit (that the bridge's hpd_mutex is unitialized). Additional research revealed that we do not add and remove internal drm_bridges in the msm drm driver. Fix this now. Dmitry Baryshkov (4): d

Re: [PATCH v6 14/14] drm/msm/dsi: Add support for DSC configuration

2022-04-05 Thread Dmitry Baryshkov
On 04/04/2022 19:34, Vinod Koul wrote: When DSC is enabled, we need to configure DSI registers accordingly and configure the respective stream compression registers. Add support to calculate the register setting based on DSC params and timing information and configure these registers. Signed-of

[PATCH] drm/msm: remove unused plane_property field from msm_drm_private

2022-04-05 Thread Dmitry Baryshkov
Remove from struct msm_drm_private unused field plane_property. Fixes: 7d36db0be3b9 ("drm/msm/mdp5: switch to standard zpos property") Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_drv.h b/drivers/g

Re: [PATCH v3 01/17] fbcon: delete a few unneeded forward decl

2022-04-05 Thread Fabio Estevam
On Tue, Apr 5, 2022 at 6:04 PM Daniel Vetter wrote: > > I didn't bother with any code movement to fix the others, these just > got a bit in the way. > > v2: Rebase on top of Helge's reverts. > > Acked-by: Thomas Zimmermann > Acked-by: Sam Ravnborg (v1) > Reviewed-by: Geert Uytterhoeven (v1) > S

Re: [PATCH] drm/atomic: Convert a warning to dbg atomic printk

2022-04-05 Thread Zack Rusin
On Tue, 2022-04-05 at 19:09 +0200, Michel Dänzer wrote: > ⚠ External Email > > On 2022-04-04 20:21, Zack Rusin wrote: > > From: Zack Rusin > > > > By default each flip times out after 0.1 sec > > 10 * HZ is 10 seconds, not 0.1. Yea, sorry, this entire commit message is not correct. I've sent o

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Marek Vasut
On 4/5/22 17:24, Dave Stevenson wrote: Hi, If we can initialise the DSI host before the bridge for the pre_enable, then all the configuration moves to the atomic_pre_enable and there should be no need to have the delay. I can't 100% guarantee that, but one of the folks on the Pi forums is usin

Re: [PATCH v3] drm: of: Properly try all possible cases for bridge/panel detection

2022-04-05 Thread Linus Walleij
On Tue, Mar 29, 2022 at 3:27 PM Paul Kocialkowski wrote: > While bridge/panel detection was initially relying on the usual > port/ports-based of graph detection, it was recently changed to > perform the lookup on any child node that is not port/ports > instead when such a node is available, with

[PATCH v3 14/17] fbcon: Move console_lock for register/unlink/unregister

2022-04-05 Thread Daniel Vetter
Ideally console_lock becomes an implementation detail of fbcon.c and doesn't show up anywhere in fbmem.c. We're still pretty far from that, but at least the register/unregister code is there now. With this the do_fb_ioctl() handler is the only code in fbmem.c still calling console_lock(). Acked-b

[PATCH v3 16/17] fbcon: untangle fbcon_exit

2022-04-05 Thread Daniel Vetter
There's a bunch of confusions going on here: - The deferred fbcon setup notifier should only be cleaned up from fb_console_exit(), to be symmetric with fb_console_init() - We also need to make sure we don't race with the work, which means temporarily dropping the console lock (or we can deadloc

[PATCH v3 17/17] fbcon: Maintain a private array of fb_info

2022-04-05 Thread Daniel Vetter
Accessing the one in fbmem.c without taking the right locks is a bad idea. Instead maintain our own private copy, which is fully protected by console_lock() (like everything else in fbcon.c). That copy is serialized through fbcon_fb_registered/unregistered() calls. Also this means we do not need t

[PATCH v3 12/17] fbcon: use lock_fb_info in fbcon_open/release

2022-04-05 Thread Daniel Vetter
Now we get to the real motiviation, because fbmem.c insists that that's the right lock for these. Ofc fbcon.c has a lot more places where it probably should call lock_fb_info(). But looking at fbmem.c at least most of these seem to be protected by console_lock() too, which is probably what papers

[PATCH v3 15/17] fbcon: Move more code into fbcon_release

2022-04-05 Thread Daniel Vetter
con2fb_release_oldinfo() has a bunch more kfree() calls than fbcon_exit(), but since kfree() on NULL is harmless doing that in both places should be ok. This is also a bit more symmetric now again with fbcon_open also allocating the fbcon_ops structure. Acked-by: Sam Ravnborg Signed-off-by: Danie

Re: [PATCH v5 0/3] Ingenic DRM bridge_atomic_enable proposal

2022-04-05 Thread Paul Cercueil
Hi Christophe, Merged to drm-misc-next. Thanks, -Paul Le lun., mars 21 2022 at 14:36:48 +0100, Christophe Branchereau a écrit : Hello, v5 : - this set doesn't include the nv3052c bindings doc anymore, as it's already applied - nv3052c panel driver : removed empty lines, proceed to turn

[PATCH v3 13/17] fbcon: Consistently protect deferred_takeover with console_lock()

2022-04-05 Thread Daniel Vetter
This shouldn't be a problem in practice since until we've actually taken over the console there's nothing we've registered with the console/vt subsystem, so the exit/unbind path that check this can't do the wrong thing. But it's confusing, so fix it by moving it a tad later. Acked-by: Sam Ravnborg

[PATCH v3 11/17] fbcon: move more common code into fb_open()

2022-04-05 Thread Daniel Vetter
No idea why con2fb_acquire_newinfo() initializes much less than fbcon_startup(), but so be it. From a quick look most of the un-initialized stuff should be fairly harmless, but who knows. Note that the error handling for the con2fb_acquire_newinfo() failure case was very strange: Callers updated c

[PATCH v3 10/17] fbcon: Ditch error handling for con2fb_release_oldinfo

2022-04-05 Thread Daniel Vetter
It doesn't ever fail anymore. Acked-by: Sam Ravnborg Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Thomas Zimmermann Cc: Greg Kroah-Hartman Cc: Claudio Suarez Cc: Du Cheng Cc: Tetsuo Handa --- drivers/video/fbdev/core/fbcon.c | 37 +++-

[PATCH v3 09/17] fbcon: Extract fbcon_open/release helpers

2022-04-05 Thread Daniel Vetter
There's two minor behaviour changes in here: - in error paths we now consistently call fb_ops->fb_release - fb_release really can't fail (fbmem.c ignores it too) and there's no reasonable cleanup we can do anyway. Note that everything in fbcon.c is protected by the big console_lock() lock (espec

[PATCH v3 06/17] fbcon: Use delayed work for cursor

2022-04-05 Thread Daniel Vetter
Allows us to delete a bunch of hand-rolled stuff using a timer plus a separate work). Also to simplify the code we initialize the cursor_work completely when we allocate the fbcon_ops structure, instead of trying to cope with console re-initialization. The motiviation here is that fbcon code stops

[PATCH v3 07/17] fbcon: Replace FBCON_FLAGS_INIT with a boolean

2022-04-05 Thread Daniel Vetter
It's only one flag and slightly tidier code. Acked-by: Thomas Zimmermann Acked-by: Sam Ravnborg Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Tetsuo Handa Cc: Greg Kroah-Hartman Cc: Du Cheng Cc: Thomas Zimmermann Cc: Claudio Suarez --- drivers/video/fbdev/core/fbcon.c | 11 +

[PATCH v3 08/17] fb: Delete fb_info->queue

2022-04-05 Thread Daniel Vetter
It was only used by fbcon, and that now switched to its own, private work. Acked-by: Sam Ravnborg Acked-by: Thomas Zimmermann Signed-off-by: Daniel Vetter Cc: Helge Deller Cc: linux-fb...@vger.kernel.org --- include/linux/fb.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/f

[PATCH v3 05/17] fbdev/sysfs: Fix locking

2022-04-05 Thread Daniel Vetter
fb_set_var requires we hold the fb_info lock. Or at least this now matches what the ioctl does ... Note that ps3fb and sh_mobile_lcdcfb are busted in different ways here, but I will not fix them up. Also in practice this isn't a big deal, because really variable fbdev state is actually protected

[PATCH v3 04/17] fbcon: delete delayed loading code

2022-04-05 Thread Daniel Vetter
Before commit 6104c37094e729f3d4ce65797002112735d49cd1 Author: Daniel Vetter Date: Tue Aug 1 17:32:07 2017 +0200 fbcon: Make fbcon a built-time depency for fbdev it was possible to load fbcon and fbdev drivers in any order, which means that fbcon init had to handle the case where fbdev dr

[PATCH v3 03/17] fbcon: Introduce wrapper for console->fb_info lookup

2022-04-05 Thread Daniel Vetter
Half of it is protected by console_lock, but the other half is a lot more awkward: Registration/deregistration of fbdev are serialized, but we don't really clear out anything in con2fb_map and so there's potential for use-after free mixups. First step is to encapsulate the lookup. Acked-by: Thoma

[PATCH v3 01/17] fbcon: delete a few unneeded forward decl

2022-04-05 Thread Daniel Vetter
I didn't bother with any code movement to fix the others, these just got a bit in the way. v2: Rebase on top of Helge's reverts. Acked-by: Thomas Zimmermann Acked-by: Sam Ravnborg (v1) Reviewed-by: Geert Uytterhoeven (v1) Signed-off-by: Daniel Vetter Cc: Helge Deller Cc: Daniel Vetter Cc: T

[PATCH v3 02/17] fbcon: Move fbcon_bmove(_rec) functions

2022-04-05 Thread Daniel Vetter
Avoids two forward declarations, and more importantly, matches what I've done in my fbcon scrolling restore patches - so I need this to avoid a bunch of conflicts in rebasing since we ended up merging Helge's series instead. Acked-by: Thomas Zimmermann Reviewed-by: Javier Martinez Canillas Signe

[PATCH v3 00/17] fbcon cleanups

2022-04-05 Thread Daniel Vetter
Hi all, Finally got around to respin this. Changes: - Bunch more acks and r-b, still not yet all patches. - one tiny fix for a bisect issue, end result was all fine - I dropped the last to patches to make registered_fb private, that needs more work around how we handle the unregister vs driver l

Re: [PATCH v2 06/19] fbcon: Use delayed work for cursor

2022-04-05 Thread Daniel Vetter
On Thu, Feb 10, 2022 at 08:43:36PM +0900, Tetsuo Handa wrote: > On 2022/02/09 6:08, Daniel Vetter wrote: > > @@ -714,6 +700,8 @@ static int con2fb_acquire_newinfo(struct vc_data *vc, > > struct fb_info *info, > > ops = kzalloc(sizeof(struct fbcon_ops), GFP_KERNEL); > > if (

Re: [PATCH 1/3] drm/vmwgfx: Add debugfs entries for ttm placements

2022-04-05 Thread Daniel Vetter
On Tue, 5 Apr 2022 at 16:01, Zack Rusin wrote: > > On Mon, 2022-04-04 at 17:38 +0200, Daniel Vetter wrote: > > On Fri, Apr 01, 2022 at 04:56:00PM -0400, Zack Rusin wrote: > > > From: Zack Rusin > > > > > > Add a few debugfs entries for every used TTM placement that vmwgfx > > > is > > > using. Th

Re: [PATCH] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-05 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-04-05 11:17:07) > HPD plugin handle is responsible for setting up main link and depend on Is "HPD plugin handle" a function? Can you use the function name? > user space frame work to start video stream. Similarly, HPD unplugged > handle is responsible for tearing down m

Re: [PATCH v2] drm/amd/display: don't ignore alpha property on pre-multiplied mode

2022-04-05 Thread Simon Ser
I've tested this patch and it fixes my bug [1]. Thanks! Tested-by: Simon Ser [1]: https://gitlab.freedesktop.org/drm/amd/-/issues/1734

Re: [PATCH v6 14/14] drm/msm/dsi: Add support for DSC configuration

2022-04-05 Thread kernel test robot
Hi Vinod, I love your patch! Perhaps something to improve: [auto build test WARNING on 05241de1f69eb7f56b0a5e0bec96a7752fad1b2f] url: https://github.com/intel-lab-lkp/linux/commits/Vinod-Koul/drm-msm-Add-Display-Stream-Compression-Support/20220405-003745 base

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-05 Thread Randy Dunlap
On 4/5/22 11:47, Simon Ser wrote: > On Tuesday, April 5th, 2022 at 19:58, Randy Dunlap > wrote: > >> On 4/5/22 08:05, Simon Ser wrote: >> >>> On Tuesday, April 5th, 2022 at 16:39, Randy Dunlap rdun...@infradead.org >>> wrote: >>> On 4/4/22 23:26, Javier Martinez Canillas wrote: >>>

Re: [PATCH v5 4/9] drm: drm_atomic_helper: Add a new helper to deal with the writeback connector validation

2022-04-05 Thread Igor Torrente
Hi André, On 4/5/22 11:21, André Almeida wrote: Às 17:45 de 04/04/22, Igor Torrente escreveu: Add a helper function to validate the connector configuration receive in Maybe it should be "received" the encoder atomic_check by the drivers. So the drivers don't need do these common validation

Re: [PATCH v5 1/9] drm: vkms: Alloc the compose frame using vzalloc

2022-04-05 Thread Igor Torrente
Hi André, On 4/5/22 11:05, André Almeida wrote: Hi Igor, Thanks for your patch! Às 17:45 de 04/04/22, Igor Torrente escreveu: Currently, the memory to the composition frame is being allocated using the kzmalloc. This comes with the limitation of maximum size of one page size(which in the x86_

Re: [Freedreno] [PATCH v6 4/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-05 Thread Abhinav Kumar
Hi Laurent On 4/5/2022 10:08 AM, Abhinav Kumar wrote: Hi Laurent On 4/5/2022 10:02 AM, Laurent Pinchart wrote: Hi Abhinav, On Tue, Apr 05, 2022 at 09:53:57AM -0700, Abhinav Kumar wrote: On 4/5/2022 9:47 AM, Laurent Pinchart wrote: On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote:

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-05 Thread Simon Ser
On Tuesday, April 5th, 2022 at 19:58, Randy Dunlap wrote: > On 4/5/22 08:05, Simon Ser wrote: > > > On Tuesday, April 5th, 2022 at 16:39, Randy Dunlap rdun...@infradead.org > > wrote: > > > > > On 4/4/22 23:26, Javier Martinez Canillas wrote: > > > > > > > On 4/5/22 08:12, Simon Ser wrote: > >

Re: [PATCH] fbdev: Fix unregistering of framebuffers without device

2022-04-05 Thread Thomas Zimmermann
Hi Am 05.04.22 um 11:01 schrieb Daniel Vetter: On Mon, Apr 04, 2022 at 09:44:02PM +0200, Thomas Zimmermann wrote: OF framebuffers do not have an underlying device in the Linux device hierarchy. Do a regular unregister call instead of hot unplugging such a non-existing device. Fixes a NULL deref

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-05 Thread Helge Deller
On 4/5/22 19:46, Ondrej Zary wrote: > On Tuesday 05 April 2022 08:33:57 Helge Deller wrote: >> Hello Geert, >> >> On 4/4/22 13:46, Geert Uytterhoeven wrote: >>> Hi Helge, >>> >>> On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: On 4/3/22 13:26, Zheyu Ma wrote: > I found a bug in the fun

[PATCH] drm/msm/dp: enhance both connect and disconnect pending_timeout handle

2022-04-05 Thread Kuogee Hsieh
HPD plugin handle is responsible for setting up main link and depend on user space frame work to start video stream. Similarly, HPD unplugged handle is responsible for tearing down main link and depend on user space frame work to stop video stream. Connect_pending_timeout and disconnect_ pending_ti

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Doug Anderson
Hi, On Tue, Apr 5, 2022 at 10:36 AM Dmitry Baryshkov wrote: > > On 05/04/2022 20:02, Doug Anderson wrote: > > Hi, > > > > On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov > > wrote: > >>> 3. For DP and eDP HPD means something a little different. Essentially > >>> there are two concepts: a) is a d

Re: [PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-05 Thread Randy Dunlap
Hi Simon, On 4/5/22 08:05, Simon Ser wrote: > On Tuesday, April 5th, 2022 at 16:39, Randy Dunlap > wrote: > >> On 4/4/22 23:26, Javier Martinez Canillas wrote: >> >>> On 4/5/22 08:12, Simon Ser wrote: >>> On Monday, April 4th, 2022 at 23:35, Randy Dunlap rdun...@infradead.org wrote:

Re: [PATCH] drm/virtio: Add execbuf flag to request no fence-event

2022-04-05 Thread Chia-I Wu
On Tue, Apr 5, 2022 at 10:38 AM Rob Clark wrote: > > From: Rob Clark > > It would have been cleaner to have a flag to *request* the fence event. > But that ship has sailed. So add a flag so that userspace which doesn't > care about the events can opt-out. > > Signed-off-by: Rob Clark Reviewed-b

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-05 Thread Ondrej Zary
On Tuesday 05 April 2022 08:33:57 Helge Deller wrote: > Hello Geert, > > On 4/4/22 13:46, Geert Uytterhoeven wrote: > > Hi Helge, > > > > On Sun, Apr 3, 2022 at 5:41 PM Helge Deller wrote: > >> On 4/3/22 13:26, Zheyu Ma wrote: > >>> I found a bug in the function i740fb_set_par(). > >> > >> Nic

Re: [PATCH] drm/amdgpu: Senseless code and unnecessary memset

2022-04-05 Thread Christian König
Am 05.04.22 um 19:36 schrieb Grigory Vasilyev: Using memset on local arrays before exiting the function is pointless. Compilator will remove this code. Also for local arrays is preferable to use {0} instead of memset. Mistakes are often made when working with memset. Well actually memset is pre

[PATCH] drm/virtio: Add execbuf flag to request no fence-event

2022-04-05 Thread Rob Clark
From: Rob Clark It would have been cleaner to have a flag to *request* the fence event. But that ship has sailed. So add a flag so that userspace which doesn't care about the events can opt-out. Signed-off-by: Rob Clark --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 8 +--- include/uapi/drm

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Dmitry Baryshkov
On 05/04/2022 20:02, Doug Anderson wrote: Hi, On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov wrote: 3. For DP and eDP HPD means something a little different. Essentially there are two concepts: a) is a display physically connected and b) is the display powered up and ready. For DP, the two ar

[PATCH v2 21/22] drm/edid: Extract drm_edid_decode_mfg_id()

2022-04-05 Thread Ville Syrjala
From: Ville Syrjälä Make the PNPID decoding available for other users. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Ville Syrjälä --- include/drm/drm_edid.h | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/include/drm/drm_edid.h b/include/drm/drm

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Daniel Vetter
On Tue, 5 Apr 2022 at 18:45, Greg KH wrote: > > On Tue, Apr 05, 2022 at 06:12:59PM +0200, Daniel Vetter wrote: > > On Tue, Apr 05, 2022 at 03:33:17PM +0200, Greg KH wrote: > > > On Tue, Apr 05, 2022 at 03:24:40PM +0200, Geert Uytterhoeven wrote: > > > > Hi Daniel, > > > > > > > > On Tue, Apr 5, 20

Re: [Freedreno] [PATCH v6 4/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-05 Thread Abhinav Kumar
Hi Laurent On 4/5/2022 10:02 AM, Laurent Pinchart wrote: Hi Abhinav, On Tue, Apr 05, 2022 at 09:53:57AM -0700, Abhinav Kumar wrote: On 4/5/2022 9:47 AM, Laurent Pinchart wrote: On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote: On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote:

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-04-05 Thread Doug Anderson
Hi, On Tue, Apr 5, 2022 at 5:54 AM Dmitry Baryshkov wrote: > > 3. For DP and eDP HPD means something a little different. Essentially > > there are two concepts: a) is a display physically connected and b) is > > the display powered up and ready. For DP, the two are really tied > > together. From

Re: [Freedreno] [PATCH v6 4/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-05 Thread Laurent Pinchart
Hi Abhinav, On Tue, Apr 05, 2022 at 09:53:57AM -0700, Abhinav Kumar wrote: > On 4/5/2022 9:47 AM, Laurent Pinchart wrote: > > On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote: > >> On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote: > >>> On Thu, Mar 31, 2022 at 05:12:13PM -0700, Abhin

Re: [PATCH v3] drm: of: Properly try all possible cases for bridge/panel detection

2022-04-05 Thread Thierry Reding
On Fri, Apr 01, 2022 at 09:44:46AM +0200, Paul Kocialkowski wrote: > Hi Bjorn, > > On Thu 31 Mar 22, 20:16, Bjorn Andersson wrote: > > On Tue 29 Mar 06:27 PDT 2022, Paul Kocialkowski wrote: > > > > > While bridge/panel detection was initially relying on the usual > > > port/ports-based of graph d

Re: [PATCH] drm/amdkfd: Fix potential NULL pointer dereference

2022-04-05 Thread Felix Kuehling
Am 2022-04-04 um 18:21 schrieb Grigory Vasilyev: In the amdgpu_amdkfd_get_xgmi_bandwidth_mbytes function, the peer_adev pointer can be NULL and is passed to amdgpu_xgmi_get_num_links. In amdgpu_xgmi_get_num_links, peer_adev pointer is dereferenced without any checks: peer_adev->gmc.xgmi.node_id

Re: [Freedreno] [PATCH v6 4/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-05 Thread Abhinav Kumar
Hi Laurent On 4/5/2022 9:47 AM, Laurent Pinchart wrote: Hi Rob and Abhinav, On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote: On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote: On Thu, Mar 31, 2022 at 05:12:13PM -0700, Abhinav Kumar wrote: For some vendor driver implementations,

Re: [PATCH v6 4/4] drm: allow real encoder to be passed for drm_writeback_connector

2022-04-05 Thread Laurent Pinchart
Hi Rob and Abhinav, On Mon, Apr 04, 2022 at 11:43:37AM -0700, Rob Clark wrote: > On Fri, Apr 1, 2022 at 8:38 AM Laurent Pinchart wrote: > > On Thu, Mar 31, 2022 at 05:12:13PM -0700, Abhinav Kumar wrote: > > > For some vendor driver implementations, display hardware can > > > be shared between the

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Greg KH
On Tue, Apr 05, 2022 at 06:12:59PM +0200, Daniel Vetter wrote: > On Tue, Apr 05, 2022 at 03:33:17PM +0200, Greg KH wrote: > > On Tue, Apr 05, 2022 at 03:24:40PM +0200, Geert Uytterhoeven wrote: > > > Hi Daniel, > > > > > > On Tue, Apr 5, 2022 at 1:48 PM Daniel Vetter wrote: > > > > On Tue, 5 Apr

Re: [PATCH] drm/msm/dsi: fix error checks and return values for DSI xmit functions

2022-04-05 Thread Abhinav Kumar
On 4/1/2022 4:11 PM, Dmitry Baryshkov wrote: As noticed by Dan ([1] an the followup thread) there are multiple issues with the return values for MSM DSI command transmission callback. In the error case it can easily return a positive value when it should have returned a proper error code. Thi

Re: [PATCH v2 18/19] Revert "fbdev: Prevent probing generic drivers if a FB is already registered"

2022-04-05 Thread Daniel Vetter
On Tue, Apr 05, 2022 at 03:33:17PM +0200, Greg KH wrote: > On Tue, Apr 05, 2022 at 03:24:40PM +0200, Geert Uytterhoeven wrote: > > Hi Daniel, > > > > On Tue, Apr 5, 2022 at 1:48 PM Daniel Vetter wrote: > > > On Tue, 5 Apr 2022 at 11:52, Javier Martinez Canillas > > > wrote: > > > > On 4/5/22 11:

Re: [Intel-gfx] [PATCH] drm/i915: Fixup kerneldoc in struct i915_gem_context

2022-04-05 Thread Daniel Vetter
On Tue, Apr 05, 2022 at 04:53:45PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Mixup in rebasing and patchwork re-runs made me push the wrong version of > the patch. Or I even forgot to send out the fixed version. Fix it up. > > Signed-off-by: Tvrtko Ursulin > Fixes: 748716041dfa ("

[PATCH] drm/i915: Fixup kerneldoc in struct i915_gem_context

2022-04-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Mixup in rebasing and patchwork re-runs made me push the wrong version of the patch. Or I even forgot to send out the fixed version. Fix it up. Signed-off-by: Tvrtko Ursulin Fixes: 748716041dfa ("drm/i915: Track all user contexts per client") Cc: Umesh Nerlige Ramappa ---

Re: [PATCH][RESEND] drm/bridge: ti-sn65dsi83: Check link status register after enabling the bridge

2022-04-05 Thread Dave Stevenson
On Tue, 5 Apr 2022 at 15:48, Marek Vasut wrote: > > On 4/5/22 16:20, Dave Stevenson wrote: > > Hi, > > >>> If we can initialise the DSI host before the bridge for the > >>> pre_enable, then all the configuration moves to the atomic_pre_enable > >>> and there should be no need to have the delay. >

[PATCH 11/11] drm/i915: Fix undefined behavior due to shift overflowing the constant

2022-04-05 Thread Borislav Petkov
From: Borislav Petkov Fix: In file included from :0:0: drivers/gpu/drm/i915/gt/uc/intel_guc.c: In function ‘intel_guc_send_mmio’: ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_1047’ \ declared with attribute error: FIELD_PREP: mask is not constant _

[PATCH 04/11] drm/r128: Fix undefined behavior due to shift overflowing the constant

2022-04-05 Thread Borislav Petkov
From: Borislav Petkov Fix: drivers/gpu/drm/r128/r128_cce.c: In function ‘r128_do_init_cce’: drivers/gpu/drm/r128/r128_cce.c:417:2: error: case label does not reduce to an integer constant case R128_PM4_64BM_64VCBM_64INDBM: ^~~~ drivers/gpu/drm/r128/r128_cce.c:418:2: error: case la

[PATCH v9 7/9] drm/i915/selftest_migrate: Check CCS meta data clear

2022-04-05 Thread Ramalingam C
Extend the live migrate selftest, to verify the ccs surface clearing during the Flat-CCS capable lmem obj clear. v2: Look at right places for ccs data [Thomas] Signed-off-by: Ramalingam C Reviewed-by: Thomas Hellstrom --- drivers/gpu/drm/i915/gt/selftest_migrate.c | 250 ++---

  1   2   3   >