Re: [PATCH 3/8] drm/display: Introduce a DRM display-helper module

2022-03-30 Thread Javier Martinez Canillas
Hello Thomas, On 3/30/22 12:32, Thomas Zimmermann wrote: > Hi > [snip] >>> >>> -obj-$(CONFIG_DRM_DP_HELPER) += drm_dp_helper.o >>> +obj-$(CONFIG_DRM_DISPLAY_HELPER) += drm_display_helper.o >> >> The drm_dp_helper.ko module has some parameters and this change will break >> existing kernel cmd

Re: drm-tip compile break

2022-03-30 Thread Christian König
I'm going to take a look, but need to figure out how to find the broken merge Christian. Am 31.03.22 um 00:33 schrieb Dixit, Ashutosh: Is anyone looking into fixing this: drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c: In function ‘amdgpu_gtt_mgr_recover’: drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_

Re: [Linaro-mm-sig] [PATCH next] dma-buf/sync-file: do not allow zero size allocations

2022-03-30 Thread Christian König
Am 30.03.22 um 20:24 schrieb Pavel Skripkin: Hi Christian, On 3/30/22 10:09, Christian König wrote: That problem is already fixed with patch 21d139d73f77 dma-buf/sync-file: fix logic error in new fence merge code. Am 30.03.22 um 00:14 schrieb Pavel Skripkin: syzbot reported GPF in dma_fenc

Re: [PATCH] dt-bindings: display: msm: dsi: remove address/size cells

2022-03-30 Thread Vinod Koul
On 29-03-22, 10:52, Rob Herring wrote: > On Tue, Mar 29, 2022 at 12:01:52PM +0530, Vinod Koul wrote: > > On 28-03-22, 13:21, Rob Herring wrote: > > > On Mon, Mar 28, 2022 at 12:18 PM Krzysztof Kozlowski > > > wrote: > > > > > > > > On 28/03/2022 19:16, Vinod Koul wrote: > > > > > On 28-03-22, 19:4

RE: [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-03-30 Thread Sankeerth Billakanti (QUIC)
Hi Dmitry, > On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti > wrote: > > > > The panel-edp driver modes needs to be validated differently from DP > > because the link capabilities are not available for EDP by that time. > > > > Signed-off-by: Sankeerth Billakanti > > This should not be nece

RE: [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts

2022-03-30 Thread Sankeerth Billakanti (QUIC)
Hi Dmitry, > On Wed, 30 Mar 2022 at 19:03, Sankeerth Billakanti > wrote: > > > > The interrupt register will still reflect the connect and disconnect > > interrupt status without generating an actual HW interrupt. > > The controller driver should not handle those masked interrupts. > > > > Signed

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-03-30 Thread Doug Anderson
Hi, On Wed, Mar 30, 2022 at 4:19 PM Dmitry Baryshkov wrote: > > + bridge->ops = > > + DRM_BRIDGE_OP_DETECT | > > + DRM_BRIDGE_OP_HPD | > > + DRM_BRIDGE_OP_MODES; > > I think OP_MODES should be used for eDP, shouldn't it? No.

RE: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-30 Thread Liu, Chuansheng
Hi Paul, > -Original Message- > From: Paul Menzel > Sent: Thursday, March 31, 2022 12:47 AM > To: Liu, Chuansheng > Cc: tzimmerm...@suse.de; linux-fb...@vger.kernel.org; del...@gmx.de; dri- > de...@lists.freedesktop.org > Subject: Re: [PATCH] fbdev: defio: fix the pagelist corruption >

[PATCH 11/15] drm/i915/gt: Always use MCR functions on multicast registers

2022-03-30 Thread Matt Roper
Rather than relying on the implicit behavior of intel_uncore_*() functions, let's always use the intel_gt_mcr_*() functions to operate on multicast/replicated registers. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_ggtt.c | 4 +- drivers/gpu/drm/i915/gt/intel_gtt.c | 4

[PATCH 07/15] drm/i915: Move XEHPSDV_TILE0_ADDR_RANGE to GT register header

2022-03-30 Thread Matt Roper
XEHPSDV_TILE0_ADDR_RANGE is a GT register and requires multicast handling. Move the definition to the proper header. Fixes: b8ca8fef58d4 ("drm/i915/stolen: don't treat small BAR as an error") Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 1 + drivers/gpu/drm/i915/gt

[PATCH 15/15] drm/i915/xehp: Eliminate shared/implicit steering

2022-03-30 Thread Matt Roper
Historically we've selected and programmed a single MCR group/instance ID at driver startup that will steer register accesses for GSLICE/DSS ranges to a non-terminated instance. Any reads of these register ranges that don't need a specific unicast access won't bother explicitly resteering because

[PATCH 14/15] drm/i915: Define multicast registers as a new type

2022-03-30 Thread Matt Roper
Rather than treating multicast registers as 'i915_reg_t' let's define them as a completely new type. This will allow the compiler to help us make sure we're using multicast-aware functions to operate on multicast registers. This plan does break down a bit in places where we're just maintaining he

[PATCH 13/15] drm/i915/gt: Add MCR-specific workaround initializers

2022-03-30 Thread Matt Roper
Let's be more explicit about which of our workarounds are updating MCR registers. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 346 +++- 1 file changed, 198 insertions(+), 148 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b

[PATCH 09/15] drm/i915/gt: Move multicast register handling to a dedicated file

2022-03-30 Thread Matt Roper
Handling of multicast/replicated registers is spread across intel_gt.c and intel_uncore.c today. As multicast handling and the related steering logic gets more complicated with the addition of new platforms and new rules it makes sense to centralize it all in one place. For now the existing funct

[PATCH 08/15] drm/i915: Define MCR registers explicitly

2022-03-30 Thread Matt Roper
Rather than using the same _MMIO() macro to define MCR registers as singleton registers, let's use a new MCR_REG() macro to make it clear that these registers are special and should be handled accordingly. For now MCR_REG() will still generate an i915_reg_t with the given offset, but we'll change

[PATCH 02/15] drm/i915/xehp: Create separate reg definitions for new MCR registers

2022-03-30 Thread Matt Roper
Starting in Xe_HP, several registers our driver works with have been converted from singleton registers into replicated registers with multicast behavior. Although the registers are still located at the same MMIO offsets as on previous platforms, let's duplicate the register definitions in prepara

[PATCH 10/15] drm/i915/gt: Cleanup interface for MCR operations

2022-03-30 Thread Matt Roper
Let's replace the assortment of intel_gt_* and intel_uncore_* functions that operate on MCR registers with a cleaner set of interfaces: * intel_gt_mcr_read -- unicast read from specific instance * intel_gt_mcr_read_any[_fw] -- unicast read from any non-terminated instance * intel_gt_mcr_

[PATCH 06/15] drm/i915: Drop duplicated definition of XEHPSDV_FLAT_CCS_BASE_ADDR

2022-03-30 Thread Matt Roper
When this register was moved to intel_gt_regs.h it wasn't dropped from i915_reg.h; do so now. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_reg.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index efb81cb4c7c0..

[PATCH 12/15] drm/i915/guc: Handle save/restore of MCR registers explicitly

2022-03-30 Thread Matt Roper
MCR registers can be placed on the GuC's save/restore list, but at the moment they are always handled in a multicast manner (i.e., the GuC reads one instance to save the value and then does a multicast write to restore that single value to all instances). In the future the GuC will probably give u

[PATCH 01/15] drm/i915/gen8: Create separate reg definitions for new MCR registers

2022-03-30 Thread Matt Roper
Gen8 was the first time our hardware had multicast registers (or at least the first time the multicast nature was exposed and MMIO accesses could be steered). There are some registers that transitioned from singleton behavior to multicast during the gen7 -> gen8 transition; let's duplicate the reg

[PATCH 05/15] drm/i915/xehp: Check for faults on all mslices

2022-03-30 Thread Matt Roper
The fault registers are multicast registers, replicated per-mslice starting on Xe_HP. When checking for faults, we should check each mslice's instance of the register rather than just one of the instances. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/gt/intel_gt.c | 44 ++

[PATCH 04/15] drm/i915/gt: Correct prefix on a few registers

2022-03-30 Thread Matt Roper
We have a few registers that have existed for several hardware generations, but are only used by the driver on Xe_HP and beyond. In cases where the Xe_HP version of the register is now replicated and uses multicast behavior, but earlier generations were singleton, let's change the register prefix

[PATCH 03/15] drm/i915/gt: Drop a few unused register definitions

2022-03-30 Thread Matt Roper
Let's drop a few register definitions that are unused anywhere in the driver today. Since the referenced offsets are part of what is now considered a multicast register region, the current definitions would not be correct for use on any future platform. Signed-off-by: Matt Roper --- drivers/gpu

[PATCH 00/15] i915: Explicit handling of multicast registers

2022-03-30 Thread Matt Roper
Multicast/replicated (MCR) registers on Intel hardware are a purely GT-specific concept. Rather than leaving MCR register handling spread across several places throughout the driver (intel_uncore.c, intel_gt.c, etc.) with confusing combinations of handler functions living in different namespaces,

Re: [PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-03-30 Thread Dmitry Baryshkov
On 30/03/2022 19:02, Sankeerth Billakanti wrote: This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel shoul

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Daniel Stone
Hi, On Wed, 30 Mar 2022 at 20:47, Daniel Vetter wrote: > On Thu, Mar 31, 2022 at 12:14:31AM +0530, Jagan Teki wrote: > > Does it mean the userspace knows when to disconnect and connect the > > LVDS or HDMI? What if display-switch ISR will disconnect LVDS and > > connect HDMI when HPD is On and co

[PATCH] drm/amd/display: protect remaining FPU-code calls on dcn3.1.x

2022-03-30 Thread Melissa Wen
>From [1], I realized two other calls to dcn30 code are associated with FPU operations and are not protected by DC_FP_* macros: * dcn30_populate_dml_writeback_from_context() * dcn30_set_mcif_arb_params() So, since FPU-associated code is not fully isolated in dcn30, and dcn3.1.x reuses them, let's

drm-tip compile break

2022-03-30 Thread Dixit, Ashutosh
Is anyone looking into fixing this: drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c: In function ‘amdgpu_gtt_mgr_recover’: drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c:200:31: error: ‘struct ttm_range_mgr_node’ has no member named ‘tbo’ amdgpu_ttm_recover_gart(node->tbo);

[PATCH v2 3/4] drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display

2022-03-30 Thread Dmitry Baryshkov
Since the last commit, the max_pclk_khz became constant, it's set to DP_MAX_PIXEL_CLK_KHZ and never changed afterwards. Remove it completely and use DP_MAX_PIXEL_CLK_KHZ directly. Reviewed-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_

[PATCH v2 2/4] drm/msm/dp: simplify dp_connector_get_modes()

2022-03-30 Thread Dmitry Baryshkov
Since dp_panel_get_modes() handling for dp_mode was removed, dp_display_get_modes also doesn't change the passed dp_mode, drop the unused dp_mode variable being allocated unused and then freed. Reviewed-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/

[PATCH v2 4/4] drm/msm/dp: make dp_connector_mode_valid() more precise

2022-03-30 Thread Dmitry Baryshkov
Make dp_connector_mode_valid() return precise MODE_CLOCK_HIGH rather than generic MODE_BAD in case the mode clock is higher than DP_MAX_PIXEL_CLK_KHZ (675 MHz). Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 1/4] drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()

2022-03-30 Thread Dmitry Baryshkov
Since the commit ab205927592b ("drm/msm/dp: remove mode hard-coding in case of DP CTS") the function dp_panel_get_modes() doesn't use (or fill) the dp_mode argument. Drop it completely. Reviewed-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/

[PATCH v2 0/4] drm/msm/dp: simplify dp_connector_get_modes()

2022-03-30 Thread Dmitry Baryshkov
As noted by Ville Syrjälä [1] the dp_connector_get_modes() has weird on-stack interim copy of the mode. When reviewing the mentioned patch I noticed that the rest of the code in dp_connector_get_modes() is weird, unused since September of 2020 and can be removed. This series removes dead weird code

Re: [PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts

2022-03-30 Thread Dmitry Baryshkov
On Wed, 30 Mar 2022 at 19:03, Sankeerth Billakanti wrote: > > The interrupt register will still reflect the connect and disconnect > interrupt status without generating an actual HW interrupt. > The controller driver should not handle those masked interrupts. > > Signed-off-by: Sankeerth Billakant

Re: [PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-03-30 Thread Dmitry Baryshkov
On Wed, 30 Mar 2022 at 19:04, Sankeerth Billakanti wrote: > > The panel-edp driver modes needs to be validated differently from DP > because the link capabilities are not available for EDP by that time. > > Signed-off-by: Sankeerth Billakanti This should not be necessary after https://patchwork.

RE: [PATCH] drm/amdkfd: Add SVM API support capability bits

2022-03-30 Thread Sierra Guiza, Alejandro (Alex)
Hi Matthew, I sent this patch by accident. Please ignore it. Regards, Alex Sierra > -Original Message- > From: Matthew Wilcox > Sent: Wednesday, March 30, 2022 4:29 PM > To: Sierra Guiza, Alejandro (Alex) > Cc: j...@nvidia.com; da...@redhat.com; Kuehling, Felix > ; linux...@kvack.org; r

[PATCH v4 RFC] drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

2022-03-30 Thread Matt Atwood
Newer platforms have DSS that aren't necessarily available for both geometry and compute, two queries will need to exist. This introduces the first, when passing a valid engine class and engine instance in the flags returns a topology describing geometry. v2: fix white space errors v3: change flag

Re: [PATCH] drm/amdkfd: Add SVM API support capability bits

2022-03-30 Thread Matthew Wilcox
On Wed, Mar 30, 2022 at 04:24:20PM -0500, Alex Sierra wrote: > From: Philip Yang > > SVMAPISupported property added to HSA_CAPABILITY, the value match > HSA_CAPABILITY defined in Thunk spec: > > SVMAPISupported: it will not be supported on older kernels that don't > have HMM or on systems with G

RE: [PATCH] drm/amdkfd: Add SVM API support capability bits

2022-03-30 Thread Sierra Guiza, Alejandro (Alex)
Please ignore this patch. > -Original Message- > From: amd-gfx On Behalf Of Alex > Sierra > Sent: Wednesday, March 30, 2022 4:24 PM > To: j...@nvidia.com > Cc: rcampb...@nvidia.com; wi...@infradead.org; da...@redhat.com; > Kuehling, Felix ; apop...@nvidia.com; amd- > g...@lists.freedeskto

[PATCH v2 3/3] tools: add selftests to hmm for COW in device memory

2022-03-30 Thread Alex Sierra
The objective is to test device migration mechanism in pages marked as COW, for private and coherent device type. In case of writing to COW private page(s), a page fault will migrate pages back to system memory first. Then, these pages will be duplicated. In case of COW device coherent type, pages

[PATCH v2 2/3] tools: add more gup configs to hmm_gup selftests

2022-03-30 Thread Alex Sierra
Test device pages with get_user_pages and get_user_pages_fast. The motivation is to test device coherent type pages in the gup and gup fast paths, after vm_normal_pages was split into LRU and non-LRU handled. Signed-off-by: Alex Sierra Acked-by: Felix Kuehling --- tools/testing/selftests/vm/hmm

[PATCH v2 1/3] mm: add vm_normal_lru_pages for LRU handled pages only

2022-03-30 Thread Alex Sierra
With DEVICE_COHERENT, we'll soon have vm_normal_pages() return device-managed anonymous pages that are not LRU pages. Although they behave like normal pages for purposes of mapping in CPU page, and for COW. They do not support LRU lists, NUMA migration or THP. The difference between new vm_normal_l

[PATCH v2 0/3] split vm_normal_pages for LRU and non-LRU handling

2022-03-30 Thread Alex Sierra
With DEVICE_COHERENT, we'll soon have vm_normal_pages() return device-managed anonymous pages that are not LRU pages. Although they behave like normal pages for purposes of mapping in CPU page, and for COW. They do not support LRU lists, NUMA migration or THP. The difference between new vm_normal_l

[PATCH] drm/amdkfd: Add SVM API support capability bits

2022-03-30 Thread Alex Sierra
From: Philip Yang SVMAPISupported property added to HSA_CAPABILITY, the value match HSA_CAPABILITY defined in Thunk spec: SVMAPISupported: it will not be supported on older kernels that don't have HMM or on systems with GFXv8 or older GPUs without support for 48-bit virtual addresses. CoherentH

[PATCH 1/2] dt-bindings: display: bridge: lt9211: Add Lontium LT9211 bridge driver

2022-03-30 Thread Marek Vasut
Add bindings for Lontium LT9211 Single/Dual-Link DSI/LVDS or Single DPI to Single-link/Dual-Link DSI/LVDS or Single DPI bridge. This chip is highly capable at converting formats, but sadly it is also highly undocumented. Signed-off-by: Marek Vasut Cc: Laurent Pinchart Cc: Lucas Stach Cc: Maxime

[PATCH 2/2] drm/bridge: lt9211: Add Lontium LT9211 bridge driver

2022-03-30 Thread Marek Vasut
Add driver for Lontium LT9211 Single/Dual-Link DSI/LVDS or Single DPI to Single-link/Dual-Link DSI/LVDS or Single DPI bridge. This chip is highly capable at converting formats, but sadly it is also highly undocumented. This driver is written without any documentation from Lontium and based only on

Re: [PATCH] drm/panel-edp: Fix AUO B133UAN01 panel id

2022-03-30 Thread Doug Anderson
Hi, On Wed, Mar 30, 2022 at 9:04 AM Matthias Kaehlcke wrote: > > Two digits are swapped in the AUO B133UAN01 panel id (0x8495 instead > of 0x8594). This went initially unnoticed because the panel is still > detected, though it is set up with a conservative default timing. Fix > the digit swap. >

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Jani Nikula
On Wed, 30 Mar 2022, Jani Nikula wrote: > On Wed, 30 Mar 2022, Ville Syrjälä wrote: >> This one points to extension blocks too so using >> struct edid doesn't seem entirely appropriate. > > So I've gone back and forth with this. I think I want to get rid of u8* > no matter what, because it alway

[PATCH v2 09/10] drm/msm/gem: Add fenced vma unpin

2022-03-30 Thread Rob Clark
From: Rob Clark With userspace allocated iova (next patch), we can have a race condition where userspace observes the fence completion and deletes the vma before retire_submit() gets around to unpinning the vma. To handle this, add a fenced unpin which drops the refcount but tracks the fence, an

[PATCH v2 10/10] drm/msm: Add a way for userspace to allocate GPU iova

2022-03-30 Thread Rob Clark
From: Rob Clark The motivation at this point is mainly native userspace mesa driver in a VM guest. The one remaining synchronous "hotpath" is buffer allocation, because guest needs to wait to know the bo's iova before it can start emitting cmdstream/state that references the new bo. By allocati

[PATCH v2 07/10] drm/msm/gem: Rework vma lookup and pin

2022-03-30 Thread Rob Clark
From: Rob Clark Combines duplicate vma lookup in the get_and_pin path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 50 ++- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_ge

[PATCH v2 08/10] drm/msm/gem: Split vma lookup and pin

2022-03-30 Thread Rob Clark
From: Rob Clark This way we only lookup vma once per object per submit, for both the submit and retire path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c| 60 +--- drivers/gpu/drm/msm/msm_gem.h| 9 +++-- drivers/gpu/drm/msm/msm_gem_submit.

[PATCH v2 05/10] drm/msm/gem: Drop PAGE_SHIFT for address space mm

2022-03-30 Thread Rob Clark
From: Rob Clark Get rid of all the unnecessary conversion between address/size and page offsets. It just confuses things. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- drivers/gpu/drm/msm/msm_gem.c | 5 ++--- drivers/gpu/dr

[PATCH v2 06/10] drm/msm: Drop msm_gem_iova()

2022-03-30 Thread Rob Clark
From: Rob Clark There was only a single user, which could just as easily stash the iova when pinning. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_fb.c | 16 ++-- drivers/gpu/drm/msm/msm_gem.c | 16 drivers/gpu/drm/msm/msm_ge

[PATCH v2 04/10] drm/msm/gem: Split out inuse helper

2022-03-30 Thread Rob Clark
From: Rob Clark Prep for a following patch, where it gets a bit more complicated. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 2 +- drivers/gpu/drm/msm/msm_gem.h | 1 + drivers/gpu/drm/msm/msm_gem_vma.c | 9 +++-- 3 files changed, 9 insertions(+), 3 deletions(-) d

[PATCH v2 03/10] drm/msm/gem: Convert some missed GEM_WARN_ON()s

2022-03-30 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem_vma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c index f914ddbaea89..64906594fc65 100644 --- a/drivers/gpu/drm/msm/

[PATCH v2 02/10] drm/msm/gpu: Drop duplicate fence counter

2022-03-30 Thread Rob Clark
From: Rob Clark The ring seqno counter duplicates the fence-context last_fence counter. They end up getting incremented in lock-step, on the same scheduler thread, but the split just makes things less obvious. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 +- drivers

[PATCH v2 01/10] drm/msm/gem: Move prototypes

2022-03-30 Thread Rob Clark
From: Rob Clark These belong more cleanly in the gem header. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_drv.h | 23 --- drivers/gpu/drm/msm/msm_gem.h | 22 ++ 2 files changed, 22 insertions(+), 23 deletions(-) di

[PATCH v2 00/10] drm/msm: Userspace allocated GPU addresses

2022-03-30 Thread Rob Clark
From: Rob Clark The first six paches are various cleanups and simplifications. The next two get rid of redundant vma lookups in the submit and retire paths. Following that, fenced vma lets us indicate a fence value following which the vma is no longer used, which is needed because otherwise use

Re: [PATCH] drm: round_up the size to the alignment value

2022-03-30 Thread Arunpravin Paneer Selvam
On 30/03/22 2:42 pm, Christian König wrote: > Am 30.03.22 um 11:20 schrieb Arunpravin Paneer Selvam: >> >> On 30/03/22 2:37 pm, Christian König wrote: >>> Am 30.03.22 um 11:04 schrieb Arunpravin Paneer Selvam: Round up the size value to the min_page_size and trim the last block to the

Re: [igt-dev] [PATCH i-g-t 02/11] tests/i915/drm_fdinfo: Basic and functional tests for GPU busyness exported via fdinfo

2022-03-30 Thread Umesh Nerlige Ramappa
This looks very similar to existing perf_pmu tests with the slight change that the busyness is now captured from the fdinfo. lgtm, Reviewed-by: Umesh Nerlige Ramappa Umesh On Tue, Feb 22, 2022 at 01:55:56PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Mostly inherited from the perf_pm

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread Sascha Hauer
On Wed, Mar 30, 2022 at 09:35:17PM +0200, Piotr Oniszczuk wrote: > > > > Wiadomość napisana przez Sascha Hauer w dniu > > 30.03.2022, o godz. 21:20: > > > >> So i tried following combinations > >> > >> -boot > >> -modetest -s 69@67:1920x1080 -> ok > >> -modetest -P 43@67:1920x1080@NV12 -> gre

Re: [Intel-gfx] [PATCH] drm/i915/guc: Use iosys_map interface to update lrc_desc

2022-03-30 Thread Daniel Vetter
On Wed, Mar 30, 2022 at 08:53:11AM -0700, John Harrison wrote: > Sorry, only just seen this patch. > > Please do not do this! > > The entire lrc_desc_pool entity is being dropped as part of the update to > GuC v70. That's why there was a recent patch set to significantly > re-organise how/where i

Re: [Intel-gfx] [PATCH i-g-t 01/11] lib: Helper library for parsing i915 fdinfo output

2022-03-30 Thread Umesh Nerlige Ramappa
On Tue, Feb 22, 2022 at 01:55:55PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Tests and intel_gpu_top will share common code for parsing this file. Signed-off-by: Tvrtko Ursulin --- lib/igt_drm_fdinfo.c | 183 +++ lib/igt_drm_fdinfo.h | 48 ++

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Daniel Vetter
On Thu, Mar 31, 2022 at 12:14:31AM +0530, Jagan Teki wrote: > On Wed, Mar 30, 2022 at 3:27 PM Daniel Vetter wrote: > > > > On Wed, Mar 30, 2022 at 10:52:54AM +0200, Maxime Ripard wrote: > > > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > > > > Hi all, > > > > > > > > I have impleme

[PATCH 2/2] drm/bridge: chrontel-ch7033: Add option for setting byteswap order

2022-03-30 Thread Chris Morgan
From: Chris Morgan Add the option to set the byteswap order in the devicetree. For the official HDMI DIP for the NTC CHIP the byteswap order needs to be RGB, however the driver sets it as BGR. With this patch the driver will remain at BGR unless manually specified via devicetree. Signed-off-by:

[PATCH 1/2] dt-bindings: Add byteswap order to chrontel ch7033

2022-03-30 Thread Chris Morgan
From: Chris Morgan Update dt-binding documentation to add support for setting byteswap of chrontel ch7033. New property name of chrontel,byteswap added to set the byteswap order. This property is optional. Signed-off-by: Chris Morgan --- .../bindings/display/bridge/chrontel,ch7033.yaml

[PATCH 0/2] chrontel-ch7033: Add byteswap order option

2022-03-30 Thread Chris Morgan
From: Chris Morgan This series adds the ability to set the byteswap order in the chrontel ch7033 driver via an optional devicetree node. This is necessary because the HDMI DIP of the NTC CHIP requires a byteswap order that differs from the default value of the driver. Signed-off-by: Chris Morgan

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread Piotr Oniszczuk
> Wiadomość napisana przez Sascha Hauer w dniu > 30.03.2022, o godz. 21:20: > >> So i tried following combinations >> >> -boot >> -modetest -s 69@67:1920x1080 -> ok >> -modetest -P 43@67:1920x1080@NV12 -> green screen > > I have no idea what is going on here. There same commands work for me

Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support

2022-03-30 Thread Sascha Hauer
On Wed, Mar 30, 2022 at 04:52:22PM +0200, Piotr Oniszczuk wrote: > > > > Wiadomość napisana przez Sascha Hauer w dniu > > 30.03.2022, o godz. 12:20: > > > > Does it change anything if you do a "modetest -s 69@67:1920x1080" before > > starting the app? Or if you run "modetest -P 43@67:1920x1080

[PATCH 0/4] drm: ssd130x: Add support for SINO WEALTH SH1106

2022-03-30 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This series adds support for SH1106 to the ssd130x OLED display driver. The SINO WEALTH SH1106 is an OLED display driver that is somewhat compatible with the SSD1306. It supports a slightly wider display, at 132 instead of 128 pixels. The basic commands are the s

[PATCH 1/4] dt-bindings: vendor-prefixes: Add prefix for SINO WEALTH Eletronics Ltd.

2022-03-30 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Add a vendor prefix entry for SINO WEALTH Eletronics Ltd. (http://www.sinowealth.com). Signed-off-by: Chen-Yu Tsai --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefix

[PATCH 2/4] dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106

2022-03-30 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The SINO WEALTH SH1106 is an OLED display driver that is somewhat compatible with the SSD1306. It supports a slightly wider display, at 132 instead of 128 pixels. The basic commands are the same, but the SH1106 doesn't support the horizontal or vertical address modes. Add a co

[PATCH 4/4] drm: ssd130x: Add support for SINO WEALTH SH1106

2022-03-30 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The SINO WEALTH SH1106 is an OLED display driver that is somewhat compatible with the SSD1306. It supports a slightly wider display, at 132 instead of 128 pixels. The basic commands are the same, but the SH1106 doesn't support the horizontal or vertical address modes. Add supp

[PATCH 3/4] drm: ssd130x: Support page addressing mode

2022-03-30 Thread Chen-Yu Tsai
From: Chen-Yu Tsai On the SINO WEALTH SH1106, which is mostly compatible with the SSD1306, only the basic page addressing mode is supported. This addressing mode is not as easy to use compared to the currently supported horizontal addressing mode, as the page address has to be set prior to writin

Re: DRM Master ignoring hotplug event during display switching (QT)

2022-03-30 Thread Jagan Teki
On Wed, Mar 30, 2022 at 3:27 PM Daniel Vetter wrote: > > On Wed, Mar 30, 2022 at 10:52:54AM +0200, Maxime Ripard wrote: > > On Tue, Mar 29, 2022 at 11:38:32PM +0530, Jagan Teki wrote: > > > Hi all, > > > > > > I have implemented runtime display switching in the MIPI switch design > > > where LVDS

Re: [Linaro-mm-sig] [PATCH next] dma-buf/sync-file: do not allow zero size allocations

2022-03-30 Thread Pavel Skripkin
Hi Christian, On 3/30/22 10:09, Christian König wrote: That problem is already fixed with patch 21d139d73f77 dma-buf/sync-file: fix logic error in new fence merge code. Am 30.03.22 um 00:14 schrieb Pavel Skripkin: syzbot reported GPF in dma_fence_array_first(), which is caused by dereferencing

[PATCH] drm/msm/gpu: Avoid -Wunused-function with !CONFIG_PM_SLEEP

2022-03-30 Thread Nathan Chancellor
When building with CONFIG_PM=y and CONFIG_PM_SLEEP=n (such as ARCH=riscv allmodconfig), the following warnings/errors occur: drivers/gpu/drm/msm/adreno/adreno_device.c:679:12: error: 'adreno_system_resume' defined but not used [-Werror=unused-function] 679 | static int adreno_system_resume(

Re: [PATCH 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list

2022-03-30 Thread Lee Jones
On Wed, 30 Mar 2022, Felix Kuehling wrote: > > Am 2022-03-30 um 03:51 schrieb Lee Jones: > > This ensures userspace cannot prematurely clean-up the client before > > it is fully initialised which has been proven to cause issues in the > > past. > > > > Cc: Felix Kuehling > > Cc: Alex Deucher >

Re: [PATCH 3/9] drm/msm/gem: Split out inuse helper

2022-03-30 Thread Rob Clark
On Wed, Mar 30, 2022 at 4:32 AM Dmitry Baryshkov wrote: > > On Wed, 30 Mar 2022 at 02:00, Rob Clark wrote: > > > > From: Rob Clark > > > > Prep for a following patch. While we are at it, convert a few remaining > > WARN_ON()s to GEM_WARN_ON(). > > Well... GEM_WARN_ON doesn't really look like a

Re: [PATCH] drm/edid: fix invalid EDID extension block filtering

2022-03-30 Thread Ville Syrjälä
On Wed, Mar 30, 2022 at 08:04:26PM +0300, Jani Nikula wrote: > The invalid EDID block filtering uses the number of valid EDID > extensions instead of all EDID extensions for looping the extensions in > the copy. This is fine, by coincidence, if all the invalid blocks are at > the end of the EDID. H

Re: [Intel-gfx] [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Jani Nikula
On Wed, 30 Mar 2022, Ville Syrjälä wrote: > I'd fix this up front so we don't end having to backport the whole > thing if/when some security scan gizmo stumbles on this. Sent separately [1]. I'll rebase this series on top once that gets merged, but the conflict is trivial so I think the first rou

[PATCH] drm/edid: fix invalid EDID extension block filtering

2022-03-30 Thread Jani Nikula
The invalid EDID block filtering uses the number of valid EDID extensions instead of all EDID extensions for looping the extensions in the copy. This is fine, by coincidence, if all the invalid blocks are at the end of the EDID. However, it's completely broken if there are invalid extensions in the

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Ville Syrjälä
On Wed, Mar 30, 2022 at 07:28:56PM +0300, Jani Nikula wrote: > On Wed, 30 Mar 2022, Ville Syrjälä wrote: > > On Wed, Mar 30, 2022 at 06:16:17PM +0300, Jani Nikula wrote: > >> On Wed, 30 Mar 2022, Ville Syrjälä wrote: > >> > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: > >> >> Mixi

Re: [PATCH] fbdev: defio: fix the pagelist corruption

2022-03-30 Thread Paul Menzel
[Cc: -jay...@intworks.biz as it bounces] Dear Chuansheng, Am 29.03.22 um 01:58 schrieb Liu, Chuansheng: -Original Message- From: Paul Menzel Sent: Monday, March 28, 2022 2:15 PM Am 28.03.22 um 02:58 schrieb Liu, Chuansheng: -Original Message- Sent: Saturday, March 26,

Re: [PATCH 1/1] drm/amdkfd: Create file descriptor after client is added to smi_clients list

2022-03-30 Thread Felix Kuehling
Am 2022-03-30 um 03:51 schrieb Lee Jones: This ensures userspace cannot prematurely clean-up the client before it is fully initialised which has been proven to cause issues in the past. Cc: Felix Kuehling Cc: Alex Deucher Cc: "Christian König" Cc: "Pan, Xinhui" Cc: David Airlie Cc: Daniel

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Jani Nikula
On Wed, 30 Mar 2022, Ville Syrjälä wrote: > On Wed, Mar 30, 2022 at 06:16:17PM +0300, Jani Nikula wrote: >> On Wed, 30 Mar 2022, Ville Syrjälä wrote: >> > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: >> >> Mixing u8 * and struct edid * is confusing, switch to the latter. >> >> >>

[PATCH] drm/panel-edp: Fix AUO B133UAN01 panel id

2022-03-30 Thread Matthias Kaehlcke
Two digits are swapped in the AUO B133UAN01 panel id (0x8495 instead of 0x8594). This went initially unnoticed because the panel is still detected, though it is set up with a conservative default timing. Fix the digit swap. Fixes: ec57376fba5a ("drm/panel-edp: Add AUO B133UAN01") Signed-off-by: Ma

[PATCH v6 8/8] drm/msm/dp: Handle eDP mode_valid differently from dp

2022-03-30 Thread Sankeerth Billakanti
The panel-edp driver modes needs to be validated differently from DP because the link capabilities are not available for EDP by that time. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/

[PATCH v6 7/8] drm/msm/dp: Support edp/dp without hpd

2022-03-30 Thread Sankeerth Billakanti
Some eDP sinks or platform boards will not support hpd. This patch adds support for those cases. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_catalog.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c b

[PATCH v6 6/8] drm/msm/dp: remove unnecessary delay during boot

2022-03-30 Thread Sankeerth Billakanti
Remove the unnecessary delay in executing the EV_HPD_INIT_SETUP event. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index

[PATCH v6 5/8] drm/msm/dp: prevent multiple votes for dp resources

2022-03-30 Thread Sankeerth Billakanti
The aux_bus support with the dp_display driver will enable the dp resources during msm_dp_modeset_init. The host_init has to return early if the core is already initialized to prevent putting an additional vote for the dp controller resources. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/

[PATCH v6 4/8] drm/msm/dp: avoid handling masked interrupts

2022-03-30 Thread Sankeerth Billakanti
The interrupt register will still reflect the connect and disconnect interrupt status without generating an actual HW interrupt. The controller driver should not handle those masked interrupts. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/msm/dp/dp_catalog.c | 5 +++-- 1 file changed,

[PATCH v6 3/8] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP

2022-03-30 Thread Sankeerth Billakanti
The panel-edp enables the eDP panel power during probe, get_modes and enable. The eDP connect and disconnect interrupts for the eDP/DP controller are directly dependent on panel power. As eDP display can be assumed as always connected, the controller driver can skip the eDP connect and disconnect i

[PATCH v6 2/8] drm/msm/dp: wait for hpd high before aux transaction

2022-03-30 Thread Sankeerth Billakanti
The source device should ensure the sink is ready before proceeding to read the sink capability or performing any aux transactions. The sink will indicate its readiness by asserting the HPD line. The controller driver needs to wait for the hpd line to be asserted by the sink before performing any a

[PATCH v6 1/8] drm/msm/dp: Add eDP support via aux_bus

2022-03-30 Thread Sankeerth Billakanti
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connector is initializ

[PATCH v6 0/8] Add support for the eDP panel over aux_bus

2022-03-30 Thread Sankeerth Billakanti
This series adds support for generic eDP panel over aux_bus. These changes are dependent on the following series in order: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=620127&state=* https://patchwork.kernel.org/project/linux-arm-msm/list/?series=616587&state=* https://patchwork

Re: [PATCH] drm/i915/guc: Use iosys_map interface to update lrc_desc

2022-03-30 Thread John Harrison
Sorry, only just seen this patch. Please do not do this! The entire lrc_desc_pool entity is being dropped as part of the update to GuC v70. That's why there was a recent patch set to significantly re-organise how/where it is used. That patch set explicitly said - this is all in preparation fo

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Ville Syrjälä
On Wed, Mar 30, 2022 at 06:16:17PM +0300, Jani Nikula wrote: > On Wed, 30 Mar 2022, Ville Syrjälä wrote: > > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: > >> Mixing u8 * and struct edid * is confusing, switch to the latter. > >> > >> Cc: Ville Syrjälä > >> Signed-off-by: Jani Ni

Re: [PATCH 01/12] drm/edid: use struct edid * in drm_do_get_edid()

2022-03-30 Thread Jani Nikula
On Wed, 30 Mar 2022, Ville Syrjälä wrote: > On Tue, Mar 29, 2022 at 09:42:08PM +0300, Jani Nikula wrote: >> Mixing u8 * and struct edid * is confusing, switch to the latter. >> >> Cc: Ville Syrjälä >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/drm_edid.c | 31 +++-

  1   2   >