Re: [PATCH 1/2] Enable buddy memory manager support

2021-09-21 Thread Christian König
Am 20.09.21 um 21:20 schrieb Arunpravin: Port Intel buddy system manager to drm root folder Add CPU mappable/non-mappable region support to the drm buddy manager And where is the patch to switch i915 and remove the Intel copy of this? In general I think that every public function here needs a

Re: [PATCH 2/2] Add drm buddy manager support to amdgpu driver

2021-09-21 Thread Christian König
Am 21.09.21 um 17:51 schrieb Paneer Selvam, Arunpravin: [AMD Public Use] Hi Christian, Please find my comments. A better mail client might be helpful for mailing list communication. I use Thunderbird, but Outlook with appropriate setting should do as well. Thanks, Arun -Original Messa

Re: [RESEND] [PATCH v2 1/2] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX

2021-09-21 Thread Geert Uytterhoeven
Hi Laurent, On Wed, Sep 22, 2021 at 3:27 AM Laurent Pinchart wrote: > On Tue, Sep 21, 2021 at 05:53:52PM +0200, Geert Uytterhoeven wrote: > > On Wed, Jul 28, 2021 at 6:26 PM Laurent Pinchart wrote: > > > The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It > > > can operate in

Re: [PATCH v1] drm/i915/bdb: Fix version check

2021-09-21 Thread Radosław Biernacki
- dropping stable ... > > diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h > > b/drivers/gpu/drm/i915/display/intel_vbt_defs.h > > index 330077c2e588..fff456bf8783 100644 > > --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h > > +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h > >

[PATCH] drm/bridge: cdns-dsi: Make sure to to create proper aliases for dt

2021-09-21 Thread Nishanth Menon
Add MODULE_DEVICE_TABLE to the device tree table to create required aliases needed for module to be loaded with device tree based platform. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Nishanth Menon --- drivers/gpu/drm/bridge/cdns-dsi.c | 1 + 1 file changed, 1 inse

[PATCH v6 9/9] HAX: drm/i915/gem: Fix the __i915_gem_is_lmem() function

2021-09-21 Thread Thomas Hellström
Signed-off-by: Thomas Hellström --- drivers/gpu/drm/i915/gem/i915_gem_lmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_lmem.c b/drivers/gpu/drm/i915/gem/i915_gem_lmem.c index d659239fcbcc..444f8268b9c5 100644 --- a/drivers/gpu/drm/i915/

[PATCH v6 8/9] HAX: component: do not leave master devres group open after bind

2021-09-21 Thread Thomas Hellström
From: Kai Vehmanen In current code, the devres group for aggregate master is left open after call to component_master_add_*(). This leads to problems when the master does further managed allocations on its own. When any participating driver calls component_del(), this leads to immediate release o

[PATCH v6 5/9] drm/i915/gt: Register the migrate contexts with their engines

2021-09-21 Thread Thomas Hellström
Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the pin

[PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

2021-09-21 Thread Thomas Hellström
With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test case after executing around 800-900 of 1000 submitted requests. Given the time we allow elsewhere for fences to signal (in the order of seconds), increase the timeout before we mark the gt wedged

[PATCH v6 7/9] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-21 Thread Thomas Hellström
We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for objects that need early restores using memcpy and a way to assign LMEM page-table object fl

[PATCH v6 6/9] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-21 Thread Thomas Hellström
Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up either. Introduce a new object flag, I915_BO_ALLOC_PM_VOLATILE meaning that an object is allowed to lose its content on suspend. v3: - Slight document

[PATCH v6 4/9] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-21 Thread Thomas Hellström
Just evict unpinned objects to system. For pinned LMEM objects, make a backup system object and blit the contents to that. Backup is performed in three steps, 1: Opportunistically evict evictable objects using the gpu blitter. 2: After gt idle, evict evictable objects using the gpu blitter. This w

[PATCH v6 2/9] drm/i915/gem: Implement a function to process all gem objects of a region

2021-09-21 Thread Thomas Hellström
An upcoming common pattern is to traverse the region object list and perform certain actions on all objects in a region. It's a little tricky to get the list locking right, in particular since a gem object may change region unless it's pinned or the object lock is held. Define a function that does

[PATCH v6 1/9] drm/i915/ttm: Implement a function to copy the contents of two TTM-based objects

2021-09-21 Thread Thomas Hellström
When backing up or restoring contents of pinned objects at suspend / resume time we need to allocate a new object as the backup. Add a function to facilitate copies between the two. Some data needs to be copied before the migration context is ready for operation, so make sure we can disable acceler

[PATCH v6 0/9] drm/i915: Suspend / resume backup- and restore of LMEM.

2021-09-21 Thread Thomas Hellström
Implement backup and restore of LMEM during suspend / resume. What complicates things a bit is handling of pinned LMEM memory during suspend and the fact that we might be dealing with unmappable LMEM in the future, which makes us want to restrict the number of pinned objects that need memcpy resume

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-21 Thread Rob Clark
On Tue, Sep 21, 2021 at 7:18 PM Andrey Grodzovsky wrote: > > > On 2021-09-21 4:47 p.m., Rob Clark wrote: > > On Tue, Sep 21, 2021 at 1:09 PM Andrey Grodzovsky > > wrote: > >> On 2021-09-03 2:47 p.m., Rob Clark wrote: > >> > >>> From: Rob Clark > >>> > >>> As the finished fence is the one that is

Re: [Freedreno] [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers

2021-09-21 Thread abhinavk
Hi Sean On 2021-09-15 13:38, Sean Paul wrote: From: Sean Paul Hello again, This is the second version of the HDCP helper patchset. See version 1 here: https://patchwork.freedesktop.org/series/94623/ In this second version, I've fixed up the oopsies exposed by 0-day and yamllint and incorporat

Re: [PATCH v3] mdacon: fix redefinition of 'scr_memsetw'

2021-09-21 Thread Jackie Liu
ping, would anyone take this patch? 在 2021/9/15 上午9:13, Jackie Liu 写道: From: Jackie Liu CONFIG_VGA_CONSOLE=n and CONFIG_MDA_CONSOLE=n will cause vt_buffer.h not include . But if we set CONFIG_MDA_CONSOLE=m, mdacon.c include is in front of include . VT_BUF_HAVE_MEMSETW is not defined, so vt_b

Re: [PATCH v2 2/2] drm/panel: Add Sony Tulip Truly NT35521 driver

2021-09-21 Thread Shawn Guo
On Tue, Aug 24, 2021 at 09:59:04PM +0200, Sam Ravnborg wrote: > On Tue, Aug 24, 2021 at 10:58:31AM +0800, Shawn Guo wrote: > > On Mon, Aug 09, 2021 at 01:10:08PM +0800, Shawn Guo wrote: > > > It adds a DRM panel driver for Sony Tulip Truly NT35521 5.24" 1280x720 > > > DSI panel, which can be found

Re: [Freedreno] [PATCH v2 08/13] drm/msm/dpu_kms: Re-order dpu includes

2021-09-21 Thread abhinavk
On 2021-09-15 13:38, Sean Paul wrote: From: Sean Paul Make includes alphabetical in dpu_kms.c Signed-off-by: Sean Paul Reviewed-by: Abhinav Kumar Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-9-s...@poorly.run #v1 Changes in v2: -None --- drivers/gpu/drm/msm/di

Re: [Freedreno] [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

2021-09-21 Thread abhinavk
On 2021-09-15 13:38, Sean Paul wrote: From: Sean Paul This patch adds HDCP 1.x support to msm DP connectors using the new HDCP helpers. Cc: Stephen Boyd Signed-off-by: Sean Paul Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-s...@poorly.run #v1 Changes in v2:

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-21 Thread Andrey Grodzovsky
On 2021-09-21 4:47 p.m., Rob Clark wrote: On Tue, Sep 21, 2021 at 1:09 PM Andrey Grodzovsky wrote: On 2021-09-03 2:47 p.m., Rob Clark wrote: From: Rob Clark As the finished fence is the one that is exposed to userspace, and therefore the one that other operations, like atomic update, woul

[PATCH] drm/i915: Drop stealing of bits from i915_sw_fence function pointer

2021-09-21 Thread Matthew Brost
Rather than stealing bits from i915_sw_fence function pointer use seperate fields for function pointer and flags. If using two different fields, the 4 byte alignment for the i915_sw_fence function pointer can also be dropped. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/display/intel_di

[PATCH] drm/i915: fix blank screen booting crashes

2021-09-21 Thread Matthew Brost
From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive at different and surprising "culprits", none of them the actual culprit. netconsole (with init_netconsole() hacked to call i915_init() when logging has

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-21 Thread Matthew Brost
On Tue, Sep 21, 2021 at 04:29:31PM -0700, Lucas De Marchi wrote: > On Tue, Sep 21, 2021 at 03:55:15PM -0700, Matthew Brost wrote: > > On Tue, Sep 21, 2021 at 11:46:37AM -0700, Lucas De Marchi wrote: > > > On Tue, Sep 21, 2021 at 10:43:32AM -0700, Matthew Brost wrote: > > > > From: Hugh Dickins > >

Re: [PATCH v2 2/2] drm: rcar-du: Add R-Car DSI driver

2021-09-21 Thread Laurent Pinchart
Hi Andrzej, On Tue, Sep 21, 2021 at 09:42:11PM +0200, Andrzej Hajda wrote: > W dniu 23.06.2021 o 15:56, Laurent Pinchart pisze: > > From: LUU HOAI > > > > The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U > > SoC. It currently supports DSI mode only. > > > > Signed-off-by:

Re: [RESEND] [PATCH v2 1/2] dt-bindings: display: bridge: Add binding for R-Car MIPI DSI/CSI-2 TX

2021-09-21 Thread Laurent Pinchart
Hi Geert, On Tue, Sep 21, 2021 at 05:53:52PM +0200, Geert Uytterhoeven wrote: > On Wed, Jul 28, 2021 at 6:26 PM Laurent Pinchart wrote: > > The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It > > can operate in either DSI or CSI-2 mode, with up to four data lanes. > > > > Sign

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-09-21 Thread Stephen Rothwell
Hi Nathan, On Tue, 21 Sep 2021 15:58:23 -0700 Nathan Chancellor wrote: > > On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > > DP 2.0 brings some new DPCD addresses for PHY repeaters. > > > > Cc: dri-devel@lists.freedesktop.org > > Reviewed-by: Manasi Navare > > Signed-off-by: Jani

Re: [PATCH v6 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-21 Thread Stephen Boyd
Quoting Philip Chen (2021-09-21 11:06:17) > Implement the first version of AUX support, which will be useful as > we expand the driver to support varied use cases. > > Reviewed-by: Sam Ravnborg > Signed-off-by: Philip Chen > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-21 Thread Stephen Boyd
Quoting Philip Chen (2021-09-21 11:06:16) > Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs, > which will simplify the future update on ps8640 driver. > > Reviewed-by: Douglas Anderson > Acked-by: Sam Ravnborg > Signed-off-by: Philip Chen > --- Reviewed-by: Stephen Boyd

[PATCH v11 00/17] drm/i915: Introduce Intel PXP

2021-09-21 Thread Alan Previn
PXP (Protected Xe Path) is an i915 component, available on GEN12 and newer platforms, that helps to establish the hardware protected session and manage the status of the alive software session, as well as its life cycle. changes from v10: - Added v10 delta into history of patches that changed in v

Re: [PATCH v5 13/16] drm/mediatek: add ETHDR support for MT8195

2021-09-21 Thread Chun-Kuang Hu
Hi, Nancy: Nancy.Lin 於 2021年9月6日 週一 下午3:15寫道: > > ETHDR is a part of ovl_adaptor. > ETHDR is designed for HDR video and graphics conversion in the external > display path. It handles multiple HDR input types and performs tone > mapping, color space/color format conversion, and then combine > diff

Re: [Freedreno] [PATCH v2 04/13] drm/hdcp: Expand HDCP helper library for enable/disable/check

2021-09-21 Thread abhinavk
On 2021-09-15 13:38, Sean Paul wrote: From: Sean Paul This patch expands upon the HDCP helper library to manage HDCP enable, disable, and check. Previous to this patch, the majority of the state management and sink interaction is tucked inside the Intel driver with the understanding that once

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-21 Thread Lucas De Marchi
On Tue, Sep 21, 2021 at 03:55:15PM -0700, Matthew Brost wrote: On Tue, Sep 21, 2021 at 11:46:37AM -0700, Lucas De Marchi wrote: On Tue, Sep 21, 2021 at 10:43:32AM -0700, Matthew Brost wrote: > From: Hugh Dickins > > 5.15-rc1 crashes with blank screen when booting up on two ThinkPads > using i91

[PATCH v3 10/12] drm/virtio: implement context init: handle VIRTGPU_CONTEXT_PARAM_POLL_RINGS_MASK

2021-09-21 Thread Gurchetan Singh
For the Sommelier guest Wayland proxy, it's desirable for the DRM fd to be pollable in response to an host compositor event. This can also be used by the 3D driver to poll events on a CPU timeline. This enables the DRM fd associated with a particular 3D context to be polled independent of KMS even

[PATCH v3 07/12] drm/virtio: implement context init: plumb {base_fence_ctx, ring_idx} to virtio_gpu_fence_alloc

2021-09-21 Thread Gurchetan Singh
These were defined in the previous commit. We'll need these parameters when allocating a dma_fence. The use case for this is multiple synchronizations timelines. The maximum number of timelines per 3D instance will be 32. Usually, only 2 are needed -- one for CPU commands, and another for GPU com

[PATCH v3 06/12] drm/virtio: implement context init: track {ring_idx, emit_fence_info} in virtio_gpu_fence

2021-09-21 Thread Gurchetan Singh
Each fence should be associated with a [fence ID, fence_context, seqno]. The seqno number is just the fence id. To get the fence context, we add the ring_idx to the 3D context's base_fence_ctx. The ring_idx is between 0 and 31, inclusive. Each 3D context will have it's own base_fence_ctx. The r

[PATCH v3 08/12] drm/virtio: implement context init: stop using drv->context when creating fence

2021-09-21 Thread Gurchetan Singh
The plumbing is all here to do this. Since we always use the default fence context when allocating a fence, this makes no functional difference. We can't process just the largest fence id anymore, since it's it's associated with different timelines. It's fine for fence_id 260 to signal before 25

[PATCH v3 12/12] drm/virtio: implement context init: advertise feature to userspace

2021-09-21 Thread Gurchetan Singh
This advertises the context init feature to userspace, along with a mask of supported capabilities. Signed-off-by: Gurchetan Singh Acked-by: Lingfeng Yang --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

[PATCH v3 11/12] drm/virtio: implement context init: add virtio_gpu_fence_event

2021-09-21 Thread Gurchetan Singh
Similar to DRM_VMW_EVENT_FENCE_SIGNALED. Sends a pollable event to the DRM file descriptor when a fence on a specific ring is signaled. One difference is the event is not exposed via the UAPI -- this is because host responses are on a shared memory buffer of type BLOB_MEM_GUEST [this is the commo

[PATCH v3 05/12] drm/virtio: implement context init: support init ioctl

2021-09-21 Thread Gurchetan Singh
From: Anthoine Bourgeois This implements the context initialization ioctl. A list of params is passed in by userspace, and kernel driver validates them. The only currently supported param is VIRTGPU_CONTEXT_PARAM_CAPSET_ID. If the context has already been initialized, -EEXIST is returned. This

[PATCH v3 09/12] drm/virtio: implement context init: allocate an array of fence contexts

2021-09-21 Thread Gurchetan Singh
We don't want fences from different 3D contexts (virgl, gfxstream, venus) to be on the same timeline. With explicit context creation, we can specify the number of ring each context wants. Execbuffer can specify which ring to use. Signed-off-by: Gurchetan Singh Acked-by: Lingfeng Yang --- driv

[PATCH v3 03/12] drm/virtio: implement context init: track valid capabilities in a mask

2021-09-21 Thread Gurchetan Singh
The valid capability IDs are between 1 to 63, and defined in the virtio gpu spec. This is used for error checking the subsequent patches. We're currently only using 2 capability IDs, so this should be plenty for the immediate future. Signed-off-by: Gurchetan Singh Acked-by: Lingfeng Yang ---

[PATCH v3 04/12] drm/virtio: implement context init: probe for feature

2021-09-21 Thread Gurchetan Singh
From: Anthoine Bourgeois Let's probe for VIRTIO_GPU_F_CONTEXT_INIT. Create a new DRM_INFO(..) line since the current one is getting too long. Signed-off-by: Anthoine Bourgeois Acked-by: Lingfeng Yang --- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 1 + drivers/gpu/drm/virtio/virtgpu_drv.c

[PATCH v3 02/12] drm/virtgpu api: create context init feature

2021-09-21 Thread Gurchetan Singh
This change allows creating contexts of depending on set of context parameters. The meaning of each of the parameters is listed below: 1) VIRTGPU_CONTEXT_PARAM_CAPSET_ID This determines the type of a context based on the capability set ID. For example, the current capsets: VIRTIO_GPU_CAPSET_VI

[PATCH v3 01/12] virtio-gpu api: multiple context types with explicit initialization

2021-09-21 Thread Gurchetan Singh
This feature allows for each virtio-gpu 3D context to be created with a "context_init" variable. This variable can specify: - the type of protocol used by the context via the capset id. This is useful for differentiating virgl, gfxstream, and venus protocols by host userspace. - other th

[PATCH v3 00/12] Context types, v3

2021-09-21 Thread Gurchetan Singh
Version 2 of context types: https://lists.oasis-open.org/archives/virtio-dev/202108/msg00141.html Changes since RFC: * le32 info --> {u8 ring_idx + u8 padding[3]). * Max rings is now 64. Changes since v1: * Document plan regarding context types + display combinations that need impl

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-21 Thread Matthew Brost
On Tue, Sep 21, 2021 at 11:46:37AM -0700, Lucas De Marchi wrote: > On Tue, Sep 21, 2021 at 10:43:32AM -0700, Matthew Brost wrote: > > From: Hugh Dickins > > > > 5.15-rc1 crashes with blank screen when booting up on two ThinkPads > > using i915. Bisections converge convincingly, but arrive at dif

Re: [Intel-gfx] [PATCH v3 03/13] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-09-21 Thread Nathan Chancellor
On Thu, Sep 09, 2021 at 03:51:55PM +0300, Jani Nikula wrote: > DP 2.0 brings some new DPCD addresses for PHY repeaters. > > Cc: dri-devel@lists.freedesktop.org > Reviewed-by: Manasi Navare > Signed-off-by: Jani Nikula > --- > include/drm/drm_dp_helper.h | 4 > 1 file changed, 4 insertions(

Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-09-21 Thread Rob Clark
On Tue, Sep 21, 2021 at 3:20 PM Doug Anderson wrote: > > Hi, > > On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I don't see an obvious better way. > > > > v2: Remove er

Re: [PATCH v2 6/6] drm/i915/dg2: Add DG2-specific shadow register table

2021-09-21 Thread Lucas De Marchi
On Fri, Sep 10, 2021 at 01:10:30PM -0700, Matt Roper wrote: We thought the DG2 table of shadowed registers would be the same as the gen12/xehp table, but it turns out that there are a few minor differences that require us to define a new DG2-specific table: * One register is removed (0xC4D4) * On

Re: [PATCH v2 3/3] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2021-09-21 Thread Doug Anderson
Hi, On Mon, Sep 20, 2021 at 3:53 PM Rob Clark wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > v2: Remove error return with NO_CONNECTOR flag > > Signed-off-by: Rob Clark > --- > dr

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-21 Thread Kirill A. Shutemov
On Tue, Sep 21, 2021 at 04:43:59PM -0500, Tom Lendacky wrote: > On 9/21/21 4:34 PM, Kirill A. Shutemov wrote: > > On Tue, Sep 21, 2021 at 11:27:17PM +0200, Borislav Petkov wrote: > > > On Wed, Sep 22, 2021 at 12:20:59AM +0300, Kirill A. Shutemov wrote: > > > > I still believe calling cc_platform_ha

Re: [RFC PATCH] component: do not leave master devres group open after bind

2021-09-21 Thread Russell King (Oracle)
On Tue, Sep 21, 2021 at 02:18:10PM +0300, Kai Vehmanen wrote: > In current code, the devres group for aggregate master is left open > after call to component_master_add_*(). This leads to problems when the > master does further managed allocations on its own. When any > participating driver calls c

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-21 Thread Tom Lendacky
On 9/21/21 4:34 PM, Kirill A. Shutemov wrote: On Tue, Sep 21, 2021 at 11:27:17PM +0200, Borislav Petkov wrote: On Wed, Sep 22, 2021 at 12:20:59AM +0300, Kirill A. Shutemov wrote: I still believe calling cc_platform_has() from __startup_64() is totally broken as it lacks proper wrapping while ac

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-21 Thread Kirill A. Shutemov
On Tue, Sep 21, 2021 at 11:27:17PM +0200, Borislav Petkov wrote: > On Wed, Sep 22, 2021 at 12:20:59AM +0300, Kirill A. Shutemov wrote: > > I still believe calling cc_platform_has() from __startup_64() is totally > > broken as it lacks proper wrapping while accessing global variables. > > Well, one

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-21 Thread Borislav Petkov
On Wed, Sep 22, 2021 at 12:20:59AM +0300, Kirill A. Shutemov wrote: > I still believe calling cc_platform_has() from __startup_64() is totally > broken as it lacks proper wrapping while accessing global variables. Well, one of the issues on the AMD side was using boot_cpu_data too early and the In

[PATCH] video: fbdev: gbefb: Only instantiate device when built for IP32

2021-09-21 Thread Mark Brown
The gbefb driver not only registers a driver but also the device for that driver. This is all well and good when run on the IP32 machines that are supported by the driver but since the driver supports building with COMPILE_TEST we might also be building on other platforms which do not have this har

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-21 Thread Kirill A. Shutemov
On Tue, Sep 21, 2021 at 07:47:15PM +0200, Borislav Petkov wrote: > On Tue, Sep 21, 2021 at 12:04:58PM -0500, Tom Lendacky wrote: > > Looks like instrumentation during early boot. I worked with Boris offline to > > exclude arch/x86/kernel/cc_platform.c from some of the instrumentation and > > that a

Re: [Freedreno] [PATCH] drm/msm/dsi: do not install irq handler before power up the host

2021-09-21 Thread abhinavk
On 2021-09-21 10:47, Dmitry Baryshkov wrote: Hi, On Tue, 21 Sept 2021 at 20:01, wrote: On 2021-09-21 09:22, Dmitry Baryshkov wrote: > The DSI host might be left in some state by the bootloader. If this > state generates an IRQ, it might hang the system by holding the > interrupt line before t

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-21 Thread Rob Clark
On Tue, Sep 21, 2021 at 1:09 PM Andrey Grodzovsky wrote: > > On 2021-09-03 2:47 p.m., Rob Clark wrote: > > > From: Rob Clark > > > > As the finished fence is the one that is exposed to userspace, and > > therefore the one that other operations, like atomic update, would > > block on, we need to p

[PATCH v2] drm/msm/dsi: do not enable irq handler before powering up the host

2021-09-21 Thread Dmitry Baryshkov
The DSI host might be left in some state by the bootloader. If this state generates an IRQ, it might hang the system by holding the interrupt line before the driver sets up the DSI host to the known state. Move the request_irq into msm_dsi_host_init and pass IRQF_NO_AUTOEN to it. Call enable/disab

Re: [PATCH v3 4/9] drm/scheduler: Add fence deadline support

2021-09-21 Thread Andrey Grodzovsky
On 2021-09-03 2:47 p.m., Rob Clark wrote: From: Rob Clark As the finished fence is the one that is exposed to userspace, and therefore the one that other operations, like atomic update, would block on, we need to propagate the deadline from from the finished fence to the actual hw fence. v2:

Re: [PATCH v2 2/2] drm: rcar-du: Add R-Car DSI driver

2021-09-21 Thread Andrzej Hajda
W dniu 23.06.2021 o 15:56, Laurent Pinchart pisze: > From: LUU HOAI > > The driver supports the MIPI DSI/CSI-2 TX encoder found in the R-Car V3U > SoC. It currently supports DSI mode only. > > Signed-off-by: LUU HOAI > Signed-off-by: Laurent Pinchart > Reviewed-by: Kieran Bingham > Tested-by:

Re: [Intel-gfx] [PATCH 19/27] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-09-21 Thread Matthew Brost
On Tue, Sep 21, 2021 at 03:49:53PM +0100, Tvrtko Ursulin wrote: > > On 20/09/2021 23:57, John Harrison wrote: > > On 8/20/2021 15:44, Matthew Brost wrote: > > > Set number of engines before attempting to create contexts so the > > > function free_engines can clean up properly. > > > > > > Fixes:

Re: [Intel-gfx] [PATCH 19/27] drm/i915: Fix bug in user proto-context creation that leaked contexts

2021-09-21 Thread Matthew Brost
On Mon, Sep 20, 2021 at 03:57:06PM -0700, John Harrison wrote: > On 8/20/2021 15:44, Matthew Brost wrote: > > Set number of engines before attempting to create contexts so the > > function free_engines can clean up properly. > > > > Fixes: d4433c7600f7 ("drm/i915/gem: Use the proto-context to hand

Re: [PATCH v2] drm/rockchip: cdn-dp-core: Fix cdn_dp_resume unused warning

2021-09-21 Thread Heiko Stübner
Hi, Am Dienstag, 21. September 2021, 17:04:10 CEST schrieb Palmer Dabbelt: > On Tue, 21 Sep 2021 02:12:17 PDT (-0700), he...@sntech.de wrote: > > On Fri, 10 Sep 2021 20:43:18 -0700, Palmer Dabbelt wrote: > >> cdn_dp_resume is only used under PM_SLEEP, and now that it's static an > >> unused functi

BoF at LPC: Documenting the Heterogeneous Memory Model Architecture

2021-09-21 Thread Felix Kuehling
As the programming models for GPU-based high-performance computing applications are evolving, HMM is helping us integrate the GPU memory management more closely with the kernel's virtual memory management. As a result we can provide a shared virtual address space with demand-paging and page-bas

Re: [Intel-gfx] [PATCH 18/27] drm/i915/guc: Update debugfs for GuC multi-lrc

2021-09-21 Thread Matthew Brost
On Mon, Sep 20, 2021 at 03:48:59PM -0700, John Harrison wrote: > > > On 8/20/2021 15:44, Matthew Brost wrote: > > Display the workqueue status in debugfs for GuC contexts that are in > > parent-child relationship. > > > > Signed-off-by: Matthew Brost > > --- > > .../gpu/drm/i915/gt/uc/intel_g

Re: [PATCH v6 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-21 Thread Doug Anderson
Hi, On Tue, Sep 21, 2021 at 11:06 AM Philip Chen wrote: > > Implement the first version of AUX support, which will be useful as > we expand the driver to support varied use cases. > > Reviewed-by: Sam Ravnborg > Signed-off-by: Philip Chen Reviewed-by: Douglas Anderson Snoozing for 2 days and

Re: [Intel-gfx] [PATCH] drm/i915: fix blank screen booting crashes

2021-09-21 Thread Lucas De Marchi
On Tue, Sep 21, 2021 at 10:43:32AM -0700, Matthew Brost wrote: From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive at different and surprising "culprits", none of them the actual culprit. netconsole (w

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #71 from youling...@gmail.com --- (In reply to James Zhu from comment #70) > My mistaake. Can you try add pci=noats in boot parameters? no help, still resume failed. -- You may reply to this email to add a comment. You are receivin

Re: [PATCH] drm/msm/dsi: do not install irq handler before power up the host

2021-09-21 Thread Andrzej Hajda
W dniu 21.09.2021 o 18:22, Dmitry Baryshkov pisze: > The DSI host might be left in some state by the bootloader. If this > state generates an IRQ, it might hang the system by holding the > interrupt line before the driver sets up the DSI host to the known > state. > > Move the request/free_irq call

Re: [PATCH] MAINTAINERS: fix typo in DRM DRIVER FOR SAMSUNG S6D27A1 PANELS

2021-09-21 Thread Linus Walleij
On Tue, Sep 21, 2021 at 2:22 PM Lukas Bulwahn wrote: > Commit ebd8cbf1fb96 ("drm/panel: s6d27a1: Add driver for Samsung S6D27A1 > display panel") introduces a new section DRM DRIVER FOR SAMSUNG S6D27A1 > PANELS with a minor typo in one of its file entries. > > Hence, ./scripts/get_maintainer.pl -

Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-21 Thread Philip Chen
Hi On Tue, Sep 21, 2021 at 9:02 AM Doug Anderson wrote: > > Hi, > > On Sat, Sep 18, 2021 at 10:21 AM Philip Chen wrote: > > > > +static ssize_t ps8640_aux_transfer(struct drm_dp_aux *aux, > > + struct drm_dp_aux_msg *msg) > > +{ > > + struct ps8640 *ps_brid

[PATCH v6 2/2] drm/bridge: parade-ps8640: Add support for AUX channel

2021-09-21 Thread Philip Chen
Implement the first version of AUX support, which will be useful as we expand the driver to support varied use cases. Reviewed-by: Sam Ravnborg Signed-off-by: Philip Chen --- Changes in v6: - Error check the aux address is no greater than 20 bits - Read RDATA into a u32 variable and then copy t

[PATCH v6 1/2] drm/bridge: parade-ps8640: Use regmap APIs

2021-09-21 Thread Philip Chen
Replace the direct i2c access (i2c_smbus_* functions) with regmap APIs, which will simplify the future update on ps8640 driver. Reviewed-by: Douglas Anderson Acked-by: Sam Ravnborg Signed-off-by: Philip Chen --- (no changes since v4) Changes in v4: - Remove excessive error logging from the pr

Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-21 Thread Harry Wentland
On 2021-09-21 09:31, Pekka Paalanen wrote: > On Mon, 20 Sep 2021 20:14:50 -0400 > Harry Wentland wrote: > >> On 2021-09-15 10:01, Pekka Paalanen wrote:> On Fri, 30 Jul 2021 16:41:29 >> -0400 >>> Harry Wentland wrote: >>> Use the new DRM RFC doc section to capture the RFC previously o

Re: [PATCH v3 8/9] dma-buf/sync_file: Add SET_DEADLINE ioctl

2021-09-21 Thread Rob Clark
On Wed, Sep 8, 2021 at 2:10 PM Daniel Vetter wrote: > > On Wed, Sep 8, 2021 at 9:36 PM Rob Clark wrote: > > On Wed, Sep 8, 2021 at 11:49 AM Daniel Vetter wrote: > > > On Wed, Sep 08, 2021 at 11:23:42AM -0700, Rob Clark wrote: > > > > On Wed, Sep 8, 2021 at 10:50 AM Daniel Vetter wrote: > > > >

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #70 from James Zhu (jam...@amd.com) --- My mistaake. Can you try add pci=noats in boot parameters? -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.

[PATCH v5 5/7] drm/i915/gt: Register the migrate contexts with their engines

2021-09-21 Thread Thomas Hellström
Pinned contexts, like the migrate contexts need reset after resume since their context image may have been lost. Also the GuC needs to register pinned contexts. Add a list to struct intel_engine_cs where we add all pinned contexts on creation, and traverse that list at resume time to reset the pin

[PATCH v5 7/7] drm/i915: Reduce the number of objects subject to memcpy recover

2021-09-21 Thread Thomas Hellström
We really only need memcpy restore for objects that affect the operability of the migrate context. That is, primarily the page-table objects of the migrate VM. Add an object flag, I915_BO_ALLOC_PM_EARLY for objects that need early restores using memcpy and a way to assign LMEM page-table object fl

[PATCH v5 6/7] drm/i915: Don't back up pinned LMEM context images and rings during suspend

2021-09-21 Thread Thomas Hellström
Pinned context images are now reset during resume. Don't back them up, and assuming that rings can be assumed empty at suspend, don't back them up either. Introduce a new object flag, I915_BO_ALLOC_PM_VOLATILE meaning that an object is allowed to lose its content on suspend. v3: - Slight document

[PATCH v5 3/7] drm/i915/gt: Increase suspend timeout

2021-09-21 Thread Thomas Hellström
With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test case after executing around 800-900 of 1000 submitted requests. Given the time we allow elsewhere for fences to signal (in the order of seconds), increase the timeout before we mark the gt wedged

[PATCH v5 2/7] drm/i915/gem: Implement a function to process all gem objects of a region

2021-09-21 Thread Thomas Hellström
An upcoming common pattern is to traverse the region object list and perform certain actions on all objects in a region. It's a little tricky to get the list locking right, in particular since a gem object may change region unless it's pinned or the object lock is held. Define a function that does

[PATCH v5 4/7] drm/i915 Implement LMEM backup and restore for suspend / resume

2021-09-21 Thread Thomas Hellström
Just evict unpinned objects to system. For pinned LMEM objects, make a backup system object and blit the contents to that. Backup is performed in three steps, 1: Opportunistically evict evictable objects using the gpu blitter. 2: After gt idle, evict evictable objects using the gpu blitter. This w

[PATCH v5 1/7] drm/i915/ttm: Implement a function to copy the contents of two TTM-based objects

2021-09-21 Thread Thomas Hellström
When backing up or restoring contents of pinned objects at suspend / resume time we need to allocate a new object as the backup. Add a function to facilitate copies between the two. Some data needs to be copied before the migration context is ready for operation, so make sure we can disable acceler

[PATCH v5 0/7] drm/i915: Suspend / resume backup- and restore of LMEM.

2021-09-21 Thread Thomas Hellström
Implement backup and restore of LMEM during suspend / resume. What complicates things a bit is handling of pinned LMEM memory during suspend and the fact that we might be dealing with unmappable LMEM in the future, which makes us want to restrict the number of pinned objects that need memcpy resume

[PATCH] drm/i915: fix blank screen booting crashes

2021-09-21 Thread Matthew Brost
From: Hugh Dickins 5.15-rc1 crashes with blank screen when booting up on two ThinkPads using i915. Bisections converge convincingly, but arrive at different and surprising "culprits", none of them the actual culprit. netconsole (with init_netconsole() hacked to call i915_init() when logging has

Re: [PATCH v3 5/8] x86/sme: Replace occurrences of sme_active() with cc_platform_has()

2021-09-21 Thread Borislav Petkov
On Tue, Sep 21, 2021 at 12:04:58PM -0500, Tom Lendacky wrote: > Looks like instrumentation during early boot. I worked with Boris offline to > exclude arch/x86/kernel/cc_platform.c from some of the instrumentation and > that allowed an allyesconfig to boot. And here's the lineup I have so far, I'd

Re: [Freedreno] [PATCH] drm/msm/dsi: do not install irq handler before power up the host

2021-09-21 Thread Dmitry Baryshkov
Hi, On Tue, 21 Sept 2021 at 20:01, wrote: > > On 2021-09-21 09:22, Dmitry Baryshkov wrote: > > The DSI host might be left in some state by the bootloader. If this > > state generates an IRQ, it might hang the system by holding the > > interrupt line before the driver sets up the DSI host to the k

Re: [RFC PATCH] component: do not leave master devres group open after bind

2021-09-21 Thread Imre Deak
On Tue, Sep 21, 2021 at 02:18:10PM +0300, Kai Vehmanen wrote: > In current code, the devres group for aggregate master is left open > after call to component_master_add_*(). This leads to problems when the > master does further managed allocations on its own. When any > participating driver calls c

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #69 from youling...@gmail.com --- (In reply to James Zhu from comment #67) > (In reply to youling257 from comment #66) > > resume failed record video, > > https://drive.google.com/drive/folders/1bWMC4ByGvudC9zBk-9Xgamz- > > shir0pqX?us

[Bug 211277] sometimes crash at s2ram-wake (Ryzen 3500U): amdgpu, drm, commit_tail, amdgpu_dm_atomic_commit_tail

2021-09-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211277 --- Comment #68 from youling...@gmail.com --- (In reply to James Zhu from comment #67) > (In reply to youling257 from comment #66) > > resume failed record video, > > https://drive.google.com/drive/folders/1bWMC4ByGvudC9zBk-9Xgamz- > > shir0pqX?us

Re: [PATCH v2 2/2] dt-bindings: display: Add binding for LG.Philips SW43101

2021-09-21 Thread Rob Herring
On Thu, 09 Sep 2021 04:40:27 +, Yassine Oudjana wrote: > Add a device tree binding for LG.Philips SW43101. > > Signed-off-by: Yassine Oudjana > --- > Changes since v1: > - Add regulator support. > - Add MAINTAINERS entry. > - Dual-license DT binding. > > .../display/panel/lgphilips,sw431

Re: [PATCH v2 5/6] drm/i915/uncore: Drop gen11 mmio read handlers

2021-09-21 Thread Lucas De Marchi
On Fri, Sep 10, 2021 at 01:10:29PM -0700, Matt Roper wrote: Consolidate down to just a single 'fwtable' implementation. For reads we don't need to worry about shadow tables. Also, the NEEDS_FORCE_WAKE() check we previously had in the fwtable implementation can be dropped --- if a register is ou

[PATCH 23/26] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

2021-09-21 Thread Christian König
Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/g

[PATCH 22/26] drm/nouveau: use the new iterator in nouveau_fence_sync

2021-09-21 Thread Christian König
Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[PATCH 25/26] drm/etnaviv: replace dma_resv_get_excl_unlocked

2021-09-21 Thread Christian König
We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine

2021-09-21 Thread Christian König
This is maybe even a fix since the RCU usage here looks incorrect. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_object.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915

  1   2   3   >