Re: [PATCH] dyndbg: add special aux_print framework

2021-07-31 Thread kernel test robot
Hi Jim, I love your patch! Yet something to improve: [auto build test ERROR on tegra-drm/drm/tegra/for-next] [also build test ERROR on linux/master linus/master v5.14-rc3 next-20210730] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

Re: [PATCH v6] drm/panel: Add support for E Ink VB3300-KCA

2021-07-31 Thread Sam Ravnborg
Hi Alistair, On Sun, Aug 01, 2021 at 10:47:00AM +1000, Alistair Francis wrote: > Add support for the 10.3" E Ink panel described at: > https://www.eink.com/product.html?type=productdetail&id=7 > > Signed-off-by: Alistair Francis > Acked-by: Rob Herring > Reviewed-by: Sam Ravnborg Thanks for yo

Re: [PATCH] dyndbg: add special aux_print framework

2021-07-31 Thread kernel test robot
Hi Jim, I love your patch! Yet something to improve: [auto build test ERROR on tegra-drm/drm/tegra/for-next] [also build test ERROR on linux/master linus/master v5.14-rc3 next-20210730] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest t

[PATCH v4 2/2] dt-bindings: mediatek: add force_dsi_end_without_null

2021-07-31 Thread Jitao Shi
The force_dsi_end_without_null requires the dsi host ent at the same time in line. Signed-off-by: Jitao Shi --- .../bindings/display/bridge/analogix,anx7625.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625

[PATCH v4 1/2] drm/mediatek: force hsa hbp hfp packets multiple of lanenum to avoid screen shift

2021-07-31 Thread Jitao Shi
The bridge chip ANX7625 requires the packets on lanes aligned at the end, or ANX7625 will shift the screen. Signed-off-by: Jitao Shi --- drivers/gpu/drm/mediatek/mtk_dsi.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/med

[PATCH] dyndbg: add special aux_print framework

2021-07-31 Thread Jim Cromie
Sean Paul seanp...@chromium.org proposed, in https://patchwork.freedesktop.org/series/78133/ drm/trace: Mirror DRM debug logs to tracefs The problem with the approach is that its built upon splitting drm_debug_enabled() into syslog & trace flavors, which clashes rather profoundly with the strategy

[PATCH] dyndbg: add special aux_print framework

2021-07-31 Thread Jim Cromie
Sean Paul seanp...@chromium.org proposed, in https://patchwork.freedesktop.org/series/78133/ drm/trace: Mirror DRM debug logs to tracefs The problem with the approach is that its built upon splitting drm_debug_enabled() into syslog & trace flavors, which clashes rather profoundly with the strategy

Re: [PATCH v2 2/5] dt-bindings: mediatek: display: Change format to yaml

2021-07-31 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月29日 週四 下午11:49寫道: > > Change mediatek,dislpay.txt to mediatek,display.yaml > > Signed-off-by: jason-jh.lin > --- > .../display/mediatek/mediatek,disp.txt| 219 - > .../display/mediatek/mediatek,disp.yaml | 432 ++ > 2 files

[PATCH v6] drm/panel: Add support for E Ink VB3300-KCA

2021-07-31 Thread Alistair Francis
Add support for the 10.3" E Ink panel described at: https://www.eink.com/product.html?type=productdetail&id=7 Signed-off-by: Alistair Francis Acked-by: Rob Herring Reviewed-by: Sam Ravnborg --- v6: - Rebase on linux-next .../bindings/display/panel/panel-simple.yaml | 2 ++ .../devicetree/b

Re: [PATCH v5 1/6] arm64: dts: mt8195: add display node for vdosys0

2021-07-31 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月30日 週五 上午1:07寫道: > > Add display node for vdosys0. > > Signed-off-by: jason-jh.lin > --- > This patch is based on [1][2][3][4] > > [1]arm64: dts: Add Mediatek SoC MT8195 and evaluation board dts and Makefile > - > https://patchwork.kernel.org/project/linux-media

Re: [PATCH v5 6/6] drm/mediatek: add MERGE support for mt8195

2021-07-31 Thread Chun-Kuang Hu
Hi, Jason: jason-jh.lin 於 2021年7月30日 週五 上午1:07寫道: > > Add MERGE module file: > > MERGE module is used to merge two slice-per-line inputs > into one side-by-side output. > > Signed-off-by: jason-jh.lin > --- > This patch is base on [1] > > [1]add mt8195 SoC DRM binding > - https://patchwork.kerne

Re: [PATCH 0/8] arm: ep93xx: CCF conversion

2021-07-31 Thread Linus Walleij
On Mon, Jul 26, 2021 at 1:51 PM Nikita Shubin wrote: > This series series of patches converts ep93xx to Common Clock Framework. > > It consists of preparation patches to use clk_prepare_enable where it is > needed, instead of clk_enable used in ep93xx drivers prior to CCF and > a patch converting

[PATCH v4 7/7] amdgpu: define a dydbg-bitmap to control categorized pr_debugs

2021-07-31 Thread Jim Cromie
logger_types.h defines many DC_LOG_*() categorized debug wrappers. Many of these use DRM_DEBUG_*, so are controllable using drm.debug, but others use bare pr_debug()s, each with a different class-prefix matching "^[\w+]:" Use DYNDBG_BITMAP_DESC() to create a parameter/debug_dc, and to define bits

[PATCH v4 6/7] drm/print: add choice to use dynamic debug in drm-debug

2021-07-31 Thread Jim Cromie
drm's debug system writes 10 distinct categories of messages to syslog using a small API[1]: drm_dbg*(10 names), DRM_DEBUG*(8 names), DRM_DEV_DEBUG*(3 names). There are thousands of these callsites, each categorized by their authors. ~2100 are on my laptop. These callsites are enabled at runtime

[PATCH v4 5/7] i915/gvt: control pr_debug("gvt:")s with bits in parameters/debug_gvt

2021-07-31 Thread Jim Cromie
The gvt component of this driver has ~120 pr_debugs, in 9 "classes". Following the interface model of drm.debug, add a parameter to map bits to these classes. If CONFIG_DRM_USE_DYNAMIC_DEBUG=y (and CONFIG_DYNAMIC_DEBUG_CORE), add -DDYNAMIC_DEBUG_MODULE into Makefile. TBD: maybe add a separate CON

[PATCH v4 4/7] i915/gvt: remove spaces in pr_debug "gvt: core:" etc prefixes

2021-07-31 Thread Jim Cromie
Collapsing "gvt: core: " to "gvt:core: " is a better class-prefix; dropping the internal spaces means a trailing space in a query will more clearly terminate the prefix. Consider a generic drm-debug example: # turn off most ATOMIC reports echo format "^drm:atomic: " -p > control # turn off

[PATCH v4 3/7] dyndbg: add dyndbg-bitmap definer and callbacks

2021-07-31 Thread Jim Cromie
Add DEFINE_DYNDBG_BITMAP(name, var, bitmap_desc, @bit_descs) to allow users to define a /sys/module/*/parameter/name, and a mapping from bits[0-N] to the debug-class-prefixes that the author wishes to control. DEFINE_DYNDBG_BITMAP(debug_gvt, __gvt_debug, "dyndbg bitmap desc", { "gv

[PATCH v4 2/7] moduleparam: add data member to struct kernel_param

2021-07-31 Thread Jim Cromie
Add a void* data member to the struct, to allow attaching private data that will be used soon by a setter method (via kp->data) to perform more elaborate actions. To attach the data at compile time, add new macros: module_param_cbd() derives from module_param_cb(), adding data param. It calls __mo

[PATCH v4 1/7] drm/print: fixup spelling in a comment

2021-07-31 Thread Jim Cromie
s/prink/printk/ - no functional changes Signed-off-by: Jim Cromie --- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h index 9b66be54dd16..15a089a87c22 100644 --- a/include/drm/drm_print.h +++ b/include/

[PATCH v4 0/7] drm: use dyndbg in drm_print

2021-07-31 Thread Jim Cromie
hi all, Apologies for broad --to, but it touches a wide range, if casually. In order to avoid runtime costs of drm_debug_enabled(), this patchset re-implements drm.debug to use dyndbg, after extending dyndbg with kernel_param_ops to implement the bitmap->dydnbg-query and expose it for use. To de

Re: [PATCH] drm/pl111: Remove unused including

2021-07-31 Thread Sam Ravnborg
Hi Cai, On Tue, Jul 27, 2021 at 01:21:07PM +0800, Cai Huoqing wrote: > Remove including that don't need it. > > Signed-off-by: Cai Huoqing thanks! Applied to drm-misc-next. The patch will show up in -next is a week or two. Sam

Re: [PATCH 00/14] drm: Make DRM's IRQ helpers legacy

2021-07-31 Thread Sam Ravnborg
Hi Thomas, On Tue, Jul 27, 2021 at 08:27:07PM +0200, Thomas Zimmermann wrote: > DRM's IRQ helpers are only helpful for old, non-KMS drivers. Move > the code behind CONFIG_DRM_LEGACY. Convert KMS drivers to Linux > IRQ interfaces. > > DRM provides IRQ helpers for setting up, receiving and removing

Re: [PATCH v5] drm/panel: Add support for E Ink VB3300-KCA

2021-07-31 Thread Sam Ravnborg
Hi Alistair, On Fri, Jul 30, 2021 at 10:13:10PM +1000, Alistair Francis wrote: > Add support for the 10.3" E Ink panel described at: > https://www.eink.com/product.html?type=productdetail&id=7 > > Signed-off-by: Alistair Francis > Acked-by: Rob Herring > Reviewed-by: Sam Ravnborg > --- > v5: >

Re: [PATCH v4] drm/panel: Add support for E Ink VB3300-KCA

2021-07-31 Thread Sam Ravnborg
Hi Alistair, On Thu, Jul 29, 2021 at 08:33:58PM +1000, Alistair Francis wrote: > Add support for the 10.3" E Ink panel described at: > https://www.eink.com/product.html?type=productdetail&id=7 > > Signed-off-by: Alistair Francis > Acked-by: Rob Herring > --- > v4: > - Fixup alphebetical sortin

Re: [PATCH v2 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel

2021-07-31 Thread Sam Ravnborg
Hi Douglas, On Fri, Jul 30, 2021 at 08:45:59AM -0700, Douglas Anderson wrote: > > The overall goal of this series is to make the Samsung ATNA33XC20 > panel work more properly. As part of this, we have: > * A bugfix for the recently abstracted DP AUX backlight code. > * A bugfix for the sequencing

Re: [PATCH v2 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel

2021-07-31 Thread Sam Ravnborg
Hi Douglas, On Fri, Jul 30, 2021 at 08:45:59AM -0700, Douglas Anderson wrote: > > The overall goal of this series is to make the Samsung ATNA33XC20 > panel work more properly. As part of this, we have: > * A bugfix for the recently abstracted DP AUX backlight code. > * A bugfix for the sequencing

Re: [PATCH 42/64] net: qede: Use memset_after() for counters

2021-07-31 Thread Kees Cook
On Tue, Jul 27, 2021 at 01:58:33PM -0700, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Use memset_after() so memset() doesn't get confused about writing >

Re: [PATCH 39/64] mac80211: Use memset_after() to clear tx status

2021-07-31 Thread Kees Cook
On Tue, Jul 27, 2021 at 01:58:30PM -0700, Kees Cook wrote: > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memset(), avoid intentionally writing across > neighboring fields. > > Use memset_after() so memset() doesn't get confused about writing >

Re: [PATCH 47/64] btrfs: Use memset_after() to clear end of struct

2021-07-31 Thread Kees Cook
On Thu, Jul 29, 2021 at 12:33:37PM +0200, David Sterba wrote: > On Wed, Jul 28, 2021 at 02:56:31PM -0700, Kees Cook wrote: > > On Wed, Jul 28, 2021 at 11:42:15AM +0200, David Sterba wrote: > > > On Tue, Jul 27, 2021 at 01:58:38PM -0700, Kees Cook wrote: > > > > In preparation for FORTIFY_SOURCE per

Re: [PATCH 04/64] stddef: Introduce struct_group() helper macro

2021-07-31 Thread Kees Cook
On Sat, Jul 31, 2021 at 07:24:44AM +0200, Rasmus Villemoes wrote: > On Sat, Jul 31, 2021, 04:59 Kees Cook wrote: > > > On Fri, Jul 30, 2021 at 10:19:20PM +, Williams, Dan J wrote: > > > On Wed, 2021-07-28 at 14:59 -0700, Kees Cook wrote: > > > > > /** > > > * struct_group(NAME, MEMBERS) >

Re: [PATCH 54/64] ipv6: Use struct_group() to zero rt6_info

2021-07-31 Thread Kees Cook
On Thu, Jul 29, 2021 at 11:58:50AM -0700, Jakub Kicinski wrote: > On Tue, 27 Jul 2021 13:58:45 -0700 Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memset(), avoid intentionally writing across > > neighboring fields. > > >

Re: [PATCH v2 1/3] staging/fbtft: Remove all strcpy() uses

2021-07-31 Thread Len Baker
On Sun, Jul 25, 2021 at 09:51:18PM +0300, Andy Shevchenko wrote: > On Sun, Jul 25, 2021 at 4:59 PM Len Baker wrote: > > On Sat, Jul 24, 2021 at 11:21:04PM +0300, Andy Shevchenko wrote: > > > On Sat, Jul 24, 2021 at 7:05 PM Len Baker wrote: > > ... > > > > > - char msg[128]; > > > > > > 128

Re: [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning

2021-07-31 Thread Laurent Pinchart
Hi Sergey, On Sat, Jul 31, 2021 at 01:12:58PM +0300, Sergei Shtylyov wrote: > On 31.07.2021 4:39, Laurent Pinchart wrote: > > > On 64-bit platforms, the compiler complains that casting a void pointer > > to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned > > Is "unsigned

Re: [Intel-gfx] [PATCH 11/14] drm/i915/guc/slpc: Cache platform frequency limits

2021-07-31 Thread Michal Wajdeczko
On 30.07.2021 22:21, Vinay Belgaumkar wrote: > Cache rp0, rp1 and rpn platform limits into SLPC structure > for range checking while setting min/max frequencies. > > Also add "soft" limits which keep track of frequency changes > made from userland. These are initially set to platform min > and

Re: [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning

2021-07-31 Thread Sergei Shtylyov
Hello On 31.07.2021 4:39, Laurent Pinchart wrote: On 64-bit platforms, the compiler complains that casting a void pointer to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned Is "unsigned" really needed here? to fix this. Signed-off-by: Laurent Pinchart --- drivers

[PATCH v2 2/2] drm: add lockdep assert to drm_is_current_master_locked

2021-07-31 Thread Desmond Cheong Zhi Xi
In drm_is_current_master_locked, accessing drm_file.master should be protected by either drm_file.master_lookup_lock or drm_device.master_mutex. This was previously awkward to assert with lockdep. Following patch ("locking/lockdep: Provide lockdep_assert{,_once}() helpers"), this assertion is now

[PATCH v2 1/2] locking/lockdep: Provide lockdep_assert{, _once}() helpers

2021-07-31 Thread Desmond Cheong Zhi Xi
From: Peter Zijlstra Extract lockdep_assert{,_once}() helpers to more easily write composite assertions like, for example: lockdep_assert(lockdep_is_held(&drm_device.master_mutex) || lockdep_is_held(&drm_file.master_lookup_lock)); Signed-off-by: Peter Zijlstra (In

[PATCH v2 0/2] locking/lockdep, drm: apply new lockdep assert in drm_auth.c

2021-07-31 Thread Desmond Cheong Zhi Xi
Hi, Following a discussion on the patch ("drm: use the lookup lock in drm_is_current_master") [1], Peter Zijlstra proposed new lockdep_assert helpers to make it convenient to compose lockdep checks together. This series includes the patch that introduces the new lockdep helpers, then utilizes the

[PATCH] drm/amdgpu: fix possible null-pointer dereference in amdgpu_ttm_tt_unpopulate()

2021-07-31 Thread Tuo Li
The variable ttm is assigned to the variable gtt, and the variable gtt is checked in: if (gtt && gtt->userptr) This indicates that both ttm and gtt can be NULL. If so, a null-pointer dereference will occur: if (ttm->page_flags & TTM_PAGE_FLAG_SG) Also, some null-pointer dereferences will occu

[PATCH] drm/amdgpu: fix possible null-pointer dereference in amdgpu_ttm_tt_populate()

2021-07-31 Thread Tuo Li
The variable ttm is assigned to the variable gtt, and the variable gtt is checked in: if (gtt && gtt->userptr) This indicates that both ttm and gtt can be NULL. If so, a null-pointer dereference will occur: if (ttm->page_flags & TTM_PAGE_FLAG_SG) Also, some null-pointer dereferences will occu

[PATCH] scsi: csiostor: fix possible null-pointer dereference in csio_eh_lun_reset_handler()

2021-07-31 Thread Tuo Li
The variable rn is checked in: if (!rn) If rn is NULL, the program goes to the label fail: fail: CSIO_INC_STATS(rn, n_lun_rst_fail); However, rn is dereferenced in this macro: #define CSIO_INC_STATS(elem, val) ((elem)->stats.val++) To fix this possible null-pointer dereference, the fun