Re: [Intel-gfx] [PATCH 30/30] drm/i915: switch num_scalers/num_sprites to consider DISPLAY_VER

2021-07-26 Thread Lucas De Marchi
On Mon, Jul 26, 2021 at 06:13:10AM -0400, Rodrigo Vivi wrote: On Fri, Jul 23, 2021 at 05:11:14PM -0700, Lucas De Marchi wrote: The numbers of scalers and sprites depend on the display version, so use it instead of GRAPHICS_VER. We were mixing both, which let me confused while removing CNL and GR

Re: [PATCH v4 2/4] drm/amd/display: Add control mechanism for FPU

2021-07-26 Thread Christian König
Am 27.07.21 um 02:52 schrieb Rodrigo Siqueira: DC invokes DC_FPU_START/END in multiple parts of the code; this can create a situation where we invoke this FPU operation in a nested way or exit too early. For avoiding this situation, this commit adds a mechanism where dc_fpu_begin/end manages the

Re: [PATCH v4 1/4] drm/amd/display: Move specific DCN2x code that uses FPU to DML

2021-07-26 Thread Christian König
Am 27.07.21 um 02:52 schrieb Rodrigo Siqueira: The display core files rely on FPU, which requires to be compiled with special flags. Ideally, we don't want these FPU operations spread around the DC code; nevertheless, it happens in the current source. This commit introduces a new directory inside

Re: [PATCH 04/30] drm/i915/display: remove explicit CNL handling from intel_cdclk.c

2021-07-26 Thread Lucas De Marchi
On Sat, Jul 24, 2021 at 11:12:07AM -0700, Matt Roper wrote: On Fri, Jul 23, 2021 at 05:10:48PM -0700, Lucas De Marchi wrote: The only real platform with DISPLAY_VER == 10 is GLK, so we don't need any checks and supporting code for CNL. Remove code and rename functions/macros accordingly. Signed

Re: [Internet]Re: [PATCH] fbcon: Out-Of-Bounds write in sys_imageblit, add range check

2021-07-26 Thread gre...@linuxfoundation.org
On Tue, Jul 27, 2021 at 01:53:13AM +, tcs_kernel(腾讯云内核开发者) wrote: > yres and vyres can be controlled by user mode paramaters, and cause p->vrows > to become a negative value. While this value be passed to real_y function, > the ypos will be out of screen range. > This is an out-of-bounds writ

[PATCH] drm/pl111: Remove unused including

2021-07-26 Thread Cai Huoqing
Remove including that don't need it. Signed-off-by: Cai Huoqing --- drivers/gpu/drm/pl111/pl111_display.c | 1 - drivers/gpu/drm/pl111/pl111_drv.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c index b5a885

[PATCH] efi: sysfb_efi: fix build when EFI is not set

2021-07-26 Thread Randy Dunlap
/sysfb_efi.c |2 ++ 1 file changed, 2 insertions(+) --- linext-20210726.orig/drivers/firmware/efi/sysfb_efi.c +++ linext-20210726/drivers/firmware/efi/sysfb_efi.c @@ -332,6 +332,7 @@ static const struct fwnode_operations ef .add_links = efifb_add_links, }; +#ifdef CONFIG_EFI static struct

Re: [PATCH] drm/msm: Fix display fault handling

2021-07-26 Thread Bjorn Andersson
On Wed 07 Jul 11:01 PDT 2021, Rob Clark wrote: > From: Rob Clark > > It turns out that when the display is enabled by the bootloader, we can > get some transient iommu faults from the display. Which doesn't go over > too well when we install a fault handler that is gpu specific. To avoid > thi

[PATCH 0/1] Increase timeout in i915_gem_contexts selftests

2021-07-26 Thread Matthew Brost
Patch says it all. Seeing a failure in CI [1] and locally on certain TGL machines with GuC submission enabled. Let's fix this so we can enable CI on TGL with GuC submission. Signed-off-by: Matthew Brost [1] https://patchwork.freedesktop.org/series/92984/#rev4 Matthew Brost (1): drm/i915/selft

[PATCH 1/1] drm/i915/selftests: Increase timeout in i915_gem_contexts selftests

2021-07-26 Thread Matthew Brost
Like in the case of several other selftests, generating lots of requests in a loop takes a bit longer with GuC submission. Increase a timeout in i915_gem_contexts selftest to take this into account. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 2 +- 1

Re: [PATCH v1 1/5] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-07-26 Thread Jason-JH Lin
Hi Enric, On Mon, 2021-07-26 at 12:08 +0200, Enric Balletbo Serra wrote: > Hi Jason, > > Missatge de Jason-JH Lin del dia dl., 26 > de jul. 2021 a les 9:02: > > > > On Fri, 2021-07-23 at 13:13 +0200, Enric Balletbo Serra wrote: > > > Hi Jason, > > > > > > Thank you for your patch. > > > > > >

[PATCH 2/2] drm/i915/uapi: Add query for hwconfig table

2021-07-26 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interes

[PATCH 0/2] Add support for querying hw info that UMDs need

2021-07-26 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Test-with: 20210727002812.43469-2-john.c.harri...@intel.com UMD: https://github.com/intel/comput

[PATCH 1/2] drm/i915/guc: Add fetch of hwconfig table

2021-07-26 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc: Mich

Re: [Internet]Re: [PATCH] fbcon: Out-Of-Bounds write in sys_imageblit, add range check

2021-07-26 Thread 腾讯云内核开发者
yres and vyres can be controlled by user mode paramaters, and cause p->vrows to become a negative value. While this value be passed to real_y function, the ypos will be out of screen range. This is an out-of-bounds write bug. I think updatescrollmode is the right place to validate values supplied

[PATCH v3] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-07-26 Thread Nicolas Boichat
Many of the DSI flags have names opposite to their actual effects, e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually be disabled. Fix this by including _NO_ in the flag names, e.g. MIPI_DSI_MODE_NO_EOT_PACKET. Signed-off-by: Nicolas Boichat Reviewed-by: Linus Walleij Reviewed-by

[PATCH 1/2] drm/i915/guc: Add fetch of hwconfig table

2021-07-26 Thread John . C . Harrison
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc: Mich

[PATCH 2/2] drm/i915/uapi: Add query for hwconfig table

2021-07-26 Thread John . C . Harrison
From: Rodrigo Vivi GuC contains a consolidated table with a bunch of information about the current device. Previously, this information was spread and hardcoded to all the components including GuC, i915 and various UMDs. The goal here is to consolidate the data into GuC in a way that all interes

[PATCH 0/2] Add support for querying hw info that UMDs need

2021-07-26 Thread John . C . Harrison
From: John Harrison Various UMDs require hardware configuration information about the current platform. A bunch of static information is available in a fixed table that can be retrieved from the GuC. Test-with: 20210727002812.43469-2-john.c.harri...@intel.com UMD: https://github.com/intel/comput

[PATCH v4 3/4] drm/amd/display: Add control mechanism for FPU utilization

2021-07-26 Thread Rodrigo Siqueira
DC invokes DC_FPU_START/END in multiple parts of the code; this can create a situation where we invoke this FPU operation in a nested way or exit too early. For avoiding this situation, this commit adds a mechanism where dc_fpu_begin/end manages the access to kernel_fpu_begin/end. Change since V3:

[PATCH v4 1/4] drm/amd/display: Move specific DCN2x code that uses FPU to DML

2021-07-26 Thread Rodrigo Siqueira
The display core files rely on FPU, which requires to be compiled with special flags. Ideally, we don't want these FPU operations spread around the DC code; nevertheless, it happens in the current source. This commit introduces a new directory inside DML for centralizing shared DCN functions that r

[PATCH v4 4/4] drm/amd/display: Add DC_FP helper to check FPU state

2021-07-26 Thread Rodrigo Siqueira
To fully isolate FPU operations in a single place, we must avoid situations where compilers spill FP values to registers due to FP enable in a specific C file. Note that even if we isolate all FPU functions in a single file and call its interface from other files, the compiler might enable the use

[PATCH v4 2/4] drm/amd/display: Add control mechanism for FPU

2021-07-26 Thread Rodrigo Siqueira
DC invokes DC_FPU_START/END in multiple parts of the code; this can create a situation where we invoke this FPU operation in a nested way or exit too early. For avoiding this situation, this commit adds a mechanism where dc_fpu_begin/end manages the access to kernel_fpu_begin/end. Change since V3:

[PATCH v4 0/4] drm/amd/display: Introduce FPU directory inside DC

2021-07-26 Thread Rodrigo Siqueira
Hi, In the display core, we utilize floats and doubles units for calculating modesetting parameters. One side effect of our approach to use double-precision is the fact that we spread multiple FPU access across our driver, which means that we can accidentally clobber user space FPU state. # Chal

Re: [RESEND PATCH v6 14/14] drm/print: Add tracefs support to the drm logging helpers

2021-07-26 Thread Rodrigo Siqueira
On 07/21, Sean Paul wrote: > From: Sean Paul > > This patch adds a new module parameter called drm.trace which accepts > the same mask as drm.debug. When a debug category is enabled, log > messages will be put in a new tracefs instance called drm for > consumption. > > Using the new tracefs inst

Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread maitreye
Thank you Stephen for reviewing. On 2021-07-26 14:31, Stephen Boyd wrote: Quoting maitreye (2021-07-26 10:36:26) @@ -509,6 +515,7 @@ static int dp_display_usbpd_attention_cb(struct device *dev) DRM_ERROR("invalid dev\n"); return -EINVAL; } + DRM_DE

[PATCH v6] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread maitreye
From: Maitreyee Rao Add trace points across the MSM DP driver to help debug interop issues. Changes in v2: - Got rid of redundant log messages. - Added %#x instead of 0x%x wherever required. - Got rid of __func__ calls in debug messages. - Added newline wherever missing. Changes in v3: - G

Re: [PATCH v2] arm64: dts: qcom: sc7280: Add gpu support

2021-07-26 Thread Stephen Boyd
Quoting Akhil P Oommen (2021-07-24 10:29:00) > Add the necessary dt nodes for gpu support in sc7280. > > Signed-off-by: Akhil P Oommen > --- > This patch has dependency on the GPUCC bindings patch here: > https://patchwork.kernel.org/project/linux-arm-msm/patch/1619519590-3019-4-git-send-email-t..

[PATCH 16/33] drm/i915/guc: Don't complain about reset races

2021-07-26 Thread Matthew Brost
From: John Harrison It is impossible to seal all race conditions of resets occurring concurrent to other operations. At least, not without introducing excesive mutex locking. Instead, don't complain if it occurs. In particular, don't complain if trying to send a H2G during a reset. Whatever the H

[PATCH 19/33] drm/i915/guc: Fix for error capture after full GPU reset with GuC

2021-07-26 Thread Matthew Brost
From: John Harrison In the case of a full GPU reset (e.g. because GuC has died or because GuC's hang detection has been disabled), the driver can't rely on GuC reporting the guilty context. Instead, the driver needs to scan all active contexts and find one that is currently executing, as per the

[PATCH 33/33] drm/i915/guc: Unblock GuC submission on Gen11+

2021-07-26 Thread Matthew Brost
From: Daniele Ceraolo Spurio Unblock GuC submission on Gen11+ platforms. v2: (Martin Peres / John H) - Delete debug message when GuC is disabled by default on certain platforms Signed-off-by: Michal Wajdeczko Signed-off-by: Daniele Ceraolo Spurio Signed-off-by: Matthew Brost Reviewed-

[PATCH 29/33] drm/i915/selftest: Increase some timeouts in live_requests

2021-07-26 Thread Matthew Brost
Requests may take slightly longer with GuC submission, let's increase the timeouts in live_requests. Signed-off-by: Matthew Brost --- drivers/gpu/drm/i915/selftests/i915_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_request.

[PATCH 27/33] drm/i915/selftest: Fix workarounds selftest for GuC submission

2021-07-26 Thread Matthew Brost
From: Rahul Kumar Singh When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison Signed-off-by: Matth

[PATCH 18/33] drm/i915/guc: Capture error state on context reset

2021-07-26 Thread Matthew Brost
We receive notification of an engine reset from GuC at its completion. Meaning GuC has potentially cleared any HW state we may have been interested in capturing. GuC resumes scheduling on the engine post-reset, as the resets are meant to be transparent, further muddling our error state. There is o

[PATCH 23/33] drm/i915/guc: Add golden context to GuC ADS

2021-07-26 Thread Matthew Brost
From: John Harrison The media watchdog mechanism involves GuC doing a silent reset and continue of the hung context. This requires the i915 driver provide a golden context to GuC in the ADS. v2: (Matthew Brost): - Fix memory corruption in shmem_read (John H) - Use locals rather than define

[PATCH 11/33] drm/i915/guc: Suspend/resume implementation for new interface

2021-07-26 Thread Matthew Brost
The new GuC interface introduces an MMIO H2G command, INTEL_GUC_ACTION_RESET_CLIENT, which is used to implement suspend. This MMIO tears down any active contexts generating a context reset G2H CTB for each. Once that step completes the GuC tears down the CTB channels. It is safe to suspend once thi

[PATCH 09/33] drm/i915: Reset GPU immediately if submission is disabled

2021-07-26 Thread Matthew Brost
If submission is disabled by the backend for any reason, reset the GPU immediately in the heartbeat code as the backend can't be reenabled until the GPU is reset. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- .../gpu/drm/i915/gt/intel_engine_heartbeat.c | 62 +++

[PATCH 03/33] drm/i915: Hold reference to intel_context over life of i915_request

2021-07-26 Thread Matthew Brost
Hold a reference to the intel_context over life of an i915_request. Without this an i915_request can exist after the context has been destroyed (e.g. request retired, context closed, but user space holds a reference to the request from an out fence). In the case of GuC submission + virtual engine,

[PATCH 30/33] drm/i915/selftest: Fix hangcheck self test for GuC submission

2021-07-26 Thread Matthew Brost
From: John Harrison When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Conversely, one of the tests specifically sends hanging batches to the engines but wants

[PATCH 26/33] drm/i915/selftest: Better error reporting from hangcheck selftest

2021-07-26 Thread Matthew Brost
From: John Harrison There are many ways in which the hangcheck selftest can fail. Very few of them actually printed an error message to say what happened. So, fill in the missing messages. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost Cc: Daniele Ceraolo

[PATCH 32/33] drm/i915/guc: Implement GuC priority management

2021-07-26 Thread Matthew Brost
Implement a simple static mapping algorithm of the i915 priority levels (int, -1k to 1k exposed to user) to the 4 GuC levels. Mapping is as follows: i915 level < 0 -> GuC low level (3) i915 level == 0 -> GuC normal level (2) i915 level < INT_MAX-> GuC high level(1) i9

[PATCH 20/33] drm/i915/guc: Hook GuC scheduling policies up

2021-07-26 Thread Matthew Brost
From: John Harrison Use the official driver default scheduling policies for configuring the GuC scheduler rather than a bunch of hardcoded values. v2: (Matthew Brost) - Move I915_ENGINE_WANT_FORCED_PREEMPTION to later patch Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed

[PATCH 28/33] drm/i915/selftest: Fix MOCS selftest for GuC submission

2021-07-26 Thread Matthew Brost
From: Rahul Kumar Singh When GuC submission is enabled, the GuC controls engine resets. Rather than explicitly triggering a reset, the driver must submit a hanging context to GuC and wait for the reset to occur. Signed-off-by: Rahul Kumar Singh Signed-off-by: John Harrison Signed-off-by: Matth

[PATCH 02/33] drm/i915/guc: Make hangcheck work with GuC virtual engines

2021-07-26 Thread Matthew Brost
From: John Harrison The serial number tracking of engines happens at the backend of request submission and was expecting to only be given physical engines. However, in GuC submission mode, the decomposition of virtual to physical engines does not happen in i915. Instead, requests are submitted to

[PATCH 13/33] drm/i915/guc: Handle engine reset failure notification

2021-07-26 Thread Matthew Brost
GuC will notify the driver, via G2H, if it fails to reset an engine. We recover by resorting to a full GPU reset. v2: (John Harrison): - s/drm_dbg/drm_err Signed-off-by: Matthew Brost Signed-off-by: Fernando Pacheco Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h

[PATCH 21/33] drm/i915/guc: Connect reset modparam updates to GuC policy flags

2021-07-26 Thread Matthew Brost
From: John Harrison Changing the reset module parameter has no effect on a running GuC. The corresponding entry in the ADS must be updated and then the GuC informed via a Host2GuC message. The new debugfs interface to module parameters allows this to happen. However, connecting the parameter dat

[PATCH 25/33] drm/i915/guc: Support request cancellation

2021-07-26 Thread Matthew Brost
This adds GuC backend support for i915_request_cancel(), which in turn makes CONFIG_DRM_I915_REQUEST_TIMEOUT work. This implementation makes use of fence while there are likely simplier options. A fence was chosen because of another feature coming soon which requires a user to block on a context u

[PATCH 17/33] drm/i915/guc: Enable GuC engine reset

2021-07-26 Thread Matthew Brost
From: John Harrison Clear the 'disable resets' flag to allow GuC to reset hung contexts (detected via pre-emption timeout). Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 3 +-- 1 file changed, 1 insertion

[PATCH 14/33] drm/i915/guc: Enable the timer expired interrupt for GuC

2021-07-26 Thread Matthew Brost
The GuC can implement execution qunatums, detect hung contexts and other such things but it requires the timer expired interrupt to do so. Signed-off-by: Matthew Brost CC: John Harrison Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_rps.c | 4 1 file changed, 4 insertions(+)

[PATCH 22/33] drm/i915/guc: Include scheduling policies in the debugfs state dump

2021-07-26 Thread Matthew Brost
From: John Harrison Added the scheduling policy parameters to the 'guc_info' debugfs state dump. Signed-off-by: John Harrison Signed-off-by: Matthew Brost Reviewed-by: Matthew Brost --- drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 14 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_a

[PATCH 31/33] drm/i915/selftest: Bump selftest timeouts for hangcheck

2021-07-26 Thread Matthew Brost
From: John Harrison Some testing environments and some heavier tests are slower than previous limits allowed for. For example, it can take multiple seconds for the 'context has been reset' notification handler to reach the 'kill the requests' code in the 'active' version of the 'reset engines' te

[PATCH 15/33] drm/i915/guc: Provide mmio list to be saved/restored on engine reset

2021-07-26 Thread Matthew Brost
From: John Harrison The driver must provide GuC with a list of mmio registers that should be saved/restored during a GuC-based engine reset. Unfortunately, the list must be dynamically allocated as its size is variable. That means the driver must generate the list twice - once to work out the siz

[PATCH 24/33] drm/i915/guc: Implement banned contexts for GuC submission

2021-07-26 Thread Matthew Brost
When using GuC submission, if a context gets banned disable scheduling and mark all inflight requests as complete. Cc: John Harrison Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- drivers/gpu/drm/i915/gt/intel_context.h

[PATCH 12/33] drm/i915/guc: Handle context reset notification

2021-07-26 Thread Matthew Brost
GuC will issue a reset on detecting an engine hang and will notify the driver via a G2H message. The driver will service the notification by resetting the guilty context to a simple state or banning it completely. v2: (John Harrison) - Move msg[0] lookup after length check v3: (John Harrison)

[PATCH 10/33] drm/i915/guc: Add disable interrupts to guc sanitize

2021-07-26 Thread Matthew Brost
Add disable GuC interrupts to intel_guc_sanitize(). Part of this requires moving the guc_*_interrupt wrapper function into header file intel_guc.h. Signed-off-by: Matthew Brost Cc: Daniele Ceraolo Spurio Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 16 +++

[PATCH 06/33] drm/i915: Add i915_sched_engine destroy vfunc

2021-07-26 Thread Matthew Brost
This is required to allow backend specific cleanup v2: (John H) - Rework commit message Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/i915_scheduler.c | 3 ++- drivers/gpu/drm/i915/i915_scheduler.h | 4 +--- drivers/gpu/drm/i915/i915_scheduler_

[PATCH 07/33] drm/i915: Move active request tracking to a vfunc

2021-07-26 Thread Matthew Brost
Move active request tracking to a backend vfunc rather than assuming all backends want to do this in the manner. In the of case execlists / ring submission the tracking is on the physical engine while with GuC submission it is on the context. Signed-off-by: Matthew Brost Reviewed-by: John Harriso

[PATCH 01/33] drm/i915/guc: GuC virtual engines

2021-07-26 Thread Matthew Brost
Implement GuC virtual engines. Rather simple implementation, basically just allocate an engine, setup context enter / exit function to virtual engine specific functions, set all other variables / functions to guc versions, and set the engine mask to that of all the siblings. v2: Update to work wit

[PATCH 08/33] drm/i915/guc: Reset implementation for new GuC interface

2021-07-26 Thread Matthew Brost
Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a fallback and this code path is also required

[PATCH 05/33] drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs

2021-07-26 Thread Matthew Brost
With GuC virtual engines the physical engine which a request executes and completes on isn't known to the i915. Therefore we can't attach a request to a physical engines breadcrumbs. To work around this we create a single breadcrumbs per engine class when using GuC submission and direct all physica

[PATCH 00/33] Remaining patches for basic GuC submission

2021-07-26 Thread Matthew Brost
The remaining patches for basic GuC submission [1]. Need 1 more RB and CI results to get this merged. v2: (Checkpatch) - Fix checkpatch warning (1 remaining overrulled) (Daniele) - Use an outer lock in guc_context_block / unblock Signed-off-by: Matthew Brost [1] https://patchwork.freedesk

[PATCH 04/33] drm/i915/guc: Disable bonding extension with GuC submission

2021-07-26 Thread Matthew Brost
Update the bonding extension to return -ENODEV when using GuC submission as this extension fundamentally will not work with the GuC submission interface. Signed-off-by: Matthew Brost Reviewed-by: John Harrison --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 + 1 file changed, 5 insertio

Re: [PATCH 2/5] drm/msm/dp: Modify prototype of encoder based API

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:32) > Functions in the DisplayPort code that relates to individual instances > (encoders) are passed both the struct msm_dp and the struct drm_encoder. But > in a situation where multiple DP instances would exist this means that > the caller need to resolve

Re: [PATCH 5/5] drm/msm/dp: Add sc8180x DP controllers

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:36) > The sc8180x has 2 DP and 1 eDP controllers, add support for these to the > DP driver. > > Link: > https://lore.kernel.org/linux-arm-msm/20210511042043.592802-5-bjorn.anders...@linaro.org/ > Signed-off-by: Bjorn Andersson > --- > drivers/gpu/drm/msm

Re: [PATCH 4/5] dt-bindings: msm/dp: Add SC8180x compatibles

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:35) > The Qualcomm SC8180x has 2 DP controllers and 1 eDP controller, add > compatibles for these to the msm/dp binding. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd

Re: [RFC 0/4] dma-fence: Deadline awareness

2021-07-26 Thread Rob Clark
On Mon, Jul 26, 2021 at 4:34 PM Rob Clark wrote: > > From: Rob Clark > > Based on discussion from a previous series[1] to add a "boost" mechanism > when, for example, vblank deadlines are missed. Instead of a boost > callback, this approach adds a way to set a deadline on the fence, by > which t

Re: [PATCH 3/5] drm/msm/dp: Support up to 3 DP controllers

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:33) > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c > b/drivers/gpu/drm/msm/dp/dp_display.c > index 59ffd6c8f41f..92b7646a1bb7 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -238,8 +251,11 @@ static i

[RFC 4/4] drm/scheduler: Add fence deadline support

2021-07-26 Thread Rob Clark
From: Rob Clark As the finished fence is the one that is exposed to userspace, and therefore the one that other operations, like atomic update, would block on, we need to propagate the deadline from from the finished fence to the actual hw fence. Signed-off-by: Rob Clark --- drivers/gpu/drm/sc

[RFC 3/4] drm/atomic-helper: Set fence deadline for vblank

2021-07-26 Thread Rob Clark
From: Rob Clark For an atomic commit updating a single CRTC (ie. a pageflip) calculate the next vblank time, and inform the fence(s) of that deadline. Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_atomic_helper.c | 36 + 1 file changed, 36 insertions(+) diff --g

[RFC 2/4] drm/vblank: Add helper to get next vblank time

2021-07-26 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/drm_vblank.c | 31 +++ include/drm/drm_vblank.h | 1 + 2 files changed, 32 insertions(+) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index 3417e1ac7918..88c824c294dc 10064

[RFC 1/4] dma-fence: Add deadline awareness

2021-07-26 Thread Rob Clark
From: Rob Clark Add a way to hint to the fence signaler of an upcoming deadline, such as vblank, which the fence waiter would prefer not to miss. This is to aid the fence signaler in making power management decisions, like boosting frequency as the deadline approaches and awareness of missing de

[RFC 0/4] dma-fence: Deadline awareness

2021-07-26 Thread Rob Clark
From: Rob Clark Based on discussion from a previous series[1] to add a "boost" mechanism when, for example, vblank deadlines are missed. Instead of a boost callback, this approach adds a way to set a deadline on the fence, by which the waiter would like to see the fence signalled. I've not yet

Re: [PATCH V3 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select

2021-07-26 Thread Rob Herring
On Mon, Jul 26, 2021 at 11:02:49PM +0200, Marek Vasut wrote: > Decoder input LVDS format is a property of the decoder chip or even > its strapping. Add DT property data-mapping the same way lvds-panel > does, to define the LVDS data mapping. > > Signed-off-by: Marek Vasut > Cc: Laurent Pinchart

Re: [PATCH 10/30] drm/i915/display: remove explicit CNL handling from intel_dmc.c

2021-07-26 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:10:54PM -0700, Lucas De Marchi wrote: > Remove DMC firmware for CNL. > > Signed-off-by: Lucas De Marchi Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_dmc.c | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/di

Re: [PATCH 23/30] drm/i915/gt: remove explicit CNL handling from intel_sseu.c

2021-07-26 Thread Matt Roper
On Fri, Jul 23, 2021 at 05:11:07PM -0700, Lucas De Marchi wrote: > CNL is the only platform with GRAPHICS_VER == 10. With its removal we > don't need to handle that version anymore. > > Also we can now reduce the max number of slices: the call to > intel_sseu_set_info() with the highest number of

[RFC] drm/msm/dp: Allow attaching a drm_panel

2021-07-26 Thread Bjorn Andersson
eDP panels might need some power sequencing and backlight management, so make it possible to associate a drm_panel with a DP instance and prepare and enable the panel accordingly. Signed-off-by: Bjorn Andersson --- This solves my immediate problem on my 8cx laptops, of indirectly controlling the

Re: [PATCH 1/5] drm/msm/dp: Remove global g_dp_display variable

2021-07-26 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-07-24 21:24:31) > As the Qualcomm DisplayPort driver only supports a single instance of > the driver the commonly used struct dp_display is kept in a global > variable. As we introduce additional instances this obviously doesn't > work. > > Replace this with a combinat

Re: [Intel-gfx] [PATCH 08/33] drm/i915/guc: Reset implementation for new GuC interface

2021-07-26 Thread John Harrison
On 7/22/2021 16:54, Matthew Brost wrote: Reset implementation for new GuC interface. This is the legacy reset implementation which is called when the i915 owns the engine hang check. Future patches will offload the engine hang check to GuC but we will continue to maintain this legacy path as a fa

Re: [PATCH v3 2/3] dt-bindings: Add DT bindings for QiShenglong Gopher 2b panel

2021-07-26 Thread Rob Herring
On Mon, Jul 26, 2021 at 01:15:26AM +0300, Artjom Vejsel wrote: > Add DT bindings for QiShenglong Gopher 2b 4.3" 480(RGB)x272 TFT LCD panel. > > Signed-off-by: Artjom Vejsel > --- > .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH v3 1/3] dt-bindings: Add QiShenglong vendor prefix

2021-07-26 Thread Rob Herring
On Mon, 26 Jul 2021 01:15:25 +0300, Artjom Vejsel wrote: > Add vendor prefix for Shenzhen QiShenglong Industrialist Co., Ltd. > QiShenglong is a Chinese manufacturer of handheld gaming consoles, most of > which run (very old) versions of Linux. > QiShenglong is known as Hamy. > > Signed-off-by: Ar

Re: [Intel-gfx] [PATCH 31/47] drm/i915/guc: Reset implementation for new GuC interface

2021-07-26 Thread Matthew Brost
On Thu, Jul 15, 2021 at 10:36:51AM +0100, Tvrtko Ursulin wrote: > > On 24/06/2021 08:05, Matthew Brost wrote: > > Reset implementation for new GuC interface. This is the legacy reset > > implementation which is called when the i915 owns the engine hang check. > > Future patches will offload the en

Re: [PATCH v2] drm/msm/dp: signal audio plugged change at dp_pm_resume

2021-07-26 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-23 09:55:39) > There is a scenario that dp cable is unplugged from DUT during system > suspended will cause audio option state does not match real connection > state. Fix this problem by Signaling audio plugged change with realtime > connection status at dp_pm_resume(

Re: [Intel-gfx] [PATCH 23/51] drm/i915/guc: Direct all breadcrumbs for a class to single breadcrumbs

2021-07-26 Thread Matthew Brost
On Thu, Jul 22, 2021 at 01:46:08PM +0100, Tvrtko Ursulin wrote: > > On 16/07/2021 21:16, Matthew Brost wrote: > > With GuC virtual engines the physical engine which a request executes > > and completes on isn't known to the i915. Therefore we can't attach a > > request to a physical engines breadc

Re: linux-next: build failure due to the drm tree

2021-07-26 Thread Javier Martinez Canillas
Hello Mark, On 7/26/21 11:36 PM, Mark Brown wrote: > Hi all, > > Today's -next fails to build an arm64 allnoconfig: > > aarch64-none-linux-gnu-ld: drivers/firmware/sysfb.o: in function `sysfb_init': > sysfb.c:(.init.text+0xc): undefined reference to `screen_info' > aarch64-none-linux-gnu-ld: dri

linux-next: build failure due to the drm tree

2021-07-26 Thread Mark Brown
Hi all, Today's -next fails to build an arm64 allnoconfig: aarch64-none-linux-gnu-ld: drivers/firmware/sysfb.o: in function `sysfb_init': sysfb.c:(.init.text+0xc): undefined reference to `screen_info' aarch64-none-linux-gnu-ld: drivers/firmware/sysfb.o: relocation R_AARCH64_ADR_PREL_PG_HI21 agai

Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread Stephen Boyd
Quoting maitreye (2021-07-26 10:36:26) > @@ -509,6 +515,7 @@ static int dp_display_usbpd_attention_cb(struct device > *dev) > DRM_ERROR("invalid dev\n"); > return -EINVAL; > } > + DRM_DEBUG_DP("sink_request: %d\n", sink_request); This one is bad. sink

Re: [PATCH v2 5/5] drm/vkms: Map output framebuffer BOs with drm_gem_fb_vmap()

2021-07-26 Thread Rodrigo Siqueira
On 07/25, Thomas Zimmermann wrote: > Abstract the framebuffer details by mappings its BOs with a call > to drm_gem_fb_vmap(). Unmap with drm_gem_fb_vunamp(). > > Before, the output address with stored as raw pointer in the priv > field of struct drm_writeback_job. Introduce the new type > struct v

[PATCH V3 2/2] drm/bridge: lvds-codec: Add support for LVDS data mapping select

2021-07-26 Thread Marek Vasut
Decoder input LVDS format is a property of the decoder chip or even its strapping. Handle data-mapping the same way lvds-panel does. In case data-mapping is not present, do nothing, since there are still legacy bindings which do not specify this property. Signed-off-by: Marek Vasut Cc: Laurent Pi

[PATCH V3 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select

2021-07-26 Thread Marek Vasut
Decoder input LVDS format is a property of the decoder chip or even its strapping. Add DT property data-mapping the same way lvds-panel does, to define the LVDS data mapping. Signed-off-by: Marek Vasut Cc: Laurent Pinchart Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org To: dri

Re: [PATCH v2] drm/msm/dp: signal audio plugged change at dp_pm_resume

2021-07-26 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-07-23 09:55:39) > There is a scenario that dp cable is unplugged from DUT during system > suspended will cause audio option state does not match real connection > state. Fix this problem by Signaling audio plugged change with realtime > connection status at dp_pm_resume(

Re: [PATCH v5] drm/msm/dp: add logs across DP driver for ease of debugging

2021-07-26 Thread Stephen Boyd
Quoting maitreye (2021-07-26 10:36:26) > From: Maitreyee Rao > > Add trace points across the MSM DP driver to help debug > interop issues. > > Changes in v2: > - Got rid of redundant log messages. > - Added %#x instead of 0x%x wherever required. > - Got rid of __func__ calls in debug messages.

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2021-07-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 jes...@jnsn.dev changed: What|Removed |Added CC||jes...@jnsn.dev --- Comment #14 from je

[PATCH V2 2/2] drm/bridge: lvds-codec: Add support for LVDS data mapping select

2021-07-26 Thread Marek Vasut
Decoder input LVDS format is a property of the decoder chip or even its strapping. Handle data-mapping the same way lvds-panel does. In case data-mapping is not present, do nothing, since there are still legacy bindings which do not specify this property. Signed-off-by: Marek Vasut Cc: Laurent Pi

[PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select

2021-07-26 Thread Marek Vasut
Decoder input LVDS format is a property of the decoder chip or even its strapping. Add DT property data-mapping the same way lvds-panel does, to define the LVDS data mapping. Signed-off-by: Marek Vasut Cc: Laurent Pinchart Cc: Rob Herring Cc: Sam Ravnborg Cc: devicet...@vger.kernel.org To: dri

Re: [PATCH v2 4/8] video: ep93xx: Prepare clock before using it

2021-07-26 Thread Sam Ravnborg
Hi Nikita, On Mon, Jul 26, 2021 at 04:59:52PM +0300, Nikita Shubin wrote: > From: Alexander Sverdlin > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch > to Common Clock Framework. > > Signed-off-by: Alexander Sverdlin > Signed-off-by: Nikita Shubin Thanks, applied

Re: [PATCH v2] drm: add logging for RMFB ioctl

2021-07-26 Thread Sam Ravnborg
Hi Simon, On Mon, Jul 26, 2021 at 07:49:06AM +, Simon Ser wrote: > We already have logging for ADDFB2. Add some logging for RMFB as > well. > > This can be handy when trying to find out why a CRTC gets magically > disabled. > > v2: make log message more explicit, add log messages to > drm_fr

Re: [PATCH 1/5] drm/vmwgfx: unbind in vmw_ttm_unpopulate

2021-07-26 Thread Dave Airlie
On Tue, 27 Jul 2021 at 05:35, Christian König wrote: > > Am 26.07.21 um 02:03 schrieb Dave Airlie: > > [SNIP] > >> But you know, normal human: Only equipped with one head and two hands > >> and not cloneable. > > I'm the same, but I'm not seeing where this problem happens at all, do > > we have an

Re: [PATCH v3 3/3] drm/panel-simple: add Gopher 2b LCD panel

2021-07-26 Thread Sam Ravnborg
Hi Paul, On Mon, Jul 26, 2021 at 10:02:08AM +0100, Paul Cercueil wrote: > Hi Artjom, > > Le lun., juil. 26 2021 at 01:15:27 +0300, Artjom Vejsel > a écrit : > > The Gopher 2b LCD panel is used in Gopher 2b handhelds. > > It's simple panel with NewVision NV3047 driver, but SPI lines are not > > co

Re: [PATCH 1/2] dt-bindings: display: simple: Add AUO B133HAN05 & B140HAN06

2021-07-26 Thread Sam Ravnborg
Hi Björn, On Mon, Jul 26, 2021 at 10:32:59AM -0700, Bjorn Andersson wrote: > Add bindings for the two AUO panels B133HAN05 and B140HAN06, both > 1920x1080 panels with 16.7M colors, first being 13.3" and the latter > 14.0". > > Signed-off-by: Bjorn Andersson Thanks, both patches applied to drm-mi

[PATCH V2] drm: mxsfb: Use bus_format from the nearest bridge if present

2021-07-26 Thread Marek Vasut
In case there is a bridge connected to the LCDIF, use bus_format from the bridge, otherwise behave as before and use bus_format from the connector. This way, even if there are multiple bridges in the display pipeline, the LCDIF will use the correct format. Reviewed-by: Lucas Stach Signed-off-by:

  1   2   3   >