Re: [PATCH v2 1/4] drm/vkms: init plane using drmm_universal_plane_alloc

2021-04-12 Thread kernel test robot
Hi Melissa, I love your patch! Perhaps something to improve: [auto build test WARNING on next-20210412] [also build test WARNING on v5.12-rc7] [cannot apply to linus/master v5.12-rc7 v5.12-rc6 v5.12-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

[PATCH] drm/i915/gvt: remove useless function

2021-04-12 Thread Jiapeng Chong
Fix the following clang warning: drivers/gpu/drm/i915/gvt/gtt.c:590:20: warning: unused function 'ppgtt_set_guest_root_entry' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/i915/gvt/gtt.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/d

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-12 Thread Michael Ellerman
Alex Williamson writes: > On Fri, 26 Mar 2021 07:13:10 +0100 > Christoph Hellwig wrote: > >> This driver never had any open userspace (which for VFIO would include >> VM kernel drivers) that use it, and thus should never have been added >> by our normal userspace ABI rules. >> >> Signed-off-by:

Re: [PATCH v2, 0/5] Revert "mailbox: mediatek: remove implementation related to atomic_exec"

2021-04-12 Thread Jassi Brar
On Mon, Apr 12, 2021 at 6:18 AM Yongqiang Niu wrote: > > This series base linux 5.12-rc2 > these patches will cause home ui flick when cursor moved, > there is no fix solution yet, revert these patches first. > > change since v1: > add mtk-gce.txt and dts modification > > Yongqiang Niu (5): > Re

[PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v3)

2021-04-12 Thread Vivek Kasireddy
If support for Blob resources is available, then dumb BOs created by the driver can be considered as guest Blobs. v2: Don't skip transfer and flush commands as part of plane update as the device may have created a shared mapping. (Gerd) v3: Don't create dumb BOs as Guest blobs if Virgl is enabled

RE: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-12 Thread Zhang, Tina
> -Original Message- > From: Gurchetan Singh > Sent: Tuesday, April 13, 2021 8:58 AM > To: Gerd Hoffmann > Cc: Kasireddy, Vivek ; ML dri-devel de...@lists.freedesktop.org>; Zhang, Tina > Subject: Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2) > > > > On Fri, Apr 9, 202

Re: [PATCH 2/2] drm/msm/dp: do not re initialize of audio_comp

2021-04-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-12 10:03:23) > At dp_display_disable(), do not re initialize audio_comp if > hdp_state == ST_DISCONNECT_PENDING (unplug event) to avoid > race condition which cause 5 second timeout expired. More details please. > Also > add abort mechanism to reduce time spinning at

Re: [PATCH 1/2] drm/msm/dp: check sink_count before update is_connected status

2021-04-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-12 10:02:51) > At pm_resume check link sisnk_count before update is_connected status > base on HPD real time link status. Also print out error message only > when either EV_CONNECT_PENDING_TIMEOUT or EV_DISCONNECT_PENDING_TIMEOUT > happen. > > Signed-off-by: Kuogee Hs

Re: [PATCH 1/2] drm/msm/dp: check sink_count before update is_connected status

2021-04-12 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-12 10:02:51) > At pm_resume check link sisnk_count before update is_connected status s/sisnk_count/sink_count/ > base on HPD real time link status. Also print out error message only > when either EV_CONNECT_PENDING_TIMEOUT or EV_DISCONNECT_PENDING_TIMEOUT > happen.

[PATCH] drm/radeon/cik: remove set but not used variables

2021-04-12 Thread Tian Tao
The value of pipe_id and queue_id are not used under certain circumstances, so just delete. Signed-off-by: Tian Tao --- drivers/gpu/drm/radeon/cik.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c index 8b7a4f7..42a8afa 100644 -

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-12 Thread Gurchetan Singh
On Fri, Apr 9, 2021 at 12:48 AM Gerd Hoffmann wrote: > Hi, > > > > IIRC the VIRTGPU_BLOB_FLAG_USE_SHAREABLE flag means that the host *can* > > > create a shared mapping (i.e. the host seeing guest-side changes > without > > > explicit transfer doesn't cause problems for the guest). It doesn no

[PATCH v2 4/4] drm/vkms: add overlay support

2021-04-12 Thread Melissa Wen
Add support to overlay plane, in addition to primary and cursor planes. In this approach, the plane composition still requires an active primary plane and planes are composed associatively in the order: (primary <- overlay) <- cursor It enables to run the following IGT tests successfully: - kms_pl

[PATCH v2 3/4] drm/vkms: add XRGB planes composition

2021-04-12 Thread Melissa Wen
Add support for composing XRGB888 planes in addition to the ARGB format. In the case of an XRGB plane at the top, the composition consists of just copying the RGB values of a pixel from src to dst, without the need for alpha blending operations for each pixel. Signed-off-by: Melissa Wen ---

[PATCH v2 2/4] drm/vkms: rename cursor to plane on ops of planes composition

2021-04-12 Thread Melissa Wen
Generalize variables and function names used for planes composition (from cursor to plane), since we will reuse the operations for both cursor and overlay types. No functional change. Signed-off-by: Melissa Wen --- drivers/gpu/drm/vkms/vkms_composer.c | 28 ++-- 1 file c

[PATCH v2 1/4] drm/vkms: init plane using drmm_universal_plane_alloc

2021-04-12 Thread Melissa Wen
By using drmm_universal_plane_alloc instead of drm_universal_plane_init, we let the DRM infrastructure handles resource allocation and cleanup. We can also get rid of some code repetitions for plane cleanup, improving code maintainability in vkms. Signed-off-by: Melissa Wen --- drivers/gpu/drm/v

[PATCH v2 0/4] drm/vkms: add overlay plane support

2021-04-12 Thread Melissa Wen
Adding support to overlay type in addition to primary and cursor plane. The planes composition relies on the z order of the active planes and only occurs if there is a primary plane (as in the current behavior). The first patch switches the function of initializing planes from drm_universal_plane_

[PATCH] drm/i915/oprom: fix memdup.cocci warnings

2021-04-12 Thread kernel test robot
test robot --- url: https://github.com/0day-ci/linux/commits/Matthew-Auld/More-DG1-enabling/20210412-171139 base: git://anongit.freedesktop.org/drm-intel for-linux-next intel_bios.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/gpu/drm/i915/display/intel_bios.c

Re: [Intel-gfx] [PATCH 14/19] drm/i915/oprom: Basic sanitization

2021-04-12 Thread kernel test robot
wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Auld/More-DG1-enabling/20210412-171139 base: git://anongit.freedesktop.org

[pull] amdgpu, radeon drm-next-5.13

2021-04-12 Thread Alex Deucher
Hi Dave, Daniel, Same PR as last week plus a few accumulated fixes, rebased on drm-next to resolve the dependencies between ttm and scheduler with changes in amdgpu. The following changes since commit c103b850721e4a79ff9578f131888129c37a4679: Merge tag 'drm-misc-next-2021-04-09' of git://anon

Re: [Outreachy kernel] Re: [PATCH 1/2] gpu: drm: Replace "unsigned" with "unsigned int"

2021-04-12 Thread Julia Lawall
On Mon, 12 Apr 2021, Daniel Vetter wrote: > On Mon, Apr 12, 2021 at 2:21 PM Fabio M. De Francesco > wrote: > > > > Replaced "unsigned with "unsigned int" since the latter is preferred. > > > > Signed-off-by: Fabio M. De Francesco > > Nit for the subjects: In drm we generally don't have the gp

Re: [PATCH v6 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP

2021-04-12 Thread Rob Herring
On Sat, 10 Apr 2021 20:15:08 +0200, Parshuram Thombare wrote: > Add binding changes for HDCP in the MHDP8546 DPI/DP bridge binding. > > Signed-off-by: Parshuram Thombare > --- > .../bindings/display/bridge/cdns,mhdp8546.yaml| 15 +++ > 1 file changed, 11 insertions(+), 4 deletion

Re: [PATCH v6 1/2] dt-bindings: display: add google,cros-ec-anx7688.yaml

2021-04-12 Thread Rob Herring
On Fri, 09 Apr 2021 18:19:50 +0200, Dafna Hirschfeld wrote: > ChromeOS EC ANX7688 is a display bridge that converts HDMI 2.0 to > DisplayPort 1.3 Ultra-HDi (4096x2160p60). It is an Analogix ANX7688 chip > which is connected to and operated by the ChromeOS Embedded Controller > (See google,cros-ec.y

[RFC PATCH] drm/i915: Simplify userptr locking

2021-04-12 Thread Thomas Hellström
Use an rwlock instead of spinlock for the global notifier lock to reduce risk of contention in execbuf. Protect object state with the object lock whenever possible rather than with the global notifier lock Don't take an explicit page_ref in userptr_submit_init() but rather call get_pages() after

[Bug 212655] New: AMDGPU crashes when resuming from suspend when amd_iommu=on

2021-04-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212655 Bug ID: 212655 Summary: AMDGPU crashes when resuming from suspend when amd_iommu=on Product: Drivers Version: 2.5 Kernel Version: 5.11.10-1 Hardware: x86-64

[PATCH 1/2] drm/msm/dp: check sink_count before update is_connected status

2021-04-12 Thread Kuogee Hsieh
At pm_resume check link sisnk_count before update is_connected status base on HPD real time link status. Also print out error message only when either EV_CONNECT_PENDING_TIMEOUT or EV_DISCONNECT_PENDING_TIMEOUT happen. Signed-off-by: Kuogee Hsieh --- drivers/gpu/drm/msm/dp/dp_display.c | 6 +++--

[PATCH 2/2] drm/msm/dp: do not re initialize of audio_comp

2021-04-12 Thread Kuogee Hsieh
At dp_display_disable(), do not re initialize audio_comp if hdp_state == ST_DISCONNECT_PENDING (unplug event) to avoid race condition which cause 5 second timeout expired. Also add abort mechanism to reduce time spinning at dp_aux_transfer() during dpcd read if type-c connection had been broken. S

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 6:08 PM Matthew Auld wrote: > > On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > > > We need to general our accessor for the page directories and tables from > > > using the simple kmap_atomic to sup

Re: [PATCH 15/19] drm/i915: WA for zero memory channel

2021-04-12 Thread Souza, Jose
On Mon, 2021-04-12 at 10:05 +0100, Matthew Auld wrote: > From: José Roberto de Souza > > Commit c457d9cf256e ("drm/i915: Make sure we have enough memory > bandwidth on ICL") assumes that we always have a non-zero > dram_info->channels and uses it as a divisor. We need num memory > channels to be

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 05:49:50PM +0200, Thomas Hellström wrote: > On Mon, 2021-04-12 at 17:43 +0200, Daniel Vetter wrote: > > On Mon, Apr 12, 2021 at 04:21:37PM +0200, Christian König wrote: > > > > > > > > > Am 12.04.21 um 16:16 schrieb Thomas Hellström: > > > > Hi, Christian, > > > > > > > >

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 07:01:19PM +0300, Jani Nikula wrote: > On Mon, 12 Apr 2021, Daniel Vetter wrote: > > And that's some serious wtf. Yes we've done some compile-time type > > casting automagic between i915_priv and dev in the past, and I think even > > that was bad taste. But it was justified

Re: [PATCH 0/8] drm/msm: Swappable GEM objects

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 08:23:33AM -0700, Rob Clark wrote: > On Mon, Apr 12, 2021 at 7:28 AM Daniel Vetter wrote: > > > > On Thu, Apr 08, 2021 at 08:23:42AM -0700, Rob Clark wrote: > > > On Thu, Apr 8, 2021 at 4:15 AM Daniel Vetter wrote: > > > > > > > > On Mon, Apr 05, 2021 at 10:45:23AM -0700,

[PATCH AUTOSEL 4.19 10/28] drm/msm: Fix a5xx/a6xx timestamps

2021-04-12 Thread Sasha Levin
From: Rob Clark [ Upstream commit 9fbd3088351b92e8c2cef6e37a39decb12a8d5bb ] They were reading a counter that was configured to ALWAYS_COUNT (ie. cycles that the GPU is doing something) rather than ALWAYS_ON. This isn't the thing that userspace is looking for. Signed-off-by: Rob Clark Acked-b

[PATCH AUTOSEL 5.4 16/39] drm/msm: Fix a5xx/a6xx timestamps

2021-04-12 Thread Sasha Levin
From: Rob Clark [ Upstream commit 9fbd3088351b92e8c2cef6e37a39decb12a8d5bb ] They were reading a counter that was configured to ALWAYS_COUNT (ie. cycles that the GPU is doing something) rather than ALWAYS_ON. This isn't the thing that userspace is looking for. Signed-off-by: Rob Clark Acked-b

[PATCH AUTOSEL 5.10 14/46] gpu/xen: Fix a use after free in xen_drm_drv_init

2021-04-12 Thread Sasha Levin
From: Lv Yunlong [ Upstream commit 52762efa2b256ed1c5274e5177cbd52ee11a2f6a ] In function displback_changed, has the call chain displback_connect(front_info)->xen_drm_drv_init(front_info). We can see that drm_info is assigned to front_info->drm_info and drm_info is freed in fail branch in xen_dr

[PATCH AUTOSEL 5.10 20/46] drm/msm: Fix a5xx/a6xx timestamps

2021-04-12 Thread Sasha Levin
From: Rob Clark [ Upstream commit 9fbd3088351b92e8c2cef6e37a39decb12a8d5bb ] They were reading a counter that was configured to ALWAYS_COUNT (ie. cycles that the GPU is doing something) rather than ALWAYS_ON. This isn't the thing that userspace is looking for. Signed-off-by: Rob Clark Acked-b

[PATCH AUTOSEL 5.11 47/51] drm/amd/display: Add missing mask for DCN3

2021-04-12 Thread Sasha Levin
From: Qingqing Zhuo [ Upstream commit df7232c4c676be29f1cf45058ec156c1183539ff ] [Why] DCN3 is not reusing DCN1 mask_sh_list, causing SURFACE_FLIP_INT_MASK missing in the mapping. [How] Add the corresponding entry to DCN3 list. Signed-off-by: Qingqing Zhuo Reviewed-by: Nicholas Kazlauskas Ac

[PATCH AUTOSEL 5.11 24/51] drm/msm: Fix a5xx/a6xx timestamps

2021-04-12 Thread Sasha Levin
From: Rob Clark [ Upstream commit 9fbd3088351b92e8c2cef6e37a39decb12a8d5bb ] They were reading a counter that was configured to ALWAYS_COUNT (ie. cycles that the GPU is doing something) rather than ALWAYS_ON. This isn't the thing that userspace is looking for. Signed-off-by: Rob Clark Acked-b

[PATCH AUTOSEL 5.11 16/51] gpu/xen: Fix a use after free in xen_drm_drv_init

2021-04-12 Thread Sasha Levin
From: Lv Yunlong [ Upstream commit 52762efa2b256ed1c5274e5177cbd52ee11a2f6a ] In function displback_changed, has the call chain displback_connect(front_info)->xen_drm_drv_init(front_info). We can see that drm_info is assigned to front_info->drm_info and drm_info is freed in fail branch in xen_dr

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Matthew Auld
On Mon, 12 Apr 2021 at 16:17, Daniel Vetter wrote: > > On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > > We need to general our accessor for the page directories and tables from > > using the simple kmap_atomic to support local memory, and this setup > > must be done on acquisition

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Jani Nikula
On Mon, 12 Apr 2021, Daniel Vetter wrote: > And that's some serious wtf. Yes we've done some compile-time type > casting automagic between i915_priv and dev in the past, and I think even > that was bad taste. But it was justified with that we have these > everywhere (especially in the mmio macros)

Re: [PATCH v2 1/5] dt-bindings: display: mediatek,hdmi: Convert to use graph schema

2021-04-12 Thread Neil Armstrong
On 12/04/2021 11:39, Neil Armstrong wrote: > Update the mediatek,dpi binding to use the graph schema. > > Signed-off-by: Neil Armstrong > --- > .../display/mediatek/mediatek,cec.yaml| 51 +++ > .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 > .../display/mediatek/medi

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
On Mon, 2021-04-12 at 17:43 +0200, Daniel Vetter wrote: > On Mon, Apr 12, 2021 at 04:21:37PM +0200, Christian König wrote: > > > > > > Am 12.04.21 um 16:16 schrieb Thomas Hellström: > > > Hi, Christian, > > > > > > On 4/12/21 4:01 PM, Christian König wrote: > > > > Hi Thomas, > > > > > > > > we

Re: [PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-12 Thread Neil Armstrong
On 12/04/2021 17:46, Neil Armstrong wrote: > From: Phong LE > > Add Neil Armstrong and myself as maintainers > > Signed-off-by: Phong LE Obviously: Signed-off-by: Neil Armstrong > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS >

[PATCH v3 0/3] drm/bridge: Add it66121 driver

2021-04-12 Thread Neil Armstrong
The IT66121 is a high-performance and low-power single channel HDMI transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible to DVI 1.0 specifications. It supports pixel rates from 25MHz to 165MHz. This series contains document bindings, add vendor prefix, Kconfig to enable or

[PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry

2021-04-12 Thread Neil Armstrong
From: Phong LE Add Neil Armstrong and myself as maintainers Signed-off-by: Phong LE --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9ae8444c96b4..ff6450c83049 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9515,6 +9515,14 @@ Q:

[PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings

2021-04-12 Thread Neil Armstrong
From: Phong LE Add the ITE bridge HDMI it66121 bindings. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- .../bindings/display/bridge/ite,it66121.yaml | 123 ++ 1 file changed, 123 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/it

[PATCH v3 2/3] drm: bridge: add it66121 driver

2021-04-12 Thread Neil Armstrong
From: Phong LE This commit is a simple driver for bridge HMDI it66121. The input format is RBG and there is no color conversion. Audio, HDCP and CEC are not supported yet. Signed-off-by: Phong LE Signed-off-by: Neil Armstrong --- drivers/gpu/drm/bridge/Kconfig |8 + drivers/gpu/drm/

Re: [PATCH v2 0/2] drm: drm_atomic_helper.c: Change types and format comments

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 02:42:12PM +0200, Fabio M. De Francesco wrote: > Replaced "unsigned" with "unsigned int" and formatted comments according > to the Linux style guidelines. Issues detected by checkpatch.pl. > > Changes from v1: Rewrote the "Subject" of the patches in the series. Also applie

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 04:21:37PM +0200, Christian König wrote: > > > Am 12.04.21 um 16:16 schrieb Thomas Hellström: > > Hi, Christian, > > > > On 4/12/21 4:01 PM, Christian König wrote: > > > Hi Thomas, > > > > > > well in general a good idea, but I'm working on a different plan for > > > a w

Re: [PATCH -next] drm/mediatek: Fix PM reference leak in mtk_crtc_ddp_hw_init()

2021-04-12 Thread Chun-Kuang Hu
Hi, Wang: Wang Li 於 2021年4月10日 週六 上午11:31寫道: > > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Reviewed-by: Chun-K

Re: [PATCH 0/8] drm/msm: Swappable GEM objects

2021-04-12 Thread Rob Clark
On Mon, Apr 12, 2021 at 7:28 AM Daniel Vetter wrote: > > On Thu, Apr 08, 2021 at 08:23:42AM -0700, Rob Clark wrote: > > On Thu, Apr 8, 2021 at 4:15 AM Daniel Vetter wrote: > > > > > > On Mon, Apr 05, 2021 at 10:45:23AM -0700, Rob Clark wrote: > > > > From: Rob Clark > > > > > > > > One would nor

Re: [Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 10:05:25AM +0100, Matthew Auld wrote: > We need to general our accessor for the page directories and tables from > using the simple kmap_atomic to support local memory, and this setup > must be done on acquisition of the backing storage prior to entering > fence execution co

[Bug 212649] general protection fault, probably for non-canonical address 0x1856385d1408f284: 0000 [#1] SMP NOPTI, RIP: 0010:kmem_cache_alloc_trace+0xe9/0x2f0

2021-04-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212649 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added CC||airl...@linux.ie,

Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels

2021-04-12 Thread H. Nikolaus Schaller
> Am 12.04.2021 um 16:34 schrieb Paul Cercueil : > > Hi, > > Can I have an ACK for this patch? > > Then I can apply it to drm-misc-next-fixes. > > Cheers, > -Paul > > > Le mar. 23 mars 2021 à 14:40, Paul Cercueil a écrit : >> When using a 24-bit panel on a 8-bit serial bus, the pixel clock

Re: [PATCH 07/19] drm/i915/fbdev: Use lmem physical addresses for fb_mmap() on discrete

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 10:05:14AM +0100, Matthew Auld wrote: > From: Mohammed Khajapasha > > use local memory io BAR address for fbdev's fb_mmap() operation on > discrete, fbdev uses the physical address of our framebuffer for its > fb_mmap() fn. > > Signed-off-by: Mohammed Khajapasha Sob mis

Re: [Intel-gfx] [PATCH 01/19] drm/i915/gt: Skip aperture remapping selftest where there is no aperture

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 10:05:08AM +0100, Matthew Auld wrote: > From: Chris Wilson > > If there is no mappable aperture, we cannot remap it for access, and the > selftest is void. > > Signed-off-by: Chris Wilson > Reviewed-by: Matthew Auld > Reviewed-by: Imre Deak I guess subject should have

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Christian König
Am 12.04.21 um 16:40 schrieb Thomas Hellström: On 4/12/21 4:21 PM, Christian König wrote: Am 12.04.21 um 16:16 schrieb Thomas Hellström: Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now.

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
On 4/12/21 4:21 PM, Christian König wrote: Am 12.04.21 um 16:16 schrieb Thomas Hellström: Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the res

Re: [PATCH] drm/ingenic: Fix pixclock rate for 24-bit serial panels

2021-04-12 Thread Paul Cercueil
Hi, Can I have an ACK for this patch? Then I can apply it to drm-misc-next-fixes. Cheers, -Paul Le mar. 23 mars 2021 à 14:40, Paul Cercueil a écrit : When using a 24-bit panel on a 8-bit serial bus, the pixel clock requested by the panel has to be multiplied by 3, since the subpixels are s

Re: [PATCH 2/2] drm/ingenic: Don't request full modeset if property is not modified

2021-04-12 Thread Paul Cercueil
Can I have an ACK for this patch? Cheers, -Paul Le lun. 29 mars 2021 à 18:50, Paul Cercueil a écrit : Avoid requesting a full modeset if the sharpness property is not modified, because then we don't actually need it. Fixes: fc1acf317b01 ("drm/ingenic: Add support for the IPU") Cc: # 5.8+ Si

Re: [PATCH 0/8] drm/msm: Swappable GEM objects

2021-04-12 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 08:23:42AM -0700, Rob Clark wrote: > On Thu, Apr 8, 2021 at 4:15 AM Daniel Vetter wrote: > > > > On Mon, Apr 05, 2021 at 10:45:23AM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > One would normally hope not to be under enough memory pressure to need > > > to swa

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-12 Thread Alex Williamson
On Mon, 12 Apr 2021 19:41:41 +1000 Michael Ellerman wrote: > Alex Williamson writes: > > On Fri, 26 Mar 2021 07:13:10 +0100 > > Christoph Hellwig wrote: > > > >> This driver never had any open userspace (which for VFIO would include > >> VM kernel drivers) that use it, and thus should never h

[PATCH v7, 1/5] drm/mediatek: add component OVL_2L2

2021-04-12 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_d

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Christian König
Am 12.04.21 um 16:16 schrieb Thomas Hellström: Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru

[PATCH v7, 2/5] drm/mediatek: add component POSTMASK

2021-04-12 Thread Yongqiang Niu
This patch add component POSTMASK. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 102 drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + 2 files changed, 73 insertions(+), 30 deletion

[PATCH v7, 4/5] soc: mediatek: add mtk mutex support for MT8192

2021-04-12 Thread Yongqiang Niu
Add mtk mutex support for MT8192 SoC. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/soc/mediatek/mtk-mutex.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediate

[PATCH v7, 5/5] drm/mediatek: add support for mediatek SOC MT8192

2021-04-12 Thread Yongqiang Niu
add support for mediatek SOC MT8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 6 + drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 20 +++ drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + driver

[PATCH v7, 3/5] drm/mediatek: add component RDMA4

2021-04-12 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Hsin-Yi Wang --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm

[PATCH v7, 0/5] drm/mediatek: add support for mediatek SOC MT8192

2021-04-12 Thread Yongqiang Niu
This series are based on Linux v5.12-rc2 and following patch: https://patchwork.kernel.org/project/linux-mediatek/cover/1618236288-1617-1-git-send-email-yongqiang@mediatek.com/ Change since v6: - rebase Yongqiang Niu (5): drm/mediatek: add component OVL_2L2 drm/mediatek: add component PO

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
Hi, Christian, On 4/12/21 4:01 PM, Christian König wrote: Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru list. The resource objects then have a pointer t

[PATCH v5, 0/4] soc: mediatek: mmsys: add mt8192 mmsys support

2021-04-12 Thread Yongqiang Niu
base 5.12-rc2 and https://patchwork.kernel.org/project/linux-mediatek/patch/20210330110423.3542163-1-hsi...@chromium.org/ Change since v4: - use routing table Yongqiang Niu (4): soc: mediatek: mmsys: add component OVL_2L2 soc: mediatek: mmsys: add component POSTMASK soc: mediatek: mmsys: ad

[PATCH v5, 4/4] soc: mediatek: mmsys: Add mt8192 mmsys routing table

2021-04-12 Thread Yongqiang Niu
mt8192 has different routing registers than mt8183 Signed-off-by: Yongqiang Niu --- drivers/soc/mediatek/mt8192-mmsys.h | 68 + drivers/soc/mediatek/mtk-mmsys.c| 7 2 files changed, 75 insertions(+) create mode 100644 drivers/soc/mediatek/mt8192-mms

[PATCH v5, 1/4] soc: mediatek: mmsys: add component OVL_2L2

2021-04-12 Thread Yongqiang Niu
This patch add component OVL_2L2 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 2228bf6..f6b58f9 100644

[PATCH v5, 3/4] soc: mediatek: mmsys: add component RDMA4

2021-04-12 Thread Yongqiang Niu
This patch add component RDMA4 Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index 7718cd6..4bba275 100644 --

[PATCH v5, 2/4] soc: mediatek: mmsys: add component POSTMASK

2021-04-12 Thread Yongqiang Niu
This patch add component POSTMASK Signed-off-by: Yongqiang Niu --- include/linux/soc/mediatek/mtk-mmsys.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/soc/mediatek/mtk-mmsys.h b/include/linux/soc/mediatek/mtk-mmsys.h index f6b58f9..7718cd6 100644 --- a/include/linux/soc/med

Re: [RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Christian König
Hi Thomas, well in general a good idea, but I'm working on a different plan for a while now. My idea here is that instead of the BO the resource object is kept on a double linked lru list. The resource objects then have a pointer to either the BO or a fence object. When it is a fence objec

Re: [PATCH 0/2] Document how userspace should use plane format list and IN_FORMATS

2021-04-12 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 07:24:30PM -0300, Leandro Ribeiro wrote: > > > On 4/8/21 8:35 AM, Daniel Vetter wrote: > > On Tue, Apr 06, 2021 at 04:21:16PM -0300, Leandro Ribeiro wrote: > >> This patch is to emphasize how userspace should use the plane format list > >> and > >> the IN_FORMATS blob. Th

Re: [PATCH] vt_ioctl: make VT_RESIZEX behave like VT_RESIZE

2021-04-12 Thread Maciej W. Rozycki
On Mon, 12 Apr 2021, Daniel Vetter wrote: > > Note that it's entirely possible that things continue to work well > > despite this warning. It's unclear to me from your email if you > > actually see any difference (and apparently you're not able to see it > > right now due to not being close to the

Re: [PATCH v2 1/5] dt-bindings: display: mediatek, hdmi: Convert to use graph schema

2021-04-12 Thread Rob Herring
On Mon, 12 Apr 2021 11:39:24 +0200, Neil Armstrong wrote: > Update the mediatek,dpi binding to use the graph schema. > > Signed-off-by: Neil Armstrong > --- > .../display/mediatek/mediatek,cec.yaml| 51 +++ > .../display/mediatek/mediatek,hdmi-ddc.yaml | 57 > .../displa

Re: [PATCH v3] drivers: introduce and use WANT_DMA_CMA for soft dependencies on DMA_CMA

2021-04-12 Thread David Hildenbrand
On 12.04.21 15:12, Robin Murphy wrote: On 2021-04-09 14:39, David Hildenbrand wrote: On 09.04.21 15:35, Arnd Bergmann wrote: On Fri, Apr 9, 2021 at 1:21 PM David Hildenbrand wrote: Random drivers should not override a user configuration of core knobs (e.g., CONFIG_DMA_CMA=n). Applicable driv

[RFC PATCH] drm/ttm: Simplify the delayed destroy locking

2021-04-12 Thread Thomas Hellström
This RFC needs some decent testing on a driver with bos that share reservation objects, and of course a check for whether I missed something obvious. The locking around delayed destroy is rather complex due to the fact that we want to individualize dma_resv pointers before putting the object on th

Re: [PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-12 Thread Daniel Vetter
On Thu, Apr 08, 2021 at 05:39:22PM +0300, Ville Syrjälä wrote: > On Thu, Apr 08, 2021 at 04:57:51PM +0300, Pekka Paalanen wrote: > > On Thu, 8 Apr 2021 13:30:16 +0200 > > Daniel Vetter wrote: > > > > > On Thu, Apr 08, 2021 at 12:59:19PM +0300, Pekka Paalanen wrote: > > > > > > The point of these

Re: [PATCH v3] drivers: introduce and use WANT_DMA_CMA for soft dependencies on DMA_CMA

2021-04-12 Thread Robin Murphy
On 2021-04-09 14:39, David Hildenbrand wrote: On 09.04.21 15:35, Arnd Bergmann wrote: On Fri, Apr 9, 2021 at 1:21 PM David Hildenbrand wrote: Random drivers should not override a user configuration of core knobs (e.g., CONFIG_DMA_CMA=n). Applicable drivers would like to use DMA_CMA, which dep

[PATCH v2 1/3] drm/aperture: Add infrastructure for aperture ownership

2021-04-12 Thread Thomas Zimmermann
Platform devices might operate on firmware framebuffers, such as VESA or EFI. Before a native driver for the graphics hardware can take over the device, it has to remove any platform driver that operates on the firmware framebuffer. Aperture helpers provide the infrastructure for native drivers to

[PATCH v2 2/3] drm/aperture: Convert drivers to aperture interfaces

2021-04-12 Thread Thomas Zimmermann
Mass-convert all drivers from FB helpers to aperture interfaces. No functional changes besides checking for returned errno codes. Signed-off-by: Thomas Zimmermann Acked-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- drivers/gpu/drm/armada/armada_drv.c | 5

[PATCH v2 3/3] drm/aperture: Inline fbdev conflict helpers into aperture helpers

2021-04-12 Thread Thomas Zimmermann
Fbdev's helpers for handling conflicting framebuffer drivers are related to framebuffer apertures, not console emulation. Therefore remove them from drm_fb_helper.h and inline them into the aperture helpers. No functional changes. Signed-off-by: Thomas Zimmermann Acked-by: Daniel Vetter Acked-by

[PATCH v2 0/3] drm: Add aperture helpers

2021-04-12 Thread Thomas Zimmermann
Adds helpers for maintaining aperture ownership. Currently wraps the infrastructure around fbdev's remove_conflicting_framebuffers(). For adding generic drivers to DRM, we need a hand-over mechanism that unloads the generic driver before loading the hardware's native driver. So far, this was suppo

Re: [PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-04-12 Thread Kevin Tang
Hi Thomas, Thomas Zimmermann 于2021年4月8日周四 下午6:53写道: > Hi, > > please see my comments below. > > Best regards > Thomas > > Am 22.02.21 um 14:28 schrieb Kevin Tang: > > Adds DPU(Display Processor Unit) support for the Unisoc's display > subsystem. > > It's support multi planes, scaler, rotation, P

[PATCH v2 2/2] drm: drm_atomic_helper.c: Correct comments format

2021-04-12 Thread Fabio M. De Francesco
Corrected comments format in accordance to the Linux style guides. Signed-off-by: Fabio M. De Francesco --- Changes from v1: Rewrote the "Subject" of the patches in the series drivers/gpu/drm/drm_atomic_helper.c | 32 +++-- 1 file changed, 21 insertions(+), 11 deletions

[PATCH v2 1/2] drm: drm_atomic_helper.c: Replace "unsigned" with "unsigned int"

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned with "unsigned int" since the latter is preferred. Signed-off-by: Fabio M. De Francesco --- Changes from v1: Rewrote the "Subject" of the patches in the series drivers/gpu/drm/drm_atomic_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dri

[PATCH v2 0/2] drm: drm_atomic_helper.c: Change types and format comments

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned" with "unsigned int" and formatted comments according to the Linux style guidelines. Issues detected by checkpatch.pl. Changes from v1: Rewrote the "Subject" of the patches in the series. Fabio M. De Francesco (2): gpu: drm: Replace "unsigned" with "unsigned int" gpu: drm:

Re: [PATCH 1/2] gpu: drm: Replace "unsigned" with "unsigned int"

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 2:21 PM Fabio M. De Francesco wrote: > > Replaced "unsigned with "unsigned int" since the latter is preferred. > > Signed-off-by: Fabio M. De Francesco Nit for the subjects: In drm we generally don't have the gpu prefix, but just the level below + what component. So for t

Re: [RFC PATCH] drm/doc/rfc: i915 DG1 uAPI

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 2:18 PM Matthew Auld wrote: > > Add an entry for the new uAPI needed for DG1. > > Signed-off-by: Matthew Auld > Cc: Joonas Lahtinen > Cc: Daniel Vetter > Cc: Dave Airlie > --- > Documentation/gpu/rfc/i915_create_ext.c | 48 ++ > .../gpu/rfc/i915_create_ex

Re: [PATCH] gpu: drm: Replace bare "unsigned" with "unsigned int"

2021-04-12 Thread Fabio M. De Francesco
On Monday, April 12, 2021 2:11:59 PM CEST Daniel Vetter wrote: > On Mon, Apr 12, 2021 at 12:53:09PM +0200, Fabio M. De Francesco wrote: > > Replaced the type "unsigned" with "unsigned int" because it is > > preferred. Issue detected by checkpatch.pl. > > Huh, I didn't know that, TIL. > > > Signed

[PATCH 2/2] gpu: drm: Correct comments format

2021-04-12 Thread Fabio M. De Francesco
Corrected comments format in accordance to the Linux style guides. Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/drm_atomic_helper.c | 32 +++-- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/d

[PATCH 0/2] gpu: drm: Change types and format comments

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned" with "unsigned int" and formatted comments according to the Linux style guidelines. Issues detected by checkpatch.pl. Fabio M. De Francesco (2): gpu: drm: Replace "unsigned" with "unsigned int" gpu: drm: Correct comments format drivers/gpu/drm/drm_atomic_helper.c | 40 +++

[PATCH 1/2] gpu: drm: Replace "unsigned" with "unsigned int"

2021-04-12 Thread Fabio M. De Francesco
Replaced "unsigned with "unsigned int" since the latter is preferred. Signed-off-by: Fabio M. De Francesco --- drivers/gpu/drm/drm_atomic_helper.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.

[RFC PATCH] drm/doc/rfc: i915 DG1 uAPI

2021-04-12 Thread Matthew Auld
Add an entry for the new uAPI needed for DG1. Signed-off-by: Matthew Auld Cc: Joonas Lahtinen Cc: Daniel Vetter Cc: Dave Airlie --- Documentation/gpu/rfc/i915_create_ext.c | 48 ++ .../gpu/rfc/i915_create_ext_placements.c | 19 Documentation/gpu/rfc/i915_region_query.c

Re: [PATCH] gpu: drm: Replace bare "unsigned" with "unsigned int"

2021-04-12 Thread Daniel Vetter
On Mon, Apr 12, 2021 at 12:53:09PM +0200, Fabio M. De Francesco wrote: > Replaced the type "unsigned" with "unsigned int" because it is > preferred. Issue detected by checkpatch.pl. Huh, I didn't know that, TIL. > Signed-off-by: Fabio M. De Francesco Thanks for your patche, merged to drm-misc-n

[PATCH v4, 2/3] arm64: dts: mt8192: add gce node

2021-04-12 Thread Yongqiang Niu
add gce node for mt8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 9757138..1afa6

  1   2   >