Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-06 Thread Christian König
Am 06.04.21 um 17:42 schrieb Felix Kuehling: Am 2021-04-01 um 6:29 p.m. schrieb Alex Deucher: Hi Dave, Daniel, New stuff for 5.13. There are two small patches for ttm and scheduler that were dependencies for amdgpu changes. The following changes since commit 2cbcb78c9ee5520c8d836c7ff57d1b60eb

[PATCH v1] drm/radeon: Fix a missing check bug in radeon_dp_mst_detect()

2021-04-06 Thread wangyingjie55
From: Yingjie Wang In radeon_dp_mst_detect(), We should check whether or not @connector has been unregistered from userspace. If the connector is unregistered, we should return disconnected status. Fixes: 9843ead08f18 ("drm/radeon: add DisplayPort MST support (v2)") Signed-off-by: Yingjie Wang

[PATCH] drivers/gpu/drm/ttm/ttm_page_allo.c: adjust ttm pages refcount fix the bug: Feb 6 17:13:13 aaa-PC kernel: [ 466.271034] BUG: Bad page state in process blur_image pfn:7aee2 Feb 6 17:13:13 aaa-P

2021-04-06 Thread songqiang
Signed-off-by: songqiang --- drivers/gpu/drm/ttm/ttm_page_alloc.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c index 14660f723f71..f3698f0ad4d7 100644 --- a/drivers/gpu/drm/ttm/

[PATCH] video: fbdev: sm501fb: Fix deallocation of buffers order

2021-04-06 Thread Aditya Pakki
The resource release in sm501fb_remove() is not in the inverse order of sm501fb_probe(), for the buffers. Release the info object after deallocating the buffers. Signed-off-by: Aditya Pakki --- drivers/video/fbdev/sm501fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

RE: [PATCH v5 1/2] dt-bindings: drm/bridge: MHDP8546 bridge binding changes for HDCP

2021-04-06 Thread Parshuram Raju Thombare
Hi Rob, Thanks for your comment and sorry for late response. >> -minItems: 1 >> -maxItems: 2 >> +minItems: 2 >> +maxItems: 3 > >1 entry was valid and now it is not? That's not a compatible change and >needs an explanation at a minimum. Yes, as the driver returns error in the abse

Re: [PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-06 Thread Gurchetan Singh
On Tue, Apr 6, 2021 at 1:47 PM Vivek Kasireddy wrote: > If support for Blob resources is available, then dumb BOs created > by the driver can be considered as guest Blobs. > > v2: Don't skip transfer and flush commands as part of plane update > as the device may have created a shared mapping. (Ge

[PATCH] clk: fixed: fix double free in resource managed fixed-factor clock

2021-04-06 Thread Dmitry Baryshkov
devm_clk_hw_register_fixed_factor_release(), the release function for the devm_clk_hw_register_fixed_factor(), calls clk_hw_unregister_fixed_factor(), which will kfree() the clock. However after that the devres functions will also kfree the allocated data, resulting in double free/memory corruption

[PATCH 3/3] drm/msm/mdp5: Disable pingpong autorefresh at tearcheck init

2021-04-06 Thread Marijn Suijten
From: AngeloGioacchino Del Regno If pp autorefresh is up (from bootloader splash), we will surely get vblank and pp timeouts. Ensure it is turned off. Signed-off-by: AngeloGioacchino Del Regno Signed-off-by: Marijn Suijten --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c | 1 + 1 file c

[PATCH 2/3] drm/msm/mdp5: Do not multiply vclk line count by 100

2021-04-06 Thread Marijn Suijten
Neither vtotal nor drm_mode_vrefresh contain a value that is premultiplied by 100 making the x100 variable name incorrect and resulting in vclks_line to become 100 times larger than it is supposed to be. The hardware counts 100 clockticks too many before tearcheck, leading to severe panel issues o

[PATCH 1/3] drm/msm/mdp5: Configure PP_SYNC_HEIGHT to double the vtotal

2021-04-06 Thread Marijn Suijten
Leaving this at a close-to-maximum register value 0xFFF0 means it takes very long for the MDSS to generate a software vsync interrupt when the hardware TE interrupt doesn't arrive. Configuring this to double the vtotal (like some downstream kernels) leads to a frame to take at most twice before th

[PATCH 0/3] drm/msm/mdp5: Emit vsync signal often enough

2021-04-06 Thread Marijn Suijten
This set of patches corrects and improves VSync-related register setup on the MDP5 block. Values written to the registers were way too high leading to the MDSS block counting way too many ticks on the vclk before emitting a vsync interrupt, resulting in significant update issues on command- and vi

Re: [PATCH] drm/radeon/ttm: Fix memory leak userptr pages

2021-04-06 Thread Alex Deucher
On Mon, Mar 22, 2021 at 6:34 AM Christian König wrote: > > Hi Daniel, > > Am 22.03.21 um 10:38 schrieb Daniel Gomez: > > On Fri, 19 Mar 2021 at 21:29, Felix Kuehling wrote: > >> This caused a regression in kfdtest in a large-buffer stress test after > >> memory allocation for user pages fails: >

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-06 Thread Alex Deucher
On Fri, Apr 2, 2021 at 12:22 PM Christian König wrote: > > Hey Alex, > > the TTM and scheduler changes should already be in the drm-misc-next > branch (not 100% sure about the TTM patch, need to double check next week). > The TTM change is not in drm-misc yet. > Could that cause problems when bo

[PATCH] drm/virtio: Create Dumb BOs as guest Blobs (v2)

2021-04-06 Thread Vivek Kasireddy
If support for Blob resources is available, then dumb BOs created by the driver can be considered as guest Blobs. v2: Don't skip transfer and flush commands as part of plane update as the device may have created a shared mapping. (Gerd) Cc: Gerd Hoffmann Signed-off-by: Vivek Kasireddy --- driv

[PATCH v2 17/18] vfio/mdev: Remove kobj from mdev_parent_ops->create()

2021-04-06 Thread Jason Gunthorpe
The kobj here is a type-erased version of mdev_type, which is already stored in the struct mdev_device being passed in. It was only ever used to compute the type_group_id, which is now extracted directly from the mdev. Reviewed-by: Kevin Tian Reviewed-by: Cornelia Huck Reviewed-by: Christoph Hel

[PATCH v2 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes

2021-04-06 Thread Jason Gunthorpe
The driver core standard is to pass in the properly typed object, the properly typed attribute and the buffer data. It stems from the root kobject method: ssize_t (*show)(struct kobject *kobj, struct kobj_attribute *attr,..) Each subclass of kobject should provide their own function with the sa

[PATCH v2 16/18] vfio/gvt: Use mdev_get_type_group_id()

2021-04-06 Thread Jason Gunthorpe
intel_gvt_init_vgpu_type_groups() makes gvt->types 1:1 with the supported_type_groups array, so the type_group_id is also the index into gvt->types. Use it directly and remove the string matching. Reviewed-by: Kevin Tian Reviewed-by: Christoph Hellwig Signed-off-by: Jason Gunthorpe --- drivers

[PATCH v2 00/18] Make vfio_mdev type safe

2021-04-06 Thread Jason Gunthorpe
vfio_mdev has a number of different objects: mdev_parent, mdev_type and mdev_device. Unfortunately the types of these have been erased in various places throughout the API, and this makes it very hard to understand this code or maintain it by the time it reaches all of the drivers. This series pu

[PATCH v2 15/18] vfio/gvt: Make DRM_I915_GVT depend on VFIO_MDEV

2021-04-06 Thread Jason Gunthorpe
At some point there may have been some reason for this weird split in this driver, but today only the VFIO side is actually implemented. However, it got messed up at some point and mdev code was put in gvt.c and is pretending to be "generic" by masquerading as some generic attribute list: stat

Re: [PATCH 1/2] vfio/pci: remove vfio_pci_nvlink2

2021-04-06 Thread Alex Williamson
On Fri, 26 Mar 2021 07:13:10 +0100 Christoph Hellwig wrote: > This driver never had any open userspace (which for VFIO would include > VM kernel drivers) that use it, and thus should never have been added > by our normal userspace ABI rules. > > Signed-off-by: Christoph Hellwig > Acked-by: Greg

[PATCH -next] gma500: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Huang Guobin
From: Guobin Huang spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/gpu/drm/gma500/power.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

RE: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Roy Im
On Tue, 06 Apr 2021, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some > rounding involved. > > pwm_get_state() traditionally returned the setting that was requested > most recently by the consu

[PATCH 1/2] drm/doc: document drm_mode_get_plane

2021-04-06 Thread Leandro Ribeiro
Add a small description and document struct fields of drm_mode_get_plane. Signed-off-by: Leandro Ribeiro --- include/uapi/drm/drm_mode.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index d1a93d2a85f9..96fc9a6d

[PATCH 0/2] Document how userspace should use plane format list and IN_FORMATS

2021-04-06 Thread Leandro Ribeiro
This patch is to emphasize how userspace should use the plane format list and the IN_FORMATS blob. The plane format list contains the formats that do not require modifiers, and the blob property has the formats that support modifiers. Note that these are not disjoint sets. If a format supports mod

[PATCH 2/2] drm/doc: emphasize difference between plane formats and IN_FORMATS blob

2021-04-06 Thread Leandro Ribeiro
Emphasize how userspace should use the plane format list (format_type_ptr) and the IN_FORMATS blob property. Formats exposed in the plane format list (format_type_ptr) do not require modifiers, and formats that are present in the IN_FORMATS blob property support modifiers. Note that these are not

Re: [Intel-gfx] [PATCH] drm/i915/dpcd_bl: Don't try vesa interface unless specified by VBT

2021-04-06 Thread Jani Nikula
On Tue, 23 Mar 2021, Lyude Paul wrote: > On Tue, 2021-03-23 at 16:06 +0200, Jani Nikula wrote: >> On Thu, 18 Mar 2021, Lyude Paul wrote: >> > Actually-NAK this. I just realized I've been misreading the bug and that >> > this >> > doesn't actually seem to be fixed. Will resend once I figure out wh

Re: [PATCH 18/18] vfio/mdev: Correct the function signatures for the mdev_type_attributes

2021-04-06 Thread Jason Gunthorpe
On Tue, Mar 23, 2021 at 08:31:03PM +0100, Christoph Hellwig wrote: > > - type = intel_gvt_find_vgpu_type(gvt, mtype_get_type_group_id(kobj)); > > + type = intel_gvt_find_vgpu_type(gvt, mtype_get_type_group_id(mtype)); > > Somewhere in this series you should probably switch > intel_gvt_find_vg

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

2021-04-06 Thread Andrzej Hajda
Hello again after easter, I have looked little bit more at sn65* driver and its application to have better background. I miss only info what panel do you have, how it is enabled/power controlled. W dniu 01.04.2021 o 16:57, Doug Anderson pisze: > Hi, > > On Thu, Apr 1, 2021 at 4:12 AM Andrzej

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-06 Thread Alex Deucher
On Tue, Apr 6, 2021 at 11:42 AM Felix Kuehling wrote: > > Am 2021-04-01 um 6:29 p.m. schrieb Alex Deucher: > > Hi Dave, Daniel, > > > > New stuff for 5.13. There are two small patches for ttm and scheduler > > that were dependencies for amdgpu changes. > > > > The following changes since commit 2

Re: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-06 Thread Felix Kuehling
Am 2021-04-01 um 6:29 p.m. schrieb Alex Deucher: > Hi Dave, Daniel, > > New stuff for 5.13. There are two small patches for ttm and scheduler > that were dependencies for amdgpu changes. > > The following changes since commit 2cbcb78c9ee5520c8d836c7ff57d1b60ebe8e9b7: > > Merge tag 'amd-drm-next-

Re: [PATCH 2/4] drm/vram-helper: Use drm_gem_ttm_dumb_map_offset()

2021-04-06 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc6 next-20210406] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documente

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Felix Kuehling
Am 2021-04-06 um 6:38 a.m. schrieb Thomas Zimmermann: > Hi > > Am 06.04.21 um 11:35 schrieb Christian König: >> Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: >>> Moving the driver-specific mmap code into a GEM object function allows >>> for using DRM helpers for various mmap callbacks. >>> >>> Th

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Felix Kuehling
Am 2021-04-06 um 9:04 a.m. schrieb Christian König: > Am 06.04.21 um 14:52 schrieb Thomas Zimmermann: >> Hi >> >> Am 06.04.21 um 14:42 schrieb Christian König: >>> Hi Thomas, >>> >>> Am 06.04.21 um 13:55 schrieb Thomas Zimmermann: Hi Am 06.04.21 um 12:56 schrieb Christian König:

[PATCH] drm/msm: Fix spelling "purgable" -> "purgeable"

2021-04-06 Thread Rob Clark
From: Rob Clark The previous patch fixes the user visible spelling. This one fixes the code. Oops. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 12 ++-- drivers/gpu/drm/msm/msm_gem.h | 16 drivers/gpu/drm/msm/msm_gem_shrinker.c | 2

Re: [PATCH][next] drm/msm: Fix spelling mistake "Purgable" -> "Purgeable"

2021-04-06 Thread Rob Clark
On Tue, Apr 6, 2021 at 6:39 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in debugfs gem stats. Fix it. Also > re-align output to cater for the extra 1 character. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/msm/msm_gem.c | 8 > 1 file chang

Re: [PATCH] drm/panel: panel-dsi-cm: disable TE for now

2021-04-06 Thread Tomi Valkeinen
On 06/04/2021 16:51, Thierry Reding wrote: On Tue, Mar 16, 2021 at 04:11:30PM +0200, Tomi Valkeinen wrote: Hi Sebastian, Sam, Thierry, On 27/02/2021 23:45, Sebastian Reichel wrote: From: Sebastian Reichel Disable TE for Droid 4 panel, since implementation is currently broken. Also disable it

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-04-06 Thread Ondřej Jirman
On Wed, Mar 31, 2021 at 07:16:40PM +0200, Dafna Hirschfeld wrote: > Hi, > > On 05.03.21 18:24, Ondřej Jirman wrote: > > Hello Dafna, > > [...] > > > > > + vconn-en1-gpios: > > > > > +description: Controls the VCONN switch on the CC1 pin. > > > > > +maxItems: 1 > > > > > + > > > > > +

Re: [PATCH 4/8] drm/radeon: Implement mmap as GEM object function

2021-04-06 Thread Alex Deucher
On Tue, Apr 6, 2021 at 5:09 AM Thomas Zimmermann wrote: > > Moving the driver-specific mmap code into a GEM object function allows > for using DRM helpers for various mmap callbacks. > > This change also allows to support prime-based mmap via DRM's helper > drm_gem_prime_mmap(). > > Permission che

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-04-06 Thread Enric Balletbo i Serra
Hi Laurent and Dafna, On 31/3/21 22:40, Laurent Pinchart wrote: > On Tue, Mar 30, 2021 at 05:14:44PM +0200, Enric Balletbo i Serra wrote: >> On 30/3/21 15:35, Dafna Hirschfeld wrote: >>> On 05.03.21 16:19, Laurent Pinchart wrote: On Fri, Mar 05, 2021 at 04:14:03PM +0100, Dafna Hirschfeld wrot

[PATCH] drm/amd/pm: convert sysfs snprintf to sysfs_emit

2021-04-06 Thread Carlis
From: Xuezhi Zhang Fix the following coccicheck warning: drivers/gpu/drm/amd/pm//amdgpu_pm.c:1940:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/amd/pm//amdgpu_pm.c:1978:8-16: WARNING: use scnprintf or sprintf drivers/gpu/drm/amd/pm//amdgpu_pm.c:2022:8-16: WARNING: use scnprintf or sp

Re: [PATCH 1/2] drm/i915/display/vlv_dsi: Do not skip panel_pwr_cycle_delay when disabling the panel

2021-04-06 Thread Hans de Goede
Hi, On 3/25/21 12:48 PM, Hans de Goede wrote: > After the recently added commit fe0f1e3bfdfe ("drm/i915: Shut down > displays gracefully on reboot"), the DSI panel on a Cherry Trail based > Predia Basic tablet would no longer properly light up after reboot. > > I've managed to reproduce this with

Re: [PATCH] drm/panel: panel-dsi-cm: disable TE for now

2021-04-06 Thread Thierry Reding
On Tue, Mar 16, 2021 at 04:11:30PM +0200, Tomi Valkeinen wrote: > Hi Sebastian, Sam, Thierry, > > On 27/02/2021 23:45, Sebastian Reichel wrote: > > From: Sebastian Reichel > > > > Disable TE for Droid 4 panel, since implementation is currently > > broken. Also disable it for N950 panel, which is

Re: [PATCH] drm/amdgpu: Fix a potential sdma invalid access

2021-04-06 Thread Christian König
Hi Qu, Am 06.04.21 um 08:04 schrieb Qu Huang: Hi Christian, On 2021/4/3 16:49, Christian König wrote: Hi Qu, Am 03.04.21 um 07:08 schrieb Qu Huang: Hi Christian, On 2021/4/3 0:25, Christian König wrote: Hi Qu, Am 02.04.21 um 05:18 schrieb Qu Huang: Before dma_resv_lock(bo->base.resv, NUL

Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Uwe Kleine-König
Hello Thierry, On Tue, Apr 06, 2021 at 01:16:31PM +0200, Thierry Reding wrote: > On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > > Given that lowlevel drivers usually cannot implement exactly what a > > consumer requests with pwm_apply_state() there is some rounding involved. >

[PULL] drm-intel-gt-next

2021-04-06 Thread Joonas Lahtinen
Hi Dave & Daniel, Bit late PR due to Easter break. Prep work for local memory support as requested. Hard hang fix for Sandybridge. Sanitize dma-buf size on import and avoid GPU reset if heartbeat callback runs before timeout. The rest is mostly small fixes and code/checkpatch cleanups. Regards

[PATCH][next] drm/msm: Fix spelling mistake "Purgable" -> "Purgeable"

2021-04-06 Thread Colin King
From: Colin Ian King There is a spelling mistake in debugfs gem stats. Fix it. Also re-align output to cater for the extra 1 character. Signed-off-by: Colin Ian King --- drivers/gpu/drm/msm/msm_gem.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/ms

Re: [PATCH v15 3/4] dt-bindings: msm: dsi: add yaml schemas for DSI PHY bindings

2021-04-06 Thread Rob Herring
On Mon, 05 Apr 2021 16:36:09 +0530, Krishna Manikandan wrote: > Add YAML schema for the device tree bindings for DSI PHY. > > Signed-off-by: Krishna Manikandan > > Changes in v1: >- Merge dsi-phy.yaml and dsi-phy-10nm.yaml (Stephen Boyd) >- Remove qcom,dsi-phy-regulator-ldo-mode (Stephen

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Christian König
Am 06.04.21 um 14:52 schrieb Thomas Zimmermann: Hi Am 06.04.21 um 14:42 schrieb Christian König: Hi Thomas, Am 06.04.21 um 13:55 schrieb Thomas Zimmermann: Hi Am 06.04.21 um 12:56 schrieb Christian König: In the end I went with the semantics I found in amdgpu_mmap() and handled KFD specia

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Thomas Zimmermann
Hi Am 06.04.21 um 14:42 schrieb Christian König: Hi Thomas, Am 06.04.21 um 13:55 schrieb Thomas Zimmermann: Hi Am 06.04.21 um 12:56 schrieb Christian König: In the end I went with the semantics I found in amdgpu_mmap() and handled KFD specially. Let me know if this requires to be changed.

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Christian König
Hi Thomas, Am 06.04.21 um 13:55 schrieb Thomas Zimmermann: Hi Am 06.04.21 um 12:56 schrieb Christian König: In the end I went with the semantics I found in amdgpu_mmap() and handled KFD specially. Let me know if this requires to be changed. Well the question is where is the call to drm_vm

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-04-06 Thread Laurent Pinchart
Hi Dafna, Thank you for the patch. On Tue, Mar 30, 2021 at 01:52:00PM +0200, Dafna Hirschfeld wrote: > drm_bridge_funcs has a function called 'hpd_notify'. > The function drm_bridge_hpd_notify does not call > 'hpd_notify' but it calls 'hpd_cb'. This is rather > confusing. Rename the function to f

Re: [PATCH] drm/i915/sysfs: convert snprintf to sysfs_emit

2021-04-06 Thread Jani Nikula
On Sun, 04 Apr 2021, Carlis wrote: > From: Xuezhi Zhang > > Fix the following coccicheck warning: > drivers/gpu/drm/i915//i915_sysfs.c:266:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm/i915//i915_sysfs.c:285:8-16: > WARNING: use scnprintf or sprintf > drivers/gpu/drm/i915//i915_sy

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Thomas Zimmermann
Hi Am 06.04.21 um 12:56 schrieb Christian König: In the end I went with the semantics I found in amdgpu_mmap() and handled KFD specially. Let me know if this requires to be changed. Well the question is where is the call to drm_vma_node_verify_access() now? Cause that needs to be skipped fo

Re: [PATCH RFC 2/3] fpga: support loading from a pre-allocated buffer

2021-04-06 Thread Martin Hundebøll
Hi Nava, On minor comment below. On 02/04/2021 11.09, Nava kishore Manne wrote: Some systems are memory constrained but they need to load very large Configuration files. The FPGA subsystem allows drivers to request this Configuration image be loaded from the filesystem, but this requires that t

[PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM_LT8912B select GPIOLIB

2021-04-06 Thread Zhang Jianhua
If CONFIG_DRM_LONTIUM_LT8912B=y, the following errors will be seen while compiling lontium-lt8912b.c drivers/gpu/drm/bridge/lontium-lt8912b.c: In function ‘lt8912_hard_power_on’: drivers/gpu/drm/bridge/lontium-lt8912b.c:252:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did

Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Mark Brown
On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some rounding involved. Acked-by: Mark Brown signature.asc Description: PGP signature _

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Do not report 100% RC6 if not supported

2021-04-06 Thread Andi Shyti
Hi Tvrtko, > We use GT parked status to estimate RC6 while not in use, however if RC6 > is not supported to start with that does not work very well and produces a > false 100% RC6 readout. > > Fix by not advancing the estimated RC6 counter when feature is not > supported. > > Signed-off-by: Tvrt

Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Thierry Reding
On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some rounding involved. > > pwm_get_state() traditionally returned the setting that was requested most > recen

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Christian König
Hi Thomas, Am 06.04.21 um 12:38 schrieb Thomas Zimmermann: Hi Am 06.04.21 um 11:35 schrieb Christian König: Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change res

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Thomas Zimmermann
Hi Am 06.04.21 um 11:35 schrieb Christian König: Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change resolves several inconsistencies between regular mmap and prime-

Re: [PATCH -next] drm/bridge: lt8912b: DRM_LONTIUM_LT8912B select GPIOLIB

2021-04-06 Thread Robert Foss
Hey Zhang On Tue, 6 Apr 2021 at 11:07, Zhang Jianhua wrote: > > If CONFIG_DRM_LONTIUM_LT8912B=y, the following errors will be seen while > compiling lontium-lt8912b.c > > drivers/gpu/drm/bridge/lontium-lt8912b.c: In function > ‘lt8912_hard_power_on’: > drivers/gpu/drm/bridge/lontium-lt8912b.c:252

Re: [PATCH 2/8] drm/amdgpu: Remove unused function amdgpu_bo_fbdev_mmap()

2021-04-06 Thread Thomas Zimmermann
Hi Am 06.04.21 um 11:43 schrieb Christian König: Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: Remove an unused function. Mapping the fbdev framebuffer is apparently not supported. Signed-off-by: Thomas Zimmermann Reviewed-by: Christian König Should I just upstream this through our inte

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-04-06 Thread Robert Foss
Reviewed-by: Robert Foss On Tue, 30 Mar 2021 at 14:28, Robert Foss wrote: > > Hey Dafna, > > Thanks for submitting a cleanup patch, it is much appreciated. It > looks good to me, feel free to add my r-b. > > I'm not going to merge this right away, but will let this patch soak > for a while to le

Re: [PATCH 2/8] drm/amdgpu: Remove unused function amdgpu_bo_fbdev_mmap()

2021-04-06 Thread Christian König
Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: Remove an unused function. Mapping the fbdev framebuffer is apparently not supported. Signed-off-by: Thomas Zimmermann Reviewed-by: Christian König Should I just upstream this through our internal branches? Thanks, Christian. --- drivers/

Re: [PATCH 8/8] drm/ttm: Remove ttm_bo_mmap() and friends

2021-04-06 Thread Christian König
Am 06.04.21 um 11:09 schrieb Thomas Zimmermann: The function ttm_bo_mmap is unused. Remove it and it's helpers; including the verify_access callback in struct ttm_device_funcs. Signed-off-by: Thomas Zimmermann Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 53

Re: [PATCH 4/8] drm/radeon: Implement mmap as GEM object function

2021-04-06 Thread Christian König
Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change also allows to support prime-based mmap via DRM's helper drm_gem_prime_mmap(). Permission checks are implemented b

[PATCH v1] drm/bridge/sii8620: fix dependency on extcon

2021-04-06 Thread Robert Foss
The DRM_SIL_SII8620 kconfig has a weak `imply` dependency on EXTCON, which causes issues when sii8620 is built as a builtin and EXTCON is built as a module. Th symptoms are 'undefined reference' errors caused by the symbols in EXTCON not being available to the sii8620 driver. Signed-off-by: Rober

Re: [PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Christian König
Am 06.04.21 um 11:08 schrieb Thomas Zimmermann: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change resolves several inconsistencies between regular mmap and prime-based mmap. The vm_ops field in vma is now set for

Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Jani Nikula
On Tue, 06 Apr 2021, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some rounding involved. > > pwm_get_state() traditionally returned the setting that was requested most > recently by the consumer (

[PATCH 5/8] drm/nouveau: Implement mmap as GEM object function

2021-04-06 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The GEM object function is provided by GEM TTM helpers. Nouveau's implementation of verify_access is unused and has been removed. Access permissions are validated by the DRM hel

[PATCH 8/8] drm/ttm: Remove ttm_bo_mmap() and friends

2021-04-06 Thread Thomas Zimmermann
The function ttm_bo_mmap is unused. Remove it and it's helpers; including the verify_access callback in struct ttm_device_funcs. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 53 - include/drm/ttm/ttm_bo_api.h| 13 include/drm

[PATCH 1/8] drm/ttm: Don't override vm_ops callbacks, if set

2021-04-06 Thread Thomas Zimmermann
Drivers may want to set their own callbacks for a VM area. Only set TTM's callbacks if the vm_ops field is clear. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drive

[PATCH 7/8] drm/vmwgfx: Inline vmw_verify_access()

2021-04-06 Thread Thomas Zimmermann
Vmwgfx is the only user of the TTM's verify_access callback. Inline the call and avoid the indirection through the function pointer. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c | 9 - drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c | 7 ++- 2 files chan

[PATCH 3/8] drm/amdgpu: Implement mmap as GEM object function

2021-04-06 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change resolves several inconsistencies between regular mmap and prime-based mmap. The vm_ops field in vma is now set for all mmap'ed areas. Previously it way only set for

[PATCH 6/8] drm/vmwgfx: Inline ttm_bo_mmap() into vmwgfx driver

2021-04-06 Thread Thomas Zimmermann
The vmwgfx driver is the only remaining user of ttm_bo_mmap(). Inline the code. The internal helper ttm_bo_vm_lookup() is now also part of vmwgfx as vmw_bo_vm_lookup(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c | 54 ++-- 1 file changed, 51

[PATCH 2/8] drm/amdgpu: Remove unused function amdgpu_bo_fbdev_mmap()

2021-04-06 Thread Thomas Zimmermann
Remove an unused function. Mapping the fbdev framebuffer is apparently not supported. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 19 --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.h | 2 -- 2 files changed, 21 deletions(-) diff --git a/drive

[PATCH 4/8] drm/radeon: Implement mmap as GEM object function

2021-04-06 Thread Thomas Zimmermann
Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. This change also allows to support prime-based mmap via DRM's helper drm_gem_prime_mmap(). Permission checks are implemented by drm_gem_mmap(), with an additional check for rad

[PATCH 0/8] drm: Clean up mmap for TTM-based GEM drivers

2021-04-06 Thread Thomas Zimmermann
Implement mmap via struct drm_gem_object_functions.mmap for amdgpu, radeon and nouveau. This allows for using common DRM helpers for the mmap-related callbacks in struct file_operations and struct drm_driver. The drivers have their own vm_ops, which are now set automatically by the DRM core functio

[PATCH v2 1/1] drm/nouveau/dmem: Remove duplicated header file inclusion

2021-04-06 Thread Zhen Lei
Delete one of the header files that are included twice, all included header files are then rearranged alphabetically. Signed-off-by: Zhen Lei --- drivers/gpu/drm/nouveau/nouveau_dmem.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/

[PATCH v2 0/1] drm/nouveau/dmem: Remove duplicated header file

2021-04-06 Thread Zhen Lei
v1 --> v2: Arrange all included header files in alphabetical order. Zhen Lei (1): drm/nouveau/dmem: Remove duplicated header file inclusion drivers/gpu/drm/nouveau/nouveau_dmem.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) -- 1.8.3 _

Re: [RESEND 00/25] Rid W=1 warnings from HID

2021-04-06 Thread Lee Jones
On Fri, 26 Mar 2021, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Lee Jones (25): > HID: intel-ish-hid: Remove unused variable 'err' > HID: ishtp-hid-client: Mov

Re: [PATCH -next] backlight: backlight: Use DEFINE_MUTEX() for mutex lock

2021-04-06 Thread Daniel Thompson
On Mon, Apr 05, 2021 at 06:14:40PM +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun This patch looks like a resend of this one (but with a diffe

[PATCH 3/4] drm/nouveau: Use drm_gem_ttm_dumb_map_offset()

2021-04-06 Thread Thomas Zimmermann
Nouveau now uses drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/nouveau/nouveau_display.c | 18 -- drivers/gpu/drm/nouveau/nouveau_display.h | 2 -- drivers/gpu/drm/nouveau/nouveau_drm.c | 3

[PATCH 4/4] drm/qxl: Use drm_gem_ttm_dumb_map_offset()

2021-04-06 Thread Thomas Zimmermann
Qxl now uses drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/qxl/qxl_drv.c| 3 ++- drivers/gpu/drm/qxl/qxl_drv.h| 3 --- drivers/gpu/drm/qxl/qxl_dumb.c | 17 - drivers/gpu/drm/qxl/qxl_i

[PATCH 0/4] drm: Generic dumb_map_offset for TTM-based drivers

2021-04-06 Thread Thomas Zimmermann
The implementation of drm_driver.dumb_map_offset is the same for several TTM-based drivers. Provide a common function in GEM-TTM helpers. Thomas Zimmermann (4): drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset drm/vram-helper: Use drm_gem_ttm_dumb_map_offset() drm

[PATCH 2/4] drm/vram-helper: Use drm_gem_ttm_dumb_map_offset()

2021-04-06 Thread Thomas Zimmermann
VRAM helpers now use drm_gem_ttm_dumb_map_offset() to implement struct drm_driver.dumb_map_offset. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 48 --- include/drm/drm_gem_vram_helper.h | 7 ++-- 2 files changed, 2 insertions(+), 53 de

[PATCH 1/4] drm/gem-ttm-helper: Provide helper for struct drm_driver.dumb_map_offset

2021-04-06 Thread Thomas Zimmermann
Provides an implementation of struct drm_driver.dumb_map_offset that can be used by TTM-based GEM drivers. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_ttm_helper.c | 33 include/drm/drm_gem_ttm_helper.h | 5 - 2 files changed, 37 insertions(

[Bug 200695] Blank screen on RX 580 with amdgpu.dc=1 enabled (no displays detected)

2021-04-06 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=200695 farshad (fars...@7d.nz) changed: What|Removed |Added CC||fars...@7d.nz --- Comment #49 f

[PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-06 Thread Uwe Kleine-König
Given that lowlevel drivers usually cannot implement exactly what a consumer requests with pwm_apply_state() there is some rounding involved. pwm_get_state() traditionally returned the setting that was requested most recently by the consumer (opposed to what was actually implemented in hardware in

Re: [PATCH] drm/panel: panel-dsi-cm: disable TE for now

2021-04-06 Thread Tony Lindgren
Hi, * Tomi Valkeinen [210316 14:12]: > Hi Sebastian, Sam, Thierry, > > On 27/02/2021 23:45, Sebastian Reichel wrote: > > From: Sebastian Reichel > > > > Disable TE for Droid 4 panel, since implementation is currently > > broken. Also disable it for N950 panel, which is untested. > > > > Repor